{"action":"opened","issue":{"url":"https://api.github.com/repos/NodeRedis/node_redis/issues/1106","repository_url":"https://api.github.com/repos/NodeRedis/node_redis","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/1106/labels{/name}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/1106/comments","events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/1106/events","html_url":"https://github.com/NodeRedis/node_redis/issues/1106","id":165649731,"number":1106,"title":"Domain handling regression since 2.5.3","user":{"login":"syrnick","id":263328,"avatar_url":"https://avatars.githubusercontent.com/u/263328?v=3","gravatar_id":"","url":"https://api.github.com/users/syrnick","html_url":"https://github.com/syrnick","followers_url":"https://api.github.com/users/syrnick/followers","following_url":"https://api.github.com/users/syrnick/following{/other_user}","gists_url":"https://api.github.com/users/syrnick/gists{/gist_id}","starred_url":"https://api.github.com/users/syrnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syrnick/subscriptions","organizations_url":"https://api.github.com/users/syrnick/orgs","repos_url":"https://api.github.com/users/syrnick/repos","events_url":"https://api.github.com/users/syrnick/events{/privacy}","received_events_url":"https://api.github.com/users/syrnick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-14T20:21:09Z","updated_at":"2016-07-14T20:21:09Z","closed_at":null,"body":"* **Version**: node_redis version 2.6.2, redis_version:2.8.19\r\n* **Platform**: OsX; Node 4.3.0\r\n* **Description**: The domain of the domain of the command callback does not match the domain when it the command was issued. That happens despite explicit domain binding in `internal_send_command` . This issue is NOT present in 2.5.3.\r\n\r\nTest case:\r\n```\r\nconst redis = require('redis');                                                                                                                                \r\nconst domain = require('domain');                                                                                                                              \r\nconst assert = require('assert');                                                                                                                              \r\n                                                                                                                                                               \r\nconst redisClient = redis.createClient();                                                                                                                      \r\n                                                                                                                                                               \r\nconst testDomain = domain.create();                                                                                                                            \r\ntestDomain.run(function() {                                                                                                                                    \r\n    redisClient.spop(`FOOBAR`, function() {                                                                                                                    \r\n        assert(process.domain === testDomain);                                                                                                                 \r\n        console.log('We are good');                                                                                                                            \r\n        process.exit(0);                                                                                                                                       \r\n    });                                                                                                                                                        \r\n}); \r\n```\r\n"}}
{"actor":{"display_login":"syrnick"}}