{"action":"created","issue":{"url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3715","repository_url":"https://api.github.com/repos/pyrocms/pyrocms","labels_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3715/labels{/name}","comments_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3715/comments","events_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3715/events","html_url":"https://github.com/pyrocms/pyrocms/issues/3715","id":156826624,"number":3715,"title":".env Configuration should restrict / play nice with settings / preferences.","user":{"login":"RyanThompson","id":1099967,"avatar_url":"https://avatars.githubusercontent.com/u/1099967?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanThompson","html_url":"https://github.com/RyanThompson","followers_url":"https://api.github.com/users/RyanThompson/followers","following_url":"https://api.github.com/users/RyanThompson/following{/other_user}","gists_url":"https://api.github.com/users/RyanThompson/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanThompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanThompson/subscriptions","organizations_url":"https://api.github.com/users/RyanThompson/orgs","repos_url":"https://api.github.com/users/RyanThompson/repos","events_url":"https://api.github.com/users/RyanThompson/events{/privacy}","received_events_url":"https://api.github.com/users/RyanThompson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pyrocms/pyrocms/milestones/18","html_url":"https://github.com/pyrocms/pyrocms/milestones/v3.0.0","labels_url":"https://api.github.com/repos/pyrocms/pyrocms/milestones/18/labels","id":334456,"number":18,"title":"v3.0.0","description":"","creator":{"login":"philsturgeon","id":67381,"avatar_url":"https://avatars.githubusercontent.com/u/67381?v=3","gravatar_id":"","url":"https://api.github.com/users/philsturgeon","html_url":"https://github.com/philsturgeon","followers_url":"https://api.github.com/users/philsturgeon/followers","following_url":"https://api.github.com/users/philsturgeon/following{/other_user}","gists_url":"https://api.github.com/users/philsturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/philsturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsturgeon/subscriptions","organizations_url":"https://api.github.com/users/philsturgeon/orgs","repos_url":"https://api.github.com/users/philsturgeon/repos","events_url":"https://api.github.com/users/philsturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/philsturgeon/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":34,"state":"open","created_at":"2013-05-15T14:35:42Z","updated_at":"2016-05-25T19:06:53Z","due_on":"2016-03-08T06:00:00Z","closed_at":null},"comments":1,"created_at":"2016-05-25T19:06:46Z","updated_at":"2016-05-25T19:11:40Z","closed_at":null,"body":"Here's my thought:\r\n\r\n1.) Setting definitions can have an `env = > THE_ENV_KEY` in the definition. \r\n2.) If the env key is there - when pulling (config is used there to determine mutation of value) use env value as defined in the key instead of the setting value.\r\n3.) In the GUI - add a warning saying it's override by environmental file.\r\n4.) In the GUI - disable the field as well."},"comment":{"url":"https://api.github.com/repos/pyrocms/pyrocms/issues/comments/221676612","html_url":"https://github.com/pyrocms/pyrocms/issues/3715#issuecomment-221676612","issue_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3715","id":221676612,"user":{"login":"edster","id":656313,"avatar_url":"https://avatars.githubusercontent.com/u/656313?v=3","gravatar_id":"","url":"https://api.github.com/users/edster","html_url":"https://github.com/edster","followers_url":"https://api.github.com/users/edster/followers","following_url":"https://api.github.com/users/edster/following{/other_user}","gists_url":"https://api.github.com/users/edster/gists{/gist_id}","starred_url":"https://api.github.com/users/edster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edster/subscriptions","organizations_url":"https://api.github.com/users/edster/orgs","repos_url":"https://api.github.com/users/edster/repos","events_url":"https://api.github.com/users/edster/events{/privacy}","received_events_url":"https://api.github.com/users/edster/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T19:11:40Z","updated_at":"2016-05-25T19:11:40Z","body":"I think this should be done the other way,\r\n\r\n1.) Setting definitions can have an env = > THE_ENV_KEY in the definition. \r\n2.) Use the env key, have the value in setting module set as \"Default\" (Default will be the value in .env.) 3.) The setting then overrides the .env if changed from default.\r\n4.) Have a setting in .env that can block access to the settings, this will disable the fields."}}
{"actor":{"display_login":"edster"}}