{"action":"created","comment":{"url":"https://api.github.com/repos/itkpi/events-parser/pulls/comments/93951707","pull_request_review_id":14482651,"id":93951707,"diff_hunk":"@@ -117,20 +117,19 @@ function RIS (cmd, args) {\n   )\n }\n \n-const describe = RIS('git', ['describe'])\n-const branch = RIS('git', ['rev-parse', '--abbrev-ref', 'HEAD'])\n-\n /**\n  * Getting build version based on 'git tags' and curent branch.\n  * Patern: vMAJOR.MINOR.PATH-%branch name%-%number of commits from last tag%-%commit hash%.\n  * Example: v0.5.0-vesioning-8-g65cc3b3.\n  * @returns {string} version - curent build version.\n  */\n utils.getVersion = () => {\n-  const ds = describe.stdout.split('-')\n-  const version = ds.length === 1\n-    ? `${ds[0]}-${branch.stdout}`\n-    : `${ds[0]}-${branch.stdout}-${ds[1]}-${ds[2]}`\n+  let app_version = process.env.APP_VERSION","path":"utils.js","position":18,"original_position":18,"commit_id":"2519b830022db490cc0d09487f6e1884f6c5727a","original_commit_id":"2519b830022db490cc0d09487f6e1884f6c5727a","user":{"login":"MaxymVlasov","id":11096782,"avatar_url":"https://avatars.githubusercontent.com/u/11096782?v=3","gravatar_id":"","url":"https://api.github.com/users/MaxymVlasov","html_url":"https://github.com/MaxymVlasov","followers_url":"https://api.github.com/users/MaxymVlasov/followers","following_url":"https://api.github.com/users/MaxymVlasov/following{/other_user}","gists_url":"https://api.github.com/users/MaxymVlasov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxymVlasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxymVlasov/subscriptions","organizations_url":"https://api.github.com/users/MaxymVlasov/orgs","repos_url":"https://api.github.com/users/MaxymVlasov/repos","events_url":"https://api.github.com/users/MaxymVlasov/events{/privacy}","received_events_url":"https://api.github.com/users/MaxymVlasov/received_events","type":"User","site_admin":false},"body":"В плані не константа?\r\nЗмінні середовища ж підкидуються до запуску програми і під час її роботи не мають змінюватись","created_at":"2016-12-27T17:13:44Z","updated_at":"2016-12-27T17:13:45Z","html_url":"https://github.com/itkpi/events-parser/pull/52#discussion_r93951707","pull_request_url":"https://api.github.com/repos/itkpi/events-parser/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/comments/93951707"},"html":{"href":"https://github.com/itkpi/events-parser/pull/52#discussion_r93951707"},"pull_request":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/itkpi/events-parser/pulls/52","id":99455001,"html_url":"https://github.com/itkpi/events-parser/pull/52","diff_url":"https://github.com/itkpi/events-parser/pull/52.diff","patch_url":"https://github.com/itkpi/events-parser/pull/52.patch","issue_url":"https://api.github.com/repos/itkpi/events-parser/issues/52","number":52,"state":"open","locked":false,"title":"Generate app version at build time","user":{"login":"webknjaz","id":578543,"avatar_url":"https://avatars.githubusercontent.com/u/578543?v=3","gravatar_id":"","url":"https://api.github.com/users/webknjaz","html_url":"https://github.com/webknjaz","followers_url":"https://api.github.com/users/webknjaz/followers","following_url":"https://api.github.com/users/webknjaz/following{/other_user}","gists_url":"https://api.github.com/users/webknjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/webknjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webknjaz/subscriptions","organizations_url":"https://api.github.com/users/webknjaz/orgs","repos_url":"https://api.github.com/users/webknjaz/repos","events_url":"https://api.github.com/users/webknjaz/events{/privacy}","received_events_url":"https://api.github.com/users/webknjaz/received_events","type":"User","site_admin":false},"body":"* Wiped out statsd garbage\r\n* Removed runtime git dependency by generating the version during build\r\n* Made app retrieve the version either via env var or via reading it from the build-specific file","created_at":"2016-12-27T15:22:24Z","updated_at":"2016-12-27T17:13:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b39fba774b62e8ab156c07e44ae4405da55ed162","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/itkpi/events-parser/pulls/52/commits","review_comments_url":"https://api.github.com/repos/itkpi/events-parser/pulls/52/comments","review_comment_url":"https://api.github.com/repos/itkpi/events-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/itkpi/events-parser/issues/52/comments","statuses_url":"https://api.github.com/repos/itkpi/events-parser/statuses/2519b830022db490cc0d09487f6e1884f6c5727a","head":{"label":"itkpi:feature/buildtime-version-generation","ref":"feature/buildtime-version-generation","sha":"2519b830022db490cc0d09487f6e1884f6c5727a","user":{"login":"itkpi","id":12073380,"avatar_url":"https://avatars.githubusercontent.com/u/12073380?v=3","gravatar_id":"","url":"https://api.github.com/users/itkpi","html_url":"https://github.com/itkpi","followers_url":"https://api.github.com/users/itkpi/followers","following_url":"https://api.github.com/users/itkpi/following{/other_user}","gists_url":"https://api.github.com/users/itkpi/gists{/gist_id}","starred_url":"https://api.github.com/users/itkpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkpi/subscriptions","organizations_url":"https://api.github.com/users/itkpi/orgs","repos_url":"https://api.github.com/users/itkpi/repos","events_url":"https://api.github.com/users/itkpi/events{/privacy}","received_events_url":"https://api.github.com/users/itkpi/received_events","type":"Organization","site_admin":false},"repo":{"id":51226809,"name":"events-parser","full_name":"itkpi/events-parser","owner":{"login":"itkpi","id":12073380,"avatar_url":"https://avatars.githubusercontent.com/u/12073380?v=3","gravatar_id":"","url":"https://api.github.com/users/itkpi","html_url":"https://github.com/itkpi","followers_url":"https://api.github.com/users/itkpi/followers","following_url":"https://api.github.com/users/itkpi/following{/other_user}","gists_url":"https://api.github.com/users/itkpi/gists{/gist_id}","starred_url":"https://api.github.com/users/itkpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkpi/subscriptions","organizations_url":"https://api.github.com/users/itkpi/orgs","repos_url":"https://api.github.com/users/itkpi/repos","events_url":"https://api.github.com/users/itkpi/events{/privacy}","received_events_url":"https://api.github.com/users/itkpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/itkpi/events-parser","description":null,"fork":false,"url":"https://api.github.com/repos/itkpi/events-parser","forks_url":"https://api.github.com/repos/itkpi/events-parser/forks","keys_url":"https://api.github.com/repos/itkpi/events-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itkpi/events-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itkpi/events-parser/teams","hooks_url":"https://api.github.com/repos/itkpi/events-parser/hooks","issue_events_url":"https://api.github.com/repos/itkpi/events-parser/issues/events{/number}","events_url":"https://api.github.com/repos/itkpi/events-parser/events","assignees_url":"https://api.github.com/repos/itkpi/events-parser/assignees{/user}","branches_url":"https://api.github.com/repos/itkpi/events-parser/branches{/branch}","tags_url":"https://api.github.com/repos/itkpi/events-parser/tags","blobs_url":"https://api.github.com/repos/itkpi/events-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itkpi/events-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itkpi/events-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/itkpi/events-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itkpi/events-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/itkpi/events-parser/languages","stargazers_url":"https://api.github.com/repos/itkpi/events-parser/stargazers","contributors_url":"https://api.github.com/repos/itkpi/events-parser/contributors","subscribers_url":"https://api.github.com/repos/itkpi/events-parser/subscribers","subscription_url":"https://api.github.com/repos/itkpi/events-parser/subscription","commits_url":"https://api.github.com/repos/itkpi/events-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/itkpi/events-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/itkpi/events-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/itkpi/events-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/itkpi/events-parser/contents/{+path}","compare_url":"https://api.github.com/repos/itkpi/events-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itkpi/events-parser/merges","archive_url":"https://api.github.com/repos/itkpi/events-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itkpi/events-parser/downloads","issues_url":"https://api.github.com/repos/itkpi/events-parser/issues{/number}","pulls_url":"https://api.github.com/repos/itkpi/events-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/itkpi/events-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/itkpi/events-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itkpi/events-parser/labels{/name}","releases_url":"https://api.github.com/repos/itkpi/events-parser/releases{/id}","deployments_url":"https://api.github.com/repos/itkpi/events-parser/deployments","created_at":"2016-02-06T23:15:43Z","updated_at":"2016-11-07T20:20:02Z","pushed_at":"2016-12-27T17:06:21Z","git_url":"git://github.com/itkpi/events-parser.git","ssh_url":"git@github.com:itkpi/events-parser.git","clone_url":"https://github.com/itkpi/events-parser.git","svn_url":"https://github.com/itkpi/events-parser","homepage":"http://itkpi.pp.ua/events/","size":129,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":0,"default_branch":"master"}},"base":{"label":"itkpi:master","ref":"master","sha":"2f0e7cf9f8445daf830c9eb94514c65ae3da4b16","user":{"login":"itkpi","id":12073380,"avatar_url":"https://avatars.githubusercontent.com/u/12073380?v=3","gravatar_id":"","url":"https://api.github.com/users/itkpi","html_url":"https://github.com/itkpi","followers_url":"https://api.github.com/users/itkpi/followers","following_url":"https://api.github.com/users/itkpi/following{/other_user}","gists_url":"https://api.github.com/users/itkpi/gists{/gist_id}","starred_url":"https://api.github.com/users/itkpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkpi/subscriptions","organizations_url":"https://api.github.com/users/itkpi/orgs","repos_url":"https://api.github.com/users/itkpi/repos","events_url":"https://api.github.com/users/itkpi/events{/privacy}","received_events_url":"https://api.github.com/users/itkpi/received_events","type":"Organization","site_admin":false},"repo":{"id":51226809,"name":"events-parser","full_name":"itkpi/events-parser","owner":{"login":"itkpi","id":12073380,"avatar_url":"https://avatars.githubusercontent.com/u/12073380?v=3","gravatar_id":"","url":"https://api.github.com/users/itkpi","html_url":"https://github.com/itkpi","followers_url":"https://api.github.com/users/itkpi/followers","following_url":"https://api.github.com/users/itkpi/following{/other_user}","gists_url":"https://api.github.com/users/itkpi/gists{/gist_id}","starred_url":"https://api.github.com/users/itkpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkpi/subscriptions","organizations_url":"https://api.github.com/users/itkpi/orgs","repos_url":"https://api.github.com/users/itkpi/repos","events_url":"https://api.github.com/users/itkpi/events{/privacy}","received_events_url":"https://api.github.com/users/itkpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/itkpi/events-parser","description":null,"fork":false,"url":"https://api.github.com/repos/itkpi/events-parser","forks_url":"https://api.github.com/repos/itkpi/events-parser/forks","keys_url":"https://api.github.com/repos/itkpi/events-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itkpi/events-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itkpi/events-parser/teams","hooks_url":"https://api.github.com/repos/itkpi/events-parser/hooks","issue_events_url":"https://api.github.com/repos/itkpi/events-parser/issues/events{/number}","events_url":"https://api.github.com/repos/itkpi/events-parser/events","assignees_url":"https://api.github.com/repos/itkpi/events-parser/assignees{/user}","branches_url":"https://api.github.com/repos/itkpi/events-parser/branches{/branch}","tags_url":"https://api.github.com/repos/itkpi/events-parser/tags","blobs_url":"https://api.github.com/repos/itkpi/events-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itkpi/events-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itkpi/events-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/itkpi/events-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itkpi/events-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/itkpi/events-parser/languages","stargazers_url":"https://api.github.com/repos/itkpi/events-parser/stargazers","contributors_url":"https://api.github.com/repos/itkpi/events-parser/contributors","subscribers_url":"https://api.github.com/repos/itkpi/events-parser/subscribers","subscription_url":"https://api.github.com/repos/itkpi/events-parser/subscription","commits_url":"https://api.github.com/repos/itkpi/events-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/itkpi/events-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/itkpi/events-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/itkpi/events-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/itkpi/events-parser/contents/{+path}","compare_url":"https://api.github.com/repos/itkpi/events-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itkpi/events-parser/merges","archive_url":"https://api.github.com/repos/itkpi/events-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itkpi/events-parser/downloads","issues_url":"https://api.github.com/repos/itkpi/events-parser/issues{/number}","pulls_url":"https://api.github.com/repos/itkpi/events-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/itkpi/events-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/itkpi/events-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itkpi/events-parser/labels{/name}","releases_url":"https://api.github.com/repos/itkpi/events-parser/releases{/id}","deployments_url":"https://api.github.com/repos/itkpi/events-parser/deployments","created_at":"2016-02-06T23:15:43Z","updated_at":"2016-11-07T20:20:02Z","pushed_at":"2016-12-27T17:06:21Z","git_url":"git://github.com/itkpi/events-parser.git","ssh_url":"git@github.com:itkpi/events-parser.git","clone_url":"https://github.com/itkpi/events-parser.git","svn_url":"https://github.com/itkpi/events-parser","homepage":"http://itkpi.pp.ua/events/","size":129,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":20,"forks":1,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/52"},"html":{"href":"https://github.com/itkpi/events-parser/pull/52"},"issue":{"href":"https://api.github.com/repos/itkpi/events-parser/issues/52"},"comments":{"href":"https://api.github.com/repos/itkpi/events-parser/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/itkpi/events-parser/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/itkpi/events-parser/statuses/2519b830022db490cc0d09487f6e1884f6c5727a"}}}}
{"actor":{"display_login":"MaxymVlasov"}}