{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/1044","repository_url":"https://api.github.com/repos/OpenMW/openmw","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/1044/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1044/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/1044/events","html_url":"https://github.com/OpenMW/openmw/pull/1044","id":174777449,"number":1044,"title":"Changes to multi-effect spells","user":{"login":"Allofich","id":19624336,"avatar_url":"https://avatars.githubusercontent.com/u/19624336?v=3","gravatar_id":"","url":"https://api.github.com/users/Allofich","html_url":"https://github.com/Allofich","followers_url":"https://api.github.com/users/Allofich/followers","following_url":"https://api.github.com/users/Allofich/following{/other_user}","gists_url":"https://api.github.com/users/Allofich/gists{/gist_id}","starred_url":"https://api.github.com/users/Allofich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Allofich/subscriptions","organizations_url":"https://api.github.com/users/Allofich/orgs","repos_url":"https://api.github.com/users/Allofich/repos","events_url":"https://api.github.com/users/Allofich/events{/privacy}","received_events_url":"https://api.github.com/users/Allofich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-02T14:48:17Z","updated_at":"2016-09-04T18:59:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1044","html_url":"https://github.com/OpenMW/openmw/pull/1044","diff_url":"https://github.com/OpenMW/openmw/pull/1044.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1044.patch"},"body":"For https://bugs.openmw.org/issues/3519.\r\n\r\nThis includes the following changes. All are to recreate behavior from the original engine.\r\n\r\n1. Allow all the magic effect hit sounds of a spell to play when the spell hits a target.\r\n2. Play all visual and sound effects when casting a spell with multiple magic effects.\r\n3. Shoot all projectiles of spells with multiple magic effects.\r\n4. Make the shot projectiles all have the same speed, which is the average of all the magic effects in the spell, including ones without their own projectiles (self-cast effects, etc.).\r\n5. Use the last magic effect of a spell to determine the color of the magic effect on the hands when casting. The first magic effect, however, is used to determine what animation is played (on Self, on Touch or on Target). The hand effect is played for each magic effect, so the more magic effects, the thicker the hand effect looks.\r\n6. Since I made all the projectiles shoot, I put all of the magic effects into the first projectile only, as otherwise the sounds of all of the magic effects would play for each projectile when they struck a target.\r\n7. Fixed a bug with the spell explosions where a ranged effect could be exploded like a touched spell due to a missing check.\r\n\r\nI had no problems with shooting different effects as different projectiles. They seem to all have the same collision and all disappear together when they strike something. In the original engine there is a swirling effect when there are multiple effects in a projectile spell, but I couldn't tell from testing whether that swirling effect has any effect on collision. I have not implemented this swirling effect.\r\n"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/244622248","html_url":"https://github.com/OpenMW/openmw/pull/1044#issuecomment-244622248","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1044","id":244622248,"user":{"login":"Allofich","id":19624336,"avatar_url":"https://avatars.githubusercontent.com/u/19624336?v=3","gravatar_id":"","url":"https://api.github.com/users/Allofich","html_url":"https://github.com/Allofich","followers_url":"https://api.github.com/users/Allofich/followers","following_url":"https://api.github.com/users/Allofich/following{/other_user}","gists_url":"https://api.github.com/users/Allofich/gists{/gist_id}","starred_url":"https://api.github.com/users/Allofich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Allofich/subscriptions","organizations_url":"https://api.github.com/users/Allofich/orgs","repos_url":"https://api.github.com/users/Allofich/repos","events_url":"https://api.github.com/users/Allofich/events{/privacy}","received_events_url":"https://api.github.com/users/Allofich/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T18:59:58Z","updated_at":"2016-09-04T18:59:58Z","body":"I think so. I'll have a look."}}
{"actor":{"display_login":"Allofich"}}