{"push_id":1216350906,"size":73,"distinct_size":73,"ref":"refs/heads/private-and-fileprivate","head":"aee6454e567296dcf3218ff26c38216e30b84766","before":"e9713d6af9af7328294a981996a5af28032800dc","commits":[{"sha":"9a4caf6c4b955957978f1aa5132f3b96798d5c41","author":{"name":"Alexander Lash","email":"beb7c69cc1f517ff48e50c58279d4267cb23dd68@google.com"},"message":"[core] hasPrefix/hasSuffix consider the empty string a prefix/suffix of all strings.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/9a4caf6c4b955957978f1aa5132f3b96798d5c41"},{"sha":"6d9515daeb002d3e1526352782242430a4afa464","author":{"name":"Tony Parker","email":"6b0dca4dd0bff0c6c240bd20c2686320b4dd67d4@apple.com"},"message":"<rdar://problem/27425997> NSCoder encodeInt:forKey cannot be overridden in Swift, throws runtime exception","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/6d9515daeb002d3e1526352782242430a4afa464"},{"sha":"2cd5426a2eb15ce6d29c34bc6c87e22f1db01be2","author":{"name":"Kevin Perry","email":"66fbb09a3c75390a7351a6c5c7c5def083f9f936@apple.com"},"message":"Use alternate implementation of Data.write() on macOS and iOS versions where the provided implementation would crash\n\nrdar://26278731","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/2cd5426a2eb15ce6d29c34bc6c87e22f1db01be2"},{"sha":"0bf7c005b32658ec3713f4502a345b1f9e88b616","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[SE-0091 Follow-up] Move global operators for non-generic concrete types into the type.\n\nIn various cases where we had global operators for non-generic\nconcrete types (such as String + String), move those operators into\nthe type. This should not affect the sources, but makes the exposition\nof the library cleaner.\n\nPlus, it's a good test for the compiler, which uncovered a few issues\nwhere the compiler was coupled with the library.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/0bf7c005b32658ec3713f4502a345b1f9e88b616"},{"sha":"42a3e36c150a899232a53442cefa9e56780fd1ca","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[SE-0091 Follow-up] Move !, &&, and || onto an extension of Bool.\n\nThe diagnostics changes make the compiler more robust in its diagnosis\nof uses of operators defined in types.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/42a3e36c150a899232a53442cefa9e56780fd1ca"},{"sha":"778e76e1583adf1b71c0b9ae44a359043746c50b","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[SE-0091 Follow-up] Move more operators into types, now for generic operators.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/778e76e1583adf1b71c0b9ae44a359043746c50b"},{"sha":"c56f96d237426824dca794eae87d4028947f636a","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[Type checker] Synthesize member operator '==' for Equatable enums.\n\nRather than synthesizing a global operator '==' for Equatable enums,\nsynthesize a member operator, which is more idiomatic and much\ncleaner.\n\nTo make sure that these synthesized operators can actually be found,\nstart considering operator requirements in protocols\nmore generally in the type checker, so that, e.g., \"myEnum == myEnum\"\nwill type-check against Equatable.== and, on successful type-check,\nwill call the (newly-synthesized) witness for '=='. This both makes it\neasier to make sure we find the operators in, e.g., complex multi-file\nand lazy-type checking scenarios, and is a step toward the\ntype-checking improvements described in SE-0091.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/c56f96d237426824dca794eae87d4028947f636a"},{"sha":"1dcfd337e56441c32e33e65b8401377940379dbe","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[Cleanup] Eliminate the notion of derived global declarations for DeclContexts.\n\nThese were only used for synthesized global operators, which have now\nbeen eliminated.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/1dcfd337e56441c32e33e65b8401377940379dbe"},{"sha":"211c58015878614f4cdebfd859fc3d1ba54f2fbd","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[Cleanup] Eliminate DerivedFileUnit.\n\nThe only client of DerivedFileUnit was synthesized global '=='\noperators for Equatable conformances, which has since been removed.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/211c58015878614f4cdebfd859fc3d1ba54f2fbd"},{"sha":"b2618e65c819fe34e4be9f1475f31e10e20777ec","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"[Type checker] Eliminate the hacks used to find synthesized global '=='.\n\nNone of this is needed no that the synthesized '==' functions are\nmembers of types, found via protocol conformance.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/b2618e65c819fe34e4be9f1475f31e10e20777ec"},{"sha":"2aad72d31e07358a1f6db33a35a8e044e98f49ba","author":{"name":"Ben Langmuir","email":"24208d537a689fccffa1f56cc0529d81ef0b3926@apple.com"},"message":"Speculative fix for code-completion nullptr dereference\n\nI haven't managed to find a test case, but we see crash reports about\nthis call. It may be that the correct fix is for some other part of the\ncompiler not to produce a null protocol self, but it's harmless for the\nASTPrinter to dodge a null pointer here.\n\nrdar://problem/27053440","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/2aad72d31e07358a1f6db33a35a8e044e98f49ba"},{"sha":"df344a8fb78d050f7d918f0ba0a710c230954e10","author":{"name":"Michael Gottesman","email":"4db64bf1b10b871c56257ec0356c24737011518b@apple.com"},"message":"[cmake] Rename SwiftInstallComponents.cmake => SwiftComponents.cmake. NFC\n\nIn the next little bit I am going to be creating a more complex components\nsystem. In order to help with this, I am renaming SwiftInstallComponents =>\nSwiftComponents.cmake to reflect the broader purpose.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/df344a8fb78d050f7d918f0ba0a710c230954e10"},{"sha":"d417b48c77e4dc59636b9dc21fe7e24c390cdb93","author":{"name":"Michael Gottesman","email":"4db64bf1b10b871c56257ec0356c24737011518b@apple.com"},"message":"[cmake] Move SwiftBuildType.cmake into SwiftUtils.cmake. NFC.\n\nThe contents of that .cmake file are cmake utility functions. Move them into\nSwiftUtils.cmake, a file that contains cmake utility functions. This is just a\nquick cleanup.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/d417b48c77e4dc59636b9dc21fe7e24c390cdb93"},{"sha":"9e71cf3c5ad182632e7eb800b4f578b12929950c","author":{"name":"John McCall","email":"c8773ae2de18f76a4f98bb913a3256b77114c46c@apple.com"},"message":"Build element-conversion expressions even when they're\nobviously trivial.\n\nMaking an extra AST node is a pretty trivial cost if it gets\nus simpler invariants.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/9e71cf3c5ad182632e7eb800b4f578b12929950c"},{"sha":"1d8d049a9d2527bcce3dd13c2de1d53d58fb4922","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"[SourceKit] Add test case for crash triggered in swift::ValueDecl::getEffectiveAccess() const\n\nStack trace:\n\n```\nfound code completion token A at offset 139\nswift-ide-test: /path/to/swift/include/swift/AST/Decl.h:2176: swift::Accessibility swift::ValueDecl::getFormalAccess() const: Assertion `hasAccessibility() && \"accessibility not computed yet\"' failed.\n8  swift-ide-test  0x0000000000c1bbae swift::ValueDecl::getEffectiveAccess() const + 606\n9  swift-ide-test  0x0000000000c2953d swift::DeclContext::getResilienceExpansion() const + 125\n10 swift-ide-test  0x0000000000c1b1b2 swift::ValueDecl::getAccessSemanticsFromContext(swift::DeclContext const*) const + 18\n11 swift-ide-test  0x00000000009bcd2d swift::TypeChecker::buildRefExpr(llvm::ArrayRef<swift::ValueDecl*>, swift::DeclContext*, swift::DeclNameLoc, bool, bool) + 125\n12 swift-ide-test  0x000000000096e2bd swift::TypeChecker::resolveDeclRefExpr(swift::UnresolvedDeclRefExpr*, swift::DeclContext*) + 3437\n14 swift-ide-test  0x0000000000bbadfb swift::Expr::walk(swift::ASTWalker&) + 27\n15 swift-ide-test  0x000000000096ed30 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) + 224\n16 swift-ide-test  0x0000000000975b62 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 610\n19 swift-ide-test  0x00000000009efbca swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) + 346\n20 swift-ide-test  0x00000000009efa2e swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) + 46\n21 swift-ide-test  0x00000000009ad5ff swift::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) + 655\n25 swift-ide-test  0x0000000000bbb244 swift::Decl::walk(swift::ASTWalker&) + 20\n26 swift-ide-test  0x0000000000c53dbe swift::SourceFile::walk(swift::ASTWalker&) + 174\n27 swift-ide-test  0x0000000000c52eff swift::ModuleDecl::walk(swift::ASTWalker&) + 79\n28 swift-ide-test  0x0000000000c298eb swift::DeclContext::walkContext(swift::ASTWalker&) + 187\n29 swift-ide-test  0x00000000008eed68 swift::performDelayedParsing(swift::DeclContext*, swift::PersistentParserState&, swift::CodeCompletionCallbacksFactory*) + 136\n30 swift-ide-test  0x00000000007a71ed swift::CompilerInstance::performSema() + 3597\n31 swift-ide-test  0x000000000074a351 main + 34593\nStack dump:\n0.\tProgram arguments: swift-ide-test -code-completion -code-completion-token=A -source-filename=<INPUT-FILE>\n1.\tWhile walking into decl 'init' at <INPUT-FILE>:3:1\n2.\tWhile type-checking expression at [<INPUT-FILE>:3:12 - line:3:12] RangeText=\"a\"\n```","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/1d8d049a9d2527bcce3dd13c2de1d53d58fb4922"},{"sha":"2de82e5b8f676e6a1e41e6ad90385559cf73c54c","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"[swiftc (72 vs. 5110)] Add crasher in swift::PrintOptions::setArchetypeAndDynamicSelfTransform(...)\n\nAdd test case for crash triggered in `swift::PrintOptions::setArchetypeAndDynamicSelfTransform(...)`.\n\nCurrent number of unresolved compiler crashers: 72 (5110 resolved)\n\nAssertion failure in [`lib/AST/ASTPrinter.cpp (line 68)`](https://github.com/apple/swift/blob/master/lib/AST/ASTPrinter.cpp#L68):\n\n```\nAssertion `ParamDecls.size() == Args.size()' failed.\n\nWhen executing: std::unique_ptr<llvm::DenseMap<StringRef, Type> > swift::collectNameTypeMap(swift::Type)\n```\n\nAssertion context:\n\n```\n    if (!D || !D->getGenericParams())\n      continue;\n    SmallVector<Type, 3> Scrach;\n    auto Args = BaseTy->getAllGenericArgs(Scrach);\n    const auto ParamDecls = D->getGenericParams()->getParams();\n    assert(ParamDecls.size() == Args.size());\n\n    // Map type parameter names with their instantiating arguments.\n    for (unsigned I = 0, N = ParamDecls.size(); I < N; I++) {\n      (*IdMap)[ParamDecls[I]->getName().str()] = Args[I];\n    }\n```\nStack trace:\n\n```\nswift: /path/to/swift/lib/AST/ASTPrinter.cpp:68: std::unique_ptr<llvm::DenseMap<StringRef, Type> > swift::collectNameTypeMap(swift::Type): Assertion `ParamDecls.size() == Args.size()' failed.\n9  swift           0x000000000104b5d2 swift::PrintOptions::setArchetypeAndDynamicSelfTransform(swift::Type, swift::DeclContext*) + 130\n13 swift           0x0000000000f11a57 swift::TypeChecker::checkConformance(swift::NormalProtocolConformance*) + 2423\n14 swift           0x0000000000f11ec7 swift::TypeChecker::checkConformancesInContext(swift::DeclContext*, swift::IterableDeclContext*) + 471\n19 swift           0x0000000000ec9ab6 swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 150\n22 swift           0x0000000000f32a64 swift::TypeChecker::typeCheckClosureBody(swift::ClosureExpr*) + 244\n23 swift           0x0000000000f5e7ac swift::constraints::ConstraintSystem::applySolution(swift::constraints::Solution&, swift::Expr*, swift::Type, bool, bool, bool) + 876\n24 swift           0x0000000000eb7b41 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*) + 769\n26 swift           0x0000000000f32ba6 swift::TypeChecker::typeCheckTopLevelCodeDecl(swift::TopLevelCodeDecl*) + 134\n27 swift           0x0000000000eec48d swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int) + 1133\n28 swift           0x0000000000c73849 swift::CompilerInstance::performSema() + 3289\n30 swift           0x00000000007d95c7 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2887\n31 swift           0x00000000007a55c8 main + 2872\nStack dump:\n0.\tProgram arguments: /path/to/swift/bin/swift -frontend -c -primary-file validation-test/compiler_crashers/28372-swift-printoptions-setarchetypeanddynamicselftransform.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -module-name main -o /tmp/28372-swift-printoptions-setarchetypeanddynamicselftransform-7809a8.o\n1.\tWhile type-checking expression at [validation-test/compiler_crashers/28372-swift-printoptions-setarchetypeanddynamicselftransform.swift:10:1 - line:12:11] RangeText=\"{protocol a{\n2.\tWhile type-checking 'a' at validation-test/compiler_crashers/28372-swift-printoptions-setarchetypeanddynamicselftransform.swift:10:2\n<unknown>:0: error: unable to execute command: Aborted\n<unknown>:0: error: compile command failed due to signal (use -v to see invocation)\n```","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/2de82e5b8f676e6a1e41e6ad90385559cf73c54c"},{"sha":"1142318eafafcaeefe6499ae04a52cb4bb25fa11","author":{"name":"swift-ci","email":"ba4463bdeeb747bfa14a6c06d0b8d74a99982bde@users.noreply.github.com"},"message":"Merge pull request #3663 from parkera/nscoder_encodeint","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/1142318eafafcaeefe6499ae04a52cb4bb25fa11"},{"sha":"9758bf17788dedc227b2d089787a1a9a4919000f","author":{"name":"swift-ci","email":"ba4463bdeeb747bfa14a6c06d0b8d74a99982bde@users.noreply.github.com"},"message":"Merge pull request #3664 from kperryua/bridged-data-crash","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/9758bf17788dedc227b2d089787a1a9a4919000f"},{"sha":"3d20fba7a728408454b0bb9a19fec8000ec99b60","author":{"name":"Doug Gregor","email":"251fda27d0a603ec7038aeb3aa510e8fbf5b9bc1@apple.com"},"message":"Merge pull request #3650 from DougGregor/se-0091-operators-in-types\n\nEmbrace operators in types more thoroughly","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/3d20fba7a728408454b0bb9a19fec8000ec99b60"},{"sha":"3f9b6aef011a06d69d603ffc7e1c7f93c5fa2edf","author":{"name":"Dave Abrahams","email":"661d28bf970edb26586d1fb79ff733f814317a59@apple.com"},"message":"utils/line-directive: cover type checker errors\n\nThis causes errors to be reported in the source file for things\ngenerated by gyb.","distinct":true,"url":"https://api.github.com/repos/jrose-apple/swift/commits/3f9b6aef011a06d69d603ffc7e1c7f93c5fa2edf"}]}
{"actor":{"display_login":"jrose-apple"}}