{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/48951393","id":48951393,"diff_hunk":"@@ -2182,6 +2183,10 @@ FunctionCallNonKeyword:\n \t{\n \t\t$$ =  &ast.FuncCallExpr{FnName: model.NewCIStr($1.(string)), Args: []ast.ExprNode{$3.(ast.ExprNode)}}\n \t}\n+|\t\"DAYNAME\" '(' Expression ')'\n+\t{\n+\t\t$$ = &ast.FuncCallExpr{FnName: model.NewCIStr($1.(string)), Args: []ast.ExprNode{$3.(ast.ExprNode)}}\n+\t}","path":"parser/parser.y","position":24,"original_position":24,"commit_id":"b607c8504b7a615b193e6ef3d27a9384097abfef","original_commit_id":"6a1a5ef7651e25c9637985541e94f5e6dae3ea9c","user":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"body":"@zimulala @shenli \r\nSome simple test cases are added.","created_at":"2016-01-06T12:14:17Z","updated_at":"2016-01-06T12:14:17Z","html_url":"https://github.com/pingcap/tidb/pull/830#discussion_r48951393","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/830","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/48951393"},"html":{"href":"https://github.com/pingcap/tidb/pull/830#discussion_r48951393"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/830"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/830","id":55170826,"html_url":"https://github.com/pingcap/tidb/pull/830","diff_url":"https://github.com/pingcap/tidb/pull/830.diff","patch_url":"https://github.com/pingcap/tidb/pull/830.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/830","number":830,"state":"open","locked":false,"title":"builtin: add time function dayname()","user":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"body":"Hi there,\r\n\r\nThis PR adds builtin time function dayname(). Please note that the system variable ` lc_time_names` which controls the locales of output names is not supported.\r\n","created_at":"2016-01-06T02:39:00Z","updated_at":"2016-01-06T12:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f357df8f0e28a8fb468b341f1273a41f82326d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/830/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/830/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/830/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/b607c8504b7a615b193e6ef3d27a9384097abfef","head":{"label":"hhkbp2:add-time-function-dayname","ref":"add-time-function-dayname","sha":"b607c8504b7a615b193e6ef3d27a9384097abfef","user":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"repo":{"id":46538684,"name":"tidb","full_name":"hhkbp2/tidb","owner":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhkbp2/tidb","description":"TiDB is a distributed SQL database compatible with MySQL protocol.","fork":true,"url":"https://api.github.com/repos/hhkbp2/tidb","forks_url":"https://api.github.com/repos/hhkbp2/tidb/forks","keys_url":"https://api.github.com/repos/hhkbp2/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhkbp2/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhkbp2/tidb/teams","hooks_url":"https://api.github.com/repos/hhkbp2/tidb/hooks","issue_events_url":"https://api.github.com/repos/hhkbp2/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/hhkbp2/tidb/events","assignees_url":"https://api.github.com/repos/hhkbp2/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/hhkbp2/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/hhkbp2/tidb/tags","blobs_url":"https://api.github.com/repos/hhkbp2/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhkbp2/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhkbp2/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhkbp2/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhkbp2/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/hhkbp2/tidb/languages","stargazers_url":"https://api.github.com/repos/hhkbp2/tidb/stargazers","contributors_url":"https://api.github.com/repos/hhkbp2/tidb/contributors","subscribers_url":"https://api.github.com/repos/hhkbp2/tidb/subscribers","subscription_url":"https://api.github.com/repos/hhkbp2/tidb/subscription","commits_url":"https://api.github.com/repos/hhkbp2/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhkbp2/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhkbp2/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhkbp2/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhkbp2/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/hhkbp2/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhkbp2/tidb/merges","archive_url":"https://api.github.com/repos/hhkbp2/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhkbp2/tidb/downloads","issues_url":"https://api.github.com/repos/hhkbp2/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/hhkbp2/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/hhkbp2/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/hhkbp2/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhkbp2/tidb/labels{/name}","releases_url":"https://api.github.com/repos/hhkbp2/tidb/releases{/id}","created_at":"2015-11-20T04:13:29Z","updated_at":"2015-11-20T04:13:31Z","pushed_at":"2016-01-06T12:12:12Z","git_url":"git://github.com/hhkbp2/tidb.git","ssh_url":"git@github.com:hhkbp2/tidb.git","clone_url":"https://github.com/hhkbp2/tidb.git","svn_url":"https://github.com/hhkbp2/tidb","homepage":"","size":9047,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"81359df4918d58a394f3dbf5faf24df519b1a652","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","created_at":"2015-09-06T04:01:52Z","updated_at":"2016-01-06T11:07:48Z","pushed_at":"2016-01-06T12:12:13Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":10135,"stargazers_count":3210,"watchers_count":3210,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":343,"mirror_url":null,"open_issues_count":66,"forks":343,"open_issues":66,"watchers":3210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/830"},"html":{"href":"https://github.com/pingcap/tidb/pull/830"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/830"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/b607c8504b7a615b193e6ef3d27a9384097abfef"}}}}