{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/53639054","id":53639054,"diff_hunk":"@@ -85,28 +85,64 @@\n \n         var isThereHetLoss = false;\n         var isThereGain = false;\n-        var filterAndSortData = function(histDataOrg) {\n+        var filterAndSortData = function(histDataOrg, sliderValue, metaData, totalSamSliderValue) {\n+            var threshold = 0;\n+            if(sliderValue !== undefined && sliderValue !== null){","path":"portal/src/main/webapp/js/src/crosscancer.js","position":7,"original_position":7,"commit_id":"c3b8aac0678ba500b5d4bc653b1e347832e1a837","original_commit_id":"c3b8aac0678ba500b5d4bc653b1e347832e1a837","user":{"login":"zhx828","id":5400599,"avatar_url":"https://avatars.githubusercontent.com/u/5400599?v=3","gravatar_id":"","url":"https://api.github.com/users/zhx828","html_url":"https://github.com/zhx828","followers_url":"https://api.github.com/users/zhx828/followers","following_url":"https://api.github.com/users/zhx828/following{/other_user}","gists_url":"https://api.github.com/users/zhx828/gists{/gist_id}","starred_url":"https://api.github.com/users/zhx828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhx828/subscriptions","organizations_url":"https://api.github.com/users/zhx828/orgs","repos_url":"https://api.github.com/users/zhx828/repos","events_url":"https://api.github.com/users/zhx828/events{/privacy}","received_events_url":"https://api.github.com/users/zhx828/received_events","type":"User","site_admin":false},"body":"You probably also want to make sure it is a number. You can just use ‘_.isNumber(sliderValue)'  instead of 'sliderValue !== undefined && sliderValue !== null'","created_at":"2016-02-22T15:22:10Z","updated_at":"2016-02-22T15:22:10Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/802#discussion_r53639054","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/53639054"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/802#discussion_r53639054"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802","id":57714984,"html_url":"https://github.com/cBioPortal/cbioportal/pull/802","diff_url":"https://github.com/cBioPortal/cbioportal/pull/802.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/802.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/802","number":802,"state":"open","locked":false,"title":"add filters to histogram in cc overview tab","user":{"login":"JiaoJiao123","id":13951023,"avatar_url":"https://avatars.githubusercontent.com/u/13951023?v=3","gravatar_id":"","url":"https://api.github.com/users/JiaoJiao123","html_url":"https://github.com/JiaoJiao123","followers_url":"https://api.github.com/users/JiaoJiao123/followers","following_url":"https://api.github.com/users/JiaoJiao123/following{/other_user}","gists_url":"https://api.github.com/users/JiaoJiao123/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaoJiao123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaoJiao123/subscriptions","organizations_url":"https://api.github.com/users/JiaoJiao123/orgs","repos_url":"https://api.github.com/users/JiaoJiao123/repos","events_url":"https://api.github.com/users/JiaoJiao123/events{/privacy}","received_events_url":"https://api.github.com/users/JiaoJiao123/received_events","type":"User","site_admin":false},"body":"soved #337 -- this pull request implemented a filtering interface in the cross cancer page similar to the one in the Cancer Type Summary tab.\r\n\r\nhttps://cbioportal-pr-802.herokuapp.com/","created_at":"2016-01-29T23:00:27Z","updated_at":"2016-02-22T15:22:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46bfbd64a26b73deef415d6f2cfd098b604114fc","assignee":{"login":"JiaoJiao123","id":13951023,"avatar_url":"https://avatars.githubusercontent.com/u/13951023?v=3","gravatar_id":"","url":"https://api.github.com/users/JiaoJiao123","html_url":"https://github.com/JiaoJiao123","followers_url":"https://api.github.com/users/JiaoJiao123/followers","following_url":"https://api.github.com/users/JiaoJiao123/following{/other_user}","gists_url":"https://api.github.com/users/JiaoJiao123/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaoJiao123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaoJiao123/subscriptions","organizations_url":"https://api.github.com/users/JiaoJiao123/orgs","repos_url":"https://api.github.com/users/JiaoJiao123/repos","events_url":"https://api.github.com/users/JiaoJiao123/events{/privacy}","received_events_url":"https://api.github.com/users/JiaoJiao123/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/7","html_url":"https://github.com/cBioPortal/cbioportal/milestones/1.1.0","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/7/labels","id":1473102,"number":7,"title":"1.1.0","description":"","creator":{"login":"jjgao","id":840895,"avatar_url":"https://avatars.githubusercontent.com/u/840895?v=3","gravatar_id":"","url":"https://api.github.com/users/jjgao","html_url":"https://github.com/jjgao","followers_url":"https://api.github.com/users/jjgao/followers","following_url":"https://api.github.com/users/jjgao/following{/other_user}","gists_url":"https://api.github.com/users/jjgao/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgao/subscriptions","organizations_url":"https://api.github.com/users/jjgao/orgs","repos_url":"https://api.github.com/users/jjgao/repos","events_url":"https://api.github.com/users/jjgao/events{/privacy}","received_events_url":"https://api.github.com/users/jjgao/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":17,"state":"open","created_at":"2015-12-23T22:21:32Z","updated_at":"2016-02-19T23:30:38Z","due_on":"2016-02-16T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/802/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/c3b8aac0678ba500b5d4bc653b1e347832e1a837","head":{"label":"JiaoJiao123:CCHistogram","ref":"CCHistogram","sha":"c3b8aac0678ba500b5d4bc653b1e347832e1a837","user":{"login":"JiaoJiao123","id":13951023,"avatar_url":"https://avatars.githubusercontent.com/u/13951023?v=3","gravatar_id":"","url":"https://api.github.com/users/JiaoJiao123","html_url":"https://github.com/JiaoJiao123","followers_url":"https://api.github.com/users/JiaoJiao123/followers","following_url":"https://api.github.com/users/JiaoJiao123/following{/other_user}","gists_url":"https://api.github.com/users/JiaoJiao123/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaoJiao123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaoJiao123/subscriptions","organizations_url":"https://api.github.com/users/JiaoJiao123/orgs","repos_url":"https://api.github.com/users/JiaoJiao123/repos","events_url":"https://api.github.com/users/JiaoJiao123/events{/privacy}","received_events_url":"https://api.github.com/users/JiaoJiao123/received_events","type":"User","site_admin":false},"repo":{"id":47633812,"name":"cbioportal","full_name":"JiaoJiao123/cbioportal","owner":{"login":"JiaoJiao123","id":13951023,"avatar_url":"https://avatars.githubusercontent.com/u/13951023?v=3","gravatar_id":"","url":"https://api.github.com/users/JiaoJiao123","html_url":"https://github.com/JiaoJiao123","followers_url":"https://api.github.com/users/JiaoJiao123/followers","following_url":"https://api.github.com/users/JiaoJiao123/following{/other_user}","gists_url":"https://api.github.com/users/JiaoJiao123/gists{/gist_id}","starred_url":"https://api.github.com/users/JiaoJiao123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiaoJiao123/subscriptions","organizations_url":"https://api.github.com/users/JiaoJiao123/orgs","repos_url":"https://api.github.com/users/JiaoJiao123/repos","events_url":"https://api.github.com/users/JiaoJiao123/events{/privacy}","received_events_url":"https://api.github.com/users/JiaoJiao123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JiaoJiao123/cbioportal","description":"","fork":true,"url":"https://api.github.com/repos/JiaoJiao123/cbioportal","forks_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/forks","keys_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/teams","hooks_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/events","assignees_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/tags","blobs_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/languages","stargazers_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/subscription","commits_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/merges","archive_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/downloads","issues_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/JiaoJiao123/cbioportal/deployments","created_at":"2015-12-08T16:20:21Z","updated_at":"2015-12-08T16:20:29Z","pushed_at":"2016-02-15T15:58:28Z","git_url":"git://github.com/JiaoJiao123/cbioportal.git","ssh_url":"git@github.com:JiaoJiao123/cbioportal.git","clone_url":"https://github.com/JiaoJiao123/cbioportal.git","svn_url":"https://github.com/JiaoJiao123/cbioportal","homepage":null,"size":152188,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:rc","ref":"rc","sha":"c0739189ffd4d04302901c848a730213c5f2f580","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-02-17T02:56:11Z","pushed_at":"2016-02-19T22:50:03Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":null,"size":181299,"stargazers_count":41,"watchers_count":41,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":176,"forks":53,"open_issues":176,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/802"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/802"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/802/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/802/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/c3b8aac0678ba500b5d4bc653b1e347832e1a837"}}}}