{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/loopback/issues/2693","repository_url":"https://api.github.com/repos/strongloop/loopback","labels_url":"https://api.github.com/repos/strongloop/loopback/issues/2693/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/loopback/issues/2693/comments","events_url":"https://api.github.com/repos/strongloop/loopback/issues/2693/events","html_url":"https://github.com/strongloop/loopback/pull/2693","id":174100226,"number":2693,"title":"Invalidate sessions after email change","user":{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false},"assignees":[{"login":"loay","id":1986928,"avatar_url":"https://avatars.githubusercontent.com/u/1986928?v=3","gravatar_id":"","url":"https://api.github.com/users/loay","html_url":"https://github.com/loay","followers_url":"https://api.github.com/users/loay/followers","following_url":"https://api.github.com/users/loay/following{/other_user}","gists_url":"https://api.github.com/users/loay/gists{/gist_id}","starred_url":"https://api.github.com/users/loay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loay/subscriptions","organizations_url":"https://api.github.com/users/loay/orgs","repos_url":"https://api.github.com/users/loay/repos","events_url":"https://api.github.com/users/loay/events{/privacy}","received_events_url":"https://api.github.com/users/loay/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-08-30T19:10:15Z","updated_at":"2016-12-15T10:55:05Z","closed_at":"2016-09-19T17:54:31Z","pull_request":{"url":"https://api.github.com/repos/strongloop/loopback/pulls/2693","html_url":"https://github.com/strongloop/loopback/pull/2693","diff_url":"https://github.com/strongloop/loopback/pull/2693.diff","patch_url":"https://github.com/strongloop/loopback/pull/2693.patch"},"body":"connect to https://github.com/strongloop-internal/scrum-loopback/issues/924\n- [x] Delete all tokens of the current user after an email was changed.\n- ~~The currently active token should not be deleted.~~\n"},"comment":{"url":"https://api.github.com/repos/strongloop/loopback/issues/comments/267299253","html_url":"https://github.com/strongloop/loopback/pull/2693#issuecomment-267299253","issue_url":"https://api.github.com/repos/strongloop/loopback/issues/2693","id":267299253,"user":{"login":"doublemarked","id":239190,"avatar_url":"https://avatars.githubusercontent.com/u/239190?v=3","gravatar_id":"","url":"https://api.github.com/users/doublemarked","html_url":"https://github.com/doublemarked","followers_url":"https://api.github.com/users/doublemarked/followers","following_url":"https://api.github.com/users/doublemarked/following{/other_user}","gists_url":"https://api.github.com/users/doublemarked/gists{/gist_id}","starred_url":"https://api.github.com/users/doublemarked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doublemarked/subscriptions","organizations_url":"https://api.github.com/users/doublemarked/orgs","repos_url":"https://api.github.com/users/doublemarked/repos","events_url":"https://api.github.com/users/doublemarked/events{/privacy}","received_events_url":"https://api.github.com/users/doublemarked/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T10:55:05Z","updated_at":"2016-12-15T10:55:05Z","body":"I guess one more thing... @bajtos you wrote,\r\n\r\n> Also the part `The currently active token should not be deleted`. is not implemented yet, but let's leave that as the second step in this pull request, do it only after the rest is already done and reviewed.\r\n\r\nThis is precisely the part that is breaking existing code, because it requires us to rework our frontend to accommodate tokens that suddenly get invalidated. Will such a fix be anticipated in the future? We're trying to figure out whether we should be reworking our frontend to anticipate/explain why the user suddenly needs to reauthenticate, or whether we can hold out on 2.34.1 until such a fix lands.\r\n"}}
{"actor":{"display_login":"doublemarked"}}