{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20","id":78339832,"html_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor/pull/20","diff_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor/pull/20.diff","patch_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor/pull/20.patch","issue_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/20","number":20,"state":"closed","locked":false,"title":"show marker select with images","user":{"login":"fupduck","id":140332,"avatar_url":"https://avatars.githubusercontent.com/u/140332?v=3","gravatar_id":"","url":"https://api.github.com/users/fupduck","html_url":"https://github.com/fupduck","followers_url":"https://api.github.com/users/fupduck/followers","following_url":"https://api.github.com/users/fupduck/following{/other_user}","gists_url":"https://api.github.com/users/fupduck/gists{/gist_id}","starred_url":"https://api.github.com/users/fupduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fupduck/subscriptions","organizations_url":"https://api.github.com/users/fupduck/orgs","repos_url":"https://api.github.com/users/fupduck/repos","events_url":"https://api.github.com/users/fupduck/events{/privacy}","received_events_url":"https://api.github.com/users/fupduck/received_events","type":"User","site_admin":false},"body":"This branch lets the user select the markers by images instead of the text list.\r\n\r\nTo make the marker select field behave like a `<select>` i used a button and divs. Images in the background of select options seem to only work in firefox. To hide the box when the map is clicked I needed to add an eventlistener to the map. I didn't want to create multiple eventlisteners (for every form opening) so i rewrote the app to use only one StyleForm. \r\n\r\nReselecting a marker / line / polygon loads the current data of that element, so for example a change  of the icon will not change the size.\r\n\r\nIf you prefer another solution, would like some changes let me know.\r\nAnother question: which tool do you use to minify the javascript? ","created_at":"2016-07-21T15:44:22Z","updated_at":"2016-10-15T18:02:25Z","closed_at":"2016-10-15T18:02:25Z","merged_at":"2016-10-15T18:02:25Z","merge_commit_sha":"5a993b677436c986175653452d06cb07e96bf3b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20/commits","review_comments_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20/comments","review_comment_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/20/comments","statuses_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/statuses/b2e762a6d96d1b197166540212f00a40f0f80bc0","head":{"label":"fupduck:markerImageselect","ref":"markerImageselect","sha":"b2e762a6d96d1b197166540212f00a40f0f80bc0","user":{"login":"fupduck","id":140332,"avatar_url":"https://avatars.githubusercontent.com/u/140332?v=3","gravatar_id":"","url":"https://api.github.com/users/fupduck","html_url":"https://github.com/fupduck","followers_url":"https://api.github.com/users/fupduck/followers","following_url":"https://api.github.com/users/fupduck/following{/other_user}","gists_url":"https://api.github.com/users/fupduck/gists{/gist_id}","starred_url":"https://api.github.com/users/fupduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fupduck/subscriptions","organizations_url":"https://api.github.com/users/fupduck/orgs","repos_url":"https://api.github.com/users/fupduck/repos","events_url":"https://api.github.com/users/fupduck/events{/privacy}","received_events_url":"https://api.github.com/users/fupduck/received_events","type":"User","site_admin":false},"repo":{"id":63424881,"name":"Leaflet.StyleEditor","full_name":"fupduck/Leaflet.StyleEditor","owner":{"login":"fupduck","id":140332,"avatar_url":"https://avatars.githubusercontent.com/u/140332?v=3","gravatar_id":"","url":"https://api.github.com/users/fupduck","html_url":"https://github.com/fupduck","followers_url":"https://api.github.com/users/fupduck/followers","following_url":"https://api.github.com/users/fupduck/following{/other_user}","gists_url":"https://api.github.com/users/fupduck/gists{/gist_id}","starred_url":"https://api.github.com/users/fupduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fupduck/subscriptions","organizations_url":"https://api.github.com/users/fupduck/orgs","repos_url":"https://api.github.com/users/fupduck/repos","events_url":"https://api.github.com/users/fupduck/events{/privacy}","received_events_url":"https://api.github.com/users/fupduck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fupduck/Leaflet.StyleEditor","description":"Edit the style of features within Leaflet.","fork":true,"url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor","forks_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/forks","keys_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/teams","hooks_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/hooks","issue_events_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/issues/events{/number}","events_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/events","assignees_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/assignees{/user}","branches_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/branches{/branch}","tags_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/tags","blobs_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/languages","stargazers_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/stargazers","contributors_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/contributors","subscribers_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/subscribers","subscription_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/subscription","commits_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/contents/{+path}","compare_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/merges","archive_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/downloads","issues_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/issues{/number}","pulls_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/labels{/name}","releases_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/releases{/id}","deployments_url":"https://api.github.com/repos/fupduck/Leaflet.StyleEditor/deployments","created_at":"2016-07-15T13:42:50Z","updated_at":"2016-07-15T13:42:51Z","pushed_at":"2016-10-14T16:04:59Z","git_url":"git://github.com/fupduck/Leaflet.StyleEditor.git","ssh_url":"git@github.com:fupduck/Leaflet.StyleEditor.git","clone_url":"https://github.com/fupduck/Leaflet.StyleEditor.git","svn_url":"https://github.com/fupduck/Leaflet.StyleEditor","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dwilhelm89:master","ref":"master","sha":"ebacb17e9201d1d8d5c0e8725c11860d2f5a0b51","user":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"repo":{"id":16957169,"name":"Leaflet.StyleEditor","full_name":"dwilhelm89/Leaflet.StyleEditor","owner":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor","description":"Edit the style of features within Leaflet.","fork":false,"url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor","forks_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/forks","keys_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/teams","hooks_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/hooks","issue_events_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/events{/number}","events_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/events","assignees_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/assignees{/user}","branches_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/branches{/branch}","tags_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/tags","blobs_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/languages","stargazers_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/stargazers","contributors_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/contributors","subscribers_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/subscribers","subscription_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/subscription","commits_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/contents/{+path}","compare_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/merges","archive_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/downloads","issues_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues{/number}","pulls_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/labels{/name}","releases_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/releases{/id}","deployments_url":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/deployments","created_at":"2014-02-18T17:25:27Z","updated_at":"2016-10-06T02:14:44Z","pushed_at":"2016-10-15T18:02:27Z","git_url":"git://github.com/dwilhelm89/Leaflet.StyleEditor.git","ssh_url":"git@github.com:dwilhelm89/Leaflet.StyleEditor.git","clone_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor.git","svn_url":"https://github.com/dwilhelm89/Leaflet.StyleEditor","homepage":null,"size":125,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":0,"forks":19,"open_issues":0,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20"},"html":{"href":"https://github.com/dwilhelm89/Leaflet.StyleEditor/pull/20"},"issue":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/20"},"comments":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/dwilhelm89/Leaflet.StyleEditor/statuses/b2e762a6d96d1b197166540212f00a40f0f80bc0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dwilhelm89","id":1424069,"avatar_url":"https://avatars.githubusercontent.com/u/1424069?v=3","gravatar_id":"","url":"https://api.github.com/users/dwilhelm89","html_url":"https://github.com/dwilhelm89","followers_url":"https://api.github.com/users/dwilhelm89/followers","following_url":"https://api.github.com/users/dwilhelm89/following{/other_user}","gists_url":"https://api.github.com/users/dwilhelm89/gists{/gist_id}","starred_url":"https://api.github.com/users/dwilhelm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwilhelm89/subscriptions","organizations_url":"https://api.github.com/users/dwilhelm89/orgs","repos_url":"https://api.github.com/users/dwilhelm89/repos","events_url":"https://api.github.com/users/dwilhelm89/events{/privacy}","received_events_url":"https://api.github.com/users/dwilhelm89/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":4,"additions":260,"deletions":75,"changed_files":5}}
{"actor":{"display_login":"dwilhelm89"}}