{"action":"created","issue":{"url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/4","repository_url":"https://api.github.com/repos/bitrix-expert/monolog-adapter","labels_url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/4/comments","events_url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/4/events","html_url":"https://github.com/bitrix-expert/monolog-adapter/pull/4","id":182772702,"number":4,"title":"Fix declaration of \\Bex\\Monolog\\ExceptionHandlerLog::write according to the last bitrix version (16.5.6)","user":{"login":"mmjurov","id":802208,"avatar_url":"https://avatars.githubusercontent.com/u/802208?v=3","gravatar_id":"","url":"https://api.github.com/users/mmjurov","html_url":"https://github.com/mmjurov","followers_url":"https://api.github.com/users/mmjurov/followers","following_url":"https://api.github.com/users/mmjurov/following{/other_user}","gists_url":"https://api.github.com/users/mmjurov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmjurov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmjurov/subscriptions","organizations_url":"https://api.github.com/users/mmjurov/orgs","repos_url":"https://api.github.com/users/mmjurov/repos","events_url":"https://api.github.com/users/mmjurov/events{/privacy}","received_events_url":"https://api.github.com/users/mmjurov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-13T12:12:38Z","updated_at":"2016-10-14T09:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/pulls/4","html_url":"https://github.com/bitrix-expert/monolog-adapter/pull/4","diff_url":"https://github.com/bitrix-expert/monolog-adapter/pull/4.diff","patch_url":"https://github.com/bitrix-expert/monolog-adapter/pull/4.patch"},"body":"В абстрактном классе \\Bitrix\\Main\\Diag\\ExceptionHandlerLog в методе write первый параметр прописан без тайпхинтинга. Когда именно это поменялось - не могу сказать ... но текущей последней стабильной версии битрикса, php будет ругаться на адаптер с сообщением:\r\n\r\nFatal error: Declaration of Bex\\Monolog\\ExceptionHandlerLog::write() must be compatible with Bitrix\\Main\\Diag\\ExceptionHandlerLog::write($exception, $logType) in .../vendor/bitrix-expert/monolog-adapter/src/ExceptionHandlerLog.php on line 134"},"comment":{"url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/comments/253751704","html_url":"https://github.com/bitrix-expert/monolog-adapter/pull/4#issuecomment-253751704","issue_url":"https://api.github.com/repos/bitrix-expert/monolog-adapter/issues/4","id":253751704,"user":{"login":"mmjurov","id":802208,"avatar_url":"https://avatars.githubusercontent.com/u/802208?v=3","gravatar_id":"","url":"https://api.github.com/users/mmjurov","html_url":"https://github.com/mmjurov","followers_url":"https://api.github.com/users/mmjurov/followers","following_url":"https://api.github.com/users/mmjurov/following{/other_user}","gists_url":"https://api.github.com/users/mmjurov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmjurov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmjurov/subscriptions","organizations_url":"https://api.github.com/users/mmjurov/orgs","repos_url":"https://api.github.com/users/mmjurov/repos","events_url":"https://api.github.com/users/mmjurov/events{/privacy}","received_events_url":"https://api.github.com/users/mmjurov/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T09:25:13Z","updated_at":"2016-10-14T09:25:13Z","body":"Обновил. \r\nКстати говоря об ограничениях. Может быть можно composer обучить определять версии модулей битрикса, и строить свои зависимости от них? Хотя это тема для другого разговора уже .."}}
{"actor":{"display_login":"mmjurov"}}