{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/74994321","id":74994321,"diff_hunk":"@@ -0,0 +1,172 @@\n+/*\n+ * Copyright © 2016 Cask Data, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package co.cask.cdap.app.runtime.spark;\n+\n+import co.cask.cdap.api.common.Bytes;\n+import co.cask.cdap.common.io.Locations;\n+import com.google.common.base.Supplier;\n+import com.google.common.base.Throwables;\n+import org.apache.hadoop.io.Text;\n+import org.apache.hadoop.security.Credentials;\n+import org.apache.hadoop.security.UserGroupInformation;\n+import org.apache.hadoop.security.token.Token;\n+import org.apache.hadoop.security.token.TokenIdentifier;\n+import org.apache.twill.filesystem.Location;\n+import org.junit.Assert;\n+import org.junit.ClassRule;\n+import org.junit.Test;\n+import org.junit.rules.TemporaryFolder;\n+\n+import java.io.DataInputStream;\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.Comparator;\n+import java.util.List;\n+import java.util.concurrent.TimeUnit;\n+import java.util.regex.Matcher;\n+import java.util.regex.Pattern;\n+\n+/**\n+ *\n+ */\n+public class SparkCredentialsUpdaterTest {\n+\n+  @ClassRule\n+  public static final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();\n+\n+  @Test\n+  public void testUpdater() throws Exception {\n+    Location credentialsDir = Locations.toLocation(TEMPORARY_FOLDER.newFolder());\n+\n+    // Create a updater that don't do any auto-update within the test time and don't cleanup\n+    SparkCredentialsUpdater updater = new SparkCredentialsUpdater(createCredentialsSupplier(),\n+                                                                  credentialsDir, \"credentials\",\n+                                                                  TimeUnit.DAYS.toMillis(1),\n+                                                                  TimeUnit.DAYS.toMillis(1), Integer.MAX_VALUE) {\n+      @Override\n+      long getNextUpdateDelay(Credentials credentials) throws IOException {\n+        return TimeUnit.DAYS.toMillis(1);\n+      }\n+    };\n+\n+    // Before the updater starts, the directory is empty\n+    Assert.assertTrue(credentialsDir.list().isEmpty());\n+\n+    UserGroupInformation.getCurrentUser().addToken(new Token<>(Bytes.toBytes(\"id\"), Bytes.toBytes(\"pass\"),\n+                                                               new Text(\"kind\"), new Text(\"service\")));\n+\n+    updater.startAndWait();\n+    try {\n+      List<Location> expectedFiles = new ArrayList<>();\n+      expectedFiles.add(credentialsDir.append(\"credentials-1\"));\n+\n+      for (int i = 1; i <= 10; i++) {\n+        Assert.assertEquals(expectedFiles, listAndSort(credentialsDir));\n+\n+        // Read the credentials from the last file\n+        Credentials newCredentials = new Credentials();\n+        try (DataInputStream is = new DataInputStream(expectedFiles.get(expectedFiles.size() - 1).getInputStream())) {\n+          newCredentials.readTokenStorageStream(is);\n+        }\n+\n+        // Should contains all tokens of the current user\n+        Credentials userCredentials = UserGroupInformation.getCurrentUser().getCredentials();\n+        for (Token<? extends TokenIdentifier> token : userCredentials.getAllTokens()) {\n+          Assert.assertEquals(token, newCredentials.getToken(token.getService()));\n+        }\n+\n+        UserGroupInformation.getCurrentUser().addToken(new Token<>(Bytes.toBytes(\"id\" + i), Bytes.toBytes(\"pass\" + i),\n+                                                                   new Text(\"kind\" + i), new Text(\"service\" + i)));\n+        updater.run();\n+        expectedFiles.add(credentialsDir.append(\"credentials-\" + (i + 1)));\n+      }\n+    } finally {\n+      updater.stopAndWait();\n+    }\n+  }\n+\n+  @Test\n+  public void testCleanup() throws IOException, InterruptedException {\n+    Location credentialsDir = Locations.toLocation(TEMPORARY_FOLDER.newFolder());\n+\n+    // Create a updater that don't do any auto-update within the test time\n+    SparkCredentialsUpdater updater = new SparkCredentialsUpdater(createCredentialsSupplier(),\n+                                                                  credentialsDir, \"credentials\",\n+                                                                  TimeUnit.DAYS.toMillis(1),\n+                                                                  TimeUnit.SECONDS.toMillis(3), 3) {\n+      @Override\n+      long getNextUpdateDelay(Credentials credentials) throws IOException {\n+        return TimeUnit.DAYS.toMillis(1);\n+      }\n+    };\n+\n+    updater.startAndWait();","path":"cdap-spark-core/src/test/java/co/cask/cdap/app/runtime/spark/SparkCredentialsUpdaterTest.java","position":118,"original_position":118,"commit_id":"90319e3c9469cbdb1d3a8046dad2352283dfae8f","original_commit_id":"90319e3c9469cbdb1d3a8046dad2352283dfae8f","user":{"login":"chtyim","id":885032,"avatar_url":"https://avatars.githubusercontent.com/u/885032?v=3","gravatar_id":"","url":"https://api.github.com/users/chtyim","html_url":"https://github.com/chtyim","followers_url":"https://api.github.com/users/chtyim/followers","following_url":"https://api.github.com/users/chtyim/following{/other_user}","gists_url":"https://api.github.com/users/chtyim/gists{/gist_id}","starred_url":"https://api.github.com/users/chtyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtyim/subscriptions","organizations_url":"https://api.github.com/users/chtyim/orgs","repos_url":"https://api.github.com/users/chtyim/repos","events_url":"https://api.github.com/users/chtyim/events{/privacy}","received_events_url":"https://api.github.com/users/chtyim/received_events","type":"User","site_admin":false},"body":"sure.","created_at":"2016-08-16T18:36:22Z","updated_at":"2016-08-16T18:36:22Z","html_url":"https://github.com/caskdata/cdap/pull/6433#discussion_r74994321","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6433","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/74994321"},"html":{"href":"https://github.com/caskdata/cdap/pull/6433#discussion_r74994321"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6433"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6433","id":81383302,"html_url":"https://github.com/caskdata/cdap/pull/6433","diff_url":"https://github.com/caskdata/cdap/pull/6433.diff","patch_url":"https://github.com/caskdata/cdap/pull/6433.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6433","number":6433,"state":"open","locked":false,"title":"(CDAP-5794) Added Credentials refresh for Spark","user":{"login":"chtyim","id":885032,"avatar_url":"https://avatars.githubusercontent.com/u/885032?v=3","gravatar_id":"","url":"https://api.github.com/users/chtyim","html_url":"https://github.com/chtyim","followers_url":"https://api.github.com/users/chtyim/followers","following_url":"https://api.github.com/users/chtyim/following{/other_user}","gists_url":"https://api.github.com/users/chtyim/gists{/gist_id}","starred_url":"https://api.github.com/users/chtyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtyim/subscriptions","organizations_url":"https://api.github.com/users/chtyim/orgs","repos_url":"https://api.github.com/users/chtyim/repos","events_url":"https://api.github.com/users/chtyim/events{/privacy}","received_events_url":"https://api.github.com/users/chtyim/received_events","type":"User","site_admin":false},"body":"- Added a new writeCredentials endpoint to the SparkExecutionService to write out latest Credentails of the Spark Client Container\r\n  - CDAP master is responsible for updating the Credentials for the client container\r\n- Add a SparkCredentialsUpdater that runs in Spark driver process\r\n  - Periodically hit the writeCredentials endpoint of the SparkExecutionService\r\n  - Update the credentials of the current driver process\r\n  - Write out credentials file to Spark staging directory for executor processes to pickup","created_at":"2016-08-15T22:02:38Z","updated_at":"2016-08-16T18:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e15905aba5cb8245a014743aab324f79299267","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6433/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6433/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6433/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/90319e3c9469cbdb1d3a8046dad2352283dfae8f","head":{"label":"caskdata:feature/CDAP-5794-spark-tokens","ref":"feature/CDAP-5794-spark-tokens","sha":"90319e3c9469cbdb1d3a8046dad2352283dfae8f","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-29T12:19:53Z","pushed_at":"2016-08-16T18:31:56Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":630178,"stargazers_count":137,"watchers_count":137,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":32,"forks":53,"open_issues":32,"watchers":137,"default_branch":"release/3.5"}},"base":{"label":"caskdata:release/3.5","ref":"release/3.5","sha":"23d941cbeb49b49b68caf7c7918be57f192b4b8c","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-07-29T12:19:53Z","pushed_at":"2016-08-16T18:31:56Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":630178,"stargazers_count":137,"watchers_count":137,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":32,"forks":53,"open_issues":32,"watchers":137,"default_branch":"release/3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6433"},"html":{"href":"https://github.com/caskdata/cdap/pull/6433"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6433"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6433/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6433/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6433/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/90319e3c9469cbdb1d3a8046dad2352283dfae8f"}}}}
{"actor":{"display_login":"chtyim"}}