{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/comments/58923474","id":58923474,"diff_hunk":"@@ -26,71 +26,58 @@\n /**\n  * Stages an application to be deployed.\n  */\n-public class StageAction extends AppAction {\n+public class StageAction implements Action {\n \n   private StageConfiguration configuration;\n+  private StageExecutor stageExecutor;\n \n-  public StageAction(StageConfiguration configuration) {\n+  public StageAction(StageConfiguration configuration, StageExecutor stageExecutor) {\n     Preconditions.checkNotNull(configuration);\n     Preconditions.checkNotNull(configuration.getSourceDirectory());\n     Preconditions.checkNotNull(configuration.getStagingDirectory());\n-    Preconditions.checkNotNull(configuration.getAppEngineSdkRoot());\n+    Preconditions.checkNotNull(stageExecutor);\n \n     this.configuration = configuration;\n+    this.stageExecutor = stageExecutor;\n   }\n \n   @Override\n-  public boolean execute() {\n+  public int execute() {\n     List<String> arguments = new ArrayList<>();\n-    arguments.add(\"stage\");\n     arguments.add(configuration.getSourceDirectory().toString());\n     arguments.add(configuration.getStagingDirectory().toString());\n-    if (configuration.isEnableQuickstart()) {\n+    if (Boolean.TRUE.equals(configuration.isEnableQuickstart())) {\n       arguments.add(\"--enable_quickstart\");\n     }\n-    if (configuration.isDisableUpdateCheck()) {\n+    if (Boolean.TRUE.equals(configuration.isDisableUpdateCheck())) {\n       arguments.add(\"--disable_update_check\");\n     }\n     if (!Strings.isNullOrEmpty(configuration.getVersion())) {\n       arguments.add(\"--version\");\n       arguments.add(configuration.getVersion());\n     }\n-    if (!Strings.isNullOrEmpty(configuration.getCloudProject())) {\n+    if (!Strings.isNullOrEmpty(configuration.getApplicationId())) {","path":"src/main/java/com/google/cloud/tools/app/action/StageAction.java","position":56,"original_position":56,"commit_id":"7eb3aefde058b49d47bd4b682d9615600c95de0c","original_commit_id":"7eb3aefde058b49d47bd4b682d9615600c95de0c","user":{"login":"patflynn","id":7862557,"avatar_url":"https://avatars.githubusercontent.com/u/7862557?v=3","gravatar_id":"","url":"https://api.github.com/users/patflynn","html_url":"https://github.com/patflynn","followers_url":"https://api.github.com/users/patflynn/followers","following_url":"https://api.github.com/users/patflynn/following{/other_user}","gists_url":"https://api.github.com/users/patflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/patflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patflynn/subscriptions","organizations_url":"https://api.github.com/users/patflynn/orgs","repos_url":"https://api.github.com/users/patflynn/repos","events_url":"https://api.github.com/users/patflynn/events{/privacy}","received_events_url":"https://api.github.com/users/patflynn/received_events","type":"User","site_admin":false},"body":"isn't 'applicationId' a deprecated concept?","created_at":"2016-04-07T18:42:23Z","updated_at":"2016-04-07T18:42:23Z","html_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9#discussion_r58923474","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/comments/58923474"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9#discussion_r58923474"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9","id":64721444,"html_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9","diff_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9.diff","patch_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/9","number":9,"state":"open","locked":false,"title":"Create execution abstraction","user":{"login":"loosebazooka","id":1304826,"avatar_url":"https://avatars.githubusercontent.com/u/1304826?v=3","gravatar_id":"","url":"https://api.github.com/users/loosebazooka","html_url":"https://github.com/loosebazooka","followers_url":"https://api.github.com/users/loosebazooka/followers","following_url":"https://api.github.com/users/loosebazooka/following{/other_user}","gists_url":"https://api.github.com/users/loosebazooka/gists{/gist_id}","starred_url":"https://api.github.com/users/loosebazooka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loosebazooka/subscriptions","organizations_url":"https://api.github.com/users/loosebazooka/orgs","repos_url":"https://api.github.com/users/loosebazooka/repos","events_url":"https://api.github.com/users/loosebazooka/events{/privacy}","received_events_url":"https://api.github.com/users/loosebazooka/received_events","type":"User","site_admin":false},"body":"Also move package paths -> com.google.gcloud.tools.action.app","created_at":"2016-03-31T01:11:22Z","updated_at":"2016-04-07T18:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"309ef5a43c2bd24067bc6619fe9d39c481521223","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/9/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/statuses/7eb3aefde058b49d47bd4b682d9615600c95de0c","head":{"label":"GoogleCloudPlatform:updateCode","ref":"updateCode","sha":"7eb3aefde058b49d47bd4b682d9615600c95de0c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"app-tools-lib-for-java","full_name":"GoogleCloudPlatform/app-tools-lib-for-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-04-06T19:46:01Z","pushed_at":"2016-04-04T22:48:43Z","git_url":"git://github.com/GoogleCloudPlatform/app-tools-lib-for-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-tools-lib-for-java.git","clone_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java.git","svn_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java","homepage":null,"size":117,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":3,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:code","ref":"code","sha":"2105fa8a350dcd00b6a20b305cffe0c7c0e051f2","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"app-tools-lib-for-java","full_name":"GoogleCloudPlatform/app-tools-lib-for-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-04-06T19:46:01Z","pushed_at":"2016-04-04T22:48:43Z","git_url":"git://github.com/GoogleCloudPlatform/app-tools-lib-for-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-tools-lib-for-java.git","clone_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java.git","svn_url":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java","homepage":null,"size":117,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-tools-lib-for-java/pull/9"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/9"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-tools-lib-for-java/statuses/7eb3aefde058b49d47bd4b682d9615600c95de0c"}}}}