{"action":"closed","number":9257,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257","id":89388792,"html_url":"https://github.com/zurb/foundation-sites/pull/9257","diff_url":"https://github.com/zurb/foundation-sites/pull/9257.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/9257.patch","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/9257","number":9257,"state":"closed","locked":false,"title":"Allow vOffset option in floated dropdown alignment","user":{"login":"whatcould","id":8288,"avatar_url":"https://avatars.githubusercontent.com/u/8288?v=3","gravatar_id":"","url":"https://api.github.com/users/whatcould","html_url":"https://github.com/whatcould","followers_url":"https://api.github.com/users/whatcould/followers","following_url":"https://api.github.com/users/whatcould/following{/other_user}","gists_url":"https://api.github.com/users/whatcould/gists{/gist_id}","starred_url":"https://api.github.com/users/whatcould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatcould/subscriptions","organizations_url":"https://api.github.com/users/whatcould/orgs","repos_url":"https://api.github.com/users/whatcould/repos","events_url":"https://api.github.com/users/whatcould/events{/privacy}","received_events_url":"https://api.github.com/users/whatcould/received_events","type":"User","site_admin":false},"body":"Left-bottom and right-bottom were added in 2d0eed, PR #8475, for dropdown alignment; but in these cases, the `vOffset` option is left off. Since the default positioning (which would correspond to ‘bottom’) adds vOffset, I’m assuming these were left off as an oversight.\n\nSince `bottom` includes this vOffset option, I don't see why left-bottom and right-bottom wouldn't either. See below for an example before and after image.\n\nBefore (no offset, menu is crowded):\n<img width=\"217\" alt=\"no-offset\" src=\"https://cloud.githubusercontent.com/assets/8288/19389928/e36dc242-91f3-11e6-86d4-60f3a824119d.png\">\n\nAfter, with vOffset, the avatar isn't so crowded:\n<img width=\"213\" alt=\"offset after\" src=\"https://cloud.githubusercontent.com/assets/8288/19389932/e9205114-91f3-11e6-920a-264480533d96.png\">\n","created_at":"2016-10-14T13:55:17Z","updated_at":"2016-10-31T21:26:49Z","closed_at":"2016-10-31T21:26:49Z","merged_at":"2016-10-31T21:26:49Z","merge_commit_sha":"1f57cf3df44e135565260f6faeffdeda2580971f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257/commits","review_comments_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257/comments","review_comment_url":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/9257/comments","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/2506b2b56e5e1b5dfa82e058ab0e4f98fae88912","head":{"label":"whatcould:develop","ref":"develop","sha":"2506b2b56e5e1b5dfa82e058ab0e4f98fae88912","user":{"login":"whatcould","id":8288,"avatar_url":"https://avatars.githubusercontent.com/u/8288?v=3","gravatar_id":"","url":"https://api.github.com/users/whatcould","html_url":"https://github.com/whatcould","followers_url":"https://api.github.com/users/whatcould/followers","following_url":"https://api.github.com/users/whatcould/following{/other_user}","gists_url":"https://api.github.com/users/whatcould/gists{/gist_id}","starred_url":"https://api.github.com/users/whatcould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatcould/subscriptions","organizations_url":"https://api.github.com/users/whatcould/orgs","repos_url":"https://api.github.com/users/whatcould/repos","events_url":"https://api.github.com/users/whatcould/events{/privacy}","received_events_url":"https://api.github.com/users/whatcould/received_events","type":"User","site_admin":false},"repo":{"id":59421456,"name":"foundation-sites","full_name":"whatcould/foundation-sites","owner":{"login":"whatcould","id":8288,"avatar_url":"https://avatars.githubusercontent.com/u/8288?v=3","gravatar_id":"","url":"https://api.github.com/users/whatcould","html_url":"https://github.com/whatcould","followers_url":"https://api.github.com/users/whatcould/followers","following_url":"https://api.github.com/users/whatcould/following{/other_user}","gists_url":"https://api.github.com/users/whatcould/gists{/gist_id}","starred_url":"https://api.github.com/users/whatcould/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatcould/subscriptions","organizations_url":"https://api.github.com/users/whatcould/orgs","repos_url":"https://api.github.com/users/whatcould/repos","events_url":"https://api.github.com/users/whatcould/events{/privacy}","received_events_url":"https://api.github.com/users/whatcould/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whatcould/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":true,"url":"https://api.github.com/repos/whatcould/foundation-sites","forks_url":"https://api.github.com/repos/whatcould/foundation-sites/forks","keys_url":"https://api.github.com/repos/whatcould/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatcould/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatcould/foundation-sites/teams","hooks_url":"https://api.github.com/repos/whatcould/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/whatcould/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/whatcould/foundation-sites/events","assignees_url":"https://api.github.com/repos/whatcould/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/whatcould/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/whatcould/foundation-sites/tags","blobs_url":"https://api.github.com/repos/whatcould/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatcould/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatcould/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatcould/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatcould/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/whatcould/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/whatcould/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/whatcould/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/whatcould/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/whatcould/foundation-sites/subscription","commits_url":"https://api.github.com/repos/whatcould/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatcould/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatcould/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatcould/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatcould/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/whatcould/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatcould/foundation-sites/merges","archive_url":"https://api.github.com/repos/whatcould/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatcould/foundation-sites/downloads","issues_url":"https://api.github.com/repos/whatcould/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/whatcould/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/whatcould/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/whatcould/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatcould/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/whatcould/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/whatcould/foundation-sites/deployments","created_at":"2016-05-22T16:08:24Z","updated_at":"2016-05-22T16:08:29Z","pushed_at":"2016-10-26T12:51:26Z","git_url":"git://github.com/whatcould/foundation-sites.git","ssh_url":"git@github.com:whatcould/foundation-sites.git","clone_url":"https://github.com/whatcould/foundation-sites.git","svn_url":"https://github.com/whatcould/foundation-sites","homepage":"http://foundation.zurb.com","size":117275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zurb:develop","ref":"develop","sha":"68cf39d1c3dd02a13f2e28886a19f931f2de0d18","user":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"repo":{"id":2573058,"name":"foundation-sites","full_name":"zurb/foundation-sites","owner":{"login":"zurb","id":156122,"avatar_url":"https://avatars.githubusercontent.com/u/156122?v=3","gravatar_id":"","url":"https://api.github.com/users/zurb","html_url":"https://github.com/zurb","followers_url":"https://api.github.com/users/zurb/followers","following_url":"https://api.github.com/users/zurb/following{/other_user}","gists_url":"https://api.github.com/users/zurb/gists{/gist_id}","starred_url":"https://api.github.com/users/zurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zurb/subscriptions","organizations_url":"https://api.github.com/users/zurb/orgs","repos_url":"https://api.github.com/users/zurb/repos","events_url":"https://api.github.com/users/zurb/events{/privacy}","received_events_url":"https://api.github.com/users/zurb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zurb/foundation-sites","description":"The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.","fork":false,"url":"https://api.github.com/repos/zurb/foundation-sites","forks_url":"https://api.github.com/repos/zurb/foundation-sites/forks","keys_url":"https://api.github.com/repos/zurb/foundation-sites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zurb/foundation-sites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zurb/foundation-sites/teams","hooks_url":"https://api.github.com/repos/zurb/foundation-sites/hooks","issue_events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/events{/number}","events_url":"https://api.github.com/repos/zurb/foundation-sites/events","assignees_url":"https://api.github.com/repos/zurb/foundation-sites/assignees{/user}","branches_url":"https://api.github.com/repos/zurb/foundation-sites/branches{/branch}","tags_url":"https://api.github.com/repos/zurb/foundation-sites/tags","blobs_url":"https://api.github.com/repos/zurb/foundation-sites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zurb/foundation-sites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zurb/foundation-sites/git/refs{/sha}","trees_url":"https://api.github.com/repos/zurb/foundation-sites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zurb/foundation-sites/statuses/{sha}","languages_url":"https://api.github.com/repos/zurb/foundation-sites/languages","stargazers_url":"https://api.github.com/repos/zurb/foundation-sites/stargazers","contributors_url":"https://api.github.com/repos/zurb/foundation-sites/contributors","subscribers_url":"https://api.github.com/repos/zurb/foundation-sites/subscribers","subscription_url":"https://api.github.com/repos/zurb/foundation-sites/subscription","commits_url":"https://api.github.com/repos/zurb/foundation-sites/commits{/sha}","git_commits_url":"https://api.github.com/repos/zurb/foundation-sites/git/commits{/sha}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/comments{/number}","issue_comment_url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments{/number}","contents_url":"https://api.github.com/repos/zurb/foundation-sites/contents/{+path}","compare_url":"https://api.github.com/repos/zurb/foundation-sites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zurb/foundation-sites/merges","archive_url":"https://api.github.com/repos/zurb/foundation-sites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zurb/foundation-sites/downloads","issues_url":"https://api.github.com/repos/zurb/foundation-sites/issues{/number}","pulls_url":"https://api.github.com/repos/zurb/foundation-sites/pulls{/number}","milestones_url":"https://api.github.com/repos/zurb/foundation-sites/milestones{/number}","notifications_url":"https://api.github.com/repos/zurb/foundation-sites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zurb/foundation-sites/labels{/name}","releases_url":"https://api.github.com/repos/zurb/foundation-sites/releases{/id}","deployments_url":"https://api.github.com/repos/zurb/foundation-sites/deployments","created_at":"2011-10-13T23:05:42Z","updated_at":"2016-10-31T20:22:28Z","pushed_at":"2016-10-31T21:26:49Z","git_url":"git://github.com/zurb/foundation-sites.git","ssh_url":"git@github.com:zurb/foundation-sites.git","clone_url":"https://github.com/zurb/foundation-sites.git","svn_url":"https://github.com/zurb/foundation-sites","homepage":"http://foundation.zurb.com","size":139392,"stargazers_count":24346,"watchers_count":24346,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5318,"mirror_url":null,"open_issues_count":435,"forks":5318,"open_issues":435,"watchers":24346,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257"},"html":{"href":"https://github.com/zurb/foundation-sites/pull/9257"},"issue":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/9257"},"comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/issues/9257/comments"},"review_comments":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257/comments"},"review_comment":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zurb/foundation-sites/pulls/9257/commits"},"statuses":{"href":"https://api.github.com/repos/zurb/foundation-sites/statuses/2506b2b56e5e1b5dfa82e058ab0e4f98fae88912"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kball","id":44007,"avatar_url":"https://avatars.githubusercontent.com/u/44007?v=3","gravatar_id":"","url":"https://api.github.com/users/kball","html_url":"https://github.com/kball","followers_url":"https://api.github.com/users/kball/followers","following_url":"https://api.github.com/users/kball/following{/other_user}","gists_url":"https://api.github.com/users/kball/gists{/gist_id}","starred_url":"https://api.github.com/users/kball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kball/subscriptions","organizations_url":"https://api.github.com/users/kball/orgs","repos_url":"https://api.github.com/users/kball/repos","events_url":"https://api.github.com/users/kball/events{/privacy}","received_events_url":"https://api.github.com/users/kball/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"kball"}}