{"action":"created","issue":{"url":"https://api.github.com/repos/naver/pinpoint/issues/2285","repository_url":"https://api.github.com/repos/naver/pinpoint","labels_url":"https://api.github.com/repos/naver/pinpoint/issues/2285/labels{/name}","comments_url":"https://api.github.com/repos/naver/pinpoint/issues/2285/comments","events_url":"https://api.github.com/repos/naver/pinpoint/issues/2285/events","html_url":"https://github.com/naver/pinpoint/issues/2285","id":191627704,"number":2285,"title":"log link button can not work","user":{"login":"zhangzhaoyu","id":5105709,"avatar_url":"https://avatars.githubusercontent.com/u/5105709?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangzhaoyu","html_url":"https://github.com/zhangzhaoyu","followers_url":"https://api.github.com/users/zhangzhaoyu/followers","following_url":"https://api.github.com/users/zhangzhaoyu/following{/other_user}","gists_url":"https://api.github.com/users/zhangzhaoyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangzhaoyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangzhaoyu/subscriptions","organizations_url":"https://api.github.com/users/zhangzhaoyu/orgs","repos_url":"https://api.github.com/users/zhangzhaoyu/repos","events_url":"https://api.github.com/users/zhangzhaoyu/events{/privacy}","received_events_url":"https://api.github.com/users/zhangzhaoyu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"minwoo-jung","id":4557258,"avatar_url":"https://avatars.githubusercontent.com/u/4557258?v=3","gravatar_id":"","url":"https://api.github.com/users/minwoo-jung","html_url":"https://github.com/minwoo-jung","followers_url":"https://api.github.com/users/minwoo-jung/followers","following_url":"https://api.github.com/users/minwoo-jung/following{/other_user}","gists_url":"https://api.github.com/users/minwoo-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoo-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoo-jung/subscriptions","organizations_url":"https://api.github.com/users/minwoo-jung/orgs","repos_url":"https://api.github.com/users/minwoo-jung/repos","events_url":"https://api.github.com/users/minwoo-jung/events{/privacy}","received_events_url":"https://api.github.com/users/minwoo-jung/received_events","type":"User","site_admin":false},"assignees":[{"login":"minwoo-jung","id":4557258,"avatar_url":"https://avatars.githubusercontent.com/u/4557258?v=3","gravatar_id":"","url":"https://api.github.com/users/minwoo-jung","html_url":"https://github.com/minwoo-jung","followers_url":"https://api.github.com/users/minwoo-jung/followers","following_url":"https://api.github.com/users/minwoo-jung/following{/other_user}","gists_url":"https://api.github.com/users/minwoo-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoo-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoo-jung/subscriptions","organizations_url":"https://api.github.com/users/minwoo-jung/orgs","repos_url":"https://api.github.com/users/minwoo-jung/repos","events_url":"https://api.github.com/users/minwoo-jung/events{/privacy}","received_events_url":"https://api.github.com/users/minwoo-jung/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-11-25T05:31:11Z","updated_at":"2016-11-28T08:41:57Z","closed_at":null,"body":"<!-- \r\n    If you're reporting a bug or seeking help because something is not working, \r\n    please fill out below. \r\n    For all else, feel free to DELETE everything and post away your issue!\r\n-->\r\n\r\n#### Description\r\n<!--- Provide a more detailed introduction to the issue itself -->\r\nHi, I am using pintpoint to trace my spring boot application. pinpoint is a really great application. In my case, I stored the detail logs into elasticsearch. I do everything as you say in ** per-request_feature_guide.md**, than I can get the log button, but when I click it, it can't open the destination url by the broswer. \r\n\r\nWhen I debug, I find the property **RecordSet.loggingTransactionInfo** is false. Because of it, I can not click the log button to show the detail logs.\r\n\r\nCan you help me how to set the value of **RecordSet.loggingTransactionInfo** ? \r\nThank you very much !!!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/naver/pinpoint/issues/comments/263212961","html_url":"https://github.com/naver/pinpoint/issues/2285#issuecomment-263212961","issue_url":"https://api.github.com/repos/naver/pinpoint/issues/2285","id":263212961,"user":{"login":"minwoo-jung","id":4557258,"avatar_url":"https://avatars.githubusercontent.com/u/4557258?v=3","gravatar_id":"","url":"https://api.github.com/users/minwoo-jung","html_url":"https://github.com/minwoo-jung","followers_url":"https://api.github.com/users/minwoo-jung/followers","following_url":"https://api.github.com/users/minwoo-jung/following{/other_user}","gists_url":"https://api.github.com/users/minwoo-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/minwoo-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minwoo-jung/subscriptions","organizations_url":"https://api.github.com/users/minwoo-jung/orgs","repos_url":"https://api.github.com/users/minwoo-jung/repos","events_url":"https://api.github.com/users/minwoo-jung/events{/privacy}","received_events_url":"https://api.github.com/users/minwoo-jung/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T08:41:57Z","updated_at":"2016-11-28T08:41:57Z","body":"1.\r\nHow are you saving your logs to elasticsearch? \r\nAre you implementing your own appender, or are you using some open source appender? Or are you parsing your local log files and sending them to elasticsearch manually?\r\nIf you can show me the code/class for the appender that saves logs to elastic search, I could take a look at it and tell you which methods to hook the interceptors. \r\n\r\n2.\r\nI wouldn't recommend your current approach.\r\nThere is something you need to know - adding the `recorder.recordLogging(...)` to the bean interceptor will activate the log button in the web UI for every single trace, **including those that did not send it's log to elasticsearch**.\r\nThis will confuse the users as the log button will be active even for traces that didn't send their logs to elasticsearch. \r\n\r\n3.\r\nDon't put too much stress into `LoggingInfo.LOGGED`. Just think of it as a boolean flag to indicate that a log has been recorded for now. Our future plan is to expand on this to record the log levels as well.\r\n \r\n4.\r\nI think adding the enable/disable configuration for each plugin to *pinpoint.config* would only confuse the users. Activating the log button depending on whether a trace sent it's log to a storage server, or not use log button and directly search for this log using the *transactionId* in logging server(ex. elasticsearch server) (which is our current approach) - is much less confusing than blindly leaving this to a configuration option for different plugins."}}
{"actor":{"display_login":"minwoo-jung"}}