{"action":"created","comment":{"url":"https://api.github.com/repos/vega/lyra/pulls/comments/57610539","id":57610539,"diff_hunk":"@@ -99,7 +103,7 @@ Mark.prototype.dataset = function(id) {\n     return this;\n   }\n \n-  this.from = undefined;\n+  delete this.from;","path":"src/js/model/primitives/marks/Mark.js","position":30,"original_position":30,"commit_id":"2d5767f1eb73253f71e923b8c89b3303eb83f065","original_commit_id":"2d5767f1eb73253f71e923b8c89b3303eb83f065","user":{"login":"kadamwhite","id":442115,"avatar_url":"https://avatars.githubusercontent.com/u/442115?v=3","gravatar_id":"","url":"https://api.github.com/users/kadamwhite","html_url":"https://github.com/kadamwhite","followers_url":"https://api.github.com/users/kadamwhite/followers","following_url":"https://api.github.com/users/kadamwhite/following{/other_user}","gists_url":"https://api.github.com/users/kadamwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/kadamwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadamwhite/subscriptions","organizations_url":"https://api.github.com/users/kadamwhite/orgs","repos_url":"https://api.github.com/users/kadamwhite/repos","events_url":"https://api.github.com/users/kadamwhite/events{/privacy}","received_events_url":"https://api.github.com/users/kadamwhite/received_events","type":"User","site_admin":false},"body":"How I read this (and @arvind can confirm) is that this code is meant to unset `this.from` if the dataset method is called with arguments that cause it to fall through all the `else if`'s... so we either need to keep the `= undefined`, which feels janky b/c we try to avoid using undefined as a value, even tho it does work in strict mode; or delete the property, which feels more explicit and accomplishes the same end. Initializing it to undefined to begin with still feels weird, b/c just omitting it entirely ought to accomplish the same goals; but I fixed this lint error about use of `undefined` then decided I didn't want to get too deep in the weeds by addressing the other as well. I would revert this if you don't feel it's appropriate, but I don't think I'd do anything further to this method b/c this patch was just for lint cleanup and isn't related to the store or signals.","created_at":"2016-03-28T18:28:52Z","updated_at":"2016-03-28T18:28:52Z","html_url":"https://github.com/vega/lyra/pull/310#discussion_r57610539","pull_request_url":"https://api.github.com/repos/vega/lyra/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments/57610539"},"html":{"href":"https://github.com/vega/lyra/pull/310#discussion_r57610539"},"pull_request":{"href":"https://api.github.com/repos/vega/lyra/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/vega/lyra/pulls/310","id":64208635,"html_url":"https://github.com/vega/lyra/pull/310","diff_url":"https://github.com/vega/lyra/pull/310.diff","patch_url":"https://github.com/vega/lyra/pull/310.patch","issue_url":"https://api.github.com/repos/vega/lyra/issues/310","number":310,"state":"open","locked":false,"title":"Move signals to redux store","user":{"login":"kadamwhite","id":442115,"avatar_url":"https://avatars.githubusercontent.com/u/442115?v=3","gravatar_id":"","url":"https://api.github.com/users/kadamwhite","html_url":"https://github.com/kadamwhite","followers_url":"https://api.github.com/users/kadamwhite/followers","following_url":"https://api.github.com/users/kadamwhite/following{/other_user}","gists_url":"https://api.github.com/users/kadamwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/kadamwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadamwhite/subscriptions","organizations_url":"https://api.github.com/users/kadamwhite/orgs","repos_url":"https://api.github.com/users/kadamwhite/repos","events_url":"https://api.github.com/users/kadamwhite/events{/privacy}","received_events_url":"https://api.github.com/users/kadamwhite/received_events","type":"User","site_admin":false},"body":"Will update description later, but PR'ing for now to get eyes on it: this moves all signals into the redux store, and (vebosely) synchronizes the view to that store on each update.","created_at":"2016-03-25T21:17:34Z","updated_at":"2016-03-28T18:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aa7b1bba2cc1bd8a9137cdd6ee071362e268e0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vega/lyra/pulls/310/commits","review_comments_url":"https://api.github.com/repos/vega/lyra/pulls/310/comments","review_comment_url":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/lyra/issues/310/comments","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/2d5767f1eb73253f71e923b8c89b3303eb83f065","head":{"label":"vega:move-signas-to-redux-store","ref":"move-signas-to-redux-store","sha":"2d5767f1eb73253f71e923b8c89b3303eb83f065","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":6179334,"name":"lyra","full_name":"vega/lyra","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":false,"url":"https://api.github.com/repos/vega/lyra","forks_url":"https://api.github.com/repos/vega/lyra/forks","keys_url":"https://api.github.com/repos/vega/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/lyra/teams","hooks_url":"https://api.github.com/repos/vega/lyra/hooks","issue_events_url":"https://api.github.com/repos/vega/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/vega/lyra/events","assignees_url":"https://api.github.com/repos/vega/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/vega/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/vega/lyra/tags","blobs_url":"https://api.github.com/repos/vega/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/lyra/languages","stargazers_url":"https://api.github.com/repos/vega/lyra/stargazers","contributors_url":"https://api.github.com/repos/vega/lyra/contributors","subscribers_url":"https://api.github.com/repos/vega/lyra/subscribers","subscription_url":"https://api.github.com/repos/vega/lyra/subscription","commits_url":"https://api.github.com/repos/vega/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/vega/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/lyra/merges","archive_url":"https://api.github.com/repos/vega/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/lyra/downloads","issues_url":"https://api.github.com/repos/vega/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/vega/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/lyra/labels{/name}","releases_url":"https://api.github.com/repos/vega/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/vega/lyra/deployments","created_at":"2012-10-11T19:16:35Z","updated_at":"2016-03-26T04:11:29Z","pushed_at":"2016-03-28T17:41:12Z","git_url":"git://github.com/vega/lyra.git","ssh_url":"git@github.com:vega/lyra.git","clone_url":"https://github.com/vega/lyra.git","svn_url":"https://github.com/vega/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7575,"stargazers_count":575,"watchers_count":575,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"open_issues_count":53,"forks":102,"open_issues":53,"watchers":575,"default_branch":"lyra2"}},"base":{"label":"vega:lyra2","ref":"lyra2","sha":"0947f11c7c1804544ca384944cc29eb8aaf89655","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":6179334,"name":"lyra","full_name":"vega/lyra","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/lyra","description":"An interactive, graphical Visualization Design Environment (VDE)","fork":false,"url":"https://api.github.com/repos/vega/lyra","forks_url":"https://api.github.com/repos/vega/lyra/forks","keys_url":"https://api.github.com/repos/vega/lyra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/lyra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/lyra/teams","hooks_url":"https://api.github.com/repos/vega/lyra/hooks","issue_events_url":"https://api.github.com/repos/vega/lyra/issues/events{/number}","events_url":"https://api.github.com/repos/vega/lyra/events","assignees_url":"https://api.github.com/repos/vega/lyra/assignees{/user}","branches_url":"https://api.github.com/repos/vega/lyra/branches{/branch}","tags_url":"https://api.github.com/repos/vega/lyra/tags","blobs_url":"https://api.github.com/repos/vega/lyra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/lyra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/lyra/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/lyra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/lyra/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/lyra/languages","stargazers_url":"https://api.github.com/repos/vega/lyra/stargazers","contributors_url":"https://api.github.com/repos/vega/lyra/contributors","subscribers_url":"https://api.github.com/repos/vega/lyra/subscribers","subscription_url":"https://api.github.com/repos/vega/lyra/subscription","commits_url":"https://api.github.com/repos/vega/lyra/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/lyra/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/lyra/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/lyra/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/lyra/contents/{+path}","compare_url":"https://api.github.com/repos/vega/lyra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/lyra/merges","archive_url":"https://api.github.com/repos/vega/lyra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/lyra/downloads","issues_url":"https://api.github.com/repos/vega/lyra/issues{/number}","pulls_url":"https://api.github.com/repos/vega/lyra/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/lyra/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/lyra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/lyra/labels{/name}","releases_url":"https://api.github.com/repos/vega/lyra/releases{/id}","deployments_url":"https://api.github.com/repos/vega/lyra/deployments","created_at":"2012-10-11T19:16:35Z","updated_at":"2016-03-26T04:11:29Z","pushed_at":"2016-03-28T17:41:12Z","git_url":"git://github.com/vega/lyra.git","ssh_url":"git@github.com:vega/lyra.git","clone_url":"https://github.com/vega/lyra.git","svn_url":"https://github.com/vega/lyra","homepage":"http://idl.cs.washington.edu/projects/lyra/","size":7575,"stargazers_count":575,"watchers_count":575,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":102,"mirror_url":null,"open_issues_count":53,"forks":102,"open_issues":53,"watchers":575,"default_branch":"lyra2"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/lyra/pulls/310"},"html":{"href":"https://github.com/vega/lyra/pull/310"},"issue":{"href":"https://api.github.com/repos/vega/lyra/issues/310"},"comments":{"href":"https://api.github.com/repos/vega/lyra/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/lyra/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/lyra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/lyra/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/vega/lyra/statuses/2d5767f1eb73253f71e923b8c89b3303eb83f065"}}}}