{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/partner-contact/issues/362","repository_url":"https://api.github.com/repos/OCA/partner-contact","labels_url":"https://api.github.com/repos/OCA/partner-contact/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/OCA/partner-contact/issues/362/comments","events_url":"https://api.github.com/repos/OCA/partner-contact/issues/362/events","html_url":"https://github.com/OCA/partner-contact/pull/362","id":196664864,"number":362,"title":"[IMP] partner_firstname: fix for address 'type' ","user":{"login":"mmuch","id":22069454,"avatar_url":"https://avatars.githubusercontent.com/u/22069454?v=3","gravatar_id":"","url":"https://api.github.com/users/mmuch","html_url":"https://github.com/mmuch","followers_url":"https://api.github.com/users/mmuch/followers","following_url":"https://api.github.com/users/mmuch/following{/other_user}","gists_url":"https://api.github.com/users/mmuch/gists{/gist_id}","starred_url":"https://api.github.com/users/mmuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmuch/subscriptions","organizations_url":"https://api.github.com/users/mmuch/orgs","repos_url":"https://api.github.com/users/mmuch/repos","events_url":"https://api.github.com/users/mmuch/events{/privacy}","received_events_url":"https://api.github.com/users/mmuch/received_events","type":"User","site_admin":false},"labels":[{"id":121861061,"url":"https://api.github.com/repos/OCA/partner-contact/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OCA/partner-contact/milestones/4","html_url":"https://github.com/OCA/partner-contact/milestone/4","labels_url":"https://api.github.com/repos/OCA/partner-contact/milestones/4/labels","id":1354371,"number":4,"title":"9.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":31,"state":"open","created_at":"2015-10-14T00:32:28Z","updated_at":"2016-12-20T13:38:09Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-12-20T12:49:39Z","updated_at":"2016-12-20T16:38:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/partner-contact/pulls/362","html_url":"https://github.com/OCA/partner-contact/pull/362","diff_url":"https://github.com/OCA/partner-contact/pull/362.diff","patch_url":"https://github.com/OCA/partner-contact/pull/362.patch"},"body":"[IMP] partner_firstname: name, firstname and lastname are only required if address field 'type' is of type contact.\r\n\r\nIn many cases addresses don't necessarily have a first- or last-name. \r\nFor example in the case of delivery addresses, required fields are not needed."},"comment":{"url":"https://api.github.com/repos/OCA/partner-contact/issues/comments/268291627","html_url":"https://github.com/OCA/partner-contact/pull/362#issuecomment-268291627","issue_url":"https://api.github.com/repos/OCA/partner-contact/issues/362","id":268291627,"user":{"login":"rafaelbn","id":8736623,"avatar_url":"https://avatars.githubusercontent.com/u/8736623?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelbn","html_url":"https://github.com/rafaelbn","followers_url":"https://api.github.com/users/rafaelbn/followers","following_url":"https://api.github.com/users/rafaelbn/following{/other_user}","gists_url":"https://api.github.com/users/rafaelbn/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelbn/subscriptions","organizations_url":"https://api.github.com/users/rafaelbn/orgs","repos_url":"https://api.github.com/users/rafaelbn/repos","events_url":"https://api.github.com/users/rafaelbn/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelbn/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T16:38:28Z","updated_at":"2016-12-20T16:38:28Z","body":"I understand, but the IMP is not correct (introduce a BUG), because in Odoo, `name` is required and after this PR you allow to create contacts with empty `name`\r\n\r\nThis is a usability issue maybe. But this PR is not correct.\r\n\r\n![2016-12-20_17-27-49](https://cloud.githubusercontent.com/assets/8736623/21359024/09509a9a-c6db-11e6-96c9-bda61be577f4.png)\r\n"}}
{"actor":{"display_login":"rafaelbn"}}