{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/67861967","id":67861967,"diff_hunk":"@@ -129,21 +129,52 @@ def unmask\n     systemctl_change_enable(:unmask)\n   end\n \n-  def restartcmd\n-    [command(:systemctl), \"restart\", @resource[:name]]\n-  end\n-\n   def startcmd\n     self.unmask\n     [command(:systemctl), \"start\", @resource[:name]]\n   end\n \n+  def restartcmd\n+    [command(:systemctl), \"restart\", @resource[:name]]\n+  end","path":"lib/puppet/provider/service/systemd.rb","position":15,"original_position":15,"commit_id":"d527705c73a4d92b9da9dd823f1a1522a444401c","original_commit_id":"d527705c73a4d92b9da9dd823f1a1522a444401c","user":{"login":"igalic","id":497249,"avatar_url":"https://avatars.githubusercontent.com/u/497249?v=3","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"body":"this seems unnecessary.","created_at":"2016-06-21T12:56:06Z","updated_at":"2016-06-21T12:56:06Z","html_url":"https://github.com/puppetlabs/puppet/pull/5033#discussion_r67861967","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/67861967"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5033#discussion_r67861967"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033","id":74440016,"html_url":"https://github.com/puppetlabs/puppet/pull/5033","diff_url":"https://github.com/puppetlabs/puppet/pull/5033.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5033.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5033","number":5033,"state":"open","locked":false,"title":"(PUP-5604) Journald on failure in Systemd","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"body":"* Braindump of ideas\r\n\r\nThis is a first run at running journald on failure to get full logs. Bit hacky, and I'm assuming there's a cleaner way of doing it but wanted to get some eyes on 👀 \r\n\r\nThe ideas from this are working as an extracted T/P: https://github.com/petems/petems-systemd_logs\r\n\r\n\r\nError before:\r\n> Error: Could not start Service[foo]: Execution of '/usr/bin/systemctl start foo' returned 6: Failed to start foo.service: Unit foo.service failed to load: Invalid argument. See system logs and 'systemctl status foo.service' for details.\r\n\r\nError after:\r\n> Error: Systemd start for foo failed:journalctl log for foo: -- Logs begin at Mon 2016-06-20 12:07:17 UTC, end at Mon 2016-06-20 12:08:06 UTC. --\r\nJun 20 12:08:06 centos-7-x64 systemd[1]: foo.service lacks both ExecStart= and ExecStop= setting. Refusing.\r\nJun 20 12:08:06 centos-7-x64 systemd[1]: foo.service lacks both ExecStart= and ExecStop= setting. Refusing.\r\n","created_at":"2016-06-20T13:06:44Z","updated_at":"2016-06-21T12:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a74c1cba76e78b299c467c2af4f4fd339917689f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5033/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/d527705c73a4d92b9da9dd823f1a1522a444401c","head":{"label":"petems:PUP-5604-show_journald_on_systemd_failure","ref":"PUP-5604-show_journald_on_systemd_failure","sha":"d527705c73a4d92b9da9dd823f1a1522a444401c","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"repo":{"id":16104292,"name":"puppet","full_name":"petems/puppet","owner":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petems/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/petems/puppet","forks_url":"https://api.github.com/repos/petems/puppet/forks","keys_url":"https://api.github.com/repos/petems/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petems/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petems/puppet/teams","hooks_url":"https://api.github.com/repos/petems/puppet/hooks","issue_events_url":"https://api.github.com/repos/petems/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/petems/puppet/events","assignees_url":"https://api.github.com/repos/petems/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/petems/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/petems/puppet/tags","blobs_url":"https://api.github.com/repos/petems/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petems/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petems/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/petems/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petems/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/petems/puppet/languages","stargazers_url":"https://api.github.com/repos/petems/puppet/stargazers","contributors_url":"https://api.github.com/repos/petems/puppet/contributors","subscribers_url":"https://api.github.com/repos/petems/puppet/subscribers","subscription_url":"https://api.github.com/repos/petems/puppet/subscription","commits_url":"https://api.github.com/repos/petems/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/petems/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/petems/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/petems/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/petems/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/petems/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petems/puppet/merges","archive_url":"https://api.github.com/repos/petems/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petems/puppet/downloads","issues_url":"https://api.github.com/repos/petems/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/petems/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/petems/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/petems/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petems/puppet/labels{/name}","releases_url":"https://api.github.com/repos/petems/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/petems/puppet/deployments","created_at":"2014-01-21T14:10:44Z","updated_at":"2014-06-02T15:40:07Z","pushed_at":"2016-06-20T21:54:11Z","git_url":"git://github.com/petems/puppet.git","ssh_url":"git@github.com:petems/puppet.git","clone_url":"https://github.com/petems/puppet.git","svn_url":"https://github.com/petems/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":52211,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"16d44423c317094263eee017bbb0d8c02e7fca68","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-06-19T07:29:46Z","pushed_at":"2016-06-21T00:30:20Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":80867,"stargazers_count":4018,"watchers_count":4018,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1666,"mirror_url":null,"open_issues_count":45,"forks":1666,"open_issues":45,"watchers":4018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5033"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5033"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5033/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5033/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/d527705c73a4d92b9da9dd823f1a1522a444401c"}}}}
{"actor":{"display_login":"igalic"}}