{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/5279","repository_url":"https://api.github.com/repos/chef/chef","labels_url":"https://api.github.com/repos/chef/chef/issues/5279/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/5279/comments","events_url":"https://api.github.com/repos/chef/chef/issues/5279/events","html_url":"https://github.com/chef/chef/pull/5279","id":174844818,"number":5279,"title":"use threads to workaround Process.spawn buginess in chef-solo unit test","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-02T20:47:35Z","updated_at":"2016-09-06T18:39:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/5279","html_url":"https://github.com/chef/chef/pull/5279","diff_url":"https://github.com/chef/chef/pull/5279.diff","patch_url":"https://github.com/chef/chef/pull/5279.patch"},"body":"there's a WONTFIX closed bug in ruby-lang.org on this bug:\r\n\r\nhttps://bugs.ruby-lang.org/issues/10583\r\n\r\nthey seem to be favoring speed over usability with the result\r\nthat if you're doing I/O synchronization (like our run_lock?)\r\ninside of a Process.spawn chain like this that you have to\r\nwrap the spawn calls inside of threads.\r\n\r\nprobably a best practice to wrap every spawn call with a\r\nThread.\r\n\r\nthis probably also explains why we had the silly-long 20\r\nsecond timeout?\r\n\r\nSigned-off-by: Lamont Granquist <lamont@scriptkiddie.org>"},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/245047751","html_url":"https://github.com/chef/chef/pull/5279#issuecomment-245047751","issue_url":"https://api.github.com/repos/chef/chef/issues/5279","id":245047751,"user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T18:39:33Z","updated_at":"2016-09-06T18:39:33Z","body":"I'm 👍.  Mixing threads+fork is usually something I'm wary of (maybe urban legends?) but this is in test code and we we are doing pretty straightforward."}}
{"actor":{"display_login":"stevendanna"}}