{"action":"created","issue":{"url":"https://api.github.com/repos/novoda/spikes/issues/175","repository_url":"https://api.github.com/repos/novoda/spikes","labels_url":"https://api.github.com/repos/novoda/spikes/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/novoda/spikes/issues/175/comments","events_url":"https://api.github.com/repos/novoda/spikes/issues/175/events","html_url":"https://github.com/novoda/spikes/pull/175","id":186752421,"number":175,"title":"Drop cap fixes","user":{"login":"Mecharyry","id":3380092,"avatar_url":"https://avatars.githubusercontent.com/u/3380092?v=3","gravatar_id":"","url":"https://api.github.com/users/Mecharyry","html_url":"https://github.com/Mecharyry","followers_url":"https://api.github.com/users/Mecharyry/followers","following_url":"https://api.github.com/users/Mecharyry/following{/other_user}","gists_url":"https://api.github.com/users/Mecharyry/gists{/gist_id}","starred_url":"https://api.github.com/users/Mecharyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mecharyry/subscriptions","organizations_url":"https://api.github.com/users/Mecharyry/orgs","repos_url":"https://api.github.com/users/Mecharyry/repos","events_url":"https://api.github.com/users/Mecharyry/events{/privacy}","received_events_url":"https://api.github.com/users/Mecharyry/received_events","type":"User","site_admin":false},"labels":[{"id":473802027,"url":"https://api.github.com/repos/novoda/spikes/labels/DropCap","name":"DropCap","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-02T09:40:18Z","updated_at":"2016-11-04T11:40:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/novoda/spikes/pulls/175","html_url":"https://github.com/novoda/spikes/pull/175","diff_url":"https://github.com/novoda/spikes/pull/175.diff","patch_url":"https://github.com/novoda/spikes/pull/175.patch"},"body":"#### Problem\r\nWhen editing the size of the DropCap and changing the length of the text input it is possible that the DropCap will overlap the copy text (below).\r\n\r\n![drop_cap](https://cloud.githubusercontent.com/assets/3380092/19923174/1f8b13bc-a0de-11e6-908b-e2a0d994bc48.jpg)\r\n\r\nThe second problem occurs when editing the text to display. I wrongly assumed that a call to `requestLayout` would perform a `measure` and `draw` call...which it does...but...apparently a `requestLayout` is always paired with a call to `invalidate`. \r\n\r\n#### Solution\r\nThe overlapping text was a simple case of ensuring that the calculation to determine how far the DropCap should span for is calculated for each measure where the `DropCapStaticLayout` is remeasured.\r\n\r\nWhenever performing any task that requires a remeasure and a redraw we should have the pair of calls `requestLayout` and `invalidate`. When performing a task that requires just a redraw then we should only use `invalidate`."},"comment":{"url":"https://api.github.com/repos/novoda/spikes/issues/comments/258410428","html_url":"https://github.com/novoda/spikes/pull/175#issuecomment-258410428","issue_url":"https://api.github.com/repos/novoda/spikes/issues/175","id":258410428,"user":{"login":"eduardb","id":2426348,"avatar_url":"https://avatars.githubusercontent.com/u/2426348?v=3","gravatar_id":"","url":"https://api.github.com/users/eduardb","html_url":"https://github.com/eduardb","followers_url":"https://api.github.com/users/eduardb/followers","following_url":"https://api.github.com/users/eduardb/following{/other_user}","gists_url":"https://api.github.com/users/eduardb/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardb/subscriptions","organizations_url":"https://api.github.com/users/eduardb/orgs","repos_url":"https://api.github.com/users/eduardb/repos","events_url":"https://api.github.com/users/eduardb/events{/privacy}","received_events_url":"https://api.github.com/users/eduardb/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T11:40:19Z","updated_at":"2016-11-04T11:40:19Z","body":"I see. But is this behavior specified anywhere? I didn't know about it, and maybe other users of the library will be confused about it too. So either this should be specified in a highly visible place, so it's hard not to see it, but I would like it more if I am given the choice to have this behavior or to always show the DropCap, even for short texts."}}
{"actor":{"display_login":"eduardb"}}