{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/55839285","id":55839285,"diff_hunk":"@@ -243,27 +270,36 @@ protected function _authRequired(Controller $controller)\n \n             if (in_array($this->request->params['action'], $requireAuth) || $requireAuth == ['*']) {\n                 if (!isset($controller->request->data['_Token'])) {\n-                    if (!$this->blackHole($controller, 'auth')) {\n-                        return false;\n-                    }\n+                    throw new AuthSecurityException(sprintf('\\'%s\\' was not found in request data.', '_Token'));","path":"src/Controller/Component/SecurityComponent.php","position":120,"original_position":120,"commit_id":"9b8e149795e0c07c08c0d2f7a8c4822b97f8598e","original_commit_id":"9b8e149795e0c07c08c0d2f7a8c4822b97f8598e","user":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"body":"Why are you sprintf() ing static strings?","created_at":"2016-03-11T14:59:05Z","updated_at":"2016-03-11T14:59:05Z","html_url":"https://github.com/cakephp/cakephp/pull/8449#discussion_r55839285","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/8449","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/55839285"},"html":{"href":"https://github.com/cakephp/cakephp/pull/8449#discussion_r55839285"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/8449"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/8449","id":62525286,"html_url":"https://github.com/cakephp/cakephp/pull/8449","diff_url":"https://github.com/cakephp/cakephp/pull/8449.diff","patch_url":"https://github.com/cakephp/cakephp/pull/8449.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/8449","number":8449,"state":"open","locked":false,"title":"Feature Debug SecurityComponent","user":{"login":"steinkel","id":151761,"avatar_url":"https://avatars.githubusercontent.com/u/151761?v=3","gravatar_id":"","url":"https://api.github.com/users/steinkel","html_url":"https://github.com/steinkel","followers_url":"https://api.github.com/users/steinkel/followers","following_url":"https://api.github.com/users/steinkel/following{/other_user}","gists_url":"https://api.github.com/users/steinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/steinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinkel/subscriptions","organizations_url":"https://api.github.com/users/steinkel/orgs","repos_url":"https://api.github.com/users/steinkel/repos","events_url":"https://api.github.com/users/steinkel/events{/privacy}","received_events_url":"https://api.github.com/users/steinkel/received_events","type":"User","site_admin":false},"body":"SecurityComponent provides no details about the reason a specific request is being \"blackholed\". This PR aims to fix this and let the developer know the error details, like a missing field in POST, a tampered hidden filed value, or issues with the (now about to be deprecated) mysterious requireAuth config.\r\n\r\nInterface with blackHoleCallback is preserved and the whole feature is available only in debug mode. ","created_at":"2016-03-11T10:39:48Z","updated_at":"2016-03-11T14:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a29d508dcd8a03ff789c93f007656ebfef7b145a","assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/82","html_url":"https://github.com/cakephp/cakephp/milestones/3.2.5","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/82/labels","id":1625052,"number":82,"title":"3.2.5","description":"Bugfixes and minor optimizations for 3.2.x","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":18,"state":"open","created_at":"2016-03-07T01:54:50Z","updated_at":"2016-03-11T13:43:33Z","due_on":"2016-03-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/8449/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/8449/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/8449/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/9b8e149795e0c07c08c0d2f7a8c4822b97f8598e","head":{"label":"CakeDC:feature/debug-security","ref":"feature/debug-security","sha":"9b8e149795e0c07c08c0d2f7a8c4822b97f8598e","user":{"login":"CakeDC","id":204531,"avatar_url":"https://avatars.githubusercontent.com/u/204531?v=3","gravatar_id":"","url":"https://api.github.com/users/CakeDC","html_url":"https://github.com/CakeDC","followers_url":"https://api.github.com/users/CakeDC/followers","following_url":"https://api.github.com/users/CakeDC/following{/other_user}","gists_url":"https://api.github.com/users/CakeDC/gists{/gist_id}","starred_url":"https://api.github.com/users/CakeDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CakeDC/subscriptions","organizations_url":"https://api.github.com/users/CakeDC/orgs","repos_url":"https://api.github.com/users/CakeDC/repos","events_url":"https://api.github.com/users/CakeDC/events{/privacy}","received_events_url":"https://api.github.com/users/CakeDC/received_events","type":"Organization","site_admin":false},"repo":{"id":47278896,"name":"cakephp","full_name":"CakeDC/cakephp","owner":{"login":"CakeDC","id":204531,"avatar_url":"https://avatars.githubusercontent.com/u/204531?v=3","gravatar_id":"","url":"https://api.github.com/users/CakeDC","html_url":"https://github.com/CakeDC","followers_url":"https://api.github.com/users/CakeDC/followers","following_url":"https://api.github.com/users/CakeDC/following{/other_user}","gists_url":"https://api.github.com/users/CakeDC/gists{/gist_id}","starred_url":"https://api.github.com/users/CakeDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CakeDC/subscriptions","organizations_url":"https://api.github.com/users/CakeDC/orgs","repos_url":"https://api.github.com/users/CakeDC/repos","events_url":"https://api.github.com/users/CakeDC/events{/privacy}","received_events_url":"https://api.github.com/users/CakeDC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CakeDC/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/CakeDC/cakephp","forks_url":"https://api.github.com/repos/CakeDC/cakephp/forks","keys_url":"https://api.github.com/repos/CakeDC/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CakeDC/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CakeDC/cakephp/teams","hooks_url":"https://api.github.com/repos/CakeDC/cakephp/hooks","issue_events_url":"https://api.github.com/repos/CakeDC/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/CakeDC/cakephp/events","assignees_url":"https://api.github.com/repos/CakeDC/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/CakeDC/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/CakeDC/cakephp/tags","blobs_url":"https://api.github.com/repos/CakeDC/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CakeDC/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CakeDC/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/CakeDC/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CakeDC/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/CakeDC/cakephp/languages","stargazers_url":"https://api.github.com/repos/CakeDC/cakephp/stargazers","contributors_url":"https://api.github.com/repos/CakeDC/cakephp/contributors","subscribers_url":"https://api.github.com/repos/CakeDC/cakephp/subscribers","subscription_url":"https://api.github.com/repos/CakeDC/cakephp/subscription","commits_url":"https://api.github.com/repos/CakeDC/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/CakeDC/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/CakeDC/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/CakeDC/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/CakeDC/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/CakeDC/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CakeDC/cakephp/merges","archive_url":"https://api.github.com/repos/CakeDC/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CakeDC/cakephp/downloads","issues_url":"https://api.github.com/repos/CakeDC/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/CakeDC/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/CakeDC/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/CakeDC/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CakeDC/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/CakeDC/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/CakeDC/cakephp/deployments","created_at":"2015-12-02T18:07:08Z","updated_at":"2016-03-08T19:06:35Z","pushed_at":"2016-03-11T13:26:00Z","git_url":"git://github.com/CakeDC/cakephp.git","ssh_url":"git@github.com:CakeDC/cakephp.git","clone_url":"https://github.com/CakeDC/cakephp.git","svn_url":"https://github.com/CakeDC/cakephp","homepage":"http://cakephp.org","size":68060,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"bf03bfe9834d564b615cec6934a21056b1f2b1a2","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-03-11T05:16:21Z","pushed_at":"2016-03-11T13:26:01Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":100958,"stargazers_count":6332,"watchers_count":6332,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2913,"mirror_url":null,"open_issues_count":183,"forks":2913,"open_issues":183,"watchers":6332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/8449"},"html":{"href":"https://github.com/cakephp/cakephp/pull/8449"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/8449"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/8449/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/8449/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/8449/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/9b8e149795e0c07c08c0d2f7a8c4822b97f8598e"}}}}