{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/53290854","id":53290854,"diff_hunk":"@@ -394,6 +394,7 @@ class LogisticRegressionSuite extends SparkFunSuite with MLlibTestSparkContext w\n     lrA.optimizer.setNumIterations(numIteration)\n     val lrB = new LogisticRegressionWithLBFGS().setIntercept(true).setFeatureScaling(false)\n     lrB.optimizer.setNumIterations(numIteration)\n+    lrB.optimizer.setRegParam(0.001)","path":"mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala","position":4,"original_position":4,"commit_id":"b973a0e9ae6e0a48ea875e5c0173760ce245a6d6","original_commit_id":"b973a0e9ae6e0a48ea875e5c0173760ce245a6d6","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"body":"If we do not penalize, it will not yield the same result in the scaled space due to poor convergence rate.","created_at":"2016-02-18T09:41:22Z","updated_at":"2016-02-18T09:41:22Z","html_url":"https://github.com/apache/spark/pull/11247#discussion_r53290854","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/11247","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/53290854"},"html":{"href":"https://github.com/apache/spark/pull/11247#discussion_r53290854"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/11247"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/11247","id":59757270,"html_url":"https://github.com/apache/spark/pull/11247","diff_url":"https://github.com/apache/spark/pull/11247.diff","patch_url":"https://github.com/apache/spark/pull/11247.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/11247","number":11247,"state":"open","locked":false,"title":"[SPARK-13372] [ML] Fix LogisticRegression when standardization = false && regParam = 0.0","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"body":"At #7080 we implemented disable feature scaling by penalizing each component differently. But if users train model without penalizing(set ```regParam = 0.0```), ```LogisticRegression``` with ```standardization = false``` will run the same route as ```standardization = true``` which is incorrect. This PR will fix this issue.\r\n\r\nWe can check the test case ```binary logistic regression without intercept without regularization```.\r\nBefore this fix, it will converged after 16 iterations  for both ```standardization = true``` and ```standardization = false```(Because they run the same code route).\r\nAfter this fix, it will converged after 16 iterations for  ```standardization = true``` and 14 iterations for  ```standardization = false```.\r\n\r\n```LinearRegression``` may have the same issue. If this is accepted, I can send another PR to fix that.\r\n\r\ncc @dbtsai @mengxr @holdenk \r\n\r\n\r\n","created_at":"2016-02-18T06:41:58Z","updated_at":"2016-02-18T09:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa856c5edccc65ee732a551b4082b14060a4f18c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/11247/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/11247/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/11247/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/b973a0e9ae6e0a48ea875e5c0173760ce245a6d6","head":{"label":"yanboliang:spark-13372","ref":"spark-13372","sha":"b973a0e9ae6e0a48ea875e5c0173760ce245a6d6","user":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"repo":{"id":21890948,"name":"spark","full_name":"yanboliang/spark","owner":{"login":"yanboliang","id":1962026,"avatar_url":"https://avatars.githubusercontent.com/u/1962026?v=3","gravatar_id":"","url":"https://api.github.com/users/yanboliang","html_url":"https://github.com/yanboliang","followers_url":"https://api.github.com/users/yanboliang/followers","following_url":"https://api.github.com/users/yanboliang/following{/other_user}","gists_url":"https://api.github.com/users/yanboliang/gists{/gist_id}","starred_url":"https://api.github.com/users/yanboliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanboliang/subscriptions","organizations_url":"https://api.github.com/users/yanboliang/orgs","repos_url":"https://api.github.com/users/yanboliang/repos","events_url":"https://api.github.com/users/yanboliang/events{/privacy}","received_events_url":"https://api.github.com/users/yanboliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanboliang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yanboliang/spark","forks_url":"https://api.github.com/repos/yanboliang/spark/forks","keys_url":"https://api.github.com/repos/yanboliang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanboliang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanboliang/spark/teams","hooks_url":"https://api.github.com/repos/yanboliang/spark/hooks","issue_events_url":"https://api.github.com/repos/yanboliang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yanboliang/spark/events","assignees_url":"https://api.github.com/repos/yanboliang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yanboliang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yanboliang/spark/tags","blobs_url":"https://api.github.com/repos/yanboliang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanboliang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanboliang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanboliang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanboliang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yanboliang/spark/languages","stargazers_url":"https://api.github.com/repos/yanboliang/spark/stargazers","contributors_url":"https://api.github.com/repos/yanboliang/spark/contributors","subscribers_url":"https://api.github.com/repos/yanboliang/spark/subscribers","subscription_url":"https://api.github.com/repos/yanboliang/spark/subscription","commits_url":"https://api.github.com/repos/yanboliang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanboliang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanboliang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanboliang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanboliang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yanboliang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanboliang/spark/merges","archive_url":"https://api.github.com/repos/yanboliang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanboliang/spark/downloads","issues_url":"https://api.github.com/repos/yanboliang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yanboliang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yanboliang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yanboliang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanboliang/spark/labels{/name}","releases_url":"https://api.github.com/repos/yanboliang/spark/releases{/id}","deployments_url":"https://api.github.com/repos/yanboliang/spark/deployments","created_at":"2014-07-16T07:24:13Z","updated_at":"2015-05-06T09:49:33Z","pushed_at":"2016-02-18T09:35:14Z","git_url":"git://github.com/yanboliang/spark.git","ssh_url":"git@github.com:yanboliang/spark.git","clone_url":"https://github.com/yanboliang/spark.git","svn_url":"https://github.com/yanboliang/spark","homepage":null,"size":137314,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"892b2dd6dd00d2088c75ab3c8443e8b3e44e5803","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-02-18T07:20:14Z","pushed_at":"2016-02-18T09:35:15Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":414453,"stargazers_count":7474,"watchers_count":7474,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6802,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":382,"forks":6802,"open_issues":382,"watchers":7474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/11247"},"html":{"href":"https://github.com/apache/spark/pull/11247"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/11247"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/11247/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/11247/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/11247/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/b973a0e9ae6e0a48ea875e5c0173760ce245a6d6"}}}}