{"action":"created","issue":{"url":"https://api.github.com/repos/apcera/libretto/issues/11","repository_url":"https://api.github.com/repos/apcera/libretto","labels_url":"https://api.github.com/repos/apcera/libretto/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/apcera/libretto/issues/11/comments","events_url":"https://api.github.com/repos/apcera/libretto/issues/11/events","html_url":"https://github.com/apcera/libretto/pull/11","id":141527945,"number":11,"title":"virtualmachine/vmrun/vm.go: fix several functions around getting the guest IP address.","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-17T09:31:40Z","updated_at":"2016-03-18T23:12:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apcera/libretto/pulls/11","html_url":"https://github.com/apcera/libretto/pull/11","diff_url":"https://github.com/apcera/libretto/pull/11.diff","patch_url":"https://github.com/apcera/libretto/pull/11.patch"},"body":"The function requestIPs was not yielding an error when the vmware tools were\r\nnot installed on the guest, causing the provisioning process to time out\r\nwithout much more information presented to the requestor.\r\n\r\nAdditionally, there were a number of positions up the the stack where this\r\ncould not be propagated due to return signatures and so on. I modified this as\r\nwell to propagate errors up the stack.\r\n\r\nSigned-off-by: Erik Hollensbe <erik+github@hollensbe.org>"},"comment":{"url":"https://api.github.com/repos/apcera/libretto/issues/comments/198577518","html_url":"https://github.com/apcera/libretto/pull/11#issuecomment-198577518","issue_url":"https://api.github.com/repos/apcera/libretto/issues/11","id":198577518,"user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T23:12:04Z","updated_at":"2016-03-18T23:12:04Z","body":"OK; I'll try to get to this later tonight. Thanks for doing the testing \nwork.\n\nOn 18 Mar 2016, at 16:10, Preet Bhinder wrote:\n\n> Tried disabling tools on a VM on workstation and checking for the exit \n> code. Couple of problems with this code, it won't work on Windows.\n>\n> `WaitStatus` is a struct on Windows, it has a `ExitStatus` method \n> defined on it which has a 32bit `ExitCode` field. When tools isn't \n> running then the exit code is `0XFFFFFFFF`. I'd suggest adding a \n> `GetExitCode` function to vm_darwin, vm_linux and vm_windows which \n> returns the right code depending on the platform.\n>\n> Also, this needs a rebase against master.\n>\n> ---\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/apcera/libretto/pull/11#issuecomment-198576911\n"}}