{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/62819286","id":62819286,"diff_hunk":"@@ -0,0 +1,102 @@\n+var cdb = require('cartodb.js');\n+var InfowindowView = require('./infowindow/infowindow-content-view');\n+var TooltipView = require('./infowindow/infowindow-content-view');\n+var createTextLabelsTabPane = require('../../../components/tab-pane/create-text-labels-tab-pane');\n+var TabPaneTemplate = require('../../tab-pane-submenu.tpl');\n+\n+module.exports = cdb.core.View.extend({\n+\n+  initialize: function (opts) {\n+    if (!opts.layerDefinitionModel) throw new Error('Layer definition is required');\n+    if (!opts.querySchemaModel) throw new Error('querySchemaModel is required');\n+    this.layerDefinitionModel = opts.layerDefinitionModel;\n+    this._querySchemaModel = opts.querySchemaModel;\n+    this._layerInfowindowModel = this.layerDefinitionModel.infowindowModel;\n+    this._layerTooltipModel = this.layerDefinitionModel.tooltipModel;\n+\n+    if (this._querySchemaModel.querySchemaModel.get('status') !== 'fetched') {\n+      // status can be: fetched, unavailable, fetching\n+      this.listenTo(this._querySchemaModel.querySchemaModel, 'change:status', this.render);","path":"lib/assets/javascripts/cartodb3/editor/layers/layer-content-views/infowindow-view.js","position":null,"original_position":19,"commit_id":"98ed53692851320186375d8ddde3948252f8fc61","original_commit_id":"3397a3d594e865417b6e74a1891b4ccb4a108402","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars.githubusercontent.com/u/36676?v=3","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"body":"indeed!","created_at":"2016-05-11T09:43:10Z","updated_at":"2016-05-11T09:43:10Z","html_url":"https://github.com/CartoDB/cartodb/pull/7175#discussion_r62819286","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/62819286"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/7175#discussion_r62819286"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175","id":66977790,"html_url":"https://github.com/CartoDB/cartodb/pull/7175","diff_url":"https://github.com/CartoDB/cartodb/pull/7175.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/7175.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/7175","number":7175,"state":"open","locked":false,"title":"infowindows: first commit","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars.githubusercontent.com/u/36676?v=3","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"body":"CR @xavijam \r\n\r\ncc @javierarce \r\n\r\nfirst commit to confirm file structure and carry on from here\r\n\r\n![screen shot 2016-04-19 at 10 17 24](https://cloud.githubusercontent.com/assets/36676/14632371/86efd698-0618-11e6-9908-65bfd3e5b3f8.png)\r\n\r\nworking with selects now, to be migrated to carousel, and persisted\r\n","created_at":"2016-04-19T08:23:07Z","updated_at":"2016-05-11T09:43:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfe865fefd43725eb58dc9e0ff2288ceb7257af7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/7175/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/98ed53692851320186375d8ddde3948252f8fc61","head":{"label":"CartoDB:infowindows3","ref":"infowindows3","sha":"98ed53692851320186375d8ddde3948252f8fc61","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-05-11T00:55:19Z","pushed_at":"2016-05-11T09:25:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://cartodb.com","size":385673,"stargazers_count":1134,"watchers_count":1134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":913,"forks":284,"open_issues":913,"watchers":1134,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"fbe5bb5abbf1f703d56262d48f0f5e1bf6975867","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-05-11T00:55:19Z","pushed_at":"2016-05-11T09:25:07Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://cartodb.com","size":385673,"stargazers_count":1134,"watchers_count":1134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":913,"forks":284,"open_issues":913,"watchers":1134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/7175"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/7175"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/7175/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/7175/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/98ed53692851320186375d8ddde3948252f8fc61"}}}}