{"action":"created","issue":{"url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/13","repository_url":"https://api.github.com/repos/ethereumjs/node-devp2p","labels_url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/13/comments","events_url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/13/events","html_url":"https://github.com/ethereumjs/node-devp2p/pull/13","id":154554908,"number":13,"title":"rewrite rlpx; inline dpt and eth","user":{"login":"fanatid","id":2633065,"avatar_url":"https://avatars.githubusercontent.com/u/2633065?v=3","gravatar_id":"","url":"https://api.github.com/users/fanatid","html_url":"https://github.com/fanatid","followers_url":"https://api.github.com/users/fanatid/followers","following_url":"https://api.github.com/users/fanatid/following{/other_user}","gists_url":"https://api.github.com/users/fanatid/gists{/gist_id}","starred_url":"https://api.github.com/users/fanatid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanatid/subscriptions","organizations_url":"https://api.github.com/users/fanatid/orgs","repos_url":"https://api.github.com/users/fanatid/repos","events_url":"https://api.github.com/users/fanatid/events{/privacy}","received_events_url":"https://api.github.com/users/fanatid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-12T18:51:53Z","updated_at":"2016-05-17T20:35:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereumjs/node-devp2p/pulls/13","html_url":"https://github.com/ethereumjs/node-devp2p/pull/13","diff_url":"https://github.com/ethereumjs/node-devp2p/pull/13.diff","patch_url":"https://github.com/ethereumjs/node-devp2p/pull/13.patch"},"body":"work in progress.."},"comment":{"url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/comments/219845444","html_url":"https://github.com/ethereumjs/node-devp2p/pull/13#issuecomment-219845444","issue_url":"https://api.github.com/repos/ethereumjs/node-devp2p/issues/13","id":219845444,"user":{"login":"wanderer","id":158211,"avatar_url":"https://avatars.githubusercontent.com/u/158211?v=3","gravatar_id":"","url":"https://api.github.com/users/wanderer","html_url":"https://github.com/wanderer","followers_url":"https://api.github.com/users/wanderer/followers","following_url":"https://api.github.com/users/wanderer/following{/other_user}","gists_url":"https://api.github.com/users/wanderer/gists{/gist_id}","starred_url":"https://api.github.com/users/wanderer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanderer/subscriptions","organizations_url":"https://api.github.com/users/wanderer/orgs","repos_url":"https://api.github.com/users/wanderer/repos","events_url":"https://api.github.com/users/wanderer/events{/privacy}","received_events_url":"https://api.github.com/users/wanderer/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T20:35:45Z","updated_at":"2016-05-17T20:35:45Z","body":"> It's hard question, in common: how much modules we should create? DPT, RLPx, ETH will be enough? How deep we should modularize?\r\n\r\nI have used the DPT several time by its self to generate stats about the network. So I think it make sense to modularize that now. As far as the subprotocols go, I'm ok inlining the packet parsing for now. If more subprotols start to utilize RLPx in the future will have to revisit then.\r\n\r\n> JSDoc? You want that docs were generated from source code?\r\n\r\nyeah it uses [Documention](https://github.com/ethereumjs/node-devp2p/blob/master/package.json#L11). "}}