{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2798","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2798/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2798/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2798/events","html_url":"https://github.com/checkstyle/checkstyle/pull/2798","id":124622291,"number":2798,"title":"Issue #1002: Add optional attribute to suppression filter","user":{"login":"liscju","id":6627878,"avatar_url":"https://avatars.githubusercontent.com/u/6627878?v=3","gravatar_id":"","url":"https://api.github.com/users/liscju","html_url":"https://github.com/liscju","followers_url":"https://api.github.com/users/liscju/followers","following_url":"https://api.github.com/users/liscju/following{/other_user}","gists_url":"https://api.github.com/users/liscju/gists{/gist_id}","starred_url":"https://api.github.com/users/liscju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liscju/subscriptions","organizations_url":"https://api.github.com/users/liscju/orgs","repos_url":"https://api.github.com/users/liscju/repos","events_url":"https://api.github.com/users/liscju/events{/privacy}","received_events_url":"https://api.github.com/users/liscju/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-01-03T01:23:52Z","updated_at":"2016-01-15T14:32:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2798","html_url":"https://github.com/checkstyle/checkstyle/pull/2798","diff_url":"https://github.com/checkstyle/checkstyle/pull/2798.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2798.patch"},"body":"This implementation lacks dealing with the fact that SuppressionsLoader.loadSuppressions doesnt throw exceptions only when the file is missing, the exceptions are thrown also when the supression file has bad structure. \r\n\r\nSo i have question what should i do: should SupressionsLoader.loadSuppressions should be refactored to throw CheckstyleException and FileNotFoundException or should i do sth else to deal with this(for example it can read from CheckstyleException msg and checks if it was matching file not found error msg, but this seems like \"Primitive Obsession\" code smell)?"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/171975740","html_url":"https://github.com/checkstyle/checkstyle/pull/2798#issuecomment-171975740","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2798","id":171975740,"user":{"login":"liscju","id":6627878,"avatar_url":"https://avatars.githubusercontent.com/u/6627878?v=3","gravatar_id":"","url":"https://api.github.com/users/liscju","html_url":"https://github.com/liscju","followers_url":"https://api.github.com/users/liscju/followers","following_url":"https://api.github.com/users/liscju/following{/other_user}","gists_url":"https://api.github.com/users/liscju/gists{/gist_id}","starred_url":"https://api.github.com/users/liscju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liscju/subscriptions","organizations_url":"https://api.github.com/users/liscju/orgs","repos_url":"https://api.github.com/users/liscju/repos","events_url":"https://api.github.com/users/liscju/events{/privacy}","received_events_url":"https://api.github.com/users/liscju/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T14:32:49Z","updated_at":"2016-01-15T14:32:49Z","body":"@romani where can i find solutions using reflection to cover such situation in project right now?"}}