{"action":"created","comment":{"url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/comments/78145552","id":78145552,"diff_hunk":"@@ -121,23 +121,13 @@ def _wrap_artifacts(self, artifacts):\n         for artifact in artifacts:\n             yield self._wrap_artifact(artifact)\n \n-    def update_objects(self, objects):\n+    def update_artifacts(self, artifacts):\n         \"\"\"\n         Updates each entry in objects to db, which must have the function\n         updated_rest_resource\n         \"\"\"\n-        update_queue = []\n-        for obj in objects:\n-            if type(obj) == Analyte:\n-                original_analyte_from_rest = ApiArtifact(self.session.api, id=obj.id)\n-                update_queue.append(obj.updated_rest_resource(original_analyte_from_rest, self.udf_map))\n-            elif type(obj) == ResultFile:\n-                # TODO: Implement\n-                pass\n-            else:\n-                raise Exception(\"Unknown type {}\".format(obj.type))\n-\n-        self.session.api.put_batch(update_queue)\n+        api_resources = [obj.api_resource for obj in artifacts]\n+        self.session.api.put_batch(api_resources)\n ","path":"clarity_ext/repository/step_repository.py","position":24,"original_position":24,"commit_id":"272a2853c233ea8a5d576c94dcdf97fffc57c7b6","original_commit_id":"272a2853c233ea8a5d576c94dcdf97fffc57c7b6","user":{"login":"withrocks","id":800390,"avatar_url":"https://avatars.githubusercontent.com/u/800390?v=3","gravatar_id":"","url":"https://api.github.com/users/withrocks","html_url":"https://github.com/withrocks","followers_url":"https://api.github.com/users/withrocks/followers","following_url":"https://api.github.com/users/withrocks/following{/other_user}","gists_url":"https://api.github.com/users/withrocks/gists{/gist_id}","starred_url":"https://api.github.com/users/withrocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/withrocks/subscriptions","organizations_url":"https://api.github.com/users/withrocks/orgs","repos_url":"https://api.github.com/users/withrocks/repos","events_url":"https://api.github.com/users/withrocks/events{/privacy}","received_events_url":"https://api.github.com/users/withrocks/received_events","type":"User","site_admin":false},"body":"It is if the domain object has ensured that the underlying resource is updated, which I do in the case of `ResultFile`s and I think all domain objects should do (take care of themselves). This can be seen by running `clarity-ext/test/integration/test_context.py:test_can_update_udfs`.\r\n\r\nIs it not being updated in the case of analytes?","created_at":"2016-09-09T08:32:47Z","updated_at":"2016-09-09T08:32:47Z","html_url":"https://github.com/Molmed/clarity-ext/pull/29#discussion_r78145552","pull_request_url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/comments/78145552"},"html":{"href":"https://github.com/Molmed/clarity-ext/pull/29#discussion_r78145552"},"pull_request":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29","id":84608744,"html_url":"https://github.com/Molmed/clarity-ext/pull/29","diff_url":"https://github.com/Molmed/clarity-ext/pull/29.diff","patch_url":"https://github.com/Molmed/clarity-ext/pull/29.patch","issue_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/29","number":29,"state":"open","locked":false,"title":"Ensure ResultFile UDFs are updated on commit","user":{"login":"withrocks","id":800390,"avatar_url":"https://avatars.githubusercontent.com/u/800390?v=3","gravatar_id":"","url":"https://api.github.com/users/withrocks","html_url":"https://github.com/withrocks","followers_url":"https://api.github.com/users/withrocks/followers","following_url":"https://api.github.com/users/withrocks/following{/other_user}","gists_url":"https://api.github.com/users/withrocks/gists{/gist_id}","starred_url":"https://api.github.com/users/withrocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/withrocks/subscriptions","organizations_url":"https://api.github.com/users/withrocks/orgs","repos_url":"https://api.github.com/users/withrocks/repos","events_url":"https://api.github.com/users/withrocks/events{/privacy}","received_events_url":"https://api.github.com/users/withrocks/received_events","type":"User","site_admin":false},"body":"Fixes LIMS-661","created_at":"2016-09-09T07:58:50Z","updated_at":"2016-09-09T08:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4c4c60db44c73e8f7e8a2c2aeb7cd795f0c868d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Molmed/clarity-ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/29/comments","statuses_url":"https://api.github.com/repos/Molmed/clarity-ext/statuses/272a2853c233ea8a5d576c94dcdf97fffc57c7b6","head":{"label":"withrocks:lims-661","ref":"lims-661","sha":"272a2853c233ea8a5d576c94dcdf97fffc57c7b6","user":{"login":"withrocks","id":800390,"avatar_url":"https://avatars.githubusercontent.com/u/800390?v=3","gravatar_id":"","url":"https://api.github.com/users/withrocks","html_url":"https://github.com/withrocks","followers_url":"https://api.github.com/users/withrocks/followers","following_url":"https://api.github.com/users/withrocks/following{/other_user}","gists_url":"https://api.github.com/users/withrocks/gists{/gist_id}","starred_url":"https://api.github.com/users/withrocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/withrocks/subscriptions","organizations_url":"https://api.github.com/users/withrocks/orgs","repos_url":"https://api.github.com/users/withrocks/repos","events_url":"https://api.github.com/users/withrocks/events{/privacy}","received_events_url":"https://api.github.com/users/withrocks/received_events","type":"User","site_admin":false},"repo":{"id":60516560,"name":"clarity-ext","full_name":"withrocks/clarity-ext","owner":{"login":"withrocks","id":800390,"avatar_url":"https://avatars.githubusercontent.com/u/800390?v=3","gravatar_id":"","url":"https://api.github.com/users/withrocks","html_url":"https://github.com/withrocks","followers_url":"https://api.github.com/users/withrocks/followers","following_url":"https://api.github.com/users/withrocks/following{/other_user}","gists_url":"https://api.github.com/users/withrocks/gists{/gist_id}","starred_url":"https://api.github.com/users/withrocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/withrocks/subscriptions","organizations_url":"https://api.github.com/users/withrocks/orgs","repos_url":"https://api.github.com/users/withrocks/repos","events_url":"https://api.github.com/users/withrocks/events{/privacy}","received_events_url":"https://api.github.com/users/withrocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/withrocks/clarity-ext","description":"Extensions for Clarity","fork":true,"url":"https://api.github.com/repos/withrocks/clarity-ext","forks_url":"https://api.github.com/repos/withrocks/clarity-ext/forks","keys_url":"https://api.github.com/repos/withrocks/clarity-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/withrocks/clarity-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/withrocks/clarity-ext/teams","hooks_url":"https://api.github.com/repos/withrocks/clarity-ext/hooks","issue_events_url":"https://api.github.com/repos/withrocks/clarity-ext/issues/events{/number}","events_url":"https://api.github.com/repos/withrocks/clarity-ext/events","assignees_url":"https://api.github.com/repos/withrocks/clarity-ext/assignees{/user}","branches_url":"https://api.github.com/repos/withrocks/clarity-ext/branches{/branch}","tags_url":"https://api.github.com/repos/withrocks/clarity-ext/tags","blobs_url":"https://api.github.com/repos/withrocks/clarity-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/withrocks/clarity-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/withrocks/clarity-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/withrocks/clarity-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/withrocks/clarity-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/withrocks/clarity-ext/languages","stargazers_url":"https://api.github.com/repos/withrocks/clarity-ext/stargazers","contributors_url":"https://api.github.com/repos/withrocks/clarity-ext/contributors","subscribers_url":"https://api.github.com/repos/withrocks/clarity-ext/subscribers","subscription_url":"https://api.github.com/repos/withrocks/clarity-ext/subscription","commits_url":"https://api.github.com/repos/withrocks/clarity-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/withrocks/clarity-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/withrocks/clarity-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/withrocks/clarity-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/withrocks/clarity-ext/contents/{+path}","compare_url":"https://api.github.com/repos/withrocks/clarity-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/withrocks/clarity-ext/merges","archive_url":"https://api.github.com/repos/withrocks/clarity-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/withrocks/clarity-ext/downloads","issues_url":"https://api.github.com/repos/withrocks/clarity-ext/issues{/number}","pulls_url":"https://api.github.com/repos/withrocks/clarity-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/withrocks/clarity-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/withrocks/clarity-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/withrocks/clarity-ext/labels{/name}","releases_url":"https://api.github.com/repos/withrocks/clarity-ext/releases{/id}","deployments_url":"https://api.github.com/repos/withrocks/clarity-ext/deployments","created_at":"2016-06-06T09:38:04Z","updated_at":"2016-06-06T09:38:05Z","pushed_at":"2016-09-09T07:49:16Z","git_url":"git://github.com/withrocks/clarity-ext.git","ssh_url":"git@github.com:withrocks/clarity-ext.git","clone_url":"https://github.com/withrocks/clarity-ext.git","svn_url":"https://github.com/withrocks/clarity-ext","homepage":null,"size":211,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Molmed:develop","ref":"develop","sha":"54d4ee5a344f43e53434e417851f3bf12d2f9e8a","user":{"login":"Molmed","id":3587866,"avatar_url":"https://avatars.githubusercontent.com/u/3587866?v=3","gravatar_id":"","url":"https://api.github.com/users/Molmed","html_url":"https://github.com/Molmed","followers_url":"https://api.github.com/users/Molmed/followers","following_url":"https://api.github.com/users/Molmed/following{/other_user}","gists_url":"https://api.github.com/users/Molmed/gists{/gist_id}","starred_url":"https://api.github.com/users/Molmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Molmed/subscriptions","organizations_url":"https://api.github.com/users/Molmed/orgs","repos_url":"https://api.github.com/users/Molmed/repos","events_url":"https://api.github.com/users/Molmed/events{/privacy}","received_events_url":"https://api.github.com/users/Molmed/received_events","type":"Organization","site_admin":false},"repo":{"id":52793916,"name":"clarity-ext","full_name":"Molmed/clarity-ext","owner":{"login":"Molmed","id":3587866,"avatar_url":"https://avatars.githubusercontent.com/u/3587866?v=3","gravatar_id":"","url":"https://api.github.com/users/Molmed","html_url":"https://github.com/Molmed","followers_url":"https://api.github.com/users/Molmed/followers","following_url":"https://api.github.com/users/Molmed/following{/other_user}","gists_url":"https://api.github.com/users/Molmed/gists{/gist_id}","starred_url":"https://api.github.com/users/Molmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Molmed/subscriptions","organizations_url":"https://api.github.com/users/Molmed/orgs","repos_url":"https://api.github.com/users/Molmed/repos","events_url":"https://api.github.com/users/Molmed/events{/privacy}","received_events_url":"https://api.github.com/users/Molmed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Molmed/clarity-ext","description":"Extensions for Clarity","fork":false,"url":"https://api.github.com/repos/Molmed/clarity-ext","forks_url":"https://api.github.com/repos/Molmed/clarity-ext/forks","keys_url":"https://api.github.com/repos/Molmed/clarity-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Molmed/clarity-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Molmed/clarity-ext/teams","hooks_url":"https://api.github.com/repos/Molmed/clarity-ext/hooks","issue_events_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/events{/number}","events_url":"https://api.github.com/repos/Molmed/clarity-ext/events","assignees_url":"https://api.github.com/repos/Molmed/clarity-ext/assignees{/user}","branches_url":"https://api.github.com/repos/Molmed/clarity-ext/branches{/branch}","tags_url":"https://api.github.com/repos/Molmed/clarity-ext/tags","blobs_url":"https://api.github.com/repos/Molmed/clarity-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Molmed/clarity-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Molmed/clarity-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/Molmed/clarity-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Molmed/clarity-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/Molmed/clarity-ext/languages","stargazers_url":"https://api.github.com/repos/Molmed/clarity-ext/stargazers","contributors_url":"https://api.github.com/repos/Molmed/clarity-ext/contributors","subscribers_url":"https://api.github.com/repos/Molmed/clarity-ext/subscribers","subscription_url":"https://api.github.com/repos/Molmed/clarity-ext/subscription","commits_url":"https://api.github.com/repos/Molmed/clarity-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/Molmed/clarity-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/Molmed/clarity-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/Molmed/clarity-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/Molmed/clarity-ext/contents/{+path}","compare_url":"https://api.github.com/repos/Molmed/clarity-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Molmed/clarity-ext/merges","archive_url":"https://api.github.com/repos/Molmed/clarity-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Molmed/clarity-ext/downloads","issues_url":"https://api.github.com/repos/Molmed/clarity-ext/issues{/number}","pulls_url":"https://api.github.com/repos/Molmed/clarity-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/Molmed/clarity-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/Molmed/clarity-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Molmed/clarity-ext/labels{/name}","releases_url":"https://api.github.com/repos/Molmed/clarity-ext/releases{/id}","deployments_url":"https://api.github.com/repos/Molmed/clarity-ext/deployments","created_at":"2016-02-29T13:41:31Z","updated_at":"2016-03-01T13:55:25Z","pushed_at":"2016-09-09T07:58:50Z","git_url":"git://github.com/Molmed/clarity-ext.git","ssh_url":"git@github.com:Molmed/clarity-ext.git","clone_url":"https://github.com/Molmed/clarity-ext.git","svn_url":"https://github.com/Molmed/clarity-ext","homepage":null,"size":253,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29"},"html":{"href":"https://github.com/Molmed/clarity-ext/pull/29"},"issue":{"href":"https://api.github.com/repos/Molmed/clarity-ext/issues/29"},"comments":{"href":"https://api.github.com/repos/Molmed/clarity-ext/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Molmed/clarity-ext/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Molmed/clarity-ext/statuses/272a2853c233ea8a5d576c94dcdf97fffc57c7b6"}}}}
{"actor":{"display_login":"withrocks"}}