{"action":"created","issue":{"url":"https://api.github.com/repos/OPENDAP/bes/issues/19","repository_url":"https://api.github.com/repos/OPENDAP/bes","labels_url":"https://api.github.com/repos/OPENDAP/bes/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/OPENDAP/bes/issues/19/comments","events_url":"https://api.github.com/repos/OPENDAP/bes/issues/19/events","html_url":"https://github.com/OPENDAP/bes/pull/19","id":142717374,"number":19,"title":"Function result unwrapper","user":{"login":"ndp-opendap","id":8389499,"avatar_url":"https://avatars.githubusercontent.com/u/8389499?v=3","gravatar_id":"","url":"https://api.github.com/users/ndp-opendap","html_url":"https://github.com/ndp-opendap","followers_url":"https://api.github.com/users/ndp-opendap/followers","following_url":"https://api.github.com/users/ndp-opendap/following{/other_user}","gists_url":"https://api.github.com/users/ndp-opendap/gists{/gist_id}","starred_url":"https://api.github.com/users/ndp-opendap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndp-opendap/subscriptions","organizations_url":"https://api.github.com/users/ndp-opendap/orgs","repos_url":"https://api.github.com/users/ndp-opendap/repos","events_url":"https://api.github.com/users/ndp-opendap/events{/privacy}","received_events_url":"https://api.github.com/users/ndp-opendap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-22T17:18:32Z","updated_at":"2016-03-22T18:07:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPENDAP/bes/pulls/19","html_url":"https://github.com/OPENDAP/bes/pull/19","diff_url":"https://github.com/OPENDAP/bes/pull/19.diff","patch_url":"https://github.com/OPENDAP/bes/pull/19.patch"},"body":"This collection of changes allows the ugrid restrict functions to return DAP and NetCDF output that can be read ugrid clients.\r\n\r\nThese changes provide a more cohesive implementation of our unwrap hack in which server side functions that need to return collections of variables that appear at the top level of the resulting dataset can achieve this by wrapping said collection into a Structure with a magic name that gets intercepted downstream by the various Transmitters.\r\n\r\nThe following modules also contain code for this feature implementation:\r\n\r\n* dap-server\r\n* fileout_gdal\r\n* fileout_json\r\n* fileout_netcdf\r\n* xml_data_handler\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OPENDAP/bes/issues/comments/199943721","html_url":"https://github.com/OPENDAP/bes/pull/19#issuecomment-199943721","issue_url":"https://api.github.com/repos/OPENDAP/bes/issues/19","id":199943721,"user":{"login":"jgallagher59701","id":8326698,"avatar_url":"https://avatars.githubusercontent.com/u/8326698?v=3","gravatar_id":"","url":"https://api.github.com/users/jgallagher59701","html_url":"https://github.com/jgallagher59701","followers_url":"https://api.github.com/users/jgallagher59701/followers","following_url":"https://api.github.com/users/jgallagher59701/following{/other_user}","gists_url":"https://api.github.com/users/jgallagher59701/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallagher59701/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallagher59701/subscriptions","organizations_url":"https://api.github.com/users/jgallagher59701/orgs","repos_url":"https://api.github.com/users/jgallagher59701/repos","events_url":"https://api.github.com/users/jgallagher59701/events{/privacy}","received_events_url":"https://api.github.com/users/jgallagher59701/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T18:07:14Z","updated_at":"2016-03-22T18:07:14Z","body":"+1\r\n\r\nAt this point I'd remove the #if 0 sections and also compact the empty lines. It may just be me, but I find the big open line parts slow down me down when I'm looking at the code and trying to understand it. Beyond that, I say 'merge.'"}}