{"action":"opened","number":359,"pull_request":{"url":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359","id":75715335,"html_url":"https://github.com/lxde/lxqt-panel/pull/359","diff_url":"https://github.com/lxde/lxqt-panel/pull/359.diff","patch_url":"https://github.com/lxde/lxqt-panel/pull/359.patch","issue_url":"https://api.github.com/repos/lxde/lxqt-panel/issues/359","number":359,"state":"open","locked":false,"title":"Remove (extranous?) m->setParent(menu)","user":{"login":"jsm222","id":4705090,"avatar_url":"https://avatars.githubusercontent.com/u/4705090?v=3","gravatar_id":"","url":"https://api.github.com/users/jsm222","html_url":"https://github.com/jsm222","followers_url":"https://api.github.com/users/jsm222/followers","following_url":"https://api.github.com/users/jsm222/following{/other_user}","gists_url":"https://api.github.com/users/jsm222/gists{/gist_id}","starred_url":"https://api.github.com/users/jsm222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsm222/subscriptions","organizations_url":"https://api.github.com/users/jsm222/orgs","repos_url":"https://api.github.com/users/jsm222/repos","events_url":"https://api.github.com/users/jsm222/events{/privacy}","received_events_url":"https://api.github.com/users/jsm222/received_events","type":"User","site_admin":false},"body":"I did a build of QT 5.5.1 on FreeBSD with WITH_DEBUG=YES in /etc/make.conf. This causes the macro Q_ASSERT to be expanded in QT sources. One assert is that the object on which setParent is called, must have isWidget set to a true value, [(1)](http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qobject.cpp?h=v5.5.1#n1932) , which defaults to false [(2)](http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qobject.cpp?h=v5.5.1#n205) for a QObject. After looking at the code, I do not get why the setParent is called. So I removed it, and AFAICT the plugins popUpMenus are  working as intended (without a failing assert on debug builds.)\r\n\r\n[1] http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qobject.cpp?h=v5.5.1#n1932\r\n[2] http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qobject.cpp?h=v5.5.1#n205","created_at":"2016-06-29T20:26:05Z","updated_at":"2016-06-29T20:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359/commits","review_comments_url":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359/comments","review_comment_url":"https://api.github.com/repos/lxde/lxqt-panel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxde/lxqt-panel/issues/359/comments","statuses_url":"https://api.github.com/repos/lxde/lxqt-panel/statuses/ff957ae66a83b66e5f8581819603be9e0e015464","head":{"label":"jsm222:master","ref":"master","sha":"ff957ae66a83b66e5f8581819603be9e0e015464","user":{"login":"jsm222","id":4705090,"avatar_url":"https://avatars.githubusercontent.com/u/4705090?v=3","gravatar_id":"","url":"https://api.github.com/users/jsm222","html_url":"https://github.com/jsm222","followers_url":"https://api.github.com/users/jsm222/followers","following_url":"https://api.github.com/users/jsm222/following{/other_user}","gists_url":"https://api.github.com/users/jsm222/gists{/gist_id}","starred_url":"https://api.github.com/users/jsm222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsm222/subscriptions","organizations_url":"https://api.github.com/users/jsm222/orgs","repos_url":"https://api.github.com/users/jsm222/repos","events_url":"https://api.github.com/users/jsm222/events{/privacy}","received_events_url":"https://api.github.com/users/jsm222/received_events","type":"User","site_admin":false},"repo":{"id":62181637,"name":"lxqt-panel","full_name":"jsm222/lxqt-panel","owner":{"login":"jsm222","id":4705090,"avatar_url":"https://avatars.githubusercontent.com/u/4705090?v=3","gravatar_id":"","url":"https://api.github.com/users/jsm222","html_url":"https://github.com/jsm222","followers_url":"https://api.github.com/users/jsm222/followers","following_url":"https://api.github.com/users/jsm222/following{/other_user}","gists_url":"https://api.github.com/users/jsm222/gists{/gist_id}","starred_url":"https://api.github.com/users/jsm222/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsm222/subscriptions","organizations_url":"https://api.github.com/users/jsm222/orgs","repos_url":"https://api.github.com/users/jsm222/repos","events_url":"https://api.github.com/users/jsm222/events{/privacy}","received_events_url":"https://api.github.com/users/jsm222/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsm222/lxqt-panel","description":"The LXQt desktop panel","fork":true,"url":"https://api.github.com/repos/jsm222/lxqt-panel","forks_url":"https://api.github.com/repos/jsm222/lxqt-panel/forks","keys_url":"https://api.github.com/repos/jsm222/lxqt-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsm222/lxqt-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsm222/lxqt-panel/teams","hooks_url":"https://api.github.com/repos/jsm222/lxqt-panel/hooks","issue_events_url":"https://api.github.com/repos/jsm222/lxqt-panel/issues/events{/number}","events_url":"https://api.github.com/repos/jsm222/lxqt-panel/events","assignees_url":"https://api.github.com/repos/jsm222/lxqt-panel/assignees{/user}","branches_url":"https://api.github.com/repos/jsm222/lxqt-panel/branches{/branch}","tags_url":"https://api.github.com/repos/jsm222/lxqt-panel/tags","blobs_url":"https://api.github.com/repos/jsm222/lxqt-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsm222/lxqt-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsm222/lxqt-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsm222/lxqt-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsm222/lxqt-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/jsm222/lxqt-panel/languages","stargazers_url":"https://api.github.com/repos/jsm222/lxqt-panel/stargazers","contributors_url":"https://api.github.com/repos/jsm222/lxqt-panel/contributors","subscribers_url":"https://api.github.com/repos/jsm222/lxqt-panel/subscribers","subscription_url":"https://api.github.com/repos/jsm222/lxqt-panel/subscription","commits_url":"https://api.github.com/repos/jsm222/lxqt-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsm222/lxqt-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsm222/lxqt-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsm222/lxqt-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsm222/lxqt-panel/contents/{+path}","compare_url":"https://api.github.com/repos/jsm222/lxqt-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsm222/lxqt-panel/merges","archive_url":"https://api.github.com/repos/jsm222/lxqt-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsm222/lxqt-panel/downloads","issues_url":"https://api.github.com/repos/jsm222/lxqt-panel/issues{/number}","pulls_url":"https://api.github.com/repos/jsm222/lxqt-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/jsm222/lxqt-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/jsm222/lxqt-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsm222/lxqt-panel/labels{/name}","releases_url":"https://api.github.com/repos/jsm222/lxqt-panel/releases{/id}","deployments_url":"https://api.github.com/repos/jsm222/lxqt-panel/deployments","created_at":"2016-06-28T23:54:58Z","updated_at":"2016-06-28T23:55:00Z","pushed_at":"2016-06-29T20:18:41Z","git_url":"git://github.com/jsm222/lxqt-panel.git","ssh_url":"git@github.com:jsm222/lxqt-panel.git","clone_url":"https://github.com/jsm222/lxqt-panel.git","svn_url":"https://github.com/jsm222/lxqt-panel","homepage":"http://lxqt.org","size":5615,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxde:master","ref":"master","sha":"57396d20c6e2d4102e9ff1e2e5907aba5af263c9","user":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"repo":{"id":11921791,"name":"lxqt-panel","full_name":"lxde/lxqt-panel","owner":{"login":"lxde","id":4973989,"avatar_url":"https://avatars.githubusercontent.com/u/4973989?v=3","gravatar_id":"","url":"https://api.github.com/users/lxde","html_url":"https://github.com/lxde","followers_url":"https://api.github.com/users/lxde/followers","following_url":"https://api.github.com/users/lxde/following{/other_user}","gists_url":"https://api.github.com/users/lxde/gists{/gist_id}","starred_url":"https://api.github.com/users/lxde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxde/subscriptions","organizations_url":"https://api.github.com/users/lxde/orgs","repos_url":"https://api.github.com/users/lxde/repos","events_url":"https://api.github.com/users/lxde/events{/privacy}","received_events_url":"https://api.github.com/users/lxde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxde/lxqt-panel","description":"The LXQt desktop panel","fork":false,"url":"https://api.github.com/repos/lxde/lxqt-panel","forks_url":"https://api.github.com/repos/lxde/lxqt-panel/forks","keys_url":"https://api.github.com/repos/lxde/lxqt-panel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxde/lxqt-panel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxde/lxqt-panel/teams","hooks_url":"https://api.github.com/repos/lxde/lxqt-panel/hooks","issue_events_url":"https://api.github.com/repos/lxde/lxqt-panel/issues/events{/number}","events_url":"https://api.github.com/repos/lxde/lxqt-panel/events","assignees_url":"https://api.github.com/repos/lxde/lxqt-panel/assignees{/user}","branches_url":"https://api.github.com/repos/lxde/lxqt-panel/branches{/branch}","tags_url":"https://api.github.com/repos/lxde/lxqt-panel/tags","blobs_url":"https://api.github.com/repos/lxde/lxqt-panel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxde/lxqt-panel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxde/lxqt-panel/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxde/lxqt-panel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxde/lxqt-panel/statuses/{sha}","languages_url":"https://api.github.com/repos/lxde/lxqt-panel/languages","stargazers_url":"https://api.github.com/repos/lxde/lxqt-panel/stargazers","contributors_url":"https://api.github.com/repos/lxde/lxqt-panel/contributors","subscribers_url":"https://api.github.com/repos/lxde/lxqt-panel/subscribers","subscription_url":"https://api.github.com/repos/lxde/lxqt-panel/subscription","commits_url":"https://api.github.com/repos/lxde/lxqt-panel/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxde/lxqt-panel/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxde/lxqt-panel/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxde/lxqt-panel/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxde/lxqt-panel/contents/{+path}","compare_url":"https://api.github.com/repos/lxde/lxqt-panel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxde/lxqt-panel/merges","archive_url":"https://api.github.com/repos/lxde/lxqt-panel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxde/lxqt-panel/downloads","issues_url":"https://api.github.com/repos/lxde/lxqt-panel/issues{/number}","pulls_url":"https://api.github.com/repos/lxde/lxqt-panel/pulls{/number}","milestones_url":"https://api.github.com/repos/lxde/lxqt-panel/milestones{/number}","notifications_url":"https://api.github.com/repos/lxde/lxqt-panel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxde/lxqt-panel/labels{/name}","releases_url":"https://api.github.com/repos/lxde/lxqt-panel/releases{/id}","deployments_url":"https://api.github.com/repos/lxde/lxqt-panel/deployments","created_at":"2013-08-06T10:48:38Z","updated_at":"2016-06-02T21:33:29Z","pushed_at":"2016-06-29T06:44:10Z","git_url":"git://github.com/lxde/lxqt-panel.git","ssh_url":"git@github.com:lxde/lxqt-panel.git","clone_url":"https://github.com/lxde/lxqt-panel.git","svn_url":"https://github.com/lxde/lxqt-panel","homepage":"http://lxqt.org","size":6244,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":5,"forks":65,"open_issues":5,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359"},"html":{"href":"https://github.com/lxde/lxqt-panel/pull/359"},"issue":{"href":"https://api.github.com/repos/lxde/lxqt-panel/issues/359"},"comments":{"href":"https://api.github.com/repos/lxde/lxqt-panel/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/lxde/lxqt-panel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxde/lxqt-panel/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/lxde/lxqt-panel/statuses/ff957ae66a83b66e5f8581819603be9e0e015464"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jsm222"}}