{"action":"created","issue":{"url":"https://api.github.com/repos/Igalia/phpreport/issues/296","repository_url":"https://api.github.com/repos/Igalia/phpreport","labels_url":"https://api.github.com/repos/Igalia/phpreport/issues/296/labels{/name}","comments_url":"https://api.github.com/repos/Igalia/phpreport/issues/296/comments","events_url":"https://api.github.com/repos/Igalia/phpreport/issues/296/events","html_url":"https://github.com/Igalia/phpreport/pull/296","id":176007752,"number":296,"title":"Do not show close confirmation when its just the empty task on screen","user":{"login":"tonythomas01","id":4214481,"avatar_url":"https://avatars.githubusercontent.com/u/4214481?v=3","gravatar_id":"","url":"https://api.github.com/users/tonythomas01","html_url":"https://github.com/tonythomas01","followers_url":"https://api.github.com/users/tonythomas01/followers","following_url":"https://api.github.com/users/tonythomas01/following{/other_user}","gists_url":"https://api.github.com/users/tonythomas01/gists{/gist_id}","starred_url":"https://api.github.com/users/tonythomas01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonythomas01/subscriptions","organizations_url":"https://api.github.com/users/tonythomas01/orgs","repos_url":"https://api.github.com/users/tonythomas01/repos","events_url":"https://api.github.com/users/tonythomas01/events{/privacy}","received_events_url":"https://api.github.com/users/tonythomas01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-09T13:21:11Z","updated_at":"2016-09-27T17:24:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Igalia/phpreport/pulls/296","html_url":"https://github.com/Igalia/phpreport/pull/296","diff_url":"https://github.com/Igalia/phpreport/pull/296.diff","patch_url":"https://github.com/Igalia/phpreport/pull/296.patch"},"body":"> (04:49:22  IST) mrobinson: tthomas: I had a suggestion for the \"empty task on empty day\" feature.\r\n(04:49:35  IST) mrobinson: tthomas: Essentially make it inactive until you click on it.\r\n(04:49:53  IST) mrobinson: tthomas: That way you won't get a lot of dialog boxes when you are clicking through empty days."},"comment":{"url":"https://api.github.com/repos/Igalia/phpreport/issues/comments/249935663","html_url":"https://github.com/Igalia/phpreport/pull/296#issuecomment-249935663","issue_url":"https://api.github.com/repos/Igalia/phpreport/issues/296","id":249935663,"user":{"login":"jaragunde","id":2900877,"avatar_url":"https://avatars.githubusercontent.com/u/2900877?v=3","gravatar_id":"","url":"https://api.github.com/users/jaragunde","html_url":"https://github.com/jaragunde","followers_url":"https://api.github.com/users/jaragunde/followers","following_url":"https://api.github.com/users/jaragunde/following{/other_user}","gists_url":"https://api.github.com/users/jaragunde/gists{/gist_id}","starred_url":"https://api.github.com/users/jaragunde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaragunde/subscriptions","organizations_url":"https://api.github.com/users/jaragunde/orgs","repos_url":"https://api.github.com/users/jaragunde/repos","events_url":"https://api.github.com/users/jaragunde/events{/privacy}","received_events_url":"https://api.github.com/users/jaragunde/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T17:24:59Z","updated_at":"2016-09-27T17:24:59Z","body":"I found another corner case:\r\n1. Open an empty date.\r\n2. Create a task from template.\r\n3. Add some text in the description.\r\n4. Change date.\r\n\r\nExpected result: Ask before leaving the page, because there are unsaved changes\r\nActual result: Confirmation popup doesn't appear\r\n\r\nThe problem is when you run `isUnsaved()`, I think the variable `freshCreatedTaskRecord` is still pointing to the old object that contained the empty task, which was removed from the store when you created the template.\r\n\r\n"}}
{"actor":{"display_login":"jaragunde"}}