{"action":"created","issue":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/209","repository_url":"https://api.github.com/repos/jeff-regier/Celeste.jl","labels_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/209/comments","events_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/209/events","html_url":"https://github.com/jeff-regier/Celeste.jl/issues/209","id":145407236,"number":209,"title":"skip really large galaxies and dim sources","user":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-02T19:24:04Z","updated_at":"2016-04-03T00:06:13Z","closed_at":null,"body":"@rgiordan Do we have logic to skip really large galaxies? We may have tasks that don't finish during the large runs if we don't skip them. (Though the code is ridiculously fast now!)\r\n\r\nI'm also wondering about the cuts based on brightness. We're skipping sources based on their max band brightness in physical units, I think. But some bands (e.g. z) record very few photons regardless of how bright the source is in physical units. Might it be better to just cut based on r band brightness, rather than a max over bands? (Computing the expected number of photons in all bands might be ideal, but r band brightness is probably pretty highly correlated with the total.)"},"comment":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/comments/204831383","html_url":"https://github.com/jeff-regier/Celeste.jl/issues/209#issuecomment-204831383","issue_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/209","id":204831383,"user":{"login":"rgiordan","id":4494910,"avatar_url":"https://avatars.githubusercontent.com/u/4494910?v=3","gravatar_id":"","url":"https://api.github.com/users/rgiordan","html_url":"https://github.com/rgiordan","followers_url":"https://api.github.com/users/rgiordan/followers","following_url":"https://api.github.com/users/rgiordan/following{/other_user}","gists_url":"https://api.github.com/users/rgiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rgiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgiordan/subscriptions","organizations_url":"https://api.github.com/users/rgiordan/orgs","repos_url":"https://api.github.com/users/rgiordan/repos","events_url":"https://api.github.com/users/rgiordan/events{/privacy}","received_events_url":"https://api.github.com/users/rgiordan/received_events","type":"User","site_admin":false},"created_at":"2016-04-03T00:06:13Z","updated_at":"2016-04-03T00:06:13Z","body":">\n> @rgiordan <https://github.com/rgiordan> Do we have logic to skip really\n> large galaxies? We may have tasks that don't finish during the large runs\n> if we don't skip them. (Though the code is ridiculously fast now!)\n>\nNot right now, no.\n\nI think a good way to do that would be to have trim_source_tiles return a\ncount of active pixels and threshold based on that.\n\nAs part of this, we should save some metadata in the output.  Part of that\ncould also be whether the optimization hit the maximum number of iterations.\n\nI have some time this evening.  Want me to do this?\n\n\n> I'm also wondering about the cuts based on brightness. We're skipping\n> sources based on their max band brightness in physical units, I think. But\n> some bands (e.g. z) record very few photons regardless of how bright the\n> source is in physical units. Might it be better to just cut based on r band\n> brightness, rather than a max over bands? (Computing the expected number of\n> photons in all bands might be ideal, but r band brightness is probably\n> pretty highly correlated with the total.)\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/jeff-regier/Celeste.jl/issues/209>\n>\n"}}