{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4858","repository_url":"https://api.github.com/repos/netty/netty","labels_url":"https://api.github.com/repos/netty/netty/issues/4858/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4858/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4858/events","html_url":"https://github.com/netty/netty/pull/4858","id":132612989,"number":4858,"title":"Fix the issue netty#3806 in 4.1","user":{"login":"jiafu1115","id":5654180,"avatar_url":"https://avatars.githubusercontent.com/u/5654180?v=3","gravatar_id":"","url":"https://api.github.com/users/jiafu1115","html_url":"https://github.com/jiafu1115","followers_url":"https://api.github.com/users/jiafu1115/followers","following_url":"https://api.github.com/users/jiafu1115/following{/other_user}","gists_url":"https://api.github.com/users/jiafu1115/gists{/gist_id}","starred_url":"https://api.github.com/users/jiafu1115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiafu1115/subscriptions","organizations_url":"https://api.github.com/users/jiafu1115/orgs","repos_url":"https://api.github.com/users/jiafu1115/repos","events_url":"https://api.github.com/users/jiafu1115/events{/privacy}","received_events_url":"https://api.github.com/users/jiafu1115/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netty/netty/labels/feature","name":"feature","color":"009800"},{"url":"https://api.github.com/repos/netty/netty/labels/improvement","name":"improvement","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/84","html_url":"https://github.com/netty/netty/milestones/4.1.0.Final","labels_url":"https://api.github.com/repos/netty/netty/milestones/84/labels","id":561880,"number":84,"title":"4.1.0.Final","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":42,"state":"open","created_at":"2014-02-07T08:42:42Z","updated_at":"2016-03-26T07:08:26Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2016-02-10T05:52:16Z","updated_at":"2016-03-29T07:12:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4858","html_url":"https://github.com/netty/netty/pull/4858","diff_url":"https://github.com/netty/netty/pull/4858.diff","patch_url":"https://github.com/netty/netty/pull/4858.patch"},"body":"Motivation:\r\n\r\nfix the issue netty#3806\r\n\r\nModifications:\r\n\r\n1. deprecated ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK and ChannelOption.WRITE_BUFFER_LOW_WATER_MARK.\r\n\r\n2. add one new option called ChannelOption.WRITE_BUFFER_WATER_MARK. \r\n\r\n3. add one new class type: WriteBufferWaterMark with constructor WriteBufferWaterMark(int, int)\r\nIt can support setting both low and high water mark at same time so that it can break values limited caused by default values.\r\n\r\nso the followed usage is recomment after this fix:\r\n\r\n> serverBootstrap.childOption(ChannelOption.WRITE_BUFFER_WATER_MARK, new WriteBufferWaterMark(32768, 65536));\r\n\r\nResult:\r\nafter the fix, the high/low water mark values limits caused by default values are removed."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/202749962","html_url":"https://github.com/netty/netty/pull/4858#issuecomment-202749962","issue_url":"https://api.github.com/repos/netty/netty/issues/4858","id":202749962,"user":{"login":"jiafu1115","id":5654180,"avatar_url":"https://avatars.githubusercontent.com/u/5654180?v=3","gravatar_id":"","url":"https://api.github.com/users/jiafu1115","html_url":"https://github.com/jiafu1115","followers_url":"https://api.github.com/users/jiafu1115/followers","following_url":"https://api.github.com/users/jiafu1115/following{/other_user}","gists_url":"https://api.github.com/users/jiafu1115/gists{/gist_id}","starred_url":"https://api.github.com/users/jiafu1115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiafu1115/subscriptions","organizations_url":"https://api.github.com/users/jiafu1115/orgs","repos_url":"https://api.github.com/users/jiafu1115/repos","events_url":"https://api.github.com/users/jiafu1115/events{/privacy}","received_events_url":"https://api.github.com/users/jiafu1115/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T07:12:56Z","updated_at":"2016-03-29T07:12:56Z","body":"@normanmaurer  I will try to modify codes on line. it may include more test builds, you can ignore it. Once I complete it, I will notify you. 3ks"}}