{"action":"created","issue":{"url":"https://api.github.com/repos/Teradata/presto/issues/294","repository_url":"https://api.github.com/repos/Teradata/presto","labels_url":"https://api.github.com/repos/Teradata/presto/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/294/comments","events_url":"https://api.github.com/repos/Teradata/presto/issues/294/events","html_url":"https://github.com/Teradata/presto/pull/294","id":169889772,"number":294,"title":"Decimal fast aggregations","user":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars.githubusercontent.com/u/8957547?v=3","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-08T10:20:57Z","updated_at":"2016-08-08T10:24:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/294","html_url":"https://github.com/Teradata/presto/pull/294","diff_url":"https://github.com/Teradata/presto/pull/294.diff","patch_url":"https://github.com/Teradata/presto/pull/294.patch"},"body":"Benchmark results with old code (@wbiela pull request with avg/sum aggregations):\r\n\r\n```\r\nBenchmark                                                                                                             (project)          (type)  Mode  Cnt     Score    Error  Units\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, avg(totalprice)   decimal(14,2)  avgt   30   274.957 ±  6.592  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, avg(totalprice)  decimal(30,10)  avgt   30   439.031 ±  7.239  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, min(totalprice)   decimal(14,2)  avgt   30   206.957 ±  5.151  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, min(totalprice)  decimal(30,10)  avgt   30   535.220 ± 28.227  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash  orderstatus, sum(totalprice), avg(totalprice), min(totalprice), max(totalprice)   decimal(14,2)  avgt   30   412.677 ±  9.621  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash  orderstatus, sum(totalprice), avg(totalprice), min(totalprice), max(totalprice)  decimal(30,10)  avgt   30  1165.726 ± 82.984  ms/op\r\n```\r\nAfter changes:\r\n\r\n```\r\nBenchmark                                                                                                             (project)  (type)  Mode  Cnt    Score    Error  Units\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, avg(totalprice)          double  avgt   10  166.982 ±  1.467  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, min(totalprice)          double  avgt   10  149.677 ±  9.512  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash  orderstatus, sum(totalprice), avg(totalprice), min(totalprice), max(totalprice)          double  avgt   10  174.185 ± 5.591  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, avg(totalprice)   decimal(14,2)  avgt   10  172.849 ± 12.891  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, avg(totalprice)  decimal(30,10)  avgt   10  231.429 ±  3.415  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, min(totalprice)   decimal(14,2)  avgt   10  151.328 ±  7.758  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash                                                     orderstatus, min(totalprice)  decimal(30,10)  avgt   10  222.131 ±  7.071  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash  orderstatus, sum(totalprice), avg(totalprice), min(totalprice), max(totalprice)   decimal(14,2)  avgt   10  251.888 ± 19.230  ms/op\r\nBenchmarkDecimalAggregation.benchmarkBuildHash  orderstatus, sum(totalprice), avg(totalprice), min(totalprice), max(totalprice)  decimal(30,10)  avgt   10  341.743 ±  4.464  ms/op\r\n```"},"comment":{"url":"https://api.github.com/repos/Teradata/presto/issues/comments/238197974","html_url":"https://github.com/Teradata/presto/pull/294#issuecomment-238197974","issue_url":"https://api.github.com/repos/Teradata/presto/issues/294","id":238197974,"user":{"login":"pnowojski","id":8957547,"avatar_url":"https://avatars.githubusercontent.com/u/8957547?v=3","gravatar_id":"","url":"https://api.github.com/users/pnowojski","html_url":"https://github.com/pnowojski","followers_url":"https://api.github.com/users/pnowojski/followers","following_url":"https://api.github.com/users/pnowojski/following{/other_user}","gists_url":"https://api.github.com/users/pnowojski/gists{/gist_id}","starred_url":"https://api.github.com/users/pnowojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnowojski/subscriptions","organizations_url":"https://api.github.com/users/pnowojski/orgs","repos_url":"https://api.github.com/users/pnowojski/repos","events_url":"https://api.github.com/users/pnowojski/events{/privacy}","received_events_url":"https://api.github.com/users/pnowojski/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T10:24:18Z","updated_at":"2016-08-08T10:24:18Z","body":"Please review only 3 commits as a part of this pull request:\r\n\r\n- Fix add overflow in unscaled decimal\r\n- Use fast decimal in SUM aggregation\r\n- Use fast decimal in AVG aggregation"}}
{"actor":{"display_login":"pnowojski"}}