{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/78603657","id":78603657,"diff_hunk":"@@ -198,27 +199,68 @@ - (bool)_processGesturesForTouch:(UITouch*)touch event:(UIEvent*)event touchEven\n         }\n     }\n \n-    // gesture priority list\n-    const static id s_gesturesPriority[] = {[UIPinchGestureRecognizer class],\n-                                            [UISwipeGestureRecognizer class],\n-                                            [UIPanGestureRecognizer class],\n-                                            [UILongPressGestureRecognizer class],\n-                                            [UITapGestureRecognizer class] };\n \n-    const static int s_numGestureTypes = sizeof(s_gesturesPriority) / sizeof(s_gesturesPriority[0]);\n+    //\n+    // Remove any gestures that should not simulatanously be recognized\n+    //\n \n-    //  Process all gestures\n-    for (int i = 0; i < s_numGestureTypes; i++) {\n-        id curgestureClass = s_gesturesPriority[i];\n-        id gestures = [g_curGesturesDict objectForKey:curgestureClass];\n-        if ([curgestureClass _fireGestures:gestures]) {\n-            handled = true;\n-            if (handled && DEBUG_GESTURES) {\n-                TraceVerbose(TAG, L\"Gesture (%hs) handled.\", object_getClassName(curgestureClass));\n+    // First find the active gesture\n+    UIGestureRecognizer* activeGesture = nil;\n+\n+    int count = [g_currentlyTrackingGesturesList count];\n+    for (int i = count - 1; i >= 0; i--) {\n+        UIGestureRecognizer* curGesture = [g_currentlyTrackingGesturesList objectAtIndex:i];\n+        UIGestureRecognizerState state = curGesture.state;\n+        if ( state != UIGestureRecognizerStatePossible && state != UIGestureRecognizerStateCancelled) {\n+            activeGesture = curGesture;\n+            break;\n+        }\n+    }\n+\n+    if ( activeGesture ) {","path":"Frameworks/UIKit/UIView.mm","position":44,"original_position":45,"commit_id":"7269fc0056e89b12c35602d3d2f5b2fb56dafd63","original_commit_id":"08aa54c23b54929114a1e2e8558b0f0aef8cc22d","user":{"login":"pittmab","id":10537188,"avatar_url":"https://avatars.githubusercontent.com/u/10537188?v=3","gravatar_id":"","url":"https://api.github.com/users/pittmab","html_url":"https://github.com/pittmab","followers_url":"https://api.github.com/users/pittmab/followers","following_url":"https://api.github.com/users/pittmab/following{/other_user}","gists_url":"https://api.github.com/users/pittmab/gists{/gist_id}","starred_url":"https://api.github.com/users/pittmab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittmab/subscriptions","organizations_url":"https://api.github.com/users/pittmab/orgs","repos_url":"https://api.github.com/users/pittmab/repos","events_url":"https://api.github.com/users/pittmab/events{/privacy}","received_events_url":"https://api.github.com/users/pittmab/received_events","type":"User","site_admin":false},"body":"@jaredhms I just ran it and it doesn't indicate that any changes are necessary.  Is there something that I am missing?  Thanks","created_at":"2016-09-13T17:14:35Z","updated_at":"2016-09-13T17:14:35Z","html_url":"https://github.com/Microsoft/WinObjC/pull/1002#discussion_r78603657","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/78603657"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1002#discussion_r78603657"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002","id":85061987,"html_url":"https://github.com/Microsoft/WinObjC/pull/1002","diff_url":"https://github.com/Microsoft/WinObjC/pull/1002.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1002.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1002","number":1002,"state":"open","locked":false,"title":"Adding the ability to subclass UIGestureRecognizer","user":{"login":"pittmab","id":10537188,"avatar_url":"https://avatars.githubusercontent.com/u/10537188?v=3","gravatar_id":"","url":"https://api.github.com/users/pittmab","html_url":"https://github.com/pittmab","followers_url":"https://api.github.com/users/pittmab/followers","following_url":"https://api.github.com/users/pittmab/following{/other_user}","gists_url":"https://api.github.com/users/pittmab/gists{/gist_id}","starred_url":"https://api.github.com/users/pittmab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pittmab/subscriptions","organizations_url":"https://api.github.com/users/pittmab/orgs","repos_url":"https://api.github.com/users/pittmab/repos","events_url":"https://api.github.com/users/pittmab/events{/privacy}","received_events_url":"https://api.github.com/users/pittmab/received_events","type":"User","site_admin":false},"body":"- removing the hard coded preference of gestures\r\n- now enumerating the list of gestures in the order in which they are added\r\n- supporting some of the callbacks for UIGestureRecognizerDelegate\r\n- Adding a callback to check if the first active gesture can prevent other potential gestures in the gesture recognizer list.\r\n\r\nFix: 489\r\nFix: 475","created_at":"2016-09-13T14:43:00Z","updated_at":"2016-09-13T17:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea826e32dd6a9199acd89844a218a20ab9a09926","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1002/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/7269fc0056e89b12c35602d3d2f5b2fb56dafd63","head":{"label":"autodesk-forks:Subclass-UIGestureRecognizer","ref":"Subclass-UIGestureRecognizer","sha":"7269fc0056e89b12c35602d3d2f5b2fb56dafd63","user":{"login":"autodesk-forks","id":13626597,"avatar_url":"https://avatars.githubusercontent.com/u/13626597?v=3","gravatar_id":"","url":"https://api.github.com/users/autodesk-forks","html_url":"https://github.com/autodesk-forks","followers_url":"https://api.github.com/users/autodesk-forks/followers","following_url":"https://api.github.com/users/autodesk-forks/following{/other_user}","gists_url":"https://api.github.com/users/autodesk-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/autodesk-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autodesk-forks/subscriptions","organizations_url":"https://api.github.com/users/autodesk-forks/orgs","repos_url":"https://api.github.com/users/autodesk-forks/repos","events_url":"https://api.github.com/users/autodesk-forks/events{/privacy}","received_events_url":"https://api.github.com/users/autodesk-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":56139086,"name":"WinObjC","full_name":"autodesk-forks/WinObjC","owner":{"login":"autodesk-forks","id":13626597,"avatar_url":"https://avatars.githubusercontent.com/u/13626597?v=3","gravatar_id":"","url":"https://api.github.com/users/autodesk-forks","html_url":"https://github.com/autodesk-forks","followers_url":"https://api.github.com/users/autodesk-forks/followers","following_url":"https://api.github.com/users/autodesk-forks/following{/other_user}","gists_url":"https://api.github.com/users/autodesk-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/autodesk-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autodesk-forks/subscriptions","organizations_url":"https://api.github.com/users/autodesk-forks/orgs","repos_url":"https://api.github.com/users/autodesk-forks/repos","events_url":"https://api.github.com/users/autodesk-forks/events{/privacy}","received_events_url":"https://api.github.com/users/autodesk-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autodesk-forks/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/autodesk-forks/WinObjC","forks_url":"https://api.github.com/repos/autodesk-forks/WinObjC/forks","keys_url":"https://api.github.com/repos/autodesk-forks/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autodesk-forks/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autodesk-forks/WinObjC/teams","hooks_url":"https://api.github.com/repos/autodesk-forks/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/autodesk-forks/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/autodesk-forks/WinObjC/events","assignees_url":"https://api.github.com/repos/autodesk-forks/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/autodesk-forks/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/autodesk-forks/WinObjC/tags","blobs_url":"https://api.github.com/repos/autodesk-forks/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autodesk-forks/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autodesk-forks/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/autodesk-forks/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autodesk-forks/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/autodesk-forks/WinObjC/languages","stargazers_url":"https://api.github.com/repos/autodesk-forks/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/autodesk-forks/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/autodesk-forks/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/autodesk-forks/WinObjC/subscription","commits_url":"https://api.github.com/repos/autodesk-forks/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/autodesk-forks/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/autodesk-forks/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/autodesk-forks/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/autodesk-forks/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/autodesk-forks/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autodesk-forks/WinObjC/merges","archive_url":"https://api.github.com/repos/autodesk-forks/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autodesk-forks/WinObjC/downloads","issues_url":"https://api.github.com/repos/autodesk-forks/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/autodesk-forks/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/autodesk-forks/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/autodesk-forks/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autodesk-forks/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/autodesk-forks/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/autodesk-forks/WinObjC/deployments","created_at":"2016-04-13T09:33:17Z","updated_at":"2016-04-13T11:49:45Z","pushed_at":"2016-09-13T17:05:38Z","git_url":"git://github.com/autodesk-forks/WinObjC.git","ssh_url":"git@github.com:autodesk-forks/WinObjC.git","clone_url":"https://github.com/autodesk-forks/WinObjC.git","svn_url":"https://github.com/autodesk-forks/WinObjC","homepage":null,"size":333021,"stargazers_count":1,"watchers_count":1,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"adsk-develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"d577cafcb1504096c4a0f6d4018a25d9a2749a94","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-09-12T22:50:40Z","pushed_at":"2016-09-13T17:05:38Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":336244,"stargazers_count":5442,"watchers_count":5442,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":698,"mirror_url":null,"open_issues_count":239,"forks":698,"open_issues":239,"watchers":5442,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1002"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1002"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1002/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1002/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/7269fc0056e89b12c35602d3d2f5b2fb56dafd63"}}}}
{"actor":{"display_login":"pittmab"}}