{"action":"created","issue":{"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/352","repository_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental","labels_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/352/comments","events_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/352/events","html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352","id":159852938,"number":352,"title":"Disable alerts","user":{"login":"tzachi-dar","id":7942372,"avatar_url":"https://avatars.githubusercontent.com/u/7942372?v=3","gravatar_id":"","url":"https://api.github.com/users/tzachi-dar","html_url":"https://github.com/tzachi-dar","followers_url":"https://api.github.com/users/tzachi-dar/followers","following_url":"https://api.github.com/users/tzachi-dar/following{/other_user}","gists_url":"https://api.github.com/users/tzachi-dar/gists{/gist_id}","starred_url":"https://api.github.com/users/tzachi-dar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzachi-dar/subscriptions","organizations_url":"https://api.github.com/users/tzachi-dar/orgs","repos_url":"https://api.github.com/users/tzachi-dar/repos","events_url":"https://api.github.com/users/tzachi-dar/events{/privacy}","received_events_url":"https://api.github.com/users/tzachi-dar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-12T22:56:36Z","updated_at":"2016-06-17T16:00:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/pulls/352","html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352","diff_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352.diff","patch_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352.patch"},"body":"This pr allows one to disable any alert.\r\nYes also the 55 alert.\r\nIt also solves issues that happened when editing alert and changing screen orientation.\r\nAlso fixes some issues of not using super() in previous commit.\r\n\r\nStill under testing."},"comment":{"url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/comments/226809401","html_url":"https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352#issuecomment-226809401","issue_url":"https://api.github.com/repos/StephenBlackWasAlreadyTaken/xDrip-Experimental/issues/352","id":226809401,"user":{"login":"tzachi-dar","id":7942372,"avatar_url":"https://avatars.githubusercontent.com/u/7942372?v=3","gravatar_id":"","url":"https://api.github.com/users/tzachi-dar","html_url":"https://github.com/tzachi-dar","followers_url":"https://api.github.com/users/tzachi-dar/followers","following_url":"https://api.github.com/users/tzachi-dar/following{/other_user}","gists_url":"https://api.github.com/users/tzachi-dar/gists{/gist_id}","starred_url":"https://api.github.com/users/tzachi-dar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzachi-dar/subscriptions","organizations_url":"https://api.github.com/users/tzachi-dar/orgs","repos_url":"https://api.github.com/users/tzachi-dar/repos","events_url":"https://api.github.com/users/tzachi-dar/events{/privacy}","received_events_url":"https://api.github.com/users/tzachi-dar/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T16:00:18Z","updated_at":"2016-06-17T16:00:18Z","body":"Thanks for testing this.\n\nI'll merge it soon, but I'll soon add a warning message about disabling all\nlow alerts.\n\nTzachi\n\nOn Fri, Jun 17, 2016 at 4:00 AM, John <notifications@github.com> wrote:\n\n> Hi All,\n> Alert disable, and alerts working as expected.\n> Please merge at will.\n> Cheers\n>\n>\n> On Fri, Jun 17, 2016 at 10:33 AM, John Stevens <jstevensog@gmail.com>\n> wrote:\n>\n> > Hi Tzachi-dar, and all,\n> > I have tested this briefly. The PR allows me to disable the Unchangeable\n> > 3.0mmol alert. I have created a new \"Hypo\" alert set above my current\n> > reading to test. Just waiting to see if that one raises.\n> > But otherwise appears to be all good.\n> >\n> > This will be great. I will be able t set two hypo alarms, one for\n> > daytime, one for nighttime. Might keep my wife happy.\n> > Do we want some form of \"Do you really want to do this?\" message when the\n> > \"unchangeable\" alert is disabled? Or at least a check to see if another\n> > low alert is configured, and if there isn't one, then ask?\n> >\n> > I am sure the Dexcom unchangeable alert is there purely for FDA approval\n> > reasons. But we might need to make it obvious that disabling this alert\n> is\n> > a risk.\n> >\n> > Great work.\n> > Cheers\n> > Cheers\n> >\n> > On Tue, Jun 14, 2016 at 5:23 PM, tzachi-dar <notifications@github.com>\n> > wrote:\n> >\n> >> This would be great if you can test that john.\n> >>\n> >> —\n> >> You are receiving this because you commented.\n> >> Reply to this email directly, view it on GitHub\n> >> <\n> https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352#issuecomment-225800021\n> >,\n> >> or mute the thread\n> >> <\n> https://github.com/notifications/unsubscribe/AIQs87fy2wKQhMiIrYyEpTon06Yv8aqVks5qLlcFgaJpZM4Iz6Dh\n> >\n> >> .\n> >>\n> >\n> >\n> >\n> > --\n> > John Stevens\n> > \"You are how you live, not what you have.\"\n> >\n>\n>\n>\n> --\n> John Stevens\n> \"You are how you live, not what you have.\"\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/pull/352#issuecomment-226655554>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AHkw5MM8AlpUdww5skAevQnK98Y5TFULks5qMfG_gaJpZM4Iz6Dh>\n> .\n>\n"}}
{"actor":{"display_login":"tzachi-dar"}}