{"action":"created","issue":{"url":"https://api.github.com/repos/yonadev/yona-server/issues/235","repository_url":"https://api.github.com/repos/yonadev/yona-server","labels_url":"https://api.github.com/repos/yonadev/yona-server/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/yonadev/yona-server/issues/235/comments","events_url":"https://api.github.com/repos/yonadev/yona-server/issues/235/events","html_url":"https://github.com/yonadev/yona-server/pull/235","id":175326710,"number":235,"title":"YD-339 Messages thread order","user":{"login":"aristotelos","id":2814758,"avatar_url":"https://avatars.githubusercontent.com/u/2814758?v=3","gravatar_id":"","url":"https://api.github.com/users/aristotelos","html_url":"https://github.com/aristotelos","followers_url":"https://api.github.com/users/aristotelos/followers","following_url":"https://api.github.com/users/aristotelos/following{/other_user}","gists_url":"https://api.github.com/users/aristotelos/gists{/gist_id}","starred_url":"https://api.github.com/users/aristotelos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aristotelos/subscriptions","organizations_url":"https://api.github.com/users/aristotelos/orgs","repos_url":"https://api.github.com/users/aristotelos/repos","events_url":"https://api.github.com/users/aristotelos/events{/privacy}","received_events_url":"https://api.github.com/users/aristotelos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-06T19:11:28Z","updated_at":"2016-09-09T18:24:40Z","closed_at":"2016-09-09T17:10:59Z","pull_request":{"url":"https://api.github.com/repos/yonadev/yona-server/pulls/235","html_url":"https://github.com/yonadev/yona-server/pull/235","diff_url":"https://github.com/yonadev/yona-server/pull/235.diff","patch_url":"https://github.com/yonadev/yona-server/pull/235.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/yonadev/yona-server/issues/comments/245997603","html_url":"https://github.com/yonadev/yona-server/pull/235#issuecomment-245997603","issue_url":"https://api.github.com/repos/yonadev/yona-server/issues/235","id":245997603,"user":{"login":"aristotelos","id":2814758,"avatar_url":"https://avatars.githubusercontent.com/u/2814758?v=3","gravatar_id":"","url":"https://api.github.com/users/aristotelos","html_url":"https://github.com/aristotelos","followers_url":"https://api.github.com/users/aristotelos/followers","following_url":"https://api.github.com/users/aristotelos/following{/other_user}","gists_url":"https://api.github.com/users/aristotelos/gists{/gist_id}","starred_url":"https://api.github.com/users/aristotelos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aristotelos/subscriptions","organizations_url":"https://api.github.com/users/aristotelos/orgs","repos_url":"https://api.github.com/users/aristotelos/repos","events_url":"https://api.github.com/users/aristotelos/events{/privacy}","received_events_url":"https://api.github.com/users/aristotelos/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T18:24:40Z","updated_at":"2016-09-09T18:24:40Z","body":"OK thanks for updating the tests! I was planning to do that too :)\n\nOn Fri, Sep 9, 2016 at 7:10 PM, Bert Roos <notifications@github.com> wrote:\n\n> About as good as it gets. I'm not happy with the move of the replied\n> message ID and the thread ID to the base Message class, but we'll leave\n> it there for now.\n>\n> Strictly speaking, it's unnecessary. The activity ID isn't there either\n> and it still features in the where clause of MessageRepository.\n> findByActivityID. That works because all messages are mapped into the\n> same table. We could have done that for threadHeadMessageID as well. That\n> would have prevented from making the base class aware of things it doesn't\n> need to know, but it would not have been nice either.\n>\n> The whole message story is high on my list of to be refactored code.\n>\n> BTW: I updated the tests for the changes done through other PRs.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/yonadev/yona-server/pull/235#issuecomment-245976979>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ACrzJskeNFTDcgq4utXMHtrXVs03p58Lks5qoZMTgaJpZM4J2Lej>\n> .\n>\n"}}
{"actor":{"display_login":"aristotelos"}}