{"action":"created","issue":{"url":"https://api.github.com/repos/lime-rt/lime/issues/99","repository_url":"https://api.github.com/repos/lime-rt/lime","labels_url":"https://api.github.com/repos/lime-rt/lime/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/lime-rt/lime/issues/99/comments","events_url":"https://api.github.com/repos/lime-rt/lime/issues/99/events","html_url":"https://github.com/lime-rt/lime/issues/99","id":147437559,"number":99,"title":"Line blending doesn't work properly","user":{"login":"tlunttil","id":12169106,"avatar_url":"https://avatars.githubusercontent.com/u/12169106?v=3","gravatar_id":"","url":"https://api.github.com/users/tlunttil","html_url":"https://github.com/tlunttil","followers_url":"https://api.github.com/users/tlunttil/followers","following_url":"https://api.github.com/users/tlunttil/following{/other_user}","gists_url":"https://api.github.com/users/tlunttil/gists{/gist_id}","starred_url":"https://api.github.com/users/tlunttil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlunttil/subscriptions","organizations_url":"https://api.github.com/users/tlunttil/orgs","repos_url":"https://api.github.com/users/tlunttil/repos","events_url":"https://api.github.com/users/tlunttil/events{/privacy}","received_events_url":"https://api.github.com/users/tlunttil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-04-11T13:56:06Z","updated_at":"2016-04-26T13:13:16Z","closed_at":null,"body":"Line blending is supposed to be taken care of with code between lines 257 and 280 in photon.c (main branch). However, the code doesn't seem to work properly. The for-loop starting at line 260 is supposed to go through all blended lines, but because the number of blended lines is calculated incorrectly, the loop body is never run. Parameter matrix is a pointer to struct of type blend, so sizeof(matrix) is on most machines 8 bytes, while sizeof(blend) is (at least) 16 bytes.\r\n\r\nThe code inside the loop (that is currently never run) also looks a bit suspicious to me. I don't think that the changes due to blending to tau and other parameters are necessarily made to the correct lines.\r\n"},"comment":{"url":"https://api.github.com/repos/lime-rt/lime/issues/comments/214736417","html_url":"https://github.com/lime-rt/lime/issues/99#issuecomment-214736417","issue_url":"https://api.github.com/repos/lime-rt/lime/issues/99","id":214736417,"user":{"login":"tlunttil","id":12169106,"avatar_url":"https://avatars.githubusercontent.com/u/12169106?v=3","gravatar_id":"","url":"https://api.github.com/users/tlunttil","html_url":"https://github.com/tlunttil","followers_url":"https://api.github.com/users/tlunttil/followers","following_url":"https://api.github.com/users/tlunttil/following{/other_user}","gists_url":"https://api.github.com/users/tlunttil/gists{/gist_id}","starred_url":"https://api.github.com/users/tlunttil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlunttil/subscriptions","organizations_url":"https://api.github.com/users/tlunttil/orgs","repos_url":"https://api.github.com/users/tlunttil/repos","events_url":"https://api.github.com/users/tlunttil/events{/privacy}","received_events_url":"https://api.github.com/users/tlunttil/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T13:13:16Z","updated_at":"2016-04-26T13:13:16Z","body":"It might be worth it to write the blending code in `photon()` and `getjbar()` in a way that allows easy extension to multiple species with overlap possibly also between different species (see #21)."}}