{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/443","repository_url":"https://api.github.com/repos/spring-projects/spring-amqp","labels_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/443/comments","events_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/443/events","html_url":"https://github.com/spring-projects/spring-amqp/pull/443","id":170785937,"number":443,"title":"Pending Confirms Count","user":{"login":"Giri-Chintala","id":12914499,"avatar_url":"https://avatars.githubusercontent.com/u/12914499?v=3","gravatar_id":"","url":"https://api.github.com/users/Giri-Chintala","html_url":"https://github.com/Giri-Chintala","followers_url":"https://api.github.com/users/Giri-Chintala/followers","following_url":"https://api.github.com/users/Giri-Chintala/following{/other_user}","gists_url":"https://api.github.com/users/Giri-Chintala/gists{/gist_id}","starred_url":"https://api.github.com/users/Giri-Chintala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Giri-Chintala/subscriptions","organizations_url":"https://api.github.com/users/Giri-Chintala/orgs","repos_url":"https://api.github.com/users/Giri-Chintala/repos","events_url":"https://api.github.com/users/Giri-Chintala/events{/privacy}","received_events_url":"https://api.github.com/users/Giri-Chintala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-12T02:08:37Z","updated_at":"2016-08-19T20:03:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-amqp/pulls/443","html_url":"https://github.com/spring-projects/spring-amqp/pull/443","diff_url":"https://github.com/spring-projects/spring-amqp/pull/443.diff","patch_url":"https://github.com/spring-projects/spring-amqp/pull/443.patch"},"body":"Resolves https://jira.spring.io/browse/AMQP-632"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/comments/241120777","html_url":"https://github.com/spring-projects/spring-amqp/pull/443#issuecomment-241120777","issue_url":"https://api.github.com/repos/spring-projects/spring-amqp/issues/443","id":241120777,"user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T20:03:49Z","updated_at":"2016-08-19T20:03:49Z","body":"Hello @Giri-Chintala !\r\n\r\nSorry for delay and thank for contribution.\r\nWe don't forget about about and really appreciate the help.\r\n\r\nFrom my point of view I don't see so much benefit of this functionality. Just because `PublisherCallbackChannelImpl.processAck` is done in separate Thread by the Broker initiative. So, any `number` as a result of this new method invocation might not reflect the reality, when during our logic new acks are arriving on background.\r\n\r\nI may agree with more general solution like:\r\n```\r\npublic Collection<CorrelationData> getUnconfirmed() {\r\n...\r\n}\r\n```\r\nwith proper JavaDoc to explain that this method returns only a snapshot at an invocation time.\r\nAnd the real confirmation picture may be different over seconds or so.\r\n\r\nWDYT?\r\n"}}
{"actor":{"display_login":"artembilan"}}