{"action":"opened","number":3568,"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568","id":63962918,"html_url":"https://github.com/chapel-lang/chapel/pull/3568","diff_url":"https://github.com/chapel-lang/chapel/pull/3568.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/3568.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3568","number":3568,"state":"open","locked":false,"title":"Avoid self-references in mod-use list","user":{"login":"noakesmichael","id":2167206,"avatar_url":"https://avatars.githubusercontent.com/u/2167206?v=3","gravatar_id":"","url":"https://api.github.com/users/noakesmichael","html_url":"https://github.com/noakesmichael","followers_url":"https://api.github.com/users/noakesmichael/followers","following_url":"https://api.github.com/users/noakesmichael/following{/other_user}","gists_url":"https://api.github.com/users/noakesmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/noakesmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noakesmichael/subscriptions","organizations_url":"https://api.github.com/users/noakesmichael/orgs","repos_url":"https://api.github.com/users/noakesmichael/repos","events_url":"https://api.github.com/users/noakesmichael/events{/privacy}","received_events_url":"https://api.github.com/users/noakesmichael/received_events","type":"User","site_admin":false},"body":"Nick alerted us to a bug that could use an apparently simple Chapel program to fail to compile with an internal error. The trigger for the bug is a Chapel program where\r\n\r\na module references itself either explicitly with a use-statement of implicitly using a fully qualified symbol reference\r\n\r\nAND\r\n\r\nthe module appears to be used directly or indirectly from the main module but proves to be dead.\r\n\r\nScope-resolution created a self-reference in the mod-use list and then dead-module-elimination\r\nended up with dangling references.\r\n\r\nWe quashed the two situations that introduce self-references and locked this in with two simple\r\ntests.\r\n\r\n\r\nWe debated providing a warning for user code that leads to this situation but concluded that there\r\nmight be legitimate edge-cases in which this is currently needed and we note that we don't have a\r\nway to silence unhelpful warnings.\r\n\r\nThis minor change has been compiled on clang/gcc and has passed linux64.\r\n","created_at":"2016-03-23T22:24:43Z","updated_at":"2016-03-23T22:24:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb966d539adc9ba297174f451b44e238b2e4953b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/3568/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/4a64ced67e0df8c5c45a280e93a30c9aa71320dc","head":{"label":"noakesmichael:selfReference","ref":"selfReference","sha":"4a64ced67e0df8c5c45a280e93a30c9aa71320dc","user":{"login":"noakesmichael","id":2167206,"avatar_url":"https://avatars.githubusercontent.com/u/2167206?v=3","gravatar_id":"","url":"https://api.github.com/users/noakesmichael","html_url":"https://github.com/noakesmichael","followers_url":"https://api.github.com/users/noakesmichael/followers","following_url":"https://api.github.com/users/noakesmichael/following{/other_user}","gists_url":"https://api.github.com/users/noakesmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/noakesmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noakesmichael/subscriptions","organizations_url":"https://api.github.com/users/noakesmichael/orgs","repos_url":"https://api.github.com/users/noakesmichael/repos","events_url":"https://api.github.com/users/noakesmichael/events{/privacy}","received_events_url":"https://api.github.com/users/noakesmichael/received_events","type":"User","site_admin":false},"repo":{"id":22014778,"name":"chapel","full_name":"noakesmichael/chapel","owner":{"login":"noakesmichael","id":2167206,"avatar_url":"https://avatars.githubusercontent.com/u/2167206?v=3","gravatar_id":"","url":"https://api.github.com/users/noakesmichael","html_url":"https://github.com/noakesmichael","followers_url":"https://api.github.com/users/noakesmichael/followers","following_url":"https://api.github.com/users/noakesmichael/following{/other_user}","gists_url":"https://api.github.com/users/noakesmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/noakesmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noakesmichael/subscriptions","organizations_url":"https://api.github.com/users/noakesmichael/orgs","repos_url":"https://api.github.com/users/noakesmichael/repos","events_url":"https://api.github.com/users/noakesmichael/events{/privacy}","received_events_url":"https://api.github.com/users/noakesmichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noakesmichael/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/noakesmichael/chapel","forks_url":"https://api.github.com/repos/noakesmichael/chapel/forks","keys_url":"https://api.github.com/repos/noakesmichael/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noakesmichael/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noakesmichael/chapel/teams","hooks_url":"https://api.github.com/repos/noakesmichael/chapel/hooks","issue_events_url":"https://api.github.com/repos/noakesmichael/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/noakesmichael/chapel/events","assignees_url":"https://api.github.com/repos/noakesmichael/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/noakesmichael/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/noakesmichael/chapel/tags","blobs_url":"https://api.github.com/repos/noakesmichael/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noakesmichael/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noakesmichael/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/noakesmichael/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noakesmichael/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/noakesmichael/chapel/languages","stargazers_url":"https://api.github.com/repos/noakesmichael/chapel/stargazers","contributors_url":"https://api.github.com/repos/noakesmichael/chapel/contributors","subscribers_url":"https://api.github.com/repos/noakesmichael/chapel/subscribers","subscription_url":"https://api.github.com/repos/noakesmichael/chapel/subscription","commits_url":"https://api.github.com/repos/noakesmichael/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/noakesmichael/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/noakesmichael/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/noakesmichael/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/noakesmichael/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/noakesmichael/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noakesmichael/chapel/merges","archive_url":"https://api.github.com/repos/noakesmichael/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noakesmichael/chapel/downloads","issues_url":"https://api.github.com/repos/noakesmichael/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/noakesmichael/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/noakesmichael/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/noakesmichael/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noakesmichael/chapel/labels{/name}","releases_url":"https://api.github.com/repos/noakesmichael/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/noakesmichael/chapel/deployments","created_at":"2014-07-19T17:11:34Z","updated_at":"2016-01-12T14:33:32Z","pushed_at":"2016-03-23T22:14:41Z","git_url":"git://github.com/noakesmichael/chapel.git","ssh_url":"git@github.com:noakesmichael/chapel.git","clone_url":"https://github.com/noakesmichael/chapel.git","svn_url":"https://github.com/noakesmichael/chapel","homepage":"http://chapel.cray.com/","size":352939,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"ef6dded963eae0f202d2e1f6e7291c8866e37b3a","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars.githubusercontent.com/u/7597261?v=3","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2016-03-23T17:05:44Z","pushed_at":"2016-03-23T22:24:45Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":445900,"stargazers_count":232,"watchers_count":232,"language":"Chapel","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":13,"forks":92,"open_issues":13,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/3568"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/3568"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/3568/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/3568/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/4a64ced67e0df8c5c45a280e93a30c9aa71320dc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":86,"deletions":3,"changed_files":5}}