{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8","id":90214734,"html_url":"https://github.com/holidayextras/plugin-jsonapi/pull/8","diff_url":"https://github.com/holidayextras/plugin-jsonapi/pull/8.diff","patch_url":"https://github.com/holidayextras/plugin-jsonapi/pull/8.patch","issue_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/8","number":8,"state":"closed","locked":false,"title":"WEB-9787 add filters to the queryString","user":{"login":"t1gr0u","id":1346793,"avatar_url":"https://avatars.githubusercontent.com/u/1346793?v=3","gravatar_id":"","url":"https://api.github.com/users/t1gr0u","html_url":"https://github.com/t1gr0u","followers_url":"https://api.github.com/users/t1gr0u/followers","following_url":"https://api.github.com/users/t1gr0u/following{/other_user}","gists_url":"https://api.github.com/users/t1gr0u/gists{/gist_id}","starred_url":"https://api.github.com/users/t1gr0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t1gr0u/subscriptions","organizations_url":"https://api.github.com/users/t1gr0u/orgs","repos_url":"https://api.github.com/users/t1gr0u/repos","events_url":"https://api.github.com/users/t1gr0u/events{/privacy}","received_events_url":"https://api.github.com/users/t1gr0u/received_events","type":"User","site_admin":false},"body":"#### What are the links to relevant tickets?\r\n[WEB-9187](https://hxshortbreaks.atlassian.net/browse/WEB-9187)\r\n\r\n#### What does this PR do?\r\nAdded filter for the linked resources so when building the href of that resource we can have filters.\r\n\r\n#### What functional/unit tests does this PR have?\r\nNone at the mo, but will come later to update the code and add unit test.\r\n\r\n#### Is there anything a developer should be aware of when reviewing this?\r\nGet the Works and checkout `WEB-9187` branch, then try:\r\n`http://localhost:3000/hotelProducts/WARMER?include=faqs`\r\n\r\nin the linked resources you should have a faqs href like: \r\n`/faqs/?filter%5BproductIds%5D=WARMER`\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [x] I've checked there is appropriate unit test coverage.\r\n- [x] I've updated documentation with any changes to procedures.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] This change passes all necessary tests (cross browser, automated or otherwise).\r\n- [x] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### Reviewer 1 @philmeehan\r\n- [x] I agree with the assumptions made in the quality checklist.\r\n- [x] I’ve witnessed the work behaving as expected.\r\n- [x] I’ve checked for appropriate test coverage.\r\n- [x] I’ve checked for coding anti-patterns.\r\n- [x] I've checked this work against the requirements of the Jira.\r\n- [x] I don’t believe this work introduces unnecessary technical debt.\r\n- [x] +1 from me!\r\n\r\n#### Reviewer 2\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!","created_at":"2016-10-20T14:42:58Z","updated_at":"2016-10-25T15:43:59Z","closed_at":"2016-10-25T15:43:58Z","merged_at":"2016-10-25T15:43:58Z","merge_commit_sha":"49f41692a25821843cbcd1ce59d8e27292fe88d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8/commits","review_comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8/comments","review_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/8/comments","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/8f4e2a3c574284fb694ae7f9d8ed02b4e8e5128f","head":{"label":"holidayextras:WEB-9187","ref":"WEB-9187","sha":"8f4e2a3c574284fb694ae7f9d8ed02b4e8e5128f","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":31768896,"name":"plugin-jsonapi","full_name":"holidayextras/plugin-jsonapi","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/plugin-jsonapi","description":"A hapijs plugin for a jsonapi style output to all requests. ","fork":false,"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi","forks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/forks","keys_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/teams","hooks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/events","assignees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/tags","blobs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/languages","stargazers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscription","commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/merges","archive_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/downloads","issues_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/deployments","created_at":"2015-03-06T12:45:26Z","updated_at":"2016-04-20T16:52:47Z","pushed_at":"2016-10-25T15:43:58Z","git_url":"git://github.com/holidayextras/plugin-jsonapi.git","ssh_url":"git@github.com:holidayextras/plugin-jsonapi.git","clone_url":"https://github.com/holidayextras/plugin-jsonapi.git","svn_url":"https://github.com/holidayextras/plugin-jsonapi","homepage":null,"size":45,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"88606958579ba2f404105e7fae7c5a965e4490e1","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":31768896,"name":"plugin-jsonapi","full_name":"holidayextras/plugin-jsonapi","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/plugin-jsonapi","description":"A hapijs plugin for a jsonapi style output to all requests. ","fork":false,"url":"https://api.github.com/repos/holidayextras/plugin-jsonapi","forks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/forks","keys_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/teams","hooks_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/events","assignees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/tags","blobs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/languages","stargazers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/subscription","commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/merges","archive_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/downloads","issues_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/plugin-jsonapi/deployments","created_at":"2015-03-06T12:45:26Z","updated_at":"2016-04-20T16:52:47Z","pushed_at":"2016-10-25T15:43:58Z","git_url":"git://github.com/holidayextras/plugin-jsonapi.git","ssh_url":"git@github.com:holidayextras/plugin-jsonapi.git","clone_url":"https://github.com/holidayextras/plugin-jsonapi.git","svn_url":"https://github.com/holidayextras/plugin-jsonapi","homepage":null,"size":45,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8"},"html":{"href":"https://github.com/holidayextras/plugin-jsonapi/pull/8"},"issue":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/8"},"comments":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/plugin-jsonapi/statuses/8f4e2a3c574284fb694ae7f9d8ed02b4e8e5128f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"t1gr0u","id":1346793,"avatar_url":"https://avatars.githubusercontent.com/u/1346793?v=3","gravatar_id":"","url":"https://api.github.com/users/t1gr0u","html_url":"https://github.com/t1gr0u","followers_url":"https://api.github.com/users/t1gr0u/followers","following_url":"https://api.github.com/users/t1gr0u/following{/other_user}","gists_url":"https://api.github.com/users/t1gr0u/gists{/gist_id}","starred_url":"https://api.github.com/users/t1gr0u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t1gr0u/subscriptions","organizations_url":"https://api.github.com/users/t1gr0u/orgs","repos_url":"https://api.github.com/users/t1gr0u/repos","events_url":"https://api.github.com/users/t1gr0u/events{/privacy}","received_events_url":"https://api.github.com/users/t1gr0u/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"commits":10,"additions":179,"deletions":29,"changed_files":3}}
{"actor":{"display_login":"t1gr0u"}}