{"action":"created","comment":{"url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/comments/73251324","id":73251324,"diff_hunk":"@@ -17,8 +22,13 @@\n   }\n \n   $ifcfg_filepath = ifcfg_filepath($::osfamily)\n+\n+  exec { \"ifdown ${interface}\":\n+    command => \"ifdown ${interface}\",\n+    path    => ['/usr/bin', '/usr/sbin'],\n+  }->\n   file { \"ifcfg-${interface}\":\n-    ensure  => 'absent',\n+    ensure  => 'present',","path":"manifests/pxe_cleanup.pp","position":26,"original_position":26,"commit_id":"688a54f936fdda994bc832b2f9c6de19b0a5161e","original_commit_id":"688a54f936fdda994bc832b2f9c6de19b0a5161e","user":{"login":"ksw2599","id":3642432,"avatar_url":"https://avatars.githubusercontent.com/u/3642432?v=3","gravatar_id":"","url":"https://api.github.com/users/ksw2599","html_url":"https://github.com/ksw2599","followers_url":"https://api.github.com/users/ksw2599/followers","following_url":"https://api.github.com/users/ksw2599/following{/other_user}","gists_url":"https://api.github.com/users/ksw2599/gists{/gist_id}","starred_url":"https://api.github.com/users/ksw2599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksw2599/subscriptions","organizations_url":"https://api.github.com/users/ksw2599/orgs","repos_url":"https://api.github.com/users/ksw2599/repos","events_url":"https://api.github.com/users/ksw2599/events{/privacy}","received_events_url":"https://api.github.com/users/ksw2599/received_events","type":"User","site_admin":false},"body":"It seems like the best way to resolve the pxe device hanging is to call ifdown, but it can't do that unless the file exists. We just turn the device off but keep the configuration file. Also removing the file after calling ifdown may cause issue w/ network refresh and postinstall resources.","created_at":"2016-08-02T22:37:38Z","updated_at":"2016-08-02T22:37:38Z","html_url":"https://github.com/dell-asm/puppet-network/pull/38#discussion_r73251324","pull_request_url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/comments/73251324"},"html":{"href":"https://github.com/dell-asm/puppet-network/pull/38#discussion_r73251324"},"pull_request":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38","id":79815096,"html_url":"https://github.com/dell-asm/puppet-network/pull/38","diff_url":"https://github.com/dell-asm/puppet-network/pull/38.diff","patch_url":"https://github.com/dell-asm/puppet-network/pull/38.patch","issue_url":"https://api.github.com/repos/dell-asm/puppet-network/issues/38","number":38,"state":"open","locked":false,"title":"ASM-7272 fix the pxe device cleanup","user":{"login":"ksw2599","id":3642432,"avatar_url":"https://avatars.githubusercontent.com/u/3642432?v=3","gravatar_id":"","url":"https://api.github.com/users/ksw2599","html_url":"https://github.com/ksw2599","followers_url":"https://api.github.com/users/ksw2599/followers","following_url":"https://api.github.com/users/ksw2599/following{/other_user}","gists_url":"https://api.github.com/users/ksw2599/gists{/gist_id}","starred_url":"https://api.github.com/users/ksw2599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksw2599/subscriptions","organizations_url":"https://api.github.com/users/ksw2599/orgs","repos_url":"https://api.github.com/users/ksw2599/repos","events_url":"https://api.github.com/users/ksw2599/events{/privacy}","received_events_url":"https://api.github.com/users/ksw2599/received_events","type":"User","site_admin":false},"body":"- modified clean_ifcfg type to ignore baremetal cases\r\n- modified pxe_cleanup resource to leave the ifcfg file\r\n- pxe_cleanup now calls ifdown to resolve the pxe device from hanging","created_at":"2016-08-02T21:49:02Z","updated_at":"2016-08-02T22:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46a58c781d684df5fab3daafc8833cbf87a249d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38/commits","review_comments_url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38/comments","review_comment_url":"https://api.github.com/repos/dell-asm/puppet-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dell-asm/puppet-network/issues/38/comments","statuses_url":"https://api.github.com/repos/dell-asm/puppet-network/statuses/688a54f936fdda994bc832b2f9c6de19b0a5161e","head":{"label":"ksw2599:asm7272","ref":"asm7272","sha":"688a54f936fdda994bc832b2f9c6de19b0a5161e","user":{"login":"ksw2599","id":3642432,"avatar_url":"https://avatars.githubusercontent.com/u/3642432?v=3","gravatar_id":"","url":"https://api.github.com/users/ksw2599","html_url":"https://github.com/ksw2599","followers_url":"https://api.github.com/users/ksw2599/followers","following_url":"https://api.github.com/users/ksw2599/following{/other_user}","gists_url":"https://api.github.com/users/ksw2599/gists{/gist_id}","starred_url":"https://api.github.com/users/ksw2599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksw2599/subscriptions","organizations_url":"https://api.github.com/users/ksw2599/orgs","repos_url":"https://api.github.com/users/ksw2599/repos","events_url":"https://api.github.com/users/ksw2599/events{/privacy}","received_events_url":"https://api.github.com/users/ksw2599/received_events","type":"User","site_admin":false},"repo":{"id":46589403,"name":"puppet-network","full_name":"ksw2599/puppet-network","owner":{"login":"ksw2599","id":3642432,"avatar_url":"https://avatars.githubusercontent.com/u/3642432?v=3","gravatar_id":"","url":"https://api.github.com/users/ksw2599","html_url":"https://github.com/ksw2599","followers_url":"https://api.github.com/users/ksw2599/followers","following_url":"https://api.github.com/users/ksw2599/following{/other_user}","gists_url":"https://api.github.com/users/ksw2599/gists{/gist_id}","starred_url":"https://api.github.com/users/ksw2599/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksw2599/subscriptions","organizations_url":"https://api.github.com/users/ksw2599/orgs","repos_url":"https://api.github.com/users/ksw2599/repos","events_url":"https://api.github.com/users/ksw2599/events{/privacy}","received_events_url":"https://api.github.com/users/ksw2599/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksw2599/puppet-network","description":"Puppet module to manage Red Hat/Fedora traditional network configuration.","fork":true,"url":"https://api.github.com/repos/ksw2599/puppet-network","forks_url":"https://api.github.com/repos/ksw2599/puppet-network/forks","keys_url":"https://api.github.com/repos/ksw2599/puppet-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksw2599/puppet-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksw2599/puppet-network/teams","hooks_url":"https://api.github.com/repos/ksw2599/puppet-network/hooks","issue_events_url":"https://api.github.com/repos/ksw2599/puppet-network/issues/events{/number}","events_url":"https://api.github.com/repos/ksw2599/puppet-network/events","assignees_url":"https://api.github.com/repos/ksw2599/puppet-network/assignees{/user}","branches_url":"https://api.github.com/repos/ksw2599/puppet-network/branches{/branch}","tags_url":"https://api.github.com/repos/ksw2599/puppet-network/tags","blobs_url":"https://api.github.com/repos/ksw2599/puppet-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksw2599/puppet-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksw2599/puppet-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksw2599/puppet-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksw2599/puppet-network/statuses/{sha}","languages_url":"https://api.github.com/repos/ksw2599/puppet-network/languages","stargazers_url":"https://api.github.com/repos/ksw2599/puppet-network/stargazers","contributors_url":"https://api.github.com/repos/ksw2599/puppet-network/contributors","subscribers_url":"https://api.github.com/repos/ksw2599/puppet-network/subscribers","subscription_url":"https://api.github.com/repos/ksw2599/puppet-network/subscription","commits_url":"https://api.github.com/repos/ksw2599/puppet-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksw2599/puppet-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksw2599/puppet-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksw2599/puppet-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/ksw2599/puppet-network/contents/{+path}","compare_url":"https://api.github.com/repos/ksw2599/puppet-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksw2599/puppet-network/merges","archive_url":"https://api.github.com/repos/ksw2599/puppet-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksw2599/puppet-network/downloads","issues_url":"https://api.github.com/repos/ksw2599/puppet-network/issues{/number}","pulls_url":"https://api.github.com/repos/ksw2599/puppet-network/pulls{/number}","milestones_url":"https://api.github.com/repos/ksw2599/puppet-network/milestones{/number}","notifications_url":"https://api.github.com/repos/ksw2599/puppet-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksw2599/puppet-network/labels{/name}","releases_url":"https://api.github.com/repos/ksw2599/puppet-network/releases{/id}","deployments_url":"https://api.github.com/repos/ksw2599/puppet-network/deployments","created_at":"2015-11-20T22:06:08Z","updated_at":"2016-01-14T18:05:14Z","pushed_at":"2016-08-02T21:47:51Z","git_url":"git://github.com/ksw2599/puppet-network.git","ssh_url":"git@github.com:ksw2599/puppet-network.git","clone_url":"https://github.com/ksw2599/puppet-network.git","svn_url":"https://github.com/ksw2599/puppet-network","homepage":"http://forge.puppetlabs.com/razorsedge/network","size":266,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dell-asm:master","ref":"master","sha":"794468ad0bf904719f41cc3ce245de9b76ffbe41","user":{"login":"dell-asm","id":6306673,"avatar_url":"https://avatars.githubusercontent.com/u/6306673?v=3","gravatar_id":"","url":"https://api.github.com/users/dell-asm","html_url":"https://github.com/dell-asm","followers_url":"https://api.github.com/users/dell-asm/followers","following_url":"https://api.github.com/users/dell-asm/following{/other_user}","gists_url":"https://api.github.com/users/dell-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dell-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dell-asm/subscriptions","organizations_url":"https://api.github.com/users/dell-asm/orgs","repos_url":"https://api.github.com/users/dell-asm/repos","events_url":"https://api.github.com/users/dell-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dell-asm/received_events","type":"Organization","site_admin":false},"repo":{"id":45943172,"name":"puppet-network","full_name":"dell-asm/puppet-network","owner":{"login":"dell-asm","id":6306673,"avatar_url":"https://avatars.githubusercontent.com/u/6306673?v=3","gravatar_id":"","url":"https://api.github.com/users/dell-asm","html_url":"https://github.com/dell-asm","followers_url":"https://api.github.com/users/dell-asm/followers","following_url":"https://api.github.com/users/dell-asm/following{/other_user}","gists_url":"https://api.github.com/users/dell-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dell-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dell-asm/subscriptions","organizations_url":"https://api.github.com/users/dell-asm/orgs","repos_url":"https://api.github.com/users/dell-asm/repos","events_url":"https://api.github.com/users/dell-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dell-asm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dell-asm/puppet-network","description":"Puppet module to manage Red Hat/Fedora traditional network configuration.","fork":true,"url":"https://api.github.com/repos/dell-asm/puppet-network","forks_url":"https://api.github.com/repos/dell-asm/puppet-network/forks","keys_url":"https://api.github.com/repos/dell-asm/puppet-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dell-asm/puppet-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dell-asm/puppet-network/teams","hooks_url":"https://api.github.com/repos/dell-asm/puppet-network/hooks","issue_events_url":"https://api.github.com/repos/dell-asm/puppet-network/issues/events{/number}","events_url":"https://api.github.com/repos/dell-asm/puppet-network/events","assignees_url":"https://api.github.com/repos/dell-asm/puppet-network/assignees{/user}","branches_url":"https://api.github.com/repos/dell-asm/puppet-network/branches{/branch}","tags_url":"https://api.github.com/repos/dell-asm/puppet-network/tags","blobs_url":"https://api.github.com/repos/dell-asm/puppet-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dell-asm/puppet-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dell-asm/puppet-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/dell-asm/puppet-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dell-asm/puppet-network/statuses/{sha}","languages_url":"https://api.github.com/repos/dell-asm/puppet-network/languages","stargazers_url":"https://api.github.com/repos/dell-asm/puppet-network/stargazers","contributors_url":"https://api.github.com/repos/dell-asm/puppet-network/contributors","subscribers_url":"https://api.github.com/repos/dell-asm/puppet-network/subscribers","subscription_url":"https://api.github.com/repos/dell-asm/puppet-network/subscription","commits_url":"https://api.github.com/repos/dell-asm/puppet-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/dell-asm/puppet-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/dell-asm/puppet-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/dell-asm/puppet-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/dell-asm/puppet-network/contents/{+path}","compare_url":"https://api.github.com/repos/dell-asm/puppet-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dell-asm/puppet-network/merges","archive_url":"https://api.github.com/repos/dell-asm/puppet-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dell-asm/puppet-network/downloads","issues_url":"https://api.github.com/repos/dell-asm/puppet-network/issues{/number}","pulls_url":"https://api.github.com/repos/dell-asm/puppet-network/pulls{/number}","milestones_url":"https://api.github.com/repos/dell-asm/puppet-network/milestones{/number}","notifications_url":"https://api.github.com/repos/dell-asm/puppet-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dell-asm/puppet-network/labels{/name}","releases_url":"https://api.github.com/repos/dell-asm/puppet-network/releases{/id}","deployments_url":"https://api.github.com/repos/dell-asm/puppet-network/deployments","created_at":"2015-11-10T22:03:16Z","updated_at":"2016-01-13T22:54:49Z","pushed_at":"2016-08-02T21:49:02Z","git_url":"git://github.com/dell-asm/puppet-network.git","ssh_url":"git@github.com:dell-asm/puppet-network.git","clone_url":"https://github.com/dell-asm/puppet-network.git","svn_url":"https://github.com/dell-asm/puppet-network","homepage":"http://forge.puppetlabs.com/razorsedge/network","size":276,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38"},"html":{"href":"https://github.com/dell-asm/puppet-network/pull/38"},"issue":{"href":"https://api.github.com/repos/dell-asm/puppet-network/issues/38"},"comments":{"href":"https://api.github.com/repos/dell-asm/puppet-network/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dell-asm/puppet-network/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/dell-asm/puppet-network/statuses/688a54f936fdda994bc832b2f9c6de19b0a5161e"}}}}
{"actor":{"display_login":"ksw2599"}}