{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5939","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5939/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5939/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5939/events","html_url":"https://github.com/apple/swift/pull/5939","id":191882064,"number":5939,"title":"[gardening] Standardize SILBasicBlock successor/predecessor methods that deal with blocks rather than the full successor data structure to have the suffix 'Block'.","user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-27T20:06:26Z","updated_at":"2016-11-27T20:06:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5939","html_url":"https://github.com/apple/swift/pull/5939","diff_url":"https://github.com/apple/swift/pull/5939.diff","patch_url":"https://github.com/apple/swift/pull/5939.patch"},"body":"[gardening] Standardize SILBasicBlock successor/predecessor methods that deal with blocks rather than the full successor data structure to have the suffix 'Block'.\r\n\r\nThis was already done for getSuccessorBlocks() to distinguish getting successor\r\nblocks from getting the full list of SILSuccessors via getSuccessors(). This\r\ncommit just makes all of the successor/predecessor code follow that naming\r\nconvention.\r\n\r\nSome examples:\r\n\r\ngetSingleSuccessor() => getSingleSuccessorBlock().\r\nisSuccessor() => isSuccessorBlock().\r\ngetPreds() => getPredecessorBlocks().\r\n\r\nReally, IMO, we should consider renaming SILSuccessor to a more verbose name so\r\nthat it is clear that it is more of an internal detail of SILBasicBlock's\r\nimplementation rather than something that one should consider as apart of one's\r\nmental model of the IR when one really wants to be thinking about predecessor\r\nand successor blocks. But that is not what this commit is trying to change, it\r\nis just trying to eliminate a bit of technical debt by making the naming\r\nconventions here consistent."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/263144018","html_url":"https://github.com/apple/swift/pull/5939#issuecomment-263144018","issue_url":"https://api.github.com/repos/apple/swift/issues/5939","id":263144018,"user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T20:06:35Z","updated_at":"2016-11-27T20:06:35Z","body":"@swift-ci Please test"}}
{"actor":{"display_login":"gottesmm"}}