{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/64538427","id":64538427,"diff_hunk":"@@ -109,7 +110,7 @@ public function loadChoiceList($value = null)\n                     }\n                 }\n \n-                $id = implode('~', $this->getIdentifierValues($entity));\n+                $id = implode(AdapterInterface::ID_SEPARATOR, $this->getIdentifierValues($entity));","path":"Form/ChoiceList/ModelChoiceLoader.php","position":13,"original_position":13,"commit_id":"3ae72f7f2e7e41770f17abbb452fabba8da445aa","original_commit_id":"3ae72f7f2e7e41770f17abbb452fabba8da445aa","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"Ok, the result is the same BTW.","created_at":"2016-05-25T09:01:58Z","updated_at":"2016-05-25T09:01:58Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3873#discussion_r64538427","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/64538427"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3873#discussion_r64538427"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873","id":71347207,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3873","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3873.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/3873.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3873","number":3873,"state":"open","locked":false,"title":"Add support composite primary key","user":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"body":"Closes #3870\r\n\r\n### Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Remove unneeded sections.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n```markdown\r\n### Added\r\n- Add support for composite primary key in `AbstractAdmin::getSubject`\r\n\r\n### Removed\r\n- Remove primary key validation in `AbstractAdmin::getSubject`\r\n```\r\n\r\n### Subject\r\n\r\nRemove primary key validation because it may extend beyond the constraint `#^[0-9A-Fa-f\\-]+$#` and it can contain a character `~` if it is a composite key.\r\n**SonataAdminBundle** does not work with composite primary key. This PR might remedy the situation.\r\n\r\n@Soullivaneuh you can comment this, why do need constraint for primary key?","created_at":"2016-05-25T08:12:52Z","updated_at":"2016-05-25T09:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c711faf73214fb616bf5001a9bc0e1a9a37698fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3873/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3ae72f7f2e7e41770f17abbb452fabba8da445aa","head":{"label":"peter-gribanov:3.x","ref":"3.x","sha":"3ae72f7f2e7e41770f17abbb452fabba8da445aa","user":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"repo":{"id":59588153,"name":"SonataAdminBundle","full_name":"peter-gribanov/SonataAdminBundle","owner":{"login":"peter-gribanov","id":1954436,"avatar_url":"https://avatars.githubusercontent.com/u/1954436?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-gribanov","html_url":"https://github.com/peter-gribanov","followers_url":"https://api.github.com/users/peter-gribanov/followers","following_url":"https://api.github.com/users/peter-gribanov/following{/other_user}","gists_url":"https://api.github.com/users/peter-gribanov/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gribanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gribanov/subscriptions","organizations_url":"https://api.github.com/users/peter-gribanov/orgs","repos_url":"https://api.github.com/users/peter-gribanov/repos","events_url":"https://api.github.com/users/peter-gribanov/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gribanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter-gribanov/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle","forks_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/peter-gribanov/SonataAdminBundle/deployments","created_at":"2016-05-24T16:04:10Z","updated_at":"2016-05-24T16:04:12Z","pushed_at":"2016-05-25T08:35:51Z","git_url":"git://github.com/peter-gribanov/SonataAdminBundle.git","ssh_url":"git@github.com:peter-gribanov/SonataAdminBundle.git","clone_url":"https://github.com/peter-gribanov/SonataAdminBundle.git","svn_url":"https://github.com/peter-gribanov/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":18222,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"e9aefa59f146143140f38f3d2ffb71776e830001","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-05-24T08:38:14Z","pushed_at":"2016-05-25T08:35:52Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22520,"stargazers_count":1381,"watchers_count":1381,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":375,"forks":982,"open_issues":375,"watchers":1381,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/3873"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3873"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/3873/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/3873/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3ae72f7f2e7e41770f17abbb452fabba8da445aa"}}}}
{"actor":{"display_login":"Soullivaneuh"}}