{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/89439187","pull_request_review_id":9984230,"id":89439187,"diff_hunk":"@@ -25,21 +25,26 @@ export function unzip(zipLocation, unzipLocation) {\n     return defer.promise;\n }\n \n-export function archiveFolder(folderPath, targetPath, zipName) {\n+export async function archiveFolder(folderPath, targetPath, zipName) {\n     var defer = Q.defer();\n     tl.debug('Archiving ' + folderPath + ' to ' + zipName);\n-     gulp.src(path.join(folderPath, '**', '*'),\n-      {\n-        dot: true\n-      })\n-      .pipe(zip(zipName))\n-      .pipe(gulp.dest(targetPath)).on('end', function(error){\n-         if(error) {\n-            defer.reject(error);\n-         }\n-        defer.resolve(path.join(targetPath, zipName));\n-      });\n-      return defer.promise;\n+    var outputZipPath = path.join(targetPath, zipName);\n+    var output = fs.createWriteStream(path.join(targetPath, zipName));","path":"Tasks/Common/webdeployment-common/ziputility.ts","position":37,"original_position":37,"commit_id":"100f0a69fdd99a4fb251823ba46e5e7a9c41ddbd","original_commit_id":"100f0a69fdd99a4fb251823ba46e5e7a9c41ddbd","user":{"login":"vincentdass","id":20121508,"avatar_url":"https://avatars.githubusercontent.com/u/20121508?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentdass","html_url":"https://github.com/vincentdass","followers_url":"https://api.github.com/users/vincentdass/followers","following_url":"https://api.github.com/users/vincentdass/following{/other_user}","gists_url":"https://api.github.com/users/vincentdass/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentdass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentdass/subscriptions","organizations_url":"https://api.github.com/users/vincentdass/orgs","repos_url":"https://api.github.com/users/vincentdass/repos","events_url":"https://api.github.com/users/vincentdass/events{/privacy}","received_events_url":"https://api.github.com/users/vincentdass/received_events","type":"User","site_admin":false},"body":"we can use outputZipPath variable instead","created_at":"2016-11-24T06:01:42Z","updated_at":"2016-11-24T06:01:42Z","html_url":"https://github.com/Microsoft/vsts-tasks/pull/3149#discussion_r89439187","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/89439187"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/3149#discussion_r89439187"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149","id":95115972,"html_url":"https://github.com/Microsoft/vsts-tasks/pull/3149","diff_url":"https://github.com/Microsoft/vsts-tasks/pull/3149.diff","patch_url":"https://github.com/Microsoft/vsts-tasks/pull/3149.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3149","number":3149,"state":"open","locked":false,"title":"Users/subraman/archiverfix","user":{"login":"mvvsubbu","id":11993108,"avatar_url":"https://avatars.githubusercontent.com/u/11993108?v=3","gravatar_id":"","url":"https://api.github.com/users/mvvsubbu","html_url":"https://github.com/mvvsubbu","followers_url":"https://api.github.com/users/mvvsubbu/followers","following_url":"https://api.github.com/users/mvvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mvvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mvvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mvvsubbu/orgs","repos_url":"https://api.github.com/users/mvvsubbu/repos","events_url":"https://api.github.com/users/mvvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mvvsubbu/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-24T04:29:17Z","updated_at":"2016-11-24T06:01:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ba06383af969e5fe60b890c7765264ffec428d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3149/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/100f0a69fdd99a4fb251823ba46e5e7a9c41ddbd","head":{"label":"Microsoft:users/subraman/archiverfix","ref":"users/subraman/archiverfix","sha":"100f0a69fdd99a4fb251823ba46e5e7a9c41ddbd","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2016-11-23T16:24:33Z","pushed_at":"2016-11-24T05:53:00Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"git@github.com:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":24673,"stargazers_count":460,"watchers_count":460,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":114,"forks":416,"open_issues":114,"watchers":460,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4c3b51366d092298b99116e559b6d0da4cd4951d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2016-11-23T16:24:33Z","pushed_at":"2016-11-24T05:53:00Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"git@github.com:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":24673,"stargazers_count":460,"watchers_count":460,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":114,"forks":416,"open_issues":114,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/3149"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3149"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/3149/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/3149/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/100f0a69fdd99a4fb251823ba46e5e7a9c41ddbd"}}}}
{"actor":{"display_login":"vincentdass"}}