{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/86358917","pull_request_review_id":7020026,"id":86358917,"diff_hunk":"@@ -322,29 +327,22 @@ public function getAttributeOrder($attribute)\n     public function link($attribute, $options = [])\n     {\n         if (($direction = $this->getAttributeOrder($attribute)) !== null) {\n-            $class = $direction === SORT_DESC ? 'desc' : 'asc';\n-            if (isset($options['class'])) {\n-                $options['class'] .= ' ' . $class;\n-            } else {\n-                $options['class'] = $class;\n-            }\n+            Html::addCssClass(\n+                $options,\n+                $direction === SORT_DESC ? 'desc' : 'asc'\n+            );","path":"framework/data/Sort.php","position":45,"original_position":45,"commit_id":"2f5cda56cb180b4b2fa29d389215594a5dbe2ea4","original_commit_id":"2f5cda56cb180b4b2fa29d389215594a5dbe2ea4","user":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-11-03T14:44:54Z","updated_at":"2016-11-03T14:44:54Z","html_url":"https://github.com/yiisoft/yii2/pull/12898#discussion_r86358917","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12898","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/86358917"},"html":{"href":"https://github.com/yiisoft/yii2/pull/12898#discussion_r86358917"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12898"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/12898","id":92079791,"html_url":"https://github.com/yiisoft/yii2/pull/12898","diff_url":"https://github.com/yiisoft/yii2/pull/12898.diff","patch_url":"https://github.com/yiisoft/yii2/pull/12898.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/12898","number":12898,"state":"open","locked":false,"title":"fix #4790","user":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Is bugfix?    | yes\r\n| New feature?  | no\r\n| Breaks BC?    | no\r\n| Tests pass?   | yes\r\n| Fixed issues  | #4790\r\n\r\n","created_at":"2016-11-03T00:16:16Z","updated_at":"2016-11-03T14:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf91453a87a9cc4ff8470d417fbf846c111a0c6","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/6","html_url":"https://github.com/yiisoft/yii2/milestones/2.1.x","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/6/labels","id":458001,"number":6,"title":"2.1.x","description":"","creator":{"login":"qiangxue","id":993322,"avatar_url":"https://avatars.githubusercontent.com/u/993322?v=3","gravatar_id":"","url":"https://api.github.com/users/qiangxue","html_url":"https://github.com/qiangxue","followers_url":"https://api.github.com/users/qiangxue/followers","following_url":"https://api.github.com/users/qiangxue/following{/other_user}","gists_url":"https://api.github.com/users/qiangxue/gists{/gist_id}","starred_url":"https://api.github.com/users/qiangxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiangxue/subscriptions","organizations_url":"https://api.github.com/users/qiangxue/orgs","repos_url":"https://api.github.com/users/qiangxue/repos","events_url":"https://api.github.com/users/qiangxue/events{/privacy}","received_events_url":"https://api.github.com/users/qiangxue/received_events","type":"User","site_admin":false},"open_issues":119,"closed_issues":17,"state":"open","created_at":"2013-10-17T21:06:09Z","updated_at":"2016-11-03T09:04:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12898/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/12898/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/12898/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/2f5cda56cb180b4b2fa29d389215594a5dbe2ea4","head":{"label":"Faryshta:Fix4790","ref":"Fix4790","sha":"2f5cda56cb180b4b2fa29d389215594a5dbe2ea4","user":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"repo":{"id":24853652,"name":"yii2","full_name":"Faryshta/yii2","owner":{"login":"Faryshta","id":2029247,"avatar_url":"https://avatars.githubusercontent.com/u/2029247?v=3","gravatar_id":"","url":"https://api.github.com/users/Faryshta","html_url":"https://github.com/Faryshta","followers_url":"https://api.github.com/users/Faryshta/followers","following_url":"https://api.github.com/users/Faryshta/following{/other_user}","gists_url":"https://api.github.com/users/Faryshta/gists{/gist_id}","starred_url":"https://api.github.com/users/Faryshta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faryshta/subscriptions","organizations_url":"https://api.github.com/users/Faryshta/orgs","repos_url":"https://api.github.com/users/Faryshta/repos","events_url":"https://api.github.com/users/Faryshta/events{/privacy}","received_events_url":"https://api.github.com/users/Faryshta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Faryshta/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/Faryshta/yii2","forks_url":"https://api.github.com/repos/Faryshta/yii2/forks","keys_url":"https://api.github.com/repos/Faryshta/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faryshta/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faryshta/yii2/teams","hooks_url":"https://api.github.com/repos/Faryshta/yii2/hooks","issue_events_url":"https://api.github.com/repos/Faryshta/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/Faryshta/yii2/events","assignees_url":"https://api.github.com/repos/Faryshta/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/Faryshta/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/Faryshta/yii2/tags","blobs_url":"https://api.github.com/repos/Faryshta/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faryshta/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faryshta/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faryshta/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faryshta/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/Faryshta/yii2/languages","stargazers_url":"https://api.github.com/repos/Faryshta/yii2/stargazers","contributors_url":"https://api.github.com/repos/Faryshta/yii2/contributors","subscribers_url":"https://api.github.com/repos/Faryshta/yii2/subscribers","subscription_url":"https://api.github.com/repos/Faryshta/yii2/subscription","commits_url":"https://api.github.com/repos/Faryshta/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faryshta/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faryshta/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faryshta/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faryshta/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/Faryshta/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faryshta/yii2/merges","archive_url":"https://api.github.com/repos/Faryshta/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faryshta/yii2/downloads","issues_url":"https://api.github.com/repos/Faryshta/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/Faryshta/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/Faryshta/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/Faryshta/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faryshta/yii2/labels{/name}","releases_url":"https://api.github.com/repos/Faryshta/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/Faryshta/yii2/deployments","created_at":"2014-10-06T16:15:53Z","updated_at":"2016-04-06T00:06:57Z","pushed_at":"2016-11-03T00:14:01Z","git_url":"git://github.com/Faryshta/yii2.git","ssh_url":"git@github.com:Faryshta/yii2.git","clone_url":"https://github.com/Faryshta/yii2.git","svn_url":"https://github.com/Faryshta/yii2","homepage":"http://www.yiiframework.com","size":40254,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"2ff72e470686209175b01a5cecc5bc378feb2ca7","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2016-11-03T14:33:55Z","pushed_at":"2016-11-03T14:37:43Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":64785,"stargazers_count":9012,"watchers_count":9012,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5235,"mirror_url":null,"open_issues_count":872,"forks":5235,"open_issues":872,"watchers":9012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12898"},"html":{"href":"https://github.com/yiisoft/yii2/pull/12898"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12898"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/12898/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12898/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/12898/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/2f5cda56cb180b4b2fa29d389215594a5dbe2ea4"}}}}
{"actor":{"display_login":"cebe"}}