{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/92157500","pull_request_review_id":12666082,"id":92157500,"diff_hunk":"@@ -133,6 +133,7 @@ bool KeyServerData::get_caps(CephContext *cct, const EntityName& name,\n \n KeyServer::KeyServer(CephContext *cct_, KeyRing *extra_secrets)\n   : cct(cct_),\n+    temp_data(extra_secrets),","path":"src/auth/cephx/CephxKeyServer.cc","position":4,"original_position":4,"commit_id":"24903eec4ccfacb568a53a802c366a3eadc0cd6d","original_commit_id":"24903eec4ccfacb568a53a802c366a3eadc0cd6d","user":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"s/temp_data/pending_data/g\r\n\r\nand shall we reset the `pending_data` once the incremental is applied.\r\n","created_at":"2016-12-13T12:21:17Z","updated_at":"2016-12-13T12:44:37Z","html_url":"https://github.com/ceph/ceph/pull/12435#discussion_r92157500","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/12435","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/92157500"},"html":{"href":"https://github.com/ceph/ceph/pull/12435#discussion_r92157500"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12435"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/12435","id":97420282,"html_url":"https://github.com/ceph/ceph/pull/12435","diff_url":"https://github.com/ceph/ceph/pull/12435.diff","patch_url":"https://github.com/ceph/ceph/pull/12435.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/12435","number":12435,"state":"open","locked":false,"title":"Fix:rotate key update problem","user":{"login":"mingyuez","id":13230507,"avatar_url":"https://avatars.githubusercontent.com/u/13230507?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyuez","html_url":"https://github.com/mingyuez","followers_url":"https://api.github.com/users/mingyuez/followers","following_url":"https://api.github.com/users/mingyuez/following{/other_user}","gists_url":"https://api.github.com/users/mingyuez/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyuez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyuez/subscriptions","organizations_url":"https://api.github.com/users/mingyuez/orgs","repos_url":"https://api.github.com/users/mingyuez/repos","events_url":"https://api.github.com/users/mingyuez/events{/privacy}","received_events_url":"https://api.github.com/users/mingyuez/received_events","type":"User","site_admin":false},"body":"Leader mon generates new rotate key every 1 hour. It  will try to trigger proposal,but if current paxos status is not active, this proposal should  wait;\r\nat this moment,if the leader monitor receives peon elect msg, it will call pending_proposal.reset() to drop the proposal.thus making\r\nthe leader mon the only one to use the new rotate key which exists in memory and the key synchronization will not be triggered in the subsequent 1 hour.\r\n\r\nSolution:\r\nWhen the new rotate key is generated, it will be stored into \"temp_data\". The leader mon will not use it until the proposal passes through\r\n\r\nSigned-off-by: mingyuez <zhao.mingyue@h3c.com>","created_at":"2016-12-10T10:21:44Z","updated_at":"2016-12-13T12:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c7539d77058fef63b4594ca17183df193210ddb","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/12435/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/12435/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/12435/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/24903eec4ccfacb568a53a802c366a3eadc0cd6d","head":{"label":"mingyuez:wip-key","ref":"wip-key","sha":"24903eec4ccfacb568a53a802c366a3eadc0cd6d","user":{"login":"mingyuez","id":13230507,"avatar_url":"https://avatars.githubusercontent.com/u/13230507?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyuez","html_url":"https://github.com/mingyuez","followers_url":"https://api.github.com/users/mingyuez/followers","following_url":"https://api.github.com/users/mingyuez/following{/other_user}","gists_url":"https://api.github.com/users/mingyuez/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyuez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyuez/subscriptions","organizations_url":"https://api.github.com/users/mingyuez/orgs","repos_url":"https://api.github.com/users/mingyuez/repos","events_url":"https://api.github.com/users/mingyuez/events{/privacy}","received_events_url":"https://api.github.com/users/mingyuez/received_events","type":"User","site_admin":false},"repo":{"id":63758737,"name":"ceph","full_name":"mingyuez/ceph","owner":{"login":"mingyuez","id":13230507,"avatar_url":"https://avatars.githubusercontent.com/u/13230507?v=3","gravatar_id":"","url":"https://api.github.com/users/mingyuez","html_url":"https://github.com/mingyuez","followers_url":"https://api.github.com/users/mingyuez/followers","following_url":"https://api.github.com/users/mingyuez/following{/other_user}","gists_url":"https://api.github.com/users/mingyuez/gists{/gist_id}","starred_url":"https://api.github.com/users/mingyuez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingyuez/subscriptions","organizations_url":"https://api.github.com/users/mingyuez/orgs","repos_url":"https://api.github.com/users/mingyuez/repos","events_url":"https://api.github.com/users/mingyuez/events{/privacy}","received_events_url":"https://api.github.com/users/mingyuez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mingyuez/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/mingyuez/ceph","forks_url":"https://api.github.com/repos/mingyuez/ceph/forks","keys_url":"https://api.github.com/repos/mingyuez/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mingyuez/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mingyuez/ceph/teams","hooks_url":"https://api.github.com/repos/mingyuez/ceph/hooks","issue_events_url":"https://api.github.com/repos/mingyuez/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/mingyuez/ceph/events","assignees_url":"https://api.github.com/repos/mingyuez/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/mingyuez/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/mingyuez/ceph/tags","blobs_url":"https://api.github.com/repos/mingyuez/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mingyuez/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mingyuez/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/mingyuez/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mingyuez/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/mingyuez/ceph/languages","stargazers_url":"https://api.github.com/repos/mingyuez/ceph/stargazers","contributors_url":"https://api.github.com/repos/mingyuez/ceph/contributors","subscribers_url":"https://api.github.com/repos/mingyuez/ceph/subscribers","subscription_url":"https://api.github.com/repos/mingyuez/ceph/subscription","commits_url":"https://api.github.com/repos/mingyuez/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/mingyuez/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/mingyuez/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/mingyuez/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/mingyuez/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/mingyuez/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mingyuez/ceph/merges","archive_url":"https://api.github.com/repos/mingyuez/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mingyuez/ceph/downloads","issues_url":"https://api.github.com/repos/mingyuez/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/mingyuez/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/mingyuez/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/mingyuez/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mingyuez/ceph/labels{/name}","releases_url":"https://api.github.com/repos/mingyuez/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/mingyuez/ceph/deployments","created_at":"2016-07-20T07:05:16Z","updated_at":"2016-07-20T07:05:37Z","pushed_at":"2016-12-10T11:08:51Z","git_url":"git://github.com/mingyuez/ceph.git","ssh_url":"git@github.com:mingyuez/ceph.git","clone_url":"https://github.com/mingyuez/ceph.git","svn_url":"https://github.com/mingyuez/ceph","homepage":"http://ceph.com","size":189036,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"b40603f60ab5fcbd45144707805d1bf0a4c2cca2","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-12-13T10:20:32Z","pushed_at":"2016-12-13T11:55:34Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":256718,"stargazers_count":2705,"watchers_count":2705,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1584,"mirror_url":null,"open_issues_count":383,"forks":1584,"open_issues":383,"watchers":2705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12435"},"html":{"href":"https://github.com/ceph/ceph/pull/12435"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/12435"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/12435/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12435/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/12435/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/24903eec4ccfacb568a53a802c366a3eadc0cd6d"}}}}
{"actor":{"display_login":"tchaikov"}}