{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/92076121","pull_request_review_id":12585766,"id":92076121,"diff_hunk":"@@ -154,17 +154,23 @@\n   }\n \n   # autosign file\n-  if $::puppet::server_ca and ! is_bool($puppet::autosign) {\n-    file { $puppet::autosign:\n-      ensure => file,\n-      owner  => $puppet::user,\n-      group  => $puppet::group,\n-      mode   => $puppet::autosign_mode,\n-    }\n-    if !empty($puppet::autosign_entries) {\n-      File[$puppet::autosign] {\n-        content => template('puppet/server/autosign.conf.erb'),\n+  if $::puppet::server_ca and ! is_bool($puppet::server::autosign){\n+    if $::puppet::server::autosign_content {\n+      if !empty($::puppet::server::autosign_entries) {\n+        fail('Cannot set both autosign_content and autosign_entries')","path":"manifests/server/config.pp","position":17,"original_position":17,"commit_id":"65ac016d7f5d15aa7d990ebe184db679ed9ff927","original_commit_id":"65ac016d7f5d15aa7d990ebe184db679ed9ff927","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"body":"could you add a test for this? grep for `it { should raise_error` in the existing tests.","created_at":"2016-12-13T00:52:02Z","updated_at":"2016-12-13T00:52:02Z","html_url":"https://github.com/theforeman/puppet-puppet/pull/416#discussion_r92076121","pull_request_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/92076121"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/416#discussion_r92076121"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416","id":75267671,"html_url":"https://github.com/theforeman/puppet-puppet/pull/416","diff_url":"https://github.com/theforeman/puppet-puppet/pull/416.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/416.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/416","number":416,"state":"open","locked":false,"title":"Allowing the user to supply autosign content template.","user":{"login":"nick-george","id":7453754,"avatar_url":"https://avatars.githubusercontent.com/u/7453754?v=3","gravatar_id":"","url":"https://api.github.com/users/nick-george","html_url":"https://github.com/nick-george","followers_url":"https://api.github.com/users/nick-george/followers","following_url":"https://api.github.com/users/nick-george/following{/other_user}","gists_url":"https://api.github.com/users/nick-george/gists{/gist_id}","starred_url":"https://api.github.com/users/nick-george/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick-george/subscriptions","organizations_url":"https://api.github.com/users/nick-george/orgs","repos_url":"https://api.github.com/users/nick-george/repos","events_url":"https://api.github.com/users/nick-george/events{/privacy}","received_events_url":"https://api.github.com/users/nick-george/received_events","type":"User","site_admin":false},"body":"Here is a patch that allows the module user to supply the content of the autosign file. It fixes issue GH-413. I attempted to run all the tests against the patch but there must be something wrong with my ruby setup, as \"rake spec\" spewed tons (thousands) of error messages.  \n\nCheers, \nNick\n","created_at":"2016-06-27T07:36:56Z","updated_at":"2016-12-13T00:52:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e12e2503ece11887c877bb76e6ad4114ddc48428","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/416/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/65ac016d7f5d15aa7d990ebe184db679ed9ff927","head":{"label":"nick-george:nick-george-GH-413-fix","ref":"nick-george-GH-413-fix","sha":"65ac016d7f5d15aa7d990ebe184db679ed9ff927","user":{"login":"nick-george","id":7453754,"avatar_url":"https://avatars.githubusercontent.com/u/7453754?v=3","gravatar_id":"","url":"https://api.github.com/users/nick-george","html_url":"https://github.com/nick-george","followers_url":"https://api.github.com/users/nick-george/followers","following_url":"https://api.github.com/users/nick-george/following{/other_user}","gists_url":"https://api.github.com/users/nick-george/gists{/gist_id}","starred_url":"https://api.github.com/users/nick-george/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick-george/subscriptions","organizations_url":"https://api.github.com/users/nick-george/orgs","repos_url":"https://api.github.com/users/nick-george/repos","events_url":"https://api.github.com/users/nick-george/events{/privacy}","received_events_url":"https://api.github.com/users/nick-george/received_events","type":"User","site_admin":false},"repo":{"id":61879792,"name":"puppet-puppet","full_name":"nick-george/puppet-puppet","owner":{"login":"nick-george","id":7453754,"avatar_url":"https://avatars.githubusercontent.com/u/7453754?v=3","gravatar_id":"","url":"https://api.github.com/users/nick-george","html_url":"https://github.com/nick-george","followers_url":"https://api.github.com/users/nick-george/followers","following_url":"https://api.github.com/users/nick-george/following{/other_user}","gists_url":"https://api.github.com/users/nick-george/gists{/gist_id}","starred_url":"https://api.github.com/users/nick-george/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nick-george/subscriptions","organizations_url":"https://api.github.com/users/nick-george/orgs","repos_url":"https://api.github.com/users/nick-george/repos","events_url":"https://api.github.com/users/nick-george/events{/privacy}","received_events_url":"https://api.github.com/users/nick-george/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nick-george/puppet-puppet","description":"Puppet module for Puppet client and server","fork":true,"url":"https://api.github.com/repos/nick-george/puppet-puppet","forks_url":"https://api.github.com/repos/nick-george/puppet-puppet/forks","keys_url":"https://api.github.com/repos/nick-george/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nick-george/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nick-george/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/nick-george/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/nick-george/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/nick-george/puppet-puppet/events","assignees_url":"https://api.github.com/repos/nick-george/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/nick-george/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/nick-george/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/nick-george/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nick-george/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nick-george/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/nick-george/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nick-george/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/nick-george/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/nick-george/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/nick-george/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/nick-george/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/nick-george/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/nick-george/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/nick-george/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/nick-george/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/nick-george/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/nick-george/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/nick-george/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nick-george/puppet-puppet/merges","archive_url":"https://api.github.com/repos/nick-george/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nick-george/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/nick-george/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/nick-george/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/nick-george/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/nick-george/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nick-george/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/nick-george/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/nick-george/puppet-puppet/deployments","created_at":"2016-06-24T11:26:34Z","updated_at":"2016-10-29T06:52:01Z","pushed_at":"2016-12-12T23:03:54Z","git_url":"git://github.com/nick-george/puppet-puppet.git","ssh_url":"git@github.com:nick-george/puppet-puppet.git","clone_url":"https://github.com/nick-george/puppet-puppet.git","svn_url":"https://github.com/nick-george/puppet-puppet","homepage":"","size":949,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"3e90793358901dd93f218ec762977a1d79710aa6","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449635,"name":"puppet-puppet","full_name":"theforeman/puppet-puppet","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-puppet","description":"Puppet module for Puppet client and server","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-puppet","forks_url":"https://api.github.com/repos/theforeman/puppet-puppet/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-puppet/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-puppet/deployments","created_at":"2012-02-15T13:23:34Z","updated_at":"2016-11-18T18:12:53Z","pushed_at":"2016-12-12T23:03:55Z","git_url":"git://github.com/theforeman/puppet-puppet.git","ssh_url":"git@github.com:theforeman/puppet-puppet.git","clone_url":"https://github.com/theforeman/puppet-puppet.git","svn_url":"https://github.com/theforeman/puppet-puppet","homepage":"","size":1397,"stargazers_count":59,"watchers_count":59,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":16,"forks":159,"open_issues":16,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/416"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/416"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/65ac016d7f5d15aa7d990ebe184db679ed9ff927"}}}}
{"actor":{"display_login":"mmoll"}}