{"action":"created","issue":{"url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/117","labels_url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/117/comments","events_url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/117/events","html_url":"https://github.com/HenrikJoreteg/hjs-webpack/pull/117","id":123652231,"number":117,"title":"Move from react-hot-loader to react-transform","user":{"login":"Dignifiedquire","id":790842,"avatar_url":"https://avatars.githubusercontent.com/u/790842?v=3","gravatar_id":"","url":"https://api.github.com/users/Dignifiedquire","html_url":"https://github.com/Dignifiedquire","followers_url":"https://api.github.com/users/Dignifiedquire/followers","following_url":"https://api.github.com/users/Dignifiedquire/following{/other_user}","gists_url":"https://api.github.com/users/Dignifiedquire/gists{/gist_id}","starred_url":"https://api.github.com/users/Dignifiedquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dignifiedquire/subscriptions","organizations_url":"https://api.github.com/users/Dignifiedquire/orgs","repos_url":"https://api.github.com/users/Dignifiedquire/repos","events_url":"https://api.github.com/users/Dignifiedquire/events{/privacy}","received_events_url":"https://api.github.com/users/Dignifiedquire/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-23T12:34:08Z","updated_at":"2016-01-14T19:48:17Z","closed_at":"2016-01-13T01:18:07Z","pull_request":{"url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/pulls/117","html_url":"https://github.com/HenrikJoreteg/hjs-webpack/pull/117","diff_url":"https://github.com/HenrikJoreteg/hjs-webpack/pull/117.diff","patch_url":"https://github.com/HenrikJoreteg/hjs-webpack/pull/117.patch"},"body":"This is the PR for resolving #65. I tried to do the following things\r\n\r\n* Provide own binary `hjs-dev-server` which replaces `webpack-dev-server`\r\n* Make upgrading as simple as possible\r\n* Upgrade two examples to use the new hot reloading (`assets-and-index-html`, `prerendered-html-files) and upgrade one to not use hot reloading (`just-assets-no-html`)\r\n* Add upgrade guide in the readme\r\n\r\nThings are working well for me locally, but now I need some more eyes on this, especially to check if this is all in line with the project. \r\n\r\n**Update:** Still missing `https` support at the moment."},"comment":{"url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/comments/171758066","html_url":"https://github.com/HenrikJoreteg/hjs-webpack/pull/117#issuecomment-171758066","issue_url":"https://api.github.com/repos/HenrikJoreteg/hjs-webpack/issues/117","id":171758066,"user":{"login":"lukekarrys","id":542108,"avatar_url":"https://avatars.githubusercontent.com/u/542108?v=3","gravatar_id":"","url":"https://api.github.com/users/lukekarrys","html_url":"https://github.com/lukekarrys","followers_url":"https://api.github.com/users/lukekarrys/followers","following_url":"https://api.github.com/users/lukekarrys/following{/other_user}","gists_url":"https://api.github.com/users/lukekarrys/gists{/gist_id}","starred_url":"https://api.github.com/users/lukekarrys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukekarrys/subscriptions","organizations_url":"https://api.github.com/users/lukekarrys/orgs","repos_url":"https://api.github.com/users/lukekarrys/repos","events_url":"https://api.github.com/users/lukekarrys/events{/privacy}","received_events_url":"https://api.github.com/users/lukekarrys/received_events","type":"User","site_admin":false},"created_at":"2016-01-14T19:48:17Z","updated_at":"2016-01-14T19:48:17Z","body":"Ok, a few more changes from me using this:\r\n\r\n* Added support for `historyApiFallback` just like in [`webpack-dev-server`](https://github.com/webpack/webpack-dev-server/blob/33ebd1f9f702068ed850227ef7c74065dc3849e7/lib/Server.js#L12) which allows you to reload you app at any url and be served the index file.\r\n\r\n* Removed setting any babel options from `lib/installed-hot-loaders`. When using this with a project that already has a `.babelrc` (which I bet is almost every project), that config takes precedence, so the user might not get hot reloading if they dont have a proper config.\r\n\r\n* Made the recommended upgrade path to use `babel-preset-hmre` for hot reloading\r\n\r\n* Cleaned up the devServer config a bit and it now passes all options to `webpack-dev-middleware` to allow users to customize that any way they want"}}