{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/86908201","pull_request_review_id":7542581,"id":86908201,"diff_hunk":"@@ -192,51 +196,61 @@ void serial_init(serial_t *obj, PinName tx, PinName rx)\n #endif\n \n     // For stdio management\n-    if (obj == &stdio_uart) {\n+    if (obj->serial.uart == STDIO_UART) {\n         stdio_uart_inited = 1;\n-        /* NOTE: Not required anymore because stdio_uart will be manually initialized in mbed-drivers/source/retarget.cpp from mbed beta */\n-        //memcpy(&stdio_uart, obj, sizeof(serial_t));\n+        memcpy(&stdio_uart, obj, sizeof(serial_t));","path":"targets/TARGET_NUVOTON/TARGET_M451/serial_api.c","position":108,"original_position":108,"commit_id":"4ae76be2ced93c78499b2b612183d96098d6faa4","original_commit_id":"e09d9a15f5a9450d1f16ce336cc0f954db6053ea","user":{"login":"ccli8","id":15923441,"avatar_url":"https://avatars.githubusercontent.com/u/15923441?v=3","gravatar_id":"","url":"https://api.github.com/users/ccli8","html_url":"https://github.com/ccli8","followers_url":"https://api.github.com/users/ccli8/followers","following_url":"https://api.github.com/users/ccli8/following{/other_user}","gists_url":"https://api.github.com/users/ccli8/gists{/gist_id}","starred_url":"https://api.github.com/users/ccli8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccli8/subscriptions","organizations_url":"https://api.github.com/users/ccli8/orgs","repos_url":"https://api.github.com/users/ccli8/repos","events_url":"https://api.github.com/users/ccli8/events{/privacy}","received_events_url":"https://api.github.com/users/ccli8/received_events","type":"User","site_admin":false},"body":"@0xc0170 That was to meet mbed OS 3.0. Now I change it back to meet mbed OS 2.0/5.0.","created_at":"2016-11-08T01:35:08Z","updated_at":"2016-11-08T01:35:08Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/3211#discussion_r86908201","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/86908201"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3211#discussion_r86908201"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211","id":92535436,"html_url":"https://github.com/ARMmbed/mbed-os/pull/3211","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3211.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3211.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3211","number":3211,"state":"open","locked":false,"title":"[NUC472/M453] Support single UART shared by multiple serial objects and other updates","user":{"login":"ccli8","id":15923441,"avatar_url":"https://avatars.githubusercontent.com/u/15923441?v=3","gravatar_id":"","url":"https://api.github.com/users/ccli8","html_url":"https://github.com/ccli8","followers_url":"https://api.github.com/users/ccli8/followers","following_url":"https://api.github.com/users/ccli8/following{/other_user}","gists_url":"https://api.github.com/users/ccli8/gists{/gist_id}","starred_url":"https://api.github.com/users/ccli8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccli8/subscriptions","organizations_url":"https://api.github.com/users/ccli8/orgs","repos_url":"https://api.github.com/users/ccli8/repos","events_url":"https://api.github.com/users/ccli8/events{/privacy}","received_events_url":"https://api.github.com/users/ccli8/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR patches for the targets NuMaker-PFM-NUC472 and NuMaker-PFM-M453 and has the following modifications:\r\n1. Fix greentea test failed. This is caused by no support for single UART H/W module shared by multiple serial S/W objects.\r\n1. Reduce interrupt stack size from 12/4 KB to 2 KB.\r\n1. Remove dead code in device.h.\r\n","created_at":"2016-11-07T07:30:24Z","updated_at":"2016-11-08T01:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fef48713fa0ba485c2cccc9f07f1217cc875f4c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3211/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/4ae76be2ced93c78499b2b612183d96098d6faa4","head":{"label":"OpenNuvoton:nuvoton","ref":"nuvoton","sha":"4ae76be2ced93c78499b2b612183d96098d6faa4","user":{"login":"OpenNuvoton","id":18352608,"avatar_url":"https://avatars.githubusercontent.com/u/18352608?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNuvoton","html_url":"https://github.com/OpenNuvoton","followers_url":"https://api.github.com/users/OpenNuvoton/followers","following_url":"https://api.github.com/users/OpenNuvoton/following{/other_user}","gists_url":"https://api.github.com/users/OpenNuvoton/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNuvoton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNuvoton/subscriptions","organizations_url":"https://api.github.com/users/OpenNuvoton/orgs","repos_url":"https://api.github.com/users/OpenNuvoton/repos","events_url":"https://api.github.com/users/OpenNuvoton/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNuvoton/received_events","type":"Organization","site_admin":false},"repo":{"id":63859220,"name":"mbed","full_name":"OpenNuvoton/mbed","owner":{"login":"OpenNuvoton","id":18352608,"avatar_url":"https://avatars.githubusercontent.com/u/18352608?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNuvoton","html_url":"https://github.com/OpenNuvoton","followers_url":"https://api.github.com/users/OpenNuvoton/followers","following_url":"https://api.github.com/users/OpenNuvoton/following{/other_user}","gists_url":"https://api.github.com/users/OpenNuvoton/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNuvoton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNuvoton/subscriptions","organizations_url":"https://api.github.com/users/OpenNuvoton/orgs","repos_url":"https://api.github.com/users/OpenNuvoton/repos","events_url":"https://api.github.com/users/OpenNuvoton/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNuvoton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNuvoton/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/OpenNuvoton/mbed","forks_url":"https://api.github.com/repos/OpenNuvoton/mbed/forks","keys_url":"https://api.github.com/repos/OpenNuvoton/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNuvoton/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNuvoton/mbed/teams","hooks_url":"https://api.github.com/repos/OpenNuvoton/mbed/hooks","issue_events_url":"https://api.github.com/repos/OpenNuvoton/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNuvoton/mbed/events","assignees_url":"https://api.github.com/repos/OpenNuvoton/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNuvoton/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNuvoton/mbed/tags","blobs_url":"https://api.github.com/repos/OpenNuvoton/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNuvoton/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNuvoton/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNuvoton/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNuvoton/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNuvoton/mbed/languages","stargazers_url":"https://api.github.com/repos/OpenNuvoton/mbed/stargazers","contributors_url":"https://api.github.com/repos/OpenNuvoton/mbed/contributors","subscribers_url":"https://api.github.com/repos/OpenNuvoton/mbed/subscribers","subscription_url":"https://api.github.com/repos/OpenNuvoton/mbed/subscription","commits_url":"https://api.github.com/repos/OpenNuvoton/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNuvoton/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNuvoton/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNuvoton/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNuvoton/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNuvoton/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNuvoton/mbed/merges","archive_url":"https://api.github.com/repos/OpenNuvoton/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNuvoton/mbed/downloads","issues_url":"https://api.github.com/repos/OpenNuvoton/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNuvoton/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNuvoton/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNuvoton/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNuvoton/mbed/labels{/name}","releases_url":"https://api.github.com/repos/OpenNuvoton/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNuvoton/mbed/deployments","created_at":"2016-07-21T10:13:33Z","updated_at":"2016-07-21T10:14:34Z","pushed_at":"2016-11-07T07:14:29Z","git_url":"git://github.com/OpenNuvoton/mbed.git","ssh_url":"git@github.com:OpenNuvoton/mbed.git","clone_url":"https://github.com/OpenNuvoton/mbed.git","svn_url":"https://github.com/OpenNuvoton/mbed","homepage":"","size":85671,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"03b8ae1811fe7aeb1a9d5d5cb20340062d6dc999","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-11-07T17:00:44Z","pushed_at":"2016-11-08T01:15:53Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":110137,"stargazers_count":804,"watchers_count":804,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":795,"mirror_url":null,"open_issues_count":396,"forks":795,"open_issues":396,"watchers":804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3211"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3211"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3211/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3211/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/4ae76be2ced93c78499b2b612183d96098d6faa4"}}}}
{"actor":{"display_login":"ccli8"}}