{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/buck/issues/652","repository_url":"https://api.github.com/repos/facebook/buck","labels_url":"https://api.github.com/repos/facebook/buck/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/facebook/buck/issues/652/comments","events_url":"https://api.github.com/repos/facebook/buck/issues/652/events","html_url":"https://github.com/facebook/buck/pull/652","id":133142334,"number":652,"title":"Fix OnDiskMavenDownloader path not resolving properly on windows","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/buck/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/buck/labels/GH%20Review:%20needs-revision","name":"GH Review: needs-revision","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-02-12T02:28:55Z","updated_at":"2016-02-12T16:52:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/652","html_url":"https://github.com/facebook/buck/pull/652","diff_url":"https://github.com/facebook/buck/pull/652.diff","patch_url":"https://github.com/facebook/buck/pull/652.patch"},"body":"OnDiskMavenDownloader#fetch used root.resolve to convert the uri returned from the MavenUrlDecoder to a local file scheme. This did not work on Windows because of the drive letter.\r\n```\r\nfile:///C:/com/android/support/support-v4/23.0.1/support-v4-23.0.1.aar\r\n```\r\non windows vs\r\n```\r\nfile:///com/android/support/support-v4/23.0.1/support-v4-23.0.1.aar\r\n```\r\non mac/linux\r\n\r\nThis removes the extra uri conversion that was breaking the path because it is only used to log the DownloadEvent which can use the actual target path instead.\r\n\r\nTested by downloading support-v4 while building react-native on both mac and windows.\r\n\r\nFixes the 2nd issue in #649"},"comment":{"url":"https://api.github.com/repos/facebook/buck/issues/comments/183409571","html_url":"https://github.com/facebook/buck/pull/652#issuecomment-183409571","issue_url":"https://api.github.com/repos/facebook/buck/issues/652","id":183409571,"user":{"login":"sdwilsh","id":656602,"avatar_url":"https://avatars.githubusercontent.com/u/656602?v=3","gravatar_id":"","url":"https://api.github.com/users/sdwilsh","html_url":"https://github.com/sdwilsh","followers_url":"https://api.github.com/users/sdwilsh/followers","following_url":"https://api.github.com/users/sdwilsh/following{/other_user}","gists_url":"https://api.github.com/users/sdwilsh/gists{/gist_id}","starred_url":"https://api.github.com/users/sdwilsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdwilsh/subscriptions","organizations_url":"https://api.github.com/users/sdwilsh/orgs","repos_url":"https://api.github.com/users/sdwilsh/repos","events_url":"https://api.github.com/users/sdwilsh/events{/privacy}","received_events_url":"https://api.github.com/users/sdwilsh/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T16:52:31Z","updated_at":"2016-02-12T16:52:31Z","body":"Whoops.  You've got some lint failures that you can see if you run `ant lint`.  CI is busted right now, but @bolinfest is looking into getting that resolved."}}