{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/buildtools/issues/616","repository_url":"https://api.github.com/repos/dotnet/buildtools","labels_url":"https://api.github.com/repos/dotnet/buildtools/issues/616/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/616/comments","events_url":"https://api.github.com/repos/dotnet/buildtools/issues/616/events","html_url":"https://github.com/dotnet/buildtools/pull/616","id":146153506,"number":616,"title":"Update PrereleaseResolveNugetPackageAssets to support project references, use project reference for test-runtime","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/buildtools/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-04-06T00:57:29Z","updated_at":"2016-04-11T19:19:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/616","html_url":"https://github.com/dotnet/buildtools/pull/616","diff_url":"https://github.com/dotnet/buildtools/pull/616.diff","patch_url":"https://github.com/dotnet/buildtools/pull/616.patch"},"body":"This updates the fork we have of PrereleaseResolveNugetPackageAssets in order to support the use of project references in dependencies. This will allow us to reference the test-runtime project in corefx from the dependencies of each test project. This will allow nuget to do proper resolution of the combined set of dependencies, which is an improvement over the error-prone way we are currently combining the two. It will also allow us to more easily reference a different test-runtime, for example.\r\n\r\nIncludes the following changes:\r\n\r\n* Updated fork of Nuget code. This is mostly verbatim from the nuget sources, but does include some changes to maintain compatibility with our build system. Long-term we need to move off of having a fork of this code.\r\n* Update ValidateProjectDependencyVersions to handle previously-unexpected values in the project.json file.\r\n* Update publishtest.targets. We no longer restore both the test-runtime project.json and the test's project.json. We only restore the test's project.json and resolve assets from it. The test project.json must now have a reference to a test-runtime to use, or more specifically must include references to all of the runtime dependencies that it needs to run tests.\r\n\r\nDon't merge this yet, I need to prepare and test changes to go along with this in corefx and WCF.\r\n\r\n@ericstj , @weshaggard"},"comment":{"url":"https://api.github.com/repos/dotnet/buildtools/issues/comments/208510204","html_url":"https://github.com/dotnet/buildtools/pull/616#issuecomment-208510204","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/616","id":208510204,"user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T19:19:23Z","updated_at":"2016-04-11T19:19:23Z","body":"I went ahead and fixed up WCF as well. There weren't very many changes needed there:\r\n\r\nhttps://github.com/dotnet/wcf/compare/master...mellinoe:test-runtime-projectref\r\n\r\n@weshaggard This should be good to go as long as you have no more reservations. I have changes ready for both corefx and WCF which should account for any breaking changes made here."}}