{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/53935772","id":53935772,"diff_hunk":"@@ -309,6 +246,17 @@ private function userAttributes() {\n \t}\n \n \t/**\n+\t * @return PermissionsService\n+\t */\n+\tprivate static function permissionsService() {","path":"includes/User.php","position":113,"original_position":113,"commit_id":"0c45fc5e2de2c8ad4d3bff8c0d5026f17fb824a0","original_commit_id":"9ff663419463d5ccac227a023b25d746fc567bd4","user":{"login":"wladekb","id":811686,"avatar_url":"https://avatars.githubusercontent.com/u/811686?v=3","gravatar_id":"","url":"https://api.github.com/users/wladekb","html_url":"https://github.com/wladekb","followers_url":"https://api.github.com/users/wladekb/followers","following_url":"https://api.github.com/users/wladekb/following{/other_user}","gists_url":"https://api.github.com/users/wladekb/gists{/gist_id}","starred_url":"https://api.github.com/users/wladekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wladekb/subscriptions","organizations_url":"https://api.github.com/users/wladekb/orgs","repos_url":"https://api.github.com/users/wladekb/repos","events_url":"https://api.github.com/users/wladekb/events{/privacy}","received_events_url":"https://api.github.com/users/wladekb/received_events","type":"User","site_admin":false},"body":"`use PermissionsAccessor` ?","created_at":"2016-02-24T13:15:30Z","updated_at":"2016-02-24T13:15:30Z","html_url":"https://github.com/Wikia/app/pull/9720#discussion_r53935772","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/9720","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/53935772"},"html":{"href":"https://github.com/Wikia/app/pull/9720#discussion_r53935772"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/9720"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/9720","id":59487240,"html_url":"https://github.com/Wikia/app/pull/9720","diff_url":"https://github.com/Wikia/app/pull/9720.diff","patch_url":"https://github.com/Wikia/app/pull/9720.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/9720","number":9720,"state":"open","locked":false,"title":"[PLATFORM-1483] User permissions lib - Do Not Merge","user":{"login":"jcellary","id":7473307,"avatar_url":"https://avatars.githubusercontent.com/u/7473307?v=3","gravatar_id":"","url":"https://api.github.com/users/jcellary","html_url":"https://github.com/jcellary","followers_url":"https://api.github.com/users/jcellary/followers","following_url":"https://api.github.com/users/jcellary/following{/other_user}","gists_url":"https://api.github.com/users/jcellary/gists{/gist_id}","starred_url":"https://api.github.com/users/jcellary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcellary/subscriptions","organizations_url":"https://api.github.com/users/jcellary/orgs","repos_url":"https://api.github.com/users/jcellary/repos","events_url":"https://api.github.com/users/jcellary/events{/privacy}","received_events_url":"https://api.github.com/users/jcellary/received_events","type":"User","site_admin":false},"body":"This PR is a WIP for centralizing permission handling inside of media wiki, so that later on we can move that logic to the user permissions service.\r\n\r\nFor that purpose a new permission service lib has been introduced (similarly to user preferences) and all logic from the User class is moved to the lib. Methods in the User class now only serve as a proxy. \r\n\r\nFrom an altered lines perspective most of changes are moving permission definition to a single file located in config repo.\r\n\r\nOther changes include\r\n- Removal of unused extension 3rdparty/SpecialProtectSite (not to confuse with wikia/SpecialProtectSite)\r\n- Removal of WIKIA_ENV_INTERNAL (retired wikia one)\r\n- Removal of unused autopromote once functionality\r\n- Removal of some of the hooks and global variables to help encapsulation\r\n\r\nThis is still a WIP - that is implementaion is finished, but I'm still testing. I created this PR the get your opinion on the introduced changes. This PR needs to processed together with the corresponding PR in config repo: https://github.com/Wikia/config/pull/1620","created_at":"2016-02-16T13:01:23Z","updated_at":"2016-02-24T13:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d4580e61f81464a4048b1082104cff986553c0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/9720/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/9720/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/9720/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/0c45fc5e2de2c8ad4d3bff8c0d5026f17fb824a0","head":{"label":"Wikia:user-permissions-lib","ref":"user-permissions-lib","sha":"0c45fc5e2de2c8ad4d3bff8c0d5026f17fb824a0","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-02-10T06:38:01Z","pushed_at":"2016-02-24T13:13:40Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":667806,"stargazers_count":98,"watchers_count":98,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":95,"forks":72,"open_issues":95,"watchers":98,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"551642a2d45e62f383c4c7c0c914e5be6806c115","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-02-10T06:38:01Z","pushed_at":"2016-02-24T13:13:40Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":667806,"stargazers_count":98,"watchers_count":98,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":95,"forks":72,"open_issues":95,"watchers":98,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/9720"},"html":{"href":"https://github.com/Wikia/app/pull/9720"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/9720"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/9720/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/9720/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/9720/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/0c45fc5e2de2c8ad4d3bff8c0d5026f17fb824a0"}}}}