{"action":"created","comment":{"url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/comments/91469736","pull_request_review_id":11977098,"id":91469736,"diff_hunk":"@@ -0,0 +1,60 @@\n+<LDAP>\n+\t# LDAP server URL\n+\tURL\t\t{{ ldap.url }}\n+\n+\t{% if ldap.anonymous_bind == false %}\n+\t# Bind DN (If your LDAP server doesn't support anonymous binds)\n+\tBindDN\t\t{{ ldap.bind_dn }}\n+\t# Bind Password\n+\tPassword\t{{ ldap.bind_password }}\n+    {% endif %}","path":"templates/ldap.conf.j2","position":10,"original_position":10,"commit_id":"af5df2c5fd5db8a2608b47dcac17622ca7ca56f2","original_commit_id":"af5df2c5fd5db8a2608b47dcac17622ca7ca56f2","user":{"login":"Sispheor","id":2573405,"avatar_url":"https://avatars.githubusercontent.com/u/2573405?v=3","gravatar_id":"","url":"https://api.github.com/users/Sispheor","html_url":"https://github.com/Sispheor","followers_url":"https://api.github.com/users/Sispheor/followers","following_url":"https://api.github.com/users/Sispheor/following{/other_user}","gists_url":"https://api.github.com/users/Sispheor/gists{/gist_id}","starred_url":"https://api.github.com/users/Sispheor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sispheor/subscriptions","organizations_url":"https://api.github.com/users/Sispheor/orgs","repos_url":"https://api.github.com/users/Sispheor/repos","events_url":"https://api.github.com/users/Sispheor/events{/privacy}","received_events_url":"https://api.github.com/users/Sispheor/received_events","type":"User","site_admin":false},"body":"It's weird. In my IDe I have no spaces at all. I don't know why the Github preview is showing one.\r\n![image](https://cloud.githubusercontent.com/assets/2573405/21003537/30d44bb0-bd2c-11e6-8cf2-eba455e8fa71.png)\r\n","created_at":"2016-12-08T08:54:25Z","updated_at":"2016-12-08T08:54:25Z","html_url":"https://github.com/kyl191/ansible-role-openvpn/pull/14#discussion_r91469736","pull_request_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/comments/91469736"},"html":{"href":"https://github.com/kyl191/ansible-role-openvpn/pull/14#discussion_r91469736"},"pull_request":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14","id":96702284,"html_url":"https://github.com/kyl191/ansible-role-openvpn/pull/14","diff_url":"https://github.com/kyl191/ansible-role-openvpn/pull/14.diff","patch_url":"https://github.com/kyl191/ansible-role-openvpn/pull/14.patch","issue_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/14","number":14,"state":"open","locked":false,"title":"Ldap support","user":{"login":"Sispheor","id":2573405,"avatar_url":"https://avatars.githubusercontent.com/u/2573405?v=3","gravatar_id":"","url":"https://api.github.com/users/Sispheor","html_url":"https://github.com/Sispheor","followers_url":"https://api.github.com/users/Sispheor/followers","following_url":"https://api.github.com/users/Sispheor/following{/other_user}","gists_url":"https://api.github.com/users/Sispheor/gists{/gist_id}","starred_url":"https://api.github.com/users/Sispheor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sispheor/subscriptions","organizations_url":"https://api.github.com/users/Sispheor/orgs","repos_url":"https://api.github.com/users/Sispheor/repos","events_url":"https://api.github.com/users/Sispheor/events{/privacy}","received_events_url":"https://api.github.com/users/Sispheor/received_events","type":"User","site_admin":false},"body":"What have been done:\r\n- add ldap support (LDAP/AD)\r\n- refactor YAML declaration to match the new Ansible recommendation\r\n- review doc, all variables are documented","created_at":"2016-12-06T10:58:36Z","updated_at":"2016-12-08T08:54:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a913242252892e926385c49ac597dab7fda207","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14/commits","review_comments_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14/comments","review_comment_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/14/comments","statuses_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/statuses/af5df2c5fd5db8a2608b47dcac17622ca7ca56f2","head":{"label":"Sispheor:ldap_support","ref":"ldap_support","sha":"af5df2c5fd5db8a2608b47dcac17622ca7ca56f2","user":{"login":"Sispheor","id":2573405,"avatar_url":"https://avatars.githubusercontent.com/u/2573405?v=3","gravatar_id":"","url":"https://api.github.com/users/Sispheor","html_url":"https://github.com/Sispheor","followers_url":"https://api.github.com/users/Sispheor/followers","following_url":"https://api.github.com/users/Sispheor/following{/other_user}","gists_url":"https://api.github.com/users/Sispheor/gists{/gist_id}","starred_url":"https://api.github.com/users/Sispheor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sispheor/subscriptions","organizations_url":"https://api.github.com/users/Sispheor/orgs","repos_url":"https://api.github.com/users/Sispheor/repos","events_url":"https://api.github.com/users/Sispheor/events{/privacy}","received_events_url":"https://api.github.com/users/Sispheor/received_events","type":"User","site_admin":false},"repo":{"id":75616564,"name":"ansible-role-openvpn","full_name":"Sispheor/ansible-role-openvpn","owner":{"login":"Sispheor","id":2573405,"avatar_url":"https://avatars.githubusercontent.com/u/2573405?v=3","gravatar_id":"","url":"https://api.github.com/users/Sispheor","html_url":"https://github.com/Sispheor","followers_url":"https://api.github.com/users/Sispheor/followers","following_url":"https://api.github.com/users/Sispheor/following{/other_user}","gists_url":"https://api.github.com/users/Sispheor/gists{/gist_id}","starred_url":"https://api.github.com/users/Sispheor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sispheor/subscriptions","organizations_url":"https://api.github.com/users/Sispheor/orgs","repos_url":"https://api.github.com/users/Sispheor/repos","events_url":"https://api.github.com/users/Sispheor/events{/privacy}","received_events_url":"https://api.github.com/users/Sispheor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sispheor/ansible-role-openvpn","description":"Ansible Playbook for OpenVPN on CentOS/Fedora/RHEL clones","fork":true,"url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn","forks_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/forks","keys_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/teams","hooks_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/hooks","issue_events_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/issues/events{/number}","events_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/events","assignees_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/assignees{/user}","branches_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/branches{/branch}","tags_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/tags","blobs_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/statuses/{sha}","languages_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/languages","stargazers_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/stargazers","contributors_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/contributors","subscribers_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/subscribers","subscription_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/subscription","commits_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/contents/{+path}","compare_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/merges","archive_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/downloads","issues_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/issues{/number}","pulls_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/pulls{/number}","milestones_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/milestones{/number}","notifications_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/labels{/name}","releases_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/releases{/id}","deployments_url":"https://api.github.com/repos/Sispheor/ansible-role-openvpn/deployments","created_at":"2016-12-05T11:01:42Z","updated_at":"2016-11-26T14:35:43Z","pushed_at":"2016-12-06T10:56:39Z","git_url":"git://github.com/Sispheor/ansible-role-openvpn.git","ssh_url":"git@github.com:Sispheor/ansible-role-openvpn.git","clone_url":"https://github.com/Sispheor/ansible-role-openvpn.git","svn_url":"https://github.com/Sispheor/ansible-role-openvpn","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kyl191:master","ref":"master","sha":"cd5a9d5178ea2699d62ef02af7a7dcfb10d3ead8","user":{"login":"kyl191","id":499035,"avatar_url":"https://avatars.githubusercontent.com/u/499035?v=3","gravatar_id":"","url":"https://api.github.com/users/kyl191","html_url":"https://github.com/kyl191","followers_url":"https://api.github.com/users/kyl191/followers","following_url":"https://api.github.com/users/kyl191/following{/other_user}","gists_url":"https://api.github.com/users/kyl191/gists{/gist_id}","starred_url":"https://api.github.com/users/kyl191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyl191/subscriptions","organizations_url":"https://api.github.com/users/kyl191/orgs","repos_url":"https://api.github.com/users/kyl191/repos","events_url":"https://api.github.com/users/kyl191/events{/privacy}","received_events_url":"https://api.github.com/users/kyl191/received_events","type":"User","site_admin":false},"repo":{"id":32620001,"name":"ansible-role-openvpn","full_name":"kyl191/ansible-role-openvpn","owner":{"login":"kyl191","id":499035,"avatar_url":"https://avatars.githubusercontent.com/u/499035?v=3","gravatar_id":"","url":"https://api.github.com/users/kyl191","html_url":"https://github.com/kyl191","followers_url":"https://api.github.com/users/kyl191/followers","following_url":"https://api.github.com/users/kyl191/following{/other_user}","gists_url":"https://api.github.com/users/kyl191/gists{/gist_id}","starred_url":"https://api.github.com/users/kyl191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyl191/subscriptions","organizations_url":"https://api.github.com/users/kyl191/orgs","repos_url":"https://api.github.com/users/kyl191/repos","events_url":"https://api.github.com/users/kyl191/events{/privacy}","received_events_url":"https://api.github.com/users/kyl191/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyl191/ansible-role-openvpn","description":"Ansible Playbook for OpenVPN on CentOS/Fedora/RHEL clones","fork":false,"url":"https://api.github.com/repos/kyl191/ansible-role-openvpn","forks_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/forks","keys_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/teams","hooks_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/hooks","issue_events_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/events{/number}","events_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/events","assignees_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/assignees{/user}","branches_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/branches{/branch}","tags_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/tags","blobs_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/statuses/{sha}","languages_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/languages","stargazers_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/stargazers","contributors_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/contributors","subscribers_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/subscribers","subscription_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/subscription","commits_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/contents/{+path}","compare_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/merges","archive_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/downloads","issues_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues{/number}","pulls_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls{/number}","milestones_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/milestones{/number}","notifications_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/labels{/name}","releases_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/releases{/id}","deployments_url":"https://api.github.com/repos/kyl191/ansible-role-openvpn/deployments","created_at":"2015-03-21T04:32:36Z","updated_at":"2016-12-06T11:01:16Z","pushed_at":"2016-12-06T18:35:26Z","git_url":"git://github.com/kyl191/ansible-role-openvpn.git","ssh_url":"git@github.com:kyl191/ansible-role-openvpn.git","clone_url":"https://github.com/kyl191/ansible-role-openvpn.git","svn_url":"https://github.com/kyl191/ansible-role-openvpn","homepage":null,"size":75,"stargazers_count":22,"watchers_count":22,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14"},"html":{"href":"https://github.com/kyl191/ansible-role-openvpn/pull/14"},"issue":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/14"},"comments":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/kyl191/ansible-role-openvpn/statuses/af5df2c5fd5db8a2608b47dcac17622ca7ca56f2"}}}}
{"actor":{"display_login":"Sispheor"}}