{"action":"created","issue":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/730","repository_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers","labels_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/730/labels{/name}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/730/comments","events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/730/events","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/issues/730","id":184748409,"number":730,"title":"Working point dependent filling of muon corrections","user":{"login":"fscutti","id":16931625,"avatar_url":"https://avatars.githubusercontent.com/u/16931625?v=3","gravatar_id":"","url":"https://api.github.com/users/fscutti","html_url":"https://github.com/fscutti","followers_url":"https://api.github.com/users/fscutti/followers","following_url":"https://api.github.com/users/fscutti/following{/other_user}","gists_url":"https://api.github.com/users/fscutti/gists{/gist_id}","starred_url":"https://api.github.com/users/fscutti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscutti/subscriptions","organizations_url":"https://api.github.com/users/fscutti/orgs","repos_url":"https://api.github.com/users/fscutti/repos","events_url":"https://api.github.com/users/fscutti/events{/privacy}","received_events_url":"https://api.github.com/users/fscutti/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T04:51:09Z","updated_at":"2016-10-24T05:05:07Z","closed_at":null,"body":"Dear all,\r\nfor muons (and also electrons) we will soon need the possibility to include corrections for many triggers and combinations of reco+iso working points. For this reason, I have created a branch which I would like to merge. However, this is a relevant update so it is useful to review the changes here and see if you approve of them.\r\n\r\nFrom now on, if a user configures the muon details string in this way:\r\n\r\n`\"m_muDetailStr\"           : \"kinematic trigger isolation quality trackparams effSF\"`,\r\n\r\ni.e. with effSF, all muon corrections branches for all triggers and combination of working points\r\nwill be created in the ntuple, which will only be filled if the corresponding decoration exists. \r\nThis is a sketch of what the ntuple will look like:\r\n\r\n![muon_allcorrections](https://cloud.githubusercontent.com/assets/16931625/19633437/812eb7b4-99fd-11e6-9d3e-a59f6ae276e5.png)\r\n\r\nHowever, if the user will specify a set of working points as well, for either trigger, reco or iso, only those will be written out. As an example\r\n\r\n`\"m_muDetailStr\"           : \"kinematic trigger isolation quality trackparams effSF HLT_mu14_RecoMedium_IsoGradient RecoMedium IsoGradient\"`\r\n will lead to:\r\n\r\n![muon_corrections](https://cloud.githubusercontent.com/assets/16931625/19633292/8e1d5e82-99fb-11e6-948d-4a3902ce3f87.png)\r\n\r\nPlease notice that this change will allow also for di-muon trigger corrections, as they can  always be recalculated at the analysis level using corrections on the single trigger legs. So, \r\nthe previous example will be perfectly suitable for say HLT_2mu14. \r\n\r\nI have to warn here that this update required the hardcoding of all trigger chains, reco and iso\r\nworking points, so a bit of maintenance will be necessary if new triggers will be added. \r\n\r\nAt the level of MuonEfficiencyCorrector configuration, I have created a new attribute m_MuTrigLegs, which has to be filled with a comma-separated list of muon trigger legs, like in \r\n\r\n`\"m_MuTrigLegs\"      : \"HLT_mu8noL1,HLT_mu24,HLT_mu14\"`\r\n\r\nwhich replaces both m_SingleMuTrig and m_DiMuTrig.\r\n\r\nShall I go ahead a issue a pull request?\r\n\r\nCheers,\r\nFederico\r\n"},"comment":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/comments/255648719","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/issues/730#issuecomment-255648719","issue_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/730","id":255648719,"user":{"login":"fscutti","id":16931625,"avatar_url":"https://avatars.githubusercontent.com/u/16931625?v=3","gravatar_id":"","url":"https://api.github.com/users/fscutti","html_url":"https://github.com/fscutti","followers_url":"https://api.github.com/users/fscutti/followers","following_url":"https://api.github.com/users/fscutti/following{/other_user}","gists_url":"https://api.github.com/users/fscutti/gists{/gist_id}","starred_url":"https://api.github.com/users/fscutti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscutti/subscriptions","organizations_url":"https://api.github.com/users/fscutti/orgs","repos_url":"https://api.github.com/users/fscutti/repos","events_url":"https://api.github.com/users/fscutti/events{/privacy}","received_events_url":"https://api.github.com/users/fscutti/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T05:05:06Z","updated_at":"2016-10-24T05:05:06Z","body":"forgot to ping you guys... @mmilesi @kratsg @MihaMuskinja "}}
{"actor":{"display_login":"fscutti"}}