{"action":"created","issue":{"url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208","repository_url":"https://api.github.com/repos/osmandapp/Osmand","labels_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208/labels{/name}","comments_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208/comments","events_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208/events","html_url":"https://github.com/osmandapp/Osmand/pull/1208","id":75358650,"number":1208,"title":"tighten parseLength() again","user":{"login":"aceman444","id":6699462,"avatar_url":"https://avatars.githubusercontent.com/u/6699462?v=3","gravatar_id":"","url":"https://api.github.com/users/aceman444","html_url":"https://github.com/aceman444","followers_url":"https://api.github.com/users/aceman444/followers","following_url":"https://api.github.com/users/aceman444/following{/other_user}","gists_url":"https://api.github.com/users/aceman444/gists{/gist_id}","starred_url":"https://api.github.com/users/aceman444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceman444/subscriptions","organizations_url":"https://api.github.com/users/aceman444/orgs","repos_url":"https://api.github.com/users/aceman444/repos","events_url":"https://api.github.com/users/aceman444/events{/privacy}","received_events_url":"https://api.github.com/users/aceman444/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/osmandapp/Osmand/labels/Nice%20to%20Have","name":"Nice to Have","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-11T21:11:35Z","updated_at":"2016-06-14T16:24:16Z","closed_at":"2016-06-13T22:40:36Z","pull_request":{"url":"https://api.github.com/repos/osmandapp/Osmand/pulls/1208","html_url":"https://github.com/osmandapp/Osmand/pull/1208","diff_url":"https://github.com/osmandapp/Osmand/pull/1208.diff","patch_url":"https://github.com/osmandapp/Osmand/pull/1208.patch"},"body":"I wonder what the test for \"-\" does. There can't be any negative values in maxlength or maxheight.\r\nIt seems your version also accepts values like \"1 km 1 km\" (meaning 2km) which is invalid per the wiki, but probably shouldn't harm. I'm fine with that. But I think it also accepted \"1 mile\" and thinking it was 1meter. You can't just test unit.contains(\"m\") as that would also match \"mile\", \"cm\", etc. That is not good so I tightened it a bit.\r\n\r\nSo I haven't compiled this again, please tell me if all the tests pass."},"comment":{"url":"https://api.github.com/repos/osmandapp/Osmand/issues/comments/225936516","html_url":"https://github.com/osmandapp/Osmand/pull/1208#issuecomment-225936516","issue_url":"https://api.github.com/repos/osmandapp/Osmand/issues/1208","id":225936516,"user":{"login":"aceman444","id":6699462,"avatar_url":"https://avatars.githubusercontent.com/u/6699462?v=3","gravatar_id":"","url":"https://api.github.com/users/aceman444","html_url":"https://github.com/aceman444","followers_url":"https://api.github.com/users/aceman444/followers","following_url":"https://api.github.com/users/aceman444/following{/other_user}","gists_url":"https://api.github.com/users/aceman444/gists{/gist_id}","starred_url":"https://api.github.com/users/aceman444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceman444/subscriptions","organizations_url":"https://api.github.com/users/aceman444/orgs","repos_url":"https://api.github.com/users/aceman444/repos","events_url":"https://api.github.com/users/aceman444/events{/privacy}","received_events_url":"https://api.github.com/users/aceman444/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T16:24:16Z","updated_at":"2016-06-14T16:24:16Z","body":"So what has changed? Why is the patch bad?"}}
{"actor":{"display_login":"aceman444"}}