{"action":"closed","issue":{"url":"https://api.github.com/repos/Neurosim-lab/netpyne/issues/129","repository_url":"https://api.github.com/repos/Neurosim-lab/netpyne","labels_url":"https://api.github.com/repos/Neurosim-lab/netpyne/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/Neurosim-lab/netpyne/issues/129/comments","events_url":"https://api.github.com/repos/Neurosim-lab/netpyne/issues/129/events","html_url":"https://github.com/Neurosim-lab/netpyne/issues/129","id":166303365,"number":129,"title":"What is the primary, unique id of the cellRule/cellModel?","user":{"login":"pgleeson","id":1556687,"avatar_url":"https://avatars.githubusercontent.com/u/1556687?v=3","gravatar_id":"","url":"https://api.github.com/users/pgleeson","html_url":"https://github.com/pgleeson","followers_url":"https://api.github.com/users/pgleeson/followers","following_url":"https://api.github.com/users/pgleeson/following{/other_user}","gists_url":"https://api.github.com/users/pgleeson/gists{/gist_id}","starred_url":"https://api.github.com/users/pgleeson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgleeson/subscriptions","organizations_url":"https://api.github.com/users/pgleeson/orgs","repos_url":"https://api.github.com/users/pgleeson/repos","events_url":"https://api.github.com/users/pgleeson/events{/privacy}","received_events_url":"https://api.github.com/users/pgleeson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Neurosim-lab/netpyne/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-19T10:57:57Z","updated_at":"2016-07-19T16:54:45Z","closed_at":"2016-07-19T16:54:45Z","body":"In the HybridTutorial it seems to be cellModel:\r\n\r\n    netParams.addPopParams('PYR_HH', {'cellModel': 'HH', 'cellType': 'PYR', 'numCells': 50})\r\n    netParams.addPopParams('PYR_Izhi', {'cellModel': 'Izhi2007b', 'cellType': 'PYR', 'numCells': 50})\r\n\r\nbut in M1 it seems to be cellType\r\n\r\n    netParams.addPopParams('IT_L5B', {'cellModel': 'Izhi2007b', 'cellType': 'IT',  'ynormRange': [0.52, 0.77], 'density': 40e3}) #  L5B IT\r\n    netParams.addPopParams('PT_L5B', {'cellModel': 'Izhi2007b', 'cellType': 'PT',  'ynormRange': [0.52, 0.77], 'density': 40e3}) #  L5B PT\r\n\r\nhere, the parameter cellModel is not even set in the cellRule:\r\n\r\n    cellRule = {'conds': {'cellType': 'IT'}, 'secs': {}}\r\n\r\nI can see that the way popparams are set up means \"try to find a cellRule which satisfies all of these conditions\", but this is not ideal, especially when you know there has to be exactly one cellRule that satisfies these conditions.\r\n\r\nIt would be better to (consistently) use the one unique id you do have for cellRules when you add them to the params:\r\n\r\n    netParams.addCellParams('IT', cellRule)\r\n"}}
{"actor":{"display_login":"salvadord"}}