{"action":"created","comment":{"url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/comments/67568048","id":67568048,"diff_hunk":"@@ -858,10 +858,10 @@ def _perform_path_port_operations(self, context, port):\n                 app_profile_name=self._get_network_app_profile(\n                     context.network.current), transaction=trs)\n \n-    def _perform_interface_port_operations(self, context, port,\n+    def _perform_interface_port_operations(self, context, port, network,\n                                            is_delete=False):\n         router_id = port.get('device_id')\n-        if router_id == '':\n+        if not router_id:","path":"apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/mechanism_apic.py","position":9,"original_position":9,"commit_id":"f39c3650bf5ae1e441b103a7419825866f0cb0c0","original_commit_id":"f39c3650bf5ae1e441b103a7419825866f0cb0c0","user":{"login":"tbachman","id":5181955,"avatar_url":"https://avatars.githubusercontent.com/u/5181955?v=3","gravatar_id":"","url":"https://api.github.com/users/tbachman","html_url":"https://github.com/tbachman","followers_url":"https://api.github.com/users/tbachman/followers","following_url":"https://api.github.com/users/tbachman/following{/other_user}","gists_url":"https://api.github.com/users/tbachman/gists{/gist_id}","starred_url":"https://api.github.com/users/tbachman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbachman/subscriptions","organizations_url":"https://api.github.com/users/tbachman/orgs","repos_url":"https://api.github.com/users/tbachman/repos","events_url":"https://api.github.com/users/tbachman/events{/privacy}","received_events_url":"https://api.github.com/users/tbachman/received_events","type":"User","site_admin":false},"body":"Is it important here to distinguish between None and empty-string (i.e. is there a reason why it was empty string)?","created_at":"2016-06-17T20:08:13Z","updated_at":"2016-06-17T20:08:13Z","html_url":"https://github.com/noironetworks/apic-ml2-driver/pull/89#discussion_r67568048","pull_request_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/comments/67568048"},"html":{"href":"https://github.com/noironetworks/apic-ml2-driver/pull/89#discussion_r67568048"},"pull_request":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89","id":74295190,"html_url":"https://github.com/noironetworks/apic-ml2-driver/pull/89","diff_url":"https://github.com/noironetworks/apic-ml2-driver/pull/89.diff","patch_url":"https://github.com/noironetworks/apic-ml2-driver/pull/89.patch","issue_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/89","number":89,"state":"open","locked":false,"title":"Link BDs to L3Outs even when NAT is disabled","user":{"login":"amittbose","id":8573271,"avatar_url":"https://avatars.githubusercontent.com/u/8573271?v=3","gravatar_id":"","url":"https://api.github.com/users/amittbose","html_url":"https://github.com/amittbose","followers_url":"https://api.github.com/users/amittbose/followers","following_url":"https://api.github.com/users/amittbose/following{/other_user}","gists_url":"https://api.github.com/users/amittbose/gists{/gist_id}","starred_url":"https://api.github.com/users/amittbose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amittbose/subscriptions","organizations_url":"https://api.github.com/users/amittbose/orgs","repos_url":"https://api.github.com/users/amittbose/repos","events_url":"https://api.github.com/users/amittbose/events{/privacy}","received_events_url":"https://api.github.com/users/amittbose/received_events","type":"User","site_admin":false},"body":"Even with NAT disabled, it is useful to connected the\r\nprivate BD to the L3Out so that private subnets are\r\nadvertised through dynamic routing protocols.\r\n\r\nIn addition, also fixed bugs in code-path for edge-NAT\r\nthat sets up the BD-to-L3Out link.\r\n\r\nPartially-Closes noironetworks/support#109\r\n\r\nSigned-off-by: Amit Bose <amitbose@gmail.com>","created_at":"2016-06-17T19:45:26Z","updated_at":"2016-06-17T20:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fae77da6dd83a4e74d424277517fa5be262fc1eb","assignee":{"login":"ivar-lazzaro","id":6353941,"avatar_url":"https://avatars.githubusercontent.com/u/6353941?v=3","gravatar_id":"","url":"https://api.github.com/users/ivar-lazzaro","html_url":"https://github.com/ivar-lazzaro","followers_url":"https://api.github.com/users/ivar-lazzaro/followers","following_url":"https://api.github.com/users/ivar-lazzaro/following{/other_user}","gists_url":"https://api.github.com/users/ivar-lazzaro/gists{/gist_id}","starred_url":"https://api.github.com/users/ivar-lazzaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivar-lazzaro/subscriptions","organizations_url":"https://api.github.com/users/ivar-lazzaro/orgs","repos_url":"https://api.github.com/users/ivar-lazzaro/repos","events_url":"https://api.github.com/users/ivar-lazzaro/events{/privacy}","received_events_url":"https://api.github.com/users/ivar-lazzaro/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89/commits","review_comments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89/comments","review_comment_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/89/comments","statuses_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/statuses/f39c3650bf5ae1e441b103a7419825866f0cb0c0","head":{"label":"noironetworks:no-nat-l3out-bd","ref":"no-nat-l3out-bd","sha":"f39c3650bf5ae1e441b103a7419825866f0cb0c0","user":{"login":"noironetworks","id":6634092,"avatar_url":"https://avatars.githubusercontent.com/u/6634092?v=3","gravatar_id":"","url":"https://api.github.com/users/noironetworks","html_url":"https://github.com/noironetworks","followers_url":"https://api.github.com/users/noironetworks/followers","following_url":"https://api.github.com/users/noironetworks/following{/other_user}","gists_url":"https://api.github.com/users/noironetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/noironetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noironetworks/subscriptions","organizations_url":"https://api.github.com/users/noironetworks/orgs","repos_url":"https://api.github.com/users/noironetworks/repos","events_url":"https://api.github.com/users/noironetworks/events{/privacy}","received_events_url":"https://api.github.com/users/noironetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":25177037,"name":"apic-ml2-driver","full_name":"noironetworks/apic-ml2-driver","owner":{"login":"noironetworks","id":6634092,"avatar_url":"https://avatars.githubusercontent.com/u/6634092?v=3","gravatar_id":"","url":"https://api.github.com/users/noironetworks","html_url":"https://github.com/noironetworks","followers_url":"https://api.github.com/users/noironetworks/followers","following_url":"https://api.github.com/users/noironetworks/following{/other_user}","gists_url":"https://api.github.com/users/noironetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/noironetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noironetworks/subscriptions","organizations_url":"https://api.github.com/users/noironetworks/orgs","repos_url":"https://api.github.com/users/noironetworks/repos","events_url":"https://api.github.com/users/noironetworks/events{/privacy}","received_events_url":"https://api.github.com/users/noironetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noironetworks/apic-ml2-driver","description":"","fork":false,"url":"https://api.github.com/repos/noironetworks/apic-ml2-driver","forks_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/forks","keys_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/teams","hooks_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/hooks","issue_events_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/events{/number}","events_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/events","assignees_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/assignees{/user}","branches_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/branches{/branch}","tags_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/tags","blobs_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/languages","stargazers_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/stargazers","contributors_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/contributors","subscribers_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/subscribers","subscription_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/subscription","commits_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/contents/{+path}","compare_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/merges","archive_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/downloads","issues_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues{/number}","pulls_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/labels{/name}","releases_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/releases{/id}","deployments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/deployments","created_at":"2014-10-13T20:45:17Z","updated_at":"2016-02-23T07:13:50Z","pushed_at":"2016-06-17T19:50:15Z","git_url":"git://github.com/noironetworks/apic-ml2-driver.git","ssh_url":"git@github.com:noironetworks/apic-ml2-driver.git","clone_url":"https://github.com/noironetworks/apic-ml2-driver.git","svn_url":"https://github.com/noironetworks/apic-ml2-driver","homepage":null,"size":1038,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"noironetworks:master","ref":"master","sha":"65e18a1c6fd17198f7ffd1db4d94f86914ad464c","user":{"login":"noironetworks","id":6634092,"avatar_url":"https://avatars.githubusercontent.com/u/6634092?v=3","gravatar_id":"","url":"https://api.github.com/users/noironetworks","html_url":"https://github.com/noironetworks","followers_url":"https://api.github.com/users/noironetworks/followers","following_url":"https://api.github.com/users/noironetworks/following{/other_user}","gists_url":"https://api.github.com/users/noironetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/noironetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noironetworks/subscriptions","organizations_url":"https://api.github.com/users/noironetworks/orgs","repos_url":"https://api.github.com/users/noironetworks/repos","events_url":"https://api.github.com/users/noironetworks/events{/privacy}","received_events_url":"https://api.github.com/users/noironetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":25177037,"name":"apic-ml2-driver","full_name":"noironetworks/apic-ml2-driver","owner":{"login":"noironetworks","id":6634092,"avatar_url":"https://avatars.githubusercontent.com/u/6634092?v=3","gravatar_id":"","url":"https://api.github.com/users/noironetworks","html_url":"https://github.com/noironetworks","followers_url":"https://api.github.com/users/noironetworks/followers","following_url":"https://api.github.com/users/noironetworks/following{/other_user}","gists_url":"https://api.github.com/users/noironetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/noironetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noironetworks/subscriptions","organizations_url":"https://api.github.com/users/noironetworks/orgs","repos_url":"https://api.github.com/users/noironetworks/repos","events_url":"https://api.github.com/users/noironetworks/events{/privacy}","received_events_url":"https://api.github.com/users/noironetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/noironetworks/apic-ml2-driver","description":"","fork":false,"url":"https://api.github.com/repos/noironetworks/apic-ml2-driver","forks_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/forks","keys_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/teams","hooks_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/hooks","issue_events_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/events{/number}","events_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/events","assignees_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/assignees{/user}","branches_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/branches{/branch}","tags_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/tags","blobs_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/languages","stargazers_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/stargazers","contributors_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/contributors","subscribers_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/subscribers","subscription_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/subscription","commits_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/contents/{+path}","compare_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/merges","archive_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/downloads","issues_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues{/number}","pulls_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/labels{/name}","releases_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/releases{/id}","deployments_url":"https://api.github.com/repos/noironetworks/apic-ml2-driver/deployments","created_at":"2014-10-13T20:45:17Z","updated_at":"2016-02-23T07:13:50Z","pushed_at":"2016-06-17T19:50:15Z","git_url":"git://github.com/noironetworks/apic-ml2-driver.git","ssh_url":"git@github.com:noironetworks/apic-ml2-driver.git","clone_url":"https://github.com/noironetworks/apic-ml2-driver.git","svn_url":"https://github.com/noironetworks/apic-ml2-driver","homepage":null,"size":1038,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89"},"html":{"href":"https://github.com/noironetworks/apic-ml2-driver/pull/89"},"issue":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/89"},"comments":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/noironetworks/apic-ml2-driver/statuses/f39c3650bf5ae1e441b103a7419825866f0cb0c0"}}}}
{"actor":{"display_login":"tbachman"}}