{"action":"created","issue":{"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/21","repository_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics","labels_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/21/comments","events_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/21/events","html_url":"https://github.com/mridgway/hoist-non-react-statics/pull/21","id":183469178,"number":21,"title":"Modernize eslint config","user":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-17T16:50:06Z","updated_at":"2016-10-17T16:51:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/21","html_url":"https://github.com/mridgway/hoist-non-react-statics/pull/21","diff_url":"https://github.com/mridgway/hoist-non-react-statics/pull/21.diff","patch_url":"https://github.com/mridgway/hoist-non-react-statics/pull/21.patch"},"body":"Although ESLint doesn't test linting rules for any files within `node_modules`, it can still fall over `.eslintrc` config files within `node_modules` that it perceives as invalid, and it looks like the rules have become stricter and `false` is no longer accepted. Instead, you now get an error like this:\r\n\r\n~~~\r\n/Users/dchamb/dev/hoist-non-react-statics/.eslintrc:\r\n\tConfiguration for rule \"no-alert\" is invalid:\r\n\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed 'false').\r\n\r\nError: /Users/dchamb/dev/hoist-non-react-statics/.eslintrc:\r\n\tConfiguration for rule \"no-alert\" is invalid:\r\n\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed 'false').\r\n~~~\r\n\r\nAlthough it could be argued that ESLint should support older config even if it was using unsupported flags, modernizing the config was helpful since it actually got rid of the need for 'babel-eslint' as a dependency, which seems like a good thing anyway."},"comment":{"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/comments/254265333","html_url":"https://github.com/mridgway/hoist-non-react-statics/pull/21#issuecomment-254265333","issue_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/21","id":254265333,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T16:51:49Z","updated_at":"2016-10-17T16:51:49Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8373470/badge)](https://coveralls.io/builds/8373470)\n\nCoverage remained the same at 100.0% when pulling **9412553a091f5732114baba16ca8b6135b8c89e7 on dchambers:modernize-eslint-config** into **58b780debcb2b666f147267449d6f1ceb0cc5351 on mridgway:master**.\n"}}
{"actor":{"display_login":"coveralls"}}