{"action":"created","issue":{"url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/472","repository_url":"https://api.github.com/repos/ember-animation/liquid-fire","labels_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/472/labels{/name}","comments_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/472/comments","events_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/472/events","html_url":"https://github.com/ember-animation/liquid-fire/issues/472","id":163260028,"number":472,"title":"Named liquid-outlets don't match route transitions","user":{"login":"mrship","id":14839,"avatar_url":"https://avatars.githubusercontent.com/u/14839?v=3","gravatar_id":"","url":"https://api.github.com/users/mrship","html_url":"https://github.com/mrship","followers_url":"https://api.github.com/users/mrship/followers","following_url":"https://api.github.com/users/mrship/following{/other_user}","gists_url":"https://api.github.com/users/mrship/gists{/gist_id}","starred_url":"https://api.github.com/users/mrship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrship/subscriptions","organizations_url":"https://api.github.com/users/mrship/orgs","repos_url":"https://api.github.com/users/mrship/repos","events_url":"https://api.github.com/users/mrship/events{/privacy}","received_events_url":"https://api.github.com/users/mrship/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-30T20:29:59Z","updated_at":"2016-07-01T01:41:46Z","closed_at":null,"body":"I have two liquid-outlets in my template:\r\n\r\n```\r\n= liquid-outlet 'rhs' class='right-hand-panel col-md-4 col-sm-6 col-xs-8' containerless=true\r\n= liquid-outlet 'lhs' class='left-hand-panel col-md-4 col-sm-6 col-xs-8' containerless=true\r\n```\r\n\r\nThe intent is to render nested routes into either a left hand panel, or a right hand panel. However, once I name the liquid-outlets, i.e. 'rhs' and 'lhs' then transitions no longer match correctly. Debug output indicates that the current route is not being correctly setup to match the transition:\r\n\r\n```\r\n[liquid-fire] Checking transition rules for <div id=​\"ember545\" class=​\"ember-view\">​…​</div>​\r\nliquid-fire rule 1] rejected because oldRoute was\r\n[liquid-fire rule 1 reverse] rejected because oldRoute was\r\n[liquid-fire rule 1 reverse] rejected because newRoute was calendar.unavailabilities\r\n```\r\n\r\n(Note the lack of a route name for `oldRoute`.)\r\n\r\nChanging the name to 'main' (for either of the outlets) and the transition _is_ matched correctly. As it is, if I remove the name of the liquid-outlet (or just have one liquid-outlet).\r\n\r\nDigging into the code, it _appears_ that the outletState isn't being set correctly for any liquid-outlet named anything other than 'main', in the [ember-internals code](https://github.com/ember-animation/liquid-fire/blob/master/addon/ember-internals.js#L71).\r\n\r\nI don't know enough to be able to fix/address that; any ideas on how to have liquid-outlet work correctly with named outlets?"},"comment":{"url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/comments/229833942","html_url":"https://github.com/ember-animation/liquid-fire/issues/472#issuecomment-229833942","issue_url":"https://api.github.com/repos/ember-animation/liquid-fire/issues/472","id":229833942,"user":{"login":"ef4","id":319282,"avatar_url":"https://avatars.githubusercontent.com/u/319282?v=3","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T01:41:46Z","updated_at":"2016-07-01T01:41:46Z","body":"Thanks, there is a legit bug here (possibly a dup of https://github.com/ember-animation/liquid-fire/issues/18).\r\n\r\nBut there is a simple workaround: use something like [ember-sidebars](https://github.com/ef4/ember-sidebars) instead of named outlets."}}
{"actor":{"display_login":"ef4"}}