{"action":"opened","number":21607,"pull_request":{"url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607","id":72237514,"html_url":"https://github.com/caskroom/homebrew-cask/pull/21607","diff_url":"https://github.com/caskroom/homebrew-cask/pull/21607.diff","patch_url":"https://github.com/caskroom/homebrew-cask/pull/21607.patch","issue_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/21607","number":21607,"state":"open","locked":false,"title":"Fix `zap` regression introduced in 6500fa1; ref #21583","user":{"login":"claui","id":1239874,"avatar_url":"https://avatars.githubusercontent.com/u/1239874?v=3","gravatar_id":"","url":"https://api.github.com/users/claui","html_url":"https://github.com/claui","followers_url":"https://api.github.com/users/claui/followers","following_url":"https://api.github.com/users/claui/following{/other_user}","gists_url":"https://api.github.com/users/claui/gists{/gist_id}","starred_url":"https://api.github.com/users/claui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claui/subscriptions","organizations_url":"https://api.github.com/users/claui/orgs","repos_url":"https://api.github.com/users/claui/repos","events_url":"https://api.github.com/users/claui/events{/privacy}","received_events_url":"https://api.github.com/users/claui/received_events","type":"User","site_admin":false},"body":"<!--\r\n### Changes to the core\r\n\r\n- [x] Followed [hacking.md](https://github.com/caskroom/homebrew-cask/blob/master/doc/development/hacking.md).\r\n\r\n-->\r\n\r\nThis PR fixes an issue with 6500fa1, in which the (internal) installer API was refactored in preparation for the big change. That refactoring missed one case, causing `zap` to break; see #21583.\r\n\r\n@caskroom/maintainers This is a one-line fix but please have a look nonetheless. Thanks!\r\n\r\nCaveats:\r\n\r\n- I did not include tests with this fix. The `zap` command seems to have test coverage issues. We do have a `cli/zap_test` case but [its main path is commented out](https://github.com/caskroom/homebrew-cask/commit/00921dd5137bcaba95ca816f8fb7a185d4bd220e#diff-7fe581fc0f85395ebffe41217d5bdc83R36). When I uncomment that test, it keeps failing and I can’t figure out why. Shall I open an issue for this on its own?\r\n\r\n- #13966 has exposed a few more (unrelated) issues with `uninstall` and `zap` in edge cases when the user has insufficient permissions. This is easily fixable (using methods from 9664b9f); I am preparing a PR right now.\r\n","created_at":"2016-06-01T19:24:56Z","updated_at":"2016-06-01T19:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607/commits","review_comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607/comments","review_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/21607/comments","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/82386c9c205cef355bea8e174c27184fe36a98c6","head":{"label":"claui:fix-zap-regression","ref":"fix-zap-regression","sha":"82386c9c205cef355bea8e174c27184fe36a98c6","user":{"login":"claui","id":1239874,"avatar_url":"https://avatars.githubusercontent.com/u/1239874?v=3","gravatar_id":"","url":"https://api.github.com/users/claui","html_url":"https://github.com/claui","followers_url":"https://api.github.com/users/claui/followers","following_url":"https://api.github.com/users/claui/following{/other_user}","gists_url":"https://api.github.com/users/claui/gists{/gist_id}","starred_url":"https://api.github.com/users/claui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claui/subscriptions","organizations_url":"https://api.github.com/users/claui/orgs","repos_url":"https://api.github.com/users/claui/repos","events_url":"https://api.github.com/users/claui/events{/privacy}","received_events_url":"https://api.github.com/users/claui/received_events","type":"User","site_admin":false},"repo":{"id":24523169,"name":"homebrew-cask","full_name":"claui/homebrew-cask","owner":{"login":"claui","id":1239874,"avatar_url":"https://avatars.githubusercontent.com/u/1239874?v=3","gravatar_id":"","url":"https://api.github.com/users/claui","html_url":"https://github.com/claui","followers_url":"https://api.github.com/users/claui/followers","following_url":"https://api.github.com/users/claui/following{/other_user}","gists_url":"https://api.github.com/users/claui/gists{/gist_id}","starred_url":"https://api.github.com/users/claui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claui/subscriptions","organizations_url":"https://api.github.com/users/claui/orgs","repos_url":"https://api.github.com/users/claui/repos","events_url":"https://api.github.com/users/claui/events{/privacy}","received_events_url":"https://api.github.com/users/claui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/claui/homebrew-cask","description":"A CLI workflow for the administration of Mac applications distributed as binaries","fork":true,"url":"https://api.github.com/repos/claui/homebrew-cask","forks_url":"https://api.github.com/repos/claui/homebrew-cask/forks","keys_url":"https://api.github.com/repos/claui/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/claui/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/claui/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/claui/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/claui/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/claui/homebrew-cask/events","assignees_url":"https://api.github.com/repos/claui/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/claui/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/claui/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/claui/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/claui/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/claui/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/claui/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/claui/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/claui/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/claui/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/claui/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/claui/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/claui/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/claui/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/claui/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/claui/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/claui/homebrew-cask/issues/comments{/number}","contents_url":"https://api.github.com/repos/claui/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/claui/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/claui/homebrew-cask/merges","archive_url":"https://api.github.com/repos/claui/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/claui/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/claui/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/claui/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/claui/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/claui/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/claui/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/claui/homebrew-cask/releases{/id}","deployments_url":"https://api.github.com/repos/claui/homebrew-cask/deployments","created_at":"2014-09-27T04:07:13Z","updated_at":"2016-05-20T20:54:59Z","pushed_at":"2016-06-01T19:01:37Z","git_url":"git://github.com/claui/homebrew-cask.git","ssh_url":"git@github.com:claui/homebrew-cask.git","clone_url":"https://github.com/claui/homebrew-cask.git","svn_url":"https://github.com/claui/homebrew-cask","homepage":"http://caskroom.io","size":62476,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caskroom:master","ref":"master","sha":"7839d221dededc6f65add573930f2cb49bdcf457","user":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=3","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"repo":{"id":3623050,"name":"homebrew-cask","full_name":"caskroom/homebrew-cask","owner":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=3","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskroom/homebrew-cask","description":"A CLI workflow for the administration of Mac applications distributed as binaries","fork":false,"url":"https://api.github.com/repos/caskroom/homebrew-cask","forks_url":"https://api.github.com/repos/caskroom/homebrew-cask/forks","keys_url":"https://api.github.com/repos/caskroom/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskroom/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskroom/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/caskroom/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/caskroom/homebrew-cask/events","assignees_url":"https://api.github.com/repos/caskroom/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/caskroom/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/caskroom/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/caskroom/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/caskroom/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskroom/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/caskroom/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskroom/homebrew-cask/merges","archive_url":"https://api.github.com/repos/caskroom/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskroom/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/caskroom/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/caskroom/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskroom/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/caskroom/homebrew-cask/releases{/id}","deployments_url":"https://api.github.com/repos/caskroom/homebrew-cask/deployments","created_at":"2012-03-05T02:05:17Z","updated_at":"2016-06-01T14:59:10Z","pushed_at":"2016-06-01T19:09:52Z","git_url":"git://github.com/caskroom/homebrew-cask.git","ssh_url":"git@github.com:caskroom/homebrew-cask.git","clone_url":"https://github.com/caskroom/homebrew-cask.git","svn_url":"https://github.com/caskroom/homebrew-cask","homepage":"http://caskroom.io","size":131988,"stargazers_count":9012,"watchers_count":9012,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3656,"mirror_url":null,"open_issues_count":89,"forks":3656,"open_issues":89,"watchers":9012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607"},"html":{"href":"https://github.com/caskroom/homebrew-cask/pull/21607"},"issue":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/21607"},"comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/21607/comments"},"review_comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607/comments"},"review_comment":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/21607/commits"},"statuses":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/82386c9c205cef355bea8e174c27184fe36a98c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"claui"}}