{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49","id":66798145,"html_url":"https://github.com/swiftceipt/SC-XW1/pull/49","diff_url":"https://github.com/swiftceipt/SC-XW1/pull/49.diff","patch_url":"https://github.com/swiftceipt/SC-XW1/pull/49.patch","issue_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/49","number":49,"state":"closed","locked":false,"title":"Login and Registration Tests","user":{"login":"SivanMehta","id":6868877,"avatar_url":"https://avatars.githubusercontent.com/u/6868877?v=3","gravatar_id":"","url":"https://api.github.com/users/SivanMehta","html_url":"https://github.com/SivanMehta","followers_url":"https://api.github.com/users/SivanMehta/followers","following_url":"https://api.github.com/users/SivanMehta/following{/other_user}","gists_url":"https://api.github.com/users/SivanMehta/gists{/gist_id}","starred_url":"https://api.github.com/users/SivanMehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SivanMehta/subscriptions","organizations_url":"https://api.github.com/users/SivanMehta/orgs","repos_url":"https://api.github.com/users/SivanMehta/repos","events_url":"https://api.github.com/users/SivanMehta/events{/privacy}","received_events_url":"https://api.github.com/users/SivanMehta/received_events","type":"User","site_admin":false},"body":"## What I did\r\n\r\nIn the process of creating `test/test-register.js` and `test/test-login.js` I also implemented a few new features a long the way including:\r\n\r\n1. Use of HTTPS in local testing\r\n2. Detailed instructions on how to set up the application in the README\r\n3. Further use of the `config/api_wrapper.js` module for more streamlined code\r\n4. Use of [`zombie.js`](http://zombie.js.org/) to walk through validating the login process\r\n\r\n## Proof of Correctness\r\n\r\n```\r\n\r\n$ npm test\r\n> ./SC-XW1\r\n> mocha\r\n\r\n\r\n\r\n Forget Password\r\n    ✓ should see the forget password (496ms)\r\n    ✓ should not allow you to enter a invalid email (859ms)\r\n    ✓ should allow you to enter a valid email and confirm a sent email (1162ms)\r\n    ✓ should tell you if you aren't recognized by the server (1218ms)\r\n\r\n SC Server\r\n    ✓ should accept valid login credentials (96ms)\r\n    ✓ should not accept invalid login credentials (59ms)\r\n\r\n  Walking through the login process\r\n    ✓ should have defined headless browser\r\n    ✓ should visit the site and see the login form (610ms)\r\n    ✓ should not be able to login with wrong credentials (558ms)\r\n    ✓ should be able to login with valid credentials (1932ms)\r\n\r\n  Looking through receipts\r\n    ✓ should have defined headless browser and log in  (518ms)\r\n    ✓ should be able to login with valid credentials (1589ms)\r\n    ✓ should navigate to the receipts page and see the Home Depot (771ms)\r\n    ✓ should be able to click on a receipt to see its information\r\n    ✓ should be able to see the original HTML page\r\n    ✓ should be able to go to the popped out receipt page (4911ms)\r\n    ✓ should be able to see the Google Map\r\n\r\n  /routes/routes.js\r\n    register(req, res)\r\n      ✓ should be able to be able to register a new user (93ms)\r\n      ✓ should be able to login as the newly created user (72ms)\r\n\r\n  /routes/validate.js\r\n    isEmail(str)\r\n      ✓ should allow valid emails\r\n      ✓ should not allow invalid emails\r\n    new_user(body)\r\n      ✓ should not allow an invalid email\r\n      ✓ should not allow an invalid username\r\n      ✓ should not allow an invalid password\r\n      ✓ should allow an valid body object\r\n\r\n\r\n  23 passing (15s)\r\n```","created_at":"2016-04-18T04:41:05Z","updated_at":"2016-04-22T00:31:00Z","closed_at":"2016-04-22T00:31:00Z","merged_at":"2016-04-22T00:31:00Z","merge_commit_sha":"8e118962a134a561a0d457c7c099082437273f32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49/commits","review_comments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49/comments","review_comment_url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/49/comments","statuses_url":"https://api.github.com/repos/swiftceipt/SC-XW1/statuses/35f92e6f14a01bb65060107f0fb05ffb34af816c","head":{"label":"swiftceipt:test_login","ref":"test_login","sha":"35f92e6f14a01bb65060107f0fb05ffb34af816c","user":{"login":"swiftceipt","id":10813308,"avatar_url":"https://avatars.githubusercontent.com/u/10813308?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftceipt","html_url":"https://github.com/swiftceipt","followers_url":"https://api.github.com/users/swiftceipt/followers","following_url":"https://api.github.com/users/swiftceipt/following{/other_user}","gists_url":"https://api.github.com/users/swiftceipt/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftceipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftceipt/subscriptions","organizations_url":"https://api.github.com/users/swiftceipt/orgs","repos_url":"https://api.github.com/users/swiftceipt/repos","events_url":"https://api.github.com/users/swiftceipt/events{/privacy}","received_events_url":"https://api.github.com/users/swiftceipt/received_events","type":"Organization","site_admin":false},"repo":{"id":50528113,"name":"SC-XW1","full_name":"swiftceipt/SC-XW1","owner":{"login":"swiftceipt","id":10813308,"avatar_url":"https://avatars.githubusercontent.com/u/10813308?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftceipt","html_url":"https://github.com/swiftceipt","followers_url":"https://api.github.com/users/swiftceipt/followers","following_url":"https://api.github.com/users/swiftceipt/following{/other_user}","gists_url":"https://api.github.com/users/swiftceipt/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftceipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftceipt/subscriptions","organizations_url":"https://api.github.com/users/swiftceipt/orgs","repos_url":"https://api.github.com/users/swiftceipt/repos","events_url":"https://api.github.com/users/swiftceipt/events{/privacy}","received_events_url":"https://api.github.com/users/swiftceipt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swiftceipt/SC-XW1","description":"CMU/Swiftceipt Collaborative Project.","fork":false,"url":"https://api.github.com/repos/swiftceipt/SC-XW1","forks_url":"https://api.github.com/repos/swiftceipt/SC-XW1/forks","keys_url":"https://api.github.com/repos/swiftceipt/SC-XW1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftceipt/SC-XW1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftceipt/SC-XW1/teams","hooks_url":"https://api.github.com/repos/swiftceipt/SC-XW1/hooks","issue_events_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/events{/number}","events_url":"https://api.github.com/repos/swiftceipt/SC-XW1/events","assignees_url":"https://api.github.com/repos/swiftceipt/SC-XW1/assignees{/user}","branches_url":"https://api.github.com/repos/swiftceipt/SC-XW1/branches{/branch}","tags_url":"https://api.github.com/repos/swiftceipt/SC-XW1/tags","blobs_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftceipt/SC-XW1/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftceipt/SC-XW1/languages","stargazers_url":"https://api.github.com/repos/swiftceipt/SC-XW1/stargazers","contributors_url":"https://api.github.com/repos/swiftceipt/SC-XW1/contributors","subscribers_url":"https://api.github.com/repos/swiftceipt/SC-XW1/subscribers","subscription_url":"https://api.github.com/repos/swiftceipt/SC-XW1/subscription","commits_url":"https://api.github.com/repos/swiftceipt/SC-XW1/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftceipt/SC-XW1/contents/{+path}","compare_url":"https://api.github.com/repos/swiftceipt/SC-XW1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftceipt/SC-XW1/merges","archive_url":"https://api.github.com/repos/swiftceipt/SC-XW1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftceipt/SC-XW1/downloads","issues_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues{/number}","pulls_url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftceipt/SC-XW1/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftceipt/SC-XW1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftceipt/SC-XW1/labels{/name}","releases_url":"https://api.github.com/repos/swiftceipt/SC-XW1/releases{/id}","deployments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/deployments","created_at":"2016-01-27T18:22:16Z","updated_at":"2016-02-28T23:06:41Z","pushed_at":"2016-04-22T00:31:00Z","git_url":"git://github.com/swiftceipt/SC-XW1.git","ssh_url":"git@github.com:swiftceipt/SC-XW1.git","clone_url":"https://github.com/swiftceipt/SC-XW1.git","svn_url":"https://github.com/swiftceipt/SC-XW1","homepage":null,"size":34502,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"swiftceipt:dev","ref":"dev","sha":"b4ad565287ff1443f27b9115b54a821ff9bf3d98","user":{"login":"swiftceipt","id":10813308,"avatar_url":"https://avatars.githubusercontent.com/u/10813308?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftceipt","html_url":"https://github.com/swiftceipt","followers_url":"https://api.github.com/users/swiftceipt/followers","following_url":"https://api.github.com/users/swiftceipt/following{/other_user}","gists_url":"https://api.github.com/users/swiftceipt/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftceipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftceipt/subscriptions","organizations_url":"https://api.github.com/users/swiftceipt/orgs","repos_url":"https://api.github.com/users/swiftceipt/repos","events_url":"https://api.github.com/users/swiftceipt/events{/privacy}","received_events_url":"https://api.github.com/users/swiftceipt/received_events","type":"Organization","site_admin":false},"repo":{"id":50528113,"name":"SC-XW1","full_name":"swiftceipt/SC-XW1","owner":{"login":"swiftceipt","id":10813308,"avatar_url":"https://avatars.githubusercontent.com/u/10813308?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftceipt","html_url":"https://github.com/swiftceipt","followers_url":"https://api.github.com/users/swiftceipt/followers","following_url":"https://api.github.com/users/swiftceipt/following{/other_user}","gists_url":"https://api.github.com/users/swiftceipt/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftceipt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftceipt/subscriptions","organizations_url":"https://api.github.com/users/swiftceipt/orgs","repos_url":"https://api.github.com/users/swiftceipt/repos","events_url":"https://api.github.com/users/swiftceipt/events{/privacy}","received_events_url":"https://api.github.com/users/swiftceipt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swiftceipt/SC-XW1","description":"CMU/Swiftceipt Collaborative Project.","fork":false,"url":"https://api.github.com/repos/swiftceipt/SC-XW1","forks_url":"https://api.github.com/repos/swiftceipt/SC-XW1/forks","keys_url":"https://api.github.com/repos/swiftceipt/SC-XW1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftceipt/SC-XW1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftceipt/SC-XW1/teams","hooks_url":"https://api.github.com/repos/swiftceipt/SC-XW1/hooks","issue_events_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/events{/number}","events_url":"https://api.github.com/repos/swiftceipt/SC-XW1/events","assignees_url":"https://api.github.com/repos/swiftceipt/SC-XW1/assignees{/user}","branches_url":"https://api.github.com/repos/swiftceipt/SC-XW1/branches{/branch}","tags_url":"https://api.github.com/repos/swiftceipt/SC-XW1/tags","blobs_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftceipt/SC-XW1/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftceipt/SC-XW1/languages","stargazers_url":"https://api.github.com/repos/swiftceipt/SC-XW1/stargazers","contributors_url":"https://api.github.com/repos/swiftceipt/SC-XW1/contributors","subscribers_url":"https://api.github.com/repos/swiftceipt/SC-XW1/subscribers","subscription_url":"https://api.github.com/repos/swiftceipt/SC-XW1/subscription","commits_url":"https://api.github.com/repos/swiftceipt/SC-XW1/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftceipt/SC-XW1/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftceipt/SC-XW1/contents/{+path}","compare_url":"https://api.github.com/repos/swiftceipt/SC-XW1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftceipt/SC-XW1/merges","archive_url":"https://api.github.com/repos/swiftceipt/SC-XW1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftceipt/SC-XW1/downloads","issues_url":"https://api.github.com/repos/swiftceipt/SC-XW1/issues{/number}","pulls_url":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftceipt/SC-XW1/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftceipt/SC-XW1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftceipt/SC-XW1/labels{/name}","releases_url":"https://api.github.com/repos/swiftceipt/SC-XW1/releases{/id}","deployments_url":"https://api.github.com/repos/swiftceipt/SC-XW1/deployments","created_at":"2016-01-27T18:22:16Z","updated_at":"2016-02-28T23:06:41Z","pushed_at":"2016-04-22T00:31:00Z","git_url":"git://github.com/swiftceipt/SC-XW1.git","ssh_url":"git@github.com:swiftceipt/SC-XW1.git","clone_url":"https://github.com/swiftceipt/SC-XW1.git","svn_url":"https://github.com/swiftceipt/SC-XW1","homepage":null,"size":34502,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49"},"html":{"href":"https://github.com/swiftceipt/SC-XW1/pull/49"},"issue":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/49"},"comments":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/swiftceipt/SC-XW1/statuses/35f92e6f14a01bb65060107f0fb05ffb34af816c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ziyunzamy","id":10524185,"avatar_url":"https://avatars.githubusercontent.com/u/10524185?v=3","gravatar_id":"","url":"https://api.github.com/users/ziyunzamy","html_url":"https://github.com/ziyunzamy","followers_url":"https://api.github.com/users/ziyunzamy/followers","following_url":"https://api.github.com/users/ziyunzamy/following{/other_user}","gists_url":"https://api.github.com/users/ziyunzamy/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyunzamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyunzamy/subscriptions","organizations_url":"https://api.github.com/users/ziyunzamy/orgs","repos_url":"https://api.github.com/users/ziyunzamy/repos","events_url":"https://api.github.com/users/ziyunzamy/events{/privacy}","received_events_url":"https://api.github.com/users/ziyunzamy/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":54,"additions":433,"deletions":255,"changed_files":29}}