{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/56198795","id":56198795,"diff_hunk":"@@ -491,6 +497,33 @@ public void execute() {\n     }\n   }\n \n+  private final class TakeSnapshot extends ViewOperation {\n+    private Snapshot snapshot;\n+    private Promise promise;\n+    private File destFile;\n+\n+    public TakeSnapshot(int tag, Snapshot snapshot, File destFile, Promise promise) {","path":"ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java","position":32,"original_position":32,"commit_id":"1b38737560b94169eb4eed331774046c0f3e840e","original_commit_id":"1b38737560b94169eb4eed331774046c0f3e840e","user":{"login":"mkonicek","id":346214,"avatar_url":"https://avatars.githubusercontent.com/u/346214?v=3","gravatar_id":"","url":"https://api.github.com/users/mkonicek","html_url":"https://github.com/mkonicek","followers_url":"https://api.github.com/users/mkonicek/followers","following_url":"https://api.github.com/users/mkonicek/following{/other_user}","gists_url":"https://api.github.com/users/mkonicek/gists{/gist_id}","starred_url":"https://api.github.com/users/mkonicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkonicek/subscriptions","organizations_url":"https://api.github.com/users/mkonicek/orgs","repos_url":"https://api.github.com/users/mkonicek/repos","events_url":"https://api.github.com/users/mkonicek/events{/privacy}","received_events_url":"https://api.github.com/users/mkonicek/received_events","type":"User","site_admin":false},"body":"Can you add a short Javadoc comment explaining this takes a screenshot? The name \"snapshot\" wasn't very obvious to me.","created_at":"2016-03-15T16:54:39Z","updated_at":"2016-03-15T16:54:39Z","html_url":"https://github.com/facebook/react-native/pull/6431#discussion_r56198795","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/6431","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/56198795"},"html":{"href":"https://github.com/facebook/react-native/pull/6431#discussion_r56198795"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6431"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6431","id":62642846,"html_url":"https://github.com/facebook/react-native/pull/6431","diff_url":"https://github.com/facebook/react-native/pull/6431.diff","patch_url":"https://github.com/facebook/react-native/pull/6431.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6431","number":6431,"state":"open","locked":false,"title":"[Android] Implement UIManager.takeSnapshot","user":{"login":"gre","id":211411,"avatar_url":"https://avatars.githubusercontent.com/u/211411?v=3","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"body":"Implement the takeSnapshot feature for Android.\r\n\r\nIt works almost like the iOS implementation. it also supports \"webm\". There might be some tiny difference in Android snapshotting behavior. For instance, the UIExplorer doesn't seem to show a \"recursive\" screenshot like in iOS. Otherwise everything works fine.\r\n\r\nHad to change the internal bridge API from `UIManager.takeSnapshot(view/*String or int*/, options)` to `UIManager.takeSnapshot(view/*String*/, tag/*int*/, options)` because RN Android don't allow generic **id** type like in iOS implementation.\r\n","created_at":"2016-03-12T14:38:32Z","updated_at":"2016-03-15T16:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14de830395d36785589da0bffb034cf5be21cab7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/6431/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/6431/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6431/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/1b38737560b94169eb4eed331774046c0f3e840e","head":{"label":"gre:android-snapshot","ref":"android-snapshot","sha":"1b38737560b94169eb4eed331774046c0f3e840e","user":{"login":"gre","id":211411,"avatar_url":"https://avatars.githubusercontent.com/u/211411?v=3","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"repo":{"id":39572965,"name":"react-native","full_name":"gre/react-native","owner":{"login":"gre","id":211411,"avatar_url":"https://avatars.githubusercontent.com/u/211411?v=3","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gre/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/gre/react-native","forks_url":"https://api.github.com/repos/gre/react-native/forks","keys_url":"https://api.github.com/repos/gre/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gre/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gre/react-native/teams","hooks_url":"https://api.github.com/repos/gre/react-native/hooks","issue_events_url":"https://api.github.com/repos/gre/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/gre/react-native/events","assignees_url":"https://api.github.com/repos/gre/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/gre/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/gre/react-native/tags","blobs_url":"https://api.github.com/repos/gre/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gre/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gre/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/gre/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gre/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/gre/react-native/languages","stargazers_url":"https://api.github.com/repos/gre/react-native/stargazers","contributors_url":"https://api.github.com/repos/gre/react-native/contributors","subscribers_url":"https://api.github.com/repos/gre/react-native/subscribers","subscription_url":"https://api.github.com/repos/gre/react-native/subscription","commits_url":"https://api.github.com/repos/gre/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/gre/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/gre/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/gre/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/gre/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/gre/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gre/react-native/merges","archive_url":"https://api.github.com/repos/gre/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gre/react-native/downloads","issues_url":"https://api.github.com/repos/gre/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/gre/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/gre/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/gre/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gre/react-native/labels{/name}","releases_url":"https://api.github.com/repos/gre/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/gre/react-native/deployments","created_at":"2015-07-23T14:45:13Z","updated_at":"2016-03-13T09:01:31Z","pushed_at":"2016-03-13T09:39:39Z","git_url":"git://github.com/gre/react-native.git","ssh_url":"git@github.com:gre/react-native.git","clone_url":"https://github.com/gre/react-native.git","svn_url":"https://github.com/gre/react-native","homepage":"http://facebook.github.io/react-native/","size":36990,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2e9c888dcd9bf1dbfe62282caa9cf35b91630d0a","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-03-15T16:38:57Z","pushed_at":"2016-03-15T16:49:55Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":82799,"stargazers_count":28712,"watchers_count":28712,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5443,"mirror_url":null,"open_issues_count":1148,"forks":5443,"open_issues":1148,"watchers":28712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6431"},"html":{"href":"https://github.com/facebook/react-native/pull/6431"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/6431"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/6431/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6431/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6431/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/1b38737560b94169eb4eed331774046c0f3e840e"}}}}