{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/53008625","id":53008625,"diff_hunk":"@@ -58,12 +60,14 @@\n     protected final ReentrantLock partitionsLock = new ReentrantLock();\n \n     protected final PartitionedIndexStorage indexStorage;\n+    private final Supplier<IndexWriterConfig> writerConfigSupplier;\n     private List<IndexPartition> partitions = new CopyOnWriteArrayList<>();\n     private volatile boolean open;\n \n-    public AbstractLuceneIndex( PartitionedIndexStorage indexStorage )\n+    public AbstractLuceneIndex( PartitionedIndexStorage indexStorage, Supplier<IndexWriterConfig> writerConfigSupplier )","path":"community/lucene-index/src/main/java/org/neo4j/kernel/api/impl/index/AbstractLuceneIndex.java","position":25,"original_position":25,"commit_id":"78e5d21b3f1654f57fcaaf747ff5cd12c6917129","original_commit_id":"78e5d21b3f1654f57fcaaf747ff5cd12c6917129","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"Would propose to use Factory<IndexWriterConfig> instead since we need new instance always","created_at":"2016-02-16T13:21:42Z","updated_at":"2016-02-16T13:21:42Z","html_url":"https://github.com/neo4j/neo4j/pull/6334#discussion_r53008625","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6334","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/53008625"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6334#discussion_r53008625"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6334"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/6334","id":57838237,"html_url":"https://github.com/neo4j/neo4j/pull/6334","diff_url":"https://github.com/neo4j/neo4j/pull/6334.diff","patch_url":"https://github.com/neo4j/neo4j/pull/6334.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/6334","number":6334,"state":"open","locked":false,"title":"Multi threaded index population","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-01T13:19:33Z","updated_at":"2016-02-16T13:21:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fdb8100b20eb40ba82388b8937403655c51bc2a","assignee":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6334/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6334/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/6334/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/78e5d21b3f1654f57fcaaf747ff5cd12c6917129","head":{"label":"lutovich:3.0-multi-threaded-index-population","ref":"3.0-multi-threaded-index-population","sha":"78e5d21b3f1654f57fcaaf747ff5cd12c6917129","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"repo":{"id":21854315,"name":"neo4j","full_name":"lutovich/neo4j","owner":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lutovich/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/lutovich/neo4j","forks_url":"https://api.github.com/repos/lutovich/neo4j/forks","keys_url":"https://api.github.com/repos/lutovich/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutovich/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutovich/neo4j/teams","hooks_url":"https://api.github.com/repos/lutovich/neo4j/hooks","issue_events_url":"https://api.github.com/repos/lutovich/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/lutovich/neo4j/events","assignees_url":"https://api.github.com/repos/lutovich/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/lutovich/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/lutovich/neo4j/tags","blobs_url":"https://api.github.com/repos/lutovich/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutovich/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutovich/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutovich/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutovich/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/lutovich/neo4j/languages","stargazers_url":"https://api.github.com/repos/lutovich/neo4j/stargazers","contributors_url":"https://api.github.com/repos/lutovich/neo4j/contributors","subscribers_url":"https://api.github.com/repos/lutovich/neo4j/subscribers","subscription_url":"https://api.github.com/repos/lutovich/neo4j/subscription","commits_url":"https://api.github.com/repos/lutovich/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutovich/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutovich/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutovich/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutovich/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/lutovich/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutovich/neo4j/merges","archive_url":"https://api.github.com/repos/lutovich/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutovich/neo4j/downloads","issues_url":"https://api.github.com/repos/lutovich/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/lutovich/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/lutovich/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/lutovich/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutovich/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/lutovich/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/lutovich/neo4j/deployments","created_at":"2014-07-15T09:38:04Z","updated_at":"2015-02-24T16:59:41Z","pushed_at":"2016-02-15T20:27:01Z","git_url":"git://github.com/lutovich/neo4j.git","ssh_url":"git@github.com:lutovich/neo4j.git","clone_url":"https://github.com/lutovich/neo4j.git","svn_url":"https://github.com/lutovich/neo4j","homepage":"http://neo4j.org","size":294599,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"f7649aec8ec019ee1491cb31219882c70f8bcf1f","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-02-16T10:58:20Z","pushed_at":"2016-02-16T13:20:42Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":334449,"stargazers_count":2348,"watchers_count":2348,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":849,"mirror_url":null,"open_issues_count":369,"forks":849,"open_issues":369,"watchers":2348,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6334"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6334"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6334"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6334/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6334/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6334/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/78e5d21b3f1654f57fcaaf747ff5cd12c6917129"}}}}