{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/77797122","id":77797122,"diff_hunk":"@@ -0,0 +1,179 @@\n+// Copyright 2016 PingCAP, Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+//! A module contains test cases of stale peers gc.\n+\n+use std::time::Duration;\n+use std::thread;\n+\n+use kvproto::eraftpb::MessageType;\n+use kvproto::raft_serverpb::{RegionLocalState, PeerState};\n+use tikv::raftstore::store::{keys, Peekable};\n+\n+use super::cluster::{Cluster, Simulator};\n+use super::node::new_node_cluster;\n+use super::server::new_server_cluster;\n+use super::transport_simulate::{Isolate, IsolateRegionStore};\n+use super::util::*;\n+\n+/// A helper function for testing the behaviour of the gc of stale peer\n+/// which is out of region.\n+/// If a peer detects the leader is missing for a specified long time,\n+/// it should consider itself as a stale peer which is removed from the region.\n+/// This test case covers the following scenario:\n+/// At first, there are three peer A, B, C in the cluster, and A is leader.\n+/// Peer B gets down. And then A adds D, E, F int the cluster.\n+/// Peer D becomes leader of the new cluster, and then removes peer A, B, C.\n+/// After all these peer in and out, now the cluster has peer D, E, F.\n+/// If peer B goes up at this moment, it still thinks it is one of the cluster\n+/// and has peers A, C. However, it could not reach A, C since they are removed from\n+/// the cluster or probably destroyed.\n+/// Meantime, D, E, F would not reach B, Since it's not in the cluster anymore.\n+/// In this case, Peer B would notice that the leader is missing for a long time,\n+/// and it would check with pd to confirm whether it's still a member of the cluster.\n+/// If not, it should destroy itself as a stale peer which is removed out already.\n+fn test_stale_peer_out_of_region<T: Simulator>(cluster: &mut Cluster<T>) {\n+    // Revise raft base tick interval small to make this test case run fast.","path":"tests/raftstore/test_stale_peer.rs","position":null,"original_position":46,"commit_id":"541c0d164fbeefa359c651081aad708b26746432","original_commit_id":"379a927362abbb22a890fa1f3c92c777cbcae8a6","user":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"body":"Address comment.","created_at":"2016-09-07T10:28:58Z","updated_at":"2016-09-07T10:28:58Z","html_url":"https://github.com/pingcap/tikv/pull/1003#discussion_r77797122","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/1003","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/77797122"},"html":{"href":"https://github.com/pingcap/tikv/pull/1003#discussion_r77797122"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1003"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/1003","id":83096222,"html_url":"https://github.com/pingcap/tikv/pull/1003","diff_url":"https://github.com/pingcap/tikv/pull/1003.diff","patch_url":"https://github.com/pingcap/tikv/pull/1003.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/1003","number":1003,"state":"open","locked":false,"title":"raftstore/*: gc stale peer out of region","user":{"login":"hhkbp2","id":1933824,"avatar_url":"https://avatars.githubusercontent.com/u/1933824?v=3","gravatar_id":"","url":"https://api.github.com/users/hhkbp2","html_url":"https://github.com/hhkbp2","followers_url":"https://api.github.com/users/hhkbp2/followers","following_url":"https://api.github.com/users/hhkbp2/following{/other_user}","gists_url":"https://api.github.com/users/hhkbp2/gists{/gist_id}","starred_url":"https://api.github.com/users/hhkbp2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhkbp2/subscriptions","organizations_url":"https://api.github.com/users/hhkbp2/orgs","repos_url":"https://api.github.com/users/hhkbp2/repos","events_url":"https://api.github.com/users/hhkbp2/events{/privacy}","received_events_url":"https://api.github.com/users/hhkbp2/received_events","type":"User","site_admin":false},"body":"Fix issue #804 ","created_at":"2016-08-29T13:10:31Z","updated_at":"2016-09-07T10:28:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0dd25a694c9c7f0b1f5c8cd6615223c384b31f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/1003/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/541c0d164fbeefa359c651081aad708b26746432","head":{"label":"pingcap:hhkbp2/gc-stale-peer-out-of-region","ref":"hhkbp2/gc-stale-peer-out-of-region","sha":"541c0d164fbeefa359c651081aad708b26746432","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2016-09-07T08:36:37Z","pushed_at":"2016-09-07T10:28:42Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"","size":5882,"stargazers_count":986,"watchers_count":986,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"open_issues_count":51,"forks":81,"open_issues":51,"watchers":986,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"697dcbfe50c3d2f05b9d2172db75ecdb3ff4582a","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2016-09-07T08:36:37Z","pushed_at":"2016-09-07T10:28:42Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"","size":5882,"stargazers_count":986,"watchers_count":986,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"open_issues_count":51,"forks":81,"open_issues":51,"watchers":986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1003"},"html":{"href":"https://github.com/pingcap/tikv/pull/1003"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/1003"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/541c0d164fbeefa359c651081aad708b26746432"}}}}
{"actor":{"display_login":"hhkbp2"}}