{"action":"opened","number":233,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233","id":73096220,"html_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/233","diff_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/233.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/233.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/233","number":233,"state":"open","locked":false,"title":"FIX: Unbreak on OpenBSD","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"body":"Seems since end of April/beginning of May, with the\r\npermission changes of puppetdb config ini files,\r\nit is broken on OpenBSD.\r\nThis fixes is by setting the $puppetdb_user, and\r\n$puppetdb_group in OS specific case statements:\r\n\r\nSome more info:\r\n\r\nunderprivileged users from packages start with\r\n_underscore, as well as such groups, therefore on OpenBSD, the\r\nuser:group is _puppetdb:_puppetdb\r\n\r\nBecause of that, instead of the single default in params.pp,\r\nmove the definition of puppetdb_user and puppetdb_group into\r\none of the OS specific case statement.\r\n\r\nAs a side node not 100% related:\r\nI wonder why the config files have to be owned by\r\nthe puppetdb user/group?\r\n\r\nFrom a security point of view, wouldn't it make more sense,\r\nto have the config files owned by root:$puppetdb_group, and\r\npermissions like 640? IIRC, puppetdb doesn't need to fiddle\r\nwith the files, only read access should be fine?\r\n\r\npuppetdb is java, so the JIT requires memory regions being\r\nwritable AND executable at the same time, so being a potentially\r\nvaluable target for attackers.\r\n\r\ncheers,\r\nSebastian","created_at":"2016-06-08T18:26:04Z","updated_at":"2016-06-08T18:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/233/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/a19d30c2e8d62a6059b3fb1d672f4645eae99d42","head":{"label":"buzzdeee:fixup_puppetdb_user_group_openbsd","ref":"fixup_puppetdb_user_group_openbsd","sha":"a19d30c2e8d62a6059b3fb1d672f4645eae99d42","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"repo":{"id":53448187,"name":"puppetlabs-puppetdb","full_name":"buzzdeee/puppetlabs-puppetdb","owner":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buzzdeee/puppetlabs-puppetdb","description":"A puppet module for installing and managing puppetdb","fork":true,"url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb","forks_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/forks","keys_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/teams","hooks_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/events","assignees_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/tags","blobs_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/languages","stargazers_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/subscription","commits_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/merges","archive_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/downloads","issues_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/buzzdeee/puppetlabs-puppetdb/deployments","created_at":"2016-03-08T21:56:39Z","updated_at":"2016-03-08T21:56:40Z","pushed_at":"2016-06-08T18:11:19Z","git_url":"git://github.com/buzzdeee/puppetlabs-puppetdb.git","ssh_url":"git@github.com:buzzdeee/puppetlabs-puppetdb.git","clone_url":"https://github.com/buzzdeee/puppetlabs-puppetdb.git","svn_url":"https://github.com/buzzdeee/puppetlabs-puppetdb","homepage":null,"size":603,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6be627da3a3ff159cdefda8c3150f92958a81e24","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":4653174,"name":"puppetlabs-puppetdb","full_name":"puppetlabs/puppetlabs-puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppetdb","description":"A puppet module for installing and managing puppetdb","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/deployments","created_at":"2012-06-13T16:17:23Z","updated_at":"2016-05-29T22:34:33Z","pushed_at":"2016-06-08T17:49:21Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppetdb","homepage":"https://forge.puppetlabs.com/puppetlabs/puppetdb","size":932,"stargazers_count":43,"watchers_count":43,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":21,"forks":139,"open_issues":21,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/233"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/233"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/a19d30c2e8d62a6059b3fb1d672f4645eae99d42"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"buzzdeee"}}