{"action":"created","comment":{"url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/comments/70204027","id":70204027,"diff_hunk":"@@ -344,17 +344,18 @@ def get(self, query):\n             xfc_view = self.application.x_flowcells_db.view(\"samples/lane_clusters\", reduce=False)\n             fc_view = self.application.flowcells_db.view(\"samples/lane_clusters\", reduce=False)\n             for row in xfc_view[query:\"{}Z\".format(query)]:\n-                if not \"isHiseqX\" in data:\n+                if not \"isHiseqX\" in data: # also don't need\n                     data[\"isHiseqX\"]=True\n                 if not row.key in data:\n                     data[row.key]=[]\n                 data[row.key].append(row.value)\n-            for row in fc_view[query:\"{}Z\".format(query)]:\n-                if not row.key in data:\n-                    data[row.key]=[]\n-                if row.value not in data[row.key]:\n-                    data[row.key].append(row.value)\n-            for key in sorted(data.keys()):\n+            # approved by FV, removing these lines 'MOST LIKELY it won't fail'","path":"status/flowcells.py","position":25,"original_position":25,"commit_id":"4e25a78fb8099e7c97235e36a968043eab5bc409","original_commit_id":"4e25a78fb8099e7c97235e36a968043eab5bc409","user":{"login":"vezzi","id":1209695,"avatar_url":"https://avatars.githubusercontent.com/u/1209695?v=3","gravatar_id":"","url":"https://api.github.com/users/vezzi","html_url":"https://github.com/vezzi","followers_url":"https://api.github.com/users/vezzi/followers","following_url":"https://api.github.com/users/vezzi/following{/other_user}","gists_url":"https://api.github.com/users/vezzi/gists{/gist_id}","starred_url":"https://api.github.com/users/vezzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vezzi/subscriptions","organizations_url":"https://api.github.com/users/vezzi/orgs","repos_url":"https://api.github.com/users/vezzi/repos","events_url":"https://api.github.com/users/vezzi/events{/privacy}","received_events_url":"https://api.github.com/users/vezzi/received_events","type":"User","site_admin":false},"body":"like this comment :-D","created_at":"2016-07-11T05:32:54Z","updated_at":"2016-07-11T05:32:54Z","html_url":"https://github.com/SciLifeLab/genomics-status/pull/296#discussion_r70204027","pull_request_url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296","_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/comments/70204027"},"html":{"href":"https://github.com/SciLifeLab/genomics-status/pull/296#discussion_r70204027"},"pull_request":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296","id":76755469,"html_url":"https://github.com/SciLifeLab/genomics-status/pull/296","diff_url":"https://github.com/SciLifeLab/genomics-status/pull/296.diff","patch_url":"https://github.com/SciLifeLab/genomics-status/pull/296.patch","issue_url":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/296","number":296,"state":"open","locked":false,"title":"TACA fix: x_flowcell DB should contain everything","user":{"login":"kate-v-stepanova","id":13888678,"avatar_url":"https://avatars.githubusercontent.com/u/13888678?v=3","gravatar_id":"","url":"https://api.github.com/users/kate-v-stepanova","html_url":"https://github.com/kate-v-stepanova","followers_url":"https://api.github.com/users/kate-v-stepanova/followers","following_url":"https://api.github.com/users/kate-v-stepanova/following{/other_user}","gists_url":"https://api.github.com/users/kate-v-stepanova/gists{/gist_id}","starred_url":"https://api.github.com/users/kate-v-stepanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kate-v-stepanova/subscriptions","organizations_url":"https://api.github.com/users/kate-v-stepanova/orgs","repos_url":"https://api.github.com/users/kate-v-stepanova/repos","events_url":"https://api.github.com/users/kate-v-stepanova/events{/privacy}","received_events_url":"https://api.github.com/users/kate-v-stepanova/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-08T13:48:03Z","updated_at":"2016-07-11T05:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df0847c700960f80cfe01f6dd76d95d2880fa2d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296/commits","review_comments_url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296/comments","review_comment_url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/296/comments","statuses_url":"https://api.github.com/repos/SciLifeLab/genomics-status/statuses/4e25a78fb8099e7c97235e36a968043eab5bc409","head":{"label":"kate-v-stepanova:master","ref":"master","sha":"4e25a78fb8099e7c97235e36a968043eab5bc409","user":{"login":"kate-v-stepanova","id":13888678,"avatar_url":"https://avatars.githubusercontent.com/u/13888678?v=3","gravatar_id":"","url":"https://api.github.com/users/kate-v-stepanova","html_url":"https://github.com/kate-v-stepanova","followers_url":"https://api.github.com/users/kate-v-stepanova/followers","following_url":"https://api.github.com/users/kate-v-stepanova/following{/other_user}","gists_url":"https://api.github.com/users/kate-v-stepanova/gists{/gist_id}","starred_url":"https://api.github.com/users/kate-v-stepanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kate-v-stepanova/subscriptions","organizations_url":"https://api.github.com/users/kate-v-stepanova/orgs","repos_url":"https://api.github.com/users/kate-v-stepanova/repos","events_url":"https://api.github.com/users/kate-v-stepanova/events{/privacy}","received_events_url":"https://api.github.com/users/kate-v-stepanova/received_events","type":"User","site_admin":false},"repo":{"id":41307693,"name":"genomics-status","full_name":"kate-v-stepanova/genomics-status","owner":{"login":"kate-v-stepanova","id":13888678,"avatar_url":"https://avatars.githubusercontent.com/u/13888678?v=3","gravatar_id":"","url":"https://api.github.com/users/kate-v-stepanova","html_url":"https://github.com/kate-v-stepanova","followers_url":"https://api.github.com/users/kate-v-stepanova/followers","following_url":"https://api.github.com/users/kate-v-stepanova/following{/other_user}","gists_url":"https://api.github.com/users/kate-v-stepanova/gists{/gist_id}","starred_url":"https://api.github.com/users/kate-v-stepanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kate-v-stepanova/subscriptions","organizations_url":"https://api.github.com/users/kate-v-stepanova/orgs","repos_url":"https://api.github.com/users/kate-v-stepanova/repos","events_url":"https://api.github.com/users/kate-v-stepanova/events{/privacy}","received_events_url":"https://api.github.com/users/kate-v-stepanova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kate-v-stepanova/genomics-status","description":"Tornado server for tracking samples at NGI Stockholm","fork":true,"url":"https://api.github.com/repos/kate-v-stepanova/genomics-status","forks_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/forks","keys_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/teams","hooks_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/hooks","issue_events_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/issues/events{/number}","events_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/events","assignees_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/assignees{/user}","branches_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/branches{/branch}","tags_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/tags","blobs_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/git/refs{/sha}","trees_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/statuses/{sha}","languages_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/languages","stargazers_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/stargazers","contributors_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/contributors","subscribers_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/subscribers","subscription_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/subscription","commits_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/commits{/sha}","git_commits_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/git/commits{/sha}","comments_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/comments{/number}","issue_comment_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/issues/comments{/number}","contents_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/contents/{+path}","compare_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/merges","archive_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/downloads","issues_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/issues{/number}","pulls_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/pulls{/number}","milestones_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/milestones{/number}","notifications_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/labels{/name}","releases_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/releases{/id}","deployments_url":"https://api.github.com/repos/kate-v-stepanova/genomics-status/deployments","created_at":"2015-08-24T14:26:28Z","updated_at":"2016-06-08T10:12:24Z","pushed_at":"2016-07-08T13:47:13Z","git_url":"git://github.com/kate-v-stepanova/genomics-status.git","ssh_url":"git@github.com:kate-v-stepanova/genomics-status.git","clone_url":"https://github.com/kate-v-stepanova/genomics-status.git","svn_url":"https://github.com/kate-v-stepanova/genomics-status","homepage":"https://genomics-status.scilifelab.se","size":4012,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciLifeLab:master","ref":"master","sha":"f334b53e8ed34ad6d3b062f1b2a8ff2c4e0d9aea","user":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=3","gravatar_id":"","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"repo":{"id":4652091,"name":"genomics-status","full_name":"SciLifeLab/genomics-status","owner":{"login":"SciLifeLab","id":713611,"avatar_url":"https://avatars.githubusercontent.com/u/713611?v=3","gravatar_id":"","url":"https://api.github.com/users/SciLifeLab","html_url":"https://github.com/SciLifeLab","followers_url":"https://api.github.com/users/SciLifeLab/followers","following_url":"https://api.github.com/users/SciLifeLab/following{/other_user}","gists_url":"https://api.github.com/users/SciLifeLab/gists{/gist_id}","starred_url":"https://api.github.com/users/SciLifeLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciLifeLab/subscriptions","organizations_url":"https://api.github.com/users/SciLifeLab/orgs","repos_url":"https://api.github.com/users/SciLifeLab/repos","events_url":"https://api.github.com/users/SciLifeLab/events{/privacy}","received_events_url":"https://api.github.com/users/SciLifeLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciLifeLab/genomics-status","description":"Tornado server for tracking samples at NGI Stockholm","fork":true,"url":"https://api.github.com/repos/SciLifeLab/genomics-status","forks_url":"https://api.github.com/repos/SciLifeLab/genomics-status/forks","keys_url":"https://api.github.com/repos/SciLifeLab/genomics-status/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciLifeLab/genomics-status/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciLifeLab/genomics-status/teams","hooks_url":"https://api.github.com/repos/SciLifeLab/genomics-status/hooks","issue_events_url":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/events{/number}","events_url":"https://api.github.com/repos/SciLifeLab/genomics-status/events","assignees_url":"https://api.github.com/repos/SciLifeLab/genomics-status/assignees{/user}","branches_url":"https://api.github.com/repos/SciLifeLab/genomics-status/branches{/branch}","tags_url":"https://api.github.com/repos/SciLifeLab/genomics-status/tags","blobs_url":"https://api.github.com/repos/SciLifeLab/genomics-status/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciLifeLab/genomics-status/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciLifeLab/genomics-status/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciLifeLab/genomics-status/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciLifeLab/genomics-status/statuses/{sha}","languages_url":"https://api.github.com/repos/SciLifeLab/genomics-status/languages","stargazers_url":"https://api.github.com/repos/SciLifeLab/genomics-status/stargazers","contributors_url":"https://api.github.com/repos/SciLifeLab/genomics-status/contributors","subscribers_url":"https://api.github.com/repos/SciLifeLab/genomics-status/subscribers","subscription_url":"https://api.github.com/repos/SciLifeLab/genomics-status/subscription","commits_url":"https://api.github.com/repos/SciLifeLab/genomics-status/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciLifeLab/genomics-status/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciLifeLab/genomics-status/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciLifeLab/genomics-status/contents/{+path}","compare_url":"https://api.github.com/repos/SciLifeLab/genomics-status/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciLifeLab/genomics-status/merges","archive_url":"https://api.github.com/repos/SciLifeLab/genomics-status/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciLifeLab/genomics-status/downloads","issues_url":"https://api.github.com/repos/SciLifeLab/genomics-status/issues{/number}","pulls_url":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls{/number}","milestones_url":"https://api.github.com/repos/SciLifeLab/genomics-status/milestones{/number}","notifications_url":"https://api.github.com/repos/SciLifeLab/genomics-status/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciLifeLab/genomics-status/labels{/name}","releases_url":"https://api.github.com/repos/SciLifeLab/genomics-status/releases{/id}","deployments_url":"https://api.github.com/repos/SciLifeLab/genomics-status/deployments","created_at":"2012-06-13T14:39:29Z","updated_at":"2016-05-25T01:20:57Z","pushed_at":"2016-07-08T13:48:03Z","git_url":"git://github.com/SciLifeLab/genomics-status.git","ssh_url":"git@github.com:SciLifeLab/genomics-status.git","clone_url":"https://github.com/SciLifeLab/genomics-status.git","svn_url":"https://github.com/SciLifeLab/genomics-status","homepage":"https://genomics-status.scilifelab.se","size":4241,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296"},"html":{"href":"https://github.com/SciLifeLab/genomics-status/pull/296"},"issue":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/296"},"comments":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/SciLifeLab/genomics-status/statuses/4e25a78fb8099e7c97235e36a968043eab5bc409"}}}}
{"actor":{"display_login":"vezzi"}}