{"action":"created","comment":{"url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/comments/78919946","id":78919946,"diff_hunk":"@@ -213,7 +215,31 @@ function install(opts, cb) {\n     );\n     fs.createReadStream(gzipFilePath).pipe(gunzip).pipe(writeStream)\n       .once('error', cb.bind(null, new Error('Could not read ' + gzipFilePath)))\n-      .once('finish', function() { cb() })\n+      .once('finish', function() {\n+        if (from.substr(-7) === '.tar.gz') {\n+          var destDir = path.join(os.tmpdir(), 'selenium-standalone-' + Math.random());","path":"lib/install.js","position":30,"original_position":30,"commit_id":"4e3fcca5dd3d7327bc82f9caaa26b7ceff0d815e","original_commit_id":"4e3fcca5dd3d7327bc82f9caaa26b7ceff0d815e","user":{"login":"jucrouzet","id":471070,"avatar_url":"https://avatars.githubusercontent.com/u/471070?v=3","gravatar_id":"","url":"https://api.github.com/users/jucrouzet","html_url":"https://github.com/jucrouzet","followers_url":"https://api.github.com/users/jucrouzet/followers","following_url":"https://api.github.com/users/jucrouzet/following{/other_user}","gists_url":"https://api.github.com/users/jucrouzet/gists{/gist_id}","starred_url":"https://api.github.com/users/jucrouzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jucrouzet/subscriptions","organizations_url":"https://api.github.com/users/jucrouzet/orgs","repos_url":"https://api.github.com/users/jucrouzet/repos","events_url":"https://api.github.com/users/jucrouzet/events{/privacy}","received_events_url":"https://api.github.com/users/jucrouzet/received_events","type":"User","site_admin":false},"body":"Probably, I will check for another module... Should be a good idea thought as it's a one file tar archive.\r\nI make a commit this afternoon to correct it","created_at":"2016-09-15T09:11:41Z","updated_at":"2016-09-15T09:11:41Z","html_url":"https://github.com/vvo/selenium-standalone/pull/222#discussion_r78919946","pull_request_url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/comments/78919946"},"html":{"href":"https://github.com/vvo/selenium-standalone/pull/222#discussion_r78919946"},"pull_request":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222","id":85309633,"html_url":"https://github.com/vvo/selenium-standalone/pull/222","diff_url":"https://github.com/vvo/selenium-standalone/pull/222.diff","patch_url":"https://github.com/vvo/selenium-standalone/pull/222.patch","issue_url":"https://api.github.com/repos/vvo/selenium-standalone/issues/222","number":222,"state":"open","locked":false,"title":"Handles geckodriver/Marionette urls weirdness and untar driver","user":{"login":"jucrouzet","id":471070,"avatar_url":"https://avatars.githubusercontent.com/u/471070?v=3","gravatar_id":"","url":"https://api.github.com/users/jucrouzet","html_url":"https://github.com/jucrouzet","followers_url":"https://api.github.com/users/jucrouzet/followers","following_url":"https://api.github.com/users/jucrouzet/following{/other_user}","gists_url":"https://api.github.com/users/jucrouzet/gists{/gist_id}","starred_url":"https://api.github.com/users/jucrouzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jucrouzet/subscriptions","organizations_url":"https://api.github.com/users/jucrouzet/orgs","repos_url":"https://api.github.com/users/jucrouzet/repos","events_url":"https://api.github.com/users/jucrouzet/events{/privacy}","received_events_url":"https://api.github.com/users/jucrouzet/received_events","type":"User","site_admin":false},"body":"Fixes several problems with geckodriver/Marionette urls and files.\r\n\r\n1. geckodriver was named wires before 0.8.0\r\n2. The 0.3.0 version directory is names `/0.3.0/` instead of `/v0.3.0/` \r\n3. The file is sometimes names `[name]-v[version]-[arch]` and sometimes `[name]-[version]-[arch]`\r\n4. Prior to 0.9.0, files were just gzipped, (not tar'd/gzipped)\r\n5. .tar.gz files were not untar'd (extracted), resulting to : \r\n\r\n```\r\n[...]\r\n>> node_modules/selenium-standalone/.selenium/geckodriver/0.9.0-x64-geckodriver: 1: node_modules/selenium-standalone/.selenium/geckodriver/0.9.0-x64-geckodriver: Syntax error: \")\" unexpected\r\n```\r\n(Which at the end throws a `org.openqa.selenium.remote.UnreachableBrowserException` as browser is not launched)","created_at":"2016-09-14T21:35:01Z","updated_at":"2016-09-15T09:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc896029a8bfaee7584e382496156a309d0cea5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222/commits","review_comments_url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222/comments","review_comment_url":"https://api.github.com/repos/vvo/selenium-standalone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vvo/selenium-standalone/issues/222/comments","statuses_url":"https://api.github.com/repos/vvo/selenium-standalone/statuses/4e3fcca5dd3d7327bc82f9caaa26b7ceff0d815e","head":{"label":"jucrouzet:master","ref":"master","sha":"4e3fcca5dd3d7327bc82f9caaa26b7ceff0d815e","user":{"login":"jucrouzet","id":471070,"avatar_url":"https://avatars.githubusercontent.com/u/471070?v=3","gravatar_id":"","url":"https://api.github.com/users/jucrouzet","html_url":"https://github.com/jucrouzet","followers_url":"https://api.github.com/users/jucrouzet/followers","following_url":"https://api.github.com/users/jucrouzet/following{/other_user}","gists_url":"https://api.github.com/users/jucrouzet/gists{/gist_id}","starred_url":"https://api.github.com/users/jucrouzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jucrouzet/subscriptions","organizations_url":"https://api.github.com/users/jucrouzet/orgs","repos_url":"https://api.github.com/users/jucrouzet/repos","events_url":"https://api.github.com/users/jucrouzet/events{/privacy}","received_events_url":"https://api.github.com/users/jucrouzet/received_events","type":"User","site_admin":false},"repo":{"id":68239642,"name":"selenium-standalone","full_name":"jucrouzet/selenium-standalone","owner":{"login":"jucrouzet","id":471070,"avatar_url":"https://avatars.githubusercontent.com/u/471070?v=3","gravatar_id":"","url":"https://api.github.com/users/jucrouzet","html_url":"https://github.com/jucrouzet","followers_url":"https://api.github.com/users/jucrouzet/followers","following_url":"https://api.github.com/users/jucrouzet/following{/other_user}","gists_url":"https://api.github.com/users/jucrouzet/gists{/gist_id}","starred_url":"https://api.github.com/users/jucrouzet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jucrouzet/subscriptions","organizations_url":"https://api.github.com/users/jucrouzet/orgs","repos_url":"https://api.github.com/users/jucrouzet/repos","events_url":"https://api.github.com/users/jucrouzet/events{/privacy}","received_events_url":"https://api.github.com/users/jucrouzet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jucrouzet/selenium-standalone","description":"get a `selenium-standalone install/start` command line to start a standalone selenium server with chromedriver, firefox, phantomjs support","fork":true,"url":"https://api.github.com/repos/jucrouzet/selenium-standalone","forks_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/forks","keys_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/teams","hooks_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/hooks","issue_events_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/events","assignees_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/tags","blobs_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/languages","stargazers_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/stargazers","contributors_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/contributors","subscribers_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/subscribers","subscription_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/subscription","commits_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/merges","archive_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/downloads","issues_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/labels{/name}","releases_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/jucrouzet/selenium-standalone/deployments","created_at":"2016-09-14T20:12:27Z","updated_at":"2016-09-14T20:12:28Z","pushed_at":"2016-09-14T21:23:19Z","git_url":"git://github.com/jucrouzet/selenium-standalone.git","ssh_url":"git@github.com:jucrouzet/selenium-standalone.git","clone_url":"https://github.com/jucrouzet/selenium-standalone.git","svn_url":"https://github.com/jucrouzet/selenium-standalone","homepage":"","size":829,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vvo:master","ref":"master","sha":"c274fa6d0d9b2862dd6bd438321267bf0065587a","user":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"repo":{"id":13092659,"name":"selenium-standalone","full_name":"vvo/selenium-standalone","owner":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvo/selenium-standalone","description":"get a `selenium-standalone install/start` command line to start a standalone selenium server with chromedriver, firefox, phantomjs support","fork":false,"url":"https://api.github.com/repos/vvo/selenium-standalone","forks_url":"https://api.github.com/repos/vvo/selenium-standalone/forks","keys_url":"https://api.github.com/repos/vvo/selenium-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvo/selenium-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvo/selenium-standalone/teams","hooks_url":"https://api.github.com/repos/vvo/selenium-standalone/hooks","issue_events_url":"https://api.github.com/repos/vvo/selenium-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/vvo/selenium-standalone/events","assignees_url":"https://api.github.com/repos/vvo/selenium-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/vvo/selenium-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/vvo/selenium-standalone/tags","blobs_url":"https://api.github.com/repos/vvo/selenium-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvo/selenium-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvo/selenium-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvo/selenium-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvo/selenium-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/vvo/selenium-standalone/languages","stargazers_url":"https://api.github.com/repos/vvo/selenium-standalone/stargazers","contributors_url":"https://api.github.com/repos/vvo/selenium-standalone/contributors","subscribers_url":"https://api.github.com/repos/vvo/selenium-standalone/subscribers","subscription_url":"https://api.github.com/repos/vvo/selenium-standalone/subscription","commits_url":"https://api.github.com/repos/vvo/selenium-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvo/selenium-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvo/selenium-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvo/selenium-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvo/selenium-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/vvo/selenium-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvo/selenium-standalone/merges","archive_url":"https://api.github.com/repos/vvo/selenium-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvo/selenium-standalone/downloads","issues_url":"https://api.github.com/repos/vvo/selenium-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/vvo/selenium-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/vvo/selenium-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/vvo/selenium-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvo/selenium-standalone/labels{/name}","releases_url":"https://api.github.com/repos/vvo/selenium-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/vvo/selenium-standalone/deployments","created_at":"2013-09-25T12:10:36Z","updated_at":"2016-09-13T09:28:19Z","pushed_at":"2016-09-14T21:35:01Z","git_url":"git://github.com/vvo/selenium-standalone.git","ssh_url":"git@github.com:vvo/selenium-standalone.git","clone_url":"https://github.com/vvo/selenium-standalone.git","svn_url":"https://github.com/vvo/selenium-standalone","homepage":"","size":848,"stargazers_count":409,"watchers_count":409,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":28,"forks":96,"open_issues":28,"watchers":409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222"},"html":{"href":"https://github.com/vvo/selenium-standalone/pull/222"},"issue":{"href":"https://api.github.com/repos/vvo/selenium-standalone/issues/222"},"comments":{"href":"https://api.github.com/repos/vvo/selenium-standalone/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vvo/selenium-standalone/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/vvo/selenium-standalone/statuses/4e3fcca5dd3d7327bc82f9caaa26b7ceff0d815e"}}}}
{"actor":{"display_login":"jucrouzet"}}