{"action":"created","comment":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/85217609","pull_request_review_id":5945880,"id":85217609,"diff_hunk":"@@ -540,7 +559,7 @@ find_package(Pugixml 1.2 REQUIRED)\n include_directories(SYSTEM ${Pugixml_INCLUDE_DIRS})\n list(APPEND LIBS ${Pugixml_LIBRARIES})\n \n-if(NOT SOURCE_PACKAGE AND NOT APPLE)\n+if(NOT SOURCE_PACKAGE AND NOT APPLE AND NOT WIN32)","path":"src/CMakeLists.txt","position":58,"original_position":58,"commit_id":"d752617d093e857b1b43d4ad92cbd193f7e502c1","original_commit_id":"984a7bd13a423902ffcf4b83bc8e8e88f8b6e46d","user":{"login":"LebedevRI","id":88600,"avatar_url":"https://avatars.githubusercontent.com/u/88600?v=3","gravatar_id":"","url":"https://api.github.com/users/LebedevRI","html_url":"https://github.com/LebedevRI","followers_url":"https://api.github.com/users/LebedevRI/followers","following_url":"https://api.github.com/users/LebedevRI/following{/other_user}","gists_url":"https://api.github.com/users/LebedevRI/gists{/gist_id}","starred_url":"https://api.github.com/users/LebedevRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LebedevRI/subscriptions","organizations_url":"https://api.github.com/users/LebedevRI/orgs","repos_url":"https://api.github.com/users/LebedevRI/repos","events_url":"https://api.github.com/users/LebedevRI/events{/privacy}","received_events_url":"https://api.github.com/users/LebedevRI/received_events","type":"User","site_admin":false},"body":"If there is no SOURCE_PACKAGE, then there is no -Werror at all.\r\nMaybe i'm missing something, which -Werror does turn them into errors for you? The one that you pass manually?","created_at":"2016-10-26T20:52:01Z","updated_at":"2016-10-26T20:52:01Z","html_url":"https://github.com/darktable-org/darktable/pull/1327#discussion_r85217609","pull_request_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1327","_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments/85217609"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1327#discussion_r85217609"},"pull_request":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1327"}}},"pull_request":{"url":"https://api.github.com/repos/darktable-org/darktable/pulls/1327","id":90648265,"html_url":"https://github.com/darktable-org/darktable/pull/1327","diff_url":"https://github.com/darktable-org/darktable/pull/1327.diff","patch_url":"https://github.com/darktable-org/darktable/pull/1327.patch","issue_url":"https://api.github.com/repos/darktable-org/darktable/issues/1327","number":1327,"state":"open","locked":false,"title":"Windows build","user":{"login":"peterbud","id":7863452,"avatar_url":"https://avatars.githubusercontent.com/u/7863452?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbud","html_url":"https://github.com/peterbud","followers_url":"https://api.github.com/users/peterbud/followers","following_url":"https://api.github.com/users/peterbud/following{/other_user}","gists_url":"https://api.github.com/users/peterbud/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbud/subscriptions","organizations_url":"https://api.github.com/users/peterbud/orgs","repos_url":"https://api.github.com/users/peterbud/repos","events_url":"https://api.github.com/users/peterbud/events{/privacy}","received_events_url":"https://api.github.com/users/peterbud/received_events","type":"User","site_admin":false},"body":"First of all I know the question of a Windows build has been controversial, and generated a lot of emotion in the past. All I'm asking is to look into this PR in an objective way, setting emotions aside.\r\n\r\nIn the last 2 months I have been working on creating a decent Windows port of darktable. I believe this software is brilliant, and would deserve  to reach a broader (but less fortunate) audience who are still only familiar with Windows.\r\nFor the port I have used the [MSYS2](http://msys2.github.io/) Mingw64 environment, which enabled to use the existing build system without any major change. The resulting code is native 64-bit, no dependency on propriatery libraries, only what comes with Windows. \r\n\r\nTo see the whole effort, please note that first I had to port to Windows the following libraries (as no ports were available on MSYS2 or on Windows at all):\r\n* [PugiXML](https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-pugixml)\r\n* [osm-gps-map](https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-osm-gps-map)\r\n* [libgd](https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-libgd)\r\n* [libgphoto2](https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-libgphoto2)\r\n* LUA was available, but a newer version, so I had to build the 5.2 version myself\r\n\r\nThe other libraries have been already ported and were available.\r\n\r\nAlso I have realized that there is no decent GTK3 binary distribution so I have also contributed to a [project ](https://github.com/tschoonj/GTK-for-Windows-Runtime-Environment-Installer) which now can deliver a solid binary distribution for GTK3\r\n\r\nAlong the way I have added all the necessary Windows specific code, where I have tried to make as few surgical changes as possible, and not interfering with the existing code. During the port I had to add a few functions which were missing from MSCRT. I have tested the current PR is still building properly on Ubuntu.\r\nI have documented the necessary steps to prepare the Windows build in the /packaging/windows/BUILD.txt file in detail.\r\n\r\nThe current version is a fully functional darktable which runs nicely on Windows, supports all basic lighttable and darkroom functionality + OpenCL, lensfun, tethering, slideshow and map.\r\n\r\nWhat is missing is the printing and color management functionality, that is more complex and requires more time.\r\n\r\nFinally I'm planning to create a decent installer package using cmake and NSIS later, as users are expecting a binary distribution format. \r\n\r\nAny constructive feedback is welcome.","created_at":"2016-10-24T16:33:58Z","updated_at":"2016-10-26T20:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"008bba5022f59edbca71aa68fc2720eb8b9c7c98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1327/commits","review_comments_url":"https://api.github.com/repos/darktable-org/darktable/pulls/1327/comments","review_comment_url":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darktable-org/darktable/issues/1327/comments","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/d752617d093e857b1b43d4ad92cbd193f7e502c1","head":{"label":"peterbud:windows-build","ref":"windows-build","sha":"d752617d093e857b1b43d4ad92cbd193f7e502c1","user":{"login":"peterbud","id":7863452,"avatar_url":"https://avatars.githubusercontent.com/u/7863452?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbud","html_url":"https://github.com/peterbud","followers_url":"https://api.github.com/users/peterbud/followers","following_url":"https://api.github.com/users/peterbud/following{/other_user}","gists_url":"https://api.github.com/users/peterbud/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbud/subscriptions","organizations_url":"https://api.github.com/users/peterbud/orgs","repos_url":"https://api.github.com/users/peterbud/repos","events_url":"https://api.github.com/users/peterbud/events{/privacy}","received_events_url":"https://api.github.com/users/peterbud/received_events","type":"User","site_admin":false},"repo":{"id":65959321,"name":"darktable","full_name":"peterbud/darktable","owner":{"login":"peterbud","id":7863452,"avatar_url":"https://avatars.githubusercontent.com/u/7863452?v=3","gravatar_id":"","url":"https://api.github.com/users/peterbud","html_url":"https://github.com/peterbud","followers_url":"https://api.github.com/users/peterbud/followers","following_url":"https://api.github.com/users/peterbud/following{/other_user}","gists_url":"https://api.github.com/users/peterbud/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbud/subscriptions","organizations_url":"https://api.github.com/users/peterbud/orgs","repos_url":"https://api.github.com/users/peterbud/repos","events_url":"https://api.github.com/users/peterbud/events{/privacy}","received_events_url":"https://api.github.com/users/peterbud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterbud/darktable","description":"darktable main repository","fork":true,"url":"https://api.github.com/repos/peterbud/darktable","forks_url":"https://api.github.com/repos/peterbud/darktable/forks","keys_url":"https://api.github.com/repos/peterbud/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterbud/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterbud/darktable/teams","hooks_url":"https://api.github.com/repos/peterbud/darktable/hooks","issue_events_url":"https://api.github.com/repos/peterbud/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/peterbud/darktable/events","assignees_url":"https://api.github.com/repos/peterbud/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/peterbud/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/peterbud/darktable/tags","blobs_url":"https://api.github.com/repos/peterbud/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterbud/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterbud/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterbud/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterbud/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/peterbud/darktable/languages","stargazers_url":"https://api.github.com/repos/peterbud/darktable/stargazers","contributors_url":"https://api.github.com/repos/peterbud/darktable/contributors","subscribers_url":"https://api.github.com/repos/peterbud/darktable/subscribers","subscription_url":"https://api.github.com/repos/peterbud/darktable/subscription","commits_url":"https://api.github.com/repos/peterbud/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterbud/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterbud/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterbud/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterbud/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/peterbud/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterbud/darktable/merges","archive_url":"https://api.github.com/repos/peterbud/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterbud/darktable/downloads","issues_url":"https://api.github.com/repos/peterbud/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/peterbud/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/peterbud/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/peterbud/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterbud/darktable/labels{/name}","releases_url":"https://api.github.com/repos/peterbud/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/peterbud/darktable/deployments","created_at":"2016-08-18T02:42:57Z","updated_at":"2016-08-18T02:43:02Z","pushed_at":"2016-10-26T20:11:43Z","git_url":"git://github.com/peterbud/darktable.git","ssh_url":"git@github.com:peterbud/darktable.git","clone_url":"https://github.com/peterbud/darktable.git","svn_url":"https://github.com/peterbud/darktable","homepage":"http://www.darktable.org","size":231679,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darktable-org:master","ref":"master","sha":"5eef02f58d090356c56fb4077a9645fd3d300731","user":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"repo":{"id":3791835,"name":"darktable","full_name":"darktable-org/darktable","owner":{"login":"darktable-org","id":1561544,"avatar_url":"https://avatars.githubusercontent.com/u/1561544?v=3","gravatar_id":"","url":"https://api.github.com/users/darktable-org","html_url":"https://github.com/darktable-org","followers_url":"https://api.github.com/users/darktable-org/followers","following_url":"https://api.github.com/users/darktable-org/following{/other_user}","gists_url":"https://api.github.com/users/darktable-org/gists{/gist_id}","starred_url":"https://api.github.com/users/darktable-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darktable-org/subscriptions","organizations_url":"https://api.github.com/users/darktable-org/orgs","repos_url":"https://api.github.com/users/darktable-org/repos","events_url":"https://api.github.com/users/darktable-org/events{/privacy}","received_events_url":"https://api.github.com/users/darktable-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darktable-org/darktable","description":"darktable is an open source photography workflow application and raw developer","fork":false,"url":"https://api.github.com/repos/darktable-org/darktable","forks_url":"https://api.github.com/repos/darktable-org/darktable/forks","keys_url":"https://api.github.com/repos/darktable-org/darktable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darktable-org/darktable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darktable-org/darktable/teams","hooks_url":"https://api.github.com/repos/darktable-org/darktable/hooks","issue_events_url":"https://api.github.com/repos/darktable-org/darktable/issues/events{/number}","events_url":"https://api.github.com/repos/darktable-org/darktable/events","assignees_url":"https://api.github.com/repos/darktable-org/darktable/assignees{/user}","branches_url":"https://api.github.com/repos/darktable-org/darktable/branches{/branch}","tags_url":"https://api.github.com/repos/darktable-org/darktable/tags","blobs_url":"https://api.github.com/repos/darktable-org/darktable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darktable-org/darktable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darktable-org/darktable/git/refs{/sha}","trees_url":"https://api.github.com/repos/darktable-org/darktable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darktable-org/darktable/statuses/{sha}","languages_url":"https://api.github.com/repos/darktable-org/darktable/languages","stargazers_url":"https://api.github.com/repos/darktable-org/darktable/stargazers","contributors_url":"https://api.github.com/repos/darktable-org/darktable/contributors","subscribers_url":"https://api.github.com/repos/darktable-org/darktable/subscribers","subscription_url":"https://api.github.com/repos/darktable-org/darktable/subscription","commits_url":"https://api.github.com/repos/darktable-org/darktable/commits{/sha}","git_commits_url":"https://api.github.com/repos/darktable-org/darktable/git/commits{/sha}","comments_url":"https://api.github.com/repos/darktable-org/darktable/comments{/number}","issue_comment_url":"https://api.github.com/repos/darktable-org/darktable/issues/comments{/number}","contents_url":"https://api.github.com/repos/darktable-org/darktable/contents/{+path}","compare_url":"https://api.github.com/repos/darktable-org/darktable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darktable-org/darktable/merges","archive_url":"https://api.github.com/repos/darktable-org/darktable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darktable-org/darktable/downloads","issues_url":"https://api.github.com/repos/darktable-org/darktable/issues{/number}","pulls_url":"https://api.github.com/repos/darktable-org/darktable/pulls{/number}","milestones_url":"https://api.github.com/repos/darktable-org/darktable/milestones{/number}","notifications_url":"https://api.github.com/repos/darktable-org/darktable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darktable-org/darktable/labels{/name}","releases_url":"https://api.github.com/repos/darktable-org/darktable/releases{/id}","deployments_url":"https://api.github.com/repos/darktable-org/darktable/deployments","created_at":"2012-03-21T21:53:04Z","updated_at":"2016-10-23T21:31:32Z","pushed_at":"2016-10-26T20:11:44Z","git_url":"git://github.com/darktable-org/darktable.git","ssh_url":"git@github.com:darktable-org/darktable.git","clone_url":"https://github.com/darktable-org/darktable.git","svn_url":"https://github.com/darktable-org/darktable","homepage":"https://www.darktable.org","size":258777,"stargazers_count":988,"watchers_count":988,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":18,"forks":323,"open_issues":18,"watchers":988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1327"},"html":{"href":"https://github.com/darktable-org/darktable/pull/1327"},"issue":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1327"},"comments":{"href":"https://api.github.com/repos/darktable-org/darktable/issues/1327/comments"},"review_comments":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1327/comments"},"review_comment":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darktable-org/darktable/pulls/1327/commits"},"statuses":{"href":"https://api.github.com/repos/darktable-org/darktable/statuses/d752617d093e857b1b43d4ad92cbd193f7e502c1"}}}}
{"actor":{"display_login":"LebedevRI"}}