{"action":"created","comment":{"url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/comments/78299062","id":78299062,"diff_hunk":"@@ -137,7 +137,7 @@ on the sniffs, the following installation steps are required.\n \n #### Issues when running the PHPCS Unit tests for another standard\n \n-This sniff library uses it's own PHPUnit setup rather than the PHPCS native unit testing framework to allow for testing the sniffs with various config settings for the `testVersion` variable.\n+This sniff library uses its own PHPUnit setup rather than the PHPCS native unit testing framework to allow for testing the sniffs with various config settings for the `testVersion` variable.","path":"README.md","position":null,"original_position":5,"commit_id":"2bc1fabcb5fb3e293482828bf1daac53239a29f6","original_commit_id":"2bc1fabcb5fb3e293482828bf1daac53239a29f6","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"body":"Ahum... not a typo: http://www.elearnenglishlanguage.com/blog/english-mistakes/its/","created_at":"2016-09-11T17:34:14Z","updated_at":"2016-09-11T17:34:14Z","html_url":"https://github.com/wimg/PHPCompatibility/pull/217#discussion_r78299062","pull_request_url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/comments/78299062"},"html":{"href":"https://github.com/wimg/PHPCompatibility/pull/217#discussion_r78299062"},"pull_request":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217","id":84406408,"html_url":"https://github.com/wimg/PHPCompatibility/pull/217","diff_url":"https://github.com/wimg/PHPCompatibility/pull/217.diff","patch_url":"https://github.com/wimg/PHPCompatibility/pull/217.patch","issue_url":"https://api.github.com/repos/wimg/PHPCompatibility/issues/217","number":217,"state":"closed","locked":false,"title":"Add section about testing other sniff libs to readme.","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"body":"I was running into issues when locally testing other sniff libs which do use the PHPCS native testing framework.\r\nThe short of it was that this would result in a fatal error before any unit tests would be run as PHPCS was trying to load the PHPCompatibility unit test and sniff files and the setup is differently from what PHPCS expects.\r\n\r\nI've figured out a solution for this which resulted in PR https://github.com/squizlabs/PHP_CodeSniffer/pull/1146\r\n\r\nOnce that PR is merged, the loading of the PHPCompatibility unit tests can be bypassed allowing for the testing of other sniff libraries without running into problems.\r\n\r\nThis PR adds a section to the Readme explaining how to apply the bypass for other developers who work on both PHPCompatibility as well as other sniff libs.","created_at":"2016-09-08T02:48:13Z","updated_at":"2016-09-11T17:34:15Z","closed_at":"2016-09-08T21:42:13Z","merged_at":"2016-09-08T21:42:12Z","merge_commit_sha":"695a68e82039b7034c12b13488bf15255d118944","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217/commits","review_comments_url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217/comments","review_comment_url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wimg/PHPCompatibility/issues/217/comments","statuses_url":"https://api.github.com/repos/wimg/PHPCompatibility/statuses/2bc1fabcb5fb3e293482828bf1daac53239a29f6","head":{"label":"jrfnl:feature/testing-other-sniff-libs","ref":"feature/testing-other-sniff-libs","sha":"2bc1fabcb5fb3e293482828bf1daac53239a29f6","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"repo":{"id":14834119,"name":"PHPCompatibility","full_name":"jrfnl/PHPCompatibility","owner":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrfnl/PHPCompatibility","description":"PHP Compatibility check for PHP_CodeSniffer","fork":true,"url":"https://api.github.com/repos/jrfnl/PHPCompatibility","forks_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/forks","keys_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/teams","hooks_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/hooks","issue_events_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/issues/events{/number}","events_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/events","assignees_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/assignees{/user}","branches_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/branches{/branch}","tags_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/tags","blobs_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/statuses/{sha}","languages_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/languages","stargazers_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/stargazers","contributors_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/contributors","subscribers_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/subscribers","subscription_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/subscription","commits_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/contents/{+path}","compare_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/merges","archive_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/downloads","issues_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/issues{/number}","pulls_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/pulls{/number}","milestones_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/milestones{/number}","notifications_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/labels{/name}","releases_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/releases{/id}","deployments_url":"https://api.github.com/repos/jrfnl/PHPCompatibility/deployments","created_at":"2013-12-01T05:31:57Z","updated_at":"2016-07-17T22:44:33Z","pushed_at":"2016-09-08T21:41:25Z","git_url":"git://github.com/jrfnl/PHPCompatibility.git","ssh_url":"git@github.com:jrfnl/PHPCompatibility.git","clone_url":"https://github.com/jrfnl/PHPCompatibility.git","svn_url":"https://github.com/jrfnl/PHPCompatibility","homepage":"http://techblog.wimgodden.be/tag/codesniffer/","size":644,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wimg:master","ref":"master","sha":"5bad310559b80e7ddf1ab1fa3d2aa0ff6265f4e7","user":{"login":"wimg","id":313511,"avatar_url":"https://avatars.githubusercontent.com/u/313511?v=3","gravatar_id":"","url":"https://api.github.com/users/wimg","html_url":"https://github.com/wimg","followers_url":"https://api.github.com/users/wimg/followers","following_url":"https://api.github.com/users/wimg/following{/other_user}","gists_url":"https://api.github.com/users/wimg/gists{/gist_id}","starred_url":"https://api.github.com/users/wimg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimg/subscriptions","organizations_url":"https://api.github.com/users/wimg/orgs","repos_url":"https://api.github.com/users/wimg/repos","events_url":"https://api.github.com/users/wimg/events{/privacy}","received_events_url":"https://api.github.com/users/wimg/received_events","type":"User","site_admin":false},"repo":{"id":3614664,"name":"PHPCompatibility","full_name":"wimg/PHPCompatibility","owner":{"login":"wimg","id":313511,"avatar_url":"https://avatars.githubusercontent.com/u/313511?v=3","gravatar_id":"","url":"https://api.github.com/users/wimg","html_url":"https://github.com/wimg","followers_url":"https://api.github.com/users/wimg/followers","following_url":"https://api.github.com/users/wimg/following{/other_user}","gists_url":"https://api.github.com/users/wimg/gists{/gist_id}","starred_url":"https://api.github.com/users/wimg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimg/subscriptions","organizations_url":"https://api.github.com/users/wimg/orgs","repos_url":"https://api.github.com/users/wimg/repos","events_url":"https://api.github.com/users/wimg/events{/privacy}","received_events_url":"https://api.github.com/users/wimg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wimg/PHPCompatibility","description":"PHP Compatibility check for PHP_CodeSniffer","fork":false,"url":"https://api.github.com/repos/wimg/PHPCompatibility","forks_url":"https://api.github.com/repos/wimg/PHPCompatibility/forks","keys_url":"https://api.github.com/repos/wimg/PHPCompatibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wimg/PHPCompatibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wimg/PHPCompatibility/teams","hooks_url":"https://api.github.com/repos/wimg/PHPCompatibility/hooks","issue_events_url":"https://api.github.com/repos/wimg/PHPCompatibility/issues/events{/number}","events_url":"https://api.github.com/repos/wimg/PHPCompatibility/events","assignees_url":"https://api.github.com/repos/wimg/PHPCompatibility/assignees{/user}","branches_url":"https://api.github.com/repos/wimg/PHPCompatibility/branches{/branch}","tags_url":"https://api.github.com/repos/wimg/PHPCompatibility/tags","blobs_url":"https://api.github.com/repos/wimg/PHPCompatibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wimg/PHPCompatibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wimg/PHPCompatibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/wimg/PHPCompatibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wimg/PHPCompatibility/statuses/{sha}","languages_url":"https://api.github.com/repos/wimg/PHPCompatibility/languages","stargazers_url":"https://api.github.com/repos/wimg/PHPCompatibility/stargazers","contributors_url":"https://api.github.com/repos/wimg/PHPCompatibility/contributors","subscribers_url":"https://api.github.com/repos/wimg/PHPCompatibility/subscribers","subscription_url":"https://api.github.com/repos/wimg/PHPCompatibility/subscription","commits_url":"https://api.github.com/repos/wimg/PHPCompatibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/wimg/PHPCompatibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/wimg/PHPCompatibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/wimg/PHPCompatibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/wimg/PHPCompatibility/contents/{+path}","compare_url":"https://api.github.com/repos/wimg/PHPCompatibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wimg/PHPCompatibility/merges","archive_url":"https://api.github.com/repos/wimg/PHPCompatibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wimg/PHPCompatibility/downloads","issues_url":"https://api.github.com/repos/wimg/PHPCompatibility/issues{/number}","pulls_url":"https://api.github.com/repos/wimg/PHPCompatibility/pulls{/number}","milestones_url":"https://api.github.com/repos/wimg/PHPCompatibility/milestones{/number}","notifications_url":"https://api.github.com/repos/wimg/PHPCompatibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wimg/PHPCompatibility/labels{/name}","releases_url":"https://api.github.com/repos/wimg/PHPCompatibility/releases{/id}","deployments_url":"https://api.github.com/repos/wimg/PHPCompatibility/deployments","created_at":"2012-03-03T23:36:15Z","updated_at":"2016-09-08T13:46:39Z","pushed_at":"2016-09-08T21:44:13Z","git_url":"git://github.com/wimg/PHPCompatibility.git","ssh_url":"git@github.com:wimg/PHPCompatibility.git","clone_url":"https://github.com/wimg/PHPCompatibility.git","svn_url":"https://github.com/wimg/PHPCompatibility","homepage":"http://techblog.wimgodden.be/tag/codesniffer/","size":793,"stargazers_count":463,"watchers_count":463,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":19,"forks":97,"open_issues":19,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217"},"html":{"href":"https://github.com/wimg/PHPCompatibility/pull/217"},"issue":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/issues/217"},"comments":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/wimg/PHPCompatibility/statuses/2bc1fabcb5fb3e293482828bf1daac53239a29f6"}}}}
{"actor":{"display_login":"jrfnl"}}