{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/61868980","id":61868980,"diff_hunk":"@@ -101,6 +101,76 @@\n             </item>\n            </layout>\n           </item>\n+          <item>\n+            <layout class=\"QHBoxLayout\" name=\"horizontalLayout_7\">\n+              <item>\n+                <widget class=\"QLabel\" name=\"label_2\">\n+                  <property name=\"text\">\n+                    <string>Language:</string>\n+                  </property>\n+                </widget>\n+              </item>\n+              <item>\n+                <widget class=\"QComboBox\" name=\"language_combobox\">\n+                  <item>\n+                    <property name=\"text\">\n+                      <string notr=\"true\">JPN (日本語)</string>\n+                    </property>\n+                  </item>\n+                  <item>\n+                    <property name=\"text\">\n+                      <string notr=\"true\">ENG (English)</string>\n+                    </property>\n+                  </item>\n+                  <item>\n+                    <property name=\"text\">\n+                      <string notr=\"true\">FRA (français)</string>","path":"src/citra_qt/configure_general.ui","position":27,"original_position":27,"commit_id":"9a9bcd56614daa08bac1f9108f6ad4b1c416a298","original_commit_id":"9a9bcd56614daa08bac1f9108f6ad4b1c416a298","user":{"login":"uberhalit","id":19159295,"avatar_url":"https://avatars.githubusercontent.com/u/19159295?v=3","gravatar_id":"","url":"https://api.github.com/users/uberhalit","html_url":"https://github.com/uberhalit","followers_url":"https://api.github.com/users/uberhalit/followers","following_url":"https://api.github.com/users/uberhalit/following{/other_user}","gists_url":"https://api.github.com/users/uberhalit/gists{/gist_id}","starred_url":"https://api.github.com/users/uberhalit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberhalit/subscriptions","organizations_url":"https://api.github.com/users/uberhalit/orgs","repos_url":"https://api.github.com/users/uberhalit/repos","events_url":"https://api.github.com/users/uberhalit/events{/privacy}","received_events_url":"https://api.github.com/users/uberhalit/received_events","type":"User","site_admin":false},"body":"The Library of Congress listed these with lowercase:\r\nhttps://www.loc.gov/standards/iso639-2/php/French_list.php","created_at":"2016-05-03T11:48:50Z","updated_at":"2016-05-03T11:48:50Z","html_url":"https://github.com/citra-emu/citra/pull/1755#discussion_r61868980","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/1755","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/61868980"},"html":{"href":"https://github.com/citra-emu/citra/pull/1755#discussion_r61868980"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1755"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1755","id":68690626,"html_url":"https://github.com/citra-emu/citra/pull/1755","diff_url":"https://github.com/citra-emu/citra/pull/1755.diff","patch_url":"https://github.com/citra-emu/citra/pull/1755.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1755","number":1755,"state":"open","locked":false,"title":"Implementation of a language selector to configuration widget","user":{"login":"uberhalit","id":19159295,"avatar_url":"https://avatars.githubusercontent.com/u/19159295?v=3","gravatar_id":"","url":"https://api.github.com/users/uberhalit","html_url":"https://github.com/uberhalit","followers_url":"https://api.github.com/users/uberhalit/followers","following_url":"https://api.github.com/users/uberhalit/following{/other_user}","gists_url":"https://api.github.com/users/uberhalit/gists{/gist_id}","starred_url":"https://api.github.com/users/uberhalit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberhalit/subscriptions","organizations_url":"https://api.github.com/users/uberhalit/orgs","repos_url":"https://api.github.com/users/uberhalit/repos","events_url":"https://api.github.com/users/uberhalit/events{/privacy}","received_events_url":"https://api.github.com/users/uberhalit/received_events","type":"User","site_admin":false},"body":"Added a language selector to configuration widget.\r\nCurrent master requires a hex-edit in `\\user\\nand\\data\\00000000000000000000000000000000\\sysdata\\00010017\\00000000\\config` to change in-game language for multi-language games as english is hardcoded as default.\r\n\r\nI used [ISO 639-2/T](https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes) for 3-letter codes and native language names.\r\n\r\nDue to the current implementation of `src/core/hle/service/cfg/cfg.cpp - Init()` setting language will be enforced only if there is no config file present as writing will be skipped completely if the file is found. I noted this with TODO.\r\n\r\n![language selector](http://i.imgur.com/dHS1ZSw.png)","created_at":"2016-05-03T11:16:32Z","updated_at":"2016-05-03T11:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51af7776a4303ac822b74e8f80347434d2be9885","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/1755/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/1755/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1755/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/9a9bcd56614daa08bac1f9108f6ad4b1c416a298","head":{"label":"uberhalit:language-selector","ref":"language-selector","sha":"9a9bcd56614daa08bac1f9108f6ad4b1c416a298","user":{"login":"uberhalit","id":19159295,"avatar_url":"https://avatars.githubusercontent.com/u/19159295?v=3","gravatar_id":"","url":"https://api.github.com/users/uberhalit","html_url":"https://github.com/uberhalit","followers_url":"https://api.github.com/users/uberhalit/followers","following_url":"https://api.github.com/users/uberhalit/following{/other_user}","gists_url":"https://api.github.com/users/uberhalit/gists{/gist_id}","starred_url":"https://api.github.com/users/uberhalit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberhalit/subscriptions","organizations_url":"https://api.github.com/users/uberhalit/orgs","repos_url":"https://api.github.com/users/uberhalit/repos","events_url":"https://api.github.com/users/uberhalit/events{/privacy}","received_events_url":"https://api.github.com/users/uberhalit/received_events","type":"User","site_admin":false},"repo":{"id":57932251,"name":"citra","full_name":"uberhalit/citra","owner":{"login":"uberhalit","id":19159295,"avatar_url":"https://avatars.githubusercontent.com/u/19159295?v=3","gravatar_id":"","url":"https://api.github.com/users/uberhalit","html_url":"https://github.com/uberhalit","followers_url":"https://api.github.com/users/uberhalit/followers","following_url":"https://api.github.com/users/uberhalit/following{/other_user}","gists_url":"https://api.github.com/users/uberhalit/gists{/gist_id}","starred_url":"https://api.github.com/users/uberhalit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberhalit/subscriptions","organizations_url":"https://api.github.com/users/uberhalit/orgs","repos_url":"https://api.github.com/users/uberhalit/repos","events_url":"https://api.github.com/users/uberhalit/events{/privacy}","received_events_url":"https://api.github.com/users/uberhalit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uberhalit/citra","description":"Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/uberhalit/citra","forks_url":"https://api.github.com/repos/uberhalit/citra/forks","keys_url":"https://api.github.com/repos/uberhalit/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberhalit/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberhalit/citra/teams","hooks_url":"https://api.github.com/repos/uberhalit/citra/hooks","issue_events_url":"https://api.github.com/repos/uberhalit/citra/issues/events{/number}","events_url":"https://api.github.com/repos/uberhalit/citra/events","assignees_url":"https://api.github.com/repos/uberhalit/citra/assignees{/user}","branches_url":"https://api.github.com/repos/uberhalit/citra/branches{/branch}","tags_url":"https://api.github.com/repos/uberhalit/citra/tags","blobs_url":"https://api.github.com/repos/uberhalit/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberhalit/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberhalit/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberhalit/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberhalit/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/uberhalit/citra/languages","stargazers_url":"https://api.github.com/repos/uberhalit/citra/stargazers","contributors_url":"https://api.github.com/repos/uberhalit/citra/contributors","subscribers_url":"https://api.github.com/repos/uberhalit/citra/subscribers","subscription_url":"https://api.github.com/repos/uberhalit/citra/subscription","commits_url":"https://api.github.com/repos/uberhalit/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberhalit/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberhalit/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberhalit/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberhalit/citra/contents/{+path}","compare_url":"https://api.github.com/repos/uberhalit/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberhalit/citra/merges","archive_url":"https://api.github.com/repos/uberhalit/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberhalit/citra/downloads","issues_url":"https://api.github.com/repos/uberhalit/citra/issues{/number}","pulls_url":"https://api.github.com/repos/uberhalit/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/uberhalit/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/uberhalit/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberhalit/citra/labels{/name}","releases_url":"https://api.github.com/repos/uberhalit/citra/releases{/id}","deployments_url":"https://api.github.com/repos/uberhalit/citra/deployments","created_at":"2016-05-03T01:25:15Z","updated_at":"2016-05-03T01:25:17Z","pushed_at":"2016-05-03T10:57:40Z","git_url":"git://github.com/uberhalit/citra.git","ssh_url":"git@github.com:uberhalit/citra.git","clone_url":"https://github.com/uberhalit/citra.git","svn_url":"https://github.com/uberhalit/citra","homepage":"https://citra-emu.org","size":12409,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"6d02fe39f50436e0d1751b81e097b412645e4418","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-05-03T11:43:15Z","pushed_at":"2016-05-03T11:44:08Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":20038,"stargazers_count":1802,"watchers_count":1802,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"open_issues_count":201,"forks":423,"open_issues":201,"watchers":1802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1755"},"html":{"href":"https://github.com/citra-emu/citra/pull/1755"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1755"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1755/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1755/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1755/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/9a9bcd56614daa08bac1f9108f6ad4b1c416a298"}}}}