{"action":"created","issue":{"url":"https://api.github.com/repos/sagemath/docker-images/issues/16","repository_url":"https://api.github.com/repos/sagemath/docker-images","labels_url":"https://api.github.com/repos/sagemath/docker-images/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/sagemath/docker-images/issues/16/comments","events_url":"https://api.github.com/repos/sagemath/docker-images/issues/16/events","html_url":"https://github.com/sagemath/docker-images/pull/16","id":136007247,"number":16,"title":"First reorganization","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-24T09:41:29Z","updated_at":"2016-02-24T15:37:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sagemath/docker-images/pulls/16","html_url":"https://github.com/sagemath/docker-images/pull/16","diff_url":"https://github.com/sagemath/docker-images/pull/16.diff","patch_url":"https://github.com/sagemath/docker-images/pull/16.patch"},"body":"This is a first set of changes to reorganize the sage images, including the makefile, their dockerfiles, and the sage installation script that runs in the containers.  This doesn't do everything I want yet, but it partially addresses:\r\n\r\n* #3 -- many unnecessary files have been removed, reducing the sizes of the `sagemath` and `sagemath-develop` images from ~7 GB to ~4 GB.  More could probably be done but that's a good start.\r\n* #6 -- all files used by sage are installed with full permissions granted to the `sage` user.  By default sage is installed to `/opt/sage/` (the `sage` user does not have permissions on `/opt/` but they can read/write to `/opt/sage/`.  Their `DOT_SAGE` is still in the `sage` user's home directory).  However, it is also possible to change the installation location for sage.  Regardless the `sage` user has full permissions on the install location.\r\n* Other minor improvements that should make future work easier.\r\n\r\nStill to do (in a separate PR):\r\n* The Dockerfiles for sagemath and sagemath-develop are identical except for the default value of the `SAGE_BRANCH` argument.  I intend to eliminate the separate `sagemath-develop` Dockerfile, and instead add additional make targets for \"develop\" versions of all relevant images (currently just \"sagemath\" and \"sagemath-jupyter\"--sagemath-patchbot is of course a separate case).  Building the \"-develop\" versions is mostly just a matter of running the build target with an additional option to change the `SAGE_BRANCH` variable.  This would finally eliminate any duplication."},"comment":{"url":"https://api.github.com/repos/sagemath/docker-images/issues/comments/188308456","html_url":"https://github.com/sagemath/docker-images/pull/16#issuecomment-188308456","issue_url":"https://api.github.com/repos/sagemath/docker-images/issues/16","id":188308456,"user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T15:37:08Z","updated_at":"2016-02-24T15:37:08Z","body":"> The Dockerfiles for sagemath and sagemath-develop are identical except for the default value of the SAGE_BRANCH argument. I intend to eliminate the separate sagemath-develop Dockerfile, and instead add additional make targets for \"develop\" versions of all relevant images (currently just \"sagemath\" and \"sagemath-jupyter\"--sagemath-patchbot is of course a separate case). Building the \"-develop\" versions is mostly just a matter of running the build target with an additional option to change the SAGE_BRANCH variable. This would finally eliminate any duplication.\r\n\r\nAlthough, that plan has a bit of a bug in it, which is that images like sagemath-jupyter wouldn't respond to a change in the SAGE_BRANCH argument, since it is built from the existing sagemath image.  A hypthetical sagemath-jupyter-devel image would have to be build from a different base image.  As I already found, the base image in a Dockerfile can't be changed via a build argument.  So this would have to be handled differently.\r\n\r\nFor now I'll just make a special case for sagemath and sagemath-devel and worry about adding additional \"-devel\" images, if we want them, later."}}