{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/luigi/pulls/comments/71152804","id":71152804,"diff_hunk":"@@ -270,15 +277,15 @@ def _get_comments(group_tasks):\n     (\"already_done\", 'present dependencies were encountered'),\n     (\"completed\", 'ran successfully'),\n     (\"failed\", 'failed'),\n-    (\"scheduling_error\", 'failed running complete() or requires()'),\n+    (\"scheduling_error\", 'failed scheduling'),\n     (\"still_pending\", 'were left pending, among these'),\n     (\"still_pending_ext\", 'were missing external dependencies'),\n     (\"run_by_other_worker\", 'were being run by another worker'),\n     (\"upstream_failure\", 'had failed dependencies'),\n     (\"upstream_missing_dependency\", 'had missing external dependencies'),\n     (\"upstream_run_by_other_worker\", 'had dependencies that were being run by other worker'),\n-    (\"upstream_scheduling_error\", 'had dependencies whose complete() or requires() failed'),\n-    (\"unknown_reason\", 'were left pending because of unknown reason'),\n+    (\"upstream_scheduling_error\", 'had dependencies whose scheduling failed'),\n+    (\"unknown_reason\", 'did not run successfully because of unknown reason'),","path":"luigi/execution_summary.py","position":29,"original_position":29,"commit_id":"dde2a24097cd1ebbb160d0c08c4142547d9354c5","original_commit_id":"dde2a24097cd1ebbb160d0c08c4142547d9354c5","user":{"login":"ulzha","id":84229,"avatar_url":"https://avatars.githubusercontent.com/u/84229?v=3","gravatar_id":"","url":"https://api.github.com/users/ulzha","html_url":"https://github.com/ulzha","followers_url":"https://api.github.com/users/ulzha/followers","following_url":"https://api.github.com/users/ulzha/following{/other_user}","gists_url":"https://api.github.com/users/ulzha/gists{/gist_id}","starred_url":"https://api.github.com/users/ulzha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulzha/subscriptions","organizations_url":"https://api.github.com/users/ulzha/orgs","repos_url":"https://api.github.com/users/ulzha/repos","events_url":"https://api.github.com/users/ulzha/events{/privacy}","received_events_url":"https://api.github.com/users/ulzha/received_events","type":"User","site_admin":false},"body":"When the task fails `run()` we do get the reason back, as the exception, right? Was there a reason to alter wording \"were left pending\"?","created_at":"2016-07-18T14:07:24Z","updated_at":"2016-07-18T14:07:24Z","html_url":"https://github.com/spotify/luigi/pull/1771#discussion_r71152804","pull_request_url":"https://api.github.com/repos/spotify/luigi/pulls/1771","_links":{"self":{"href":"https://api.github.com/repos/spotify/luigi/pulls/comments/71152804"},"html":{"href":"https://github.com/spotify/luigi/pull/1771#discussion_r71152804"},"pull_request":{"href":"https://api.github.com/repos/spotify/luigi/pulls/1771"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/1771","id":77777583,"html_url":"https://github.com/spotify/luigi/pull/1771","diff_url":"https://github.com/spotify/luigi/pull/1771.diff","patch_url":"https://github.com/spotify/luigi/pull/1771.patch","issue_url":"https://api.github.com/repos/spotify/luigi/issues/1771","number":1771,"state":"open","locked":false,"title":"Update retcodes to handle new cases","user":{"login":"fabriziodemaria","id":7601824,"avatar_url":"https://avatars.githubusercontent.com/u/7601824?v=3","gravatar_id":"","url":"https://api.github.com/users/fabriziodemaria","html_url":"https://github.com/fabriziodemaria","followers_url":"https://api.github.com/users/fabriziodemaria/followers","following_url":"https://api.github.com/users/fabriziodemaria/following{/other_user}","gists_url":"https://api.github.com/users/fabriziodemaria/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziodemaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziodemaria/subscriptions","organizations_url":"https://api.github.com/users/fabriziodemaria/orgs","repos_url":"https://api.github.com/users/fabriziodemaria/repos","events_url":"https://api.github.com/users/fabriziodemaria/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziodemaria/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis pull request is a continuation of #1612. The purpose of this pull request is to cover more cases for which tasks does not run successfully and Luigi exit code is 0.\r\nMore specifically, the following two cases are covered:\r\n- Tasks are not run because task-limit is reached counts as _scheduling_error_ \r\n- Return code can be set for cases in which tasks fail or are left pending for _unknown_reason_ \r\n\r\n## Motivation and Context\r\nThis relates to #1660.\r\n\r\n## Have you tested this? If so, how?\r\nI have included unit tests.","created_at":"2016-07-18T09:08:50Z","updated_at":"2016-07-18T14:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaa665e1809a01153aa8b1e0725089b695cfbdbb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/luigi/pulls/1771/commits","review_comments_url":"https://api.github.com/repos/spotify/luigi/pulls/1771/comments","review_comment_url":"https://api.github.com/repos/spotify/luigi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/1771/comments","statuses_url":"https://api.github.com/repos/spotify/luigi/statuses/dde2a24097cd1ebbb160d0c08c4142547d9354c5","head":{"label":"spotify:continue-exit-code","ref":"continue-exit-code","sha":"dde2a24097cd1ebbb160d0c08c4142547d9354c5","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":5888353,"name":"luigi","full_name":"spotify/luigi","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/luigi","description":"Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in. ","fork":false,"url":"https://api.github.com/repos/spotify/luigi","forks_url":"https://api.github.com/repos/spotify/luigi/forks","keys_url":"https://api.github.com/repos/spotify/luigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/luigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/luigi/teams","hooks_url":"https://api.github.com/repos/spotify/luigi/hooks","issue_events_url":"https://api.github.com/repos/spotify/luigi/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/luigi/events","assignees_url":"https://api.github.com/repos/spotify/luigi/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/luigi/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/luigi/tags","blobs_url":"https://api.github.com/repos/spotify/luigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/luigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/luigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/luigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/luigi/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/luigi/languages","stargazers_url":"https://api.github.com/repos/spotify/luigi/stargazers","contributors_url":"https://api.github.com/repos/spotify/luigi/contributors","subscribers_url":"https://api.github.com/repos/spotify/luigi/subscribers","subscription_url":"https://api.github.com/repos/spotify/luigi/subscription","commits_url":"https://api.github.com/repos/spotify/luigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/luigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/luigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/luigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/luigi/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/luigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/luigi/merges","archive_url":"https://api.github.com/repos/spotify/luigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/luigi/downloads","issues_url":"https://api.github.com/repos/spotify/luigi/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/luigi/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/luigi/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/luigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/luigi/labels{/name}","releases_url":"https://api.github.com/repos/spotify/luigi/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/luigi/deployments","created_at":"2012-09-20T15:06:38Z","updated_at":"2016-07-18T14:03:54Z","pushed_at":"2016-07-18T13:21:57Z","git_url":"git://github.com/spotify/luigi.git","ssh_url":"git@github.com:spotify/luigi.git","clone_url":"https://github.com/spotify/luigi.git","svn_url":"https://github.com/spotify/luigi","homepage":null,"size":10599,"stargazers_count":4930,"watchers_count":4930,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":961,"mirror_url":null,"open_issues_count":186,"forks":961,"open_issues":186,"watchers":4930,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"decf400b1f515cbff6d2e421becbb15d1aedbb8f","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":5888353,"name":"luigi","full_name":"spotify/luigi","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/luigi","description":"Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in. ","fork":false,"url":"https://api.github.com/repos/spotify/luigi","forks_url":"https://api.github.com/repos/spotify/luigi/forks","keys_url":"https://api.github.com/repos/spotify/luigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/luigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/luigi/teams","hooks_url":"https://api.github.com/repos/spotify/luigi/hooks","issue_events_url":"https://api.github.com/repos/spotify/luigi/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/luigi/events","assignees_url":"https://api.github.com/repos/spotify/luigi/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/luigi/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/luigi/tags","blobs_url":"https://api.github.com/repos/spotify/luigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/luigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/luigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/luigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/luigi/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/luigi/languages","stargazers_url":"https://api.github.com/repos/spotify/luigi/stargazers","contributors_url":"https://api.github.com/repos/spotify/luigi/contributors","subscribers_url":"https://api.github.com/repos/spotify/luigi/subscribers","subscription_url":"https://api.github.com/repos/spotify/luigi/subscription","commits_url":"https://api.github.com/repos/spotify/luigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/luigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/luigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/luigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/luigi/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/luigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/luigi/merges","archive_url":"https://api.github.com/repos/spotify/luigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/luigi/downloads","issues_url":"https://api.github.com/repos/spotify/luigi/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/luigi/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/luigi/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/luigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/luigi/labels{/name}","releases_url":"https://api.github.com/repos/spotify/luigi/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/luigi/deployments","created_at":"2012-09-20T15:06:38Z","updated_at":"2016-07-18T14:03:54Z","pushed_at":"2016-07-18T13:21:57Z","git_url":"git://github.com/spotify/luigi.git","ssh_url":"git@github.com:spotify/luigi.git","clone_url":"https://github.com/spotify/luigi.git","svn_url":"https://github.com/spotify/luigi","homepage":null,"size":10599,"stargazers_count":4930,"watchers_count":4930,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":961,"mirror_url":null,"open_issues_count":186,"forks":961,"open_issues":186,"watchers":4930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/luigi/pulls/1771"},"html":{"href":"https://github.com/spotify/luigi/pull/1771"},"issue":{"href":"https://api.github.com/repos/spotify/luigi/issues/1771"},"comments":{"href":"https://api.github.com/repos/spotify/luigi/issues/1771/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/luigi/pulls/1771/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/luigi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/luigi/pulls/1771/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/luigi/statuses/dde2a24097cd1ebbb160d0c08c4142547d9354c5"}}}}
{"actor":{"display_login":"ulzha"}}