{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/72766339","id":72766339,"diff_hunk":"@@ -111,18 +112,18 @@ tox --version\n case $TESTENV in\n     py34-cov)\n         pip_install codecov\n-        apt_install xvfb $pyqt_pkgs libpython3.4-dev\n+        apt_install xvfb \"$pyqt_pkgs\" libpython3.4-dev\n         check_pyqt\n         ;;\n     pylint|vulture)\n-        apt_install $pyqt_pkgs libpython3.4-dev\n+        apt_install \"$pyqt_pkgs\" libpython3.4-dev\n         check_pyqt\n         ;;\n     flake8)\n         apt_install libpython3.4-dev\n         ;;\n     docs)\n-        apt_install $pyqt_pkgs asciidoc libpython3.4-dev\n+        apt_install \"$pyqt_pkgs\" asciidoc libpython3.4-dev","path":"scripts/dev/ci/travis_install.sh","position":53,"original_position":53,"commit_id":"8141a18aacbdeb8e4ef950c6d724f8842ed83879","original_commit_id":"8141a18aacbdeb8e4ef950c6d724f8842ed83879","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"body":"It doesn't matter if it's unquoted - not because of that, but because there are no spaces in the package name. `apt_install` quoting things doesn't help if they arrive split in the first place :wink:\r\n\r\nHowever, as-is this is wrong and [fails](https://travis-ci.org/The-Compiler/qutebrowser/jobs/148124899#L242-L243) because it tries to install the whole thing as a single package.","created_at":"2016-07-29T09:36:24Z","updated_at":"2016-07-29T09:36:24Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1697#discussion_r72766339","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/72766339"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1697#discussion_r72766339"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697","id":79243735,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/1697","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/1697.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/1697.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1697","number":1697,"state":"open","locked":false,"title":"[WIP] shell check fixes","user":{"login":"neeasade","id":3747396,"avatar_url":"https://avatars.githubusercontent.com/u/3747396?v=3","gravatar_id":"","url":"https://api.github.com/users/neeasade","html_url":"https://github.com/neeasade","followers_url":"https://api.github.com/users/neeasade/followers","following_url":"https://api.github.com/users/neeasade/following{/other_user}","gists_url":"https://api.github.com/users/neeasade/gists{/gist_id}","starred_url":"https://api.github.com/users/neeasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neeasade/subscriptions","organizations_url":"https://api.github.com/users/neeasade/orgs","repos_url":"https://api.github.com/users/neeasade/repos","events_url":"https://api.github.com/users/neeasade/events{/privacy}","received_events_url":"https://api.github.com/users/neeasade/received_events","type":"User","site_admin":false},"body":"ref: #1685 \r\n\r\nThis encompasses shellcheck fixes listed in that issue, except for ones in the `password_fill` script. Going to add that to this PR soon™. ","created_at":"2016-07-28T18:20:57Z","updated_at":"2016-07-29T09:36:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"624a7dc9bd9400bfd8250708d1d9bb4ff3193091","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1697/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/8141a18aacbdeb8e4ef950c6d724f8842ed83879","head":{"label":"neeasade:master","ref":"master","sha":"8141a18aacbdeb8e4ef950c6d724f8842ed83879","user":{"login":"neeasade","id":3747396,"avatar_url":"https://avatars.githubusercontent.com/u/3747396?v=3","gravatar_id":"","url":"https://api.github.com/users/neeasade","html_url":"https://github.com/neeasade","followers_url":"https://api.github.com/users/neeasade/followers","following_url":"https://api.github.com/users/neeasade/following{/other_user}","gists_url":"https://api.github.com/users/neeasade/gists{/gist_id}","starred_url":"https://api.github.com/users/neeasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neeasade/subscriptions","organizations_url":"https://api.github.com/users/neeasade/orgs","repos_url":"https://api.github.com/users/neeasade/repos","events_url":"https://api.github.com/users/neeasade/events{/privacy}","received_events_url":"https://api.github.com/users/neeasade/received_events","type":"User","site_admin":false},"repo":{"id":43384122,"name":"qutebrowser","full_name":"neeasade/qutebrowser","owner":{"login":"neeasade","id":3747396,"avatar_url":"https://avatars.githubusercontent.com/u/3747396?v=3","gravatar_id":"","url":"https://api.github.com/users/neeasade","html_url":"https://github.com/neeasade","followers_url":"https://api.github.com/users/neeasade/followers","following_url":"https://api.github.com/users/neeasade/following{/other_user}","gists_url":"https://api.github.com/users/neeasade/gists{/gist_id}","starred_url":"https://api.github.com/users/neeasade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neeasade/subscriptions","organizations_url":"https://api.github.com/users/neeasade/orgs","repos_url":"https://api.github.com/users/neeasade/repos","events_url":"https://api.github.com/users/neeasade/events{/privacy}","received_events_url":"https://api.github.com/users/neeasade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neeasade/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.","fork":true,"url":"https://api.github.com/repos/neeasade/qutebrowser","forks_url":"https://api.github.com/repos/neeasade/qutebrowser/forks","keys_url":"https://api.github.com/repos/neeasade/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neeasade/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neeasade/qutebrowser/teams","hooks_url":"https://api.github.com/repos/neeasade/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/neeasade/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/neeasade/qutebrowser/events","assignees_url":"https://api.github.com/repos/neeasade/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/neeasade/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/neeasade/qutebrowser/tags","blobs_url":"https://api.github.com/repos/neeasade/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neeasade/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neeasade/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/neeasade/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neeasade/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/neeasade/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/neeasade/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/neeasade/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/neeasade/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/neeasade/qutebrowser/subscription","commits_url":"https://api.github.com/repos/neeasade/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/neeasade/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/neeasade/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/neeasade/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/neeasade/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/neeasade/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neeasade/qutebrowser/merges","archive_url":"https://api.github.com/repos/neeasade/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neeasade/qutebrowser/downloads","issues_url":"https://api.github.com/repos/neeasade/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/neeasade/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/neeasade/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/neeasade/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neeasade/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/neeasade/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/neeasade/qutebrowser/deployments","created_at":"2015-09-29T17:48:15Z","updated_at":"2016-07-28T18:15:45Z","pushed_at":"2016-07-28T19:17:58Z","git_url":"git://github.com/neeasade/qutebrowser.git","ssh_url":"git@github.com:neeasade/qutebrowser.git","clone_url":"https://github.com/neeasade/qutebrowser.git","svn_url":"https://github.com/neeasade/qutebrowser","homepage":null,"size":18043,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"b48b7eddc84d75d9ab273279017666a67e4c0ded","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2016-07-28T21:08:24Z","pushed_at":"2016-07-29T08:43:59Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":"https://www.qutebrowser.org/","size":22110,"stargazers_count":1362,"watchers_count":1362,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":412,"forks":205,"open_issues":412,"watchers":1362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/1697"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1697"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1697/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1697/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/8141a18aacbdeb8e4ef950c6d724f8842ed83879"}}}}
{"actor":{"display_login":"The-Compiler"}}