{"action":"created","issue":{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5717","repository_url":"https://api.github.com/repos/rethinkdb/rethinkdb","labels_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5717/labels{/name}","comments_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5717/comments","events_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5717/events","html_url":"https://github.com/rethinkdb/rethinkdb/issues/5717","id":150944468,"number":5717,"title":"compile warning from ql2.pb.h","user":{"login":"larkost","id":7431361,"avatar_url":"https://avatars.githubusercontent.com/u/7431361?v=3","gravatar_id":"","url":"https://api.github.com/users/larkost","html_url":"https://github.com/larkost","followers_url":"https://api.github.com/users/larkost/followers","following_url":"https://api.github.com/users/larkost/following{/other_user}","gists_url":"https://api.github.com/users/larkost/gists{/gist_id}","starred_url":"https://api.github.com/users/larkost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larkost/subscriptions","organizations_url":"https://api.github.com/users/larkost/orgs","repos_url":"https://api.github.com/users/larkost/repos","events_url":"https://api.github.com/users/larkost/events{/privacy}","received_events_url":"https://api.github.com/users/larkost/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-25T18:25:02Z","updated_at":"2016-04-27T00:31:54Z","closed_at":null,"body":"On `newton` I am seeing a compile warning (which we treat as an error) in `ql2.pb.h`:\r\n```\r\nIn file included from build/proto/rdb_protocol/ql2.pb.cc:5:0:\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Query_AssocPair::set_allocated_key(std::string*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2022:66: error: declaration of ‘key’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Query_AssocPair::set_allocated_key(::std::string* key) {\r\n                                                                  ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Query_AssocPair::set_allocated_val(Term*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2063:59: error: declaration of ‘val’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Query_AssocPair::set_allocated_val(::Term* val) {\r\n                                                           ^\r\nIn file included from build/proto/rdb_protocol/ql2.pb.cc:5:0:\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Query::set_allocated_query(Term*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2128:53: error: declaration of ‘query’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Query::set_allocated_query(::Term* query) {\r\n                                                     ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Frame::set_allocated_opt(std::string*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2335:56: error: declaration of ‘opt’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Frame::set_allocated_opt(::std::string* opt) {\r\n                                                        ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Response::set_allocated_backtrace(Backtrace*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2529:69: error: declaration of ‘backtrace’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Response::set_allocated_backtrace(::Backtrace* backtrace) {\r\n                                                                     ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Response::set_allocated_profile(Datum*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2567:61: error: declaration of ‘profile’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Response::set_allocated_profile(::Datum* profile) {\r\n                                                             ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Datum_AssocPair::set_allocated_key(std::string*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2638:66: error: declaration of ‘key’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Datum_AssocPair::set_allocated_key(::std::string* key) {\r\n                                                                  ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Datum_AssocPair::set_allocated_val(Datum*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2679:60: error: declaration of ‘val’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Datum_AssocPair::set_allocated_val(::Datum* val) {\r\n                                                            ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Datum::set_allocated_r_str(std::string*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2817:60: error: declaration of ‘r_str’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Datum::set_allocated_r_str(::std::string* r_str) {\r\n                                                            ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Term_AssocPair::set_allocated_key(std::string*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2941:65: error: declaration of ‘key’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Term_AssocPair::set_allocated_key(::std::string* key) {\r\n                                                                 ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Term_AssocPair::set_allocated_val(Term*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:2982:58: error: declaration of ‘val’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Term_AssocPair::set_allocated_val(::Term* val) {\r\n                                                          ^\r\n./build/proto/rdb_protocol/ql2.pb.h: In member function ‘void Term::set_allocated_datum(Datum*)’:\r\n./build/proto/rdb_protocol/ql2.pb.h:3047:53: error: declaration of ‘datum’ shadows a member of 'this' [-Werror=shadow]\r\n inline void Term::set_allocated_datum(::Datum* datum) {\r\n                                                     ^\r\n```"},"comment":{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/comments/214929033","html_url":"https://github.com/rethinkdb/rethinkdb/issues/5717#issuecomment-214929033","issue_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5717","id":214929033,"user":{"login":"danielmewes","id":505365,"avatar_url":"https://avatars.githubusercontent.com/u/505365?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmewes","html_url":"https://github.com/danielmewes","followers_url":"https://api.github.com/users/danielmewes/followers","following_url":"https://api.github.com/users/danielmewes/following{/other_user}","gists_url":"https://api.github.com/users/danielmewes/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmewes/subscriptions","organizations_url":"https://api.github.com/users/danielmewes/orgs","repos_url":"https://api.github.com/users/danielmewes/repos","events_url":"https://api.github.com/users/danielmewes/events{/privacy}","received_events_url":"https://api.github.com/users/danielmewes/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T00:31:53Z","updated_at":"2016-04-27T00:31:53Z","body":"I think this was broken by https://github.com/rethinkdb/rethinkdb/commit/2993603fa743e0c68b2701b737321afedcb05fd3 which added `-Wshadow` to the GCC compiler options. I'm also running into this on our package builders."}}