{"action":"opened","number":1170,"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/1170","id":94324957,"html_url":"https://github.com/percona/percona-server/pull/1170","diff_url":"https://github.com/percona/percona-server/pull/1170.diff","patch_url":"https://github.com/percona/percona-server/pull/1170.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/1170","number":1170,"state":"open","locked":false,"title":"Fix bug 1641612 (New compilation warnings with GCC 6 (-Wshift-negativ…","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"body":"…e-value, -Wdeprecated-declarations, -Wnonnull-compare))\r\n\r\n\"Left shift of negative value warnings are caused by (~0 << x) code\r\nconstruct, where constant zero and its complement are of type signed\r\nint. Fix by replacing 0 with 0U.\r\n\r\n\"‘readdir_r’ is deprecated\" warnings are fixed by observing that glibc\r\nreaddir is thread-safe for non-shared directory streams, thus\r\nreplacing readdir_r with readdir is easy and simplifies code.\r\n\r\n\"warning: nonnull argument 'foo' compared to NULL\" is fixed by\r\nbackporting [1], which removes nonnull attribute as unsafe. It also\r\nremoves pure attribute due to a compiler bug. In this backport, where\r\napplicable, warn_unused_result attribute has been added.\r\n\r\nA special case of the above is comparison of this to NULL in a\r\npartition_info::get_clone member function. Fixed by backporting the\r\nrelevant bit of [2].\r\n\r\n[1]\r\n\r\ncommit 7b899ac00c5d6a18b5b8eda661885f6f1afc502a\r\nAuthor: Marko Makela <marko.makela@oracle.com>\r\nDate: Wed Oct 8 10:31:13 2014 +0300\r\n\r\n    Bug#19632776 Code gets incorrectly optimized away by gcc\r\n\r\n    As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764220\r\n    it is possible that gcc incorrectly optimizes away some code\r\n    when a function that takes a pointer or reference as a parameter\r\n    is declared as attribute((const)) or attribute((pure)).\r\n\r\n    The function affected was page_zip_rec_needs_ext().\r\n\r\n    As a preventive measure, we will remove the potentially problematic\r\n    attributes from all functions that take pointers or references that\r\n    they are dereferencing. Functions that perform pointer arithmetics\r\n    without dereferencing the pointers should be safe: page_offset() is\r\n    an example.\r\n\r\n    While we are at it, remove also some attribute((nonnull)).\r\n    This attribute is dangerous, because it does not always generate\r\n    a warning when NULL may be passed, but it may optimize away code\r\n    for handling the NULL case. We wanted this attribute for the sake\r\n    of the warnings, not for the optimizations.\r\n\r\n    rb#6940 approved by Vasil Dimov and Jimmy Yang\r\n\r\n[2]\r\n\r\ncommit 33c2404b397e1077daaf0ef0ff9edba445430f5f\r\nAuthor: Vasil Dimov <vasil.dimov@oracle.com>\r\nDate: Wed Jan 21 10:33:58 2015 +0200\r\n\r\n    Fix Bug#20380977 COMPILER WARNINGS IN MYSQL-5.6\r\n\r\n    Remove unsued symbols and resolve other compiler warnings accordingly\r\n\r\nhttp://jenkins.percona.com/job/percona-server-5.5-param/1435/","created_at":"2016-11-18T09:03:48Z","updated_at":"2016-11-18T09:03:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"percona-ysorokin","id":13441497,"avatar_url":"https://avatars.githubusercontent.com/u/13441497?v=3","gravatar_id":"","url":"https://api.github.com/users/percona-ysorokin","html_url":"https://github.com/percona-ysorokin","followers_url":"https://api.github.com/users/percona-ysorokin/followers","following_url":"https://api.github.com/users/percona-ysorokin/following{/other_user}","gists_url":"https://api.github.com/users/percona-ysorokin/gists{/gist_id}","starred_url":"https://api.github.com/users/percona-ysorokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona-ysorokin/subscriptions","organizations_url":"https://api.github.com/users/percona-ysorokin/orgs","repos_url":"https://api.github.com/users/percona-ysorokin/repos","events_url":"https://api.github.com/users/percona-ysorokin/events{/privacy}","received_events_url":"https://api.github.com/users/percona-ysorokin/received_events","type":"User","site_admin":false},"assignees":[{"login":"percona-ysorokin","id":13441497,"avatar_url":"https://avatars.githubusercontent.com/u/13441497?v=3","gravatar_id":"","url":"https://api.github.com/users/percona-ysorokin","html_url":"https://github.com/percona-ysorokin","followers_url":"https://api.github.com/users/percona-ysorokin/followers","following_url":"https://api.github.com/users/percona-ysorokin/following{/other_user}","gists_url":"https://api.github.com/users/percona-ysorokin/gists{/gist_id}","starred_url":"https://api.github.com/users/percona-ysorokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona-ysorokin/subscriptions","organizations_url":"https://api.github.com/users/percona-ysorokin/orgs","repos_url":"https://api.github.com/users/percona-ysorokin/repos","events_url":"https://api.github.com/users/percona-ysorokin/events{/privacy}","received_events_url":"https://api.github.com/users/percona-ysorokin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/1170/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/1170/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/1170/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/028a164d44ca880d660684c97daa0a9114251b19","head":{"label":"laurynas-biveinis:bug1641612-5.5","ref":"bug1641612-5.5","sha":"028a164d44ca880d660684c97daa0a9114251b19","user":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"repo":{"id":30962866,"name":"percona-server","full_name":"laurynas-biveinis/percona-server","owner":{"login":"laurynas-biveinis","id":58894,"avatar_url":"https://avatars.githubusercontent.com/u/58894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurynas-biveinis","html_url":"https://github.com/laurynas-biveinis","followers_url":"https://api.github.com/users/laurynas-biveinis/followers","following_url":"https://api.github.com/users/laurynas-biveinis/following{/other_user}","gists_url":"https://api.github.com/users/laurynas-biveinis/gists{/gist_id}","starred_url":"https://api.github.com/users/laurynas-biveinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurynas-biveinis/subscriptions","organizations_url":"https://api.github.com/users/laurynas-biveinis/orgs","repos_url":"https://api.github.com/users/laurynas-biveinis/repos","events_url":"https://api.github.com/users/laurynas-biveinis/events{/privacy}","received_events_url":"https://api.github.com/users/laurynas-biveinis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laurynas-biveinis/percona-server","description":null,"fork":true,"url":"https://api.github.com/repos/laurynas-biveinis/percona-server","forks_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/forks","keys_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/teams","hooks_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/hooks","issue_events_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/events","assignees_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/tags","blobs_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/languages","stargazers_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/stargazers","contributors_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/contributors","subscribers_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/subscribers","subscription_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/subscription","commits_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/merges","archive_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/downloads","issues_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/laurynas-biveinis/percona-server/deployments","created_at":"2015-02-18T11:27:04Z","updated_at":"2015-02-18T11:28:38Z","pushed_at":"2016-11-18T08:39:23Z","git_url":"git://github.com/laurynas-biveinis/percona-server.git","ssh_url":"git@github.com:laurynas-biveinis/percona-server.git","clone_url":"https://github.com/laurynas-biveinis/percona-server.git","svn_url":"https://github.com/laurynas-biveinis/percona-server","homepage":null,"size":889997,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.5","ref":"5.5","sha":"7af03de247e8dd48be31c397e3280be16fcdb92d","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2016-11-15T09:10:56Z","pushed_at":"2016-11-18T08:39:24Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":585406,"stargazers_count":236,"watchers_count":236,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":15,"forks":86,"open_issues":15,"watchers":236,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1170"},"html":{"href":"https://github.com/percona/percona-server/pull/1170"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/1170"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/1170/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1170/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/1170/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/028a164d44ca880d660684c97daa0a9114251b19"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":71,"deletions":141,"changed_files":32}}
{"actor":{"display_login":"laurynas-biveinis"}}