{"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24","id":65293120,"html_url":"https://github.com/logstash-plugins/logstash-filter-json/pull/24","diff_url":"https://github.com/logstash-plugins/logstash-filter-json/pull/24.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-json/pull/24.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/24","number":24,"state":"open","locked":false,"title":"Add `fallback_mode` option to allow non-json source w/o warnings","user":{"login":"klausmeyer","id":615777,"avatar_url":"https://avatars.githubusercontent.com/u/615777?v=3","gravatar_id":"","url":"https://api.github.com/users/klausmeyer","html_url":"https://github.com/klausmeyer","followers_url":"https://api.github.com/users/klausmeyer/followers","following_url":"https://api.github.com/users/klausmeyer/following{/other_user}","gists_url":"https://api.github.com/users/klausmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/klausmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausmeyer/subscriptions","organizations_url":"https://api.github.com/users/klausmeyer/orgs","repos_url":"https://api.github.com/users/klausmeyer/repos","events_url":"https://api.github.com/users/klausmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/klausmeyer/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nwe're using logstash in our setup to process logs from our docker-infrastrucutre (with the GELF logging-driver and the `gelf` input in logstash).\r\n\r\nThe biggest part of our own applications running inside the docker-containers are logging in JSON format already so we're using the `json` filter to split the json-document provided in `short_message` field into separate fields in elasticsearch.\r\n\r\nFor each log-entry produced by a docker-container which is not in JSON format (e.g. parts of our applications where we don't can have impact on the log-format or third-party application) the `json` filter is producing a warning in the log-file:\r\n\r\n```\r\nlogstash_1      | {:timestamp=>\"2016-03-29T07:55:09.158000+0000\", :message=>\"Error parsing json\", :source=>\"short_message\", :raw=>\"ActionController::RoutingError (No route matches [GET] \\\"/\\\"):\", :exception=>#<LogStash::Json::ParserError: Unrecognized token 'ActionController': was expecting ('true', 'false' or 'null')\r\nlogstash_1      |  at [Source: [B@209c8fc2; line: 1, column: 18]>, :level=>:warn}\r\nlogstash_1      | {:timestamp=>\"2016-03-29T07:55:09.158000+0000\", :message=>\"Error parsing json\", :source=>\"short_message\", :raw=>\"  actionpack (4.2.5.2) lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call'\", :exception=>#<LogStash::Json::ParserError: Unrecognized token 'actionpack': was expecting ('true', 'false' or 'null')\r\nlogstash_1      |  at [Source: [B@302c32ba; line: 1, column: 14]>, :level=>:warn}\r\n```\r\n\r\nI've added a new config-option to the `json` filter called `fall_backmode` (default `false`) which allows to turn of this warnings and also prevent the filter from tagging the event with `\"_jsonparsefailure\"`.\r\n\r\nWould be great if we can get this change (or any variation of it) upstream so we won't have to use a fork of this plugin in our setup.\r\n\r\nI'll sign the CLA after positive feedback and before merge - hope that's ok.\r\n\r\nCheers, Klaus\r\n\r\n","created_at":"2016-04-05T12:06:59Z","updated_at":"2016-04-05T12:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/24/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/statuses/1d788a0d93a1f12c5adee6c520b78452cf3cc594","head":{"label":"klausmeyer:fallback-mode","ref":"fallback-mode","sha":"1d788a0d93a1f12c5adee6c520b78452cf3cc594","user":{"login":"klausmeyer","id":615777,"avatar_url":"https://avatars.githubusercontent.com/u/615777?v=3","gravatar_id":"","url":"https://api.github.com/users/klausmeyer","html_url":"https://github.com/klausmeyer","followers_url":"https://api.github.com/users/klausmeyer/followers","following_url":"https://api.github.com/users/klausmeyer/following{/other_user}","gists_url":"https://api.github.com/users/klausmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/klausmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausmeyer/subscriptions","organizations_url":"https://api.github.com/users/klausmeyer/orgs","repos_url":"https://api.github.com/users/klausmeyer/repos","events_url":"https://api.github.com/users/klausmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/klausmeyer/received_events","type":"User","site_admin":false},"repo":{"id":55503897,"name":"logstash-filter-json","full_name":"klausmeyer/logstash-filter-json","owner":{"login":"klausmeyer","id":615777,"avatar_url":"https://avatars.githubusercontent.com/u/615777?v=3","gravatar_id":"","url":"https://api.github.com/users/klausmeyer","html_url":"https://github.com/klausmeyer","followers_url":"https://api.github.com/users/klausmeyer/followers","following_url":"https://api.github.com/users/klausmeyer/following{/other_user}","gists_url":"https://api.github.com/users/klausmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/klausmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausmeyer/subscriptions","organizations_url":"https://api.github.com/users/klausmeyer/orgs","repos_url":"https://api.github.com/users/klausmeyer/repos","events_url":"https://api.github.com/users/klausmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/klausmeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klausmeyer/logstash-filter-json","description":null,"fork":true,"url":"https://api.github.com/repos/klausmeyer/logstash-filter-json","forks_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/forks","keys_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/teams","hooks_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/hooks","issue_events_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/issues/events{/number}","events_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/events","assignees_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/assignees{/user}","branches_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/branches{/branch}","tags_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/tags","blobs_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/statuses/{sha}","languages_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/languages","stargazers_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/stargazers","contributors_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/contributors","subscribers_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/subscribers","subscription_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/subscription","commits_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/contents/{+path}","compare_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/merges","archive_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/downloads","issues_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/issues{/number}","pulls_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/pulls{/number}","milestones_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/milestones{/number}","notifications_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/labels{/name}","releases_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/releases{/id}","deployments_url":"https://api.github.com/repos/klausmeyer/logstash-filter-json/deployments","created_at":"2016-04-05T11:54:24Z","updated_at":"2016-04-05T11:54:25Z","pushed_at":"2016-04-05T11:55:01Z","git_url":"git://github.com/klausmeyer/logstash-filter-json.git","ssh_url":"git@github.com:klausmeyer/logstash-filter-json.git","clone_url":"https://github.com/klausmeyer/logstash-filter-json.git","svn_url":"https://github.com/klausmeyer/logstash-filter-json","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"f2410ff91850d76bf3906f54348f66c955dfe99c","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":24894905,"name":"logstash-filter-json","full_name":"logstash-plugins/logstash-filter-json","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-json","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/deployments","created_at":"2014-10-07T14:46:47Z","updated_at":"2016-02-26T14:56:08Z","pushed_at":"2016-04-05T12:06:59Z","git_url":"git://github.com/logstash-plugins/logstash-filter-json.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-json.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-json.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-json","homepage":null,"size":45,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-json/pull/24"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/24"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-json/statuses/1d788a0d93a1f12c5adee6c520b78452cf3cc594"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":54,"deletions":2,"changed_files":2}}