{"action":"created","comment":{"url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments/68906253","id":68906253,"diff_hunk":"@@ -4589,13 +4593,19 @@ SpellCastResult Spell::CheckCast(bool strict)\n                                     if (i_spellST->type == SPELL_TARGET_TYPE_DEAD && ((Creature*)pTarget)->IsCorpse())\n                                     {\n                                         // always use spellMaxRange, in case GetLastRange returned different in a previous pass\n-                                        if (pTarget->IsWithinDistInMap(m_caster, GetSpellMaxRange(srange)))\n+                                        if(worldObject && (worldObject->GetTypeId() == TYPEID_GAMEOBJECT || worldObject->GetTypeId() == TYPEID_DYNAMICOBJECT) \n+                                            && pTarget->IsWithinDistInMap(worldObject, GetSpellMaxRange(srange)))\n+                                            targetExplicit = (Creature*)pTarget;\n+                                        else if (pTarget->IsWithinDistInMap(m_caster, GetSpellMaxRange(srange)))\n                                             targetExplicit = (Creature*)pTarget;\n                                     }\n                                     else if (i_spellST->type == SPELL_TARGET_TYPE_CREATURE && pTarget->isAlive())\n                                     {\n                                         // always use spellMaxRange, in case GetLastRange returned different in a previous pass\n-                                        if (pTarget->IsWithinDistInMap(m_caster, GetSpellMaxRange(srange)))\n+                                        if (worldObject && (worldObject->GetTypeId() == TYPEID_GAMEOBJECT || worldObject->GetTypeId() == TYPEID_DYNAMICOBJECT)","path":"src/game/Spell.cpp","position":56,"original_position":56,"commit_id":"58cc19e20b1b0c6504007a671fc4238d31f0e0d7","original_commit_id":"58cc19e20b1b0c6504007a671fc4238d31f0e0d7","user":{"login":"kartoffelsup","id":1819197,"avatar_url":"https://avatars.githubusercontent.com/u/1819197?v=3","gravatar_id":"","url":"https://api.github.com/users/kartoffelsup","html_url":"https://github.com/kartoffelsup","followers_url":"https://api.github.com/users/kartoffelsup/followers","following_url":"https://api.github.com/users/kartoffelsup/following{/other_user}","gists_url":"https://api.github.com/users/kartoffelsup/gists{/gist_id}","starred_url":"https://api.github.com/users/kartoffelsup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kartoffelsup/subscriptions","organizations_url":"https://api.github.com/users/kartoffelsup/orgs","repos_url":"https://api.github.com/users/kartoffelsup/repos","events_url":"https://api.github.com/users/kartoffelsup/events{/privacy}","received_events_url":"https://api.github.com/users/kartoffelsup/received_events","type":"User","site_admin":false},"body":"Looks like it :D ","created_at":"2016-06-29T08:40:23Z","updated_at":"2016-06-29T08:40:23Z","html_url":"https://github.com/cmangos/mangos-tbc/pull/64#discussion_r68906253","pull_request_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments/68906253"},"html":{"href":"https://github.com/cmangos/mangos-tbc/pull/64#discussion_r68906253"},"pull_request":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64","id":74486825,"html_url":"https://github.com/cmangos/mangos-tbc/pull/64","diff_url":"https://github.com/cmangos/mangos-tbc/pull/64.diff","patch_url":"https://github.com/cmangos/mangos-tbc/pull/64.patch","issue_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/64","number":64,"state":"open","locked":false,"title":"Plagued lands","user":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"body":"Quest 2118 fixup and some new core changes.\r\n\r\nRequired SQL for changes\r\nDELETE FROM spell_script_target WHERE entry=9439;\r\nINSERT INTO spell_script_target VALUES(9439, 1, 2164, 0);\r\n\r\nUPDATE quest_template SET ReqSpellCast1=0 WHERE entry=2118;\r\nUPDATE gameobject_template SET data2=10, data4=0 WHERE entry=109515;\r\n\r\nDELETE FROM spell_dbc WHERE Id=9439; -- change to spell_template in open source for now\r\nINSERT INTO spell_dbc(Id, SpellName, Effect1, EffectImplicitTargetA1, EffectBasePoints1, rangeIndex, SpellIconID, EquippedItemClass) VALUES\r\n(9439, 'Bear Captured in Trap', 3, 38, 1, 12, 1, -1);\r\n\r\nUPDATE creature_template SET FactionAlliance=35,FactionHorde=35 WHERE entry=11836;\r\n\r\nEDIT: @cyberium @xfurry @cala ","created_at":"2016-06-20T18:07:28Z","updated_at":"2016-06-29T08:40:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ca079630cb34f317e0acad40b49da0e69db242","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64/commits","review_comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64/comments","review_comment_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/64/comments","statuses_url":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/58cc19e20b1b0c6504007a671fc4238d31f0e0d7","head":{"label":"killerwife:PlaguedLands","ref":"PlaguedLands","sha":"58cc19e20b1b0c6504007a671fc4238d31f0e0d7","user":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"repo":{"id":56988077,"name":"mangos-tbc","full_name":"killerwife/mangos-tbc","owner":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/killerwife/mangos-tbc","description":"C(ontinued)-MaNGOS is about: -- Doing WoW-Emulation Right! ","fork":true,"url":"https://api.github.com/repos/killerwife/mangos-tbc","forks_url":"https://api.github.com/repos/killerwife/mangos-tbc/forks","keys_url":"https://api.github.com/repos/killerwife/mangos-tbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killerwife/mangos-tbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killerwife/mangos-tbc/teams","hooks_url":"https://api.github.com/repos/killerwife/mangos-tbc/hooks","issue_events_url":"https://api.github.com/repos/killerwife/mangos-tbc/issues/events{/number}","events_url":"https://api.github.com/repos/killerwife/mangos-tbc/events","assignees_url":"https://api.github.com/repos/killerwife/mangos-tbc/assignees{/user}","branches_url":"https://api.github.com/repos/killerwife/mangos-tbc/branches{/branch}","tags_url":"https://api.github.com/repos/killerwife/mangos-tbc/tags","blobs_url":"https://api.github.com/repos/killerwife/mangos-tbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killerwife/mangos-tbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killerwife/mangos-tbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/killerwife/mangos-tbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killerwife/mangos-tbc/statuses/{sha}","languages_url":"https://api.github.com/repos/killerwife/mangos-tbc/languages","stargazers_url":"https://api.github.com/repos/killerwife/mangos-tbc/stargazers","contributors_url":"https://api.github.com/repos/killerwife/mangos-tbc/contributors","subscribers_url":"https://api.github.com/repos/killerwife/mangos-tbc/subscribers","subscription_url":"https://api.github.com/repos/killerwife/mangos-tbc/subscription","commits_url":"https://api.github.com/repos/killerwife/mangos-tbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/killerwife/mangos-tbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/killerwife/mangos-tbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/killerwife/mangos-tbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/killerwife/mangos-tbc/contents/{+path}","compare_url":"https://api.github.com/repos/killerwife/mangos-tbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killerwife/mangos-tbc/merges","archive_url":"https://api.github.com/repos/killerwife/mangos-tbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killerwife/mangos-tbc/downloads","issues_url":"https://api.github.com/repos/killerwife/mangos-tbc/issues{/number}","pulls_url":"https://api.github.com/repos/killerwife/mangos-tbc/pulls{/number}","milestones_url":"https://api.github.com/repos/killerwife/mangos-tbc/milestones{/number}","notifications_url":"https://api.github.com/repos/killerwife/mangos-tbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killerwife/mangos-tbc/labels{/name}","releases_url":"https://api.github.com/repos/killerwife/mangos-tbc/releases{/id}","deployments_url":"https://api.github.com/repos/killerwife/mangos-tbc/deployments","created_at":"2016-04-24T18:38:39Z","updated_at":"2016-04-24T18:38:49Z","pushed_at":"2016-06-25T17:05:16Z","git_url":"git://github.com/killerwife/mangos-tbc.git","ssh_url":"git@github.com:killerwife/mangos-tbc.git","clone_url":"https://github.com/killerwife/mangos-tbc.git","svn_url":"https://github.com/killerwife/mangos-tbc","homepage":"http://cmangos.net","size":78153,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmangos:master","ref":"master","sha":"0cd45f74cf0bfd3f4d0cff2cc1969c4cb76f2cbd","user":{"login":"cmangos","id":2212917,"avatar_url":"https://avatars.githubusercontent.com/u/2212917?v=3","gravatar_id":"","url":"https://api.github.com/users/cmangos","html_url":"https://github.com/cmangos","followers_url":"https://api.github.com/users/cmangos/followers","following_url":"https://api.github.com/users/cmangos/following{/other_user}","gists_url":"https://api.github.com/users/cmangos/gists{/gist_id}","starred_url":"https://api.github.com/users/cmangos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmangos/subscriptions","organizations_url":"https://api.github.com/users/cmangos/orgs","repos_url":"https://api.github.com/users/cmangos/repos","events_url":"https://api.github.com/users/cmangos/events{/privacy}","received_events_url":"https://api.github.com/users/cmangos/received_events","type":"Organization","site_admin":false},"repo":{"id":6829204,"name":"mangos-tbc","full_name":"cmangos/mangos-tbc","owner":{"login":"cmangos","id":2212917,"avatar_url":"https://avatars.githubusercontent.com/u/2212917?v=3","gravatar_id":"","url":"https://api.github.com/users/cmangos","html_url":"https://github.com/cmangos","followers_url":"https://api.github.com/users/cmangos/followers","following_url":"https://api.github.com/users/cmangos/following{/other_user}","gists_url":"https://api.github.com/users/cmangos/gists{/gist_id}","starred_url":"https://api.github.com/users/cmangos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmangos/subscriptions","organizations_url":"https://api.github.com/users/cmangos/orgs","repos_url":"https://api.github.com/users/cmangos/repos","events_url":"https://api.github.com/users/cmangos/events{/privacy}","received_events_url":"https://api.github.com/users/cmangos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmangos/mangos-tbc","description":"C(ontinued)-MaNGOS is about: -- Doing WoW-Emulation Right! ","fork":false,"url":"https://api.github.com/repos/cmangos/mangos-tbc","forks_url":"https://api.github.com/repos/cmangos/mangos-tbc/forks","keys_url":"https://api.github.com/repos/cmangos/mangos-tbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmangos/mangos-tbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmangos/mangos-tbc/teams","hooks_url":"https://api.github.com/repos/cmangos/mangos-tbc/hooks","issue_events_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/events{/number}","events_url":"https://api.github.com/repos/cmangos/mangos-tbc/events","assignees_url":"https://api.github.com/repos/cmangos/mangos-tbc/assignees{/user}","branches_url":"https://api.github.com/repos/cmangos/mangos-tbc/branches{/branch}","tags_url":"https://api.github.com/repos/cmangos/mangos-tbc/tags","blobs_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/{sha}","languages_url":"https://api.github.com/repos/cmangos/mangos-tbc/languages","stargazers_url":"https://api.github.com/repos/cmangos/mangos-tbc/stargazers","contributors_url":"https://api.github.com/repos/cmangos/mangos-tbc/contributors","subscribers_url":"https://api.github.com/repos/cmangos/mangos-tbc/subscribers","subscription_url":"https://api.github.com/repos/cmangos/mangos-tbc/subscription","commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmangos/mangos-tbc/contents/{+path}","compare_url":"https://api.github.com/repos/cmangos/mangos-tbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmangos/mangos-tbc/merges","archive_url":"https://api.github.com/repos/cmangos/mangos-tbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmangos/mangos-tbc/downloads","issues_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues{/number}","pulls_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls{/number}","milestones_url":"https://api.github.com/repos/cmangos/mangos-tbc/milestones{/number}","notifications_url":"https://api.github.com/repos/cmangos/mangos-tbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmangos/mangos-tbc/labels{/name}","releases_url":"https://api.github.com/repos/cmangos/mangos-tbc/releases{/id}","deployments_url":"https://api.github.com/repos/cmangos/mangos-tbc/deployments","created_at":"2012-11-23T15:18:26Z","updated_at":"2016-06-29T07:04:36Z","pushed_at":"2016-06-29T02:52:10Z","git_url":"git://github.com/cmangos/mangos-tbc.git","ssh_url":"git@github.com:cmangos/mangos-tbc.git","clone_url":"https://github.com/cmangos/mangos-tbc.git","svn_url":"https://github.com/cmangos/mangos-tbc","homepage":"http://cmangos.net","size":58514,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":31,"forks":191,"open_issues":31,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64"},"html":{"href":"https://github.com/cmangos/mangos-tbc/pull/64"},"issue":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/issues/64"},"comments":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/58cc19e20b1b0c6504007a671fc4238d31f0e0d7"}}}}
{"actor":{"display_login":"kartoffelsup"}}