{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10403","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10403/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10403/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10403/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10403","id":170641987,"number":10403,"title":"[WIP] purge ui_lookup() from MiqPolicyController and children","user":{"login":"cben","id":273688,"avatar_url":"https://avatars.githubusercontent.com/u/273688?v=3","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/no","name":"darga/no","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/internationalization","name":"internationalization","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":{"login":"mzazrivec","id":6648365,"avatar_url":"https://avatars.githubusercontent.com/u/6648365?v=3","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"assignees":[{"login":"mzazrivec","id":6648365,"avatar_url":"https://avatars.githubusercontent.com/u/6648365?v=3","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-11T13:10:39Z","updated_at":"2016-08-30T13:05:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10403","html_url":"https://github.com/ManageIQ/manageiq/pull/10403","diff_url":"https://github.com/ManageIQ/manageiq/pull/10403.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10403.patch"},"body":"The promised followup to #9347.\r\nRemoves ~80 `ui_lookup` calls.  Most of these will need new translations.\r\nAlso turned most `mode.capitalize` interpolations `_(\"... Control ...\")`, `_(\"... Compliance ...\")` pairs of strings (not all though?)\r\n\r\nStandardizing on \"%{towhat} Policy\", \"%{towhat} Conditions\" etc in new strings.  It's already used, IMO clearer than %{typ} or %{model} and matches the actual `.towhat` field.\r\n\r\nUnraveled (ab)use of existing translations by sticking multiple things (`:foo => \"#{bar} #{baz}\"`) or fixed words (`:model => \"#{@sb[:mode]} Policy\"`) in one parameter.\r\n\r\nThe remaining `ui_lookup` calls are \"towhat\"s.\r\n\r\n@miq-bot add-label internationalization, refactoring, darga/no, wip\r\n\r\nWIP because I want to:\r\n- [x] double-check plural/singular (a few were deliberate corrections, probably had mistakes too)\r\n- [ ] understand some `nil` guards that I preserved\r\n- [ ] actually run and test :-)"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/243431800","html_url":"https://github.com/ManageIQ/manageiq/pull/10403#issuecomment-243431800","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10403","id":243431800,"user":{"login":"mzazrivec","id":6648365,"avatar_url":"https://avatars.githubusercontent.com/u/6648365?v=3","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T13:05:49Z","updated_at":"2016-08-30T13:05:49Z","body":"@cben Yes, so far it looks good."}}
{"actor":{"display_login":"mzazrivec"}}