{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/74095112","id":74095112,"diff_hunk":"@@ -27,7 +27,10 @@ EndScriptData */\n #include \"ScriptedCreature.h\"\n #include \"PassiveAI.h\"\n \n-#define GENERIC_CREATURE_COOLDOWN   5000\n+enum GenericCreature\n+{\n+    GENERIC_CREATURE_COOLDOWN = 5000","path":"src/server/scripts/World/mob_generic_creature.cpp","position":7,"original_position":7,"commit_id":"688019b1b34080ff9d4e8aed8cfc94d7327c6496","original_commit_id":"688019b1b34080ff9d4e8aed8cfc94d7327c6496","user":{"login":"Naios","id":1146834,"avatar_url":"https://avatars.githubusercontent.com/u/1146834?v=3","gravatar_id":"","url":"https://api.github.com/users/Naios","html_url":"https://github.com/Naios","followers_url":"https://api.github.com/users/Naios/followers","following_url":"https://api.github.com/users/Naios/following{/other_user}","gists_url":"https://api.github.com/users/Naios/gists{/gist_id}","starred_url":"https://api.github.com/users/Naios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naios/subscriptions","organizations_url":"https://api.github.com/users/Naios/orgs","repos_url":"https://api.github.com/users/Naios/repos","events_url":"https://api.github.com/users/Naios/events{/privacy}","received_events_url":"https://api.github.com/users/Naios/received_events","type":"User","site_admin":false},"body":"Use std::chrono pls (`Seconds(5)`)","created_at":"2016-08-09T16:36:32Z","updated_at":"2016-08-09T16:36:32Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17748#discussion_r74095112","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/74095112"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17748#discussion_r74095112"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748","id":80332023,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/17748","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17748.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17748.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17748","number":17748,"state":"open","locked":false,"title":"Core/Scripts: move #define to enum","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"**Changes proposed:**\r\n\r\nMove #define variable and value to enum in script generic_creature,\r\ncore script file mob_generic_creature.cpp\r\n\r\n(Part of the ongoing series of removing hardcoded #define variables in core scripts.)\r\n\r\n**Target branch(es):** 3.3.5 (not sure if this file is in use in 6.x/7.x)\r\n\r\n**Issues addressed:** Updates https://github.com/velinath/TrinityCore/issues/2\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc)\r\nBuilds without issues, only a text change by moving a #define to enum.\r\n\r\n**Known issues and TODO list:**\r\n\r\nNone that I know of.","created_at":"2016-08-06T06:02:53Z","updated_at":"2016-08-09T16:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd57cac0aaa6cf161c3498e0333c0616934b3f1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17748/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/688019b1b34080ff9d4e8aed8cfc94d7327c6496","head":{"label":"tkrokli:generic_creature","ref":"generic_creature","sha":"688019b1b34080ff9d4e8aed8cfc94d7327c6496","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"repo":{"id":33367544,"name":"TrinityCore","full_name":"tkrokli/TrinityCore","owner":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkrokli/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/tkrokli/TrinityCore","forks_url":"https://api.github.com/repos/tkrokli/TrinityCore/forks","keys_url":"https://api.github.com/repos/tkrokli/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkrokli/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkrokli/TrinityCore/teams","hooks_url":"https://api.github.com/repos/tkrokli/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/tkrokli/TrinityCore/events","assignees_url":"https://api.github.com/repos/tkrokli/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/tkrokli/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/tags","blobs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkrokli/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/tkrokli/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/tkrokli/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/tkrokli/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscription","commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkrokli/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkrokli/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/tkrokli/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkrokli/TrinityCore/merges","archive_url":"https://api.github.com/repos/tkrokli/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkrokli/TrinityCore/downloads","issues_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/tkrokli/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/tkrokli/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/tkrokli/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkrokli/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/tkrokli/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/tkrokli/TrinityCore/deployments","created_at":"2015-04-03T14:46:13Z","updated_at":"2016-06-08T21:21:04Z","pushed_at":"2016-08-09T01:45:22Z","git_url":"git://github.com/tkrokli/TrinityCore.git","ssh_url":"git@github.com:tkrokli/TrinityCore.git","clone_url":"https://github.com/tkrokli/TrinityCore.git","svn_url":"https://github.com/tkrokli/TrinityCore","homepage":"http://www.trinitycore.org","size":277126,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":7,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"b51409a5d3201e86bd189d1ea7dfd1dc1ca8a35f","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-08-09T14:51:45Z","pushed_at":"2016-08-09T15:21:03Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":789183,"stargazers_count":3436,"watchers_count":3436,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3507,"mirror_url":null,"open_issues_count":1323,"forks":3507,"open_issues":1323,"watchers":3436,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17748"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17748"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17748/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17748/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/688019b1b34080ff9d4e8aed8cfc94d7327c6496"}}}}
{"actor":{"display_login":"Naios"}}