{"action":"created","issue":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/53","repository_url":"https://api.github.com/repos/AliSoftware/SwiftGen","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/53/comments","events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/53/events","html_url":"https://github.com/AliSoftware/SwiftGen/pull/53","id":115148998,"number":53,"title":"Added font support via plist file in swiftgen.","user":{"login":"joseprl89","id":2854936,"avatar_url":"https://avatars.githubusercontent.com/u/2854936?v=3","gravatar_id":"","url":"https://api.github.com/users/joseprl89","html_url":"https://github.com/joseprl89","followers_url":"https://api.github.com/users/joseprl89/followers","following_url":"https://api.github.com/users/joseprl89/following{/other_user}","gists_url":"https://api.github.com/users/joseprl89/gists{/gist_id}","starred_url":"https://api.github.com/users/joseprl89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseprl89/subscriptions","organizations_url":"https://api.github.com/users/joseprl89/orgs","repos_url":"https://api.github.com/users/joseprl89/repos","events_url":"https://api.github.com/users/joseprl89/events{/privacy}","received_events_url":"https://api.github.com/users/joseprl89/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/labels/type:%20enhancement","name":"type: enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones/7","html_url":"https://github.com/AliSoftware/SwiftGen/milestones/1.1.0","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones/7/labels","id":1803394,"number":7,"title":"1.1.0","description":"","creator":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-06-01T22:01:27Z","updated_at":"2016-06-04T23:04:11Z","due_on":"2016-06-30T22:00:00Z","closed_at":null},"comments":5,"created_at":"2015-11-04T21:12:53Z","updated_at":"2016-06-04T23:04:11Z","closed_at":"2016-06-04T23:04:11Z","pull_request":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/53","html_url":"https://github.com/AliSoftware/SwiftGen/pull/53","diff_url":"https://github.com/AliSoftware/SwiftGen/pull/53.diff","patch_url":"https://github.com/AliSoftware/SwiftGen/pull/53.patch"},"body":"I'm afraid I don't have enough time today to finish the whole font support, however most of it is already done.\r\n\r\nI think I have some issue with the XCTDiffStrings method and the encoding I use in the files I created, I assume it should be easy to sort out if you know that method well. (Also maybe worth taking a look at it?).\r\n\r\nHope you can pick this up, since I won't be able to follow up much in the following days.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/comments/223783126","html_url":"https://github.com/AliSoftware/SwiftGen/pull/53#issuecomment-223783126","issue_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/53","id":223783126,"user":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T23:04:11Z","updated_at":"2016-06-04T23:04:11Z","body":"I think I'm gonna close this PR now, because now that Font support has been added in SwiftGen via #102, then:\r\n1. this PR might not be as necessary as it was before, and\r\n2. even if you still find it useful to define your fonts in a plist rather than let SwiftGen parse the fonts folder, I'm sure it'll be better to open a new PR starting from the code for the Fonts that is now in place rather than adapt this very PR.\r\n\r\nFeel free to open a new PR for this feature (but starting with latest commits) if this is still a feature you need."}}
{"actor":{"display_login":"AliSoftware"}}