{"action":"closed","issue":{"url":"https://api.github.com/repos/prerender/prerender-node/issues/111","repository_url":"https://api.github.com/repos/prerender/prerender-node","labels_url":"https://api.github.com/repos/prerender/prerender-node/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/prerender/prerender-node/issues/111/comments","events_url":"https://api.github.com/repos/prerender/prerender-node/issues/111/events","html_url":"https://github.com/prerender/prerender-node/issues/111","id":161621490,"number":111,"title":"Waiting until all assets are loaded before taking HTML snapshot","user":{"login":"declanelcocks","id":2836593,"avatar_url":"https://avatars.githubusercontent.com/u/2836593?v=3","gravatar_id":"","url":"https://api.github.com/users/declanelcocks","html_url":"https://github.com/declanelcocks","followers_url":"https://api.github.com/users/declanelcocks/followers","following_url":"https://api.github.com/users/declanelcocks/following{/other_user}","gists_url":"https://api.github.com/users/declanelcocks/gists{/gist_id}","starred_url":"https://api.github.com/users/declanelcocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declanelcocks/subscriptions","organizations_url":"https://api.github.com/users/declanelcocks/orgs","repos_url":"https://api.github.com/users/declanelcocks/repos","events_url":"https://api.github.com/users/declanelcocks/events{/privacy}","received_events_url":"https://api.github.com/users/declanelcocks/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-06-22T08:27:20Z","updated_at":"2016-06-27T08:49:25Z","closed_at":"2016-06-27T08:49:25Z","body":"I'm using the self-hosted solution to host a `prerender` server and use `prerender-node` to access that server. I'm in the early stages of setting this up and was wanting to know the correct/suggested approach for waiting until everything is ready to render the HTML.\r\n\r\nFor the JS (Angular), I assume you would use `window.prerenderReady = true` at some point in your JS code to notify prerender that it's ready, but what about the CSS or images? Currently when I try to ping my website using my `prerender` server, it's 50/50 whether the correct page will be rendered. Sometimes the page will render like normal, and sometimes it will render with a lot of `404`s for the CSS/images on the page.\r\n\r\nObviously that will be terrible for SEO, so what is the recommended approach for handling assets? I would be against doing some kind of `timeOut` to check if it's loaded as this could affect the time it takes for the `googlebot` to fetch the page."}}
{"actor":{"display_login":"declanelcocks"}}