{"action":"created","comment":{"url":"https://api.github.com/repos/esl/amoc/pulls/comments/73494470","id":73494470,"diff_hunk":"@@ -81,8 +81,7 @@ resource_exists(Req, State = #state{resource = Resource}) ->\n -spec to_json(cowboy_req:req(), state()) -> \n     {jsx:json_text(), cowboy_req:req(), state()}.\n to_json(Req0, State = #state{resource = Resource}) ->\n-    Status = amoc_controller:test_status(\n-                     erlang:list_to_atom(Resource)),\n+    Status = amoc_dist:test_status(erlang:list_to_atom(Resource)),","path":"src/amoc_api_scenario_handler.erl","position":6,"original_position":6,"commit_id":"8aafc67c048577d7a3b19932325c53d6dcbed212","original_commit_id":"8aafc67c048577d7a3b19932325c53d6dcbed212","user":{"login":"kklocek","id":9058693,"avatar_url":"https://avatars.githubusercontent.com/u/9058693?v=3","gravatar_id":"","url":"https://api.github.com/users/kklocek","html_url":"https://github.com/kklocek","followers_url":"https://api.github.com/users/kklocek/followers","following_url":"https://api.github.com/users/kklocek/following{/other_user}","gists_url":"https://api.github.com/users/kklocek/gists{/gist_id}","starred_url":"https://api.github.com/users/kklocek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklocek/subscriptions","organizations_url":"https://api.github.com/users/kklocek/orgs","repos_url":"https://api.github.com/users/kklocek/repos","events_url":"https://api.github.com/users/kklocek/events{/privacy}","received_events_url":"https://api.github.com/users/kklocek/received_events","type":"User","site_admin":false},"body":"Ad 1. It's safe here because when we want to do a `GET` request cowboy checks whether scenario exists on filesystem, so in this line we will get a name of a existing module (but maybe not loaded)\r\nAd 2. We use `binary_to_list/2` in `rest_init` function to check later in `resource_exists` whether our scenario is on disk. Without that we would need to convert our binary/atom to list, so in my opinion it's not a problem. ","created_at":"2016-08-04T09:59:43Z","updated_at":"2016-08-04T09:59:43Z","html_url":"https://github.com/esl/amoc/pull/30#discussion_r73494470","pull_request_url":"https://api.github.com/repos/esl/amoc/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/esl/amoc/pulls/comments/73494470"},"html":{"href":"https://github.com/esl/amoc/pull/30#discussion_r73494470"},"pull_request":{"href":"https://api.github.com/repos/esl/amoc/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/esl/amoc/pulls/30","id":79745684,"html_url":"https://github.com/esl/amoc/pull/30","diff_url":"https://github.com/esl/amoc/pull/30.diff","patch_url":"https://github.com/esl/amoc/pull/30.patch","issue_url":"https://api.github.com/repos/esl/amoc/issues/30","number":30,"state":"open","locked":false,"title":"Change way of getting scenario status","user":{"login":"kklocek","id":9058693,"avatar_url":"https://avatars.githubusercontent.com/u/9058693?v=3","gravatar_id":"","url":"https://api.github.com/users/kklocek","html_url":"https://github.com/kklocek","followers_url":"https://api.github.com/users/kklocek/followers","following_url":"https://api.github.com/users/kklocek/following{/other_user}","gists_url":"https://api.github.com/users/kklocek/gists{/gist_id}","starred_url":"https://api.github.com/users/kklocek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kklocek/subscriptions","organizations_url":"https://api.github.com/users/kklocek/orgs","repos_url":"https://api.github.com/users/kklocek/repos","events_url":"https://api.github.com/users/kklocek/events{/privacy}","received_events_url":"https://api.github.com/users/kklocek/received_events","type":"User","site_admin":false},"body":"Now if you want to get scenario status, yo will get status running on the whole\r\ncluster, previously you get information from node.","created_at":"2016-08-02T14:31:46Z","updated_at":"2016-08-04T09:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4578d350912887eebcb118440ec068e2ada0345f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/esl/amoc/pulls/30/commits","review_comments_url":"https://api.github.com/repos/esl/amoc/pulls/30/comments","review_comment_url":"https://api.github.com/repos/esl/amoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esl/amoc/issues/30/comments","statuses_url":"https://api.github.com/repos/esl/amoc/statuses/8aafc67c048577d7a3b19932325c53d6dcbed212","head":{"label":"esl:simple_api2_test_status_fix","ref":"simple_api2_test_status_fix","sha":"8aafc67c048577d7a3b19932325c53d6dcbed212","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":30109806,"name":"amoc","full_name":"esl/amoc","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/amoc","description":"amoc is a simple tool for running massively parallel XMPP tests","fork":false,"url":"https://api.github.com/repos/esl/amoc","forks_url":"https://api.github.com/repos/esl/amoc/forks","keys_url":"https://api.github.com/repos/esl/amoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/amoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/amoc/teams","hooks_url":"https://api.github.com/repos/esl/amoc/hooks","issue_events_url":"https://api.github.com/repos/esl/amoc/issues/events{/number}","events_url":"https://api.github.com/repos/esl/amoc/events","assignees_url":"https://api.github.com/repos/esl/amoc/assignees{/user}","branches_url":"https://api.github.com/repos/esl/amoc/branches{/branch}","tags_url":"https://api.github.com/repos/esl/amoc/tags","blobs_url":"https://api.github.com/repos/esl/amoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/amoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/amoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/amoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/amoc/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/amoc/languages","stargazers_url":"https://api.github.com/repos/esl/amoc/stargazers","contributors_url":"https://api.github.com/repos/esl/amoc/contributors","subscribers_url":"https://api.github.com/repos/esl/amoc/subscribers","subscription_url":"https://api.github.com/repos/esl/amoc/subscription","commits_url":"https://api.github.com/repos/esl/amoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/amoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/amoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/amoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/amoc/contents/{+path}","compare_url":"https://api.github.com/repos/esl/amoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/amoc/merges","archive_url":"https://api.github.com/repos/esl/amoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/amoc/downloads","issues_url":"https://api.github.com/repos/esl/amoc/issues{/number}","pulls_url":"https://api.github.com/repos/esl/amoc/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/amoc/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/amoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/amoc/labels{/name}","releases_url":"https://api.github.com/repos/esl/amoc/releases{/id}","deployments_url":"https://api.github.com/repos/esl/amoc/deployments","created_at":"2015-01-31T10:57:07Z","updated_at":"2016-07-25T14:12:32Z","pushed_at":"2016-08-04T08:12:16Z","git_url":"git://github.com/esl/amoc.git","ssh_url":"git@github.com:esl/amoc.git","clone_url":"https://github.com/esl/amoc.git","svn_url":"https://github.com/esl/amoc","homepage":"","size":1187,"stargazers_count":34,"watchers_count":34,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":34,"default_branch":"master"}},"base":{"label":"esl:simple_api2","ref":"simple_api2","sha":"f2ba8775754a456edee1809b62a24d82ea4bcf18","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":30109806,"name":"amoc","full_name":"esl/amoc","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/amoc","description":"amoc is a simple tool for running massively parallel XMPP tests","fork":false,"url":"https://api.github.com/repos/esl/amoc","forks_url":"https://api.github.com/repos/esl/amoc/forks","keys_url":"https://api.github.com/repos/esl/amoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/amoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/amoc/teams","hooks_url":"https://api.github.com/repos/esl/amoc/hooks","issue_events_url":"https://api.github.com/repos/esl/amoc/issues/events{/number}","events_url":"https://api.github.com/repos/esl/amoc/events","assignees_url":"https://api.github.com/repos/esl/amoc/assignees{/user}","branches_url":"https://api.github.com/repos/esl/amoc/branches{/branch}","tags_url":"https://api.github.com/repos/esl/amoc/tags","blobs_url":"https://api.github.com/repos/esl/amoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/amoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/amoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/amoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/amoc/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/amoc/languages","stargazers_url":"https://api.github.com/repos/esl/amoc/stargazers","contributors_url":"https://api.github.com/repos/esl/amoc/contributors","subscribers_url":"https://api.github.com/repos/esl/amoc/subscribers","subscription_url":"https://api.github.com/repos/esl/amoc/subscription","commits_url":"https://api.github.com/repos/esl/amoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/amoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/amoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/amoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/amoc/contents/{+path}","compare_url":"https://api.github.com/repos/esl/amoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/amoc/merges","archive_url":"https://api.github.com/repos/esl/amoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/amoc/downloads","issues_url":"https://api.github.com/repos/esl/amoc/issues{/number}","pulls_url":"https://api.github.com/repos/esl/amoc/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/amoc/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/amoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/amoc/labels{/name}","releases_url":"https://api.github.com/repos/esl/amoc/releases{/id}","deployments_url":"https://api.github.com/repos/esl/amoc/deployments","created_at":"2015-01-31T10:57:07Z","updated_at":"2016-07-25T14:12:32Z","pushed_at":"2016-08-04T08:12:16Z","git_url":"git://github.com/esl/amoc.git","ssh_url":"git@github.com:esl/amoc.git","clone_url":"https://github.com/esl/amoc.git","svn_url":"https://github.com/esl/amoc","homepage":"","size":1187,"stargazers_count":34,"watchers_count":34,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/amoc/pulls/30"},"html":{"href":"https://github.com/esl/amoc/pull/30"},"issue":{"href":"https://api.github.com/repos/esl/amoc/issues/30"},"comments":{"href":"https://api.github.com/repos/esl/amoc/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/amoc/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/amoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esl/amoc/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/esl/amoc/statuses/8aafc67c048577d7a3b19932325c53d6dcbed212"}}}}
{"actor":{"display_login":"kklocek"}}