{"action":"created","comment":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/84713066","pull_request_review_id":5473230,"id":84713066,"diff_hunk":"@@ -62,6 +62,12 @@ if (WIN32)\n         PATH_SUFFIXES\n             Release/${ARCH}\n         DOC \"The GLEW library\")\n+\n+    if (\"${GLEW_LIBRARY}\" MATCHES \"glew32s(d|)\")\n+        add_definitions(\"/DGLEW_STATIC\")","path":"cmake/modules/FindGLEW.cmake","position":15,"original_position":15,"commit_id":"27331a450500bdc600fa341de53e36d073cd628b","original_commit_id":"27331a450500bdc600fa341de53e36d073cd628b","user":{"login":"jcowles","id":1510114,"avatar_url":"https://avatars.githubusercontent.com/u/1510114?v=3","gravatar_id":"","url":"https://api.github.com/users/jcowles","html_url":"https://github.com/jcowles","followers_url":"https://api.github.com/users/jcowles/followers","following_url":"https://api.github.com/users/jcowles/following{/other_user}","gists_url":"https://api.github.com/users/jcowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jcowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcowles/subscriptions","organizations_url":"https://api.github.com/users/jcowles/orgs","repos_url":"https://api.github.com/users/jcowles/repos","events_url":"https://api.github.com/users/jcowles/events{/privacy}","received_events_url":"https://api.github.com/users/jcowles/received_events","type":"User","site_admin":false},"body":"Yeah, that's what I thought from the docs too, however Windows has a quirk where global variables declared \"extern\" will not be shared over library boundaries unless they are declared with dllexport declspec. Looking at the GLEW_STATIC/GLEW_BUILD preprocessor logic, the way to get dllexport is by declaring GLEW_BUILD.\r\n\r\nSo it seems this is the only way to make it work, unless you are ok with unique glew state per-library, but the USD imaging init pattern requires shared state, since Glf calls glewInit() (via GlfGlewInit); so without shared state, Glf will be the only library that gets initialized correctly.\r\n","created_at":"2016-10-24T15:26:05Z","updated_at":"2016-10-24T15:26:06Z","html_url":"https://github.com/PixarAnimationStudios/USD/pull/54#discussion_r84713066","pull_request_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments/84713066"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/54#discussion_r84713066"},"pull_request":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54","id":85282595,"html_url":"https://github.com/PixarAnimationStudios/USD/pull/54","diff_url":"https://github.com/PixarAnimationStudios/USD/pull/54.diff","patch_url":"https://github.com/PixarAnimationStudios/USD/pull/54.patch","issue_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/54","number":54,"state":"open","locked":false,"title":"Fix static GLEW linkage","user":{"login":"jcowles","id":1510114,"avatar_url":"https://avatars.githubusercontent.com/u/1510114?v=3","gravatar_id":"","url":"https://api.github.com/users/jcowles","html_url":"https://github.com/jcowles","followers_url":"https://api.github.com/users/jcowles/followers","following_url":"https://api.github.com/users/jcowles/following{/other_user}","gists_url":"https://api.github.com/users/jcowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jcowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcowles/subscriptions","organizations_url":"https://api.github.com/users/jcowles/orgs","repos_url":"https://api.github.com/users/jcowles/repos","events_url":"https://api.github.com/users/jcowles/events{/privacy}","received_events_url":"https://api.github.com/users/jcowles/received_events","type":"User","site_admin":false},"body":"In glew.h, it is required to define GLEW_STATIC when using the static library,\r\nhowever USD never sets this flag, thus previously all glew linkage was assumed\r\nto be dynamic with \"dllimport\" linkage.\r\n\r\nNow the CMake FindGlew module sets this flag when running in Win32 and the\r\nstatic library is discovered (this is determined by convention of the \"s\" or \"sd\"\r\nsuffix).\r\n\r\nAlso, GLEW debug libraries are now supported (e.g. glew32[s]d.lib).\r\n\r\nAddresses Issue #53","created_at":"2016-09-14T18:41:52Z","updated_at":"2016-10-24T15:26:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60a26b6d253697a9e3a41d63dd973926f7b2a7dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54/commits","review_comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54/comments","review_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/54/comments","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/27331a450500bdc600fa341de53e36d073cd628b","head":{"label":"jcowles:dev_win_ip","ref":"dev_win_ip","sha":"27331a450500bdc600fa341de53e36d073cd628b","user":{"login":"jcowles","id":1510114,"avatar_url":"https://avatars.githubusercontent.com/u/1510114?v=3","gravatar_id":"","url":"https://api.github.com/users/jcowles","html_url":"https://github.com/jcowles","followers_url":"https://api.github.com/users/jcowles/followers","following_url":"https://api.github.com/users/jcowles/following{/other_user}","gists_url":"https://api.github.com/users/jcowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jcowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcowles/subscriptions","organizations_url":"https://api.github.com/users/jcowles/orgs","repos_url":"https://api.github.com/users/jcowles/repos","events_url":"https://api.github.com/users/jcowles/events{/privacy}","received_events_url":"https://api.github.com/users/jcowles/received_events","type":"User","site_admin":false},"repo":{"id":67569923,"name":"USD","full_name":"jcowles/USD","owner":{"login":"jcowles","id":1510114,"avatar_url":"https://avatars.githubusercontent.com/u/1510114?v=3","gravatar_id":"","url":"https://api.github.com/users/jcowles","html_url":"https://github.com/jcowles","followers_url":"https://api.github.com/users/jcowles/followers","following_url":"https://api.github.com/users/jcowles/following{/other_user}","gists_url":"https://api.github.com/users/jcowles/gists{/gist_id}","starred_url":"https://api.github.com/users/jcowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcowles/subscriptions","organizations_url":"https://api.github.com/users/jcowles/orgs","repos_url":"https://api.github.com/users/jcowles/repos","events_url":"https://api.github.com/users/jcowles/events{/privacy}","received_events_url":"https://api.github.com/users/jcowles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcowles/USD","description":"Universal Scene Description","fork":true,"url":"https://api.github.com/repos/jcowles/USD","forks_url":"https://api.github.com/repos/jcowles/USD/forks","keys_url":"https://api.github.com/repos/jcowles/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcowles/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcowles/USD/teams","hooks_url":"https://api.github.com/repos/jcowles/USD/hooks","issue_events_url":"https://api.github.com/repos/jcowles/USD/issues/events{/number}","events_url":"https://api.github.com/repos/jcowles/USD/events","assignees_url":"https://api.github.com/repos/jcowles/USD/assignees{/user}","branches_url":"https://api.github.com/repos/jcowles/USD/branches{/branch}","tags_url":"https://api.github.com/repos/jcowles/USD/tags","blobs_url":"https://api.github.com/repos/jcowles/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcowles/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcowles/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcowles/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcowles/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/jcowles/USD/languages","stargazers_url":"https://api.github.com/repos/jcowles/USD/stargazers","contributors_url":"https://api.github.com/repos/jcowles/USD/contributors","subscribers_url":"https://api.github.com/repos/jcowles/USD/subscribers","subscription_url":"https://api.github.com/repos/jcowles/USD/subscription","commits_url":"https://api.github.com/repos/jcowles/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcowles/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcowles/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcowles/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcowles/USD/contents/{+path}","compare_url":"https://api.github.com/repos/jcowles/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcowles/USD/merges","archive_url":"https://api.github.com/repos/jcowles/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcowles/USD/downloads","issues_url":"https://api.github.com/repos/jcowles/USD/issues{/number}","pulls_url":"https://api.github.com/repos/jcowles/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/jcowles/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/jcowles/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcowles/USD/labels{/name}","releases_url":"https://api.github.com/repos/jcowles/USD/releases{/id}","deployments_url":"https://api.github.com/repos/jcowles/USD/deployments","created_at":"2016-09-07T03:49:52Z","updated_at":"2016-09-07T03:49:59Z","pushed_at":"2016-10-15T09:37:18Z","git_url":"git://github.com/jcowles/USD.git","ssh_url":"git@github.com:jcowles/USD.git","clone_url":"https://github.com/jcowles/USD.git","svn_url":"https://github.com/jcowles/USD","homepage":"http://www.openusd.org","size":25462,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PixarAnimationStudios:dev_win_ip","ref":"dev_win_ip","sha":"b13421e7eb244050d687816ee84d7adf88e2fd17","user":{"login":"PixarAnimationStudios","id":1672744,"avatar_url":"https://avatars.githubusercontent.com/u/1672744?v=3","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"repo":{"id":58168143,"name":"USD","full_name":"PixarAnimationStudios/USD","owner":{"login":"PixarAnimationStudios","id":1672744,"avatar_url":"https://avatars.githubusercontent.com/u/1672744?v=3","gravatar_id":"","url":"https://api.github.com/users/PixarAnimationStudios","html_url":"https://github.com/PixarAnimationStudios","followers_url":"https://api.github.com/users/PixarAnimationStudios/followers","following_url":"https://api.github.com/users/PixarAnimationStudios/following{/other_user}","gists_url":"https://api.github.com/users/PixarAnimationStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/PixarAnimationStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PixarAnimationStudios/subscriptions","organizations_url":"https://api.github.com/users/PixarAnimationStudios/orgs","repos_url":"https://api.github.com/users/PixarAnimationStudios/repos","events_url":"https://api.github.com/users/PixarAnimationStudios/events{/privacy}","received_events_url":"https://api.github.com/users/PixarAnimationStudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PixarAnimationStudios/USD","description":"Universal Scene Description","fork":false,"url":"https://api.github.com/repos/PixarAnimationStudios/USD","forks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/forks","keys_url":"https://api.github.com/repos/PixarAnimationStudios/USD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PixarAnimationStudios/USD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PixarAnimationStudios/USD/teams","hooks_url":"https://api.github.com/repos/PixarAnimationStudios/USD/hooks","issue_events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/events{/number}","events_url":"https://api.github.com/repos/PixarAnimationStudios/USD/events","assignees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/assignees{/user}","branches_url":"https://api.github.com/repos/PixarAnimationStudios/USD/branches{/branch}","tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/tags","blobs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/refs{/sha}","trees_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/{sha}","languages_url":"https://api.github.com/repos/PixarAnimationStudios/USD/languages","stargazers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/stargazers","contributors_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contributors","subscribers_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscribers","subscription_url":"https://api.github.com/repos/PixarAnimationStudios/USD/subscription","commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/commits{/sha}","git_commits_url":"https://api.github.com/repos/PixarAnimationStudios/USD/git/commits{/sha}","comments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/comments{/number}","issue_comment_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/comments{/number}","contents_url":"https://api.github.com/repos/PixarAnimationStudios/USD/contents/{+path}","compare_url":"https://api.github.com/repos/PixarAnimationStudios/USD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PixarAnimationStudios/USD/merges","archive_url":"https://api.github.com/repos/PixarAnimationStudios/USD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PixarAnimationStudios/USD/downloads","issues_url":"https://api.github.com/repos/PixarAnimationStudios/USD/issues{/number}","pulls_url":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls{/number}","milestones_url":"https://api.github.com/repos/PixarAnimationStudios/USD/milestones{/number}","notifications_url":"https://api.github.com/repos/PixarAnimationStudios/USD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PixarAnimationStudios/USD/labels{/name}","releases_url":"https://api.github.com/repos/PixarAnimationStudios/USD/releases{/id}","deployments_url":"https://api.github.com/repos/PixarAnimationStudios/USD/deployments","created_at":"2016-05-06T00:02:56Z","updated_at":"2016-10-23T23:36:19Z","pushed_at":"2016-10-19T04:44:33Z","git_url":"git://github.com/PixarAnimationStudios/USD.git","ssh_url":"git@github.com:PixarAnimationStudios/USD.git","clone_url":"https://github.com/PixarAnimationStudios/USD.git","svn_url":"https://github.com/PixarAnimationStudios/USD","homepage":"http://www.openusd.org","size":25667,"stargazers_count":948,"watchers_count":948,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":52,"forks":113,"open_issues":52,"watchers":948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54"},"html":{"href":"https://github.com/PixarAnimationStudios/USD/pull/54"},"issue":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/54"},"comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/PixarAnimationStudios/USD/statuses/27331a450500bdc600fa341de53e36d073cd628b"}}}}
{"actor":{"display_login":"jcowles"}}