{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1260","repository_url":"https://api.github.com/repos/mozilla/addons-frontend","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1260/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1260/comments","events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1260/events","html_url":"https://github.com/mozilla/addons-frontend/issues/1260","id":184055077,"number":1260,"title":"Standardize on component layout","user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/addons-frontend/labels/code%20quality","name":"code quality","color":"c5def5"},{"url":"https://api.github.com/repos/mozilla/addons-frontend/labels/triaged","name":"triaged","color":"c5def5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-19T19:40:17Z","updated_at":"2016-10-20T17:01:42Z","closed_at":null,"body":"Our components typically have associated Sass and image files and we have a couple different styles of organizational layout. We should pick one and convert everything to that style.\r\n\r\nHere are the current approaches:\r\n\r\nComponent is self contained:\r\n````\r\nsrc/amo/components/SystematicDysfunctioner/index.js\r\nsrc/amo/components/SystematicDysfunctioner/SystematicDysfunctioner.scss\r\nsrc/amo/components/SystematicDysfunctioner/img/thing.svg\r\n````\r\n\r\nComponent is mingled with everything else:\r\n````\r\nsrc/amo/components/SystematicDysfunctioner.js\r\nsrc/amo/components/SystematicDysfunctioner.scss\r\nsrc/amo/components/SomeOtherThing.js\r\n````\r\n\r\nComponent parts are scattered:\r\n````\r\nsrc/amo/components/SystematicDysfunctioner.js\r\nsrc/amo/css/SystematicDysfunctioner.scss\r\nsrc/amo/img/thing.svg\r\n````\r\n\r\nI like the self-contained approach. However, I think it would be fair to allow `src/amo/components/SystematicDysfunctioner.js` *only* if there are no other files associated with the component. Thoughts?"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments/255165807","html_url":"https://github.com/mozilla/addons-frontend/issues/1260#issuecomment-255165807","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1260","id":255165807,"user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T17:01:42Z","updated_at":"2016-10-20T17:01:42Z","body":"@tofumatt hmm, that's unfortunate. Is there a plugin or anything that will show the parent directory, maybe? For me, in Vim, it doesn't really feel like a problem: \r\n![screenshot 2016-10-20 11 59 31](https://cloud.githubusercontent.com/assets/55398/19569839/d0502182-96bc-11e6-82a2-6dbdd7c4003f.png)\r\n"}}
{"actor":{"display_login":"kumar303"}}