{"action":"created","comment":{"url":"https://api.github.com/repos/unicef/etools/pulls/comments/68543837","id":68543837,"diff_hunk":"@@ -188,8 +188,9 @@ def clean(self):\n         new_locations = sorted([f.instance for f in self.forms if f.cleaned_data])\n         if self.instance.approved_by_supervisor:\n             old_locations = [i for i in self.instance.triplocation_set.all()]\n-            if new_locations != old_locations:\n-                raise ValidationError('You cannot modify the location after the trip has been approved')\n+            for location in new_locations:\n+                if location not in old_locations:","path":"EquiTrack/trips/forms.py","position":7,"original_position":7,"commit_id":"05d65c02a5666ef41e1b83921639c426d1f9af23","original_commit_id":"05d65c02a5666ef41e1b83921639c426d1f9af23","user":{"login":"achamseddine","id":16557591,"avatar_url":"https://avatars.githubusercontent.com/u/16557591?v=3","gravatar_id":"","url":"https://api.github.com/users/achamseddine","html_url":"https://github.com/achamseddine","followers_url":"https://api.github.com/users/achamseddine/followers","following_url":"https://api.github.com/users/achamseddine/following{/other_user}","gists_url":"https://api.github.com/users/achamseddine/gists{/gist_id}","starred_url":"https://api.github.com/users/achamseddine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achamseddine/subscriptions","organizations_url":"https://api.github.com/users/achamseddine/orgs","repos_url":"https://api.github.com/users/achamseddine/repos","events_url":"https://api.github.com/users/achamseddine/events{/privacy}","received_events_url":"https://api.github.com/users/achamseddine/received_events","type":"User","site_admin":false},"body":"You alright, I will add a length validation","created_at":"2016-06-27T09:05:09Z","updated_at":"2016-06-27T09:05:09Z","html_url":"https://github.com/unicef/etools/pull/20#discussion_r68543837","pull_request_url":"https://api.github.com/repos/unicef/etools/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/unicef/etools/pulls/comments/68543837"},"html":{"href":"https://github.com/unicef/etools/pull/20#discussion_r68543837"},"pull_request":{"href":"https://api.github.com/repos/unicef/etools/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/unicef/etools/pulls/20","id":75070570,"html_url":"https://github.com/unicef/etools/pull/20","diff_url":"https://github.com/unicef/etools/pull/20.diff","patch_url":"https://github.com/unicef/etools/pull/20.patch","issue_url":"https://api.github.com/repos/unicef/etools/issues/20","number":20,"state":"open","locked":false,"title":"Fix small issues","user":{"login":"achamseddine","id":16557591,"avatar_url":"https://avatars.githubusercontent.com/u/16557591?v=3","gravatar_id":"","url":"https://api.github.com/users/achamseddine","html_url":"https://github.com/achamseddine","followers_url":"https://api.github.com/users/achamseddine/followers","following_url":"https://api.github.com/users/achamseddine/following{/other_user}","gists_url":"https://api.github.com/users/achamseddine/gists{/gist_id}","starred_url":"https://api.github.com/users/achamseddine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achamseddine/subscriptions","organizations_url":"https://api.github.com/users/achamseddine/orgs","repos_url":"https://api.github.com/users/achamseddine/repos","events_url":"https://api.github.com/users/achamseddine/events{/privacy}","received_events_url":"https://api.github.com/users/achamseddine/received_events","type":"User","site_admin":false},"body":"@jamescw \r\n\r\nResult display name\r\nApprove trip by supervisor\r\nDo not send trip notification to PA if no budget owner","created_at":"2016-06-24T06:37:31Z","updated_at":"2016-06-27T09:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad284c190a6506cfdbc5593f7831dd12ec8e2411","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicef/etools/pulls/20/commits","review_comments_url":"https://api.github.com/repos/unicef/etools/pulls/20/comments","review_comment_url":"https://api.github.com/repos/unicef/etools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicef/etools/issues/20/comments","statuses_url":"https://api.github.com/repos/unicef/etools/statuses/05d65c02a5666ef41e1b83921639c426d1f9af23","head":{"label":"unicef:fix-small-issues","ref":"fix-small-issues","sha":"05d65c02a5666ef41e1b83921639c426d1f9af23","user":{"login":"unicef","id":175849,"avatar_url":"https://avatars.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"repo":{"id":54648215,"name":"etools","full_name":"unicef/etools","owner":{"login":"unicef","id":175849,"avatar_url":"https://avatars.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicef/etools","description":"","fork":false,"url":"https://api.github.com/repos/unicef/etools","forks_url":"https://api.github.com/repos/unicef/etools/forks","keys_url":"https://api.github.com/repos/unicef/etools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicef/etools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicef/etools/teams","hooks_url":"https://api.github.com/repos/unicef/etools/hooks","issue_events_url":"https://api.github.com/repos/unicef/etools/issues/events{/number}","events_url":"https://api.github.com/repos/unicef/etools/events","assignees_url":"https://api.github.com/repos/unicef/etools/assignees{/user}","branches_url":"https://api.github.com/repos/unicef/etools/branches{/branch}","tags_url":"https://api.github.com/repos/unicef/etools/tags","blobs_url":"https://api.github.com/repos/unicef/etools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicef/etools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicef/etools/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicef/etools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicef/etools/statuses/{sha}","languages_url":"https://api.github.com/repos/unicef/etools/languages","stargazers_url":"https://api.github.com/repos/unicef/etools/stargazers","contributors_url":"https://api.github.com/repos/unicef/etools/contributors","subscribers_url":"https://api.github.com/repos/unicef/etools/subscribers","subscription_url":"https://api.github.com/repos/unicef/etools/subscription","commits_url":"https://api.github.com/repos/unicef/etools/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicef/etools/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicef/etools/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicef/etools/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicef/etools/contents/{+path}","compare_url":"https://api.github.com/repos/unicef/etools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicef/etools/merges","archive_url":"https://api.github.com/repos/unicef/etools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicef/etools/downloads","issues_url":"https://api.github.com/repos/unicef/etools/issues{/number}","pulls_url":"https://api.github.com/repos/unicef/etools/pulls{/number}","milestones_url":"https://api.github.com/repos/unicef/etools/milestones{/number}","notifications_url":"https://api.github.com/repos/unicef/etools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicef/etools/labels{/name}","releases_url":"https://api.github.com/repos/unicef/etools/releases{/id}","deployments_url":"https://api.github.com/repos/unicef/etools/deployments","created_at":"2016-03-24T14:28:49Z","updated_at":"2016-06-08T18:36:34Z","pushed_at":"2016-06-25T00:05:35Z","git_url":"git://github.com/unicef/etools.git","ssh_url":"git@github.com:unicef/etools.git","clone_url":"https://github.com/unicef/etools.git","svn_url":"https://github.com/unicef/etools","homepage":null,"size":60395,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"unicef:master","ref":"master","sha":"0517eff90bc464a3002685e55bc67b3ef3ef000f","user":{"login":"unicef","id":175849,"avatar_url":"https://avatars.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"repo":{"id":54648215,"name":"etools","full_name":"unicef/etools","owner":{"login":"unicef","id":175849,"avatar_url":"https://avatars.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicef/etools","description":"","fork":false,"url":"https://api.github.com/repos/unicef/etools","forks_url":"https://api.github.com/repos/unicef/etools/forks","keys_url":"https://api.github.com/repos/unicef/etools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicef/etools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicef/etools/teams","hooks_url":"https://api.github.com/repos/unicef/etools/hooks","issue_events_url":"https://api.github.com/repos/unicef/etools/issues/events{/number}","events_url":"https://api.github.com/repos/unicef/etools/events","assignees_url":"https://api.github.com/repos/unicef/etools/assignees{/user}","branches_url":"https://api.github.com/repos/unicef/etools/branches{/branch}","tags_url":"https://api.github.com/repos/unicef/etools/tags","blobs_url":"https://api.github.com/repos/unicef/etools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicef/etools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicef/etools/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicef/etools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicef/etools/statuses/{sha}","languages_url":"https://api.github.com/repos/unicef/etools/languages","stargazers_url":"https://api.github.com/repos/unicef/etools/stargazers","contributors_url":"https://api.github.com/repos/unicef/etools/contributors","subscribers_url":"https://api.github.com/repos/unicef/etools/subscribers","subscription_url":"https://api.github.com/repos/unicef/etools/subscription","commits_url":"https://api.github.com/repos/unicef/etools/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicef/etools/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicef/etools/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicef/etools/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicef/etools/contents/{+path}","compare_url":"https://api.github.com/repos/unicef/etools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicef/etools/merges","archive_url":"https://api.github.com/repos/unicef/etools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicef/etools/downloads","issues_url":"https://api.github.com/repos/unicef/etools/issues{/number}","pulls_url":"https://api.github.com/repos/unicef/etools/pulls{/number}","milestones_url":"https://api.github.com/repos/unicef/etools/milestones{/number}","notifications_url":"https://api.github.com/repos/unicef/etools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicef/etools/labels{/name}","releases_url":"https://api.github.com/repos/unicef/etools/releases{/id}","deployments_url":"https://api.github.com/repos/unicef/etools/deployments","created_at":"2016-03-24T14:28:49Z","updated_at":"2016-06-08T18:36:34Z","pushed_at":"2016-06-25T00:05:35Z","git_url":"git://github.com/unicef/etools.git","ssh_url":"git@github.com:unicef/etools.git","clone_url":"https://github.com/unicef/etools.git","svn_url":"https://github.com/unicef/etools","homepage":null,"size":60395,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicef/etools/pulls/20"},"html":{"href":"https://github.com/unicef/etools/pull/20"},"issue":{"href":"https://api.github.com/repos/unicef/etools/issues/20"},"comments":{"href":"https://api.github.com/repos/unicef/etools/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/unicef/etools/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/unicef/etools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicef/etools/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/unicef/etools/statuses/05d65c02a5666ef41e1b83921639c426d1f9af23"}}}}
{"actor":{"display_login":"achamseddine"}}