{"action":"created","issue":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2482","repository_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2482/labels{/name}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2482/comments","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2482/events","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/2482","id":183332074,"number":2482,"title":"[Mod-Incompatibility] SpongeForge needs ModMetaData class to remain un-classloaded before CoreMod instantiation","user":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars.githubusercontent.com/u/1203877?v=3","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2016-10-17T06:03:14Z","updated_at":"2016-10-20T08:51:33Z","closed_at":"2016-10-19T10:06:22Z","body":"This is realistically a simple change of how AE2's core mod initializes itself. Because the CoreMod `IFMLLoadingPlugin` is indirectly classloading classes before other coremod transformers have a chance to transform them, certain integrations may fail outright. An example is available here: https://github.com/SpongePowered/SpongeForge/issues/966. \r\n\r\nNow, the change required is rather simple (of which I have written a [PR to rectify the incompatibility](https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/2483)), simply separating the `DummyModContainer` out from the `IFMLLoadingPlugin`. The functionality otherwise does not change the mod or the game in any other way.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments/255047340","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/2482#issuecomment-255047340","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/2482","id":255047340,"user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T08:51:33Z","updated_at":"2016-10-20T08:51:33Z","body":"Blaming every sponge user out there is certainly not my intention. @asiekierka is certainly right here.\r\nThus I have to apologise for it.\r\n\r\nI absolutely do not want to use it as excuse, just to clarify this situtation.\r\nIt was mostly about me feeling to just waste time to the issue, after already stating multiple times we will look into it as well as one (in my eyes) smaller user group trying to push their agenda to be resolved ASAP.\r\nWhile we certainly still have many more things to do, which will affect absolutely every user and are certainly much longer unresolved. Which feels very unfair towards them should we now favour the most recent issue. Regardless of how small it appears after a quick look at it.\r\n\r\nSo my original plan still stands. We will update the coremod to at least allow it to start.\r\n\r\nBut under the conditions, that we have time to look at the coremod itself. It is simply a part of AE2 none of use have ever looked as they just work. So we need to do at least a bit research. There is no point of having to ask someone else each time we have to change something about them. \r\n\r\nAs well a we think AE2 is ready to be tested on a server. There are certainly many open issues left and worst case they might require a full reset of the world or maybe even waste all time spent on things using the AE API or even internal code.\r\n\r\nSupporting plugins is certainly of the table due to time constraints. With Mixins they simple can interfere too easily with our code and we cannot review absoluetely everything. It can change at some point in the future. But until then we have to require that any bug has to be reproducable in a minimal setup with just Forge + AE2 and potentially the mod (not plugin) being involved.\r\n\r\nI also looked shortly at the PR and there are still issues left. While it appears to start, at least once it no longer does, it will at least display incorrect information. Maybe there are even other rare cases now causing bugs. Like some error handling, which no longer work because these are designed with the container and coremod being the same class in mind. So it is certainly not as straightforward to resolve as it currently appears."}}
{"actor":{"display_login":"yueh"}}