{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/53","repository_url":"https://api.github.com/repos/PowerShell/xSQLServer","labels_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/53/comments","events_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/53/events","html_url":"https://github.com/PowerShell/xSQLServer/pull/53","id":152030585,"number":53,"title":"Additional resources for managing AlwaysOn","user":{"login":"johlju","id":7189721,"avatar_url":"https://avatars.githubusercontent.com/u/7189721?v=3","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/xSQLServer/labels/cla-signed","name":"cla-signed","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"narrieta","id":8194100,"avatar_url":"https://avatars.githubusercontent.com/u/8194100?v=3","gravatar_id":"","url":"https://api.github.com/users/narrieta","html_url":"https://github.com/narrieta","followers_url":"https://api.github.com/users/narrieta/followers","following_url":"https://api.github.com/users/narrieta/following{/other_user}","gists_url":"https://api.github.com/users/narrieta/gists{/gist_id}","starred_url":"https://api.github.com/users/narrieta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narrieta/subscriptions","organizations_url":"https://api.github.com/users/narrieta/orgs","repos_url":"https://api.github.com/users/narrieta/repos","events_url":"https://api.github.com/users/narrieta/events{/privacy}","received_events_url":"https://api.github.com/users/narrieta/received_events","type":"User","site_admin":false},"assignees":[{"login":"narrieta","id":8194100,"avatar_url":"https://avatars.githubusercontent.com/u/8194100?v=3","gravatar_id":"","url":"https://api.github.com/users/narrieta","html_url":"https://github.com/narrieta","followers_url":"https://api.github.com/users/narrieta/followers","following_url":"https://api.github.com/users/narrieta/following{/other_user}","gists_url":"https://api.github.com/users/narrieta/gists{/gist_id}","starred_url":"https://api.github.com/users/narrieta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narrieta/subscriptions","organizations_url":"https://api.github.com/users/narrieta/orgs","repos_url":"https://api.github.com/users/narrieta/repos","events_url":"https://api.github.com/users/narrieta/events{/privacy}","received_events_url":"https://api.github.com/users/narrieta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2016-04-30T13:35:41Z","updated_at":"2016-08-02T16:29:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/53","html_url":"https://github.com/PowerShell/xSQLServer/pull/53","diff_url":"https://github.com/PowerShell/xSQLServer/pull/53.diff","patch_url":"https://github.com/PowerShell/xSQLServer/pull/53.patch"},"body":"* Resources Added\r\n  - xSQLServerPermission\r\n  - xSQLServerEndpointState\r\n  - xSQLServerEndpointPermission\r\n  - xSQLServerAvailabilityGroupListner\r\n  \r\n* Changes to xSQLServerHelper\r\n\t- added functions \r\n\t\t- Import-SQLPSModule\r\n\t\t- Get-SQLPSInstanceName\r\n\t\t- Get-SQLPSInstance\r\n\t\t- Get-SQLAlwaysOnEndpoint\r\n\t- modified functions\r\n\t\t- New-TerminatingError - *added optional parameter `-InnerException` to be able to give the user more information in the returned message*\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xsqlserver/53)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/comments/236960829","html_url":"https://github.com/PowerShell/xSQLServer/pull/53#issuecomment-236960829","issue_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/53","id":236960829,"user":{"login":"narrieta","id":8194100,"avatar_url":"https://avatars.githubusercontent.com/u/8194100?v=3","gravatar_id":"","url":"https://api.github.com/users/narrieta","html_url":"https://github.com/narrieta","followers_url":"https://api.github.com/users/narrieta/followers","following_url":"https://api.github.com/users/narrieta/following{/other_user}","gists_url":"https://api.github.com/users/narrieta/gists{/gist_id}","starred_url":"https://api.github.com/users/narrieta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narrieta/subscriptions","organizations_url":"https://api.github.com/users/narrieta/orgs","repos_url":"https://api.github.com/users/narrieta/repos","events_url":"https://api.github.com/users/narrieta/events{/privacy}","received_events_url":"https://api.github.com/users/narrieta/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T16:29:19Z","updated_at":"2016-08-02T16:29:19Z","body":"\n\n\n\nReview status: 8 of 17 files reviewed at latest revision, 9 unresolved discussions.\n\n---\n\n*[Tests/Unit/xSQLServerPermission.Tests.ps1, line 20 \\[r9\\]](https://reviewable.io:443/reviews/powershell/xsqlserver/53#-KO78-_Dklc3LY0QCCqc:-KOB3ZBeJHX5r9A5X6tm:1718249252) ([raw file](https://github.com/powershell/xsqlserver/blob/e390adb141d394b16d9540891f7f017f36225b4d/Tests/Unit/xSQLServerPermission.Tests.ps1#L20)):*\n<details><summary><i>Previously, johlju (Johan Ljunggren) wrote…</i></summary>\n> Does that work? It says it has to be inside a describe block. And that I think is something that should be changed in the unit template first. Do you agree?\n> \n> https://github.com/pester/Pester/issues/302\n> https://github.com/pester/Pester/blob/7a55e0ffa8bc1517f97d3a144c1f77f3d9b450f8/en-US/about_BeforeEach_AfterEach.help.txt#L24\n</details>\nYes, it should work:\n\n    Describe 'BeforeAll' {\n        BeforeAll {\n            $myvariable = 'foo'\n        }\n        It 'Should be executed within the scope of the Describe block' {\n            $myvariable | Should Be 'foo'\n        }\n    }\n\n    Describing BeforeAll\n         [+] Should be executed within the scope of the Describe block 132ms\n\nI agree that this should be fixed in the test template, and I opened an issue yesterday: https://github.com/PowerShell/DscResources/issues/162\n\nI'd recommend doing the change in these tests even if the template has not been updated yet, but this is optional,\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/xsqlserver/53)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"narrieta"}}