{"action":"created","comment":{"url":"https://api.github.com/repos/google/shaka-player/pulls/comments/68497259","id":68497259,"diff_hunk":"@@ -121,7 +121,8 @@ def get(*args):\n \n   # Ignore missing goog.require since we assume the whole library is\n   # already included.\n-  opts = ['--jscomp_off=missingRequire', '--checks-only', '-O', 'SIMPLE']\n+  opts = ['--jscomp_off=missingRequire', '--jscomp_off=lintChecks',","path":"build/check.py","position":5,"original_position":5,"commit_id":"70e81eb0dd62ce5e8dd12e322ff7b88f09f9c5c4","original_commit_id":"70e81eb0dd62ce5e8dd12e322ff7b88f09f9c5c4","user":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"body":"Regrettably, the compiler contains two different variants of the \"missing require\" check (MISSING_REQUIRE_WARNING, MISSING_REQUIRE_CALL_WARNING). Some [legacy code](https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/DiagnosticGroups.java#L504) is preventing MISSING_REQUIRE_CALL_WARNING from being included with the \"missingRequire\" diagnostic group but rather it is included in lintChecks.\r\n\r\nSaid differently, all of the lintChecks besides MISSING_REQUIRE_CALL_WARNING still pass. Without adding lintChecks we get the following errors:\r\n\r\n```\r\n/home/ahochhaus/shaka-player2/demo/asset_section.js:30: ERROR - missing require: 'shakaAssets.testAssets'\r\n  shakaAssets.testAssets.forEach(function(asset) {\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/asset_section.js:194: ERROR - missing require: 'shaka.log'\r\n      shaka.log.debug('load() interrupted');\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/configuration_section.js:59: ERROR - missing require: 'shakaDemo.player_'\r\n  shakaDemo.player_.configure(/** @type {shakaExtern.PlayerConfiguration} */({\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/configuration_section.js:71: ERROR - missing require: 'shakaDemo.controls_'\r\n  shakaDemo.controls_.showTrickPlay(event.target.checked);\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/info_section.js:28: ERROR - missing require: 'shakaDemo.player_'\r\n  shakaDemo.player_.addEventListener(\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/info_section.js:107: ERROR - missing require: 'shakaDemo.player_'\r\n  var tracks = shakaDemo.player_.getTracks();\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/log_section.js:91: ERROR - missing require: 'shaka.log'\r\n  shaka.log.setLevel(shaka.log.currentLevel);\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/main.js:79: ERROR - missing require: 'shaka.log'\r\n    shaka.log.setLevel(shaka.log.Level.DEBUG);\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/main.js:84: ERROR - missing require: 'shaka.polyfill'\r\n  shaka.polyfill.installAll();\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/main.js:86: ERROR - missing require: 'shaka.Player'\r\n  if (!shaka.Player.isBrowserSupported()) {\r\n       ^\r\n\r\n/home/ahochhaus/shaka-player2/demo/main.js:112: ERROR - missing require: 'shaka.Player'\r\n    shaka.Player.probeSupport().then(function(support) {\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/cancelable_chain_unit.js:185: ERROR - missing require: 'shaka.test.Util'\r\n      shaka.test.Util.delay(0.1).then(function() {\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_content_protection_unit.js:33: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    var retry = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_content_protection_unit.js:125: ERROR - missing require: 'shaka.util.Uint8ArrayUtils'\r\n        initData: shaka.util.Uint8ArrayUtils.fromBase64(base64)\r\n                  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_content_protection_unit.js:219: ERROR - missing require: 'shaka.test.Dash'\r\n    var expected = shaka.test.Dash.makeManifestFromStreamSets([\r\n                   ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_live_unit.js:30: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    var retry = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_live_unit.js:430: ERROR - missing require: 'shaka.util.StringUtils'\r\n            var data = shaka.util.StringUtils.toUTF8(manifest);\r\n                       ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_live_unit.js:853: ERROR - missing require: 'shaka.test.Dash'\r\n      shaka.test.Dash.makeReference('s4.mp4', 4, 30, 40)\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_manifest_unit.js:27: ERROR - missing require: 'shaka.test.Dash'\r\n    parser = shaka.test.Dash.makeDashParser();\r\n             ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_manifest_unit.js:555: ERROR - missing require: 'shaka.util.StringUtils'\r\n          var data = shaka.util.StringUtils.toUTF8(source);\r\n                     ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_segment_base_unit.js:30: ERROR - missing require: 'shaka.test.Dash'\r\n    parser = shaka.test.Dash.makeDashParser();\r\n             ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_segment_list_unit.js:30: ERROR - missing require: 'shaka.test.Dash'\r\n    parser = shaka.test.Dash.makeDashParser();\r\n             ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_segment_list_unit.js:33: ERROR - missing require: 'shaka.test.Dash'\r\n  shaka.test.Dash.makeTimelineTests('SegmentList', '', [\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_segment_template_unit.js:30: ERROR - missing require: 'shaka.test.Dash'\r\n    parser = shaka.test.Dash.makeDashParser();\r\n             ^\r\n\r\n/home/ahochhaus/shaka-player2/test/dash_parser_segment_template_unit.js:33: ERROR - missing require: 'shaka.test.Dash'\r\n  shaka.test.Dash.makeTimelineTests(\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/data_uri_plugin_unit.js:22: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    retryParameters = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/data_uri_plugin_unit.js:78: ERROR - missing require: 'shaka.util.StringUtils'\r\n          var data = shaka.util.StringUtils.fromBytesAutoDetect(response.data);\r\n                     ^\r\n\r\n/home/ahochhaus/shaka-player2/test/data_uri_plugin_unit.js:87: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n        shaka.net.NetworkingEngine.makeRequest([uri], retryParameters);\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/data_uri_plugin_unit.js:88: ERROR - missing require: 'shaka.net.DataUriPlugin'\r\n    shaka.net.DataUriPlugin(uri, request)\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/db_engine_unit.js:31: ERROR - missing require: 'shaka.offline.DBEngine'\r\n    shaka.offline.DBEngine.deleteDatabase().then(function() {\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/db_engine_unit.js:117: ERROR - missing require: 'shaka.test.Util'\r\n      shaka.test.Util.expectToEqualError(error, expectedError);\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/db_engine_unit.js:126: ERROR - missing require: 'shaka.test.Util'\r\n          return shaka.test.Util.delay(0.001);\r\n                 ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_integration.js:47: ERROR - missing require: 'shaka.media.DrmEngine'\r\n    var supportTest = shaka.media.DrmEngine.probeSupport()\r\n                      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_integration.js:73: ERROR - missing require: 'shaka.net.HttpPlugin'\r\n      shaka.net.HttpPlugin(audioSegmentUri, dummyRequest)\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_integration.js:282: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n        retryParameters: shaka.net.NetworkingEngine.defaultRetryParameters(),\r\n                         ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_integration.js:350: ERROR - missing require: 'shaka.test.Util'\r\n        shaka.test.Util.expectToEqualError(\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_integration.js:386: ERROR - missing require: 'shaka.test.Util'\r\n        return Promise.race([shaka.test.Util.delay(6), onErrorCalled]);\r\n                             ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:99: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    var retryParameters = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                          ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:563: ERROR - missing require: 'shaka.util.StringUtils'\r\n        var initData = JSON.parse(shaka.util.StringUtils.fromUTF8(\r\n                                  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:898: ERROR - missing require: 'shaka.net.DataUriPlugin'\r\n        return shaka.net.DataUriPlugin(request.uris[0], request);\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:910: ERROR - missing require: 'shaka.util.StringUtils'\r\n            shaka.util.StringUtils.fromBytesAutoDetect(licenseBuffer);\r\n            ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:942: ERROR - missing require: 'shaka.test.Util'\r\n        shaka.test.Util.expectToEqualError(error, new shaka.util.Error(\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/drm_engine_unit.js:1271: ERROR - missing require: 'shaka.test.Util'\r\n        return shaka.test.Util.delay(0.1);\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/ebml_parser_unit.js:238: ERROR - missing require: 'shaka.util.EbmlParser'\r\n      shaka.util.EbmlParser.getVintValue_(data);\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/fake_event_target_unit.js:132: ERROR - missing require: 'shaka.test.Util'\r\n    shaka.test.Util.delay(0.1).then(function() {\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/http_plugin_unit.js:48: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    retryParameters = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/http_plugin_unit.js:128: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    var request = shaka.net.NetworkingEngine.makeRequest(\r\n                  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/http_plugin_unit.js:130: ERROR - missing require: 'shaka.net.HttpPlugin'\r\n    shaka.net.HttpPlugin(uri, request)\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/networking_engine_unit.js:49: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    shaka.net.NetworkingEngine.registerScheme('reject', rejectScheme);\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/networking_engine_unit.js:239: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n      shaka.net.NetworkingEngine.unregisterScheme('resolve');\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/networking_engine_unit.js:630: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n                          shaka.net.NetworkingEngine.defaultRetryParameters();\r\n                          ^\r\n\r\n/home/ahochhaus/shaka-player2/test/networking_engine_unit.js:631: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n    return shaka.net.NetworkingEngine.makeRequest([uri], retryParameters);\r\n           ^\r\n\r\n/home/ahochhaus/shaka-player2/test/offline_integration.js:33: ERROR - missing require: 'shaka.Player'\r\n    var supportPromise = shaka.Player.probeSupport()\r\n                         ^\r\n\r\n/home/ahochhaus/shaka-player2/test/offline_integration.js:41: ERROR - missing require: 'shaka.offline.DBEngine'\r\n    Promise.all([shaka.offline.DBEngine.deleteDatabase(), supportPromise])\r\n                 ^\r\n\r\n/home/ahochhaus/shaka-player2/test/offline_integration.js:115: ERROR - missing require: 'shaka.test.Util'\r\n      shaka.test.Util.expectToEqualError(e, expected);\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/offline_integration.js:129: ERROR - missing require: 'shaka.test.Util'\r\n          return shaka.test.Util.delay(5);\r\n                 ^\r\n\r\n/home/ahochhaus/shaka-player2/test/player_unit.js:120: ERROR - missing require: 'shaka.log'\r\n        shaka.log.debug('finished unload 2');\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/player_unit.js:253: ERROR - missing require: 'shaka.media.ManifestParser'\r\n        shaka.media.ManifestParser.registerParserByMime('undefined', factory1);\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/player_unit.js:335: ERROR - missing require: 'shaka.test.Util'\r\n        shaka.test.Util.delay(0.5).then(function() {\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/player_unit.js:1223: ERROR - missing require: 'shaka.test.Util'\r\n        shaka.test.Util.expectToEqualError(\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/simple_abr_manager_unit.js:278: ERROR - missing require: 'shaka.test.Util'\r\n    var delay = shaka.test.Util.fakeEventLoop(\r\n                ^\r\n\r\n/home/ahochhaus/shaka-player2/test/storage_unit.js:636: ERROR - missing require: 'shaka.test.Util'\r\n            shaka.test.Util.expectToEqualError(\r\n            ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:147: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n      timeline = shaka.test.StreamingEngineUtil.createFakePresentationTimeline(\r\n                 ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:205: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n        shaka.test.StreamingEngineUtil.boundsCheckPosition.bind(\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:209: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n        shaka.test.StreamingEngineUtil.getNumSegments.bind(\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:214: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n    netEngine = shaka.test.StreamingEngineUtil.createFakeNetworkingEngine(\r\n                ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:257: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n    manifest = shaka.test.StreamingEngineUtil.createManifest(\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_integration.js:293: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n      retryParameters: shaka.net.NetworkingEngine.defaultRetryParameters(),\r\n                       ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_unit.js:232: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n    timeline = shaka.test.StreamingEngineUtil.createFakePresentationTimeline(\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_unit.js:248: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n    netEngine = shaka.test.StreamingEngineUtil.createFakeNetworkingEngine(\r\n                ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_unit.js:266: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n    manifest = shaka.test.StreamingEngineUtil.createManifest(\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_unit.js:304: ERROR - missing require: 'shaka.test.StreamingEngineUtil'\r\n        shaka.test.StreamingEngineUtil.createMockVideoStream(6);\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/streaming_engine_unit.js:1730: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n        retryParameters: shaka.net.NetworkingEngine.defaultRetryParameters(),\r\n                         ^\r\n\r\n/home/ahochhaus/shaka-player2/test/support_check.js:20: ERROR - missing require: 'shaka.Player'\r\n    if (!shaka.Player.isBrowserSupported()) {\r\n         ^\r\n\r\n/home/ahochhaus/shaka-player2/test/support_check.js:22: ERROR - missing require: 'shaka.test.Util'\r\n      shaka.test.Util.cancelAllRemainingSpecs();\r\n      ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/dash_parser_util.js:26: ERROR - missing require: 'shaka.net.NetworkingEngine'\r\n  var retry = shaka.net.NetworkingEngine.defaultRetryParameters();\r\n              ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/dash_parser_util.js:102: ERROR - missing require: 'shaka.util.StringUtils'\r\n  var manifestData = shaka.util.StringUtils.toUTF8(manifestText);\r\n                     ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/dash_parser_util.js:110: ERROR - missing require: 'shaka.test.Util'\r\n        shaka.test.Util.expectToEqualError(error, expectedError);\r\n        ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/manifest_generator.js:262: ERROR - missing require: 'shaka.util.Uint8ArrayUtils'\r\n  var buffer = shaka.util.Uint8ArrayUtils.fromBase64(base64);\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/manifest_generator.js:541: ERROR - missing require: 'goog.asserts'\r\n  goog.asserts.assert(streamSet.streams.length > 0,\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/memory_db_engine.js:85: ERROR - missing require: 'shaka.util.MapUtils'\r\n  shaka.util.MapUtils.values(this.getStore_(storeName)).forEach(callback);\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/memory_db_engine.js:135: ERROR - missing require: 'goog.asserts'\r\n  goog.asserts.assert(storeName in this.stores_,\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/stream_generator.js:482: ERROR - missing require: 'goog.asserts'\r\n  goog.asserts.assert(\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/stream_generator.js:500: ERROR - missing require: 'shaka.log'\r\n    shaka.log.debug('tfdt box is version 1.');\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/util.js:277: ERROR - missing require: 'shaka.log'\r\n    shaka.log.setLevel(shaka.log.Level.INFO);\r\n    ^\r\n\r\n/home/ahochhaus/shaka-player2/test/util/util.js:279: ERROR - missing require: 'shaka.polyfill'\r\n  shaka.polyfill.installAll();\r\n  ^\r\n\r\n/home/ahochhaus/shaka-player2/test/vtt_text_parser_unit.js:280: ERROR - missing require: 'shaka.util.StringUtils'\r\n    var data = shaka.util.StringUtils.toUTF8(string);\r\n               ^\r\n\r\n/home/ahochhaus/shaka-player2/test/vtt_text_parser_unit.js:282: ERROR - missing require: 'shaka.media.VttTextParser'\r\n      shaka.media.VttTextParser(data);\r\n      ^\r\n\r\n88 error(s), 0 warning(s)\r\n```\r\n\r\nDo you know of a better solution?","created_at":"2016-06-26T03:52:23Z","updated_at":"2016-06-26T03:52:23Z","html_url":"https://github.com/google/shaka-player/pull/421#discussion_r68497259","pull_request_url":"https://api.github.com/repos/google/shaka-player/pulls/421","_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments/68497259"},"html":{"href":"https://github.com/google/shaka-player/pull/421#discussion_r68497259"},"pull_request":{"href":"https://api.github.com/repos/google/shaka-player/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/google/shaka-player/pulls/421","id":75216674,"html_url":"https://github.com/google/shaka-player/pull/421","diff_url":"https://github.com/google/shaka-player/pull/421.diff","patch_url":"https://github.com/google/shaka-player/pull/421.patch","issue_url":"https://api.github.com/repos/google/shaka-player/issues/421","number":421,"state":"open","locked":false,"title":"Update to compiler v20160619.","user":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"body":"Note, this PR depends upon #420.","created_at":"2016-06-25T23:05:17Z","updated_at":"2016-06-26T03:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b94200353040c988426a45c6beb6c1bd525568fe","assignee":{"login":"joeyparrish","id":6843156,"avatar_url":"https://avatars.githubusercontent.com/u/6843156?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyparrish","html_url":"https://github.com/joeyparrish","followers_url":"https://api.github.com/users/joeyparrish/followers","following_url":"https://api.github.com/users/joeyparrish/following{/other_user}","gists_url":"https://api.github.com/users/joeyparrish/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyparrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyparrish/subscriptions","organizations_url":"https://api.github.com/users/joeyparrish/orgs","repos_url":"https://api.github.com/users/joeyparrish/repos","events_url":"https://api.github.com/users/joeyparrish/events{/privacy}","received_events_url":"https://api.github.com/users/joeyparrish/received_events","type":"User","site_admin":false},"assignees":[{"login":"joeyparrish","id":6843156,"avatar_url":"https://avatars.githubusercontent.com/u/6843156?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyparrish","html_url":"https://github.com/joeyparrish","followers_url":"https://api.github.com/users/joeyparrish/followers","following_url":"https://api.github.com/users/joeyparrish/following{/other_user}","gists_url":"https://api.github.com/users/joeyparrish/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyparrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyparrish/subscriptions","organizations_url":"https://api.github.com/users/joeyparrish/orgs","repos_url":"https://api.github.com/users/joeyparrish/repos","events_url":"https://api.github.com/users/joeyparrish/events{/privacy}","received_events_url":"https://api.github.com/users/joeyparrish/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/shaka-player/pulls/421/commits","review_comments_url":"https://api.github.com/repos/google/shaka-player/pulls/421/comments","review_comment_url":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/shaka-player/issues/421/comments","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/70e81eb0dd62ce5e8dd12e322ff7b88f09f9c5c4","head":{"label":"hochhaus:ver","ref":"ver","sha":"70e81eb0dd62ce5e8dd12e322ff7b88f09f9c5c4","user":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"repo":{"id":61736924,"name":"shaka-player","full_name":"hochhaus/shaka-player","owner":{"login":"hochhaus","id":5508784,"avatar_url":"https://avatars.githubusercontent.com/u/5508784?v=3","gravatar_id":"","url":"https://api.github.com/users/hochhaus","html_url":"https://github.com/hochhaus","followers_url":"https://api.github.com/users/hochhaus/followers","following_url":"https://api.github.com/users/hochhaus/following{/other_user}","gists_url":"https://api.github.com/users/hochhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/hochhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hochhaus/subscriptions","organizations_url":"https://api.github.com/users/hochhaus/orgs","repos_url":"https://api.github.com/users/hochhaus/repos","events_url":"https://api.github.com/users/hochhaus/events{/privacy}","received_events_url":"https://api.github.com/users/hochhaus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hochhaus/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":true,"url":"https://api.github.com/repos/hochhaus/shaka-player","forks_url":"https://api.github.com/repos/hochhaus/shaka-player/forks","keys_url":"https://api.github.com/repos/hochhaus/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hochhaus/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hochhaus/shaka-player/teams","hooks_url":"https://api.github.com/repos/hochhaus/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/hochhaus/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/hochhaus/shaka-player/events","assignees_url":"https://api.github.com/repos/hochhaus/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/hochhaus/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/hochhaus/shaka-player/tags","blobs_url":"https://api.github.com/repos/hochhaus/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hochhaus/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hochhaus/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/hochhaus/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hochhaus/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/hochhaus/shaka-player/languages","stargazers_url":"https://api.github.com/repos/hochhaus/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/hochhaus/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/hochhaus/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/hochhaus/shaka-player/subscription","commits_url":"https://api.github.com/repos/hochhaus/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/hochhaus/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/hochhaus/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/hochhaus/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/hochhaus/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/hochhaus/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hochhaus/shaka-player/merges","archive_url":"https://api.github.com/repos/hochhaus/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hochhaus/shaka-player/downloads","issues_url":"https://api.github.com/repos/hochhaus/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/hochhaus/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/hochhaus/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/hochhaus/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hochhaus/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/hochhaus/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/hochhaus/shaka-player/deployments","created_at":"2016-06-22T17:06:34Z","updated_at":"2016-06-22T17:06:35Z","pushed_at":"2016-06-25T23:03:07Z","git_url":"git://github.com/hochhaus/shaka-player.git","ssh_url":"git@github.com:hochhaus/shaka-player.git","clone_url":"https://github.com/hochhaus/shaka-player.git","svn_url":"https://github.com/hochhaus/shaka-player","homepage":"","size":29161,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a3c1ed29d4d1cb769daeddf390ad5f7bb2b71399","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":28246472,"name":"shaka-player","full_name":"google/shaka-player","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":false,"url":"https://api.github.com/repos/google/shaka-player","forks_url":"https://api.github.com/repos/google/shaka-player/forks","keys_url":"https://api.github.com/repos/google/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/shaka-player/teams","hooks_url":"https://api.github.com/repos/google/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/google/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/google/shaka-player/events","assignees_url":"https://api.github.com/repos/google/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/google/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/google/shaka-player/tags","blobs_url":"https://api.github.com/repos/google/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/google/shaka-player/languages","stargazers_url":"https://api.github.com/repos/google/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/google/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/google/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/google/shaka-player/subscription","commits_url":"https://api.github.com/repos/google/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/google/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/shaka-player/merges","archive_url":"https://api.github.com/repos/google/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/shaka-player/downloads","issues_url":"https://api.github.com/repos/google/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/google/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/google/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/google/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/google/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/google/shaka-player/deployments","created_at":"2014-12-19T21:12:18Z","updated_at":"2016-06-25T18:33:01Z","pushed_at":"2016-06-26T00:41:51Z","git_url":"git://github.com/google/shaka-player.git","ssh_url":"git@github.com:google/shaka-player.git","clone_url":"https://github.com/google/shaka-player.git","svn_url":"https://github.com/google/shaka-player","homepage":"","size":30110,"stargazers_count":655,"watchers_count":655,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":40,"forks":146,"open_issues":40,"watchers":655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/421"},"html":{"href":"https://github.com/google/shaka-player/pull/421"},"issue":{"href":"https://api.github.com/repos/google/shaka-player/issues/421"},"comments":{"href":"https://api.github.com/repos/google/shaka-player/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/google/shaka-player/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/shaka-player/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/google/shaka-player/statuses/70e81eb0dd62ce5e8dd12e322ff7b88f09f9c5c4"}}}}
{"actor":{"display_login":"hochhaus"}}