{"action":"created","comment":{"url":"https://api.github.com/repos/typelevel/cats/pulls/comments/94266935","pull_request_review_id":14798189,"id":94266935,"diff_hunk":"@@ -212,132 +212,6 @@ magic(\"123\") match {\n }\n ```\n \n-## Either in the small, Either in the large","path":"docs/src/main/tut/datatypes/either.md","position":null,"original_position":4,"commit_id":"5cafcdd7fb86ce4361cb36f4bb34b4e12a8c5599","original_commit_id":"95d96fa11149f7ea9cdbaed303b590491e4d54ab","user":{"login":"marcin-rzeznicki","id":3391348,"avatar_url":"https://avatars.githubusercontent.com/u/3391348?v=3","gravatar_id":"","url":"https://api.github.com/users/marcin-rzeznicki","html_url":"https://github.com/marcin-rzeznicki","followers_url":"https://api.github.com/users/marcin-rzeznicki/followers","following_url":"https://api.github.com/users/marcin-rzeznicki/following{/other_user}","gists_url":"https://api.github.com/users/marcin-rzeznicki/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-rzeznicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-rzeznicki/subscriptions","organizations_url":"https://api.github.com/users/marcin-rzeznicki/orgs","repos_url":"https://api.github.com/users/marcin-rzeznicki/repos","events_url":"https://api.github.com/users/marcin-rzeznicki/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-rzeznicki/received_events","type":"User","site_admin":false},"body":"@adelbertc I've come up with a new version of docs. Only some parts that had been no longer true in presence of variance were rewritten. Some other parts were rearranged. Please check if you like it. ( Since Contributors' Guide discourages squashing commits, it may be awkward to compare :-( )","created_at":"2016-12-31T01:22:30Z","updated_at":"2016-12-31T01:22:31Z","html_url":"https://github.com/typelevel/cats/pull/1506#discussion_r94266935","pull_request_url":"https://api.github.com/repos/typelevel/cats/pulls/1506","_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats/pulls/comments/94266935"},"html":{"href":"https://github.com/typelevel/cats/pull/1506#discussion_r94266935"},"pull_request":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1506"}}},"pull_request":{"url":"https://api.github.com/repos/typelevel/cats/pulls/1506","id":99649426,"html_url":"https://github.com/typelevel/cats/pull/1506","diff_url":"https://github.com/typelevel/cats/pull/1506.diff","patch_url":"https://github.com/typelevel/cats/pull/1506.patch","issue_url":"https://api.github.com/repos/typelevel/cats/issues/1506","number":1506,"state":"open","locked":false,"title":"Partially revert 4530d3aa93131ec28096968a3c903ed1016dbf1b. Add back v…","user":{"login":"marcin-rzeznicki","id":3391348,"avatar_url":"https://avatars.githubusercontent.com/u/3391348?v=3","gravatar_id":"","url":"https://api.github.com/users/marcin-rzeznicki","html_url":"https://github.com/marcin-rzeznicki","followers_url":"https://api.github.com/users/marcin-rzeznicki/followers","following_url":"https://api.github.com/users/marcin-rzeznicki/following{/other_user}","gists_url":"https://api.github.com/users/marcin-rzeznicki/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-rzeznicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-rzeznicki/subscriptions","organizations_url":"https://api.github.com/users/marcin-rzeznicki/orgs","repos_url":"https://api.github.com/users/marcin-rzeznicki/repos","events_url":"https://api.github.com/users/marcin-rzeznicki/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-rzeznicki/received_events","type":"User","site_admin":false},"body":"…ariance on methods in EitherT and Either syntax.\r\nCurrent signatures make it impossible to write, for example, for-comprehensions with 'lefts' not being of the same type. The following code does not compile with current signatures, but it compiles after the change (compiler is able to infer the common supertype):\r\n\r\n```scala\r\nsealed abstract class AppError\r\ncase object Error1 extends AppError\r\ncase object Error2 extends AppError\r\n\r\nval either1: Future[Either[Error1.type , String]] = Future.successful(Right(\"hi\"))\r\nval either2: Future[Either[Error2.type , String]] = Future.successful(Right(\"bye\"))\r\n\r\nfor {\r\n  s1 <- EitherT(either1)\r\n  s2 <- EitherT[Future, AppError, String](either2)\r\n} yield s1 ++ s2\r\n```\r\n\r\n> Error:(17, 7) type mismatch;\r\n found   : cats.data.EitherT[scala.concurrent.Future,Error2.type,String]\r\n required: cats.data.EitherT[scala.concurrent.Future, Error1.type,?]\r\n  s2 <- EitherT(either2)\r\n     ^\r\n\r\nThis change has been discussed on gitter with @travisbrown and @edmundnoble \r\n","created_at":"2016-12-29T12:16:58Z","updated_at":"2016-12-31T01:22:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5a7ddc503d5a9ecca104bd68accbf95eca23326","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typelevel/cats/pulls/1506/commits","review_comments_url":"https://api.github.com/repos/typelevel/cats/pulls/1506/comments","review_comment_url":"https://api.github.com/repos/typelevel/cats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typelevel/cats/issues/1506/comments","statuses_url":"https://api.github.com/repos/typelevel/cats/statuses/5cafcdd7fb86ce4361cb36f4bb34b4e12a8c5599","head":{"label":"marcin-rzeznicki:eitherT-either-syntax-variance","ref":"eitherT-either-syntax-variance","sha":"5cafcdd7fb86ce4361cb36f4bb34b4e12a8c5599","user":{"login":"marcin-rzeznicki","id":3391348,"avatar_url":"https://avatars.githubusercontent.com/u/3391348?v=3","gravatar_id":"","url":"https://api.github.com/users/marcin-rzeznicki","html_url":"https://github.com/marcin-rzeznicki","followers_url":"https://api.github.com/users/marcin-rzeznicki/followers","following_url":"https://api.github.com/users/marcin-rzeznicki/following{/other_user}","gists_url":"https://api.github.com/users/marcin-rzeznicki/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-rzeznicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-rzeznicki/subscriptions","organizations_url":"https://api.github.com/users/marcin-rzeznicki/orgs","repos_url":"https://api.github.com/users/marcin-rzeznicki/repos","events_url":"https://api.github.com/users/marcin-rzeznicki/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-rzeznicki/received_events","type":"User","site_admin":false},"repo":{"id":76404264,"name":"cats","full_name":"marcin-rzeznicki/cats","owner":{"login":"marcin-rzeznicki","id":3391348,"avatar_url":"https://avatars.githubusercontent.com/u/3391348?v=3","gravatar_id":"","url":"https://api.github.com/users/marcin-rzeznicki","html_url":"https://github.com/marcin-rzeznicki","followers_url":"https://api.github.com/users/marcin-rzeznicki/followers","following_url":"https://api.github.com/users/marcin-rzeznicki/following{/other_user}","gists_url":"https://api.github.com/users/marcin-rzeznicki/gists{/gist_id}","starred_url":"https://api.github.com/users/marcin-rzeznicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcin-rzeznicki/subscriptions","organizations_url":"https://api.github.com/users/marcin-rzeznicki/orgs","repos_url":"https://api.github.com/users/marcin-rzeznicki/repos","events_url":"https://api.github.com/users/marcin-rzeznicki/events{/privacy}","received_events_url":"https://api.github.com/users/marcin-rzeznicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcin-rzeznicki/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":true,"url":"https://api.github.com/repos/marcin-rzeznicki/cats","forks_url":"https://api.github.com/repos/marcin-rzeznicki/cats/forks","keys_url":"https://api.github.com/repos/marcin-rzeznicki/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcin-rzeznicki/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcin-rzeznicki/cats/teams","hooks_url":"https://api.github.com/repos/marcin-rzeznicki/cats/hooks","issue_events_url":"https://api.github.com/repos/marcin-rzeznicki/cats/issues/events{/number}","events_url":"https://api.github.com/repos/marcin-rzeznicki/cats/events","assignees_url":"https://api.github.com/repos/marcin-rzeznicki/cats/assignees{/user}","branches_url":"https://api.github.com/repos/marcin-rzeznicki/cats/branches{/branch}","tags_url":"https://api.github.com/repos/marcin-rzeznicki/cats/tags","blobs_url":"https://api.github.com/repos/marcin-rzeznicki/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcin-rzeznicki/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcin-rzeznicki/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcin-rzeznicki/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcin-rzeznicki/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/marcin-rzeznicki/cats/languages","stargazers_url":"https://api.github.com/repos/marcin-rzeznicki/cats/stargazers","contributors_url":"https://api.github.com/repos/marcin-rzeznicki/cats/contributors","subscribers_url":"https://api.github.com/repos/marcin-rzeznicki/cats/subscribers","subscription_url":"https://api.github.com/repos/marcin-rzeznicki/cats/subscription","commits_url":"https://api.github.com/repos/marcin-rzeznicki/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcin-rzeznicki/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcin-rzeznicki/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcin-rzeznicki/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcin-rzeznicki/cats/contents/{+path}","compare_url":"https://api.github.com/repos/marcin-rzeznicki/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcin-rzeznicki/cats/merges","archive_url":"https://api.github.com/repos/marcin-rzeznicki/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcin-rzeznicki/cats/downloads","issues_url":"https://api.github.com/repos/marcin-rzeznicki/cats/issues{/number}","pulls_url":"https://api.github.com/repos/marcin-rzeznicki/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/marcin-rzeznicki/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/marcin-rzeznicki/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcin-rzeznicki/cats/labels{/name}","releases_url":"https://api.github.com/repos/marcin-rzeznicki/cats/releases{/id}","deployments_url":"https://api.github.com/repos/marcin-rzeznicki/cats/deployments","created_at":"2016-12-13T22:36:19Z","updated_at":"2016-12-13T22:36:20Z","pushed_at":"2016-12-31T01:19:00Z","git_url":"git://github.com/marcin-rzeznicki/cats.git","ssh_url":"git@github.com:marcin-rzeznicki/cats.git","clone_url":"https://github.com/marcin-rzeznicki/cats.git","svn_url":"https://github.com/marcin-rzeznicki/cats","homepage":"http://typelevel.org/cats/","size":15218,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typelevel:master","ref":"master","sha":"974b84090ec1cae7e692589e5e8168f2f609f221","user":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars.githubusercontent.com/u/3731824?v=3","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"typelevel/cats","owner":{"login":"typelevel","id":3731824,"avatar_url":"https://avatars.githubusercontent.com/u/3731824?v=3","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typelevel/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":false,"url":"https://api.github.com/repos/typelevel/cats","forks_url":"https://api.github.com/repos/typelevel/cats/forks","keys_url":"https://api.github.com/repos/typelevel/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typelevel/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typelevel/cats/teams","hooks_url":"https://api.github.com/repos/typelevel/cats/hooks","issue_events_url":"https://api.github.com/repos/typelevel/cats/issues/events{/number}","events_url":"https://api.github.com/repos/typelevel/cats/events","assignees_url":"https://api.github.com/repos/typelevel/cats/assignees{/user}","branches_url":"https://api.github.com/repos/typelevel/cats/branches{/branch}","tags_url":"https://api.github.com/repos/typelevel/cats/tags","blobs_url":"https://api.github.com/repos/typelevel/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typelevel/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typelevel/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/typelevel/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typelevel/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/typelevel/cats/languages","stargazers_url":"https://api.github.com/repos/typelevel/cats/stargazers","contributors_url":"https://api.github.com/repos/typelevel/cats/contributors","subscribers_url":"https://api.github.com/repos/typelevel/cats/subscribers","subscription_url":"https://api.github.com/repos/typelevel/cats/subscription","commits_url":"https://api.github.com/repos/typelevel/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/typelevel/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/typelevel/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/typelevel/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/typelevel/cats/contents/{+path}","compare_url":"https://api.github.com/repos/typelevel/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typelevel/cats/merges","archive_url":"https://api.github.com/repos/typelevel/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typelevel/cats/downloads","issues_url":"https://api.github.com/repos/typelevel/cats/issues{/number}","pulls_url":"https://api.github.com/repos/typelevel/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/typelevel/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/typelevel/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typelevel/cats/labels{/name}","releases_url":"https://api.github.com/repos/typelevel/cats/releases{/id}","deployments_url":"https://api.github.com/repos/typelevel/cats/deployments","created_at":"2015-01-28T20:26:48Z","updated_at":"2016-12-30T16:15:17Z","pushed_at":"2016-12-31T01:19:02Z","git_url":"git://github.com/typelevel/cats.git","ssh_url":"git@github.com:typelevel/cats.git","clone_url":"https://github.com/typelevel/cats.git","svn_url":"https://github.com/typelevel/cats","homepage":"http://typelevel.org/cats/","size":15224,"stargazers_count":1491,"watchers_count":1491,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":341,"mirror_url":null,"open_issues_count":213,"forks":341,"open_issues":213,"watchers":1491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1506"},"html":{"href":"https://github.com/typelevel/cats/pull/1506"},"issue":{"href":"https://api.github.com/repos/typelevel/cats/issues/1506"},"comments":{"href":"https://api.github.com/repos/typelevel/cats/issues/1506/comments"},"review_comments":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1506/comments"},"review_comment":{"href":"https://api.github.com/repos/typelevel/cats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typelevel/cats/pulls/1506/commits"},"statuses":{"href":"https://api.github.com/repos/typelevel/cats/statuses/5cafcdd7fb86ce4361cb36f4bb34b4e12a8c5599"}}}}
{"actor":{"display_login":"marcin-rzeznicki"}}