{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/urbn/URBNValidator/pulls/16","id":83670739,"html_url":"https://github.com/urbn/URBNValidator/pull/16","diff_url":"https://github.com/urbn/URBNValidator/pull/16.diff","patch_url":"https://github.com/urbn/URBNValidator/pull/16.patch","issue_url":"https://api.github.com/repos/urbn/URBNValidator/issues/16","number":16,"state":"closed","locked":false,"title":"[FPMA-1869] is required localzation replacement blowing up","user":{"login":"ryang1428","id":3100539,"avatar_url":"https://avatars.githubusercontent.com/u/3100539?v=3","gravatar_id":"","url":"https://api.github.com/users/ryang1428","html_url":"https://github.com/ryang1428","followers_url":"https://api.github.com/users/ryang1428/followers","following_url":"https://api.github.com/users/ryang1428/following{/other_user}","gists_url":"https://api.github.com/users/ryang1428/gists{/gist_id}","starred_url":"https://api.github.com/users/ryang1428/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryang1428/subscriptions","organizations_url":"https://api.github.com/users/ryang1428/orgs","repos_url":"https://api.github.com/users/ryang1428/repos","events_url":"https://api.github.com/users/ryang1428/events{/privacy}","received_events_url":"https://api.github.com/users/ryang1428/received_events","type":"User","site_admin":false},"body":"- When using Chinese characters in the \"is required\" localization, validator blows up when creating a NSRange using `s.lengthOfBytesUsingEncoding` to fill out the localization. Using `length - 1` seems to do the trick as fine and does not blow up with Chinese characters.","created_at":"2016-09-01T17:06:08Z","updated_at":"2016-09-07T12:02:47Z","closed_at":"2016-09-07T12:02:47Z","merged_at":"2016-09-07T12:02:47Z","merge_commit_sha":"e5529309a374056b1b9c2c4a2d11912595569343","assignee":{"login":"jgrandelli","id":1181839,"avatar_url":"https://avatars.githubusercontent.com/u/1181839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrandelli","html_url":"https://github.com/jgrandelli","followers_url":"https://api.github.com/users/jgrandelli/followers","following_url":"https://api.github.com/users/jgrandelli/following{/other_user}","gists_url":"https://api.github.com/users/jgrandelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandelli/subscriptions","organizations_url":"https://api.github.com/users/jgrandelli/orgs","repos_url":"https://api.github.com/users/jgrandelli/repos","events_url":"https://api.github.com/users/jgrandelli/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandelli/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgrandelli","id":1181839,"avatar_url":"https://avatars.githubusercontent.com/u/1181839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrandelli","html_url":"https://github.com/jgrandelli","followers_url":"https://api.github.com/users/jgrandelli/followers","following_url":"https://api.github.com/users/jgrandelli/following{/other_user}","gists_url":"https://api.github.com/users/jgrandelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandelli/subscriptions","organizations_url":"https://api.github.com/users/jgrandelli/orgs","repos_url":"https://api.github.com/users/jgrandelli/repos","events_url":"https://api.github.com/users/jgrandelli/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandelli/received_events","type":"User","site_admin":false},{"login":"ndis1","id":2287679,"avatar_url":"https://avatars.githubusercontent.com/u/2287679?v=3","gravatar_id":"","url":"https://api.github.com/users/ndis1","html_url":"https://github.com/ndis1","followers_url":"https://api.github.com/users/ndis1/followers","following_url":"https://api.github.com/users/ndis1/following{/other_user}","gists_url":"https://api.github.com/users/ndis1/gists{/gist_id}","starred_url":"https://api.github.com/users/ndis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndis1/subscriptions","organizations_url":"https://api.github.com/users/ndis1/orgs","repos_url":"https://api.github.com/users/ndis1/repos","events_url":"https://api.github.com/users/ndis1/events{/privacy}","received_events_url":"https://api.github.com/users/ndis1/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/urbn/URBNValidator/pulls/16/commits","review_comments_url":"https://api.github.com/repos/urbn/URBNValidator/pulls/16/comments","review_comment_url":"https://api.github.com/repos/urbn/URBNValidator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urbn/URBNValidator/issues/16/comments","statuses_url":"https://api.github.com/repos/urbn/URBNValidator/statuses/6db1bb644cb88444b4c0c6c6753bb2da93e562ba","head":{"label":"urbn:FPMA-1869","ref":"FPMA-1869","sha":"6db1bb644cb88444b4c0c6c6753bb2da93e562ba","user":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"repo":{"id":46370700,"name":"URBNValidator","full_name":"urbn/URBNValidator","owner":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbn/URBNValidator","description":"","fork":false,"url":"https://api.github.com/repos/urbn/URBNValidator","forks_url":"https://api.github.com/repos/urbn/URBNValidator/forks","keys_url":"https://api.github.com/repos/urbn/URBNValidator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbn/URBNValidator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbn/URBNValidator/teams","hooks_url":"https://api.github.com/repos/urbn/URBNValidator/hooks","issue_events_url":"https://api.github.com/repos/urbn/URBNValidator/issues/events{/number}","events_url":"https://api.github.com/repos/urbn/URBNValidator/events","assignees_url":"https://api.github.com/repos/urbn/URBNValidator/assignees{/user}","branches_url":"https://api.github.com/repos/urbn/URBNValidator/branches{/branch}","tags_url":"https://api.github.com/repos/urbn/URBNValidator/tags","blobs_url":"https://api.github.com/repos/urbn/URBNValidator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbn/URBNValidator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbn/URBNValidator/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbn/URBNValidator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbn/URBNValidator/statuses/{sha}","languages_url":"https://api.github.com/repos/urbn/URBNValidator/languages","stargazers_url":"https://api.github.com/repos/urbn/URBNValidator/stargazers","contributors_url":"https://api.github.com/repos/urbn/URBNValidator/contributors","subscribers_url":"https://api.github.com/repos/urbn/URBNValidator/subscribers","subscription_url":"https://api.github.com/repos/urbn/URBNValidator/subscription","commits_url":"https://api.github.com/repos/urbn/URBNValidator/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbn/URBNValidator/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbn/URBNValidator/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbn/URBNValidator/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbn/URBNValidator/contents/{+path}","compare_url":"https://api.github.com/repos/urbn/URBNValidator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbn/URBNValidator/merges","archive_url":"https://api.github.com/repos/urbn/URBNValidator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbn/URBNValidator/downloads","issues_url":"https://api.github.com/repos/urbn/URBNValidator/issues{/number}","pulls_url":"https://api.github.com/repos/urbn/URBNValidator/pulls{/number}","milestones_url":"https://api.github.com/repos/urbn/URBNValidator/milestones{/number}","notifications_url":"https://api.github.com/repos/urbn/URBNValidator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbn/URBNValidator/labels{/name}","releases_url":"https://api.github.com/repos/urbn/URBNValidator/releases{/id}","deployments_url":"https://api.github.com/repos/urbn/URBNValidator/deployments","created_at":"2015-11-17T19:38:18Z","updated_at":"2016-03-16T20:54:09Z","pushed_at":"2016-09-07T12:02:47Z","git_url":"git://github.com/urbn/URBNValidator.git","ssh_url":"git@github.com:urbn/URBNValidator.git","clone_url":"https://github.com/urbn/URBNValidator.git","svn_url":"https://github.com/urbn/URBNValidator","homepage":null,"size":141,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"urbn:master","ref":"master","sha":"3b1569066b665208fc93b659834b18799f73b2b2","user":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"repo":{"id":46370700,"name":"URBNValidator","full_name":"urbn/URBNValidator","owner":{"login":"urbn","id":4368103,"avatar_url":"https://avatars.githubusercontent.com/u/4368103?v=3","gravatar_id":"","url":"https://api.github.com/users/urbn","html_url":"https://github.com/urbn","followers_url":"https://api.github.com/users/urbn/followers","following_url":"https://api.github.com/users/urbn/following{/other_user}","gists_url":"https://api.github.com/users/urbn/gists{/gist_id}","starred_url":"https://api.github.com/users/urbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbn/subscriptions","organizations_url":"https://api.github.com/users/urbn/orgs","repos_url":"https://api.github.com/users/urbn/repos","events_url":"https://api.github.com/users/urbn/events{/privacy}","received_events_url":"https://api.github.com/users/urbn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbn/URBNValidator","description":"","fork":false,"url":"https://api.github.com/repos/urbn/URBNValidator","forks_url":"https://api.github.com/repos/urbn/URBNValidator/forks","keys_url":"https://api.github.com/repos/urbn/URBNValidator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbn/URBNValidator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbn/URBNValidator/teams","hooks_url":"https://api.github.com/repos/urbn/URBNValidator/hooks","issue_events_url":"https://api.github.com/repos/urbn/URBNValidator/issues/events{/number}","events_url":"https://api.github.com/repos/urbn/URBNValidator/events","assignees_url":"https://api.github.com/repos/urbn/URBNValidator/assignees{/user}","branches_url":"https://api.github.com/repos/urbn/URBNValidator/branches{/branch}","tags_url":"https://api.github.com/repos/urbn/URBNValidator/tags","blobs_url":"https://api.github.com/repos/urbn/URBNValidator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbn/URBNValidator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbn/URBNValidator/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbn/URBNValidator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbn/URBNValidator/statuses/{sha}","languages_url":"https://api.github.com/repos/urbn/URBNValidator/languages","stargazers_url":"https://api.github.com/repos/urbn/URBNValidator/stargazers","contributors_url":"https://api.github.com/repos/urbn/URBNValidator/contributors","subscribers_url":"https://api.github.com/repos/urbn/URBNValidator/subscribers","subscription_url":"https://api.github.com/repos/urbn/URBNValidator/subscription","commits_url":"https://api.github.com/repos/urbn/URBNValidator/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbn/URBNValidator/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbn/URBNValidator/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbn/URBNValidator/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbn/URBNValidator/contents/{+path}","compare_url":"https://api.github.com/repos/urbn/URBNValidator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbn/URBNValidator/merges","archive_url":"https://api.github.com/repos/urbn/URBNValidator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbn/URBNValidator/downloads","issues_url":"https://api.github.com/repos/urbn/URBNValidator/issues{/number}","pulls_url":"https://api.github.com/repos/urbn/URBNValidator/pulls{/number}","milestones_url":"https://api.github.com/repos/urbn/URBNValidator/milestones{/number}","notifications_url":"https://api.github.com/repos/urbn/URBNValidator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbn/URBNValidator/labels{/name}","releases_url":"https://api.github.com/repos/urbn/URBNValidator/releases{/id}","deployments_url":"https://api.github.com/repos/urbn/URBNValidator/deployments","created_at":"2015-11-17T19:38:18Z","updated_at":"2016-03-16T20:54:09Z","pushed_at":"2016-09-07T12:02:47Z","git_url":"git://github.com/urbn/URBNValidator.git","ssh_url":"git@github.com:urbn/URBNValidator.git","clone_url":"https://github.com/urbn/URBNValidator.git","svn_url":"https://github.com/urbn/URBNValidator","homepage":null,"size":141,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urbn/URBNValidator/pulls/16"},"html":{"href":"https://github.com/urbn/URBNValidator/pull/16"},"issue":{"href":"https://api.github.com/repos/urbn/URBNValidator/issues/16"},"comments":{"href":"https://api.github.com/repos/urbn/URBNValidator/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/urbn/URBNValidator/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/urbn/URBNValidator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urbn/URBNValidator/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/urbn/URBNValidator/statuses/6db1bb644cb88444b4c0c6c6753bb2da93e562ba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jgrandelli","id":1181839,"avatar_url":"https://avatars.githubusercontent.com/u/1181839?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrandelli","html_url":"https://github.com/jgrandelli","followers_url":"https://api.github.com/users/jgrandelli/followers","following_url":"https://api.github.com/users/jgrandelli/following{/other_user}","gists_url":"https://api.github.com/users/jgrandelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandelli/subscriptions","organizations_url":"https://api.github.com/users/jgrandelli/orgs","repos_url":"https://api.github.com/users/jgrandelli/repos","events_url":"https://api.github.com/users/jgrandelli/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandelli/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":48,"deletions":20,"changed_files":7}}
{"actor":{"display_login":"jgrandelli"}}