{"action":"created","comment":{"url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/comments/80397597","id":80397597,"diff_hunk":"@@ -0,0 +1,38 @@\n+class Arena {\n+  constructor(name) {\n+    this.name = name.charAt(0).toUpperCase() + name.slice(1);\n+    this.gladiators = [];\n+  }\n+  addGladiator(gladiator) {\n+    if (this.gladiators.length < 2) {\n+      this.gladiators.push(gladiator);\n+    } else {\n+      console.error('There are already 2 warriors in the arena');\n+    }\n+  }\n+\n+  fight() {\n+    let glad1 = this.gladiators[0];\n+    let glad2 = this.gladiators[1];\n+     if (glad1.weapon == ('Trident' || 'Club') && glad2.weapon == ('Spear' || 'Club')) {\n+      this.gladiators.splice(1, 1);\n+    }\n+    else if (glad1.weapon == ('Spear' || 'Trident') && glad2.weapon == ('Club' ||' Trident')) {\n+      this.gladiators.splice(0, 1);\n+    }\n+    else if (glad1.weapon == ('Club' || 'Spear')&& glad2.weapon == 'Trident' || 'Spear' ) {\n+      this.gladiators.splice(1, 1);\n+    }","path":"arena.js","position":25,"original_position":25,"commit_id":"bf7a6cbd7f2beb846b4ffd0869881f833816d10a","original_commit_id":"bf7a6cbd7f2beb846b4ffd0869881f833816d10a","user":{"login":"nolds9","id":10698044,"avatar_url":"https://avatars.githubusercontent.com/u/10698044?v=3","gravatar_id":"","url":"https://api.github.com/users/nolds9","html_url":"https://github.com/nolds9","followers_url":"https://api.github.com/users/nolds9/followers","following_url":"https://api.github.com/users/nolds9/following{/other_user}","gists_url":"https://api.github.com/users/nolds9/gists{/gist_id}","starred_url":"https://api.github.com/users/nolds9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolds9/subscriptions","organizations_url":"https://api.github.com/users/nolds9/orgs","repos_url":"https://api.github.com/users/nolds9/repos","events_url":"https://api.github.com/users/nolds9/events{/privacy}","received_events_url":"https://api.github.com/users/nolds9/received_events","type":"User","site_admin":false},"body":"this is great! But can you think of any way to abstract the winning conditions at all so you do not have as many conditionals?","created_at":"2016-09-26T01:13:57Z","updated_at":"2016-09-26T01:13:57Z","html_url":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10#discussion_r80397597","pull_request_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/comments/80397597"},"html":{"href":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10#discussion_r80397597"},"pull_request":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10","id":86556722,"html_url":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10","diff_url":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10.diff","patch_url":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10.patch","issue_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/10","number":10,"state":"open","locked":false,"title":"Mariana Lungu / Js-gladiator","user":{"login":"marlungu","id":18635698,"avatar_url":"https://avatars.githubusercontent.com/u/18635698?v=3","gravatar_id":"","url":"https://api.github.com/users/marlungu","html_url":"https://github.com/marlungu","followers_url":"https://api.github.com/users/marlungu/followers","following_url":"https://api.github.com/users/marlungu/following{/other_user}","gists_url":"https://api.github.com/users/marlungu/gists{/gist_id}","starred_url":"https://api.github.com/users/marlungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marlungu/subscriptions","organizations_url":"https://api.github.com/users/marlungu/orgs","repos_url":"https://api.github.com/users/marlungu/repos","events_url":"https://api.github.com/users/marlungu/events{/privacy}","received_events_url":"https://api.github.com/users/marlungu/received_events","type":"User","site_admin":false},"body":"comfort: 4;\r\ncompleteness: 5;","created_at":"2016-09-23T18:11:04Z","updated_at":"2016-09-26T01:13:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cacf3ea780516bf181c12c375d5e184ff9cb8ff3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/10/comments","statuses_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/statuses/bf7a6cbd7f2beb846b4ffd0869881f833816d10a","head":{"label":"marlungu:master","ref":"master","sha":"bf7a6cbd7f2beb846b4ffd0869881f833816d10a","user":{"login":"marlungu","id":18635698,"avatar_url":"https://avatars.githubusercontent.com/u/18635698?v=3","gravatar_id":"","url":"https://api.github.com/users/marlungu","html_url":"https://github.com/marlungu","followers_url":"https://api.github.com/users/marlungu/followers","following_url":"https://api.github.com/users/marlungu/following{/other_user}","gists_url":"https://api.github.com/users/marlungu/gists{/gist_id}","starred_url":"https://api.github.com/users/marlungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marlungu/subscriptions","organizations_url":"https://api.github.com/users/marlungu/orgs","repos_url":"https://api.github.com/users/marlungu/repos","events_url":"https://api.github.com/users/marlungu/events{/privacy}","received_events_url":"https://api.github.com/users/marlungu/received_events","type":"User","site_admin":false},"repo":{"id":69031021,"name":"js-gladiator","full_name":"marlungu/js-gladiator","owner":{"login":"marlungu","id":18635698,"avatar_url":"https://avatars.githubusercontent.com/u/18635698?v=3","gravatar_id":"","url":"https://api.github.com/users/marlungu","html_url":"https://github.com/marlungu","followers_url":"https://api.github.com/users/marlungu/followers","following_url":"https://api.github.com/users/marlungu/following{/other_user}","gists_url":"https://api.github.com/users/marlungu/gists{/gist_id}","starred_url":"https://api.github.com/users/marlungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marlungu/subscriptions","organizations_url":"https://api.github.com/users/marlungu/orgs","repos_url":"https://api.github.com/users/marlungu/repos","events_url":"https://api.github.com/users/marlungu/events{/privacy}","received_events_url":"https://api.github.com/users/marlungu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marlungu/js-gladiator","description":"[OOJS, ES6, Classes, OOP]","fork":true,"url":"https://api.github.com/repos/marlungu/js-gladiator","forks_url":"https://api.github.com/repos/marlungu/js-gladiator/forks","keys_url":"https://api.github.com/repos/marlungu/js-gladiator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marlungu/js-gladiator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marlungu/js-gladiator/teams","hooks_url":"https://api.github.com/repos/marlungu/js-gladiator/hooks","issue_events_url":"https://api.github.com/repos/marlungu/js-gladiator/issues/events{/number}","events_url":"https://api.github.com/repos/marlungu/js-gladiator/events","assignees_url":"https://api.github.com/repos/marlungu/js-gladiator/assignees{/user}","branches_url":"https://api.github.com/repos/marlungu/js-gladiator/branches{/branch}","tags_url":"https://api.github.com/repos/marlungu/js-gladiator/tags","blobs_url":"https://api.github.com/repos/marlungu/js-gladiator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marlungu/js-gladiator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marlungu/js-gladiator/git/refs{/sha}","trees_url":"https://api.github.com/repos/marlungu/js-gladiator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marlungu/js-gladiator/statuses/{sha}","languages_url":"https://api.github.com/repos/marlungu/js-gladiator/languages","stargazers_url":"https://api.github.com/repos/marlungu/js-gladiator/stargazers","contributors_url":"https://api.github.com/repos/marlungu/js-gladiator/contributors","subscribers_url":"https://api.github.com/repos/marlungu/js-gladiator/subscribers","subscription_url":"https://api.github.com/repos/marlungu/js-gladiator/subscription","commits_url":"https://api.github.com/repos/marlungu/js-gladiator/commits{/sha}","git_commits_url":"https://api.github.com/repos/marlungu/js-gladiator/git/commits{/sha}","comments_url":"https://api.github.com/repos/marlungu/js-gladiator/comments{/number}","issue_comment_url":"https://api.github.com/repos/marlungu/js-gladiator/issues/comments{/number}","contents_url":"https://api.github.com/repos/marlungu/js-gladiator/contents/{+path}","compare_url":"https://api.github.com/repos/marlungu/js-gladiator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marlungu/js-gladiator/merges","archive_url":"https://api.github.com/repos/marlungu/js-gladiator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marlungu/js-gladiator/downloads","issues_url":"https://api.github.com/repos/marlungu/js-gladiator/issues{/number}","pulls_url":"https://api.github.com/repos/marlungu/js-gladiator/pulls{/number}","milestones_url":"https://api.github.com/repos/marlungu/js-gladiator/milestones{/number}","notifications_url":"https://api.github.com/repos/marlungu/js-gladiator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marlungu/js-gladiator/labels{/name}","releases_url":"https://api.github.com/repos/marlungu/js-gladiator/releases{/id}","deployments_url":"https://api.github.com/repos/marlungu/js-gladiator/deployments","created_at":"2016-09-23T14:12:48Z","updated_at":"2016-09-23T18:09:48Z","pushed_at":"2016-09-23T18:09:47Z","git_url":"git://github.com/marlungu/js-gladiator.git","ssh_url":"git@github.com:marlungu/js-gladiator.git","clone_url":"https://github.com/marlungu/js-gladiator.git","svn_url":"https://github.com/marlungu/js-gladiator","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga-wdi-exercises:master","ref":"master","sha":"e4632dbaf6307ddeaea65b037981d1b88411882d","user":{"login":"ga-wdi-exercises","id":16946328,"avatar_url":"https://avatars.githubusercontent.com/u/16946328?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-exercises","html_url":"https://github.com/ga-wdi-exercises","followers_url":"https://api.github.com/users/ga-wdi-exercises/followers","following_url":"https://api.github.com/users/ga-wdi-exercises/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-exercises/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-exercises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-exercises/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-exercises/orgs","repos_url":"https://api.github.com/users/ga-wdi-exercises/repos","events_url":"https://api.github.com/users/ga-wdi-exercises/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-exercises/received_events","type":"Organization","site_admin":false},"repo":{"id":68982244,"name":"js-gladiator","full_name":"ga-wdi-exercises/js-gladiator","owner":{"login":"ga-wdi-exercises","id":16946328,"avatar_url":"https://avatars.githubusercontent.com/u/16946328?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-exercises","html_url":"https://github.com/ga-wdi-exercises","followers_url":"https://api.github.com/users/ga-wdi-exercises/followers","following_url":"https://api.github.com/users/ga-wdi-exercises/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-exercises/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-exercises/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-exercises/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-exercises/orgs","repos_url":"https://api.github.com/users/ga-wdi-exercises/repos","events_url":"https://api.github.com/users/ga-wdi-exercises/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-exercises/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga-wdi-exercises/js-gladiator","description":"[OOJS, ES6, Classes, OOP]","fork":false,"url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator","forks_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/forks","keys_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/teams","hooks_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/hooks","issue_events_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/events{/number}","events_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/events","assignees_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/assignees{/user}","branches_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/branches{/branch}","tags_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/tags","blobs_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/statuses/{sha}","languages_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/languages","stargazers_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/stargazers","contributors_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/contributors","subscribers_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/subscribers","subscription_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/subscription","commits_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/contents/{+path}","compare_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/merges","archive_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/downloads","issues_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues{/number}","pulls_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls{/number}","milestones_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/milestones{/number}","notifications_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/labels{/name}","releases_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/releases{/id}","deployments_url":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/deployments","created_at":"2016-09-23T02:46:39Z","updated_at":"2016-09-23T02:47:12Z","pushed_at":"2016-09-23T18:33:27Z","git_url":"git://github.com/ga-wdi-exercises/js-gladiator.git","ssh_url":"git@github.com:ga-wdi-exercises/js-gladiator.git","clone_url":"https://github.com/ga-wdi-exercises/js-gladiator.git","svn_url":"https://github.com/ga-wdi-exercises/js-gladiator","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":20,"forks":23,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10"},"html":{"href":"https://github.com/ga-wdi-exercises/js-gladiator/pull/10"},"issue":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/10"},"comments":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/ga-wdi-exercises/js-gladiator/statuses/bf7a6cbd7f2beb846b4ffd0869881f833816d10a"}}}}
{"actor":{"display_login":"nolds9"}}