{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/sequins/issues/39","repository_url":"https://api.github.com/repos/stripe/sequins","labels_url":"https://api.github.com/repos/stripe/sequins/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/stripe/sequins/issues/39/comments","events_url":"https://api.github.com/repos/stripe/sequins/issues/39/events","html_url":"https://github.com/stripe/sequins/pull/39","id":155950206,"number":39,"title":"Add some zkWatcher tests, and fix some minor bugs","user":{"login":"colinmarc","id":821775,"avatar_url":"https://avatars.githubusercontent.com/u/821775?v=3","gravatar_id":"","url":"https://api.github.com/users/colinmarc","html_url":"https://github.com/colinmarc","followers_url":"https://api.github.com/users/colinmarc/followers","following_url":"https://api.github.com/users/colinmarc/following{/other_user}","gists_url":"https://api.github.com/users/colinmarc/gists{/gist_id}","starred_url":"https://api.github.com/users/colinmarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinmarc/subscriptions","organizations_url":"https://api.github.com/users/colinmarc/orgs","repos_url":"https://api.github.com/users/colinmarc/repos","events_url":"https://api.github.com/users/colinmarc/events{/privacy}","received_events_url":"https://api.github.com/users/colinmarc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"forklady42","id":1852147,"avatar_url":"https://avatars.githubusercontent.com/u/1852147?v=3","gravatar_id":"","url":"https://api.github.com/users/forklady42","html_url":"https://github.com/forklady42","followers_url":"https://api.github.com/users/forklady42/followers","following_url":"https://api.github.com/users/forklady42/following{/other_user}","gists_url":"https://api.github.com/users/forklady42/gists{/gist_id}","starred_url":"https://api.github.com/users/forklady42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forklady42/subscriptions","organizations_url":"https://api.github.com/users/forklady42/orgs","repos_url":"https://api.github.com/users/forklady42/repos","events_url":"https://api.github.com/users/forklady42/events{/privacy}","received_events_url":"https://api.github.com/users/forklady42/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-20T12:16:22Z","updated_at":"2016-05-20T16:10:39Z","closed_at":"2016-05-20T16:10:24Z","pull_request":{"url":"https://api.github.com/repos/stripe/sequins/pulls/39","html_url":"https://github.com/stripe/sequins/pull/39","diff_url":"https://github.com/stripe/sequins/pull/39.diff","patch_url":"https://github.com/stripe/sequins/pull/39.patch"},"body":"The new tests caught two (minor) bugs in zkWatcher:\r\n\r\n - `break` inside a switch statement just breaks out of the switch,\r\n   so we weren't properly closing watches on shutdown\r\n\r\n - There was a missing `return` inside `hookWatchChildren` which was\r\n   causing the watch to 'leak'; to continue inside the loop even\r\n   when the connection to zookeeper closed. In some very specific\r\n   conditions, this could cause zkWatcher to infinitely reconnect.\r\n\r\n - We don't need to throw away the connection when we get `STATE_CONNECTING`\r\n\r\n - Access to `w.conn` wasn't synchronized, which lead to a possible (but extremely unlikely) data race"},"comment":{"url":"https://api.github.com/repos/stripe/sequins/issues/comments/220649216","html_url":"https://github.com/stripe/sequins/pull/39#issuecomment-220649216","issue_url":"https://api.github.com/repos/stripe/sequins/issues/39","id":220649216,"user":{"login":"colinmarc","id":821775,"avatar_url":"https://avatars.githubusercontent.com/u/821775?v=3","gravatar_id":"","url":"https://api.github.com/users/colinmarc","html_url":"https://github.com/colinmarc","followers_url":"https://api.github.com/users/colinmarc/followers","following_url":"https://api.github.com/users/colinmarc/following{/other_user}","gists_url":"https://api.github.com/users/colinmarc/gists{/gist_id}","starred_url":"https://api.github.com/users/colinmarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinmarc/subscriptions","organizations_url":"https://api.github.com/users/colinmarc/orgs","repos_url":"https://api.github.com/users/colinmarc/repos","events_url":"https://api.github.com/users/colinmarc/events{/privacy}","received_events_url":"https://api.github.com/users/colinmarc/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T16:10:39Z","updated_at":"2016-05-20T16:10:39Z","body":"(I just changed the commit message on that last commit)"}}
{"actor":{"display_login":"colinmarc"}}