{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/3998","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/3998/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3998/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/3998/events","html_url":"https://github.com/kripken/emscripten/pull/3998","id":124641675,"number":3998,"title":"getpeername implementation","user":{"login":"TBBle","id":138397,"avatar_url":"https://avatars.githubusercontent.com/u/138397?v=3","gravatar_id":"","url":"https://api.github.com/users/TBBle","html_url":"https://github.com/TBBle","followers_url":"https://api.github.com/users/TBBle/followers","following_url":"https://api.github.com/users/TBBle/following{/other_user}","gists_url":"https://api.github.com/users/TBBle/gists{/gist_id}","starred_url":"https://api.github.com/users/TBBle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBBle/subscriptions","organizations_url":"https://api.github.com/users/TBBle/orgs","repos_url":"https://api.github.com/users/TBBle/repos","events_url":"https://api.github.com/users/TBBle/events{/privacy}","received_events_url":"https://api.github.com/users/TBBle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-03T10:24:24Z","updated_at":"2016-01-03T19:50:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/3998","html_url":"https://github.com/kripken/emscripten/pull/3998","diff_url":"https://github.com/kripken/emscripten/pull/3998.diff","patch_url":"https://github.com/kripken/emscripten/pull/3998.patch"},"body":"This pulls in the fixes for issues described in #3997\r\nThe following tests pass:\r\n* sockets.test_nodejs_sockets_echo\r\n* sockets.test_getsockname_null\r\n* *new* sockets.test_getpeername_null\r\n\r\nThe latter two tests should probably be renamed from 'null' to 'unconnected' as that is what they are actually testing. But I'm not sure if renaming tests would cause issues, so I haven't done so.\r\n\r\nI'm developing on an SSH connection to a remove Linux machine, so I didn't seem to be able to run\r\n* sockets.test_sockets_echo\r\n* sockets.test_sockets_echo_bigdata\r\n\r\nas they appear to depend on access to a local web browser?\r\n\r\nI have the default tests ran with 11 failures, but the above tests are the only ones that reference getsockname. Hopefully no one is relying on the behaviour of `DNS.lookup_name( '0.0.0.0' )` not returning `'0.0.0.0'`."},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/168534798","html_url":"https://github.com/kripken/emscripten/pull/3998#issuecomment-168534798","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3998","id":168534798,"user":{"login":"TBBle","id":138397,"avatar_url":"https://avatars.githubusercontent.com/u/138397?v=3","gravatar_id":"","url":"https://api.github.com/users/TBBle","html_url":"https://github.com/TBBle","followers_url":"https://api.github.com/users/TBBle/followers","following_url":"https://api.github.com/users/TBBle/following{/other_user}","gists_url":"https://api.github.com/users/TBBle/gists{/gist_id}","starred_url":"https://api.github.com/users/TBBle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBBle/subscriptions","organizations_url":"https://api.github.com/users/TBBle/orgs","repos_url":"https://api.github.com/users/TBBle/repos","events_url":"https://api.github.com/users/TBBle/events{/privacy}","received_events_url":"https://api.github.com/users/TBBle/received_events","type":"User","site_admin":false},"created_at":"2016-01-03T19:50:13Z","updated_at":"2016-01-03T19:50:13Z","body":"@NWilson: Does this help?\r\n\r\n```\r\n$ locale |grep LC_TIME\r\nLC_TIME=\"en_US.UTF-8\"\r\n```\r\n\r\n```\r\n$ timedatectl status\r\n      Local time: Mon 2016-01-04 06:47:48 AEDT\r\n  Universal time: Sun 2016-01-03 19:47:48 UTC\r\n        RTC time: Sun 2016-01-03 19:47:48\r\n       Time zone: Australia/Sydney (AEDT, +1100)\r\n     NTP enabled: no\r\nNTP synchronized: yes\r\n RTC in local TZ: no\r\n      DST active: yes\r\n Last DST change: DST began at\r\n                  Sun 2015-10-04 01:59:59 AEST\r\n                  Sun 2015-10-04 03:00:00 AEDT\r\n Next DST change: DST ends (the clock jumps one hour backwards) at\r\n                  Sun 2016-04-03 02:59:59 AEDT\r\n                  Sun 2016-04-03 02:00:00 AEST\r\n```\r\n\r\nI wasn't testing with a browser, it was running the nodejs tests:\r\n```\r\n$ python tests/runner.py test_time\r\nWARNING:root:use EM_ALL_ENGINES=1 in the env to run against all JS engines, which is slower but provides more coverage\r\ntest_time (test_core.default) ... (checking sanity from test runner)\r\nINFO:root:(Emscripten: Running sanity checks)\r\nWARNING:root:generating system library: libc.bc...\r\nWARNING:root:                                     ok\r\nWARNING:root:generating system library: dlmalloc.bc...\r\nWARNING:root:                                         ok\r\n(test did not pass in JS engine: ['/home/paulh/emsdk/emsdk_portable/node/4.1.1_64bit/bin/node'])\r\nERROR\r\n```"}}