{"action":"created","issue":{"url":"https://api.github.com/repos/thenativeweb/roboter/issues/22","repository_url":"https://api.github.com/repos/thenativeweb/roboter","labels_url":"https://api.github.com/repos/thenativeweb/roboter/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/thenativeweb/roboter/issues/22/comments","events_url":"https://api.github.com/repos/thenativeweb/roboter/issues/22/events","html_url":"https://github.com/thenativeweb/roboter/issues/22","id":171586166,"number":22,"title":"make bot publish stop on outdated and unused-dependencies","user":{"login":"stefanheine","id":19835327,"avatar_url":"https://avatars.githubusercontent.com/u/19835327?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanheine","html_url":"https://github.com/stefanheine","followers_url":"https://api.github.com/users/stefanheine/followers","following_url":"https://api.github.com/users/stefanheine/following{/other_user}","gists_url":"https://api.github.com/users/stefanheine/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanheine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanheine/subscriptions","organizations_url":"https://api.github.com/users/stefanheine/orgs","repos_url":"https://api.github.com/users/stefanheine/repos","events_url":"https://api.github.com/users/stefanheine/events{/privacy}","received_events_url":"https://api.github.com/users/stefanheine/received_events","type":"User","site_admin":false},"labels":[{"id":426251729,"url":"https://api.github.com/repos/thenativeweb/roboter/labels/Feature","name":"Feature","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-17T06:46:31Z","updated_at":"2016-11-15T10:20:31Z","closed_at":"2016-11-15T10:20:31Z","body":"bot publish runs the analyze tasks, reporting outdated and unused-dependencies.\nI wish bot publish would stop if any issues are found in these categories, and there was a flag to publish in spite of those issues. so by default the publish would only succeed on no issues.\n"},"comment":{"url":"https://api.github.com/repos/thenativeweb/roboter/issues/comments/260603158","html_url":"https://github.com/thenativeweb/roboter/issues/22#issuecomment-260603158","issue_url":"https://api.github.com/repos/thenativeweb/roboter/issues/22","id":260603158,"user":{"login":"goloroden","id":906327,"avatar_url":"https://avatars.githubusercontent.com/u/906327?v=3","gravatar_id":"","url":"https://api.github.com/users/goloroden","html_url":"https://github.com/goloroden","followers_url":"https://api.github.com/users/goloroden/followers","following_url":"https://api.github.com/users/goloroden/following{/other_user}","gists_url":"https://api.github.com/users/goloroden/gists{/gist_id}","starred_url":"https://api.github.com/users/goloroden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goloroden/subscriptions","organizations_url":"https://api.github.com/users/goloroden/orgs","repos_url":"https://api.github.com/users/goloroden/repos","events_url":"https://api.github.com/users/goloroden/events{/privacy}","received_events_url":"https://api.github.com/users/goloroden/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T10:20:31Z","updated_at":"2016-11-15T10:20:31Z","body":"Okay, let's split this issue into three separate tasks:\r\n\r\n### Stop publishing when `analyze` fails\r\n\r\nThis is already the default behavior. You can not publish anything if it fails code analysis and / or tests. So there is no need to change anything here.\r\n\r\n### Stop publishing when `outdated` fails\r\n\r\nThis does not make sense, IMHO. It does not break anything, and it does not do any harm. It's just that you do not use the latest versions. Hence it is a warning. This will stay this way, especially because it happens from time to time that you can not yet update. Hence it is useful to get this warning every time, but you should be able to publish nonetheless. It's not a show stopper (other than a failed code analysis).\r\n\r\n### Stop publishing when `unused-dependencies` fails\r\n\r\nOn this, you are right: Publishing should stop here, because it just does not make sense to publish a module with a non-needed sub-module. It only increases install time unnecessarily. In case there is a false positive there is the option to exclude specific modules from the check (this check already existed in the past), so that's easy to fix here. The default behavior is now changed, so when any unused dependencies are found, publishing stops."}}
{"actor":{"display_login":"goloroden"}}