{"action":"created","comment":{"url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments/93798489","pull_request_review_id":14335454,"id":93798489,"diff_hunk":"@@ -19,7 +19,7 @@ public enum Strings {\n    - **fr**: \"Environ %{reward_amount}\"\n    - **en**: \"About %{reward_amount}\"\n   */\n-  public static func About_reward_amount(reward_amount reward_amount: String) -> String {\n+  public static func About_reward_amount(reward_amount: String) -> String {","path":"Library/Strings.swift","position":5,"original_position":5,"commit_id":"f401246fc95b982c184a9b98edf2faded2701c38","original_commit_id":"f401246fc95b982c184a9b98edf2faded2701c38","user":{"login":"mbrandonw","id":135203,"avatar_url":"https://avatars.githubusercontent.com/u/135203?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"lol at the diff in this file. lucky it's all computer generated, we just have to fix the [`bin/strings.swift`](https://github.com/kickstarter/ios-oss/blob/master/bin/strings.swift) to be swift 3 compatible. ","created_at":"2016-12-23T20:03:12Z","updated_at":"2016-12-23T20:03:12Z","html_url":"https://github.com/kickstarter/ios-oss/pull/26#discussion_r93798489","pull_request_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments/93798489"},"html":{"href":"https://github.com/kickstarter/ios-oss/pull/26#discussion_r93798489"},"pull_request":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26","id":99266864,"html_url":"https://github.com/kickstarter/ios-oss/pull/26","diff_url":"https://github.com/kickstarter/ios-oss/pull/26.diff","patch_url":"https://github.com/kickstarter/ios-oss/pull/26.patch","issue_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/26","number":26,"state":"open","locked":false,"title":"Swift 3 compatibility for Library.framework","user":{"login":"mbrandonw","id":135203,"avatar_url":"https://avatars.githubusercontent.com/u/135203?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"This one is a doozy!\r\n\r\nThis upgrades our `Library.framework` to Swift 3, which contains (most) of our view models and platform agnostic shared code. Right now `Library` builds, tests pass, and swiftlint passes except for some `FIXME`s I have placed at places that need attention.\r\n\r\nLet's start by reviewing this, and I will work on the `Kickstarter.framework` swift 3 conversion separately and PR it against this. We probably need a way of divvying up this work, but for now I think it's chill just to scan it and call out anything weird. I'll be making a ton of notes in the PR comments to call out things I've learned some some problems I'm having...\r\n\r\n![10215497-116640902_13-s4-v1](https://cloud.githubusercontent.com/assets/135203/21459519/d1737082-c90c-11e6-9b16-e3b460dc2112.png)\r\n\r\n### See also\r\n\r\nhttps://github.com/kickstarter/Kickstarter-Prelude/pull/62\r\nhttps://github.com/kickstarter/ios-ksapi/pull/3\r\nhttps://github.com/kickstarter/Kickstarter-ReactiveExtensions/pull/54","created_at":"2016-12-23T17:39:36Z","updated_at":"2016-12-23T20:03:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caa09fb3fb8db7da33bf19788022e99822774b35","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26/commits","review_comments_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26/comments","review_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/26/comments","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/f401246fc95b982c184a9b98edf2faded2701c38","head":{"label":"kickstarter:swift3","ref":"swift3","sha":"f401246fc95b982c184a9b98edf2faded2701c38","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":75432091,"name":"ios-oss","full_name":"kickstarter/ios-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/ios-oss","description":"Kickstarter for iOS. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/ios-oss","forks_url":"https://api.github.com/repos/kickstarter/ios-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/ios-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/ios-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/ios-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/ios-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/ios-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/ios-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/ios-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/ios-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/ios-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/ios-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/ios-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/ios-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/ios-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/ios-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/ios-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/ios-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/ios-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/ios-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/ios-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/ios-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/ios-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/ios-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/ios-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/ios-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/ios-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/ios-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/ios-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/ios-oss/deployments","created_at":"2016-12-02T21:24:40Z","updated_at":"2016-12-23T19:19:23Z","pushed_at":"2016-12-23T18:12:58Z","git_url":"git://github.com/kickstarter/ios-oss.git","ssh_url":"git@github.com:kickstarter/ios-oss.git","clone_url":"https://github.com/kickstarter/ios-oss.git","svn_url":"https://github.com/kickstarter/ios-oss","homepage":"https://www.kickstarter.com/mobile","size":194252,"stargazers_count":3384,"watchers_count":3384,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":8,"forks":377,"open_issues":8,"watchers":3384,"default_branch":"master"}},"base":{"label":"kickstarter:master","ref":"master","sha":"c4728398027f034640058a2f9ff52f8528bf8232","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":75432091,"name":"ios-oss","full_name":"kickstarter/ios-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/ios-oss","description":"Kickstarter for iOS. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/ios-oss","forks_url":"https://api.github.com/repos/kickstarter/ios-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/ios-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/ios-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/ios-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/ios-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/ios-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/ios-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/ios-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/ios-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/ios-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/ios-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/ios-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/ios-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/ios-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/ios-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/ios-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/ios-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/ios-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/ios-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/ios-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/ios-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/ios-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/ios-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/ios-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/ios-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/ios-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/ios-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/ios-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/ios-oss/deployments","created_at":"2016-12-02T21:24:40Z","updated_at":"2016-12-23T19:19:23Z","pushed_at":"2016-12-23T18:12:58Z","git_url":"git://github.com/kickstarter/ios-oss.git","ssh_url":"git@github.com:kickstarter/ios-oss.git","clone_url":"https://github.com/kickstarter/ios-oss.git","svn_url":"https://github.com/kickstarter/ios-oss","homepage":"https://www.kickstarter.com/mobile","size":194252,"stargazers_count":3384,"watchers_count":3384,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":8,"forks":377,"open_issues":8,"watchers":3384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26"},"html":{"href":"https://github.com/kickstarter/ios-oss/pull/26"},"issue":{"href":"https://api.github.com/repos/kickstarter/ios-oss/issues/26"},"comments":{"href":"https://api.github.com/repos/kickstarter/ios-oss/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/kickstarter/ios-oss/statuses/f401246fc95b982c184a9b98edf2faded2701c38"}}}}
{"actor":{"display_login":"mbrandonw"}}