{"action":"created","comment":{"url":"https://api.github.com/repos/guptapuneet/lens/pulls/comments/92170154","pull_request_review_id":12679540,"id":92170154,"diff_hunk":"@@ -343,39 +442,6 @@ String getStorageTableName(CubeFactTable fact, String storage, List<String> vali\n     return tableName;\n   }\n \n-  private TimeRange getFallbackRange(TimeRange range, CandidateFact cfact, CubeQueryContext cubeql)\n-    throws LensException {\n-    Cube baseCube = cubeql.getBaseCube();\n-    ArrayList<String> tableNames = Lists.newArrayList(cfact.fact.getName(), cubeql.getCube().getName());\n-    if (!cubeql.getCube().getName().equals(baseCube.getName())) {\n-      tableNames.add(baseCube.getName());\n-    }\n-    String fallBackString = null;\n-    String timedim = baseCube.getTimeDimOfPartitionColumn(range.getPartitionColumn());\n-    for (String tableName : tableNames) {\n-      fallBackString = cubeql.getMetastoreClient().getTable(tableName).getParameters()\n-        .get(MetastoreConstants.TIMEDIM_RELATION + timedim);\n-      if (StringUtils.isNotBlank(fallBackString)) {\n-        break;\n-      }\n-    }\n-    if (StringUtils.isBlank(fallBackString)) {\n-      return null;\n-    }\n-    Matcher matcher = Pattern.compile(\"(.*?)\\\\+\\\\[(.*?),(.*?)\\\\]\").matcher(fallBackString.replaceAll(WSPACE, \"\"));\n-    if (!matcher.matches()) {\n-      return null;\n-    }\n-    DateUtil.TimeDiff diff1 = DateUtil.TimeDiff.parseFrom(matcher.group(2).trim());\n-    DateUtil.TimeDiff diff2 = DateUtil.TimeDiff.parseFrom(matcher.group(3).trim());\n-    String relatedTimeDim = matcher.group(1).trim();\n-    String fallbackPartCol = baseCube.getPartitionColumnOfTimeDim(relatedTimeDim);\n-    return TimeRange.getBuilder()\n-      .fromDate(diff2.negativeOffsetFrom(range.getFromDate()))\n-      .toDate(diff1.negativeOffsetFrom(range.getToDate()))\n-      .partitionColumn(fallbackPartCol).build();\n-  }\n-\n   private void resolveFactStoragePartitions(CubeQueryContext cubeql) throws LensException {","path":"lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java","position":null,"original_position":406,"commit_id":"790d85835b6dfbdca7b02352b35628c438e5c380","original_commit_id":"c70394f3de6e616b95f2919a4bef1d539ea2c185","user":{"login":"lavkesh","id":893339,"avatar_url":"https://avatars.githubusercontent.com/u/893339?v=3","gravatar_id":"","url":"https://api.github.com/users/lavkesh","html_url":"https://github.com/lavkesh","followers_url":"https://api.github.com/users/lavkesh/followers","following_url":"https://api.github.com/users/lavkesh/following{/other_user}","gists_url":"https://api.github.com/users/lavkesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lavkesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavkesh/subscriptions","organizations_url":"https://api.github.com/users/lavkesh/orgs","repos_url":"https://api.github.com/users/lavkesh/repos","events_url":"https://api.github.com/users/lavkesh/events{/privacy}","received_events_url":"https://api.github.com/users/lavkesh/received_events","type":"User","site_admin":false},"body":"Deleting it. ","created_at":"2016-12-13T13:44:53Z","updated_at":"2016-12-13T13:44:53Z","html_url":"https://github.com/guptapuneet/lens/pull/3#discussion_r92170154","pull_request_url":"https://api.github.com/repos/guptapuneet/lens/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/comments/92170154"},"html":{"href":"https://github.com/guptapuneet/lens/pull/3#discussion_r92170154"},"pull_request":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/guptapuneet/lens/pulls/3","id":97185520,"html_url":"https://github.com/guptapuneet/lens/pull/3","diff_url":"https://github.com/guptapuneet/lens/pull/3.diff","patch_url":"https://github.com/guptapuneet/lens/pull/3.patch","issue_url":"https://api.github.com/repos/guptapuneet/lens/issues/3","number":3,"state":"open","locked":false,"title":"Storage table resolver","user":{"login":"lavkesh","id":893339,"avatar_url":"https://avatars.githubusercontent.com/u/893339?v=3","gravatar_id":"","url":"https://api.github.com/users/lavkesh","html_url":"https://github.com/lavkesh","followers_url":"https://api.github.com/users/lavkesh/followers","following_url":"https://api.github.com/users/lavkesh/following{/other_user}","gists_url":"https://api.github.com/users/lavkesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lavkesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavkesh/subscriptions","organizations_url":"https://api.github.com/users/lavkesh/orgs","repos_url":"https://api.github.com/users/lavkesh/repos","events_url":"https://api.github.com/users/lavkesh/events{/privacy}","received_events_url":"https://api.github.com/users/lavkesh/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-08T19:33:26Z","updated_at":"2016-12-13T13:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17b5fc55fef91f45a7593b4fd079926b936bcaa5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guptapuneet/lens/pulls/3/commits","review_comments_url":"https://api.github.com/repos/guptapuneet/lens/pulls/3/comments","review_comment_url":"https://api.github.com/repos/guptapuneet/lens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guptapuneet/lens/issues/3/comments","statuses_url":"https://api.github.com/repos/guptapuneet/lens/statuses/790d85835b6dfbdca7b02352b35628c438e5c380","head":{"label":"lavkesh:union","ref":"union","sha":"790d85835b6dfbdca7b02352b35628c438e5c380","user":{"login":"lavkesh","id":893339,"avatar_url":"https://avatars.githubusercontent.com/u/893339?v=3","gravatar_id":"","url":"https://api.github.com/users/lavkesh","html_url":"https://github.com/lavkesh","followers_url":"https://api.github.com/users/lavkesh/followers","following_url":"https://api.github.com/users/lavkesh/following{/other_user}","gists_url":"https://api.github.com/users/lavkesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lavkesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavkesh/subscriptions","organizations_url":"https://api.github.com/users/lavkesh/orgs","repos_url":"https://api.github.com/users/lavkesh/repos","events_url":"https://api.github.com/users/lavkesh/events{/privacy}","received_events_url":"https://api.github.com/users/lavkesh/received_events","type":"User","site_admin":false},"repo":{"id":56748267,"name":"lens","full_name":"lavkesh/lens","owner":{"login":"lavkesh","id":893339,"avatar_url":"https://avatars.githubusercontent.com/u/893339?v=3","gravatar_id":"","url":"https://api.github.com/users/lavkesh","html_url":"https://github.com/lavkesh","followers_url":"https://api.github.com/users/lavkesh/followers","following_url":"https://api.github.com/users/lavkesh/following{/other_user}","gists_url":"https://api.github.com/users/lavkesh/gists{/gist_id}","starred_url":"https://api.github.com/users/lavkesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavkesh/subscriptions","organizations_url":"https://api.github.com/users/lavkesh/orgs","repos_url":"https://api.github.com/users/lavkesh/repos","events_url":"https://api.github.com/users/lavkesh/events{/privacy}","received_events_url":"https://api.github.com/users/lavkesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lavkesh/lens","description":"Mirror of Apache Lens","fork":true,"url":"https://api.github.com/repos/lavkesh/lens","forks_url":"https://api.github.com/repos/lavkesh/lens/forks","keys_url":"https://api.github.com/repos/lavkesh/lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lavkesh/lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lavkesh/lens/teams","hooks_url":"https://api.github.com/repos/lavkesh/lens/hooks","issue_events_url":"https://api.github.com/repos/lavkesh/lens/issues/events{/number}","events_url":"https://api.github.com/repos/lavkesh/lens/events","assignees_url":"https://api.github.com/repos/lavkesh/lens/assignees{/user}","branches_url":"https://api.github.com/repos/lavkesh/lens/branches{/branch}","tags_url":"https://api.github.com/repos/lavkesh/lens/tags","blobs_url":"https://api.github.com/repos/lavkesh/lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lavkesh/lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lavkesh/lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/lavkesh/lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lavkesh/lens/statuses/{sha}","languages_url":"https://api.github.com/repos/lavkesh/lens/languages","stargazers_url":"https://api.github.com/repos/lavkesh/lens/stargazers","contributors_url":"https://api.github.com/repos/lavkesh/lens/contributors","subscribers_url":"https://api.github.com/repos/lavkesh/lens/subscribers","subscription_url":"https://api.github.com/repos/lavkesh/lens/subscription","commits_url":"https://api.github.com/repos/lavkesh/lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/lavkesh/lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/lavkesh/lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/lavkesh/lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/lavkesh/lens/contents/{+path}","compare_url":"https://api.github.com/repos/lavkesh/lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lavkesh/lens/merges","archive_url":"https://api.github.com/repos/lavkesh/lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lavkesh/lens/downloads","issues_url":"https://api.github.com/repos/lavkesh/lens/issues{/number}","pulls_url":"https://api.github.com/repos/lavkesh/lens/pulls{/number}","milestones_url":"https://api.github.com/repos/lavkesh/lens/milestones{/number}","notifications_url":"https://api.github.com/repos/lavkesh/lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lavkesh/lens/labels{/name}","releases_url":"https://api.github.com/repos/lavkesh/lens/releases{/id}","deployments_url":"https://api.github.com/repos/lavkesh/lens/deployments","created_at":"2016-04-21T06:29:44Z","updated_at":"2016-04-21T06:29:52Z","pushed_at":"2016-12-13T11:21:39Z","git_url":"git://github.com/lavkesh/lens.git","ssh_url":"git@github.com:lavkesh/lens.git","clone_url":"https://github.com/lavkesh/lens.git","svn_url":"https://github.com/lavkesh/lens","homepage":null,"size":16411,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guptapuneet:union-refactor","ref":"union-refactor","sha":"d3d6172f2ad72931e806e466028b2cb69b8905e3","user":{"login":"guptapuneet","id":9948264,"avatar_url":"https://avatars.githubusercontent.com/u/9948264?v=3","gravatar_id":"","url":"https://api.github.com/users/guptapuneet","html_url":"https://github.com/guptapuneet","followers_url":"https://api.github.com/users/guptapuneet/followers","following_url":"https://api.github.com/users/guptapuneet/following{/other_user}","gists_url":"https://api.github.com/users/guptapuneet/gists{/gist_id}","starred_url":"https://api.github.com/users/guptapuneet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptapuneet/subscriptions","organizations_url":"https://api.github.com/users/guptapuneet/orgs","repos_url":"https://api.github.com/users/guptapuneet/repos","events_url":"https://api.github.com/users/guptapuneet/events{/privacy}","received_events_url":"https://api.github.com/users/guptapuneet/received_events","type":"User","site_admin":false},"repo":{"id":42512048,"name":"lens","full_name":"guptapuneet/lens","owner":{"login":"guptapuneet","id":9948264,"avatar_url":"https://avatars.githubusercontent.com/u/9948264?v=3","gravatar_id":"","url":"https://api.github.com/users/guptapuneet","html_url":"https://github.com/guptapuneet","followers_url":"https://api.github.com/users/guptapuneet/followers","following_url":"https://api.github.com/users/guptapuneet/following{/other_user}","gists_url":"https://api.github.com/users/guptapuneet/gists{/gist_id}","starred_url":"https://api.github.com/users/guptapuneet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptapuneet/subscriptions","organizations_url":"https://api.github.com/users/guptapuneet/orgs","repos_url":"https://api.github.com/users/guptapuneet/repos","events_url":"https://api.github.com/users/guptapuneet/events{/privacy}","received_events_url":"https://api.github.com/users/guptapuneet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guptapuneet/lens","description":"Mirror of Apache Lens","fork":true,"url":"https://api.github.com/repos/guptapuneet/lens","forks_url":"https://api.github.com/repos/guptapuneet/lens/forks","keys_url":"https://api.github.com/repos/guptapuneet/lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guptapuneet/lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guptapuneet/lens/teams","hooks_url":"https://api.github.com/repos/guptapuneet/lens/hooks","issue_events_url":"https://api.github.com/repos/guptapuneet/lens/issues/events{/number}","events_url":"https://api.github.com/repos/guptapuneet/lens/events","assignees_url":"https://api.github.com/repos/guptapuneet/lens/assignees{/user}","branches_url":"https://api.github.com/repos/guptapuneet/lens/branches{/branch}","tags_url":"https://api.github.com/repos/guptapuneet/lens/tags","blobs_url":"https://api.github.com/repos/guptapuneet/lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guptapuneet/lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guptapuneet/lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/guptapuneet/lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guptapuneet/lens/statuses/{sha}","languages_url":"https://api.github.com/repos/guptapuneet/lens/languages","stargazers_url":"https://api.github.com/repos/guptapuneet/lens/stargazers","contributors_url":"https://api.github.com/repos/guptapuneet/lens/contributors","subscribers_url":"https://api.github.com/repos/guptapuneet/lens/subscribers","subscription_url":"https://api.github.com/repos/guptapuneet/lens/subscription","commits_url":"https://api.github.com/repos/guptapuneet/lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/guptapuneet/lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/guptapuneet/lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/guptapuneet/lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/guptapuneet/lens/contents/{+path}","compare_url":"https://api.github.com/repos/guptapuneet/lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guptapuneet/lens/merges","archive_url":"https://api.github.com/repos/guptapuneet/lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guptapuneet/lens/downloads","issues_url":"https://api.github.com/repos/guptapuneet/lens/issues{/number}","pulls_url":"https://api.github.com/repos/guptapuneet/lens/pulls{/number}","milestones_url":"https://api.github.com/repos/guptapuneet/lens/milestones{/number}","notifications_url":"https://api.github.com/repos/guptapuneet/lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guptapuneet/lens/labels{/name}","releases_url":"https://api.github.com/repos/guptapuneet/lens/releases{/id}","deployments_url":"https://api.github.com/repos/guptapuneet/lens/deployments","created_at":"2015-09-15T10:40:34Z","updated_at":"2015-09-15T10:40:37Z","pushed_at":"2016-12-13T11:21:40Z","git_url":"git://github.com/guptapuneet/lens.git","ssh_url":"git@github.com:guptapuneet/lens.git","clone_url":"https://github.com/guptapuneet/lens.git","svn_url":"https://github.com/guptapuneet/lens","homepage":null,"size":16841,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/3"},"html":{"href":"https://github.com/guptapuneet/lens/pull/3"},"issue":{"href":"https://api.github.com/repos/guptapuneet/lens/issues/3"},"comments":{"href":"https://api.github.com/repos/guptapuneet/lens/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guptapuneet/lens/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/guptapuneet/lens/statuses/790d85835b6dfbdca7b02352b35628c438e5c380"}}}}
{"actor":{"display_login":"lavkesh"}}