{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/contrib/issues/1385","repository_url":"https://api.github.com/repos/kubernetes/contrib","labels_url":"https://api.github.com/repos/kubernetes/contrib/issues/1385/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/1385/comments","events_url":"https://api.github.com/repos/kubernetes/contrib/issues/1385/events","html_url":"https://github.com/kubernetes/contrib/pull/1385","id":166034159,"number":1385,"title":"Removing defaults from code and making command-line options explicit in deployment.yaml.","user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/contrib/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-18T07:25:32Z","updated_at":"2016-07-19T01:20:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/1385","html_url":"https://github.com/kubernetes/contrib/pull/1385","diff_url":"https://github.com/kubernetes/contrib/pull/1385.diff","patch_url":"https://github.com/kubernetes/contrib/pull/1385.patch"},"body":"Continuing work on #1304. \r\n\r\nWe have a large number of defaults specified for various flags according to the main kubernetes repository. \r\nThe defaults don't make sense as we make mungegithub work with other repositories.\r\n\r\n- The first commit adds logging to print the values of various command-line parameters.\r\n- The second removes defaults and includes them in the deployment.yaml file. "},"comment":{"url":"https://api.github.com/repos/kubernetes/contrib/issues/comments/233505203","html_url":"https://github.com/kubernetes/contrib/pull/1385#issuecomment-233505203","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/1385","id":233505203,"user":{"login":"foxish","id":906471,"avatar_url":"https://avatars.githubusercontent.com/u/906471?v=3","gravatar_id":"","url":"https://api.github.com/users/foxish","html_url":"https://github.com/foxish","followers_url":"https://api.github.com/users/foxish/followers","following_url":"https://api.github.com/users/foxish/following{/other_user}","gists_url":"https://api.github.com/users/foxish/gists{/gist_id}","starred_url":"https://api.github.com/users/foxish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxish/subscriptions","organizations_url":"https://api.github.com/users/foxish/orgs","repos_url":"https://api.github.com/users/foxish/repos","events_url":"https://api.github.com/users/foxish/events{/privacy}","received_events_url":"https://api.github.com/users/foxish/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T01:20:33Z","updated_at":"2016-07-19T01:20:33Z","body":"@apelisse I can't seem to find any such functions that work in the cobra library. [MarkFlagRequired](https://github.com/spf13/cobra/blob/master/bash_completions.go#L588) sounded like the right thing, but it doesn't seem to work, and there is no documentation to be found. In the case of project name, there is a check being performed [here](https://github.com/foxish/contrib/blob/50f8dd5afe37e08b4e9e93677a563019cffe7a1e/mungegithub/github/github.go#L332). But I think you are right in that some places don't have enough sanity checks. I'll add some more error checking code."}}
{"actor":{"display_login":"foxish"}}