{"action":"created","comment":{"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments/82854120","pull_request_review_id":3732046,"id":82854120,"diff_hunk":"@@ -20,22 +19,16 @@\n //!   gain, but only restrict your API for every-day use cases\n //!\n //! [builder pattern]: https://aturon.github.io/ownership/builders.html\n-//! [custom_derive]: https://crates.io/crates/custom_derive\n //!\n //! # Examples\n //!\n-//! This crate is best used in combination with [custom_derive].\n-//!\n //! ```rust\n-//! #[macro_use] extern crate custom_derive;\n //! #[macro_use] extern crate derive_builder;","path":"src/lib.rs","position":21,"original_position":21,"commit_id":"d616575c1662e2b79082e2d7d189fba615f79e83","original_commit_id":"d616575c1662e2b79082e2d7d189fba615f79e83","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"body":"I need to try. ","created_at":"2016-10-11T18:08:55Z","updated_at":"2016-10-11T18:08:55Z","html_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/28#discussion_r82854120","pull_request_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments/82854120"},"html":{"href":"https://github.com/colin-kiegel/rust-derive-builder/pull/28#discussion_r82854120"},"pull_request":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28","id":88876202,"html_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/28","diff_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/28.diff","patch_url":"https://github.com/colin-kiegel/rust-derive-builder/pull/28.patch","issue_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/28","number":28,"state":"open","locked":false,"title":"Macros one dot one (Do Not Merge)","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"body":"So today I [read up on the new Macros 1.1 approach](http://www.ncameron.org/blog/macros-and-syntax-extensions-and-compiler-plugins-where-are-we-at/) and it turns out it is really easy to use (together with the `syn` and `quote` crates).\r\n\r\nI ported over the code to use Macros 1.1 and it works with significantly less code now.\r\nI had to move the tests into their own crate, compiling a test binary in the right library mode is impossible.\r\n\r\n**This makes the code require a recent nightly, DO NOT MERGE immediately**\r\n\r\nThis can probably stay around until Macros 1.1 are actually stable (probably not before the end of the year though).","created_at":"2016-10-11T17:32:49Z","updated_at":"2016-10-11T18:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf3802c315240ed21fdfb5e923bff76c5efb8471","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28/commits","review_comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28/comments","review_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/28/comments","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/d616575c1662e2b79082e2d7d189fba615f79e83","head":{"label":"badboy:macros-one-dot-one","ref":"macros-one-dot-one","sha":"d616575c1662e2b79082e2d7d189fba615f79e83","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"repo":{"id":70592889,"name":"rust-derive-builder","full_name":"badboy/rust-derive-builder","owner":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/badboy/rust-derive-builder","description":"derive builder implementation for rust structs","fork":true,"url":"https://api.github.com/repos/badboy/rust-derive-builder","forks_url":"https://api.github.com/repos/badboy/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/badboy/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badboy/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badboy/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/badboy/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/badboy/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/badboy/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/badboy/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/badboy/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/badboy/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/badboy/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badboy/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badboy/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/badboy/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badboy/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/badboy/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/badboy/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/badboy/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/badboy/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/badboy/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/badboy/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/badboy/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/badboy/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/badboy/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/badboy/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/badboy/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badboy/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/badboy/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badboy/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/badboy/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/badboy/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/badboy/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/badboy/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badboy/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/badboy/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/badboy/rust-derive-builder/deployments","created_at":"2016-10-11T12:52:18Z","updated_at":"2016-10-11T12:52:20Z","pushed_at":"2016-10-11T17:29:16Z","git_url":"git://github.com/badboy/rust-derive-builder.git","ssh_url":"git@github.com:badboy/rust-derive-builder.git","clone_url":"https://github.com/badboy/rust-derive-builder.git","svn_url":"https://github.com/badboy/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":575,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colin-kiegel:master","ref":"master","sha":"5165bf3b06a8b1286c53078e393658d2733f0a29","user":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"repo":{"id":65087808,"name":"rust-derive-builder","full_name":"colin-kiegel/rust-derive-builder","owner":{"login":"colin-kiegel","id":7691186,"avatar_url":"https://avatars.githubusercontent.com/u/7691186?v=3","gravatar_id":"","url":"https://api.github.com/users/colin-kiegel","html_url":"https://github.com/colin-kiegel","followers_url":"https://api.github.com/users/colin-kiegel/followers","following_url":"https://api.github.com/users/colin-kiegel/following{/other_user}","gists_url":"https://api.github.com/users/colin-kiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/colin-kiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colin-kiegel/subscriptions","organizations_url":"https://api.github.com/users/colin-kiegel/orgs","repos_url":"https://api.github.com/users/colin-kiegel/repos","events_url":"https://api.github.com/users/colin-kiegel/events{/privacy}","received_events_url":"https://api.github.com/users/colin-kiegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colin-kiegel/rust-derive-builder","description":"derive builder implementation for rust structs","fork":false,"url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder","forks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/forks","keys_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/teams","hooks_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/hooks","issue_events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/events{/number}","events_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/events","assignees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/assignees{/user}","branches_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/branches{/branch}","tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/tags","blobs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/languages","stargazers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/stargazers","contributors_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contributors","subscribers_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscribers","subscription_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/subscription","commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/contents/{+path}","compare_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/merges","archive_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/downloads","issues_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues{/number}","pulls_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/labels{/name}","releases_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/releases{/id}","deployments_url":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/deployments","created_at":"2016-08-06T15:03:46Z","updated_at":"2016-09-28T10:23:43Z","pushed_at":"2016-10-11T17:32:49Z","git_url":"git://github.com/colin-kiegel/rust-derive-builder.git","ssh_url":"git@github.com:colin-kiegel/rust-derive-builder.git","clone_url":"https://github.com/colin-kiegel/rust-derive-builder.git","svn_url":"https://github.com/colin-kiegel/rust-derive-builder","homepage":"https://colin-kiegel.github.io/rust-derive-builder/","size":573,"stargazers_count":33,"watchers_count":33,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28"},"html":{"href":"https://github.com/colin-kiegel/rust-derive-builder/pull/28"},"issue":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/28"},"comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/colin-kiegel/rust-derive-builder/statuses/d616575c1662e2b79082e2d7d189fba615f79e83"}}}}
{"actor":{"display_login":"badboy"}}