{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/80361565","id":80361565,"diff_hunk":"@@ -32,7 +32,7 @@ module.exports = angular.module('spinnaker.core.search.global.controller', [\n \n     this.searchFieldBlurred = ($blurEvent) => {\n       // if the target is outside the global search (e.g. shift+tab), hide the results\n-      if (!$.contains($element.get(0), $blurEvent.relatedTarget)) {\n+      if (!$.includes($element.get(0), $blurEvent.relatedTarget)) {","path":"app/scripts/modules/core/search/global/globalSearch.controller.js","position":14,"original_position":14,"commit_id":"08f52d03511b79a056156d334ff59743d26057dd","original_commit_id":"08f52d03511b79a056156d334ff59743d26057dd","user":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"body":"No, that's incorrect as well.","created_at":"2016-09-24T14:16:40Z","updated_at":"2016-09-24T14:16:40Z","html_url":"https://github.com/spinnaker/deck/pull/2746#discussion_r80361565","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/2746","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/80361565"},"html":{"href":"https://github.com/spinnaker/deck/pull/2746#discussion_r80361565"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2746"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/2746","id":86597514,"html_url":"https://github.com/spinnaker/deck/pull/2746","diff_url":"https://github.com/spinnaker/deck/pull/2746.diff","patch_url":"https://github.com/spinnaker/deck/pull/2746.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/2746","number":2746,"state":"open","locked":false,"title":"(core) upgrade lodash to 4.x","user":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"body":"This is a massive change.  I've looked at https://github.com/lodash/lodash/wiki/Changelog and believe I've addressed the compatibility issues but won't even remotely swear to it being flawless.\r\n\r\nMigration strategy was to look at methods that were removed, renamed, and whose functionality has been split out.","created_at":"2016-09-23T23:42:56Z","updated_at":"2016-09-24T14:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9ea1d85f3ce93f69fe6c5295da231aabf78dff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/2746/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/2746/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/2746/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/08f52d03511b79a056156d334ff59743d26057dd","head":{"label":"icfantv:lodash_upgrade","ref":"lodash_upgrade","sha":"08f52d03511b79a056156d334ff59743d26057dd","user":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"repo":{"id":65839353,"name":"deck","full_name":"icfantv/deck","owner":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icfantv/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/icfantv/deck","forks_url":"https://api.github.com/repos/icfantv/deck/forks","keys_url":"https://api.github.com/repos/icfantv/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icfantv/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icfantv/deck/teams","hooks_url":"https://api.github.com/repos/icfantv/deck/hooks","issue_events_url":"https://api.github.com/repos/icfantv/deck/issues/events{/number}","events_url":"https://api.github.com/repos/icfantv/deck/events","assignees_url":"https://api.github.com/repos/icfantv/deck/assignees{/user}","branches_url":"https://api.github.com/repos/icfantv/deck/branches{/branch}","tags_url":"https://api.github.com/repos/icfantv/deck/tags","blobs_url":"https://api.github.com/repos/icfantv/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icfantv/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icfantv/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/icfantv/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icfantv/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/icfantv/deck/languages","stargazers_url":"https://api.github.com/repos/icfantv/deck/stargazers","contributors_url":"https://api.github.com/repos/icfantv/deck/contributors","subscribers_url":"https://api.github.com/repos/icfantv/deck/subscribers","subscription_url":"https://api.github.com/repos/icfantv/deck/subscription","commits_url":"https://api.github.com/repos/icfantv/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/icfantv/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/icfantv/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/icfantv/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/icfantv/deck/contents/{+path}","compare_url":"https://api.github.com/repos/icfantv/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icfantv/deck/merges","archive_url":"https://api.github.com/repos/icfantv/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icfantv/deck/downloads","issues_url":"https://api.github.com/repos/icfantv/deck/issues{/number}","pulls_url":"https://api.github.com/repos/icfantv/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/icfantv/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/icfantv/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icfantv/deck/labels{/name}","releases_url":"https://api.github.com/repos/icfantv/deck/releases{/id}","deployments_url":"https://api.github.com/repos/icfantv/deck/deployments","created_at":"2016-08-16T17:20:24Z","updated_at":"2016-08-16T17:20:30Z","pushed_at":"2016-09-23T23:44:25Z","git_url":"git://github.com/icfantv/deck.git","ssh_url":"git@github.com:icfantv/deck.git","clone_url":"https://github.com/icfantv/deck.git","svn_url":"https://github.com/icfantv/deck","homepage":"","size":20162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"114d5962c027758400c7a00321f36c513c5eaa5f","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2016-09-22T14:50:39Z","pushed_at":"2016-09-23T23:44:25Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":32228,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":5,"forks":92,"open_issues":5,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2746"},"html":{"href":"https://github.com/spinnaker/deck/pull/2746"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/2746"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/2746/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2746/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/2746/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/08f52d03511b79a056156d334ff59743d26057dd"}}}}
{"actor":{"display_login":"icfantv"}}