{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/542","repository_url":"https://api.github.com/repos/square/p2","labels_url":"https://api.github.com/repos/square/p2/issues/542/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/542/comments","events_url":"https://api.github.com/repos/square/p2/issues/542/events","html_url":"https://github.com/square/p2/pull/542","id":164145347,"number":542,"title":"Provide functionality to notice changes in node tree","user":{"login":"KoishiKomeiji","id":5440350,"avatar_url":"https://avatars.githubusercontent.com/u/5440350?v=3","gravatar_id":"","url":"https://api.github.com/users/KoishiKomeiji","html_url":"https://github.com/KoishiKomeiji","followers_url":"https://api.github.com/users/KoishiKomeiji/followers","following_url":"https://api.github.com/users/KoishiKomeiji/following{/other_user}","gists_url":"https://api.github.com/users/KoishiKomeiji/gists{/gist_id}","starred_url":"https://api.github.com/users/KoishiKomeiji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoishiKomeiji/subscriptions","organizations_url":"https://api.github.com/users/KoishiKomeiji/orgs","repos_url":"https://api.github.com/users/KoishiKomeiji/repos","events_url":"https://api.github.com/users/KoishiKomeiji/events{/privacy}","received_events_url":"https://api.github.com/users/KoishiKomeiji/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-06T18:40:31Z","updated_at":"2016-07-19T15:32:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/542","html_url":"https://github.com/square/p2/pull/542","diff_url":"https://github.com/square/p2/pull/542.diff","patch_url":"https://github.com/square/p2/pull/542.patch"},"body":"Minor changes:\r\nShare the PodLocation structure between RCs and DSs\r\nAsk the caller to WatchDesires to send a daemon set when a change has been made so that you can verify it\r\nFix tests to for the above change to WatchDesires\r\n\r\nMajor changes:\r\nAdd a WatchMatchDiff function for each daemon set process to detect changes in node tree\r\nProvide and modify tests for the above WatchDiff function"},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/233671072","html_url":"https://github.com/square/p2/pull/542#issuecomment-233671072","issue_url":"https://api.github.com/repos/square/p2/issues/542","id":233671072,"user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T15:32:15Z","updated_at":"2016-07-19T15:32:15Z","body":"From the commit message to 3eff464:\r\n> The tests in WatchDiff have been changed ...\r\n> This will remove the code ...\r\n> This will also change the tests ...\r\n> There are also changes ...\r\n> Also change ...\r\n\r\nI want to reiterate that you should work to put one logical change into each commit. Each commit should be a self-contained bundle of changes that accomplish *one* goal and can stand on its own.\r\n\r\nWhy go to the effort? It's relevant right now because it makes reviewing easier.  When I read through a PR, I have to learn how the code works while also figuring out which parts are related to watching their own nodes, improving type safety, fixing error messages, fixing other bugs, etc.  *You can do that last part for me!* After having written it, you know your own code better than anyone else—you can split apart separate concerns faster and more precisely than I can.\r\n\r\nIf I don't spend time having to disentangle parts your code, I can spend it checking the code for completeness and correctness. Your review will go faster, you will get higher quality feedback, and everyone will have higher confidence that this code is good. I suspect that failing to do this is one reason why this PR is now a couple weeks old without being approved on an otherwise-fast-moving team.\r\n\r\nThis isn't simply about the number of commits. Github's UI merges everything together anyway. Instead, it's about you presenting a clear view of your work in a way that makes it understandable to others."}}
{"actor":{"display_login":"bwester"}}