{"action":"created","issue":{"url":"https://api.github.com/repos/pymor/pymor/issues/238","repository_url":"https://api.github.com/repos/pymor/pymor","labels_url":"https://api.github.com/repos/pymor/pymor/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/pymor/pymor/issues/238/comments","events_url":"https://api.github.com/repos/pymor/pymor/issues/238/events","html_url":"https://github.com/pymor/pymor/pull/238","id":151581161,"number":238,"title":"From Operator to NumPy operator","user":{"login":"pmli","id":1268421,"avatar_url":"https://avatars.githubusercontent.com/u/1268421?v=3","gravatar_id":"","url":"https://api.github.com/users/pmli","html_url":"https://github.com/pmli","followers_url":"https://api.github.com/users/pmli/followers","following_url":"https://api.github.com/users/pmli/following{/other_user}","gists_url":"https://api.github.com/users/pmli/gists{/gist_id}","starred_url":"https://api.github.com/users/pmli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmli/subscriptions","organizations_url":"https://api.github.com/users/pmli/orgs","repos_url":"https://api.github.com/users/pmli/repos","events_url":"https://api.github.com/users/pmli/events{/privacy}","received_events_url":"https://api.github.com/users/pmli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pymor/pymor/milestones/6","html_url":"https://github.com/pymor/pymor/milestones/0.5","labels_url":"https://api.github.com/repos/pymor/pymor/milestones/6/labels","id":1003939,"number":6,"title":"0.5","description":"","creator":{"login":"sdrave","id":2648288,"avatar_url":"https://avatars.githubusercontent.com/u/2648288?v=3","gravatar_id":"","url":"https://api.github.com/users/sdrave","html_url":"https://github.com/sdrave","followers_url":"https://api.github.com/users/sdrave/followers","following_url":"https://api.github.com/users/sdrave/following{/other_user}","gists_url":"https://api.github.com/users/sdrave/gists{/gist_id}","starred_url":"https://api.github.com/users/sdrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdrave/subscriptions","organizations_url":"https://api.github.com/users/sdrave/orgs","repos_url":"https://api.github.com/users/sdrave/repos","events_url":"https://api.github.com/users/sdrave/events{/privacy}","received_events_url":"https://api.github.com/users/sdrave/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":1,"state":"open","created_at":"2015-03-03T12:36:33Z","updated_at":"2016-05-03T14:40:55Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-04-28T08:39:44Z","updated_at":"2016-05-03T15:20:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pymor/pymor/pulls/238","html_url":"https://github.com/pymor/pymor/pull/238","diff_url":"https://github.com/pymor/pymor/pull/238.diff","patch_url":"https://github.com/pymor/pymor/pull/238.patch"},"body":"See #234 "},"comment":{"url":"https://api.github.com/repos/pymor/pymor/issues/comments/216562382","html_url":"https://github.com/pymor/pymor/pull/238#issuecomment-216562382","issue_url":"https://api.github.com/repos/pymor/pymor/issues/238","id":216562382,"user":{"login":"sdrave","id":2648288,"avatar_url":"https://avatars.githubusercontent.com/u/2648288?v=3","gravatar_id":"","url":"https://api.github.com/users/sdrave","html_url":"https://github.com/sdrave","followers_url":"https://api.github.com/users/sdrave/followers","following_url":"https://api.github.com/users/sdrave/following{/other_user}","gists_url":"https://api.github.com/users/sdrave/gists{/gist_id}","starred_url":"https://api.github.com/users/sdrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdrave/subscriptions","organizations_url":"https://api.github.com/users/sdrave/orgs","repos_url":"https://api.github.com/users/sdrave/repos","events_url":"https://api.github.com/users/sdrave/events{/privacy}","received_events_url":"https://api.github.com/users/sdrave/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T15:20:37Z","updated_at":"2016-05-03T15:20:37Z","body":"Thanks for the nice work! I only have two remarks:\r\n\r\n1. The suite for `LincombOperator` will not work when the operator is parametric, in which case you would need to call `op.evaluate_coefficients(mu)` to obtain the linear coefficients. I would say one should at least check that all coefficients are numbers and not `ParameterFunctionals`. Even nicer would be to add an optional `mu` parameter to `_to_matrix` and pass it along.\r\n\r\n2. I would prefer to leave out the `to_numpy_operator` function and rename `_to_matrix` to `to_matrix`. This would make it clearer that by using this function you leave the realm of pyMOR's abstractions and directly work on the data. - If you really need the matrix again as an `Operator`, it should not be too much of a pain to explicitly instantiate the `NumpyMatrixOperator`. Hoever, others (@ftalbrecht, @andreasbuhr) might disagree? Do you use `to_numpy_operator` yourself very often?"}}