{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tajo/pulls/comments/61828973","id":61828973,"diff_hunk":"@@ -212,6 +212,7 @@ public Tuple next() throws IOException {\n \n         prevKeyTuple = getKeyTuple(prevKeyTupleMap, keyTuple.getValues());\n         prevTuple.put(tuple.getValues());\n+        prevTuple.put(tuple.getValues());","path":"tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySecondAggregationExec.java","position":4,"original_position":4,"commit_id":"17b7ec84360e4b207ea8bdfe75b49b90d430f43b","original_commit_id":"17b7ec84360e4b207ea8bdfe75b49b90d430f43b","user":{"login":"blrunner","id":3724310,"avatar_url":"https://avatars.githubusercontent.com/u/3724310?v=3","gravatar_id":"","url":"https://api.github.com/users/blrunner","html_url":"https://github.com/blrunner","followers_url":"https://api.github.com/users/blrunner/followers","following_url":"https://api.github.com/users/blrunner/following{/other_user}","gists_url":"https://api.github.com/users/blrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/blrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrunner/subscriptions","organizations_url":"https://api.github.com/users/blrunner/orgs","repos_url":"https://api.github.com/users/blrunner/repos","events_url":"https://api.github.com/users/blrunner/events{/privacy}","received_events_url":"https://api.github.com/users/blrunner/received_events","type":"User","site_admin":false},"body":"Why you use same codes again?","created_at":"2016-05-03T01:08:08Z","updated_at":"2016-05-03T01:08:08Z","html_url":"https://github.com/apache/tajo/pull/1009#discussion_r61828973","pull_request_url":"https://api.github.com/repos/apache/tajo/pulls/1009","_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/61828973"},"html":{"href":"https://github.com/apache/tajo/pull/1009#discussion_r61828973"},"pull_request":{"href":"https://api.github.com/repos/apache/tajo/pulls/1009"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/1009","id":68496964,"html_url":"https://github.com/apache/tajo/pull/1009","diff_url":"https://github.com/apache/tajo/pull/1009.diff","patch_url":"https://github.com/apache/tajo/pull/1009.patch","issue_url":"https://api.github.com/repos/apache/tajo/issues/1009","number":1009,"state":"open","locked":false,"title":"TAJO-2135: Invalid join result when join key columns contain nulls","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"First of all, apologize for a large patch.\r\nI added null values to every TPC-H tables in our test, and it makes a lot of changes in tests. However, fortunately, I could find several critical bugs with null values.\r\nHere are the changes of this patch.\r\n\r\n* Fixed invalid join result problem with null values.\r\n * When executing hash join, null values of the right table are filtered out while constructing a hash table.\r\n* Fixed invalid cast exception in outer joins with null values.\r\n* Fixed the problem of that sort-merge algorithm for full outer join is not executed in tests.\r\n* Fixed wrong result of full outer hash join with null values.\r\n* Fixed wrong result of RightOuterMergeJoinExec.\r\n* Fixed wrong query result on partitioned tables when partition keys contain nulls.\r\n* Changed the default null character of text file as '\\N'.\r\n* Added null values to every TPC-H tables.\r\n\r\nI also found two additional bugs in anti join and window function executions with nulls. I think we need to fix these problems in other jiras.","created_at":"2016-05-01T14:15:20Z","updated_at":"2016-05-03T01:08:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbc3eee194b676f57f46cd631657fc8108a060c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tajo/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/apache/tajo/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tajo/issues/1009/comments","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/17b7ec84360e4b207ea8bdfe75b49b90d430f43b","head":{"label":"jihoonson:TAJO-2135","ref":"TAJO-2135","sha":"17b7ec84360e4b207ea8bdfe75b49b90d430f43b","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"repo":{"id":19723915,"name":"tajo-2","full_name":"jihoonson/tajo-2","owner":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jihoonson/tajo-2","description":"Mirror of Apache Tajo","fork":true,"url":"https://api.github.com/repos/jihoonson/tajo-2","forks_url":"https://api.github.com/repos/jihoonson/tajo-2/forks","keys_url":"https://api.github.com/repos/jihoonson/tajo-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihoonson/tajo-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihoonson/tajo-2/teams","hooks_url":"https://api.github.com/repos/jihoonson/tajo-2/hooks","issue_events_url":"https://api.github.com/repos/jihoonson/tajo-2/issues/events{/number}","events_url":"https://api.github.com/repos/jihoonson/tajo-2/events","assignees_url":"https://api.github.com/repos/jihoonson/tajo-2/assignees{/user}","branches_url":"https://api.github.com/repos/jihoonson/tajo-2/branches{/branch}","tags_url":"https://api.github.com/repos/jihoonson/tajo-2/tags","blobs_url":"https://api.github.com/repos/jihoonson/tajo-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihoonson/tajo-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihoonson/tajo-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihoonson/tajo-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihoonson/tajo-2/statuses/{sha}","languages_url":"https://api.github.com/repos/jihoonson/tajo-2/languages","stargazers_url":"https://api.github.com/repos/jihoonson/tajo-2/stargazers","contributors_url":"https://api.github.com/repos/jihoonson/tajo-2/contributors","subscribers_url":"https://api.github.com/repos/jihoonson/tajo-2/subscribers","subscription_url":"https://api.github.com/repos/jihoonson/tajo-2/subscription","commits_url":"https://api.github.com/repos/jihoonson/tajo-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihoonson/tajo-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihoonson/tajo-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihoonson/tajo-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihoonson/tajo-2/contents/{+path}","compare_url":"https://api.github.com/repos/jihoonson/tajo-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihoonson/tajo-2/merges","archive_url":"https://api.github.com/repos/jihoonson/tajo-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihoonson/tajo-2/downloads","issues_url":"https://api.github.com/repos/jihoonson/tajo-2/issues{/number}","pulls_url":"https://api.github.com/repos/jihoonson/tajo-2/pulls{/number}","milestones_url":"https://api.github.com/repos/jihoonson/tajo-2/milestones{/number}","notifications_url":"https://api.github.com/repos/jihoonson/tajo-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihoonson/tajo-2/labels{/name}","releases_url":"https://api.github.com/repos/jihoonson/tajo-2/releases{/id}","deployments_url":"https://api.github.com/repos/jihoonson/tajo-2/deployments","created_at":"2014-05-13T02:59:45Z","updated_at":"2015-09-01T01:38:41Z","pushed_at":"2016-05-02T13:24:56Z","git_url":"git://github.com/jihoonson/tajo-2.git","ssh_url":"git@github.com:jihoonson/tajo-2.git","clone_url":"https://github.com/jihoonson/tajo-2.git","svn_url":"https://github.com/jihoonson/tajo-2","homepage":null,"size":31699,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"16cbf69fe363de82e17bbb26f39ce7efa23d6546","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17971138,"name":"tajo","full_name":"apache/tajo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tajo","description":"Mirror of Apache Tajo","fork":false,"url":"https://api.github.com/repos/apache/tajo","forks_url":"https://api.github.com/repos/apache/tajo/forks","keys_url":"https://api.github.com/repos/apache/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tajo/teams","hooks_url":"https://api.github.com/repos/apache/tajo/hooks","issue_events_url":"https://api.github.com/repos/apache/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tajo/events","assignees_url":"https://api.github.com/repos/apache/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tajo/tags","blobs_url":"https://api.github.com/repos/apache/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tajo/languages","stargazers_url":"https://api.github.com/repos/apache/tajo/stargazers","contributors_url":"https://api.github.com/repos/apache/tajo/contributors","subscribers_url":"https://api.github.com/repos/apache/tajo/subscribers","subscription_url":"https://api.github.com/repos/apache/tajo/subscription","commits_url":"https://api.github.com/repos/apache/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tajo/merges","archive_url":"https://api.github.com/repos/apache/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tajo/downloads","issues_url":"https://api.github.com/repos/apache/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tajo/labels{/name}","releases_url":"https://api.github.com/repos/apache/tajo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tajo/deployments","created_at":"2014-03-21T07:00:07Z","updated_at":"2016-04-08T15:03:48Z","pushed_at":"2016-05-02T05:00:29Z","git_url":"git://github.com/apache/tajo.git","ssh_url":"git@github.com:apache/tajo.git","clone_url":"https://github.com/apache/tajo.git","svn_url":"https://github.com/apache/tajo","homepage":null,"size":44830,"stargazers_count":82,"watchers_count":82,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":"git://git.apache.org/tajo.git","open_issues_count":42,"forks":89,"open_issues":42,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/1009"},"html":{"href":"https://github.com/apache/tajo/pull/1009"},"issue":{"href":"https://api.github.com/repos/apache/tajo/issues/1009"},"comments":{"href":"https://api.github.com/repos/apache/tajo/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tajo/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tajo/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tajo/statuses/17b7ec84360e4b207ea8bdfe75b49b90d430f43b"}}}}