{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/207","repository_url":"https://api.github.com/repos/voxpupuli/modulesync_config","labels_url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/207/comments","events_url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/207/events","html_url":"https://github.com/voxpupuli/modulesync_config/pull/207","id":169680707,"number":207,"title":"make loading default facts more robust","user":{"login":"3flex","id":170028,"avatar_url":"https://avatars.githubusercontent.com/u/170028?v=3","gravatar_id":"","url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-05T19:35:34Z","updated_at":"2016-08-05T19:38:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/modulesync_config/pulls/207","html_url":"https://github.com/voxpupuli/modulesync_config/pull/207","diff_url":"https://github.com/voxpupuli/modulesync_config/pull/207.diff","patch_url":"https://github.com/voxpupuli/modulesync_config/pull/207.patch"},"body":"* Merge instead of attempting to append - means default_module_facts can override default_facts\r\n* Make the loading of the files independent of the current working directory\r\n* YAML.read_file doesn't appear to be a valid method - replaced with YAML.load\r\n\r\nTested on Ruby 1.9.3, 2.1, 2.2 and 2.3.1. See results at https://travis-ci.org/jfryman/puppet-nginx"},"comment":{"url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/comments/237943532","html_url":"https://github.com/voxpupuli/modulesync_config/pull/207#issuecomment-237943532","issue_url":"https://api.github.com/repos/voxpupuli/modulesync_config/issues/207","id":237943532,"user":{"login":"3flex","id":170028,"avatar_url":"https://avatars.githubusercontent.com/u/170028?v=3","gravatar_id":"","url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T19:38:19Z","updated_at":"2016-08-05T19:38:19Z","body":"Regarding the second point (making the loading files independent of current working directory), the files were never loaded when running `bundle exec rake test` without the change to checking for existence with `File.expand_path('../default_facts.yml', __FILE__)`"}}
{"actor":{"display_login":"3flex"}}