{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/55747808","id":55747808,"diff_hunk":"@@ -339,16 +339,10 @@ sub accounting {\n \n         my $config = _get_rpc_config();\n         my $data;\n+        $data = send_msgpack_notification($config, \"handle_accounting_metadata\", \\%RAD_REQUEST);\n         if ($RAD_REQUEST{'Acct-Status-Type'} eq 'Stop' || $RAD_REQUEST{'Acct-Status-Type'} eq 'Interim-Update') {\n             $data = send_rpc_request($config, \"radius_accounting\", \\%RAD_REQUEST);\n-        } elsif ($RAD_REQUEST{'Acct-Status-Type'} eq 'Start') {\n-            #\n-            # Updating location log in on initial ('Start') accounting run.\n-            #\n-            $data = send_rpc_request($config, \"radius_update_locationlog\", \\%RAD_REQUEST);\n-        }\n-        # Tracking IP address.\n-        send_rpc_request($config, \"update_iplog\", {mac => $mac, ip => $RAD_REQUEST{'Framed-IP-Address'}, source => \"accounting\"}) if ($RAD_REQUEST{'Framed-IP-Address'} );\n+        } ","path":"raddb/mods-config/perl/packetfence.pm","position":15,"original_position":15,"commit_id":"f0da11afa1b9e59b0b8256d0ee08f3fef3805876","original_commit_id":"f0da11afa1b9e59b0b8256d0ee08f3fef3805876","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"I don't think so because we want to send it for every type that exists so we can extract out metadata out of every packet.\r\n\r\nI initially made this piece of code for accounting fingerprinting and its present in every packet so we want the metadata to be handled on every packet","created_at":"2016-03-10T20:55:13Z","updated_at":"2016-03-10T20:55:13Z","html_url":"https://github.com/inverse-inc/packetfence/pull/1237#discussion_r55747808","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/55747808"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1237#discussion_r55747808"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237","id":62447570,"html_url":"https://github.com/inverse-inc/packetfence/pull/1237","diff_url":"https://github.com/inverse-inc/packetfence/pull/1237.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/1237.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1237","number":1237,"state":"open","locked":false,"title":"Fix/less rpc in acct","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"# Description\r\nReduce the amount of webservices calls for the handling of the accounting.\r\n\r\n# Impacts\r\nAccounting\r\n\r\n# Delete branch after merge\r\nYES\r\n\r\n# NEWS file entries\r\n## Enhancements\r\n* Reduced the number of webservices calls in accounting\r\n* Enhancement 2\r\n","created_at":"2016-03-10T20:05:05Z","updated_at":"2016-03-10T20:55:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"761e6698349d4f9ebb11ad076dc9aac7b71ecacb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/1237/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/f0da11afa1b9e59b0b8256d0ee08f3fef3805876","head":{"label":"julsemaan:fix/less-rpc-in-acct","ref":"fix/less-rpc-in-acct","sha":"f0da11afa1b9e59b0b8256d0ee08f3fef3805876","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"repo":{"id":9198603,"name":"packetfence","full_name":"julsemaan/packetfence","owner":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julsemaan/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/julsemaan/packetfence","forks_url":"https://api.github.com/repos/julsemaan/packetfence/forks","keys_url":"https://api.github.com/repos/julsemaan/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julsemaan/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julsemaan/packetfence/teams","hooks_url":"https://api.github.com/repos/julsemaan/packetfence/hooks","issue_events_url":"https://api.github.com/repos/julsemaan/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/julsemaan/packetfence/events","assignees_url":"https://api.github.com/repos/julsemaan/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/julsemaan/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/julsemaan/packetfence/tags","blobs_url":"https://api.github.com/repos/julsemaan/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julsemaan/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julsemaan/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/julsemaan/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julsemaan/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/julsemaan/packetfence/languages","stargazers_url":"https://api.github.com/repos/julsemaan/packetfence/stargazers","contributors_url":"https://api.github.com/repos/julsemaan/packetfence/contributors","subscribers_url":"https://api.github.com/repos/julsemaan/packetfence/subscribers","subscription_url":"https://api.github.com/repos/julsemaan/packetfence/subscription","commits_url":"https://api.github.com/repos/julsemaan/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/julsemaan/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/julsemaan/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/julsemaan/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/julsemaan/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/julsemaan/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julsemaan/packetfence/merges","archive_url":"https://api.github.com/repos/julsemaan/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julsemaan/packetfence/downloads","issues_url":"https://api.github.com/repos/julsemaan/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/julsemaan/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/julsemaan/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/julsemaan/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julsemaan/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/julsemaan/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/julsemaan/packetfence/deployments","created_at":"2013-04-03T15:52:51Z","updated_at":"2014-06-17T14:56:13Z","pushed_at":"2016-03-10T19:58:26Z","git_url":"git://github.com/julsemaan/packetfence.git","ssh_url":"git@github.com:julsemaan/packetfence.git","clone_url":"https://github.com/julsemaan/packetfence.git","svn_url":"https://github.com/julsemaan/packetfence","homepage":"http://www.packetfence.org","size":165245,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"cc7fcccd5186f1eca1058c37cfc2a5528aa6dcd1","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence/deployments","created_at":"2012-03-01T20:21:13Z","updated_at":"2016-03-10T07:53:41Z","pushed_at":"2016-03-10T20:29:05Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":168325,"stargazers_count":167,"watchers_count":167,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":216,"forks":78,"open_issues":216,"watchers":167,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/1237"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1237"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/1237/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/1237/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/f0da11afa1b9e59b0b8256d0ee08f3fef3805876"}}}}