{"action":"created","issue":{"url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/95","repository_url":"https://api.github.com/repos/vert-x3/vertx-auth","labels_url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/95/comments","events_url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/95/events","html_url":"https://github.com/vert-x3/vertx-auth/pull/95","id":185096125,"number":95,"title":"Use getEncoder instead of getUrlEncoder","user":{"login":"mguillet","id":701325,"avatar_url":"https://avatars.githubusercontent.com/u/701325?v=3","gravatar_id":"","url":"https://api.github.com/users/mguillet","html_url":"https://github.com/mguillet","followers_url":"https://api.github.com/users/mguillet/followers","following_url":"https://api.github.com/users/mguillet/following{/other_user}","gists_url":"https://api.github.com/users/mguillet/gists{/gist_id}","starred_url":"https://api.github.com/users/mguillet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mguillet/subscriptions","organizations_url":"https://api.github.com/users/mguillet/orgs","repos_url":"https://api.github.com/users/mguillet/repos","events_url":"https://api.github.com/users/mguillet/events{/privacy}","received_events_url":"https://api.github.com/users/mguillet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vert-x3/vertx-auth/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-25T11:59:28Z","updated_at":"2016-10-26T08:52:44Z","closed_at":"2016-10-26T08:37:28Z","pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-auth/pulls/95","html_url":"https://github.com/vert-x3/vertx-auth/pull/95","diff_url":"https://github.com/vert-x3/vertx-auth/pull/95.diff","patch_url":"https://github.com/vert-x3/vertx-auth/pull/95.patch"},"body":"According to RFC7617 I don't believe we need to encode special character before doing base64 encoding.\r\n\r\nI had an issue with some credentials that contained '$' in them producing a different output with `Base64.getEncoder()`. My OAuth provider didn't accept the authorisation header with ```Base64.getUrlEncoder()``` but it worked with ```Base64.getEncoder()```"},"comment":{"url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/comments/256287540","html_url":"https://github.com/vert-x3/vertx-auth/pull/95#issuecomment-256287540","issue_url":"https://api.github.com/repos/vert-x3/vertx-auth/issues/95","id":256287540,"user":{"login":"mguillet","id":701325,"avatar_url":"https://avatars.githubusercontent.com/u/701325?v=3","gravatar_id":"","url":"https://api.github.com/users/mguillet","html_url":"https://github.com/mguillet","followers_url":"https://api.github.com/users/mguillet/followers","following_url":"https://api.github.com/users/mguillet/following{/other_user}","gists_url":"https://api.github.com/users/mguillet/gists{/gist_id}","starred_url":"https://api.github.com/users/mguillet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mguillet/subscriptions","organizations_url":"https://api.github.com/users/mguillet/orgs","repos_url":"https://api.github.com/users/mguillet/repos","events_url":"https://api.github.com/users/mguillet/events{/privacy}","received_events_url":"https://api.github.com/users/mguillet/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T08:52:44Z","updated_at":"2016-10-26T08:52:44Z","body":"Thanks!"}}
{"actor":{"display_login":"mguillet"}}