{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/74274263","id":74274263,"diff_hunk":"@@ -4,6 +4,10 @@ if(POLICY CMP0051)\n   cmake_policy(SET CMP0051 NEW)\n endif()\n \n+if(POLICY CMP0054)","path":"CMakeLists.txt","position":4,"original_position":4,"commit_id":"5f25625f4ae39fa57d79a4111ccb51c47f5c9bf8","original_commit_id":"32d22d6efe86f529e7d22ba1096b50a090e121a1","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I see. So the right answer is to set it to `NEW`?","created_at":"2016-08-10T16:00:09Z","updated_at":"2016-08-10T16:00:10Z","html_url":"https://github.com/apple/swift/pull/3841#discussion_r74274263","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/3841","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/74274263"},"html":{"href":"https://github.com/apple/swift/pull/3841#discussion_r74274263"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/3841"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3841","id":79285015,"html_url":"https://github.com/apple/swift/pull/3841","diff_url":"https://github.com/apple/swift/pull/3841.diff","patch_url":"https://github.com/apple/swift/pull/3841.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3841","number":3841,"state":"open","locked":false,"title":"[swiftc] Fixed for Cygwin","user":{"login":"tinysun212","id":12603793,"avatar_url":"https://avatars.githubusercontent.com/u/12603793?v=3","gravatar_id":"","url":"https://api.github.com/users/tinysun212","html_url":"https://github.com/tinysun212","followers_url":"https://api.github.com/users/tinysun212/followers","following_url":"https://api.github.com/users/tinysun212/following{/other_user}","gists_url":"https://api.github.com/users/tinysun212/gists{/gist_id}","starred_url":"https://api.github.com/users/tinysun212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinysun212/subscriptions","organizations_url":"https://api.github.com/users/tinysun212/orgs","repos_url":"https://api.github.com/users/tinysun212/repos","events_url":"https://api.github.com/users/tinysun212/events{/privacy}","received_events_url":"https://api.github.com/users/tinysun212/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating the pull request. -->\r\n#### What's in this pull request?\r\n<!-- Description about pull request. -->\r\n\r\n#### Resolved bug number: ([SR-](https://bugs.swift.org/browse/SR-))\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\nA smoke test on macOS does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library only for macOS. Simulator standard libraries and\r\n   device standard libraries are not built.\r\n3. lldb is not built.\r\n4. The test and validation-test targets are run only for macOS. The optimized\r\n   version of these tests are not run.\r\n\r\nA smoke test on Linux does the following:\r\n\r\n1. Builds the compiler incrementally.\r\n2. Builds the standard library incrementally.\r\n3. lldb is built incrementally.\r\n4. The swift test and validation-test targets are run. The optimized version of these\r\n   tests are not run.\r\n5. lldb is tested.\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\nFixed for the difference of Cygwin with other Windows variants (MSVC,\r\nItanium, MinGW).\r\n\r\n- The platform name is renamed to \"cygwin\" from \"windows\" which is used\r\n  for searching the standard libraries.\r\n\r\n- The consideration for DLL storage class (DllExport/DllImport) is not\r\n  required for Cygwin and MinGW. There is no problem when linking in\r\n  these environment.\r\n\r\n- Cygwin should use large memory model as default.(This may be changed\r\n  if someone ports to 32bit)\r\n\r\n- Cygwin and MinGW should use the autolink feature in the sameway of\r\n  Linux due to the linker's limit.","created_at":"2016-07-28T23:23:03Z","updated_at":"2016-08-10T16:00:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d122bd9a47282bec19dc9a995f073a500ec7dcac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3841/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3841/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3841/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/5f25625f4ae39fa57d79a4111ccb51c47f5c9bf8","head":{"label":"tinysun212:pr-swiftc-cygwin-2","ref":"pr-swiftc-cygwin-2","sha":"5f25625f4ae39fa57d79a4111ccb51c47f5c9bf8","user":{"login":"tinysun212","id":12603793,"avatar_url":"https://avatars.githubusercontent.com/u/12603793?v=3","gravatar_id":"","url":"https://api.github.com/users/tinysun212","html_url":"https://github.com/tinysun212","followers_url":"https://api.github.com/users/tinysun212/followers","following_url":"https://api.github.com/users/tinysun212/following{/other_user}","gists_url":"https://api.github.com/users/tinysun212/gists{/gist_id}","starred_url":"https://api.github.com/users/tinysun212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinysun212/subscriptions","organizations_url":"https://api.github.com/users/tinysun212/orgs","repos_url":"https://api.github.com/users/tinysun212/repos","events_url":"https://api.github.com/users/tinysun212/events{/privacy}","received_events_url":"https://api.github.com/users/tinysun212/received_events","type":"User","site_admin":false},"repo":{"id":48312409,"name":"swift-windows","full_name":"tinysun212/swift-windows","owner":{"login":"tinysun212","id":12603793,"avatar_url":"https://avatars.githubusercontent.com/u/12603793?v=3","gravatar_id":"","url":"https://api.github.com/users/tinysun212","html_url":"https://github.com/tinysun212","followers_url":"https://api.github.com/users/tinysun212/followers","following_url":"https://api.github.com/users/tinysun212/following{/other_user}","gists_url":"https://api.github.com/users/tinysun212/gists{/gist_id}","starred_url":"https://api.github.com/users/tinysun212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinysun212/subscriptions","organizations_url":"https://api.github.com/users/tinysun212/orgs","repos_url":"https://api.github.com/users/tinysun212/repos","events_url":"https://api.github.com/users/tinysun212/events{/privacy}","received_events_url":"https://api.github.com/users/tinysun212/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinysun212/swift-windows","description":"Swift for Windows (cygwin, msvc, mingw)","fork":true,"url":"https://api.github.com/repos/tinysun212/swift-windows","forks_url":"https://api.github.com/repos/tinysun212/swift-windows/forks","keys_url":"https://api.github.com/repos/tinysun212/swift-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinysun212/swift-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinysun212/swift-windows/teams","hooks_url":"https://api.github.com/repos/tinysun212/swift-windows/hooks","issue_events_url":"https://api.github.com/repos/tinysun212/swift-windows/issues/events{/number}","events_url":"https://api.github.com/repos/tinysun212/swift-windows/events","assignees_url":"https://api.github.com/repos/tinysun212/swift-windows/assignees{/user}","branches_url":"https://api.github.com/repos/tinysun212/swift-windows/branches{/branch}","tags_url":"https://api.github.com/repos/tinysun212/swift-windows/tags","blobs_url":"https://api.github.com/repos/tinysun212/swift-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinysun212/swift-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinysun212/swift-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinysun212/swift-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinysun212/swift-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/tinysun212/swift-windows/languages","stargazers_url":"https://api.github.com/repos/tinysun212/swift-windows/stargazers","contributors_url":"https://api.github.com/repos/tinysun212/swift-windows/contributors","subscribers_url":"https://api.github.com/repos/tinysun212/swift-windows/subscribers","subscription_url":"https://api.github.com/repos/tinysun212/swift-windows/subscription","commits_url":"https://api.github.com/repos/tinysun212/swift-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinysun212/swift-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinysun212/swift-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinysun212/swift-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinysun212/swift-windows/contents/{+path}","compare_url":"https://api.github.com/repos/tinysun212/swift-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinysun212/swift-windows/merges","archive_url":"https://api.github.com/repos/tinysun212/swift-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinysun212/swift-windows/downloads","issues_url":"https://api.github.com/repos/tinysun212/swift-windows/issues{/number}","pulls_url":"https://api.github.com/repos/tinysun212/swift-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/tinysun212/swift-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/tinysun212/swift-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinysun212/swift-windows/labels{/name}","releases_url":"https://api.github.com/repos/tinysun212/swift-windows/releases{/id}","deployments_url":"https://api.github.com/repos/tinysun212/swift-windows/deployments","created_at":"2015-12-20T08:16:08Z","updated_at":"2016-08-08T03:22:41Z","pushed_at":"2016-08-06T22:28:44Z","git_url":"git://github.com/tinysun212/swift-windows.git","ssh_url":"git@github.com:tinysun212/swift-windows.git","clone_url":"https://github.com/tinysun212/swift-windows.git","svn_url":"https://github.com/tinysun212/swift-windows","homepage":"","size":124703,"stargazers_count":179,"watchers_count":179,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":1,"forks":19,"open_issues":1,"watchers":179,"default_branch":"stable"}},"base":{"label":"apple:master","ref":"master","sha":"16e4294a02e5b30f8115259926d0f61c6fd4962c","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-08-10T15:54:43Z","pushed_at":"2016-08-10T15:46:54Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":172884,"stargazers_count":33077,"watchers_count":33077,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4636,"mirror_url":null,"open_issues_count":96,"forks":4636,"open_issues":96,"watchers":33077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3841"},"html":{"href":"https://github.com/apple/swift/pull/3841"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3841"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3841/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3841/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3841/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/5f25625f4ae39fa57d79a4111ccb51c47f5c9bf8"}}}}
{"actor":{"display_login":"jrose-apple"}}