{"action":"created","comment":{"url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/comments/83724154","pull_request_review_id":4549453,"id":83724154,"diff_hunk":"@@ -10,6 +10,28 @@\n     private $testRequestHost = 'example.com';\n \n     /**\n+     * @var string[]\n+     */\n+    private $originalServerState;\n+\n+    /**\n+     * @var string[]\n+     */\n+    private $originalCookieState;\n+\n+    protected function setUp()\n+    {\n+        $this->originalServerState = $_SERVER;\n+        $this->originalCookieState = $_COOKIE;\n+    }","path":"tests/Unit/Suites/Http/AbstractHttpRequestTest.php","position":17,"original_position":17,"commit_id":"12d916dabed907f7c16fa7b2a2bffedb837ddb63","original_commit_id":"12d916dabed907f7c16fa7b2a2bffedb837ddb63","user":{"login":"Vinai","id":72463,"avatar_url":"https://avatars.githubusercontent.com/u/72463?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinai","html_url":"https://github.com/Vinai","followers_url":"https://api.github.com/users/Vinai/followers","following_url":"https://api.github.com/users/Vinai/following{/other_user}","gists_url":"https://api.github.com/users/Vinai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinai/subscriptions","organizations_url":"https://api.github.com/users/Vinai/orgs","repos_url":"https://api.github.com/users/Vinai/repos","events_url":"https://api.github.com/users/Vinai/events{/privacy}","received_events_url":"https://api.github.com/users/Vinai/received_events","type":"User","site_admin":false},"body":"Instead of overriding `setUp` and `tearDown` and forcing children to call `parent::` it is better to use `@before` and `@after` with specific, more descriptive final public methods.","created_at":"2016-10-17T20:15:45Z","updated_at":"2016-10-17T20:15:45Z","html_url":"https://github.com/lizards-and-pumpkins/catalog/pull/941#discussion_r83724154","pull_request_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941","_links":{"self":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/comments/83724154"},"html":{"href":"https://github.com/lizards-and-pumpkins/catalog/pull/941#discussion_r83724154"},"pull_request":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941","id":89623831,"html_url":"https://github.com/lizards-and-pumpkins/catalog/pull/941","diff_url":"https://github.com/lizards-and-pumpkins/catalog/pull/941.diff","patch_url":"https://github.com/lizards-and-pumpkins/catalog/pull/941.patch","issue_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/941","number":941,"state":"open","locked":false,"title":"Issue #940: Move header creation from globals into HttpHeaders value object","user":{"login":"tim-bezhashvyly","id":462687,"avatar_url":"https://avatars.githubusercontent.com/u/462687?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-bezhashvyly","html_url":"https://github.com/tim-bezhashvyly","followers_url":"https://api.github.com/users/tim-bezhashvyly/followers","following_url":"https://api.github.com/users/tim-bezhashvyly/following{/other_user}","gists_url":"https://api.github.com/users/tim-bezhashvyly/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-bezhashvyly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-bezhashvyly/subscriptions","organizations_url":"https://api.github.com/users/tim-bezhashvyly/orgs","repos_url":"https://api.github.com/users/tim-bezhashvyly/repos","events_url":"https://api.github.com/users/tim-bezhashvyly/events{/privacy}","received_events_url":"https://api.github.com/users/tim-bezhashvyly/received_events","type":"User","site_admin":false},"body":"Closes #940.","created_at":"2016-10-17T13:31:39Z","updated_at":"2016-10-17T20:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e8684079febe3bb0d34a2367a51398ce64521a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941/commits","review_comments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941/comments","review_comment_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/941/comments","statuses_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/statuses/12d916dabed907f7c16fa7b2a2bffedb837ddb63","head":{"label":"lizards-and-pumpkins:issue-940","ref":"issue-940","sha":"12d916dabed907f7c16fa7b2a2bffedb837ddb63","user":{"login":"lizards-and-pumpkins","id":8191923,"avatar_url":"https://avatars.githubusercontent.com/u/8191923?v=3","gravatar_id":"","url":"https://api.github.com/users/lizards-and-pumpkins","html_url":"https://github.com/lizards-and-pumpkins","followers_url":"https://api.github.com/users/lizards-and-pumpkins/followers","following_url":"https://api.github.com/users/lizards-and-pumpkins/following{/other_user}","gists_url":"https://api.github.com/users/lizards-and-pumpkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lizards-and-pumpkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizards-and-pumpkins/subscriptions","organizations_url":"https://api.github.com/users/lizards-and-pumpkins/orgs","repos_url":"https://api.github.com/users/lizards-and-pumpkins/repos","events_url":"https://api.github.com/users/lizards-and-pumpkins/events{/privacy}","received_events_url":"https://api.github.com/users/lizards-and-pumpkins/received_events","type":"Organization","site_admin":false},"repo":{"id":25209535,"name":"catalog","full_name":"lizards-and-pumpkins/catalog","owner":{"login":"lizards-and-pumpkins","id":8191923,"avatar_url":"https://avatars.githubusercontent.com/u/8191923?v=3","gravatar_id":"","url":"https://api.github.com/users/lizards-and-pumpkins","html_url":"https://github.com/lizards-and-pumpkins","followers_url":"https://api.github.com/users/lizards-and-pumpkins/followers","following_url":"https://api.github.com/users/lizards-and-pumpkins/following{/other_user}","gists_url":"https://api.github.com/users/lizards-and-pumpkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lizards-and-pumpkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizards-and-pumpkins/subscriptions","organizations_url":"https://api.github.com/users/lizards-and-pumpkins/orgs","repos_url":"https://api.github.com/users/lizards-and-pumpkins/repos","events_url":"https://api.github.com/users/lizards-and-pumpkins/events{/privacy}","received_events_url":"https://api.github.com/users/lizards-and-pumpkins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lizards-and-pumpkins/catalog","description":"Lizards and Pumpkins","fork":false,"url":"https://api.github.com/repos/lizards-and-pumpkins/catalog","forks_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/forks","keys_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/teams","hooks_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/hooks","issue_events_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/events{/number}","events_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/events","assignees_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/assignees{/user}","branches_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/branches{/branch}","tags_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/tags","blobs_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/languages","stargazers_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/stargazers","contributors_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/contributors","subscribers_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/subscribers","subscription_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/subscription","commits_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/contents/{+path}","compare_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/merges","archive_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/downloads","issues_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues{/number}","pulls_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/labels{/name}","releases_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/releases{/id}","deployments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/deployments","created_at":"2014-10-14T13:57:56Z","updated_at":"2016-10-15T22:15:04Z","pushed_at":"2016-10-17T13:31:39Z","git_url":"git://github.com/lizards-and-pumpkins/catalog.git","ssh_url":"git@github.com:lizards-and-pumpkins/catalog.git","clone_url":"https://github.com/lizards-and-pumpkins/catalog.git","svn_url":"https://github.com/lizards-and-pumpkins/catalog","homepage":"lizardsandpumpkins.com","size":19159,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":66,"forks":0,"open_issues":66,"watchers":2,"default_branch":"master"}},"base":{"label":"lizards-and-pumpkins:master","ref":"master","sha":"7076c4db0149b35984aead47c5bf32b5694b12a6","user":{"login":"lizards-and-pumpkins","id":8191923,"avatar_url":"https://avatars.githubusercontent.com/u/8191923?v=3","gravatar_id":"","url":"https://api.github.com/users/lizards-and-pumpkins","html_url":"https://github.com/lizards-and-pumpkins","followers_url":"https://api.github.com/users/lizards-and-pumpkins/followers","following_url":"https://api.github.com/users/lizards-and-pumpkins/following{/other_user}","gists_url":"https://api.github.com/users/lizards-and-pumpkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lizards-and-pumpkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizards-and-pumpkins/subscriptions","organizations_url":"https://api.github.com/users/lizards-and-pumpkins/orgs","repos_url":"https://api.github.com/users/lizards-and-pumpkins/repos","events_url":"https://api.github.com/users/lizards-and-pumpkins/events{/privacy}","received_events_url":"https://api.github.com/users/lizards-and-pumpkins/received_events","type":"Organization","site_admin":false},"repo":{"id":25209535,"name":"catalog","full_name":"lizards-and-pumpkins/catalog","owner":{"login":"lizards-and-pumpkins","id":8191923,"avatar_url":"https://avatars.githubusercontent.com/u/8191923?v=3","gravatar_id":"","url":"https://api.github.com/users/lizards-and-pumpkins","html_url":"https://github.com/lizards-and-pumpkins","followers_url":"https://api.github.com/users/lizards-and-pumpkins/followers","following_url":"https://api.github.com/users/lizards-and-pumpkins/following{/other_user}","gists_url":"https://api.github.com/users/lizards-and-pumpkins/gists{/gist_id}","starred_url":"https://api.github.com/users/lizards-and-pumpkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizards-and-pumpkins/subscriptions","organizations_url":"https://api.github.com/users/lizards-and-pumpkins/orgs","repos_url":"https://api.github.com/users/lizards-and-pumpkins/repos","events_url":"https://api.github.com/users/lizards-and-pumpkins/events{/privacy}","received_events_url":"https://api.github.com/users/lizards-and-pumpkins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lizards-and-pumpkins/catalog","description":"Lizards and Pumpkins","fork":false,"url":"https://api.github.com/repos/lizards-and-pumpkins/catalog","forks_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/forks","keys_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/teams","hooks_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/hooks","issue_events_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/events{/number}","events_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/events","assignees_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/assignees{/user}","branches_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/branches{/branch}","tags_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/tags","blobs_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/languages","stargazers_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/stargazers","contributors_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/contributors","subscribers_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/subscribers","subscription_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/subscription","commits_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/contents/{+path}","compare_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/merges","archive_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/downloads","issues_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues{/number}","pulls_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/labels{/name}","releases_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/releases{/id}","deployments_url":"https://api.github.com/repos/lizards-and-pumpkins/catalog/deployments","created_at":"2014-10-14T13:57:56Z","updated_at":"2016-10-15T22:15:04Z","pushed_at":"2016-10-17T13:31:39Z","git_url":"git://github.com/lizards-and-pumpkins/catalog.git","ssh_url":"git@github.com:lizards-and-pumpkins/catalog.git","clone_url":"https://github.com/lizards-and-pumpkins/catalog.git","svn_url":"https://github.com/lizards-and-pumpkins/catalog","homepage":"lizardsandpumpkins.com","size":19159,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":66,"forks":0,"open_issues":66,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941"},"html":{"href":"https://github.com/lizards-and-pumpkins/catalog/pull/941"},"issue":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/941"},"comments":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/lizards-and-pumpkins/catalog/statuses/12d916dabed907f7c16fa7b2a2bffedb837ddb63"}}}}
{"actor":{"display_login":"Vinai"}}