{"action":"created","issue":{"url":"https://api.github.com/repos/symengine/symengine/issues/772","repository_url":"https://api.github.com/repos/symengine/symengine","labels_url":"https://api.github.com/repos/symengine/symengine/issues/772/labels{/name}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/772/comments","events_url":"https://api.github.com/repos/symengine/symengine/issues/772/events","html_url":"https://github.com/symengine/symengine/pull/772","id":127744973,"number":772,"title":"implemented parsing (string -> Basic)","user":{"login":"srajangarg","id":8615180,"avatar_url":"https://avatars.githubusercontent.com/u/8615180?v=3","gravatar_id":"","url":"https://api.github.com/users/srajangarg","html_url":"https://github.com/srajangarg","followers_url":"https://api.github.com/users/srajangarg/followers","following_url":"https://api.github.com/users/srajangarg/following{/other_user}","gists_url":"https://api.github.com/users/srajangarg/gists{/gist_id}","starred_url":"https://api.github.com/users/srajangarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajangarg/subscriptions","organizations_url":"https://api.github.com/users/srajangarg/orgs","repos_url":"https://api.github.com/users/srajangarg/repos","events_url":"https://api.github.com/users/srajangarg/events{/privacy}","received_events_url":"https://api.github.com/users/srajangarg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-01-20T17:52:45Z","updated_at":"2016-02-07T17:11:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/772","html_url":"https://github.com/symengine/symengine/pull/772","diff_url":"https://github.com/symengine/symengine/pull/772.diff","patch_url":"https://github.com/symengine/symengine/pull/772.patch"},"body":"* [x] Implement a basic integer parser, with all basic operations\r\n* [x] Add support for symbols (any token which has even one non-digit character, is considered a symbol)\r\n* [x] Change styling and formatting according to symengine, comment code properly\r\n* [x] Add support for symengine implemented functions\r\n* [x] Add support for symengine implemented constants\r\n* [x] Handle most errors, and their reporting\r\n* [x] Handle entered doubles (any numerical token with exactly a single '.' is converted to RealDouble)\r\n* [x] Add support for function_symbol\r\n* [x] Add support for complex numbers"},"comment":{"url":"https://api.github.com/repos/symengine/symengine/issues/comments/181051873","html_url":"https://github.com/symengine/symengine/pull/772#issuecomment-181051873","issue_url":"https://api.github.com/repos/symengine/symengine/issues/772","id":181051873,"user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"created_at":"2016-02-07T17:11:08Z","updated_at":"2016-02-07T17:11:08Z","body":"Looks good to me. Can you add a header file `parser.h` and have just one method like `RCP<const Basic> parse(const std::string& s)` which would call the `ExpressionParser` in the implementation file?"}}