{"action":"created","issue":{"url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/880","repository_url":"https://api.github.com/repos/aksonov/react-native-router-flux","labels_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/880/labels{/name}","comments_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/880/comments","events_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/880/events","html_url":"https://github.com/aksonov/react-native-router-flux/issues/880","id":162946734,"number":880,"title":"Right button Icon sizes not working? Where to override styling for navigation icons.","user":{"login":"cyphire","id":337798,"avatar_url":"https://avatars.githubusercontent.com/u/337798?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphire","html_url":"https://github.com/cyphire","followers_url":"https://api.github.com/users/cyphire/followers","following_url":"https://api.github.com/users/cyphire/following{/other_user}","gists_url":"https://api.github.com/users/cyphire/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphire/subscriptions","organizations_url":"https://api.github.com/users/cyphire/orgs","repos_url":"https://api.github.com/users/cyphire/repos","events_url":"https://api.github.com/users/cyphire/events{/privacy}","received_events_url":"https://api.github.com/users/cyphire/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-29T14:54:44Z","updated_at":"2016-06-30T21:38:06Z","closed_at":"2016-06-30T21:38:06Z","body":"### Version\r\nTell us which versions you are using: \r\n\r\n- react-native-router-flux v3.30.3\r\n- react-native v0.28.0\r\n\r\n### Expected behaviour\r\n\r\nBoth the right and left icons should be the same size.\r\n\r\n### Actual behaviour\r\n\r\nBoth icons (right and left) which are the same file (for the purposes of debugging this) render differently.  Also they are not in their proper place. (left icon crowds the [title).]\r\n\r\n(url\r\n![screen-2016-06-29_09-48-39](https://cloud.githubusercontent.com/assets/337798/16456836/f408f96e-3dde-11e6-85ff-9491b03d82e0.jpg)\r\n)\r\n\r\n\r\n### Steps to reproduce\r\n\r\n1. set default icon in my scene.\r\n2.\r\n3.\r\n\r\n```\r\nimport React, {Component} from 'react';\r\nimport { Scene, Router, Route, NavigationBar, Schema, TabBar, Modal, Actions, Reducer, DefaultRenderer} from 'react-native-router-flux'\r\nimport {View, StyleSheet, Alert, Navigator, } from 'react-native';\r\nimport {Drawer} from 'react-native-drawer';\r\nimport SideDrawer       from './components/nav/sidedrawer.js';\r\n\r\n\r\nimport {codePush} from 'react-native-code-push';\r\n\r\nimport Login          from  './components/authentication/login';\r\nimport Register          from  './components/authentication/register';\r\n\r\nimport Add_New          from  './components/adding/add_new';\r\nimport Main_View        from  './main_view';\r\nimport LeftPanel        from  './components/nav/leftpanel';\r\nimport RightPanel       from  './components/nav/rightpanel';\r\nimport RightPanel2      from  './components/nav/rightpanel2';\r\nimport Coll_Entry        from  './collection_entry';\r\nimport Start_Page        from  './start_page';\r\nimport Cat_Chooser        from './components/common/cat_chooser';\r\n\r\n\r\n/* NavigationSceneRendererProps */\r\n  const getSceneStyle = ( props, computedProps) => {\r\n    const style = {\r\n      flex: 1,\r\n      backgroundColor: '#fff',\r\n      shadowColor: null,\r\n      shadowOffset: null,\r\n      shadowOpacity: null,\r\n      shadowRadius: null,\r\n    };\r\n\r\n    if (computedProps.isActive) {\r\n      style.marginTop = computedProps.hideNavBar ? 0 : 64;\r\n      style.marginBottom = computedProps.hideTabBar ? 0 : 50;\r\n    }\r\n    return style;\r\n  }\r\n\r\nexport default class App extends Component {\r\n  constructor(props) {\r\n    super(props);\r\n\r\n    this.onPressRight = this.onPressRight.bind(this);\r\n\r\n    this.aDebug_mode = true;\r\n  }\r\n\r\n  //For microsoft codesync...\r\n  componentDidMount() {\r\n\r\n      // codePush.sync();\r\n// Currently crashes, get it working\r\nif (false) {\r\n  //code\r\n\r\n  codePush.checkForUpdate()\r\n     .then((update) => {\r\n       if (!update) {\r\n           console.log(\"The app is up to date!\");\r\n       } else {\r\n          alert(\"An update is available! Should we download it?\");\r\n       }\r\n   });\r\n\r\n}\r\n  }\r\n\r\n  onPressLeft () {\r\n  // Woot, don't have to shake the android, make a debug_mode, with extra button on action menu (left menu) to purposly crash!\r\n    Actions.left_panel({data: {dm: this.aDebug_mode}});\r\n  }\r\n\r\n  onPressLeft2 () {\r\n    Actions.pop();\r\n  }\r\n\r\n  onPressRight() {\r\n    Actions.rightpanel({data: {dm: this.aDebug_mode}});\r\n  }\r\n\r\n  // No more back buttons!!!    Actions.pop();\r\n  onPressRight2() {\r\n\r\n    Actions.rightpanel2({data: {dm: this.aDebug_mode}});\r\n  }\r\n\r\n  render() {\r\n    return (\r\n      <Router  name='root' navigationBarStyle={styles.navBar} titleStyle={styles.navTitle} sceneStyle={styles.routerScene} oh={Navigator.NavigationBar.Styles.General.NavBarHeight}>\r\n        <Scene key=\"rr\"\r\n              component={Drawer}\r\n              onLeft={()=>this.onPressLeft()}\r\n              onRight={() => this.onPressRight2()}\r\n              leftButtonImage ={require('./icons/left.png')}\r\n              rightButtonImage ={require('./icons/left.png')}\r\n              >\r\n                <Scene key=\"coll_entry\" component={Coll_Entry} title=\"Welcome to BinStuffer\" initial/>\r\n        </Scene>\r\n        <Scene key=\"rmain\"\r\n              component={Drawer}\r\n              onLeft={()=>this.onPressLeft()}\r\n              onRight={() => this.onPressRight2()}\r\n              rightButtonImage ={require('./icons/left.png')}\r\n              leftButtonImage ={require('./icons/left.png')}\r\n              >\r\n              <Scene key=\"main_view\"  component={Main_View} title=\"Show Bins-Items\"/>\r\n        </Scene>\r\n              <Scene key=\"add_new\" component={Add_New} title=\"Add New Bins-Items\"/>\r\n              <Scene key=\"cat_chooser\" component={Cat_Chooser} title=\"Major Categories\"/>\r\n              <Scene key=\"rightpanel\"  component={RightPanel} title=\"SysAction Panel\" />\r\n              <Scene key=\"rightpanel2\"  component={RightPanel2} title=\"Action Panel\" />\r\n              <Scene key=\"left_panel\"  component={LeftPanel} title=\"System Panel\" />\r\n\r\n\t  </Router>\r\n    )\r\n  }\r\n}\r\n\r\nvar styles = StyleSheet.create({\r\n  navBar: {\r\n    flex: 1,\r\n    flexDirection: 'row',\r\n    alignItems: 'center',\r\n    justifyContent: 'center',\r\n    backgroundColor: 'white',\r\n    height: 60,\r\n  },\r\n  navTitle: {\r\n    color: 'grey',\r\n    // changing navbar title color\r\n  },\r\n  routerScene: {\r\n    paddingTop: Navigator.NavigationBar.Styles.General.NavBarHeight, // some navbar padding to avoid content overlap\r\n  },\r\n});\r\n\r\nmodule.exports = App;\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/comments/229796494","html_url":"https://github.com/aksonov/react-native-router-flux/issues/880#issuecomment-229796494","issue_url":"https://api.github.com/repos/aksonov/react-native-router-flux/issues/880","id":229796494,"user":{"login":"cyphire","id":337798,"avatar_url":"https://avatars.githubusercontent.com/u/337798?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphire","html_url":"https://github.com/cyphire","followers_url":"https://api.github.com/users/cyphire/followers","following_url":"https://api.github.com/users/cyphire/following{/other_user}","gists_url":"https://api.github.com/users/cyphire/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphire/subscriptions","organizations_url":"https://api.github.com/users/cyphire/orgs","repos_url":"https://api.github.com/users/cyphire/repos","events_url":"https://api.github.com/users/cyphire/events{/privacy}","received_events_url":"https://api.github.com/users/cyphire/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T21:38:06Z","updated_at":"2016-06-30T21:38:06Z","body":"I'm going to close this issue.  With no changes to the code, and just creating an assembleRelease and and installRelease then putting it on an actual device, the error goes away.  Now building with debug in local env. it looks good again.  It is strange that rebuilds sometimes make the problem go away, but it works now!\r\n\r\nThanks cridenour!"}}
{"actor":{"display_login":"cyphire"}}