{"action":"opened","number":4641,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/4641","id":84176633,"html_url":"https://github.com/apple/swift/pull/4641","diff_url":"https://github.com/apple/swift/pull/4641.diff","patch_url":"https://github.com/apple/swift/pull/4641.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/4641","number":4641,"state":"open","locked":false,"title":"[sil-cse] Fix a bug in the CSE of open_existential_ref instructions","user":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars.githubusercontent.com/u/15327066?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\n––– CCC Information –––\r\n• Explanation: It is a correctness fix for the CSE of init_existential_ref\r\n• Scope of Issue: SIL verifier would asset in certain cases. Reported by external user.\r\n• Origination: https://bugs.swift.org/browse/SR-2545  rdar://problem/28136015\r\n• Risk: Pretty low. It fixes some cases which would result in a verifier assertion.\r\n• Reviewed By: Erik Eckstein\r\n• Testing: Verified locally and using a CI @please test\r\n• Directions for QA: No special directions. The patch includes unit tests.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-2545](https://bugs.swift.org/browse/SR-2545).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n\r\nDetailed description\r\n\r\nWhen performing a CSE of open_existential_ref instructions, we replace the new archetype by the old archetype by cloning the uses and re-mapping the archetypes. But we also need to consider that some of the uses of a open_existential_ref instruction (e.g. loads) may produce results depending on the opened archetype being replaced. Therefore, for every such use its own uses (and their uses) should be eventually recursively cloned and type-remapped as well if they depend on the opened archetype being replaced.\r\n\r\nFixes rdar://28136015 and https://bugs.swift.org/browse/SR-2545","created_at":"2016-09-06T18:56:09Z","updated_at":"2016-09-06T18:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/4641/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/4641/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/4641/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/36a0bdeff24063379a60b2ef7226b4820ce1142e","head":{"label":"swiftix:swift-3.0-branch-rdar-28136015","ref":"swift-3.0-branch-rdar-28136015","sha":"36a0bdeff24063379a60b2ef7226b4820ce1142e","user":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars.githubusercontent.com/u/15327066?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"repo":{"id":47780480,"name":"swift","full_name":"swiftix/swift","owner":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars.githubusercontent.com/u/15327066?v=3","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swiftix/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/swiftix/swift","forks_url":"https://api.github.com/repos/swiftix/swift/forks","keys_url":"https://api.github.com/repos/swiftix/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftix/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftix/swift/teams","hooks_url":"https://api.github.com/repos/swiftix/swift/hooks","issue_events_url":"https://api.github.com/repos/swiftix/swift/issues/events{/number}","events_url":"https://api.github.com/repos/swiftix/swift/events","assignees_url":"https://api.github.com/repos/swiftix/swift/assignees{/user}","branches_url":"https://api.github.com/repos/swiftix/swift/branches{/branch}","tags_url":"https://api.github.com/repos/swiftix/swift/tags","blobs_url":"https://api.github.com/repos/swiftix/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftix/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftix/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftix/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftix/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftix/swift/languages","stargazers_url":"https://api.github.com/repos/swiftix/swift/stargazers","contributors_url":"https://api.github.com/repos/swiftix/swift/contributors","subscribers_url":"https://api.github.com/repos/swiftix/swift/subscribers","subscription_url":"https://api.github.com/repos/swiftix/swift/subscription","commits_url":"https://api.github.com/repos/swiftix/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftix/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftix/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftix/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftix/swift/contents/{+path}","compare_url":"https://api.github.com/repos/swiftix/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftix/swift/merges","archive_url":"https://api.github.com/repos/swiftix/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftix/swift/downloads","issues_url":"https://api.github.com/repos/swiftix/swift/issues{/number}","pulls_url":"https://api.github.com/repos/swiftix/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftix/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftix/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftix/swift/labels{/name}","releases_url":"https://api.github.com/repos/swiftix/swift/releases{/id}","deployments_url":"https://api.github.com/repos/swiftix/swift/deployments","created_at":"2015-12-10T18:41:01Z","updated_at":"2016-02-27T06:09:30Z","pushed_at":"2016-09-06T16:31:55Z","git_url":"git://github.com/swiftix/swift.git","ssh_url":"git@github.com:swiftix/swift.git","clone_url":"https://github.com/swiftix/swift.git","svn_url":"https://github.com/swiftix/swift","homepage":"","size":116637,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:swift-3.0-branch","ref":"swift-3.0-branch","sha":"da4d996444fd410092ef565fefcc7defd38d0fc1","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-09-06T17:07:12Z","pushed_at":"2016-09-06T18:53:17Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":180013,"stargazers_count":33662,"watchers_count":33662,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4750,"mirror_url":null,"open_issues_count":87,"forks":4750,"open_issues":87,"watchers":33662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/4641"},"html":{"href":"https://github.com/apple/swift/pull/4641"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/4641"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/4641/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/4641/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/4641/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/36a0bdeff24063379a60b2ef7226b4820ce1142e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":50,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"swiftix"}}