{"action":"created","comment":{"url":"https://api.github.com/repos/google/google-auth-library-java/pulls/comments/55867999","id":55867999,"diff_hunk":"@@ -26,6 +26,8 @@\n    * populated in headers or other context. The operation can block and fail to complete and may do\n    * things such as refreshing access tokens.\n    *\n+   * <p>If a key ends with {@code \"-bin\"}, its values are base64-encoded binary data.\n+   *\n    * @throws IOException if there was an error getting up-to-date access.","path":"credentials/java/com/google/auth/Credentials.java","position":6,"original_position":6,"commit_id":"b54e7ed64447993446d6405427c7d9ec2b1395a2","original_commit_id":"b54e7ed64447993446d6405427c7d9ec2b1395a2","user":{"login":"anthmgoogle","id":6653712,"avatar_url":"https://avatars.githubusercontent.com/u/6653712?v=3","gravatar_id":"","url":"https://api.github.com/users/anthmgoogle","html_url":"https://github.com/anthmgoogle","followers_url":"https://api.github.com/users/anthmgoogle/followers","following_url":"https://api.github.com/users/anthmgoogle/following{/other_user}","gists_url":"https://api.github.com/users/anthmgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/anthmgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthmgoogle/subscriptions","organizations_url":"https://api.github.com/users/anthmgoogle/orgs","repos_url":"https://api.github.com/users/anthmgoogle/repos","events_url":"https://api.github.com/users/anthmgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/anthmgoogle/received_events","type":"User","site_admin":false},"body":"It is not clear how this comment relates to the inputs and outputs of this abstract method. Can you clarify which specific  values have this convention and what that means. It may be that this convention should be described somewhere other than the getRequestMetadata method.","created_at":"2016-03-11T18:29:53Z","updated_at":"2016-03-11T18:29:53Z","html_url":"https://github.com/google/google-auth-library-java/pull/59#discussion_r55867999","pull_request_url":"https://api.github.com/repos/google/google-auth-library-java/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/comments/55867999"},"html":{"href":"https://github.com/google/google-auth-library-java/pull/59#discussion_r55867999"},"pull_request":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/google/google-auth-library-java/pulls/59","id":61788667,"html_url":"https://github.com/google/google-auth-library-java/pull/59","diff_url":"https://github.com/google/google-auth-library-java/pull/59.diff","patch_url":"https://github.com/google/google-auth-library-java/pull/59.patch","issue_url":"https://api.github.com/repos/google/google-auth-library-java/issues/59","number":59,"state":"open","locked":false,"title":"Standardize the naming convention of base64-encoded binary data.","user":{"login":"zhangkun83","id":9053690,"avatar_url":"https://avatars.githubusercontent.com/u/9053690?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangkun83","html_url":"https://github.com/zhangkun83","followers_url":"https://api.github.com/users/zhangkun83/followers","following_url":"https://api.github.com/users/zhangkun83/following{/other_user}","gists_url":"https://api.github.com/users/zhangkun83/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangkun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangkun83/subscriptions","organizations_url":"https://api.github.com/users/zhangkun83/orgs","repos_url":"https://api.github.com/users/zhangkun83/repos","events_url":"https://api.github.com/users/zhangkun83/events{/privacy}","received_events_url":"https://api.github.com/users/zhangkun83/received_events","type":"User","site_admin":false},"body":"I am working on populating our internal (prod) authentication object onto wire in gRPC.  I am going to use `Credentials`, and because the authentication object is serialized as binary headers, I will base64-encode them.\r\n\r\nThe `Credentials` object will be passed to gRPC `ClientAuthInterceptor` and populated to gRPC `Metadata`, which accepts binary value (`byte[]`) when the key ends with `\"-bin\"`, and string value otherwise.  Therefore, `ClientAuthInterceptor` needs to decode the base64-encoded binary headers returned by `Crendentials`, and pass through the others.\r\n\r\n`ClientAuthInterceptor` could use `\"-bin\"` as the indicator. However, because it consumes any `Crendentials` implementation, it's not safe for it to rely on this indicator unless it's defined on the `Credentials` interface.\r\n\r\nThis is a documentation-only no-op change.  I have talked with @ejona86, and he is OK with this change.","created_at":"2016-03-04T23:47:38Z","updated_at":"2016-03-11T18:29:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca597785d3cc45663dbaf2351a35dd1308f374fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/google-auth-library-java/pulls/59/commits","review_comments_url":"https://api.github.com/repos/google/google-auth-library-java/pulls/59/comments","review_comment_url":"https://api.github.com/repos/google/google-auth-library-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/google-auth-library-java/issues/59/comments","statuses_url":"https://api.github.com/repos/google/google-auth-library-java/statuses/b54e7ed64447993446d6405427c7d9ec2b1395a2","head":{"label":"zhangkun83:binary_headers","ref":"binary_headers","sha":"b54e7ed64447993446d6405427c7d9ec2b1395a2","user":{"login":"zhangkun83","id":9053690,"avatar_url":"https://avatars.githubusercontent.com/u/9053690?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangkun83","html_url":"https://github.com/zhangkun83","followers_url":"https://api.github.com/users/zhangkun83/followers","following_url":"https://api.github.com/users/zhangkun83/following{/other_user}","gists_url":"https://api.github.com/users/zhangkun83/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangkun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangkun83/subscriptions","organizations_url":"https://api.github.com/users/zhangkun83/orgs","repos_url":"https://api.github.com/users/zhangkun83/repos","events_url":"https://api.github.com/users/zhangkun83/events{/privacy}","received_events_url":"https://api.github.com/users/zhangkun83/received_events","type":"User","site_admin":false},"repo":{"id":53171247,"name":"google-auth-library-java","full_name":"zhangkun83/google-auth-library-java","owner":{"login":"zhangkun83","id":9053690,"avatar_url":"https://avatars.githubusercontent.com/u/9053690?v=3","gravatar_id":"","url":"https://api.github.com/users/zhangkun83","html_url":"https://github.com/zhangkun83","followers_url":"https://api.github.com/users/zhangkun83/followers","following_url":"https://api.github.com/users/zhangkun83/following{/other_user}","gists_url":"https://api.github.com/users/zhangkun83/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangkun83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangkun83/subscriptions","organizations_url":"https://api.github.com/users/zhangkun83/orgs","repos_url":"https://api.github.com/users/zhangkun83/repos","events_url":"https://api.github.com/users/zhangkun83/events{/privacy}","received_events_url":"https://api.github.com/users/zhangkun83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhangkun83/google-auth-library-java","description":null,"fork":true,"url":"https://api.github.com/repos/zhangkun83/google-auth-library-java","forks_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/forks","keys_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/teams","hooks_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/hooks","issue_events_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/issues/events{/number}","events_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/events","assignees_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/assignees{/user}","branches_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/branches{/branch}","tags_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/tags","blobs_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/statuses/{sha}","languages_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/languages","stargazers_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/stargazers","contributors_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/contributors","subscribers_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/subscribers","subscription_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/subscription","commits_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/contents/{+path}","compare_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/merges","archive_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/downloads","issues_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/issues{/number}","pulls_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/pulls{/number}","milestones_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/milestones{/number}","notifications_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/labels{/name}","releases_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/releases{/id}","deployments_url":"https://api.github.com/repos/zhangkun83/google-auth-library-java/deployments","created_at":"2016-03-04T23:06:20Z","updated_at":"2016-03-04T23:06:21Z","pushed_at":"2016-03-04T23:44:07Z","git_url":"git://github.com/zhangkun83/google-auth-library-java.git","ssh_url":"git@github.com:zhangkun83/google-auth-library-java.git","clone_url":"https://github.com/zhangkun83/google-auth-library-java.git","svn_url":"https://github.com/zhangkun83/google-auth-library-java","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c4a7045842870d4d97b7bf6fd254a20bf27e528e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":30676648,"name":"google-auth-library-java","full_name":"google/google-auth-library-java","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/google-auth-library-java","description":null,"fork":false,"url":"https://api.github.com/repos/google/google-auth-library-java","forks_url":"https://api.github.com/repos/google/google-auth-library-java/forks","keys_url":"https://api.github.com/repos/google/google-auth-library-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/google-auth-library-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/google-auth-library-java/teams","hooks_url":"https://api.github.com/repos/google/google-auth-library-java/hooks","issue_events_url":"https://api.github.com/repos/google/google-auth-library-java/issues/events{/number}","events_url":"https://api.github.com/repos/google/google-auth-library-java/events","assignees_url":"https://api.github.com/repos/google/google-auth-library-java/assignees{/user}","branches_url":"https://api.github.com/repos/google/google-auth-library-java/branches{/branch}","tags_url":"https://api.github.com/repos/google/google-auth-library-java/tags","blobs_url":"https://api.github.com/repos/google/google-auth-library-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/google-auth-library-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/google-auth-library-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/google-auth-library-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/google-auth-library-java/statuses/{sha}","languages_url":"https://api.github.com/repos/google/google-auth-library-java/languages","stargazers_url":"https://api.github.com/repos/google/google-auth-library-java/stargazers","contributors_url":"https://api.github.com/repos/google/google-auth-library-java/contributors","subscribers_url":"https://api.github.com/repos/google/google-auth-library-java/subscribers","subscription_url":"https://api.github.com/repos/google/google-auth-library-java/subscription","commits_url":"https://api.github.com/repos/google/google-auth-library-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/google-auth-library-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/google-auth-library-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/google-auth-library-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/google-auth-library-java/contents/{+path}","compare_url":"https://api.github.com/repos/google/google-auth-library-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/google-auth-library-java/merges","archive_url":"https://api.github.com/repos/google/google-auth-library-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/google-auth-library-java/downloads","issues_url":"https://api.github.com/repos/google/google-auth-library-java/issues{/number}","pulls_url":"https://api.github.com/repos/google/google-auth-library-java/pulls{/number}","milestones_url":"https://api.github.com/repos/google/google-auth-library-java/milestones{/number}","notifications_url":"https://api.github.com/repos/google/google-auth-library-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/google-auth-library-java/labels{/name}","releases_url":"https://api.github.com/repos/google/google-auth-library-java/releases{/id}","deployments_url":"https://api.github.com/repos/google/google-auth-library-java/deployments","created_at":"2015-02-12T00:06:15Z","updated_at":"2016-03-08T05:21:13Z","pushed_at":"2016-03-04T23:47:39Z","git_url":"git://github.com/google/google-auth-library-java.git","ssh_url":"git@github.com:google/google-auth-library-java.git","clone_url":"https://github.com/google/google-auth-library-java.git","svn_url":"https://github.com/google/google-auth-library-java","homepage":null,"size":191,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":16,"forks":27,"open_issues":16,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/59"},"html":{"href":"https://github.com/google/google-auth-library-java/pull/59"},"issue":{"href":"https://api.github.com/repos/google/google-auth-library-java/issues/59"},"comments":{"href":"https://api.github.com/repos/google/google-auth-library-java/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/google-auth-library-java/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/google/google-auth-library-java/statuses/b54e7ed64447993446d6405427c7d9ec2b1395a2"}}}}