{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/59125266","id":59125266,"diff_hunk":"@@ -271,25 +272,23 @@ namespace Js\n             doneConversion = true;\n #endif\n         }\n-        __finally\n+        catch(...)","path":"lib/Runtime/Types/ES5ArrayTypeHandler.cpp","position":24,"original_position":24,"commit_id":"2e6eb3d199addfbc596770e8f85cc3be72b154ce","original_commit_id":"2e6eb3d199addfbc596770e8f85cc3be72b154ce","user":{"login":"digitalinfinity","id":158390,"avatar_url":"https://avatars.githubusercontent.com/u/158390?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalinfinity","html_url":"https://github.com/digitalinfinity","followers_url":"https://api.github.com/users/digitalinfinity/followers","following_url":"https://api.github.com/users/digitalinfinity/following{/other_user}","gists_url":"https://api.github.com/users/digitalinfinity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalinfinity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalinfinity/subscriptions","organizations_url":"https://api.github.com/users/digitalinfinity/orgs","repos_url":"https://api.github.com/users/digitalinfinity/repos","events_url":"https://api.github.com/users/digitalinfinity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalinfinity/received_events","type":"User","site_admin":false},"body":"Is this commit slightly stale or is there a reason you decided to go with catch(...) instead of catch (Js::ExceptionBase)?","created_at":"2016-04-10T01:52:10Z","updated_at":"2016-04-10T01:52:10Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/726#discussion_r59125266","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/59125266"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/726#discussion_r59125266"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726","id":65075613,"html_url":"https://github.com/Microsoft/ChakraCore/pull/726","diff_url":"https://github.com/Microsoft/ChakraCore/pull/726.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/726.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/726","number":726,"state":"open","locked":false,"title":"cross platform: Runtime/types Part 2/2","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-03T18:10:34Z","updated_at":"2016-04-10T01:52:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bb70f5443a7e22579e0c93096b7ee2b7a3989eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/726/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/2e6eb3d199addfbc596770e8f85cc3be72b154ce","head":{"label":"obastemur:pp1","ref":"pp1","sha":"2e6eb3d199addfbc596770e8f85cc3be72b154ce","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"repo":{"id":53002057,"name":"ChakraCore","full_name":"obastemur/ChakraCore","owner":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obastemur/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/obastemur/ChakraCore","forks_url":"https://api.github.com/repos/obastemur/ChakraCore/forks","keys_url":"https://api.github.com/repos/obastemur/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obastemur/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obastemur/ChakraCore/teams","hooks_url":"https://api.github.com/repos/obastemur/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/obastemur/ChakraCore/events","assignees_url":"https://api.github.com/repos/obastemur/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/obastemur/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/obastemur/ChakraCore/tags","blobs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obastemur/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/obastemur/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obastemur/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/obastemur/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/obastemur/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/obastemur/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/obastemur/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/obastemur/ChakraCore/subscription","commits_url":"https://api.github.com/repos/obastemur/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/obastemur/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/obastemur/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/obastemur/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/obastemur/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obastemur/ChakraCore/merges","archive_url":"https://api.github.com/repos/obastemur/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obastemur/ChakraCore/downloads","issues_url":"https://api.github.com/repos/obastemur/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/obastemur/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/obastemur/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/obastemur/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obastemur/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/obastemur/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/obastemur/ChakraCore/deployments","created_at":"2016-03-02T22:43:37Z","updated_at":"2016-03-02T22:43:53Z","pushed_at":"2016-04-09T11:43:44Z","git_url":"git://github.com/obastemur/ChakraCore.git","ssh_url":"git@github.com:obastemur/ChakraCore.git","clone_url":"https://github.com/obastemur/ChakraCore.git","svn_url":"https://github.com/obastemur/ChakraCore","homepage":null,"size":25049,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:linux","ref":"linux","sha":"e7fc09c0679eadd91ac6b99c532568c533a5fb67","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-04-09T20:06:58Z","pushed_at":"2016-04-09T11:45:29Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":29609,"stargazers_count":5077,"watchers_count":5077,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"open_issues_count":131,"forks":551,"open_issues":131,"watchers":5077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/726"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/726"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/726/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/726/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/2e6eb3d199addfbc596770e8f85cc3be72b154ce"}}}}