{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/93815498","pull_request_review_id":14352061,"id":93815498,"diff_hunk":"@@ -0,0 +1,47 @@\n+// @flow weak\n+\n+import React, { PropTypes, Component } from 'react';\n+import { createStyleSheet } from 'jss-theme-reactor';\n+import Input from 'material-ui/Input';\n+import InputLabel from 'material-ui/Input/InputLabel';\n+import FormControl from 'material-ui/Form/FormControl';\n+\n+const styleSheet = createStyleSheet('TextFields', () => ({","path":"docs/site/src/demos/text-fields/ComposedTextField.js","position":9,"original_position":9,"commit_id":"c1f85800686ad25e3c1b9ec880650b901986e63e","original_commit_id":"c1f85800686ad25e3c1b9ec880650b901986e63e","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"`'CompleteTextField'`","created_at":"2016-12-24T10:21:37Z","updated_at":"2016-12-24T10:39:00Z","html_url":"https://github.com/callemall/material-ui/pull/5801#discussion_r93815498","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/5801","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/93815498"},"html":{"href":"https://github.com/callemall/material-ui/pull/5801#discussion_r93815498"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5801"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5801","id":98445638,"html_url":"https://github.com/callemall/material-ui/pull/5801","diff_url":"https://github.com/callemall/material-ui/pull/5801.diff","patch_url":"https://github.com/callemall/material-ui/pull/5801.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5801","number":5801,"state":"open","locked":false,"title":"Updates/cleanup to TextField and related components","user":{"login":"nathanmarks","id":4420103,"avatar_url":"https://avatars.githubusercontent.com/u/4420103?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanmarks","html_url":"https://github.com/nathanmarks","followers_url":"https://api.github.com/users/nathanmarks/followers","following_url":"https://api.github.com/users/nathanmarks/following{/other_user}","gists_url":"https://api.github.com/users/nathanmarks/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanmarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanmarks/subscriptions","organizations_url":"https://api.github.com/users/nathanmarks/orgs","repos_url":"https://api.github.com/users/nathanmarks/repos","events_url":"https://api.github.com/users/nathanmarks/events{/privacy}","received_events_url":"https://api.github.com/users/nathanmarks/received_events","type":"User","site_admin":false},"body":"Hit a few snags with our textfield setup on next (that I never properly \"finished\" after I started it previously) while developing the `Select`.\r\n\r\nMade a bunch of changes to better accommodate different control types with some common form+input components.\r\n\r\n- `FormControl` is the new equivalent of the current `TextField` (in terms of handling form control state) but is designed for use with different types of inputs, not strictly `TextField`.\r\n- `FormControl` has been designed with a context based API instead of checking child types and conditionally cloning with various props. This previous method was very brittle and inflexible which made it hard to use with other input types.\r\n- `TextFieldInput` and `TextFieldLabel` have been changed to `Input` and `InputLabel`.\r\n- `TextField` is now a wrapper component with a props based interface. It implements `shouldComponentUpdate`. This should help with out of the box form perf.\r\n\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\n","created_at":"2016-12-17T14:36:24Z","updated_at":"2016-12-24T10:39:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f487e138699b2fdffe8c0d810c94da664d14803","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5801/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5801/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5801/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/c1f85800686ad25e3c1b9ec880650b901986e63e","head":{"label":"nathanmarks:textfield-input-underline","ref":"textfield-input-underline","sha":"c1f85800686ad25e3c1b9ec880650b901986e63e","user":{"login":"nathanmarks","id":4420103,"avatar_url":"https://avatars.githubusercontent.com/u/4420103?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanmarks","html_url":"https://github.com/nathanmarks","followers_url":"https://api.github.com/users/nathanmarks/followers","following_url":"https://api.github.com/users/nathanmarks/following{/other_user}","gists_url":"https://api.github.com/users/nathanmarks/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanmarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanmarks/subscriptions","organizations_url":"https://api.github.com/users/nathanmarks/orgs","repos_url":"https://api.github.com/users/nathanmarks/repos","events_url":"https://api.github.com/users/nathanmarks/events{/privacy}","received_events_url":"https://api.github.com/users/nathanmarks/received_events","type":"User","site_admin":false},"repo":{"id":51347102,"name":"material-ui","full_name":"nathanmarks/material-ui","owner":{"login":"nathanmarks","id":4420103,"avatar_url":"https://avatars.githubusercontent.com/u/4420103?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanmarks","html_url":"https://github.com/nathanmarks","followers_url":"https://api.github.com/users/nathanmarks/followers","following_url":"https://api.github.com/users/nathanmarks/following{/other_user}","gists_url":"https://api.github.com/users/nathanmarks/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanmarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanmarks/subscriptions","organizations_url":"https://api.github.com/users/nathanmarks/orgs","repos_url":"https://api.github.com/users/nathanmarks/repos","events_url":"https://api.github.com/users/nathanmarks/events{/privacy}","received_events_url":"https://api.github.com/users/nathanmarks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanmarks/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/nathanmarks/material-ui","forks_url":"https://api.github.com/repos/nathanmarks/material-ui/forks","keys_url":"https://api.github.com/repos/nathanmarks/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanmarks/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanmarks/material-ui/teams","hooks_url":"https://api.github.com/repos/nathanmarks/material-ui/hooks","issue_events_url":"https://api.github.com/repos/nathanmarks/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/nathanmarks/material-ui/events","assignees_url":"https://api.github.com/repos/nathanmarks/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/nathanmarks/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/nathanmarks/material-ui/tags","blobs_url":"https://api.github.com/repos/nathanmarks/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanmarks/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanmarks/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanmarks/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanmarks/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanmarks/material-ui/languages","stargazers_url":"https://api.github.com/repos/nathanmarks/material-ui/stargazers","contributors_url":"https://api.github.com/repos/nathanmarks/material-ui/contributors","subscribers_url":"https://api.github.com/repos/nathanmarks/material-ui/subscribers","subscription_url":"https://api.github.com/repos/nathanmarks/material-ui/subscription","commits_url":"https://api.github.com/repos/nathanmarks/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanmarks/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanmarks/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanmarks/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanmarks/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/nathanmarks/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanmarks/material-ui/merges","archive_url":"https://api.github.com/repos/nathanmarks/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanmarks/material-ui/downloads","issues_url":"https://api.github.com/repos/nathanmarks/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/nathanmarks/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanmarks/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanmarks/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanmarks/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/nathanmarks/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/nathanmarks/material-ui/deployments","created_at":"2016-02-09T04:46:22Z","updated_at":"2016-02-09T04:46:24Z","pushed_at":"2016-12-24T02:29:36Z","git_url":"git://github.com/nathanmarks/material-ui.git","ssh_url":"git@github.com:nathanmarks/material-ui.git","clone_url":"https://github.com/nathanmarks/material-ui.git","svn_url":"https://github.com/nathanmarks/material-ui","homepage":"http://www.material-ui.com","size":65743,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:next","ref":"next","sha":"a5066c89ff32e3a1462dc9dc0c5cf7a9027f4836","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-12-24T09:28:04Z","pushed_at":"2016-12-24T10:18:57Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":77364,"stargazers_count":21956,"watchers_count":21956,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3908,"mirror_url":null,"open_issues_count":669,"forks":3908,"open_issues":669,"watchers":21956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5801"},"html":{"href":"https://github.com/callemall/material-ui/pull/5801"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5801"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5801/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5801/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5801/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/c1f85800686ad25e3c1b9ec880650b901986e63e"}}}}
{"actor":{"display_login":"oliviertassinari"}}