{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/87303747","pull_request_review_id":7521812,"id":87303747,"diff_hunk":"@@ -103,4 +103,9 @@\n \n   /** Converts the given string to a {@link Path}. */\n   Path toPath(String path);\n+\n+  /**\n+   * Delete files with the given {@code uris} if they exist.\n+   */\n+  void deleteIfExists(Collection<String> uris) throws IOException;","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/util/IOChannelFactory.java","position":8,"original_position":8,"commit_id":"c7b47962f48d560ccab78322edc22f06c4879d27","original_commit_id":"c7b47962f48d560ccab78322edc22f06c4879d27","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"I think the actual problem is that you modified `IOChannelFactory` rather than `FileOperations` in `FileBasedSink`, which is the place this code actually belong. You are right that `IOChannelFactory` does not have any delete functionality.\r\n\r\nThat already has a `remove` function you can use. Perhaps as-is, perhaps with a try and catch.","created_at":"2016-11-09T23:54:25Z","updated_at":"2016-11-09T23:54:25Z","html_url":"https://github.com/apache/incubator-beam/pull/1277#discussion_r87303747","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1277","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/87303747"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1277#discussion_r87303747"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1277"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1277","id":92253625,"html_url":"https://github.com/apache/incubator-beam/pull/1277","diff_url":"https://github.com/apache/incubator-beam/pull/1277.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1277.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1277","number":1277,"state":"open","locked":false,"title":"[BEAM-894] Using @Teardown to remove temp files from failed bundles in Write.WriteBundles.","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [ ] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\n","created_at":"2016-11-03T22:33:24Z","updated_at":"2016-11-09T23:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51220baa455d3539167986303aa365efabdaa361","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1277/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1277/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1277/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/c7b47962f48d560ccab78322edc22f06c4879d27","head":{"label":"peihe:write-teardown","ref":"write-teardown","sha":"c7b47962f48d560ccab78322edc22f06c4879d27","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"repo":{"id":52831526,"name":"incubator-beam","full_name":"peihe/incubator-beam","owner":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peihe/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/peihe/incubator-beam","forks_url":"https://api.github.com/repos/peihe/incubator-beam/forks","keys_url":"https://api.github.com/repos/peihe/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peihe/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peihe/incubator-beam/teams","hooks_url":"https://api.github.com/repos/peihe/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/peihe/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/peihe/incubator-beam/events","assignees_url":"https://api.github.com/repos/peihe/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/peihe/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/peihe/incubator-beam/tags","blobs_url":"https://api.github.com/repos/peihe/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peihe/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peihe/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/peihe/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peihe/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/peihe/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/peihe/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/peihe/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/peihe/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/peihe/incubator-beam/subscription","commits_url":"https://api.github.com/repos/peihe/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/peihe/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/peihe/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/peihe/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/peihe/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/peihe/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peihe/incubator-beam/merges","archive_url":"https://api.github.com/repos/peihe/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peihe/incubator-beam/downloads","issues_url":"https://api.github.com/repos/peihe/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/peihe/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/peihe/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/peihe/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peihe/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/peihe/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/peihe/incubator-beam/deployments","created_at":"2016-02-29T23:06:11Z","updated_at":"2016-02-29T23:06:15Z","pushed_at":"2016-11-09T21:22:15Z","git_url":"git://github.com/peihe/incubator-beam.git","ssh_url":"git@github.com:peihe/incubator-beam.git","clone_url":"https://github.com/peihe/incubator-beam.git","svn_url":"https://github.com/peihe/incubator-beam","homepage":null,"size":21225,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"baa7fb0317afa4a18462ed66ab0a7ba1e8eb2c89","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-11-09T16:07:03Z","pushed_at":"2016-11-09T23:43:40Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":34275,"stargazers_count":426,"watchers_count":426,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":62,"forks":263,"open_issues":62,"watchers":426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1277"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1277"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1277"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1277/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1277/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1277/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/c7b47962f48d560ccab78322edc22f06c4879d27"}}}}
{"actor":{"display_login":"dhalperi"}}