{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/android/issues/1416","labels_url":"https://api.github.com/repos/owncloud/android/issues/1416/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/android/issues/1416/comments","events_url":"https://api.github.com/repos/owncloud/android/issues/1416/events","html_url":"https://github.com/owncloud/android/pull/1416","id":125767928,"number":1416,"title":"#1413 share view enhancement","user":{"login":"AndyScherzinger","id":1315170,"avatar_url":"https://avatars.githubusercontent.com/u/1315170?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyScherzinger","html_url":"https://github.com/AndyScherzinger","followers_url":"https://api.github.com/users/AndyScherzinger/followers","following_url":"https://api.github.com/users/AndyScherzinger/following{/other_user}","gists_url":"https://api.github.com/users/AndyScherzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyScherzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyScherzinger/subscriptions","organizations_url":"https://api.github.com/users/AndyScherzinger/orgs","repos_url":"https://api.github.com/users/AndyScherzinger/repos","events_url":"https://api.github.com/users/AndyScherzinger/events{/privacy}","received_events_url":"https://api.github.com/users/AndyScherzinger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/android/labels/3%20-%20To%20review","name":"3 - To review","color":"CCCCCC"},{"url":"https://api.github.com/repos/owncloud/android/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-01-09T16:28:28Z","updated_at":"2016-01-12T17:13:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/android/pulls/1416","html_url":"https://github.com/owncloud/android/pull/1416","diff_url":"https://github.com/owncloud/android/pull/1416.diff","patch_url":"https://github.com/owncloud/android/pull/1416.patch"},"body":"For details and discussion please see #1413 \r\n\r\nFor reviewers, thing that have been done in this PR:\r\n* Moved from Switch zu AppComat Switch to have a material switch on all Android versions\r\n* changed paddings/margins according to the introduced standard value where fit\r\n* added user/group icons to items to also visually distinguish between user and group line items\r\n\r\npinging @jancborchardt for visual review, open issue imho is now that I added icons for user/group (see screenshots) each line has an icon on the left (visual indication user or group item) and one on the right (delete action). Both are grey at the moment, but only the right icon is an action. My idea would be to color the delete icon in blue to indicate it is as an action. What do you think. We can also stay with it the way it is right now, what ever choose :wink: \r\n\r\n**Detailed Screenshots (before/after)**\r\n\r\nBEFORE: Share screen (on Android v15) with old Holo style switcher\r\n![device-2016-01-09-171558](https://cloud.githubusercontent.com/assets/1315170/12217079/5401e766-b6f5-11e5-9e86-d9669d1fc279.png)\r\n\r\nAFTER: Share screen (on Android v15) with new Material style switcher, icons for user/group, Link items header being black and values being grey, switchers now top aligned to their corresponding headers\r\n![device-2016-01-09-163851](https://cloud.githubusercontent.com/assets/1315170/12217086/71fa4358-b6f5-11e5-8a32-e3a98b1c341b.png)\r\n\r\nAFTER: Share screen (on Android v23) with new Material style switcher, icons for user/group, Link items header being black and values being grey, switchers now top aligned to their corresponding headers\r\n![device-2016-01-09-162507](https://cloud.githubusercontent.com/assets/1315170/12217087/a33dab44-b6f5-11e5-82a7-d439427e0572.png)\r\n\r\nAFTER: Share screen (on Android v23) being empty\r\n![device-2016-01-09-170355](https://cloud.githubusercontent.com/assets/1315170/12217092/cb9b54ec-b6f5-11e5-92c5-6422fb817478.png)\r\n\r\nBEFORE: User search (on Android v23)\r\n![device-2016-01-09-170930](https://cloud.githubusercontent.com/assets/1315170/12217089/b589bf0e-b6f5-11e5-8601-0cc4f291dbf2.png)\r\n\r\nAFTER: User search (on Android v15) (this has been styled like this before, since this is a standard UI component of Android)\r\n![device-2016-01-09-164649](https://cloud.githubusercontent.com/assets/1315170/12217093/d194cd60-b6f5-11e5-91c5-61cfae0ff4d6.png)\r\n\r\nAFTER: User search (on Android v23)\r\n![device-2016-01-09-163300](https://cloud.githubusercontent.com/assets/1315170/12217094/df147dbe-b6f5-11e5-8e0d-e5abaa6608a8.png)\r\n\r\nFIXED: Passwort dialog, buttons now colored correctly in the accent coloring and not in the Android platform color + fixed padding\r\n![device-2016-01-09-162523](https://cloud.githubusercontent.com/assets/1315170/12217100/fc5e544e-b6f5-11e5-943d-789d8a8f9b61.png)\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/android/issues/comments/170978910","html_url":"https://github.com/owncloud/android/pull/1416#issuecomment-170978910","issue_url":"https://api.github.com/repos/owncloud/android/issues/1416","id":170978910,"user":{"login":"AndyScherzinger","id":1315170,"avatar_url":"https://avatars.githubusercontent.com/u/1315170?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyScherzinger","html_url":"https://github.com/AndyScherzinger","followers_url":"https://api.github.com/users/AndyScherzinger/followers","following_url":"https://api.github.com/users/AndyScherzinger/following{/other_user}","gists_url":"https://api.github.com/users/AndyScherzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyScherzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyScherzinger/subscriptions","organizations_url":"https://api.github.com/users/AndyScherzinger/orgs","repos_url":"https://api.github.com/users/AndyScherzinger/repos","events_url":"https://api.github.com/users/AndyScherzinger/events{/privacy}","received_events_url":"https://api.github.com/users/AndyScherzinger/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T17:13:34Z","updated_at":"2016-01-12T17:13:34Z","body":"@davivel @masensio this branch/PR has been tested on Android 6.0.1 on a Nexus5X and on NexusS-Android15-Emultator."}}