{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/76098249","id":76098249,"diff_hunk":"@@ -268,8 +268,9 @@ export default class Environment extends GlimmerEnvironment {\n \n   getComponentDefinition(path, parentMeta) {\n     let name = path[0];\n+    let owner = !!(parentMeta && parentMeta.owner) ? parentMeta.owner : this.owner;","path":"packages/ember-glimmer/lib/environment.js","position":19,"original_position":19,"commit_id":"4883411d204443d12f0184dee17bff7ee6d67cd5","original_commit_id":"b73b913f56b7b89ba5645d1e94412a711d13be05","user":{"login":"asakusuma","id":597574,"avatar_url":"https://avatars.githubusercontent.com/u/597574?v=3","gravatar_id":"","url":"https://api.github.com/users/asakusuma","html_url":"https://github.com/asakusuma","followers_url":"https://api.github.com/users/asakusuma/followers","following_url":"https://api.github.com/users/asakusuma/following{/other_user}","gists_url":"https://api.github.com/users/asakusuma/gists{/gist_id}","starred_url":"https://api.github.com/users/asakusuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asakusuma/subscriptions","organizations_url":"https://api.github.com/users/asakusuma/orgs","repos_url":"https://api.github.com/users/asakusuma/repos","events_url":"https://api.github.com/users/asakusuma/events{/privacy}","received_events_url":"https://api.github.com/users/asakusuma/received_events","type":"User","site_admin":false},"body":"Went to look into this more since I wrote this code, then noticed that `hasComponentDefinition` returns false in ember. Why is this?\r\n\r\nhttps://github.com/emberjs/ember.js/blob/5f5b9ae5f8c117c3dc45409b7f0d2272f042cb68/packages/ember-glimmer/lib/environment.js#L266","created_at":"2016-08-24T17:10:11Z","updated_at":"2016-08-24T17:10:11Z","html_url":"https://github.com/emberjs/ember.js/pull/14112#discussion_r76098249","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/14112","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/76098249"},"html":{"href":"https://github.com/emberjs/ember.js/pull/14112#discussion_r76098249"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14112"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/14112","id":82211325,"html_url":"https://github.com/emberjs/ember.js/pull/14112","diff_url":"https://github.com/emberjs/ember.js/pull/14112.diff","patch_url":"https://github.com/emberjs/ember.js/pull/14112.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/14112","number":14112,"state":"open","locked":false,"title":"[BUGFix beta] Fix basic component and helper resolution in engines","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"body":"A rebase and extension of #14055, this contains the following fixes:\r\n\r\n* Clone additional parent dependencies into engine instances. Specifically `service:-glimmer-environment` (only for glimmer) and `renderer:-dom` or `renderer:-inert`\r\n\r\n* Ensure that Cache lookups are performed using the correct owner.\r\n\r\n* Ensure that engines are destroyed _before_ top-level views so that top-level\r\nviews are not re-instantiated during engine teardown.","created_at":"2016-08-22T15:25:33Z","updated_at":"2016-08-24T17:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50fc962d98adbfbf04248f4535b352b6b2b85fbd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/14112/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/14112/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/14112/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/4883411d204443d12f0184dee17bff7ee6d67cd5","head":{"label":"dgeb:glimmer-owner","ref":"glimmer-owner","sha":"4883411d204443d12f0184dee17bff7ee6d67cd5","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"repo":{"id":3148649,"name":"ember.js","full_name":"dgeb/ember.js","owner":{"login":"dgeb","id":29122,"avatar_url":"https://avatars.githubusercontent.com/u/29122?v=3","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgeb/ember.js","description":"Ember.js - formerly known as SproutCore 2.0","fork":true,"url":"https://api.github.com/repos/dgeb/ember.js","forks_url":"https://api.github.com/repos/dgeb/ember.js/forks","keys_url":"https://api.github.com/repos/dgeb/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgeb/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgeb/ember.js/teams","hooks_url":"https://api.github.com/repos/dgeb/ember.js/hooks","issue_events_url":"https://api.github.com/repos/dgeb/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/dgeb/ember.js/events","assignees_url":"https://api.github.com/repos/dgeb/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/dgeb/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/dgeb/ember.js/tags","blobs_url":"https://api.github.com/repos/dgeb/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgeb/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgeb/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgeb/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgeb/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dgeb/ember.js/languages","stargazers_url":"https://api.github.com/repos/dgeb/ember.js/stargazers","contributors_url":"https://api.github.com/repos/dgeb/ember.js/contributors","subscribers_url":"https://api.github.com/repos/dgeb/ember.js/subscribers","subscription_url":"https://api.github.com/repos/dgeb/ember.js/subscription","commits_url":"https://api.github.com/repos/dgeb/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgeb/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgeb/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgeb/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgeb/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/dgeb/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgeb/ember.js/merges","archive_url":"https://api.github.com/repos/dgeb/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgeb/ember.js/downloads","issues_url":"https://api.github.com/repos/dgeb/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/dgeb/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dgeb/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dgeb/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgeb/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/dgeb/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/dgeb/ember.js/deployments","created_at":"2012-01-10T21:07:31Z","updated_at":"2015-03-23T17:40:23Z","pushed_at":"2016-08-22T22:58:37Z","git_url":"git://github.com/dgeb/ember.js.git","ssh_url":"git@github.com:dgeb/ember.js.git","clone_url":"https://github.com/dgeb/ember.js.git","svn_url":"https://github.com/dgeb/ember.js","homepage":"http://www.emberjs.com","size":30352,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"f7d64dc3895c43b1a23164c599d3dee6371cd6a4","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-08-24T12:27:25Z","pushed_at":"2016-08-24T16:15:55Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":75292,"stargazers_count":16711,"watchers_count":16711,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3560,"mirror_url":null,"open_issues_count":270,"forks":3560,"open_issues":270,"watchers":16711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14112"},"html":{"href":"https://github.com/emberjs/ember.js/pull/14112"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/14112"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/14112/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14112/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/14112/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/4883411d204443d12f0184dee17bff7ee6d67cd5"}}}}
{"actor":{"display_login":"asakusuma"}}