{"action":"created","comment":{"url":"https://api.github.com/repos/airlift/airlift/pulls/comments/88312395","pull_request_review_id":8889806,"id":88312395,"diff_hunk":"@@ -169,4 +164,21 @@ public NodeConfig setConfigSpec(String configSpec)\n         this.configSpec = configSpec;\n         return this;\n     }\n+\n+    public AddressType getAddressType()\n+    {\n+        return addressType;\n+    }\n+\n+    @Config(\"node.address-type\")","path":"node/src/main/java/io/airlift/node/NodeConfig.java","position":62,"original_position":62,"commit_id":"145bdd34e4521aac980511f6def99c60bf47ee82","original_commit_id":"145bdd34e4521aac980511f6def99c60bf47ee82","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Maybe `node.internal-address-type`? Since this is for configuring `internal-address`","created_at":"2016-11-16T19:28:07Z","updated_at":"2016-11-16T19:28:07Z","html_url":"https://github.com/airlift/airlift/pull/487#discussion_r88312395","pull_request_url":"https://api.github.com/repos/airlift/airlift/pulls/487","_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments/88312395"},"html":{"href":"https://github.com/airlift/airlift/pull/487#discussion_r88312395"},"pull_request":{"href":"https://api.github.com/repos/airlift/airlift/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/airlift/airlift/pulls/487","id":94032556,"html_url":"https://github.com/airlift/airlift/pull/487","diff_url":"https://github.com/airlift/airlift/pull/487.diff","patch_url":"https://github.com/airlift/airlift/pull/487.patch","issue_url":"https://api.github.com/repos/airlift/airlift/issues/487","number":487,"state":"open","locked":false,"title":"Allow node internal address to be a hostname","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"body":"For SSL communication it is more convenient to generate certificates\r\nfor the top level host name. To do so, nodes must introduce themselves\r\nwith the hostname, instead of the IP. This change allows to either set\r\nthe internal node hostname explicitly, or to make the auto-resolve\r\nalgorithm to return node hostname instead of IP.","created_at":"2016-11-16T19:25:28Z","updated_at":"2016-11-16T19:28:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58a8bbebcf7a87ae2c24d744252f697bd051a8e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airlift/airlift/pulls/487/commits","review_comments_url":"https://api.github.com/repos/airlift/airlift/pulls/487/comments","review_comment_url":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airlift/airlift/issues/487/comments","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/145bdd34e4521aac980511f6def99c60bf47ee82","head":{"label":"arhimondr:internal_address","ref":"internal_address","sha":"145bdd34e4521aac980511f6def99c60bf47ee82","user":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"repo":{"id":53517684,"name":"airlift","full_name":"arhimondr/airlift","owner":{"login":"arhimondr","id":5570988,"avatar_url":"https://avatars.githubusercontent.com/u/5570988?v=3","gravatar_id":"","url":"https://api.github.com/users/arhimondr","html_url":"https://github.com/arhimondr","followers_url":"https://api.github.com/users/arhimondr/followers","following_url":"https://api.github.com/users/arhimondr/following{/other_user}","gists_url":"https://api.github.com/users/arhimondr/gists{/gist_id}","starred_url":"https://api.github.com/users/arhimondr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhimondr/subscriptions","organizations_url":"https://api.github.com/users/arhimondr/orgs","repos_url":"https://api.github.com/users/arhimondr/repos","events_url":"https://api.github.com/users/arhimondr/events{/privacy}","received_events_url":"https://api.github.com/users/arhimondr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arhimondr/airlift","description":"Airlift framework for building REST services","fork":true,"url":"https://api.github.com/repos/arhimondr/airlift","forks_url":"https://api.github.com/repos/arhimondr/airlift/forks","keys_url":"https://api.github.com/repos/arhimondr/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arhimondr/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arhimondr/airlift/teams","hooks_url":"https://api.github.com/repos/arhimondr/airlift/hooks","issue_events_url":"https://api.github.com/repos/arhimondr/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/arhimondr/airlift/events","assignees_url":"https://api.github.com/repos/arhimondr/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/arhimondr/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/arhimondr/airlift/tags","blobs_url":"https://api.github.com/repos/arhimondr/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arhimondr/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arhimondr/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/arhimondr/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arhimondr/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/arhimondr/airlift/languages","stargazers_url":"https://api.github.com/repos/arhimondr/airlift/stargazers","contributors_url":"https://api.github.com/repos/arhimondr/airlift/contributors","subscribers_url":"https://api.github.com/repos/arhimondr/airlift/subscribers","subscription_url":"https://api.github.com/repos/arhimondr/airlift/subscription","commits_url":"https://api.github.com/repos/arhimondr/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/arhimondr/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/arhimondr/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/arhimondr/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/arhimondr/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/arhimondr/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arhimondr/airlift/merges","archive_url":"https://api.github.com/repos/arhimondr/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arhimondr/airlift/downloads","issues_url":"https://api.github.com/repos/arhimondr/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/arhimondr/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/arhimondr/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/arhimondr/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arhimondr/airlift/labels{/name}","releases_url":"https://api.github.com/repos/arhimondr/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/arhimondr/airlift/deployments","created_at":"2016-03-09T17:33:14Z","updated_at":"2016-03-09T17:33:16Z","pushed_at":"2016-11-16T19:24:42Z","git_url":"git://github.com/arhimondr/airlift.git","ssh_url":"git@github.com:arhimondr/airlift.git","clone_url":"https://github.com/arhimondr/airlift.git","svn_url":"https://github.com/arhimondr/airlift","homepage":"","size":18976,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airlift:master","ref":"master","sha":"7d20a507eaa444669493974fe2c38764200903d8","user":{"login":"airlift","id":1855389,"avatar_url":"https://avatars.githubusercontent.com/u/1855389?v=3","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"repo":{"id":4681328,"name":"airlift","full_name":"airlift/airlift","owner":{"login":"airlift","id":1855389,"avatar_url":"https://avatars.githubusercontent.com/u/1855389?v=3","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airlift/airlift","description":"Airlift framework for building REST services","fork":false,"url":"https://api.github.com/repos/airlift/airlift","forks_url":"https://api.github.com/repos/airlift/airlift/forks","keys_url":"https://api.github.com/repos/airlift/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airlift/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airlift/airlift/teams","hooks_url":"https://api.github.com/repos/airlift/airlift/hooks","issue_events_url":"https://api.github.com/repos/airlift/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/airlift/airlift/events","assignees_url":"https://api.github.com/repos/airlift/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/airlift/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/airlift/airlift/tags","blobs_url":"https://api.github.com/repos/airlift/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airlift/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airlift/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/airlift/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/airlift/airlift/languages","stargazers_url":"https://api.github.com/repos/airlift/airlift/stargazers","contributors_url":"https://api.github.com/repos/airlift/airlift/contributors","subscribers_url":"https://api.github.com/repos/airlift/airlift/subscribers","subscription_url":"https://api.github.com/repos/airlift/airlift/subscription","commits_url":"https://api.github.com/repos/airlift/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/airlift/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/airlift/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/airlift/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/airlift/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/airlift/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airlift/airlift/merges","archive_url":"https://api.github.com/repos/airlift/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airlift/airlift/downloads","issues_url":"https://api.github.com/repos/airlift/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/airlift/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/airlift/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/airlift/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airlift/airlift/labels{/name}","releases_url":"https://api.github.com/repos/airlift/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/airlift/airlift/deployments","created_at":"2012-06-16T00:33:13Z","updated_at":"2016-11-10T15:47:10Z","pushed_at":"2016-11-16T19:25:29Z","git_url":"git://github.com/airlift/airlift.git","ssh_url":"git@github.com:airlift/airlift.git","clone_url":"https://github.com/airlift/airlift.git","svn_url":"https://github.com/airlift/airlift","homepage":"","size":28781,"stargazers_count":175,"watchers_count":175,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":48,"forks":92,"open_issues":48,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/487"},"html":{"href":"https://github.com/airlift/airlift/pull/487"},"issue":{"href":"https://api.github.com/repos/airlift/airlift/issues/487"},"comments":{"href":"https://api.github.com/repos/airlift/airlift/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/airlift/airlift/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airlift/airlift/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/airlift/airlift/statuses/145bdd34e4521aac980511f6def99c60bf47ee82"}}}}
{"actor":{"display_login":"electrum"}}