{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments/55407906","id":55407906,"diff_hunk":"@@ -103,7 +102,10 @@ private void it(String comment, int count) throws IOException {\n     }\n \n     private void makeCachedRequestWithCredsId(String credsId) throws IOException {\n-        jRule.getInstance().getDescriptorByType(GitHubServerConfig.DescriptorImpl.class)\n-                .doVerifyCredentials(github.serverConfig().getApiUrl(), credsId, 1);\n+        GitHubServerConfig config = new GitHubServerConfig(credsId);\n+        config.setApiUrl(github.serverConfig().getApiUrl());\n+        config.setClientCacheSize(1);\n+        GitHub gitHub = new GitHubLoginFunction().apply(config);","path":"src/test/java/org/jenkinsci/plugins/github/internal/GitHubClientCacheCleanupTest.java","position":33,"original_position":33,"commit_id":"96c8426bd48165dde4910f868d246b1b21b9342c","original_commit_id":"96c8426bd48165dde4910f868d246b1b21b9342c","user":{"login":"lanwen","id":1964214,"avatar_url":"https://avatars.githubusercontent.com/u/1964214?v=3","gravatar_id":"","url":"https://api.github.com/users/lanwen","html_url":"https://github.com/lanwen","followers_url":"https://api.github.com/users/lanwen/followers","following_url":"https://api.github.com/users/lanwen/following{/other_user}","gists_url":"https://api.github.com/users/lanwen/gists{/gist_id}","starred_url":"https://api.github.com/users/lanwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanwen/subscriptions","organizations_url":"https://api.github.com/users/lanwen/orgs","repos_url":"https://api.github.com/users/lanwen/repos","events_url":"https://api.github.com/users/lanwen/events{/privacy}","received_events_url":"https://api.github.com/users/lanwen/received_events","type":"User","site_admin":false},"body":"please use `GitHubServerConfig#loginToGithub()` instead","created_at":"2016-03-08T18:55:35Z","updated_at":"2016-03-08T18:55:35Z","html_url":"https://github.com/jenkinsci/github-plugin/pull/112#discussion_r55407906","pull_request_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments/55407906"},"html":{"href":"https://github.com/jenkinsci/github-plugin/pull/112#discussion_r55407906"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112","id":62025548,"html_url":"https://github.com/jenkinsci/github-plugin/pull/112","diff_url":"https://github.com/jenkinsci/github-plugin/pull/112.diff","patch_url":"https://github.com/jenkinsci/github-plugin/pull/112.patch","issue_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/112","number":112,"state":"open","locked":false,"title":"[JENKINS-33228] Misc global config page improvements","user":{"login":"kohsuke","id":50003,"avatar_url":"https://avatars.githubusercontent.com/u/50003?v=3","gravatar_id":"","url":"https://api.github.com/users/kohsuke","html_url":"https://github.com/kohsuke","followers_url":"https://api.github.com/users/kohsuke/followers","following_url":"https://api.github.com/users/kohsuke/following{/other_user}","gists_url":"https://api.github.com/users/kohsuke/gists{/gist_id}","starred_url":"https://api.github.com/users/kohsuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohsuke/subscriptions","organizations_url":"https://api.github.com/users/kohsuke/orgs","repos_url":"https://api.github.com/users/kohsuke/repos","events_url":"https://api.github.com/users/kohsuke/events{/privacy}","received_events_url":"https://api.github.com/users/kohsuke/received_events","type":"User","site_admin":false},"body":"See [JENKINS-33228](https://issues.jenkins-ci.org/browse/JENKINS-33228) for the context of this discussion.\r\n\r\nThis PR consists of a number of small changes to slightly improve the global configuration page.\r\n\r\n`GitHubServerConfig` and especially its help text is still not really adequate for reuse by other plugins, but those requires further work.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/jenkinsci/github-plugin/112)\n<!-- Reviewable:end -->\n","created_at":"2016-03-08T05:10:34Z","updated_at":"2016-03-08T18:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7130fdba95090b5ed6d96ef684662601257b141f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/112/comments","statuses_url":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/96c8426bd48165dde4910f868d246b1b21b9342c","head":{"label":"jenkinsci:config-improvements","ref":"config-improvements","sha":"96c8426bd48165dde4910f868d246b1b21b9342c","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163555,"name":"github-plugin","full_name":"jenkinsci/github-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/github-plugin","description":"Jenkins GitHub plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/github-plugin","forks_url":"https://api.github.com/repos/jenkinsci/github-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/github-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/github-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/github-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/github-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/github-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/github-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/github-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/github-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/github-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/github-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/github-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/github-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/github-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/github-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/github-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/github-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/github-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/github-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/github-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/github-plugin/deployments","created_at":"2010-12-13T05:35:14Z","updated_at":"2016-02-24T13:33:35Z","pushed_at":"2016-03-08T18:14:00Z","git_url":"git://github.com/jenkinsci/github-plugin.git","ssh_url":"git@github.com:jenkinsci/github-plugin.git","clone_url":"https://github.com/jenkinsci/github-plugin.git","svn_url":"https://github.com/jenkinsci/github-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin","size":994,"stargazers_count":143,"watchers_count":143,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":5,"forks":194,"open_issues":5,"watchers":143,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"20c159e05809a4133b7130a9c3606e402eba0707","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163555,"name":"github-plugin","full_name":"jenkinsci/github-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/github-plugin","description":"Jenkins GitHub plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/github-plugin","forks_url":"https://api.github.com/repos/jenkinsci/github-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/github-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/github-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/github-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/github-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/github-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/github-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/github-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/github-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/github-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/github-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/github-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/github-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/github-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/github-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/github-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/github-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/github-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/github-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/github-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/github-plugin/deployments","created_at":"2010-12-13T05:35:14Z","updated_at":"2016-02-24T13:33:35Z","pushed_at":"2016-03-08T18:14:00Z","git_url":"git://github.com/jenkinsci/github-plugin.git","ssh_url":"git@github.com:jenkinsci/github-plugin.git","clone_url":"https://github.com/jenkinsci/github-plugin.git","svn_url":"https://github.com/jenkinsci/github-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin","size":994,"stargazers_count":143,"watchers_count":143,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":5,"forks":194,"open_issues":5,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112"},"html":{"href":"https://github.com/jenkinsci/github-plugin/pull/112"},"issue":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/issues/112"},"comments":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/96c8426bd48165dde4910f868d246b1b21b9342c"}}}}