{"action":"created","comment":{"url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments/76887699","id":76887699,"diff_hunk":"@@ -1272,7 +1275,7 @@ public String getSyntax() {\n         /**\n          * {@inheritDoc}\n          */\n-        public boolean process(final ZigBeeApiDongleImpl zigbeeApi, final String[] args, PrintStream out) throws Exception {\n+        public boolean process(final ZigBeeApi zigbeeApi, final String[] args, PrintStream out) throws Exception {","path":"zigbee-gateway-server/src/main/java/org/bubblecloud/zigbee/v3/ZigBeeGateway.java","position":135,"original_position":288,"commit_id":"55c2f9b8f31ab74ce4366eee491f929721c4b226","original_commit_id":"55c2f9b8f31ab74ce4366eee491f929721c4b226","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [A method/constructor shouldnt explicitly throw java.lang.Exception](https://www.codacy.com/app/tommi-s-e-laukkanen/zigbee4java/file/3666969717/issues/source?bid=3322503&fileBranchId=3655361#l1278)","created_at":"2016-08-30T21:58:37Z","updated_at":"2016-08-30T21:58:37Z","html_url":"https://github.com/tlaukkan/zigbee4java/pull/105#discussion_r76887699","pull_request_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments/76887699"},"html":{"href":"https://github.com/tlaukkan/zigbee4java/pull/105#discussion_r76887699"},"pull_request":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105","id":83354936,"html_url":"https://github.com/tlaukkan/zigbee4java/pull/105","diff_url":"https://github.com/tlaukkan/zigbee4java/pull/105.diff","patch_url":"https://github.com/tlaukkan/zigbee4java/pull/105.patch","issue_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/105","number":105,"state":"open","locked":false,"title":"Initial addition of ZigBeeNetworkManager","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"body":"This is an initial refactor to move some of the management that is currently in the dongle code, into the main API.\r\n\r\nAs discussed elsewhere, I think there's too much code still in the dongle interface. This initially moves the command listener handler from the dongle into the API. This changes the dongle interface slightly so that there's now just a sendCommand() method (same as before), but on the receive side there's a callback into the API. This means the dongle code now only needs to process packets. I've not optimised the code in the 2531 implementation - just moved the handler.\r\n\r\nMy thought is that the ZigBeeNetworkManager class handles 'all' of the network management, so I plan to move some of what is in the API class into here. The ZigBeeApi can then remain as a simple API, or more complex implementations can use the network manager directly.\r\n\r\nThis is in no way optimised and I'm providing this PR for visibility and any thoughts you might have :)\r\n\r\nSigned-off-by: Chris Jackson <chris@cd-jackson.com>","created_at":"2016-08-30T21:56:42Z","updated_at":"2016-08-30T21:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ac70cf33fc0450bee51062ecc132084ea0d69f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105/commits","review_comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105/comments","review_comment_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/105/comments","statuses_url":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/55c2f9b8f31ab74ce4366eee491f929721c4b226","head":{"label":"cdjackson:network_manager","ref":"network_manager","sha":"55c2f9b8f31ab74ce4366eee491f929721c4b226","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"repo":{"id":66854112,"name":"zigbee4java","full_name":"cdjackson/zigbee4java","owner":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdjackson/zigbee4java","description":"Zigbee API for Java provides simple Java interface to ZigBee network.","fork":true,"url":"https://api.github.com/repos/cdjackson/zigbee4java","forks_url":"https://api.github.com/repos/cdjackson/zigbee4java/forks","keys_url":"https://api.github.com/repos/cdjackson/zigbee4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdjackson/zigbee4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdjackson/zigbee4java/teams","hooks_url":"https://api.github.com/repos/cdjackson/zigbee4java/hooks","issue_events_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues/events{/number}","events_url":"https://api.github.com/repos/cdjackson/zigbee4java/events","assignees_url":"https://api.github.com/repos/cdjackson/zigbee4java/assignees{/user}","branches_url":"https://api.github.com/repos/cdjackson/zigbee4java/branches{/branch}","tags_url":"https://api.github.com/repos/cdjackson/zigbee4java/tags","blobs_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdjackson/zigbee4java/statuses/{sha}","languages_url":"https://api.github.com/repos/cdjackson/zigbee4java/languages","stargazers_url":"https://api.github.com/repos/cdjackson/zigbee4java/stargazers","contributors_url":"https://api.github.com/repos/cdjackson/zigbee4java/contributors","subscribers_url":"https://api.github.com/repos/cdjackson/zigbee4java/subscribers","subscription_url":"https://api.github.com/repos/cdjackson/zigbee4java/subscription","commits_url":"https://api.github.com/repos/cdjackson/zigbee4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdjackson/zigbee4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdjackson/zigbee4java/contents/{+path}","compare_url":"https://api.github.com/repos/cdjackson/zigbee4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdjackson/zigbee4java/merges","archive_url":"https://api.github.com/repos/cdjackson/zigbee4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdjackson/zigbee4java/downloads","issues_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues{/number}","pulls_url":"https://api.github.com/repos/cdjackson/zigbee4java/pulls{/number}","milestones_url":"https://api.github.com/repos/cdjackson/zigbee4java/milestones{/number}","notifications_url":"https://api.github.com/repos/cdjackson/zigbee4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdjackson/zigbee4java/labels{/name}","releases_url":"https://api.github.com/repos/cdjackson/zigbee4java/releases{/id}","deployments_url":"https://api.github.com/repos/cdjackson/zigbee4java/deployments","created_at":"2016-08-29T15:05:29Z","updated_at":"2016-08-29T15:05:35Z","pushed_at":"2016-08-30T21:45:24Z","git_url":"git://github.com/cdjackson/zigbee4java.git","ssh_url":"git@github.com:cdjackson/zigbee4java.git","clone_url":"https://github.com/cdjackson/zigbee4java.git","svn_url":"https://github.com/cdjackson/zigbee4java","homepage":"","size":2865,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlaukkan:master","ref":"master","sha":"11165c0d346640227ccacab7ed5f2c2636e674ef","user":{"login":"tlaukkan","id":232774,"avatar_url":"https://avatars.githubusercontent.com/u/232774?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaukkan","html_url":"https://github.com/tlaukkan","followers_url":"https://api.github.com/users/tlaukkan/followers","following_url":"https://api.github.com/users/tlaukkan/following{/other_user}","gists_url":"https://api.github.com/users/tlaukkan/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaukkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaukkan/subscriptions","organizations_url":"https://api.github.com/users/tlaukkan/orgs","repos_url":"https://api.github.com/users/tlaukkan/repos","events_url":"https://api.github.com/users/tlaukkan/events{/privacy}","received_events_url":"https://api.github.com/users/tlaukkan/received_events","type":"User","site_admin":false},"repo":{"id":15199543,"name":"zigbee4java","full_name":"tlaukkan/zigbee4java","owner":{"login":"tlaukkan","id":232774,"avatar_url":"https://avatars.githubusercontent.com/u/232774?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaukkan","html_url":"https://github.com/tlaukkan","followers_url":"https://api.github.com/users/tlaukkan/followers","following_url":"https://api.github.com/users/tlaukkan/following{/other_user}","gists_url":"https://api.github.com/users/tlaukkan/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaukkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaukkan/subscriptions","organizations_url":"https://api.github.com/users/tlaukkan/orgs","repos_url":"https://api.github.com/users/tlaukkan/repos","events_url":"https://api.github.com/users/tlaukkan/events{/privacy}","received_events_url":"https://api.github.com/users/tlaukkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlaukkan/zigbee4java","description":"Zigbee API for Java provides simple Java interface to ZigBee network.","fork":false,"url":"https://api.github.com/repos/tlaukkan/zigbee4java","forks_url":"https://api.github.com/repos/tlaukkan/zigbee4java/forks","keys_url":"https://api.github.com/repos/tlaukkan/zigbee4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlaukkan/zigbee4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlaukkan/zigbee4java/teams","hooks_url":"https://api.github.com/repos/tlaukkan/zigbee4java/hooks","issue_events_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/events{/number}","events_url":"https://api.github.com/repos/tlaukkan/zigbee4java/events","assignees_url":"https://api.github.com/repos/tlaukkan/zigbee4java/assignees{/user}","branches_url":"https://api.github.com/repos/tlaukkan/zigbee4java/branches{/branch}","tags_url":"https://api.github.com/repos/tlaukkan/zigbee4java/tags","blobs_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/{sha}","languages_url":"https://api.github.com/repos/tlaukkan/zigbee4java/languages","stargazers_url":"https://api.github.com/repos/tlaukkan/zigbee4java/stargazers","contributors_url":"https://api.github.com/repos/tlaukkan/zigbee4java/contributors","subscribers_url":"https://api.github.com/repos/tlaukkan/zigbee4java/subscribers","subscription_url":"https://api.github.com/repos/tlaukkan/zigbee4java/subscription","commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlaukkan/zigbee4java/contents/{+path}","compare_url":"https://api.github.com/repos/tlaukkan/zigbee4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlaukkan/zigbee4java/merges","archive_url":"https://api.github.com/repos/tlaukkan/zigbee4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlaukkan/zigbee4java/downloads","issues_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues{/number}","pulls_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls{/number}","milestones_url":"https://api.github.com/repos/tlaukkan/zigbee4java/milestones{/number}","notifications_url":"https://api.github.com/repos/tlaukkan/zigbee4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlaukkan/zigbee4java/labels{/name}","releases_url":"https://api.github.com/repos/tlaukkan/zigbee4java/releases{/id}","deployments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/deployments","created_at":"2013-12-15T07:20:58Z","updated_at":"2016-08-01T16:09:07Z","pushed_at":"2016-08-30T21:56:42Z","git_url":"git://github.com/tlaukkan/zigbee4java.git","ssh_url":"git@github.com:tlaukkan/zigbee4java.git","clone_url":"https://github.com/tlaukkan/zigbee4java.git","svn_url":"https://github.com/tlaukkan/zigbee4java","homepage":"","size":6334,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":15,"forks":33,"open_issues":15,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105"},"html":{"href":"https://github.com/tlaukkan/zigbee4java/pull/105"},"issue":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/105"},"comments":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/55c2f9b8f31ab74ce4366eee491f929721c4b226"}}}}
{"actor":{"display_login":"codacy-bot"}}