{"action":"closed","number":5309,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309","id":90103517,"html_url":"https://github.com/zfsonlinux/zfs/pull/5309","diff_url":"https://github.com/zfsonlinux/zfs/pull/5309.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5309.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5309","number":5309,"state":"closed","locked":false,"title":"Turn on/off enclosure slot fault LED even when disk isn't present","user":{"login":"tonyhutter","id":11469457,"avatar_url":"https://avatars.githubusercontent.com/u/11469457?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyhutter","html_url":"https://github.com/tonyhutter","followers_url":"https://api.github.com/users/tonyhutter/followers","following_url":"https://api.github.com/users/tonyhutter/following{/other_user}","gists_url":"https://api.github.com/users/tonyhutter/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyhutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyhutter/subscriptions","organizations_url":"https://api.github.com/users/tonyhutter/orgs","repos_url":"https://api.github.com/users/tonyhutter/repos","events_url":"https://api.github.com/users/tonyhutter/events{/privacy}","received_events_url":"https://api.github.com/users/tonyhutter/received_events","type":"User","site_admin":false},"body":"Previously, when a drive faulted, the `statechange-led.sh` script would lookup the drive's LED sysfs entry in `/sys/block/sd*/device/enclosure_device` and turn it on.  During testing we noticed that if you pulled out a drive, or if the drive was so badly broken that it no longer appeared to Linux, that the\r\n`/sys/block/sd*` path would be removed, and the script could not lookup the LED entry.\r\n\r\nTo fix this, this patch looks up the disks's more persistent `/sys/class/enclosure/X:X:X:X/Slot N` LED sysfs path at pool import.  It then passes that path to `statechange-led.sh` via a ZED env variable, rather than having the script look it up on the fly.  This allows the script to turn on/off the slot LEDs even when the drive is missing.","created_at":"2016-10-19T22:35:36Z","updated_at":"2016-10-24T17:45:59Z","closed_at":"2016-10-24T17:45:59Z","merged_at":"2016-10-24T17:45:59Z","merge_commit_sha":"1bbd8770490f0e5b8c575865ab70f6853bca2a2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5309/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/0b7f6f51ff6cc2ab747cedd6741f159cfcaf4d8e","head":{"label":"tonyhutter:fma3","ref":"fma3","sha":"0b7f6f51ff6cc2ab747cedd6741f159cfcaf4d8e","user":{"login":"tonyhutter","id":11469457,"avatar_url":"https://avatars.githubusercontent.com/u/11469457?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyhutter","html_url":"https://github.com/tonyhutter","followers_url":"https://api.github.com/users/tonyhutter/followers","following_url":"https://api.github.com/users/tonyhutter/following{/other_user}","gists_url":"https://api.github.com/users/tonyhutter/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyhutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyhutter/subscriptions","organizations_url":"https://api.github.com/users/tonyhutter/orgs","repos_url":"https://api.github.com/users/tonyhutter/repos","events_url":"https://api.github.com/users/tonyhutter/events{/privacy}","received_events_url":"https://api.github.com/users/tonyhutter/received_events","type":"User","site_admin":false},"repo":{"id":52639123,"name":"zfs","full_name":"tonyhutter/zfs","owner":{"login":"tonyhutter","id":11469457,"avatar_url":"https://avatars.githubusercontent.com/u/11469457?v=3","gravatar_id":"","url":"https://api.github.com/users/tonyhutter","html_url":"https://github.com/tonyhutter","followers_url":"https://api.github.com/users/tonyhutter/followers","following_url":"https://api.github.com/users/tonyhutter/following{/other_user}","gists_url":"https://api.github.com/users/tonyhutter/gists{/gist_id}","starred_url":"https://api.github.com/users/tonyhutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonyhutter/subscriptions","organizations_url":"https://api.github.com/users/tonyhutter/orgs","repos_url":"https://api.github.com/users/tonyhutter/repos","events_url":"https://api.github.com/users/tonyhutter/events{/privacy}","received_events_url":"https://api.github.com/users/tonyhutter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonyhutter/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/tonyhutter/zfs","forks_url":"https://api.github.com/repos/tonyhutter/zfs/forks","keys_url":"https://api.github.com/repos/tonyhutter/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonyhutter/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonyhutter/zfs/teams","hooks_url":"https://api.github.com/repos/tonyhutter/zfs/hooks","issue_events_url":"https://api.github.com/repos/tonyhutter/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/tonyhutter/zfs/events","assignees_url":"https://api.github.com/repos/tonyhutter/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/tonyhutter/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/tonyhutter/zfs/tags","blobs_url":"https://api.github.com/repos/tonyhutter/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonyhutter/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonyhutter/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonyhutter/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonyhutter/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/tonyhutter/zfs/languages","stargazers_url":"https://api.github.com/repos/tonyhutter/zfs/stargazers","contributors_url":"https://api.github.com/repos/tonyhutter/zfs/contributors","subscribers_url":"https://api.github.com/repos/tonyhutter/zfs/subscribers","subscription_url":"https://api.github.com/repos/tonyhutter/zfs/subscription","commits_url":"https://api.github.com/repos/tonyhutter/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonyhutter/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonyhutter/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonyhutter/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonyhutter/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/tonyhutter/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonyhutter/zfs/merges","archive_url":"https://api.github.com/repos/tonyhutter/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonyhutter/zfs/downloads","issues_url":"https://api.github.com/repos/tonyhutter/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/tonyhutter/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/tonyhutter/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/tonyhutter/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonyhutter/zfs/labels{/name}","releases_url":"https://api.github.com/repos/tonyhutter/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/tonyhutter/zfs/deployments","created_at":"2016-02-26T23:20:12Z","updated_at":"2016-02-26T23:20:16Z","pushed_at":"2016-10-20T21:27:46Z","git_url":"git://github.com/tonyhutter/zfs.git","ssh_url":"git@github.com:tonyhutter/zfs.git","clone_url":"https://github.com/tonyhutter/zfs.git","svn_url":"https://github.com/tonyhutter/zfs","homepage":"http://zfsonlinux.org/","size":32792,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"9523b15ac1881946a7a6b7a145c8e2bb622dc56c","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-10-23T03:24:24Z","pushed_at":"2016-10-24T17:45:59Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":60757,"stargazers_count":2089,"watchers_count":2089,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":525,"mirror_url":null,"open_issues_count":920,"forks":525,"open_issues":920,"watchers":2089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5309"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5309"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5309/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5309/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/0b7f6f51ff6cc2ab747cedd6741f159cfcaf4d8e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"comments":6,"review_comments":17,"commits":1,"additions":215,"deletions":80,"changed_files":13}}
{"actor":{"display_login":"behlendorf"}}