{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/6797","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/6797/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/6797/comments","events_url":"https://api.github.com/repos/facebook/react/issues/6797/events","html_url":"https://github.com/facebook/react/issues/6797","id":155597556,"number":6797,"title":"Move instrumentation from isomorphic to renderers/shared","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/good%20first%20bug","name":"good first bug","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-05-18T20:46:37Z","updated_at":"2016-05-19T23:59:09Z","closed_at":"2016-05-19T12:24:24Z","body":"Per @sebmarkbage, we want `isomorphic` folder to only contain the code necessary to author React components. It should not have dependencies on `ReactInstrumentation`, `ReactDebugTool`, and `devtools/*` friends, which themselves should be moved to `renderers/shared/`.\r\n\r\nThe only caller we to `ReactInstrumentation` we have right now in that folder is [`onSetState()`](https://github.com/facebook/react/blob/8ea1cf4ee0f5315c4190a9e67e15f0f7404cb0cf/src/isomorphic/modern/class/ReactComponent.js#L70) inside `ReactComponent`. We need to move it somewhere inside the renderer (e.g. in the update queue implementation).\r\n\r\nLabeling it as a `good first bug` because this mostly involves moving files. The goal is that files in `isomorphic` folder don’t contain anything that references `ReactInstrumentation`.\r\n\r\nThis is up for grabs but I’ll do it myself if no one takes it."},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/220483906","html_url":"https://github.com/facebook/react/issues/6797#issuecomment-220483906","issue_url":"https://api.github.com/repos/facebook/react/issues/6797","id":220483906,"user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T23:59:08Z","updated_at":"2016-05-19T23:59:08Z","body":"Is the intent also to get away from the current dependency injection? Would this allow multiple independent renderers to coexist in a runtime environment as well? (Possible upcoming scenario: ReactDOM and ReactART, with ReactDOM using the current reconciler and ART using the incremental reconciler)"}}
{"actor":{"display_login":"iamdustan"}}