{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/50742245","id":50742245,"diff_hunk":"@@ -134,7 +134,11 @@ private MaxwellAbstractRowsEvent processRowsEvent(AbstractRowEvent e) throws Sch\n \n \t\ttable = tableCache.getTable(e.getTableId());\n \n-\t\tif (table == null) {\n+\t\tif ( table == null && this.filter.hasTableBlacklist() ) {\n+\t\t\tLOGGER.warn(String.format(\"couldn't find table in cache for table id: %d, assuming blacklisted table\", e.getTableId()));\n+\t\t\treturn null;","path":"src/main/java/com/zendesk/maxwell/MaxwellReplicator.java","position":7,"original_position":7,"commit_id":"6a8a27005aa17265433728c6e0883e725c5ceee5","original_commit_id":"6a8a27005aa17265433728c6e0883e725c5ceee5","user":{"login":"osheroff","id":260084,"avatar_url":"https://avatars.githubusercontent.com/u/260084?v=3","gravatar_id":"","url":"https://api.github.com/users/osheroff","html_url":"https://github.com/osheroff","followers_url":"https://api.github.com/users/osheroff/followers","following_url":"https://api.github.com/users/osheroff/following{/other_user}","gists_url":"https://api.github.com/users/osheroff/gists{/gist_id}","starred_url":"https://api.github.com/users/osheroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheroff/subscriptions","organizations_url":"https://api.github.com/users/osheroff/orgs","repos_url":"https://api.github.com/users/osheroff/repos","events_url":"https://api.github.com/users/osheroff/events{/privacy}","received_events_url":"https://api.github.com/users/osheroff/received_events","type":"User","site_admin":false},"body":"(as well as the table-id) -- that's what it's mapping, id -> table_name (and some schema info)","created_at":"2016-01-25T19:24:25Z","updated_at":"2016-01-25T19:24:25Z","html_url":"https://github.com/zendesk/maxwell/pull/253#discussion_r50742245","pull_request_url":"https://api.github.com/repos/zendesk/maxwell/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments/50742245"},"html":{"href":"https://github.com/zendesk/maxwell/pull/253#discussion_r50742245"},"pull_request":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/maxwell/pulls/253","id":57031816,"html_url":"https://github.com/zendesk/maxwell/pull/253","diff_url":"https://github.com/zendesk/maxwell/pull/253.diff","patch_url":"https://github.com/zendesk/maxwell/pull/253.patch","issue_url":"https://api.github.com/repos/zendesk/maxwell/issues/253","number":253,"state":"open","locked":false,"title":"add --blacklist_tables command-line option","user":{"login":"nmaquet","id":248304,"avatar_url":"https://avatars.githubusercontent.com/u/248304?v=3","gravatar_id":"","url":"https://api.github.com/users/nmaquet","html_url":"https://github.com/nmaquet","followers_url":"https://api.github.com/users/nmaquet/followers","following_url":"https://api.github.com/users/nmaquet/following{/other_user}","gists_url":"https://api.github.com/users/nmaquet/gists{/gist_id}","starred_url":"https://api.github.com/users/nmaquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmaquet/subscriptions","organizations_url":"https://api.github.com/users/nmaquet/orgs","repos_url":"https://api.github.com/users/nmaquet/repos","events_url":"https://api.github.com/users/nmaquet/events{/privacy}","received_events_url":"https://api.github.com/users/nmaquet/received_events","type":"User","site_admin":false},"body":"Add `--blacklist_tables PATTERN` command-line option.\r\n\r\nThe option `blacklist_tables` controls whether Maxwell will send updates for a table to its producer AND whether it captures schema changes for that table. Note that once Maxwell has been running with a table marked as blacklisted, you *must* continue to run Maxwell with that table blacklisted or else Maxwell will halt. If you want to stop blacklisting a table, you will have to drop the maxwell schema first. Also note that with table blacklisting enabled, Maxwell cannot distinguish between row updates for blacklisted tables and row updates for unknown tables; it will just assume that all row updates for unknown tables relate to blacklisted tables.\r\n ","created_at":"2016-01-25T06:03:00Z","updated_at":"2016-01-25T19:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b013dd8a32630546121cbf6eae9753cdd702146","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/maxwell/pulls/253/commits","review_comments_url":"https://api.github.com/repos/zendesk/maxwell/pulls/253/comments","review_comment_url":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/maxwell/issues/253/comments","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/6a8a27005aa17265433728c6e0883e725c5ceee5","head":{"label":"movio:blacklist-tables","ref":"blacklist-tables","sha":"6a8a27005aa17265433728c6e0883e725c5ceee5","user":{"login":"movio","id":3209548,"avatar_url":"https://avatars.githubusercontent.com/u/3209548?v=3","gravatar_id":"","url":"https://api.github.com/users/movio","html_url":"https://github.com/movio","followers_url":"https://api.github.com/users/movio/followers","following_url":"https://api.github.com/users/movio/following{/other_user}","gists_url":"https://api.github.com/users/movio/gists{/gist_id}","starred_url":"https://api.github.com/users/movio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movio/subscriptions","organizations_url":"https://api.github.com/users/movio/orgs","repos_url":"https://api.github.com/users/movio/repos","events_url":"https://api.github.com/users/movio/events{/privacy}","received_events_url":"https://api.github.com/users/movio/received_events","type":"Organization","site_admin":false},"repo":{"id":47786869,"name":"maxwell","full_name":"movio/maxwell","owner":{"login":"movio","id":3209548,"avatar_url":"https://avatars.githubusercontent.com/u/3209548?v=3","gravatar_id":"","url":"https://api.github.com/users/movio","html_url":"https://github.com/movio","followers_url":"https://api.github.com/users/movio/followers","following_url":"https://api.github.com/users/movio/following{/other_user}","gists_url":"https://api.github.com/users/movio/gists{/gist_id}","starred_url":"https://api.github.com/users/movio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movio/subscriptions","organizations_url":"https://api.github.com/users/movio/orgs","repos_url":"https://api.github.com/users/movio/repos","events_url":"https://api.github.com/users/movio/events{/privacy}","received_events_url":"https://api.github.com/users/movio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/movio/maxwell","description":"Maxwell's daemon, a mysqlbinlog->kafka/json pusher","fork":true,"url":"https://api.github.com/repos/movio/maxwell","forks_url":"https://api.github.com/repos/movio/maxwell/forks","keys_url":"https://api.github.com/repos/movio/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/movio/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/movio/maxwell/teams","hooks_url":"https://api.github.com/repos/movio/maxwell/hooks","issue_events_url":"https://api.github.com/repos/movio/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/movio/maxwell/events","assignees_url":"https://api.github.com/repos/movio/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/movio/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/movio/maxwell/tags","blobs_url":"https://api.github.com/repos/movio/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/movio/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/movio/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/movio/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/movio/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/movio/maxwell/languages","stargazers_url":"https://api.github.com/repos/movio/maxwell/stargazers","contributors_url":"https://api.github.com/repos/movio/maxwell/contributors","subscribers_url":"https://api.github.com/repos/movio/maxwell/subscribers","subscription_url":"https://api.github.com/repos/movio/maxwell/subscription","commits_url":"https://api.github.com/repos/movio/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/movio/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/movio/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/movio/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/movio/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/movio/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/movio/maxwell/merges","archive_url":"https://api.github.com/repos/movio/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/movio/maxwell/downloads","issues_url":"https://api.github.com/repos/movio/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/movio/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/movio/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/movio/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/movio/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/movio/maxwell/releases{/id}","deployments_url":"https://api.github.com/repos/movio/maxwell/deployments","created_at":"2015-12-10T20:54:39Z","updated_at":"2015-12-10T20:54:40Z","pushed_at":"2016-01-25T05:59:27Z","git_url":"git://github.com/movio/maxwell.git","ssh_url":"git@github.com:movio/maxwell.git","clone_url":"https://github.com/movio/maxwell.git","svn_url":"https://github.com/movio/maxwell","homepage":"http://maxwells-daemon.io/","size":7145,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"707b68babe0717050ffea9f035ae18d58d1990e5","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":30561160,"name":"maxwell","full_name":"zendesk/maxwell","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/maxwell","description":"Maxwell's daemon, a mysqlbinlog->kafka/json pusher","fork":false,"url":"https://api.github.com/repos/zendesk/maxwell","forks_url":"https://api.github.com/repos/zendesk/maxwell/forks","keys_url":"https://api.github.com/repos/zendesk/maxwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/maxwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/maxwell/teams","hooks_url":"https://api.github.com/repos/zendesk/maxwell/hooks","issue_events_url":"https://api.github.com/repos/zendesk/maxwell/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/maxwell/events","assignees_url":"https://api.github.com/repos/zendesk/maxwell/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/maxwell/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/maxwell/tags","blobs_url":"https://api.github.com/repos/zendesk/maxwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/maxwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/maxwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/maxwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/maxwell/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/maxwell/languages","stargazers_url":"https://api.github.com/repos/zendesk/maxwell/stargazers","contributors_url":"https://api.github.com/repos/zendesk/maxwell/contributors","subscribers_url":"https://api.github.com/repos/zendesk/maxwell/subscribers","subscription_url":"https://api.github.com/repos/zendesk/maxwell/subscription","commits_url":"https://api.github.com/repos/zendesk/maxwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/maxwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/maxwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/maxwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/maxwell/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/maxwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/maxwell/merges","archive_url":"https://api.github.com/repos/zendesk/maxwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/maxwell/downloads","issues_url":"https://api.github.com/repos/zendesk/maxwell/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/maxwell/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/maxwell/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/maxwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/maxwell/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/maxwell/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/maxwell/deployments","created_at":"2015-02-09T22:06:13Z","updated_at":"2016-01-25T15:10:54Z","pushed_at":"2016-01-25T06:03:02Z","git_url":"git://github.com/zendesk/maxwell.git","ssh_url":"git@github.com:zendesk/maxwell.git","clone_url":"https://github.com/zendesk/maxwell.git","svn_url":"https://github.com/zendesk/maxwell","homepage":"http://maxwells-daemon.io/","size":7257,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":21,"forks":29,"open_issues":21,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/253"},"html":{"href":"https://github.com/zendesk/maxwell/pull/253"},"issue":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/253"},"comments":{"href":"https://api.github.com/repos/zendesk/maxwell/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/maxwell/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/maxwell/statuses/6a8a27005aa17265433728c6e0883e725c5ceee5"}}}}