{"action":"created","issue":{"url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/72","repository_url":"https://api.github.com/repos/PopulateTools/gobierto-dev","labels_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/72/comments","events_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/72/events","html_url":"https://github.com/PopulateTools/gobierto-dev/pull/72","id":191058239,"number":72,"title":"User verification process against Census data","user":{"login":"danguita","id":126392,"avatar_url":"https://avatars.githubusercontent.com/u/126392?v=3","gravatar_id":"","url":"https://api.github.com/users/danguita","html_url":"https://github.com/danguita","followers_url":"https://api.github.com/users/danguita/followers","following_url":"https://api.github.com/users/danguita/following{/other_user}","gists_url":"https://api.github.com/users/danguita/gists{/gist_id}","starred_url":"https://api.github.com/users/danguita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danguita/subscriptions","organizations_url":"https://api.github.com/users/danguita/orgs","repos_url":"https://api.github.com/users/danguita/repos","events_url":"https://api.github.com/users/danguita/events{/privacy}","received_events_url":"https://api.github.com/users/danguita/received_events","type":"User","site_admin":false},"labels":[{"id":484033113,"url":"https://api.github.com/repos/PopulateTools/gobierto-dev/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-22T16:39:58Z","updated_at":"2016-11-23T08:16:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PopulateTools/gobierto-dev/pulls/72","html_url":"https://github.com/PopulateTools/gobierto-dev/pull/72","diff_url":"https://github.com/PopulateTools/gobierto-dev/pull/72.diff","patch_url":"https://github.com/PopulateTools/gobierto-dev/pull/72.patch"},"body":"Connects to #56.\r\n\r\n### What does this PR do?\r\n\r\nContinuing with the changes introduced in #69, this PR implements a verification process against that Census data. It can be requested by any signed in User, and it may require filling up new fields to complete the verification process. The current approach adds a generic user verification mechanism that could have multiple implementations, starting from the verification against Census data which is already working here.\r\n\r\nIn this case we're asking for the document number and date of birth fields to match the Census data through the recently created `CensusRepository`. Digging a little bit deeper on the implementation, the `User::Verification::CensusVerification` model inherits from `User::Verification` and specializes it by adding some Census-specific behavior such as handling the required fields, that are serialized for ease and portability.\r\n\r\nThe rest of logic is handled by the corresponding form object (`User::CensusVerificationForm`), as usual.\r\n\r\n### How should this be manually tested?\r\n\r\nThe verification process can be requested by any unverified Users, so just go to http://madrid.gobierto.dev/user/verifications/new (also reachable from the session navbar, on top of page when signed in, just to keep it in mind) and submit the form to start the process. If everything goes well, you should be redirected to the verification status page at http://madrid.gobierto.dev/user/verifications. Here you can see how your current verification request is going (if it couldn't be calculated instantly).\r\n\r\nPlease note this is a very early implementation of the UI, just as a starting point for any coming features.\r\n\r\n### Notes\r\n\r\nI'm not implementing this point here to have better context:\r\n\r\n> - Any verification status will be regenerated each time the census data source changes (i.e. reload the census CSV file).\r\n\r\nWill take care in a new issue."},"comment":{"url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/comments/262454647","html_url":"https://github.com/PopulateTools/gobierto-dev/pull/72#issuecomment-262454647","issue_url":"https://api.github.com/repos/PopulateTools/gobierto-dev/issues/72","id":262454647,"user":{"login":"danguita","id":126392,"avatar_url":"https://avatars.githubusercontent.com/u/126392?v=3","gravatar_id":"","url":"https://api.github.com/users/danguita","html_url":"https://github.com/danguita","followers_url":"https://api.github.com/users/danguita/followers","following_url":"https://api.github.com/users/danguita/following{/other_user}","gists_url":"https://api.github.com/users/danguita/gists{/gist_id}","starred_url":"https://api.github.com/users/danguita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danguita/subscriptions","organizations_url":"https://api.github.com/users/danguita/orgs","repos_url":"https://api.github.com/users/danguita/repos","events_url":"https://api.github.com/users/danguita/events{/privacy}","received_events_url":"https://api.github.com/users/danguita/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T08:16:21Z","updated_at":"2016-11-23T08:16:21Z","body":"I've just refactored a little this code by doing the following:\r\n\r\n- Moved all verification check behavior from the Form object to the corresponding `User::Verification` Model itself.\r\n\r\nA couple of UI improvements:\r\n\r\n- Show a detailed verification summary view to every signed in user instead of just the last/current one. This way he/she can notice any validation status changes due to data source changes, such as the Census repository.\r\n- Ask for birth date in select format. That UI felt incomplete to me.\r\n\r\nI do not plan to make any further changes here so feel free to check it! 🚀 "}}
{"actor":{"display_login":"danguita"}}