{"action":"created","issue":{"url":"https://api.github.com/repos/farmOS/farmOS/issues/22","repository_url":"https://api.github.com/repos/farmOS/farmOS","labels_url":"https://api.github.com/repos/farmOS/farmOS/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/farmOS/farmOS/issues/22/comments","events_url":"https://api.github.com/repos/farmOS/farmOS/issues/22/events","html_url":"https://github.com/farmOS/farmOS/pull/22","id":186328119,"number":22,"title":"Set the container names to DNS safe values.","user":{"login":"kadaan","id":1904898,"avatar_url":"https://avatars.githubusercontent.com/u/1904898?v=3","gravatar_id":"","url":"https://api.github.com/users/kadaan","html_url":"https://github.com/kadaan","followers_url":"https://api.github.com/users/kadaan/followers","following_url":"https://api.github.com/users/kadaan/following{/other_user}","gists_url":"https://api.github.com/users/kadaan/gists{/gist_id}","starred_url":"https://api.github.com/users/kadaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadaan/subscriptions","organizations_url":"https://api.github.com/users/kadaan/orgs","repos_url":"https://api.github.com/users/kadaan/repos","events_url":"https://api.github.com/users/kadaan/events{/privacy}","received_events_url":"https://api.github.com/users/kadaan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-31T16:20:18Z","updated_at":"2016-10-31T17:05:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/farmOS/farmOS/pulls/22","html_url":"https://github.com/farmOS/farmOS/pull/22","diff_url":"https://github.com/farmOS/farmOS/pull/22.diff","patch_url":"https://github.com/farmOS/farmOS/pull/22.patch"},"body":"Change `network_mode` to `bridge` to support running on Os X under dlite: https://github.com/nlf/dlite\r\nNOTE: To run farmOS under dlite:\r\n\r\n1. Download the latest release from https://github.com/nlf/dlite/releases\r\n2. Copy `dlite` to `/usr/local/bin/dlite`\r\n3. Run `chmod +x /usr/local/bin/dlite`\r\n4. Initialize dlite by running: `dlite init`\r\n5. Start dlite host vm by running `dlite start`\r\n6. Start farmOS with docker-compose\r\n6. Profit!"},"comment":{"url":"https://api.github.com/repos/farmOS/farmOS/issues/comments/257354312","html_url":"https://github.com/farmOS/farmOS/pull/22#issuecomment-257354312","issue_url":"https://api.github.com/repos/farmOS/farmOS/issues/22","id":257354312,"user":{"login":"mstenta","id":95381,"avatar_url":"https://avatars.githubusercontent.com/u/95381?v=3","gravatar_id":"","url":"https://api.github.com/users/mstenta","html_url":"https://github.com/mstenta","followers_url":"https://api.github.com/users/mstenta/followers","following_url":"https://api.github.com/users/mstenta/following{/other_user}","gists_url":"https://api.github.com/users/mstenta/gists{/gist_id}","starred_url":"https://api.github.com/users/mstenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstenta/subscriptions","organizations_url":"https://api.github.com/users/mstenta/orgs","repos_url":"https://api.github.com/users/mstenta/repos","events_url":"https://api.github.com/users/mstenta/events{/privacy}","received_events_url":"https://api.github.com/users/mstenta/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T17:05:45Z","updated_at":"2016-10-31T17:05:45Z","body":"Thanks @kadaan ! It will be great to get this working better on OS X.\r\n\r\nUnfortunately, I'm not sure we can add the container_name parameter...\r\n\r\nOne of the things that I have been doing is building multiple local development sites using Docker Compose. I do this by cloning the repository into folders with different names. For example: `farmOS1`, `farmOS2`, etc.\r\n\r\nWhen `docker-compose up` is run, it generates containers with names based on the parent folder. For example: `farmos1_www_1`, `farmos2_www_`1, etc.\r\n\r\nBut if `container_name` is defined in docker-compose.yml, then that doesn't work anymore. I get the following error when I try it:\r\n\r\n    Recreating farmostest2_db_1\r\n\r\n    ERROR: for db  Cannot create container for service db: Conflict. The name \"/farmos-db\" is already in use by container ce0f223c3080a13074356703f5b0d662225874228d9bc728c0f7a5936a238a7d. You have to remove (or rename) that container to be able to reuse that name.\r\n    ERROR: Encountered errors while bringing up the project.\r\n\r\nI think the same is true of the `bridge` parameter. It seems that Docker creates a single network called \"bridge\". Whereas without it, it creates a network called \"farmos_default\" (using the name of the parent folder followed by `_default`).\r\n\r\nI wonder if there is another way to solve the issues on OS X without sacrificing the ability to run multiple local dev sites?\r\n\r\nDo you have a sense of exactly what problems the `container_name` and `network` parameters were fixing? Maybe we can find another fix."}}
{"actor":{"display_login":"mstenta"}}