{"action":"opened","number":184,"pull_request":{"url":"https://api.github.com/repos/w3c/testharness.js/pulls/184","id":58786908,"html_url":"https://github.com/w3c/testharness.js/pull/184","diff_url":"https://github.com/w3c/testharness.js/pull/184.diff","patch_url":"https://github.com/w3c/testharness.js/pull/184.patch","issue_url":"https://api.github.com/repos/w3c/testharness.js/issues/184","number":184,"state":"open","locked":false,"title":"Allow longer strings when emitting errors, truncate at 1000 vs 60.","user":{"login":"scheib","id":386971,"avatar_url":"https://avatars.githubusercontent.com/u/386971?v=3","gravatar_id":"","url":"https://api.github.com/users/scheib","html_url":"https://github.com/scheib","followers_url":"https://api.github.com/users/scheib/followers","following_url":"https://api.github.com/users/scheib/following{/other_user}","gists_url":"https://api.github.com/users/scheib/gists{/gist_id}","starred_url":"https://api.github.com/users/scheib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheib/subscriptions","organizations_url":"https://api.github.com/users/scheib/orgs","repos_url":"https://api.github.com/users/scheib/repos","events_url":"https://api.github.com/users/scheib/events{/privacy}","received_events_url":"https://api.github.com/users/scheib/received_events","type":"User","site_admin":false},"body":"format_value truncates strings for readability, but was too aggressive. More recent APIs implementation emit useful error messages, e.g. Web Bluetooth may emit a message such as:\r\n\r\nSyntaxError: Failed to execute 'getCharacteristic' on 'BluetoothGATTService': Invalid Characteristic name: 'heart_rate'. It must be a valid UUID alias (e.g. 0x1234), UUID (lowercase hex characters e.g. '00001234-0000-1000-8000-00805f9b34fb'), or recognized standard name from https://developer.bluetooth.org/gatt/characteristics/Pages/CharacteristicsHome.aspx e.g. 'aerobic_heart_rate_lower_limit'.\r\n\r\nAt least 110 characters are necessary to understand the reason a test is failing. The truncation shouldn't make tests hard to understand or diagnose. A well formed and performing test will not emit long strings, so this is primarily for diagnosing when something isn't working.\r\n\r\nRemoving truncation may result in very large objects still completely spamming the output. Thus, increasing to 1000, as an order of magnitude larger than what is known to be useful seems an appropriate solution.","created_at":"2016-02-09T18:16:45Z","updated_at":"2016-02-09T18:16:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/testharness.js/pulls/184/commits","review_comments_url":"https://api.github.com/repos/w3c/testharness.js/pulls/184/comments","review_comment_url":"https://api.github.com/repos/w3c/testharness.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/testharness.js/issues/184/comments","statuses_url":"https://api.github.com/repos/w3c/testharness.js/statuses/2457d4057a9466a2979af077fd4b7860bf5c3024","head":{"label":"scheib:increase-truncate-limit","ref":"increase-truncate-limit","sha":"2457d4057a9466a2979af077fd4b7860bf5c3024","user":{"login":"scheib","id":386971,"avatar_url":"https://avatars.githubusercontent.com/u/386971?v=3","gravatar_id":"","url":"https://api.github.com/users/scheib","html_url":"https://github.com/scheib","followers_url":"https://api.github.com/users/scheib/followers","following_url":"https://api.github.com/users/scheib/following{/other_user}","gists_url":"https://api.github.com/users/scheib/gists{/gist_id}","starred_url":"https://api.github.com/users/scheib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheib/subscriptions","organizations_url":"https://api.github.com/users/scheib/orgs","repos_url":"https://api.github.com/users/scheib/repos","events_url":"https://api.github.com/users/scheib/events{/privacy}","received_events_url":"https://api.github.com/users/scheib/received_events","type":"User","site_admin":false},"repo":{"id":51331844,"name":"testharness.js","full_name":"scheib/testharness.js","owner":{"login":"scheib","id":386971,"avatar_url":"https://avatars.githubusercontent.com/u/386971?v=3","gravatar_id":"","url":"https://api.github.com/users/scheib","html_url":"https://github.com/scheib","followers_url":"https://api.github.com/users/scheib/followers","following_url":"https://api.github.com/users/scheib/following{/other_user}","gists_url":"https://api.github.com/users/scheib/gists{/gist_id}","starred_url":"https://api.github.com/users/scheib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheib/subscriptions","organizations_url":"https://api.github.com/users/scheib/orgs","repos_url":"https://api.github.com/users/scheib/repos","events_url":"https://api.github.com/users/scheib/events{/privacy}","received_events_url":"https://api.github.com/users/scheib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scheib/testharness.js","description":"","fork":true,"url":"https://api.github.com/repos/scheib/testharness.js","forks_url":"https://api.github.com/repos/scheib/testharness.js/forks","keys_url":"https://api.github.com/repos/scheib/testharness.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scheib/testharness.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scheib/testharness.js/teams","hooks_url":"https://api.github.com/repos/scheib/testharness.js/hooks","issue_events_url":"https://api.github.com/repos/scheib/testharness.js/issues/events{/number}","events_url":"https://api.github.com/repos/scheib/testharness.js/events","assignees_url":"https://api.github.com/repos/scheib/testharness.js/assignees{/user}","branches_url":"https://api.github.com/repos/scheib/testharness.js/branches{/branch}","tags_url":"https://api.github.com/repos/scheib/testharness.js/tags","blobs_url":"https://api.github.com/repos/scheib/testharness.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scheib/testharness.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scheib/testharness.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/scheib/testharness.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scheib/testharness.js/statuses/{sha}","languages_url":"https://api.github.com/repos/scheib/testharness.js/languages","stargazers_url":"https://api.github.com/repos/scheib/testharness.js/stargazers","contributors_url":"https://api.github.com/repos/scheib/testharness.js/contributors","subscribers_url":"https://api.github.com/repos/scheib/testharness.js/subscribers","subscription_url":"https://api.github.com/repos/scheib/testharness.js/subscription","commits_url":"https://api.github.com/repos/scheib/testharness.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/scheib/testharness.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/scheib/testharness.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/scheib/testharness.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/scheib/testharness.js/contents/{+path}","compare_url":"https://api.github.com/repos/scheib/testharness.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scheib/testharness.js/merges","archive_url":"https://api.github.com/repos/scheib/testharness.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scheib/testharness.js/downloads","issues_url":"https://api.github.com/repos/scheib/testharness.js/issues{/number}","pulls_url":"https://api.github.com/repos/scheib/testharness.js/pulls{/number}","milestones_url":"https://api.github.com/repos/scheib/testharness.js/milestones{/number}","notifications_url":"https://api.github.com/repos/scheib/testharness.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scheib/testharness.js/labels{/name}","releases_url":"https://api.github.com/repos/scheib/testharness.js/releases{/id}","deployments_url":"https://api.github.com/repos/scheib/testharness.js/deployments","created_at":"2016-02-08T22:26:58Z","updated_at":"2016-02-08T22:26:59Z","pushed_at":"2016-02-08T22:41:19Z","git_url":"git://github.com/scheib/testharness.js.git","ssh_url":"git@github.com:scheib/testharness.js.git","clone_url":"https://github.com/scheib/testharness.js.git","svn_url":"https://github.com/scheib/testharness.js","homepage":"","size":4480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"80578bab0e1a7a4b8a3f9d10b141b7b5c2959c23","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3608990,"name":"testharness.js","full_name":"w3c/testharness.js","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/testharness.js","description":"","fork":false,"url":"https://api.github.com/repos/w3c/testharness.js","forks_url":"https://api.github.com/repos/w3c/testharness.js/forks","keys_url":"https://api.github.com/repos/w3c/testharness.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/testharness.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/testharness.js/teams","hooks_url":"https://api.github.com/repos/w3c/testharness.js/hooks","issue_events_url":"https://api.github.com/repos/w3c/testharness.js/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/testharness.js/events","assignees_url":"https://api.github.com/repos/w3c/testharness.js/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/testharness.js/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/testharness.js/tags","blobs_url":"https://api.github.com/repos/w3c/testharness.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/testharness.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/testharness.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/testharness.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/testharness.js/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/testharness.js/languages","stargazers_url":"https://api.github.com/repos/w3c/testharness.js/stargazers","contributors_url":"https://api.github.com/repos/w3c/testharness.js/contributors","subscribers_url":"https://api.github.com/repos/w3c/testharness.js/subscribers","subscription_url":"https://api.github.com/repos/w3c/testharness.js/subscription","commits_url":"https://api.github.com/repos/w3c/testharness.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/testharness.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/testharness.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/testharness.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/testharness.js/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/testharness.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/testharness.js/merges","archive_url":"https://api.github.com/repos/w3c/testharness.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/testharness.js/downloads","issues_url":"https://api.github.com/repos/w3c/testharness.js/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/testharness.js/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/testharness.js/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/testharness.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/testharness.js/labels{/name}","releases_url":"https://api.github.com/repos/w3c/testharness.js/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/testharness.js/deployments","created_at":"2012-03-03T06:20:05Z","updated_at":"2016-01-27T19:16:01Z","pushed_at":"2016-02-04T23:09:34Z","git_url":"git://github.com/w3c/testharness.js.git","ssh_url":"git@github.com:w3c/testharness.js.git","clone_url":"https://github.com/w3c/testharness.js.git","svn_url":"https://github.com/w3c/testharness.js","homepage":"","size":4698,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":47,"forks":120,"open_issues":47,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/testharness.js/pulls/184"},"html":{"href":"https://github.com/w3c/testharness.js/pull/184"},"issue":{"href":"https://api.github.com/repos/w3c/testharness.js/issues/184"},"comments":{"href":"https://api.github.com/repos/w3c/testharness.js/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/testharness.js/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/testharness.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/testharness.js/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/testharness.js/statuses/2457d4057a9466a2979af077fd4b7860bf5c3024"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}