{"action":"created","issue":{"url":"https://api.github.com/repos/moment/moment/issues/3595","repository_url":"https://api.github.com/repos/moment/moment","labels_url":"https://api.github.com/repos/moment/moment/issues/3595/labels{/name}","comments_url":"https://api.github.com/repos/moment/moment/issues/3595/comments","events_url":"https://api.github.com/repos/moment/moment/issues/3595/events","html_url":"https://github.com/moment/moment/pull/3595","id":188734517,"number":3595,"title":"Fix accidental reference to global \"value\" variable","user":{"login":"davidxmoody","id":4699197,"avatar_url":"https://avatars.githubusercontent.com/u/4699197?v=3","gravatar_id":"","url":"https://api.github.com/users/davidxmoody","html_url":"https://github.com/davidxmoody","followers_url":"https://api.github.com/users/davidxmoody/followers","following_url":"https://api.github.com/users/davidxmoody/following{/other_user}","gists_url":"https://api.github.com/users/davidxmoody/gists{/gist_id}","starred_url":"https://api.github.com/users/davidxmoody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidxmoody/subscriptions","organizations_url":"https://api.github.com/users/davidxmoody/orgs","repos_url":"https://api.github.com/users/davidxmoody/repos","events_url":"https://api.github.com/users/davidxmoody/events{/privacy}","received_events_url":"https://api.github.com/users/davidxmoody/received_events","type":"User","site_admin":false},"labels":[{"id":313210217,"url":"https://api.github.com/repos/moment/moment/labels/Pending%20Next%20Release","name":"Pending Next Release","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-11T10:54:19Z","updated_at":"2016-11-12T06:08:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moment/moment/pulls/3595","html_url":"https://github.com/moment/moment/pull/3595","diff_url":"https://github.com/moment/moment/pull/3595.diff","patch_url":"https://github.com/moment/moment/pull/3595.patch"},"body":"Hi,\r\n\r\nWe just encountered a bug today where moment was incorrectly parsing year and month fields. The bug was introduced while upgrading to moment v2.16.0.\r\n\r\nWe eventually tracked it down to another library (modular-scale) which was setting a global variable called `value` to a number. The isNumber function in moment is then mistakenly referencing this global value instead of the input value it gets passed. This pull request fixes the problem.\r\n\r\nAll the best,\r\nDavid"},"comment":{"url":"https://api.github.com/repos/moment/moment/issues/comments/260104477","html_url":"https://github.com/moment/moment/pull/3595#issuecomment-260104477","issue_url":"https://api.github.com/repos/moment/moment/issues/3595","id":260104477,"user":{"login":"ichernev","id":757060,"avatar_url":"https://avatars.githubusercontent.com/u/757060?v=3","gravatar_id":"","url":"https://api.github.com/users/ichernev","html_url":"https://github.com/ichernev","followers_url":"https://api.github.com/users/ichernev/followers","following_url":"https://api.github.com/users/ichernev/following{/other_user}","gists_url":"https://api.github.com/users/ichernev/gists{/gist_id}","starred_url":"https://api.github.com/users/ichernev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichernev/subscriptions","organizations_url":"https://api.github.com/users/ichernev/orgs","repos_url":"https://api.github.com/users/ichernev/repos","events_url":"https://api.github.com/users/ichernev/events{/privacy}","received_events_url":"https://api.github.com/users/ichernev/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T06:08:05Z","updated_at":"2016-11-12T06:08:05Z","body":"Merged in 93d1a675cb4879e85173be35422e9d88836a9b36"}}
{"actor":{"display_login":"ichernev"}}