{"action":"created","issue":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1732","repository_url":"https://api.github.com/repos/mitmproxy/mitmproxy","labels_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1732/labels{/name}","comments_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1732/comments","events_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1732/events","html_url":"https://github.com/mitmproxy/mitmproxy/pull/1732","id":188881401,"number":1732,"title":"Added proxy_username to HTTPFlow object","user":{"login":"martyn-w","id":86833,"avatar_url":"https://avatars.githubusercontent.com/u/86833?v=3","gravatar_id":"","url":"https://api.github.com/users/martyn-w","html_url":"https://github.com/martyn-w","followers_url":"https://api.github.com/users/martyn-w/followers","following_url":"https://api.github.com/users/martyn-w/following{/other_user}","gists_url":"https://api.github.com/users/martyn-w/gists{/gist_id}","starred_url":"https://api.github.com/users/martyn-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyn-w/subscriptions","organizations_url":"https://api.github.com/users/martyn-w/orgs","repos_url":"https://api.github.com/users/martyn-w/repos","events_url":"https://api.github.com/users/martyn-w/events{/privacy}","received_events_url":"https://api.github.com/users/martyn-w/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-12T00:56:52Z","updated_at":"2016-11-12T00:58:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/pulls/1732","html_url":"https://github.com/mitmproxy/mitmproxy/pull/1732","diff_url":"https://github.com/mitmproxy/mitmproxy/pull/1732.diff","patch_url":"https://github.com/mitmproxy/mitmproxy/pull/1732.patch"},"body":"Hi,\r\n\r\nThis PR adds a variable `proxy_username` to the HTTPFlow class, which is used to store the username authenticating with MITMProxy.\r\n\r\nI'm quite new to the codebase (and also to Python) so this may not be structured in the best way possible - please could you review the code and feel free to suggest improvements or additional tests?\r\n\r\nThanks,\r\n\r\nMartyn."},"comment":{"url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/comments/260089654","html_url":"https://github.com/mitmproxy/mitmproxy/pull/1732#issuecomment-260089654","issue_url":"https://api.github.com/repos/mitmproxy/mitmproxy/issues/1732","id":260089654,"user":{"login":"cortesi","id":22544,"avatar_url":"https://avatars.githubusercontent.com/u/22544?v=3","gravatar_id":"","url":"https://api.github.com/users/cortesi","html_url":"https://github.com/cortesi","followers_url":"https://api.github.com/users/cortesi/followers","following_url":"https://api.github.com/users/cortesi/following{/other_user}","gists_url":"https://api.github.com/users/cortesi/gists{/gist_id}","starred_url":"https://api.github.com/users/cortesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cortesi/subscriptions","organizations_url":"https://api.github.com/users/cortesi/orgs","repos_url":"https://api.github.com/users/cortesi/repos","events_url":"https://api.github.com/users/cortesi/events{/privacy}","received_events_url":"https://api.github.com/users/cortesi/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T00:58:29Z","updated_at":"2016-11-12T00:58:29Z","body":"Hi there, and thanks for working on mitmproxy. I'm rewriting this portion of the codebase right now (proxy and upstream authentication). Could you fill me in on the use-case here? \r\n\r\n\r\n"}}
{"actor":{"display_login":"cortesi"}}