{"action":"opened","number":140,"pull_request":{"url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140","id":86254750,"html_url":"https://github.com/cloudflare/gokeyless/pull/140","diff_url":"https://github.com/cloudflare/gokeyless/pull/140.diff","patch_url":"https://github.com/cloudflare/gokeyless/pull/140.patch","issue_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/140","number":140,"state":"open","locked":false,"title":"Allow the server to not respond to some requests.","user":{"login":"Bren2010","id":416022,"avatar_url":"https://avatars.githubusercontent.com/u/416022?v=3","gravatar_id":"","url":"https://api.github.com/users/Bren2010","html_url":"https://github.com/Bren2010","followers_url":"https://api.github.com/users/Bren2010/followers","following_url":"https://api.github.com/users/Bren2010/following{/other_user}","gists_url":"https://api.github.com/users/Bren2010/gists{/gist_id}","starred_url":"https://api.github.com/users/Bren2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bren2010/subscriptions","organizations_url":"https://api.github.com/users/Bren2010/orgs","repos_url":"https://api.github.com/users/Bren2010/repos","events_url":"https://api.github.com/users/Bren2010/events{/privacy}","received_events_url":"https://api.github.com/users/Bren2010/received_events","type":"User","site_admin":false},"body":"Allowing the gokeyless server to panic w/o dying means that some requests will not get responses, and should timeout.\r\n\r\nImagine you call \"DoOperation\" twice. The first request causes a panic and the second is successful. The first DoOperation reads the second response and puts it into the channel and blocks on waiting for its own response, eventually timing out. The second DoOperation will block on reading another header from the socket. If a third DoOperation happens and gets a successful response, the second DoOperation will unblock and return its response, and the third DoOperation will hang until a fourth DoOperation. And on...","created_at":"2016-09-21T22:45:44Z","updated_at":"2016-09-21T22:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36bf2630a87ed2567797b982956ed55141d43019","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140/commits","review_comments_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140/comments","review_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/140/comments","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/c75724177719a6825b4ad97b3ad6ee7dda94015b","head":{"label":"cloudflare:brendan/no-lag","ref":"brendan/no-lag","sha":"c75724177719a6825b4ad97b3ad6ee7dda94015b","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":37894193,"name":"gokeyless","full_name":"cloudflare/gokeyless","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/gokeyless","description":"Go implementation of the keyless protocol","fork":false,"url":"https://api.github.com/repos/cloudflare/gokeyless","forks_url":"https://api.github.com/repos/cloudflare/gokeyless/forks","keys_url":"https://api.github.com/repos/cloudflare/gokeyless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/gokeyless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/gokeyless/teams","hooks_url":"https://api.github.com/repos/cloudflare/gokeyless/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/gokeyless/events","assignees_url":"https://api.github.com/repos/cloudflare/gokeyless/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/gokeyless/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/gokeyless/tags","blobs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/gokeyless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/gokeyless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/gokeyless/languages","stargazers_url":"https://api.github.com/repos/cloudflare/gokeyless/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/gokeyless/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/gokeyless/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/gokeyless/subscription","commits_url":"https://api.github.com/repos/cloudflare/gokeyless/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/gokeyless/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/gokeyless/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/gokeyless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/gokeyless/merges","archive_url":"https://api.github.com/repos/cloudflare/gokeyless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/gokeyless/downloads","issues_url":"https://api.github.com/repos/cloudflare/gokeyless/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/gokeyless/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/gokeyless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/gokeyless/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/gokeyless/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/gokeyless/deployments","created_at":"2015-06-23T03:09:09Z","updated_at":"2016-09-12T20:56:36Z","pushed_at":"2016-09-21T22:45:44Z","git_url":"git://github.com/cloudflare/gokeyless.git","ssh_url":"git@github.com:cloudflare/gokeyless.git","clone_url":"https://github.com/cloudflare/gokeyless.git","svn_url":"https://github.com/cloudflare/gokeyless","homepage":null,"size":988,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":70,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"40e71f34b36bdf925a04c6ece5af5479f80f0b4e","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":37894193,"name":"gokeyless","full_name":"cloudflare/gokeyless","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/gokeyless","description":"Go implementation of the keyless protocol","fork":false,"url":"https://api.github.com/repos/cloudflare/gokeyless","forks_url":"https://api.github.com/repos/cloudflare/gokeyless/forks","keys_url":"https://api.github.com/repos/cloudflare/gokeyless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/gokeyless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/gokeyless/teams","hooks_url":"https://api.github.com/repos/cloudflare/gokeyless/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/gokeyless/events","assignees_url":"https://api.github.com/repos/cloudflare/gokeyless/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/gokeyless/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/gokeyless/tags","blobs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/gokeyless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/gokeyless/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/gokeyless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/gokeyless/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/gokeyless/languages","stargazers_url":"https://api.github.com/repos/cloudflare/gokeyless/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/gokeyless/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/gokeyless/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/gokeyless/subscription","commits_url":"https://api.github.com/repos/cloudflare/gokeyless/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/gokeyless/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/gokeyless/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/gokeyless/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/gokeyless/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/gokeyless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/gokeyless/merges","archive_url":"https://api.github.com/repos/cloudflare/gokeyless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/gokeyless/downloads","issues_url":"https://api.github.com/repos/cloudflare/gokeyless/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/gokeyless/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/gokeyless/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/gokeyless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/gokeyless/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/gokeyless/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/gokeyless/deployments","created_at":"2015-06-23T03:09:09Z","updated_at":"2016-09-12T20:56:36Z","pushed_at":"2016-09-21T22:45:44Z","git_url":"git://github.com/cloudflare/gokeyless.git","ssh_url":"git@github.com:cloudflare/gokeyless.git","clone_url":"https://github.com/cloudflare/gokeyless.git","svn_url":"https://github.com/cloudflare/gokeyless","homepage":null,"size":988,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140"},"html":{"href":"https://github.com/cloudflare/gokeyless/pull/140"},"issue":{"href":"https://api.github.com/repos/cloudflare/gokeyless/issues/140"},"comments":{"href":"https://api.github.com/repos/cloudflare/gokeyless/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/gokeyless/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/gokeyless/statuses/c75724177719a6825b4ad97b3ad6ee7dda94015b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"Bren2010"}}