{"push_id":1024095216,"size":371,"distinct_size":1,"ref":"refs/heads/sfu-develop","head":"6080e91dce05e664ade1eec0794e0b4d720f739e","before":"1576871e64ebecf46ca16626b86f76a9afcbd21e","commits":[{"sha":"4585fdedb2c93b0f972b33673adc1ba42646e9a6","author":{"email":"c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","name":"Cody Cutrer"},"message":"enforce not-null on role overrides.enabled and locked\n\nChange-Id: Iba5cffd103ccd15aedfd996403057967dd60be62\nReviewed-on: https://gerrit.instructure.com/25895\nTested-by: Jenkins\nReviewed-by: Rob Orton <rob@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/4585fdedb2c93b0f972b33673adc1ba42646e9a6"},{"sha":"ec50e13f2d21cf000253c9cebc3172d5c07f13c4","author":{"email":"c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","name":"Cody Cutrer"},"message":"bump switchman\n\ntest plan:\n * test all the things!\n\nChange-Id: I1ecd36be4165fbbce84132a26d0e47db6d1aa31d\nReviewed-on: https://gerrit.instructure.com/71073\nTested-by: Jenkins\nReviewed-by: James Williams  <jamesw@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/ec50e13f2d21cf000253c9cebc3172d5c07f13c4"},{"sha":"eb598ab5b35854f09a3b017d0b508df8cc2eb33e","author":{"email":"088e16a1019277b15d58faf0541e11910eb756f6@instructure.com","name":"Simon Williams"},"message":"only count active quizzes in course stats\n\nfixes CNVS-26308\n\ntest plan:\n- create 2 quizzes, with questions\n- take them both\n- delete 1 of them\n- go to the course stats page\n- only the non-deleted quiz should count\n  (for quizzes, questions, and submissions)\n\nChange-Id: Ib6155e1036fce43c81c2ad346b7252e818831114\nReviewed-on: https://gerrit.instructure.com/70822\nTested-by: Jenkins\nReviewed-by: Ryan Taylor <rtaylor@instructure.com>\nQA-Review: Michael Hargiss <mhargiss@instructure.com>\nProduct-Review: Simon Williams <simon@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/eb598ab5b35854f09a3b017d0b508df8cc2eb33e"},{"sha":"5df84d11710e042a626e7eea0974142d1b590e62","author":{"email":"691289743b3739516b93ebf9090eb6c75ea2793c@gmail.com","name":"Ethan Vizitei"},"message":"include root account on error_report messages\n\nrefs CNVS-26792\n\nmessages are easier to group back to their accounts if the\nroot_account_id is popluated when a ticketing system ticket\nis created and a send via email is attempted.\n\nTEST PLAN:\n 1) enable ticketing connector for email\n 2) file a ticket\n 3) in the rails console, the generated message object\n    has it's root_account_id populated\n\nChange-Id: Iceae2d09c6a33ba522a4333f634d238a78c81e03\nReviewed-on: https://gerrit.instructure.com/71068\nTested-by: Jenkins\nReviewed-by: Simon Williams <simon@instructure.com>\nQA-Review: August Thornton <august@instructure.com>\nProduct-Review: Ethan Vizitei <evizitei@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/5df84d11710e042a626e7eea0974142d1b590e62"},{"sha":"4558243af0701fa3a3a5dbcc9ea277f5db614620","author":{"email":"7cc0890d6f1f70810a023e7173eca5724d6c8e49@instructure.com","name":"Spencer Olson"},"message":"grading schemes page: fix a11y issues\n\nfix multiple a11y issues on the\ngrading schemes page.\n\ncloses CNVS-26083\ncloses CNVS-26082\ncloses CNVS-26206\ncloses CNVS-26217\n\ntest plan:\n\nA) Verify extraneous focus area\nno longer exists when editing\n\n  - Begin editing a grading scheme\n  - Press Tab to move from the title\n    field to the first row\n  - Note that the \"+\" is focused (before\n    this fix, a large, awkwardly placed\n    grey box would be focused before the\n    \"+\" button was focused)\n\nB) Verify focus on grading schemes\n\n  - Tab to the \"Add grading scheme\" button\n  - Tab again and note that focus is on a\n    grading scheme (before this fix, the\n    focus would disappear and skip over the\n    grading scheme)\n\nC) Verify the icon to add a new line on\na grading scheme is always visible when editing\n\n  - Begin editing a grading scheme\n  - Verify a \"+\" icon appears next to each line\n    of the grading scheme (before this fix, the\n    \"+\" icon would only appear when hovering\n    or focusing on a line)\n\nD) Verify the 'Add a grading scheme button' is\n   announced as a 'Button'\n\n  - Navigate to the \"Add a grading scheme\" button\n    using a screenreader. Verify the \"Add a grading\n    scheme\" button is announced as a button (\n    previously, this was announced as a link)\n\nE) Verify the icons to edit and trash grading\n   schemes are announced as 'Button's\n\n  - Using a screenreader, navigate to the pencil\n    icon within a grading scheme. Verify the\n    pencil icon is announced as a button (\n    previously, this was announced as a link)\n  - Using a screenreader, navigate to the trash\n    icon within a grading scheme. Verify the\n    trash icon is announced as a button (\n    previously, this was announced as a link)\n\nF) Verify the icons to add and delete lines of\na grading scheme are announced as 'Button's\n\n  - Begin editing a grading scheme\n  - Navigate to the \"+\" icon using a screenreader.\n    Verify the \"+\" is announced as a button (\n    previously, this was announced as a link)\n  - Navigate to the \"x\" icon using a screenreader.\n    Verify the \"x\" is announced as a button (\n    previously, this was announced as a link)\n\nChange-Id: I49c46fe8d9d7eaf40551e23f70673b519ed89898\nReviewed-on: https://gerrit.instructure.com/70796\nTested-by: Jenkins\nReviewed-by: Derek Bender <djbender@instructure.com>\nQA-Review: KC Naegle <knaegle@instructure.com>\nProduct-Review: Spencer Olson <solson@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/4558243af0701fa3a3a5dbcc9ea277f5db614620"},{"sha":"b27b4ceea9330ba402141c3f00c63035c8b5040f","author":{"email":"7a57d889ea7f266299434459898a90c7f6a1ca4d@instructure.com","name":"Sterling Cobb"},"message":"add descriptive aria-label to rich content editors\n\nfixes CNVS-15756\n\nTest Plan\nGiven I'm working in NVDA\nAnd I'm using firefox\nWhen I go to any page with the Rich Content Editor\nAnd I navigate to that editor\nThen I should hear the screen reader read aria-label \"Rich Content Editor\"\n\nChange-Id: Idb5f527e58ac5cf66c97419e452d87480733fd06\nReviewed-on: https://gerrit.instructure.com/71104\nProduct-Review: Aaron Cannon <acannon@instructure.com>\nTested-by: Jenkins\nReviewed-by: Bryan Petty <bpetty@instructure.com>\nQA-Review: Michael Hargiss <mhargiss@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/b27b4ceea9330ba402141c3f00c63035c8b5040f"},{"sha":"74c5beba22839881fd801cb9705c1b5d8365e54f","author":{"email":"3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@instructure.com","name":"Brian Palmer"},"message":"restore cache store logging in rails 4.0\n\nfixes CNVS-26757\n\nIt turns out this code is still necessary in rails 4.0, it's the rails\n4.2 branch where it is deprecated and always true.\n\ntest plan: do some redis cache reads and writes, verify the \"CacheStore\"\nlines appear in the debug logs.\n\nChange-Id: I51a2696f3e7104c8d54f0b5bb5ca61fac0e20656\nReviewed-on: https://gerrit.instructure.com/71155\nReviewed-by: Simon Williams <simon@instructure.com>\nQA-Review: August Thornton <august@instructure.com>\nTested-by: Jenkins\nProduct-Review: Brian Palmer <brianp@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/74c5beba22839881fd801cb9705c1b5d8365e54f"},{"sha":"00f622e92826d33fb6ca19c884d2465bc316e528","author":{"email":"088e16a1019277b15d58faf0541e11910eb756f6@instructure.com","name":"Simon Williams"},"message":"fix course api for logged out users\n\nfixes CNVS-26840\n\ntest plan:\n- in a public course, as a logged out user,\n- hit the /api/v1/courses/X api\n- it should work\n\nChange-Id: Ibfa1b04ee0c7599d56df6d16c37c4aa615160708\nReviewed-on: https://gerrit.instructure.com/71014\nTested-by: Jenkins\nReviewed-by: Cody Cutrer <cody@instructure.com>\nQA-Review: Jeremy Putnam <jeremyp@instructure.com>\nProduct-Review: Simon Williams <simon@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/00f622e92826d33fb6ca19c884d2465bc316e528"},{"sha":"aa627e50a61357c408f1888334730f282b164ce7","author":{"email":"c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","name":"Cody Cutrer"},"message":"bump switchman\n\nChange-Id: I46a608cf4e3dfd1c981d585dd2d057322691172e\nReviewed-on: https://gerrit.instructure.com/71192\nReviewed-by: Brian Palmer <brianp@instructure.com>\nTested-by: Jenkins\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/aa627e50a61357c408f1888334730f282b164ce7"},{"sha":"fae0cfd3e305c63bd15166067705e02795cb9b04","author":{"email":"691289743b3739516b93ebf9090eb6c75ea2793c@gmail.com","name":"Ethan Vizitei"},"message":"spec: make cdn_spec webpack friendly\n\nrefs CNVS-25916\n\nCDN spec made some assumptions about require_js base bundles,\nthis adds a conditional to check if we're using webpack\nin this context first and fixes the js paths and bundles expected\nif so.\n\nTEST PLAN:\n 1) selenium webpack pass rate should go through the roof\n\nChange-Id: I07c4b4fec5c91d9ebe21a6375b1add03b3041015\nReviewed-on: https://gerrit.instructure.com/71218\nTested-by: Jenkins\nReviewed-by: Cody Cutrer <cody@instructure.com>\nProduct-Review: Ethan Vizitei <evizitei@instructure.com>\nQA-Review: Ethan Vizitei <evizitei@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/fae0cfd3e305c63bd15166067705e02795cb9b04"},{"sha":"07c0a58fbaaccd032de40895ac3ce6147f6f1e00","author":{"email":"691289743b3739516b93ebf9090eb6c75ea2793c@gmail.com","name":"Ethan Vizitei"},"message":"spec: stabilize groups_shared_examples\n\nrefs CNVS-25916\n\nthis link doesn't always exist right when the page loads,\nso sometimes we try to click on it before it's there.\nThis awaits the correct behavior.\n\nTEST PLAN:\n 1) groups_shared_Examples should become less fragile in jenkins runs\n\nChange-Id: I3e57f12a93510ba1dd2a323855cc6b86e859ed49\nReviewed-on: https://gerrit.instructure.com/71186\nReviewed-by: Simon Williams <simon@instructure.com>\nTested-by: Jenkins\nProduct-Review: Ethan Vizitei <evizitei@instructure.com>\nQA-Review: Ethan Vizitei <evizitei@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/07c0a58fbaaccd032de40895ac3ce6147f6f1e00"},{"sha":"4b1b4caf423fa32d9176566c0ace2c8906bc40fd","author":{"email":"691289743b3739516b93ebf9090eb6c75ea2793c@gmail.com","name":"Ethan Vizitei"},"message":"spec: stabilize quizzes_unpublish_quiz_teacher_spec\n\nrefs CNVS-25916\n\nbuilds on top of c/71022.  this published link has it's text changed in stages (to\nblank then to unpublished)\nand if we start asserting things on it before it's been populated\nwe get intermittant breakages.  This makes sure the transition is\ncomplete before continuing into the specs.\n\nTEST PLAN:\n 1) quizzes_unpublish_quiz_teacher_spec fail rate should fall\nsignificantly\n\nChange-Id: Ib3898782d7f7a80f930ca8da5e65f8061bd404f1\nReviewed-on: https://gerrit.instructure.com/71183\nTested-by: Jenkins\nReviewed-by: Simon Williams <simon@instructure.com>\nProduct-Review: Ethan Vizitei <evizitei@instructure.com>\nQA-Review: Ethan Vizitei <evizitei@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/4b1b4caf423fa32d9176566c0ace2c8906bc40fd"},{"sha":"ab0f9be30c823d97087a227776cf786c8563d007","author":{"email":"3a5f4ed991dbfa5c9ef76ad729d240ca12f62180@instructure.com","name":"James Williams"},"message":"rails 4.2: turn xss_safe mode on for json\n\nrefs #CNVS-26056\n\nChange-Id: I1c5c8e0568d619dd7cadc20f6a3a34cab46b12fa\nReviewed-on: https://gerrit.instructure.com/71173\nTested-by: Jenkins\nReviewed-by: Cody Cutrer <cody@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>\nQA-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/ab0f9be30c823d97087a227776cf786c8563d007"},{"sha":"56e555543a5b803df0453346fa4058cff5c07767","author":{"email":"3a5f4ed991dbfa5c9ef76ad729d240ca12f62180@instructure.com","name":"James Williams"},"message":"rails 4.2: fix simply_verioned_spec\n\nprevents Woozel from breaking sharding setup\n\nrefs #CNVS-26056\n\nChange-Id: Iecc28589336e21c416df90e0a9cd7a2d3624b6f5\nReviewed-on: https://gerrit.instructure.com/71132\nTested-by: Jenkins\nReviewed-by: Cody Cutrer <cody@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>\nQA-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/56e555543a5b803df0453346fa4058cff5c07767"},{"sha":"48bc66317c6c1cc0691a807ce5885c83b18924a6","author":{"email":"3a5f4ed991dbfa5c9ef76ad729d240ca12f62180@instructure.com","name":"James Williams"},"message":"rails 4.2: more spec fixes\n\nrefs #CNVS-26056\n\nChange-Id: I7faaddf76130ef846364e2c5ead84e568e3bdac5\nReviewed-on: https://gerrit.instructure.com/71175\nTested-by: Jenkins\nReviewed-by: Cody Cutrer <cody@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>\nQA-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/48bc66317c6c1cc0691a807ce5885c83b18924a6"},{"sha":"53733b4743eb319156319b641029d83107235c26","author":{"email":"3a5f4ed991dbfa5c9ef76ad729d240ca12f62180@instructure.com","name":"James Williams"},"message":"rails 4.2: fix invalid assignment_override deletion\n\nfixes problems with validates_associated\n\nrefs #CNVS-26056\n\nChange-Id: I020a7c6905ee61a24520671a5faa472d2b791e45\nReviewed-on: https://gerrit.instructure.com/69787\nReviewed-by: Cody Cutrer <cody@instructure.com>\nTested-by: Jenkins\nReviewed-by: Jeremy Stanley <jeremy@instructure.com>\nReviewed-by: Simon Williams <simon@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>\nQA-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/53733b4743eb319156319b641029d83107235c26"},{"sha":"e046aac6b9ea038616a7f28bd29416889db8e66c","author":{"email":"33564f6eff3d808d3eaaa056a1631fdcde5faed6@instructure.com","name":"Bryan Petty"},"message":"fix spelling of \"assignment\"\n\nfixes CNVS-26208\n\nTest Plan:\n  1. Create a new assignment.\n  2. Set points to a negative number like \"-5\", and click Save.\n  3. Verify correct spelling of \"assignment\" in validation error.\n\nChange-Id: I28617ed343097fefd15b9c826005da3b33ff1176\nReviewed-on: https://gerrit.instructure.com/71051\nReviewed-by: Davis McClellan <dmcclellan@instructure.com>\nTested-by: Jenkins\nQA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>\nProduct-Review: Jason Sparks <jsparks@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/e046aac6b9ea038616a7f28bd29416889db8e66c"},{"sha":"9315eadbd1dce48e27e8de875aa84cc9a54847a7","author":{"email":"3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@instructure.com","name":"Brian Palmer"},"message":"don't raise/record an error when a file link can't be found\n\nrefs sentry error 33094\n\nThis isn't an actionable error, it typically just means bad content was\nimported. It's also extremely common due to content imports. Note that\nthe import warning \"Missing links found in imported content\" is still\nrecorded and displayed in the imports UI, this change just gets rid of\nthe error report.\n\ntest plan: import a common cartridge package that includes an assessment\nquestion that has html pointing to a non-existent image file. no error\nreport should be generated, though you'll still see a warning in the ui\nabout a missing link.\n\nChange-Id: Ic44ee446ed648388c87e022b80c695816f890e23\nReviewed-on: https://gerrit.instructure.com/71162\nTested-by: Jenkins\nReviewed-by: James Williams  <jamesw@instructure.com>\nQA-Review: August Thornton <august@instructure.com>\nProduct-Review: Brian Palmer <brianp@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/9315eadbd1dce48e27e8de875aa84cc9a54847a7"},{"sha":"47557f7a16770f2b95d508af9f5d195c5303168e","author":{"email":"3cb4e1df5ec4da2c7c4af7c52cec8cf340a55a10@instructure.com","name":"Brian Palmer"},"message":"avoid doing empty kaltura bulk uploads\n\nrefs sentry error 33018\n\nIt's very common for us to filter out the lone attachment passed in to\nKalturaMediaFileHandler#add_media_files because the attachment already\nhas a media_object. In that situation, we've been posting a blank csv\nupload to kaltura anyway, causing errors further down the processes.\n\ntest plan: this can happen on uploading a media file, but doesn't always\nhappen, so it might be difficult to intentionally trigger from the ui. From the\nrails console you could attempt to re-upload an attachment that already\nhas a media_object, using something like\n`KalturaMediaFileHandler.new.add_media_files([my_attachment], false)`\nand verify that no exception is raised.\n\nChange-Id: Ia89550df2883f240a2fbc287e0cd2a4086b5b6fb\nReviewed-on: https://gerrit.instructure.com/71214\nReviewed-by: Rob Orton <rob@instructure.com>\nTested-by: Jenkins\nQA-Review: August Thornton <august@instructure.com>\nProduct-Review: Brian Palmer <brianp@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/47557f7a16770f2b95d508af9f5d195c5303168e"},{"sha":"f80ad3fa518a16b50390532b43fbee66a3de37e4","author":{"email":"c4fe2b1d90ef8f2548c8aeabfa633434316f0305@instructure.com","name":"Cody Cutrer"},"message":"fix loading ICU\n\ntest plan:\n * user_spec.rb:2085 should actually run, and pass, on ubuntu\n\nChange-Id: I28b31cbc56d4225f83001c506e1fb752223a8843\nReviewed-on: https://gerrit.instructure.com/71072\nReviewed-by: Simon Williams <simon@instructure.com>\nTested-by: Jenkins\nQA-Review: August Thornton <august@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/sfu/canvas-lms/commits/f80ad3fa518a16b50390532b43fbee66a3de37e4"}]}