{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/75851481","id":75851481,"diff_hunk":"@@ -14033,12 +14033,26 @@ ABoundActivity * HqlCppTranslator::doBuildActivityDedup(BuildCtx & ctx, IHqlExpr\n \n     if (!useHash)\n     {\n-        if (info.compareAllRows)\n-            doBuildBoolFunction(instance->classctx, \"compareAll\", info.compareAllRows);\n-        if (!info.keepLeft)\n-            doBuildBoolFunction(instance->classctx, \"keepLeft\", info.keepLeft);\n+        // Only necessary to create getFlags() if different from base class getFlags() - i.e. different from default\n+        if ( !(!info.compareAllRows && !info.keepBest && info.keepLeft) )\n+        {\n+            StringBuffer flags;\n+            if (info.compareAllRows)\n+                flags.append(\"|DFcompareall\");\n+            if (info.keepLeft)\n+                flags.append(\"|DFkeepleft\");\n+            if (info.keepBest)\n+                flags.append(\"|DFkeepbest\");\n+            if (flags.length()==0)\n+                flags.append(\"|0\");","path":"ecl/hqlcpp/hqlhtcpp.cpp","position":19,"original_position":19,"commit_id":"4f3b96372a97616fec2cd19223d8e83bc47a5f56","original_commit_id":"4f3b96372a97616fec2cd19223d8e83bc47a5f56","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"body":"Please see the previous explanation. (This is for the situation where compareAllRows=false, keepBest=false and keepLeft=false.  i.e. all the flags are OFF).","created_at":"2016-08-23T12:02:19Z","updated_at":"2016-08-23T12:02:19Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023#discussion_r75851481","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/75851481"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023#discussion_r75851481"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023","id":81978783,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9023","number":9023,"state":"open","locked":false,"title":"HPCC-15926 Add BEST attribute to DEDUP","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shamser Ahmed <shamser.ahmed@lexisnexis.co.uk>","created_at":"2016-08-19T13:12:45Z","updated_at":"2016-08-23T12:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7adeb06248575a6d23f976bd65f35b0c3a14754e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9023/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/4f3b96372a97616fec2cd19223d8e83bc47a5f56","head":{"label":"shamser:issue15926","ref":"issue15926","sha":"4f3b96372a97616fec2cd19223d8e83bc47a5f56","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"repo":{"id":32939247,"name":"HPCC-Platform","full_name":"shamser/HPCC-Platform","owner":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shamser/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/shamser/HPCC-Platform","forks_url":"https://api.github.com/repos/shamser/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/shamser/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shamser/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shamser/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/shamser/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/shamser/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/shamser/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/shamser/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shamser/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/shamser/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/shamser/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/shamser/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/shamser/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/shamser/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/shamser/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shamser/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/shamser/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shamser/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/shamser/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/shamser/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/shamser/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shamser/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/shamser/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/shamser/HPCC-Platform/deployments","created_at":"2015-03-26T16:34:05Z","updated_at":"2016-01-18T14:01:23Z","pushed_at":"2016-08-23T09:45:28Z","git_url":"git://github.com/shamser/HPCC-Platform.git","ssh_url":"git@github.com:shamser/HPCC-Platform.git","clone_url":"https://github.com/shamser/HPCC-Platform.git","svn_url":"https://github.com/shamser/HPCC-Platform","homepage":"track.hpccsystems.com","size":161651,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"ed7936b257174aa9f842a8b110ab61329750e78d","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-08-22T09:01:00Z","pushed_at":"2016-08-23T11:10:06Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":182715,"stargazers_count":285,"watchers_count":285,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":427,"forks":150,"open_issues":427,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9023"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9023"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9023/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9023/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/4f3b96372a97616fec2cd19223d8e83bc47a5f56"}}}}
{"actor":{"display_login":"shamser"}}