{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/comments/69397898","id":69397898,"diff_hunk":"@@ -121,9 +122,20 @@ private Cursor readCursor(JsonParser jsonParser) throws IOException {\n \n         final List<T> events = new ArrayList<>();\n \n-        while (jsonParser.nextToken() == JsonToken.START_OBJECT) {\n-            final T event = objectReader.readValue(jsonParser, eventClass);\n-            events.add(event);\n+        if (jsonParser.nextToken() == JsonToken.START_OBJECT) {\n+            final Iterator<T> eventIterator = objectReader.readValues(jsonParser, eventClass);\n+            while (eventIterator.hasNext()) {\n+                try {\n+                    events.add(eventIterator.next());\n+                } catch (final Exception e) {","path":"src/main/java/org/zalando/fahrschein/NakadiReader.java","position":20,"original_position":20,"commit_id":"199043b52c7f288c4600d2592fcc2f4f63d1e294","original_commit_id":"199043b52c7f288c4600d2592fcc2f4f63d1e294","user":{"login":"jhorstmann","id":689138,"avatar_url":"https://avatars.githubusercontent.com/u/689138?v=3","gravatar_id":"","url":"https://api.github.com/users/jhorstmann","html_url":"https://github.com/jhorstmann","followers_url":"https://api.github.com/users/jhorstmann/followers","following_url":"https://api.github.com/users/jhorstmann/following{/other_user}","gists_url":"https://api.github.com/users/jhorstmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorstmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorstmann/subscriptions","organizations_url":"https://api.github.com/users/jhorstmann/orgs","repos_url":"https://api.github.com/users/jhorstmann/repos","events_url":"https://api.github.com/users/jhorstmann/events{/privacy}","received_events_url":"https://api.github.com/users/jhorstmann/received_events","type":"User","site_admin":false},"body":"`JsonMappingException` even contains some additional information which might make it possible to handle the error in a sensible way or only ignore certain errors.\r\n\r\nOn the other hand, if you know where you expect errors, it might be better to just have a more lenient deserializer.","created_at":"2016-07-03T21:55:27Z","updated_at":"2016-07-03T21:55:27Z","html_url":"https://github.com/zalando-incubator/fahrschein/pull/20#discussion_r69397898","pull_request_url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/comments/69397898"},"html":{"href":"https://github.com/zalando-incubator/fahrschein/pull/20#discussion_r69397898"},"pull_request":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20","id":76090029,"html_url":"https://github.com/zalando-incubator/fahrschein/pull/20","diff_url":"https://github.com/zalando-incubator/fahrschein/pull/20.diff","patch_url":"https://github.com/zalando-incubator/fahrschein/pull/20.patch","issue_url":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/20","number":20,"state":"open","locked":false,"title":"Allow custom parse error handling","user":{"login":"lukasniemeier-zalando","id":10497901,"avatar_url":"https://avatars.githubusercontent.com/u/10497901?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasniemeier-zalando","html_url":"https://github.com/lukasniemeier-zalando","followers_url":"https://api.github.com/users/lukasniemeier-zalando/followers","following_url":"https://api.github.com/users/lukasniemeier-zalando/following{/other_user}","gists_url":"https://api.github.com/users/lukasniemeier-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasniemeier-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasniemeier-zalando/subscriptions","organizations_url":"https://api.github.com/users/lukasniemeier-zalando/orgs","repos_url":"https://api.github.com/users/lukasniemeier-zalando/repos","events_url":"https://api.github.com/users/lukasniemeier-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/lukasniemeier-zalando/received_events","type":"User","site_admin":false},"body":"Fixes #9.\r\n\r\n* allow for partial parsing of an event batch\r\n* user method decides whether to continue or abort connection on parse error\r\n* added crude test to show this off","created_at":"2016-07-03T14:17:17Z","updated_at":"2016-07-03T21:55:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/20/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/fahrschein/statuses/199043b52c7f288c4600d2592fcc2f4f63d1e294","head":{"label":"lukasniemeier-zalando:error-handling","ref":"error-handling","sha":"199043b52c7f288c4600d2592fcc2f4f63d1e294","user":{"login":"lukasniemeier-zalando","id":10497901,"avatar_url":"https://avatars.githubusercontent.com/u/10497901?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasniemeier-zalando","html_url":"https://github.com/lukasniemeier-zalando","followers_url":"https://api.github.com/users/lukasniemeier-zalando/followers","following_url":"https://api.github.com/users/lukasniemeier-zalando/following{/other_user}","gists_url":"https://api.github.com/users/lukasniemeier-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasniemeier-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasniemeier-zalando/subscriptions","organizations_url":"https://api.github.com/users/lukasniemeier-zalando/orgs","repos_url":"https://api.github.com/users/lukasniemeier-zalando/repos","events_url":"https://api.github.com/users/lukasniemeier-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/lukasniemeier-zalando/received_events","type":"User","site_admin":false},"repo":{"id":62376935,"name":"fahrschein","full_name":"lukasniemeier-zalando/fahrschein","owner":{"login":"lukasniemeier-zalando","id":10497901,"avatar_url":"https://avatars.githubusercontent.com/u/10497901?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasniemeier-zalando","html_url":"https://github.com/lukasniemeier-zalando","followers_url":"https://api.github.com/users/lukasniemeier-zalando/followers","following_url":"https://api.github.com/users/lukasniemeier-zalando/following{/other_user}","gists_url":"https://api.github.com/users/lukasniemeier-zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasniemeier-zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasniemeier-zalando/subscriptions","organizations_url":"https://api.github.com/users/lukasniemeier-zalando/orgs","repos_url":"https://api.github.com/users/lukasniemeier-zalando/repos","events_url":"https://api.github.com/users/lukasniemeier-zalando/events{/privacy}","received_events_url":"https://api.github.com/users/lukasniemeier-zalando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukasniemeier-zalando/fahrschein","description":"A java client for the nakadi event bus","fork":true,"url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein","forks_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/forks","keys_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/teams","hooks_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/hooks","issue_events_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/issues/events{/number}","events_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/events","assignees_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/assignees{/user}","branches_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/branches{/branch}","tags_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/tags","blobs_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/statuses/{sha}","languages_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/languages","stargazers_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/stargazers","contributors_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/contributors","subscribers_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/subscribers","subscription_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/subscription","commits_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/contents/{+path}","compare_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/merges","archive_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/downloads","issues_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/issues{/number}","pulls_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/pulls{/number}","milestones_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/milestones{/number}","notifications_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/labels{/name}","releases_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/releases{/id}","deployments_url":"https://api.github.com/repos/lukasniemeier-zalando/fahrschein/deployments","created_at":"2016-07-01T08:18:15Z","updated_at":"2016-07-01T08:18:16Z","pushed_at":"2016-07-03T14:21:09Z","git_url":"git://github.com/lukasniemeier-zalando/fahrschein.git","ssh_url":"git@github.com:lukasniemeier-zalando/fahrschein.git","clone_url":"https://github.com/lukasniemeier-zalando/fahrschein.git","svn_url":"https://github.com/lukasniemeier-zalando/fahrschein","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando-incubator:close-http-components","ref":"close-http-components","sha":"4516abbf7bdcbe6e2a8e51304aac1eccac27401a","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":60344998,"name":"fahrschein","full_name":"zalando-incubator/fahrschein","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/fahrschein","description":"A java client for the nakadi event bus","fork":false,"url":"https://api.github.com/repos/zalando-incubator/fahrschein","forks_url":"https://api.github.com/repos/zalando-incubator/fahrschein/forks","keys_url":"https://api.github.com/repos/zalando-incubator/fahrschein/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/fahrschein/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/fahrschein/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/fahrschein/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/fahrschein/events","assignees_url":"https://api.github.com/repos/zalando-incubator/fahrschein/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/fahrschein/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/fahrschein/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/fahrschein/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/fahrschein/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/fahrschein/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/fahrschein/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/fahrschein/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/fahrschein/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/fahrschein/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/fahrschein/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/fahrschein/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/fahrschein/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/fahrschein/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/fahrschein/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/fahrschein/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/fahrschein/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/fahrschein/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/fahrschein/merges","archive_url":"https://api.github.com/repos/zalando-incubator/fahrschein/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/fahrschein/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/fahrschein/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/fahrschein/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/fahrschein/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/fahrschein/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/fahrschein/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/fahrschein/deployments","created_at":"2016-06-03T12:10:14Z","updated_at":"2016-07-01T17:21:32Z","pushed_at":"2016-07-03T14:21:09Z","git_url":"git://github.com/zalando-incubator/fahrschein.git","ssh_url":"git@github.com:zalando-incubator/fahrschein.git","clone_url":"https://github.com/zalando-incubator/fahrschein.git","svn_url":"https://github.com/zalando-incubator/fahrschein","homepage":"","size":184,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20"},"html":{"href":"https://github.com/zalando-incubator/fahrschein/pull/20"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/20"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/fahrschein/statuses/199043b52c7f288c4600d2592fcc2f4f63d1e294"}}}}
{"actor":{"display_login":"jhorstmann"}}