{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/89065030","pull_request_review_id":9615354,"id":89065030,"diff_hunk":"@@ -0,0 +1,199 @@\n+/**\n+ * \\copyright\n+ * Copyright (c) 2012-2016, OpenGeoSys Community (http://www.opengeosys.org)\n+ *            Distributed under a Modified BSD License.\n+ *              See accompanying file LICENSE.txt or\n+ *              http://www.opengeosys.org/project/license\n+ *\n+ * \\file   TestRelativePermeabilityModel.cpp\n+ *\n+ * Created on November 2, 2016, 3:09 PM\n+ */\n+\n+#include <gtest/gtest.h>\n+\n+#include <memory>\n+#include <vector>\n+\n+#include \"BaseLib/ConfigTree.h\"\n+\n+#include \"TestTools.h\"\n+\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/RelativePermeability/RelativePermeability.h\"\n+#include \"MaterialLib/PorousMedium/UnsaturatedProperty/RelativePermeability/CreateRelativePermeabilityModel.h\"\n+\n+using namespace MaterialLib;\n+using namespace MaterialLib::PorousMedium;\n+\n+std::unique_ptr<RelativePermeability> createRelativePermeabilityModel(\n+    const char xml[])\n+{\n+    auto const ptree = readXml(xml);\n+    BaseLib::ConfigTree conf(ptree, \"\", BaseLib::ConfigTree::onerror,\n+                             BaseLib::ConfigTree::onwarning);\n+    auto const& sub_config = conf.getConfigSubtree(\"relative_permeability\");\n+    sub_config.ignoreConfigAttribute(\"id\");\n+    return createRelativePermeabilityModel(sub_config);\n+}\n+\n+TEST(MaterialPorousMedium, checkWettingPhaseVanGenuchten)\n+{\n+    const char xml[] =\n+        // Should be <relative_permeability id=\"0\">\n+        \"<relative_permeability id=\\\"0\\\">\"","path":"Tests/MaterialLib/TestRelativePermeabilityModel.cpp","position":null,"original_position":43,"commit_id":"1336632334555756040860a8cd6d32bcab0f870c","original_commit_id":"1272e53cbf65b276775d603b14b2c54c9a77405c","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"Removed.","created_at":"2016-11-22T08:44:04Z","updated_at":"2016-11-22T08:44:04Z","html_url":"https://github.com/ufz/ogs/pull/1531#discussion_r89065030","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1531","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/89065030"},"html":{"href":"https://github.com/ufz/ogs/pull/1531#discussion_r89065030"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1531"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1531","id":92972921,"html_url":"https://github.com/ufz/ogs/pull/1531","diff_url":"https://github.com/ufz/ogs/pull/1531.diff","patch_url":"https://github.com/ufz/ogs/pull/1531.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1531","number":1531,"state":"open","locked":false,"title":"Relative permeability model","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"This PR presents:\r\n- base class for relative permeability models\r\n- class for WettingPhaseVanGenuchten model\r\n- class for NonWettingPhaseVanGenuchten model\r\n- class for WettingPhaseBrookCoreyOilGas model\r\n- class for NonWettingPhaseBrookCoreyOilGas model\r\n- class for curve type model\r\n- unit tests for these classes.","created_at":"2016-11-09T14:30:42Z","updated_at":"2016-11-22T08:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c864a7c3e90a2fe4878bb3e264c198c8e79459d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1531/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1531/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1531/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/1336632334555756040860a8cd6d32bcab0f870c","head":{"label":"wenqing:krel","ref":"krel","sha":"1336632334555756040860a8cd6d32bcab0f870c","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"repo":{"id":12785911,"name":"ogs","full_name":"wenqing/ogs","owner":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wenqing/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/wenqing/ogs","forks_url":"https://api.github.com/repos/wenqing/ogs/forks","keys_url":"https://api.github.com/repos/wenqing/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wenqing/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wenqing/ogs/teams","hooks_url":"https://api.github.com/repos/wenqing/ogs/hooks","issue_events_url":"https://api.github.com/repos/wenqing/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/wenqing/ogs/events","assignees_url":"https://api.github.com/repos/wenqing/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/wenqing/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/wenqing/ogs/tags","blobs_url":"https://api.github.com/repos/wenqing/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wenqing/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wenqing/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wenqing/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wenqing/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/wenqing/ogs/languages","stargazers_url":"https://api.github.com/repos/wenqing/ogs/stargazers","contributors_url":"https://api.github.com/repos/wenqing/ogs/contributors","subscribers_url":"https://api.github.com/repos/wenqing/ogs/subscribers","subscription_url":"https://api.github.com/repos/wenqing/ogs/subscription","commits_url":"https://api.github.com/repos/wenqing/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wenqing/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wenqing/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wenqing/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wenqing/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/wenqing/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wenqing/ogs/merges","archive_url":"https://api.github.com/repos/wenqing/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wenqing/ogs/downloads","issues_url":"https://api.github.com/repos/wenqing/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/wenqing/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/wenqing/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/wenqing/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wenqing/ogs/labels{/name}","releases_url":"https://api.github.com/repos/wenqing/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/wenqing/ogs/deployments","created_at":"2013-09-12T14:33:21Z","updated_at":"2015-02-25T13:44:13Z","pushed_at":"2016-11-22T08:38:14Z","git_url":"git://github.com/wenqing/ogs.git","ssh_url":"git@github.com:wenqing/ogs.git","clone_url":"https://github.com/wenqing/ogs.git","svn_url":"https://github.com/wenqing/ogs","homepage":"www.opengeosys.org","size":16456,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"dff98b29343b5b11f2f41e5ff2d3b12664e9f8ef","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-10-24T08:18:46Z","pushed_at":"2016-11-22T08:39:11Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":27088,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":96,"forks":55,"open_issues":96,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1531"},"html":{"href":"https://github.com/ufz/ogs/pull/1531"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1531"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1531/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1531/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1531/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/1336632334555756040860a8cd6d32bcab0f870c"}}}}
{"actor":{"display_login":"wenqing"}}