{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15018","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15018/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15018/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15018/events","html_url":"https://github.com/NixOS/nixpkgs/pull/15018","id":151308037,"number":15018,"title":"php: add default php.ini","user":{"login":"ericsagnes","id":367880,"avatar_url":"https://avatars.githubusercontent.com/u/367880?v=3","gravatar_id":"","url":"https://api.github.com/users/ericsagnes","html_url":"https://github.com/ericsagnes","followers_url":"https://api.github.com/users/ericsagnes/followers","following_url":"https://api.github.com/users/ericsagnes/following{/other_user}","gists_url":"https://api.github.com/users/ericsagnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsagnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsagnes/subscriptions","organizations_url":"https://api.github.com/users/ericsagnes/orgs","repos_url":"https://api.github.com/users/ericsagnes/repos","events_url":"https://api.github.com/users/ericsagnes/events{/privacy}","received_events_url":"https://api.github.com/users/ericsagnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-27T06:22:12Z","updated_at":"2016-04-27T06:22:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/15018","html_url":"https://github.com/NixOS/nixpkgs/pull/15018","diff_url":"https://github.com/NixOS/nixpkgs/pull/15018.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/15018.patch"},"body":"###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nPHP had no `php.ini` file set by default.\r\nIt is useful to have one so cli mode php can run with sane settings. (see #9625)\r\n\r\nThe following PR does:\r\n- set the `php.ini` in the php package to the provided `php.ini-production` (for reference Archlinux does the [same](https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/php#n183))\r\n- remove the `php-recommended.ini` as it become meaningless\r\n- update the services that were using `php-recommended.ini` (namely httpd and phpfpm)\r\n- remove the `services.phpfpm.phpIni` option as it redundant and there is no need for another way to override `php.ini`\r\n\r\nOne could consider to have the default `php.ini` immutable in the store could be an issue, but php provides many (too much?) ways to change this functionality so this shouldn't be a problem.\r\nThe normal way would be to use `/etc/php.ini` to add or change settings, else it is possible to use no setting file with the `-n` flag, use a different file with the `-c` flag or override it with the `PHPRC` environment variable.\r\n\r\ncc \r\n- php maintainer @globin \r\n- phpfpm module creator @rickynils \r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/214982054","html_url":"https://github.com/NixOS/nixpkgs/pull/15018#issuecomment-214982054","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15018","id":214982054,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T06:22:14Z","updated_at":"2016-04-27T06:22:14Z","body":"By analyzing the blame information on this pull request, we identified @bluescreen303, @edolstra and @vcunat to be potential reviewers"}}