{"action":"created","issue":{"url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/9","repository_url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib","labels_url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/9/comments","events_url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/9/events","html_url":"https://github.com/netsec-ethz/scion-lwip-contrib/pull/9","id":195198535,"number":9,"title":"TCP settings","user":{"login":"pszalach","id":8159928,"avatar_url":"https://avatars.githubusercontent.com/u/8159928?v=3","gravatar_id":"","url":"https://api.github.com/users/pszalach","html_url":"https://github.com/pszalach","followers_url":"https://api.github.com/users/pszalach/followers","following_url":"https://api.github.com/users/pszalach/following{/other_user}","gists_url":"https://api.github.com/users/pszalach/gists{/gist_id}","starred_url":"https://api.github.com/users/pszalach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pszalach/subscriptions","organizations_url":"https://api.github.com/users/pszalach/orgs","repos_url":"https://api.github.com/users/pszalach/repos","events_url":"https://api.github.com/users/pszalach/events{/privacy}","received_events_url":"https://api.github.com/users/pszalach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-13T09:13:45Z","updated_at":"2016-12-14T11:55:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/pulls/9","html_url":"https://github.com/netsec-ethz/scion-lwip-contrib/pull/9","diff_url":"https://github.com/netsec-ethz/scion-lwip-contrib/pull/9.diff","patch_url":"https://github.com/netsec-ethz/scion-lwip-contrib/pull/9.patch"},"body":"TCP setting that give ~3 times better performance than the default one.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/netsec-ethz/scion-lwip-contrib/9)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/comments/267015935","html_url":"https://github.com/netsec-ethz/scion-lwip-contrib/pull/9#issuecomment-267015935","issue_url":"https://api.github.com/repos/netsec-ethz/scion-lwip-contrib/issues/9","id":267015935,"user":{"login":"pszalach","id":8159928,"avatar_url":"https://avatars.githubusercontent.com/u/8159928?v=3","gravatar_id":"","url":"https://api.github.com/users/pszalach","html_url":"https://github.com/pszalach","followers_url":"https://api.github.com/users/pszalach/followers","following_url":"https://api.github.com/users/pszalach/following{/other_user}","gists_url":"https://api.github.com/users/pszalach/gists{/gist_id}","starred_url":"https://api.github.com/users/pszalach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pszalach/subscriptions","organizations_url":"https://api.github.com/users/pszalach/orgs","repos_url":"https://api.github.com/users/pszalach/repos","events_url":"https://api.github.com/users/pszalach/events{/privacy}","received_events_url":"https://api.github.com/users/pszalach/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T11:55:07Z","updated_at":"2016-12-14T11:55:07Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[ports/unix/proj/scion/lwipopts.h, line 256 at r1](https://reviewable.io:443/reviews/netsec-ethz/scion-lwip-contrib/9#-KYwVm9auuZqPR0iQEbn:-KYx9e3R6P2B31ja2Vce:bsj78nn) ([raw file](https://github.com/netsec-ethz/scion-lwip-contrib/blob/9770a3e2fdede619c205aebc7afb524878e7848c/ports/unix/proj/scion/lwipopts.h#L256)):*\n<details><summary><i>Previously, klausman (Tobias Klausmann) wrote…</i></summary><blockquote>\n\nIt would be nice to have a comment regarding the origin of these constants or the rationale for choosing them.\n</blockquote></details>\n\nAll these parameter values are chosen empirically, but I put comments with default values.\nAfter some more testing seems that `TCP_MSS` and `TCP_SND_BUF` are dominant for the perfomance in our scenario, thus I left other options with default values.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/netsec-ethz/scion-lwip-contrib/9)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pszalach"}}