{"action":"opened","number":3467,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/3467","id":61447799,"html_url":"https://github.com/dotnet/coreclr/pull/3467","diff_url":"https://github.com/dotnet/coreclr/pull/3467.diff","patch_url":"https://github.com/dotnet/coreclr/pull/3467.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/3467","number":3467,"state":"open","locked":false,"title":"Fix to intermittent failure of jit test 200w1d-09_cpp_r.exe","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"body":"This is a long standing bug in xarch emitter that repros when a static field\r\naccess results in the following IR\r\n\r\nlclvar =  GT_IND(GT_LEA(GT_CLS_VAR_ADDR, offset=200))\r\n\r\nGT_CLAS_VAR_ADDR represents address of the static class object and\r\noffset is used to access a field of the static class.\r\n\r\nIn this case codegen of GT_IND would call emitInsMov(treeNode= GT_IND)\r\nemiInsMov() is checking whether 'base' of addr is GT_CLS_VAR_ADDR and if\r\nso is disregarding offset/indiex/scale fields within addr mode.  As a\r\nresult code generated is\r\n\r\nlea      rdx, [reloc classVar[0xddc44ce8]]\r\nmovsd    xmm10, qword ptr [reloc classVar[0xddc44ce8]]\r\n\r\nThe bug is that emitInsMov() should be checking that oper of addr of GT_IND\r\nis GT_CLS_VAR_ADDR. Same issue exists in GT_STOREIND case.  After the\r\nfix the following code is generated\r\n\r\nlea      rdx, [reloc classVar[0xdc5a4ce8]]\r\nmovsd    xmm10, qword ptr [rdx+200]\r\n\r\nWhy this bug repros intermittently?  fgMorphField() when morphing a static\r\nfield access obtains static's addr and checks to see whether its addr\r\ncan be encoded as pc-relative 32-bit offset.  If so then fgMorphField() will create\r\nGT_CLS_VAR_ADDR to represent static's addr.  If static's addr cannot be\r\nencoded pc-relative 32-bit offset then it will create long type icon to represent the\r\naddress.  Later long icon + offset is folded into a single long constant\r\nand the test passes in this case.  The test fails whenver GT_CLS_VAR_ADDR +\r\noffset materializes in IR which in turn depends on the distance between\r\njitted code address and the static's address. In most cases statics\r\nwere at a distance that cannot be encoded as pc-relative and hence works\r\ncorrectly.  Hence the intermittent failure of this test.","created_at":"2016-03-02T18:50:56Z","updated_at":"2016-03-02T18:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/coreclr/milestones/4","html_url":"https://github.com/dotnet/coreclr/milestones/1.0.0-rtm","labels_url":"https://api.github.com/repos/dotnet/coreclr/milestones/4/labels","id":1321405,"number":4,"title":"1.0.0-rtm","description":"Q1 2016 (https://github.com/dotnet/corefx/milestones)","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":129,"closed_issues":53,"state":"open","created_at":"2015-09-24T02:23:52Z","updated_at":"2016-03-02T18:50:56Z","due_on":"2016-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3467/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3467/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/3467/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/3eb08188497063e8251144ba1f78d23e1b9306f8","head":{"label":"sivarv:emitInsMovFix","ref":"emitInsMovFix","sha":"3eb08188497063e8251144ba1f78d23e1b9306f8","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"repo":{"id":47229875,"name":"coreclr","full_name":"sivarv/coreclr","owner":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sivarv/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/sivarv/coreclr","forks_url":"https://api.github.com/repos/sivarv/coreclr/forks","keys_url":"https://api.github.com/repos/sivarv/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sivarv/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sivarv/coreclr/teams","hooks_url":"https://api.github.com/repos/sivarv/coreclr/hooks","issue_events_url":"https://api.github.com/repos/sivarv/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/sivarv/coreclr/events","assignees_url":"https://api.github.com/repos/sivarv/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/sivarv/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/sivarv/coreclr/tags","blobs_url":"https://api.github.com/repos/sivarv/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sivarv/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sivarv/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sivarv/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sivarv/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/sivarv/coreclr/languages","stargazers_url":"https://api.github.com/repos/sivarv/coreclr/stargazers","contributors_url":"https://api.github.com/repos/sivarv/coreclr/contributors","subscribers_url":"https://api.github.com/repos/sivarv/coreclr/subscribers","subscription_url":"https://api.github.com/repos/sivarv/coreclr/subscription","commits_url":"https://api.github.com/repos/sivarv/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sivarv/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sivarv/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sivarv/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sivarv/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/sivarv/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sivarv/coreclr/merges","archive_url":"https://api.github.com/repos/sivarv/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sivarv/coreclr/downloads","issues_url":"https://api.github.com/repos/sivarv/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/sivarv/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/sivarv/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/sivarv/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sivarv/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/sivarv/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/sivarv/coreclr/deployments","created_at":"2015-12-02T01:53:26Z","updated_at":"2016-01-14T18:21:57Z","pushed_at":"2016-03-02T18:49:06Z","git_url":"git://github.com/sivarv/coreclr.git","ssh_url":"git@github.com:sivarv/coreclr.git","clone_url":"https://github.com/sivarv/coreclr.git","svn_url":"https://github.com/sivarv/coreclr","homepage":"http://dotnet.github.io/","size":62970,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5c2de44cbb2eb39105904bfe603a5ea45a2a13c2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-03-02T16:46:35Z","pushed_at":"2016-03-02T18:49:56Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":69339,"stargazers_count":5962,"watchers_count":5962,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1318,"mirror_url":null,"open_issues_count":578,"forks":1318,"open_issues":578,"watchers":5962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3467"},"html":{"href":"https://github.com/dotnet/coreclr/pull/3467"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3467"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3467/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3467/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3467/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/3eb08188497063e8251144ba1f78d23e1b9306f8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":6,"changed_files":1}}