{"action":"created","comment":{"url":"https://api.github.com/repos/eggjs/egg-core/pulls/comments/84007647","pull_request_review_id":4812363,"id":84007647,"diff_hunk":"@@ -25,7 +25,7 @@ describe('test/loader/get_server_env.test.js', function() {\n   it('should use default when NODE_ENV = production', function() {","path":"test/loader/get_server_env.test.js","position":1,"original_position":1,"commit_id":"5bf21af99915b9f1aa6b276c7451da7d1d56b543","original_commit_id":"5bf21af99915b9f1aa6b276c7451da7d1d56b543","user":{"login":"popomore","id":360661,"avatar_url":"https://avatars.githubusercontent.com/u/360661?v=3","gravatar_id":"","url":"https://api.github.com/users/popomore","html_url":"https://github.com/popomore","followers_url":"https://api.github.com/users/popomore/followers","following_url":"https://api.github.com/users/popomore/following{/other_user}","gists_url":"https://api.github.com/users/popomore/gists{/gist_id}","starred_url":"https://api.github.com/users/popomore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popomore/subscriptions","organizations_url":"https://api.github.com/users/popomore/orgs","repos_url":"https://api.github.com/users/popomore/repos","events_url":"https://api.github.com/users/popomore/events{/privacy}","received_events_url":"https://api.github.com/users/popomore/received_events","type":"User","site_admin":false},"body":"should use prod","created_at":"2016-10-19T07:04:35Z","updated_at":"2016-10-19T07:04:39Z","html_url":"https://github.com/eggjs/egg-core/pull/24#discussion_r84007647","pull_request_url":"https://api.github.com/repos/eggjs/egg-core/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/comments/84007647"},"html":{"href":"https://github.com/eggjs/egg-core/pull/24#discussion_r84007647"},"pull_request":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/eggjs/egg-core/pulls/24","id":89947993,"html_url":"https://github.com/eggjs/egg-core/pull/24","diff_url":"https://github.com/eggjs/egg-core/pull/24.diff","patch_url":"https://github.com/eggjs/egg-core/pull/24.patch","issue_url":"https://api.github.com/repos/eggjs/egg-core/issues/24","number":24,"state":"open","locked":false,"title":"feat: [BREAKING_CHANGE] env as prod when EGG_SERVER_ENV undefined & NODE_ENV prod","user":{"login":"atian25","id":227713,"avatar_url":"https://avatars.githubusercontent.com/u/227713?v=3","gravatar_id":"","url":"https://api.github.com/users/atian25","html_url":"https://github.com/atian25","followers_url":"https://api.github.com/users/atian25/followers","following_url":"https://api.github.com/users/atian25/following{/other_user}","gists_url":"https://api.github.com/users/atian25/gists{/gist_id}","starred_url":"https://api.github.com/users/atian25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atian25/subscriptions","organizations_url":"https://api.github.com/users/atian25/orgs","repos_url":"https://api.github.com/users/atian25/repos","events_url":"https://api.github.com/users/atian25/events{/privacy}","received_events_url":"https://api.github.com/users/atian25/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\nBug fixes and new features should include tests and possibly benchmarks.\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n\r\n感谢您贡献代码。请确认下列 checklist 的完成情况。\r\nBug 修复和新功能必须包含测试，必要时请附上性能测试。\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `npm test` passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nhttps://github.com/eggjs/egg-core/pull/23#issuecomment-254717826","created_at":"2016-10-19T06:19:20Z","updated_at":"2016-10-19T07:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c81a589eb406eea76cf063535feaff974ab91f0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eggjs/egg-core/pulls/24/commits","review_comments_url":"https://api.github.com/repos/eggjs/egg-core/pulls/24/comments","review_comment_url":"https://api.github.com/repos/eggjs/egg-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggjs/egg-core/issues/24/comments","statuses_url":"https://api.github.com/repos/eggjs/egg-core/statuses/5bf21af99915b9f1aa6b276c7451da7d1d56b543","head":{"label":"eggjs:env","ref":"env","sha":"5bf21af99915b9f1aa6b276c7451da7d1d56b543","user":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"repo":{"id":61421577,"name":"egg-core","full_name":"eggjs/egg-core","owner":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggjs/egg-core","description":"A core Pluggable framework based on koa.","fork":false,"url":"https://api.github.com/repos/eggjs/egg-core","forks_url":"https://api.github.com/repos/eggjs/egg-core/forks","keys_url":"https://api.github.com/repos/eggjs/egg-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggjs/egg-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggjs/egg-core/teams","hooks_url":"https://api.github.com/repos/eggjs/egg-core/hooks","issue_events_url":"https://api.github.com/repos/eggjs/egg-core/issues/events{/number}","events_url":"https://api.github.com/repos/eggjs/egg-core/events","assignees_url":"https://api.github.com/repos/eggjs/egg-core/assignees{/user}","branches_url":"https://api.github.com/repos/eggjs/egg-core/branches{/branch}","tags_url":"https://api.github.com/repos/eggjs/egg-core/tags","blobs_url":"https://api.github.com/repos/eggjs/egg-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggjs/egg-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggjs/egg-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggjs/egg-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggjs/egg-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eggjs/egg-core/languages","stargazers_url":"https://api.github.com/repos/eggjs/egg-core/stargazers","contributors_url":"https://api.github.com/repos/eggjs/egg-core/contributors","subscribers_url":"https://api.github.com/repos/eggjs/egg-core/subscribers","subscription_url":"https://api.github.com/repos/eggjs/egg-core/subscription","commits_url":"https://api.github.com/repos/eggjs/egg-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggjs/egg-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggjs/egg-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggjs/egg-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggjs/egg-core/contents/{+path}","compare_url":"https://api.github.com/repos/eggjs/egg-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggjs/egg-core/merges","archive_url":"https://api.github.com/repos/eggjs/egg-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggjs/egg-core/downloads","issues_url":"https://api.github.com/repos/eggjs/egg-core/issues{/number}","pulls_url":"https://api.github.com/repos/eggjs/egg-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eggjs/egg-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eggjs/egg-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggjs/egg-core/labels{/name}","releases_url":"https://api.github.com/repos/eggjs/egg-core/releases{/id}","deployments_url":"https://api.github.com/repos/eggjs/egg-core/deployments","created_at":"2016-06-18T07:02:57Z","updated_at":"2016-09-27T09:20:20Z","pushed_at":"2016-10-19T06:59:09Z","git_url":"git://github.com/eggjs/egg-core.git","ssh_url":"git@github.com:eggjs/egg-core.git","clone_url":"https://github.com/eggjs/egg-core.git","svn_url":"https://github.com/eggjs/egg-core","homepage":"http://eggjs.org","size":199,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":34,"default_branch":"master"}},"base":{"label":"eggjs:master","ref":"master","sha":"9ecf888e6e1b7efa1dadbdf5fdc15a57e2019df3","user":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"repo":{"id":61421577,"name":"egg-core","full_name":"eggjs/egg-core","owner":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggjs/egg-core","description":"A core Pluggable framework based on koa.","fork":false,"url":"https://api.github.com/repos/eggjs/egg-core","forks_url":"https://api.github.com/repos/eggjs/egg-core/forks","keys_url":"https://api.github.com/repos/eggjs/egg-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggjs/egg-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggjs/egg-core/teams","hooks_url":"https://api.github.com/repos/eggjs/egg-core/hooks","issue_events_url":"https://api.github.com/repos/eggjs/egg-core/issues/events{/number}","events_url":"https://api.github.com/repos/eggjs/egg-core/events","assignees_url":"https://api.github.com/repos/eggjs/egg-core/assignees{/user}","branches_url":"https://api.github.com/repos/eggjs/egg-core/branches{/branch}","tags_url":"https://api.github.com/repos/eggjs/egg-core/tags","blobs_url":"https://api.github.com/repos/eggjs/egg-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggjs/egg-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggjs/egg-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggjs/egg-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggjs/egg-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eggjs/egg-core/languages","stargazers_url":"https://api.github.com/repos/eggjs/egg-core/stargazers","contributors_url":"https://api.github.com/repos/eggjs/egg-core/contributors","subscribers_url":"https://api.github.com/repos/eggjs/egg-core/subscribers","subscription_url":"https://api.github.com/repos/eggjs/egg-core/subscription","commits_url":"https://api.github.com/repos/eggjs/egg-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggjs/egg-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggjs/egg-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggjs/egg-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggjs/egg-core/contents/{+path}","compare_url":"https://api.github.com/repos/eggjs/egg-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggjs/egg-core/merges","archive_url":"https://api.github.com/repos/eggjs/egg-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggjs/egg-core/downloads","issues_url":"https://api.github.com/repos/eggjs/egg-core/issues{/number}","pulls_url":"https://api.github.com/repos/eggjs/egg-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eggjs/egg-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eggjs/egg-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggjs/egg-core/labels{/name}","releases_url":"https://api.github.com/repos/eggjs/egg-core/releases{/id}","deployments_url":"https://api.github.com/repos/eggjs/egg-core/deployments","created_at":"2016-06-18T07:02:57Z","updated_at":"2016-09-27T09:20:20Z","pushed_at":"2016-10-19T06:59:09Z","git_url":"git://github.com/eggjs/egg-core.git","ssh_url":"git@github.com:eggjs/egg-core.git","clone_url":"https://github.com/eggjs/egg-core.git","svn_url":"https://github.com/eggjs/egg-core","homepage":"http://eggjs.org","size":199,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/24"},"html":{"href":"https://github.com/eggjs/egg-core/pull/24"},"issue":{"href":"https://api.github.com/repos/eggjs/egg-core/issues/24"},"comments":{"href":"https://api.github.com/repos/eggjs/egg-core/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggjs/egg-core/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/eggjs/egg-core/statuses/5bf21af99915b9f1aa6b276c7451da7d1d56b543"}}}}
{"actor":{"display_login":"popomore"}}