{"action":"created","issue":{"url":"https://api.github.com/repos/Auklets/LoadEffect/issues/146","repository_url":"https://api.github.com/repos/Auklets/LoadEffect","labels_url":"https://api.github.com/repos/Auklets/LoadEffect/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/Auklets/LoadEffect/issues/146/comments","events_url":"https://api.github.com/repos/Auklets/LoadEffect/issues/146/events","html_url":"https://github.com/Auklets/LoadEffect/pull/146","id":163596656,"number":146,"title":"Testing","user":{"login":"anhtaiH","id":15970451,"avatar_url":"https://avatars.githubusercontent.com/u/15970451?v=3","gravatar_id":"","url":"https://api.github.com/users/anhtaiH","html_url":"https://github.com/anhtaiH","followers_url":"https://api.github.com/users/anhtaiH/followers","following_url":"https://api.github.com/users/anhtaiH/following{/other_user}","gists_url":"https://api.github.com/users/anhtaiH/gists{/gist_id}","starred_url":"https://api.github.com/users/anhtaiH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhtaiH/subscriptions","organizations_url":"https://api.github.com/users/anhtaiH/orgs","repos_url":"https://api.github.com/users/anhtaiH/repos","events_url":"https://api.github.com/users/anhtaiH/events{/privacy}","received_events_url":"https://api.github.com/users/anhtaiH/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Auklets/LoadEffect/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T03:19:36Z","updated_at":"2016-07-04T03:21:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Auklets/LoadEffect/pulls/146","html_url":"https://github.com/Auklets/LoadEffect/pull/146","diff_url":"https://github.com/Auklets/LoadEffect/pull/146.diff","patch_url":"https://github.com/Auklets/LoadEffect/pull/146.patch"},"body":"### Summary\r\n<!--- Provide a general summary of your changes in the Title above -->\r\nThe bulk of this PR is adding new tests for redux reducers, and also add tests for user model with addition of site tokens. The other bulk is abstracting fetch api to single function inside of the redux action creators to avoid code duplication. \r\n##### Description\r\n<!--- Describe your changes in detail -->\r\n~ Actions - create a sendHttpRequest helper function to be reused across actions that are making restful requests.\r\n~ Tests - add testing for reducers\r\n~ Fix async issue in test for user models, which was running test before the user was actually saved to the database. \r\n~ Add test to check for site token on the user model\r\n##### Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\n##### Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nAdds testing to increase code coverage and refactor to make the code base more readable and maintainable\r\n##### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] Automated Testing\r\n- [ ] Documentation\r\n\r\n##### Testing Details\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n<!--- If there are none to be shared, report 'Travis CI - Build Passing'  -->\r\n\r\n##### Screenshots (if appropriate)\r\n<!--- Report 'N/A' if none --->\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/Auklets/LoadEffect/issues/comments/230197542","html_url":"https://github.com/Auklets/LoadEffect/pull/146#issuecomment-230197542","issue_url":"https://api.github.com/repos/Auklets/LoadEffect/issues/146","id":230197542,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T03:21:54Z","updated_at":"2016-07-04T03:21:54Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6854140/badge)](https://coveralls.io/builds/6854140)\n\nCoverage increased (+4.5%) to 61.964% when pulling **2c12c1c9b6e318b481aea42bcb4c85eeab1900e6 on anhtaiH:testing** into **5920b5780e027166244f2b67867e6c12b476697a on Auklets:master**.\n"}}
{"actor":{"display_login":"coveralls"}}