{"action":"created","issue":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/700","repository_url":"https://api.github.com/repos/jackhumbert/qmk_firmware","labels_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/700/labels{/name}","comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/700/comments","events_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/700/events","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/700","id":173734399,"number":700,"title":"build_keyboard.mk: Restore UCIS_ENABLE support","user":{"login":"algernon","id":17243,"avatar_url":"https://avatars.githubusercontent.com/u/17243?v=3","gravatar_id":"","url":"https://api.github.com/users/algernon","html_url":"https://github.com/algernon","followers_url":"https://api.github.com/users/algernon/followers","following_url":"https://api.github.com/users/algernon/following{/other_user}","gists_url":"https://api.github.com/users/algernon/gists{/gist_id}","starred_url":"https://api.github.com/users/algernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algernon/subscriptions","organizations_url":"https://api.github.com/users/algernon/orgs","repos_url":"https://api.github.com/users/algernon/repos","events_url":"https://api.github.com/users/algernon/events{/privacy}","received_events_url":"https://api.github.com/users/algernon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T09:32:31Z","updated_at":"2016-08-29T10:11:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/700","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/700","diff_url":"https://github.com/jackhumbert/qmk_firmware/pull/700.diff","patch_url":"https://github.com/jackhumbert/qmk_firmware/pull/700.patch"},"body":"During the build system refactor, support for enabling UCIS seems to have been lost. This little patch adds that back, so that keymaps using UCIS can be compiled again."},"comment":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/comments/243086107","html_url":"https://github.com/jackhumbert/qmk_firmware/pull/700#issuecomment-243086107","issue_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/700","id":243086107,"user":{"login":"fredizzimo","id":9946255,"avatar_url":"https://avatars.githubusercontent.com/u/9946255?v=3","gravatar_id":"","url":"https://api.github.com/users/fredizzimo","html_url":"https://github.com/fredizzimo","followers_url":"https://api.github.com/users/fredizzimo/followers","following_url":"https://api.github.com/users/fredizzimo/following{/other_user}","gists_url":"https://api.github.com/users/fredizzimo/gists{/gist_id}","starred_url":"https://api.github.com/users/fredizzimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredizzimo/subscriptions","organizations_url":"https://api.github.com/users/fredizzimo/orgs","repos_url":"https://api.github.com/users/fredizzimo/repos","events_url":"https://api.github.com/users/fredizzimo/events{/privacy}","received_events_url":"https://api.github.com/users/fredizzimo/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T10:11:32Z","updated_at":"2016-08-29T10:11:32Z","body":"Ah yes, sorry about that. \r\n\r\nIt wasn't easy to keep up with the merging. It worked OK in the beginning when I used rebasing. But then I ran into some issues with line endings, that caused the rebasing to fail So I switched over to merging. But unfortunately that didn't know that build_keyboard.mk was copied from the Makefile. So I had to do manually try to see what was changed, and I must have missed that one.\r\n\r\nAs as side-note, at some point I would like to get these all moved to common.mk, like the serial link stuff. This would allow unit tests for example to selectively add features."}}
{"actor":{"display_login":"fredizzimo"}}