{"action":"created","issue":{"url":"https://api.github.com/repos/delph-in/pydmrs/issues/16","repository_url":"https://api.github.com/repos/delph-in/pydmrs","labels_url":"https://api.github.com/repos/delph-in/pydmrs/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/delph-in/pydmrs/issues/16/comments","events_url":"https://api.github.com/repos/delph-in/pydmrs/issues/16/events","html_url":"https://github.com/delph-in/pydmrs/pull/16","id":137544601,"number":16,"title":"Sortinfo classes and smaller changes (for mapping)","user":{"login":"AlexKuhnle","id":14937649,"avatar_url":"https://avatars.githubusercontent.com/u/14937649?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKuhnle","html_url":"https://github.com/AlexKuhnle","followers_url":"https://api.github.com/users/AlexKuhnle/followers","following_url":"https://api.github.com/users/AlexKuhnle/following{/other_user}","gists_url":"https://api.github.com/users/AlexKuhnle/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKuhnle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKuhnle/subscriptions","organizations_url":"https://api.github.com/users/AlexKuhnle/orgs","repos_url":"https://api.github.com/users/AlexKuhnle/repos","events_url":"https://api.github.com/users/AlexKuhnle/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKuhnle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-01T11:16:46Z","updated_at":"2016-03-02T12:31:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/delph-in/pydmrs/pulls/16","html_url":"https://github.com/delph-in/pydmrs/pull/16","diff_url":"https://github.com/delph-in/pydmrs/pull/16.diff","patch_url":"https://github.com/delph-in/pydmrs/pull/16.patch"},"body":"Changes:\r\n- Sortinfo classes added (should be backward compatible, but let me know if not and why).\r\n- Pred instantiation supported\r\n- free_nodeid and visualise method added to Dmrs (and in serial)\r\n- A few small improvements (hopefully)"},"comment":{"url":"https://api.github.com/repos/delph-in/pydmrs/issues/comments/191222247","html_url":"https://github.com/delph-in/pydmrs/pull/16#issuecomment-191222247","issue_url":"https://api.github.com/repos/delph-in/pydmrs/issues/16","id":191222247,"user":{"login":"guyemerson","id":5824426,"avatar_url":"https://avatars.githubusercontent.com/u/5824426?v=3","gravatar_id":"","url":"https://api.github.com/users/guyemerson","html_url":"https://github.com/guyemerson","followers_url":"https://api.github.com/users/guyemerson/followers","following_url":"https://api.github.com/users/guyemerson/following{/other_user}","gists_url":"https://api.github.com/users/guyemerson/gists{/gist_id}","starred_url":"https://api.github.com/users/guyemerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyemerson/subscriptions","organizations_url":"https://api.github.com/users/guyemerson/orgs","repos_url":"https://api.github.com/users/guyemerson/repos","events_url":"https://api.github.com/users/guyemerson/events{/privacy}","received_events_url":"https://api.github.com/users/guyemerson/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T12:31:48Z","updated_at":"2016-03-02T12:31:48Z","body":"I was actually considering throwing an error if you try to instantiate a Pred directly.  I hadn't done this yet because it would mean either changing Pred to be an abstract base class (which RealPred and GPred are registered as subclasses of, rather than actually subclassing), or being more careful with how super is called (if Pred.__new__ throws an error, then RealPred.__new__ must avoid it).\r\n\r\nPerhaps in the mean time, you should commit the uncontroversial changes (e.g. visualisation) and pend the rest until we can have a group discussion about these things."}}