{"action":"created","issue":{"url":"https://api.github.com/repos/dropbox/json11/issues/71","repository_url":"https://api.github.com/repos/dropbox/json11","labels_url":"https://api.github.com/repos/dropbox/json11/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/dropbox/json11/issues/71/comments","events_url":"https://api.github.com/repos/dropbox/json11/issues/71/events","html_url":"https://github.com/dropbox/json11/pull/71","id":170553889,"number":71,"title":"Use CXX_STANDARD to specify c++11 compile flags","user":{"login":"admsyn","id":609318,"avatar_url":"https://avatars.githubusercontent.com/u/609318?v=3","gravatar_id":"","url":"https://api.github.com/users/admsyn","html_url":"https://github.com/admsyn","followers_url":"https://api.github.com/users/admsyn/followers","following_url":"https://api.github.com/users/admsyn/following{/other_user}","gists_url":"https://api.github.com/users/admsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/admsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admsyn/subscriptions","organizations_url":"https://api.github.com/users/admsyn/orgs","repos_url":"https://api.github.com/users/admsyn/repos","events_url":"https://api.github.com/users/admsyn/events{/privacy}","received_events_url":"https://api.github.com/users/admsyn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-11T01:22:09Z","updated_at":"2016-08-11T17:35:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dropbox/json11/pulls/71","html_url":"https://github.com/dropbox/json11/pull/71","diff_url":"https://github.com/dropbox/json11/pull/71.diff","patch_url":"https://github.com/dropbox/json11/pull/71.patch"},"body":"Uses [CXX_STANDARD](https://cmake.org/cmake/help/v3.1/prop_tgt/CXX_STANDARD.html#prop_tgt:CXX_STANDARD) to specify a C++11 build, which avoids issues when a build contains C files.\r\n\r\nFixes #70 \r\n\r\nThe tests seem to fail on my laptop, with or without this change (same output)\r\n\r\n```\r\nbuild ▹ ./json11_test\r\nk1: v1\r\nk3: [\"a\", 123, true, false, null]\r\n    - \"a\"\r\n    - 123\r\n    - true\r\n    - false\r\n    - null\r\nResult: {\"a\": 1, \"b\": \"text\", \"c\": [1, 2, 3]}\r\nResult: {}\r\nFailed: malformed comment\r\nFailed: unexpected end of input inside inline comment\r\nFailed: unexpected end of input inside comment\r\nFailed: unexpected end of input inside multi-line comment\r\nobj: {\"k1\": \"v1\", \"k2\": 42, \"k3\": [\"a\", 123, true, false, null]}\r\nAssertion failed: (nested_array.array_items().size() == 1), function json11_test, file /Users/adam/workspace/json11/test.cpp, line 198.\r\nAbort trap: 6\r\n```"},"comment":{"url":"https://api.github.com/repos/dropbox/json11/issues/comments/239233253","html_url":"https://github.com/dropbox/json11/pull/71#issuecomment-239233253","issue_url":"https://api.github.com/repos/dropbox/json11/issues/71","id":239233253,"user":{"login":"admsyn","id":609318,"avatar_url":"https://avatars.githubusercontent.com/u/609318?v=3","gravatar_id":"","url":"https://api.github.com/users/admsyn","html_url":"https://github.com/admsyn","followers_url":"https://api.github.com/users/admsyn/followers","following_url":"https://api.github.com/users/admsyn/following{/other_user}","gists_url":"https://api.github.com/users/admsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/admsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/admsyn/subscriptions","organizations_url":"https://api.github.com/users/admsyn/orgs","repos_url":"https://api.github.com/users/admsyn/repos","events_url":"https://api.github.com/users/admsyn/events{/privacy}","received_events_url":"https://api.github.com/users/admsyn/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T17:35:19Z","updated_at":"2016-08-11T17:35:19Z","body":"Did the CLA again, double checked that I was using the same email as my github account. ¯\\_(ツ)_/¯\r\n\r\n> .. If you want to add that ability to CMake too, I'd welcome that PR.\r\n\r\nSure, enabled (`=1`) by default?"}}
{"actor":{"display_login":"admsyn"}}