{"action":"created","issue":{"url":"https://api.github.com/repos/danger/danger/issues/648","repository_url":"https://api.github.com/repos/danger/danger","labels_url":"https://api.github.com/repos/danger/danger/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/danger/danger/issues/648/comments","events_url":"https://api.github.com/repos/danger/danger/issues/648/events","html_url":"https://github.com/danger/danger/issues/648","id":184818140,"number":648,"title":"GitLab request source lacks new_comment parameter in update_pull_request","user":{"login":"nikolaykasyanov","id":136644,"avatar_url":"https://avatars.githubusercontent.com/u/136644?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolaykasyanov","html_url":"https://github.com/nikolaykasyanov","followers_url":"https://api.github.com/users/nikolaykasyanov/followers","following_url":"https://api.github.com/users/nikolaykasyanov/following{/other_user}","gists_url":"https://api.github.com/users/nikolaykasyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaykasyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaykasyanov/subscriptions","organizations_url":"https://api.github.com/users/nikolaykasyanov/orgs","repos_url":"https://api.github.com/users/nikolaykasyanov/repos","events_url":"https://api.github.com/users/nikolaykasyanov/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaykasyanov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-24T11:44:29Z","updated_at":"2016-10-24T11:54:01Z","closed_at":null,"body":"# Report\r\n\r\n## What did you do?\r\n\r\nI'm trying to setup danger to work with GitLab EE installation. However, I'm getting a crash due to lack of `new_comment` argument in [`update_pull_request`](https://github.com/danger/danger/blob/8b695e7c66de788fb020ade9206d6d4807984934/lib/danger/request_sources/gitlab.rb#L100) method of GitLab request source. Here's the [call site](https://github.com/danger/danger/blob/8b695e7c66de788fb020ade9206d6d4807984934/lib/danger/danger_core/dangerfile.rb#L247).\r\n\r\nI'm using Fastlane to run danger and I'm faking CI environment with Fastlane. Basically my lane is just fakes environment & calls `danger(verbose: true)`.\r\n\r\n## What did you expect to happen?\r\n\r\nI expected comments to be posted to my MR on GitLab.\r\n\r\n## What happened instead?\r\n\r\n```\r\n[!] Exit status of command 'bundle exec danger --verbose' was 1 instead of 0.\r\nbundler: failed to load command: danger (/Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger)\r\nArgumentError: unknown keyword: new_comment\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/request_sources/gitlab.rb:100:in `update_pull_request!'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/dangerfile.rb:247:in `post_results'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/dangerfile.rb:277:in `run'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/danger_core/executor.rb:27:in `run'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/lib/danger/commands/runner.rb:66:in `run'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:334:in `run'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-3.5.5/bin/danger:5:in `<top (required)>'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger:23:in `load'\r\n  /Users/nkasyanov/.rbenv/versions/2.3.1/bin/danger:23:in `<top (required)>'\r\n```\r\n\r\n## Your Environment\r\n\r\n* Which CI are you running on? — locally, faking Jenkins environment, though\r\n* Are you running the latest version of Danger? — Yes, 3.5.5"},"comment":{"url":"https://api.github.com/repos/danger/danger/issues/comments/255719809","html_url":"https://github.com/danger/danger/issues/648#issuecomment-255719809","issue_url":"https://api.github.com/repos/danger/danger/issues/648","id":255719809,"user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T11:54:01Z","updated_at":"2016-10-24T11:54:01Z","body":"Looks right, you want to send us a PR adding that arg? to the gitlab provider?"}}
{"actor":{"display_login":"orta"}}