{"action":"created","comment":{"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments/92362217","pull_request_review_id":12874850,"id":92362217,"diff_hunk":"@@ -14,24 +14,53 @@\n         envConfig = {\n             DEVELOPMENT: {\n                 bag: {\n-                    ENDPOINT_PREVIEW: 'https://api-acc.datapunt.amsterdam.nl/dataselectie/bag/',\n                     ENDPOINT_MARKERS: 'https://api-acc.datapunt.amsterdam.nl/dataselectie/bag/geolocation/',\n                     ENDPOINT_EXPORT: 'https://api-acc.datapunt.amsterdam.nl/dataselectie/bag/export/',\n                     ENDPOINT_DETAIL: 'https://api-acc.datapunt.amsterdam.nl/bag/nummeraanduiding/'\n                 }\n             },\n             PRODUCTION: {\n                 bag: {\n-                    ENDPOINT_PREVIEW: 'https://api.datapunt.amsterdam.nl/dataselectie/bag/',\n                     ENDPOINT_MARKERS: 'https://api.datapunt.amsterdam.nl/dataselectie/bag/geolocation/',\n                     ENDPOINT_EXPORT: 'https://api.datapunt.amsterdam.nl/dataselectie/bag/export/',\n                     ENDPOINT_DETAIL: 'https://api.datapunt.amsterdam.nl/bag/nummeraanduiding/'\n                 }\n             }\n         };\n         globalConfig = {\n-            MAX_AVAILABLE_PAGES: 100,\n+            catalogus: {\n+                MAX_ITEMS_PER_PAGE: 10,\n+                CUSTOM_API: 'dataSelectionApiCkan',","path":"modules/data-selection/data-selection-config.factory.js","position":23,"original_position":23,"commit_id":"171a76e8e3b12704879ad4aaa0f8de328d38619e","original_commit_id":"171a76e8e3b12704879ad4aaa0f8de328d38619e","user":{"login":"ErikNijland","id":7983484,"avatar_url":"https://avatars.githubusercontent.com/u/7983484?v=3","gravatar_id":"","url":"https://api.github.com/users/ErikNijland","html_url":"https://github.com/ErikNijland","followers_url":"https://api.github.com/users/ErikNijland/followers","following_url":"https://api.github.com/users/ErikNijland/following{/other_user}","gists_url":"https://api.github.com/users/ErikNijland/gists{/gist_id}","starred_url":"https://api.github.com/users/ErikNijland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErikNijland/subscriptions","organizations_url":"https://api.github.com/users/ErikNijland/orgs","repos_url":"https://api.github.com/users/ErikNijland/repos","events_url":"https://api.github.com/users/ErikNijland/events{/privacy}","received_events_url":"https://api.github.com/users/ErikNijland/received_events","type":"User","site_admin":false},"body":"Ik zou het geen CUSTOM_API noemen. Dit suggereert dat dat er een default is. Ik zou doen per dataset: API_SERVICE: 'dataSelectionApiCkan', en anders 'dataSelectionApiDatapunt' oid.","created_at":"2016-12-14T10:16:31Z","updated_at":"2016-12-14T10:16:31Z","html_url":"https://github.com/DatapuntAmsterdam/atlas/pull/334#discussion_r92362217","pull_request_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments/92362217"},"html":{"href":"https://github.com/DatapuntAmsterdam/atlas/pull/334#discussion_r92362217"},"pull_request":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334","id":97146833,"html_url":"https://github.com/DatapuntAmsterdam/atlas/pull/334","diff_url":"https://github.com/DatapuntAmsterdam/atlas/pull/334.diff","patch_url":"https://github.com/DatapuntAmsterdam/atlas/pull/334.patch","issue_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/334","number":334,"state":"open","locked":false,"title":"Feature/tg 2322 api service aanpassen voor implementatie catalogus","user":{"login":"boris-arkenaar","id":2932084,"avatar_url":"https://avatars.githubusercontent.com/u/2932084?v=3","gravatar_id":"","url":"https://api.github.com/users/boris-arkenaar","html_url":"https://github.com/boris-arkenaar","followers_url":"https://api.github.com/users/boris-arkenaar/followers","following_url":"https://api.github.com/users/boris-arkenaar/following{/other_user}","gists_url":"https://api.github.com/users/boris-arkenaar/gists{/gist_id}","starred_url":"https://api.github.com/users/boris-arkenaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boris-arkenaar/subscriptions","organizations_url":"https://api.github.com/users/boris-arkenaar/orgs","repos_url":"https://api.github.com/users/boris-arkenaar/repos","events_url":"https://api.github.com/users/boris-arkenaar/events{/privacy}","received_events_url":"https://api.github.com/users/boris-arkenaar/received_events","type":"User","site_admin":false},"body":"Werk voor de catalogus.\r\nDe API service is een generieke API service geworden die niet direct API calls uitvoert. Hij haalt de naam van een specifieke API service implementatie uit de configuratie. Vervolgens wordt die service dynamisch geïnject en aangeroepen.","created_at":"2016-12-08T15:48:59Z","updated_at":"2016-12-14T10:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7082181544bd204e605b197d8f3467966b45f3eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334/commits","review_comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334/comments","review_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/334/comments","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/171a76e8e3b12704879ad4aaa0f8de328d38619e","head":{"label":"DatapuntAmsterdam:feature/tg-2322-api-service","ref":"feature/tg-2322-api-service","sha":"171a76e8e3b12704879ad4aaa0f8de328d38619e","user":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":60016458,"name":"atlas","full_name":"DatapuntAmsterdam/atlas","owner":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DatapuntAmsterdam/atlas","description":null,"fork":false,"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas","forks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/forks","keys_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/teams","hooks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/hooks","issue_events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/events","assignees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/tags","blobs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/languages","stargazers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/stargazers","contributors_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contributors","subscribers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscribers","subscription_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscription","commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/merges","archive_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/downloads","issues_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/labels{/name}","releases_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/deployments","created_at":"2016-05-30T14:31:42Z","updated_at":"2016-10-25T06:17:20Z","pushed_at":"2016-12-14T10:16:23Z","git_url":"git://github.com/DatapuntAmsterdam/atlas.git","ssh_url":"git@github.com:DatapuntAmsterdam/atlas.git","clone_url":"https://github.com/DatapuntAmsterdam/atlas.git","svn_url":"https://github.com/DatapuntAmsterdam/atlas","homepage":"","size":9070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"DatapuntAmsterdam:catalogus","ref":"catalogus","sha":"26d97c323a33e62b152050c8e864f9a2a77a0ef8","user":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"repo":{"id":60016458,"name":"atlas","full_name":"DatapuntAmsterdam/atlas","owner":{"login":"DatapuntAmsterdam","id":15195167,"avatar_url":"https://avatars.githubusercontent.com/u/15195167?v=3","gravatar_id":"","url":"https://api.github.com/users/DatapuntAmsterdam","html_url":"https://github.com/DatapuntAmsterdam","followers_url":"https://api.github.com/users/DatapuntAmsterdam/followers","following_url":"https://api.github.com/users/DatapuntAmsterdam/following{/other_user}","gists_url":"https://api.github.com/users/DatapuntAmsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/DatapuntAmsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DatapuntAmsterdam/subscriptions","organizations_url":"https://api.github.com/users/DatapuntAmsterdam/orgs","repos_url":"https://api.github.com/users/DatapuntAmsterdam/repos","events_url":"https://api.github.com/users/DatapuntAmsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/DatapuntAmsterdam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DatapuntAmsterdam/atlas","description":null,"fork":false,"url":"https://api.github.com/repos/DatapuntAmsterdam/atlas","forks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/forks","keys_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/teams","hooks_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/hooks","issue_events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/events","assignees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/tags","blobs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/languages","stargazers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/stargazers","contributors_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contributors","subscribers_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscribers","subscription_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/subscription","commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/merges","archive_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/downloads","issues_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/labels{/name}","releases_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/DatapuntAmsterdam/atlas/deployments","created_at":"2016-05-30T14:31:42Z","updated_at":"2016-10-25T06:17:20Z","pushed_at":"2016-12-14T10:16:23Z","git_url":"git://github.com/DatapuntAmsterdam/atlas.git","ssh_url":"git@github.com:DatapuntAmsterdam/atlas.git","clone_url":"https://github.com/DatapuntAmsterdam/atlas.git","svn_url":"https://github.com/DatapuntAmsterdam/atlas","homepage":"","size":9070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334"},"html":{"href":"https://github.com/DatapuntAmsterdam/atlas/pull/334"},"issue":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/334"},"comments":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/DatapuntAmsterdam/atlas/statuses/171a76e8e3b12704879ad4aaa0f8de328d38619e"}}}}
{"actor":{"display_login":"ErikNijland"}}