{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments/62875686","id":62875686,"diff_hunk":"@@ -6,6 +6,9 @@ using Base.Meta\n \n if isdefined(Core, :String) && isdefined(Core, :AbstractString)\n     typealias String Core.String\n+    # Not exported in order to not break code on 0.5\n+    typealias UTF8String Core.String\n+    typealias ASCIIString Core.String","path":"src/Compat.jl","position":6,"original_position":6,"commit_id":"4abb76769dfa4125a38257089a224a3dea55bc22","original_commit_id":"4abb76769dfa4125a38257089a224a3dea55bc22","user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"body":"Right, on julia-0.5 there is no way to do this anyway; this is just to avoid breaking packages that used to work on julia-0.4.","created_at":"2016-05-11T15:59:14Z","updated_at":"2016-05-11T15:59:14Z","html_url":"https://github.com/JuliaLang/Compat.jl/pull/198#discussion_r62875686","pull_request_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments/62875686"},"html":{"href":"https://github.com/JuliaLang/Compat.jl/pull/198#discussion_r62875686"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198","id":69688815,"html_url":"https://github.com/JuliaLang/Compat.jl/pull/198","diff_url":"https://github.com/JuliaLang/Compat.jl/pull/198.diff","patch_url":"https://github.com/JuliaLang/Compat.jl/pull/198.patch","issue_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/198","number":198,"state":"open","locked":false,"title":"Add unexported alias for UTF8String and ASCIIString","user":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"body":"To help package to upgrade without breaking API on julia 0.4.\r\n\r\nAs discussed in https://github.com/JuliaLang/Compat.jl/pull/197#discussion_r62842265\r\n\r\nThe name and the expected usage are picked using the follow reasoning,\r\n\r\n1. Since this is a reverse `Compat` usage the usage should have `Compat` in it so it is easy to search and fix when 0.4 support is dropped from the package that uses this. The package can still `import` the symbol.\r\n2. `Compat.*` is as easy to write as `Compat*`, might as well make it simpler (and reduce a few lines of code for 0.4)\r\n3. The binding is not exported in order to not break packages on 0.5. Otherwise, a package that `using Compat` without importing explicitly will get a error when using `UTF8String` or `ASCIIString` on 0.5 instead of a deprecation.\r\n\r\nAlso fix a few warnings in the test.\r\n\r\n@timholy @stevengj \r\n","created_at":"2016-05-11T15:08:22Z","updated_at":"2016-05-11T15:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f5fd581c99b8974ee1bc09375a40f8c8fcb0a0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/198/comments","statuses_url":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/4abb76769dfa4125a38257089a224a3dea55bc22","head":{"label":"JuliaLang:yyc/more-strings","ref":"yyc/more-strings","sha":"4abb76769dfa4125a38257089a224a3dea55bc22","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":24995432,"name":"Compat.jl","full_name":"JuliaLang/Compat.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/Compat.jl","description":"cross-version compatibility","fork":false,"url":"https://api.github.com/repos/JuliaLang/Compat.jl","forks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/Compat.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/Compat.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/Compat.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/Compat.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/Compat.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/Compat.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/Compat.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/Compat.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/Compat.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/Compat.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/Compat.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/Compat.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/Compat.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/deployments","created_at":"2014-10-09T15:27:45Z","updated_at":"2016-05-09T11:39:49Z","pushed_at":"2016-05-11T15:18:10Z","git_url":"git://github.com/JuliaLang/Compat.jl.git","ssh_url":"git@github.com:JuliaLang/Compat.jl.git","clone_url":"https://github.com/JuliaLang/Compat.jl.git","svn_url":"https://github.com/JuliaLang/Compat.jl","homepage":null,"size":432,"stargazers_count":18,"watchers_count":18,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":23,"forks":35,"open_issues":23,"watchers":18,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"93ff2e1b1b77c11f7387a1997d6ba69b544a7dc9","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":24995432,"name":"Compat.jl","full_name":"JuliaLang/Compat.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/Compat.jl","description":"cross-version compatibility","fork":false,"url":"https://api.github.com/repos/JuliaLang/Compat.jl","forks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/Compat.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/Compat.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/Compat.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/Compat.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/Compat.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/Compat.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/Compat.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/Compat.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/Compat.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/Compat.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/Compat.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/Compat.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/Compat.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/Compat.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/Compat.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/Compat.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/Compat.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/Compat.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/Compat.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/Compat.jl/deployments","created_at":"2014-10-09T15:27:45Z","updated_at":"2016-05-09T11:39:49Z","pushed_at":"2016-05-11T15:18:10Z","git_url":"git://github.com/JuliaLang/Compat.jl.git","ssh_url":"git@github.com:JuliaLang/Compat.jl.git","clone_url":"https://github.com/JuliaLang/Compat.jl.git","svn_url":"https://github.com/JuliaLang/Compat.jl","homepage":null,"size":432,"stargazers_count":18,"watchers_count":18,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":23,"forks":35,"open_issues":23,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198"},"html":{"href":"https://github.com/JuliaLang/Compat.jl/pull/198"},"issue":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/198"},"comments":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/Compat.jl/statuses/4abb76769dfa4125a38257089a224a3dea55bc22"}}}}