{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/35413","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/35413/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/35413/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/35413/events","html_url":"https://github.com/saltstack/salt/pull/35413","id":170851810,"number":35413,"title":"Resolve path issues with cp.push","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-12T11:28:06Z","updated_at":"2016-08-13T08:26:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/35413","html_url":"https://github.com/saltstack/salt/pull/35413","diff_url":"https://github.com/saltstack/salt/pull/35413.diff","patch_url":"https://github.com/saltstack/salt/pull/35413.patch"},"body":"### What does this PR do?\r\nThis PR modifies the master file recv method to take a list instead of a string for a path name for incoming files. This approach easier cross-platform compatibility concerns by allowing the master to reconstruct the path for whatever platform it happens to be on, regardless of what path separator and other idiosyncrasies the minion might have.\r\n\r\nThis resolves a bug wherein Windows minions would often write out nonsense or otherwise incorrect file paths to the master cache dir.\r\n\r\nAdditionally, it also implements additional safety features to ensure that a malicious actor can not write to files outside of the master's cache directory.\r\n### What issues does this PR fix or reference?\r\n#35296\r\n### Previous Behavior\r\nWindows minions would construct paths with backslashes in their name in the master cache directory.\r\n\r\n### New Behavior\r\nPaths constructed correctly.\r\n### Tests written?\r\n\r\nYes\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/239609691","html_url":"https://github.com/saltstack/salt/pull/35413#issuecomment-239609691","issue_url":"https://api.github.com/repos/saltstack/salt/issues/35413","id":239609691,"user":{"login":"s0undt3ch","id":300048,"avatar_url":"https://avatars.githubusercontent.com/u/300048?v=3","gravatar_id":"","url":"https://api.github.com/users/s0undt3ch","html_url":"https://github.com/s0undt3ch","followers_url":"https://api.github.com/users/s0undt3ch/followers","following_url":"https://api.github.com/users/s0undt3ch/following{/other_user}","gists_url":"https://api.github.com/users/s0undt3ch/gists{/gist_id}","starred_url":"https://api.github.com/users/s0undt3ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s0undt3ch/subscriptions","organizations_url":"https://api.github.com/users/s0undt3ch/orgs","repos_url":"https://api.github.com/users/s0undt3ch/repos","events_url":"https://api.github.com/users/s0undt3ch/events{/privacy}","received_events_url":"https://api.github.com/users/s0undt3ch/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T08:26:01Z","updated_at":"2016-08-13T08:26:01Z","body":"Looks great! I'd just have a test which triggers salt's security routines ;)"}}
{"actor":{"display_login":"s0undt3ch"}}