{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/61071410","id":61071410,"diff_hunk":"@@ -187,17 +187,31 @@ angular.module('ui.bootstrap.dropdown', ['ui.bootstrap.position'])\n     }\n   };\n \n+  function toggleDropdownUp() {\n+    var clientRect = $element[0].getBoundingClientRect(),\n+      dropdownHeight = scope.getDropdownElement().outerHeight();\n+\n+    if (clientRect.top > dropdownHeight &&\n+        window.innerHeight - clientRect.top < clientRect.height + dropdownHeight) {\n+      return true;\n+    }\n+    return false;\n+  }\n+\n   scope.$watch('isOpen', function(isOpen, wasOpen) {\n     if (appendTo && self.dropdownMenu) {\n       var pos = $position.positionElements($element, self.dropdownMenu, 'bottom-left', true),","path":"src/dropdown/dropdown.js","position":17,"original_position":17,"commit_id":"844a5c00682cadd44a442a1f0f0bb0f2f19803e6","original_commit_id":"844a5c00682cadd44a442a1f0f0bb0f2f19803e6","user":{"login":"RobJacobs","id":4559806,"avatar_url":"https://avatars.githubusercontent.com/u/4559806?v=3","gravatar_id":"","url":"https://api.github.com/users/RobJacobs","html_url":"https://github.com/RobJacobs","followers_url":"https://api.github.com/users/RobJacobs/followers","following_url":"https://api.github.com/users/RobJacobs/following{/other_user}","gists_url":"https://api.github.com/users/RobJacobs/gists{/gist_id}","starred_url":"https://api.github.com/users/RobJacobs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobJacobs/subscriptions","organizations_url":"https://api.github.com/users/RobJacobs/orgs","repos_url":"https://api.github.com/users/RobJacobs/repos","events_url":"https://api.github.com/users/RobJacobs/events{/privacy}","received_events_url":"https://api.github.com/users/RobJacobs/received_events","type":"User","site_admin":false},"body":"The placement parameter passed to the positionElements method should be changed to 'auto bottom-left' and leverage the work already being done there.","created_at":"2016-04-26T11:46:52Z","updated_at":"2016-04-26T11:46:52Z","html_url":"https://github.com/angular-ui/bootstrap/pull/5845#discussion_r61071410","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/61071410"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/5845#discussion_r61071410"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845","id":67846985,"html_url":"https://github.com/angular-ui/bootstrap/pull/5845","diff_url":"https://github.com/angular-ui/bootstrap/pull/5845.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/5845.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/5845","number":5845,"state":"open","locked":false,"title":"fix(dropdown): browser collision detection","user":{"login":"SjorsH","id":8993481,"avatar_url":"https://avatars.githubusercontent.com/u/8993481?v=3","gravatar_id":"","url":"https://api.github.com/users/SjorsH","html_url":"https://github.com/SjorsH","followers_url":"https://api.github.com/users/SjorsH/followers","following_url":"https://api.github.com/users/SjorsH/following{/other_user}","gists_url":"https://api.github.com/users/SjorsH/gists{/gist_id}","starred_url":"https://api.github.com/users/SjorsH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SjorsH/subscriptions","organizations_url":"https://api.github.com/users/SjorsH/orgs","repos_url":"https://api.github.com/users/SjorsH/repos","events_url":"https://api.github.com/users/SjorsH/events{/privacy}","received_events_url":"https://api.github.com/users/SjorsH/received_events","type":"User","site_admin":false},"body":"Fix for the dropdown issues #5841, #5767","created_at":"2016-04-26T08:42:08Z","updated_at":"2016-04-26T11:46:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9705d243a7c337a2487fcc95d7bc31a8b9c23577","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/5845/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/844a5c00682cadd44a442a1f0f0bb0f2f19803e6","head":{"label":"SjorsH:toggleDropdown","ref":"toggleDropdown","sha":"844a5c00682cadd44a442a1f0f0bb0f2f19803e6","user":{"login":"SjorsH","id":8993481,"avatar_url":"https://avatars.githubusercontent.com/u/8993481?v=3","gravatar_id":"","url":"https://api.github.com/users/SjorsH","html_url":"https://github.com/SjorsH","followers_url":"https://api.github.com/users/SjorsH/followers","following_url":"https://api.github.com/users/SjorsH/following{/other_user}","gists_url":"https://api.github.com/users/SjorsH/gists{/gist_id}","starred_url":"https://api.github.com/users/SjorsH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SjorsH/subscriptions","organizations_url":"https://api.github.com/users/SjorsH/orgs","repos_url":"https://api.github.com/users/SjorsH/repos","events_url":"https://api.github.com/users/SjorsH/events{/privacy}","received_events_url":"https://api.github.com/users/SjorsH/received_events","type":"User","site_admin":false},"repo":{"id":57032747,"name":"bootstrap","full_name":"SjorsH/bootstrap","owner":{"login":"SjorsH","id":8993481,"avatar_url":"https://avatars.githubusercontent.com/u/8993481?v=3","gravatar_id":"","url":"https://api.github.com/users/SjorsH","html_url":"https://github.com/SjorsH","followers_url":"https://api.github.com/users/SjorsH/followers","following_url":"https://api.github.com/users/SjorsH/following{/other_user}","gists_url":"https://api.github.com/users/SjorsH/gists{/gist_id}","starred_url":"https://api.github.com/users/SjorsH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SjorsH/subscriptions","organizations_url":"https://api.github.com/users/SjorsH/orgs","repos_url":"https://api.github.com/users/SjorsH/repos","events_url":"https://api.github.com/users/SjorsH/events{/privacy}","received_events_url":"https://api.github.com/users/SjorsH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SjorsH/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":true,"url":"https://api.github.com/repos/SjorsH/bootstrap","forks_url":"https://api.github.com/repos/SjorsH/bootstrap/forks","keys_url":"https://api.github.com/repos/SjorsH/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SjorsH/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SjorsH/bootstrap/teams","hooks_url":"https://api.github.com/repos/SjorsH/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/SjorsH/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/SjorsH/bootstrap/events","assignees_url":"https://api.github.com/repos/SjorsH/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/SjorsH/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/SjorsH/bootstrap/tags","blobs_url":"https://api.github.com/repos/SjorsH/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SjorsH/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SjorsH/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/SjorsH/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SjorsH/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/SjorsH/bootstrap/languages","stargazers_url":"https://api.github.com/repos/SjorsH/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/SjorsH/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/SjorsH/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/SjorsH/bootstrap/subscription","commits_url":"https://api.github.com/repos/SjorsH/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/SjorsH/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/SjorsH/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/SjorsH/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/SjorsH/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/SjorsH/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SjorsH/bootstrap/merges","archive_url":"https://api.github.com/repos/SjorsH/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SjorsH/bootstrap/downloads","issues_url":"https://api.github.com/repos/SjorsH/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/SjorsH/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/SjorsH/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/SjorsH/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SjorsH/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/SjorsH/bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/SjorsH/bootstrap/deployments","created_at":"2016-04-25T10:23:14Z","updated_at":"2016-04-25T10:23:17Z","pushed_at":"2016-04-26T08:37:21Z","git_url":"git://github.com/SjorsH/bootstrap.git","ssh_url":"git@github.com:SjorsH/bootstrap.git","clone_url":"https://github.com/SjorsH/bootstrap.git","svn_url":"https://github.com/SjorsH/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":9967,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"f88067a04f8647f25e3bb987e3ea13993a146147","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/angular-ui/bootstrap/deployments","created_at":"2012-10-05T18:27:01Z","updated_at":"2016-04-26T08:15:29Z","pushed_at":"2016-04-26T08:42:08Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":16836,"stargazers_count":12189,"watchers_count":12189,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6300,"mirror_url":null,"open_issues_count":128,"forks":6300,"open_issues":128,"watchers":12189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/5845"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/5845"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/5845/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/5845/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/844a5c00682cadd44a442a1f0f0bb0f2f19803e6"}}}}