{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104","id":87388692,"html_url":"https://github.com/shoreditch-ops/artillery-core/pull/104","diff_url":"https://github.com/shoreditch-ops/artillery-core/pull/104.diff","patch_url":"https://github.com/shoreditch-ops/artillery-core/pull/104.patch","issue_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/104","number":104,"state":"closed","locked":false,"title":"Initial set of changes and bug fix to support capture/match in socket.io emit flows","user":{"login":"gboysko","id":636721,"avatar_url":"https://avatars.githubusercontent.com/u/636721?v=3","gravatar_id":"","url":"https://api.github.com/users/gboysko","html_url":"https://github.com/gboysko","followers_url":"https://api.github.com/users/gboysko/followers","following_url":"https://api.github.com/users/gboysko/following{/other_user}","gists_url":"https://api.github.com/users/gboysko/gists{/gist_id}","starred_url":"https://api.github.com/users/gboysko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gboysko/subscriptions","organizations_url":"https://api.github.com/users/gboysko/orgs","repos_url":"https://api.github.com/users/gboysko/repos","events_url":"https://api.github.com/users/gboysko/events{/privacy}","received_events_url":"https://api.github.com/users/gboysko/received_events","type":"User","site_admin":false},"body":"Hello Hassey:\r\n\r\nThis commit it not intended to be checked in as I have not finished my refactoring. Just getting basic competency in the code base. \r\n\r\nFeel free to review my approach and changes. I admit I don't know if I've followed all of your conventions consistently.\r\n\r\nMy plan is to next refactor the `captureOrMatch` function into its own module in `engine_utils` and then apply those changes to `engine_http` and `engine_socketio`. \r\n\r\nThe callback handler for each of those entry points seems to be very common and perhaps that should be shared as well. \r\n\r\nAny thoughts you have are appreciated.\r\n\r\nRegards,\r\nGlenn","created_at":"2016-09-29T20:34:31Z","updated_at":"2016-10-10T12:28:18Z","closed_at":"2016-10-10T12:28:18Z","merged_at":"2016-10-10T12:28:18Z","merge_commit_sha":"56924ffcbcdd09c5cf6d5a84cd6a7d925dfa34a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104/commits","review_comments_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104/comments","review_comment_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/104/comments","statuses_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/statuses/036df5fcea131f4c11cef38f89d7a137805addff","head":{"label":"gboysko:master","ref":"master","sha":"036df5fcea131f4c11cef38f89d7a137805addff","user":{"login":"gboysko","id":636721,"avatar_url":"https://avatars.githubusercontent.com/u/636721?v=3","gravatar_id":"","url":"https://api.github.com/users/gboysko","html_url":"https://github.com/gboysko","followers_url":"https://api.github.com/users/gboysko/followers","following_url":"https://api.github.com/users/gboysko/following{/other_user}","gists_url":"https://api.github.com/users/gboysko/gists{/gist_id}","starred_url":"https://api.github.com/users/gboysko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gboysko/subscriptions","organizations_url":"https://api.github.com/users/gboysko/orgs","repos_url":"https://api.github.com/users/gboysko/repos","events_url":"https://api.github.com/users/gboysko/events{/privacy}","received_events_url":"https://api.github.com/users/gboysko/received_events","type":"User","site_admin":false},"repo":{"id":69502327,"name":"artillery-core","full_name":"gboysko/artillery-core","owner":{"login":"gboysko","id":636721,"avatar_url":"https://avatars.githubusercontent.com/u/636721?v=3","gravatar_id":"","url":"https://api.github.com/users/gboysko","html_url":"https://github.com/gboysko","followers_url":"https://api.github.com/users/gboysko/followers","following_url":"https://api.github.com/users/gboysko/following{/other_user}","gists_url":"https://api.github.com/users/gboysko/gists{/gist_id}","starred_url":"https://api.github.com/users/gboysko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gboysko/subscriptions","organizations_url":"https://api.github.com/users/gboysko/orgs","repos_url":"https://api.github.com/users/gboysko/repos","events_url":"https://api.github.com/users/gboysko/events{/privacy}","received_events_url":"https://api.github.com/users/gboysko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gboysko/artillery-core","description":"Core load-generating functionality of Artillery","fork":true,"url":"https://api.github.com/repos/gboysko/artillery-core","forks_url":"https://api.github.com/repos/gboysko/artillery-core/forks","keys_url":"https://api.github.com/repos/gboysko/artillery-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gboysko/artillery-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gboysko/artillery-core/teams","hooks_url":"https://api.github.com/repos/gboysko/artillery-core/hooks","issue_events_url":"https://api.github.com/repos/gboysko/artillery-core/issues/events{/number}","events_url":"https://api.github.com/repos/gboysko/artillery-core/events","assignees_url":"https://api.github.com/repos/gboysko/artillery-core/assignees{/user}","branches_url":"https://api.github.com/repos/gboysko/artillery-core/branches{/branch}","tags_url":"https://api.github.com/repos/gboysko/artillery-core/tags","blobs_url":"https://api.github.com/repos/gboysko/artillery-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gboysko/artillery-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gboysko/artillery-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gboysko/artillery-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gboysko/artillery-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gboysko/artillery-core/languages","stargazers_url":"https://api.github.com/repos/gboysko/artillery-core/stargazers","contributors_url":"https://api.github.com/repos/gboysko/artillery-core/contributors","subscribers_url":"https://api.github.com/repos/gboysko/artillery-core/subscribers","subscription_url":"https://api.github.com/repos/gboysko/artillery-core/subscription","commits_url":"https://api.github.com/repos/gboysko/artillery-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gboysko/artillery-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gboysko/artillery-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gboysko/artillery-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/gboysko/artillery-core/contents/{+path}","compare_url":"https://api.github.com/repos/gboysko/artillery-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gboysko/artillery-core/merges","archive_url":"https://api.github.com/repos/gboysko/artillery-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gboysko/artillery-core/downloads","issues_url":"https://api.github.com/repos/gboysko/artillery-core/issues{/number}","pulls_url":"https://api.github.com/repos/gboysko/artillery-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gboysko/artillery-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gboysko/artillery-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gboysko/artillery-core/labels{/name}","releases_url":"https://api.github.com/repos/gboysko/artillery-core/releases{/id}","deployments_url":"https://api.github.com/repos/gboysko/artillery-core/deployments","created_at":"2016-09-28T20:45:39Z","updated_at":"2016-09-28T20:45:41Z","pushed_at":"2016-10-03T20:18:21Z","git_url":"git://github.com/gboysko/artillery-core.git","ssh_url":"git@github.com:gboysko/artillery-core.git","clone_url":"https://github.com/gboysko/artillery-core.git","svn_url":"https://github.com/gboysko/artillery-core","homepage":"https://artillery.io","size":13742,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shoreditch-ops:master","ref":"master","sha":"7a9f5c50451659f55bcaff34f37e00d0740125b7","user":{"login":"shoreditch-ops","id":12608521,"avatar_url":"https://avatars.githubusercontent.com/u/12608521?v=3","gravatar_id":"","url":"https://api.github.com/users/shoreditch-ops","html_url":"https://github.com/shoreditch-ops","followers_url":"https://api.github.com/users/shoreditch-ops/followers","following_url":"https://api.github.com/users/shoreditch-ops/following{/other_user}","gists_url":"https://api.github.com/users/shoreditch-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/shoreditch-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoreditch-ops/subscriptions","organizations_url":"https://api.github.com/users/shoreditch-ops/orgs","repos_url":"https://api.github.com/users/shoreditch-ops/repos","events_url":"https://api.github.com/users/shoreditch-ops/events{/privacy}","received_events_url":"https://api.github.com/users/shoreditch-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":38884248,"name":"artillery-core","full_name":"shoreditch-ops/artillery-core","owner":{"login":"shoreditch-ops","id":12608521,"avatar_url":"https://avatars.githubusercontent.com/u/12608521?v=3","gravatar_id":"","url":"https://api.github.com/users/shoreditch-ops","html_url":"https://github.com/shoreditch-ops","followers_url":"https://api.github.com/users/shoreditch-ops/followers","following_url":"https://api.github.com/users/shoreditch-ops/following{/other_user}","gists_url":"https://api.github.com/users/shoreditch-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/shoreditch-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoreditch-ops/subscriptions","organizations_url":"https://api.github.com/users/shoreditch-ops/orgs","repos_url":"https://api.github.com/users/shoreditch-ops/repos","events_url":"https://api.github.com/users/shoreditch-ops/events{/privacy}","received_events_url":"https://api.github.com/users/shoreditch-ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoreditch-ops/artillery-core","description":"Core load-generating functionality of Artillery","fork":false,"url":"https://api.github.com/repos/shoreditch-ops/artillery-core","forks_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/forks","keys_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/teams","hooks_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/hooks","issue_events_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/events{/number}","events_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/events","assignees_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/assignees{/user}","branches_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/branches{/branch}","tags_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/tags","blobs_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/statuses/{sha}","languages_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/languages","stargazers_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/stargazers","contributors_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/contributors","subscribers_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/subscribers","subscription_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/subscription","commits_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/contents/{+path}","compare_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/merges","archive_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/downloads","issues_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues{/number}","pulls_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls{/number}","milestones_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/milestones{/number}","notifications_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/labels{/name}","releases_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/releases{/id}","deployments_url":"https://api.github.com/repos/shoreditch-ops/artillery-core/deployments","created_at":"2015-07-10T14:23:01Z","updated_at":"2016-09-13T08:48:03Z","pushed_at":"2016-10-10T12:28:18Z","git_url":"git://github.com/shoreditch-ops/artillery-core.git","ssh_url":"git@github.com:shoreditch-ops/artillery-core.git","clone_url":"https://github.com/shoreditch-ops/artillery-core.git","svn_url":"https://github.com/shoreditch-ops/artillery-core","homepage":"https://artillery.io","size":13750,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":9,"forks":36,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104"},"html":{"href":"https://github.com/shoreditch-ops/artillery-core/pull/104"},"issue":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/104"},"comments":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/shoreditch-ops/artillery-core/statuses/036df5fcea131f4c11cef38f89d7a137805addff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hassy","id":1490,"avatar_url":"https://avatars.githubusercontent.com/u/1490?v=3","gravatar_id":"","url":"https://api.github.com/users/hassy","html_url":"https://github.com/hassy","followers_url":"https://api.github.com/users/hassy/followers","following_url":"https://api.github.com/users/hassy/following{/other_user}","gists_url":"https://api.github.com/users/hassy/gists{/gist_id}","starred_url":"https://api.github.com/users/hassy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassy/subscriptions","organizations_url":"https://api.github.com/users/hassy/orgs","repos_url":"https://api.github.com/users/hassy/repos","events_url":"https://api.github.com/users/hassy/events{/privacy}","received_events_url":"https://api.github.com/users/hassy/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":3,"additions":313,"deletions":256,"changed_files":4}}
{"actor":{"display_login":"hassy"}}