{"action":"created","comment":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/89700985","pull_request_review_id":10239346,"id":89700985,"diff_hunk":"@@ -1217,6 +1217,27 @@ public void shouldCreateReverseIteratorOfNonEmpty() {\n         assertThat(ofAll(of(\"a\", \"b\", \"c\")).reverseIterator().toList()).isEqualTo(Iterator.of(\"c\", \"b\", \"a\").toList());\n     }\n \n+    // -- shuffle\n+\n+    @Test\n+    public void shouldShuffleEmpty() {\n+        assertThat(empty().shuffle().isEmpty());\n+    }\n+\n+    @Test\n+    public void shouldShuffleHaveSameLength() {\n+        assertThat(of(1, 2, 3).shuffle().size()).isEqualTo(of(1, 2, 3).size());\n+    }\n+\n+    @Test\n+    public void shouldShuffleHaveSameElements() {\n+        Seq<Integer> shuffled = of(1, 2, 3).shuffle();\n+        assertThat(shuffled.indexOf(1)).isNotEqualTo(-1);","path":"javaslang/src/test/java/javaslang/collection/AbstractSeqTest.java","position":19,"original_position":19,"commit_id":"f1a0ca965d816f5ad70bebf44ab515f1a064ad47","original_commit_id":"f1a0ca965d816f5ad70bebf44ab515f1a064ad47","user":{"login":"io7m","id":612494,"avatar_url":"https://avatars.githubusercontent.com/u/612494?v=3","gravatar_id":"","url":"https://api.github.com/users/io7m","html_url":"https://github.com/io7m","followers_url":"https://api.github.com/users/io7m/followers","following_url":"https://api.github.com/users/io7m/following{/other_user}","gists_url":"https://api.github.com/users/io7m/gists{/gist_id}","starred_url":"https://api.github.com/users/io7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/io7m/subscriptions","organizations_url":"https://api.github.com/users/io7m/orgs","repos_url":"https://api.github.com/users/io7m/repos","events_url":"https://api.github.com/users/io7m/events{/privacy}","received_events_url":"https://api.github.com/users/io7m/received_events","type":"User","site_admin":false},"body":"I did consider it, but I thought that `indexOf` was more primitive and therefore would limit the scope of what's being tested a little more than the use of a higher level function would.\r\n\r\nIt's up to you whether it gets rewritten or not, I'll do it if you think it needs doing.","created_at":"2016-11-27T22:01:40Z","updated_at":"2016-11-27T22:01:40Z","html_url":"https://github.com/javaslang/javaslang/pull/1712#discussion_r89700985","pull_request_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1712","_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/89700985"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1712#discussion_r89700985"},"pull_request":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1712"}}},"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1712","id":95371351,"html_url":"https://github.com/javaslang/javaslang/pull/1712","diff_url":"https://github.com/javaslang/javaslang/pull/1712.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1712.patch","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1712","number":1712,"state":"open","locked":false,"title":"Implement Seq.shuffle()","user":{"login":"io7m","id":612494,"avatar_url":"https://avatars.githubusercontent.com/u/612494?v=3","gravatar_id":"","url":"https://api.github.com/users/io7m","html_url":"https://github.com/io7m","followers_url":"https://api.github.com/users/io7m/followers","following_url":"https://api.github.com/users/io7m/following{/other_user}","gists_url":"https://api.github.com/users/io7m/gists{/gist_id}","starred_url":"https://api.github.com/users/io7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/io7m/subscriptions","organizations_url":"https://api.github.com/users/io7m/orgs","repos_url":"https://api.github.com/users/io7m/repos","events_url":"https://api.github.com/users/io7m/events{/privacy}","received_events_url":"https://api.github.com/users/io7m/received_events","type":"User","site_admin":false},"body":"Fix #1318","created_at":"2016-11-26T13:15:53Z","updated_at":"2016-11-27T22:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa8651d1dc9f4a7ce29249782e2557a7155930ea","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/javaslang/javaslang/milestones/20","html_url":"https://github.com/javaslang/javaslang/milestones/2.1.0","labels_url":"https://api.github.com/repos/javaslang/javaslang/milestones/20/labels","id":1294243,"number":20,"title":"2.1.0","description":"Boost up collection performance","creator":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":377,"state":"open","created_at":"2015-09-07T18:46:28Z","updated_at":"2016-11-27T21:30:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1712/commits","review_comments_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1712/comments","review_comment_url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1712/comments","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/f1a0ca965d816f5ad70bebf44ab515f1a064ad47","head":{"label":"io7m:master","ref":"master","sha":"f1a0ca965d816f5ad70bebf44ab515f1a064ad47","user":{"login":"io7m","id":612494,"avatar_url":"https://avatars.githubusercontent.com/u/612494?v=3","gravatar_id":"","url":"https://api.github.com/users/io7m","html_url":"https://github.com/io7m","followers_url":"https://api.github.com/users/io7m/followers","following_url":"https://api.github.com/users/io7m/following{/other_user}","gists_url":"https://api.github.com/users/io7m/gists{/gist_id}","starred_url":"https://api.github.com/users/io7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/io7m/subscriptions","organizations_url":"https://api.github.com/users/io7m/orgs","repos_url":"https://api.github.com/users/io7m/repos","events_url":"https://api.github.com/users/io7m/events{/privacy}","received_events_url":"https://api.github.com/users/io7m/received_events","type":"User","site_admin":false},"repo":{"id":74826364,"name":"javaslang","full_name":"io7m/javaslang","owner":{"login":"io7m","id":612494,"avatar_url":"https://avatars.githubusercontent.com/u/612494?v=3","gravatar_id":"","url":"https://api.github.com/users/io7m","html_url":"https://github.com/io7m","followers_url":"https://api.github.com/users/io7m/followers","following_url":"https://api.github.com/users/io7m/following{/other_user}","gists_url":"https://api.github.com/users/io7m/gists{/gist_id}","starred_url":"https://api.github.com/users/io7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/io7m/subscriptions","organizations_url":"https://api.github.com/users/io7m/orgs","repos_url":"https://api.github.com/users/io7m/repos","events_url":"https://api.github.com/users/io7m/events{/privacy}","received_events_url":"https://api.github.com/users/io7m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/io7m/javaslang","description":"Javaslang is an object-functional language extension to Java 8, which aims to reduce the lines of code and increase code quality. It provides persistent collections, functional abstractions for error handling, concurrent programming, pattern matching and much more.  Javaslang fuses the power of object-oriented programming with the elegance and robustness of functional programming. The most interesting part is a feature-rich, persistent collection library that smoothly integrates with Java's standard collections.","fork":true,"url":"https://api.github.com/repos/io7m/javaslang","forks_url":"https://api.github.com/repos/io7m/javaslang/forks","keys_url":"https://api.github.com/repos/io7m/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/io7m/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/io7m/javaslang/teams","hooks_url":"https://api.github.com/repos/io7m/javaslang/hooks","issue_events_url":"https://api.github.com/repos/io7m/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/io7m/javaslang/events","assignees_url":"https://api.github.com/repos/io7m/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/io7m/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/io7m/javaslang/tags","blobs_url":"https://api.github.com/repos/io7m/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/io7m/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/io7m/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/io7m/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/io7m/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/io7m/javaslang/languages","stargazers_url":"https://api.github.com/repos/io7m/javaslang/stargazers","contributors_url":"https://api.github.com/repos/io7m/javaslang/contributors","subscribers_url":"https://api.github.com/repos/io7m/javaslang/subscribers","subscription_url":"https://api.github.com/repos/io7m/javaslang/subscription","commits_url":"https://api.github.com/repos/io7m/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/io7m/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/io7m/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/io7m/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/io7m/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/io7m/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/io7m/javaslang/merges","archive_url":"https://api.github.com/repos/io7m/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/io7m/javaslang/downloads","issues_url":"https://api.github.com/repos/io7m/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/io7m/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/io7m/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/io7m/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/io7m/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/io7m/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/io7m/javaslang/deployments","created_at":"2016-11-26T13:08:28Z","updated_at":"2016-11-26T13:08:30Z","pushed_at":"2016-11-27T11:35:12Z","git_url":"git://github.com/io7m/javaslang.git","ssh_url":"git@github.com:io7m/javaslang.git","clone_url":"https://github.com/io7m/javaslang.git","svn_url":"https://github.com/io7m/javaslang","homepage":"http://javaslang.io","size":13415,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"javaslang:master","ref":"master","sha":"b72230af91a8fbf9d9e64faa4886c61b842a81c2","user":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"repo":{"id":16378879,"name":"javaslang","full_name":"javaslang/javaslang","owner":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/javaslang/javaslang","description":"Javaslang is an object-functional language extension to Java 8, which aims to reduce the lines of code and increase code quality. It provides persistent collections, functional abstractions for error handling, concurrent programming, pattern matching and much more.  Javaslang fuses the power of object-oriented programming with the elegance and robustness of functional programming. The most interesting part is a feature-rich, persistent collection library that smoothly integrates with Java's standard collections.","fork":false,"url":"https://api.github.com/repos/javaslang/javaslang","forks_url":"https://api.github.com/repos/javaslang/javaslang/forks","keys_url":"https://api.github.com/repos/javaslang/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaslang/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaslang/javaslang/teams","hooks_url":"https://api.github.com/repos/javaslang/javaslang/hooks","issue_events_url":"https://api.github.com/repos/javaslang/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/javaslang/javaslang/events","assignees_url":"https://api.github.com/repos/javaslang/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/javaslang/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/javaslang/javaslang/tags","blobs_url":"https://api.github.com/repos/javaslang/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaslang/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaslang/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaslang/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/javaslang/javaslang/languages","stargazers_url":"https://api.github.com/repos/javaslang/javaslang/stargazers","contributors_url":"https://api.github.com/repos/javaslang/javaslang/contributors","subscribers_url":"https://api.github.com/repos/javaslang/javaslang/subscribers","subscription_url":"https://api.github.com/repos/javaslang/javaslang/subscription","commits_url":"https://api.github.com/repos/javaslang/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaslang/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaslang/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaslang/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaslang/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/javaslang/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaslang/javaslang/merges","archive_url":"https://api.github.com/repos/javaslang/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaslang/javaslang/downloads","issues_url":"https://api.github.com/repos/javaslang/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/javaslang/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/javaslang/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/javaslang/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaslang/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/javaslang/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/javaslang/javaslang/deployments","created_at":"2014-01-30T14:07:25Z","updated_at":"2016-11-27T18:38:50Z","pushed_at":"2016-11-27T21:30:16Z","git_url":"git://github.com/javaslang/javaslang.git","ssh_url":"git@github.com:javaslang/javaslang.git","clone_url":"https://github.com/javaslang/javaslang.git","svn_url":"https://github.com/javaslang/javaslang","homepage":"http://javaslang.io","size":15164,"stargazers_count":1363,"watchers_count":1363,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":87,"forks":171,"open_issues":87,"watchers":1363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1712"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1712"},"issue":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1712"},"comments":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1712/comments"},"review_comments":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1712/comments"},"review_comment":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1712/commits"},"statuses":{"href":"https://api.github.com/repos/javaslang/javaslang/statuses/f1a0ca965d816f5ad70bebf44ab515f1a064ad47"}}}}
{"actor":{"display_login":"io7m"}}