{"action":"closed","number":14971,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14971","id":93353921,"html_url":"https://github.com/guardian/frontend/pull/14971","diff_url":"https://github.com/guardian/frontend/pull/14971.diff","patch_url":"https://github.com/guardian/frontend/pull/14971.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14971","number":14971,"state":"closed","locked":false,"title":"Top-traffic content amp validation improvements","user":{"login":"jfsoul","id":8754692,"avatar_url":"https://avatars.githubusercontent.com/u/8754692?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsoul","html_url":"https://github.com/jfsoul","followers_url":"https://api.github.com/users/jfsoul/followers","following_url":"https://api.github.com/users/jfsoul/following{/other_user}","gists_url":"https://api.github.com/users/jfsoul/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsoul/subscriptions","organizations_url":"https://api.github.com/users/jfsoul/orgs","repos_url":"https://api.github.com/users/jfsoul/repos","events_url":"https://api.github.com/users/jfsoul/events{/privacy}","received_events_url":"https://api.github.com/users/jfsoul/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nThis PR adds some improvements to the ophan-top-traffic option of the amp validator which differentiates it more from the normal fixed-endpoints option.  Differences are:\r\n\r\n- No longer reports the specific error details for each validation error for each failure as this is more useful for developers.\r\n- Now checks for the presence of an `amphtml` `<link>` in the version of the page fetched from www .  If the `<link>` isn't present then we don't try and validate the page.  There is no need to apply this to the fixed endpoints, as these are hand-picked amp content.\r\n- Logging is a bit more sensible - i.e. only suggest running `dev-build` if actually trying to fetch from localhost.  Also the pass/fail messages are easier to read now.\r\n\r\n## What is the value of this and can you measure success?\r\nThe top-traffic option becomes more useful as it can be used more as a *quick check* rather than a full blown validation.  It will also only attempt to validate actual amp content.\r\n\r\n<!--\r\nIf setting up an AB test, make sure you have read our [AB testing doc](https://github.com/guardian/frontend/blob/master/docs/03-dev-howtos/01-ab-testing.md).\r\n-->\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNope\r\n\r\n<!--\r\nRun the AMP test suite with `make validate-amp`\r\n\r\nYou should also validate a specific page that your change affects by adding the amp query string along with the development hash: http://localhost:3000/sport/2016/aug/25/katie-ledecky-first-pitch-washington-nationals-bryce-harper?amp=1#development=1\r\n\r\nThe AMP validation results will appear in your console.\r\n-->\r\n\r\n## Screenshots\r\n![image](https://cloud.githubusercontent.com/assets/8754692/20220596/1278eb00-a826-11e6-88b5-fd74c0ec167f.png)\r\n\r\n\r\n![image](https://cloud.githubusercontent.com/assets/8754692/20220615/21a9ae3e-a826-11e6-9015-d98ab3ca7f83.png)\r\n\r\n## Request for comment\r\n@gtrufitt\r\n\r\ncc: @stephanfowler \r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->\r\n","created_at":"2016-11-11T15:57:33Z","updated_at":"2016-11-11T17:21:14Z","closed_at":"2016-11-11T17:21:13Z","merged_at":"2016-11-11T17:21:13Z","merge_commit_sha":"eb23138dbd7d57bdaea05d4b8ee26beaa68b8244","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/14971/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/14971/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14971/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/420260f904cb551fbc5d1d36739fb1bd85860289","head":{"label":"guardian:amp-validator-ophan","ref":"amp-validator-ophan","sha":"420260f904cb551fbc5d1d36739fb1bd85860289","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-11-11T15:59:16Z","pushed_at":"2016-11-11T17:21:13Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":552599,"stargazers_count":3396,"watchers_count":3396,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":54,"forks":359,"open_issues":54,"watchers":3396,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ff740787b37c0e3834521ff5edd69142f6ae6347","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-11-11T15:59:16Z","pushed_at":"2016-11-11T17:21:13Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":552599,"stargazers_count":3396,"watchers_count":3396,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":54,"forks":359,"open_issues":54,"watchers":3396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14971"},"html":{"href":"https://github.com/guardian/frontend/pull/14971"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/14971"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/14971/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14971/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14971/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/420260f904cb551fbc5d1d36739fb1bd85860289"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jfsoul","id":8754692,"avatar_url":"https://avatars.githubusercontent.com/u/8754692?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsoul","html_url":"https://github.com/jfsoul","followers_url":"https://api.github.com/users/jfsoul/followers","following_url":"https://api.github.com/users/jfsoul/following{/other_user}","gists_url":"https://api.github.com/users/jfsoul/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsoul/subscriptions","organizations_url":"https://api.github.com/users/jfsoul/orgs","repos_url":"https://api.github.com/users/jfsoul/repos","events_url":"https://api.github.com/users/jfsoul/events{/privacy}","received_events_url":"https://api.github.com/users/jfsoul/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":104,"deletions":68,"changed_files":6}}
{"actor":{"display_login":"jfsoul"}}