{"action":"created","comment":{"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/comments/70696356","id":70696356,"diff_hunk":"@@ -140,47 +133,42 @@ private MessageProcessResult processAsDirectMessage(MimeMessage mimeMessage) {\n     }\n \n     /**\n-     * The SmtpAgentConfig.xml is removed as part of CONN-1213. The\n-     * direct.appcontext.xml invokes smtpAgent and looks for\n-     * ConfigurationService endpoints to be published before the deployment of\n-     * Direct and this fails in case of Appservers JBoss,WebLogic and WebSphere\n-     * whereas GlassFish works.\n+     * The SmtpAgentConfig.xml is removed as part of CONN-1213. The direct.appcontext.xml invokes smtpAgent and looks\n+     * for ConfigurationService endpoints to be published before the deployment of Direct and this fails in case of\n+     * Appservers JBoss,WebLogic and WebSphere whereas GlassFish works.\n      *\n-     * CONN-1213: The SmtpAgent is created after the deployment of Direct.\n-     * Whenever the DirectSender/DirectReceiver is initiated the SmtpAgent is\n-     * created and the aAgent is used for further processing of Direct Messages.\n-     * The SmtpAgent injection is removed from direct.beans.xml whereas\n-     * ConfigurationService url can be configured in internalConnectionInfo.xml\n-     * like any other CONNECT service.\n+     * CONN-1213: The SmtpAgent is created after the deployment of Direct. Whenever the DirectSender/DirectReceiver is\n+     * initiated the SmtpAgent is created and the aAgent is used for further processing of Direct Messages. The\n+     * SmtpAgent injection is removed from direct.beans.xml whereas ConfigurationService url can be configured in\n+     * internalConnectionInfo.xml like any other CONNECT service.\n      *\n-     * Also starts the Agent Settings Manager to refresh agent settings cache\n-     * which stores information related to certificates, anchors, domains,\n-     * settings etc. The default cache refresh time is 5 minutes and can be\n-     * overridden using the gateway property AgentSettingsCacheRefreshTime.\n+     * Also starts the Agent Settings Manager to refresh agent settings cache which stores information related to\n+     * certificates, anchors, domains, settings etc. The default cache refresh time is 5 minutes and can be overridden\n+     * using the gateway property AgentSettingsCacheRefreshTime.\n      *\n      * @param url the directConfig Service url String converted into URL format.\n      * @return SmtpAgent SmtpAgent created to process Direct Messages.\n      */\n     protected SmtpAgent getSmtpAgent(URL url) {\n \n-        if ((smtpAgent != null) && smtpAgent instanceof SmtpAgent) {\n+        if (smtpAgent != null) {","path":"Product/Production/Services/DirectCore/src/main/java/gov/hhs/fha/nhinc/direct/DirectAdapter.java","position":102,"original_position":102,"commit_id":"6b109a6c0b7e91b2fb8ba1b25d9a9082b0be6a41","original_commit_id":"6b109a6c0b7e91b2fb8ba1b25d9a9082b0be6a41","user":{"login":"mhpnguyen","id":16296754,"avatar_url":"https://avatars.githubusercontent.com/u/16296754?v=3","gravatar_id":"","url":"https://api.github.com/users/mhpnguyen","html_url":"https://github.com/mhpnguyen","followers_url":"https://api.github.com/users/mhpnguyen/followers","following_url":"https://api.github.com/users/mhpnguyen/following{/other_user}","gists_url":"https://api.github.com/users/mhpnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/mhpnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhpnguyen/subscriptions","organizations_url":"https://api.github.com/users/mhpnguyen/orgs","repos_url":"https://api.github.com/users/mhpnguyen/repos","events_url":"https://api.github.com/users/mhpnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/mhpnguyen/received_events","type":"User","site_admin":false},"body":"possible to remove null check and use instanceof: \r\nPlease see the link for more information: http://stackoverflow.com/questions/2950319/is-null-check-needed-before-calling-instanceof","created_at":"2016-07-13T19:53:47Z","updated_at":"2016-07-13T19:53:47Z","html_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1319#discussion_r70696356","pull_request_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319","_links":{"self":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/comments/70696356"},"html":{"href":"https://github.com/CONNECT-Solution/CONNECT/pull/1319#discussion_r70696356"},"pull_request":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319"}}},"pull_request":{"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319","id":77347270,"html_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1319","diff_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1319.diff","patch_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1319.patch","issue_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1319","number":1319,"state":"open","locked":false,"title":"FHAC-967: Sonarqube reports 2 Direct Critical issues: Instance methods should not write to static fields","user":{"login":"danielrf123","id":16464874,"avatar_url":"https://avatars.githubusercontent.com/u/16464874?v=3","gravatar_id":"","url":"https://api.github.com/users/danielrf123","html_url":"https://github.com/danielrf123","followers_url":"https://api.github.com/users/danielrf123/followers","following_url":"https://api.github.com/users/danielrf123/following{/other_user}","gists_url":"https://api.github.com/users/danielrf123/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrf123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrf123/subscriptions","organizations_url":"https://api.github.com/users/danielrf123/orgs","repos_url":"https://api.github.com/users/danielrf123/repos","events_url":"https://api.github.com/users/danielrf123/events{/privacy}","received_events_url":"https://api.github.com/users/danielrf123/received_events","type":"User","site_admin":false},"body":"Removed the instanceof operator from line 154 to solve a major SonarQube finding.\r\n\r\n@TabassumJafri @mhpnguyen please review.","created_at":"2016-07-13T19:29:50Z","updated_at":"2016-07-13T19:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"421c776760d0206701e8fa24507182f605edbacc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319/commits","review_comments_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319/comments","review_comment_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1319/comments","statuses_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/statuses/6b109a6c0b7e91b2fb8ba1b25d9a9082b0be6a41","head":{"label":"danielrf123:FHAC-967","ref":"FHAC-967","sha":"6b109a6c0b7e91b2fb8ba1b25d9a9082b0be6a41","user":{"login":"danielrf123","id":16464874,"avatar_url":"https://avatars.githubusercontent.com/u/16464874?v=3","gravatar_id":"","url":"https://api.github.com/users/danielrf123","html_url":"https://github.com/danielrf123","followers_url":"https://api.github.com/users/danielrf123/followers","following_url":"https://api.github.com/users/danielrf123/following{/other_user}","gists_url":"https://api.github.com/users/danielrf123/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrf123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrf123/subscriptions","organizations_url":"https://api.github.com/users/danielrf123/orgs","repos_url":"https://api.github.com/users/danielrf123/repos","events_url":"https://api.github.com/users/danielrf123/events{/privacy}","received_events_url":"https://api.github.com/users/danielrf123/received_events","type":"User","site_admin":false},"repo":{"id":48698295,"name":"CONNECT","full_name":"danielrf123/CONNECT","owner":{"login":"danielrf123","id":16464874,"avatar_url":"https://avatars.githubusercontent.com/u/16464874?v=3","gravatar_id":"","url":"https://api.github.com/users/danielrf123","html_url":"https://github.com/danielrf123","followers_url":"https://api.github.com/users/danielrf123/followers","following_url":"https://api.github.com/users/danielrf123/following{/other_user}","gists_url":"https://api.github.com/users/danielrf123/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrf123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrf123/subscriptions","organizations_url":"https://api.github.com/users/danielrf123/orgs","repos_url":"https://api.github.com/users/danielrf123/repos","events_url":"https://api.github.com/users/danielrf123/events{/privacy}","received_events_url":"https://api.github.com/users/danielrf123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielrf123/CONNECT","description":"CONNECT Codebase (2.x, 3.x, 4.x)","fork":true,"url":"https://api.github.com/repos/danielrf123/CONNECT","forks_url":"https://api.github.com/repos/danielrf123/CONNECT/forks","keys_url":"https://api.github.com/repos/danielrf123/CONNECT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielrf123/CONNECT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielrf123/CONNECT/teams","hooks_url":"https://api.github.com/repos/danielrf123/CONNECT/hooks","issue_events_url":"https://api.github.com/repos/danielrf123/CONNECT/issues/events{/number}","events_url":"https://api.github.com/repos/danielrf123/CONNECT/events","assignees_url":"https://api.github.com/repos/danielrf123/CONNECT/assignees{/user}","branches_url":"https://api.github.com/repos/danielrf123/CONNECT/branches{/branch}","tags_url":"https://api.github.com/repos/danielrf123/CONNECT/tags","blobs_url":"https://api.github.com/repos/danielrf123/CONNECT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielrf123/CONNECT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielrf123/CONNECT/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielrf123/CONNECT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielrf123/CONNECT/statuses/{sha}","languages_url":"https://api.github.com/repos/danielrf123/CONNECT/languages","stargazers_url":"https://api.github.com/repos/danielrf123/CONNECT/stargazers","contributors_url":"https://api.github.com/repos/danielrf123/CONNECT/contributors","subscribers_url":"https://api.github.com/repos/danielrf123/CONNECT/subscribers","subscription_url":"https://api.github.com/repos/danielrf123/CONNECT/subscription","commits_url":"https://api.github.com/repos/danielrf123/CONNECT/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielrf123/CONNECT/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielrf123/CONNECT/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielrf123/CONNECT/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielrf123/CONNECT/contents/{+path}","compare_url":"https://api.github.com/repos/danielrf123/CONNECT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielrf123/CONNECT/merges","archive_url":"https://api.github.com/repos/danielrf123/CONNECT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielrf123/CONNECT/downloads","issues_url":"https://api.github.com/repos/danielrf123/CONNECT/issues{/number}","pulls_url":"https://api.github.com/repos/danielrf123/CONNECT/pulls{/number}","milestones_url":"https://api.github.com/repos/danielrf123/CONNECT/milestones{/number}","notifications_url":"https://api.github.com/repos/danielrf123/CONNECT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielrf123/CONNECT/labels{/name}","releases_url":"https://api.github.com/repos/danielrf123/CONNECT/releases{/id}","deployments_url":"https://api.github.com/repos/danielrf123/CONNECT/deployments","created_at":"2015-12-28T15:16:37Z","updated_at":"2015-12-28T15:16:52Z","pushed_at":"2016-07-13T19:26:40Z","git_url":"git://github.com/danielrf123/CONNECT.git","ssh_url":"git@github.com:danielrf123/CONNECT.git","clone_url":"https://github.com/danielrf123/CONNECT.git","svn_url":"https://github.com/danielrf123/CONNECT","homepage":"http://www.connectopensource.org","size":1925501,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CONNECT_integration"}},"base":{"label":"CONNECT-Solution:CONNECT_integration","ref":"CONNECT_integration","sha":"c95e1611c205fb6f4c7dc66429a3fd211c58ecc8","user":{"login":"CONNECT-Solution","id":1440978,"avatar_url":"https://avatars.githubusercontent.com/u/1440978?v=3","gravatar_id":"","url":"https://api.github.com/users/CONNECT-Solution","html_url":"https://github.com/CONNECT-Solution","followers_url":"https://api.github.com/users/CONNECT-Solution/followers","following_url":"https://api.github.com/users/CONNECT-Solution/following{/other_user}","gists_url":"https://api.github.com/users/CONNECT-Solution/gists{/gist_id}","starred_url":"https://api.github.com/users/CONNECT-Solution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CONNECT-Solution/subscriptions","organizations_url":"https://api.github.com/users/CONNECT-Solution/orgs","repos_url":"https://api.github.com/users/CONNECT-Solution/repos","events_url":"https://api.github.com/users/CONNECT-Solution/events{/privacy}","received_events_url":"https://api.github.com/users/CONNECT-Solution/received_events","type":"Organization","site_admin":false},"repo":{"id":3452904,"name":"CONNECT","full_name":"CONNECT-Solution/CONNECT","owner":{"login":"CONNECT-Solution","id":1440978,"avatar_url":"https://avatars.githubusercontent.com/u/1440978?v=3","gravatar_id":"","url":"https://api.github.com/users/CONNECT-Solution","html_url":"https://github.com/CONNECT-Solution","followers_url":"https://api.github.com/users/CONNECT-Solution/followers","following_url":"https://api.github.com/users/CONNECT-Solution/following{/other_user}","gists_url":"https://api.github.com/users/CONNECT-Solution/gists{/gist_id}","starred_url":"https://api.github.com/users/CONNECT-Solution/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CONNECT-Solution/subscriptions","organizations_url":"https://api.github.com/users/CONNECT-Solution/orgs","repos_url":"https://api.github.com/users/CONNECT-Solution/repos","events_url":"https://api.github.com/users/CONNECT-Solution/events{/privacy}","received_events_url":"https://api.github.com/users/CONNECT-Solution/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CONNECT-Solution/CONNECT","description":"CONNECT Codebase (2.x, 3.x, 4.x)","fork":false,"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT","forks_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/forks","keys_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/teams","hooks_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/hooks","issue_events_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/events{/number}","events_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/events","assignees_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/assignees{/user}","branches_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/branches{/branch}","tags_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/tags","blobs_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/git/refs{/sha}","trees_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/statuses/{sha}","languages_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/languages","stargazers_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/stargazers","contributors_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/contributors","subscribers_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/subscribers","subscription_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/subscription","commits_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/commits{/sha}","git_commits_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/git/commits{/sha}","comments_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/comments{/number}","issue_comment_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/comments{/number}","contents_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/contents/{+path}","compare_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/merges","archive_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/downloads","issues_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues{/number}","pulls_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls{/number}","milestones_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/milestones{/number}","notifications_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/labels{/name}","releases_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/releases{/id}","deployments_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/deployments","created_at":"2012-02-15T19:44:26Z","updated_at":"2016-06-20T14:02:55Z","pushed_at":"2016-07-13T19:29:51Z","git_url":"git://github.com/CONNECT-Solution/CONNECT.git","ssh_url":"git@github.com:CONNECT-Solution/CONNECT.git","clone_url":"https://github.com/CONNECT-Solution/CONNECT.git","svn_url":"https://github.com/CONNECT-Solution/CONNECT","homepage":"http://www.connectopensource.org","size":1938845,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":2,"forks":84,"open_issues":2,"watchers":46,"default_branch":"CONNECT_integration"}},"_links":{"self":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319"},"html":{"href":"https://github.com/CONNECT-Solution/CONNECT/pull/1319"},"issue":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1319"},"comments":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1319/comments"},"review_comments":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319/comments"},"review_comment":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1319/commits"},"statuses":{"href":"https://api.github.com/repos/CONNECT-Solution/CONNECT/statuses/6b109a6c0b7e91b2fb8ba1b25d9a9082b0be6a41"}}}}
{"actor":{"display_login":"mhpnguyen"}}