{"action":"closed","number":630,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630","id":64408522,"html_url":"https://github.com/wikimedia/wikipedia-ios/pull/630","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/630.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/630.patch","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/630","number":630,"state":"closed","locked":false,"title":"handle null case for article history delta","user":{"login":"ndis1","id":2287679,"avatar_url":"https://avatars.githubusercontent.com/u/2287679?v=3","gravatar_id":"","url":"https://api.github.com/users/ndis1","html_url":"https://github.com/ndis1","followers_url":"https://api.github.com/users/ndis1/followers","following_url":"https://api.github.com/users/ndis1/following{/other_user}","gists_url":"https://api.github.com/users/ndis1/gists{/gist_id}","starred_url":"https://api.github.com/users/ndis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndis1/subscriptions","organizations_url":"https://api.github.com/users/ndis1/orgs","repos_url":"https://api.github.com/users/ndis1/repos","events_url":"https://api.github.com/users/ndis1/events{/privacy}","received_events_url":"https://api.github.com/users/ndis1/received_events","type":"User","site_admin":false},"body":"[Ticket: T127373 article history item null delta](https://phabricator.wikimedia.org/T127373)\r\narticle history delta is calculated between two items\r\nwe can't know the delta of the last item unless it is the first item ever created\r\nthis bumps the number of items requested and doesn't show the final item received\r\nunless it is the first in the article history\r\n\r\nIf someone could point me to the preferred pattern for adding tests to these fetchers I'd be happy to add some or update existing.","created_at":"2016-03-29T03:19:24Z","updated_at":"2016-04-02T00:12:40Z","closed_at":"2016-04-02T00:12:40Z","merged_at":"2016-04-02T00:12:40Z","merge_commit_sha":"f9e1483f6148deb92e5e5b030f5458da07a1bc1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630/commits","review_comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630/comments","review_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/630/comments","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/92f0d33ac6ec52195d494fb41c05e82e379a449a","head":{"label":"ndis1:article_history_null_size_change","ref":"article_history_null_size_change","sha":"92f0d33ac6ec52195d494fb41c05e82e379a449a","user":{"login":"ndis1","id":2287679,"avatar_url":"https://avatars.githubusercontent.com/u/2287679?v=3","gravatar_id":"","url":"https://api.github.com/users/ndis1","html_url":"https://github.com/ndis1","followers_url":"https://api.github.com/users/ndis1/followers","following_url":"https://api.github.com/users/ndis1/following{/other_user}","gists_url":"https://api.github.com/users/ndis1/gists{/gist_id}","starred_url":"https://api.github.com/users/ndis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndis1/subscriptions","organizations_url":"https://api.github.com/users/ndis1/orgs","repos_url":"https://api.github.com/users/ndis1/repos","events_url":"https://api.github.com/users/ndis1/events{/privacy}","received_events_url":"https://api.github.com/users/ndis1/received_events","type":"User","site_admin":false},"repo":{"id":54941040,"name":"wikipedia-ios","full_name":"ndis1/wikipedia-ios","owner":{"login":"ndis1","id":2287679,"avatar_url":"https://avatars.githubusercontent.com/u/2287679?v=3","gravatar_id":"","url":"https://api.github.com/users/ndis1","html_url":"https://github.com/ndis1","followers_url":"https://api.github.com/users/ndis1/followers","following_url":"https://api.github.com/users/ndis1/following{/other_user}","gists_url":"https://api.github.com/users/ndis1/gists{/gist_id}","starred_url":"https://api.github.com/users/ndis1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndis1/subscriptions","organizations_url":"https://api.github.com/users/ndis1/orgs","repos_url":"https://api.github.com/users/ndis1/repos","events_url":"https://api.github.com/users/ndis1/events{/privacy}","received_events_url":"https://api.github.com/users/ndis1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndis1/wikipedia-ios","description":"The official Wikipedia iOS app.","fork":true,"url":"https://api.github.com/repos/ndis1/wikipedia-ios","forks_url":"https://api.github.com/repos/ndis1/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/ndis1/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndis1/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndis1/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/ndis1/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/ndis1/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ndis1/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/ndis1/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ndis1/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ndis1/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/ndis1/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndis1/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndis1/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndis1/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndis1/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ndis1/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/ndis1/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/ndis1/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/ndis1/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/ndis1/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/ndis1/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndis1/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndis1/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndis1/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndis1/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ndis1/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndis1/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/ndis1/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndis1/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/ndis1/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ndis1/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ndis1/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ndis1/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndis1/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/ndis1/wikipedia-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ndis1/wikipedia-ios/deployments","created_at":"2016-03-29T02:55:05Z","updated_at":"2016-03-29T02:55:10Z","pushed_at":"2016-04-01T22:22:42Z","git_url":"git://github.com/ndis1/wikipedia-ios.git","ssh_url":"git@github.com:ndis1/wikipedia-ios.git","clone_url":"https://github.com/ndis1/wikipedia-ios.git","svn_url":"https://github.com/ndis1/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":131541,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"wikimedia:develop","ref":"develop","sha":"0c2a0f821eed6235ac5287506f8a6223b4138974","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13863130,"name":"wikipedia-ios","full_name":"wikimedia/wikipedia-ios","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/wikipedia-ios","description":"The official Wikipedia iOS app.","fork":false,"url":"https://api.github.com/repos/wikimedia/wikipedia-ios","forks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/deployments","created_at":"2013-10-25T14:36:56Z","updated_at":"2016-04-01T10:03:35Z","pushed_at":"2016-04-02T00:12:40Z","git_url":"git://github.com/wikimedia/wikipedia-ios.git","ssh_url":"git@github.com:wikimedia/wikipedia-ios.git","clone_url":"https://github.com/wikimedia/wikipedia-ios.git","svn_url":"https://github.com/wikimedia/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":133592,"stargazers_count":691,"watchers_count":691,"language":"Objective-C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":4,"forks":211,"open_issues":4,"watchers":691,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630"},"html":{"href":"https://github.com/wikimedia/wikipedia-ios/pull/630"},"issue":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/630"},"comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/92f0d33ac6ec52195d494fb41c05e82e379a449a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"comments":16,"review_comments":1,"commits":2,"additions":16,"deletions":1,"changed_files":1}}