{"action":"created","comment":{"url":"https://api.github.com/repos/ngageoint/geowave/pulls/comments/55874455","id":55874455,"diff_hunk":"@@ -379,7 +407,27 @@ public static long getSerialversionuid() {\n \t\t\t}\n \t\t}\n \n-\t\tfinal ByteBuffer buf = ByteBuffer.allocate(16 + authBytes.length + aSize + iSize);\n+\t\tint fieldIdsBytesNeeded = 0;\n+\t\tbyte[] fieldIdsBytes = null;\n+\t\tif (fieldIds != null && fieldIds.size() > 0) {\n+\t\t\tfinal StringBuffer sBuf = new StringBuffer();\n+\t\t\tfinal String comma = \",\";\n+\t\t\tfor (String fieldId : fieldIds) {\n+\t\t\t\tif (sBuf.length() > 0) {\n+\t\t\t\t\tsBuf.append(comma);\n+\t\t\t\t}\n+\t\t\t\tsBuf.append(fieldId);\n+\t\t\t}\n+\t\t\tfieldIdsBytes = StringUtils.stringToBinary(sBuf.toString());\n+\t\t\tfieldIdsBytesNeeded = 4 + fieldIdsBytes.length;\n+\t\t}\n+\n+\t\tfinal ByteBuffer buf = ByteBuffer.allocate(20 + authBytes.length + aSize + iSize + fieldIdsBytesNeeded);\n+\t\tbuf.putInt((fieldIdsBytesNeeded > 0) ? 1 : 0);","path":"core/store/src/main/java/mil/nga/giat/geowave/core/store/query/QueryOptions.java","position":83,"original_position":83,"commit_id":"95e6cbe10064e72a5b2e77c33146a0879bc55dac","original_commit_id":"95e6cbe10064e72a5b2e77c33146a0879bc55dac","user":{"login":"rwgdrummer","id":6342425,"avatar_url":"https://avatars.githubusercontent.com/u/6342425?v=3","gravatar_id":"","url":"https://api.github.com/users/rwgdrummer","html_url":"https://github.com/rwgdrummer","followers_url":"https://api.github.com/users/rwgdrummer/followers","following_url":"https://api.github.com/users/rwgdrummer/following{/other_user}","gists_url":"https://api.github.com/users/rwgdrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/rwgdrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwgdrummer/subscriptions","organizations_url":"https://api.github.com/users/rwgdrummer/orgs","repos_url":"https://api.github.com/users/rwgdrummer/repos","events_url":"https://api.github.com/users/rwgdrummer/events{/privacy}","received_events_url":"https://api.github.com/users/rwgdrummer/received_events","type":"User","site_admin":false},"body":"Do we need the extra int, or can we just place a 0 if the field id list is emty?","created_at":"2016-03-11T19:16:27Z","updated_at":"2016-03-11T19:16:27Z","html_url":"https://github.com/ngageoint/geowave/pull/663#discussion_r55874455","pull_request_url":"https://api.github.com/repos/ngageoint/geowave/pulls/663","_links":{"self":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/comments/55874455"},"html":{"href":"https://github.com/ngageoint/geowave/pull/663#discussion_r55874455"},"pull_request":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/663"}}},"pull_request":{"url":"https://api.github.com/repos/ngageoint/geowave/pulls/663","id":62546942,"html_url":"https://github.com/ngageoint/geowave/pull/663","diff_url":"https://github.com/ngageoint/geowave/pull/663.diff","patch_url":"https://github.com/ngageoint/geowave/pull/663.patch","issue_url":"https://api.github.com/repos/ngageoint/geowave/issues/663","number":663,"state":"open","locked":false,"title":"Geowave 615","user":{"login":"dcy2003","id":408950,"avatar_url":"https://avatars.githubusercontent.com/u/408950?v=3","gravatar_id":"","url":"https://api.github.com/users/dcy2003","html_url":"https://github.com/dcy2003","followers_url":"https://api.github.com/users/dcy2003/followers","following_url":"https://api.github.com/users/dcy2003/following{/other_user}","gists_url":"https://api.github.com/users/dcy2003/gists{/gist_id}","starred_url":"https://api.github.com/users/dcy2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcy2003/subscriptions","organizations_url":"https://api.github.com/users/dcy2003/orgs","repos_url":"https://api.github.com/users/dcy2003/repos","events_url":"https://api.github.com/users/dcy2003/events{/privacy}","received_events_url":"https://api.github.com/users/dcy2003/received_events","type":"User","site_admin":false},"body":"Fix for #615\r\n\r\nSharedVisibilitySplittingIterator decomposes composite fieldIds on the tablet server, which replaces the old approach of doing this twice (once client side in AccumuloUtils and also in QueryFilterIterator)\r\n\r\nFieldFilter filters only those fieldIds that were specified in QueryOptions\r\n\r\nAttributesSubsetQueryIT tests both server side and client side filtering functionality\r\n\r\nWe also support subsetting through GeoTools Query via propertyNames.  GeoToolsAttributesSubsetTest verifies this functionality","created_at":"2016-03-11T14:04:58Z","updated_at":"2016-03-11T19:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9934e00370bbe98816191f12f5338b89ac31ea6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ngageoint/geowave/pulls/663/commits","review_comments_url":"https://api.github.com/repos/ngageoint/geowave/pulls/663/comments","review_comment_url":"https://api.github.com/repos/ngageoint/geowave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ngageoint/geowave/issues/663/comments","statuses_url":"https://api.github.com/repos/ngageoint/geowave/statuses/95e6cbe10064e72a5b2e77c33146a0879bc55dac","head":{"label":"ngageoint:GEOWAVE-615","ref":"GEOWAVE-615","sha":"95e6cbe10064e72a5b2e77c33146a0879bc55dac","user":{"login":"ngageoint","id":7175944,"avatar_url":"https://avatars.githubusercontent.com/u/7175944?v=3","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"repo":{"id":20448696,"name":"geowave","full_name":"ngageoint/geowave","owner":{"login":"ngageoint","id":7175944,"avatar_url":"https://avatars.githubusercontent.com/u/7175944?v=3","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngageoint/geowave","description":"GeoWave provides geospatial and temporal indexing on top of Accumulo","fork":false,"url":"https://api.github.com/repos/ngageoint/geowave","forks_url":"https://api.github.com/repos/ngageoint/geowave/forks","keys_url":"https://api.github.com/repos/ngageoint/geowave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngageoint/geowave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngageoint/geowave/teams","hooks_url":"https://api.github.com/repos/ngageoint/geowave/hooks","issue_events_url":"https://api.github.com/repos/ngageoint/geowave/issues/events{/number}","events_url":"https://api.github.com/repos/ngageoint/geowave/events","assignees_url":"https://api.github.com/repos/ngageoint/geowave/assignees{/user}","branches_url":"https://api.github.com/repos/ngageoint/geowave/branches{/branch}","tags_url":"https://api.github.com/repos/ngageoint/geowave/tags","blobs_url":"https://api.github.com/repos/ngageoint/geowave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngageoint/geowave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngageoint/geowave/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngageoint/geowave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngageoint/geowave/statuses/{sha}","languages_url":"https://api.github.com/repos/ngageoint/geowave/languages","stargazers_url":"https://api.github.com/repos/ngageoint/geowave/stargazers","contributors_url":"https://api.github.com/repos/ngageoint/geowave/contributors","subscribers_url":"https://api.github.com/repos/ngageoint/geowave/subscribers","subscription_url":"https://api.github.com/repos/ngageoint/geowave/subscription","commits_url":"https://api.github.com/repos/ngageoint/geowave/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngageoint/geowave/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngageoint/geowave/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngageoint/geowave/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngageoint/geowave/contents/{+path}","compare_url":"https://api.github.com/repos/ngageoint/geowave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngageoint/geowave/merges","archive_url":"https://api.github.com/repos/ngageoint/geowave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngageoint/geowave/downloads","issues_url":"https://api.github.com/repos/ngageoint/geowave/issues{/number}","pulls_url":"https://api.github.com/repos/ngageoint/geowave/pulls{/number}","milestones_url":"https://api.github.com/repos/ngageoint/geowave/milestones{/number}","notifications_url":"https://api.github.com/repos/ngageoint/geowave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngageoint/geowave/labels{/name}","releases_url":"https://api.github.com/repos/ngageoint/geowave/releases{/id}","deployments_url":"https://api.github.com/repos/ngageoint/geowave/deployments","created_at":"2014-06-03T15:39:29Z","updated_at":"2016-03-04T00:41:44Z","pushed_at":"2016-03-11T14:04:58Z","git_url":"git://github.com/ngageoint/geowave.git","ssh_url":"git@github.com:ngageoint/geowave.git","clone_url":"https://github.com/ngageoint/geowave.git","svn_url":"https://github.com/ngageoint/geowave","homepage":null,"size":766875,"stargazers_count":110,"watchers_count":110,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":102,"forks":42,"open_issues":102,"watchers":110,"default_branch":"master"}},"base":{"label":"ngageoint:0.9.1","ref":"0.9.1","sha":"2c8449acdb1be018eea89836178e46bf11f1c424","user":{"login":"ngageoint","id":7175944,"avatar_url":"https://avatars.githubusercontent.com/u/7175944?v=3","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"repo":{"id":20448696,"name":"geowave","full_name":"ngageoint/geowave","owner":{"login":"ngageoint","id":7175944,"avatar_url":"https://avatars.githubusercontent.com/u/7175944?v=3","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngageoint/geowave","description":"GeoWave provides geospatial and temporal indexing on top of Accumulo","fork":false,"url":"https://api.github.com/repos/ngageoint/geowave","forks_url":"https://api.github.com/repos/ngageoint/geowave/forks","keys_url":"https://api.github.com/repos/ngageoint/geowave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngageoint/geowave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngageoint/geowave/teams","hooks_url":"https://api.github.com/repos/ngageoint/geowave/hooks","issue_events_url":"https://api.github.com/repos/ngageoint/geowave/issues/events{/number}","events_url":"https://api.github.com/repos/ngageoint/geowave/events","assignees_url":"https://api.github.com/repos/ngageoint/geowave/assignees{/user}","branches_url":"https://api.github.com/repos/ngageoint/geowave/branches{/branch}","tags_url":"https://api.github.com/repos/ngageoint/geowave/tags","blobs_url":"https://api.github.com/repos/ngageoint/geowave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngageoint/geowave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngageoint/geowave/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngageoint/geowave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngageoint/geowave/statuses/{sha}","languages_url":"https://api.github.com/repos/ngageoint/geowave/languages","stargazers_url":"https://api.github.com/repos/ngageoint/geowave/stargazers","contributors_url":"https://api.github.com/repos/ngageoint/geowave/contributors","subscribers_url":"https://api.github.com/repos/ngageoint/geowave/subscribers","subscription_url":"https://api.github.com/repos/ngageoint/geowave/subscription","commits_url":"https://api.github.com/repos/ngageoint/geowave/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngageoint/geowave/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngageoint/geowave/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngageoint/geowave/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngageoint/geowave/contents/{+path}","compare_url":"https://api.github.com/repos/ngageoint/geowave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngageoint/geowave/merges","archive_url":"https://api.github.com/repos/ngageoint/geowave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngageoint/geowave/downloads","issues_url":"https://api.github.com/repos/ngageoint/geowave/issues{/number}","pulls_url":"https://api.github.com/repos/ngageoint/geowave/pulls{/number}","milestones_url":"https://api.github.com/repos/ngageoint/geowave/milestones{/number}","notifications_url":"https://api.github.com/repos/ngageoint/geowave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngageoint/geowave/labels{/name}","releases_url":"https://api.github.com/repos/ngageoint/geowave/releases{/id}","deployments_url":"https://api.github.com/repos/ngageoint/geowave/deployments","created_at":"2014-06-03T15:39:29Z","updated_at":"2016-03-04T00:41:44Z","pushed_at":"2016-03-11T14:04:58Z","git_url":"git://github.com/ngageoint/geowave.git","ssh_url":"git@github.com:ngageoint/geowave.git","clone_url":"https://github.com/ngageoint/geowave.git","svn_url":"https://github.com/ngageoint/geowave","homepage":null,"size":766875,"stargazers_count":110,"watchers_count":110,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":102,"forks":42,"open_issues":102,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/663"},"html":{"href":"https://github.com/ngageoint/geowave/pull/663"},"issue":{"href":"https://api.github.com/repos/ngageoint/geowave/issues/663"},"comments":{"href":"https://api.github.com/repos/ngageoint/geowave/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ngageoint/geowave/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/ngageoint/geowave/statuses/95e6cbe10064e72a5b2e77c33146a0879bc55dac"}}}}