{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/56329414","id":56329414,"diff_hunk":"@@ -558,7 +559,13 @@ func (c *MasterConfig) InstallUnprotectedAPI(container *restful.Container) ([]st\n \n // initAPIVersionRoute initializes the osapi endpoint to behave similar to the upstream api endpoint\n func initAPIVersionRoute(root *restful.WebService, prefix string, versions ...string) {\n-\tversionHandler := apiserver.APIVersionHandler(kapi.Codecs, versions...)\n+\tversionHandler := apiserver.APIVersionHandler(kapi.Codecs, func(req *restful.Request) *unversioned.APIVersions {\n+\t\tapiVersionsForDiscovery := unversioned.APIVersions{\n+\t\t\t// TODO: ServerAddressByClientCIDRs: s.getServerAddressByClientCIDRs(req.Request),","path":"pkg/cmd/server/origin/master.go","position":null,"original_position":30,"commit_id":"fe9b2bfb514dafd63f054f0f40d55dc34f24aece","original_commit_id":"6401e0e510ff9c48b250a7d23444f768dc7be254","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"Already on the follow up list\n\nOn Wed, Mar 16, 2016 at 8:04 AM, David Eads <notifications@github.com>\nwrote:\n\n> In pkg/cmd/server/origin/master.go\n> <https://github.com/openshift/origin/pull/7975#discussion_r56321878>:\n>\n> > @@ -558,7 +559,13 @@ func (c *MasterConfig) InstallUnprotectedAPI(container *restful.Container) ([]st\n> >\n> >  // initAPIVersionRoute initializes the osapi endpoint to behave similar to the upstream api endpoint\n> >  func initAPIVersionRoute(root *restful.WebService, prefix string, versions ...string) {\n> > -\tversionHandler := apiserver.APIVersionHandler(kapi.Codecs, versions...)\n> > +\tversionHandler := apiserver.APIVersionHandler(kapi.Codecs, func(req *restful.Request) *unversioned.APIVersions {\n> > +\t\tapiVersionsForDiscovery := unversioned.APIVersions{\n> > +\t\t\t// TODO: ServerAddressByClientCIDRs: s.getServerAddressByClientCIDRs(req.Request),\n>\n> Seems like something we'll want. Followup issue?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openshift/origin/pull/7975/files/9ad61a43602f99e9be4d2504b48a13352980ea49..6401e0e510ff9c48b250a7d23444f768dc7be254#r56321878>\n>\n","created_at":"2016-03-16T13:09:08Z","updated_at":"2016-03-16T13:09:08Z","html_url":"https://github.com/openshift/origin/pull/7975#discussion_r56329414","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/7975","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/56329414"},"html":{"href":"https://github.com/openshift/origin/pull/7975#discussion_r56329414"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/7975"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7975","id":62661381,"html_url":"https://github.com/openshift/origin/pull/7975","diff_url":"https://github.com/openshift/origin/pull/7975.diff","patch_url":"https://github.com/openshift/origin/pull/7975.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/7975","number":7975,"state":"open","locked":false,"title":"rebase onto v1.2.0-beta.1","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"- [x] Rebase https://github.com/openshift/kubernetes/tree/stable-20160309 onto https://github.com/kubernetes/kubernetes/tree/v1.2.0-beta.1 (see https://github.com/openshift/kubernetes/tree/release-1.2-stable-20160312)\r\n- [x] Bump k8s.io/kubernetes Godep to https://github.com/openshift/kubernetes/commit/148dd34ab0e7daeb82582d6ea8e840c15a24e745\r\n- [x] Origin build\r\n- [x] unit tests\r\n- [x] test-cmd\r\n- [x] integration tests\r\n- [x] e2e\r\n- [x] check open ports\r\n- [x] review policy changes for autoscaling and batch API groups\r\n- [x] Rework dropped commits:\r\n  - [x] 378f6f1f1e23c61d5ed4321b0ff7241ccc111867 `UPSTREAM: <carry>: Keep default generator for run 'run-pod/v1'` - replace with oc-specific overrides\r\n  - [x] 055d8eccf9942063113b174b98535f82618327db `UPSTREAM: 12221: Allow custom namespace creation in e2e framework` - replaced by 20808 upstream\r\n  - [x] e4d9fb6906dbef5a069e5f45ee64a49d20418c2e `UPSTREAM: 20706: register internal types with scheme for reference unit test` - replaced with conditional re-register\r\n- [x] `should KubeletCgroups and SystemCgroups also be set to \"\"?`\r\n- [x] `right default for defaultReplenishmentSyncPeriod?`\r\n- [x] p1: resolve policy reconcile for discovery with namespace controller (discovery rules live in the StatusChecker role which isn't autoreconciled on startup)\r\n- [ ] extended tests (current status against master: https://github.com/openshift/origin/issues/6882#issuecomment-194487536)\r\n\r\nFollow-ups:\r\n- [ ] p1: Allow storage versions for API groups to be configurable (see upstream)\r\n- [ ] p1: Set up cross-encoding storage? (see upstream... not sure why this is needed)\r\n- [ ] p1: sweep upstream config/initialization to make sure we match\r\n  - [ ] kube-apiserver\r\n  - [ ] kubelet\r\n  - [ ] kube-proxy\r\n  - [ ] kube-controllermanager\r\n- [ ] p2: update callers to handle partial success from reconcile-cluster-role-bindings\r\n- [ ] p2: determine a preferred GVK to pass to `InfoForObject` in bulk create?\r\n- [ ] p2: `ServerAddressByClientCIDRs: s.getServerAddressByClientCIDRs(req.Request) in discovery doc`\r\n- [ ] p2: Enable client generation for our types\r\n- [ ] p2: Start using genericapiserver framework\r\n- [ ] p2: Sweep for use of kapi.RestMapper\r\n- [ ] p2: Start using the generic namespace controller\r\n- [ ] p3: remove authorizationapi groups\r\n- [ ] p3: improve factoring of volume config upstream to allow passing volume config through (c.f. https://github.com/liggitt/origin/commit/5e9855e1768e84f48a03b7a4e5a7e76a8c471c6f#commitcomment-16705544)\r\n- [ ] p3: upstream issue for job/hpa/daemonset/replicaset controllers to use discovery, support batch/autoscaling API calls if extensions is disabled","created_at":"2016-03-13T04:22:45Z","updated_at":"2016-03-16T13:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c86aceab1a997cb99c8e3221d53f2c7a399f1cbe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/7975/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/7975/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7975/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/fe9b2bfb514dafd63f054f0f40d55dc34f24aece","head":{"label":"liggitt:rebase-20160312","ref":"rebase-20160312","sha":"fe9b2bfb514dafd63f054f0f40d55dc34f24aece","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"repo":{"id":23198153,"name":"origin","full_name":"liggitt/origin","owner":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liggitt/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/liggitt/origin","forks_url":"https://api.github.com/repos/liggitt/origin/forks","keys_url":"https://api.github.com/repos/liggitt/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liggitt/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liggitt/origin/teams","hooks_url":"https://api.github.com/repos/liggitt/origin/hooks","issue_events_url":"https://api.github.com/repos/liggitt/origin/issues/events{/number}","events_url":"https://api.github.com/repos/liggitt/origin/events","assignees_url":"https://api.github.com/repos/liggitt/origin/assignees{/user}","branches_url":"https://api.github.com/repos/liggitt/origin/branches{/branch}","tags_url":"https://api.github.com/repos/liggitt/origin/tags","blobs_url":"https://api.github.com/repos/liggitt/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liggitt/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liggitt/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/liggitt/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liggitt/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/liggitt/origin/languages","stargazers_url":"https://api.github.com/repos/liggitt/origin/stargazers","contributors_url":"https://api.github.com/repos/liggitt/origin/contributors","subscribers_url":"https://api.github.com/repos/liggitt/origin/subscribers","subscription_url":"https://api.github.com/repos/liggitt/origin/subscription","commits_url":"https://api.github.com/repos/liggitt/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/liggitt/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/liggitt/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/liggitt/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/liggitt/origin/contents/{+path}","compare_url":"https://api.github.com/repos/liggitt/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liggitt/origin/merges","archive_url":"https://api.github.com/repos/liggitt/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liggitt/origin/downloads","issues_url":"https://api.github.com/repos/liggitt/origin/issues{/number}","pulls_url":"https://api.github.com/repos/liggitt/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/liggitt/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/liggitt/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liggitt/origin/labels{/name}","releases_url":"https://api.github.com/repos/liggitt/origin/releases{/id}","deployments_url":"https://api.github.com/repos/liggitt/origin/deployments","created_at":"2014-08-21T18:23:05Z","updated_at":"2016-01-11T15:42:07Z","pushed_at":"2016-03-16T13:01:55Z","git_url":"git://github.com/liggitt/origin.git","ssh_url":"git@github.com:liggitt/origin.git","clone_url":"https://github.com/liggitt/origin.git","svn_url":"https://github.com/liggitt/origin","homepage":"https://openshift.github.io","size":250525,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7e38050cd0e974a64153df0d17b19a800cdc4204","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-03-16T00:49:13Z","pushed_at":"2016-03-16T13:05:14Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":289394,"stargazers_count":1127,"watchers_count":1127,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":697,"mirror_url":null,"open_issues_count":947,"forks":697,"open_issues":947,"watchers":1127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/7975"},"html":{"href":"https://github.com/openshift/origin/pull/7975"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/7975"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/7975/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/7975/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/7975/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/fe9b2bfb514dafd63f054f0f40d55dc34f24aece"}}}}