{"action":"created","comment":{"url":"https://api.github.com/repos/gimli-rs/gimli/pulls/comments/83533636","pull_request_review_id":4373580,"id":83533636,"diff_hunk":"@@ -771,6 +787,16 @@ impl<'input, Endian> Operation<'input, Endian>\n                 Ok((newbytes, Operation::ImplicitValue { data: data.into() }))\n             }\n             constants::DW_OP_stack_value => Ok((bytes, Operation::StackValue)),\n+            constants::DW_OP_implicit_pointer |\n+            constants::DW_OP_GNU_implicit_pointer => {\n+                let (newbytes, value) = try!(parse_offset(bytes, format));\n+                let (newbytes, byte_offset) = try!(parse_signed_lebe(newbytes));\n+                Ok((newbytes,\n+                    Operation::ImplicitPointer {\n+                    value: DebugInfoOffset(value),","path":"src/op.rs","position":null,"original_position":40,"commit_id":"2b6b70f50f21e9a90fd0d5993197ff229113c349","original_commit_id":"3381068922aef257535783611f3da633f0f88925","user":{"login":"tromey","id":1557670,"avatar_url":"https://avatars.githubusercontent.com/u/1557670?v=3","gravatar_id":"","url":"https://api.github.com/users/tromey","html_url":"https://github.com/tromey","followers_url":"https://api.github.com/users/tromey/followers","following_url":"https://api.github.com/users/tromey/following{/other_user}","gists_url":"https://api.github.com/users/tromey/gists{/gist_id}","starred_url":"https://api.github.com/users/tromey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tromey/subscriptions","organizations_url":"https://api.github.com/users/tromey/orgs","repos_url":"https://api.github.com/users/tromey/repos","events_url":"https://api.github.com/users/tromey/events{/privacy}","received_events_url":"https://api.github.com/users/tromey/received_events","type":"User","site_admin":false},"body":"The indentation looks off here but I can't tell if that is github or just needing rustfmt.","created_at":"2016-10-15T14:56:54Z","updated_at":"2016-10-15T14:58:48Z","html_url":"https://github.com/gimli-rs/gimli/pull/150#discussion_r83533636","pull_request_url":"https://api.github.com/repos/gimli-rs/gimli/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/comments/83533636"},"html":{"href":"https://github.com/gimli-rs/gimli/pull/150#discussion_r83533636"},"pull_request":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/gimli-rs/gimli/pulls/150","id":89480621,"html_url":"https://github.com/gimli-rs/gimli/pull/150","diff_url":"https://github.com/gimli-rs/gimli/pull/150.diff","patch_url":"https://github.com/gimli-rs/gimli/pull/150.patch","issue_url":"https://api.github.com/repos/gimli-rs/gimli/issues/150","number":150,"state":"open","locked":false,"title":"Implement DW_OP_implicit_pointer and DW_OP_entry_value","user":{"login":"philipc","id":330342,"avatar_url":"https://avatars.githubusercontent.com/u/330342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipc","html_url":"https://github.com/philipc","followers_url":"https://api.github.com/users/philipc/followers","following_url":"https://api.github.com/users/philipc/following{/other_user}","gists_url":"https://api.github.com/users/philipc/gists{/gist_id}","starred_url":"https://api.github.com/users/philipc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipc/subscriptions","organizations_url":"https://api.github.com/users/philipc/orgs","repos_url":"https://api.github.com/users/philipc/repos","events_url":"https://api.github.com/users/philipc/events{/privacy}","received_events_url":"https://api.github.com/users/philipc/received_events","type":"User","site_admin":false},"body":"- move op.rs tests into submodule\r\n- convert operation parsing tests to use `test_assembler`\r\n- implement DW_OP_implicit_pointer and DW_OP_entry_value\r\n\r\nThe implementation for the new operations is minimal: it offloads all the real work to the caller. We probably want to add more support in future to make it easier for users to handle these though.\r\n\r\nI didn't convert the operation evaluation tests to use `test_assembler` because @tromey had already written some code that does basically the same thing, so there wouldn't be much benefit to doing so (other than consistency).","created_at":"2016-10-15T03:53:15Z","updated_at":"2016-10-15T14:58:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a9dfbbf0ae0bc56eabd5433a73c9f583873a307","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gimli-rs/gimli/pulls/150/commits","review_comments_url":"https://api.github.com/repos/gimli-rs/gimli/pulls/150/comments","review_comment_url":"https://api.github.com/repos/gimli-rs/gimli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gimli-rs/gimli/issues/150/comments","statuses_url":"https://api.github.com/repos/gimli-rs/gimli/statuses/2b6b70f50f21e9a90fd0d5993197ff229113c349","head":{"label":"philipc:op","ref":"op","sha":"2b6b70f50f21e9a90fd0d5993197ff229113c349","user":{"login":"philipc","id":330342,"avatar_url":"https://avatars.githubusercontent.com/u/330342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipc","html_url":"https://github.com/philipc","followers_url":"https://api.github.com/users/philipc/followers","following_url":"https://api.github.com/users/philipc/following{/other_user}","gists_url":"https://api.github.com/users/philipc/gists{/gist_id}","starred_url":"https://api.github.com/users/philipc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipc/subscriptions","organizations_url":"https://api.github.com/users/philipc/orgs","repos_url":"https://api.github.com/users/philipc/repos","events_url":"https://api.github.com/users/philipc/events{/privacy}","received_events_url":"https://api.github.com/users/philipc/received_events","type":"User","site_admin":false},"repo":{"id":67472930,"name":"gimli","full_name":"philipc/gimli","owner":{"login":"philipc","id":330342,"avatar_url":"https://avatars.githubusercontent.com/u/330342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipc","html_url":"https://github.com/philipc","followers_url":"https://api.github.com/users/philipc/followers","following_url":"https://api.github.com/users/philipc/following{/other_user}","gists_url":"https://api.github.com/users/philipc/gists{/gist_id}","starred_url":"https://api.github.com/users/philipc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipc/subscriptions","organizations_url":"https://api.github.com/users/philipc/orgs","repos_url":"https://api.github.com/users/philipc/repos","events_url":"https://api.github.com/users/philipc/events{/privacy}","received_events_url":"https://api.github.com/users/philipc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philipc/gimli","description":"A lazy, zero-copy parser for the DWARF debugging format.","fork":true,"url":"https://api.github.com/repos/philipc/gimli","forks_url":"https://api.github.com/repos/philipc/gimli/forks","keys_url":"https://api.github.com/repos/philipc/gimli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philipc/gimli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philipc/gimli/teams","hooks_url":"https://api.github.com/repos/philipc/gimli/hooks","issue_events_url":"https://api.github.com/repos/philipc/gimli/issues/events{/number}","events_url":"https://api.github.com/repos/philipc/gimli/events","assignees_url":"https://api.github.com/repos/philipc/gimli/assignees{/user}","branches_url":"https://api.github.com/repos/philipc/gimli/branches{/branch}","tags_url":"https://api.github.com/repos/philipc/gimli/tags","blobs_url":"https://api.github.com/repos/philipc/gimli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philipc/gimli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philipc/gimli/git/refs{/sha}","trees_url":"https://api.github.com/repos/philipc/gimli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philipc/gimli/statuses/{sha}","languages_url":"https://api.github.com/repos/philipc/gimli/languages","stargazers_url":"https://api.github.com/repos/philipc/gimli/stargazers","contributors_url":"https://api.github.com/repos/philipc/gimli/contributors","subscribers_url":"https://api.github.com/repos/philipc/gimli/subscribers","subscription_url":"https://api.github.com/repos/philipc/gimli/subscription","commits_url":"https://api.github.com/repos/philipc/gimli/commits{/sha}","git_commits_url":"https://api.github.com/repos/philipc/gimli/git/commits{/sha}","comments_url":"https://api.github.com/repos/philipc/gimli/comments{/number}","issue_comment_url":"https://api.github.com/repos/philipc/gimli/issues/comments{/number}","contents_url":"https://api.github.com/repos/philipc/gimli/contents/{+path}","compare_url":"https://api.github.com/repos/philipc/gimli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philipc/gimli/merges","archive_url":"https://api.github.com/repos/philipc/gimli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philipc/gimli/downloads","issues_url":"https://api.github.com/repos/philipc/gimli/issues{/number}","pulls_url":"https://api.github.com/repos/philipc/gimli/pulls{/number}","milestones_url":"https://api.github.com/repos/philipc/gimli/milestones{/number}","notifications_url":"https://api.github.com/repos/philipc/gimli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philipc/gimli/labels{/name}","releases_url":"https://api.github.com/repos/philipc/gimli/releases{/id}","deployments_url":"https://api.github.com/repos/philipc/gimli/deployments","created_at":"2016-09-06T04:20:43Z","updated_at":"2016-09-06T04:20:45Z","pushed_at":"2016-10-15T03:45:10Z","git_url":"git://github.com/philipc/gimli.git","ssh_url":"git@github.com:philipc/gimli.git","clone_url":"https://github.com/philipc/gimli.git","svn_url":"https://github.com/philipc/gimli","homepage":"http://gimli-rs.github.io/gimli/gimli/index.html","size":2243,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gimli-rs:master","ref":"master","sha":"c7399c0ae78f858ce58f32bdf93bad8eabf8a248","user":{"login":"gimli-rs","id":21131604,"avatar_url":"https://avatars.githubusercontent.com/u/21131604?v=3","gravatar_id":"","url":"https://api.github.com/users/gimli-rs","html_url":"https://github.com/gimli-rs","followers_url":"https://api.github.com/users/gimli-rs/followers","following_url":"https://api.github.com/users/gimli-rs/following{/other_user}","gists_url":"https://api.github.com/users/gimli-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gimli-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gimli-rs/subscriptions","organizations_url":"https://api.github.com/users/gimli-rs/orgs","repos_url":"https://api.github.com/users/gimli-rs/repos","events_url":"https://api.github.com/users/gimli-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gimli-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":61165669,"name":"gimli","full_name":"gimli-rs/gimli","owner":{"login":"gimli-rs","id":21131604,"avatar_url":"https://avatars.githubusercontent.com/u/21131604?v=3","gravatar_id":"","url":"https://api.github.com/users/gimli-rs","html_url":"https://github.com/gimli-rs","followers_url":"https://api.github.com/users/gimli-rs/followers","following_url":"https://api.github.com/users/gimli-rs/following{/other_user}","gists_url":"https://api.github.com/users/gimli-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gimli-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gimli-rs/subscriptions","organizations_url":"https://api.github.com/users/gimli-rs/orgs","repos_url":"https://api.github.com/users/gimli-rs/repos","events_url":"https://api.github.com/users/gimli-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gimli-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gimli-rs/gimli","description":"A lazy, zero-copy parser for the DWARF debugging format.","fork":false,"url":"https://api.github.com/repos/gimli-rs/gimli","forks_url":"https://api.github.com/repos/gimli-rs/gimli/forks","keys_url":"https://api.github.com/repos/gimli-rs/gimli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gimli-rs/gimli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gimli-rs/gimli/teams","hooks_url":"https://api.github.com/repos/gimli-rs/gimli/hooks","issue_events_url":"https://api.github.com/repos/gimli-rs/gimli/issues/events{/number}","events_url":"https://api.github.com/repos/gimli-rs/gimli/events","assignees_url":"https://api.github.com/repos/gimli-rs/gimli/assignees{/user}","branches_url":"https://api.github.com/repos/gimli-rs/gimli/branches{/branch}","tags_url":"https://api.github.com/repos/gimli-rs/gimli/tags","blobs_url":"https://api.github.com/repos/gimli-rs/gimli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gimli-rs/gimli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gimli-rs/gimli/git/refs{/sha}","trees_url":"https://api.github.com/repos/gimli-rs/gimli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gimli-rs/gimli/statuses/{sha}","languages_url":"https://api.github.com/repos/gimli-rs/gimli/languages","stargazers_url":"https://api.github.com/repos/gimli-rs/gimli/stargazers","contributors_url":"https://api.github.com/repos/gimli-rs/gimli/contributors","subscribers_url":"https://api.github.com/repos/gimli-rs/gimli/subscribers","subscription_url":"https://api.github.com/repos/gimli-rs/gimli/subscription","commits_url":"https://api.github.com/repos/gimli-rs/gimli/commits{/sha}","git_commits_url":"https://api.github.com/repos/gimli-rs/gimli/git/commits{/sha}","comments_url":"https://api.github.com/repos/gimli-rs/gimli/comments{/number}","issue_comment_url":"https://api.github.com/repos/gimli-rs/gimli/issues/comments{/number}","contents_url":"https://api.github.com/repos/gimli-rs/gimli/contents/{+path}","compare_url":"https://api.github.com/repos/gimli-rs/gimli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gimli-rs/gimli/merges","archive_url":"https://api.github.com/repos/gimli-rs/gimli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gimli-rs/gimli/downloads","issues_url":"https://api.github.com/repos/gimli-rs/gimli/issues{/number}","pulls_url":"https://api.github.com/repos/gimli-rs/gimli/pulls{/number}","milestones_url":"https://api.github.com/repos/gimli-rs/gimli/milestones{/number}","notifications_url":"https://api.github.com/repos/gimli-rs/gimli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gimli-rs/gimli/labels{/name}","releases_url":"https://api.github.com/repos/gimli-rs/gimli/releases{/id}","deployments_url":"https://api.github.com/repos/gimli-rs/gimli/deployments","created_at":"2016-06-15T00:39:04Z","updated_at":"2016-10-08T01:41:24Z","pushed_at":"2016-10-15T03:53:15Z","git_url":"git://github.com/gimli-rs/gimli.git","ssh_url":"git@github.com:gimli-rs/gimli.git","clone_url":"https://github.com/gimli-rs/gimli.git","svn_url":"https://github.com/gimli-rs/gimli","homepage":"http://gimli-rs.github.io/gimli/gimli/index.html","size":2438,"stargazers_count":41,"watchers_count":41,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":29,"forks":11,"open_issues":29,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/150"},"html":{"href":"https://github.com/gimli-rs/gimli/pull/150"},"issue":{"href":"https://api.github.com/repos/gimli-rs/gimli/issues/150"},"comments":{"href":"https://api.github.com/repos/gimli-rs/gimli/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gimli-rs/gimli/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/gimli-rs/gimli/statuses/2b6b70f50f21e9a90fd0d5993197ff229113c349"}}}}
{"actor":{"display_login":"tromey"}}