{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/13819","repository_url":"https://api.github.com/repos/laravel/framework","labels_url":"https://api.github.com/repos/laravel/framework/issues/13819/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/13819/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/13819/events","html_url":"https://github.com/laravel/framework/pull/13819","id":157956388,"number":13819,"title":"[5.3] Adding Redis support for new Broadcast Support Provider","user":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-01T16:54:49Z","updated_at":"2016-06-01T20:43:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/13819","html_url":"https://github.com/laravel/framework/pull/13819","diff_url":"https://github.com/laravel/framework/pull/13819.diff","patch_url":"https://github.com/laravel/framework/pull/13819.patch"},"body":"Squashed commits:\r\n[d8cc1ee] Forgot to add json_encode to return a string.\r\n[5ef6fce] Fixed docs.\r\n[1ac510e] Style fix.\r\n[a5fba3a] Removed parent construct from broadcasters.\r\n[b7047c8] Updates.\r\n[22900c1] Style fixes.\r\n[ddf4ba4] Added an abstract class for Broadcasters.\r\n[1c23e53] Updated Broadcast Manager to cache a socket_id as \"broadcast:socket...\" instead of \"pusher:socket...\"\r\n[180934c] Updated the validAuthenticationResponse method to send back data as \"channel_data\"\r\n[0712630] Update RedisBroadcaster.php\r\n\r\nAdded support for `$this->dontBroadcastToCurrentUser();`\r\n\r\nWith the addition of the socket_id in the payload, socket.io can broadcast the event as the requesting user.\r\n[6e43303] Code style updates\r\n[237cacd] Adding support for new Broadcast Support Provider"},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/223118647","html_url":"https://github.com/laravel/framework/pull/13819#issuecomment-223118647","issue_url":"https://api.github.com/repos/laravel/framework/issues/13819","id":223118647,"user":{"login":"tlaverdure","id":1731025,"avatar_url":"https://avatars.githubusercontent.com/u/1731025?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaverdure","html_url":"https://github.com/tlaverdure","followers_url":"https://api.github.com/users/tlaverdure/followers","following_url":"https://api.github.com/users/tlaverdure/following{/other_user}","gists_url":"https://api.github.com/users/tlaverdure/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaverdure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaverdure/subscriptions","organizations_url":"https://api.github.com/users/tlaverdure/orgs","repos_url":"https://api.github.com/users/tlaverdure/repos","events_url":"https://api.github.com/users/tlaverdure/events{/privacy}","received_events_url":"https://api.github.com/users/tlaverdure/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T20:43:41Z","updated_at":"2016-06-01T20:43:41Z","body":"This PR is only focused on using the Broadcast facade with Redis very similarly to Pusher. Like with many other systems within Laravel I aimed at making this easily interchangeable. So one could go to their config file and switch their broadcast driver between redis and pusher and expect the same or similar output. Which is my primary concern at this point. It appears to me that the other PR has met some friction because it aims to not only solve the redis broadcast provider issue but also adds enhancements and some extra stuff that is debatable.\r\n\r\nAnyways, along with Echo, I've tested this PR between a [Socket.io server](https://github.com/tlaverdure/laravel-echo-server) that I've been working on and Pusher. I've been able to use both interchangeably. You would need this [version](https://github.com/tlaverdure/echo) of Echo though. Still a WIP but it is setup with both a PusherConnector and SocketIoConnector."}}
{"actor":{"display_login":"tlaverdure"}}