{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/73973873","id":73973873,"diff_hunk":"@@ -1,40 +1,17 @@\n-// Type definitions for serialport\n-// Project: https://github.com/EmergingTechnologyAdvisors/node-serialport \n+// Type definitions for serialport 4.0.1\n+// Project: https://github.com/EmergingTechnologyAdvisors/node-serialport\n // Definitions by: Jeremy Foster <https://github.com/codefoster>\n-// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped \n-\n-declare module 'serialport' {\n-    module parsers {\n-        function readline(delimiter: string):void;\n-        function raw(emitter:any, buffer:string):void\n-    }\n-\n-    export class SerialPort {\n-        constructor(path: string, options?: Object, openImmediately?: boolean, callback?: (err:string) => void)\n-        isOpen: boolean;\n-        on(event: string, callback?: (data?:any) => void):void;\n-        open(callback?: () => void):void;\n-        write(buffer: any, callback?: (err:string, bytesWritten:number) => void):void\n-        pause():void;\n-        resume():void;\n-        disconnected(err: Error):void;\n-        close(callback?: () => void):void;\n-        flush(callback?: () => void):void;\n-        set(options: setOptions, callback: () => void):void;\n-        drain(callback?: () => void):void;\n-        update(options: updateOptions, callback?: () => void):void;\n-    }\n-\n-    export function list(callback: (err: string, ports:portConfig[]) => void): void;\n+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n \n+declare namespace serialport {","path":"serialport/serialport.d.ts","position":33,"original_position":33,"commit_id":"be022bef6f8ff7c931618618cf3218f31de5909d","original_commit_id":"be022bef6f8ff7c931618618cf3218f31de5909d","user":{"login":"sandersn","id":293473,"avatar_url":"https://avatars.githubusercontent.com/u/293473?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersn","html_url":"https://github.com/sandersn","followers_url":"https://api.github.com/users/sandersn/followers","following_url":"https://api.github.com/users/sandersn/following{/other_user}","gists_url":"https://api.github.com/users/sandersn/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersn/subscriptions","organizations_url":"https://api.github.com/users/sandersn/orgs","repos_url":"https://api.github.com/users/sandersn/repos","events_url":"https://api.github.com/users/sandersn/events{/privacy}","received_events_url":"https://api.github.com/users/sandersn/received_events","type":"User","site_admin":false},"body":"It would be better to stick with the original `declare module 'serialport'`, which just created a module.\r\n\r\nThe original didn't pollute the global scope with a namespace. Since this is not going to be a UMD module (it looks like it's Node-only), it shouldn't put values in the global namespace.","created_at":"2016-08-08T23:19:08Z","updated_at":"2016-08-08T23:19:08Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515#discussion_r73973873","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/73973873"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515#discussion_r73973873"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515","id":80457514,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10515","number":10515,"state":"open","locked":false,"title":"Update serialport for 4.0 changes to the way it is exported","user":{"login":"underscorebrody","id":145505,"avatar_url":"https://avatars.githubusercontent.com/u/145505?v=3","gravatar_id":"","url":"https://api.github.com/users/underscorebrody","html_url":"https://github.com/underscorebrody","followers_url":"https://api.github.com/users/underscorebrody/followers","following_url":"https://api.github.com/users/underscorebrody/following{/other_user}","gists_url":"https://api.github.com/users/underscorebrody/gists{/gist_id}","starred_url":"https://api.github.com/users/underscorebrody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underscorebrody/subscriptions","organizations_url":"https://api.github.com/users/underscorebrody/orgs","repos_url":"https://api.github.com/users/underscorebrody/repos","events_url":"https://api.github.com/users/underscorebrody/events{/privacy}","received_events_url":"https://api.github.com/users/underscorebrody/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/DefinitelyTyped/DefinitelyTyped/issues/10500\r\n\r\nUpdates based on 4.0 changes to the way the library is exported. See deprecation warning here: https://github.com/EmergingTechnologyAdvisors/node-serialport/blob/master/lib/serialport.js#L664","created_at":"2016-08-08T14:10:31Z","updated_at":"2016-08-08T23:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28dc0ed2b92e36cb982c55b5e5391cfb59bc770","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10515/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/be022bef6f8ff7c931618618cf3218f31de5909d","head":{"label":"kitcheck:serialport-4-updates","ref":"serialport-4-updates","sha":"be022bef6f8ff7c931618618cf3218f31de5909d","user":{"login":"kitcheck","id":5598366,"avatar_url":"https://avatars.githubusercontent.com/u/5598366?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcheck","html_url":"https://github.com/kitcheck","followers_url":"https://api.github.com/users/kitcheck/followers","following_url":"https://api.github.com/users/kitcheck/following{/other_user}","gists_url":"https://api.github.com/users/kitcheck/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcheck/subscriptions","organizations_url":"https://api.github.com/users/kitcheck/orgs","repos_url":"https://api.github.com/users/kitcheck/repos","events_url":"https://api.github.com/users/kitcheck/events{/privacy}","received_events_url":"https://api.github.com/users/kitcheck/received_events","type":"Organization","site_admin":false},"repo":{"id":62238443,"name":"DefinitelyTyped","full_name":"kitcheck/DefinitelyTyped","owner":{"login":"kitcheck","id":5598366,"avatar_url":"https://avatars.githubusercontent.com/u/5598366?v=3","gravatar_id":"","url":"https://api.github.com/users/kitcheck","html_url":"https://github.com/kitcheck","followers_url":"https://api.github.com/users/kitcheck/followers","following_url":"https://api.github.com/users/kitcheck/following{/other_user}","gists_url":"https://api.github.com/users/kitcheck/gists{/gist_id}","starred_url":"https://api.github.com/users/kitcheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitcheck/subscriptions","organizations_url":"https://api.github.com/users/kitcheck/orgs","repos_url":"https://api.github.com/users/kitcheck/repos","events_url":"https://api.github.com/users/kitcheck/events{/privacy}","received_events_url":"https://api.github.com/users/kitcheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kitcheck/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/kitcheck/DefinitelyTyped","forks_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/kitcheck/DefinitelyTyped/deployments","created_at":"2016-06-29T15:48:45Z","updated_at":"2016-06-29T15:48:52Z","pushed_at":"2016-08-08T20:00:55Z","git_url":"git://github.com/kitcheck/DefinitelyTyped.git","ssh_url":"git@github.com:kitcheck/DefinitelyTyped.git","clone_url":"https://github.com/kitcheck/DefinitelyTyped.git","svn_url":"https://github.com/kitcheck/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":111108,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"d7dfa08dd469b232243d2b1db7cf93e5783b1646","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-08-08T13:31:01Z","pushed_at":"2016-08-08T23:13:42Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":156258,"stargazers_count":7899,"watchers_count":7899,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5929,"mirror_url":null,"open_issues_count":895,"forks":5929,"open_issues":895,"watchers":7899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/10515"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10515"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/10515/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/10515/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/be022bef6f8ff7c931618618cf3218f31de5909d"}}}}
{"actor":{"display_login":"sandersn"}}