{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/666","repository_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster","labels_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/666/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/666/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/666/events","html_url":"https://github.com/Leaflet/Leaflet.markercluster/issues/666","id":150564640,"number":666,"title":"Reorganize versions, publish 1.0 supported version on npm","user":{"login":"hyperknot","id":494223,"avatar_url":"https://avatars.githubusercontent.com/u/494223?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperknot","html_url":"https://github.com/hyperknot","followers_url":"https://api.github.com/users/hyperknot/followers","following_url":"https://api.github.com/users/hyperknot/following{/other_user}","gists_url":"https://api.github.com/users/hyperknot/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperknot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperknot/subscriptions","organizations_url":"https://api.github.com/users/hyperknot/orgs","repos_url":"https://api.github.com/users/hyperknot/repos","events_url":"https://api.github.com/users/hyperknot/events{/privacy}","received_events_url":"https://api.github.com/users/hyperknot/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-04-23T15:24:44Z","updated_at":"2016-04-26T05:53:29Z","closed_at":"2016-04-26T03:55:59Z","body":"- The most current version of markercluster on npm is from two years ago, has version number 0.4.0.\r\n- It doesn't support Leaflet 1.0 and ends in a cryptic messages of Trim not supported on undefined. This is the root cause of https://github.com/Leaflet/Leaflet/issues/4422 which no one knew why is happening. (and also https://github.com/Leaflet/Leaflet/issues/2408)\r\n- The readme says user should use bower, yet bower is discouraged by current Leaflet recommendations.\r\n- The 1.0 supporting master is still on 0.4.0 version number, just like the old 0.7 build.\r\n- The 0.7 branch is on 0.5.0 version (!), which is also what you get on bower.\r\n- brainmelt :-(\r\n\r\nWe should discuss how to handle markercluster, since it's an official repo and has 1400+ stars.\r\n\r\nAs a temp workaround I published a \"built\" branch, so users can just use:\r\n```\r\n\"leaflet.markercluster\": \"hyperknot/Leaflet.markercluster#built\"\r\n```\r\nin their package.json to support Leaflet 1.0. Ideally something like this should be pushed on npm with version number 0.6.0 or something.\r\n\r\n@mourner @perliedman @IvanSanchez @yohanboniface What do you think we should do? "},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/comments/214623172","html_url":"https://github.com/Leaflet/Leaflet.markercluster/issues/666#issuecomment-214623172","issue_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/666","id":214623172,"user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T05:53:29Z","updated_at":"2016-04-26T05:53:29Z","body":"Excellent, thanks @danzel :)\r\n\r\n> I'm not sure we should be matching leaflet version numbers, as when we change things we will want to bump our version number, and then we won't line up.\r\n\r\nAgreed!\r\nBut I think bumping to 1.0.0 make sense for this long used plugin :)\r\nBut then I agree plugins should not follow leaflet version number."}}