{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/1190","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/1190/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1190/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/1190/events","html_url":"https://github.com/opencontainers/runc/pull/1190","id":189935641,"number":1190,"title":"return code changed to ErrNotExist","user":{"login":"kunalkushwaha","id":2758433,"avatar_url":"https://avatars.githubusercontent.com/u/2758433?v=3","gravatar_id":"","url":"https://api.github.com/users/kunalkushwaha","html_url":"https://github.com/kunalkushwaha","followers_url":"https://api.github.com/users/kunalkushwaha/followers","following_url":"https://api.github.com/users/kunalkushwaha/following{/other_user}","gists_url":"https://api.github.com/users/kunalkushwaha/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalkushwaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalkushwaha/subscriptions","organizations_url":"https://api.github.com/users/kunalkushwaha/orgs","repos_url":"https://api.github.com/users/kunalkushwaha/repos","events_url":"https://api.github.com/users/kunalkushwaha/events{/privacy}","received_events_url":"https://api.github.com/users/kunalkushwaha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-17T04:38:31Z","updated_at":"2016-11-18T01:02:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1190","html_url":"https://github.com/opencontainers/runc/pull/1190","diff_url":"https://github.com/opencontainers/runc/pull/1190.diff","patch_url":"https://github.com/opencontainers/runc/pull/1190.patch"},"body":"getBlkioStat was returning nil instead of ErrNotExist,\r\nif any file in /sys/fs/cgroup/blkio/ was not found.\r\n\r\nCorrecting this error also, force to fix test cases,\r\nwhich were not verifying if the files were really missing.\r\n\r\nSigned-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/261419003","html_url":"https://github.com/opencontainers/runc/pull/1190#issuecomment-261419003","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1190","id":261419003,"user":{"login":"kunalkushwaha","id":2758433,"avatar_url":"https://avatars.githubusercontent.com/u/2758433?v=3","gravatar_id":"","url":"https://api.github.com/users/kunalkushwaha","html_url":"https://github.com/kunalkushwaha","followers_url":"https://api.github.com/users/kunalkushwaha/followers","following_url":"https://api.github.com/users/kunalkushwaha/following{/other_user}","gists_url":"https://api.github.com/users/kunalkushwaha/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalkushwaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalkushwaha/subscriptions","organizations_url":"https://api.github.com/users/kunalkushwaha/orgs","repos_url":"https://api.github.com/users/kunalkushwaha/repos","events_url":"https://api.github.com/users/kunalkushwaha/events{/privacy}","received_events_url":"https://api.github.com/users/kunalkushwaha/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T01:02:31Z","updated_at":"2016-11-18T01:02:31Z","body":"> some files' absence is totally legal, such as different kernel configurations, for blkio, some\r\nfiles could only be seem on CFQ enabled kernels, so you can't just return error for not finding some files. Some subsystems don't have this issue, so we are having this inconsistency issue.\r\n\r\nI Agree. The [GetStats()](https://github.com/opencontainers/runc/blob/master/libcontainer/cgroups/fs/blkio.go#L167) function already take cares about CFQ enabled/disabled configuration.\r\n\r\nMy fix simply checks, if CFQ enabled, then in case some files are missing, it reports ``ErrNotExist`` . Modification is done in ``getBlkioStat()`` which is not exposed outside this package."}}
{"actor":{"display_login":"kunalkushwaha"}}