{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/etcd/issues/4361","labels_url":"https://api.github.com/repos/coreos/etcd/issues/4361/labels{/name}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/4361/comments","events_url":"https://api.github.com/repos/coreos/etcd/issues/4361/events","html_url":"https://github.com/coreos/etcd/pull/4361","id":130107124,"number":4361,"title":"e2e: check regexp.MatchReader return, curl SSL issue","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-31T09:38:10Z","updated_at":"2016-02-01T17:43:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/4361","html_url":"https://github.com/coreos/etcd/pull/4361","diff_url":"https://github.com/coreos/etcd/pull/4361.diff","patch_url":"https://github.com/coreos/etcd/pull/4361.patch"},"body":"```go\r\nbuf := new(bytes.Buffer)\r\nbuf.WriteString(\"abc\")\r\ns, err := regexp.MatchReader(\"x\", buf)\r\nfmt.Println(s, err)\r\n// false <nil>\r\n```\r\n\r\n1. proc.ExpectRegex returns the result of regexp.MatchReader,\r\nwhich does not return error even if there is no match of regex.\r\nThis fixes it by checking the boolean value and if the boolean\r\nvalue is false, it returns error.\r\n\r\n1. Adds more tests and finishes https://github.com/coreos/etcd/issues/4259.\r\n\r\n1. When we do the regex match correctly, curl request through SSL\r\nreturns error. For the purpose of debugging, I changed it to log\r\nwithout failing the tests. etcdctl with SSL works fine [1]. \r\n\r\n1. Did some clean-ups.\r\n\r\n1. Added TODO for watch: `// TODO: 'watch' sometimes times out in Semaphore CI environment but works fine in every other environments`.\r\n\r\n1. increase test time\r\n\r\n1:\r\n```\r\n--- PASS: TestCurlAllTLS (0.31s)\r\ncurl: (35) error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/coreos/etcd/issues/comments/178090921","html_url":"https://github.com/coreos/etcd/pull/4361#issuecomment-178090921","issue_url":"https://api.github.com/repos/coreos/etcd/issues/4361","id":178090921,"user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T17:43:55Z","updated_at":"2016-02-01T17:43:55Z","body":"@gyuho Seems fine with me. Defer to @heyitsanthony "}}