{"action":"created","comment":{"url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/comments/64154387","id":64154387,"diff_hunk":"@@ -8,6 +8,13 @@\n \n     private HashMap<String, String> map;\n \n+    /*","path":"reminder/src/main/java/com/onecodelabs/reminderexample/bundle/ReminderBundle.java","position":4,"original_position":4,"commit_id":"b5f588615099a6d2a5d21800961cddd2da864ca5","original_commit_id":"b5f588615099a6d2a5d21800961cddd2da864ca5","user":{"login":"goodengineer","id":4495145,"avatar_url":"https://avatars.githubusercontent.com/u/4495145?v=3","gravatar_id":"","url":"https://api.github.com/users/goodengineer","html_url":"https://github.com/goodengineer","followers_url":"https://api.github.com/users/goodengineer/followers","following_url":"https://api.github.com/users/goodengineer/following{/other_user}","gists_url":"https://api.github.com/users/goodengineer/gists{/gist_id}","starred_url":"https://api.github.com/users/goodengineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodengineer/subscriptions","organizations_url":"https://api.github.com/users/goodengineer/orgs","repos_url":"https://api.github.com/users/goodengineer/repos","events_url":"https://api.github.com/users/goodengineer/events{/privacy}","received_events_url":"https://api.github.com/users/goodengineer/received_events","type":"User","site_admin":false},"body":"I understand that \"time\" is not a happy name and that there is a period in which the value it's holding is not what the comment in its getter says it is. But the consumer of this library will always receive ReminderBundles with the time set to the time in millis that has passed since the snapshot was saved. This period in which time holds a timestamp starts when the snapshot is saved and ends when the Remindable is about to be \"reminded\". Maybe the variable can have a different name or we can use more than one variable to do this trick. I just thought using a second variable wasn't clean because this second variable would also have a getter&setter and the user would be able to see them.\r\n\r\nAlso, the idea of the timeout looks clean but if you think about it why would you take away from the user the possibility to decide what to do with the snapshot? The idea of this time variable was to let the user decide whether the information is old or not and act accordingly. Perhaps he wants to display it anyway and if it's not old we won't do any request and if it's old he will fetch new data from API (actually that's what I'm doing in the code example). Actually the whole idea of this library is to ALWAYS have something to show. Adding a feature that sometimes gets rid of the snapshot kinda violates the principle that governs this library.","created_at":"2016-05-22T18:50:56Z","updated_at":"2016-05-22T18:50:56Z","html_url":"https://github.com/OneCodeLabs/reminder/pull/6#discussion_r64154387","pull_request_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/comments/64154387"},"html":{"href":"https://github.com/OneCodeLabs/reminder/pull/6#discussion_r64154387"},"pull_request":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6","id":70938406,"html_url":"https://github.com/OneCodeLabs/reminder/pull/6","diff_url":"https://github.com/OneCodeLabs/reminder/pull/6.diff","patch_url":"https://github.com/OneCodeLabs/reminder/pull/6.patch","issue_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/6","number":6,"state":"open","locked":false,"title":"added time to snapshots","user":{"login":"goodengineer","id":4495145,"avatar_url":"https://avatars.githubusercontent.com/u/4495145?v=3","gravatar_id":"","url":"https://api.github.com/users/goodengineer","html_url":"https://github.com/goodengineer","followers_url":"https://api.github.com/users/goodengineer/followers","following_url":"https://api.github.com/users/goodengineer/following{/other_user}","gists_url":"https://api.github.com/users/goodengineer/gists{/gist_id}","starred_url":"https://api.github.com/users/goodengineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodengineer/subscriptions","organizations_url":"https://api.github.com/users/goodengineer/orgs","repos_url":"https://api.github.com/users/goodengineer/repos","events_url":"https://api.github.com/users/goodengineer/events{/privacy}","received_events_url":"https://api.github.com/users/goodengineer/received_events","type":"User","site_admin":false},"body":"# Summary\r\n\r\n - Added a new variable to ReminderBundle to hold the time in milliseconds since save time\r\n - Added onSnapshotNotFound() to Remindable\r\n - Updated example code so it uses this new feature\r\n - Several null checks inside Reminder","created_at":"2016-05-21T03:14:48Z","updated_at":"2016-05-22T18:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efb7fa07244e0a0688581069d7ba0705a1e34b05","assignee":{"login":"goodengineer","id":4495145,"avatar_url":"https://avatars.githubusercontent.com/u/4495145?v=3","gravatar_id":"","url":"https://api.github.com/users/goodengineer","html_url":"https://github.com/goodengineer","followers_url":"https://api.github.com/users/goodengineer/followers","following_url":"https://api.github.com/users/goodengineer/following{/other_user}","gists_url":"https://api.github.com/users/goodengineer/gists{/gist_id}","starred_url":"https://api.github.com/users/goodengineer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodengineer/subscriptions","organizations_url":"https://api.github.com/users/goodengineer/orgs","repos_url":"https://api.github.com/users/goodengineer/repos","events_url":"https://api.github.com/users/goodengineer/events{/privacy}","received_events_url":"https://api.github.com/users/goodengineer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6/commits","review_comments_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6/comments","review_comment_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/6/comments","statuses_url":"https://api.github.com/repos/OneCodeLabs/reminder/statuses/b5f588615099a6d2a5d21800961cddd2da864ca5","head":{"label":"OneCodeLabs:snapshot-timestamp","ref":"snapshot-timestamp","sha":"b5f588615099a6d2a5d21800961cddd2da864ca5","user":{"login":"OneCodeLabs","id":17692906,"avatar_url":"https://avatars.githubusercontent.com/u/17692906?v=3","gravatar_id":"","url":"https://api.github.com/users/OneCodeLabs","html_url":"https://github.com/OneCodeLabs","followers_url":"https://api.github.com/users/OneCodeLabs/followers","following_url":"https://api.github.com/users/OneCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/OneCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/OneCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/OneCodeLabs/orgs","repos_url":"https://api.github.com/users/OneCodeLabs/repos","events_url":"https://api.github.com/users/OneCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/OneCodeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":58655164,"name":"reminder","full_name":"OneCodeLabs/reminder","owner":{"login":"OneCodeLabs","id":17692906,"avatar_url":"https://avatars.githubusercontent.com/u/17692906?v=3","gravatar_id":"","url":"https://api.github.com/users/OneCodeLabs","html_url":"https://github.com/OneCodeLabs","followers_url":"https://api.github.com/users/OneCodeLabs/followers","following_url":"https://api.github.com/users/OneCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/OneCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/OneCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/OneCodeLabs/orgs","repos_url":"https://api.github.com/users/OneCodeLabs/repos","events_url":"https://api.github.com/users/OneCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/OneCodeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneCodeLabs/reminder","description":"[Android library] reminder lets you persist the state of your views to recover them later in order to display old data until fresh data arrives","fork":false,"url":"https://api.github.com/repos/OneCodeLabs/reminder","forks_url":"https://api.github.com/repos/OneCodeLabs/reminder/forks","keys_url":"https://api.github.com/repos/OneCodeLabs/reminder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneCodeLabs/reminder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneCodeLabs/reminder/teams","hooks_url":"https://api.github.com/repos/OneCodeLabs/reminder/hooks","issue_events_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/events{/number}","events_url":"https://api.github.com/repos/OneCodeLabs/reminder/events","assignees_url":"https://api.github.com/repos/OneCodeLabs/reminder/assignees{/user}","branches_url":"https://api.github.com/repos/OneCodeLabs/reminder/branches{/branch}","tags_url":"https://api.github.com/repos/OneCodeLabs/reminder/tags","blobs_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneCodeLabs/reminder/statuses/{sha}","languages_url":"https://api.github.com/repos/OneCodeLabs/reminder/languages","stargazers_url":"https://api.github.com/repos/OneCodeLabs/reminder/stargazers","contributors_url":"https://api.github.com/repos/OneCodeLabs/reminder/contributors","subscribers_url":"https://api.github.com/repos/OneCodeLabs/reminder/subscribers","subscription_url":"https://api.github.com/repos/OneCodeLabs/reminder/subscription","commits_url":"https://api.github.com/repos/OneCodeLabs/reminder/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneCodeLabs/reminder/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneCodeLabs/reminder/contents/{+path}","compare_url":"https://api.github.com/repos/OneCodeLabs/reminder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneCodeLabs/reminder/merges","archive_url":"https://api.github.com/repos/OneCodeLabs/reminder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneCodeLabs/reminder/downloads","issues_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues{/number}","pulls_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls{/number}","milestones_url":"https://api.github.com/repos/OneCodeLabs/reminder/milestones{/number}","notifications_url":"https://api.github.com/repos/OneCodeLabs/reminder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneCodeLabs/reminder/labels{/name}","releases_url":"https://api.github.com/repos/OneCodeLabs/reminder/releases{/id}","deployments_url":"https://api.github.com/repos/OneCodeLabs/reminder/deployments","created_at":"2016-05-12T15:45:39Z","updated_at":"2016-05-16T20:13:56Z","pushed_at":"2016-05-22T18:16:09Z","git_url":"git://github.com/OneCodeLabs/reminder.git","ssh_url":"git@github.com:OneCodeLabs/reminder.git","clone_url":"https://github.com/OneCodeLabs/reminder.git","svn_url":"https://github.com/OneCodeLabs/reminder","homepage":"","size":110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OneCodeLabs:master","ref":"master","sha":"e49d96c8a480958fb7bc5bb4007e3a6e617a3d81","user":{"login":"OneCodeLabs","id":17692906,"avatar_url":"https://avatars.githubusercontent.com/u/17692906?v=3","gravatar_id":"","url":"https://api.github.com/users/OneCodeLabs","html_url":"https://github.com/OneCodeLabs","followers_url":"https://api.github.com/users/OneCodeLabs/followers","following_url":"https://api.github.com/users/OneCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/OneCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/OneCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/OneCodeLabs/orgs","repos_url":"https://api.github.com/users/OneCodeLabs/repos","events_url":"https://api.github.com/users/OneCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/OneCodeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":58655164,"name":"reminder","full_name":"OneCodeLabs/reminder","owner":{"login":"OneCodeLabs","id":17692906,"avatar_url":"https://avatars.githubusercontent.com/u/17692906?v=3","gravatar_id":"","url":"https://api.github.com/users/OneCodeLabs","html_url":"https://github.com/OneCodeLabs","followers_url":"https://api.github.com/users/OneCodeLabs/followers","following_url":"https://api.github.com/users/OneCodeLabs/following{/other_user}","gists_url":"https://api.github.com/users/OneCodeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/OneCodeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneCodeLabs/subscriptions","organizations_url":"https://api.github.com/users/OneCodeLabs/orgs","repos_url":"https://api.github.com/users/OneCodeLabs/repos","events_url":"https://api.github.com/users/OneCodeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/OneCodeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneCodeLabs/reminder","description":"[Android library] reminder lets you persist the state of your views to recover them later in order to display old data until fresh data arrives","fork":false,"url":"https://api.github.com/repos/OneCodeLabs/reminder","forks_url":"https://api.github.com/repos/OneCodeLabs/reminder/forks","keys_url":"https://api.github.com/repos/OneCodeLabs/reminder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneCodeLabs/reminder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneCodeLabs/reminder/teams","hooks_url":"https://api.github.com/repos/OneCodeLabs/reminder/hooks","issue_events_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/events{/number}","events_url":"https://api.github.com/repos/OneCodeLabs/reminder/events","assignees_url":"https://api.github.com/repos/OneCodeLabs/reminder/assignees{/user}","branches_url":"https://api.github.com/repos/OneCodeLabs/reminder/branches{/branch}","tags_url":"https://api.github.com/repos/OneCodeLabs/reminder/tags","blobs_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneCodeLabs/reminder/statuses/{sha}","languages_url":"https://api.github.com/repos/OneCodeLabs/reminder/languages","stargazers_url":"https://api.github.com/repos/OneCodeLabs/reminder/stargazers","contributors_url":"https://api.github.com/repos/OneCodeLabs/reminder/contributors","subscribers_url":"https://api.github.com/repos/OneCodeLabs/reminder/subscribers","subscription_url":"https://api.github.com/repos/OneCodeLabs/reminder/subscription","commits_url":"https://api.github.com/repos/OneCodeLabs/reminder/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneCodeLabs/reminder/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneCodeLabs/reminder/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneCodeLabs/reminder/contents/{+path}","compare_url":"https://api.github.com/repos/OneCodeLabs/reminder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneCodeLabs/reminder/merges","archive_url":"https://api.github.com/repos/OneCodeLabs/reminder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneCodeLabs/reminder/downloads","issues_url":"https://api.github.com/repos/OneCodeLabs/reminder/issues{/number}","pulls_url":"https://api.github.com/repos/OneCodeLabs/reminder/pulls{/number}","milestones_url":"https://api.github.com/repos/OneCodeLabs/reminder/milestones{/number}","notifications_url":"https://api.github.com/repos/OneCodeLabs/reminder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneCodeLabs/reminder/labels{/name}","releases_url":"https://api.github.com/repos/OneCodeLabs/reminder/releases{/id}","deployments_url":"https://api.github.com/repos/OneCodeLabs/reminder/deployments","created_at":"2016-05-12T15:45:39Z","updated_at":"2016-05-16T20:13:56Z","pushed_at":"2016-05-22T18:16:09Z","git_url":"git://github.com/OneCodeLabs/reminder.git","ssh_url":"git@github.com:OneCodeLabs/reminder.git","clone_url":"https://github.com/OneCodeLabs/reminder.git","svn_url":"https://github.com/OneCodeLabs/reminder","homepage":"","size":110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6"},"html":{"href":"https://github.com/OneCodeLabs/reminder/pull/6"},"issue":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/issues/6"},"comments":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/OneCodeLabs/reminder/statuses/b5f588615099a6d2a5d21800961cddd2da864ca5"}}}}
{"actor":{"display_login":"goodengineer"}}