{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/18157","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/18157/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/18157/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/18157/events","html_url":"https://github.com/mantidproject/mantid/pull/18157","id":192804236,"number":18157,"title":"Add SANSState","user":{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false},"labels":[{"id":40342875,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20SANS","name":"Component: SANS","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"assignees":[{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/59","html_url":"https://github.com/mantidproject/mantid/milestone/59","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/59/labels","id":1622022,"number":59,"title":"Release 3.9","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars.githubusercontent.com/u/1017173?v=3","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":191,"closed_issues":491,"state":"open","created_at":"2016-03-04T11:29:48Z","updated_at":"2016-12-19T14:17:23Z","due_on":"2017-02-13T08:00:00Z","closed_at":null},"comments":6,"created_at":"2016-12-01T10:16:21Z","updated_at":"2016-12-19T16:18:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/18157","html_url":"https://github.com/mantidproject/mantid/pull/18157","diff_url":"https://github.com/mantidproject/mantid/pull/18157.diff","patch_url":"https://github.com/mantidproject/mantid/pull/18157.patch"},"body":"Fixes #18156\r\n\r\nThese changes adds the SANSState which is required for the second version of the ISIS reduction framework. The SANSState will allow to have the SANS settings:\r\n\r\n* centralized\r\n* self-validating\r\n* typed\r\n* serializable\r\n* easy to reason about\r\n* modular\r\n\r\nThe changes cannot be directly used by the user, hence a code review is probably the main review tool here.\r\n\r\nThe release notes will be updated once the entire SANS reducer backend has been roled out.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/268006323","html_url":"https://github.com/mantidproject/mantid/pull/18157#issuecomment-268006323","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/18157","id":268006323,"user":{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T16:18:21Z","updated_at":"2016-12-19T16:18:21Z","body":"Changes made:\r\n* Removed `SANSConstants` class and capitalised constants\r\n* renamed `sans_type` to `serializable_enum`\r\n* added static methods `to_string` and `from_string` to the typed enums which require it. This feature is now a decorator \r\n\r\n"}}
{"actor":{"display_login":"AntonPiccardoSelg"}}