{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/124","repository_url":"https://api.github.com/repos/spring-projects/spring-kafka","labels_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/124/comments","events_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/124/events","html_url":"https://github.com/spring-projects/spring-kafka/issues/124","id":160969733,"number":124,"title":"Consider providing some default values for `ackTime` and `ackCount`","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spring-projects/spring-kafka/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-kafka/milestones/6","html_url":"https://github.com/spring-projects/spring-kafka/milestones/1.0.0.GA","labels_url":"https://api.github.com/repos/spring-projects/spring-kafka/milestones/6/labels","id":1814202,"number":6,"title":"1.0.0.GA","description":"","creator":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-06-07T19:18:58Z","updated_at":"2016-06-17T20:46:09Z","due_on":"2016-06-16T04:00:00Z","closed_at":null},"comments":2,"created_at":"2016-06-17T20:34:12Z","updated_at":"2016-06-17T20:59:26Z","closed_at":null,"body":"Currently they're both set to 0, which essentially renders the default behaviour of `TIME`, `COUNT`,`COUNT_TIME` and `MANUAL` identical to `BATCH` (and `MANUAL_IMMEDIATE_SYNC` in the case of `MANUAL`).\r\n\r\nIt would be better if we provided some defaults, or at the very least, we validated the values (e.g. COUNT requires a non-zero count value, etc). \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/comments/226880120","html_url":"https://github.com/spring-projects/spring-kafka/issues/124#issuecomment-226880120","issue_url":"https://api.github.com/repos/spring-projects/spring-kafka/issues/124","id":226880120,"user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T20:59:26Z","updated_at":"2016-06-17T20:59:26Z","body":"For time, we could, in principle, use the default settings of autocommit - the default for `auto.commit.interval.ms` is 5s.\r\n\r\nFor count, I'm not sure - this is very dependent on the nature of the application. Maybe we should just validate that a positive number is set in that case. \r\n"}}
{"actor":{"display_login":"mbogoevici"}}