{"action":"created","comment":{"url":"https://api.github.com/repos/cdk/cdk/pulls/comments/65660765","id":65660765,"diff_hunk":"@@ -126,6 +132,18 @@ public SDFWriter(Set<String> propertiesToWrite) {\n         this(new StringWriter(), propertiesToWrite);\n     }\n \n+    /**\n+     * Ensures a writer is buffered.\n+     *\n+     * @param wtr writer, may be buffered\n+     * @return a BufferedWriter\n+     */\n+    private static BufferedWriter ensureBuffered(Writer wtr) {","path":"storage/io/src/main/java/org/openscience/cdk/io/SDFWriter.java","position":82,"original_position":82,"commit_id":"aabd1fb9e4a22893f7f5c51d1d67c2fbd9f75f87","original_commit_id":"aabd1fb9e4a22893f7f5c51d1d67c2fbd9f75f87","user":{"login":"egonw","id":26721,"avatar_url":"https://avatars.githubusercontent.com/u/26721?v=3","gravatar_id":"","url":"https://api.github.com/users/egonw","html_url":"https://github.com/egonw","followers_url":"https://api.github.com/users/egonw/followers","following_url":"https://api.github.com/users/egonw/following{/other_user}","gists_url":"https://api.github.com/users/egonw/gists{/gist_id}","starred_url":"https://api.github.com/users/egonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egonw/subscriptions","organizations_url":"https://api.github.com/users/egonw/orgs","repos_url":"https://api.github.com/users/egonw/repos","events_url":"https://api.github.com/users/egonw/events{/privacy}","received_events_url":"https://api.github.com/users/egonw/received_events","type":"User","site_admin":false},"body":"What about the idea to have the class implement BufferedReader too? One complication with that would be that most of our readers support Reader and InputStream. The latter is at least import for XML-based formats...","created_at":"2016-06-03T06:16:34Z","updated_at":"2016-06-03T06:16:34Z","html_url":"https://github.com/cdk/cdk/pull/203#discussion_r65660765","pull_request_url":"https://api.github.com/repos/cdk/cdk/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments/65660765"},"html":{"href":"https://github.com/cdk/cdk/pull/203#discussion_r65660765"},"pull_request":{"href":"https://api.github.com/repos/cdk/cdk/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/cdk/cdk/pulls/203","id":72404432,"html_url":"https://github.com/cdk/cdk/pull/203","diff_url":"https://github.com/cdk/cdk/pull/203.diff","patch_url":"https://github.com/cdk/cdk/pull/203.patch","issue_url":"https://api.github.com/repos/cdk/cdk/issues/203","number":203,"state":"open","locked":false,"title":"Make it explicit that a BufferedWriter can be passed in.","user":{"login":"johnmay","id":983232,"avatar_url":"https://avatars.githubusercontent.com/u/983232?v=3","gravatar_id":"","url":"https://api.github.com/users/johnmay","html_url":"https://github.com/johnmay","followers_url":"https://api.github.com/users/johnmay/followers","following_url":"https://api.github.com/users/johnmay/following{/other_user}","gists_url":"https://api.github.com/users/johnmay/gists{/gist_id}","starred_url":"https://api.github.com/users/johnmay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnmay/subscriptions","organizations_url":"https://api.github.com/users/johnmay/orgs","repos_url":"https://api.github.com/users/johnmay/repos","events_url":"https://api.github.com/users/johnmay/events{/privacy}","received_events_url":"https://api.github.com/users/johnmay/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-02T19:36:00Z","updated_at":"2016-06-03T06:16:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f32b985d15f1edfa08273f61641e682af0e549ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cdk/cdk/pulls/203/commits","review_comments_url":"https://api.github.com/repos/cdk/cdk/pulls/203/comments","review_comment_url":"https://api.github.com/repos/cdk/cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdk/cdk/issues/203/comments","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/aabd1fb9e4a22893f7f5c51d1d67c2fbd9f75f87","head":{"label":"cdk:patch/sdfwriteinit","ref":"patch/sdfwriteinit","sha":"aabd1fb9e4a22893f7f5c51d1d67c2fbd9f75f87","user":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"repo":{"id":660443,"name":"cdk","full_name":"cdk/cdk","owner":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cdk/cdk","description":"The Chemistry Development Kit","fork":false,"url":"https://api.github.com/repos/cdk/cdk","forks_url":"https://api.github.com/repos/cdk/cdk/forks","keys_url":"https://api.github.com/repos/cdk/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdk/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdk/cdk/teams","hooks_url":"https://api.github.com/repos/cdk/cdk/hooks","issue_events_url":"https://api.github.com/repos/cdk/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/cdk/cdk/events","assignees_url":"https://api.github.com/repos/cdk/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/cdk/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/cdk/cdk/tags","blobs_url":"https://api.github.com/repos/cdk/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdk/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdk/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdk/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cdk/cdk/languages","stargazers_url":"https://api.github.com/repos/cdk/cdk/stargazers","contributors_url":"https://api.github.com/repos/cdk/cdk/contributors","subscribers_url":"https://api.github.com/repos/cdk/cdk/subscribers","subscription_url":"https://api.github.com/repos/cdk/cdk/subscription","commits_url":"https://api.github.com/repos/cdk/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdk/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdk/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdk/cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdk/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/cdk/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdk/cdk/merges","archive_url":"https://api.github.com/repos/cdk/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdk/cdk/downloads","issues_url":"https://api.github.com/repos/cdk/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/cdk/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cdk/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cdk/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdk/cdk/labels{/name}","releases_url":"https://api.github.com/repos/cdk/cdk/releases{/id}","deployments_url":"https://api.github.com/repos/cdk/cdk/deployments","created_at":"2010-05-11T08:30:07Z","updated_at":"2016-05-21T08:46:11Z","pushed_at":"2016-06-02T21:20:19Z","git_url":"git://github.com/cdk/cdk.git","ssh_url":"git@github.com:cdk/cdk.git","clone_url":"https://github.com/cdk/cdk.git","svn_url":"https://github.com/cdk/cdk","homepage":"http://cdk.sf.net/","size":185273,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":3,"forks":38,"open_issues":3,"watchers":68,"default_branch":"master"}},"base":{"label":"cdk:master","ref":"master","sha":"e78d3050c3f4ed43612494cadbf472f32b712ff1","user":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"repo":{"id":660443,"name":"cdk","full_name":"cdk/cdk","owner":{"login":"cdk","id":273111,"avatar_url":"https://avatars.githubusercontent.com/u/273111?v=3","gravatar_id":"","url":"https://api.github.com/users/cdk","html_url":"https://github.com/cdk","followers_url":"https://api.github.com/users/cdk/followers","following_url":"https://api.github.com/users/cdk/following{/other_user}","gists_url":"https://api.github.com/users/cdk/gists{/gist_id}","starred_url":"https://api.github.com/users/cdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdk/subscriptions","organizations_url":"https://api.github.com/users/cdk/orgs","repos_url":"https://api.github.com/users/cdk/repos","events_url":"https://api.github.com/users/cdk/events{/privacy}","received_events_url":"https://api.github.com/users/cdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cdk/cdk","description":"The Chemistry Development Kit","fork":false,"url":"https://api.github.com/repos/cdk/cdk","forks_url":"https://api.github.com/repos/cdk/cdk/forks","keys_url":"https://api.github.com/repos/cdk/cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdk/cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdk/cdk/teams","hooks_url":"https://api.github.com/repos/cdk/cdk/hooks","issue_events_url":"https://api.github.com/repos/cdk/cdk/issues/events{/number}","events_url":"https://api.github.com/repos/cdk/cdk/events","assignees_url":"https://api.github.com/repos/cdk/cdk/assignees{/user}","branches_url":"https://api.github.com/repos/cdk/cdk/branches{/branch}","tags_url":"https://api.github.com/repos/cdk/cdk/tags","blobs_url":"https://api.github.com/repos/cdk/cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdk/cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdk/cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdk/cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdk/cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cdk/cdk/languages","stargazers_url":"https://api.github.com/repos/cdk/cdk/stargazers","contributors_url":"https://api.github.com/repos/cdk/cdk/contributors","subscribers_url":"https://api.github.com/repos/cdk/cdk/subscribers","subscription_url":"https://api.github.com/repos/cdk/cdk/subscription","commits_url":"https://api.github.com/repos/cdk/cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdk/cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdk/cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdk/cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdk/cdk/contents/{+path}","compare_url":"https://api.github.com/repos/cdk/cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdk/cdk/merges","archive_url":"https://api.github.com/repos/cdk/cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdk/cdk/downloads","issues_url":"https://api.github.com/repos/cdk/cdk/issues{/number}","pulls_url":"https://api.github.com/repos/cdk/cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cdk/cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cdk/cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdk/cdk/labels{/name}","releases_url":"https://api.github.com/repos/cdk/cdk/releases{/id}","deployments_url":"https://api.github.com/repos/cdk/cdk/deployments","created_at":"2010-05-11T08:30:07Z","updated_at":"2016-05-21T08:46:11Z","pushed_at":"2016-06-02T21:20:19Z","git_url":"git://github.com/cdk/cdk.git","ssh_url":"git@github.com:cdk/cdk.git","clone_url":"https://github.com/cdk/cdk.git","svn_url":"https://github.com/cdk/cdk","homepage":"http://cdk.sf.net/","size":185273,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":3,"forks":38,"open_issues":3,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cdk/cdk/pulls/203"},"html":{"href":"https://github.com/cdk/cdk/pull/203"},"issue":{"href":"https://api.github.com/repos/cdk/cdk/issues/203"},"comments":{"href":"https://api.github.com/repos/cdk/cdk/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/cdk/cdk/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/cdk/cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdk/cdk/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/cdk/cdk/statuses/aabd1fb9e4a22893f7f5c51d1d67c2fbd9f75f87"}}}}
{"actor":{"display_login":"egonw"}}