{"action":"opened","number":198,"pull_request":{"url":"https://api.github.com/repos/atom/atom-keymap/pulls/198","id":98123687,"html_url":"https://github.com/atom/atom-keymap/pull/198","diff_url":"https://github.com/atom/atom-keymap/pull/198.diff","patch_url":"https://github.com/atom/atom-keymap/pull/198.patch","issue_url":"https://api.github.com/repos/atom/atom-keymap/issues/198","number":198,"state":"open","locked":false,"title":"Resolve numpad differently to avoid conflict with Windows unicode entry","user":{"login":"Ben3eeE","id":1058982,"avatar_url":"https://avatars.githubusercontent.com/u/1058982?v=3","gravatar_id":"","url":"https://api.github.com/users/Ben3eeE","html_url":"https://github.com/Ben3eeE","followers_url":"https://api.github.com/users/Ben3eeE/followers","following_url":"https://api.github.com/users/Ben3eeE/following{/other_user}","gists_url":"https://api.github.com/users/Ben3eeE/gists{/gist_id}","starred_url":"https://api.github.com/users/Ben3eeE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ben3eeE/subscriptions","organizations_url":"https://api.github.com/users/Ben3eeE/orgs","repos_url":"https://api.github.com/users/Ben3eeE/repos","events_url":"https://api.github.com/users/Ben3eeE/events{/privacy}","received_events_url":"https://api.github.com/users/Ben3eeE/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\nWindows uses <kbd>Alt-numpad</kbd> to insert unicode characters. `atom-keymap` currently resolves the numpad digits the same was as the numeric row which means that unicode entry will conflict with <kbd>Alt-number</kbd> bound keys. <kbd>Alt-number</kbd> is bound to `pane-show-item-[number]` which means you can't use <kbd>Alt-numpad</kbd> to enter unicode characters in Atom without changing pane items.\r\n\r\nThis changes the numpad digits to resolve to `numpad[number]` instead of just `[number]` by using `KeyboardEvent.code` when numlock is on to avoid conflict. Windows seems to still allow unicode entry when numlock is off which would conflict with keybindings but this seems to be the expected behavior on Windows after testing it in some common programs.\r\n\r\n### Alternate Designs\r\n\r\n\r\n### Benefits\r\n\r\nFixes https://github.com/atom/atom-keymap/issues/147 and allows us to enter unicode characters with the numpad on Windows without conflicting with Atoms default set of keybindings.\r\n\r\n### Possible Drawbacks\r\n\r\n* Someone relies on the current way we resolve keys\r\n* This adds the change for all platforms. I don't know if this makes sense of Linux or mac. Linux seems to use a different method to insert unicode characters.\r\n\r\n### Applicable Issues\r\n\r\nFixes https://github.com/atom/atom-keymap/issues/147","created_at":"2016-12-15T10:31:00Z","updated_at":"2016-12-15T10:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom-keymap/pulls/198/commits","review_comments_url":"https://api.github.com/repos/atom/atom-keymap/pulls/198/comments","review_comment_url":"https://api.github.com/repos/atom/atom-keymap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom-keymap/issues/198/comments","statuses_url":"https://api.github.com/repos/atom/atom-keymap/statuses/bd9c9d174620f134d04f5124c6f118ae74c08af9","head":{"label":"atom:b3-resolve-numpad","ref":"b3-resolve-numpad","sha":"bd9c9d174620f134d04f5124c6f118ae74c08af9","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":17691877,"name":"atom-keymap","full_name":"atom/atom-keymap","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-keymap","description":"Atom's selector-based keymap system","fork":false,"url":"https://api.github.com/repos/atom/atom-keymap","forks_url":"https://api.github.com/repos/atom/atom-keymap/forks","keys_url":"https://api.github.com/repos/atom/atom-keymap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-keymap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-keymap/teams","hooks_url":"https://api.github.com/repos/atom/atom-keymap/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-keymap/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-keymap/events","assignees_url":"https://api.github.com/repos/atom/atom-keymap/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-keymap/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-keymap/tags","blobs_url":"https://api.github.com/repos/atom/atom-keymap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-keymap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-keymap/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-keymap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-keymap/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-keymap/languages","stargazers_url":"https://api.github.com/repos/atom/atom-keymap/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-keymap/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-keymap/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-keymap/subscription","commits_url":"https://api.github.com/repos/atom/atom-keymap/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-keymap/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-keymap/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-keymap/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom-keymap/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-keymap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-keymap/merges","archive_url":"https://api.github.com/repos/atom/atom-keymap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-keymap/downloads","issues_url":"https://api.github.com/repos/atom/atom-keymap/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-keymap/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-keymap/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-keymap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-keymap/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-keymap/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom-keymap/deployments","created_at":"2014-03-13T02:31:22Z","updated_at":"2016-12-11T17:42:53Z","pushed_at":"2016-12-15T10:10:49Z","git_url":"git://github.com/atom/atom-keymap.git","ssh_url":"git@github.com:atom/atom-keymap.git","clone_url":"https://github.com/atom/atom-keymap.git","svn_url":"https://github.com/atom/atom-keymap","homepage":null,"size":568,"stargazers_count":84,"watchers_count":84,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":36,"forks":37,"open_issues":36,"watchers":84,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"bf9998ebc3f768b6f69fe46ae60ea663a7bbbc64","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":17691877,"name":"atom-keymap","full_name":"atom/atom-keymap","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-keymap","description":"Atom's selector-based keymap system","fork":false,"url":"https://api.github.com/repos/atom/atom-keymap","forks_url":"https://api.github.com/repos/atom/atom-keymap/forks","keys_url":"https://api.github.com/repos/atom/atom-keymap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-keymap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-keymap/teams","hooks_url":"https://api.github.com/repos/atom/atom-keymap/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-keymap/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-keymap/events","assignees_url":"https://api.github.com/repos/atom/atom-keymap/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-keymap/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-keymap/tags","blobs_url":"https://api.github.com/repos/atom/atom-keymap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-keymap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-keymap/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-keymap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-keymap/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-keymap/languages","stargazers_url":"https://api.github.com/repos/atom/atom-keymap/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-keymap/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-keymap/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-keymap/subscription","commits_url":"https://api.github.com/repos/atom/atom-keymap/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-keymap/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-keymap/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-keymap/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom-keymap/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-keymap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-keymap/merges","archive_url":"https://api.github.com/repos/atom/atom-keymap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-keymap/downloads","issues_url":"https://api.github.com/repos/atom/atom-keymap/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-keymap/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-keymap/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-keymap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-keymap/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-keymap/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom-keymap/deployments","created_at":"2014-03-13T02:31:22Z","updated_at":"2016-12-11T17:42:53Z","pushed_at":"2016-12-15T10:10:49Z","git_url":"git://github.com/atom/atom-keymap.git","ssh_url":"git@github.com:atom/atom-keymap.git","clone_url":"https://github.com/atom/atom-keymap.git","svn_url":"https://github.com/atom/atom-keymap","homepage":null,"size":568,"stargazers_count":84,"watchers_count":84,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":36,"forks":37,"open_issues":36,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom-keymap/pulls/198"},"html":{"href":"https://github.com/atom/atom-keymap/pull/198"},"issue":{"href":"https://api.github.com/repos/atom/atom-keymap/issues/198"},"comments":{"href":"https://api.github.com/repos/atom/atom-keymap/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom-keymap/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom-keymap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom-keymap/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom-keymap/statuses/bd9c9d174620f134d04f5124c6f118ae74c08af9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":41,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"Ben3eeE"}}