{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/50431203","id":50431203,"diff_hunk":"@@ -748,7 +748,7 @@ class rekey_test : public beast::unit_test::suite\n     }\n };\n \n-BEAST_DEFINE_TESTSUITE_MANUAL(rekey,NodeStore,ripple);\n+BEAST_DEFINE_TESTSUITE(rekey,NodeStore,ripple);","path":"src/ripple/nodestore/tests/import_test.cpp","position":14,"original_position":14,"commit_id":"a7d91ee95e319969773b29afcd92503d84111694","original_commit_id":"a7d91ee95e319969773b29afcd92503d84111694","user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"body":"The purpose of this test is to allow a command line to regenerate the .key file for a nudb nodestore. Marking it non-manual will just cause it to fail with \"missing parameter\" errors.","created_at":"2016-01-21T17:14:20Z","updated_at":"2016-01-21T17:14:20Z","html_url":"https://github.com/ripple/rippled/pull/1497#discussion_r50431203","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1497","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/50431203"},"html":{"href":"https://github.com/ripple/rippled/pull/1497#discussion_r50431203"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1497"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1497","id":56778287,"html_url":"https://github.com/ripple/rippled/pull/1497","diff_url":"https://github.com/ripple/rippled/pull/1497.diff","patch_url":"https://github.com/ripple/rippled/pull/1497.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1497","number":1497,"state":"open","locked":false,"title":"Convert fast manual unit tests to automatic.","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?v=3","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"body":"Some of the code marked un-covered by our coverage tool is manual unit tests.  Switching these particular unit tests to non-manual increases our code coverage and adds only about 1/10th of a second to our unit test run time.\r\n\r\nReviewers: @vinniefalco @ximinez ","created_at":"2016-01-21T17:02:05Z","updated_at":"2016-01-21T17:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ee465a38ff031f497f1e2298d2f7ee80a539b44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1497/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1497/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1497/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/a7d91ee95e319969773b29afcd92503d84111694","head":{"label":"scottschurr:more-unittests","ref":"more-unittests","sha":"a7d91ee95e319969773b29afcd92503d84111694","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?v=3","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"repo":{"id":20703176,"name":"rippled","full_name":"scottschurr/rippled","owner":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?v=3","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scottschurr/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/scottschurr/rippled","forks_url":"https://api.github.com/repos/scottschurr/rippled/forks","keys_url":"https://api.github.com/repos/scottschurr/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scottschurr/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scottschurr/rippled/teams","hooks_url":"https://api.github.com/repos/scottschurr/rippled/hooks","issue_events_url":"https://api.github.com/repos/scottschurr/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/scottschurr/rippled/events","assignees_url":"https://api.github.com/repos/scottschurr/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/scottschurr/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/scottschurr/rippled/tags","blobs_url":"https://api.github.com/repos/scottschurr/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scottschurr/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scottschurr/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/scottschurr/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scottschurr/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/scottschurr/rippled/languages","stargazers_url":"https://api.github.com/repos/scottschurr/rippled/stargazers","contributors_url":"https://api.github.com/repos/scottschurr/rippled/contributors","subscribers_url":"https://api.github.com/repos/scottschurr/rippled/subscribers","subscription_url":"https://api.github.com/repos/scottschurr/rippled/subscription","commits_url":"https://api.github.com/repos/scottschurr/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/scottschurr/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/scottschurr/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/scottschurr/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/scottschurr/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/scottschurr/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scottschurr/rippled/merges","archive_url":"https://api.github.com/repos/scottschurr/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scottschurr/rippled/downloads","issues_url":"https://api.github.com/repos/scottschurr/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/scottschurr/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/scottschurr/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/scottschurr/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scottschurr/rippled/labels{/name}","releases_url":"https://api.github.com/repos/scottschurr/rippled/releases{/id}","created_at":"2014-06-10T21:58:27Z","updated_at":"2016-01-15T01:44:41Z","pushed_at":"2016-01-21T02:28:19Z","git_url":"git://github.com/scottschurr/rippled.git","ssh_url":"git@github.com:scottschurr/rippled.git","clone_url":"https://github.com/scottschurr/rippled.git","svn_url":"https://github.com/scottschurr/rippled","homepage":"https://ripple.com","size":59600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"27673c1c3f27b34eb4b36d32506b37fce9933233","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2016-01-20T05:35:29Z","pushed_at":"2016-01-21T17:02:05Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":107950,"stargazers_count":1024,"watchers_count":1024,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"open_issues_count":138,"forks":303,"open_issues":138,"watchers":1024,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1497"},"html":{"href":"https://github.com/ripple/rippled/pull/1497"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1497"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1497/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1497/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1497/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/a7d91ee95e319969773b29afcd92503d84111694"}}}}