{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments/83691979","pull_request_review_id":4519033,"id":83691979,"diff_hunk":"@@ -197,15 +197,15 @@ def provision\n \n       @hosts.each do |host|\n         ip = get_ip\n-        hostname = ip.ip.gsub '.','-'\n-        host[:vmhostname] = hostname+'.rfc1918.puppetlabs.net'\n-        @logger.debug \"Provisioning #{host.name} (#{host[:vmhostname]})\"\n+        host[:vmhostname] = ip.ip.gsub! '.','-'","path":"lib/beaker/hypervisor/openstack.rb","position":7,"original_position":7,"commit_id":"a93de6490a8f33c29c1d3f1138632475e6797d45","original_commit_id":"a93de6490a8f33c29c1d3f1138632475e6797d45","user":{"login":"kevpl","id":8973629,"avatar_url":"https://avatars.githubusercontent.com/u/8973629?v=3","gravatar_id":"","url":"https://api.github.com/users/kevpl","html_url":"https://github.com/kevpl","followers_url":"https://api.github.com/users/kevpl/followers","following_url":"https://api.github.com/users/kevpl/following{/other_user}","gists_url":"https://api.github.com/users/kevpl/gists{/gist_id}","starred_url":"https://api.github.com/users/kevpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevpl/subscriptions","organizations_url":"https://api.github.com/users/kevpl/orgs","repos_url":"https://api.github.com/users/kevpl/repos","events_url":"https://api.github.com/users/kevpl/events{/privacy}","received_events_url":"https://api.github.com/users/kevpl/received_events","type":"User","site_admin":false},"body":"@spjmurray this was changed to the non-bang version recently in [this changeset](https://github.com/puppetlabs/beaker/commit/5f50452a3b5f70e15a423449684d2033a2488805). If you check that code out, it looks like it was setting it back to '.'s rather than '-'s just before the `host[:ip]` got set on line 237, so that code didn't change the `ip.ip` value.\r\n\r\nIt looks like you'd rather keep that value as '-'s here, and seem fine setting the `host[:ip]` to use those dashes. Was something broken using the '.'s? Or am I misunderstanding this code?","created_at":"2016-10-17T17:23:06Z","updated_at":"2016-10-17T17:23:37Z","html_url":"https://github.com/puppetlabs/beaker/pull/1259#discussion_r83691979","pull_request_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments/83691979"},"html":{"href":"https://github.com/puppetlabs/beaker/pull/1259#discussion_r83691979"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259","id":87462252,"html_url":"https://github.com/puppetlabs/beaker/pull/1259","diff_url":"https://github.com/puppetlabs/beaker/pull/1259.diff","patch_url":"https://github.com/puppetlabs/beaker/pull/1259.patch","issue_url":"https://api.github.com/repos/puppetlabs/beaker/issues/1259","number":1259,"state":"open","locked":false,"title":"(BKR-949) Fix Keypair Generation on OpenStack","user":{"login":"spjmurray","id":5549946,"avatar_url":"https://avatars.githubusercontent.com/u/5549946?v=3","gravatar_id":"","url":"https://api.github.com/users/spjmurray","html_url":"https://github.com/spjmurray","followers_url":"https://api.github.com/users/spjmurray/followers","following_url":"https://api.github.com/users/spjmurray/following{/other_user}","gists_url":"https://api.github.com/users/spjmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/spjmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spjmurray/subscriptions","organizations_url":"https://api.github.com/users/spjmurray/orgs","repos_url":"https://api.github.com/users/spjmurray/repos","events_url":"https://api.github.com/users/spjmurray/events{/privacy}","received_events_url":"https://api.github.com/users/spjmurray/received_events","type":"User","site_admin":false},"body":"Fixes a regression in 2.51.0 whereby the hostname was updated to be based upon the\r\nserver IP, and get a domain.  Random keypair generation is based upon this hostname\r\nhowever OpenStack deems the period character unsafe, therefore this functionality\r\ngot broken.  This commit attaches both the hostname and fqdn to the host object.  To\r\nmaintain backwards compatibility all references to vmhostname now refer to vmfqdn.\r\nKey generation now uses the safe vmhostname variable, and clean up uses vm.key_name\r\ncached in the Fog Server object.","created_at":"2016-09-30T09:33:13Z","updated_at":"2016-10-17T17:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd5d950b35e7a77bf20455b119735bfbe5aa94a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/beaker/issues/1259/comments","statuses_url":"https://api.github.com/repos/puppetlabs/beaker/statuses/a93de6490a8f33c29c1d3f1138632475e6797d45","head":{"label":"spjmurray:bkr949_fix_keypairs","ref":"bkr949_fix_keypairs","sha":"a93de6490a8f33c29c1d3f1138632475e6797d45","user":{"login":"spjmurray","id":5549946,"avatar_url":"https://avatars.githubusercontent.com/u/5549946?v=3","gravatar_id":"","url":"https://api.github.com/users/spjmurray","html_url":"https://github.com/spjmurray","followers_url":"https://api.github.com/users/spjmurray/followers","following_url":"https://api.github.com/users/spjmurray/following{/other_user}","gists_url":"https://api.github.com/users/spjmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/spjmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spjmurray/subscriptions","organizations_url":"https://api.github.com/users/spjmurray/orgs","repos_url":"https://api.github.com/users/spjmurray/repos","events_url":"https://api.github.com/users/spjmurray/events{/privacy}","received_events_url":"https://api.github.com/users/spjmurray/received_events","type":"User","site_admin":false},"repo":{"id":35657708,"name":"beaker","full_name":"spjmurray/beaker","owner":{"login":"spjmurray","id":5549946,"avatar_url":"https://avatars.githubusercontent.com/u/5549946?v=3","gravatar_id":"","url":"https://api.github.com/users/spjmurray","html_url":"https://github.com/spjmurray","followers_url":"https://api.github.com/users/spjmurray/followers","following_url":"https://api.github.com/users/spjmurray/following{/other_user}","gists_url":"https://api.github.com/users/spjmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/spjmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spjmurray/subscriptions","organizations_url":"https://api.github.com/users/spjmurray/orgs","repos_url":"https://api.github.com/users/spjmurray/repos","events_url":"https://api.github.com/users/spjmurray/events{/privacy}","received_events_url":"https://api.github.com/users/spjmurray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spjmurray/beaker","description":"Puppet Acceptance Testing Harness","fork":true,"url":"https://api.github.com/repos/spjmurray/beaker","forks_url":"https://api.github.com/repos/spjmurray/beaker/forks","keys_url":"https://api.github.com/repos/spjmurray/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spjmurray/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spjmurray/beaker/teams","hooks_url":"https://api.github.com/repos/spjmurray/beaker/hooks","issue_events_url":"https://api.github.com/repos/spjmurray/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/spjmurray/beaker/events","assignees_url":"https://api.github.com/repos/spjmurray/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/spjmurray/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/spjmurray/beaker/tags","blobs_url":"https://api.github.com/repos/spjmurray/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spjmurray/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spjmurray/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/spjmurray/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spjmurray/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/spjmurray/beaker/languages","stargazers_url":"https://api.github.com/repos/spjmurray/beaker/stargazers","contributors_url":"https://api.github.com/repos/spjmurray/beaker/contributors","subscribers_url":"https://api.github.com/repos/spjmurray/beaker/subscribers","subscription_url":"https://api.github.com/repos/spjmurray/beaker/subscription","commits_url":"https://api.github.com/repos/spjmurray/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/spjmurray/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/spjmurray/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/spjmurray/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/spjmurray/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/spjmurray/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spjmurray/beaker/merges","archive_url":"https://api.github.com/repos/spjmurray/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spjmurray/beaker/downloads","issues_url":"https://api.github.com/repos/spjmurray/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/spjmurray/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/spjmurray/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/spjmurray/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spjmurray/beaker/labels{/name}","releases_url":"https://api.github.com/repos/spjmurray/beaker/releases{/id}","deployments_url":"https://api.github.com/repos/spjmurray/beaker/deployments","created_at":"2015-05-15T06:30:33Z","updated_at":"2016-09-30T09:31:00Z","pushed_at":"2016-09-30T09:31:46Z","git_url":"git://github.com/spjmurray/beaker.git","ssh_url":"git@github.com:spjmurray/beaker.git","clone_url":"https://github.com/spjmurray/beaker.git","svn_url":"https://github.com/spjmurray/beaker","homepage":"https://groups.google.com/forum/#!forum/puppet-beaker","size":12490,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"6bd87b00ecf24cc094c152f4c50df77e1b9ecdf3","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12164675,"name":"beaker","full_name":"puppetlabs/beaker","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/beaker","description":"Puppet Acceptance Testing Harness","fork":false,"url":"https://api.github.com/repos/puppetlabs/beaker","forks_url":"https://api.github.com/repos/puppetlabs/beaker/forks","keys_url":"https://api.github.com/repos/puppetlabs/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/beaker/teams","hooks_url":"https://api.github.com/repos/puppetlabs/beaker/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/beaker/events","assignees_url":"https://api.github.com/repos/puppetlabs/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/beaker/tags","blobs_url":"https://api.github.com/repos/puppetlabs/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/beaker/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/beaker/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/beaker/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/beaker/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/beaker/subscription","commits_url":"https://api.github.com/repos/puppetlabs/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/beaker/merges","archive_url":"https://api.github.com/repos/puppetlabs/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/beaker/downloads","issues_url":"https://api.github.com/repos/puppetlabs/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/beaker/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/beaker/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/beaker/deployments","created_at":"2013-08-16T17:57:03Z","updated_at":"2016-10-12T13:16:44Z","pushed_at":"2016-10-17T17:21:28Z","git_url":"git://github.com/puppetlabs/beaker.git","ssh_url":"git@github.com:puppetlabs/beaker.git","clone_url":"https://github.com/puppetlabs/beaker.git","svn_url":"https://github.com/puppetlabs/beaker","homepage":"https://groups.google.com/forum/#!forum/puppet-beaker","size":16158,"stargazers_count":267,"watchers_count":267,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":10,"forks":243,"open_issues":10,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259"},"html":{"href":"https://github.com/puppetlabs/beaker/pull/1259"},"issue":{"href":"https://api.github.com/repos/puppetlabs/beaker/issues/1259"},"comments":{"href":"https://api.github.com/repos/puppetlabs/beaker/issues/1259/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/1259/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/beaker/statuses/a93de6490a8f33c29c1d3f1138632475e6797d45"}}}}
{"actor":{"display_login":"kevpl"}}