{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/84710504","pull_request_review_id":5470756,"id":84710504,"diff_hunk":"@@ -226,7 +226,7 @@ protected GrpcServiceOptions(\n   /**\n    * Returns a builder for API call settings.\n    */\n-  protected ApiCallSettings.Builder apiCallSettings() {\n+  protected UnaryApiCallSettings.Builder apiCallSettings() {","path":"google-cloud-core/src/main/java/com/google/cloud/GrpcServiceOptions.java","position":14,"original_position":14,"commit_id":"dd88e23830110e3ba601df51d08135597686ecf3","original_commit_id":"dd88e23830110e3ba601df51d08135597686ecf3","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"Yeah this is inconsistent. @shinfan , could you address the inconsistency? Maybe removing the `Api` from the names would be best. We needed `Api` on `ApiCallable` because using `Callable` on its own would be confusing due to the existing type in Java, but the other names don't have that problem. \r\n\r\n@mziccard it's not clear which class you are referencing when you say \"Should we consider renaming it?\" I can see how `PageStreamingCallSettings` might seem more related to `StreamingCallSettings`. Maybe we should call the first one `PagedListCallSettings`.\r\n\r\nDoes this scheme work?\r\n* `UnaryCallable` and `UnaryCallSettings`\r\n  * `PagedListCallSettings`\r\n* `StreamingCallable` and `StreamingCallSettings`\r\n","created_at":"2016-10-24T15:14:46Z","updated_at":"2016-10-24T15:14:47Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326#discussion_r84710504","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments/84710504"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326#discussion_r84710504"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326","id":90099042,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1326","number":1326,"state":"open","locked":false,"title":"Update spi classes with GAX 0.0.19","user":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"body":"- Add grpc streaming support\r\n- Rename ApiCallable to UnaryApiCallable\r\n- Rename ApiCallSettings to UnaryApiCallSettings","created_at":"2016-10-19T22:00:40Z","updated_at":"2016-10-24T15:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25387359bd0b5cf8ea93bcc73499f4ba4429cce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1326/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/dd88e23830110e3ba601df51d08135597686ecf3","head":{"label":"shinfan:master","ref":"master","sha":"dd88e23830110e3ba601df51d08135597686ecf3","user":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"repo":{"id":54235715,"name":"gcloud-java","full_name":"shinfan/gcloud-java","owner":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinfan/gcloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/shinfan/gcloud-java","forks_url":"https://api.github.com/repos/shinfan/gcloud-java/forks","keys_url":"https://api.github.com/repos/shinfan/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinfan/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinfan/gcloud-java/teams","hooks_url":"https://api.github.com/repos/shinfan/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/shinfan/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/shinfan/gcloud-java/events","assignees_url":"https://api.github.com/repos/shinfan/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/shinfan/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/shinfan/gcloud-java/tags","blobs_url":"https://api.github.com/repos/shinfan/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinfan/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinfan/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinfan/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinfan/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/shinfan/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/shinfan/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/shinfan/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/shinfan/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/shinfan/gcloud-java/subscription","commits_url":"https://api.github.com/repos/shinfan/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinfan/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinfan/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinfan/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinfan/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/shinfan/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinfan/gcloud-java/merges","archive_url":"https://api.github.com/repos/shinfan/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinfan/gcloud-java/downloads","issues_url":"https://api.github.com/repos/shinfan/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/shinfan/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/shinfan/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/shinfan/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinfan/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/shinfan/gcloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/shinfan/gcloud-java/deployments","created_at":"2016-03-18T22:44:47Z","updated_at":"2016-03-18T22:44:48Z","pushed_at":"2016-10-19T21:57:55Z","git_url":"git://github.com/shinfan/gcloud-java.git","ssh_url":"git@github.com:shinfan/gcloud-java.git","clone_url":"https://github.com/shinfan/gcloud-java.git","svn_url":"https://github.com/shinfan/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":33565,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"8c9aca409f98f910569adba836be3f83e6dd0430","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"google-cloud-java","full_name":"GoogleCloudPlatform/google-cloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2016-10-23T17:32:43Z","pushed_at":"2016-10-24T11:41:18Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-java","homepage":"http://googlecloudplatform.github.io/google-cloud-java/","size":253984,"stargazers_count":173,"watchers_count":173,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"open_issues_count":126,"forks":88,"open_issues":126,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1326"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1326"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/1326/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/1326/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/statuses/dd88e23830110e3ba601df51d08135597686ecf3"}}}}
{"actor":{"display_login":"garrettjonesgoogle"}}