{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/78481937","id":78481937,"diff_hunk":"@@ -116,6 +116,10 @@ exports.rules = [\n   },\n   {\n     filesMatching: 'extensions/**/*.js',\n+    mustNotDependOn: '3p/**/*.js',\n+  },\n+  {\n+    filesMatching: 'extensions/**/*.js',","path":"build-system/dep-check-config.js","position":7,"original_position":7,"commit_id":"08fb00f2cfd9e7a14e0eeb9eda268b67d27e4e53","original_commit_id":"08fb00f2cfd9e7a14e0eeb9eda268b67d27e4e53","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"can we move this to the config that already exists? just do:\r\n\r\n```js\r\n  {\r\n    filesMatching: '{src,extensions}/**/*.js',\r\n    mustNotDependOn: '3p/**/*.js',\r\n  },\r\n\r\n```\r\n","created_at":"2016-09-13T01:05:38Z","updated_at":"2016-09-13T01:05:38Z","html_url":"https://github.com/ampproject/amphtml/pull/4952#discussion_r78481937","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4952","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/78481937"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4952#discussion_r78481937"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4952"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4952","id":84970009,"html_url":"https://github.com/ampproject/amphtml/pull/4952","diff_url":"https://github.com/ampproject/amphtml/pull/4952.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4952.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4952","number":4952,"state":"open","locked":false,"title":"dep-check fix: extension must not depend on 3p","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-13T01:01:00Z","updated_at":"2016-09-13T01:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4232242ea28beaae2d8d12f7f28857f8c8a1fcf8","assignee":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"assignees":[{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4952/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4952/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4952/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/08fb00f2cfd9e7a14e0eeb9eda268b67d27e4e53","head":{"label":"zhouyx:fix-dep-check","ref":"fix-dep-check","sha":"08fb00f2cfd9e7a14e0eeb9eda268b67d27e4e53","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"repo":{"id":55454453,"name":"amphtml","full_name":"zhouyx/amphtml","owner":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhouyx/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/zhouyx/amphtml","forks_url":"https://api.github.com/repos/zhouyx/amphtml/forks","keys_url":"https://api.github.com/repos/zhouyx/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhouyx/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhouyx/amphtml/teams","hooks_url":"https://api.github.com/repos/zhouyx/amphtml/hooks","issue_events_url":"https://api.github.com/repos/zhouyx/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/zhouyx/amphtml/events","assignees_url":"https://api.github.com/repos/zhouyx/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/zhouyx/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/zhouyx/amphtml/tags","blobs_url":"https://api.github.com/repos/zhouyx/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhouyx/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhouyx/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhouyx/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhouyx/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/zhouyx/amphtml/languages","stargazers_url":"https://api.github.com/repos/zhouyx/amphtml/stargazers","contributors_url":"https://api.github.com/repos/zhouyx/amphtml/contributors","subscribers_url":"https://api.github.com/repos/zhouyx/amphtml/subscribers","subscription_url":"https://api.github.com/repos/zhouyx/amphtml/subscription","commits_url":"https://api.github.com/repos/zhouyx/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhouyx/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhouyx/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhouyx/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhouyx/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/zhouyx/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhouyx/amphtml/merges","archive_url":"https://api.github.com/repos/zhouyx/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhouyx/amphtml/downloads","issues_url":"https://api.github.com/repos/zhouyx/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/zhouyx/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/zhouyx/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/zhouyx/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhouyx/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/zhouyx/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/zhouyx/amphtml/deployments","created_at":"2016-04-05T00:10:42Z","updated_at":"2016-04-05T00:10:45Z","pushed_at":"2016-09-13T00:59:49Z","git_url":"git://github.com/zhouyx/amphtml.git","ssh_url":"git@github.com:zhouyx/amphtml.git","clone_url":"https://github.com/zhouyx/amphtml.git","svn_url":"https://github.com/zhouyx/amphtml","homepage":"https://ampproject.org","size":155593,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"5d16474f0e4f7b8a6662e0237d7a1ac34e3cc3e8","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-09-13T00:55:36Z","pushed_at":"2016-09-13T01:01:00Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":194580,"stargazers_count":8439,"watchers_count":8439,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1244,"mirror_url":null,"open_issues_count":738,"forks":1244,"open_issues":738,"watchers":8439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4952"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4952"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4952"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4952/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4952/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4952/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/08fb00f2cfd9e7a14e0eeb9eda268b67d27e4e53"}}}}
{"actor":{"display_login":"erwinmombay"}}