{"action":"created","comment":{"url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/comments/68935785","id":68935785,"diff_hunk":"@@ -28,11 +28,21 @@ class ProductConfigurator(models.AbstractModel):\n     name = fields.Char()\n \n     @api.multi\n-    @api.depends('product_attribute_ids', 'product_attribute_ids.value_id')\n+    @api.depends('product_attribute_ids', 'product_attribute_ids.value_id',\n+                 'product_id')\n     def _compute_price_extra(self):\n         for record in self:\n-            record.price_extra = sum(\n-                record.mapped('product_attribute_ids.price_extra'))\n+            if record.product_id:","path":"product_variants_no_automatic_creation/models/product_configurator.py","position":11,"original_position":11,"commit_id":"965cf9b0289f16008c90fc764ec59d9bde922f4b","original_commit_id":"965cf9b0289f16008c90fc764ec59d9bde922f4b","user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"Sí, perdona, lo he dicho mal.","created_at":"2016-06-29T12:20:56Z","updated_at":"2016-06-29T12:20:56Z","html_url":"https://github.com/odoomrp/odoomrp-wip/pull/1252#discussion_r68935785","pull_request_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252","_links":{"self":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/comments/68935785"},"html":{"href":"https://github.com/odoomrp/odoomrp-wip/pull/1252#discussion_r68935785"},"pull_request":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252"}}},"pull_request":{"url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252","id":75437071,"html_url":"https://github.com/odoomrp/odoomrp-wip/pull/1252","diff_url":"https://github.com/odoomrp/odoomrp-wip/pull/1252.diff","patch_url":"https://github.com/odoomrp/odoomrp-wip/pull/1252.patch","issue_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/1252","number":1252,"state":"open","locked":false,"title":"[FIX] product_variants_no_automatic_creation: Bug Product attribute e…","user":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"body":" Bug Product attribute extra prices are not automatically added.","created_at":"2016-06-28T08:28:54Z","updated_at":"2016-06-29T12:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03dc047ba5fd5448b96343f069e43a4b15e65e4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252/commits","review_comments_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252/comments","review_comment_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/1252/comments","statuses_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/statuses/965cf9b0289f16008c90fc764ec59d9bde922f4b","head":{"label":"Daniel-CA:product_variants_no_automatic_creation","ref":"product_variants_no_automatic_creation","sha":"965cf9b0289f16008c90fc764ec59d9bde922f4b","user":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"repo":{"id":24584015,"name":"odoomrp-wip-public","full_name":"Daniel-CA/odoomrp-wip-public","owner":{"login":"Daniel-CA","id":7643575,"avatar_url":"https://avatars.githubusercontent.com/u/7643575?v=3","gravatar_id":"","url":"https://api.github.com/users/Daniel-CA","html_url":"https://github.com/Daniel-CA","followers_url":"https://api.github.com/users/Daniel-CA/followers","following_url":"https://api.github.com/users/Daniel-CA/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-CA/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-CA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-CA/subscriptions","organizations_url":"https://api.github.com/users/Daniel-CA/orgs","repos_url":"https://api.github.com/users/Daniel-CA/repos","events_url":"https://api.github.com/users/Daniel-CA/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-CA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Daniel-CA/odoomrp-wip-public","description":"WIP of OdooMRP","fork":true,"url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public","forks_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/forks","keys_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/teams","hooks_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/hooks","issue_events_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/issues/events{/number}","events_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/events","assignees_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/assignees{/user}","branches_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/branches{/branch}","tags_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/tags","blobs_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/git/refs{/sha}","trees_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/statuses/{sha}","languages_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/languages","stargazers_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/stargazers","contributors_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/contributors","subscribers_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/subscribers","subscription_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/subscription","commits_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/commits{/sha}","git_commits_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/git/commits{/sha}","comments_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/comments{/number}","issue_comment_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/issues/comments{/number}","contents_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/contents/{+path}","compare_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/merges","archive_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/downloads","issues_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/issues{/number}","pulls_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/pulls{/number}","milestones_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/milestones{/number}","notifications_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/labels{/name}","releases_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/releases{/id}","deployments_url":"https://api.github.com/repos/Daniel-CA/odoomrp-wip-public/deployments","created_at":"2014-09-29T07:26:12Z","updated_at":"2016-02-26T11:51:28Z","pushed_at":"2016-06-29T09:40:52Z","git_url":"git://github.com/Daniel-CA/odoomrp-wip-public.git","ssh_url":"git@github.com:Daniel-CA/odoomrp-wip-public.git","clone_url":"https://github.com/Daniel-CA/odoomrp-wip-public.git","svn_url":"https://github.com/Daniel-CA/odoomrp-wip-public","homepage":"http://www.odoomrp.com","size":5158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"odoomrp:8.0","ref":"8.0","sha":"f4964592a5ea8ea809bf81f619f8a87731b7ded4","user":{"login":"odoomrp","id":7858947,"avatar_url":"https://avatars.githubusercontent.com/u/7858947?v=3","gravatar_id":"","url":"https://api.github.com/users/odoomrp","html_url":"https://github.com/odoomrp","followers_url":"https://api.github.com/users/odoomrp/followers","following_url":"https://api.github.com/users/odoomrp/following{/other_user}","gists_url":"https://api.github.com/users/odoomrp/gists{/gist_id}","starred_url":"https://api.github.com/users/odoomrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoomrp/subscriptions","organizations_url":"https://api.github.com/users/odoomrp/orgs","repos_url":"https://api.github.com/users/odoomrp/repos","events_url":"https://api.github.com/users/odoomrp/events{/privacy}","received_events_url":"https://api.github.com/users/odoomrp/received_events","type":"Organization","site_admin":false},"repo":{"id":22124768,"name":"odoomrp-wip","full_name":"odoomrp/odoomrp-wip","owner":{"login":"odoomrp","id":7858947,"avatar_url":"https://avatars.githubusercontent.com/u/7858947?v=3","gravatar_id":"","url":"https://api.github.com/users/odoomrp","html_url":"https://github.com/odoomrp","followers_url":"https://api.github.com/users/odoomrp/followers","following_url":"https://api.github.com/users/odoomrp/following{/other_user}","gists_url":"https://api.github.com/users/odoomrp/gists{/gist_id}","starred_url":"https://api.github.com/users/odoomrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoomrp/subscriptions","organizations_url":"https://api.github.com/users/odoomrp/orgs","repos_url":"https://api.github.com/users/odoomrp/repos","events_url":"https://api.github.com/users/odoomrp/events{/privacy}","received_events_url":"https://api.github.com/users/odoomrp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoomrp/odoomrp-wip","description":"WIP of OdooMRP","fork":false,"url":"https://api.github.com/repos/odoomrp/odoomrp-wip","forks_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/forks","keys_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/teams","hooks_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/hooks","issue_events_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/events{/number}","events_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/events","assignees_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/assignees{/user}","branches_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/branches{/branch}","tags_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/tags","blobs_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/statuses/{sha}","languages_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/languages","stargazers_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/stargazers","contributors_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/contributors","subscribers_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/subscribers","subscription_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/subscription","commits_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/contents/{+path}","compare_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/merges","archive_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/downloads","issues_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues{/number}","pulls_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls{/number}","milestones_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/milestones{/number}","notifications_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/labels{/name}","releases_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/releases{/id}","deployments_url":"https://api.github.com/repos/odoomrp/odoomrp-wip/deployments","created_at":"2014-07-22T23:29:59Z","updated_at":"2016-06-29T09:17:05Z","pushed_at":"2016-06-29T09:40:52Z","git_url":"git://github.com/odoomrp/odoomrp-wip.git","ssh_url":"git@github.com:odoomrp/odoomrp-wip.git","clone_url":"https://github.com/odoomrp/odoomrp-wip.git","svn_url":"https://github.com/odoomrp/odoomrp-wip","homepage":"http://www.odoomrp.com","size":6697,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":68,"forks":186,"open_issues":68,"watchers":76,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252"},"html":{"href":"https://github.com/odoomrp/odoomrp-wip/pull/1252"},"issue":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/1252"},"comments":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/issues/1252/comments"},"review_comments":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252/comments"},"review_comment":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/pulls/1252/commits"},"statuses":{"href":"https://api.github.com/repos/odoomrp/odoomrp-wip/statuses/965cf9b0289f16008c90fc764ec59d9bde922f4b"}}}}
{"actor":{"display_login":"pedrobaeza"}}