{"action":"created","issue":{"url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/1","repository_url":"https://api.github.com/repos/EikosPartners/Knockout-Validation","labels_url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/1/comments","events_url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/1/events","html_url":"https://github.com/EikosPartners/Knockout-Validation/pull/1","id":187146650,"number":1,"title":"Added tests for severity","user":{"login":"Hekku2","id":2670916,"avatar_url":"https://avatars.githubusercontent.com/u/2670916?v=3","gravatar_id":"","url":"https://api.github.com/users/Hekku2","html_url":"https://github.com/Hekku2","followers_url":"https://api.github.com/users/Hekku2/followers","following_url":"https://api.github.com/users/Hekku2/following{/other_user}","gists_url":"https://api.github.com/users/Hekku2/gists{/gist_id}","starred_url":"https://api.github.com/users/Hekku2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hekku2/subscriptions","organizations_url":"https://api.github.com/users/Hekku2/orgs","repos_url":"https://api.github.com/users/Hekku2/repos","events_url":"https://api.github.com/users/Hekku2/events{/privacy}","received_events_url":"https://api.github.com/users/Hekku2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-03T18:04:57Z","updated_at":"2016-11-03T18:39:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/pulls/1","html_url":"https://github.com/EikosPartners/Knockout-Validation/pull/1","diff_url":"https://github.com/EikosPartners/Knockout-Validation/pull/1.diff","patch_url":"https://github.com/EikosPartners/Knockout-Validation/pull/1.patch"},"body":"- Added tests for related items\r\n- Fixed broken tests\r\n- Fixed jshint-warnings\r\n- Fixed case where observable with severity-function defined causes errors. This can happen when for example 'equal'-rule is used and it refers to validatable observable."},"comment":{"url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/comments/258235763","html_url":"https://github.com/EikosPartners/Knockout-Validation/pull/1#issuecomment-258235763","issue_url":"https://api.github.com/repos/EikosPartners/Knockout-Validation/issues/1","id":258235763,"user":{"login":"egucciar","id":2848185,"avatar_url":"https://avatars.githubusercontent.com/u/2848185?v=3","gravatar_id":"","url":"https://api.github.com/users/egucciar","html_url":"https://github.com/egucciar","followers_url":"https://api.github.com/users/egucciar/followers","following_url":"https://api.github.com/users/egucciar/following{/other_user}","gists_url":"https://api.github.com/users/egucciar/gists{/gist_id}","starred_url":"https://api.github.com/users/egucciar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egucciar/subscriptions","organizations_url":"https://api.github.com/users/egucciar/orgs","repos_url":"https://api.github.com/users/egucciar/repos","events_url":"https://api.github.com/users/egucciar/events{/privacy}","received_events_url":"https://api.github.com/users/egucciar/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T18:39:10Z","updated_at":"2016-11-03T18:39:10Z","body":"due to the fact we are using this lib in many places already I am hesitant to introduce a breaking change to our code.\r\n\r\nLet's think of this from another perspective, in your first commit you disregard all params which are observables, that didn't work for my use case, but I don't have a usecase where I actually require params to be a *validated* observable. Why not check if the severity property is observable and return only then? That was both our usecases get satisfied without having to introduce breaking API changes within the code.\r\n\r\n`params && !ko.isObservable(params.severity)`"}}
{"actor":{"display_login":"egucciar"}}