{"action":"created","comment":{"url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/comments/66736313","id":66736313,"diff_hunk":"@@ -21,23 +21,25 @@\n     default => false,\n   }\n \n-  if $openntp::service_restart == $openntp::params::service_restart {\n-    # The restart script does not properly check if the service is actually stopped; hence, the start command can fail\n-    # to start the service because it is still running. This script checks the status and issues the start command as\n-    # soon as the service is actually stopped.\n+  if $openntp::service_restart != undef {\n+    if $openntp::service_restart == $openntp::params::service_restart {","path":"manifests/service.pp","position":9,"original_position":9,"commit_id":"81288f7420bbd9612e0da119aa8ea3fded791d1b","original_commit_id":"81288f7420bbd9612e0da119aa8ea3fded791d1b","user":{"login":"tohuwabohu","id":7029238,"avatar_url":"https://avatars.githubusercontent.com/u/7029238?v=3","gravatar_id":"","url":"https://api.github.com/users/tohuwabohu","html_url":"https://github.com/tohuwabohu","followers_url":"https://api.github.com/users/tohuwabohu/followers","following_url":"https://api.github.com/users/tohuwabohu/following{/other_user}","gists_url":"https://api.github.com/users/tohuwabohu/gists{/gist_id}","starred_url":"https://api.github.com/users/tohuwabohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohuwabohu/subscriptions","organizations_url":"https://api.github.com/users/tohuwabohu/orgs","repos_url":"https://api.github.com/users/tohuwabohu/repos","events_url":"https://api.github.com/users/tohuwabohu/events{/privacy}","received_events_url":"https://api.github.com/users/tohuwabohu/received_events","type":"User","site_admin":false},"body":"hmm k. Looks like YAGNI to me but I'm happy to roll with it for the moment.","created_at":"2016-06-13T03:23:06Z","updated_at":"2016-06-13T03:23:06Z","html_url":"https://github.com/tohuwabohu/puppet-openntp/pull/6#discussion_r66736313","pull_request_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/comments/66736313"},"html":{"href":"https://github.com/tohuwabohu/puppet-openntp/pull/6#discussion_r66736313"},"pull_request":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6","id":70520762,"html_url":"https://github.com/tohuwabohu/puppet-openntp/pull/6","diff_url":"https://github.com/tohuwabohu/puppet-openntp/pull/6.diff","patch_url":"https://github.com/tohuwabohu/puppet-openntp/pull/6.patch","issue_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/6","number":6,"state":"open","locked":false,"title":"added support for FreeBSD","user":{"login":"alxwr","id":1920805,"avatar_url":"https://avatars.githubusercontent.com/u/1920805?v=3","gravatar_id":"","url":"https://api.github.com/users/alxwr","html_url":"https://github.com/alxwr","followers_url":"https://api.github.com/users/alxwr/followers","following_url":"https://api.github.com/users/alxwr/following{/other_user}","gists_url":"https://api.github.com/users/alxwr/gists{/gist_id}","starred_url":"https://api.github.com/users/alxwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxwr/subscriptions","organizations_url":"https://api.github.com/users/alxwr/orgs","repos_url":"https://api.github.com/users/alxwr/repos","events_url":"https://api.github.com/users/alxwr/events{/privacy}","received_events_url":"https://api.github.com/users/alxwr/received_events","type":"User","site_admin":false},"body":"Tested on Ubuntu 15.10 and FreeBSD 10.\r\nI'm planning to stick with this module and provide updates for FreeBSD if needed. :-)\r\n\r\nThanks for sharing!","created_at":"2016-05-18T12:43:16Z","updated_at":"2016-06-13T03:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77cc41622608f2c99f11c7ff41d5b3c2e9de3b6d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6/commits","review_comments_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6/comments","review_comment_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/6/comments","statuses_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/statuses/81288f7420bbd9612e0da119aa8ea3fded791d1b","head":{"label":"alxwr:freebsd-support","ref":"freebsd-support","sha":"81288f7420bbd9612e0da119aa8ea3fded791d1b","user":{"login":"alxwr","id":1920805,"avatar_url":"https://avatars.githubusercontent.com/u/1920805?v=3","gravatar_id":"","url":"https://api.github.com/users/alxwr","html_url":"https://github.com/alxwr","followers_url":"https://api.github.com/users/alxwr/followers","following_url":"https://api.github.com/users/alxwr/following{/other_user}","gists_url":"https://api.github.com/users/alxwr/gists{/gist_id}","starred_url":"https://api.github.com/users/alxwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxwr/subscriptions","organizations_url":"https://api.github.com/users/alxwr/orgs","repos_url":"https://api.github.com/users/alxwr/repos","events_url":"https://api.github.com/users/alxwr/events{/privacy}","received_events_url":"https://api.github.com/users/alxwr/received_events","type":"User","site_admin":false},"repo":{"id":59113891,"name":"puppet-openntp","full_name":"alxwr/puppet-openntp","owner":{"login":"alxwr","id":1920805,"avatar_url":"https://avatars.githubusercontent.com/u/1920805?v=3","gravatar_id":"","url":"https://api.github.com/users/alxwr","html_url":"https://github.com/alxwr","followers_url":"https://api.github.com/users/alxwr/followers","following_url":"https://api.github.com/users/alxwr/following{/other_user}","gists_url":"https://api.github.com/users/alxwr/gists{/gist_id}","starred_url":"https://api.github.com/users/alxwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxwr/subscriptions","organizations_url":"https://api.github.com/users/alxwr/orgs","repos_url":"https://api.github.com/users/alxwr/repos","events_url":"https://api.github.com/users/alxwr/events{/privacy}","received_events_url":"https://api.github.com/users/alxwr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alxwr/puppet-openntp","description":"Puppet module to manage the OpenNTP server","fork":true,"url":"https://api.github.com/repos/alxwr/puppet-openntp","forks_url":"https://api.github.com/repos/alxwr/puppet-openntp/forks","keys_url":"https://api.github.com/repos/alxwr/puppet-openntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alxwr/puppet-openntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alxwr/puppet-openntp/teams","hooks_url":"https://api.github.com/repos/alxwr/puppet-openntp/hooks","issue_events_url":"https://api.github.com/repos/alxwr/puppet-openntp/issues/events{/number}","events_url":"https://api.github.com/repos/alxwr/puppet-openntp/events","assignees_url":"https://api.github.com/repos/alxwr/puppet-openntp/assignees{/user}","branches_url":"https://api.github.com/repos/alxwr/puppet-openntp/branches{/branch}","tags_url":"https://api.github.com/repos/alxwr/puppet-openntp/tags","blobs_url":"https://api.github.com/repos/alxwr/puppet-openntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alxwr/puppet-openntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alxwr/puppet-openntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/alxwr/puppet-openntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alxwr/puppet-openntp/statuses/{sha}","languages_url":"https://api.github.com/repos/alxwr/puppet-openntp/languages","stargazers_url":"https://api.github.com/repos/alxwr/puppet-openntp/stargazers","contributors_url":"https://api.github.com/repos/alxwr/puppet-openntp/contributors","subscribers_url":"https://api.github.com/repos/alxwr/puppet-openntp/subscribers","subscription_url":"https://api.github.com/repos/alxwr/puppet-openntp/subscription","commits_url":"https://api.github.com/repos/alxwr/puppet-openntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/alxwr/puppet-openntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/alxwr/puppet-openntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/alxwr/puppet-openntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/alxwr/puppet-openntp/contents/{+path}","compare_url":"https://api.github.com/repos/alxwr/puppet-openntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alxwr/puppet-openntp/merges","archive_url":"https://api.github.com/repos/alxwr/puppet-openntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alxwr/puppet-openntp/downloads","issues_url":"https://api.github.com/repos/alxwr/puppet-openntp/issues{/number}","pulls_url":"https://api.github.com/repos/alxwr/puppet-openntp/pulls{/number}","milestones_url":"https://api.github.com/repos/alxwr/puppet-openntp/milestones{/number}","notifications_url":"https://api.github.com/repos/alxwr/puppet-openntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alxwr/puppet-openntp/labels{/name}","releases_url":"https://api.github.com/repos/alxwr/puppet-openntp/releases{/id}","deployments_url":"https://api.github.com/repos/alxwr/puppet-openntp/deployments","created_at":"2016-05-18T12:33:55Z","updated_at":"2016-05-18T12:33:56Z","pushed_at":"2016-05-18T23:34:08Z","git_url":"git://github.com/alxwr/puppet-openntp.git","ssh_url":"git@github.com:alxwr/puppet-openntp.git","clone_url":"https://github.com/alxwr/puppet-openntp.git","svn_url":"https://github.com/alxwr/puppet-openntp","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tohuwabohu:master","ref":"master","sha":"87efb172a14cbbd26751e7a8cfb81abf25794279","user":{"login":"tohuwabohu","id":7029238,"avatar_url":"https://avatars.githubusercontent.com/u/7029238?v=3","gravatar_id":"","url":"https://api.github.com/users/tohuwabohu","html_url":"https://github.com/tohuwabohu","followers_url":"https://api.github.com/users/tohuwabohu/followers","following_url":"https://api.github.com/users/tohuwabohu/following{/other_user}","gists_url":"https://api.github.com/users/tohuwabohu/gists{/gist_id}","starred_url":"https://api.github.com/users/tohuwabohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohuwabohu/subscriptions","organizations_url":"https://api.github.com/users/tohuwabohu/orgs","repos_url":"https://api.github.com/users/tohuwabohu/repos","events_url":"https://api.github.com/users/tohuwabohu/events{/privacy}","received_events_url":"https://api.github.com/users/tohuwabohu/received_events","type":"User","site_admin":false},"repo":{"id":18031171,"name":"puppet-openntp","full_name":"tohuwabohu/puppet-openntp","owner":{"login":"tohuwabohu","id":7029238,"avatar_url":"https://avatars.githubusercontent.com/u/7029238?v=3","gravatar_id":"","url":"https://api.github.com/users/tohuwabohu","html_url":"https://github.com/tohuwabohu","followers_url":"https://api.github.com/users/tohuwabohu/followers","following_url":"https://api.github.com/users/tohuwabohu/following{/other_user}","gists_url":"https://api.github.com/users/tohuwabohu/gists{/gist_id}","starred_url":"https://api.github.com/users/tohuwabohu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohuwabohu/subscriptions","organizations_url":"https://api.github.com/users/tohuwabohu/orgs","repos_url":"https://api.github.com/users/tohuwabohu/repos","events_url":"https://api.github.com/users/tohuwabohu/events{/privacy}","received_events_url":"https://api.github.com/users/tohuwabohu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tohuwabohu/puppet-openntp","description":"Puppet module to manage the OpenNTP server","fork":false,"url":"https://api.github.com/repos/tohuwabohu/puppet-openntp","forks_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/forks","keys_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/teams","hooks_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/hooks","issue_events_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/events{/number}","events_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/events","assignees_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/assignees{/user}","branches_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/branches{/branch}","tags_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/tags","blobs_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/statuses/{sha}","languages_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/languages","stargazers_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/stargazers","contributors_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/contributors","subscribers_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/subscribers","subscription_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/subscription","commits_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/contents/{+path}","compare_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/merges","archive_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/downloads","issues_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues{/number}","pulls_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls{/number}","milestones_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/milestones{/number}","notifications_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/labels{/name}","releases_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/releases{/id}","deployments_url":"https://api.github.com/repos/tohuwabohu/puppet-openntp/deployments","created_at":"2014-03-23T10:42:30Z","updated_at":"2016-01-11T09:12:13Z","pushed_at":"2016-05-18T23:34:09Z","git_url":"git://github.com/tohuwabohu/puppet-openntp.git","ssh_url":"git@github.com:tohuwabohu/puppet-openntp.git","clone_url":"https://github.com/tohuwabohu/puppet-openntp.git","svn_url":"https://github.com/tohuwabohu/puppet-openntp","homepage":null,"size":65,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6"},"html":{"href":"https://github.com/tohuwabohu/puppet-openntp/pull/6"},"issue":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/6"},"comments":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/tohuwabohu/puppet-openntp/statuses/81288f7420bbd9612e0da119aa8ea3fded791d1b"}}}}
{"actor":{"display_login":"tohuwabohu"}}