{"action":"created","issue":{"url":"https://api.github.com/repos/carlosperate/ardublockly/issues/67","repository_url":"https://api.github.com/repos/carlosperate/ardublockly","labels_url":"https://api.github.com/repos/carlosperate/ardublockly/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/carlosperate/ardublockly/issues/67/comments","events_url":"https://api.github.com/repos/carlosperate/ardublockly/issues/67/events","html_url":"https://github.com/carlosperate/ardublockly/issues/67","id":147128416,"number":67,"title":"Translation of typeName required","user":{"login":"bmcage","id":1011414,"avatar_url":"https://avatars.githubusercontent.com/u/1011414?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcage","html_url":"https://github.com/bmcage","followers_url":"https://api.github.com/users/bmcage/followers","following_url":"https://api.github.com/users/bmcage/following{/other_user}","gists_url":"https://api.github.com/users/bmcage/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcage/subscriptions","organizations_url":"https://api.github.com/users/bmcage/orgs","repos_url":"https://api.github.com/users/bmcage/repos","events_url":"https://api.github.com/users/bmcage/events{/privacy}","received_events_url":"https://api.github.com/users/bmcage/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-09T13:16:32Z","updated_at":"2016-04-10T18:52:03Z","closed_at":null,"body":"I see quite some code checking on typeName, and not on typeKey.\r\n\r\nI want to translate typeName, as that is always English in the currect method.\r\nI see \r\n\r\n      typesArray.push([Blockly.Types[typeKey].typeName, typeKey]);\r\n\r\nSo from a selection in the dropdown of the cast block typeKey is returned. However, a grep search on typeName show it used a lot, eg in arduino.js, `switch (typeBlockly.typeName) { `\r\n\r\nSo, how to translate. Will changing in types.js \r\n\r\n      typeName: 'Character',\r\n\r\ninto \r\n\r\n      typeName: Blockly.Msg.ARD_TYPE_CHARACTER,\r\n\r\nand then the translations everywhere just work ?\r\n"},"comment":{"url":"https://api.github.com/repos/carlosperate/ardublockly/issues/comments/208043568","html_url":"https://github.com/carlosperate/ardublockly/issues/67#issuecomment-208043568","issue_url":"https://api.github.com/repos/carlosperate/ardublockly/issues/67","id":208043568,"user":{"login":"carlosperate","id":4189262,"avatar_url":"https://avatars.githubusercontent.com/u/4189262?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosperate","html_url":"https://github.com/carlosperate","followers_url":"https://api.github.com/users/carlosperate/followers","following_url":"https://api.github.com/users/carlosperate/following{/other_user}","gists_url":"https://api.github.com/users/carlosperate/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosperate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosperate/subscriptions","organizations_url":"https://api.github.com/users/carlosperate/orgs","repos_url":"https://api.github.com/users/carlosperate/repos","events_url":"https://api.github.com/users/carlosperate/events{/privacy}","received_events_url":"https://api.github.com/users/carlosperate/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T18:52:03Z","updated_at":"2016-04-10T18:52:03Z","body":"If you are refering to the TypeName from [blockly/core/type.js](https://github.com/carlosperate/ardublockly/blob/4f8dd66cfdf0f91aa3e56b1afbacfeebd007de35/blockly/core/type.js#L33), then it perhaps should not be translated, it is really meat to be an internal string used for \"type\" identification on Blockly. Then the code generator will translate that to whatever the code represnetation is like in [blockly/generators/arduino.js](https://github.com/carlosperate/ardublockly/blob/4f8dd66cfdf0f91aa3e56b1afbacfeebd007de35/blockly/generators/arduino.js#L370).\r\n\r\nHowever, as you say, that same string is then used for that dropdown, so I think we should be deal with that translation in the in [blockly/core/types.js](https://github.com/carlosperate/ardublockly/blob/4f8dd66cfdf0f91aa3e56b1afbacfeebd007de35/blockly/core/types.js#L131) `Blockly.Types.getValidTypeArray` function and rename it to something a bit more representation of its new expanded functionality."}}