{"action":"opened","number":3572,"pull_request":{"url":"https://api.github.com/repos/mapnik/mapnik/pulls/3572","id":97872088,"html_url":"https://github.com/mapnik/mapnik/pull/3572","diff_url":"https://github.com/mapnik/mapnik/pull/3572.diff","patch_url":"https://github.com/mapnik/mapnik/pull/3572.patch","issue_url":"https://api.github.com/repos/mapnik/mapnik/issues/3572","number":3572,"state":"open","locked":false,"title":"simplify mapnik::value conversion rules","user":{"login":"lightmare","id":1419852,"avatar_url":"https://avatars.githubusercontent.com/u/1419852?v=3","gravatar_id":"","url":"https://api.github.com/users/lightmare","html_url":"https://github.com/lightmare","followers_url":"https://api.github.com/users/lightmare/followers","following_url":"https://api.github.com/users/lightmare/following{/other_user}","gists_url":"https://api.github.com/users/lightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/lightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightmare/subscriptions","organizations_url":"https://api.github.com/users/lightmare/orgs","repos_url":"https://api.github.com/users/lightmare/repos","events_url":"https://api.github.com/users/lightmare/events{/privacy}","received_events_url":"https://api.github.com/users/lightmare/received_events","type":"User","site_admin":false},"body":"- fixes #3570\r\n\r\n- avoids recursive exception-specification on value constructor\r\n  by only constructing a temporary for arithmetic types (everything\r\n  else passes a reference to the base variant constructor)\r\n\r\n- also removes `is_same<decay_t<T>, value>` SFINAE check -- because\r\n  we're only passing a reference down, explicitly forcing the compiler\r\n  to use the implicitly-defined copy/move instead is pointless","created_at":"2016-12-14T01:40:44Z","updated_at":"2016-12-14T01:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapnik/mapnik/pulls/3572/commits","review_comments_url":"https://api.github.com/repos/mapnik/mapnik/pulls/3572/comments","review_comment_url":"https://api.github.com/repos/mapnik/mapnik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapnik/mapnik/issues/3572/comments","statuses_url":"https://api.github.com/repos/mapnik/mapnik/statuses/7c14964de3891b293d5ad4301c4630148ad9d171","head":{"label":"mapnik:issue-3570","ref":"issue-3570","sha":"7c14964de3891b293d5ad4301c4630148ad9d171","user":{"login":"mapnik","id":318055,"avatar_url":"https://avatars.githubusercontent.com/u/318055?v=3","gravatar_id":"","url":"https://api.github.com/users/mapnik","html_url":"https://github.com/mapnik","followers_url":"https://api.github.com/users/mapnik/followers","following_url":"https://api.github.com/users/mapnik/following{/other_user}","gists_url":"https://api.github.com/users/mapnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mapnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapnik/subscriptions","organizations_url":"https://api.github.com/users/mapnik/orgs","repos_url":"https://api.github.com/users/mapnik/repos","events_url":"https://api.github.com/users/mapnik/events{/privacy}","received_events_url":"https://api.github.com/users/mapnik/received_events","type":"Organization","site_admin":false},"repo":{"id":2556327,"name":"mapnik","full_name":"mapnik/mapnik","owner":{"login":"mapnik","id":318055,"avatar_url":"https://avatars.githubusercontent.com/u/318055?v=3","gravatar_id":"","url":"https://api.github.com/users/mapnik","html_url":"https://github.com/mapnik","followers_url":"https://api.github.com/users/mapnik/followers","following_url":"https://api.github.com/users/mapnik/following{/other_user}","gists_url":"https://api.github.com/users/mapnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mapnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapnik/subscriptions","organizations_url":"https://api.github.com/users/mapnik/orgs","repos_url":"https://api.github.com/users/mapnik/repos","events_url":"https://api.github.com/users/mapnik/events{/privacy}","received_events_url":"https://api.github.com/users/mapnik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapnik/mapnik","description":"Mapnik is an open source toolkit for developing mapping applications","fork":false,"url":"https://api.github.com/repos/mapnik/mapnik","forks_url":"https://api.github.com/repos/mapnik/mapnik/forks","keys_url":"https://api.github.com/repos/mapnik/mapnik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapnik/mapnik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapnik/mapnik/teams","hooks_url":"https://api.github.com/repos/mapnik/mapnik/hooks","issue_events_url":"https://api.github.com/repos/mapnik/mapnik/issues/events{/number}","events_url":"https://api.github.com/repos/mapnik/mapnik/events","assignees_url":"https://api.github.com/repos/mapnik/mapnik/assignees{/user}","branches_url":"https://api.github.com/repos/mapnik/mapnik/branches{/branch}","tags_url":"https://api.github.com/repos/mapnik/mapnik/tags","blobs_url":"https://api.github.com/repos/mapnik/mapnik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapnik/mapnik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapnik/mapnik/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapnik/mapnik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapnik/mapnik/statuses/{sha}","languages_url":"https://api.github.com/repos/mapnik/mapnik/languages","stargazers_url":"https://api.github.com/repos/mapnik/mapnik/stargazers","contributors_url":"https://api.github.com/repos/mapnik/mapnik/contributors","subscribers_url":"https://api.github.com/repos/mapnik/mapnik/subscribers","subscription_url":"https://api.github.com/repos/mapnik/mapnik/subscription","commits_url":"https://api.github.com/repos/mapnik/mapnik/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapnik/mapnik/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapnik/mapnik/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapnik/mapnik/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapnik/mapnik/contents/{+path}","compare_url":"https://api.github.com/repos/mapnik/mapnik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapnik/mapnik/merges","archive_url":"https://api.github.com/repos/mapnik/mapnik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapnik/mapnik/downloads","issues_url":"https://api.github.com/repos/mapnik/mapnik/issues{/number}","pulls_url":"https://api.github.com/repos/mapnik/mapnik/pulls{/number}","milestones_url":"https://api.github.com/repos/mapnik/mapnik/milestones{/number}","notifications_url":"https://api.github.com/repos/mapnik/mapnik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapnik/mapnik/labels{/name}","releases_url":"https://api.github.com/repos/mapnik/mapnik/releases{/id}","deployments_url":"https://api.github.com/repos/mapnik/mapnik/deployments","created_at":"2011-10-11T15:49:31Z","updated_at":"2016-12-13T22:16:38Z","pushed_at":"2016-12-14T01:40:44Z","git_url":"git://github.com/mapnik/mapnik.git","ssh_url":"git@github.com:mapnik/mapnik.git","clone_url":"https://github.com/mapnik/mapnik.git","svn_url":"https://github.com/mapnik/mapnik","homepage":"http://mapnik.org","size":160717,"stargazers_count":1577,"watchers_count":1577,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"open_issues_count":545,"forks":442,"open_issues":545,"watchers":1577,"default_branch":"master"}},"base":{"label":"mapnik:master","ref":"master","sha":"81fafe8198c18c4776c13276e7e29f818a68dd17","user":{"login":"mapnik","id":318055,"avatar_url":"https://avatars.githubusercontent.com/u/318055?v=3","gravatar_id":"","url":"https://api.github.com/users/mapnik","html_url":"https://github.com/mapnik","followers_url":"https://api.github.com/users/mapnik/followers","following_url":"https://api.github.com/users/mapnik/following{/other_user}","gists_url":"https://api.github.com/users/mapnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mapnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapnik/subscriptions","organizations_url":"https://api.github.com/users/mapnik/orgs","repos_url":"https://api.github.com/users/mapnik/repos","events_url":"https://api.github.com/users/mapnik/events{/privacy}","received_events_url":"https://api.github.com/users/mapnik/received_events","type":"Organization","site_admin":false},"repo":{"id":2556327,"name":"mapnik","full_name":"mapnik/mapnik","owner":{"login":"mapnik","id":318055,"avatar_url":"https://avatars.githubusercontent.com/u/318055?v=3","gravatar_id":"","url":"https://api.github.com/users/mapnik","html_url":"https://github.com/mapnik","followers_url":"https://api.github.com/users/mapnik/followers","following_url":"https://api.github.com/users/mapnik/following{/other_user}","gists_url":"https://api.github.com/users/mapnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mapnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapnik/subscriptions","organizations_url":"https://api.github.com/users/mapnik/orgs","repos_url":"https://api.github.com/users/mapnik/repos","events_url":"https://api.github.com/users/mapnik/events{/privacy}","received_events_url":"https://api.github.com/users/mapnik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapnik/mapnik","description":"Mapnik is an open source toolkit for developing mapping applications","fork":false,"url":"https://api.github.com/repos/mapnik/mapnik","forks_url":"https://api.github.com/repos/mapnik/mapnik/forks","keys_url":"https://api.github.com/repos/mapnik/mapnik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapnik/mapnik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapnik/mapnik/teams","hooks_url":"https://api.github.com/repos/mapnik/mapnik/hooks","issue_events_url":"https://api.github.com/repos/mapnik/mapnik/issues/events{/number}","events_url":"https://api.github.com/repos/mapnik/mapnik/events","assignees_url":"https://api.github.com/repos/mapnik/mapnik/assignees{/user}","branches_url":"https://api.github.com/repos/mapnik/mapnik/branches{/branch}","tags_url":"https://api.github.com/repos/mapnik/mapnik/tags","blobs_url":"https://api.github.com/repos/mapnik/mapnik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapnik/mapnik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapnik/mapnik/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapnik/mapnik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapnik/mapnik/statuses/{sha}","languages_url":"https://api.github.com/repos/mapnik/mapnik/languages","stargazers_url":"https://api.github.com/repos/mapnik/mapnik/stargazers","contributors_url":"https://api.github.com/repos/mapnik/mapnik/contributors","subscribers_url":"https://api.github.com/repos/mapnik/mapnik/subscribers","subscription_url":"https://api.github.com/repos/mapnik/mapnik/subscription","commits_url":"https://api.github.com/repos/mapnik/mapnik/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapnik/mapnik/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapnik/mapnik/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapnik/mapnik/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapnik/mapnik/contents/{+path}","compare_url":"https://api.github.com/repos/mapnik/mapnik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapnik/mapnik/merges","archive_url":"https://api.github.com/repos/mapnik/mapnik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapnik/mapnik/downloads","issues_url":"https://api.github.com/repos/mapnik/mapnik/issues{/number}","pulls_url":"https://api.github.com/repos/mapnik/mapnik/pulls{/number}","milestones_url":"https://api.github.com/repos/mapnik/mapnik/milestones{/number}","notifications_url":"https://api.github.com/repos/mapnik/mapnik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapnik/mapnik/labels{/name}","releases_url":"https://api.github.com/repos/mapnik/mapnik/releases{/id}","deployments_url":"https://api.github.com/repos/mapnik/mapnik/deployments","created_at":"2011-10-11T15:49:31Z","updated_at":"2016-12-13T22:16:38Z","pushed_at":"2016-12-14T01:40:44Z","git_url":"git://github.com/mapnik/mapnik.git","ssh_url":"git@github.com:mapnik/mapnik.git","clone_url":"https://github.com/mapnik/mapnik.git","svn_url":"https://github.com/mapnik/mapnik","homepage":"http://mapnik.org","size":160717,"stargazers_count":1577,"watchers_count":1577,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"open_issues_count":545,"forks":442,"open_issues":545,"watchers":1577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapnik/mapnik/pulls/3572"},"html":{"href":"https://github.com/mapnik/mapnik/pull/3572"},"issue":{"href":"https://api.github.com/repos/mapnik/mapnik/issues/3572"},"comments":{"href":"https://api.github.com/repos/mapnik/mapnik/issues/3572/comments"},"review_comments":{"href":"https://api.github.com/repos/mapnik/mapnik/pulls/3572/comments"},"review_comment":{"href":"https://api.github.com/repos/mapnik/mapnik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapnik/mapnik/pulls/3572/commits"},"statuses":{"href":"https://api.github.com/repos/mapnik/mapnik/statuses/7c14964de3891b293d5ad4301c4630148ad9d171"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":30,"deletions":112,"changed_files":3}}
{"actor":{"display_login":"lightmare"}}