{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/3429","repository_url":"https://api.github.com/repos/hypothesis/h","labels_url":"https://api.github.com/repos/hypothesis/h/issues/3429/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/3429/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/3429/events","html_url":"https://github.com/hypothesis/h/pull/3429","id":159373509,"number":3429,"title":"Do not use query property in User.get_by_username","user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-09T10:16:48Z","updated_at":"2016-06-09T10:29:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/3429","html_url":"https://github.com/hypothesis/h/pull/3429","diff_url":"https://github.com/hypothesis/h/pull/3429.diff","patch_url":"https://github.com/hypothesis/h/pull/3429.patch"},"body":"The use of a \"magic\" query property makes testing difficult and causes confusion about which session is the correct session to use when writing new code.\n\nThis commit is part of an effort to standardise all ORM classmethods so they take a database session as their first parameter and do not rely on a thread-local query property."},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/224857490","html_url":"https://github.com/hypothesis/h/pull/3429#issuecomment-224857490","issue_url":"https://api.github.com/repos/hypothesis/h/issues/3429","id":224857490,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T10:29:00Z","updated_at":"2016-06-09T10:29:00Z","body":"## [Current coverage][cc-pull] is **73.56%**\n> Merging [#3429][cc-pull] into [master][cc-base-branch] will increase coverage by **<.01%**\n\n1. 3 files (not in diff) in `h` were modified. [more](https://codecov.io/gh/hypothesis/h/commit/5d0d8ccceaf7c8bf7d0f4fb7ecad136e86b8df30/changes?src=pr#68) \n  - Misses `-3` \n  - Partials `+3`\n\n```diff\n@@             master      #3429   diff @@\n==========================================\n  Files           132        132          \n  Lines          4834       4835     +1   \n  Methods           0          0          \n  Messages          0          0          \n  Branches        573        573          \n==========================================\n+ Hits           3556       3557     +1   \n+ Misses         1198       1195     -3   \n- Partials         80         83     +3   \n```\n\n[![Sunburst](https://codecov.io/gh/hypothesis/h/pull/3429/graphs/sunburst.svg?size=150&src=pr)][cc-pull]\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [9406b3a...5d0d8cc][cc-compare]\n[cc-base-branch]: https://codecov.io/gh/hypothesis/h/branch/master?src=pr\n[cc-compare]: https://codecov.io/gh/hypothesis/h/compare/9406b3a0dab40bf18cb5df3c0ea591fcf3d46298...5d0d8ccceaf7c8bf7d0f4fb7ecad136e86b8df30\n[cc-pull]: https://codecov.io/gh/hypothesis/h/pull/3429?src=pr"}}
{"actor":{"display_login":"codecov-io"}}