{"action":"closed","number":234,"pull_request":{"url":"https://api.github.com/repos/crate/crate-admin/pulls/234","id":87877729,"html_url":"https://github.com/crate/crate-admin/pull/234","diff_url":"https://github.com/crate/crate-admin/pull/234.diff","patch_url":"https://github.com/crate/crate-admin/pull/234.patch","issue_url":"https://api.github.com/repos/crate/crate-admin/issues/234","number":234,"state":"closed","locked":false,"title":"fix: history doesn't work properly","user":{"login":"m-kharbat","id":13311684,"avatar_url":"https://avatars.githubusercontent.com/u/13311684?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kharbat","html_url":"https://github.com/m-kharbat","followers_url":"https://api.github.com/users/m-kharbat/followers","following_url":"https://api.github.com/users/m-kharbat/following{/other_user}","gists_url":"https://api.github.com/users/m-kharbat/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kharbat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kharbat/subscriptions","organizations_url":"https://api.github.com/users/m-kharbat/orgs","repos_url":"https://api.github.com/users/m-kharbat/repos","events_url":"https://api.github.com/users/m-kharbat/events{/privacy}","received_events_url":"https://api.github.com/users/m-kharbat/received_events","type":"User","site_admin":false},"body":"two things were not working properly:\r\n\r\n1. if the index of the recentQueries is too high it returned \"undefined\" and resulted in this error:\r\n<img width=\"525\" alt=\"screen shot 2016-10-04 at 13 37 23\" src=\"https://cloud.githubusercontent.com/assets/13311684/19072870/ee8f3b9c-8a37-11e6-9fef-99c506a1830b.png\">\r\n\r\n\r\n2. the recentQueries array was always inconsistent and didn't store the last query typed (in the sa,e session)\r\n\r\n@chaudum please review\r\n","created_at":"2016-10-04T11:40:23Z","updated_at":"2016-10-04T12:49:44Z","closed_at":"2016-10-04T12:49:44Z","merged_at":"2016-10-04T12:49:44Z","merge_commit_sha":"4f58278c47e6ab562b618cef72e57ae124fdb799","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crate/crate-admin/pulls/234/commits","review_comments_url":"https://api.github.com/repos/crate/crate-admin/pulls/234/comments","review_comment_url":"https://api.github.com/repos/crate/crate-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crate/crate-admin/issues/234/comments","statuses_url":"https://api.github.com/repos/crate/crate-admin/statuses/4f58278c47e6ab562b618cef72e57ae124fdb799","head":{"label":"crate:mk/sql-history","ref":"mk/sql-history","sha":"4f58278c47e6ab562b618cef72e57ae124fdb799","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":16980777,"name":"crate-admin","full_name":"crate/crate-admin","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate-admin","description":"Crate Data Admin Interface","fork":false,"url":"https://api.github.com/repos/crate/crate-admin","forks_url":"https://api.github.com/repos/crate/crate-admin/forks","keys_url":"https://api.github.com/repos/crate/crate-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate-admin/teams","hooks_url":"https://api.github.com/repos/crate/crate-admin/hooks","issue_events_url":"https://api.github.com/repos/crate/crate-admin/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate-admin/events","assignees_url":"https://api.github.com/repos/crate/crate-admin/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate-admin/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate-admin/tags","blobs_url":"https://api.github.com/repos/crate/crate-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate-admin/languages","stargazers_url":"https://api.github.com/repos/crate/crate-admin/stargazers","contributors_url":"https://api.github.com/repos/crate/crate-admin/contributors","subscribers_url":"https://api.github.com/repos/crate/crate-admin/subscribers","subscription_url":"https://api.github.com/repos/crate/crate-admin/subscription","commits_url":"https://api.github.com/repos/crate/crate-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate-admin/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate-admin/merges","archive_url":"https://api.github.com/repos/crate/crate-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate-admin/downloads","issues_url":"https://api.github.com/repos/crate/crate-admin/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate-admin/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate-admin/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate-admin/deployments","created_at":"2014-02-19T10:25:57Z","updated_at":"2016-05-21T13:11:42Z","pushed_at":"2016-10-04T12:49:43Z","git_url":"git://github.com/crate/crate-admin.git","ssh_url":"git@github.com:crate/crate-admin.git","clone_url":"https://github.com/crate/crate-admin.git","svn_url":"https://github.com/crate/crate-admin","homepage":"","size":3236,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":8,"default_branch":"master"}},"base":{"label":"crate:master","ref":"master","sha":"d753ad12d3bb4cf1a71e8cf5fb93949286271c74","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":16980777,"name":"crate-admin","full_name":"crate/crate-admin","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/crate-admin","description":"Crate Data Admin Interface","fork":false,"url":"https://api.github.com/repos/crate/crate-admin","forks_url":"https://api.github.com/repos/crate/crate-admin/forks","keys_url":"https://api.github.com/repos/crate/crate-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/crate-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/crate-admin/teams","hooks_url":"https://api.github.com/repos/crate/crate-admin/hooks","issue_events_url":"https://api.github.com/repos/crate/crate-admin/issues/events{/number}","events_url":"https://api.github.com/repos/crate/crate-admin/events","assignees_url":"https://api.github.com/repos/crate/crate-admin/assignees{/user}","branches_url":"https://api.github.com/repos/crate/crate-admin/branches{/branch}","tags_url":"https://api.github.com/repos/crate/crate-admin/tags","blobs_url":"https://api.github.com/repos/crate/crate-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/crate-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/crate-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/crate-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/crate-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/crate-admin/languages","stargazers_url":"https://api.github.com/repos/crate/crate-admin/stargazers","contributors_url":"https://api.github.com/repos/crate/crate-admin/contributors","subscribers_url":"https://api.github.com/repos/crate/crate-admin/subscribers","subscription_url":"https://api.github.com/repos/crate/crate-admin/subscription","commits_url":"https://api.github.com/repos/crate/crate-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/crate-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/crate-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/crate-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/crate-admin/contents/{+path}","compare_url":"https://api.github.com/repos/crate/crate-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/crate-admin/merges","archive_url":"https://api.github.com/repos/crate/crate-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/crate-admin/downloads","issues_url":"https://api.github.com/repos/crate/crate-admin/issues{/number}","pulls_url":"https://api.github.com/repos/crate/crate-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/crate-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/crate-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/crate-admin/labels{/name}","releases_url":"https://api.github.com/repos/crate/crate-admin/releases{/id}","deployments_url":"https://api.github.com/repos/crate/crate-admin/deployments","created_at":"2014-02-19T10:25:57Z","updated_at":"2016-05-21T13:11:42Z","pushed_at":"2016-10-04T12:49:43Z","git_url":"git://github.com/crate/crate-admin.git","ssh_url":"git@github.com:crate/crate-admin.git","clone_url":"https://github.com/crate/crate-admin.git","svn_url":"https://github.com/crate/crate-admin","homepage":"","size":3236,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crate/crate-admin/pulls/234"},"html":{"href":"https://github.com/crate/crate-admin/pull/234"},"issue":{"href":"https://api.github.com/repos/crate/crate-admin/issues/234"},"comments":{"href":"https://api.github.com/repos/crate/crate-admin/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/crate/crate-admin/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/crate/crate-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crate/crate-admin/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/crate/crate-admin/statuses/4f58278c47e6ab562b618cef72e57ae124fdb799"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"m-kharbat","id":13311684,"avatar_url":"https://avatars.githubusercontent.com/u/13311684?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kharbat","html_url":"https://github.com/m-kharbat","followers_url":"https://api.github.com/users/m-kharbat/followers","following_url":"https://api.github.com/users/m-kharbat/following{/other_user}","gists_url":"https://api.github.com/users/m-kharbat/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kharbat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kharbat/subscriptions","organizations_url":"https://api.github.com/users/m-kharbat/orgs","repos_url":"https://api.github.com/users/m-kharbat/repos","events_url":"https://api.github.com/users/m-kharbat/events{/privacy}","received_events_url":"https://api.github.com/users/m-kharbat/received_events","type":"User","site_admin":false},"comments":0,"review_comments":5,"commits":1,"additions":23,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"m-kharbat"}}