{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17468","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17468/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17468/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17468/events","html_url":"https://github.com/mantidproject/mantid/pull/17468","id":176425572,"number":17468,"title":"More OSX floating window issues","user":{"login":"samueljackson92","id":2487781,"avatar_url":"https://avatars.githubusercontent.com/u/2487781?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljackson92","html_url":"https://github.com/samueljackson92","followers_url":"https://api.github.com/users/samueljackson92/followers","following_url":"https://api.github.com/users/samueljackson92/following{/other_user}","gists_url":"https://api.github.com/users/samueljackson92/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljackson92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljackson92/subscriptions","organizations_url":"https://api.github.com/users/samueljackson92/orgs","repos_url":"https://api.github.com/users/samueljackson92/repos","events_url":"https://api.github.com/users/samueljackson92/events{/privacy}","received_events_url":"https://api.github.com/users/samueljackson92/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20GUI","name":"Component: GUI","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"assignees":[{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"Code Freeze: 16-Sep-2016\r\nDeveloper & Unscripted Testing: 16-Sep-2016 to 20-Sep-2016\r\nBeta test: 20-Sep-2016 to 04-Oct-2016\r\nRelease Date: 10-Oct-2016","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":515,"closed_issues":921,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-09-20T12:22:16Z","due_on":"2016-10-10T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-09-12T16:47:26Z","updated_at":"2016-09-20T12:48:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17468","html_url":"https://github.com/mantidproject/mantid/pull/17468","diff_url":"https://github.com/mantidproject/mantid/pull/17468.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17468.patch"},"body":"I missed a few interfaces in earlier issues. I believe this makes all interfaces consistent across Mantid. Floating windows in OSX will no always be on top of the main window and will not \"disappear\" behind the main window. The penalty we pay for this that Qt + OSX cannot have both a minimise and maximise button on the floating windows (despite trying all the flag combinations of flags...), so here we force the window to offer the minimise button.\r\n\r\n**To test:**\r\n\r\nThe following windows should now properly appear as floating in OSX:\r\n\r\n - Instrument View\r\n - Spectrum viewer\r\n - Slice viewer\r\n - VSI\r\n - Algorithm Dialogs\r\n - Algorithm History window\r\n - Scripting window\r\n\r\nFixes #17465 .\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/248291226","html_url":"https://github.com/mantidproject/mantid/pull/17468#issuecomment-248291226","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17468","id":248291226,"user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T12:48:13Z","updated_at":"2016-09-20T12:48:13Z","body":"Would have been good to have avoided some of the duplication while setting the flags in these different locations, but otherwise works ok."}}
{"actor":{"display_login":"OwenArnold"}}