{"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/hana/pulls/comments/70210474","id":70210474,"diff_hunk":"@@ -70,7 +70,7 @@ Distributed under the Boost Software License, Version 1.0.\n //////////////////////////////////////////////////////////////////////////////\n // Check the compiler for general C++14 capabilities\n //////////////////////////////////////////////////////////////////////////////\n-#if (__cplusplus < 201400)\n+#if (__cplusplus < 201400) && (defined(__clang__) || !defined(_MSC_VER))","path":"include/boost/hana/config.hpp","position":null,"original_position":5,"commit_id":"1fd48d209307dd1a571123620043fbd453d8b96a","original_commit_id":"7ae410a5437f7fbb5168aedddc2663cecb185653","user":{"login":"MarcelRaad","id":5967138,"avatar_url":"https://avatars.githubusercontent.com/u/5967138?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelRaad","html_url":"https://github.com/MarcelRaad","followers_url":"https://api.github.com/users/MarcelRaad/followers","following_url":"https://api.github.com/users/MarcelRaad/following{/other_user}","gists_url":"https://api.github.com/users/MarcelRaad/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelRaad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelRaad/subscriptions","organizations_url":"https://api.github.com/users/MarcelRaad/orgs","repos_url":"https://api.github.com/users/MarcelRaad/repos","events_url":"https://api.github.com/users/MarcelRaad/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelRaad/received_events","type":"User","site_admin":false},"body":"> Why not simply #if (__cplusplus < 201400) && !defined(_MSC_VER) ?\r\n\r\nBecause I didn't know that clang in MSVC mode also supports `#pragma message`. But it does, just tested with clang/c2, so I've updated to use `#pragma message` in MSVC mode.","created_at":"2016-07-11T07:13:42Z","updated_at":"2016-07-11T07:13:42Z","html_url":"https://github.com/boostorg/hana/pull/294#discussion_r70210474","pull_request_url":"https://api.github.com/repos/boostorg/hana/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/boostorg/hana/pulls/comments/70210474"},"html":{"href":"https://github.com/boostorg/hana/pull/294#discussion_r70210474"},"pull_request":{"href":"https://api.github.com/repos/boostorg/hana/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/hana/pulls/294","id":76816592,"html_url":"https://github.com/boostorg/hana/pull/294","diff_url":"https://github.com/boostorg/hana/pull/294.diff","patch_url":"https://github.com/boostorg/hana/pull/294.patch","issue_url":"https://api.github.com/repos/boostorg/hana/issues/294","number":294,"state":"open","locked":false,"title":"Unblock testing with MSVC","user":{"login":"MarcelRaad","id":5967138,"avatar_url":"https://avatars.githubusercontent.com/u/5967138?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelRaad","html_url":"https://github.com/MarcelRaad","followers_url":"https://api.github.com/users/MarcelRaad/followers","following_url":"https://api.github.com/users/MarcelRaad/following{/other_user}","gists_url":"https://api.github.com/users/MarcelRaad/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelRaad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelRaad/subscriptions","organizations_url":"https://api.github.com/users/MarcelRaad/orgs","repos_url":"https://api.github.com/users/MarcelRaad/repos","events_url":"https://api.github.com/users/MarcelRaad/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelRaad/received_events","type":"User","site_admin":false},"body":"MSVC doesn't like the #warning directive and issues a fatal error.\r\nIt also sets _MSVC_LANG to 201402 for C++14 instead of __cplusplus, but that's the minimum value anyway.\r\nIt also doesn't like using {} instead of ::value for some type traits sometimes and issues an error about a missing default constructor. ::value is used most of the time anyway.","created_at":"2016-07-08T21:25:15Z","updated_at":"2016-07-11T07:13:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d42384ef43ec25b19fe14f15af10d01d4a23bb3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/hana/pulls/294/commits","review_comments_url":"https://api.github.com/repos/boostorg/hana/pulls/294/comments","review_comment_url":"https://api.github.com/repos/boostorg/hana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boostorg/hana/issues/294/comments","statuses_url":"https://api.github.com/repos/boostorg/hana/statuses/1fd48d209307dd1a571123620043fbd453d8b96a","head":{"label":"MarcelRaad:msvc","ref":"msvc","sha":"1fd48d209307dd1a571123620043fbd453d8b96a","user":{"login":"MarcelRaad","id":5967138,"avatar_url":"https://avatars.githubusercontent.com/u/5967138?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelRaad","html_url":"https://github.com/MarcelRaad","followers_url":"https://api.github.com/users/MarcelRaad/followers","following_url":"https://api.github.com/users/MarcelRaad/following{/other_user}","gists_url":"https://api.github.com/users/MarcelRaad/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelRaad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelRaad/subscriptions","organizations_url":"https://api.github.com/users/MarcelRaad/orgs","repos_url":"https://api.github.com/users/MarcelRaad/repos","events_url":"https://api.github.com/users/MarcelRaad/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelRaad/received_events","type":"User","site_admin":false},"repo":{"id":62918096,"name":"hana","full_name":"MarcelRaad/hana","owner":{"login":"MarcelRaad","id":5967138,"avatar_url":"https://avatars.githubusercontent.com/u/5967138?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcelRaad","html_url":"https://github.com/MarcelRaad","followers_url":"https://api.github.com/users/MarcelRaad/followers","following_url":"https://api.github.com/users/MarcelRaad/following{/other_user}","gists_url":"https://api.github.com/users/MarcelRaad/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelRaad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelRaad/subscriptions","organizations_url":"https://api.github.com/users/MarcelRaad/orgs","repos_url":"https://api.github.com/users/MarcelRaad/repos","events_url":"https://api.github.com/users/MarcelRaad/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelRaad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcelRaad/hana","description":"Your standard library for metaprogramming","fork":true,"url":"https://api.github.com/repos/MarcelRaad/hana","forks_url":"https://api.github.com/repos/MarcelRaad/hana/forks","keys_url":"https://api.github.com/repos/MarcelRaad/hana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcelRaad/hana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcelRaad/hana/teams","hooks_url":"https://api.github.com/repos/MarcelRaad/hana/hooks","issue_events_url":"https://api.github.com/repos/MarcelRaad/hana/issues/events{/number}","events_url":"https://api.github.com/repos/MarcelRaad/hana/events","assignees_url":"https://api.github.com/repos/MarcelRaad/hana/assignees{/user}","branches_url":"https://api.github.com/repos/MarcelRaad/hana/branches{/branch}","tags_url":"https://api.github.com/repos/MarcelRaad/hana/tags","blobs_url":"https://api.github.com/repos/MarcelRaad/hana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcelRaad/hana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcelRaad/hana/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcelRaad/hana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcelRaad/hana/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcelRaad/hana/languages","stargazers_url":"https://api.github.com/repos/MarcelRaad/hana/stargazers","contributors_url":"https://api.github.com/repos/MarcelRaad/hana/contributors","subscribers_url":"https://api.github.com/repos/MarcelRaad/hana/subscribers","subscription_url":"https://api.github.com/repos/MarcelRaad/hana/subscription","commits_url":"https://api.github.com/repos/MarcelRaad/hana/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcelRaad/hana/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcelRaad/hana/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcelRaad/hana/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcelRaad/hana/contents/{+path}","compare_url":"https://api.github.com/repos/MarcelRaad/hana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcelRaad/hana/merges","archive_url":"https://api.github.com/repos/MarcelRaad/hana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcelRaad/hana/downloads","issues_url":"https://api.github.com/repos/MarcelRaad/hana/issues{/number}","pulls_url":"https://api.github.com/repos/MarcelRaad/hana/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcelRaad/hana/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcelRaad/hana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcelRaad/hana/labels{/name}","releases_url":"https://api.github.com/repos/MarcelRaad/hana/releases{/id}","deployments_url":"https://api.github.com/repos/MarcelRaad/hana/deployments","created_at":"2016-07-08T21:20:49Z","updated_at":"2016-07-08T21:20:55Z","pushed_at":"2016-07-11T07:09:23Z","git_url":"git://github.com/MarcelRaad/hana.git","ssh_url":"git@github.com:MarcelRaad/hana.git","clone_url":"https://github.com/MarcelRaad/hana.git","svn_url":"https://github.com/MarcelRaad/hana","homepage":"http://boostorg.github.io/hana","size":43780,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"e4a3ce2666351a11d6bdeb1654e7509580a6e65d","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":19887998,"name":"hana","full_name":"boostorg/hana","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/hana","description":"Your standard library for metaprogramming","fork":false,"url":"https://api.github.com/repos/boostorg/hana","forks_url":"https://api.github.com/repos/boostorg/hana/forks","keys_url":"https://api.github.com/repos/boostorg/hana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/hana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/hana/teams","hooks_url":"https://api.github.com/repos/boostorg/hana/hooks","issue_events_url":"https://api.github.com/repos/boostorg/hana/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/hana/events","assignees_url":"https://api.github.com/repos/boostorg/hana/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/hana/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/hana/tags","blobs_url":"https://api.github.com/repos/boostorg/hana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/hana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/hana/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/hana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/hana/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/hana/languages","stargazers_url":"https://api.github.com/repos/boostorg/hana/stargazers","contributors_url":"https://api.github.com/repos/boostorg/hana/contributors","subscribers_url":"https://api.github.com/repos/boostorg/hana/subscribers","subscription_url":"https://api.github.com/repos/boostorg/hana/subscription","commits_url":"https://api.github.com/repos/boostorg/hana/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/hana/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/hana/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/hana/issues/comments{/number}","contents_url":"https://api.github.com/repos/boostorg/hana/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/hana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/hana/merges","archive_url":"https://api.github.com/repos/boostorg/hana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/hana/downloads","issues_url":"https://api.github.com/repos/boostorg/hana/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/hana/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/hana/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/hana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/hana/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/hana/releases{/id}","deployments_url":"https://api.github.com/repos/boostorg/hana/deployments","created_at":"2014-05-17T14:06:06Z","updated_at":"2016-07-09T18:41:28Z","pushed_at":"2016-07-11T07:09:23Z","git_url":"git://github.com/boostorg/hana.git","ssh_url":"git@github.com:boostorg/hana.git","clone_url":"https://github.com/boostorg/hana.git","svn_url":"https://github.com/boostorg/hana","homepage":"http://boostorg.github.io/hana","size":45543,"stargazers_count":458,"watchers_count":458,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":44,"forks":63,"open_issues":44,"watchers":458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/hana/pulls/294"},"html":{"href":"https://github.com/boostorg/hana/pull/294"},"issue":{"href":"https://api.github.com/repos/boostorg/hana/issues/294"},"comments":{"href":"https://api.github.com/repos/boostorg/hana/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/hana/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/hana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boostorg/hana/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/hana/statuses/1fd48d209307dd1a571123620043fbd453d8b96a"}}}}
{"actor":{"display_login":"MarcelRaad"}}