{"action":"created","issue":{"url":"https://api.github.com/repos/firebase/firepad/issues/241","repository_url":"https://api.github.com/repos/firebase/firepad","labels_url":"https://api.github.com/repos/firebase/firepad/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/firebase/firepad/issues/241/comments","events_url":"https://api.github.com/repos/firebase/firepad/issues/241/events","html_url":"https://github.com/firebase/firepad/pull/241","id":145833102,"number":241,"title":"update current attributes ","user":{"login":"kofifus","id":3926071,"avatar_url":"https://avatars.githubusercontent.com/u/3926071?v=3","gravatar_id":"","url":"https://api.github.com/users/kofifus","html_url":"https://github.com/kofifus","followers_url":"https://api.github.com/users/kofifus/followers","following_url":"https://api.github.com/users/kofifus/following{/other_user}","gists_url":"https://api.github.com/users/kofifus/gists{/gist_id}","starred_url":"https://api.github.com/users/kofifus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofifus/subscriptions","organizations_url":"https://api.github.com/users/kofifus/orgs","repos_url":"https://api.github.com/users/kofifus/repos","events_url":"https://api.github.com/users/kofifus/events{/privacy}","received_events_url":"https://api.github.com/users/kofifus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-04-04T23:32:06Z","updated_at":"2016-04-29T07:58:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/firebase/firepad/pulls/241","html_url":"https://github.com/firebase/firepad/pull/241","diff_url":"https://github.com/firebase/firepad/pull/241.diff","patch_url":"https://github.com/firebase/firepad/pull/241.patch"},"body":"This PR includes a few fixes and additions to Firepad attribute changes:\r\n\r\n1. Toolbar button state now changes according to the relevant attributes. Included buttons are bold,Italics, Underline & strike. This can be expanded in the future to include all buttons.\r\n\r\n2. The original code did not properly handle attribute changes at the end of the line, for example turning bold off and then inserting a newline would still make text on the new line bold. \r\nThe reason was the original code backs up before the newline which holds this attribute change. The new code backs up to the correct pos.\r\n\r\n3. The original code did not properly handle cursor at the beginning of a non empty line - it would copy the attribute s from the left (line before) and not the right (first char). The new code handles this situation correctly.\r\n\r\n4. The original code did not properly handle backspace. The new code preserves the attribute of the removed character when pressing backspace.\r\n\r\nDemo at: http://plnkr.co/edit/vGtggEc3xQrurST0z6Cl?p=preview"},"comment":{"url":"https://api.github.com/repos/firebase/firepad/issues/comments/215652919","html_url":"https://github.com/firebase/firepad/pull/241#issuecomment-215652919","issue_url":"https://api.github.com/repos/firebase/firepad/issues/241","id":215652919,"user":{"login":"vincentwoo","id":613320,"avatar_url":"https://avatars.githubusercontent.com/u/613320?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentwoo","html_url":"https://github.com/vincentwoo","followers_url":"https://api.github.com/users/vincentwoo/followers","following_url":"https://api.github.com/users/vincentwoo/following{/other_user}","gists_url":"https://api.github.com/users/vincentwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentwoo/subscriptions","organizations_url":"https://api.github.com/users/vincentwoo/orgs","repos_url":"https://api.github.com/users/vincentwoo/repos","events_url":"https://api.github.com/users/vincentwoo/events{/privacy}","received_events_url":"https://api.github.com/users/vincentwoo/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T07:58:28Z","updated_at":"2016-04-29T07:58:28Z","body":"i pegged travis to node 5 for now which should stop the test bleeding, too"}}