{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments/92901109","pull_request_review_id":13426871,"id":92901109,"diff_hunk":"@@ -64,11 +65,19 @@ public void run(RunConfiguration config) throws AppEngineException {\n       arguments.add(appYaml.toPath().toString());\n     }\n \n-    Map<String,String> env = Maps.newHashMap();\n+    Map<String,String> environmentVariables = Maps.newHashMap();\n     if (!Strings.isNullOrEmpty(config.getJavaHomeDir())) {\n-      env.put(\"JAVA_HOME\", config.getJavaHomeDir());\n+      environmentVariables.put(\"JAVA_HOME\", config.getJavaHomeDir());\n     }\n \n+    List<String> environment = config.getEnvironmentVariables();\n+    if (environment != null) {\n+      for (String nameValue : environment) {\n+        String[] pair = nameValue.split(\"\\\\=\");","path":"src/main/java/com/google/cloud/tools/appengine/cloudsdk/CloudSdkAppEngineDevServer.java","position":null,"original_position":31,"commit_id":"e3dd1cdb9db7ec70495b367651e6abc2b13b90cb","original_commit_id":"64d34d46462efa7991831010eb69d4954d0bd581","user":{"login":"elharo","id":1005544,"avatar_url":"https://avatars.githubusercontent.com/u/1005544?v=3","gravatar_id":"","url":"https://api.github.com/users/elharo","html_url":"https://github.com/elharo","followers_url":"https://api.github.com/users/elharo/followers","following_url":"https://api.github.com/users/elharo/following{/other_user}","gists_url":"https://api.github.com/users/elharo/gists{/gist_id}","starred_url":"https://api.github.com/users/elharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elharo/subscriptions","organizations_url":"https://api.github.com/users/elharo/orgs","repos_url":"https://api.github.com/users/elharo/repos","events_url":"https://api.github.com/users/elharo/events{/privacy}","received_events_url":"https://api.github.com/users/elharo/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-12-16T23:04:33Z","updated_at":"2016-12-16T23:04:54Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284#discussion_r92901109","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments/92901109"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284#discussion_r92901109"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284","id":98407178,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284","diff_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/284","number":284,"state":"open","locked":false,"title":"supply environment variables","user":{"login":"elharo","id":1005544,"avatar_url":"https://avatars.githubusercontent.com/u/1005544?v=3","gravatar_id":"","url":"https://api.github.com/users/elharo","html_url":"https://github.com/elharo","followers_url":"https://api.github.com/users/elharo/followers","following_url":"https://api.github.com/users/elharo/following{/other_user}","gists_url":"https://api.github.com/users/elharo/gists{/gist_id}","starred_url":"https://api.github.com/users/elharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elharo/subscriptions","organizations_url":"https://api.github.com/users/elharo/orgs","repos_url":"https://api.github.com/users/elharo/repos","events_url":"https://api.github.com/users/elharo/events{/privacy}","received_events_url":"https://api.github.com/users/elharo/received_events","type":"User","site_admin":false},"body":"@briandealwis @chanseokoh ","created_at":"2016-12-16T21:39:26Z","updated_at":"2016-12-16T23:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c5a3a129b592d07b82327d90a0dcf10da5cfc8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/284/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/e3dd1cdb9db7ec70495b367651e6abc2b13b90cb","head":{"label":"GoogleCloudPlatform:i1139","ref":"i1139","sha":"e3dd1cdb9db7ec70495b367651e6abc2b13b90cb","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"appengine-plugins-core","full_name":"GoogleCloudPlatform/appengine-plugins-core","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","description":"A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-11-26T09:33:14Z","pushed_at":"2016-12-16T23:04:49Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-plugins-core.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-plugins-core.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","homepage":"","size":561,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":53,"forks":3,"open_issues":53,"watchers":8,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f1cca8bf72208463743d4ce84f556cfe9e2174bc","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"appengine-plugins-core","full_name":"GoogleCloudPlatform/appengine-plugins-core","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","description":"A client Java library to manage App Engine Java applications for any project that performs App Engine Java application management. For example, the Maven, Gradle and Eclipse App Engine plugins, custom user tools, etc.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-11-26T09:33:14Z","pushed_at":"2016-12-16T23:04:49Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-plugins-core.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-plugins-core.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","homepage":"","size":561,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":53,"forks":3,"open_issues":53,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/284"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/284"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/e3dd1cdb9db7ec70495b367651e6abc2b13b90cb"}}}}
{"actor":{"display_login":"elharo"}}