{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/79637033","id":79637033,"diff_hunk":"@@ -78,7 +87,7 @@ func (b *backend) pathConfigLeaseRead(\n \treturn &logical.Response{\n \t\tData: map[string]interface{}{\n \t\t\t\"ttl\":     leaseConfig.TTL.String(),\n-\t\t\t\"ttl_max\": leaseConfig.TTLMax.String(),\n+\t\t\t\"max_ttl\": leaseConfig.TTLMax.String(),","path":"builtin/logical/mssql/path_config_lease.go","position":39,"original_position":39,"commit_id":"711311a8cb130c3e1dd23a782681cdc7fc316204","original_commit_id":"711311a8cb130c3e1dd23a782681cdc7fc316204","user":{"login":"vishalnayak","id":3053672,"avatar_url":"https://avatars.githubusercontent.com/u/3053672?v=3","gravatar_id":"","url":"https://api.github.com/users/vishalnayak","html_url":"https://github.com/vishalnayak","followers_url":"https://api.github.com/users/vishalnayak/followers","following_url":"https://api.github.com/users/vishalnayak/following{/other_user}","gists_url":"https://api.github.com/users/vishalnayak/gists{/gist_id}","starred_url":"https://api.github.com/users/vishalnayak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishalnayak/subscriptions","organizations_url":"https://api.github.com/users/vishalnayak/orgs","repos_url":"https://api.github.com/users/vishalnayak/repos","events_url":"https://api.github.com/users/vishalnayak/events{/privacy}","received_events_url":"https://api.github.com/users/vishalnayak/received_events","type":"User","site_admin":false},"body":"@chrishoffman Retain the old field in the response, along with the new one and add a warning to the response that the old one will be removed after 2 releases.","created_at":"2016-09-20T15:19:31Z","updated_at":"2016-09-20T15:19:31Z","html_url":"https://github.com/hashicorp/vault/pull/1905#discussion_r79637033","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/1905","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/79637033"},"html":{"href":"https://github.com/hashicorp/vault/pull/1905#discussion_r79637033"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1905"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/1905","id":85909634,"html_url":"https://github.com/hashicorp/vault/pull/1905","diff_url":"https://github.com/hashicorp/vault/pull/1905.diff","patch_url":"https://github.com/hashicorp/vault/pull/1905.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/1905","number":1905,"state":"open","locked":false,"title":"Renaming ttl_max -> max_ttl in mssql backend","user":{"login":"chrishoffman","id":99742,"avatar_url":"https://avatars.githubusercontent.com/u/99742?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishoffman","html_url":"https://github.com/chrishoffman","followers_url":"https://api.github.com/users/chrishoffman/followers","following_url":"https://api.github.com/users/chrishoffman/following{/other_user}","gists_url":"https://api.github.com/users/chrishoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishoffman/subscriptions","organizations_url":"https://api.github.com/users/chrishoffman/orgs","repos_url":"https://api.github.com/users/chrishoffman/repos","events_url":"https://api.github.com/users/chrishoffman/events{/privacy}","received_events_url":"https://api.github.com/users/chrishoffman/received_events","type":"User","site_admin":false},"body":"This will bring this backends parameters in line with the other secret backends.","created_at":"2016-09-20T04:33:43Z","updated_at":"2016-09-20T15:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cae20ff03899c6317d7ce2372ddfbed29245885","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/1905/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/1905/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/1905/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/711311a8cb130c3e1dd23a782681cdc7fc316204","head":{"label":"chrishoffman:mssql-max-ttl","ref":"mssql-max-ttl","sha":"711311a8cb130c3e1dd23a782681cdc7fc316204","user":{"login":"chrishoffman","id":99742,"avatar_url":"https://avatars.githubusercontent.com/u/99742?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishoffman","html_url":"https://github.com/chrishoffman","followers_url":"https://api.github.com/users/chrishoffman/followers","following_url":"https://api.github.com/users/chrishoffman/following{/other_user}","gists_url":"https://api.github.com/users/chrishoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishoffman/subscriptions","organizations_url":"https://api.github.com/users/chrishoffman/orgs","repos_url":"https://api.github.com/users/chrishoffman/repos","events_url":"https://api.github.com/users/chrishoffman/events{/privacy}","received_events_url":"https://api.github.com/users/chrishoffman/received_events","type":"User","site_admin":false},"repo":{"id":50726091,"name":"vault","full_name":"chrishoffman/vault","owner":{"login":"chrishoffman","id":99742,"avatar_url":"https://avatars.githubusercontent.com/u/99742?v=3","gravatar_id":"","url":"https://api.github.com/users/chrishoffman","html_url":"https://github.com/chrishoffman","followers_url":"https://api.github.com/users/chrishoffman/followers","following_url":"https://api.github.com/users/chrishoffman/following{/other_user}","gists_url":"https://api.github.com/users/chrishoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishoffman/subscriptions","organizations_url":"https://api.github.com/users/chrishoffman/orgs","repos_url":"https://api.github.com/users/chrishoffman/repos","events_url":"https://api.github.com/users/chrishoffman/events{/privacy}","received_events_url":"https://api.github.com/users/chrishoffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrishoffman/vault","description":"A tool for managing secrets.","fork":true,"url":"https://api.github.com/repos/chrishoffman/vault","forks_url":"https://api.github.com/repos/chrishoffman/vault/forks","keys_url":"https://api.github.com/repos/chrishoffman/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrishoffman/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrishoffman/vault/teams","hooks_url":"https://api.github.com/repos/chrishoffman/vault/hooks","issue_events_url":"https://api.github.com/repos/chrishoffman/vault/issues/events{/number}","events_url":"https://api.github.com/repos/chrishoffman/vault/events","assignees_url":"https://api.github.com/repos/chrishoffman/vault/assignees{/user}","branches_url":"https://api.github.com/repos/chrishoffman/vault/branches{/branch}","tags_url":"https://api.github.com/repos/chrishoffman/vault/tags","blobs_url":"https://api.github.com/repos/chrishoffman/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrishoffman/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrishoffman/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrishoffman/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrishoffman/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/chrishoffman/vault/languages","stargazers_url":"https://api.github.com/repos/chrishoffman/vault/stargazers","contributors_url":"https://api.github.com/repos/chrishoffman/vault/contributors","subscribers_url":"https://api.github.com/repos/chrishoffman/vault/subscribers","subscription_url":"https://api.github.com/repos/chrishoffman/vault/subscription","commits_url":"https://api.github.com/repos/chrishoffman/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrishoffman/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrishoffman/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrishoffman/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrishoffman/vault/contents/{+path}","compare_url":"https://api.github.com/repos/chrishoffman/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrishoffman/vault/merges","archive_url":"https://api.github.com/repos/chrishoffman/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrishoffman/vault/downloads","issues_url":"https://api.github.com/repos/chrishoffman/vault/issues{/number}","pulls_url":"https://api.github.com/repos/chrishoffman/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/chrishoffman/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/chrishoffman/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrishoffman/vault/labels{/name}","releases_url":"https://api.github.com/repos/chrishoffman/vault/releases{/id}","deployments_url":"https://api.github.com/repos/chrishoffman/vault/deployments","created_at":"2016-01-30T13:33:22Z","updated_at":"2016-07-29T20:26:17Z","pushed_at":"2016-09-20T15:16:35Z","git_url":"git://github.com/chrishoffman/vault.git","ssh_url":"git@github.com:chrishoffman/vault.git","clone_url":"https://github.com/chrishoffman/vault.git","svn_url":"https://github.com/chrishoffman/vault","homepage":"http://vaultproject.io","size":18070,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"15001218e3433454067fa6549c85be6e5ba8f02e","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for managing secrets.","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2016-09-20T14:05:43Z","pushed_at":"2016-09-20T15:16:36Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":19980,"stargazers_count":5300,"watchers_count":5300,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":566,"mirror_url":null,"open_issues_count":172,"forks":566,"open_issues":172,"watchers":5300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1905"},"html":{"href":"https://github.com/hashicorp/vault/pull/1905"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/1905"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/1905/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1905/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/1905/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/711311a8cb130c3e1dd23a782681cdc7fc316204"}}}}
{"actor":{"display_login":"vishalnayak"}}