{"action":"created","comment":{"url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/comments/56726802","id":56726802,"diff_hunk":"@@ -38,14 +38,13 @@ fn to_intern_str(ctx: &mut GenCtx, s: &str) -> parse::token::InternedString {\n     id.name.as_str()\n }\n \n-fn rust_id(ctx: &mut GenCtx, name: String) -> (String, bool) {\n-    let token = parse::token::Ident(ctx.ext_cx.ident_of(&name[..]), parse::token::Plain);\n-    if token.is_any_keyword() || \"bool\" == &name[..] {\n-        let mut s = \"_\".to_owned();\n-        s.push_str(&name[..]);\n+fn rust_id(ctx: &mut GenCtx, name: &str) -> (String, bool) {\n+    let token = parse::token::Ident(ctx.ext_cx.ident_of(name), parse::token::Plain);\n+    if token.is_any_keyword() || \"bool\" == name {\n+        let s = format!(\"_{}\", name);","path":"src/gen.rs","position":56,"original_position":12,"commit_id":"ff2419e837f6df6f7ea34cbddc505f2bfc3c29a7","original_commit_id":"193a1bfeb828b65b664005f12c16cef8a8cda0b6","user":{"login":"Yamakaky","id":1327378,"avatar_url":"https://avatars.githubusercontent.com/u/1327378?v=3","gravatar_id":"","url":"https://api.github.com/users/Yamakaky","html_url":"https://github.com/Yamakaky","followers_url":"https://api.github.com/users/Yamakaky/followers","following_url":"https://api.github.com/users/Yamakaky/following{/other_user}","gists_url":"https://api.github.com/users/Yamakaky/gists{/gist_id}","starred_url":"https://api.github.com/users/Yamakaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yamakaky/subscriptions","organizations_url":"https://api.github.com/users/Yamakaky/orgs","repos_url":"https://api.github.com/users/Yamakaky/repos","events_url":"https://api.github.com/users/Yamakaky/events{/privacy}","received_events_url":"https://api.github.com/users/Yamakaky/received_events","type":"User","site_admin":false},"body":"Maybe open an issue, your comment will be lost ^^","created_at":"2016-03-18T21:45:43Z","updated_at":"2016-03-18T21:45:43Z","html_url":"https://github.com/crabtw/rust-bindgen/pull/296#discussion_r56726802","pull_request_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296","_links":{"self":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/comments/56726802"},"html":{"href":"https://github.com/crabtw/rust-bindgen/pull/296#discussion_r56726802"},"pull_request":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296","id":62948198,"html_url":"https://github.com/crabtw/rust-bindgen/pull/296","diff_url":"https://github.com/crabtw/rust-bindgen/pull/296.diff","patch_url":"https://github.com/crabtw/rust-bindgen/pull/296.patch","issue_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/296","number":296,"state":"open","locked":false,"title":"Refactoring gen.rs","user":{"login":"Yamakaky","id":1327378,"avatar_url":"https://avatars.githubusercontent.com/u/1327378?v=3","gravatar_id":"","url":"https://api.github.com/users/Yamakaky","html_url":"https://github.com/Yamakaky","followers_url":"https://api.github.com/users/Yamakaky/followers","following_url":"https://api.github.com/users/Yamakaky/following{/other_user}","gists_url":"https://api.github.com/users/Yamakaky/gists{/gist_id}","starred_url":"https://api.github.com/users/Yamakaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yamakaky/subscriptions","organizations_url":"https://api.github.com/users/Yamakaky/orgs","repos_url":"https://api.github.com/users/Yamakaky/repos","events_url":"https://api.github.com/users/Yamakaky/events{/privacy}","received_events_url":"https://api.github.com/users/Yamakaky/received_events","type":"User","site_admin":false},"body":"Various refactoring, separated by commits.","created_at":"2016-03-15T17:47:01Z","updated_at":"2016-03-18T21:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3744093ce6d6dab7208e080c7af95b4e0e948910","assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296/commits","review_comments_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296/comments","review_comment_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/296/comments","statuses_url":"https://api.github.com/repos/crabtw/rust-bindgen/statuses/ff2419e837f6df6f7ea34cbddc505f2bfc3c29a7","head":{"label":"crabtw:refactoring-gen-rs","ref":"refactoring-gen-rs","sha":"ff2419e837f6df6f7ea34cbddc505f2bfc3c29a7","user":{"login":"crabtw","id":36015,"avatar_url":"https://avatars.githubusercontent.com/u/36015?v=3","gravatar_id":"","url":"https://api.github.com/users/crabtw","html_url":"https://github.com/crabtw","followers_url":"https://api.github.com/users/crabtw/followers","following_url":"https://api.github.com/users/crabtw/following{/other_user}","gists_url":"https://api.github.com/users/crabtw/gists{/gist_id}","starred_url":"https://api.github.com/users/crabtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crabtw/subscriptions","organizations_url":"https://api.github.com/users/crabtw/orgs","repos_url":"https://api.github.com/users/crabtw/repos","events_url":"https://api.github.com/users/crabtw/events{/privacy}","received_events_url":"https://api.github.com/users/crabtw/received_events","type":"User","site_admin":false},"repo":{"id":3579003,"name":"rust-bindgen","full_name":"crabtw/rust-bindgen","owner":{"login":"crabtw","id":36015,"avatar_url":"https://avatars.githubusercontent.com/u/36015?v=3","gravatar_id":"","url":"https://api.github.com/users/crabtw","html_url":"https://github.com/crabtw","followers_url":"https://api.github.com/users/crabtw/followers","following_url":"https://api.github.com/users/crabtw/following{/other_user}","gists_url":"https://api.github.com/users/crabtw/gists{/gist_id}","starred_url":"https://api.github.com/users/crabtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crabtw/subscriptions","organizations_url":"https://api.github.com/users/crabtw/orgs","repos_url":"https://api.github.com/users/crabtw/repos","events_url":"https://api.github.com/users/crabtw/events{/privacy}","received_events_url":"https://api.github.com/users/crabtw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crabtw/rust-bindgen","description":"binding generator for rust language","fork":false,"url":"https://api.github.com/repos/crabtw/rust-bindgen","forks_url":"https://api.github.com/repos/crabtw/rust-bindgen/forks","keys_url":"https://api.github.com/repos/crabtw/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crabtw/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crabtw/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/crabtw/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/crabtw/rust-bindgen/events","assignees_url":"https://api.github.com/repos/crabtw/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/crabtw/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/crabtw/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crabtw/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/crabtw/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/crabtw/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/crabtw/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/crabtw/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/crabtw/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/crabtw/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/crabtw/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/crabtw/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/crabtw/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crabtw/rust-bindgen/merges","archive_url":"https://api.github.com/repos/crabtw/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crabtw/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/crabtw/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/crabtw/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crabtw/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/crabtw/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/crabtw/rust-bindgen/deployments","created_at":"2012-02-29T05:46:19Z","updated_at":"2016-03-15T02:46:51Z","pushed_at":"2016-03-17T07:04:59Z","git_url":"git://github.com/crabtw/rust-bindgen.git","ssh_url":"git@github.com:crabtw/rust-bindgen.git","clone_url":"https://github.com/crabtw/rust-bindgen.git","svn_url":"https://github.com/crabtw/rust-bindgen","homepage":"","size":1165,"stargazers_count":474,"watchers_count":474,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":52,"forks":103,"open_issues":52,"watchers":474,"default_branch":"master"}},"base":{"label":"crabtw:master","ref":"master","sha":"6f1904e52612db3a2517727c053e7cbc84601b2a","user":{"login":"crabtw","id":36015,"avatar_url":"https://avatars.githubusercontent.com/u/36015?v=3","gravatar_id":"","url":"https://api.github.com/users/crabtw","html_url":"https://github.com/crabtw","followers_url":"https://api.github.com/users/crabtw/followers","following_url":"https://api.github.com/users/crabtw/following{/other_user}","gists_url":"https://api.github.com/users/crabtw/gists{/gist_id}","starred_url":"https://api.github.com/users/crabtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crabtw/subscriptions","organizations_url":"https://api.github.com/users/crabtw/orgs","repos_url":"https://api.github.com/users/crabtw/repos","events_url":"https://api.github.com/users/crabtw/events{/privacy}","received_events_url":"https://api.github.com/users/crabtw/received_events","type":"User","site_admin":false},"repo":{"id":3579003,"name":"rust-bindgen","full_name":"crabtw/rust-bindgen","owner":{"login":"crabtw","id":36015,"avatar_url":"https://avatars.githubusercontent.com/u/36015?v=3","gravatar_id":"","url":"https://api.github.com/users/crabtw","html_url":"https://github.com/crabtw","followers_url":"https://api.github.com/users/crabtw/followers","following_url":"https://api.github.com/users/crabtw/following{/other_user}","gists_url":"https://api.github.com/users/crabtw/gists{/gist_id}","starred_url":"https://api.github.com/users/crabtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crabtw/subscriptions","organizations_url":"https://api.github.com/users/crabtw/orgs","repos_url":"https://api.github.com/users/crabtw/repos","events_url":"https://api.github.com/users/crabtw/events{/privacy}","received_events_url":"https://api.github.com/users/crabtw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crabtw/rust-bindgen","description":"binding generator for rust language","fork":false,"url":"https://api.github.com/repos/crabtw/rust-bindgen","forks_url":"https://api.github.com/repos/crabtw/rust-bindgen/forks","keys_url":"https://api.github.com/repos/crabtw/rust-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crabtw/rust-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crabtw/rust-bindgen/teams","hooks_url":"https://api.github.com/repos/crabtw/rust-bindgen/hooks","issue_events_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/crabtw/rust-bindgen/events","assignees_url":"https://api.github.com/repos/crabtw/rust-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/crabtw/rust-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/crabtw/rust-bindgen/tags","blobs_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crabtw/rust-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/crabtw/rust-bindgen/languages","stargazers_url":"https://api.github.com/repos/crabtw/rust-bindgen/stargazers","contributors_url":"https://api.github.com/repos/crabtw/rust-bindgen/contributors","subscribers_url":"https://api.github.com/repos/crabtw/rust-bindgen/subscribers","subscription_url":"https://api.github.com/repos/crabtw/rust-bindgen/subscription","commits_url":"https://api.github.com/repos/crabtw/rust-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/crabtw/rust-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/crabtw/rust-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/crabtw/rust-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/crabtw/rust-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crabtw/rust-bindgen/merges","archive_url":"https://api.github.com/repos/crabtw/rust-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crabtw/rust-bindgen/downloads","issues_url":"https://api.github.com/repos/crabtw/rust-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/crabtw/rust-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/crabtw/rust-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/crabtw/rust-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crabtw/rust-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/crabtw/rust-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/crabtw/rust-bindgen/deployments","created_at":"2012-02-29T05:46:19Z","updated_at":"2016-03-15T02:46:51Z","pushed_at":"2016-03-17T07:04:59Z","git_url":"git://github.com/crabtw/rust-bindgen.git","ssh_url":"git@github.com:crabtw/rust-bindgen.git","clone_url":"https://github.com/crabtw/rust-bindgen.git","svn_url":"https://github.com/crabtw/rust-bindgen","homepage":"","size":1165,"stargazers_count":474,"watchers_count":474,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":52,"forks":103,"open_issues":52,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296"},"html":{"href":"https://github.com/crabtw/rust-bindgen/pull/296"},"issue":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/issues/296"},"comments":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/crabtw/rust-bindgen/statuses/ff2419e837f6df6f7ea34cbddc505f2bfc3c29a7"}}}}