{"action":"opened","issue":{"url":"https://api.github.com/repos/mobify/pinny/issues/98","repository_url":"https://api.github.com/repos/mobify/pinny","labels_url":"https://api.github.com/repos/mobify/pinny/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/mobify/pinny/issues/98/comments","events_url":"https://api.github.com/repos/mobify/pinny/issues/98/events","html_url":"https://github.com/mobify/pinny/issues/98","id":163954350,"number":98,"title":"Improve a11y to close Pinny","user":{"login":"cole-sanderson","id":5376326,"avatar_url":"https://avatars.githubusercontent.com/u/5376326?v=3","gravatar_id":"","url":"https://api.github.com/users/cole-sanderson","html_url":"https://github.com/cole-sanderson","followers_url":"https://api.github.com/users/cole-sanderson/followers","following_url":"https://api.github.com/users/cole-sanderson/following{/other_user}","gists_url":"https://api.github.com/users/cole-sanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/cole-sanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cole-sanderson/subscriptions","organizations_url":"https://api.github.com/users/cole-sanderson/orgs","repos_url":"https://api.github.com/users/cole-sanderson/repos","events_url":"https://api.github.com/users/cole-sanderson/events{/privacy}","received_events_url":"https://api.github.com/users/cole-sanderson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-05T21:47:18Z","updated_at":"2016-07-05T21:47:18Z","closed_at":null,"body":"We are missing two features to allow user to close Pinny. \r\n\r\n- 1. There is a case that there is no close button in Pinny to close Pinny and screenreader wont be able to close Pinny. \r\n\r\nTo do: \r\n- Add visually hidden close button to structure at end of `pinny__wrapper` to allow screenreader to close Pinny after reading content in Pinny. \r\n\r\nCurrent structure: \r\n\r\n```html\r\n<div id=\"myPinny\" class=\"pinny__wrapper\" role=\"document\" hidden>\r\n    <div class=\"pinny__header\">\r\n        <a class=\"pinny__close\">close</a>\r\n    </div>\r\n    <div class=\"pinny__content pinny--is-scrollable\"></div>\r\n    <div class=\"pinny__footer\"></div>\r\n</div>\r\n```\r\n\r\nProposal structure: \r\n\r\n```html\r\n<div id=\"myPinny\" class=\"pinny__wrapper\" role=\"document\" hidden>\r\n    <div class=\"pinny__header\">\r\n        <button class=\"pinny__close\">close</button>\r\n    </div>\r\n    <div class=\"pinny__content pinny--is-scrollable\"></div>\r\n    <div class=\"pinny__footer\"></div>\r\n    <button class=\"pinny__visually-hidden-close pinny__close\">close</button>\r\n</div>\r\n```\r\n\r\n**Additional note**: We should be using <button> element instead of <a> since its behaviour button not linking to new page. \r\n\r\n- 2. Add 'escape' keyboard function to Pinny. When user tap 'escape' button on keyboard and it should close Pinny. "}}
{"actor":{"display_login":"cole-sanderson"}}