{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/rasterio/issues/754","repository_url":"https://api.github.com/repos/mapbox/rasterio","labels_url":"https://api.github.com/repos/mapbox/rasterio/issues/754/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/rasterio/issues/754/comments","events_url":"https://api.github.com/repos/mapbox/rasterio/issues/754/events","html_url":"https://github.com/mapbox/rasterio/issues/754","id":158234102,"number":754,"title":"VFS tests fail on Windows due to path strings","user":{"login":"grovduck","id":1706997,"avatar_url":"https://avatars.githubusercontent.com/u/1706997?v=3","gravatar_id":"","url":"https://api.github.com/users/grovduck","html_url":"https://github.com/grovduck","followers_url":"https://api.github.com/users/grovduck/followers","following_url":"https://api.github.com/users/grovduck/following{/other_user}","gists_url":"https://api.github.com/users/grovduck/gists{/gist_id}","starred_url":"https://api.github.com/users/grovduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grovduck/subscriptions","organizations_url":"https://api.github.com/users/grovduck/orgs","repos_url":"https://api.github.com/users/grovduck/repos","events_url":"https://api.github.com/users/grovduck/events{/privacy}","received_events_url":"https://api.github.com/users/grovduck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-02T20:38:24Z","updated_at":"2016-06-10T13:09:07Z","closed_at":null,"body":"Running `py.test -v tests\\test_rio_options.py` on Windows fails because of UNIX-style paths in tests.  Specifically, two tests fail:\r\n\r\n    tests\\test_rio_options.py::test_file_in_handler_with_vfs FAILED\r\n    tests\\test_rio_options.py::test_file_in_handler_with_vfs_file FAILED\r\n\r\nFor `test_file_in_handler_with_vfs_file`, I think it can be fixed with:\r\n    \r\n    assert retval.endswith(os.path.normpath('tests/data/RGB.byte.tif'))\r\n\r\nbut not sure what to do about `test_file_in_handler_with_vfs`.  My `retval` from line 54 is:\r\n\r\n    'zip://D:\\\\matt\\\\rasterio\\\\tests\\\\data\\\\files.zip!/inputs/RGB.byte.tif'\r\n\r\nso the path to the zip file is Windows, path inside the zip is UNIX.  Both asserts fail here.  Hopefully an easy one ...\r\n  "},"comment":{"url":"https://api.github.com/repos/mapbox/rasterio/issues/comments/225177409","html_url":"https://github.com/mapbox/rasterio/issues/754#issuecomment-225177409","issue_url":"https://api.github.com/repos/mapbox/rasterio/issues/754","id":225177409,"user":{"login":"perrygeo","id":1151287,"avatar_url":"https://avatars.githubusercontent.com/u/1151287?v=3","gravatar_id":"","url":"https://api.github.com/users/perrygeo","html_url":"https://github.com/perrygeo","followers_url":"https://api.github.com/users/perrygeo/followers","following_url":"https://api.github.com/users/perrygeo/following{/other_user}","gists_url":"https://api.github.com/users/perrygeo/gists{/gist_id}","starred_url":"https://api.github.com/users/perrygeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrygeo/subscriptions","organizations_url":"https://api.github.com/users/perrygeo/orgs","repos_url":"https://api.github.com/users/perrygeo/repos","events_url":"https://api.github.com/users/perrygeo/events{/privacy}","received_events_url":"https://api.github.com/users/perrygeo/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T13:09:07Z","updated_at":"2016-06-10T13:09:07Z","body":"For the `test_file_in_handler_with_vfs_file` fix, can you submit a PR for that? sounds like a good idea.\r\n\r\nFor the `zip://` paths I really don't have a good answer and no way to test for one. Can you confirm that using vfs zip files even works at all on windows? If not, then the issue is beyond testing and we should xfail that test on the windows platform."}}
{"actor":{"display_login":"perrygeo"}}