{"action":"closed","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/9669","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/9669/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/9669/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/9669/events","html_url":"https://github.com/dotnet/corefx/issues/9669","id":162201420,"number":9669,"title":"Trace uses the string DEFAULT_APPNAME unconditionally in logged messages","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"labels":[{"id":158547585,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Diagnostics","name":"area-System.Diagnostics","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestones/1.2.0","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"1.2.0","description":".NET Core 1.2 Placeholder.  https://github.com/dotnet/core/blob/master/roadmap.md","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":516,"closed_issues":1537,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-11-08T04:02:21Z","due_on":"2017-04-30T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-06-24T18:13:05Z","updated_at":"2016-11-08T04:02:21Z","closed_at":"2016-11-08T04:02:20Z","body":"This looks like a temporary workaround that was never fully resolved, and got lost in an old bug tracker.\n\nhttps://github.com/dotnet/corefx/blob/d0dc5fc099946adc1035b34a8b1f6042eddb0c75/src/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceInternal.cs#L52\n\n``` CSharp\n// This needs to be updated once we have the correct property implemented in the Environment class.\n// Bug:895000 is tracking this.\ns_appName = \"DEFAULT_APPNAME\";\n```\n\nDesktop uses the code below, which may not be a good idea in today's world where the first command-line arg is often the CLR host.\n\n``` CSharp\nappName = Path.GetFileName(Environment.GetCommandLineArgs()[0]);\n```\n\nI propose we use `Assembly.GetEntryAssembly()`, but it would require us to bump the support up to `netstandard1.5`:\n\n``` CSharp\ns_appName = Assembly.GetEntryAssembly().GetName().Name;\n```\n"}}
{"actor":{"display_login":"stephentoub"}}