{"action":"created","comment":{"url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/comments/60222117","id":60222117,"diff_hunk":"@@ -43,13 +43,14 @@ module.exports = {\n   registerRoutes (app, server) {\n     _.each(app.routes, route => server.route(route))\n \n-    if (app.config.web.assets) {\n+    if (app.config.main.paths.www) {","path":"lib/server.js","position":5,"original_position":5,"commit_id":"4f8ef74d9b6e452ad1bf1dbccb7701d3ab2518e6","original_commit_id":"4f8ef74d9b6e452ad1bf1dbccb7701d3ab2518e6","user":{"login":"jaumard","id":2970449,"avatar_url":"https://avatars.githubusercontent.com/u/2970449?v=3","gravatar_id":"","url":"https://api.github.com/users/jaumard","html_url":"https://github.com/jaumard","followers_url":"https://api.github.com/users/jaumard/followers","following_url":"https://api.github.com/users/jaumard/following{/other_user}","gists_url":"https://api.github.com/users/jaumard/gists{/gist_id}","starred_url":"https://api.github.com/users/jaumard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaumard/subscriptions","organizations_url":"https://api.github.com/users/jaumard/orgs","repos_url":"https://api.github.com/users/jaumard/repos","events_url":"https://api.github.com/users/jaumard/events{/privacy}","received_events_url":"https://api.github.com/users/jaumard/received_events","type":"User","site_admin":false},"body":"In express I log a message when `app.config.main.paths.www` is not set. Like this user know it have to set it if he want static assets :) look https://github.com/trailsjs/trailpack-express4/blob/master/lib/server.js#L37 it also have to be on documentation but I think it's good to say it here","created_at":"2016-04-19T12:39:00Z","updated_at":"2016-04-19T12:39:00Z","html_url":"https://github.com/trailsjs/trailpack-hapi/pull/77#discussion_r60222117","pull_request_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/comments/60222117"},"html":{"href":"https://github.com/trailsjs/trailpack-hapi/pull/77#discussion_r60222117"},"pull_request":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77","id":66893178,"html_url":"https://github.com/trailsjs/trailpack-hapi/pull/77","diff_url":"https://github.com/trailsjs/trailpack-hapi/pull/77.diff","patch_url":"https://github.com/trailsjs/trailpack-hapi/pull/77.patch","issue_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/77","number":77,"state":"open","locked":false,"title":"Express similar","user":{"login":"weyj4","id":10169274,"avatar_url":"https://avatars.githubusercontent.com/u/10169274?v=3","gravatar_id":"","url":"https://api.github.com/users/weyj4","html_url":"https://github.com/weyj4","followers_url":"https://api.github.com/users/weyj4/followers","following_url":"https://api.github.com/users/weyj4/following{/other_user}","gists_url":"https://api.github.com/users/weyj4/gists{/gist_id}","starred_url":"https://api.github.com/users/weyj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weyj4/subscriptions","organizations_url":"https://api.github.com/users/weyj4/orgs","repos_url":"https://api.github.com/users/weyj4/repos","events_url":"https://api.github.com/users/weyj4/events{/privacy}","received_events_url":"https://api.github.com/users/weyj4/received_events","type":"User","site_admin":false},"body":"This is an effort to make config uniform between trailpack-hapi and trailpack-express4. trailpack-express4 has the user declare static directory in app.config.main.paths, so we should do that here as well.\r\n\r\nSee this issue: [75](https://github.com/trailsjs/trailpack-hapi/issues/75)\r\n\r\nAlso, we need to decide if the user must use path.resolve(...) to declare the static directory. It is required by trailpack-express4 currently: [10](https://github.com/trailsjs/trailpack-express4/issues/10)","created_at":"2016-04-18T17:44:27Z","updated_at":"2016-04-19T12:39:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abef4904546bbbcc2563b9c9d120e8624d181d65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77/commits","review_comments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77/comments","review_comment_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/77/comments","statuses_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/statuses/4f8ef74d9b6e452ad1bf1dbccb7701d3ab2518e6","head":{"label":"trailsjs:express-similar","ref":"express-similar","sha":"4f8ef74d9b6e452ad1bf1dbccb7701d3ab2518e6","user":{"login":"trailsjs","id":15969634,"avatar_url":"https://avatars.githubusercontent.com/u/15969634?v=3","gravatar_id":"","url":"https://api.github.com/users/trailsjs","html_url":"https://github.com/trailsjs","followers_url":"https://api.github.com/users/trailsjs/followers","following_url":"https://api.github.com/users/trailsjs/following{/other_user}","gists_url":"https://api.github.com/users/trailsjs/gists{/gist_id}","starred_url":"https://api.github.com/users/trailsjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailsjs/subscriptions","organizations_url":"https://api.github.com/users/trailsjs/orgs","repos_url":"https://api.github.com/users/trailsjs/repos","events_url":"https://api.github.com/users/trailsjs/events{/privacy}","received_events_url":"https://api.github.com/users/trailsjs/received_events","type":"Organization","site_admin":false},"repo":{"id":46914697,"name":"trailpack-hapi","full_name":"trailsjs/trailpack-hapi","owner":{"login":"trailsjs","id":15969634,"avatar_url":"https://avatars.githubusercontent.com/u/15969634?v=3","gravatar_id":"","url":"https://api.github.com/users/trailsjs","html_url":"https://github.com/trailsjs","followers_url":"https://api.github.com/users/trailsjs/followers","following_url":"https://api.github.com/users/trailsjs/following{/other_user}","gists_url":"https://api.github.com/users/trailsjs/gists{/gist_id}","starred_url":"https://api.github.com/users/trailsjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailsjs/subscriptions","organizations_url":"https://api.github.com/users/trailsjs/orgs","repos_url":"https://api.github.com/users/trailsjs/repos","events_url":"https://api.github.com/users/trailsjs/events{/privacy}","received_events_url":"https://api.github.com/users/trailsjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trailsjs/trailpack-hapi","description":":package: Hapi.js Trailpack","fork":false,"url":"https://api.github.com/repos/trailsjs/trailpack-hapi","forks_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/forks","keys_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/teams","hooks_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/hooks","issue_events_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/events{/number}","events_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/events","assignees_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/assignees{/user}","branches_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/branches{/branch}","tags_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/tags","blobs_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/statuses/{sha}","languages_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/languages","stargazers_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/stargazers","contributors_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/contributors","subscribers_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/subscribers","subscription_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/subscription","commits_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/contents/{+path}","compare_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/merges","archive_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/downloads","issues_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues{/number}","pulls_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls{/number}","milestones_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/milestones{/number}","notifications_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/labels{/name}","releases_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/releases{/id}","deployments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/deployments","created_at":"2015-11-26T08:47:54Z","updated_at":"2016-04-10T01:53:09Z","pushed_at":"2016-04-19T11:59:55Z","git_url":"git://github.com/trailsjs/trailpack-hapi.git","ssh_url":"git@github.com:trailsjs/trailpack-hapi.git","clone_url":"https://github.com/trailsjs/trailpack-hapi.git","svn_url":"https://github.com/trailsjs/trailpack-hapi","homepage":null,"size":107,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":8,"default_branch":"master"}},"base":{"label":"trailsjs:master","ref":"master","sha":"855ed66ccd5d88ffc2b9ae6fb871214ae3a0bca1","user":{"login":"trailsjs","id":15969634,"avatar_url":"https://avatars.githubusercontent.com/u/15969634?v=3","gravatar_id":"","url":"https://api.github.com/users/trailsjs","html_url":"https://github.com/trailsjs","followers_url":"https://api.github.com/users/trailsjs/followers","following_url":"https://api.github.com/users/trailsjs/following{/other_user}","gists_url":"https://api.github.com/users/trailsjs/gists{/gist_id}","starred_url":"https://api.github.com/users/trailsjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailsjs/subscriptions","organizations_url":"https://api.github.com/users/trailsjs/orgs","repos_url":"https://api.github.com/users/trailsjs/repos","events_url":"https://api.github.com/users/trailsjs/events{/privacy}","received_events_url":"https://api.github.com/users/trailsjs/received_events","type":"Organization","site_admin":false},"repo":{"id":46914697,"name":"trailpack-hapi","full_name":"trailsjs/trailpack-hapi","owner":{"login":"trailsjs","id":15969634,"avatar_url":"https://avatars.githubusercontent.com/u/15969634?v=3","gravatar_id":"","url":"https://api.github.com/users/trailsjs","html_url":"https://github.com/trailsjs","followers_url":"https://api.github.com/users/trailsjs/followers","following_url":"https://api.github.com/users/trailsjs/following{/other_user}","gists_url":"https://api.github.com/users/trailsjs/gists{/gist_id}","starred_url":"https://api.github.com/users/trailsjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailsjs/subscriptions","organizations_url":"https://api.github.com/users/trailsjs/orgs","repos_url":"https://api.github.com/users/trailsjs/repos","events_url":"https://api.github.com/users/trailsjs/events{/privacy}","received_events_url":"https://api.github.com/users/trailsjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trailsjs/trailpack-hapi","description":":package: Hapi.js Trailpack","fork":false,"url":"https://api.github.com/repos/trailsjs/trailpack-hapi","forks_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/forks","keys_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/teams","hooks_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/hooks","issue_events_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/events{/number}","events_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/events","assignees_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/assignees{/user}","branches_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/branches{/branch}","tags_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/tags","blobs_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/statuses/{sha}","languages_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/languages","stargazers_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/stargazers","contributors_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/contributors","subscribers_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/subscribers","subscription_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/subscription","commits_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/contents/{+path}","compare_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/merges","archive_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/downloads","issues_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues{/number}","pulls_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls{/number}","milestones_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/milestones{/number}","notifications_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/labels{/name}","releases_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/releases{/id}","deployments_url":"https://api.github.com/repos/trailsjs/trailpack-hapi/deployments","created_at":"2015-11-26T08:47:54Z","updated_at":"2016-04-10T01:53:09Z","pushed_at":"2016-04-19T11:59:55Z","git_url":"git://github.com/trailsjs/trailpack-hapi.git","ssh_url":"git@github.com:trailsjs/trailpack-hapi.git","clone_url":"https://github.com/trailsjs/trailpack-hapi.git","svn_url":"https://github.com/trailsjs/trailpack-hapi","homepage":null,"size":107,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":17,"forks":7,"open_issues":17,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77"},"html":{"href":"https://github.com/trailsjs/trailpack-hapi/pull/77"},"issue":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/77"},"comments":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/trailsjs/trailpack-hapi/statuses/4f8ef74d9b6e452ad1bf1dbccb7701d3ab2518e6"}}}}