{"action":"created","comment":{"url":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments/77521905","id":77521905,"diff_hunk":"@@ -504,6 +504,22 @@ app.DocumentEditingController.prototype.pushToArray = function(object, property,\n   app.utils.pushToArray(object, property, value, event);\n };\n \n+/**\n+ * @param {number} value\n+ * @export\n+ */\n+app.DocumentEditingController.prototype.convertExposureTime = function(value) {\n+  if (value === 0) {\n+    this['scope']['image']['exposure_time_converted'] = this.alerts.gettext('cannot be 0');","path":"c2corg_ui/static/js/documentediting.js","position":61,"original_position":10,"commit_id":"2330bd38a97b1ec5ba5effa4d959bac44efd4e0d","original_commit_id":"fc60dad25a1c66ec22ad870220fdfc741054a8cd","user":{"login":"ginold","id":7814311,"avatar_url":"https://avatars.githubusercontent.com/u/7814311?v=3","gravatar_id":"","url":"https://api.github.com/users/ginold","html_url":"https://github.com/ginold","followers_url":"https://api.github.com/users/ginold/followers","following_url":"https://api.github.com/users/ginold/following{/other_user}","gists_url":"https://api.github.com/users/ginold/gists{/gist_id}","starred_url":"https://api.github.com/users/ginold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginold/subscriptions","organizations_url":"https://api.github.com/users/ginold/orgs","repos_url":"https://api.github.com/users/ginold/repos","events_url":"https://api.github.com/users/ginold/events{/privacy}","received_events_url":"https://api.github.com/users/ginold/received_events","type":"User","site_admin":false},"body":"i used `aletrs.gettext` only to get a translated version of the message string t:P  but i'm not sure if that service does it like the `mainController's` `translate()`","created_at":"2016-09-05T13:28:28Z","updated_at":"2016-09-05T13:28:28Z","html_url":"https://github.com/c2corg/v6_ui/pull/582#discussion_r77521905","pull_request_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments/77521905"},"html":{"href":"https://github.com/c2corg/v6_ui/pull/582#discussion_r77521905"},"pull_request":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/c2corg/v6_ui/pulls/582","id":83431633,"html_url":"https://github.com/c2corg/v6_ui/pull/582","diff_url":"https://github.com/c2corg/v6_ui/pull/582.diff","patch_url":"https://github.com/c2corg/v6_ui/pull/582.patch","issue_url":"https://api.github.com/repos/c2corg/v6_ui/issues/582","number":582,"state":"open","locked":false,"title":"Image detail-view + edit + list pages","user":{"login":"ginold","id":7814311,"avatar_url":"https://avatars.githubusercontent.com/u/7814311?v=3","gravatar_id":"","url":"https://api.github.com/users/ginold","html_url":"https://github.com/ginold","followers_url":"https://api.github.com/users/ginold/followers","following_url":"https://api.github.com/users/ginold/following{/other_user}","gists_url":"https://api.github.com/users/ginold/gists{/gist_id}","starred_url":"https://api.github.com/users/ginold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginold/subscriptions","organizations_url":"https://api.github.com/users/ginold/orgs","repos_url":"https://api.github.com/users/ginold/repos","events_url":"https://api.github.com/users/ginold/events{/privacy}","received_events_url":"https://api.github.com/users/ginold/received_events","type":"User","site_admin":false},"body":"a combination of #575 and #550 with further improvements and some other fixups.\r\n\r\nDon't know why the commits appear in disorder, they are ordered in my git log. \r\n\r\nCloses https://github.com/c2corg/v6_ui/issues/586","created_at":"2016-08-31T11:03:22Z","updated_at":"2016-09-05T13:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eaa99d428d136a047076871e39c945051a59bfd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/582/commits","review_comments_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/582/comments","review_comment_url":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/issues/582/comments","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/2330bd38a97b1ec5ba5effa4d959bac44efd4e0d","head":{"label":"c2corg:image-view-editing","ref":"image-view-editing","sha":"2330bd38a97b1ec5ba5effa4d959bac44efd4e0d","user":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"repo":{"id":43445823,"name":"v6_ui","full_name":"c2corg/v6_ui","owner":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/c2corg/v6_ui","description":"UI for c2c.org v6","fork":false,"url":"https://api.github.com/repos/c2corg/v6_ui","forks_url":"https://api.github.com/repos/c2corg/v6_ui/forks","keys_url":"https://api.github.com/repos/c2corg/v6_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c2corg/v6_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c2corg/v6_ui/teams","hooks_url":"https://api.github.com/repos/c2corg/v6_ui/hooks","issue_events_url":"https://api.github.com/repos/c2corg/v6_ui/issues/events{/number}","events_url":"https://api.github.com/repos/c2corg/v6_ui/events","assignees_url":"https://api.github.com/repos/c2corg/v6_ui/assignees{/user}","branches_url":"https://api.github.com/repos/c2corg/v6_ui/branches{/branch}","tags_url":"https://api.github.com/repos/c2corg/v6_ui/tags","blobs_url":"https://api.github.com/repos/c2corg/v6_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c2corg/v6_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c2corg/v6_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/c2corg/v6_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/c2corg/v6_ui/languages","stargazers_url":"https://api.github.com/repos/c2corg/v6_ui/stargazers","contributors_url":"https://api.github.com/repos/c2corg/v6_ui/contributors","subscribers_url":"https://api.github.com/repos/c2corg/v6_ui/subscribers","subscription_url":"https://api.github.com/repos/c2corg/v6_ui/subscription","commits_url":"https://api.github.com/repos/c2corg/v6_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/c2corg/v6_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/c2corg/v6_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/c2corg/v6_ui/contents/{+path}","compare_url":"https://api.github.com/repos/c2corg/v6_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c2corg/v6_ui/merges","archive_url":"https://api.github.com/repos/c2corg/v6_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c2corg/v6_ui/downloads","issues_url":"https://api.github.com/repos/c2corg/v6_ui/issues{/number}","pulls_url":"https://api.github.com/repos/c2corg/v6_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/c2corg/v6_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/c2corg/v6_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c2corg/v6_ui/labels{/name}","releases_url":"https://api.github.com/repos/c2corg/v6_ui/releases{/id}","deployments_url":"https://api.github.com/repos/c2corg/v6_ui/deployments","created_at":"2015-09-30T16:52:44Z","updated_at":"2016-04-12T09:20:57Z","pushed_at":"2016-09-05T12:47:50Z","git_url":"git://github.com/c2corg/v6_ui.git","ssh_url":"git@github.com:c2corg/v6_ui.git","clone_url":"https://github.com/c2corg/v6_ui.git","svn_url":"https://github.com/c2corg/v6_ui","homepage":null,"size":2490,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":91,"forks":3,"open_issues":91,"watchers":2,"default_branch":"master"}},"base":{"label":"c2corg:master","ref":"master","sha":"d5d548c7db5163e9aaf6389b76b2e70b83bf28ba","user":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"repo":{"id":43445823,"name":"v6_ui","full_name":"c2corg/v6_ui","owner":{"login":"c2corg","id":3200587,"avatar_url":"https://avatars.githubusercontent.com/u/3200587?v=3","gravatar_id":"","url":"https://api.github.com/users/c2corg","html_url":"https://github.com/c2corg","followers_url":"https://api.github.com/users/c2corg/followers","following_url":"https://api.github.com/users/c2corg/following{/other_user}","gists_url":"https://api.github.com/users/c2corg/gists{/gist_id}","starred_url":"https://api.github.com/users/c2corg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c2corg/subscriptions","organizations_url":"https://api.github.com/users/c2corg/orgs","repos_url":"https://api.github.com/users/c2corg/repos","events_url":"https://api.github.com/users/c2corg/events{/privacy}","received_events_url":"https://api.github.com/users/c2corg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/c2corg/v6_ui","description":"UI for c2c.org v6","fork":false,"url":"https://api.github.com/repos/c2corg/v6_ui","forks_url":"https://api.github.com/repos/c2corg/v6_ui/forks","keys_url":"https://api.github.com/repos/c2corg/v6_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c2corg/v6_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c2corg/v6_ui/teams","hooks_url":"https://api.github.com/repos/c2corg/v6_ui/hooks","issue_events_url":"https://api.github.com/repos/c2corg/v6_ui/issues/events{/number}","events_url":"https://api.github.com/repos/c2corg/v6_ui/events","assignees_url":"https://api.github.com/repos/c2corg/v6_ui/assignees{/user}","branches_url":"https://api.github.com/repos/c2corg/v6_ui/branches{/branch}","tags_url":"https://api.github.com/repos/c2corg/v6_ui/tags","blobs_url":"https://api.github.com/repos/c2corg/v6_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c2corg/v6_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c2corg/v6_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/c2corg/v6_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c2corg/v6_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/c2corg/v6_ui/languages","stargazers_url":"https://api.github.com/repos/c2corg/v6_ui/stargazers","contributors_url":"https://api.github.com/repos/c2corg/v6_ui/contributors","subscribers_url":"https://api.github.com/repos/c2corg/v6_ui/subscribers","subscription_url":"https://api.github.com/repos/c2corg/v6_ui/subscription","commits_url":"https://api.github.com/repos/c2corg/v6_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/c2corg/v6_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/c2corg/v6_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/c2corg/v6_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/c2corg/v6_ui/contents/{+path}","compare_url":"https://api.github.com/repos/c2corg/v6_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c2corg/v6_ui/merges","archive_url":"https://api.github.com/repos/c2corg/v6_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c2corg/v6_ui/downloads","issues_url":"https://api.github.com/repos/c2corg/v6_ui/issues{/number}","pulls_url":"https://api.github.com/repos/c2corg/v6_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/c2corg/v6_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/c2corg/v6_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c2corg/v6_ui/labels{/name}","releases_url":"https://api.github.com/repos/c2corg/v6_ui/releases{/id}","deployments_url":"https://api.github.com/repos/c2corg/v6_ui/deployments","created_at":"2015-09-30T16:52:44Z","updated_at":"2016-04-12T09:20:57Z","pushed_at":"2016-09-05T12:47:50Z","git_url":"git://github.com/c2corg/v6_ui.git","ssh_url":"git@github.com:c2corg/v6_ui.git","clone_url":"https://github.com/c2corg/v6_ui.git","svn_url":"https://github.com/c2corg/v6_ui","homepage":null,"size":2490,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":91,"forks":3,"open_issues":91,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/582"},"html":{"href":"https://github.com/c2corg/v6_ui/pull/582"},"issue":{"href":"https://api.github.com/repos/c2corg/v6_ui/issues/582"},"comments":{"href":"https://api.github.com/repos/c2corg/v6_ui/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c2corg/v6_ui/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/c2corg/v6_ui/statuses/2330bd38a97b1ec5ba5effa4d959bac44efd4e0d"}}}}
{"actor":{"display_login":"ginold"}}