{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/90615392","pull_request_review_id":11133749,"id":90615392,"diff_hunk":"@@ -205,6 +206,16 @@ private void attemptAuthentication(HttpServerRequest request) throws HttpAuthent\n     }\n \n     private boolean authorize(String username, HttpServerRequest request) throws HttpAuthenticationException {\n+        if (log.isTraceEnabled()) {","path":"src/main/java/org/wildfly/security/http/impl/FormAuthenticationMechanism.java","position":12,"original_position":12,"commit_id":"71b813a571c9a972ab2ad0fc054d4a2805a664cf","original_commit_id":"71b813a571c9a972ab2ad0fc054d4a2805a664cf","user":{"login":"iweiss","id":4449438,"avatar_url":"https://avatars.githubusercontent.com/u/4449438?v=3","gravatar_id":"","url":"https://api.github.com/users/iweiss","html_url":"https://github.com/iweiss","followers_url":"https://api.github.com/users/iweiss/followers","following_url":"https://api.github.com/users/iweiss/following{/other_user}","gists_url":"https://api.github.com/users/iweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/iweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iweiss/subscriptions","organizations_url":"https://api.github.com/users/iweiss/orgs","repos_url":"https://api.github.com/users/iweiss/repos","events_url":"https://api.github.com/users/iweiss/events{/privacy}","received_events_url":"https://api.github.com/users/iweiss/received_events","type":"User","site_admin":false},"body":"Understood. My train of thought is to provide referential information between the login action and its associated session.","created_at":"2016-12-02T10:05:23Z","updated_at":"2016-12-02T10:05:23Z","html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/504#discussion_r90615392","pull_request_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504","_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments/90615392"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/504#discussion_r90615392"},"pull_request":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504","id":88088763,"html_url":"https://github.com/wildfly-security/wildfly-elytron/pull/504","diff_url":"https://github.com/wildfly-security/wildfly-elytron/pull/504.diff","patch_url":"https://github.com/wildfly-security/wildfly-elytron/pull/504.patch","issue_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/504","number":504,"state":"open","locked":false,"title":"[ELY-632] No log messages comming from Elytron - authentication process start","user":{"login":"iweiss","id":4449438,"avatar_url":"https://avatars.githubusercontent.com/u/4449438?v=3","gravatar_id":"","url":"https://api.github.com/users/iweiss","html_url":"https://github.com/iweiss","followers_url":"https://api.github.com/users/iweiss/followers","following_url":"https://api.github.com/users/iweiss/following{/other_user}","gists_url":"https://api.github.com/users/iweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/iweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iweiss/subscriptions","organizations_url":"https://api.github.com/users/iweiss/orgs","repos_url":"https://api.github.com/users/iweiss/repos","events_url":"https://api.github.com/users/iweiss/events{/privacy}","received_events_url":"https://api.github.com/users/iweiss/received_events","type":"User","site_admin":false},"body":"Issue: https://issues.jboss.org/browse/ELY-632\n\nThis is a request for comments at the moment. I'm looking for an opinion if that's what is expected/wanted from this issue and, if not, what should be changes before I commit to a full PR.\n","created_at":"2016-10-05T14:28:25Z","updated_at":"2016-12-02T10:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0e734e6405f2e621937e61dec390bb899e82d77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504/commits","review_comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504/comments","review_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/504/comments","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/71b813a571c9a972ab2ad0fc054d4a2805a664cf","head":{"label":"iweiss:ELY-632","ref":"ELY-632","sha":"71b813a571c9a972ab2ad0fc054d4a2805a664cf","user":{"login":"iweiss","id":4449438,"avatar_url":"https://avatars.githubusercontent.com/u/4449438?v=3","gravatar_id":"","url":"https://api.github.com/users/iweiss","html_url":"https://github.com/iweiss","followers_url":"https://api.github.com/users/iweiss/followers","following_url":"https://api.github.com/users/iweiss/following{/other_user}","gists_url":"https://api.github.com/users/iweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/iweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iweiss/subscriptions","organizations_url":"https://api.github.com/users/iweiss/orgs","repos_url":"https://api.github.com/users/iweiss/repos","events_url":"https://api.github.com/users/iweiss/events{/privacy}","received_events_url":"https://api.github.com/users/iweiss/received_events","type":"User","site_admin":false},"repo":{"id":30182956,"name":"wildfly-elytron","full_name":"iweiss/wildfly-elytron","owner":{"login":"iweiss","id":4449438,"avatar_url":"https://avatars.githubusercontent.com/u/4449438?v=3","gravatar_id":"","url":"https://api.github.com/users/iweiss","html_url":"https://github.com/iweiss","followers_url":"https://api.github.com/users/iweiss/followers","following_url":"https://api.github.com/users/iweiss/following{/other_user}","gists_url":"https://api.github.com/users/iweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/iweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iweiss/subscriptions","organizations_url":"https://api.github.com/users/iweiss/orgs","repos_url":"https://api.github.com/users/iweiss/repos","events_url":"https://api.github.com/users/iweiss/events{/privacy}","received_events_url":"https://api.github.com/users/iweiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iweiss/wildfly-elytron","description":"WildFly Elytron: Security, Authentication, and Authorization SPIs for the WildFly project","fork":true,"url":"https://api.github.com/repos/iweiss/wildfly-elytron","forks_url":"https://api.github.com/repos/iweiss/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/iweiss/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iweiss/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iweiss/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/iweiss/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/iweiss/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/iweiss/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/iweiss/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/iweiss/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/iweiss/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/iweiss/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iweiss/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iweiss/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/iweiss/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iweiss/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/iweiss/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/iweiss/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/iweiss/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/iweiss/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/iweiss/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/iweiss/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/iweiss/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/iweiss/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/iweiss/wildfly-elytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/iweiss/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/iweiss/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iweiss/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/iweiss/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iweiss/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/iweiss/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/iweiss/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/iweiss/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/iweiss/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iweiss/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/iweiss/wildfly-elytron/releases{/id}","deployments_url":"https://api.github.com/repos/iweiss/wildfly-elytron/deployments","created_at":"2015-02-02T10:53:49Z","updated_at":"2016-09-22T10:04:13Z","pushed_at":"2016-12-02T09:58:15Z","git_url":"git://github.com/iweiss/wildfly-elytron.git","ssh_url":"git@github.com:iweiss/wildfly-elytron.git","clone_url":"https://github.com/iweiss/wildfly-elytron.git","svn_url":"https://github.com/iweiss/wildfly-elytron","homepage":"http://wildfly.org/","size":9054,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-security:master","ref":"master","sha":"4ce3aea60b9f5c2a6fb483c6340dc5abbb5be79e","user":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars.githubusercontent.com/u/7501379?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"repo":{"id":13660977,"name":"wildfly-elytron","full_name":"wildfly-security/wildfly-elytron","owner":{"login":"wildfly-security","id":7501379,"avatar_url":"https://avatars.githubusercontent.com/u/7501379?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security","html_url":"https://github.com/wildfly-security","followers_url":"https://api.github.com/users/wildfly-security/followers","following_url":"https://api.github.com/users/wildfly-security/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security/orgs","repos_url":"https://api.github.com/users/wildfly-security/repos","events_url":"https://api.github.com/users/wildfly-security/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security/wildfly-elytron","description":"WildFly Elytron: Security, Authentication, and Authorization SPIs for the WildFly project","fork":false,"url":"https://api.github.com/repos/wildfly-security/wildfly-elytron","forks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/forks","keys_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/teams","hooks_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/events","assignees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/tags","blobs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/languages","stargazers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/subscription","commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/merges","archive_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/downloads","issues_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-security/wildfly-elytron/deployments","created_at":"2013-10-17T20:57:07Z","updated_at":"2016-11-04T19:22:21Z","pushed_at":"2016-12-02T09:55:27Z","git_url":"git://github.com/wildfly-security/wildfly-elytron.git","ssh_url":"git@github.com:wildfly-security/wildfly-elytron.git","clone_url":"https://github.com/wildfly-security/wildfly-elytron.git","svn_url":"https://github.com/wildfly-security/wildfly-elytron","homepage":"http://wildfly.org/","size":26179,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":9,"forks":32,"open_issues":9,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504"},"html":{"href":"https://github.com/wildfly-security/wildfly-elytron/pull/504"},"issue":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/504"},"comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-security/wildfly-elytron/statuses/71b813a571c9a972ab2ad0fc054d4a2805a664cf"}}}}
{"actor":{"display_login":"iweiss"}}