{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/63935437","id":63935437,"diff_hunk":"@@ -159,9 +159,8 @@ bool ExecVariableListCodegen::GenerateExecVariableList(\n   }\n \n   // So looks like we're going to generate code\n-  llvm::Function* ExecVariableList_func = codegen_utils->\n-      CreateFunction<ExecVariableListFn>(\n-          GetUniqueFuncName());\n+  llvm::Function* ExecVariableList_func = CreateFunction<ExecVariableListFn>(","path":"src/backend/codegen/ExecVariableList_codegen.cc","position":7,"original_position":7,"commit_id":"d140610d01db89184bf8371929435fcea2f80fc6","original_commit_id":"d140610d01db89184bf8371929435fcea2f80fc6","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"body":":)","created_at":"2016-05-19T18:58:18Z","updated_at":"2016-05-19T18:58:18Z","html_url":"https://github.com/greenplum-db/gpdb/pull/764#discussion_r63935437","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/63935437"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/764#discussion_r63935437"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764","id":70618656,"html_url":"https://github.com/greenplum-db/gpdb/pull/764","diff_url":"https://github.com/greenplum-db/gpdb/pull/764.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/764.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/764","number":764,"state":"open","locked":false,"title":"Enhance Base Codegen to do clean up when generation fails","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"body":"When generator failed to generate code, base codegen will handle the clean up. It is important to remove those broken functions else llvm exit when it compiles \r\n\r\n@foyzur @hardikar @armenatzoglou @gcaragea Please take a look when you get chance.","created_at":"2016-05-19T00:00:37Z","updated_at":"2016-05-19T18:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46f6221d67e238d2596d4313cb53d25828933bcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/764/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/d140610d01db89184bf8371929435fcea2f80fc6","head":{"label":"karthijrk:cg-broken","ref":"cg-broken","sha":"d140610d01db89184bf8371929435fcea2f80fc6","user":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"repo":{"id":46308528,"name":"gpdb","full_name":"karthijrk/gpdb","owner":{"login":"karthijrk","id":5432707,"avatar_url":"https://avatars.githubusercontent.com/u/5432707?v=3","gravatar_id":"","url":"https://api.github.com/users/karthijrk","html_url":"https://github.com/karthijrk","followers_url":"https://api.github.com/users/karthijrk/followers","following_url":"https://api.github.com/users/karthijrk/following{/other_user}","gists_url":"https://api.github.com/users/karthijrk/gists{/gist_id}","starred_url":"https://api.github.com/users/karthijrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthijrk/subscriptions","organizations_url":"https://api.github.com/users/karthijrk/orgs","repos_url":"https://api.github.com/users/karthijrk/repos","events_url":"https://api.github.com/users/karthijrk/events{/privacy}","received_events_url":"https://api.github.com/users/karthijrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karthijrk/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/karthijrk/gpdb","forks_url":"https://api.github.com/repos/karthijrk/gpdb/forks","keys_url":"https://api.github.com/repos/karthijrk/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karthijrk/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karthijrk/gpdb/teams","hooks_url":"https://api.github.com/repos/karthijrk/gpdb/hooks","issue_events_url":"https://api.github.com/repos/karthijrk/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/karthijrk/gpdb/events","assignees_url":"https://api.github.com/repos/karthijrk/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/karthijrk/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/karthijrk/gpdb/tags","blobs_url":"https://api.github.com/repos/karthijrk/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karthijrk/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karthijrk/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/karthijrk/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karthijrk/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/karthijrk/gpdb/languages","stargazers_url":"https://api.github.com/repos/karthijrk/gpdb/stargazers","contributors_url":"https://api.github.com/repos/karthijrk/gpdb/contributors","subscribers_url":"https://api.github.com/repos/karthijrk/gpdb/subscribers","subscription_url":"https://api.github.com/repos/karthijrk/gpdb/subscription","commits_url":"https://api.github.com/repos/karthijrk/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/karthijrk/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/karthijrk/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/karthijrk/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/karthijrk/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/karthijrk/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karthijrk/gpdb/merges","archive_url":"https://api.github.com/repos/karthijrk/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karthijrk/gpdb/downloads","issues_url":"https://api.github.com/repos/karthijrk/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/karthijrk/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/karthijrk/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/karthijrk/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karthijrk/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/karthijrk/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/karthijrk/gpdb/deployments","created_at":"2015-11-16T22:58:20Z","updated_at":"2016-04-13T06:48:19Z","pushed_at":"2016-05-19T00:14:14Z","git_url":"git://github.com/karthijrk/gpdb.git","ssh_url":"git@github.com:karthijrk/gpdb.git","clone_url":"https://github.com/karthijrk/gpdb.git","svn_url":"https://github.com/karthijrk/gpdb","homepage":"http://greenplum.org","size":141420,"stargazers_count":1,"watchers_count":1,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"6cd2d2d2c6631fbdce52bf1ef5e9808c355720a4","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-05-19T09:26:22Z","pushed_at":"2016-05-19T17:41:00Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":153957,"stargazers_count":1439,"watchers_count":1439,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":382,"mirror_url":null,"open_issues_count":91,"forks":382,"open_issues":91,"watchers":1439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/764"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/764"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/d140610d01db89184bf8371929435fcea2f80fc6"}}}}