{"action":"created","issue":{"url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/178","repository_url":"https://api.github.com/repos/Preston-Crary/liferay-portal","labels_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/178/labels{/name}","comments_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/178/comments","events_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/178/events","html_url":"https://github.com/Preston-Crary/liferay-portal/pull/178","id":179261669,"number":178,"title":"LPS-66950 build-lang","user":{"login":"pavel-savinov","id":12697489,"avatar_url":"https://avatars.githubusercontent.com/u/12697489?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-savinov","html_url":"https://github.com/pavel-savinov","followers_url":"https://api.github.com/users/pavel-savinov/followers","following_url":"https://api.github.com/users/pavel-savinov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-savinov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-savinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-savinov/subscriptions","organizations_url":"https://api.github.com/users/pavel-savinov/orgs","repos_url":"https://api.github.com/users/pavel-savinov/repos","events_url":"https://api.github.com/users/pavel-savinov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-savinov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-26T15:31:47Z","updated_at":"2016-09-26T16:59:00Z","closed_at":"2016-09-26T16:59:00Z","pull_request":{"url":"https://api.github.com/repos/Preston-Crary/liferay-portal/pulls/178","html_url":"https://github.com/Preston-Crary/liferay-portal/pull/178","diff_url":"https://github.com/Preston-Crary/liferay-portal/pull/178.diff","patch_url":"https://github.com/Preston-Crary/liferay-portal/pull/178.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/comments/249630220","html_url":"https://github.com/Preston-Crary/liferay-portal/pull/178#issuecomment-249630220","issue_url":"https://api.github.com/repos/Preston-Crary/liferay-portal/issues/178","id":249630220,"user":{"login":"Preston-Crary","id":1714297,"avatar_url":"https://avatars.githubusercontent.com/u/1714297?v=3","gravatar_id":"","url":"https://api.github.com/users/Preston-Crary","html_url":"https://github.com/Preston-Crary","followers_url":"https://api.github.com/users/Preston-Crary/followers","following_url":"https://api.github.com/users/Preston-Crary/following{/other_user}","gists_url":"https://api.github.com/users/Preston-Crary/gists{/gist_id}","starred_url":"https://api.github.com/users/Preston-Crary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preston-Crary/subscriptions","organizations_url":"https://api.github.com/users/Preston-Crary/orgs","repos_url":"https://api.github.com/users/Preston-Crary/repos","events_url":"https://api.github.com/users/Preston-Crary/events{/privacy}","received_events_url":"https://api.github.com/users/Preston-Crary/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T16:59:00Z","updated_at":"2016-09-26T16:59:00Z","body":"Hi Pavel,\r\n\r\nit seems strange to be reading in the XML when we already know what is in the database for these.  I want to avoid having issues with custom resource actions.  Let's read the ones in the database instead of the XML.\r\n\r\nBefore in portal-impl/src/resource-actions/asset.xml there are 3 resource actions (ADD_TAG, ADD_CATEGORY and ADD_VOCABULARY) and afterwards there are still 3 but they've been divided between the Tags and Categories. I still don't understand why we can't update these in this case?\r\n\r\nI mentioned this in the previous pull, we should avoid filtering after we do the query.  The filtering logic [here](https://github.com/Preston-Crary/liferay-portal/pull/178/files#diff-62c6a954d5aa411076c9e956ca699048R216) and [here](https://github.com/Preston-Crary/liferay-portal/pull/178/files#diff-62c6a954d5aa411076c9e956ca699048R235) should be in the query (ideally in two separate queries).\r\n\r\nThere's still some more PreparedStatements that are not being closed [like this one](https://github.com/Preston-Crary/liferay-portal/pull/178/files#diff-62c6a954d5aa411076c9e956ca699048R209).\r\n\r\nWe should also be using the AutoBatchPreparedStatementUtil, so that we can reduce the overhead of the network traffic to the database.\r\n\r\nPlease resend with these changes and thanks for working on this and adding the test."}}
{"actor":{"display_login":"Preston-Crary"}}