{"push_id":1221142161,"size":99,"distinct_size":99,"ref":"refs/heads/master","head":"0b322be4714cdc0701749e568fea4bf42c2c18a0","before":"12351f2b35f0fecf6d7d30a5776f81e8a5e38404","commits":[{"sha":"9c8370d0c65f0b41d4599ec983b565ee80641313","author":{"name":"Richard Mapes","email":"9e27a7e070959f19cf2da1c99e2f64220eccc6b6@fb.com"},"message":"Clean up nested main methods for readability\n\nSummary:\nI'm doing a few quick refactorings to make the code more readable.\nThis one collapses two top level wrapper methods for the main method into one\n\nTest Plan:\nant clean test is successful\nbuck dummy_command returns error message about no dummy_command subcommand existing\nbuck targest //... works correctly\n\nReviewed By: ruibm\n\nfbshipit-source-id: 9081698","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/9c8370d0c65f0b41d4599ec983b565ee80641313"},{"sha":"544349e5a9cbe09683b5d3e71930b1dcbb9369fc","author":{"name":"Jakub Zika","email":"baff7152439df344bfd58532c85ff94583f29f02@fb.com"},"message":"Let ShellStep throw IOException\n\nSummary:\nWhen `ShellStep` fails because it cannot execute the file specified\nin the command, it exits with an unhelpful error message stating\nthat the command exited with code 1. This change instead makes\n`ShellStep` propagate the exception outside of the step so the\nerror message can be reported to the user. This also makes it\neasier for its subclasses to handle `IOException`s.\n\nTest Plan: `buck test`\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 82fb5a2","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/544349e5a9cbe09683b5d3e71930b1dcbb9369fc"},{"sha":"204353b16975dd566dc29ad0301adafacb21b5e1","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Move ActionGraphEvent under events\n\nSummary: If it ends with \"Event\" it should be under events.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: d3137b4","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/204353b16975dd566dc29ad0301adafacb21b5e1"},{"sha":"9b5a31448b60c0b077386652209a5e22857a197b","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"ScribeLogger with offline mode and loggers for testing\n\nSummary: Adding ScribeLoggerWithOffline that will allow for offline logging - right now it fallbacks to storing when logging fails, but does not actually perform writing. Also test loggers for helping with testing the behavious of scribe logging.\n\nTest Plan: ant clean test -Dtest.class=OfflineScribeLoggerTest\n\nReviewed By: ruibm\n\nfbshipit-source-id: c5b2e5c","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/9b5a31448b60c0b077386652209a5e22857a197b"},{"sha":"e85202dd8e230879207f4118a3a01f4f2aacf05a","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Reduce the number of `new ProjectFilesystem()` calls in Main.java by 1.\n\nSummary:\nNote that there are still 4 instances of this in `Main.java` alone:\n\n* There is one instantiation for the immediate project root (expected).\n* There is a loop where we create one for each cell (expected).\n* There appears to be one for each (cell, daemon) pair, as well, though I'm not sure whether the one for the cell itself can be reused here.\n* I think the last call site is redundant, so I added a comment to that effect.\n\nThis also deletes rather than updates `limit_new_project_filesystem_test.sh` because it was\nno longer enforcing the thing that it was originally intended to enforce.\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 38e40dd","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/e85202dd8e230879207f4118a3a01f4f2aacf05a"},{"sha":"32fb6882e5b7d1672cbb30aa25089b3aac574556","author":{"name":"Michael Bolin","email":"0a4e03210b267ad0dd892ddbf5339329bbbd9f0b@fb.com"},"message":"Introducing ProjectFilesystemDelegate\n\nSummary:\nThis introduces a new parameter to `ProjectFilesystem`: `ProjectFilesystemDelegate`.\nThe purpose of the delegate is explained in the interface overview:\n\n> Delegate that a {link ProjectFilesystem} can use to leverage a specialized implementation of\n> certain filesystem operations, tailored to the underlying filesystem. Use of the delegate is\n> often motivated by performance reasons.\n\nThis revision does not introduce any actual use of delegation yet, but it sets\nthings up so we can create an `EdenProjectFilesystemDelegate` in a follow-up revision.\n\nIn general, the right way to create a `ProjectFilesystemDelegate` is via\n`ProjectFilesystemDelegateFactory#newInstance(Path)`. Indeed, this revision\nmakes this the default behavior when creating a `ProjectFilesystem`.\n(There are too many call sites to `new ProjectFilesystem` to make it worth it\nto require `ProjectFilesystemDelegate` to be specified explicitly in all cases,\nparticularly when there is a sensible default in the overwhelming majority of cases.)\n\nThat said, it is possible to pass a specific `ProjectFilesystemDelegate` from above.\n`FakeProjectFilesystem` takes advantage of this to ensure that a\n`DefaultProjectFilesystemDelegate` is always used for testing.\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: cd4659a","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/32fb6882e5b7d1672cbb30aa25089b3aac574556"},{"sha":"19826b582bf94403dd9b5db2c25c157b1e5fdc14","author":{"name":"Hoa Dinh","email":"35a754ed0112b1ff2ba1107384782b98b8c08fd8@fb.com"},"message":"Added .buckconfig:project. xcode_project_tests_mode to configure how tests are generated in the xcode project\n\nSummary:\nPossible values \"without_tests\", \"with_test\" or \"without_dependencies_tests\".\nUsing --without-tests, --with-tests or --without-dependencies-tests with buck project will override that default value.\n\nTest Plan:\nAdded:\n- ProjectIntegrationTest.testBuckProjectBuckConfigWithoutTestsGenerate()\n- ProjectIntegrationTest.testBuckProjectBuckConfigWithoutTestsGenerateWithTests()\n\n```\ndvh-mbp:~/BuckRepo/buck$ ./bin/buck test //test/com/facebook/buck/apple/xcode:xcode\nShutting down nailgun server...\nUsing watchman.\n[-] PROCESSING BUCK FILES...FINISHED 2.8s [100%]\n[-] DOWNLOADING... (0.00 B/S AVG, TOTAL: 0.00 B, 0 Artifacts)\n[-] BUILDING...FINISHED 63.0s [100%] (513/513 JOBS, 513 UPDATED, 513 [100.0%] CACHE MISS)\n[-] TESTING...FINISHED 19.6s (26 PASS/0 FAIL)\nRESULTS FOR //test/com/facebook/buck/apple/xcode:xcode\nPASS    <100ms  2 Passed   0 Skipped   0 Failed   com.facebook.buck.apple.xcode.GidGeneratorTest\nPASS     19.0s 20 Passed   0 Skipped   0 Failed   com.facebook.buck.apple.xcode.ProjectIntegrationTest\nPASS    <100ms  1 Passed   0 Skipped   0 Failed   com.facebook.buck.apple.xcode.XcodeprojSerializerTest\nPASS    <100ms  2 Passed   0 Skipped   0 Failed   com.facebook.buck.apple.xcode.xcodeproj.FileTypesTest\nPASS    <100ms  1 Passed   0 Skipped   0 Failed   com.facebook.buck.apple.xcode.xcodeproj.SourceTreePathTest\nTESTS PASSED\n```\n\nReviewed By: Coneko\n\nfbshipit-source-id: b24d87b","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/19826b582bf94403dd9b5db2c25c157b1e5fdc14"},{"sha":"ab9fb0d932971ddaa1936401d4ba3b67279627fd","author":{"name":"Keeley D. Erhardt","email":"b55878025e1039f0e1d9159da25aa1b37643b9a3@fb.com"},"message":"Implement circular buffer to store high granularity LogRecords directly preceding a build failure\n\nSummary: Implemented a MemoryHandler to store high granularity error logs only necessary in case of a failed build.\n\nReviewed By: Coneko\n\nfbshipit-source-id: 83ce02c","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/ab9fb0d932971ddaa1936401d4ba3b67279627fd"},{"sha":"f48f07efbe3ac68a0d70f1a8dc6f36c2a8b43e2c","author":{"name":"Michal Lowicki","email":"99c4bc4e11de5b5d1714066d4b2c27e0dfc0e0e4@fb.com"},"message":"Add warnings when importing modules if sandboxing is enabled\n\nSummary:\nOverride the __import__ function and show warnings when importing modules if sandboxing is enabled.\n\n  [project]\n      enable_build_file_sandboxing = true\n\nin `.buckconfig` enables sandboxing (default value is false).\n\nTest Plan:\nConfirm that importing modules in BUCK files results in warnings if sandboxing enabled, no warnings when explicitly disabled / not specified, and other builtin functions work correctly, i.e. add to BUCK file\n\n  import math\n  import os\n  import time\n  print math.pi, len([0,1,2]), eval('2+2')\n\nImports in `buck.py` etc shouldn't produce warnings.\n\nReviewed By: k21\n\nfbshipit-source-id: 13b9570","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/f48f07efbe3ac68a0d70f1a8dc6f36c2a8b43e2c"},{"sha":"7da5238272e4870b52fc53343eb01340fb2dbd44","author":{"name":"Martin Kosiba","email":"6bd994d075fcd7642f04677ba9960527dece6461@fb.com"},"message":"Don't use the rootCell in TargetGraphHashing.\n\nSummary:\nResolving all Cells against the root cell is not correct as not all\ncells are visible to the root. Since all TargetNodes already know their\nProjectFilesystem use that instead.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: d185e1b","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/7da5238272e4870b52fc53343eb01340fb2dbd44"},{"sha":"e1a552e4e07100accb71ff9bc4b75f50b0bf2ea5","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Remove project filesystem from DefaultAndroidDirectoryResolver.\n\nSummary: This isn't used for anything.\n\nTest Plan: CI\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: ac08b51","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/e1a552e4e07100accb71ff9bc4b75f50b0bf2ea5"},{"sha":"7c79dd4039a44b0c81f2f6309a0bee9bb15db209","author":{"name":"Martin Kosiba","email":"6bd994d075fcd7642f04677ba9960527dece6461@fb.com"},"message":"Make cell config override resolution work for transitive cells.\n\nSummary:\nThis makes cell config overrides works if they're specified for\ntransitive cells.\n\nTest Plan: CI\n\nReviewed By: mzlee\n\nfbshipit-source-id: 4f32b63","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/7c79dd4039a44b0c81f2f6309a0bee9bb15db209"},{"sha":"ee94e93836c6cc366c219feb8bcf20a6f19e4bc2","author":{"name":"Kellie Medlin","email":"8ef0cbf86318d8526251bdcfea047e18146a9d99@fb.com"},"message":"Unify the default host platform with overrides in .buckconfig\n\nSummary:\nSome build targets, such as Facebook's targets when building on Linux,\nneed to override the default toolchain generated for building Linux\ntargets. This patch introduces this functionality; CXX platforms\ncan be overridden by defining [cxx#macosx-x86_64] or [cxx#linux-x86_64]\nin .buckconfig.\n\nFurthermore, this makes support for 'host_platform' unnecessary.\nFacebook uses this value to force MacOSX builds to use Mac SDKs,\nwhich is now currently the default.\n\nTest Plan:\nGet a little farther when building a Halide target on Linux\nwith clang.\n\nReviewed By: Coneko\n\nfbshipit-source-id: b4fc01d","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/ee94e93836c6cc366c219feb8bcf20a6f19e4bc2"},{"sha":"a70e0175476c94635a8692a23f3c507d2ae0406d","author":{"name":"Mike Athanasakis","email":"10373f86d38e66303a4183dc20589cdbcc9cd632@fb.com"},"message":"Changes to ActionGraphCache check mechanism\n\nSummary:\nMade the call synchronous to the main thread.\nPossible mismatch causes a Runtime exception.\nUpdated the documentation.\nMade the value be true/false.\n\nNote: Immutable SampleRate is not currently needed but I decided not to delete it since it could\nbe useful in a future. If we decide to remove it I can do it at another diff.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 633949f","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/a70e0175476c94635a8692a23f3c507d2ae0406d"},{"sha":"9acfa38dafff1160b314e7b5a1edb50ef26f8fae","author":{"name":"Michal Sienkiewicz","email":"d6d7f7418f73c48aaf946b2533a3a2c0b3abda83@fb.com"},"message":"Allow for storing for offline Scribe logging when flag used\n\nSummary: Use the new OfflineScribeLogger to fallback to storing when logging fails. Behaviour dependent of flag set/not set (false by default, but enabled it for Buck repo) and categories chosen for offline logging.\n\nTest Plan: buck test\n\nReviewed By: ruibm\n\nfbshipit-source-id: da797ca","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/9acfa38dafff1160b314e7b5a1edb50ef26f8fae"},{"sha":"f00def95557ad0e489fbb94fab8e84655710254b","author":{"name":"Mick Killianey","email":"4c696aca7c9e1d3e11752ee303a7fac0d53a2661@fb.com"},"message":"Stop using an upper-bound on the buck-plugin.\n\nSummary:\nBy putting an upper-bound on the plugin, we're preventing EAP users\nfrom giving us helpful bug reports.  Let's allow users on bleeding-edge\nversions of IntelliJ to help us beta-test the plugin and discover problems\nbefore stable releases.\n\nTest Plan: Build plugin, make sure it can be installed in IntelliJ 2016.2.\n\nReviewed By: cosmin1123\n\nfbshipit-source-id: cce3eba","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/f00def95557ad0e489fbb94fab8e84655710254b"},{"sha":"732df36cc36c66e6287a91d76045cf11ac84f6b6","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"Use ST template for generating python buck rule defs\n\nSummary: I'm of the opinion that when you have a good tool, use it.\n\nTest Plan: existing tests pass.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 6256c37","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/732df36cc36c66e6287a91d76045cf11ac84f6b6"},{"sha":"b03f1056a36fc43958d11022a5ba89dac0d2d885","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Don't refer to abstract type of immutable.\n\nTest Plan: CI\n\nReviewed By: ruibm\n\nfbshipit-source-id: bb9c09f","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/b03f1056a36fc43958d11022a5ba89dac0d2d885"},{"sha":"1ffd1b7f423352888a4128804e2ced74f49bfa86","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Simplify parameters of setupLoggers.\n\nSummary:\nThese are always passed in as present optionals, so they don't need\nto be optionals in the first place.\n\nTest Plan: CI\n\nReviewed By: ruibm\n\nfbshipit-source-id: e55bdfa","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/1ffd1b7f423352888a4128804e2ced74f49bfa86"},{"sha":"995e69f660a49415c429af9d9cad26144a67b3c9","author":{"name":"Ognjen Dragoljevic","email":"e9734b0c0077fc279b03277caf5e73109dc92e0d@fb.com"},"message":"Improve ZipOutputStreamTest\n\nSummary:\nSome unit tests that test STORE mode were not setting the entry size. This would produce incorrect output, but was not caught because it was not tested for. Note that this was just a slight incompleteness on the unit test side, the code itself is fine (or we hope so).\nAnother issue with unit tests was that not all of the tests were applied to all of the HandleDuplicate modes. And in cases where they were, the code would be copy-pasted with only a single constant being different.\nThis diff fixes both of the issues.\n\nTest Plan: buck test\n\nReviewed By: Coneko\n\nfbshipit-source-id: 0a699a9","distinct":true,"url":"https://api.github.com/repos/OkBuilds/buck/commits/995e69f660a49415c429af9d9cad26144a67b3c9"}]}
{"actor":{"display_login":"kageiit"}}