{"action":"closed","number":1313,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313","id":93392522,"html_url":"https://github.com/greenplum-db/gpdb/pull/1313","diff_url":"https://github.com/greenplum-db/gpdb/pull/1313.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1313.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1313","number":1313,"state":"closed","locked":false,"title":"Faultinjector to convey num times fault hit, fix pgtwophase tests using same","user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"body":"This PR contains bunch of commits to fix fault injector and current pg_twophase tests. \r\n\r\n- DtmXLogDistributedCommit fault to only hit for DTX\r\n- Currently, fault injector framework doesn't convey how many times a given fault\r\nhas been hit. This is useful information to help optimize many tests which are\r\ncurrently relying on sleep and select * from pg_stat_activity to figure out if\r\nits time to trigger next step or not. Tests which need the fault to be triggered\r\nfor n number of commands and then perform some other activity, will now be able\r\nto get this information in gpfaultinjector status message.\r\n- Just fixing rough edges in current tests for now, no doubt whole mechanism needs\r\nto be altered to how testing is done for this part. Using newly added mechanism\r\nto check number of times fault triggered to remove sleeps and indeterministic\r\nbehavior of the tests. Also, fix the tests to correctly calculate number of\r\nfaults being trigered. Also, correctly run post sqls for\r\ndtm_broadcast_commit_prepared and dtm_xlog_distributed_commit faults as\r\ntransactions would be committed for these situations.","created_at":"2016-11-11T20:25:32Z","updated_at":"2016-12-01T22:47:38Z","closed_at":"2016-12-01T22:47:38Z","merged_at":"2016-12-01T22:47:38Z","merge_commit_sha":"8ebe012e5bdf993af59dab549311acabaf671127","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1313/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8ebe012e5bdf993af59dab549311acabaf671127","head":{"label":"ashwinstar:fault_status","ref":"fault_status","sha":"8ebe012e5bdf993af59dab549311acabaf671127","user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"repo":{"id":45129886,"name":"gpdb","full_name":"ashwinstar/gpdb","owner":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashwinstar/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/ashwinstar/gpdb","forks_url":"https://api.github.com/repos/ashwinstar/gpdb/forks","keys_url":"https://api.github.com/repos/ashwinstar/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashwinstar/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashwinstar/gpdb/teams","hooks_url":"https://api.github.com/repos/ashwinstar/gpdb/hooks","issue_events_url":"https://api.github.com/repos/ashwinstar/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/ashwinstar/gpdb/events","assignees_url":"https://api.github.com/repos/ashwinstar/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/ashwinstar/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/ashwinstar/gpdb/tags","blobs_url":"https://api.github.com/repos/ashwinstar/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashwinstar/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashwinstar/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashwinstar/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashwinstar/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ashwinstar/gpdb/languages","stargazers_url":"https://api.github.com/repos/ashwinstar/gpdb/stargazers","contributors_url":"https://api.github.com/repos/ashwinstar/gpdb/contributors","subscribers_url":"https://api.github.com/repos/ashwinstar/gpdb/subscribers","subscription_url":"https://api.github.com/repos/ashwinstar/gpdb/subscription","commits_url":"https://api.github.com/repos/ashwinstar/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashwinstar/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashwinstar/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashwinstar/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashwinstar/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/ashwinstar/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashwinstar/gpdb/merges","archive_url":"https://api.github.com/repos/ashwinstar/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashwinstar/gpdb/downloads","issues_url":"https://api.github.com/repos/ashwinstar/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/ashwinstar/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ashwinstar/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ashwinstar/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashwinstar/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/ashwinstar/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/ashwinstar/gpdb/deployments","created_at":"2015-10-28T17:27:21Z","updated_at":"2016-02-02T21:35:16Z","pushed_at":"2016-12-01T22:25:27Z","git_url":"git://github.com/ashwinstar/gpdb.git","ssh_url":"git@github.com:ashwinstar/gpdb.git","clone_url":"https://github.com/ashwinstar/gpdb.git","svn_url":"https://github.com/ashwinstar/gpdb","homepage":"http://greenplum.org","size":180508,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"8e7af0ad4215ecc6ff3d60c28f35b9ba2a4b739a","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2016-12-01T13:19:10Z","pushed_at":"2016-12-01T22:47:36Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":233494,"stargazers_count":1689,"watchers_count":1689,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":120,"forks":492,"open_issues":120,"watchers":1689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/1313"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1313"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/1313/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1313/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/8ebe012e5bdf993af59dab549311acabaf671127"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":4,"additions":125,"deletions":122,"changed_files":11}}
{"actor":{"display_login":"ashwinstar"}}