{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/55111767","id":55111767,"diff_hunk":"@@ -10650,7 +10669,13 @@ namespace HVACUnitarySystem {\n \t\t\t} // ELSE ! No Moisture Load\n \t\t} // No Heating/Cooling Load\n \n-\t\tMSHPMassFlowRateLow = CompOffMassFlow; // these need to be set for multi-speed coils\n+\t\tif ( UnitarySystem( UnitarySysNum ).MultiSpeedHeatingCoil && ( HeatingLoad && HeatSpeedNum == 1 ) ) {\n+\t\t\tMSHPMassFlowRateLow = CompOnMassFlow * PartLoadRatio; // proportional to PLR when speed = 1,  #5518\n+\t\t} else if ( UnitarySystem( UnitarySysNum ).MultiSpeedCoolingCoil && ( CoolingLoad && CoolSpeedNum == 1 ) ) {\n+\t\t\tMSHPMassFlowRateLow = CompOnMassFlow * PartLoadRatio; // proportional to PLR when speed = 1,  #5518\n+\t\t} else {\n+\t\t\tMSHPMassFlowRateLow = CompOffMassFlow; // these need to be set for multi-speed coils\n+\t\t}","path":"src/EnergyPlus/HVACUnitarySystem.cc","position":114,"original_position":114,"commit_id":"c9edc1b9838c9d5d0405949a8bda9c31b3aa3f00","original_commit_id":"c9edc1b9838c9d5d0405949a8bda9c31b3aa3f00","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"Added specific coil model logic here. Not sure if Var speed coil has the same performance issue, will address when we see a defect.","created_at":"2016-03-05T01:25:53Z","updated_at":"2016-03-05T01:25:53Z","html_url":"https://github.com/NREL/EnergyPlus/pull/5519#discussion_r55111767","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/55111767"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5519#discussion_r55111767"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519"}}},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519","id":61585608,"html_url":"https://github.com/NREL/EnergyPlus/pull/5519","diff_url":"https://github.com/NREL/EnergyPlus/pull/5519.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5519.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5519","number":5519,"state":"open","locked":false,"title":"Corrects air flow defect in AirloopHVAC:UnitarySystem when MS coils operate at Speed = 1","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"body":"Pull request overview\r\n---------------------\r\nThere are 2 changes associated with this issue.\r\n\r\nThe first is that the DX MS cooling coil has a discontinuity between 1st and 2nd stage. This is due to the calculation of capacity using hfg for speed 2.\r\n\r\nThe second change is in regards to the internal variable MSHPMassFlowRateLow is currently set to 0 at Speed = 1. This variable should instead be set proportional to PLR. This apparently only affects the TotCapFlowModFac calculation and causes a discontinuity between capacity at Speed=1 and Speed=2. Minor changes will be made to correct how this internal variable is set. Diff's are expected only in UnitarySystem files which use MS coils, and in MSHP files using the DX MS cooing coil.\r\n\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [x] Code style (parentheses padding, variable names)\r\n - [x] Functional code review (it has to work!)\r\n - [x] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [x] CI status: all green or justified\r\n - [x] Performance: CI Linux results include performance check -- verify this\r\n - [x] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] ExpandObjects changes??\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n\r\n","created_at":"2016-03-03T16:29:32Z","updated_at":"2016-03-05T01:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0dd3fa2c18f62a4364ad79a888aece0c426b190","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5519/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/c9edc1b9838c9d5d0405949a8bda9c31b3aa3f00","head":{"label":"NREL:#5518-Multispeed-Coils-used-with-AirloopHVACUnitarySystem-do-not-control-air-flow-properly-at-Speed-=-1","ref":"#5518-Multispeed-Coils-used-with-AirloopHVACUnitarySystem-do-not-control-air-flow-properly-at-Speed-=-1","sha":"c9edc1b9838c9d5d0405949a8bda9c31b3aa3f00","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-02-24T18:18:21Z","pushed_at":"2016-03-04T23:42:26Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":236481,"stargazers_count":93,"watchers_count":93,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":414,"forks":62,"open_issues":414,"watchers":93,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"21ae200105e3831fab28c726b10e3de8c58e777e","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars.githubusercontent.com/u/1906800?v=3","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2016-02-24T18:18:21Z","pushed_at":"2016-03-04T23:42:26Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":236481,"stargazers_count":93,"watchers_count":93,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":414,"forks":62,"open_issues":414,"watchers":93,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/5519"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5519"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/5519/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5519/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/c9edc1b9838c9d5d0405949a8bda9c31b3aa3f00"}}}}