{"action":"closed","number":275,"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275","id":61734562,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/275","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/275.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/275.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/275","number":275,"state":"closed","locked":false,"title":"SR-794 pass supplied subpath through to URLForResource rather than nil","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"body":"[SR-794](https://bugs.swift.org/browse/SR-794) reports an issue with `NSBundle.pathForResource()` whereby it returns `nil` instead of the expected resource.\r\n\r\nIt looks like this is cause because the supplied `subpath` value isn't passed down to the underlying `URLForResource()` call.\r\n\r\nI've fixed that and added an implementation of the test case to TestNSBundle. I've done that under the existing `test_URLsForResourcesWithExtension()` test as a separate call and check as its a similar test and reuses the same bundle setup/teardown. I can spin it off as a separate test though if it makes sense.","created_at":"2016-03-04T16:22:48Z","updated_at":"2016-03-07T15:20:21Z","closed_at":"2016-03-07T15:20:21Z","merged_at":"2016-03-07T15:20:21Z","merge_commit_sha":"7b3fb8b45e1f881d890a5c36e79dd1acc09f40fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/275/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/55e95236e2b351d1c6942f6136e2a52d51a8df91","head":{"label":"seabaylea:nsbundle","ref":"nsbundle","sha":"55e95236e2b351d1c6942f6136e2a52d51a8df91","user":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"repo":{"id":51076787,"name":"swift-corelibs-foundation","full_name":"seabaylea/swift-corelibs-foundation","owner":{"login":"seabaylea","id":11974522,"avatar_url":"https://avatars.githubusercontent.com/u/11974522?v=3","gravatar_id":"","url":"https://api.github.com/users/seabaylea","html_url":"https://github.com/seabaylea","followers_url":"https://api.github.com/users/seabaylea/followers","following_url":"https://api.github.com/users/seabaylea/following{/other_user}","gists_url":"https://api.github.com/users/seabaylea/gists{/gist_id}","starred_url":"https://api.github.com/users/seabaylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seabaylea/subscriptions","organizations_url":"https://api.github.com/users/seabaylea/orgs","repos_url":"https://api.github.com/users/seabaylea/repos","events_url":"https://api.github.com/users/seabaylea/events{/privacy}","received_events_url":"https://api.github.com/users/seabaylea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seabaylea/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/seabaylea/swift-corelibs-foundation/deployments","created_at":"2016-02-04T13:12:13Z","updated_at":"2016-02-04T13:12:17Z","pushed_at":"2016-03-04T16:17:05Z","git_url":"git://github.com/seabaylea/swift-corelibs-foundation.git","ssh_url":"git@github.com:seabaylea/swift-corelibs-foundation.git","clone_url":"https://github.com/seabaylea/swift-corelibs-foundation.git","svn_url":"https://github.com/seabaylea/swift-corelibs-foundation","homepage":"swift.org","size":3989,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"47fa18af33fff2e3ef9b14122831f81e8290597b","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/deployments","created_at":"2015-11-09T20:12:23Z","updated_at":"2016-03-07T06:09:15Z","pushed_at":"2016-03-07T15:20:21Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":4688,"stargazers_count":1667,"watchers_count":1667,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":16,"forks":314,"open_issues":16,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/275"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/275"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/275/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/275/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/55e95236e2b351d1c6942f6136e2a52d51a8df91"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"phausler","id":278470,"avatar_url":"https://avatars.githubusercontent.com/u/278470?v=3","gravatar_id":"","url":"https://api.github.com/users/phausler","html_url":"https://github.com/phausler","followers_url":"https://api.github.com/users/phausler/followers","following_url":"https://api.github.com/users/phausler/following{/other_user}","gists_url":"https://api.github.com/users/phausler/gists{/gist_id}","starred_url":"https://api.github.com/users/phausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phausler/subscriptions","organizations_url":"https://api.github.com/users/phausler/orgs","repos_url":"https://api.github.com/users/phausler/repos","events_url":"https://api.github.com/users/phausler/events{/privacy}","received_events_url":"https://api.github.com/users/phausler/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":2}}