{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/comments/85122482","pull_request_review_id":5855522,"id":85122482,"diff_hunk":"@@ -30,8 +30,8 @@\n \n \t\t\t\t</div>\n \t\t\t</div>\n-\t\t\t<button class=\"o-header__subnav-button o-header__subnav-button--left\" aria-hidden=\"true\" disabled></button>\n-\t\t\t<button class=\"o-header__subnav-button o-header__subnav-button--right\" aria-hidden=\"true\" disabled></button>\n+\t\t\t<button title=\"subnav-spacing-btn-left\" class=\"o-header__subnav-button o-header__subnav-button--left\" aria-hidden=\"true\" disabled></button>","path":"header/partials/subnav/template-new.html","position":6,"original_position":6,"commit_id":"84abe349fb216f4b6912b363d276579c5ec70a90","original_commit_id":"84abe349fb216f4b6912b363d276579c5ec70a90","user":{"login":"debugwand","id":996106,"avatar_url":"https://avatars.githubusercontent.com/u/996106?v=3","gravatar_id":"","url":"https://api.github.com/users/debugwand","html_url":"https://github.com/debugwand","followers_url":"https://api.github.com/users/debugwand/followers","following_url":"https://api.github.com/users/debugwand/following{/other_user}","gists_url":"https://api.github.com/users/debugwand/gists{/gist_id}","starred_url":"https://api.github.com/users/debugwand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debugwand/subscriptions","organizations_url":"https://api.github.com/users/debugwand/orgs","repos_url":"https://api.github.com/users/debugwand/repos","events_url":"https://api.github.com/users/debugwand/events{/privacy}","received_events_url":"https://api.github.com/users/debugwand/received_events","type":"User","site_admin":false},"body":"titles 99% of the time are problematic for screenreaders, let me dig up the docs to confirm","created_at":"2016-10-26T13:33:54Z","updated_at":"2016-10-26T13:50:09Z","html_url":"https://github.com/Financial-Times/n-ui/pull/581#discussion_r85122482","pull_request_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/comments/85122482"},"html":{"href":"https://github.com/Financial-Times/n-ui/pull/581#discussion_r85122482"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581","id":91001582,"html_url":"https://github.com/Financial-Times/n-ui/pull/581","diff_url":"https://github.com/Financial-Times/n-ui/pull/581.diff","patch_url":"https://github.com/Financial-Times/n-ui/pull/581.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/581","number":581,"state":"open","locked":false,"title":"subnav title attribute added for a11y","user":{"login":"pixelandpage","id":17549437,"avatar_url":"https://avatars.githubusercontent.com/u/17549437?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelandpage","html_url":"https://github.com/pixelandpage","followers_url":"https://api.github.com/users/pixelandpage/followers","following_url":"https://api.github.com/users/pixelandpage/following{/other_user}","gists_url":"https://api.github.com/users/pixelandpage/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelandpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelandpage/subscriptions","organizations_url":"https://api.github.com/users/pixelandpage/orgs","repos_url":"https://api.github.com/users/pixelandpage/repos","events_url":"https://api.github.com/users/pixelandpage/events{/privacy}","received_events_url":"https://api.github.com/users/pixelandpage/received_events","type":"User","site_admin":false},"body":"To pass our pa11y test suite, button elements must have a title attribute. ","created_at":"2016-10-26T13:15:10Z","updated_at":"2016-10-26T13:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2557c4dea88293bd3814ce516ad126c5d9f0d8cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/581/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-ui/statuses/84abe349fb216f4b6912b363d276579c5ec70a90","head":{"label":"Financial-Times:myft-a11y-optimisation","ref":"myft-a11y-optimisation","sha":"84abe349fb216f4b6912b363d276579c5ec70a90","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":56768327,"name":"n-ui","full_name":"Financial-Times/n-ui","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-ui","description":"Next's shared client-side code","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-ui","forks_url":"https://api.github.com/repos/Financial-Times/n-ui/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-ui/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-ui/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-ui/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-ui/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-ui/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-ui/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-ui/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-ui/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-ui/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-ui/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-ui/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-ui/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-ui/deployments","created_at":"2016-04-21T11:30:29Z","updated_at":"2016-10-24T12:56:51Z","pushed_at":"2016-10-26T13:15:10Z","git_url":"git://github.com/Financial-Times/n-ui.git","ssh_url":"git@github.com:Financial-Times/n-ui.git","clone_url":"https://github.com/Financial-Times/n-ui.git","svn_url":"https://github.com/Financial-Times/n-ui","homepage":"https://github.com/Financial-Times/n-ui/wiki","size":2164,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":22,"forks":0,"open_issues":22,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"31de455e8bae1682f022f29d06143b31ec10b3ad","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":56768327,"name":"n-ui","full_name":"Financial-Times/n-ui","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-ui","description":"Next's shared client-side code","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-ui","forks_url":"https://api.github.com/repos/Financial-Times/n-ui/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-ui/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-ui/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-ui/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-ui/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-ui/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-ui/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-ui/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-ui/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-ui/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-ui/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-ui/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-ui/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-ui/deployments","created_at":"2016-04-21T11:30:29Z","updated_at":"2016-10-24T12:56:51Z","pushed_at":"2016-10-26T13:15:10Z","git_url":"git://github.com/Financial-Times/n-ui.git","ssh_url":"git@github.com:Financial-Times/n-ui.git","clone_url":"https://github.com/Financial-Times/n-ui.git","svn_url":"https://github.com/Financial-Times/n-ui","homepage":"https://github.com/Financial-Times/n-ui/wiki","size":2164,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":22,"forks":0,"open_issues":22,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581"},"html":{"href":"https://github.com/Financial-Times/n-ui/pull/581"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-ui/issues/581"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-ui/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-ui/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-ui/statuses/84abe349fb216f4b6912b363d276579c5ec70a90"}}}}
{"actor":{"display_login":"debugwand"}}