{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/73029316","id":73029316,"diff_hunk":"@@ -715,3 +715,168 @@ def transform(self, X):\n         X = self.estimator.transform(X)\n         X = np.reshape(X.T, [-1, n_epochs, n_times]).transpose([1, 0, 2])\n         return X\n+\n+\n+class Filterer(TransformerMixin):\n+    \"\"\"Estimator to filter 3D array(epochs).\n+\n+    Applies a zero-phase low-pass, high-pass, band-pass, or band-stop\n+    filter to the channels.\n+\n+    l_freq and h_freq are the frequencies below which and above which,\n+    respectively, to filter out of the data. Thus the uses are:\n+\n+        - l_freq < h_freq: band-pass filter\n+        - l_freq > h_freq: band-stop filter\n+        - l_freq is not None, h_freq is None: low-pass filter\n+        - l_freq is None, h_freq is not None: high-pass filter\n+\n+    If n_jobs > 1, more memory is required as \"len(picks) * n_times\"\n+    additional time points need to be temporarily stored in memory.\n+\n+    Parameters\n+    ----------\n+    l_freq : float | None\n+        Low cut-off frequency in Hz. If None the data are only low-passed.\n+    h_freq : float | None\n+        High cut-off frequency in Hz. If None the data are only\n+        high-passed.\n+        channels will be filtered.\n+    sfreq : float, Default: 1.0\n+        Sampling frequency in Hz.\n+    filter_length : str (Default: '10s') | int | None\n+        Length of the filter to use. If None or \"len(x) < filter_length\",\n+        the filter length used is len(x). Otherwise, if int, overlap-add\n+        filtering with a filter of the specified length in samples) is\n+        used (faster for long signals). If str, a human-readable time in\n+        units of \"s\" or \"ms\" (e.g., \"10s\" or \"5500ms\") will be converted\n+        to the shortest power-of-two length at least that duration.\n+    l_trans_bandwidth : float | str\n+        Width of the transition band at the low cut-off frequency in Hz.\n+    h_trans_bandwidth : float | str\n+        Width of the transition band at the high cut-off frequency in Hz.\n+    n_jobs : int | str\n+        Number of jobs to run in parallel. Can be 'cuda' if scikits.cuda\n+        is installed properly, CUDA is initialized, and method='fft'.\n+    method : str\n+        'fft' will use overlap-add FIR filtering, 'iir' will use IIR\n+        forward-backward filtering (via filtfilt).\n+    iir_params : dict | None\n+        Dictionary of parameters to use for IIR filtering.\n+        See mne.filter.construct_iir_filter for details. If iir_params\n+        is None and method=\"iir\", 4th order Butterworth will be used.\n+    verbose : bool, str, int, or None\n+        If not None, override default verbose level (see mne.verbose).\n+        Defaults to self.verbose.\n+    \"\"\"\n+    def __init__(self, l_freq=None, h_freq=None, sfreq=1.0,\n+                 filter_length='10s', l_trans_bandwidth=None,\n+                 h_trans_bandwidth=None, n_jobs=1, method='fft',\n+                 iir_params=None, verbose=None):","path":"mne/decoding/transformer.py","position":70,"original_position":70,"commit_id":"0e669ca7a2f8c7105c74793f7c13cad66a4d4632","original_commit_id":"0e669ca7a2f8c7105c74793f7c13cad66a4d4632","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"and `method='fir'`","created_at":"2016-08-01T18:36:14Z","updated_at":"2016-08-01T18:36:14Z","html_url":"https://github.com/mne-tools/mne-python/pull/3472#discussion_r73029316","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/73029316"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3472#discussion_r73029316"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472","id":79416313,"html_url":"https://github.com/mne-tools/mne-python/pull/3472","diff_url":"https://github.com/mne-tools/mne-python/pull/3472.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3472.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3472","number":3472,"state":"open","locked":false,"title":"[WIP]Created class Filterer and deprecated FilterEstimator","user":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"body":"`Filterer` is exactly the same as `FilterEstimator` with minor changes which includes removal of `info` and `picks` parameter. This is done to follow the API as discussed in #3428.\r\n\r\n@kingjr ","created_at":"2016-07-29T20:06:30Z","updated_at":"2016-08-01T18:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d052fc3219e7a00230214ea2370a883fc284f369","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3472/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/0e669ca7a2f8c7105c74793f7c13cad66a4d4632","head":{"label":"kaichogami:filterer","ref":"filterer","sha":"0e669ca7a2f8c7105c74793f7c13cad66a4d4632","user":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"repo":{"id":52144716,"name":"mne-python","full_name":"kaichogami/mne-python","owner":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaichogami/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/kaichogami/mne-python","forks_url":"https://api.github.com/repos/kaichogami/mne-python/forks","keys_url":"https://api.github.com/repos/kaichogami/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaichogami/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaichogami/mne-python/teams","hooks_url":"https://api.github.com/repos/kaichogami/mne-python/hooks","issue_events_url":"https://api.github.com/repos/kaichogami/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/kaichogami/mne-python/events","assignees_url":"https://api.github.com/repos/kaichogami/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/kaichogami/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/kaichogami/mne-python/tags","blobs_url":"https://api.github.com/repos/kaichogami/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaichogami/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaichogami/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaichogami/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaichogami/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/kaichogami/mne-python/languages","stargazers_url":"https://api.github.com/repos/kaichogami/mne-python/stargazers","contributors_url":"https://api.github.com/repos/kaichogami/mne-python/contributors","subscribers_url":"https://api.github.com/repos/kaichogami/mne-python/subscribers","subscription_url":"https://api.github.com/repos/kaichogami/mne-python/subscription","commits_url":"https://api.github.com/repos/kaichogami/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaichogami/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaichogami/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaichogami/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaichogami/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/kaichogami/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaichogami/mne-python/merges","archive_url":"https://api.github.com/repos/kaichogami/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaichogami/mne-python/downloads","issues_url":"https://api.github.com/repos/kaichogami/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/kaichogami/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/kaichogami/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/kaichogami/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaichogami/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/kaichogami/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/kaichogami/mne-python/deployments","created_at":"2016-02-20T08:49:13Z","updated_at":"2016-02-20T08:49:17Z","pushed_at":"2016-08-01T13:36:14Z","git_url":"git://github.com/kaichogami/mne-python.git","ssh_url":"git@github.com:kaichogami/mne-python.git","clone_url":"https://github.com/kaichogami/mne-python.git","svn_url":"https://github.com/kaichogami/mne-python","homepage":"http://martinos.org/mne/","size":88005,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"e71529b88417d634330cb8a5249633fed63a59fc","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-07-31T20:39:25Z","pushed_at":"2016-08-01T17:34:02Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":180248,"stargazers_count":218,"watchers_count":218,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":193,"forks":206,"open_issues":193,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3472"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3472"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3472/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3472/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/0e669ca7a2f8c7105c74793f7c13cad66a4d4632"}}}}
{"actor":{"display_login":"Eric89GXL"}}