{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142","id":92717949,"html_url":"https://github.com/e-mission/e-mission-data-collection/pull/142","diff_url":"https://github.com/e-mission/e-mission-data-collection/pull/142.diff","patch_url":"https://github.com/e-mission/e-mission-data-collection/pull/142.patch","issue_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/142","number":142,"state":"closed","locked":false,"title":"Ensure that we prompt for consent from remote push/visit notification…","user":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"body":"…s as well\r\n\r\nWe don't always load the full app if the app is in the background.\r\nIn practice, leaving the prompt only in the plugin caused it to never trigger,\r\nas reported by users who did have the consent magically deleted.\r\n\r\nPutting the checks in here caused us to have alerts when we\r\nmanually deleted the consent and roamed around.\r\n\r\nTODO: We might want to consider moving the current consent requirements to an\r\nxml/plist file instead of the current config.xml. That ensures that we can read\r\nit in background native code without having to do creative stuff with XML parsers.","created_at":"2016-11-08T05:37:14Z","updated_at":"2016-11-09T05:54:05Z","closed_at":"2016-11-09T05:54:05Z","merged_at":"2016-11-09T05:54:05Z","merge_commit_sha":"4206506b14f05b8040b8d1881f02a523ca4c3f8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142/commits","review_comments_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142/comments","review_comment_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/142/comments","statuses_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/statuses/c85b8ccc94cd13dc1495c56f58772c76c94e50d5","head":{"label":"shankari:fix_init_after_consent","ref":"fix_init_after_consent","sha":"c85b8ccc94cd13dc1495c56f58772c76c94e50d5","user":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"repo":{"id":30003947,"name":"e-mission-data-collection","full_name":"shankari/e-mission-data-collection","owner":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shankari/e-mission-data-collection","description":"Repository for our own data collection","fork":true,"url":"https://api.github.com/repos/shankari/e-mission-data-collection","forks_url":"https://api.github.com/repos/shankari/e-mission-data-collection/forks","keys_url":"https://api.github.com/repos/shankari/e-mission-data-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shankari/e-mission-data-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shankari/e-mission-data-collection/teams","hooks_url":"https://api.github.com/repos/shankari/e-mission-data-collection/hooks","issue_events_url":"https://api.github.com/repos/shankari/e-mission-data-collection/issues/events{/number}","events_url":"https://api.github.com/repos/shankari/e-mission-data-collection/events","assignees_url":"https://api.github.com/repos/shankari/e-mission-data-collection/assignees{/user}","branches_url":"https://api.github.com/repos/shankari/e-mission-data-collection/branches{/branch}","tags_url":"https://api.github.com/repos/shankari/e-mission-data-collection/tags","blobs_url":"https://api.github.com/repos/shankari/e-mission-data-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shankari/e-mission-data-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shankari/e-mission-data-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/shankari/e-mission-data-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shankari/e-mission-data-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/shankari/e-mission-data-collection/languages","stargazers_url":"https://api.github.com/repos/shankari/e-mission-data-collection/stargazers","contributors_url":"https://api.github.com/repos/shankari/e-mission-data-collection/contributors","subscribers_url":"https://api.github.com/repos/shankari/e-mission-data-collection/subscribers","subscription_url":"https://api.github.com/repos/shankari/e-mission-data-collection/subscription","commits_url":"https://api.github.com/repos/shankari/e-mission-data-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/shankari/e-mission-data-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/shankari/e-mission-data-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/shankari/e-mission-data-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/shankari/e-mission-data-collection/contents/{+path}","compare_url":"https://api.github.com/repos/shankari/e-mission-data-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shankari/e-mission-data-collection/merges","archive_url":"https://api.github.com/repos/shankari/e-mission-data-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shankari/e-mission-data-collection/downloads","issues_url":"https://api.github.com/repos/shankari/e-mission-data-collection/issues{/number}","pulls_url":"https://api.github.com/repos/shankari/e-mission-data-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/shankari/e-mission-data-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/shankari/e-mission-data-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shankari/e-mission-data-collection/labels{/name}","releases_url":"https://api.github.com/repos/shankari/e-mission-data-collection/releases{/id}","deployments_url":"https://api.github.com/repos/shankari/e-mission-data-collection/deployments","created_at":"2015-01-29T04:40:52Z","updated_at":"2016-01-23T05:50:15Z","pushed_at":"2016-11-08T05:36:14Z","git_url":"git://github.com/shankari/e-mission-data-collection.git","ssh_url":"git@github.com:shankari/e-mission-data-collection.git","clone_url":"https://github.com/shankari/e-mission-data-collection.git","svn_url":"https://github.com/shankari/e-mission-data-collection","homepage":null,"size":14642,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"e-mission:master","ref":"master","sha":"de53165f383943e5e7c0960146ad21f71baa6f7c","user":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"repo":{"id":30003805,"name":"e-mission-data-collection","full_name":"e-mission/e-mission-data-collection","owner":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/e-mission/e-mission-data-collection","description":"Repository for our own data collection","fork":false,"url":"https://api.github.com/repos/e-mission/e-mission-data-collection","forks_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/forks","keys_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/teams","hooks_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/hooks","issue_events_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/events{/number}","events_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/events","assignees_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/assignees{/user}","branches_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/branches{/branch}","tags_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/tags","blobs_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/languages","stargazers_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/stargazers","contributors_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/contributors","subscribers_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/subscribers","subscription_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/subscription","commits_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/contents/{+path}","compare_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/merges","archive_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/downloads","issues_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues{/number}","pulls_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/labels{/name}","releases_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/releases{/id}","deployments_url":"https://api.github.com/repos/e-mission/e-mission-data-collection/deployments","created_at":"2015-01-29T04:35:25Z","updated_at":"2016-10-27T23:01:21Z","pushed_at":"2016-11-09T05:54:05Z","git_url":"git://github.com/e-mission/e-mission-data-collection.git","ssh_url":"git@github.com:e-mission/e-mission-data-collection.git","clone_url":"https://github.com/e-mission/e-mission-data-collection.git","svn_url":"https://github.com/e-mission/e-mission-data-collection","homepage":null,"size":15611,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":34,"forks":10,"open_issues":34,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142"},"html":{"href":"https://github.com/e-mission/e-mission-data-collection/pull/142"},"issue":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/142"},"comments":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/e-mission/e-mission-data-collection/statuses/c85b8ccc94cd13dc1495c56f58772c76c94e50d5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":32,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"shankari"}}