{"action":"created","comment":{"url":"https://api.github.com/repos/twisted/twisted/pulls/comments/67603180","id":67603180,"diff_hunk":"@@ -2470,6 +2471,30 @@ def test_finishProducesLog(self):\n                       factory.logFile.getvalue())\n \n \n+    def test_requestBodyTimeoutFromFactory(self):\n+        \"\"\"\n+        L{HTTPChannel} timeouts whenever data from a request body is not\n+        delivered to it in time, even when it gets built from a L{HTTPFactory}.\n+        \"\"\"\n+        clock = Clock()\n+        factory = http.HTTPFactory(timeout=100, reactor=clock)\n+        factory.startFactory()\n+        protocol = factory.buildProtocol(None)\n+        transport = StringTransport()\n+\n+        # This is a terrible violation of the abstraction later of\n+        # _genericHTTPChannelProtocol, but we need to do it because\n+        # policies.TimeoutMixin doesn't accept a reactor on the object.\n+        # Maybe we should fix this?","path":"twisted/web/test/test_http.py","position":26,"original_position":26,"commit_id":"44718b4c3064eff42cd416d7e56deb5eb2fce02a","original_commit_id":"44718b4c3064eff42cd416d7e56deb5eb2fce02a","user":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"body":"I don't think that leaving such questions as comments is a good idea.\r\n\r\nThe question is very good, but I think that it should be part of the PR description or the review request.\r\n\r\nYes. We might find a nicer way to inject the reactor... or use a standard self._reactor or self._scheduler","created_at":"2016-06-18T16:38:44Z","updated_at":"2016-06-18T16:38:44Z","html_url":"https://github.com/twisted/twisted/pull/193#discussion_r67603180","pull_request_url":"https://api.github.com/repos/twisted/twisted/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments/67603180"},"html":{"href":"https://github.com/twisted/twisted/pull/193#discussion_r67603180"},"pull_request":{"href":"https://api.github.com/repos/twisted/twisted/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/twisted/twisted/pulls/193","id":74093037,"html_url":"https://github.com/twisted/twisted/pull/193","diff_url":"https://github.com/twisted/twisted/pull/193.diff","patch_url":"https://github.com/twisted/twisted/pull/193.patch","issue_url":"https://api.github.com/repos/twisted/twisted/issues/193","number":193,"state":"open","locked":false,"title":"Restore timeouts to the HTTP/1.1 server.","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"See [Twisted issue 8481](https://twistedmatrix.com/trac/ticket/8481) for more details.\r\n\r\nThis restores the timeout in the HTTP/1.1 server that was broken in 16.2 when we released the `_GenericHTTPChannelProtocol`.","created_at":"2016-06-16T14:42:07Z","updated_at":"2016-06-18T16:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba871caf97c41ff6262e8ef2867450ddd71c314","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twisted/twisted/pulls/193/commits","review_comments_url":"https://api.github.com/repos/twisted/twisted/pulls/193/comments","review_comment_url":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/twisted/issues/193/comments","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/44718b4c3064eff42cd416d7e56deb5eb2fce02a","head":{"label":"Lukasa:issue/8481","ref":"issue/8481","sha":"44718b4c3064eff42cd416d7e56deb5eb2fce02a","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"repo":{"id":58872076,"name":"twisted","full_name":"Lukasa/twisted","owner":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukasa/twisted","description":"Event-driven networking engine written in Python.","fork":true,"url":"https://api.github.com/repos/Lukasa/twisted","forks_url":"https://api.github.com/repos/Lukasa/twisted/forks","keys_url":"https://api.github.com/repos/Lukasa/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukasa/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukasa/twisted/teams","hooks_url":"https://api.github.com/repos/Lukasa/twisted/hooks","issue_events_url":"https://api.github.com/repos/Lukasa/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/Lukasa/twisted/events","assignees_url":"https://api.github.com/repos/Lukasa/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/Lukasa/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/Lukasa/twisted/tags","blobs_url":"https://api.github.com/repos/Lukasa/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukasa/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukasa/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukasa/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukasa/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukasa/twisted/languages","stargazers_url":"https://api.github.com/repos/Lukasa/twisted/stargazers","contributors_url":"https://api.github.com/repos/Lukasa/twisted/contributors","subscribers_url":"https://api.github.com/repos/Lukasa/twisted/subscribers","subscription_url":"https://api.github.com/repos/Lukasa/twisted/subscription","commits_url":"https://api.github.com/repos/Lukasa/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukasa/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukasa/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukasa/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukasa/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/Lukasa/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukasa/twisted/merges","archive_url":"https://api.github.com/repos/Lukasa/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukasa/twisted/downloads","issues_url":"https://api.github.com/repos/Lukasa/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/Lukasa/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukasa/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukasa/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukasa/twisted/labels{/name}","releases_url":"https://api.github.com/repos/Lukasa/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/Lukasa/twisted/deployments","created_at":"2016-05-15T16:28:38Z","updated_at":"2016-05-15T16:28:48Z","pushed_at":"2016-06-17T10:07:37Z","git_url":"git://github.com/Lukasa/twisted.git","ssh_url":"git@github.com:Lukasa/twisted.git","clone_url":"https://github.com/Lukasa/twisted.git","svn_url":"https://github.com/Lukasa/twisted","homepage":"http://www.twistedmatrix.com","size":48653,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"twisted:trunk","ref":"trunk","sha":"b99220d4007fb78868688a7fc3781f2201e98064","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2016-06-18T09:03:07Z","pushed_at":"2016-06-18T16:32:24Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"http://www.twistedmatrix.com","size":77684,"stargazers_count":1279,"watchers_count":1279,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":50,"forks":393,"open_issues":50,"watchers":1279,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/193"},"html":{"href":"https://github.com/twisted/twisted/pull/193"},"issue":{"href":"https://api.github.com/repos/twisted/twisted/issues/193"},"comments":{"href":"https://api.github.com/repos/twisted/twisted/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/twisted/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/twisted/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/twisted/statuses/44718b4c3064eff42cd416d7e56deb5eb2fce02a"}}}}
{"actor":{"display_login":"adiroiban"}}