{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/49985201","id":49985201,"diff_hunk":"@@ -994,6 +995,8 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)\n     if (GetBoolArg(\"-peerbloomfilters\", true))\n         nLocalServices |= NODE_BLOOM;\n \n+    nMaxTipAge = GetArg(\"-maxtipage\", DEFAULT_MAX_TIP_AGE);","path":"src/init.cpp","position":12,"original_position":12,"commit_id":"64360f13044125fbb3cdcbe2e5e8f2bfb82a8b27","original_commit_id":"64360f13044125fbb3cdcbe2e5e8f2bfb82a8b27","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"@jtimon We use the `DEFAULT_*` values to make it easier to implement #1044.","created_at":"2016-01-18T10:58:44Z","updated_at":"2016-01-18T10:58:44Z","html_url":"https://github.com/bitcoin/bitcoin/pull/7208#discussion_r49985201","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/49985201"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7208#discussion_r49985201"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208","id":53558603,"html_url":"https://github.com/bitcoin/bitcoin/pull/7208","diff_url":"https://github.com/bitcoin/bitcoin/pull/7208.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7208.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7208","number":7208,"state":"closed","locked":false,"title":"Make max tip age an option instead of chainparam","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"After discussion in #7164 I think this is better.\r\n\r\nMax tip age was introduced in #5987 to make it possible to run testnet-in-a-box. But associating this behavior with the testnet chain is wrong conceptually, as it is not needed in normal usage. Should aim to make testnet test the software as-is.\r\n\r\nReplace it with a (debug) option `-maxtipage`, which can be specified only in the specific case.","created_at":"2015-12-14T12:30:39Z","updated_at":"2016-01-18T10:58:44Z","closed_at":"2016-01-18T10:56:14Z","merged_at":"2016-01-18T10:56:14Z","merge_commit_sha":"ea6f5f10c80db3d03b1960b86803c927b5797269","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7208/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/64360f13044125fbb3cdcbe2e5e8f2bfb82a8b27","head":{"label":"laanwj:2015_12_maxtipage","ref":"2015_12_maxtipage","sha":"64360f13044125fbb3cdcbe2e5e8f2bfb82a8b27","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"repo":{"id":1750308,"name":"bitcoin","full_name":"laanwj/bitcoin","owner":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laanwj/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/laanwj/bitcoin","forks_url":"https://api.github.com/repos/laanwj/bitcoin/forks","keys_url":"https://api.github.com/repos/laanwj/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laanwj/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laanwj/bitcoin/teams","hooks_url":"https://api.github.com/repos/laanwj/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/laanwj/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/laanwj/bitcoin/events","assignees_url":"https://api.github.com/repos/laanwj/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/laanwj/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/laanwj/bitcoin/tags","blobs_url":"https://api.github.com/repos/laanwj/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laanwj/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laanwj/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/laanwj/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laanwj/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/laanwj/bitcoin/languages","stargazers_url":"https://api.github.com/repos/laanwj/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/laanwj/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/laanwj/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/laanwj/bitcoin/subscription","commits_url":"https://api.github.com/repos/laanwj/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/laanwj/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/laanwj/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/laanwj/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/laanwj/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/laanwj/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laanwj/bitcoin/merges","archive_url":"https://api.github.com/repos/laanwj/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laanwj/bitcoin/downloads","issues_url":"https://api.github.com/repos/laanwj/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/laanwj/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/laanwj/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/laanwj/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laanwj/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/laanwj/bitcoin/releases{/id}","created_at":"2011-05-15T07:09:54Z","updated_at":"2015-08-27T22:21:18Z","pushed_at":"2016-01-18T09:59:29Z","git_url":"git://github.com/laanwj/bitcoin.git","ssh_url":"git@github.com:laanwj/bitcoin.git","clone_url":"https://github.com/laanwj/bitcoin.git","svn_url":"https://github.com/laanwj/bitcoin","homepage":"http://www.bitcoin.org","size":57253,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"dc511dcfd9eaa82a773d0a402b1500c3fd9113e0","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-01-18T10:55:50Z","pushed_at":"2016-01-18T10:56:04Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":104504,"stargazers_count":8309,"watchers_count":8309,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5647,"mirror_url":null,"open_issues_count":448,"forks":5647,"open_issues":448,"watchers":8309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/7208"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7208"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/7208/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7208/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/64360f13044125fbb3cdcbe2e5e8f2bfb82a8b27"}}}}