{"action":"closed","number":584,"pull_request":{"url":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584","id":91401654,"html_url":"https://github.com/danielkocsis/liferay-portal/pull/584","diff_url":"https://github.com/danielkocsis/liferay-portal/pull/584.diff","patch_url":"https://github.com/danielkocsis/liferay-portal/pull/584.patch","issue_url":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/584","number":584,"state":"closed","locked":false,"title":"LPS-68898","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"body":"Hi @danielkocsis,\n\nThe issue is that embedded portlet preferences are being being exported and imported correctly. This commit is doing the following:\n1. Using portlet ID instead of root portlet ID since we should always be getting the actual portlet. This is necessary because the Web Content Display portlet is considered instanceable so getting the root portlet ID will be incorrect and the preferences won't be exported/imported correctly. This changes LPS-30387 but it is necessary to trust what is in the preferences or LAR so that we can correctly import/export embedded portlets.\n2. Using the group owner type when passing the group ID to the preferences instead of using the layout owner type with a group ID which causes a mismatch.\n3. Rearranging how preferences are retrieved so that the embedded logic is used across the board. Without this change, the correct preferences for embedded portlets are not retrieved since it tries to fetch the layout's preferences instead of the group's.\n\nPlease let me know if you have any questions. Thanks!\n","created_at":"2016-10-28T15:25:51Z","updated_at":"2016-11-02T13:40:06Z","closed_at":"2016-11-02T13:40:05Z","merged_at":null,"merge_commit_sha":"46ccb0af31664f2c9d90e4e8cdd17019546052ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584/commits","review_comments_url":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584/comments","review_comment_url":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/584/comments","statuses_url":"https://api.github.com/repos/danielkocsis/liferay-portal/statuses/1302725258960d44bf688facb5ac8357a66cd539","head":{"label":"jonathanmccann:LPS-68898","ref":"LPS-68898","sha":"1302725258960d44bf688facb5ac8357a66cd539","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"repo":{"id":4877415,"name":"liferay-portal","full_name":"jonathanmccann/liferay-portal","owner":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathanmccann/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/jonathanmccann/liferay-portal","forks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/forks","keys_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/events","assignees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/merges","archive_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/deployments","created_at":"2012-07-03T20:58:23Z","updated_at":"2016-10-24T14:42:24Z","pushed_at":"2016-11-02T13:37:22Z","git_url":"git://github.com/jonathanmccann/liferay-portal.git","ssh_url":"git@github.com:jonathanmccann/liferay-portal.git","clone_url":"https://github.com/jonathanmccann/liferay-portal.git","svn_url":"https://github.com/jonathanmccann/liferay-portal","homepage":"http://liferay.com","size":10408568,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"danielkocsis:master","ref":"master","sha":"66678dad5a2d1189ff8662bb178b08dd9b8e1744","user":{"login":"danielkocsis","id":990522,"avatar_url":"https://avatars.githubusercontent.com/u/990522?v=3","gravatar_id":"","url":"https://api.github.com/users/danielkocsis","html_url":"https://github.com/danielkocsis","followers_url":"https://api.github.com/users/danielkocsis/followers","following_url":"https://api.github.com/users/danielkocsis/following{/other_user}","gists_url":"https://api.github.com/users/danielkocsis/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkocsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkocsis/subscriptions","organizations_url":"https://api.github.com/users/danielkocsis/orgs","repos_url":"https://api.github.com/users/danielkocsis/repos","events_url":"https://api.github.com/users/danielkocsis/events{/privacy}","received_events_url":"https://api.github.com/users/danielkocsis/received_events","type":"User","site_admin":false},"repo":{"id":2232731,"name":"liferay-portal","full_name":"danielkocsis/liferay-portal","owner":{"login":"danielkocsis","id":990522,"avatar_url":"https://avatars.githubusercontent.com/u/990522?v=3","gravatar_id":"","url":"https://api.github.com/users/danielkocsis","html_url":"https://github.com/danielkocsis","followers_url":"https://api.github.com/users/danielkocsis/followers","following_url":"https://api.github.com/users/danielkocsis/following{/other_user}","gists_url":"https://api.github.com/users/danielkocsis/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkocsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkocsis/subscriptions","organizations_url":"https://api.github.com/users/danielkocsis/orgs","repos_url":"https://api.github.com/users/danielkocsis/repos","events_url":"https://api.github.com/users/danielkocsis/events{/privacy}","received_events_url":"https://api.github.com/users/danielkocsis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielkocsis/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/danielkocsis/liferay-portal","forks_url":"https://api.github.com/repos/danielkocsis/liferay-portal/forks","keys_url":"https://api.github.com/repos/danielkocsis/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielkocsis/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielkocsis/liferay-portal/teams","hooks_url":"https://api.github.com/repos/danielkocsis/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/danielkocsis/liferay-portal/events","assignees_url":"https://api.github.com/repos/danielkocsis/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/danielkocsis/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/danielkocsis/liferay-portal/tags","blobs_url":"https://api.github.com/repos/danielkocsis/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielkocsis/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielkocsis/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielkocsis/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielkocsis/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/danielkocsis/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/danielkocsis/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/danielkocsis/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/danielkocsis/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/danielkocsis/liferay-portal/subscription","commits_url":"https://api.github.com/repos/danielkocsis/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielkocsis/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielkocsis/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielkocsis/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/danielkocsis/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielkocsis/liferay-portal/merges","archive_url":"https://api.github.com/repos/danielkocsis/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielkocsis/liferay-portal/downloads","issues_url":"https://api.github.com/repos/danielkocsis/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/danielkocsis/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/danielkocsis/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielkocsis/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/danielkocsis/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/danielkocsis/liferay-portal/deployments","created_at":"2011-08-19T07:49:07Z","updated_at":"2016-10-24T08:07:44Z","pushed_at":"2016-11-02T13:37:24Z","git_url":"git://github.com/danielkocsis/liferay-portal.git","ssh_url":"git@github.com:danielkocsis/liferay-portal.git","clone_url":"https://github.com/danielkocsis/liferay-portal.git","svn_url":"https://github.com/danielkocsis/liferay-portal","homepage":"http://liferay.com","size":10457418,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584"},"html":{"href":"https://github.com/danielkocsis/liferay-portal/pull/584"},"issue":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/584"},"comments":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/danielkocsis/liferay-portal/statuses/1302725258960d44bf688facb5ac8357a66cd539"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":115,"deletions":121,"changed_files":6}}
{"actor":{"display_login":"jonathanmccann"}}