{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25572","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25572/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25572/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25572/events","html_url":"https://github.com/kubernetes/kubernetes/issues/25572","id":154725681,"number":25572,"title":"glide dependency flattening","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/build-release","name":"area/build-release","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/release-infra","name":"team/release-infra","color":"d2b48c"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-05-13T14:32:39Z","updated_at":"2016-07-21T17:07:25Z","closed_at":"2016-07-21T17:07:25Z","body":"Now that we're using glide / vendoring (hooray - thank you @thockin ), we have a vendor directory.  But I'm hitting a problem using glide myself in a separate project (upup):\r\n\r\n1. I'm taking k8s as a dependency (I want the safe format and mount utility)\r\n2. Because we don't have a glide.yaml / glide.lock file, glide does not flatten the dependencies AFAICT.\r\n3. So glog gets defined twice, once because I am using glog, and once in vendor/k8s.io/kubernetes/vendor.  This is the same problem as listed here https://github.com/Masterminds/glide#q-should-i-check-vendor-into-version-control\r\n4. That causes an error because glog's log_dir flag is then defined twice.\r\n\r\nI was able to work around this by manually deleting the vendor directory from vendor/k8s.io/kubernetes/vendor.\r\n\r\nI think if we checked in the glide.yaml / glide.lock files, glide would detect that k8s is using vendoring and would flatten the dependencies.  At least that is how I read the glide documentation.\r\n\r\nI may also not be using glide correctly or be misunderstanding something bigger!"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/234318918","html_url":"https://github.com/kubernetes/kubernetes/issues/25572#issuecomment-234318918","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25572","id":234318918,"user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T17:07:25Z","updated_at":"2016-07-21T17:07:25Z","body":"Kubernetes is NOT using glide yet.  We filed a number of bugs with glide, and are waiting for them.  They seemed like smallish bugs, but the glide folks have a more general solution they want to use, which has left us waiting.\r\n\r\n@mattfarina is there no shorter path? I filed my issues literally 3 months ago.\r\n\r\nAnyway, I am going to close this since I think it was based on the mistaken belief that we had achieved glide.  We haven't."}}
{"actor":{"display_login":"thockin"}}