{"action":"created","comment":{"url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/comments/89492159","pull_request_review_id":10037067,"id":89492159,"diff_hunk":"@@ -22,12 +22,29 @@ module.exports = (repo) => {\n     let cid3\n \n     before((done) => {\n-      node1 = new dagPB.DAGNode(new Buffer('I am 1'))\n-      node2 = new dagPB.DAGNode(new Buffer('I am 2'))\n-      node3 = new dagPB.DAGNode(new Buffer('I am 3'))\n-\n       series([\n         (cb) => {\n+          dagPB.DAGNode.create(new Buffer('I am 1'), (err, node) => {\n+            expect(err).to.not.exist\n+            node1 = node\n+            cb()\n+          })\n+        },\n+        (cb) => {\n+          dagPB.DAGNode.create(new Buffer('I am 2'), (err, node) => {\n+            expect(err).to.not.exist\n+            node2 = node\n+            cb()\n+          })\n+        },\n+        (cb) => {\n+          dagPB.DAGNode.create(new Buffer('I am 3'), (err, node) => {\n+            expect(err).to.not.exist\n+            node3 = node\n+            cb()\n+          })\n+        },","path":"test/test-ipld-dag-pb.js","position":29,"original_position":29,"commit_id":"45fa7beffa41738275e069a039ab6ee22fce4f89","original_commit_id":"45fa7beffa41738275e069a039ab6ee22fce4f89","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"@VictorBjelkholm true, in an example where the only other thing that happens is an assignment, that would be ok, but if there was more operations between that `expect(err)` and `done`, other operations would fail and the error would have the right information for debugging, which would not get printed due to the operations in between failing. For the sake of consistency (check for the error first thing), I keep doing it this way.","created_at":"2016-11-24T12:50:15Z","updated_at":"2016-11-24T12:50:15Z","html_url":"https://github.com/ipld/js-ipld-resolver/pull/67#discussion_r89492159","pull_request_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/comments/89492159"},"html":{"href":"https://github.com/ipld/js-ipld-resolver/pull/67#discussion_r89492159"},"pull_request":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67","id":94869435,"html_url":"https://github.com/ipld/js-ipld-resolver/pull/67","diff_url":"https://github.com/ipld/js-ipld-resolver/pull/67.diff","patch_url":"https://github.com/ipld/js-ipld-resolver/pull/67.patch","issue_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/67","number":67,"state":"open","locked":false,"title":"feat: update to latest dag-pb.DAGNode API","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-22T18:17:12Z","updated_at":"2016-11-24T12:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0ac29788739a2509eaf322d0aa37708d09073cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/67/comments","statuses_url":"https://api.github.com/repos/ipld/js-ipld-resolver/statuses/45fa7beffa41738275e069a039ab6ee22fce4f89","head":{"label":"ipld:feat/awesome-dag-pb","ref":"feat/awesome-dag-pb","sha":"45fa7beffa41738275e069a039ab6ee22fce4f89","user":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"repo":{"id":55763542,"name":"js-ipld-resolver","full_name":"ipld/js-ipld-resolver","owner":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipld/js-ipld-resolver","description":"JavaScript implementation of the IPLDService","fork":false,"url":"https://api.github.com/repos/ipld/js-ipld-resolver","forks_url":"https://api.github.com/repos/ipld/js-ipld-resolver/forks","keys_url":"https://api.github.com/repos/ipld/js-ipld-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipld/js-ipld-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipld/js-ipld-resolver/teams","hooks_url":"https://api.github.com/repos/ipld/js-ipld-resolver/hooks","issue_events_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/ipld/js-ipld-resolver/events","assignees_url":"https://api.github.com/repos/ipld/js-ipld-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/ipld/js-ipld-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/ipld/js-ipld-resolver/tags","blobs_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipld/js-ipld-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/ipld/js-ipld-resolver/languages","stargazers_url":"https://api.github.com/repos/ipld/js-ipld-resolver/stargazers","contributors_url":"https://api.github.com/repos/ipld/js-ipld-resolver/contributors","subscribers_url":"https://api.github.com/repos/ipld/js-ipld-resolver/subscribers","subscription_url":"https://api.github.com/repos/ipld/js-ipld-resolver/subscription","commits_url":"https://api.github.com/repos/ipld/js-ipld-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipld/js-ipld-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/ipld/js-ipld-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipld/js-ipld-resolver/merges","archive_url":"https://api.github.com/repos/ipld/js-ipld-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipld/js-ipld-resolver/downloads","issues_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/ipld/js-ipld-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/ipld/js-ipld-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipld/js-ipld-resolver/labels{/name}","releases_url":"https://api.github.com/repos/ipld/js-ipld-resolver/releases{/id}","deployments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/deployments","created_at":"2016-04-08T08:34:07Z","updated_at":"2016-10-24T00:47:13Z","pushed_at":"2016-11-22T18:17:12Z","git_url":"git://github.com/ipld/js-ipld-resolver.git","ssh_url":"git@github.com:ipld/js-ipld-resolver.git","clone_url":"https://github.com/ipld/js-ipld-resolver.git","svn_url":"https://github.com/ipld/js-ipld-resolver","homepage":"","size":97,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"ipld:master","ref":"master","sha":"ee453f30bd7622bad6f185c4ded22d4cc7e9adf5","user":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"repo":{"id":55763542,"name":"js-ipld-resolver","full_name":"ipld/js-ipld-resolver","owner":{"login":"ipld","id":19803583,"avatar_url":"https://avatars.githubusercontent.com/u/19803583?v=3","gravatar_id":"","url":"https://api.github.com/users/ipld","html_url":"https://github.com/ipld","followers_url":"https://api.github.com/users/ipld/followers","following_url":"https://api.github.com/users/ipld/following{/other_user}","gists_url":"https://api.github.com/users/ipld/gists{/gist_id}","starred_url":"https://api.github.com/users/ipld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipld/subscriptions","organizations_url":"https://api.github.com/users/ipld/orgs","repos_url":"https://api.github.com/users/ipld/repos","events_url":"https://api.github.com/users/ipld/events{/privacy}","received_events_url":"https://api.github.com/users/ipld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipld/js-ipld-resolver","description":"JavaScript implementation of the IPLDService","fork":false,"url":"https://api.github.com/repos/ipld/js-ipld-resolver","forks_url":"https://api.github.com/repos/ipld/js-ipld-resolver/forks","keys_url":"https://api.github.com/repos/ipld/js-ipld-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipld/js-ipld-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipld/js-ipld-resolver/teams","hooks_url":"https://api.github.com/repos/ipld/js-ipld-resolver/hooks","issue_events_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/ipld/js-ipld-resolver/events","assignees_url":"https://api.github.com/repos/ipld/js-ipld-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/ipld/js-ipld-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/ipld/js-ipld-resolver/tags","blobs_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipld/js-ipld-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/ipld/js-ipld-resolver/languages","stargazers_url":"https://api.github.com/repos/ipld/js-ipld-resolver/stargazers","contributors_url":"https://api.github.com/repos/ipld/js-ipld-resolver/contributors","subscribers_url":"https://api.github.com/repos/ipld/js-ipld-resolver/subscribers","subscription_url":"https://api.github.com/repos/ipld/js-ipld-resolver/subscription","commits_url":"https://api.github.com/repos/ipld/js-ipld-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipld/js-ipld-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipld/js-ipld-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/ipld/js-ipld-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipld/js-ipld-resolver/merges","archive_url":"https://api.github.com/repos/ipld/js-ipld-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipld/js-ipld-resolver/downloads","issues_url":"https://api.github.com/repos/ipld/js-ipld-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/ipld/js-ipld-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/ipld/js-ipld-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipld/js-ipld-resolver/labels{/name}","releases_url":"https://api.github.com/repos/ipld/js-ipld-resolver/releases{/id}","deployments_url":"https://api.github.com/repos/ipld/js-ipld-resolver/deployments","created_at":"2016-04-08T08:34:07Z","updated_at":"2016-10-24T00:47:13Z","pushed_at":"2016-11-22T18:17:12Z","git_url":"git://github.com/ipld/js-ipld-resolver.git","ssh_url":"git@github.com:ipld/js-ipld-resolver.git","clone_url":"https://github.com/ipld/js-ipld-resolver.git","svn_url":"https://github.com/ipld/js-ipld-resolver","homepage":"","size":97,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67"},"html":{"href":"https://github.com/ipld/js-ipld-resolver/pull/67"},"issue":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/67"},"comments":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ipld/js-ipld-resolver/statuses/45fa7beffa41738275e069a039ab6ee22fce4f89"}}}}
{"actor":{"display_login":"diasdavid"}}