{"action":"created","issue":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/60","repository_url":"https://api.github.com/repos/BohemianCoding/BCFoundation","labels_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/60/comments","events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/60/events","html_url":"https://github.com/BohemianCoding/BCFoundation/pull/60","id":163182993,"number":60,"title":"Code Review: Performance regression with smoothness of dragging text layers around canvas (#9670)","user":{"login":"randomsequence","id":421031,"avatar_url":"https://avatars.githubusercontent.com/u/421031?v=3","gravatar_id":"","url":"https://api.github.com/users/randomsequence","html_url":"https://github.com/randomsequence","followers_url":"https://api.github.com/users/randomsequence/followers","following_url":"https://api.github.com/users/randomsequence/following{/other_user}","gists_url":"https://api.github.com/users/randomsequence/gists{/gist_id}","starred_url":"https://api.github.com/users/randomsequence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomsequence/subscriptions","organizations_url":"https://api.github.com/users/randomsequence/orgs","repos_url":"https://api.github.com/users/randomsequence/repos","events_url":"https://api.github.com/users/randomsequence/events{/privacy}","received_events_url":"https://api.github.com/users/randomsequence/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-30T14:43:35Z","updated_at":"2016-06-30T16:04:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/60","html_url":"https://github.com/BohemianCoding/BCFoundation/pull/60","diff_url":"https://github.com/BohemianCoding/BCFoundation/pull/60.diff","patch_url":"https://github.com/BohemianCoding/BCFoundation/pull/60.patch"},"body":"Code review for Performance regression with smoothness of dragging text layers around canvas (#9670):\n\n> Papadakis reported a noticeable lag when dragging text layers around in Sketch Beta 39 (31443).\n> \n> I can confirm that this lag or apparent drop in frames is indeed particularly noticeable when comparing the current beta alongside Sketch 3.8.3.\n> \n> **Steps**\n> \n> 1. Insert a text layer into a new document\n> 2. Select and drag the text layer around the canvas\n> \n> **Notes**\n> \n> * In a new document, 3.8.3 doesn't appear to drop any frames\n> * In a direct comparison with 3.8.3, Sketch Beta 39 (31443) appears to drop some frames\n> * Tested on a Retain display\n> * Reproducible on a clean setup with no plugins installed\n> \n> cc @pieteromvlee\n\n\nConnect to BohemianCoding/Sketch#9670."},"comment":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/comments/229705883","html_url":"https://github.com/BohemianCoding/BCFoundation/pull/60#issuecomment-229705883","issue_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/60","id":229705883,"user":{"login":"samdeane","id":206306,"avatar_url":"https://avatars.githubusercontent.com/u/206306?v=3","gravatar_id":"","url":"https://api.github.com/users/samdeane","html_url":"https://github.com/samdeane","followers_url":"https://api.github.com/users/samdeane/followers","following_url":"https://api.github.com/users/samdeane/following{/other_user}","gists_url":"https://api.github.com/users/samdeane/gists{/gist_id}","starred_url":"https://api.github.com/users/samdeane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdeane/subscriptions","organizations_url":"https://api.github.com/users/samdeane/orgs","repos_url":"https://api.github.com/users/samdeane/repos","events_url":"https://api.github.com/users/samdeane/events{/privacy}","received_events_url":"https://api.github.com/users/samdeane/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:04:16Z","updated_at":"2016-06-30T16:04:16Z","body":"Ah, one thing I've found. You are #importing it incorrectly from within Sketch. \r\n\r\nYou need to add `#import \"BCObjectPool.h\"` to the BCFoundation.h umbrella header. It will then get picked up for you as part of the module."}}
{"actor":{"display_login":"samdeane"}}