{"action":"created","comment":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/81200654","pull_request_review_id":2198299,"id":81200654,"diff_hunk":"@@ -346,6 +346,16 @@ _.extend UserSchema.properties,\n   role: {type: 'string', enum: [\"God\", \"advisor\", \"parent\", \"principal\", \"student\", \"superintendent\", \"teacher\", \"technology coordinator\"]}\n   birthday: c.stringDate({title: \"Birthday\"})\n   lastAchievementChecked: c.stringDate({ name: 'Last Achievement Checked' })\n+  signupQueryParams: { type: 'object', properties: {","path":"app/schemas/models/user.coffee","position":4,"original_position":4,"commit_id":"b0de25bcceb7baffff126184bea53536156b0583","original_commit_id":"b0de25bcceb7baffff126184bea53536156b0583","user":{"login":"sderickson","id":204723,"avatar_url":"https://avatars.githubusercontent.com/u/204723?v=3","gravatar_id":"","url":"https://api.github.com/users/sderickson","html_url":"https://github.com/sderickson","followers_url":"https://api.github.com/users/sderickson/followers","following_url":"https://api.github.com/users/sderickson/following{/other_user}","gists_url":"https://api.github.com/users/sderickson/gists{/gist_id}","starred_url":"https://api.github.com/users/sderickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderickson/subscriptions","organizations_url":"https://api.github.com/users/sderickson/orgs","repos_url":"https://api.github.com/users/sderickson/repos","events_url":"https://api.github.com/users/sderickson/events{/privacy}","received_events_url":"https://api.github.com/users/sderickson/received_events","type":"User","site_admin":false},"body":"Actually, it makes more sense for these to be top-level. I'm reorganizing these so the data fields can be repurposed later.\r\n\r\n```\r\n  israelId: {type: 'string', description: 'ID string used just for il.codecombat.com'}\r\n  school: { \r\n    type: 'object', \r\n    description: 'Generic property for storing school information. Currently\r\n                  only used by Israel; if/when we use it for other purposes,\r\n                  think about how to keep the data consistent.',\r\n    properties: {\r\n      name: { type: 'string' }\r\n      city: { type: 'string' }\r\n      district: { type: 'string' }\r\n      state: { type: 'string' }\r\n      country: { type: 'string' }\r\n    }\r\n  }\r\n```\r\n\r\nWhat do you think?","created_at":"2016-09-29T18:14:29Z","updated_at":"2016-09-29T18:14:29Z","html_url":"https://github.com/codecombat/codecombat/pull/3947#discussion_r81200654","pull_request_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3947","_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments/81200654"},"html":{"href":"https://github.com/codecombat/codecombat/pull/3947#discussion_r81200654"},"pull_request":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3947"}}},"pull_request":{"url":"https://api.github.com/repos/codecombat/codecombat/pulls/3947","id":87015749,"html_url":"https://github.com/codecombat/codecombat/pull/3947","diff_url":"https://github.com/codecombat/codecombat/pull/3947.diff","patch_url":"https://github.com/codecombat/codecombat/pull/3947.patch","issue_url":"https://api.github.com/repos/codecombat/codecombat/issues/3947","number":3947,"state":"open","locked":false,"title":"Add Israel signup view","user":{"login":"sderickson","id":204723,"avatar_url":"https://avatars.githubusercontent.com/u/204723?v=3","gravatar_id":"","url":"https://api.github.com/users/sderickson","html_url":"https://github.com/sderickson","followers_url":"https://api.github.com/users/sderickson/followers","following_url":"https://api.github.com/users/sderickson/following{/other_user}","gists_url":"https://api.github.com/users/sderickson/gists{/gist_id}","starred_url":"https://api.github.com/users/sderickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sderickson/subscriptions","organizations_url":"https://api.github.com/users/sderickson/orgs","repos_url":"https://api.github.com/users/sderickson/repos","events_url":"https://api.github.com/users/sderickson/events{/privacy}","received_events_url":"https://api.github.com/users/sderickson/received_events","type":"User","site_admin":false},"body":"Add a dedicated signup page for Israel. In the future, student and individuals creating accounts will be redirected to a separate site to sign up. This site will then redirect to `/il-signup`, providing information about the user through GET parameters, including email and an ID which will be saved, and all the student needs to do on our end is provide a username and password.","created_at":"2016-09-27T21:28:53Z","updated_at":"2016-09-29T18:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f34221bbe5452fe7f67f03ca7dcdcbd6aae2961","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3947/commits","review_comments_url":"https://api.github.com/repos/codecombat/codecombat/pulls/3947/comments","review_comment_url":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codecombat/codecombat/issues/3947/comments","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/b0de25bcceb7baffff126184bea53536156b0583","head":{"label":"codecombat:israel-signup","ref":"israel-signup","sha":"b0de25bcceb7baffff126184bea53536156b0583","user":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2016-09-29T12:17:49Z","pushed_at":"2016-09-29T17:18:59Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":152770,"stargazers_count":5235,"watchers_count":5235,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2561,"mirror_url":null,"open_issues_count":306,"forks":2561,"open_issues":306,"watchers":5235,"default_branch":"master"}},"base":{"label":"codecombat:master","ref":"master","sha":"b7180833b426b25021d4a04d50120145988f38e9","user":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"repo":{"id":15193430,"name":"codecombat","full_name":"codecombat/codecombat","owner":{"login":"codecombat","id":5795842,"avatar_url":"https://avatars.githubusercontent.com/u/5795842?v=3","gravatar_id":"","url":"https://api.github.com/users/codecombat","html_url":"https://github.com/codecombat","followers_url":"https://api.github.com/users/codecombat/followers","following_url":"https://api.github.com/users/codecombat/following{/other_user}","gists_url":"https://api.github.com/users/codecombat/gists{/gist_id}","starred_url":"https://api.github.com/users/codecombat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecombat/subscriptions","organizations_url":"https://api.github.com/users/codecombat/orgs","repos_url":"https://api.github.com/users/codecombat/repos","events_url":"https://api.github.com/users/codecombat/events{/privacy}","received_events_url":"https://api.github.com/users/codecombat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codecombat/codecombat","description":"Game for learning how to code.","fork":false,"url":"https://api.github.com/repos/codecombat/codecombat","forks_url":"https://api.github.com/repos/codecombat/codecombat/forks","keys_url":"https://api.github.com/repos/codecombat/codecombat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codecombat/codecombat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codecombat/codecombat/teams","hooks_url":"https://api.github.com/repos/codecombat/codecombat/hooks","issue_events_url":"https://api.github.com/repos/codecombat/codecombat/issues/events{/number}","events_url":"https://api.github.com/repos/codecombat/codecombat/events","assignees_url":"https://api.github.com/repos/codecombat/codecombat/assignees{/user}","branches_url":"https://api.github.com/repos/codecombat/codecombat/branches{/branch}","tags_url":"https://api.github.com/repos/codecombat/codecombat/tags","blobs_url":"https://api.github.com/repos/codecombat/codecombat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codecombat/codecombat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codecombat/codecombat/git/refs{/sha}","trees_url":"https://api.github.com/repos/codecombat/codecombat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codecombat/codecombat/statuses/{sha}","languages_url":"https://api.github.com/repos/codecombat/codecombat/languages","stargazers_url":"https://api.github.com/repos/codecombat/codecombat/stargazers","contributors_url":"https://api.github.com/repos/codecombat/codecombat/contributors","subscribers_url":"https://api.github.com/repos/codecombat/codecombat/subscribers","subscription_url":"https://api.github.com/repos/codecombat/codecombat/subscription","commits_url":"https://api.github.com/repos/codecombat/codecombat/commits{/sha}","git_commits_url":"https://api.github.com/repos/codecombat/codecombat/git/commits{/sha}","comments_url":"https://api.github.com/repos/codecombat/codecombat/comments{/number}","issue_comment_url":"https://api.github.com/repos/codecombat/codecombat/issues/comments{/number}","contents_url":"https://api.github.com/repos/codecombat/codecombat/contents/{+path}","compare_url":"https://api.github.com/repos/codecombat/codecombat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codecombat/codecombat/merges","archive_url":"https://api.github.com/repos/codecombat/codecombat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codecombat/codecombat/downloads","issues_url":"https://api.github.com/repos/codecombat/codecombat/issues{/number}","pulls_url":"https://api.github.com/repos/codecombat/codecombat/pulls{/number}","milestones_url":"https://api.github.com/repos/codecombat/codecombat/milestones{/number}","notifications_url":"https://api.github.com/repos/codecombat/codecombat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codecombat/codecombat/labels{/name}","releases_url":"https://api.github.com/repos/codecombat/codecombat/releases{/id}","deployments_url":"https://api.github.com/repos/codecombat/codecombat/deployments","created_at":"2013-12-14T21:47:37Z","updated_at":"2016-09-29T12:17:49Z","pushed_at":"2016-09-29T17:18:59Z","git_url":"git://github.com/codecombat/codecombat.git","ssh_url":"git@github.com:codecombat/codecombat.git","clone_url":"https://github.com/codecombat/codecombat.git","svn_url":"https://github.com/codecombat/codecombat","homepage":"http://codecombat.com","size":152770,"stargazers_count":5235,"watchers_count":5235,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2561,"mirror_url":null,"open_issues_count":306,"forks":2561,"open_issues":306,"watchers":5235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3947"},"html":{"href":"https://github.com/codecombat/codecombat/pull/3947"},"issue":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/3947"},"comments":{"href":"https://api.github.com/repos/codecombat/codecombat/issues/3947/comments"},"review_comments":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3947/comments"},"review_comment":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codecombat/codecombat/pulls/3947/commits"},"statuses":{"href":"https://api.github.com/repos/codecombat/codecombat/statuses/b0de25bcceb7baffff126184bea53536156b0583"}}}}
{"actor":{"display_login":"sderickson"}}