{"action":"created","issue":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1933","repository_url":"https://api.github.com/repos/cBioPortal/cbioportal","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1933/labels{/name}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1933/comments","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1933/events","html_url":"https://github.com/cBioPortal/cbioportal/pull/1933","id":191876810,"number":1933,"title":"Add tab for MDACC Heatmap viewer on patient view","user":{"login":"ChrisWakefield","id":14006681,"avatar_url":"https://avatars.githubusercontent.com/u/14006681?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisWakefield","html_url":"https://github.com/ChrisWakefield","followers_url":"https://api.github.com/users/ChrisWakefield/followers","following_url":"https://api.github.com/users/ChrisWakefield/following{/other_user}","gists_url":"https://api.github.com/users/ChrisWakefield/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisWakefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisWakefield/subscriptions","organizations_url":"https://api.github.com/users/ChrisWakefield/orgs","repos_url":"https://api.github.com/users/ChrisWakefield/repos","events_url":"https://api.github.com/users/ChrisWakefield/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisWakefield/received_events","type":"User","site_admin":false},"labels":[{"id":289899696,"url":"https://api.github.com/repos/cBioPortal/cbioportal/labels/do%20not%20merge","name":"do not merge","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-27T18:37:13Z","updated_at":"2016-12-02T22:22:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1933","html_url":"https://github.com/cBioPortal/cbioportal/pull/1933","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1933.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1933.patch"},"body":"# What?\r\n\r\nAdd tab for MDACC Heatmap viewer on patient page, as an embedded iframe\r\n# Why?\r\n\r\nIntegrates MD Anderson's pregenerated heatmap compendiums to many of the same studies that are loaded into cBioPortal.  This PR is the feature to show patient/sample related heatmaps, similar to PR #1709 that shows study-related heatmaps.\r\n\r\nChanges proposed in this pull request:\r\n- add tab HTML elements and include feature-specific javascript file mdacc_patient_heatmap_viewer.jsp\r\n\r\n# Checks\r\n- [x] Runs on Heroku.\r\n- [x] Follows [7 rules of great commit messages](http://chris.beams.io/posts/git-commit/). For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid [merge commits, use rebase instead.](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [x] Follows the [Google Style Guide](https://github.com/google/styleguide).\r\n- [x] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n- [x] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to\r\n  hotfix.\r\n\r\n# Any screenshots or GIFs?\r\n\r\nNo. Though this has the new visual feature of the added tab, properties must be configured and the patient must be selected to see the tab.  I don't know how to automate that complete scenario.\r\n\r\n# Notify reviewers\r\n\r\n@zhx828\r\n@cBioPortal/frontend\r\n@jjgao\r\n@ecerami\r\n\r\nThis adds a new tab to the patient view page.  Clicking on the tab\r\ndisplays an embedded \"MDACC Clustered Heatmap Compendium\" page, that\r\nshows only heatmaps that were indexed as including the sample id being\r\nviewed.  If the user clicks on a heatmap, The NG-CHM viewer is displayed\r\nwithin that embedded iframe.  The approach used (the embedded iframe)\r\nfollows the approach for the existing embedded Digital Slide Archive\r\nviewer.\r\n\r\nThis is based on my previous pull request #1709\r\n\r\nThe heatmap index mentioned above is queried via a web service running\r\nat MD Anderson, whose URL is set in the property\r\nmdacc.heatmap.meta.url in portal.properties.EXAMPLE.  A blank or\r\nmissing url property causes the query to be skipped and disables the\r\nentire functionality.\r\n\r\nSigned-off-by: Chris Wakefield <cwakefield@mdanderson.org>"},"comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments/264578638","html_url":"https://github.com/cBioPortal/cbioportal/pull/1933#issuecomment-264578638","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1933","id":264578638,"user":{"login":"ChrisWakefield","id":14006681,"avatar_url":"https://avatars.githubusercontent.com/u/14006681?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisWakefield","html_url":"https://github.com/ChrisWakefield","followers_url":"https://api.github.com/users/ChrisWakefield/followers","following_url":"https://api.github.com/users/ChrisWakefield/following{/other_user}","gists_url":"https://api.github.com/users/ChrisWakefield/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisWakefield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisWakefield/subscriptions","organizations_url":"https://api.github.com/users/ChrisWakefield/orgs","repos_url":"https://api.github.com/users/ChrisWakefield/repos","events_url":"https://api.github.com/users/ChrisWakefield/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisWakefield/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T22:22:56Z","updated_at":"2016-12-02T22:22:56Z","body":"@zhx828\r\n@jjgao\r\nReady for review?  Thanks!"}}
{"actor":{"display_login":"ChrisWakefield"}}