{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/117","repository_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure","labels_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/117/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/117/events","html_url":"https://github.com/elastic/elasticsearch-cloud-azure/pull/117","id":156786558,"number":117,"title":"Fix remove of azure files","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/labels/2.8.4","name":"2.8.4","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/labels/bug","name":"bug","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/milestones/16","html_url":"https://github.com/elastic/elasticsearch-cloud-azure/milestones/2.8.4","labels_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/milestones/16/labels","id":1787929,"number":16,"title":"2.8.4","description":"","creator":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2016-05-25T15:55:47Z","updated_at":"2016-05-27T15:02:50Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-05-25T15:54:41Z","updated_at":"2016-05-27T15:34:04Z","closed_at":"2016-05-27T15:02:50Z","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/pulls/117","html_url":"https://github.com/elastic/elasticsearch-cloud-azure/pull/117","diff_url":"https://github.com/elastic/elasticsearch-cloud-azure/pull/117.diff","patch_url":"https://github.com/elastic/elasticsearch-cloud-azure/pull/117.patch"},"body":"Probably when we updated Azure SDK, we introduced a regression.\r\nActually, we are not able to remove files anymore.\r\n\r\nFor example, if you register a new azure repository, the snapshot service tries to create a temp file and then remove it.\r\nRemoving does not work and you can see in logs:\r\n\r\n```\r\n[2016-05-18 11:03:24,914][WARN ][org.elasticsearch.cloud.azure.blobstore] [azure] can not remove [tests-ilmRPJ8URU-sh18yj38O6g/] in container {elasticsearch-snapshots}: The specified blob does not exist.\r\n```\r\n\r\nThis fix deals with that. It now list all the files in a flatten mode, remove in the full URL the server and the container name.\r\n\r\nAs an example, when you are removing a blob which full name is `https://dpi24329.blob.core.windows.net/elasticsearch-snapshots/bar/test` you need to actually call Azure SDK with `bar/test` as the path, `elasticsearch-snapshots` is the container.\r\n\r\nRelated to elastic/elasticsearch#16472.\r\nRelated to elastic/elasticsearch#18436.\r\n\r\nBackport of elastic/elasticsearch#18451 for 1.7 series"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/comments/222178609","html_url":"https://github.com/elastic/elasticsearch-cloud-azure/pull/117#issuecomment-222178609","issue_url":"https://api.github.com/repos/elastic/elasticsearch-cloud-azure/issues/117","id":222178609,"user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T15:34:03Z","updated_at":"2016-05-27T15:34:03Z","body":"If anyone wants to test a SNAPSHOT version before we release:\r\n\r\n```sh\r\nbin/plugin --remove cloud-azure\r\nbin/plugin --url https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/elasticsearch-cloud-azure/2.8.4-SNAPSHOT/elasticsearch-cloud-azure-2.8.4-20160527.150319-1.zip --install cloud-azure\r\n```\r\n\r\nThen create a **new repo**, snapshot an index. Check on Azure that files are here.\r\nThe remove the snapshot. As it cas the only snapshot containing those files in the repo, all files should have been removed.\r\n\r\n"}}
{"actor":{"display_login":"dadoonet"}}