{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/resource/pulls/comments/64052811","id":64052811,"diff_hunk":"@@ -119,4 +123,53 @@ protected function buildCollection(array $nodes)\n \n         return $collection;\n     }\n+\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function add($path, $resource)\n+    {\n+        Assert::notEq('', trim($path, '/'), 'The root directory cannot be created.');\n+        Assert::startsWith($path, '/', 'The target path %s is not absolute.');\n+\n+        $resolvedPath = $this->resolvePath($path);\n+        $parentNode = $this->session->getNode($resolvedPath);","path":"Repository/PhpcrRepository.php","position":31,"original_position":31,"commit_id":"05ffedad2f5871445788acf96fad2d7da095163c","original_commit_id":"05ffedad2f5871445788acf96fad2d7da095163c","user":{"login":"dantleech","id":530801,"avatar_url":"https://avatars.githubusercontent.com/u/530801?v=3","gravatar_id":"","url":"https://api.github.com/users/dantleech","html_url":"https://github.com/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","following_url":"https://api.github.com/users/dantleech/following{/other_user}","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","organizations_url":"https://api.github.com/users/dantleech/orgs","repos_url":"https://api.github.com/users/dantleech/repos","events_url":"https://api.github.com/users/dantleech/events{/privacy}","received_events_url":"https://api.github.com/users/dantleech/received_events","type":"User","site_admin":false},"body":"this isn't the parent.","created_at":"2016-05-20T14:45:46Z","updated_at":"2016-05-20T14:45:46Z","html_url":"https://github.com/symfony-cmf/resource/pull/17#discussion_r64052811","pull_request_url":"https://api.github.com/repos/symfony-cmf/resource/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/comments/64052811"},"html":{"href":"https://github.com/symfony-cmf/resource/pull/17#discussion_r64052811"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/resource/pulls/17","id":70854135,"html_url":"https://github.com/symfony-cmf/resource/pull/17","diff_url":"https://github.com/symfony-cmf/resource/pull/17.diff","patch_url":"https://github.com/symfony-cmf/resource/pull/17.patch","issue_url":"https://api.github.com/repos/symfony-cmf/resource/issues/17","number":17,"state":"open","locked":false,"title":"Add, remove and move (later)","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=3","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"body":"This PR does the implemenetation of the the base methods of the `EditableRepository` in both repositories. We will hopefully get the move method when https://github.com/puli/repository/pull/26 is ready, but i will start with it before the merge and use the interface defined by @WouterJ \r\n\r\nToDo:\r\n* [x] add()\r\n* [x] remove()\r\n* [ ] move()\r\n* [ ] clear()\r\n\r\nNote: i branched from the state #15 will rebase on master when its merged, so the other commits should disappear.","created_at":"2016-05-20T13:24:40Z","updated_at":"2016-05-20T14:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba7963acfcbb80ac1df84f0018f19699f72b9e37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/resource/pulls/17/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/resource/pulls/17/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/resource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/resource/issues/17/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/resource/statuses/05ffedad2f5871445788acf96fad2d7da095163c","head":{"label":"ElectricMaxxx:write_move_delete","ref":"write_move_delete","sha":"05ffedad2f5871445788acf96fad2d7da095163c","user":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=3","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"repo":{"id":59151090,"name":"resource","full_name":"ElectricMaxxx/resource","owner":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=3","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElectricMaxxx/resource","description":"CMF Resource Component","fork":true,"url":"https://api.github.com/repos/ElectricMaxxx/resource","forks_url":"https://api.github.com/repos/ElectricMaxxx/resource/forks","keys_url":"https://api.github.com/repos/ElectricMaxxx/resource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElectricMaxxx/resource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElectricMaxxx/resource/teams","hooks_url":"https://api.github.com/repos/ElectricMaxxx/resource/hooks","issue_events_url":"https://api.github.com/repos/ElectricMaxxx/resource/issues/events{/number}","events_url":"https://api.github.com/repos/ElectricMaxxx/resource/events","assignees_url":"https://api.github.com/repos/ElectricMaxxx/resource/assignees{/user}","branches_url":"https://api.github.com/repos/ElectricMaxxx/resource/branches{/branch}","tags_url":"https://api.github.com/repos/ElectricMaxxx/resource/tags","blobs_url":"https://api.github.com/repos/ElectricMaxxx/resource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElectricMaxxx/resource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElectricMaxxx/resource/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElectricMaxxx/resource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElectricMaxxx/resource/statuses/{sha}","languages_url":"https://api.github.com/repos/ElectricMaxxx/resource/languages","stargazers_url":"https://api.github.com/repos/ElectricMaxxx/resource/stargazers","contributors_url":"https://api.github.com/repos/ElectricMaxxx/resource/contributors","subscribers_url":"https://api.github.com/repos/ElectricMaxxx/resource/subscribers","subscription_url":"https://api.github.com/repos/ElectricMaxxx/resource/subscription","commits_url":"https://api.github.com/repos/ElectricMaxxx/resource/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElectricMaxxx/resource/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElectricMaxxx/resource/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElectricMaxxx/resource/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElectricMaxxx/resource/contents/{+path}","compare_url":"https://api.github.com/repos/ElectricMaxxx/resource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElectricMaxxx/resource/merges","archive_url":"https://api.github.com/repos/ElectricMaxxx/resource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElectricMaxxx/resource/downloads","issues_url":"https://api.github.com/repos/ElectricMaxxx/resource/issues{/number}","pulls_url":"https://api.github.com/repos/ElectricMaxxx/resource/pulls{/number}","milestones_url":"https://api.github.com/repos/ElectricMaxxx/resource/milestones{/number}","notifications_url":"https://api.github.com/repos/ElectricMaxxx/resource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElectricMaxxx/resource/labels{/name}","releases_url":"https://api.github.com/repos/ElectricMaxxx/resource/releases{/id}","deployments_url":"https://api.github.com/repos/ElectricMaxxx/resource/deployments","created_at":"2016-05-18T21:03:37Z","updated_at":"2016-05-18T21:03:38Z","pushed_at":"2016-05-20T13:35:40Z","git_url":"git://github.com/ElectricMaxxx/resource.git","ssh_url":"git@github.com:ElectricMaxxx/resource.git","clone_url":"https://github.com/ElectricMaxxx/resource.git","svn_url":"https://github.com/ElectricMaxxx/resource","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"6fac87147d969e8f410d64f5e9766f705382e7ff","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":26994566,"name":"resource","full_name":"symfony-cmf/resource","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/resource","description":"CMF Resource Component","fork":false,"url":"https://api.github.com/repos/symfony-cmf/resource","forks_url":"https://api.github.com/repos/symfony-cmf/resource/forks","keys_url":"https://api.github.com/repos/symfony-cmf/resource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/resource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/resource/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/resource/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/resource/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/resource/events","assignees_url":"https://api.github.com/repos/symfony-cmf/resource/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/resource/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/resource/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/resource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/resource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/resource/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/resource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/resource/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/resource/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/resource/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/resource/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/resource/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/resource/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/resource/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/resource/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/resource/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/resource/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/resource/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/resource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/resource/merges","archive_url":"https://api.github.com/repos/symfony-cmf/resource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/resource/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/resource/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/resource/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/resource/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/resource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/resource/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/resource/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/resource/deployments","created_at":"2014-11-22T09:30:23Z","updated_at":"2016-04-07T08:02:09Z","pushed_at":"2016-05-20T13:35:40Z","git_url":"git://github.com/symfony-cmf/resource.git","ssh_url":"git@github.com:symfony-cmf/resource.git","clone_url":"https://github.com/symfony-cmf/resource.git","svn_url":"https://github.com/symfony-cmf/resource","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/17"},"html":{"href":"https://github.com/symfony-cmf/resource/pull/17"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/resource/issues/17"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/resource/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/resource/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/resource/statuses/05ffedad2f5871445788acf96fad2d7da095163c"}}}}
{"actor":{"display_login":"dantleech"}}