{"action":"opened","number":9871,"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/9871","id":97895577,"html_url":"https://github.com/cakephp/cakephp/pull/9871","diff_url":"https://github.com/cakephp/cakephp/pull/9871.diff","patch_url":"https://github.com/cakephp/cakephp/pull/9871.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/9871","number":9871,"state":"open","locked":false,"title":"Using variadic instead of func_* functions","user":{"login":"jrbasso","id":26548,"avatar_url":"https://avatars.githubusercontent.com/u/26548?v=3","gravatar_id":"","url":"https://api.github.com/users/jrbasso","html_url":"https://github.com/jrbasso","followers_url":"https://api.github.com/users/jrbasso/followers","following_url":"https://api.github.com/users/jrbasso/following{/other_user}","gists_url":"https://api.github.com/users/jrbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbasso/subscriptions","organizations_url":"https://api.github.com/users/jrbasso/orgs","repos_url":"https://api.github.com/users/jrbasso/repos","events_url":"https://api.github.com/users/jrbasso/events{/privacy}","received_events_url":"https://api.github.com/users/jrbasso/received_events","type":"User","site_admin":false},"body":"This PR replace the use of some of the `func_*` functions by the variadic. It reduces the function calls and consequently improves the performance, especially on the `EventManager`, which is very often called.\r\n\r\nThe signature of few methods were changed, so people extending the method can get a strict error from php, but the functionality is the same. I don't think people extend it very often, but I can revert it to the original. These methods are not often called.\r\nPS: The i18n functions won't matter for this BC since they need to be completely redefined instead of extended.","created_at":"2016-12-14T06:40:56Z","updated_at":"2016-12-14T06:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/95","html_url":"https://github.com/cakephp/cakephp/milestone/95","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/95/labels","id":1906253,"number":95,"title":"3.4.0","description":"Backwards compatible features for 3.x. See the [3.4-Roadmap](https://github.com/cakephp/cakephp/wiki/3.4-Roadmap).","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":141,"state":"open","created_at":"2016-07-27T02:20:40Z","updated_at":"2016-12-14T06:40:56Z","due_on":"2016-12-18T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9871/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/9871/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9871/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/825371dae9122a3fbe2478b94035f7539a623db6","head":{"label":"jrbasso:variadic","ref":"variadic","sha":"825371dae9122a3fbe2478b94035f7539a623db6","user":{"login":"jrbasso","id":26548,"avatar_url":"https://avatars.githubusercontent.com/u/26548?v=3","gravatar_id":"","url":"https://api.github.com/users/jrbasso","html_url":"https://github.com/jrbasso","followers_url":"https://api.github.com/users/jrbasso/followers","following_url":"https://api.github.com/users/jrbasso/following{/other_user}","gists_url":"https://api.github.com/users/jrbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbasso/subscriptions","organizations_url":"https://api.github.com/users/jrbasso/orgs","repos_url":"https://api.github.com/users/jrbasso/repos","events_url":"https://api.github.com/users/jrbasso/events{/privacy}","received_events_url":"https://api.github.com/users/jrbasso/received_events","type":"User","site_admin":false},"repo":{"id":657625,"name":"cakephp","full_name":"jrbasso/cakephp","owner":{"login":"jrbasso","id":26548,"avatar_url":"https://avatars.githubusercontent.com/u/26548?v=3","gravatar_id":"","url":"https://api.github.com/users/jrbasso","html_url":"https://github.com/jrbasso","followers_url":"https://api.github.com/users/jrbasso/followers","following_url":"https://api.github.com/users/jrbasso/following{/other_user}","gists_url":"https://api.github.com/users/jrbasso/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbasso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbasso/subscriptions","organizations_url":"https://api.github.com/users/jrbasso/orgs","repos_url":"https://api.github.com/users/jrbasso/repos","events_url":"https://api.github.com/users/jrbasso/events{/privacy}","received_events_url":"https://api.github.com/users/jrbasso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrbasso/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - This is not the official repository, please dont use this!","fork":true,"url":"https://api.github.com/repos/jrbasso/cakephp","forks_url":"https://api.github.com/repos/jrbasso/cakephp/forks","keys_url":"https://api.github.com/repos/jrbasso/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrbasso/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrbasso/cakephp/teams","hooks_url":"https://api.github.com/repos/jrbasso/cakephp/hooks","issue_events_url":"https://api.github.com/repos/jrbasso/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/jrbasso/cakephp/events","assignees_url":"https://api.github.com/repos/jrbasso/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/jrbasso/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/jrbasso/cakephp/tags","blobs_url":"https://api.github.com/repos/jrbasso/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrbasso/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrbasso/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrbasso/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrbasso/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/jrbasso/cakephp/languages","stargazers_url":"https://api.github.com/repos/jrbasso/cakephp/stargazers","contributors_url":"https://api.github.com/repos/jrbasso/cakephp/contributors","subscribers_url":"https://api.github.com/repos/jrbasso/cakephp/subscribers","subscription_url":"https://api.github.com/repos/jrbasso/cakephp/subscription","commits_url":"https://api.github.com/repos/jrbasso/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrbasso/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrbasso/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrbasso/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrbasso/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/jrbasso/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrbasso/cakephp/merges","archive_url":"https://api.github.com/repos/jrbasso/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrbasso/cakephp/downloads","issues_url":"https://api.github.com/repos/jrbasso/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/jrbasso/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/jrbasso/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/jrbasso/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrbasso/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/jrbasso/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/jrbasso/cakephp/deployments","created_at":"2010-05-09T13:35:25Z","updated_at":"2014-05-20T03:00:53Z","pushed_at":"2016-12-14T06:30:18Z","git_url":"git://github.com/jrbasso/cakephp.git","ssh_url":"git@github.com:jrbasso/cakephp.git","clone_url":"https://github.com/jrbasso/cakephp.git","svn_url":"https://github.com/jrbasso/cakephp","homepage":"http://github.com/cakephp/cakephp","size":64966,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"3.0-namespace"}},"base":{"label":"cakephp:3.next","ref":"3.next","sha":"02f8000ed7614615393a0a63ff6109f3cf5a4894","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2016-12-13T10:34:20Z","pushed_at":"2016-12-14T04:09:57Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":67497,"stargazers_count":6828,"watchers_count":6828,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3089,"mirror_url":null,"open_issues_count":183,"forks":3089,"open_issues":183,"watchers":6828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9871"},"html":{"href":"https://github.com/cakephp/cakephp/pull/9871"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9871"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/9871/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9871/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/9871/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/825371dae9122a3fbe2478b94035f7539a623db6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":54,"deletions":85,"changed_files":17}}
{"actor":{"display_login":"jrbasso"}}