{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/14794","repository_url":"https://api.github.com/repos/angular/angular.js","labels_url":"https://api.github.com/repos/angular/angular.js/issues/14794/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/14794/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/14794/events","html_url":"https://github.com/angular/angular.js/pull/14794","id":160754373,"number":14794,"title":"fix(*): do not break when modules are used with `angular-loader`","user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngAnimate","name":"component: ngAnimate","color":"bfdadc"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngMessageFormat","name":"component: ngMessageFormat","color":"0052cc"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngMessages","name":"component: ngMessages","color":"c7def8"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngRoute","name":"component: ngRoute","color":"DDDDDD"},{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20ngSanitize","name":"component: ngSanitize","color":"fef2c0"},{"url":"https://api.github.com/repos/angular/angular.js/labels/frequency:%20low","name":"frequency: low","color":"bfe5bf"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20review","name":"needs: review","color":"eb6420"},{"url":"https://api.github.com/repos/angular/angular.js/labels/severity:%20broken%20expected%20use","name":"severity: broken expected use","color":"fbda00"},{"url":"https://api.github.com/repos/angular/angular.js/labels/type:%20bug","name":"type: bug","color":"000000"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/125","html_url":"https://github.com/angular/angular.js/milestones/1.5.8","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/125/labels","id":1829158,"number":125,"title":"1.5.8","description":"","creator":{"login":"Narretz","id":1153097,"avatar_url":"https://avatars.githubusercontent.com/u/1153097?v=3","gravatar_id":"","url":"https://api.github.com/users/Narretz","html_url":"https://github.com/Narretz","followers_url":"https://api.github.com/users/Narretz/followers","following_url":"https://api.github.com/users/Narretz/following{/other_user}","gists_url":"https://api.github.com/users/Narretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Narretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narretz/subscriptions","organizations_url":"https://api.github.com/users/Narretz/orgs","repos_url":"https://api.github.com/users/Narretz/repos","events_url":"https://api.github.com/users/Narretz/events{/privacy}","received_events_url":"https://api.github.com/users/Narretz/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2016-06-15T13:51:21Z","updated_at":"2016-06-17T09:26:51Z","due_on":"2016-06-28T22:00:00Z","closed_at":null},"comments":6,"created_at":"2016-06-16T20:33:46Z","updated_at":"2016-06-17T10:58:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/14794","html_url":"https://github.com/angular/angular.js/pull/14794","diff_url":"https://github.com/angular/angular.js/pull/14794.diff","patch_url":"https://github.com/angular/angular.js/pull/14794.patch"},"body":"**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nBug fix.\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nWhen using `angular-loader`, you should be able to load the other scripts in any order. Yet, some of the external modules were assuming that `window.angular` would be available as soon as the script was loaded and executed. If the external module file happened to get loaded before the core angular file, things would fall apart.\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nWhen using `angular-loader`, you are be able to load the other scripts in any order.\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] ~~Docs have been added / updated (for bug fixes / features)~~\r\n\r\n**Other information**:\r\n-"},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/226741190","html_url":"https://github.com/angular/angular.js/pull/14794#issuecomment-226741190","issue_url":"https://api.github.com/repos/angular/angular.js/issues/14794","id":226741190,"user":{"login":"gkalpak","id":8604205,"avatar_url":"https://avatars.githubusercontent.com/u/8604205?v=3","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T10:58:52Z","updated_at":"2016-06-17T10:58:52Z","body":"BTW, this would fix #9140."}}
{"actor":{"display_login":"gkalpak"}}