{"action":"closed","number":217,"pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217","id":79856734,"html_url":"https://github.com/ianstormtaylor/slate/pull/217","diff_url":"https://github.com/ianstormtaylor/slate/pull/217.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/217.patch","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/217","number":217,"state":"closed","locked":false,"title":"Drop deprecated `escape` and `unescape`","user":{"login":"w00fz","id":11734,"avatar_url":"https://avatars.githubusercontent.com/u/11734?v=3","gravatar_id":"","url":"https://api.github.com/users/w00fz","html_url":"https://github.com/w00fz","followers_url":"https://api.github.com/users/w00fz/followers","following_url":"https://api.github.com/users/w00fz/following{/other_user}","gists_url":"https://api.github.com/users/w00fz/gists{/gist_id}","starred_url":"https://api.github.com/users/w00fz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w00fz/subscriptions","organizations_url":"https://api.github.com/users/w00fz/orgs","repos_url":"https://api.github.com/users/w00fz/repos","events_url":"https://api.github.com/users/w00fz/events{/privacy}","received_events_url":"https://api.github.com/users/w00fz/received_events","type":"User","site_admin":false},"body":"As the title suggests, it'd be best to drop [`escape`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape) and [`unescape`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/unescape) since they are both deprecated methods that serve no real purpose when in combination with `decodeURIComponent` and `encodeURIComponent`.\r\n\r\nIn addition, a quick [benchmark](https://jsfiddle.net/w00fz/3mgLe6bf/) shows a ~50% boost in speed.","created_at":"2016-08-03T06:57:28Z","updated_at":"2016-08-04T18:20:08Z","closed_at":"2016-08-04T18:20:08Z","merged_at":"2016-08-04T18:20:08Z","merge_commit_sha":"5a92083686044b585cb22660bfee29eff9c3d1d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217/commits","review_comments_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217/comments","review_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/217/comments","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/29dda252cef509e551d51d1c839cd843917b2104","head":{"label":"w00fz:patch-1","ref":"patch-1","sha":"29dda252cef509e551d51d1c839cd843917b2104","user":{"login":"w00fz","id":11734,"avatar_url":"https://avatars.githubusercontent.com/u/11734?v=3","gravatar_id":"","url":"https://api.github.com/users/w00fz","html_url":"https://github.com/w00fz","followers_url":"https://api.github.com/users/w00fz/followers","following_url":"https://api.github.com/users/w00fz/following{/other_user}","gists_url":"https://api.github.com/users/w00fz/gists{/gist_id}","starred_url":"https://api.github.com/users/w00fz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w00fz/subscriptions","organizations_url":"https://api.github.com/users/w00fz/orgs","repos_url":"https://api.github.com/users/w00fz/repos","events_url":"https://api.github.com/users/w00fz/events{/privacy}","received_events_url":"https://api.github.com/users/w00fz/received_events","type":"User","site_admin":false},"repo":{"id":64822660,"name":"slate","full_name":"w00fz/slate","owner":{"login":"w00fz","id":11734,"avatar_url":"https://avatars.githubusercontent.com/u/11734?v=3","gravatar_id":"","url":"https://api.github.com/users/w00fz","html_url":"https://github.com/w00fz","followers_url":"https://api.github.com/users/w00fz/followers","following_url":"https://api.github.com/users/w00fz/following{/other_user}","gists_url":"https://api.github.com/users/w00fz/gists{/gist_id}","starred_url":"https://api.github.com/users/w00fz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w00fz/subscriptions","organizations_url":"https://api.github.com/users/w00fz/orgs","repos_url":"https://api.github.com/users/w00fz/repos","events_url":"https://api.github.com/users/w00fz/events{/privacy}","received_events_url":"https://api.github.com/users/w00fz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/w00fz/slate","description":"A completely customizable framework for building rich text editors.","fork":true,"url":"https://api.github.com/repos/w00fz/slate","forks_url":"https://api.github.com/repos/w00fz/slate/forks","keys_url":"https://api.github.com/repos/w00fz/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w00fz/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w00fz/slate/teams","hooks_url":"https://api.github.com/repos/w00fz/slate/hooks","issue_events_url":"https://api.github.com/repos/w00fz/slate/issues/events{/number}","events_url":"https://api.github.com/repos/w00fz/slate/events","assignees_url":"https://api.github.com/repos/w00fz/slate/assignees{/user}","branches_url":"https://api.github.com/repos/w00fz/slate/branches{/branch}","tags_url":"https://api.github.com/repos/w00fz/slate/tags","blobs_url":"https://api.github.com/repos/w00fz/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w00fz/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w00fz/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/w00fz/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w00fz/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/w00fz/slate/languages","stargazers_url":"https://api.github.com/repos/w00fz/slate/stargazers","contributors_url":"https://api.github.com/repos/w00fz/slate/contributors","subscribers_url":"https://api.github.com/repos/w00fz/slate/subscribers","subscription_url":"https://api.github.com/repos/w00fz/slate/subscription","commits_url":"https://api.github.com/repos/w00fz/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/w00fz/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/w00fz/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/w00fz/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/w00fz/slate/contents/{+path}","compare_url":"https://api.github.com/repos/w00fz/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w00fz/slate/merges","archive_url":"https://api.github.com/repos/w00fz/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w00fz/slate/downloads","issues_url":"https://api.github.com/repos/w00fz/slate/issues{/number}","pulls_url":"https://api.github.com/repos/w00fz/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/w00fz/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/w00fz/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w00fz/slate/labels{/name}","releases_url":"https://api.github.com/repos/w00fz/slate/releases{/id}","deployments_url":"https://api.github.com/repos/w00fz/slate/deployments","created_at":"2016-08-03T06:52:32Z","updated_at":"2016-08-03T06:52:34Z","pushed_at":"2016-08-03T06:53:03Z","git_url":"git://github.com/w00fz/slate.git","ssh_url":"git@github.com:w00fz/slate.git","clone_url":"https://github.com/w00fz/slate.git","svn_url":"https://github.com/w00fz/slate","homepage":"http://slatejs.org","size":17986,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ianstormtaylor:master","ref":"master","sha":"5825db3caa009a2b92332112e1a90f50c2f6bc4f","user":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars.githubusercontent.com/u/311752?v=3","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"repo":{"id":61412022,"name":"slate","full_name":"ianstormtaylor/slate","owner":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars.githubusercontent.com/u/311752?v=3","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianstormtaylor/slate","description":"A completely customizable framework for building rich text editors.","fork":false,"url":"https://api.github.com/repos/ianstormtaylor/slate","forks_url":"https://api.github.com/repos/ianstormtaylor/slate/forks","keys_url":"https://api.github.com/repos/ianstormtaylor/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianstormtaylor/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianstormtaylor/slate/teams","hooks_url":"https://api.github.com/repos/ianstormtaylor/slate/hooks","issue_events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/events{/number}","events_url":"https://api.github.com/repos/ianstormtaylor/slate/events","assignees_url":"https://api.github.com/repos/ianstormtaylor/slate/assignees{/user}","branches_url":"https://api.github.com/repos/ianstormtaylor/slate/branches{/branch}","tags_url":"https://api.github.com/repos/ianstormtaylor/slate/tags","blobs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianstormtaylor/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianstormtaylor/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/ianstormtaylor/slate/languages","stargazers_url":"https://api.github.com/repos/ianstormtaylor/slate/stargazers","contributors_url":"https://api.github.com/repos/ianstormtaylor/slate/contributors","subscribers_url":"https://api.github.com/repos/ianstormtaylor/slate/subscribers","subscription_url":"https://api.github.com/repos/ianstormtaylor/slate/subscription","commits_url":"https://api.github.com/repos/ianstormtaylor/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianstormtaylor/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianstormtaylor/slate/contents/{+path}","compare_url":"https://api.github.com/repos/ianstormtaylor/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianstormtaylor/slate/merges","archive_url":"https://api.github.com/repos/ianstormtaylor/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianstormtaylor/slate/downloads","issues_url":"https://api.github.com/repos/ianstormtaylor/slate/issues{/number}","pulls_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/ianstormtaylor/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/ianstormtaylor/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/labels{/name}","releases_url":"https://api.github.com/repos/ianstormtaylor/slate/releases{/id}","deployments_url":"https://api.github.com/repos/ianstormtaylor/slate/deployments","created_at":"2016-06-18T01:52:42Z","updated_at":"2016-08-04T13:46:12Z","pushed_at":"2016-08-04T18:20:08Z","git_url":"git://github.com/ianstormtaylor/slate.git","ssh_url":"git@github.com:ianstormtaylor/slate.git","clone_url":"https://github.com/ianstormtaylor/slate.git","svn_url":"https://github.com/ianstormtaylor/slate","homepage":"http://slatejs.org","size":18168,"stargazers_count":2134,"watchers_count":2134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":29,"forks":64,"open_issues":29,"watchers":2134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/217"},"issue":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/217"},"comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/ianstormtaylor/slate/statuses/29dda252cef509e551d51d1c839cd843917b2104"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars.githubusercontent.com/u/311752?v=3","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ianstormtaylor"}}