{"action":"created","comment":{"url":"https://api.github.com/repos/google/oauth2client/pulls/comments/58818436","id":58818436,"diff_hunk":"@@ -1862,7 +1863,7 @@ def FromResponse(cls, response):\n         })\n         if 'expires_in' in response:\n             kwargs['user_code_expiry'] = (\n-                datetime.datetime.now() +\n+                _NOW() +","path":"oauth2client/client.py","position":13,"original_position":13,"commit_id":"fffede8cbb9398ee8556de463ebce914e6790801","original_commit_id":"fffede8cbb9398ee8556de463ebce914e6790801","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"@nathanielmanistaatgoogle The device flow code chunks seem to be very haphazard so I'd guess `utcnow` was intended here instead of `now`. What are the implications of us righting this wrong?","created_at":"2016-04-07T04:39:11Z","updated_at":"2016-04-07T04:39:11Z","html_url":"https://github.com/google/oauth2client/pull/485#discussion_r58818436","pull_request_url":"https://api.github.com/repos/google/oauth2client/pulls/485","_links":{"self":{"href":"https://api.github.com/repos/google/oauth2client/pulls/comments/58818436"},"html":{"href":"https://github.com/google/oauth2client/pull/485#discussion_r58818436"},"pull_request":{"href":"https://api.github.com/repos/google/oauth2client/pulls/485"}}},"pull_request":{"url":"https://api.github.com/repos/google/oauth2client/pulls/485","id":65573078,"html_url":"https://github.com/google/oauth2client/pull/485","diff_url":"https://github.com/google/oauth2client/pull/485.diff","patch_url":"https://github.com/google/oauth2client/pull/485.patch","issue_url":"https://api.github.com/repos/google/oauth2client/issues/485","number":485,"state":"open","locked":false,"title":"Adding test coverage for client.py.","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"- `DeviceFlowInfo` (and using datetime now patch).\r\n- Corner cases for `step1_get_authorize_url` and\r\n  `step2_exchange`\r\n- Failure cases for `flow_from_clientsecrets`\r\n- `verify_id_token` when the cached HTTP is used (i.e.\r\n  the default argument)","created_at":"2016-04-07T04:38:21Z","updated_at":"2016-04-07T04:39:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bb083bcbbdb132f4f1fea958163188b1f3867cd","assignee":{"login":"jonparrott","id":250995,"avatar_url":"https://avatars.githubusercontent.com/u/250995?v=3","gravatar_id":"","url":"https://api.github.com/users/jonparrott","html_url":"https://github.com/jonparrott","followers_url":"https://api.github.com/users/jonparrott/followers","following_url":"https://api.github.com/users/jonparrott/following{/other_user}","gists_url":"https://api.github.com/users/jonparrott/gists{/gist_id}","starred_url":"https://api.github.com/users/jonparrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonparrott/subscriptions","organizations_url":"https://api.github.com/users/jonparrott/orgs","repos_url":"https://api.github.com/users/jonparrott/repos","events_url":"https://api.github.com/users/jonparrott/events{/privacy}","received_events_url":"https://api.github.com/users/jonparrott/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/oauth2client/pulls/485/commits","review_comments_url":"https://api.github.com/repos/google/oauth2client/pulls/485/comments","review_comment_url":"https://api.github.com/repos/google/oauth2client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/oauth2client/issues/485/comments","statuses_url":"https://api.github.com/repos/google/oauth2client/statuses/fffede8cbb9398ee8556de463ebce914e6790801","head":{"label":"dhermes:cover-client-v6","ref":"cover-client-v6","sha":"fffede8cbb9398ee8556de463ebce914e6790801","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":20973461,"name":"oauth2client","full_name":"dhermes/oauth2client","owner":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhermes/oauth2client","description":null,"fork":true,"url":"https://api.github.com/repos/dhermes/oauth2client","forks_url":"https://api.github.com/repos/dhermes/oauth2client/forks","keys_url":"https://api.github.com/repos/dhermes/oauth2client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/oauth2client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/oauth2client/teams","hooks_url":"https://api.github.com/repos/dhermes/oauth2client/hooks","issue_events_url":"https://api.github.com/repos/dhermes/oauth2client/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/oauth2client/events","assignees_url":"https://api.github.com/repos/dhermes/oauth2client/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/oauth2client/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/oauth2client/tags","blobs_url":"https://api.github.com/repos/dhermes/oauth2client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/oauth2client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/oauth2client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/oauth2client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/oauth2client/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/oauth2client/languages","stargazers_url":"https://api.github.com/repos/dhermes/oauth2client/stargazers","contributors_url":"https://api.github.com/repos/dhermes/oauth2client/contributors","subscribers_url":"https://api.github.com/repos/dhermes/oauth2client/subscribers","subscription_url":"https://api.github.com/repos/dhermes/oauth2client/subscription","commits_url":"https://api.github.com/repos/dhermes/oauth2client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/oauth2client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/oauth2client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/oauth2client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/oauth2client/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/oauth2client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/oauth2client/merges","archive_url":"https://api.github.com/repos/dhermes/oauth2client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/oauth2client/downloads","issues_url":"https://api.github.com/repos/dhermes/oauth2client/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/oauth2client/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/oauth2client/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/oauth2client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/oauth2client/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/oauth2client/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/oauth2client/deployments","created_at":"2014-06-18T18:34:02Z","updated_at":"2016-01-27T17:38:44Z","pushed_at":"2016-04-07T04:38:10Z","git_url":"git://github.com/dhermes/oauth2client.git","ssh_url":"git@github.com:dhermes/oauth2client.git","clone_url":"https://github.com/dhermes/oauth2client.git","svn_url":"https://github.com/dhermes/oauth2client","homepage":null,"size":20195,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"3ff581077bd54b91410a72204bf9a1bead55f539","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":14211461,"name":"oauth2client","full_name":"google/oauth2client","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oauth2client","description":"This is a Python library for accessing resources protected by OAuth 2.0.","fork":false,"url":"https://api.github.com/repos/google/oauth2client","forks_url":"https://api.github.com/repos/google/oauth2client/forks","keys_url":"https://api.github.com/repos/google/oauth2client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oauth2client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oauth2client/teams","hooks_url":"https://api.github.com/repos/google/oauth2client/hooks","issue_events_url":"https://api.github.com/repos/google/oauth2client/issues/events{/number}","events_url":"https://api.github.com/repos/google/oauth2client/events","assignees_url":"https://api.github.com/repos/google/oauth2client/assignees{/user}","branches_url":"https://api.github.com/repos/google/oauth2client/branches{/branch}","tags_url":"https://api.github.com/repos/google/oauth2client/tags","blobs_url":"https://api.github.com/repos/google/oauth2client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oauth2client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oauth2client/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oauth2client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oauth2client/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oauth2client/languages","stargazers_url":"https://api.github.com/repos/google/oauth2client/stargazers","contributors_url":"https://api.github.com/repos/google/oauth2client/contributors","subscribers_url":"https://api.github.com/repos/google/oauth2client/subscribers","subscription_url":"https://api.github.com/repos/google/oauth2client/subscription","commits_url":"https://api.github.com/repos/google/oauth2client/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oauth2client/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oauth2client/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oauth2client/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oauth2client/contents/{+path}","compare_url":"https://api.github.com/repos/google/oauth2client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oauth2client/merges","archive_url":"https://api.github.com/repos/google/oauth2client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oauth2client/downloads","issues_url":"https://api.github.com/repos/google/oauth2client/issues{/number}","pulls_url":"https://api.github.com/repos/google/oauth2client/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oauth2client/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oauth2client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oauth2client/labels{/name}","releases_url":"https://api.github.com/repos/google/oauth2client/releases{/id}","deployments_url":"https://api.github.com/repos/google/oauth2client/deployments","created_at":"2013-11-07T18:03:04Z","updated_at":"2016-04-07T02:24:41Z","pushed_at":"2016-04-07T04:38:21Z","git_url":"git://github.com/google/oauth2client.git","ssh_url":"git@github.com:google/oauth2client.git","clone_url":"https://github.com/google/oauth2client.git","svn_url":"https://github.com/google/oauth2client","homepage":"","size":24489,"stargazers_count":353,"watchers_count":353,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":182,"mirror_url":null,"open_issues_count":84,"forks":182,"open_issues":84,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/oauth2client/pulls/485"},"html":{"href":"https://github.com/google/oauth2client/pull/485"},"issue":{"href":"https://api.github.com/repos/google/oauth2client/issues/485"},"comments":{"href":"https://api.github.com/repos/google/oauth2client/issues/485/comments"},"review_comments":{"href":"https://api.github.com/repos/google/oauth2client/pulls/485/comments"},"review_comment":{"href":"https://api.github.com/repos/google/oauth2client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/oauth2client/pulls/485/commits"},"statuses":{"href":"https://api.github.com/repos/google/oauth2client/statuses/fffede8cbb9398ee8556de463ebce914e6790801"}}}}