{"action":"created","comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/77946242","id":77946242,"diff_hunk":"@@ -1107,6 +1108,10 @@\n       })), 'sort');\n     }\n \n+    function isSaleItemUnlocked(saleItem) {\n+      return _.every(saleItem.unlockStatuses, function(status) { return status.isSet; });","path":"app/scripts/services/dimStoreService.factory.js","position":13,"original_position":13,"commit_id":"77e15fbb1dfd65f417e83b6452a4ff45f5c30b66","original_commit_id":"77e15fbb1dfd65f417e83b6452a4ff45f5c30b66","user":{"login":"bhollis","id":313208,"avatar_url":"https://avatars.githubusercontent.com/u/313208?v=3","gravatar_id":"","url":"https://api.github.com/users/bhollis","html_url":"https://github.com/bhollis","followers_url":"https://api.github.com/users/bhollis/followers","following_url":"https://api.github.com/users/bhollis/following{/other_user}","gists_url":"https://api.github.com/users/bhollis/gists{/gist_id}","starred_url":"https://api.github.com/users/bhollis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhollis/subscriptions","organizations_url":"https://api.github.com/users/bhollis/orgs","repos_url":"https://api.github.com/users/bhollis/repos","events_url":"https://api.github.com/users/bhollis/events{/privacy}","received_events_url":"https://api.github.com/users/bhollis/received_events","type":"User","site_admin":false},"body":"Fun underscore trick:\r\n\r\n```js\r\nreturn _every(saleItem.unlockStatuses, 'isSet');\r\n```\r\n\r\nNot necessary to actually change it, but thought you might be amused to know about it.","created_at":"2016-09-08T05:02:25Z","updated_at":"2016-09-08T05:02:25Z","html_url":"https://github.com/DestinyItemManager/DIM/pull/862#discussion_r77946242","pull_request_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862","_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/77946242"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/862#discussion_r77946242"},"pull_request":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862"}}},"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862","id":84350066,"html_url":"https://github.com/DestinyItemManager/DIM/pull/862","diff_url":"https://github.com/DestinyItemManager/DIM/pull/862.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/862.patch","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/862","number":862,"state":"open","locked":false,"title":"Update vendors","user":{"login":"ericnelson0","id":4594931,"avatar_url":"https://avatars.githubusercontent.com/u/4594931?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnelson0","html_url":"https://github.com/ericnelson0","followers_url":"https://api.github.com/users/ericnelson0/followers","following_url":"https://api.github.com/users/ericnelson0/following{/other_user}","gists_url":"https://api.github.com/users/ericnelson0/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnelson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnelson0/subscriptions","organizations_url":"https://api.github.com/users/ericnelson0/orgs","repos_url":"https://api.github.com/users/ericnelson0/repos","events_url":"https://api.github.com/users/ericnelson0/events{/privacy}","received_events_url":"https://api.github.com/users/ericnelson0/received_events","type":"User","site_admin":false},"body":"This is PR is an effort to try and make the vendors more general in preparation for ROI. It will use the vendor definitions from the manifest instead of using a hard-coded subset of the vendors. \r\n\r\nThere are also a number of new tabs for different types of items. If the items are locked then they have a gray overlay. I also added the box-shadow back to the sticky header.\r\n\r\n![example-vendor-update](https://cloud.githubusercontent.com/assets/4594931/18323572/d105eb4c-74fd-11e6-9583-aac6e56d2adf.gif)\r\n\r\nI think there are still a couple of things to work on:\r\n- A coherent ordering to the vendors in a tab\r\n- An option for not displaying gear below a specific light\r\n","created_at":"2016-09-07T18:27:13Z","updated_at":"2016-09-08T05:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daed41caeca17b1ab07743888c707785a339c384","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862/commits","review_comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862/comments","review_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/862/comments","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/77e15fbb1dfd65f417e83b6452a4ff45f5c30b66","head":{"label":"ericnelson0:update-vendors","ref":"update-vendors","sha":"77e15fbb1dfd65f417e83b6452a4ff45f5c30b66","user":{"login":"ericnelson0","id":4594931,"avatar_url":"https://avatars.githubusercontent.com/u/4594931?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnelson0","html_url":"https://github.com/ericnelson0","followers_url":"https://api.github.com/users/ericnelson0/followers","following_url":"https://api.github.com/users/ericnelson0/following{/other_user}","gists_url":"https://api.github.com/users/ericnelson0/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnelson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnelson0/subscriptions","organizations_url":"https://api.github.com/users/ericnelson0/orgs","repos_url":"https://api.github.com/users/ericnelson0/repos","events_url":"https://api.github.com/users/ericnelson0/events{/privacy}","received_events_url":"https://api.github.com/users/ericnelson0/received_events","type":"User","site_admin":false},"repo":{"id":58879621,"name":"DIM","full_name":"ericnelson0/DIM","owner":{"login":"ericnelson0","id":4594931,"avatar_url":"https://avatars.githubusercontent.com/u/4594931?v=3","gravatar_id":"","url":"https://api.github.com/users/ericnelson0","html_url":"https://github.com/ericnelson0","followers_url":"https://api.github.com/users/ericnelson0/followers","following_url":"https://api.github.com/users/ericnelson0/following{/other_user}","gists_url":"https://api.github.com/users/ericnelson0/gists{/gist_id}","starred_url":"https://api.github.com/users/ericnelson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericnelson0/subscriptions","organizations_url":"https://api.github.com/users/ericnelson0/orgs","repos_url":"https://api.github.com/users/ericnelson0/repos","events_url":"https://api.github.com/users/ericnelson0/events{/privacy}","received_events_url":"https://api.github.com/users/ericnelson0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericnelson0/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/ericnelson0/DIM","forks_url":"https://api.github.com/repos/ericnelson0/DIM/forks","keys_url":"https://api.github.com/repos/ericnelson0/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericnelson0/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericnelson0/DIM/teams","hooks_url":"https://api.github.com/repos/ericnelson0/DIM/hooks","issue_events_url":"https://api.github.com/repos/ericnelson0/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/ericnelson0/DIM/events","assignees_url":"https://api.github.com/repos/ericnelson0/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/ericnelson0/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/ericnelson0/DIM/tags","blobs_url":"https://api.github.com/repos/ericnelson0/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericnelson0/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericnelson0/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericnelson0/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericnelson0/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/ericnelson0/DIM/languages","stargazers_url":"https://api.github.com/repos/ericnelson0/DIM/stargazers","contributors_url":"https://api.github.com/repos/ericnelson0/DIM/contributors","subscribers_url":"https://api.github.com/repos/ericnelson0/DIM/subscribers","subscription_url":"https://api.github.com/repos/ericnelson0/DIM/subscription","commits_url":"https://api.github.com/repos/ericnelson0/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericnelson0/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericnelson0/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericnelson0/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericnelson0/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/ericnelson0/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericnelson0/DIM/merges","archive_url":"https://api.github.com/repos/ericnelson0/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericnelson0/DIM/downloads","issues_url":"https://api.github.com/repos/ericnelson0/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/ericnelson0/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/ericnelson0/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/ericnelson0/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericnelson0/DIM/labels{/name}","releases_url":"https://api.github.com/repos/ericnelson0/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/ericnelson0/DIM/deployments","created_at":"2016-05-15T19:17:19Z","updated_at":"2016-05-15T19:17:23Z","pushed_at":"2016-09-07T19:01:37Z","git_url":"git://github.com/ericnelson0/DIM.git","ssh_url":"git@github.com:ericnelson0/DIM.git","clone_url":"https://github.com/ericnelson0/DIM.git","svn_url":"https://github.com/ericnelson0/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":243234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DestinyItemManager:dev","ref":"dev","sha":"fb10d435ae6350a8bcc3cb0b238c3cbb682c505e","user":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"repo":{"id":31681575,"name":"DIM","full_name":"DestinyItemManager/DIM","owner":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DestinyItemManager/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/DestinyItemManager/DIM","forks_url":"https://api.github.com/repos/DestinyItemManager/DIM/forks","keys_url":"https://api.github.com/repos/DestinyItemManager/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DestinyItemManager/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DestinyItemManager/DIM/teams","hooks_url":"https://api.github.com/repos/DestinyItemManager/DIM/hooks","issue_events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/events","assignees_url":"https://api.github.com/repos/DestinyItemManager/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/DestinyItemManager/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/tags","blobs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/DestinyItemManager/DIM/languages","stargazers_url":"https://api.github.com/repos/DestinyItemManager/DIM/stargazers","contributors_url":"https://api.github.com/repos/DestinyItemManager/DIM/contributors","subscribers_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscribers","subscription_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscription","commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/DestinyItemManager/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/DestinyItemManager/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DestinyItemManager/DIM/merges","archive_url":"https://api.github.com/repos/DestinyItemManager/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DestinyItemManager/DIM/downloads","issues_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/DestinyItemManager/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/DestinyItemManager/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/labels{/name}","releases_url":"https://api.github.com/repos/DestinyItemManager/DIM/releases{/id}","deployments_url":"https://api.github.com/repos/DestinyItemManager/DIM/deployments","created_at":"2015-03-04T21:46:50Z","updated_at":"2016-09-07T23:20:59Z","pushed_at":"2016-09-08T04:56:56Z","git_url":"git://github.com/DestinyItemManager/DIM.git","ssh_url":"git@github.com:DestinyItemManager/DIM.git","clone_url":"https://github.com/DestinyItemManager/DIM.git","svn_url":"https://github.com/DestinyItemManager/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":252999,"stargazers_count":334,"watchers_count":334,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":94,"forks":161,"open_issues":94,"watchers":334,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/862"},"issue":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/862"},"comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/862/comments"},"review_comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862/comments"},"review_comment":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/862/commits"},"statuses":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/77e15fbb1dfd65f417e83b6452a4ff45f5c30b66"}}}}
{"actor":{"display_login":"bhollis"}}