{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/upta/pubsub/pulls/7","id":50512700,"html_url":"https://github.com/upta/pubsub/pull/7","diff_url":"https://github.com/upta/pubsub/pull/7.diff","patch_url":"https://github.com/upta/pubsub/pull/7.patch","issue_url":"https://api.github.com/repos/upta/pubsub/issues/7","number":7,"state":"closed","locked":false,"title":"Added a Publish() and Subscribe() method onto the Hub class to allow …","user":{"login":"codearoo","id":1846799,"avatar_url":"https://avatars.githubusercontent.com/u/1846799?v=3","gravatar_id":"","url":"https://api.github.com/users/codearoo","html_url":"https://github.com/codearoo","followers_url":"https://api.github.com/users/codearoo/followers","following_url":"https://api.github.com/users/codearoo/following{/other_user}","gists_url":"https://api.github.com/users/codearoo/gists{/gist_id}","starred_url":"https://api.github.com/users/codearoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codearoo/subscriptions","organizations_url":"https://api.github.com/users/codearoo/orgs","repos_url":"https://api.github.com/users/codearoo/repos","events_url":"https://api.github.com/users/codearoo/events{/privacy}","received_events_url":"https://api.github.com/users/codearoo/received_events","type":"User","site_admin":false},"body":"Hi.. I love the simplicity of this project. However I did find a significant bug and need for small change due to the use of the static instance of a Hub in the Extensions class. While it is very handy to use a static instance, in a multi-threaded web environment it typically causes dangers and users might want to limit an instance of a Hub to their current thread. I added the 2 methods to the Hub class to make it possible to directly use that hub.\r\n\r\nI also added some test code to demonstrate the current extension methods for publish which weren't tested at all, as well as the direct use which actually did not work as someone would expect without this fix as far as I can tell.\r\n","created_at":"2015-11-12T13:52:39Z","updated_at":"2016-06-06T15:00:53Z","closed_at":"2016-06-06T15:00:53Z","merged_at":"2016-06-06T15:00:53Z","merge_commit_sha":"192a3417a889a101d0a3f5ce104c3edd85194ed5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/upta/pubsub/pulls/7/commits","review_comments_url":"https://api.github.com/repos/upta/pubsub/pulls/7/comments","review_comment_url":"https://api.github.com/repos/upta/pubsub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/upta/pubsub/issues/7/comments","statuses_url":"https://api.github.com/repos/upta/pubsub/statuses/1ee2a160e89366105f5b8a4e7e26652470a85232","head":{"label":"codearoo:master","ref":"master","sha":"1ee2a160e89366105f5b8a4e7e26652470a85232","user":{"login":"codearoo","id":1846799,"avatar_url":"https://avatars.githubusercontent.com/u/1846799?v=3","gravatar_id":"","url":"https://api.github.com/users/codearoo","html_url":"https://github.com/codearoo","followers_url":"https://api.github.com/users/codearoo/followers","following_url":"https://api.github.com/users/codearoo/following{/other_user}","gists_url":"https://api.github.com/users/codearoo/gists{/gist_id}","starred_url":"https://api.github.com/users/codearoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codearoo/subscriptions","organizations_url":"https://api.github.com/users/codearoo/orgs","repos_url":"https://api.github.com/users/codearoo/repos","events_url":"https://api.github.com/users/codearoo/events{/privacy}","received_events_url":"https://api.github.com/users/codearoo/received_events","type":"User","site_admin":false},"repo":{"id":46053952,"name":"pubsub","full_name":"codearoo/pubsub","owner":{"login":"codearoo","id":1846799,"avatar_url":"https://avatars.githubusercontent.com/u/1846799?v=3","gravatar_id":"","url":"https://api.github.com/users/codearoo","html_url":"https://github.com/codearoo","followers_url":"https://api.github.com/users/codearoo/followers","following_url":"https://api.github.com/users/codearoo/following{/other_user}","gists_url":"https://api.github.com/users/codearoo/gists{/gist_id}","starred_url":"https://api.github.com/users/codearoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codearoo/subscriptions","organizations_url":"https://api.github.com/users/codearoo/orgs","repos_url":"https://api.github.com/users/codearoo/repos","events_url":"https://api.github.com/users/codearoo/events{/privacy}","received_events_url":"https://api.github.com/users/codearoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codearoo/pubsub","description":"An extremely light-weight, easy to use PCL pub/sub library","fork":true,"url":"https://api.github.com/repos/codearoo/pubsub","forks_url":"https://api.github.com/repos/codearoo/pubsub/forks","keys_url":"https://api.github.com/repos/codearoo/pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codearoo/pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codearoo/pubsub/teams","hooks_url":"https://api.github.com/repos/codearoo/pubsub/hooks","issue_events_url":"https://api.github.com/repos/codearoo/pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/codearoo/pubsub/events","assignees_url":"https://api.github.com/repos/codearoo/pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/codearoo/pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/codearoo/pubsub/tags","blobs_url":"https://api.github.com/repos/codearoo/pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codearoo/pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codearoo/pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/codearoo/pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codearoo/pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/codearoo/pubsub/languages","stargazers_url":"https://api.github.com/repos/codearoo/pubsub/stargazers","contributors_url":"https://api.github.com/repos/codearoo/pubsub/contributors","subscribers_url":"https://api.github.com/repos/codearoo/pubsub/subscribers","subscription_url":"https://api.github.com/repos/codearoo/pubsub/subscription","commits_url":"https://api.github.com/repos/codearoo/pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/codearoo/pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/codearoo/pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/codearoo/pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/codearoo/pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/codearoo/pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codearoo/pubsub/merges","archive_url":"https://api.github.com/repos/codearoo/pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codearoo/pubsub/downloads","issues_url":"https://api.github.com/repos/codearoo/pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/codearoo/pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/codearoo/pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/codearoo/pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codearoo/pubsub/labels{/name}","releases_url":"https://api.github.com/repos/codearoo/pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/codearoo/pubsub/deployments","created_at":"2015-11-12T13:17:52Z","updated_at":"2015-11-12T13:17:53Z","pushed_at":"2015-11-12T15:40:17Z","git_url":"git://github.com/codearoo/pubsub.git","ssh_url":"git@github.com:codearoo/pubsub.git","clone_url":"https://github.com/codearoo/pubsub.git","svn_url":"https://github.com/codearoo/pubsub","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"upta:master","ref":"master","sha":"f7eb4871acaa1e8e259cfa6e1838c5e3dd9be102","user":{"login":"upta","id":3310732,"avatar_url":"https://avatars.githubusercontent.com/u/3310732?v=3","gravatar_id":"","url":"https://api.github.com/users/upta","html_url":"https://github.com/upta","followers_url":"https://api.github.com/users/upta/followers","following_url":"https://api.github.com/users/upta/following{/other_user}","gists_url":"https://api.github.com/users/upta/gists{/gist_id}","starred_url":"https://api.github.com/users/upta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upta/subscriptions","organizations_url":"https://api.github.com/users/upta/orgs","repos_url":"https://api.github.com/users/upta/repos","events_url":"https://api.github.com/users/upta/events{/privacy}","received_events_url":"https://api.github.com/users/upta/received_events","type":"User","site_admin":false},"repo":{"id":18809744,"name":"pubsub","full_name":"upta/pubsub","owner":{"login":"upta","id":3310732,"avatar_url":"https://avatars.githubusercontent.com/u/3310732?v=3","gravatar_id":"","url":"https://api.github.com/users/upta","html_url":"https://github.com/upta","followers_url":"https://api.github.com/users/upta/followers","following_url":"https://api.github.com/users/upta/following{/other_user}","gists_url":"https://api.github.com/users/upta/gists{/gist_id}","starred_url":"https://api.github.com/users/upta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upta/subscriptions","organizations_url":"https://api.github.com/users/upta/orgs","repos_url":"https://api.github.com/users/upta/repos","events_url":"https://api.github.com/users/upta/events{/privacy}","received_events_url":"https://api.github.com/users/upta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/upta/pubsub","description":"An extremely light-weight, easy to use PCL pub/sub library","fork":false,"url":"https://api.github.com/repos/upta/pubsub","forks_url":"https://api.github.com/repos/upta/pubsub/forks","keys_url":"https://api.github.com/repos/upta/pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/upta/pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/upta/pubsub/teams","hooks_url":"https://api.github.com/repos/upta/pubsub/hooks","issue_events_url":"https://api.github.com/repos/upta/pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/upta/pubsub/events","assignees_url":"https://api.github.com/repos/upta/pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/upta/pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/upta/pubsub/tags","blobs_url":"https://api.github.com/repos/upta/pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/upta/pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/upta/pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/upta/pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/upta/pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/upta/pubsub/languages","stargazers_url":"https://api.github.com/repos/upta/pubsub/stargazers","contributors_url":"https://api.github.com/repos/upta/pubsub/contributors","subscribers_url":"https://api.github.com/repos/upta/pubsub/subscribers","subscription_url":"https://api.github.com/repos/upta/pubsub/subscription","commits_url":"https://api.github.com/repos/upta/pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/upta/pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/upta/pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/upta/pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/upta/pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/upta/pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/upta/pubsub/merges","archive_url":"https://api.github.com/repos/upta/pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/upta/pubsub/downloads","issues_url":"https://api.github.com/repos/upta/pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/upta/pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/upta/pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/upta/pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/upta/pubsub/labels{/name}","releases_url":"https://api.github.com/repos/upta/pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/upta/pubsub/deployments","created_at":"2014-04-15T17:48:18Z","updated_at":"2016-06-02T12:47:46Z","pushed_at":"2016-06-06T15:00:53Z","git_url":"git://github.com/upta/pubsub.git","ssh_url":"git@github.com:upta/pubsub.git","clone_url":"https://github.com/upta/pubsub.git","svn_url":"https://github.com/upta/pubsub","homepage":null,"size":257,"stargazers_count":39,"watchers_count":39,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":0,"forks":10,"open_issues":0,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/upta/pubsub/pulls/7"},"html":{"href":"https://github.com/upta/pubsub/pull/7"},"issue":{"href":"https://api.github.com/repos/upta/pubsub/issues/7"},"comments":{"href":"https://api.github.com/repos/upta/pubsub/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/upta/pubsub/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/upta/pubsub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/upta/pubsub/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/upta/pubsub/statuses/1ee2a160e89366105f5b8a4e7e26652470a85232"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"upta","id":3310732,"avatar_url":"https://avatars.githubusercontent.com/u/3310732?v=3","gravatar_id":"","url":"https://api.github.com/users/upta","html_url":"https://github.com/upta","followers_url":"https://api.github.com/users/upta/followers","following_url":"https://api.github.com/users/upta/following{/other_user}","gists_url":"https://api.github.com/users/upta/gists{/gist_id}","starred_url":"https://api.github.com/users/upta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upta/subscriptions","organizations_url":"https://api.github.com/users/upta/orgs","repos_url":"https://api.github.com/users/upta/repos","events_url":"https://api.github.com/users/upta/events{/privacy}","received_events_url":"https://api.github.com/users/upta/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":2,"additions":166,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"upta"}}