{"push_id":1338773626,"size":180,"distinct_size":0,"ref":"refs/heads/master","head":"c1a359c7230393f55705d1210c25281eb7740143","before":"59b67efd8a9b37242e2dca10065d6a365aa24454","commits":[{"sha":"8abec085ec0af0319d561e5328fd0ac285c2244f","author":{"name":"Peter McAtominey","email":"aed252c5543fc36c4883edb0ddf7160a8616ddcd@bedegaming.com"},"message":"helper: create validation package to provide common validation functions","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/8abec085ec0af0319d561e5328fd0ac285c2244f"},{"sha":"012fd9825f65b39b2459c2894b351f32f19db068","author":{"name":"Peter McAtominey","email":"aed252c5543fc36c4883edb0ddf7160a8616ddcd@bedegaming.com"},"message":"provider/azurerm: refactor traffic_manager_ resources to use validation helpers\n\nUpdated:\n\ttraffic_manager_profile\n\ttraffic_manager_endpoint","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/012fd9825f65b39b2459c2894b351f32f19db068"},{"sha":"74587baa4ae1d3d7ee7be5c66e635b4a2596c58d","author":{"name":"Steve Hoeksema","email":"5eb4f8ae09d1b5661f1add989b1c3fabe443bd83@kotiri.com"},"message":"Add AWS Billing & Cost Management service account\n\nThis adds a very simple data source for the AWS Billing account ID magic number.\n\nUsed to allow AWS to dump detailed billing reports into an S3 bucket you control.\n\nhttp://docs.aws.amazon.com/awsaccountbilling/latest/aboutv2/billing-getting-started.html#step-2","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/74587baa4ae1d3d7ee7be5c66e635b4a2596c58d"},{"sha":"55ac68e0a2112ecc280a1dcc01c6b741e9bbd4c6","author":{"name":"Steve Hoeksema","email":"5eb4f8ae09d1b5661f1add989b1c3fabe443bd83@kotiri.com"},"message":"Fix formatting","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/55ac68e0a2112ecc280a1dcc01c6b741e9bbd4c6"},{"sha":"e65be3d25634d3f7618d35e30075909c764956ed","author":{"name":"Steve Hoeksema","email":"5eb4f8ae09d1b5661f1add989b1c3fabe443bd83@kotiri.com"},"message":"Format with tabs, add missing comma","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/e65be3d25634d3f7618d35e30075909c764956ed"},{"sha":"0cf330000e661d8f6aa076cc28ee60998405ce00","author":{"name":"Steve Hoeksema","email":"5eb4f8ae09d1b5661f1add989b1c3fabe443bd83@kotiri.com"},"message":"Don't import fmt","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/0cf330000e661d8f6aa076cc28ee60998405ce00"},{"sha":"9217f5a0630ebd3962e0b2b0a4752375e71beb3e","author":{"name":"Justin Marney","email":"6313a9f01f3c33af822afde84fb507c3e152b4c4@gmail.com"},"message":"Unchanged NestedSets are not returned by DiffFieldReader.","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/9217f5a0630ebd3962e0b2b0a4752375e71beb3e"},{"sha":"53e10dfa89b7c6f454f92d910cf5815d33dce411","author":{"name":"Justin Marney","email":"6313a9f01f3c33af822afde84fb507c3e152b4c4@gmail.com"},"message":"Name test appropriately.","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/53e10dfa89b7c6f454f92d910cf5815d33dce411"},{"sha":"895d10a62729722ac1f0fdfb361422a1f554e2df","author":{"name":"Justin Marney","email":"6313a9f01f3c33af822afde84fb507c3e152b4c4@gmail.com"},"message":"Use DeepEqual instead of multiple if statements to reduce noise.","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/895d10a62729722ac1f0fdfb361422a1f554e2df"},{"sha":"475e0f1e6b3916169a6562a094dc181097cbde7c","author":{"name":"James Bardin","email":"5192af46395652008fbc97083f552f06bc32f1c0@gmail.com"},"message":"Fix race on Provisioner.RawConfig\n\nA race when accessing Provisioner.RawConfig can cause unexpected output\nfor provisioners that interpolate variables. Use RawConfig.Copy which\nneeds to acquire the RawConfig mutex to get the values.\n\nFixes #8890","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/475e0f1e6b3916169a6562a094dc181097cbde7c"},{"sha":"3297a460c770a34160f300c773e34cf56d18fc7d","author":{"name":"James Bardin","email":"5192af46395652008fbc97083f552f06bc32f1c0@gmail.com"},"message":"Allow map variables from json\n\nA JSON object will be decoded as a list with a single map value. This\nwill be properly coerced later, so let it through the initial config\nsemantic checks.","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/3297a460c770a34160f300c773e34cf56d18fc7d"},{"sha":"028f96d3735f3974c4964499e90874d6fa09e49c","author":{"name":"Peter McAtominey","email":"aed252c5543fc36c4883edb0ddf7160a8616ddcd@bedegaming.com"},"message":"provider/azurerm: update Azure SDK for go-autorest time parsing fix\n\nazure-sdk-for-go@5dbdd3e002c0c232938bf953a5e7fa9a58ee749e\ngo-autorest@928711bfb9b6bc052ea85a8f4e1d8f4e1bf55f95","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/028f96d3735f3974c4964499e90874d6fa09e49c"},{"sha":"1bc154535f5aeba42d61d7520464dbebc1642556","author":{"name":"DJ Home","email":"b8b96009002be92a0312423b2d281e3fada4f205@sainsburys.co.uk"},"message":"Add ability to import OpsWorks stacks","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/1bc154535f5aeba42d61d7520464dbebc1642556"},{"sha":"979afcecdcce18fa6d96f60c9710704f3372dae3","author":{"name":"DJ Home","email":"b8b96009002be92a0312423b2d281e3fada4f205@sainsburys.co.uk"},"message":"Fix acceptance tests","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/979afcecdcce18fa6d96f60c9710704f3372dae3"},{"sha":"ae2b8d45db0064b5ad7207229b5bf25a50743dbd","author":{"name":"stack72","email":"353f652e6aee6330394c5a6982b37ac14a1a8314@paulstack.co.uk"},"message":"provider/aws: aws_route53_record alias refresh manually updated record\n\nFixes #9108\n\nWhen an aws_route53_record alias is created with terraform and then\nmodified via cli or console, terraform wasn't picking up the changes. I\nhad the following config:\n\n```\nresource \"aws_route53_record\" \"alias\" {\n  zone_id = \"${aws_route53_zone.main.zone_id}\"\n  name = \"www\"\n  type = \"A\"\n\n  alias {\n  \tzone_id = \"${aws_elb.main.zone_id}\"\n  \tname = \"${aws_elb.main.dns_name}\"\n  \tevaluate_target_health = true\n  }\n}\n```\n\nI changed the evaluate_health_target on the AWS console and terraform plan showed me this:\n\n```\n% terraform plan\nRefreshing Terraform state in-memory prior to plan...\nThe refreshed state will be used to calculate this plan, but\nwill not be persisted to local or remote state storage.\n\naws_route53_zone.main: Refreshing state... (ID: Z32Z9B1UPAIP6X)\naws_elb.main: Refreshing state... (ID: foobar-terraform-elb-1111)\naws_route53_record.alias: Refreshing state... (ID: Z32Z9B1UPAIP6X_www_A)\n\nNo changes. Infrastructure is up-to-date. This means that Terraform\ncould not detect any differences between your configuration and\nthe real physical resources that exist. As a result, Terraform\ndoesn't need to do anything.\n```\n\nWhen rebuilding the provider with the changes in the PR, a terraform plan then looks as follows:\n\n```\n% terraform plan\n[WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider.\n  If you did not expect to see this message you will need to remove the old plugin.\n  See https://www.terraform.io/docs/internals/internal-plugins.html\n[WARN] /Users/stacko/Code/go/bin/terraform-provider-azurerm overrides an internal plugin for azurerm-provider.\n  If you did not expect to see this message you will need to remove the old plugin.\n  See https://www.terraform.io/docs/internals/internal-plugins.html\nRefreshing Terraform state in-memory prior to plan...\nThe refreshed state will be used to calculate this plan, but\nwill not be persisted to local or remote state storage.\n\naws_route53_zone.main: Refreshing state... (ID: Z32Z9B1UPAIP6X)\naws_elb.main: Refreshing state... (ID: foobar-terraform-elb-1111)\naws_route53_record.alias: Refreshing state... (ID: Z32Z9B1UPAIP6X_www_A)\n\nThe Terraform execution plan has been generated and is shown below.\nResources are shown in alphabetical order for quick scanning. Green resources\nwill be created (or destroyed and then created if an existing resource\nexists), yellow resources are being changed in-place, and red resources\nwill be destroyed. Cyan entries are data sources to be read.\n\nNote: You didn't specify an \"-out\" parameter to save this plan, so when\n\"apply\" is called, Terraform can't guarantee this is what will execute.\n\n~ aws_route53_record.alias\n    alias.1050468691.evaluate_target_health: \"\" => \"true\"\n    alias.1050468691.name:                   \"\" => \"foobar-terraform-elb-1111-522021794.us-west-2.elb.amazonaws.com\"\n    alias.1050468691.zone_id:                \"\" => \"Z1H1FL5HABSF5\"\n    alias.2906616344.evaluate_target_health: \"false\" => \"false\"\n    alias.2906616344.name:                   \"foobar-terraform-elb-1111-522021794.us-west-2.elb.amazonaws.com.\" => \"\"\n    alias.2906616344.zone_id:                \"Z1H1FL5HABSF5\" => \"\"\n\nPlan: 0 to add, 1 to change, 0 to destroy.\n```\n\nthe apply then changed the target back to true\n\n```\n% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute53Record_'\n==> Checking that code complies with gofmt requirements...\ngo generate $(go list ./... | grep -v /terraform/vendor/)\n2016/09/29 18:17:23 Generated command/internal_plugin_list.go\nTF_ACC=1 go test ./builtin/providers/aws -v\n-run=TestAccAWSRoute53Record_ -timeout 120m\n=== RUN   TestAccAWSRoute53Record_basic\n--- PASS: TestAccAWSRoute53Record_basic (120.63s)\n=== RUN   TestAccAWSRoute53Record_basic_fqdn\n--- PASS: TestAccAWSRoute53Record_basic_fqdn (131.81s)\n=== RUN   TestAccAWSRoute53Record_txtSupport\n--- PASS: TestAccAWSRoute53Record_txtSupport (128.40s)\n=== RUN   TestAccAWSRoute53Record_spfSupport\n--- PASS: TestAccAWSRoute53Record_spfSupport (120.06s)\n=== RUN   TestAccAWSRoute53Record_generatesSuffix\n--- PASS: TestAccAWSRoute53Record_generatesSuffix (114.02s)\n=== RUN   TestAccAWSRoute53Record_wildcard\n--- PASS: TestAccAWSRoute53Record_wildcard (165.54s)\n=== RUN   TestAccAWSRoute53Record_failover\n--- PASS: TestAccAWSRoute53Record_failover (118.10s)\n=== RUN   TestAccAWSRoute53Record_weighted_basic\n--- PASS: TestAccAWSRoute53Record_weighted_basic (128.10s)\n=== RUN   TestAccAWSRoute53Record_alias\n--- PASS: TestAccAWSRoute53Record_alias (132.62s)\n=== RUN   TestAccAWSRoute53Record_s3_alias\n--- PASS: TestAccAWSRoute53Record_s3_alias (132.12s)\n=== RUN   TestAccAWSRoute53Record_weighted_alias\n--- PASS: TestAccAWSRoute53Record_weighted_alias (237.92s)\n=== RUN   TestAccAWSRoute53Record_geolocation_basic\n--- PASS: TestAccAWSRoute53Record_geolocation_basic (121.95s)\n=== RUN   TestAccAWSRoute53Record_latency_basic\n--- PASS: TestAccAWSRoute53Record_latency_basic (123.40s)\n=== RUN   TestAccAWSRoute53Record_TypeChange\n--- PASS: TestAccAWSRoute53Record_TypeChange (198.24s)\n=== RUN   TestAccAWSRoute53Record_empty\n--- PASS: TestAccAWSRoute53Record_empty (119.68s)\nPASS\nok      github.com/hashicorp/terraform/builtin/providers/aws2092.597s\n```","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/ae2b8d45db0064b5ad7207229b5bf25a50743dbd"},{"sha":"73f20ec88dc40862c9345fffc40307d3dbf7f729","author":{"name":"DJ Home","email":"b8b96009002be92a0312423b2d281e3fada4f205@sainsburys.co.uk"},"message":"Revert region to us-west-2 (and set us-west-2 as default region in acceptance test class)","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/73f20ec88dc40862c9345fffc40307d3dbf7f729"},{"sha":"a3ceb25dd700f8bf72f36250b55d6d75f27a2c19","author":{"name":"Jonathan McCall","email":"09028fc2e0d0d6f9939dd32a38eb1aac2d8e6576@hbo.com"},"message":"Skip DetachVolume if volume is not attached","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/a3ceb25dd700f8bf72f36250b55d6d75f27a2c19"},{"sha":"f3deaab87861b9af9d84aba374f81a84bc7a934c","author":{"name":"Jonathan McCall","email":"09028fc2e0d0d6f9939dd32a38eb1aac2d8e6576@hbo.com"},"message":"Remove resource if volume to detach is missing","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/f3deaab87861b9af9d84aba374f81a84bc7a934c"},{"sha":"dc4a7b7d25f56f3ae3e30c889521827de68dfcbd","author":{"name":"Jonathan McCall","email":"09028fc2e0d0d6f9939dd32a38eb1aac2d8e6576@hbo.com"},"message":"Simplify check for already detached volume before destroying","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/dc4a7b7d25f56f3ae3e30c889521827de68dfcbd"},{"sha":"34764c52afe5cea7c066a67f5891073ec8bee613","author":{"name":"dnABic","email":"5dd04f3fa9d04170399db3331de36a36aeac5d8b@localhost"},"message":"mostly typos in documens and aws autoscaling id instead of name","distinct":false,"url":"https://api.github.com/repos/jamtur01/terraform/commits/34764c52afe5cea7c066a67f5891073ec8bee613"}]}
{"actor":{"display_login":"jamtur01"}}