{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12351","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12351/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12351/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12351/events","html_url":"https://github.com/apache/spark/pull/12351","id":147960176,"number":12351,"title":"[SPARK-14593][SQL] Make currentVars work with splitExpressions to enable whole stage codegen for large input columns","user":{"login":"viirya","id":68855,"avatar_url":"https://avatars.githubusercontent.com/u/68855?v=3","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-04-13T06:32:28Z","updated_at":"2016-04-15T04:44:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12351","html_url":"https://github.com/apache/spark/pull/12351","diff_url":"https://github.com/apache/spark/pull/12351.diff","patch_url":"https://github.com/apache/spark/pull/12351.patch"},"body":"## What changes were proposed in this pull request?\r\nJIRA: https://issues.apache.org/jira/browse/SPARK-14593\r\n\r\nWe now disable whole stage codegen if the input column number are too large. If we can make `CodeGenContext.currentVars` work with `CodeGenContext.splitExpressions`. We can enable whole stage codegen for large input columns.\r\n\r\n## How was this patch tested?\r\n\r\nExisting tests.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/210286319","html_url":"https://github.com/apache/spark/pull/12351#issuecomment-210286319","issue_url":"https://api.github.com/repos/apache/spark/issues/12351","id":210286319,"user":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"created_at":"2016-04-15T04:44:53Z","updated_at":"2016-04-15T04:44:53Z","body":"Since we can easily fallback, I'd like not to make it even complicated to support all the corner. Each column require two arguments, java method only support 255 arguments, to make this really works (not hit this limit), it need to be more complicated than current shape.\r\n\r\nWithout a very good reason, I'd not to do this for now."}}