{"action":"created","comment":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/comments/56345792","id":56345792,"diff_hunk":"@@ -292,6 +292,70 @@ char *DetectLoadCompleteSigPath(const DetectEngineCtx *de_ctx, char *sig_file)\n     return path;\n }\n \n+static SigString *SigStringAlloc(void)","path":"src/detect.c","position":4,"original_position":4,"commit_id":"04e8b2203ce707b0dbc115f1b059b8dac6bf8970","original_commit_id":"04e8b2203ce707b0dbc115f1b059b8dac6bf8970","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"body":"Thinking we should maybe put this in a new/different file. Trying to reduce the size of detect.c and this seems more like a util than a core detect feature.","created_at":"2016-03-16T14:46:10Z","updated_at":"2016-03-16T14:46:10Z","html_url":"https://github.com/inliniac/suricata/pull/1853#discussion_r56345792","pull_request_url":"https://api.github.com/repos/inliniac/suricata/pulls/1853","_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments/56345792"},"html":{"href":"https://github.com/inliniac/suricata/pull/1853#discussion_r56345792"},"pull_request":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1853"}}},"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/1853","id":59504367,"html_url":"https://github.com/inliniac/suricata/pull/1853","diff_url":"https://github.com/inliniac/suricata/pull/1853.diff","patch_url":"https://github.com/inliniac/suricata/pull/1853.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/1853","number":1853,"state":"open","locked":false,"title":"Ruleset stats v4","user":{"login":"glongo","id":101933,"avatar_url":"https://avatars.githubusercontent.com/u/101933?v=3","gravatar_id":"","url":"https://api.github.com/users/glongo","html_url":"https://github.com/glongo","followers_url":"https://api.github.com/users/glongo/followers","following_url":"https://api.github.com/users/glongo/following{/other_user}","gists_url":"https://api.github.com/users/glongo/gists{/gist_id}","starred_url":"https://api.github.com/users/glongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glongo/subscriptions","organizations_url":"https://api.github.com/users/glongo/orgs","repos_url":"https://api.github.com/users/glongo/repos","events_url":"https://api.github.com/users/glongo/events{/privacy}","received_events_url":"https://api.github.com/users/glongo/received_events","type":"User","site_admin":false},"body":"A patchset updated that aims at improving information regarding ruleset returned to the user by suricata.\r\n\r\nFirst feature is an update on stats JSON with information added about the ruleset so user can know and monitor how much rules are loaded and failed.\r\n\r\n    \"detect\":{\"engine\":{\"last_reload\":\"2015-10-13T09:59:48.044996+0200\",\"rules_loaded\":17184,\"rules_failed\":0},\"alert\":28}\r\n\r\nOther changes are related to unix socket with some new commands:\r\n\r\n- last-reload\r\n- ruleset-stats: display information about number of loaded and failed rules\r\n- show-failed-rules: display a list of failed rules (dc53401 for more details)\r\n\r\nThis PR also contains a patch implementing a non blocking reload command in unix socket. As we can know with this patchset when reload is done we can also have an asynchronous command.\r\n\r\nThis also provides ruleset information through unix-socket when multi-tenancy is enabled.\r\n\r\nLast PR: https://github.com/inliniac/suricata/pull/1778\r\nTicket: [#1585] (https://redmine.openinfosecfoundation.org/issues/1585)\r\n\r\nPrscript:\r\n- PR glongo: https://buildbot.openinfosecfoundation.org/builders/glongo/builds/97\r\n- PR glongo-pcap: https://buildbot.openinfosecfoundation.org/builders/glongo-pcap/builds/96\r\n","created_at":"2016-02-16T15:14:18Z","updated_at":"2016-03-16T14:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a228662953bf1256874935ecdf4edee657690d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/1853/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/1853/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/1853/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/04e8b2203ce707b0dbc115f1b059b8dac6bf8970","head":{"label":"glongo:ruleset-stats-v4","ref":"ruleset-stats-v4","sha":"04e8b2203ce707b0dbc115f1b059b8dac6bf8970","user":{"login":"glongo","id":101933,"avatar_url":"https://avatars.githubusercontent.com/u/101933?v=3","gravatar_id":"","url":"https://api.github.com/users/glongo","html_url":"https://github.com/glongo","followers_url":"https://api.github.com/users/glongo/followers","following_url":"https://api.github.com/users/glongo/following{/other_user}","gists_url":"https://api.github.com/users/glongo/gists{/gist_id}","starred_url":"https://api.github.com/users/glongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glongo/subscriptions","organizations_url":"https://api.github.com/users/glongo/orgs","repos_url":"https://api.github.com/users/glongo/repos","events_url":"https://api.github.com/users/glongo/events{/privacy}","received_events_url":"https://api.github.com/users/glongo/received_events","type":"User","site_admin":false},"repo":{"id":13040040,"name":"suricata","full_name":"glongo/suricata","owner":{"login":"glongo","id":101933,"avatar_url":"https://avatars.githubusercontent.com/u/101933?v=3","gravatar_id":"","url":"https://api.github.com/users/glongo","html_url":"https://github.com/glongo","followers_url":"https://api.github.com/users/glongo/followers","following_url":"https://api.github.com/users/glongo/following{/other_user}","gists_url":"https://api.github.com/users/glongo/gists{/gist_id}","starred_url":"https://api.github.com/users/glongo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glongo/subscriptions","organizations_url":"https://api.github.com/users/glongo/orgs","repos_url":"https://api.github.com/users/glongo/repos","events_url":"https://api.github.com/users/glongo/events{/privacy}","received_events_url":"https://api.github.com/users/glongo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glongo/suricata","description":"Mirror of the official OISF Suricata git repository","fork":true,"url":"https://api.github.com/repos/glongo/suricata","forks_url":"https://api.github.com/repos/glongo/suricata/forks","keys_url":"https://api.github.com/repos/glongo/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glongo/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glongo/suricata/teams","hooks_url":"https://api.github.com/repos/glongo/suricata/hooks","issue_events_url":"https://api.github.com/repos/glongo/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/glongo/suricata/events","assignees_url":"https://api.github.com/repos/glongo/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/glongo/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/glongo/suricata/tags","blobs_url":"https://api.github.com/repos/glongo/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glongo/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glongo/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/glongo/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glongo/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/glongo/suricata/languages","stargazers_url":"https://api.github.com/repos/glongo/suricata/stargazers","contributors_url":"https://api.github.com/repos/glongo/suricata/contributors","subscribers_url":"https://api.github.com/repos/glongo/suricata/subscribers","subscription_url":"https://api.github.com/repos/glongo/suricata/subscription","commits_url":"https://api.github.com/repos/glongo/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/glongo/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/glongo/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/glongo/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/glongo/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/glongo/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glongo/suricata/merges","archive_url":"https://api.github.com/repos/glongo/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glongo/suricata/downloads","issues_url":"https://api.github.com/repos/glongo/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/glongo/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/glongo/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/glongo/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glongo/suricata/labels{/name}","releases_url":"https://api.github.com/repos/glongo/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/glongo/suricata/deployments","created_at":"2013-09-23T15:52:17Z","updated_at":"2015-05-02T21:15:07Z","pushed_at":"2016-03-15T21:43:02Z","git_url":"git://github.com/glongo/suricata.git","ssh_url":"git@github.com:glongo/suricata.git","clone_url":"https://github.com/glongo/suricata.git","svn_url":"https://github.com/glongo/suricata","homepage":"http://suricata-ids.org/","size":37011,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"0138bf560594b629ce0ab809c48800e938cf728b","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/inliniac/suricata/deployments","created_at":"2012-08-14T08:30:06Z","updated_at":"2016-03-15T23:27:59Z","pushed_at":"2016-03-16T13:31:05Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":57926,"stargazers_count":251,"watchers_count":251,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":236,"mirror_url":null,"open_issues_count":40,"forks":236,"open_issues":40,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1853"},"html":{"href":"https://github.com/inliniac/suricata/pull/1853"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1853"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1853/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1853/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1853/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/04e8b2203ce707b0dbc115f1b059b8dac6bf8970"}}}}