{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/rr/pulls/comments/80023332","id":80023332,"diff_hunk":"@@ -176,7 +176,7 @@ static uint64_t GUARD_VALUE = 0xdeadbeeff00dbaad;\n  */\n inline static void* allocate_guard(size_t size, char value) {\n   char* cp =\n-      (char*)malloc(size + 2 * sizeof(GUARD_VALUE)) + sizeof(GUARD_VALUE);\n+      (char*)xmalloc(size + 2 * sizeof(GUARD_VALUE)) + sizeof(GUARD_VALUE);","path":"src/test/rrutil.h","position":24,"original_position":5,"commit_id":"6a946dfdb2d9c9b20a9ce7546dc8d108b87acd0a","original_commit_id":"c9a0d8486d43d7a76671bc79739604b1c163c530","user":{"login":"tpltnt","id":1172976,"avatar_url":"https://avatars.githubusercontent.com/u/1172976?v=3","gravatar_id":"","url":"https://api.github.com/users/tpltnt","html_url":"https://github.com/tpltnt","followers_url":"https://api.github.com/users/tpltnt/followers","following_url":"https://api.github.com/users/tpltnt/following{/other_user}","gists_url":"https://api.github.com/users/tpltnt/gists{/gist_id}","starred_url":"https://api.github.com/users/tpltnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpltnt/subscriptions","organizations_url":"https://api.github.com/users/tpltnt/orgs","repos_url":"https://api.github.com/users/tpltnt/repos","events_url":"https://api.github.com/users/tpltnt/events{/privacy}","received_events_url":"https://api.github.com/users/tpltnt/received_events","type":"User","site_admin":false},"body":"I copied the xmalloc() implementation to rrutil.h, pretty much at the beginning of the file.","created_at":"2016-09-22T11:47:30Z","updated_at":"2016-09-22T11:47:30Z","html_url":"https://github.com/mozilla/rr/pull/1813#discussion_r80023332","pull_request_url":"https://api.github.com/repos/mozilla/rr/pulls/1813","_links":{"self":{"href":"https://api.github.com/repos/mozilla/rr/pulls/comments/80023332"},"html":{"href":"https://github.com/mozilla/rr/pull/1813#discussion_r80023332"},"pull_request":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1813"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/rr/pulls/1813","id":85865140,"html_url":"https://github.com/mozilla/rr/pull/1813","diff_url":"https://github.com/mozilla/rr/pull/1813.diff","patch_url":"https://github.com/mozilla/rr/pull/1813.patch","issue_url":"https://api.github.com/repos/mozilla/rr/issues/1813","number":1813,"state":"open","locked":false,"title":"Fixing potential null dereferences","user":{"login":"tpltnt","id":1172976,"avatar_url":"https://avatars.githubusercontent.com/u/1172976?v=3","gravatar_id":"","url":"https://api.github.com/users/tpltnt","html_url":"https://github.com/tpltnt","followers_url":"https://api.github.com/users/tpltnt/followers","following_url":"https://api.github.com/users/tpltnt/following{/other_user}","gists_url":"https://api.github.com/users/tpltnt/gists{/gist_id}","starred_url":"https://api.github.com/users/tpltnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpltnt/subscriptions","organizations_url":"https://api.github.com/users/tpltnt/orgs","repos_url":"https://api.github.com/users/tpltnt/repos","events_url":"https://api.github.com/users/tpltnt/events{/privacy}","received_events_url":"https://api.github.com/users/tpltnt/received_events","type":"User","site_admin":false},"body":"Hi there,\r\n\r\nI fixed a few potential NULL pointer dereferences in the way pointed out in #1800.\r\nCheers,\r\ntpltnt","created_at":"2016-09-19T20:39:24Z","updated_at":"2016-09-22T11:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a74ea87044a1275635d64eb043f28ef4d2449622","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/rr/pulls/1813/commits","review_comments_url":"https://api.github.com/repos/mozilla/rr/pulls/1813/comments","review_comment_url":"https://api.github.com/repos/mozilla/rr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/rr/issues/1813/comments","statuses_url":"https://api.github.com/repos/mozilla/rr/statuses/6a946dfdb2d9c9b20a9ce7546dc8d108b87acd0a","head":{"label":"tpltnt:fixing-potential-null-dereferences","ref":"fixing-potential-null-dereferences","sha":"6a946dfdb2d9c9b20a9ce7546dc8d108b87acd0a","user":{"login":"tpltnt","id":1172976,"avatar_url":"https://avatars.githubusercontent.com/u/1172976?v=3","gravatar_id":"","url":"https://api.github.com/users/tpltnt","html_url":"https://github.com/tpltnt","followers_url":"https://api.github.com/users/tpltnt/followers","following_url":"https://api.github.com/users/tpltnt/following{/other_user}","gists_url":"https://api.github.com/users/tpltnt/gists{/gist_id}","starred_url":"https://api.github.com/users/tpltnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpltnt/subscriptions","organizations_url":"https://api.github.com/users/tpltnt/orgs","repos_url":"https://api.github.com/users/tpltnt/repos","events_url":"https://api.github.com/users/tpltnt/events{/privacy}","received_events_url":"https://api.github.com/users/tpltnt/received_events","type":"User","site_admin":false},"repo":{"id":67683949,"name":"rr","full_name":"tpltnt/rr","owner":{"login":"tpltnt","id":1172976,"avatar_url":"https://avatars.githubusercontent.com/u/1172976?v=3","gravatar_id":"","url":"https://api.github.com/users/tpltnt","html_url":"https://github.com/tpltnt","followers_url":"https://api.github.com/users/tpltnt/followers","following_url":"https://api.github.com/users/tpltnt/following{/other_user}","gists_url":"https://api.github.com/users/tpltnt/gists{/gist_id}","starred_url":"https://api.github.com/users/tpltnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpltnt/subscriptions","organizations_url":"https://api.github.com/users/tpltnt/orgs","repos_url":"https://api.github.com/users/tpltnt/repos","events_url":"https://api.github.com/users/tpltnt/events{/privacy}","received_events_url":"https://api.github.com/users/tpltnt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpltnt/rr","description":"Record and Replay Framework","fork":true,"url":"https://api.github.com/repos/tpltnt/rr","forks_url":"https://api.github.com/repos/tpltnt/rr/forks","keys_url":"https://api.github.com/repos/tpltnt/rr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpltnt/rr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpltnt/rr/teams","hooks_url":"https://api.github.com/repos/tpltnt/rr/hooks","issue_events_url":"https://api.github.com/repos/tpltnt/rr/issues/events{/number}","events_url":"https://api.github.com/repos/tpltnt/rr/events","assignees_url":"https://api.github.com/repos/tpltnt/rr/assignees{/user}","branches_url":"https://api.github.com/repos/tpltnt/rr/branches{/branch}","tags_url":"https://api.github.com/repos/tpltnt/rr/tags","blobs_url":"https://api.github.com/repos/tpltnt/rr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpltnt/rr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpltnt/rr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpltnt/rr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpltnt/rr/statuses/{sha}","languages_url":"https://api.github.com/repos/tpltnt/rr/languages","stargazers_url":"https://api.github.com/repos/tpltnt/rr/stargazers","contributors_url":"https://api.github.com/repos/tpltnt/rr/contributors","subscribers_url":"https://api.github.com/repos/tpltnt/rr/subscribers","subscription_url":"https://api.github.com/repos/tpltnt/rr/subscription","commits_url":"https://api.github.com/repos/tpltnt/rr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpltnt/rr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpltnt/rr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpltnt/rr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpltnt/rr/contents/{+path}","compare_url":"https://api.github.com/repos/tpltnt/rr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpltnt/rr/merges","archive_url":"https://api.github.com/repos/tpltnt/rr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpltnt/rr/downloads","issues_url":"https://api.github.com/repos/tpltnt/rr/issues{/number}","pulls_url":"https://api.github.com/repos/tpltnt/rr/pulls{/number}","milestones_url":"https://api.github.com/repos/tpltnt/rr/milestones{/number}","notifications_url":"https://api.github.com/repos/tpltnt/rr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpltnt/rr/labels{/name}","releases_url":"https://api.github.com/repos/tpltnt/rr/releases{/id}","deployments_url":"https://api.github.com/repos/tpltnt/rr/deployments","created_at":"2016-09-08T08:28:13Z","updated_at":"2016-09-08T08:28:15Z","pushed_at":"2016-09-22T08:44:02Z","git_url":"git://github.com/tpltnt/rr.git","ssh_url":"git@github.com:tpltnt/rr.git","clone_url":"https://github.com/tpltnt/rr.git","svn_url":"https://github.com/tpltnt/rr","homepage":"http://rr-project.org/","size":14852,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"87c2491569b50dfd48d3344aa38ceb53f53ea2ee","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2269868,"name":"rr","full_name":"mozilla/rr","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/rr","description":"Record and Replay Framework","fork":false,"url":"https://api.github.com/repos/mozilla/rr","forks_url":"https://api.github.com/repos/mozilla/rr/forks","keys_url":"https://api.github.com/repos/mozilla/rr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/rr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/rr/teams","hooks_url":"https://api.github.com/repos/mozilla/rr/hooks","issue_events_url":"https://api.github.com/repos/mozilla/rr/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/rr/events","assignees_url":"https://api.github.com/repos/mozilla/rr/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/rr/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/rr/tags","blobs_url":"https://api.github.com/repos/mozilla/rr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/rr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/rr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/rr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/rr/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/rr/languages","stargazers_url":"https://api.github.com/repos/mozilla/rr/stargazers","contributors_url":"https://api.github.com/repos/mozilla/rr/contributors","subscribers_url":"https://api.github.com/repos/mozilla/rr/subscribers","subscription_url":"https://api.github.com/repos/mozilla/rr/subscription","commits_url":"https://api.github.com/repos/mozilla/rr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/rr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/rr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/rr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/rr/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/rr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/rr/merges","archive_url":"https://api.github.com/repos/mozilla/rr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/rr/downloads","issues_url":"https://api.github.com/repos/mozilla/rr/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/rr/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/rr/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/rr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/rr/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/rr/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/rr/deployments","created_at":"2011-08-25T18:59:32Z","updated_at":"2016-09-22T03:53:39Z","pushed_at":"2016-09-22T10:47:13Z","git_url":"git://github.com/mozilla/rr.git","ssh_url":"git@github.com:mozilla/rr.git","clone_url":"https://github.com/mozilla/rr.git","svn_url":"https://github.com/mozilla/rr","homepage":"http://rr-project.org/","size":54290,"stargazers_count":1935,"watchers_count":1935,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":167,"mirror_url":null,"open_issues_count":187,"forks":167,"open_issues":187,"watchers":1935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1813"},"html":{"href":"https://github.com/mozilla/rr/pull/1813"},"issue":{"href":"https://api.github.com/repos/mozilla/rr/issues/1813"},"comments":{"href":"https://api.github.com/repos/mozilla/rr/issues/1813/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1813/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/rr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/rr/pulls/1813/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/rr/statuses/6a946dfdb2d9c9b20a9ce7546dc8d108b87acd0a"}}}}
{"actor":{"display_login":"tpltnt"}}