{"action":"created","comment":{"url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/comments/84543863","pull_request_review_id":5318938,"id":84543863,"diff_hunk":"@@ -98,24 +100,24 @@ def main():\n                               m5=[defaults.m5(bandpass)],\n                               seeing=[seeing])\n \n-    # Trim the input catalog to a single chip.\n-    raICRS = phoSimObjectList['ra'].values\n-    decICRS = phoSimObjectList['dec'].values\n-    phoSimObjectList['chipName'] = chipNameFromRaDec(raICRS, decICRS,\n-                                                     camera=camera,\n-                                                     obs_metadata=obs,\n-                                                     epoch=2000.0)\n     # Now further sub-divide the source dataframe into stars and galaxies.\n     if arguments.sensor is not None:\n+        # Trim the input catalog to a single chip.\n+        raICRS = phoSimObjectList['ra'].values\n+        decICRS = phoSimObjectList['dec'].values\n+        phoSimObjectList['chipName'] = chipNameFromRaDec(raICRS, decICRS,\n+                                                         camera=camera,\n+                                                         obs_metadata=obs,\n+                                                         epoch=2000.0)\n         starDataBase = \\\n-            phoSimObjectList.query(\"galSimType == 'pointSource' and magNorm < 50 and chipName=='%s'\" % arguments.sensor)\n+            phoSimObjectList.query(\"galSimType=='pointSource' and magNorm<50 and chipName=='%s'\" % arguments.sensor)","path":"bin/imsim.py","position":54,"original_position":54,"commit_id":"1d68b8931e673dbb30d01c98a5bb28a116dac02e","original_commit_id":"1d68b8931e673dbb30d01c98a5bb28a116dac02e","user":{"login":"sethdigel","id":6035835,"avatar_url":"https://avatars.githubusercontent.com/u/6035835?v=3","gravatar_id":"","url":"https://api.github.com/users/sethdigel","html_url":"https://github.com/sethdigel","followers_url":"https://api.github.com/users/sethdigel/followers","following_url":"https://api.github.com/users/sethdigel/following{/other_user}","gists_url":"https://api.github.com/users/sethdigel/gists{/gist_id}","starred_url":"https://api.github.com/users/sethdigel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethdigel/subscriptions","organizations_url":"https://api.github.com/users/sethdigel/orgs","repos_url":"https://api.github.com/users/sethdigel/repos","events_url":"https://api.github.com/users/sethdigel/events{/privacy}","received_events_url":"https://api.github.com/users/sethdigel/received_events","type":"User","site_admin":false},"body":"In its output summary, phosim lists the numbers of sources and the numbers of photons they generated by magnitude range.  For the Twinkles runs, no source with magnitude > 37 generates any recorded photons, and only ~10 sources that faint or fainter are in the instance catalogs (see, e.g., [this log file](http://srs.slac.stanford.edu/Pipeline-II/exp/LSST-DESC/log.jsp?pi=41888463) for ObsHistID 200.","created_at":"2016-10-21T21:00:49Z","updated_at":"2016-10-21T21:00:49Z","html_url":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4#discussion_r84543863","pull_request_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/comments/84543863"},"html":{"href":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4#discussion_r84543863"},"pull_request":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4","id":89886496,"html_url":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4","diff_url":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4.diff","patch_url":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4.patch","issue_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/4","number":4,"state":"open","locked":false,"title":"set photometric parameters based on instance catalog","user":{"login":"jchiang87","id":1994473,"avatar_url":"https://avatars.githubusercontent.com/u/1994473?v=3","gravatar_id":"","url":"https://api.github.com/users/jchiang87","html_url":"https://github.com/jchiang87","followers_url":"https://api.github.com/users/jchiang87/followers","following_url":"https://api.github.com/users/jchiang87/following{/other_user}","gists_url":"https://api.github.com/users/jchiang87/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiang87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiang87/subscriptions","organizations_url":"https://api.github.com/users/jchiang87/orgs","repos_url":"https://api.github.com/users/jchiang87/repos","events_url":"https://api.github.com/users/jchiang87/events{/privacy}","received_events_url":"https://api.github.com/users/jchiang87/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-18T19:53:15Z","updated_at":"2016-10-21T21:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"801cf1e818c7f0c1cfe73234e901d40210c4f5cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4/commits","review_comments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4/comments","review_comment_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/4/comments","statuses_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/statuses/1d68b8931e673dbb30d01c98a5bb28a116dac02e","head":{"label":"DarkEnergyScienceCollaboration:issue/3/set_photometric_parameters","ref":"issue/3/set_photometric_parameters","sha":"1d68b8931e673dbb30d01c98a5bb28a116dac02e","user":{"login":"DarkEnergyScienceCollaboration","id":2731443,"avatar_url":"https://avatars.githubusercontent.com/u/2731443?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkEnergyScienceCollaboration","html_url":"https://github.com/DarkEnergyScienceCollaboration","followers_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/followers","following_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/following{/other_user}","gists_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/subscriptions","organizations_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/orgs","repos_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/repos","events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":70957320,"name":"imSim","full_name":"DarkEnergyScienceCollaboration/imSim","owner":{"login":"DarkEnergyScienceCollaboration","id":2731443,"avatar_url":"https://avatars.githubusercontent.com/u/2731443?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkEnergyScienceCollaboration","html_url":"https://github.com/DarkEnergyScienceCollaboration","followers_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/followers","following_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/following{/other_user}","gists_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/subscriptions","organizations_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/orgs","repos_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/repos","events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkEnergyScienceCollaboration/imSim","description":"GalSim based LSST simulation package","fork":false,"url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim","forks_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/forks","keys_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/teams","hooks_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/hooks","issue_events_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/events{/number}","events_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/events","assignees_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/assignees{/user}","branches_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/branches{/branch}","tags_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/tags","blobs_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/languages","stargazers_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/stargazers","contributors_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/contributors","subscribers_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/subscribers","subscription_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/subscription","commits_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/contents/{+path}","compare_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/merges","archive_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/downloads","issues_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues{/number}","pulls_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/labels{/name}","releases_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/releases{/id}","deployments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/deployments","created_at":"2016-10-15T00:53:14Z","updated_at":"2016-10-15T00:55:07Z","pushed_at":"2016-10-19T19:49:57Z","git_url":"git://github.com/DarkEnergyScienceCollaboration/imSim.git","ssh_url":"git@github.com:DarkEnergyScienceCollaboration/imSim.git","clone_url":"https://github.com/DarkEnergyScienceCollaboration/imSim.git","svn_url":"https://github.com/DarkEnergyScienceCollaboration/imSim","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"DarkEnergyScienceCollaboration:master","ref":"master","sha":"363e7a7673af95dae4b7d1193ac26af62fbba16a","user":{"login":"DarkEnergyScienceCollaboration","id":2731443,"avatar_url":"https://avatars.githubusercontent.com/u/2731443?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkEnergyScienceCollaboration","html_url":"https://github.com/DarkEnergyScienceCollaboration","followers_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/followers","following_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/following{/other_user}","gists_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/subscriptions","organizations_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/orgs","repos_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/repos","events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":70957320,"name":"imSim","full_name":"DarkEnergyScienceCollaboration/imSim","owner":{"login":"DarkEnergyScienceCollaboration","id":2731443,"avatar_url":"https://avatars.githubusercontent.com/u/2731443?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkEnergyScienceCollaboration","html_url":"https://github.com/DarkEnergyScienceCollaboration","followers_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/followers","following_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/following{/other_user}","gists_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/subscriptions","organizations_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/orgs","repos_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/repos","events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEnergyScienceCollaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkEnergyScienceCollaboration/imSim","description":"GalSim based LSST simulation package","fork":false,"url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim","forks_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/forks","keys_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/teams","hooks_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/hooks","issue_events_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/events{/number}","events_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/events","assignees_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/assignees{/user}","branches_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/branches{/branch}","tags_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/tags","blobs_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/languages","stargazers_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/stargazers","contributors_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/contributors","subscribers_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/subscribers","subscription_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/subscription","commits_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/contents/{+path}","compare_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/merges","archive_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/downloads","issues_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues{/number}","pulls_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/labels{/name}","releases_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/releases{/id}","deployments_url":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/deployments","created_at":"2016-10-15T00:53:14Z","updated_at":"2016-10-15T00:55:07Z","pushed_at":"2016-10-19T19:49:57Z","git_url":"git://github.com/DarkEnergyScienceCollaboration/imSim.git","ssh_url":"git@github.com:DarkEnergyScienceCollaboration/imSim.git","clone_url":"https://github.com/DarkEnergyScienceCollaboration/imSim.git","svn_url":"https://github.com/DarkEnergyScienceCollaboration/imSim","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4"},"html":{"href":"https://github.com/DarkEnergyScienceCollaboration/imSim/pull/4"},"issue":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/4"},"comments":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/DarkEnergyScienceCollaboration/imSim/statuses/1d68b8931e673dbb30d01c98a5bb28a116dac02e"}}}}
{"actor":{"display_login":"sethdigel"}}