{"action":"closed","number":259,"pull_request":{"url":"https://api.github.com/repos/facebook/fbctf/pulls/259","id":87842361,"html_url":"https://github.com/facebook/fbctf/pull/259","diff_url":"https://github.com/facebook/fbctf/pull/259.diff","patch_url":"https://github.com/facebook/fbctf/pull/259.patch","issue_url":"https://api.github.com/repos/facebook/fbctf/issues/259","number":259,"state":"closed","locked":false,"title":"Fix progressive scoreboard and bases","user":{"login":"irqbank","id":19373147,"avatar_url":"https://avatars.githubusercontent.com/u/19373147?v=3","gravatar_id":"","url":"https://api.github.com/users/irqbank","html_url":"https://github.com/irqbank","followers_url":"https://api.github.com/users/irqbank/followers","following_url":"https://api.github.com/users/irqbank/following{/other_user}","gists_url":"https://api.github.com/users/irqbank/gists{/gist_id}","starred_url":"https://api.github.com/users/irqbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irqbank/subscriptions","organizations_url":"https://api.github.com/users/irqbank/orgs","repos_url":"https://api.github.com/users/irqbank/repos","events_url":"https://api.github.com/users/irqbank/events{/privacy}","received_events_url":"https://api.github.com/users/irqbank/received_events","type":"User","site_admin":false},"body":"When a new game is started, `src/models/Progressive.php` starts `scripts/progressive.php` in the background by passing it as a parameter to hhvm from the shell. The file `scripts/progressive.php` includes `autoload.php`, which initiates a chain of inclusions, most of which use `$_SERVER['DOCUMENT_ROOT']` to determine the file path. Since the `$_SERVER` variable is not available when hhvm is called from the shell, the shell command errors out, and the progressive scoreboard doesn't work. The workaround is to manually include the required php files for `scripts/progressive.php` to work.\n\nIt seems to me that this is related to #165. Can anyone please reject my analysis by showing that the progressive scoreboard works for them with the latest code?\n\nNew open issue: the background process is not killed when the game is stopped.\n","created_at":"2016-10-04T07:08:18Z","updated_at":"2016-12-09T01:14:00Z","closed_at":"2016-12-09T01:14:00Z","merged_at":null,"merge_commit_sha":"e8fc5e0b1d82377917c51f0a12829319314b2e45","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/facebook/fbctf/milestones/2","html_url":"https://github.com/facebook/fbctf/milestone/2","labels_url":"https://api.github.com/repos/facebook/fbctf/milestones/2/labels","id":2108087,"number":2,"title":"In Progress ","description":"These are issues in development by the FBCTF team. ","creator":{"login":"juliannagler","id":12618541,"avatar_url":"https://avatars.githubusercontent.com/u/12618541?v=3","gravatar_id":"","url":"https://api.github.com/users/juliannagler","html_url":"https://github.com/juliannagler","followers_url":"https://api.github.com/users/juliannagler/followers","following_url":"https://api.github.com/users/juliannagler/following{/other_user}","gists_url":"https://api.github.com/users/juliannagler/gists{/gist_id}","starred_url":"https://api.github.com/users/juliannagler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliannagler/subscriptions","organizations_url":"https://api.github.com/users/juliannagler/orgs","repos_url":"https://api.github.com/users/juliannagler/repos","events_url":"https://api.github.com/users/juliannagler/events{/privacy}","received_events_url":"https://api.github.com/users/juliannagler/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":2,"state":"open","created_at":"2016-11-01T22:04:43Z","updated_at":"2016-12-09T01:14:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebook/fbctf/pulls/259/commits","review_comments_url":"https://api.github.com/repos/facebook/fbctf/pulls/259/comments","review_comment_url":"https://api.github.com/repos/facebook/fbctf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/fbctf/issues/259/comments","statuses_url":"https://api.github.com/repos/facebook/fbctf/statuses/690a03674eb7542e4c8a1e3ed6d178a916d99c58","head":{"label":"irqbank:master","ref":"master","sha":"690a03674eb7542e4c8a1e3ed6d178a916d99c58","user":{"login":"irqbank","id":19373147,"avatar_url":"https://avatars.githubusercontent.com/u/19373147?v=3","gravatar_id":"","url":"https://api.github.com/users/irqbank","html_url":"https://github.com/irqbank","followers_url":"https://api.github.com/users/irqbank/followers","following_url":"https://api.github.com/users/irqbank/following{/other_user}","gists_url":"https://api.github.com/users/irqbank/gists{/gist_id}","starred_url":"https://api.github.com/users/irqbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irqbank/subscriptions","organizations_url":"https://api.github.com/users/irqbank/orgs","repos_url":"https://api.github.com/users/irqbank/repos","events_url":"https://api.github.com/users/irqbank/events{/privacy}","received_events_url":"https://api.github.com/users/irqbank/received_events","type":"User","site_admin":false},"repo":{"id":69940231,"name":"fbctf","full_name":"irqbank/fbctf","owner":{"login":"irqbank","id":19373147,"avatar_url":"https://avatars.githubusercontent.com/u/19373147?v=3","gravatar_id":"","url":"https://api.github.com/users/irqbank","html_url":"https://github.com/irqbank","followers_url":"https://api.github.com/users/irqbank/followers","following_url":"https://api.github.com/users/irqbank/following{/other_user}","gists_url":"https://api.github.com/users/irqbank/gists{/gist_id}","starred_url":"https://api.github.com/users/irqbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irqbank/subscriptions","organizations_url":"https://api.github.com/users/irqbank/orgs","repos_url":"https://api.github.com/users/irqbank/repos","events_url":"https://api.github.com/users/irqbank/events{/privacy}","received_events_url":"https://api.github.com/users/irqbank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irqbank/fbctf","description":"Platform to host Capture the Flag competitions","fork":true,"url":"https://api.github.com/repos/irqbank/fbctf","forks_url":"https://api.github.com/repos/irqbank/fbctf/forks","keys_url":"https://api.github.com/repos/irqbank/fbctf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irqbank/fbctf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irqbank/fbctf/teams","hooks_url":"https://api.github.com/repos/irqbank/fbctf/hooks","issue_events_url":"https://api.github.com/repos/irqbank/fbctf/issues/events{/number}","events_url":"https://api.github.com/repos/irqbank/fbctf/events","assignees_url":"https://api.github.com/repos/irqbank/fbctf/assignees{/user}","branches_url":"https://api.github.com/repos/irqbank/fbctf/branches{/branch}","tags_url":"https://api.github.com/repos/irqbank/fbctf/tags","blobs_url":"https://api.github.com/repos/irqbank/fbctf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irqbank/fbctf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irqbank/fbctf/git/refs{/sha}","trees_url":"https://api.github.com/repos/irqbank/fbctf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irqbank/fbctf/statuses/{sha}","languages_url":"https://api.github.com/repos/irqbank/fbctf/languages","stargazers_url":"https://api.github.com/repos/irqbank/fbctf/stargazers","contributors_url":"https://api.github.com/repos/irqbank/fbctf/contributors","subscribers_url":"https://api.github.com/repos/irqbank/fbctf/subscribers","subscription_url":"https://api.github.com/repos/irqbank/fbctf/subscription","commits_url":"https://api.github.com/repos/irqbank/fbctf/commits{/sha}","git_commits_url":"https://api.github.com/repos/irqbank/fbctf/git/commits{/sha}","comments_url":"https://api.github.com/repos/irqbank/fbctf/comments{/number}","issue_comment_url":"https://api.github.com/repos/irqbank/fbctf/issues/comments{/number}","contents_url":"https://api.github.com/repos/irqbank/fbctf/contents/{+path}","compare_url":"https://api.github.com/repos/irqbank/fbctf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irqbank/fbctf/merges","archive_url":"https://api.github.com/repos/irqbank/fbctf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irqbank/fbctf/downloads","issues_url":"https://api.github.com/repos/irqbank/fbctf/issues{/number}","pulls_url":"https://api.github.com/repos/irqbank/fbctf/pulls{/number}","milestones_url":"https://api.github.com/repos/irqbank/fbctf/milestones{/number}","notifications_url":"https://api.github.com/repos/irqbank/fbctf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irqbank/fbctf/labels{/name}","releases_url":"https://api.github.com/repos/irqbank/fbctf/releases{/id}","deployments_url":"https://api.github.com/repos/irqbank/fbctf/deployments","created_at":"2016-10-04T06:44:57Z","updated_at":"2016-10-04T06:44:58Z","pushed_at":"2016-10-06T19:35:50Z","git_url":"git://github.com/irqbank/fbctf.git","ssh_url":"git@github.com:irqbank/fbctf.git","clone_url":"https://github.com/irqbank/fbctf.git","svn_url":"https://github.com/irqbank/fbctf","homepage":null,"size":17425,"stargazers_count":0,"watchers_count":0,"language":"Hack","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"13daa4755c8563e79a77a940d19ddd1348871126","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":53877810,"name":"fbctf","full_name":"facebook/fbctf","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/fbctf","description":"Platform to host Capture the Flag competitions","fork":false,"url":"https://api.github.com/repos/facebook/fbctf","forks_url":"https://api.github.com/repos/facebook/fbctf/forks","keys_url":"https://api.github.com/repos/facebook/fbctf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/fbctf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/fbctf/teams","hooks_url":"https://api.github.com/repos/facebook/fbctf/hooks","issue_events_url":"https://api.github.com/repos/facebook/fbctf/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/fbctf/events","assignees_url":"https://api.github.com/repos/facebook/fbctf/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/fbctf/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/fbctf/tags","blobs_url":"https://api.github.com/repos/facebook/fbctf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/fbctf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/fbctf/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/fbctf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/fbctf/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/fbctf/languages","stargazers_url":"https://api.github.com/repos/facebook/fbctf/stargazers","contributors_url":"https://api.github.com/repos/facebook/fbctf/contributors","subscribers_url":"https://api.github.com/repos/facebook/fbctf/subscribers","subscription_url":"https://api.github.com/repos/facebook/fbctf/subscription","commits_url":"https://api.github.com/repos/facebook/fbctf/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/fbctf/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/fbctf/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/fbctf/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/fbctf/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/fbctf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/fbctf/merges","archive_url":"https://api.github.com/repos/facebook/fbctf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/fbctf/downloads","issues_url":"https://api.github.com/repos/facebook/fbctf/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/fbctf/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/fbctf/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/fbctf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/fbctf/labels{/name}","releases_url":"https://api.github.com/repos/facebook/fbctf/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/fbctf/deployments","created_at":"2016-03-14T17:42:04Z","updated_at":"2016-12-07T13:54:54Z","pushed_at":"2016-12-08T19:58:43Z","git_url":"git://github.com/facebook/fbctf.git","ssh_url":"git@github.com:facebook/fbctf.git","clone_url":"https://github.com/facebook/fbctf.git","svn_url":"https://github.com/facebook/fbctf","homepage":null,"size":18078,"stargazers_count":4665,"watchers_count":4665,"language":"Hack","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":885,"mirror_url":null,"open_issues_count":69,"forks":885,"open_issues":69,"watchers":4665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/fbctf/pulls/259"},"html":{"href":"https://github.com/facebook/fbctf/pull/259"},"issue":{"href":"https://api.github.com/repos/facebook/fbctf/issues/259"},"comments":{"href":"https://api.github.com/repos/facebook/fbctf/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/fbctf/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/fbctf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/fbctf/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/fbctf/statuses/690a03674eb7542e4c8a1e3ed6d178a916d99c58"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":2,"additions":12,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"gsingh93"}}