{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7104","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7104/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7104/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7104/events","html_url":"https://github.com/nodejs/node/pull/7104","id":158067210,"number":7104,"title":"repl: refine handling of illegal tokens","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/repl","name":"repl","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-02T06:18:40Z","updated_at":"2016-06-02T07:30:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7104","html_url":"https://github.com/nodejs/node/pull/7104","diff_url":"https://github.com/nodejs/node/pull/7104.diff","patch_url":"https://github.com/nodejs/node/pull/7104.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nRun tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. If possible, include a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\n\r\n##### Description of change\r\n<!-- provide a description of the change below this comment -->\r\n\r\nIllegal tokens are only recoverable in string literals, RegExp literals,\r\nand block comments. If not in one of these constructs, immediately\r\nreturn an error rather than giving the user false hope by giving them a\r\nchance to try to recover.\r\n\r\nFixes: https://github.com/nodejs/node/issues/3611"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/223216702","html_url":"https://github.com/nodejs/node/pull/7104#issuecomment-223216702","issue_url":"https://api.github.com/repos/nodejs/node/issues/7104","id":223216702,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T07:30:53Z","updated_at":"2016-06-02T07:30:53Z","body":"LGTM although checking for ILLEGAL could break when we upgrade V8."}}
{"actor":{"display_login":"bnoordhuis"}}