{"action":"created","issue":{"url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/4036","repository_url":"https://api.github.com/repos/juliocamarero/liferay-portal","labels_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/4036/labels{/name}","comments_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/4036/comments","events_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/4036/events","html_url":"https://github.com/juliocamarero/liferay-portal/pull/4036","id":137608093,"number":4036,"title":"[TECHNICAL-SUPPORT] LPS-63772 Create portletURL with 0 as classTypeId only if it is not p…resent in classTypes","user":{"login":"moltam89","id":1397179,"avatar_url":"https://avatars.githubusercontent.com/u/1397179?v=3","gravatar_id":"","url":"https://api.github.com/users/moltam89","html_url":"https://github.com/moltam89","followers_url":"https://api.github.com/users/moltam89/followers","following_url":"https://api.github.com/users/moltam89/following{/other_user}","gists_url":"https://api.github.com/users/moltam89/gists{/gist_id}","starred_url":"https://api.github.com/users/moltam89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moltam89/subscriptions","organizations_url":"https://api.github.com/users/moltam89/orgs","repos_url":"https://api.github.com/users/moltam89/repos","events_url":"https://api.github.com/users/moltam89/events{/privacy}","received_events_url":"https://api.github.com/users/moltam89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-01T15:41:45Z","updated_at":"2016-03-02T08:22:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/4036","html_url":"https://github.com/juliocamarero/liferay-portal/pull/4036","diff_url":"https://github.com/juliocamarero/liferay-portal/pull/4036.diff","patch_url":"https://github.com/juliocamarero/liferay-portal/pull/4036.patch"},"body":"Hi Julio,\r\n\r\nsorry, it will be a bit longer than usual:\r\n\r\n**1.**\r\nSince [LPS-46103](https://issues.liferay.com/browse/LPS-46103) the classTypes list includes the Basic Document as well, so there is no need to create the default portletURL (currently the Basic Document is listed twice in the Asset Publisher's add dropdown).\r\n\r\nThis problem doesn't affect Journal and DDLRecords, as in **JournalArticle/DDLRecordAssetRendererFactory** classes the **hasAddPermission** methods check whether the classTypeId is 0.\r\nHowever, we can't use this logic for DLFileEntries, as the default  dlFileEntryType for Basic Document is generated with 0 as fileEntryTypeId.\r\n\r\n\r\n**2.**\r\nI found this regression while I was checking the code related to the mentioned LPS-46103. After LPS-46103 it is possible to configure Asset Publisher's portlet to filter by Basic Document.\r\n\r\n**Do you see any problems with backporting LPS-46103 to 6.2.x?**\r\nI'm asking because [LPS-29196](https://issues.liferay.com/browse/LPS-29196) (which was solved in [LPS-45107](https://issues.liferay.com/browse/LPS-45107)) for selecting Basic Document in Asset Publisher's filter was opened as a feature request. \r\nHowever, it focuses on Web Contents (creating the default Web Content structure as a DDMStructure), the dlFileEntryType for Basic Document exists in 6.2 as well and I can't see any problems using it.\r\n\r\nThanks,\r\nTamás\r\n"},"comment":{"url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/comments/191125017","html_url":"https://github.com/juliocamarero/liferay-portal/pull/4036#issuecomment-191125017","issue_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/4036","id":191125017,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T08:22:51Z","updated_at":"2016-03-02T08:22:51Z","body":"<h1>Some tests FAILED!</h1><p>Build Time: 37 minutes 16 seconds</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a><br />Branch GIT ID: <a href=\"https://github.com/liferay/liferay-portal/commit/0348c4968b9c6b340ff6161adab4b7bf35172df4\">0348c4968b9c6b340ff6161adab4b7bf35172df4</a></p><h4>Job Summary:</h4><ul><li><strike><strong><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest(master)/2389/\">test-portal-acceptance-pullrequest(master)</a></strong></strike></li><li><a href=\"https://test-1-19.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/17824/\">test-portal-acceptance-pullrequest-batch(master)/compile-jsp-jdk7</a></li><li><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20510/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-hypersonic20-jdk7/0</a></li><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/32352/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/0</a></li><li><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/32085/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/1</a></li><li><a href=\"https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20077/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/10</a></li><li><a href=\"https://test-1-17.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21773/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/11</a></li><li><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/28905/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/12</a></li><li><a href=\"https://test-1-15.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/24277/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/13</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/28683/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/14</a></li><li><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20249/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/15</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21061/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/16</a></li><li><a href=\"https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/32440/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/17</a></li><li><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20202/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/18</a></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21019/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/19</a></li><li><a href=\"https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/28527/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/2</a></li><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/29238/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/20</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/24278/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/21</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21062/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/22</a></li><li><a href=\"https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20078/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/23</a></li><li><a href=\"https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21916/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/3</a></li><li><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/27846/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/4</a></li><li><a href=\"https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21300/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/5</a></li><li><a href=\"https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/32439/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/6</a></li><li><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20201/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/7</a></li><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/29237/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/8</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/24277/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/9</a></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21020/\">test-portal-acceptance-pullrequest-batch(master)/functional-wildfly10-mariadb100-jdk8/0</a></li><li><a href=\"https://test-1-19.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/17825/\">test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk7</a></li><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/29239/\">test-portal-acceptance-pullrequest-batch(master)/integration-mysql56-jdk7</a></li><li><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20250/\">test-portal-acceptance-pullrequest-batch(master)/integration-postgresql94-jdk7</a></li><li><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20511/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic20-jdk7</a></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21021/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql56-jdk7</a></li><li><strike><strong><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/28684/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql94-jdk7</a></strong></strike></li><li><a href=\"https://test-1-18.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20079/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk7</a></li><li><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20203/\">test-portal-acceptance-pullrequest-batch(master)/plugins-compile-jdk7</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21063/\">test-portal-acceptance-pullrequest-batch(master)/portal-web-jdk7</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/24279/\">test-portal-acceptance-pullrequest-batch(master)/ruby-sass-compiler-jdk7</a></li><li><a href=\"https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/32441/\">test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk7</a></li><li><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20204/\">test-portal-acceptance-pullrequest-batch(master)/tck-jdk7</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/24280/\">test-portal-acceptance-pullrequest-batch(master)/unit-jdk7</a></li><li><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/2359/\">test-portal-acceptance-pullrequest-source(master)</a></li></ul><h5>For more details click <a href=\"https://test-1-1.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/2389/jenkins-report.html\">here</a>.</h5><hr /><h4>Failed Jobs:</h4><ol><li><h5><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest(master)/2389/\">test-portal-acceptance-pullrequest(master)</a></h5><h6>Job Results:</h6><p>40 Jobs Passed.<br />2 Jobs Failed.</p><pre>Completed with the status of FAILURE.</pre></li><li><h5 job-result=\"UNSTABLE\"><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/28684/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql94-jdk7</a></h5><h6>Job Results:</h6><p>4297 Tests Passed.<br />1 Test Failed.</p><ol><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch%28master%29/AXIS_VARIABLE=3,label_exp=!master/28684//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog\">PortalLogAssertorTest.testScanXMLLog</a></li></ol></li></ol>"}}