{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/68280761","id":68280761,"diff_hunk":"@@ -1667,13 +1694,42 @@ SymmetricTensor<rank,dim,Number>::operator [] (const TableIndices<rank> &indices\n \n \n \n+\n+namespace internal\n+{\n+  namespace SymmetricTensor\n+  {\n+    template <int dim, typename Number>\n+    unsigned int\n+    entry_to_indices (const dealii::SymmetricTensor<2,dim,Number> &,","path":"include/deal.II/base/symmetric_tensor.h","position":138,"original_position":138,"commit_id":"8adaf35c6c9f0e97202dd9556ff94440ed0e9ed3","original_commit_id":"8adaf35c6c9f0e97202dd9556ff94440ed0e9ed3","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"But I need overloads for the two different ranks (that also return different types), and I can't do that as you suggest because there is no such thing as a partial specialization of function templates. It really doesn't work without the unused argument (unless I want to enclose the function into a class of its own, because there are partial specializations of class templates; but then I still have to write a separate dispatch class to deal with the different return types). ","created_at":"2016-06-23T17:43:42Z","updated_at":"2016-06-23T17:43:42Z","html_url":"https://github.com/dealii/dealii/pull/2699#discussion_r68280761","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/2699","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/68280761"},"html":{"href":"https://github.com/dealii/dealii/pull/2699#discussion_r68280761"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2699"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2699","id":74993490,"html_url":"https://github.com/dealii/dealii/pull/2699","diff_url":"https://github.com/dealii/dealii/pull/2699.diff","patch_url":"https://github.com/dealii/dealii/pull/2699.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2699","number":2699,"state":"open","locked":false,"title":"Make all functions of SymmetricTensor compile.","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"It turns out that some of the functions of SymmetricTensor did either not compile outright,\ndid not compile for rank==4, or did not compile if the underlying scalar is a complex\nnumber. Make things work.","created_at":"2016-06-23T17:21:35Z","updated_at":"2016-06-23T17:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"557328dde486cdbd1ba9c7dd04e69c1b4a33acce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/2699/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/2699/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2699/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/8adaf35c6c9f0e97202dd9556ff94440ed0e9ed3","head":{"label":"bangerth:make-symmetric-tensor-compile","ref":"make-symmetric-tensor-compile","sha":"8adaf35c6c9f0e97202dd9556ff94440ed0e9ed3","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"repo":{"id":22048720,"name":"dealii","full_name":"bangerth/dealii","owner":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bangerth/dealii","description":"","fork":true,"url":"https://api.github.com/repos/bangerth/dealii","forks_url":"https://api.github.com/repos/bangerth/dealii/forks","keys_url":"https://api.github.com/repos/bangerth/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bangerth/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bangerth/dealii/teams","hooks_url":"https://api.github.com/repos/bangerth/dealii/hooks","issue_events_url":"https://api.github.com/repos/bangerth/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/bangerth/dealii/events","assignees_url":"https://api.github.com/repos/bangerth/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/bangerth/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/bangerth/dealii/tags","blobs_url":"https://api.github.com/repos/bangerth/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bangerth/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bangerth/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/bangerth/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bangerth/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/bangerth/dealii/languages","stargazers_url":"https://api.github.com/repos/bangerth/dealii/stargazers","contributors_url":"https://api.github.com/repos/bangerth/dealii/contributors","subscribers_url":"https://api.github.com/repos/bangerth/dealii/subscribers","subscription_url":"https://api.github.com/repos/bangerth/dealii/subscription","commits_url":"https://api.github.com/repos/bangerth/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/bangerth/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/bangerth/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/bangerth/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/bangerth/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/bangerth/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bangerth/dealii/merges","archive_url":"https://api.github.com/repos/bangerth/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bangerth/dealii/downloads","issues_url":"https://api.github.com/repos/bangerth/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/bangerth/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/bangerth/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/bangerth/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bangerth/dealii/labels{/name}","releases_url":"https://api.github.com/repos/bangerth/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/bangerth/dealii/deployments","created_at":"2014-07-21T02:07:57Z","updated_at":"2016-01-15T17:48:51Z","pushed_at":"2016-06-23T17:24:38Z","git_url":"git://github.com/bangerth/dealii.git","ssh_url":"git@github.com:bangerth/dealii.git","clone_url":"https://github.com/bangerth/dealii.git","svn_url":"https://github.com/bangerth/dealii","homepage":null,"size":140955,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"e2d6d922922f034a40a887b0345f71bf7fae5769","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-06-22T06:42:31Z","pushed_at":"2016-06-23T17:25:27Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":161920,"stargazers_count":153,"watchers_count":153,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":182,"forks":171,"open_issues":182,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2699"},"html":{"href":"https://github.com/dealii/dealii/pull/2699"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/2699"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/2699/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2699/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2699/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/8adaf35c6c9f0e97202dd9556ff94440ed0e9ed3"}}}}
{"actor":{"display_login":"bangerth"}}