{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/jest/issues/780","repository_url":"https://api.github.com/repos/facebook/jest","labels_url":"https://api.github.com/repos/facebook/jest/issues/780/labels{/name}","comments_url":"https://api.github.com/repos/facebook/jest/issues/780/comments","events_url":"https://api.github.com/repos/facebook/jest/issues/780/events","html_url":"https://github.com/facebook/jest/pull/780","id":139402322,"number":780,"title":"[lint] Ignore all node_modules directories in existance","user":{"login":"zpao","id":8445,"avatar_url":"https://avatars.githubusercontent.com/u/8445?v=3","gravatar_id":"","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/jest/labels/CLA%20Signed","name":"CLA Signed","color":"009900"},{"url":"https://api.github.com/repos/facebook/jest/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-08T21:44:30Z","updated_at":"2016-03-08T21:47:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/780","html_url":"https://github.com/facebook/jest/pull/780","diff_url":"https://github.com/facebook/jest/pull/780.diff","patch_url":"https://github.com/facebook/jest/pull/780.patch"},"body":"The problem was that the ignore patterns we had weren't right when passed to `glob`. This meant that `glob` was returning thousands of files it shouldn't have which eslint was then checking again and finally ignoring there.\r\n\r\nWe don't ever want to lint anything in any `node_modules` directory so just ignore all of them all the time.\r\n\r\nAfter a simple `npm install` inside `examples/async` this brought be down from 17s back to what I had before that install, ~5s."},"comment":{"url":"https://api.github.com/repos/facebook/jest/issues/comments/193981711","html_url":"https://github.com/facebook/jest/pull/780#issuecomment-193981711","issue_url":"https://api.github.com/repos/facebook/jest/issues/780","id":193981711,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T21:47:21Z","updated_at":"2016-03-08T21:47:21Z","body":"Thanks for importing. If you are an FB employee go to [Phabricator](https://our.intern.facebook.com/intern/opensource/github/pull_request/101703140226255/int_phab) to review."}}