{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/comments/70843689","id":70843689,"diff_hunk":"@@ -136,6 +187,9 @@ public String getExternalDelete() {\n     }\n \n     private boolean shouldCleanBuildBasedOnState(Result result) {\n+        if (result == null)\n+            // in case of Pipeline, the result may be null\n+            return true;","path":"src/main/java/hudson/plugins/ws_cleanup/WsCleanup.java","position":149,"original_position":149,"commit_id":"748c9ed09d70c63dfdeae8557338d62b2701c551","original_commit_id":"748c9ed09d70c63dfdeae8557338d62b2701c551","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"Good practice is to use brackets even for single-line conditions","created_at":"2016-07-14T17:06:49Z","updated_at":"2016-07-14T17:06:49Z","html_url":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27#discussion_r70843689","pull_request_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/comments/70843689"},"html":{"href":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27#discussion_r70843689"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27","id":76654010,"html_url":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27","diff_url":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27.diff","patch_url":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27.patch","issue_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/27","number":27,"state":"open","locked":false,"title":"[JENKINS-28454] Pipeline compatibility","user":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"body":"Related to issue [[JENKINS-28454]](https://issues.jenkins-ci.org/browse/JENKINS-28454)\r\n\r\nSummary of this pull request:\r\n- [x] Update POM to prepare for Pipeline integration\r\n- [x] Implement `SimpleBuildStep`\r\n- [x] Fix failing test\r\n- [x] Fix FindBugs warnings\r\n- [x] Write Pipeline smoke test\r\n- [x] Use `@DataBoundSetter` to minimize *Snippet Generator* output","created_at":"2016-07-07T19:46:35Z","updated_at":"2016-07-14T17:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9269cc93e62d749e20bcc5953a04aee1a7f5fba0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/27/comments","statuses_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/statuses/748c9ed09d70c63dfdeae8557338d62b2701c551","head":{"label":"alexsomai:Pipeline-JENKINS-28454","ref":"Pipeline-JENKINS-28454","sha":"748c9ed09d70c63dfdeae8557338d62b2701c551","user":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"repo":{"id":62830994,"name":"ws-cleanup-plugin","full_name":"alexsomai/ws-cleanup-plugin","owner":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexsomai/ws-cleanup-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin","forks_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/forks","keys_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/teams","hooks_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/hooks","issue_events_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/events","assignees_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/tags","blobs_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/languages","stargazers_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/stargazers","contributors_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/contributors","subscribers_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/subscribers","subscription_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/subscription","commits_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/merges","archive_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/downloads","issues_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/labels{/name}","releases_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/alexsomai/ws-cleanup-plugin/deployments","created_at":"2016-07-07T18:53:36Z","updated_at":"2016-07-07T18:53:37Z","pushed_at":"2016-07-10T12:00:35Z","git_url":"git://github.com/alexsomai/ws-cleanup-plugin.git","ssh_url":"git@github.com:alexsomai/ws-cleanup-plugin.git","clone_url":"https://github.com/alexsomai/ws-cleanup-plugin.git","svn_url":"https://github.com/alexsomai/ws-cleanup-plugin","homepage":"","size":150,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"4ea0d3d7776d9b11c3da1247088649c05e80150c","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1350114,"name":"ws-cleanup-plugin","full_name":"jenkinsci/ws-cleanup-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/ws-cleanup-plugin","description":"","fork":true,"url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin","forks_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/deployments","created_at":"2011-02-10T10:03:00Z","updated_at":"2016-07-09T12:04:32Z","pushed_at":"2016-07-14T14:21:40Z","git_url":"git://github.com/jenkinsci/ws-cleanup-plugin.git","ssh_url":"git@github.com:jenkinsci/ws-cleanup-plugin.git","clone_url":"https://github.com/jenkinsci/ws-cleanup-plugin.git","svn_url":"https://github.com/jenkinsci/ws-cleanup-plugin","homepage":"","size":210,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":3,"forks":26,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27"},"html":{"href":"https://github.com/jenkinsci/ws-cleanup-plugin/pull/27"},"issue":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/27"},"comments":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/ws-cleanup-plugin/statuses/748c9ed09d70c63dfdeae8557338d62b2701c551"}}}}
{"actor":{"display_login":"oleg-nenashev"}}