{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2","id":61977041,"html_url":"https://github.com/jvandemo/angular-consent/pull/2","diff_url":"https://github.com/jvandemo/angular-consent/pull/2.diff","patch_url":"https://github.com/jvandemo/angular-consent/pull/2.patch","issue_url":"https://api.github.com/repos/jvandemo/angular-consent/issues/2","number":2,"state":"closed","locked":false,"title":"Support for ngCookies < 1.4.x","user":{"login":"accraze","id":989447,"avatar_url":"https://avatars.githubusercontent.com/u/989447?v=3","gravatar_id":"","url":"https://api.github.com/users/accraze","html_url":"https://github.com/accraze","followers_url":"https://api.github.com/users/accraze/followers","following_url":"https://api.github.com/users/accraze/following{/other_user}","gists_url":"https://api.github.com/users/accraze/gists{/gist_id}","starred_url":"https://api.github.com/users/accraze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accraze/subscriptions","organizations_url":"https://api.github.com/users/accraze/orgs","repos_url":"https://api.github.com/users/accraze/repos","events_url":"https://api.github.com/users/accraze/events{/privacy}","received_events_url":"https://api.github.com/users/accraze/received_events","type":"User","site_admin":false},"body":"This PR contains an enhancement to the cookie getter and setter methods in the controller.\r\n\r\nThere was a breaking API change in `ngCookies` from Angular `1.3.x` to `1.4x`, which will result in throwing a `TypeError` if anyone using this is on Angular < 1.4\r\nhttp://stackoverflow.com/questions/28971126/angular-and-cookies-cookies-get-is-not-a-function\r\n\r\nIn your `bower.json` the project's dev dependencies say `\"angular\": \">=1.2.0\"`, so it should be able to handle both versions of `ngCookies`.\r\n\r\nMy solution checks for `TypeError` and then uses the older API syntax to get/set cookies.\r\n","created_at":"2016-03-07T20:41:40Z","updated_at":"2016-09-18T06:46:06Z","closed_at":"2016-09-18T06:46:06Z","merged_at":"2016-09-18T06:46:06Z","merge_commit_sha":"6b134ffedd7499a731d3ec78e3dd53b59ddbec84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jvandemo/angular-consent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jvandemo/angular-consent/issues/2/comments","statuses_url":"https://api.github.com/repos/jvandemo/angular-consent/statuses/940829b3b33ae0f8a9b780533da06284d985c7b6","head":{"label":"accraze:cookies-1.3.x","ref":"cookies-1.3.x","sha":"940829b3b33ae0f8a9b780533da06284d985c7b6","user":{"login":"accraze","id":989447,"avatar_url":"https://avatars.githubusercontent.com/u/989447?v=3","gravatar_id":"","url":"https://api.github.com/users/accraze","html_url":"https://github.com/accraze","followers_url":"https://api.github.com/users/accraze/followers","following_url":"https://api.github.com/users/accraze/following{/other_user}","gists_url":"https://api.github.com/users/accraze/gists{/gist_id}","starred_url":"https://api.github.com/users/accraze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accraze/subscriptions","organizations_url":"https://api.github.com/users/accraze/orgs","repos_url":"https://api.github.com/users/accraze/repos","events_url":"https://api.github.com/users/accraze/events{/privacy}","received_events_url":"https://api.github.com/users/accraze/received_events","type":"User","site_admin":false},"repo":{"id":53354742,"name":"angular-consent","full_name":"accraze/angular-consent","owner":{"login":"accraze","id":989447,"avatar_url":"https://avatars.githubusercontent.com/u/989447?v=3","gravatar_id":"","url":"https://api.github.com/users/accraze","html_url":"https://github.com/accraze","followers_url":"https://api.github.com/users/accraze/followers","following_url":"https://api.github.com/users/accraze/following{/other_user}","gists_url":"https://api.github.com/users/accraze/gists{/gist_id}","starred_url":"https://api.github.com/users/accraze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accraze/subscriptions","organizations_url":"https://api.github.com/users/accraze/orgs","repos_url":"https://api.github.com/users/accraze/repos","events_url":"https://api.github.com/users/accraze/events{/privacy}","received_events_url":"https://api.github.com/users/accraze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/accraze/angular-consent","description":"Easily show consent messages that keep appearing until the user clicks them away.","fork":true,"url":"https://api.github.com/repos/accraze/angular-consent","forks_url":"https://api.github.com/repos/accraze/angular-consent/forks","keys_url":"https://api.github.com/repos/accraze/angular-consent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/accraze/angular-consent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/accraze/angular-consent/teams","hooks_url":"https://api.github.com/repos/accraze/angular-consent/hooks","issue_events_url":"https://api.github.com/repos/accraze/angular-consent/issues/events{/number}","events_url":"https://api.github.com/repos/accraze/angular-consent/events","assignees_url":"https://api.github.com/repos/accraze/angular-consent/assignees{/user}","branches_url":"https://api.github.com/repos/accraze/angular-consent/branches{/branch}","tags_url":"https://api.github.com/repos/accraze/angular-consent/tags","blobs_url":"https://api.github.com/repos/accraze/angular-consent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/accraze/angular-consent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/accraze/angular-consent/git/refs{/sha}","trees_url":"https://api.github.com/repos/accraze/angular-consent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/accraze/angular-consent/statuses/{sha}","languages_url":"https://api.github.com/repos/accraze/angular-consent/languages","stargazers_url":"https://api.github.com/repos/accraze/angular-consent/stargazers","contributors_url":"https://api.github.com/repos/accraze/angular-consent/contributors","subscribers_url":"https://api.github.com/repos/accraze/angular-consent/subscribers","subscription_url":"https://api.github.com/repos/accraze/angular-consent/subscription","commits_url":"https://api.github.com/repos/accraze/angular-consent/commits{/sha}","git_commits_url":"https://api.github.com/repos/accraze/angular-consent/git/commits{/sha}","comments_url":"https://api.github.com/repos/accraze/angular-consent/comments{/number}","issue_comment_url":"https://api.github.com/repos/accraze/angular-consent/issues/comments{/number}","contents_url":"https://api.github.com/repos/accraze/angular-consent/contents/{+path}","compare_url":"https://api.github.com/repos/accraze/angular-consent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/accraze/angular-consent/merges","archive_url":"https://api.github.com/repos/accraze/angular-consent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/accraze/angular-consent/downloads","issues_url":"https://api.github.com/repos/accraze/angular-consent/issues{/number}","pulls_url":"https://api.github.com/repos/accraze/angular-consent/pulls{/number}","milestones_url":"https://api.github.com/repos/accraze/angular-consent/milestones{/number}","notifications_url":"https://api.github.com/repos/accraze/angular-consent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/accraze/angular-consent/labels{/name}","releases_url":"https://api.github.com/repos/accraze/angular-consent/releases{/id}","deployments_url":"https://api.github.com/repos/accraze/angular-consent/deployments","created_at":"2016-03-07T19:58:09Z","updated_at":"2016-03-07T19:58:10Z","pushed_at":"2016-09-13T02:45:20Z","git_url":"git://github.com/accraze/angular-consent.git","ssh_url":"git@github.com:accraze/angular-consent.git","clone_url":"https://github.com/accraze/angular-consent.git","svn_url":"https://github.com/accraze/angular-consent","homepage":"http://angular-consent-demo.surge.sh/","size":19,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jvandemo:development","ref":"development","sha":"4764aa9412bcdb59918dac21202f7528b5a3bc1d","user":{"login":"jvandemo","id":1859381,"avatar_url":"https://avatars.githubusercontent.com/u/1859381?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandemo","html_url":"https://github.com/jvandemo","followers_url":"https://api.github.com/users/jvandemo/followers","following_url":"https://api.github.com/users/jvandemo/following{/other_user}","gists_url":"https://api.github.com/users/jvandemo/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandemo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandemo/subscriptions","organizations_url":"https://api.github.com/users/jvandemo/orgs","repos_url":"https://api.github.com/users/jvandemo/repos","events_url":"https://api.github.com/users/jvandemo/events{/privacy}","received_events_url":"https://api.github.com/users/jvandemo/received_events","type":"User","site_admin":false},"repo":{"id":41504007,"name":"angular-consent","full_name":"jvandemo/angular-consent","owner":{"login":"jvandemo","id":1859381,"avatar_url":"https://avatars.githubusercontent.com/u/1859381?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandemo","html_url":"https://github.com/jvandemo","followers_url":"https://api.github.com/users/jvandemo/followers","following_url":"https://api.github.com/users/jvandemo/following{/other_user}","gists_url":"https://api.github.com/users/jvandemo/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandemo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandemo/subscriptions","organizations_url":"https://api.github.com/users/jvandemo/orgs","repos_url":"https://api.github.com/users/jvandemo/repos","events_url":"https://api.github.com/users/jvandemo/events{/privacy}","received_events_url":"https://api.github.com/users/jvandemo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvandemo/angular-consent","description":"Easily show consent messages that keep appearing until the user clicks them away.","fork":false,"url":"https://api.github.com/repos/jvandemo/angular-consent","forks_url":"https://api.github.com/repos/jvandemo/angular-consent/forks","keys_url":"https://api.github.com/repos/jvandemo/angular-consent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvandemo/angular-consent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvandemo/angular-consent/teams","hooks_url":"https://api.github.com/repos/jvandemo/angular-consent/hooks","issue_events_url":"https://api.github.com/repos/jvandemo/angular-consent/issues/events{/number}","events_url":"https://api.github.com/repos/jvandemo/angular-consent/events","assignees_url":"https://api.github.com/repos/jvandemo/angular-consent/assignees{/user}","branches_url":"https://api.github.com/repos/jvandemo/angular-consent/branches{/branch}","tags_url":"https://api.github.com/repos/jvandemo/angular-consent/tags","blobs_url":"https://api.github.com/repos/jvandemo/angular-consent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvandemo/angular-consent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvandemo/angular-consent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvandemo/angular-consent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvandemo/angular-consent/statuses/{sha}","languages_url":"https://api.github.com/repos/jvandemo/angular-consent/languages","stargazers_url":"https://api.github.com/repos/jvandemo/angular-consent/stargazers","contributors_url":"https://api.github.com/repos/jvandemo/angular-consent/contributors","subscribers_url":"https://api.github.com/repos/jvandemo/angular-consent/subscribers","subscription_url":"https://api.github.com/repos/jvandemo/angular-consent/subscription","commits_url":"https://api.github.com/repos/jvandemo/angular-consent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvandemo/angular-consent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvandemo/angular-consent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvandemo/angular-consent/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvandemo/angular-consent/contents/{+path}","compare_url":"https://api.github.com/repos/jvandemo/angular-consent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvandemo/angular-consent/merges","archive_url":"https://api.github.com/repos/jvandemo/angular-consent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvandemo/angular-consent/downloads","issues_url":"https://api.github.com/repos/jvandemo/angular-consent/issues{/number}","pulls_url":"https://api.github.com/repos/jvandemo/angular-consent/pulls{/number}","milestones_url":"https://api.github.com/repos/jvandemo/angular-consent/milestones{/number}","notifications_url":"https://api.github.com/repos/jvandemo/angular-consent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvandemo/angular-consent/labels{/name}","releases_url":"https://api.github.com/repos/jvandemo/angular-consent/releases{/id}","deployments_url":"https://api.github.com/repos/jvandemo/angular-consent/deployments","created_at":"2015-08-27T18:26:20Z","updated_at":"2016-08-30T21:34:41Z","pushed_at":"2016-09-18T06:46:06Z","git_url":"git://github.com/jvandemo/angular-consent.git","ssh_url":"git@github.com:jvandemo/angular-consent.git","clone_url":"https://github.com/jvandemo/angular-consent.git","svn_url":"https://github.com/jvandemo/angular-consent","homepage":"http://angular-consent-demo.surge.sh/","size":16,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2"},"html":{"href":"https://github.com/jvandemo/angular-consent/pull/2"},"issue":{"href":"https://api.github.com/repos/jvandemo/angular-consent/issues/2"},"comments":{"href":"https://api.github.com/repos/jvandemo/angular-consent/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jvandemo/angular-consent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jvandemo/angular-consent/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jvandemo/angular-consent/statuses/940829b3b33ae0f8a9b780533da06284d985c7b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jvandemo","id":1859381,"avatar_url":"https://avatars.githubusercontent.com/u/1859381?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandemo","html_url":"https://github.com/jvandemo","followers_url":"https://api.github.com/users/jvandemo/followers","following_url":"https://api.github.com/users/jvandemo/following{/other_user}","gists_url":"https://api.github.com/users/jvandemo/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandemo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandemo/subscriptions","organizations_url":"https://api.github.com/users/jvandemo/orgs","repos_url":"https://api.github.com/users/jvandemo/repos","events_url":"https://api.github.com/users/jvandemo/events{/privacy}","received_events_url":"https://api.github.com/users/jvandemo/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":21,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jvandemo"}}