{"action":"opened","issue":{"url":"https://api.github.com/repos/modxcms/revolution/issues/12919","repository_url":"https://api.github.com/repos/modxcms/revolution","labels_url":"https://api.github.com/repos/modxcms/revolution/issues/12919/labels{/name}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12919/comments","events_url":"https://api.github.com/repos/modxcms/revolution/issues/12919/events","html_url":"https://github.com/modxcms/revolution/issues/12919","id":135857051,"number":12919,"title":"mail_smtp_user & emailsender settings editing is broken","user":{"login":"kasthack","id":1292818,"avatar_url":"https://avatars.githubusercontent.com/u/1292818?v=3","gravatar_id":"","url":"https://api.github.com/users/kasthack","html_url":"https://github.com/kasthack","followers_url":"https://api.github.com/users/kasthack/followers","following_url":"https://api.github.com/users/kasthack/following{/other_user}","gists_url":"https://api.github.com/users/kasthack/gists{/gist_id}","starred_url":"https://api.github.com/users/kasthack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasthack/subscriptions","organizations_url":"https://api.github.com/users/kasthack/orgs","repos_url":"https://api.github.com/users/kasthack/repos","events_url":"https://api.github.com/users/kasthack/events{/privacy}","received_events_url":"https://api.github.com/users/kasthack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-23T20:38:40Z","updated_at":"2016-02-23T20:38:40Z","closed_at":null,"body":"### Summary\r\nmail_smtp_user and emailsender are not checked to be valid email addresses and leading/trailing spaces are not trimmed.\r\n\r\n### Step to reproduce\r\n1. Go to system settings page.\r\n2. Set emailsender and/or mail_smtp_user to ' <valid_mail_login>'.\r\n3. Logout and try to recover password with email.\r\n\r\n### Observed behavior\r\n1. Value is saved and used as-is.\r\n2. Error message about bad smtp login/pass.\r\n\r\n### Expected behavior\r\n1. emailsender/mail_smtp_user should be trimmed and/or checked to be valid email addresses.\r\n\r\n### Environment\r\nApache/2.4.7 (Ubuntu) PHP/5.5.9-1ubuntu4.14\r\nPHP extension: mysqliDocumentation curlDocumentation mbstringDocumentation\r\nPHP version: 5.5.9-1ubuntu4.14\r\nMODX: 2.43-pl"}}