{"action":"created","comment":{"url":"https://api.github.com/repos/opentx/opentx/pulls/comments/75922327","id":75922327,"diff_hunk":"@@ -1235,6 +1266,23 @@ void audioEvent(unsigned int index)\n   }\n }\n \n+#if defined(SDCARD)\n+void pushUnit(uint8_t unit, uint8_t idx, uint8_t id=0)\n+{\n+  if (unit < DIM(unitsFilenames) && idx < 5)\n+  {\n+    char path[AUDIO_FILENAME_MAXLEN+1];\n+    getSystemAudioPath(path);\n+    getStringWithIndex(path, unitsFilenames[unit], (int)idx);","path":"radio/src/audio_arm.cpp","position":49,"original_position":49,"commit_id":"756d951ff943ac226d29c04e6586c06f533e2b8d","original_commit_id":"756d951ff943ac226d29c04e6586c06f533e2b8d","user":{"login":"bsongis","id":5603504,"avatar_url":"https://avatars.githubusercontent.com/u/5603504?v=3","gravatar_id":"","url":"https://api.github.com/users/bsongis","html_url":"https://github.com/bsongis","followers_url":"https://api.github.com/users/bsongis/followers","following_url":"https://api.github.com/users/bsongis/following{/other_user}","gists_url":"https://api.github.com/users/bsongis/gists{/gist_id}","starred_url":"https://api.github.com/users/bsongis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsongis/subscriptions","organizations_url":"https://api.github.com/users/bsongis/orgs","repos_url":"https://api.github.com/users/bsongis/repos","events_url":"https://api.github.com/users/bsongis/events{/privacy}","received_events_url":"https://api.github.com/users/bsongis/received_events","type":"User","site_admin":false},"body":"no need to cast idx","created_at":"2016-08-23T18:19:06Z","updated_at":"2016-08-23T18:19:06Z","html_url":"https://github.com/opentx/opentx/pull/3716#discussion_r75922327","pull_request_url":"https://api.github.com/repos/opentx/opentx/pulls/3716","_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments/75922327"},"html":{"href":"https://github.com/opentx/opentx/pull/3716#discussion_r75922327"},"pull_request":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3716"}}},"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/3716","id":82412650,"html_url":"https://github.com/opentx/opentx/pull/3716","diff_url":"https://github.com/opentx/opentx/pull/3716.diff","patch_url":"https://github.com/opentx/opentx/pull/3716.patch","issue_url":"https://api.github.com/repos/opentx/opentx/issues/3716","number":3716,"state":"open","locked":false,"title":"Change ARM targets sound file handling for UNITS table","user":{"login":"3djc","id":5167938,"avatar_url":"https://avatars.githubusercontent.com/u/5167938?v=3","gravatar_id":"","url":"https://api.github.com/users/3djc","html_url":"https://github.com/3djc","followers_url":"https://api.github.com/users/3djc/followers","following_url":"https://api.github.com/users/3djc/following{/other_user}","gists_url":"https://api.github.com/users/3djc/gists{/gist_id}","starred_url":"https://api.github.com/users/3djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3djc/subscriptions","organizations_url":"https://api.github.com/users/3djc/orgs","repos_url":"https://api.github.com/users/3djc/repos","events_url":"https://api.github.com/users/3djc/events{/privacy}","received_events_url":"https://api.github.com/users/3djc/received_events","type":"User","site_admin":false},"body":"Change audio generation files accordingly\r\nNew way of working :\r\n- units files are ALWAYS named in english based on the names in audio_arm.cpp names.\r\n- multiple form (singular, plural(s) are ammended with 0 to 4 suffix, according to languages rules.\r\nexample : meter1.wav for first form of plural of meter unit,. This filename needs to be the same for all languages (in their respective directories of course)","created_at":"2016-08-23T18:04:08Z","updated_at":"2016-08-23T18:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a249ec4493a016c6eb00e0c1b2663c883c62760","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentx/opentx/pulls/3716/commits","review_comments_url":"https://api.github.com/repos/opentx/opentx/pulls/3716/comments","review_comment_url":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/3716/comments","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/756d951ff943ac226d29c04e6586c06f533e2b8d","head":{"label":"opentx:ARM-Units-soundfiles","ref":"ARM-Units-soundfiles","sha":"756d951ff943ac226d29c04e6586c06f533e2b8d","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2016-08-23T10:33:09Z","pushed_at":"2016-08-23T18:08:16Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":149978,"stargazers_count":429,"watchers_count":429,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":449,"forks":257,"open_issues":449,"watchers":429,"default_branch":"master"}},"base":{"label":"opentx:next","ref":"next","sha":"f34de72e25253d8a946b136e067317abbe577ca7","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2016-08-23T10:33:09Z","pushed_at":"2016-08-23T18:08:16Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":149978,"stargazers_count":429,"watchers_count":429,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":449,"forks":257,"open_issues":449,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3716"},"html":{"href":"https://github.com/opentx/opentx/pull/3716"},"issue":{"href":"https://api.github.com/repos/opentx/opentx/issues/3716"},"comments":{"href":"https://api.github.com/repos/opentx/opentx/issues/3716/comments"},"review_comments":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3716/comments"},"review_comment":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3716/commits"},"statuses":{"href":"https://api.github.com/repos/opentx/opentx/statuses/756d951ff943ac226d29c04e6586c06f533e2b8d"}}}}
{"actor":{"display_login":"bsongis"}}