{"action":"created","comment":{"url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/comments/81413065","pull_request_review_id":2397501,"id":81413065,"diff_hunk":"@@ -996,46 +996,46 @@ void fsm_msgGetAddress(GetAddress *msg)\n \n void fsm_msgEthereumGetAddress(EthereumGetAddress *msg)\n {\n-\tRESP_INIT(EthereumAddress);\n+    RESP_INIT(EthereumAddress);\n \n-        if (!storage_is_initialized()) {\n-\t\tfsm_sendFailure(FailureType_Failure_NotInitialized, \"Device not initialized\");\n-\t\treturn;\n-\t}\n+    if (!storage_is_initialized()) {\n+        fsm_sendFailure(FailureType_Failure_NotInitialized, \"Device not initialized\");\n+        return;\n+    }\n \n-        if(!pin_protect(\"Enter Current PIN\"))\n-        {\n-                go_home();\n-\t\treturn;\n-\t}\n+    if (!pin_protect_cached()) {","path":"keepkey/local/baremetal/fsm.c","position":57,"original_position":57,"commit_id":"f8b4e11d1ecd9cad68495858012f852d0ed26795","original_commit_id":"f8b4e11d1ecd9cad68495858012f852d0ed26795","user":{"login":"bgok","id":514334,"avatar_url":"https://avatars.githubusercontent.com/u/514334?v=3","gravatar_id":"","url":"https://api.github.com/users/bgok","html_url":"https://github.com/bgok","followers_url":"https://api.github.com/users/bgok/followers","following_url":"https://api.github.com/users/bgok/following{/other_user}","gists_url":"https://api.github.com/users/bgok/gists{/gist_id}","starred_url":"https://api.github.com/users/bgok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgok/subscriptions","organizations_url":"https://api.github.com/users/bgok/orgs","repos_url":"https://api.github.com/users/bgok/repos","events_url":"https://api.github.com/users/bgok/events{/privacy}","received_events_url":"https://api.github.com/users/bgok/received_events","type":"User","site_admin":false},"body":"This is the line that changed. The rest of the changes in this file are formatting difference. Sorry about that.","created_at":"2016-09-30T20:34:31Z","updated_at":"2016-09-30T20:34:31Z","html_url":"https://github.com/keepkey/keepkey-firmware/pull/11#discussion_r81413065","pull_request_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/comments/81413065"},"html":{"href":"https://github.com/keepkey/keepkey-firmware/pull/11#discussion_r81413065"},"pull_request":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11","id":87555507,"html_url":"https://github.com/keepkey/keepkey-firmware/pull/11","diff_url":"https://github.com/keepkey/keepkey-firmware/pull/11.diff","patch_url":"https://github.com/keepkey/keepkey-firmware/pull/11.patch","issue_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/11","number":11,"state":"open","locked":false,"title":"Minor Ethereum Updates","user":{"login":"bgok","id":514334,"avatar_url":"https://avatars.githubusercontent.com/u/514334?v=3","gravatar_id":"","url":"https://api.github.com/users/bgok","html_url":"https://github.com/bgok","followers_url":"https://api.github.com/users/bgok/followers","following_url":"https://api.github.com/users/bgok/following{/other_user}","gists_url":"https://api.github.com/users/bgok/gists{/gist_id}","starred_url":"https://api.github.com/users/bgok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgok/subscriptions","organizations_url":"https://api.github.com/users/bgok/orgs","repos_url":"https://api.github.com/users/bgok/repos","events_url":"https://api.github.com/users/bgok/events{/privacy}","received_events_url":"https://api.github.com/users/bgok/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-30T19:50:46Z","updated_at":"2016-09-30T20:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08edf7f8fb22e6dcbb18a07d26067849c3c73198","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11/commits","review_comments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11/comments","review_comment_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/11/comments","statuses_url":"https://api.github.com/repos/keepkey/keepkey-firmware/statuses/f8b4e11d1ecd9cad68495858012f852d0ed26795","head":{"label":"keepkey:ethereum-coin-types","ref":"ethereum-coin-types","sha":"f8b4e11d1ecd9cad68495858012f852d0ed26795","user":{"login":"keepkey","id":8077335,"avatar_url":"https://avatars.githubusercontent.com/u/8077335?v=3","gravatar_id":"","url":"https://api.github.com/users/keepkey","html_url":"https://github.com/keepkey","followers_url":"https://api.github.com/users/keepkey/followers","following_url":"https://api.github.com/users/keepkey/following{/other_user}","gists_url":"https://api.github.com/users/keepkey/gists{/gist_id}","starred_url":"https://api.github.com/users/keepkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepkey/subscriptions","organizations_url":"https://api.github.com/users/keepkey/orgs","repos_url":"https://api.github.com/users/keepkey/repos","events_url":"https://api.github.com/users/keepkey/events{/privacy}","received_events_url":"https://api.github.com/users/keepkey/received_events","type":"Organization","site_admin":false},"repo":{"id":39457329,"name":"keepkey-firmware","full_name":"keepkey/keepkey-firmware","owner":{"login":"keepkey","id":8077335,"avatar_url":"https://avatars.githubusercontent.com/u/8077335?v=3","gravatar_id":"","url":"https://api.github.com/users/keepkey","html_url":"https://github.com/keepkey","followers_url":"https://api.github.com/users/keepkey/followers","following_url":"https://api.github.com/users/keepkey/following{/other_user}","gists_url":"https://api.github.com/users/keepkey/gists{/gist_id}","starred_url":"https://api.github.com/users/keepkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepkey/subscriptions","organizations_url":"https://api.github.com/users/keepkey/orgs","repos_url":"https://api.github.com/users/keepkey/repos","events_url":"https://api.github.com/users/keepkey/events{/privacy}","received_events_url":"https://api.github.com/users/keepkey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepkey/keepkey-firmware","description":"KeepKey Device Firmware","fork":false,"url":"https://api.github.com/repos/keepkey/keepkey-firmware","forks_url":"https://api.github.com/repos/keepkey/keepkey-firmware/forks","keys_url":"https://api.github.com/repos/keepkey/keepkey-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepkey/keepkey-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepkey/keepkey-firmware/teams","hooks_url":"https://api.github.com/repos/keepkey/keepkey-firmware/hooks","issue_events_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/keepkey/keepkey-firmware/events","assignees_url":"https://api.github.com/repos/keepkey/keepkey-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/keepkey/keepkey-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/keepkey/keepkey-firmware/tags","blobs_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepkey/keepkey-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/keepkey/keepkey-firmware/languages","stargazers_url":"https://api.github.com/repos/keepkey/keepkey-firmware/stargazers","contributors_url":"https://api.github.com/repos/keepkey/keepkey-firmware/contributors","subscribers_url":"https://api.github.com/repos/keepkey/keepkey-firmware/subscribers","subscription_url":"https://api.github.com/repos/keepkey/keepkey-firmware/subscription","commits_url":"https://api.github.com/repos/keepkey/keepkey-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepkey/keepkey-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/keepkey/keepkey-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepkey/keepkey-firmware/merges","archive_url":"https://api.github.com/repos/keepkey/keepkey-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepkey/keepkey-firmware/downloads","issues_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/keepkey/keepkey-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/keepkey/keepkey-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepkey/keepkey-firmware/labels{/name}","releases_url":"https://api.github.com/repos/keepkey/keepkey-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/deployments","created_at":"2015-07-21T16:37:45Z","updated_at":"2016-07-22T23:46:09Z","pushed_at":"2016-09-30T20:31:14Z","git_url":"git://github.com/keepkey/keepkey-firmware.git","ssh_url":"git@github.com:keepkey/keepkey-firmware.git","clone_url":"https://github.com/keepkey/keepkey-firmware.git","svn_url":"https://github.com/keepkey/keepkey-firmware","homepage":null,"size":34794,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":17,"default_branch":"master"}},"base":{"label":"keepkey:ethereum-integration","ref":"ethereum-integration","sha":"415ba3ea95710055038c05bb85347709e657104f","user":{"login":"keepkey","id":8077335,"avatar_url":"https://avatars.githubusercontent.com/u/8077335?v=3","gravatar_id":"","url":"https://api.github.com/users/keepkey","html_url":"https://github.com/keepkey","followers_url":"https://api.github.com/users/keepkey/followers","following_url":"https://api.github.com/users/keepkey/following{/other_user}","gists_url":"https://api.github.com/users/keepkey/gists{/gist_id}","starred_url":"https://api.github.com/users/keepkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepkey/subscriptions","organizations_url":"https://api.github.com/users/keepkey/orgs","repos_url":"https://api.github.com/users/keepkey/repos","events_url":"https://api.github.com/users/keepkey/events{/privacy}","received_events_url":"https://api.github.com/users/keepkey/received_events","type":"Organization","site_admin":false},"repo":{"id":39457329,"name":"keepkey-firmware","full_name":"keepkey/keepkey-firmware","owner":{"login":"keepkey","id":8077335,"avatar_url":"https://avatars.githubusercontent.com/u/8077335?v=3","gravatar_id":"","url":"https://api.github.com/users/keepkey","html_url":"https://github.com/keepkey","followers_url":"https://api.github.com/users/keepkey/followers","following_url":"https://api.github.com/users/keepkey/following{/other_user}","gists_url":"https://api.github.com/users/keepkey/gists{/gist_id}","starred_url":"https://api.github.com/users/keepkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepkey/subscriptions","organizations_url":"https://api.github.com/users/keepkey/orgs","repos_url":"https://api.github.com/users/keepkey/repos","events_url":"https://api.github.com/users/keepkey/events{/privacy}","received_events_url":"https://api.github.com/users/keepkey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepkey/keepkey-firmware","description":"KeepKey Device Firmware","fork":false,"url":"https://api.github.com/repos/keepkey/keepkey-firmware","forks_url":"https://api.github.com/repos/keepkey/keepkey-firmware/forks","keys_url":"https://api.github.com/repos/keepkey/keepkey-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepkey/keepkey-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepkey/keepkey-firmware/teams","hooks_url":"https://api.github.com/repos/keepkey/keepkey-firmware/hooks","issue_events_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/keepkey/keepkey-firmware/events","assignees_url":"https://api.github.com/repos/keepkey/keepkey-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/keepkey/keepkey-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/keepkey/keepkey-firmware/tags","blobs_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepkey/keepkey-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/keepkey/keepkey-firmware/languages","stargazers_url":"https://api.github.com/repos/keepkey/keepkey-firmware/stargazers","contributors_url":"https://api.github.com/repos/keepkey/keepkey-firmware/contributors","subscribers_url":"https://api.github.com/repos/keepkey/keepkey-firmware/subscribers","subscription_url":"https://api.github.com/repos/keepkey/keepkey-firmware/subscription","commits_url":"https://api.github.com/repos/keepkey/keepkey-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepkey/keepkey-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepkey/keepkey-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/keepkey/keepkey-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepkey/keepkey-firmware/merges","archive_url":"https://api.github.com/repos/keepkey/keepkey-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepkey/keepkey-firmware/downloads","issues_url":"https://api.github.com/repos/keepkey/keepkey-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/keepkey/keepkey-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/keepkey/keepkey-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepkey/keepkey-firmware/labels{/name}","releases_url":"https://api.github.com/repos/keepkey/keepkey-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/keepkey/keepkey-firmware/deployments","created_at":"2015-07-21T16:37:45Z","updated_at":"2016-07-22T23:46:09Z","pushed_at":"2016-09-30T20:31:14Z","git_url":"git://github.com/keepkey/keepkey-firmware.git","ssh_url":"git@github.com:keepkey/keepkey-firmware.git","clone_url":"https://github.com/keepkey/keepkey-firmware.git","svn_url":"https://github.com/keepkey/keepkey-firmware","homepage":null,"size":34794,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11"},"html":{"href":"https://github.com/keepkey/keepkey-firmware/pull/11"},"issue":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/11"},"comments":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/keepkey/keepkey-firmware/statuses/f8b4e11d1ecd9cad68495858012f852d0ed26795"}}}}
{"actor":{"display_login":"bgok"}}