{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/comments/61230604","id":61230604,"diff_hunk":"@@ -38,6 +38,7 @@ Filesystem.do_mount() and Filesystem.do_mount_text(). No other functions\n should have that naming schema.\n \n When variables or values with an underscores in the name are written to XML\n-the underscores have to be replaced by dashed. So e.g. size_k is saved as\n-<size-k>18</size-k>. In the logs the names should follow the same convention.\n+the underscores have to be replaced by dashed. So e.g. chunk_size is saved as","path":"doc/style-guide.md","position":6,"original_position":6,"commit_id":"26ab3ce9588e72134af6e4279a4dcdc41fa8d656","original_commit_id":"26ab3ce9588e72134af6e4279a4dcdc41fa8d656","user":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"body":"\"dashes\", most likely, right?","created_at":"2016-04-27T09:46:30Z","updated_at":"2016-04-27T09:46:30Z","html_url":"https://github.com/openSUSE/libstorage-ng/pull/85#discussion_r61230604","pull_request_url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/comments/61230604"},"html":{"href":"https://github.com/openSUSE/libstorage-ng/pull/85#discussion_r61230604"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85","id":65995608,"html_url":"https://github.com/openSUSE/libstorage-ng/pull/85","diff_url":"https://github.com/openSUSE/libstorage-ng/pull/85.diff","patch_url":"https://github.com/openSUSE/libstorage-ng/pull/85.patch","issue_url":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/85","number":85,"state":"open","locked":false,"title":"- partition alignment, drop cylinders and geometry, change unit of sizes","user":{"login":"aschnell","id":908062,"avatar_url":"https://avatars.githubusercontent.com/u/908062?v=3","gravatar_id":"","url":"https://api.github.com/users/aschnell","html_url":"https://github.com/aschnell","followers_url":"https://api.github.com/users/aschnell/followers","following_url":"https://api.github.com/users/aschnell/following{/other_user}","gists_url":"https://api.github.com/users/aschnell/gists{/gist_id}","starred_url":"https://api.github.com/users/aschnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschnell/subscriptions","organizations_url":"https://api.github.com/users/aschnell/orgs","repos_url":"https://api.github.com/users/aschnell/repos","events_url":"https://api.github.com/users/aschnell/events{/privacy}","received_events_url":"https://api.github.com/users/aschnell/received_events","type":"User","site_admin":false},"body":"You should not look at individual commits, there are intermediate mistakes. I recommend to first look at the changes in storage/Utils since those are the base for the rest.\r\n\r\nMajor API changes:\r\n- *_size_k() -> *_size()\r\n- Region::to_kb() -> to_bytes()\r\n- Region::to_value() -> to_blocks()\r\n- class Geometry dropped\r\n- get/set_geometry() dropped\r\n- region of class Partition is sector based\r\n- class Topology added\r\n- get/set_topology() added\r\n","created_at":"2016-04-11T13:43:47Z","updated_at":"2016-04-27T09:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ff122215885c3a6ab50f1910d13c4a345821d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85/commits","review_comments_url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85/comments","review_comment_url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/85/comments","statuses_url":"https://api.github.com/repos/openSUSE/libstorage-ng/statuses/26ab3ce9588e72134af6e4279a4dcdc41fa8d656","head":{"label":"aschnell:master","ref":"master","sha":"26ab3ce9588e72134af6e4279a4dcdc41fa8d656","user":{"login":"aschnell","id":908062,"avatar_url":"https://avatars.githubusercontent.com/u/908062?v=3","gravatar_id":"","url":"https://api.github.com/users/aschnell","html_url":"https://github.com/aschnell","followers_url":"https://api.github.com/users/aschnell/followers","following_url":"https://api.github.com/users/aschnell/following{/other_user}","gists_url":"https://api.github.com/users/aschnell/gists{/gist_id}","starred_url":"https://api.github.com/users/aschnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschnell/subscriptions","organizations_url":"https://api.github.com/users/aschnell/orgs","repos_url":"https://api.github.com/users/aschnell/repos","events_url":"https://api.github.com/users/aschnell/events{/privacy}","received_events_url":"https://api.github.com/users/aschnell/received_events","type":"User","site_admin":false},"repo":{"id":52535700,"name":"libstorage-ng","full_name":"aschnell/libstorage-ng","owner":{"login":"aschnell","id":908062,"avatar_url":"https://avatars.githubusercontent.com/u/908062?v=3","gravatar_id":"","url":"https://api.github.com/users/aschnell","html_url":"https://github.com/aschnell","followers_url":"https://api.github.com/users/aschnell/followers","following_url":"https://api.github.com/users/aschnell/following{/other_user}","gists_url":"https://api.github.com/users/aschnell/gists{/gist_id}","starred_url":"https://api.github.com/users/aschnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschnell/subscriptions","organizations_url":"https://api.github.com/users/aschnell/orgs","repos_url":"https://api.github.com/users/aschnell/repos","events_url":"https://api.github.com/users/aschnell/events{/privacy}","received_events_url":"https://api.github.com/users/aschnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aschnell/libstorage-ng","description":"Evaluating use of boost graph library in libstorage","fork":true,"url":"https://api.github.com/repos/aschnell/libstorage-ng","forks_url":"https://api.github.com/repos/aschnell/libstorage-ng/forks","keys_url":"https://api.github.com/repos/aschnell/libstorage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aschnell/libstorage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aschnell/libstorage-ng/teams","hooks_url":"https://api.github.com/repos/aschnell/libstorage-ng/hooks","issue_events_url":"https://api.github.com/repos/aschnell/libstorage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/aschnell/libstorage-ng/events","assignees_url":"https://api.github.com/repos/aschnell/libstorage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/aschnell/libstorage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/aschnell/libstorage-ng/tags","blobs_url":"https://api.github.com/repos/aschnell/libstorage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aschnell/libstorage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aschnell/libstorage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/aschnell/libstorage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aschnell/libstorage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/aschnell/libstorage-ng/languages","stargazers_url":"https://api.github.com/repos/aschnell/libstorage-ng/stargazers","contributors_url":"https://api.github.com/repos/aschnell/libstorage-ng/contributors","subscribers_url":"https://api.github.com/repos/aschnell/libstorage-ng/subscribers","subscription_url":"https://api.github.com/repos/aschnell/libstorage-ng/subscription","commits_url":"https://api.github.com/repos/aschnell/libstorage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/aschnell/libstorage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/aschnell/libstorage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/aschnell/libstorage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/aschnell/libstorage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/aschnell/libstorage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aschnell/libstorage-ng/merges","archive_url":"https://api.github.com/repos/aschnell/libstorage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aschnell/libstorage-ng/downloads","issues_url":"https://api.github.com/repos/aschnell/libstorage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/aschnell/libstorage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/aschnell/libstorage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/aschnell/libstorage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aschnell/libstorage-ng/labels{/name}","releases_url":"https://api.github.com/repos/aschnell/libstorage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/aschnell/libstorage-ng/deployments","created_at":"2016-02-25T15:32:02Z","updated_at":"2016-02-25T15:32:03Z","pushed_at":"2016-04-27T07:45:06Z","git_url":"git://github.com/aschnell/libstorage-ng.git","ssh_url":"git@github.com:aschnell/libstorage-ng.git","clone_url":"https://github.com/aschnell/libstorage-ng.git","svn_url":"https://github.com/aschnell/libstorage-ng","homepage":null,"size":1472,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"ed9c6f2889f6cba3158e5ff02535b21c06e29b34","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":25586824,"name":"libstorage-ng","full_name":"openSUSE/libstorage-ng","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/libstorage-ng","description":"Evaluating use of boost graph library in libstorage","fork":false,"url":"https://api.github.com/repos/openSUSE/libstorage-ng","forks_url":"https://api.github.com/repos/openSUSE/libstorage-ng/forks","keys_url":"https://api.github.com/repos/openSUSE/libstorage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/libstorage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/libstorage-ng/teams","hooks_url":"https://api.github.com/repos/openSUSE/libstorage-ng/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/libstorage-ng/events","assignees_url":"https://api.github.com/repos/openSUSE/libstorage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/libstorage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/libstorage-ng/tags","blobs_url":"https://api.github.com/repos/openSUSE/libstorage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/libstorage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/libstorage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/libstorage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/libstorage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/libstorage-ng/languages","stargazers_url":"https://api.github.com/repos/openSUSE/libstorage-ng/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/libstorage-ng/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/libstorage-ng/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/libstorage-ng/subscription","commits_url":"https://api.github.com/repos/openSUSE/libstorage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/libstorage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/libstorage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/libstorage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/libstorage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/libstorage-ng/merges","archive_url":"https://api.github.com/repos/openSUSE/libstorage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/libstorage-ng/downloads","issues_url":"https://api.github.com/repos/openSUSE/libstorage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/libstorage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/libstorage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/libstorage-ng/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/libstorage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/libstorage-ng/deployments","created_at":"2014-10-22T14:46:51Z","updated_at":"2016-04-16T08:46:00Z","pushed_at":"2016-04-27T07:45:06Z","git_url":"git://github.com/openSUSE/libstorage-ng.git","ssh_url":"git@github.com:openSUSE/libstorage-ng.git","clone_url":"https://github.com/openSUSE/libstorage-ng.git","svn_url":"https://github.com/openSUSE/libstorage-ng","homepage":null,"size":1480,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85"},"html":{"href":"https://github.com/openSUSE/libstorage-ng/pull/85"},"issue":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/85"},"comments":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/libstorage-ng/statuses/26ab3ce9588e72134af6e4279a4dcdc41fa8d656"}}}}