{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/87091712","pull_request_review_id":7718155,"id":87091712,"diff_hunk":"@@ -121,11 +119,11 @@ public void startClientConnetion() throws IOException, URISyntaxException {\n     public void stopChannels() throws InterruptedException {\n         IoUtils.safeClose(clientChannel);\n         IoUtils.safeClose(serverChannel);\n-        IoUtils.safeClose(connection);\n+//        IoUtils.safeClose(connection);","path":"controller/src/test/java/org/jboss/as/controller/support/RemoteChannelPairSetup.java","position":36,"original_position":36,"commit_id":"9a4a1385af00025471cfb8b9a1d4c56cc52409d0","original_commit_id":"9a4a1385af00025471cfb8b9a1d4c56cc52409d0","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"not closing anymore?","created_at":"2016-11-08T21:50:02Z","updated_at":"2016-11-08T21:50:02Z","html_url":"https://github.com/wildfly/wildfly-core/pull/1921#discussion_r87091712","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/87091712"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1921#discussion_r87091712"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921","id":92824638,"html_url":"https://github.com/wildfly/wildfly-core/pull/1921","diff_url":"https://github.com/wildfly/wildfly-core/pull/1921.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/1921.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1921","number":1921,"state":"open","locked":false,"title":"[WFCORE-673] WildFly Elytron Integration with WildFly Core.","user":{"login":"darranl","id":481922,"avatar_url":"https://avatars.githubusercontent.com/u/481922?v=3","gravatar_id":"","url":"https://api.github.com/users/darranl","html_url":"https://github.com/darranl","followers_url":"https://api.github.com/users/darranl/followers","following_url":"https://api.github.com/users/darranl/following{/other_user}","gists_url":"https://api.github.com/users/darranl/gists{/gist_id}","starred_url":"https://api.github.com/users/darranl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darranl/subscriptions","organizations_url":"https://api.github.com/users/darranl/orgs","repos_url":"https://api.github.com/users/darranl/repos","events_url":"https://api.github.com/users/darranl/events{/privacy}","received_events_url":"https://api.github.com/users/darranl/received_events","type":"User","site_admin":false},"body":"This pull request pulls in JBoss Remoting 5 which allows us to start using WildFly Elytron based SASL authentication for incoming calls over Remoting.\r\n\r\nManagement clients are updated to the new Remoting APIs allowing authentication configuration to be handled by Elytron AuthenticationClient.\r\n\r\nThe legacy security realms are wrapped using Elytron components allowing for legacy configuration to be used whilst switching management over to entirely be driven by WildFly Elytron.  The management interfaces are both updated so they can make direct references to Elytron capabilities for SSL and authentication.\r\n\r\nA SecurityDomain can be associated with management of the server allowing for more advanced identity propagation scenarios.\r\n\r\nThis is just the initial pull request for the changes so a few tests are ignored, ongoing planned changes are: -\r\n \r\n- Legacy SSL Handling\r\n- Kerberos Authentication\r\n- DomainMode\r\n- Audit Logging\r\n\r\n","created_at":"2016-11-08T17:38:11Z","updated_at":"2016-11-08T21:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c1a227f575b30dce22133b0a0f99c33c2648e43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/1921/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/9a4a1385af00025471cfb8b9a1d4c56cc52409d0","head":{"label":"wildfly-security-incubator:WFCORE-673","ref":"WFCORE-673","sha":"9a4a1385af00025471cfb8b9a1d4c56cc52409d0","user":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":32583015,"name":"wildfly-core","full_name":"wildfly-security-incubator/wildfly-core","owner":{"login":"wildfly-security-incubator","id":11571905,"avatar_url":"https://avatars.githubusercontent.com/u/11571905?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-security-incubator","html_url":"https://github.com/wildfly-security-incubator","followers_url":"https://api.github.com/users/wildfly-security-incubator/followers","following_url":"https://api.github.com/users/wildfly-security-incubator/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-security-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-security-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-security-incubator/subscriptions","organizations_url":"https://api.github.com/users/wildfly-security-incubator/orgs","repos_url":"https://api.github.com/users/wildfly-security-incubator/repos","events_url":"https://api.github.com/users/wildfly-security-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-security-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-security-incubator/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core","forks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-security-incubator/wildfly-core/deployments","created_at":"2015-03-20T12:40:48Z","updated_at":"2016-01-20T16:17:04Z","pushed_at":"2016-11-08T19:28:30Z","git_url":"git://github.com/wildfly-security-incubator/wildfly-core.git","ssh_url":"git@github.com:wildfly-security-incubator/wildfly-core.git","clone_url":"https://github.com/wildfly-security-incubator/wildfly-core.git","svn_url":"https://github.com/wildfly-security-incubator/wildfly-core","homepage":null,"size":51756,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"elytron_integration"}},"base":{"label":"wildfly:master","ref":"master","sha":"0df33e3246438cebbd82ee9c1bb9b732f1b59a4d","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2016-11-03T06:31:59Z","pushed_at":"2016-11-08T20:27:33Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":61116,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":29,"forks":225,"open_issues":29,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/1921"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1921"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/9a4a1385af00025471cfb8b9a1d4c56cc52409d0"}}}}
{"actor":{"display_login":"ctomc"}}