{"action":"created","comment":{"url":"https://api.github.com/repos/google/shaka-player/pulls/comments/86660035","pull_request_review_id":7310148,"id":86660035,"diff_hunk":"@@ -418,6 +418,25 @@ describe('TtmlTextParser', function() {\n         '</tt>');\n   });\n \n+  it('aligns center when textAlign is center', function() {","path":"test/media/ttml_text_parser_unit.js","position":null,"original_position":4,"commit_id":"e698ca937391be576db787077670cae2cfe3f196","original_commit_id":"f8a65a9e5cb50a73d3790d7f166821db07db36f3","user":{"login":"birme","id":7220788,"avatar_url":"https://avatars.githubusercontent.com/u/7220788?v=3","gravatar_id":"","url":"https://api.github.com/users/birme","html_url":"https://github.com/birme","followers_url":"https://api.github.com/users/birme/followers","following_url":"https://api.github.com/users/birme/following{/other_user}","gists_url":"https://api.github.com/users/birme/gists{/gist_id}","starred_url":"https://api.github.com/users/birme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birme/subscriptions","organizations_url":"https://api.github.com/users/birme/orgs","repos_url":"https://api.github.com/users/birme/repos","events_url":"https://api.github.com/users/birme/events{/privacy}","received_events_url":"https://api.github.com/users/birme/received_events","type":"User","site_admin":false},"body":"Sure, done!","created_at":"2016-11-05T07:37:18Z","updated_at":"2016-11-05T07:37:18Z","html_url":"https://github.com/google/shaka-player/pull/573#discussion_r86660035","pull_request_url":"https://api.github.com/repos/google/shaka-player/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments/86660035"},"html":{"href":"https://github.com/google/shaka-player/pull/573#discussion_r86660035"},"pull_request":{"href":"https://api.github.com/repos/google/shaka-player/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/google/shaka-player/pulls/573","id":92294494,"html_url":"https://github.com/google/shaka-player/pull/573","diff_url":"https://github.com/google/shaka-player/pull/573.diff","patch_url":"https://github.com/google/shaka-player/pull/573.patch","issue_url":"https://api.github.com/repos/google/shaka-player/issues/573","number":573,"state":"open","locked":false,"title":"Fix for TTML text alignment","user":{"login":"birme","id":7220788,"avatar_url":"https://avatars.githubusercontent.com/u/7220788?v=3","gravatar_id":"","url":"https://api.github.com/users/birme","html_url":"https://github.com/birme","followers_url":"https://api.github.com/users/birme/followers","following_url":"https://api.github.com/users/birme/following{/other_user}","gists_url":"https://api.github.com/users/birme/gists{/gist_id}","starred_url":"https://api.github.com/users/birme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birme/subscriptions","organizations_url":"https://api.github.com/users/birme/orgs","repos_url":"https://api.github.com/users/birme/repos","events_url":"https://api.github.com/users/birme/events{/privacy}","received_events_url":"https://api.github.com/users/birme/received_events","type":"User","site_admin":false},"body":"This pull request solves the problem with TTML text alignment. We have TTML subtitles that has tts:textAlign=left and the subtitle was placed on the left side of the player but the text was centered. If I am reading the VTTCue specification correctly [1] the cue.align also needs to be set. This was not done and is solved by this PR.\r\n\r\n[1] https://w3c.github.io/webvtt/#dom-vttcue-align ","created_at":"2016-11-04T07:27:17Z","updated_at":"2016-11-05T07:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"850e84a505407ca45e14afce61c54f7b0ff5d87b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/shaka-player/pulls/573/commits","review_comments_url":"https://api.github.com/repos/google/shaka-player/pulls/573/comments","review_comment_url":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/shaka-player/issues/573/comments","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/e698ca937391be576db787077670cae2cfe3f196","head":{"label":"Eyevinn:fix-ttmlalign","ref":"fix-ttmlalign","sha":"e698ca937391be576db787077670cae2cfe3f196","user":{"login":"Eyevinn","id":7300575,"avatar_url":"https://avatars.githubusercontent.com/u/7300575?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyevinn","html_url":"https://github.com/Eyevinn","followers_url":"https://api.github.com/users/Eyevinn/followers","following_url":"https://api.github.com/users/Eyevinn/following{/other_user}","gists_url":"https://api.github.com/users/Eyevinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyevinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyevinn/subscriptions","organizations_url":"https://api.github.com/users/Eyevinn/orgs","repos_url":"https://api.github.com/users/Eyevinn/repos","events_url":"https://api.github.com/users/Eyevinn/events{/privacy}","received_events_url":"https://api.github.com/users/Eyevinn/received_events","type":"Organization","site_admin":false},"repo":{"id":68705831,"name":"shaka-player","full_name":"Eyevinn/shaka-player","owner":{"login":"Eyevinn","id":7300575,"avatar_url":"https://avatars.githubusercontent.com/u/7300575?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyevinn","html_url":"https://github.com/Eyevinn","followers_url":"https://api.github.com/users/Eyevinn/followers","following_url":"https://api.github.com/users/Eyevinn/following{/other_user}","gists_url":"https://api.github.com/users/Eyevinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyevinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyevinn/subscriptions","organizations_url":"https://api.github.com/users/Eyevinn/orgs","repos_url":"https://api.github.com/users/Eyevinn/repos","events_url":"https://api.github.com/users/Eyevinn/events{/privacy}","received_events_url":"https://api.github.com/users/Eyevinn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eyevinn/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":true,"url":"https://api.github.com/repos/Eyevinn/shaka-player","forks_url":"https://api.github.com/repos/Eyevinn/shaka-player/forks","keys_url":"https://api.github.com/repos/Eyevinn/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eyevinn/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eyevinn/shaka-player/teams","hooks_url":"https://api.github.com/repos/Eyevinn/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/Eyevinn/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/Eyevinn/shaka-player/events","assignees_url":"https://api.github.com/repos/Eyevinn/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/Eyevinn/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/Eyevinn/shaka-player/tags","blobs_url":"https://api.github.com/repos/Eyevinn/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eyevinn/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eyevinn/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eyevinn/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eyevinn/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/Eyevinn/shaka-player/languages","stargazers_url":"https://api.github.com/repos/Eyevinn/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/Eyevinn/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/Eyevinn/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/Eyevinn/shaka-player/subscription","commits_url":"https://api.github.com/repos/Eyevinn/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eyevinn/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eyevinn/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eyevinn/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eyevinn/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/Eyevinn/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eyevinn/shaka-player/merges","archive_url":"https://api.github.com/repos/Eyevinn/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eyevinn/shaka-player/downloads","issues_url":"https://api.github.com/repos/Eyevinn/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/Eyevinn/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/Eyevinn/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/Eyevinn/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eyevinn/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/Eyevinn/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/Eyevinn/shaka-player/deployments","created_at":"2016-09-20T11:37:08Z","updated_at":"2016-09-20T11:37:10Z","pushed_at":"2016-11-05T07:36:51Z","git_url":"git://github.com/Eyevinn/shaka-player.git","ssh_url":"git@github.com:Eyevinn/shaka-player.git","clone_url":"https://github.com/Eyevinn/shaka-player.git","svn_url":"https://github.com/Eyevinn/shaka-player","homepage":"","size":32917,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a4bc7f36d78be5dc2806120a6a962ab3cc5e49c8","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":28246472,"name":"shaka-player","full_name":"google/shaka-player","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/shaka-player","description":"JavaScript player library / DASH client / MSE-EME player","fork":false,"url":"https://api.github.com/repos/google/shaka-player","forks_url":"https://api.github.com/repos/google/shaka-player/forks","keys_url":"https://api.github.com/repos/google/shaka-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/shaka-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/shaka-player/teams","hooks_url":"https://api.github.com/repos/google/shaka-player/hooks","issue_events_url":"https://api.github.com/repos/google/shaka-player/issues/events{/number}","events_url":"https://api.github.com/repos/google/shaka-player/events","assignees_url":"https://api.github.com/repos/google/shaka-player/assignees{/user}","branches_url":"https://api.github.com/repos/google/shaka-player/branches{/branch}","tags_url":"https://api.github.com/repos/google/shaka-player/tags","blobs_url":"https://api.github.com/repos/google/shaka-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/shaka-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/shaka-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/shaka-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/shaka-player/statuses/{sha}","languages_url":"https://api.github.com/repos/google/shaka-player/languages","stargazers_url":"https://api.github.com/repos/google/shaka-player/stargazers","contributors_url":"https://api.github.com/repos/google/shaka-player/contributors","subscribers_url":"https://api.github.com/repos/google/shaka-player/subscribers","subscription_url":"https://api.github.com/repos/google/shaka-player/subscription","commits_url":"https://api.github.com/repos/google/shaka-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/shaka-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/shaka-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/shaka-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/shaka-player/contents/{+path}","compare_url":"https://api.github.com/repos/google/shaka-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/shaka-player/merges","archive_url":"https://api.github.com/repos/google/shaka-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/shaka-player/downloads","issues_url":"https://api.github.com/repos/google/shaka-player/issues{/number}","pulls_url":"https://api.github.com/repos/google/shaka-player/pulls{/number}","milestones_url":"https://api.github.com/repos/google/shaka-player/milestones{/number}","notifications_url":"https://api.github.com/repos/google/shaka-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/shaka-player/labels{/name}","releases_url":"https://api.github.com/repos/google/shaka-player/releases{/id}","deployments_url":"https://api.github.com/repos/google/shaka-player/deployments","created_at":"2014-12-19T21:12:18Z","updated_at":"2016-11-03T19:19:52Z","pushed_at":"2016-11-05T07:36:51Z","git_url":"git://github.com/google/shaka-player.git","ssh_url":"git@github.com:google/shaka-player.git","clone_url":"https://github.com/google/shaka-player.git","svn_url":"https://github.com/google/shaka-player","homepage":"","size":34064,"stargazers_count":828,"watchers_count":828,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":45,"forks":194,"open_issues":45,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/shaka-player/pulls/573"},"html":{"href":"https://github.com/google/shaka-player/pull/573"},"issue":{"href":"https://api.github.com/repos/google/shaka-player/issues/573"},"comments":{"href":"https://api.github.com/repos/google/shaka-player/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/google/shaka-player/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/google/shaka-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/shaka-player/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/google/shaka-player/statuses/e698ca937391be576db787077670cae2cfe3f196"}}}}
{"actor":{"display_login":"birme"}}