{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/comments/81186161","pull_request_review_id":2185022,"id":81186161,"diff_hunk":"@@ -169,19 +161,24 @@ private static void JobSetup(JobBase job, bool consoleLogOnly, IDictionary<strin\n                 job.JobTraceListener.Flush();\n \n                 stopWatch.Restart();\n-                success = await job.Run();\n+                var initialized = job.Init(jobArgsDictionary);\n+                var succeeded = initialized && await job.Run();\n                 stopWatch.Stop();\n \n                 Trace.WriteLine(\"Job run ended...\");","path":"src/NuGet.Jobs.Common/JobRunner.cs","position":58,"original_position":58,"commit_id":"84d1b991971d012f8ca8c1c8e3b01918bd66d6db","original_commit_id":"84d1b991971d012f8ca8c1c8e3b01918bd66d6db","user":{"login":"scottbommarito","id":18014088,"avatar_url":"https://avatars.githubusercontent.com/u/18014088?v=3","gravatar_id":"","url":"https://api.github.com/users/scottbommarito","html_url":"https://github.com/scottbommarito","followers_url":"https://api.github.com/users/scottbommarito/followers","following_url":"https://api.github.com/users/scottbommarito/following{/other_user}","gists_url":"https://api.github.com/users/scottbommarito/gists{/gist_id}","starred_url":"https://api.github.com/users/scottbommarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottbommarito/subscriptions","organizations_url":"https://api.github.com/users/scottbommarito/orgs","repos_url":"https://api.github.com/users/scottbommarito/repos","events_url":"https://api.github.com/users/scottbommarito/events{/privacy}","received_events_url":"https://api.github.com/users/scottbommarito/received_events","type":"User","site_admin":false},"body":"if `job.Run()` or `job.Init()` throws an exception, it gets caught by the the function that calls this one. are you suggesting that we might want to catch them here and throw them here instead without exiting the loop?","created_at":"2016-09-29T17:09:41Z","updated_at":"2016-09-29T17:09:41Z","html_url":"https://github.com/NuGet/NuGet.Jobs/pull/68#discussion_r81186161","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/comments/81186161"},"html":{"href":"https://github.com/NuGet/NuGet.Jobs/pull/68#discussion_r81186161"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68","id":86246579,"html_url":"https://github.com/NuGet/NuGet.Jobs/pull/68","diff_url":"https://github.com/NuGet/NuGet.Jobs/pull/68.diff","patch_url":"https://github.com/NuGet/NuGet.Jobs/pull/68.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/68","number":68,"state":"open","locked":false,"title":"Key rotation logic for jobs v2","user":{"login":"scottbommarito","id":18014088,"avatar_url":"https://avatars.githubusercontent.com/u/18014088?v=3","gravatar_id":"","url":"https://api.github.com/users/scottbommarito","html_url":"https://github.com/scottbommarito","followers_url":"https://api.github.com/users/scottbommarito/followers","following_url":"https://api.github.com/users/scottbommarito/following{/other_user}","gists_url":"https://api.github.com/users/scottbommarito/gists{/gist_id}","starred_url":"https://api.github.com/users/scottbommarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottbommarito/subscriptions","organizations_url":"https://api.github.com/users/scottbommarito/orgs","repos_url":"https://api.github.com/users/scottbommarito/repos","events_url":"https://api.github.com/users/scottbommarito/events{/privacy}","received_events_url":"https://api.github.com/users/scottbommarito/received_events","type":"User","site_admin":false},"body":"Since @skofman1 informed me that the deadlock condition is only an issue for MVC apps, there is no problem with using a synchronous context to access KeyVault. Therefore, the amount of code changes to require key rotation of the jobs was greatly reduced.\r\n\r\nThis code is in addition to a class called `ConfigurationDictionary`, which is in `NuGet.Services.KeyVault`, that is basically a dictionary that just calls `InjectSecret` on every access. It uses a `CachingSecretReader`, so the operation is generally quite fast.\r\n\r\n- [ ] release `NuGet.Services.KeyVault` and update references\r\n- [x] test the functionality by creating a test KeyVault and rotating keys while a job is running","created_at":"2016-09-21T21:40:43Z","updated_at":"2016-09-29T17:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca77cd5cb95245912e72ecb4ba621f304d3cace4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/68/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/statuses/84d1b991971d012f8ca8c1c8e3b01918bd66d6db","head":{"label":"NuGet:sb-keyrot2","ref":"sb-keyrot2","sha":"84d1b991971d012f8ca8c1c8e3b01918bd66d6db","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":23330255,"name":"NuGet.Jobs","full_name":"NuGet/NuGet.Jobs","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Jobs","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Jobs","forks_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/deployments","created_at":"2014-08-25T22:01:47Z","updated_at":"2016-09-07T11:37:53Z","pushed_at":"2016-09-28T21:51:28Z","git_url":"git://github.com/NuGet/NuGet.Jobs.git","ssh_url":"git@github.com:NuGet/NuGet.Jobs.git","clone_url":"https://github.com/NuGet/NuGet.Jobs.git","svn_url":"https://github.com/NuGet/NuGet.Jobs","homepage":null,"size":1763,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"a9d258461e989eea4c5277c87a9cdf0827971dde","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":23330255,"name":"NuGet.Jobs","full_name":"NuGet/NuGet.Jobs","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Jobs","description":"","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Jobs","forks_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Jobs/deployments","created_at":"2014-08-25T22:01:47Z","updated_at":"2016-09-07T11:37:53Z","pushed_at":"2016-09-28T21:51:28Z","git_url":"git://github.com/NuGet/NuGet.Jobs.git","ssh_url":"git@github.com:NuGet/NuGet.Jobs.git","clone_url":"https://github.com/NuGet/NuGet.Jobs.git","svn_url":"https://github.com/NuGet/NuGet.Jobs","homepage":null,"size":1763,"stargazers_count":8,"watchers_count":8,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68"},"html":{"href":"https://github.com/NuGet/NuGet.Jobs/pull/68"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/68"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Jobs/statuses/84d1b991971d012f8ca8c1c8e3b01918bd66d6db"}}}}
{"actor":{"display_login":"scottbommarito"}}