{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/74729072","id":74729072,"diff_hunk":"@@ -482,6 +491,13 @@ function setuphost()\n         [[ $arch = s390x ]] && {\n             echo 1 > /proc/sys/vm/allocate_pgste\n         }\n+\n+        # enable UEFI boot\n+        [[ -n $want_efi ]] && {\n+            zypper --non-interactive in --no-recommends \\\n+                ovmf ovmf-tools qemu-ovmf-x86_64\n+            [ \"$?\" == 0 -o \"$?\" == 4 ] || complain 10 \"setuphost failed to install required packages\"","path":"scripts/mkcloud","position":52,"original_position":52,"commit_id":"9e2496197378f31940848cc9018ce4dd0e089965","original_commit_id":"9e2496197378f31940848cc9018ce4dd0e089965","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"which should be fine, older host systems don't have ovmf available. I wouldn't make that a failure, but that can be debated.","created_at":"2016-08-15T07:47:28Z","updated_at":"2016-08-15T07:47:28Z","html_url":"https://github.com/SUSE-Cloud/automation/pull/1141#discussion_r74729072","pull_request_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141","_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/74729072"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1141#discussion_r74729072"},"pull_request":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141","id":81017626,"html_url":"https://github.com/SUSE-Cloud/automation/pull/1141","diff_url":"https://github.com/SUSE-Cloud/automation/pull/1141.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/1141.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1141","number":1141,"state":"open","locked":false,"title":"[WIP]Uefi boot support  on mkcloud","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"body":"Allow support for firmware_type as a parameter to admin_config and add an option to mkcloud \"want_efi\" to use UEFI image to boot mkcloud.","created_at":"2016-08-11T19:38:40Z","updated_at":"2016-08-15T07:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635632452338713502c1c5ac9348dc5e2d193ba8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1141/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/9e2496197378f31940848cc9018ce4dd0e089965","head":{"label":"mmnelemane:uefi_mkcloud","ref":"uefi_mkcloud","sha":"9e2496197378f31940848cc9018ce4dd0e089965","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"repo":{"id":43808599,"name":"automation","full_name":"mmnelemane/automation","owner":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmnelemane/automation","description":"Automation scripts for development, testing, and CI","fork":true,"url":"https://api.github.com/repos/mmnelemane/automation","forks_url":"https://api.github.com/repos/mmnelemane/automation/forks","keys_url":"https://api.github.com/repos/mmnelemane/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmnelemane/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmnelemane/automation/teams","hooks_url":"https://api.github.com/repos/mmnelemane/automation/hooks","issue_events_url":"https://api.github.com/repos/mmnelemane/automation/issues/events{/number}","events_url":"https://api.github.com/repos/mmnelemane/automation/events","assignees_url":"https://api.github.com/repos/mmnelemane/automation/assignees{/user}","branches_url":"https://api.github.com/repos/mmnelemane/automation/branches{/branch}","tags_url":"https://api.github.com/repos/mmnelemane/automation/tags","blobs_url":"https://api.github.com/repos/mmnelemane/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmnelemane/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmnelemane/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmnelemane/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmnelemane/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/mmnelemane/automation/languages","stargazers_url":"https://api.github.com/repos/mmnelemane/automation/stargazers","contributors_url":"https://api.github.com/repos/mmnelemane/automation/contributors","subscribers_url":"https://api.github.com/repos/mmnelemane/automation/subscribers","subscription_url":"https://api.github.com/repos/mmnelemane/automation/subscription","commits_url":"https://api.github.com/repos/mmnelemane/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmnelemane/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmnelemane/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmnelemane/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmnelemane/automation/contents/{+path}","compare_url":"https://api.github.com/repos/mmnelemane/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmnelemane/automation/merges","archive_url":"https://api.github.com/repos/mmnelemane/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmnelemane/automation/downloads","issues_url":"https://api.github.com/repos/mmnelemane/automation/issues{/number}","pulls_url":"https://api.github.com/repos/mmnelemane/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/mmnelemane/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/mmnelemane/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmnelemane/automation/labels{/name}","releases_url":"https://api.github.com/repos/mmnelemane/automation/releases{/id}","deployments_url":"https://api.github.com/repos/mmnelemane/automation/deployments","created_at":"2015-10-07T10:23:47Z","updated_at":"2016-01-22T12:04:40Z","pushed_at":"2016-08-12T12:22:19Z","git_url":"git://github.com/mmnelemane/automation.git","ssh_url":"git@github.com:mmnelemane/automation.git","clone_url":"https://github.com/mmnelemane/automation.git","svn_url":"https://github.com/mmnelemane/automation","homepage":"","size":5521,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:master","ref":"master","sha":"2321c8e3fc6cc05d894b660fc833fd82c3798844","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6384356,"name":"automation","full_name":"SUSE-Cloud/automation","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/automation","description":"Automation scripts for development, testing, and CI","fork":false,"url":"https://api.github.com/repos/SUSE-Cloud/automation","forks_url":"https://api.github.com/repos/SUSE-Cloud/automation/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/automation/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/automation/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/automation/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/automation/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/automation/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/automation/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/automation/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/automation/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/automation/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/automation/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/automation/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE-Cloud/automation/deployments","created_at":"2012-10-25T08:45:31Z","updated_at":"2016-07-08T19:13:44Z","pushed_at":"2016-08-15T07:39:37Z","git_url":"git://github.com/SUSE-Cloud/automation.git","ssh_url":"git@github.com:SUSE-Cloud/automation.git","clone_url":"https://github.com/SUSE-Cloud/automation.git","svn_url":"https://github.com/SUSE-Cloud/automation","homepage":"","size":8421,"stargazers_count":17,"watchers_count":17,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":34,"forks":51,"open_issues":34,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1141"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1141"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1141/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1141/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/9e2496197378f31940848cc9018ce4dd0e089965"}}}}
{"actor":{"display_login":"dirkmueller"}}