{"action":"created","comment":{"url":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments/80993834","pull_request_review_id":2007603,"id":80993834,"diff_hunk":"@@ -9,25 +9,104 @@\n package privet\n \n import (\n-\t\"errors\"\n+  \"fmt\"\n+  \"sync\"\n+  \"github.com/andrewtj/dnssd\"","path":"privet/windows.go","position":7,"original_position":7,"commit_id":"4e04a563e08bf9f4a992b00c1c6e484d12ec9dc0","original_commit_id":"4e04a563e08bf9f4a992b00c1c6e484d12ec9dc0","user":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"body":"I am happy to go in either order. My thought was that if we moved Mac over first (which works today), we would find potential issues that might cause problems on Windows, thus improving the chances Windows would work properly.","created_at":"2016-09-28T19:04:54Z","updated_at":"2016-09-28T19:04:54Z","html_url":"https://github.com/google/cloud-print-connector/pull/306#discussion_r80993834","pull_request_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments/80993834"},"html":{"href":"https://github.com/google/cloud-print-connector/pull/306#discussion_r80993834"},"pull_request":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/google/cloud-print-connector/pulls/306","id":85796500,"html_url":"https://github.com/google/cloud-print-connector/pull/306","diff_url":"https://github.com/google/cloud-print-connector/pull/306.diff","patch_url":"https://github.com/google/cloud-print-connector/pull/306.patch","issue_url":"https://api.github.com/repos/google/cloud-print-connector/issues/306","number":306,"state":"open","locked":false,"title":"Implement Privet on Windows fixes #246","user":{"login":"jay0lee","id":4623536,"avatar_url":"https://avatars.githubusercontent.com/u/4623536?v=3","gravatar_id":"","url":"https://api.github.com/users/jay0lee","html_url":"https://github.com/jay0lee","followers_url":"https://api.github.com/users/jay0lee/followers","following_url":"https://api.github.com/users/jay0lee/following{/other_user}","gists_url":"https://api.github.com/users/jay0lee/gists{/gist_id}","starred_url":"https://api.github.com/users/jay0lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay0lee/subscriptions","organizations_url":"https://api.github.com/users/jay0lee/orgs","repos_url":"https://api.github.com/users/jay0lee/repos","events_url":"https://api.github.com/users/jay0lee/events{/privacy}","received_events_url":"https://api.github.com/users/jay0lee/received_events","type":"User","site_admin":false},"body":"First shot at Privet on Windows for local printing. Code needs a lot of\r\nwork but on my test machine, local printing seems to work for basic\r\nscenarios.\r\n\r\nThis patch uses github.com/andrewtj/dnssd for mDNS which in turn relies\r\non Apple's Bonjour Service for Windows which must be installed:\r\n\r\nhttps://support.apple.com/kb/dl999?locale=en_US\r\n\r\nApple does allow Bonjour Service to be distrubuted in some cases so we\r\nmay be able to wrap it into the MSI installer but for now it will need\r\nto be installed before cloud-print-connector.","created_at":"2016-09-19T13:48:21Z","updated_at":"2016-09-28T19:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c82c80d8b4058d1395094c64f908c678cd3df6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/306/commits","review_comments_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/306/comments","review_comment_url":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cloud-print-connector/issues/306/comments","statuses_url":"https://api.github.com/repos/google/cloud-print-connector/statuses/4e04a563e08bf9f4a992b00c1c6e484d12ec9dc0","head":{"label":"jay0lee:master","ref":"master","sha":"4e04a563e08bf9f4a992b00c1c6e484d12ec9dc0","user":{"login":"jay0lee","id":4623536,"avatar_url":"https://avatars.githubusercontent.com/u/4623536?v=3","gravatar_id":"","url":"https://api.github.com/users/jay0lee","html_url":"https://github.com/jay0lee","followers_url":"https://api.github.com/users/jay0lee/followers","following_url":"https://api.github.com/users/jay0lee/following{/other_user}","gists_url":"https://api.github.com/users/jay0lee/gists{/gist_id}","starred_url":"https://api.github.com/users/jay0lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay0lee/subscriptions","organizations_url":"https://api.github.com/users/jay0lee/orgs","repos_url":"https://api.github.com/users/jay0lee/repos","events_url":"https://api.github.com/users/jay0lee/events{/privacy}","received_events_url":"https://api.github.com/users/jay0lee/received_events","type":"User","site_admin":false},"repo":{"id":68609235,"name":"cloud-print-connector","full_name":"jay0lee/cloud-print-connector","owner":{"login":"jay0lee","id":4623536,"avatar_url":"https://avatars.githubusercontent.com/u/4623536?v=3","gravatar_id":"","url":"https://api.github.com/users/jay0lee","html_url":"https://github.com/jay0lee","followers_url":"https://api.github.com/users/jay0lee/followers","following_url":"https://api.github.com/users/jay0lee/following{/other_user}","gists_url":"https://api.github.com/users/jay0lee/gists{/gist_id}","starred_url":"https://api.github.com/users/jay0lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay0lee/subscriptions","organizations_url":"https://api.github.com/users/jay0lee/orgs","repos_url":"https://api.github.com/users/jay0lee/repos","events_url":"https://api.github.com/users/jay0lee/events{/privacy}","received_events_url":"https://api.github.com/users/jay0lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jay0lee/cloud-print-connector","description":"Google Cloud Print Connector","fork":true,"url":"https://api.github.com/repos/jay0lee/cloud-print-connector","forks_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/forks","keys_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/teams","hooks_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/hooks","issue_events_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/issues/events{/number}","events_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/events","assignees_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/assignees{/user}","branches_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/branches{/branch}","tags_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/tags","blobs_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/languages","stargazers_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/stargazers","contributors_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/contributors","subscribers_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/subscribers","subscription_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/subscription","commits_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/contents/{+path}","compare_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/merges","archive_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/downloads","issues_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/issues{/number}","pulls_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/labels{/name}","releases_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/releases{/id}","deployments_url":"https://api.github.com/repos/jay0lee/cloud-print-connector/deployments","created_at":"2016-09-19T13:36:12Z","updated_at":"2016-09-19T13:36:13Z","pushed_at":"2016-09-28T18:31:36Z","git_url":"git://github.com/jay0lee/cloud-print-connector.git","ssh_url":"git@github.com:jay0lee/cloud-print-connector.git","clone_url":"https://github.com/jay0lee/cloud-print-connector.git","svn_url":"https://github.com/jay0lee/cloud-print-connector","homepage":"","size":1140,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"97d0b1c8267e067435dcc33b848df75d405c37f4","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":31638315,"name":"cloud-print-connector","full_name":"google/cloud-print-connector","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cloud-print-connector","description":"Google Cloud Print Connector","fork":false,"url":"https://api.github.com/repos/google/cloud-print-connector","forks_url":"https://api.github.com/repos/google/cloud-print-connector/forks","keys_url":"https://api.github.com/repos/google/cloud-print-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cloud-print-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cloud-print-connector/teams","hooks_url":"https://api.github.com/repos/google/cloud-print-connector/hooks","issue_events_url":"https://api.github.com/repos/google/cloud-print-connector/issues/events{/number}","events_url":"https://api.github.com/repos/google/cloud-print-connector/events","assignees_url":"https://api.github.com/repos/google/cloud-print-connector/assignees{/user}","branches_url":"https://api.github.com/repos/google/cloud-print-connector/branches{/branch}","tags_url":"https://api.github.com/repos/google/cloud-print-connector/tags","blobs_url":"https://api.github.com/repos/google/cloud-print-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cloud-print-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cloud-print-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cloud-print-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cloud-print-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cloud-print-connector/languages","stargazers_url":"https://api.github.com/repos/google/cloud-print-connector/stargazers","contributors_url":"https://api.github.com/repos/google/cloud-print-connector/contributors","subscribers_url":"https://api.github.com/repos/google/cloud-print-connector/subscribers","subscription_url":"https://api.github.com/repos/google/cloud-print-connector/subscription","commits_url":"https://api.github.com/repos/google/cloud-print-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cloud-print-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cloud-print-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cloud-print-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cloud-print-connector/contents/{+path}","compare_url":"https://api.github.com/repos/google/cloud-print-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cloud-print-connector/merges","archive_url":"https://api.github.com/repos/google/cloud-print-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cloud-print-connector/downloads","issues_url":"https://api.github.com/repos/google/cloud-print-connector/issues{/number}","pulls_url":"https://api.github.com/repos/google/cloud-print-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cloud-print-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cloud-print-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cloud-print-connector/labels{/name}","releases_url":"https://api.github.com/repos/google/cloud-print-connector/releases{/id}","deployments_url":"https://api.github.com/repos/google/cloud-print-connector/deployments","created_at":"2015-03-04T04:41:38Z","updated_at":"2016-09-27T15:00:23Z","pushed_at":"2016-09-28T18:32:20Z","git_url":"git://github.com/google/cloud-print-connector.git","ssh_url":"git@github.com:google/cloud-print-connector.git","clone_url":"https://github.com/google/cloud-print-connector.git","svn_url":"https://github.com/google/cloud-print-connector","homepage":"","size":1409,"stargazers_count":283,"watchers_count":283,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":37,"forks":59,"open_issues":37,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/306"},"html":{"href":"https://github.com/google/cloud-print-connector/pull/306"},"issue":{"href":"https://api.github.com/repos/google/cloud-print-connector/issues/306"},"comments":{"href":"https://api.github.com/repos/google/cloud-print-connector/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cloud-print-connector/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/google/cloud-print-connector/statuses/4e04a563e08bf9f4a992b00c1c6e484d12ec9dc0"}}}}
{"actor":{"display_login":"agoode"}}