{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/7288","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/7288/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/7288/comments","events_url":"https://api.github.com/repos/angular/angular/issues/7288/events","html_url":"https://github.com/angular/angular/pull/7288","id":136513555,"number":7288,"title":"feat(forms): Added form related methods and tests","user":{"login":"basvandenheuvel","id":3515248,"avatar_url":"https://avatars.githubusercontent.com/u/3515248?v=3","gravatar_id":"","url":"https://api.github.com/users/basvandenheuvel","html_url":"https://github.com/basvandenheuvel","followers_url":"https://api.github.com/users/basvandenheuvel/followers","following_url":"https://api.github.com/users/basvandenheuvel/following{/other_user}","gists_url":"https://api.github.com/users/basvandenheuvel/gists{/gist_id}","starred_url":"https://api.github.com/users/basvandenheuvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvandenheuvel/subscriptions","organizations_url":"https://api.github.com/users/basvandenheuvel/orgs","repos_url":"https://api.github.com/users/basvandenheuvel/repos","events_url":"https://api.github.com/users/basvandenheuvel/events{/privacy}","received_events_url":"https://api.github.com/users/basvandenheuvel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular/labels/action:%20review","name":"action: review","color":"ededed"},{"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/angular/labels/status:%20Travis%20OK","name":"status: Travis OK","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=3","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-02-25T21:10:56Z","updated_at":"2016-03-29T06:16:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/7288","html_url":"https://github.com/angular/angular/pull/7288","diff_url":"https://github.com/angular/angular/pull/7288.diff","patch_url":"https://github.com/angular/angular/pull/7288.patch"},"body":"#### I DELETED THE PREVIOUS PR DUE TO SOME WEIRD ERRORS\r\n\r\n@robwormald @vsavkin\r\n\r\nCredits to @MarkPerryBV for helping out with this PR.\r\n\r\n#### Changes in this PR\r\nAbstractControl: \r\n- Added `markAsUntouched()`, `markAsPristine()`\r\n\r\nControlGroup: \r\n- Added `markAsPristine()`, `markAllAsPristine()`, `markAllAsDirty()`, `markAllAsTouched()`, `markAllAsUntouched()`, `markAllAsPending()`\r\n\r\nControlArray: \r\n- Added `markAsPristine()`, `markAllAsPristine()`, `markAllAsDirty()`, `markAllAsTouched()`, `markAllAsUntouched()`, `markAllAsPending()`\r\n\r\nTests:\r\n- Added missing tests for \"touched\" part\r\n- Added tests for all new methods\r\n\r\nNG_COMMON:\r\n- Added needed NG_COMMON values (ask permission? @mhevery)\r\n\r\n#### Questions for the Angular team:\r\n- Methods like \"dirty\" and \"pristine\" bubble up to the parent, the touched part doesn't. Is this intended? If the touched part should also bubble up i can create a PR for this, let me know.\r\n\r\n#### Next PR\r\n- For a next PR i'm going to look into stuff like `clear()` and `reset()` methods for the form.\r\n\r\nIssues I (partly) solve with this PR: #4933, #5568"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/202731135","html_url":"https://github.com/angular/angular/pull/7288#issuecomment-202731135","issue_url":"https://api.github.com/repos/angular/angular/issues/7288","id":202731135,"user":{"login":"basvandenheuvel","id":3515248,"avatar_url":"https://avatars.githubusercontent.com/u/3515248?v=3","gravatar_id":"","url":"https://api.github.com/users/basvandenheuvel","html_url":"https://github.com/basvandenheuvel","followers_url":"https://api.github.com/users/basvandenheuvel/followers","following_url":"https://api.github.com/users/basvandenheuvel/following{/other_user}","gists_url":"https://api.github.com/users/basvandenheuvel/gists{/gist_id}","starred_url":"https://api.github.com/users/basvandenheuvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvandenheuvel/subscriptions","organizations_url":"https://api.github.com/users/basvandenheuvel/orgs","repos_url":"https://api.github.com/users/basvandenheuvel/repos","events_url":"https://api.github.com/users/basvandenheuvel/events{/privacy}","received_events_url":"https://api.github.com/users/basvandenheuvel/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T06:16:12Z","updated_at":"2016-03-29T06:16:12Z","body":"Can anyone help me witht he Squask? As you can see in my commits, there are 2 commits related to retrieving the newest version of the Angular 2 master because my PR branch was behind the master. \r\n\r\nIn the past i tried to squash these commits as well resulting in A LOT of errors. How can i squash these 3 commits togheter?\r\n\r\nSorry this PR is taking so long, i've been very busy."}}