{"action":"closed","number":17330,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17330","id":82551824,"html_url":"https://github.com/mantidproject/mantid/pull/17330","diff_url":"https://github.com/mantidproject/mantid/pull/17330.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17330.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17330","number":17330,"state":"closed","locked":false,"title":"detector scale factor update","user":{"login":"VickieLynch","id":1108354,"avatar_url":"https://avatars.githubusercontent.com/u/1108354?v=3","gravatar_id":"","url":"https://api.github.com/users/VickieLynch","html_url":"https://github.com/VickieLynch","followers_url":"https://api.github.com/users/VickieLynch/followers","following_url":"https://api.github.com/users/VickieLynch/following{/other_user}","gists_url":"https://api.github.com/users/VickieLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/VickieLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VickieLynch/subscriptions","organizations_url":"https://api.github.com/users/VickieLynch/orgs","repos_url":"https://api.github.com/users/VickieLynch/repos","events_url":"https://api.github.com/users/VickieLynch/events{/privacy}","received_events_url":"https://api.github.com/users/VickieLynch/received_events","type":"User","site_admin":false},"body":"Description of work.\r\nPut detScale factors for each detector into TOPAZ instrument parameters to be used by SaveHKL and AnvredCorrection.  They can be changes with new algorithm, SetDetScale, by the user.\r\n**To test:**\r\nhttps://www.dropbox.com/s/5eidrhs9ehnfkge/Si2mm_Cubic_F.integrate?dl=0\r\nhttps://www.dropbox.com/s/ozciwztjyig7rm7/Si2mm_Cubic_F.mat?dl=0\r\nhttps://www.dropbox.com/s/1uauouef6bbzha4/Spectrum_20380_20381.dat?dl=0\r\n```python\r\nLoadIsawPeaks(Filename='Si2mm_Cubic_F.integrate', OutputWorkspace='peaks')\r\nLoadIsawUB(InputWorkspace='peaks', Filename='Si2mm_Cubic_F.mat')\r\nSetSampleMaterial(InputWorkspace='peaks', ChemicalFormula='Si')\r\nSetDetScale(Workspace='peaks', DetScaleList=r'13:1.046504,14:1.259293,16:1.02449,17:1.18898,18:0.88014,19:0.98665,\\\r\n20:0.690458,21:0.819038,22:1.02569,23:1.08087,26:1.14672,27:1.13668,28:0.86027,29:0.92396,\\\r\n33:1.143364,34:1.01889,36:1.21876,37:1.03531,38:1.04846,39:0.77124,\\\r\n46:1.030088,47:1.05372,48:0.81623,49:5.79402')\r\nwksp = mtd['peaks']\r\nprint wksp.getInstrument().getNumberParameter(\"detScale49\")\r\nSaveHKL(InputWorkspace='peaks', Radius=0.1, Filename='new0.hkl',ApplyAnvredCorrections=True,SpectraFile='Spectrum_20380_20381.dat',ScalePeaks=0.00001)\r\n```\r\nFixes #10254\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant documentation been added/updated?\r\n- [x] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-08-24T14:24:31Z","updated_at":"2016-08-25T19:58:39Z","closed_at":"2016-08-25T19:58:38Z","merged_at":"2016-08-25T19:58:38Z","merge_commit_sha":"1ac6843da326ddb6dd9f75df95efd639a09e2030","assignee":{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreiSavici","id":1128952,"avatar_url":"https://avatars.githubusercontent.com/u/1128952?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreiSavici","html_url":"https://github.com/AndreiSavici","followers_url":"https://api.github.com/users/AndreiSavici/followers","following_url":"https://api.github.com/users/AndreiSavici/following{/other_user}","gists_url":"https://api.github.com/users/AndreiSavici/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreiSavici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreiSavici/subscriptions","organizations_url":"https://api.github.com/users/AndreiSavici/orgs","repos_url":"https://api.github.com/users/AndreiSavici/repos","events_url":"https://api.github.com/users/AndreiSavici/events{/privacy}","received_events_url":"https://api.github.com/users/AndreiSavici/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":710,"closed_issues":702,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-25T19:58:38Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17330/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17330/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17330/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/0579c4557f5645f0fefe09b0d50921a2d74ba898","head":{"label":"mantidproject:10254_DetectorScaleFactor","ref":"10254_DetectorScaleFactor","sha":"0579c4557f5645f0fefe09b0d50921a2d74ba898","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-08-22T07:35:41Z","pushed_at":"2016-08-25T19:58:38Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":435305,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1636,"forks":36,"open_issues":1636,"watchers":47,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"9f4c57e6f0295cbbc8a3becb06dd4500919f4b86","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-08-22T07:35:41Z","pushed_at":"2016-08-25T19:58:38Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":435305,"stargazers_count":47,"watchers_count":47,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1636,"forks":36,"open_issues":1636,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17330"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17330"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17330"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17330/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17330/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17330/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/0579c4557f5645f0fefe09b0d50921a2d74ba898"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":14,"additions":308,"deletions":72,"changed_files":11}}
{"actor":{"display_login":"peterfpeterson"}}