{"action":"created","issue":{"url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/31","repository_url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect","labels_url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/31/comments","events_url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/31/events","html_url":"https://github.com/nobleclem/jQuery-MultiSelect/issues/31","id":156623275,"number":31,"title":"Issue Reports","user":{"login":"SoftCircuits","id":3191331,"avatar_url":"https://avatars.githubusercontent.com/u/3191331?v=3","gravatar_id":"","url":"https://api.github.com/users/SoftCircuits","html_url":"https://github.com/SoftCircuits","followers_url":"https://api.github.com/users/SoftCircuits/followers","following_url":"https://api.github.com/users/SoftCircuits/following{/other_user}","gists_url":"https://api.github.com/users/SoftCircuits/gists{/gist_id}","starred_url":"https://api.github.com/users/SoftCircuits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SoftCircuits/subscriptions","organizations_url":"https://api.github.com/users/SoftCircuits/orgs","repos_url":"https://api.github.com/users/SoftCircuits/repos","events_url":"https://api.github.com/users/SoftCircuits/events{/privacy}","received_events_url":"https://api.github.com/users/SoftCircuits/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/labels/needs%20feedback","name":"needs feedback","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-05-24T22:23:36Z","updated_at":"2016-07-26T10:10:31Z","closed_at":null,"body":"Sorry to pester you (and thanks for accepting my other code changes), but I'm seeing a couple of other issues.\r\n\r\n#### Placeholder Text Grows without Limit\r\nIf I click the **Select All** option, all items in the list appear in the placeholder text, and the width of the placeholder container grows way too wide.\r\n\r\nLooking at the code, this line doesn't look quite right:\r\n\r\n    // if copy is larger than button width use \"# selected\"\r\n    if( copyWidth > placeWidth ) {\r\n        placeholder.text( selOpts.length + instance.options.texts.selectedOptions );\r\n    }\r\n\r\nPrior to this code, you have just created a copy of the placeholder, and then set the text of the original placeholder to hold all selected items. So how could the `copyWidth` be wider than `placeWidth`?\r\n\r\nPerhaps I'm not fully understanding the logic behind this, but would appreciate if you could look at this issue.\r\n\r\n#### Reverse Handling for Select All\r\nIf I start with a multiselect control with nothing checked, and then click the **Select All** option, all items in the list are correctly checked. But the selected items do not appear in the placeholder text. If I click the **Select All** option a second time, now all items in the list are correctly unchecked. But the selected items now *do* show up in the placeholder text.\r\n\r\nThe placeholder text and the checkmarks are now out of sync.\r\n\r\nThank you for any attention you can give these issues.\r\n"},"comment":{"url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/comments/235226014","html_url":"https://github.com/nobleclem/jQuery-MultiSelect/issues/31#issuecomment-235226014","issue_url":"https://api.github.com/repos/nobleclem/jQuery-MultiSelect/issues/31","id":235226014,"user":{"login":"GakuseiDev","id":20659612,"avatar_url":"https://avatars.githubusercontent.com/u/20659612?v=3","gravatar_id":"","url":"https://api.github.com/users/GakuseiDev","html_url":"https://github.com/GakuseiDev","followers_url":"https://api.github.com/users/GakuseiDev/followers","following_url":"https://api.github.com/users/GakuseiDev/following{/other_user}","gists_url":"https://api.github.com/users/GakuseiDev/gists{/gist_id}","starred_url":"https://api.github.com/users/GakuseiDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GakuseiDev/subscriptions","organizations_url":"https://api.github.com/users/GakuseiDev/orgs","repos_url":"https://api.github.com/users/GakuseiDev/repos","events_url":"https://api.github.com/users/GakuseiDev/events{/privacy}","received_events_url":"https://api.github.com/users/GakuseiDev/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T10:10:31Z","updated_at":"2016-07-26T10:10:31Z","body":"Hi,\r\n\r\nI encountered the same issue about the placeholder text making the button element growing with no limit but I figured out this can be fix by changing the width of the \".ms-options-wrap\" in the css files.\r\nIndeed, for specific needs in my project I added :\r\n```\r\n.ms-options-wrap {\r\n    width : 40%;\r\n    float : right;\r\n}\r\n```\r\nin the css config and now the feature works well. The placeholder text no longer grows too much. As soon as it should exceed the available place it becomes \"x selected\"."}}
{"actor":{"display_login":"GakuseiDev"}}