{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/comments/58933881","id":58933881,"diff_hunk":"@@ -8,18 +9,21 @@\n   font-weight: none;\n }\n \n-.big_number text.big {\n+.big_number text.big,\n+.big_number_total text.big{\n   stroke: black;\n   text-anchor: middle;\n   fill: black;\n }\n \n-.big_number g.tick line {\n+.big_number g.tick line,\n+.big_number_total g.tick line{\n   stroke-width: 1px;\n   stroke: grey;\n }\n \n-.big_number .domain {\n+.big_number .domain,\n+.big_number_total .domain{","path":"caravel/assets/visualizations/big_number.css","position":28,"original_position":28,"commit_id":"e0eb74f0229f87a9d845bce624e6fc0ac496becc","original_commit_id":"e0eb74f0229f87a9d845bce624e6fc0ac496becc","user":{"login":"williaster","id":4496521,"avatar_url":"https://avatars.githubusercontent.com/u/4496521?v=3","gravatar_id":"","url":"https://api.github.com/users/williaster","html_url":"https://github.com/williaster","followers_url":"https://api.github.com/users/williaster/followers","following_url":"https://api.github.com/users/williaster/following{/other_user}","gists_url":"https://api.github.com/users/williaster/gists{/gist_id}","starred_url":"https://api.github.com/users/williaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williaster/subscriptions","organizations_url":"https://api.github.com/users/williaster/orgs","repos_url":"https://api.github.com/users/williaster/repos","events_url":"https://api.github.com/users/williaster/events{/privacy}","received_events_url":"https://api.github.com/users/williaster/received_events","type":"User","site_admin":false},"body":"don't worry about changing it for this diff, but going forward I'm trying to get people to adopt dash case for css eg `.big-number-total`\r\n\r\nBEM is also an interesting approach if you feel like reading :) https://css-tricks.com/bem-101/","created_at":"2016-04-07T19:52:38Z","updated_at":"2016-04-07T19:52:38Z","html_url":"https://github.com/airbnb/caravel/pull/212#discussion_r58933881","pull_request_url":"https://api.github.com/repos/airbnb/caravel/pulls/212","_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments/58933881"},"html":{"href":"https://github.com/airbnb/caravel/pull/212#discussion_r58933881"},"pull_request":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/caravel/pulls/212","id":64557494,"html_url":"https://github.com/airbnb/caravel/pull/212","diff_url":"https://github.com/airbnb/caravel/pull/212.diff","patch_url":"https://github.com/airbnb/caravel/pull/212.patch","issue_url":"https://api.github.com/repos/airbnb/caravel/issues/212","number":212,"state":"open","locked":false,"title":"Adding a big number total viz type that is not a timeseries metric","user":{"login":"michellethomas","id":817955,"avatar_url":"https://avatars.githubusercontent.com/u/817955?v=3","gravatar_id":"","url":"https://api.github.com/users/michellethomas","html_url":"https://github.com/michellethomas","followers_url":"https://api.github.com/users/michellethomas/followers","following_url":"https://api.github.com/users/michellethomas/following{/other_user}","gists_url":"https://api.github.com/users/michellethomas/gists{/gist_id}","starred_url":"https://api.github.com/users/michellethomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellethomas/subscriptions","organizations_url":"https://api.github.com/users/michellethomas/orgs","repos_url":"https://api.github.com/users/michellethomas/repos","events_url":"https://api.github.com/users/michellethomas/events{/privacy}","received_events_url":"https://api.github.com/users/michellethomas/received_events","type":"User","site_admin":false},"body":"@williaster @mistercrunch \r\n\r\nI'm adding a new big number total viz type that uses the same d3 as the big number but it is not a timeseries metric, so it will aggregate over whatever time period is given (this will allow us to do WAUs). I've also added functionality to add descriptive text below the number. I originally tried to adjust the text size based on the length but couldn't get it to work because of the loading order of the viz. ","created_at":"2016-03-30T00:58:36Z","updated_at":"2016-04-07T19:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1bc53a5dab20f8d63dedac5bb807148d8da0b30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/caravel/pulls/212/commits","review_comments_url":"https://api.github.com/repos/airbnb/caravel/pulls/212/comments","review_comment_url":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/caravel/issues/212/comments","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/e0eb74f0229f87a9d845bce624e6fc0ac496becc","head":{"label":"airbnb:big_number_total","ref":"big_number_total","sha":"e0eb74f0229f87a9d845bce624e6fc0ac496becc","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"caravel","full_name":"airbnb/caravel","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/caravel","forks_url":"https://api.github.com/repos/airbnb/caravel/forks","keys_url":"https://api.github.com/repos/airbnb/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/caravel/teams","hooks_url":"https://api.github.com/repos/airbnb/caravel/hooks","issue_events_url":"https://api.github.com/repos/airbnb/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/caravel/events","assignees_url":"https://api.github.com/repos/airbnb/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/caravel/tags","blobs_url":"https://api.github.com/repos/airbnb/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/caravel/languages","stargazers_url":"https://api.github.com/repos/airbnb/caravel/stargazers","contributors_url":"https://api.github.com/repos/airbnb/caravel/contributors","subscribers_url":"https://api.github.com/repos/airbnb/caravel/subscribers","subscription_url":"https://api.github.com/repos/airbnb/caravel/subscription","commits_url":"https://api.github.com/repos/airbnb/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/caravel/merges","archive_url":"https://api.github.com/repos/airbnb/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/caravel/downloads","issues_url":"https://api.github.com/repos/airbnb/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/caravel/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/caravel/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-04-07T19:41:50Z","pushed_at":"2016-04-07T18:48:00Z","git_url":"git://github.com/airbnb/caravel.git","ssh_url":"git@github.com:airbnb/caravel.git","clone_url":"https://github.com/airbnb/caravel.git","svn_url":"https://github.com/airbnb/caravel","homepage":"","size":30794,"stargazers_count":4679,"watchers_count":4679,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":326,"mirror_url":null,"open_issues_count":49,"forks":326,"open_issues":49,"watchers":4679,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"bcca840f01547399a56c5273b006b2711d3df171","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"name":"caravel","full_name":"airbnb/caravel","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/caravel","description":"Caravel is a data exploration platform designed to be visual, intuitive, and interactive","fork":false,"url":"https://api.github.com/repos/airbnb/caravel","forks_url":"https://api.github.com/repos/airbnb/caravel/forks","keys_url":"https://api.github.com/repos/airbnb/caravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/caravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/caravel/teams","hooks_url":"https://api.github.com/repos/airbnb/caravel/hooks","issue_events_url":"https://api.github.com/repos/airbnb/caravel/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/caravel/events","assignees_url":"https://api.github.com/repos/airbnb/caravel/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/caravel/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/caravel/tags","blobs_url":"https://api.github.com/repos/airbnb/caravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/caravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/caravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/caravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/caravel/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/caravel/languages","stargazers_url":"https://api.github.com/repos/airbnb/caravel/stargazers","contributors_url":"https://api.github.com/repos/airbnb/caravel/contributors","subscribers_url":"https://api.github.com/repos/airbnb/caravel/subscribers","subscription_url":"https://api.github.com/repos/airbnb/caravel/subscription","commits_url":"https://api.github.com/repos/airbnb/caravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/caravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/caravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/caravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/caravel/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/caravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/caravel/merges","archive_url":"https://api.github.com/repos/airbnb/caravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/caravel/downloads","issues_url":"https://api.github.com/repos/airbnb/caravel/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/caravel/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/caravel/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/caravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/caravel/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/caravel/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/caravel/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2016-04-07T19:41:50Z","pushed_at":"2016-04-07T18:48:00Z","git_url":"git://github.com/airbnb/caravel.git","ssh_url":"git@github.com:airbnb/caravel.git","clone_url":"https://github.com/airbnb/caravel.git","svn_url":"https://github.com/airbnb/caravel","homepage":"","size":30794,"stargazers_count":4679,"watchers_count":4679,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":326,"mirror_url":null,"open_issues_count":49,"forks":326,"open_issues":49,"watchers":4679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/212"},"html":{"href":"https://github.com/airbnb/caravel/pull/212"},"issue":{"href":"https://api.github.com/repos/airbnb/caravel/issues/212"},"comments":{"href":"https://api.github.com/repos/airbnb/caravel/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/caravel/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/caravel/statuses/e0eb74f0229f87a9d845bce624e6fc0ac496becc"}}}}