{"action":"created","comment":{"url":"https://api.github.com/repos/pfrazee/beaker/pulls/comments/77649489","id":77649489,"diff_hunk":"@@ -14,5 +14,9 @@ export default {\n   uninstallPlugin: 'promise',\n \n   getHomePages: 'promise',\n-  getProtocolDescription: 'sync'\n-}\n\\ No newline at end of file\n+  getProtocolDescription: 'sync',\n+\n+  getDefaultProtocolSettings: 'sync',\n+  setAsDefaultProtocolClient: 'sync',\n+  removeAsDefaultProtocolClient: 'sync'","path":"app/background-process/api-manifests/browser.js","position":11,"original_position":11,"commit_id":"867a36fa02771d1e2bbf069fff0d284dc120ee8e","original_commit_id":"867a36fa02771d1e2bbf069fff0d284dc120ee8e","user":{"login":"pfrazee","id":1270099,"avatar_url":"https://avatars.githubusercontent.com/u/1270099?v=3","gravatar_id":"","url":"https://api.github.com/users/pfrazee","html_url":"https://github.com/pfrazee","followers_url":"https://api.github.com/users/pfrazee/followers","following_url":"https://api.github.com/users/pfrazee/following{/other_user}","gists_url":"https://api.github.com/users/pfrazee/gists{/gist_id}","starred_url":"https://api.github.com/users/pfrazee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfrazee/subscriptions","organizations_url":"https://api.github.com/users/pfrazee/orgs","repos_url":"https://api.github.com/users/pfrazee/repos","events_url":"https://api.github.com/users/pfrazee/events{/privacy}","received_events_url":"https://api.github.com/users/pfrazee/received_events","type":"User","site_admin":false},"body":"Lets make these RPC calls promises instead of sync. Even sync calls freeze the thread briefly, and, if they fail, can freeze up the program -- so I try to avoid them.","created_at":"2016-09-06T14:45:57Z","updated_at":"2016-09-06T14:45:57Z","html_url":"https://github.com/pfrazee/beaker/pull/80#discussion_r77649489","pull_request_url":"https://api.github.com/repos/pfrazee/beaker/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/comments/77649489"},"html":{"href":"https://github.com/pfrazee/beaker/pull/80#discussion_r77649489"},"pull_request":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/pfrazee/beaker/pulls/80","id":83971572,"html_url":"https://github.com/pfrazee/beaker/pull/80","diff_url":"https://github.com/pfrazee/beaker/pull/80.diff","patch_url":"https://github.com/pfrazee/beaker/pull/80.patch","issue_url":"https://api.github.com/repos/pfrazee/beaker/issues/80","number":80,"state":"open","locked":false,"title":"add open-url support","user":{"login":"poga","id":8631,"avatar_url":"https://avatars.githubusercontent.com/u/8631?v=3","gravatar_id":"","url":"https://api.github.com/users/poga","html_url":"https://github.com/poga","followers_url":"https://api.github.com/users/poga/followers","following_url":"https://api.github.com/users/poga/following{/other_user}","gists_url":"https://api.github.com/users/poga/gists{/gist_id}","starred_url":"https://api.github.com/users/poga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poga/subscriptions","organizations_url":"https://api.github.com/users/poga/orgs","repos_url":"https://api.github.com/users/poga/repos","events_url":"https://api.github.com/users/poga/events{/privacy}","received_events_url":"https://api.github.com/users/poga/received_events","type":"User","site_admin":false},"body":"In order to make this work, `background-process` need to know when `shell-window` is ready, then send `file:new-tab` command to shell-window.\r\n\r\n- add 'shell-window-ready' event to indicate shell-window is ready\r\n- add app listener for `open-url` event.\r\n- add `http` and `https` protocol to `package.json` so on OSX we can go `system perferences` -> `general` -> `default browser` and select beaker!\r\n\r\n<img width=\"279\" alt=\"2016-09-05 5 08 07\" src=\"https://cloud.githubusercontent.com/assets/8631/18242995/7879609e-738b-11e6-838e-7c578fe68009.png\">\r\n\r\nfix #77 ","created_at":"2016-09-05T09:12:03Z","updated_at":"2016-09-06T14:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c4f68c1b7fc750e598f34a214347a8e1aa7ee11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pfrazee/beaker/pulls/80/commits","review_comments_url":"https://api.github.com/repos/pfrazee/beaker/pulls/80/comments","review_comment_url":"https://api.github.com/repos/pfrazee/beaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfrazee/beaker/issues/80/comments","statuses_url":"https://api.github.com/repos/pfrazee/beaker/statuses/867a36fa02771d1e2bbf069fff0d284dc120ee8e","head":{"label":"poga:support-open-url","ref":"support-open-url","sha":"867a36fa02771d1e2bbf069fff0d284dc120ee8e","user":{"login":"poga","id":8631,"avatar_url":"https://avatars.githubusercontent.com/u/8631?v=3","gravatar_id":"","url":"https://api.github.com/users/poga","html_url":"https://github.com/poga","followers_url":"https://api.github.com/users/poga/followers","following_url":"https://api.github.com/users/poga/following{/other_user}","gists_url":"https://api.github.com/users/poga/gists{/gist_id}","starred_url":"https://api.github.com/users/poga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poga/subscriptions","organizations_url":"https://api.github.com/users/poga/orgs","repos_url":"https://api.github.com/users/poga/repos","events_url":"https://api.github.com/users/poga/events{/privacy}","received_events_url":"https://api.github.com/users/poga/received_events","type":"User","site_admin":false},"repo":{"id":67384931,"name":"beaker","full_name":"poga/beaker","owner":{"login":"poga","id":8631,"avatar_url":"https://avatars.githubusercontent.com/u/8631?v=3","gravatar_id":"","url":"https://api.github.com/users/poga","html_url":"https://github.com/poga","followers_url":"https://api.github.com/users/poga/followers","following_url":"https://api.github.com/users/poga/following{/other_user}","gists_url":"https://api.github.com/users/poga/gists{/gist_id}","starred_url":"https://api.github.com/users/poga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poga/subscriptions","organizations_url":"https://api.github.com/users/poga/orgs","repos_url":"https://api.github.com/users/poga/repos","events_url":"https://api.github.com/users/poga/events{/privacy}","received_events_url":"https://api.github.com/users/poga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poga/beaker","description":"Beaker is a browser for IPFS and Dat. It's licensed MIT, and supports plugins for adding new protocols and Web APIs.","fork":true,"url":"https://api.github.com/repos/poga/beaker","forks_url":"https://api.github.com/repos/poga/beaker/forks","keys_url":"https://api.github.com/repos/poga/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poga/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poga/beaker/teams","hooks_url":"https://api.github.com/repos/poga/beaker/hooks","issue_events_url":"https://api.github.com/repos/poga/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/poga/beaker/events","assignees_url":"https://api.github.com/repos/poga/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/poga/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/poga/beaker/tags","blobs_url":"https://api.github.com/repos/poga/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poga/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poga/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/poga/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poga/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/poga/beaker/languages","stargazers_url":"https://api.github.com/repos/poga/beaker/stargazers","contributors_url":"https://api.github.com/repos/poga/beaker/contributors","subscribers_url":"https://api.github.com/repos/poga/beaker/subscribers","subscription_url":"https://api.github.com/repos/poga/beaker/subscription","commits_url":"https://api.github.com/repos/poga/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/poga/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/poga/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/poga/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/poga/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/poga/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poga/beaker/merges","archive_url":"https://api.github.com/repos/poga/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poga/beaker/downloads","issues_url":"https://api.github.com/repos/poga/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/poga/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/poga/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/poga/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poga/beaker/labels{/name}","releases_url":"https://api.github.com/repos/poga/beaker/releases{/id}","deployments_url":"https://api.github.com/repos/poga/beaker/deployments","created_at":"2016-09-05T03:27:46Z","updated_at":"2016-09-05T03:27:48Z","pushed_at":"2016-09-06T05:58:02Z","git_url":"git://github.com/poga/beaker.git","ssh_url":"git@github.com:poga/beaker.git","clone_url":"https://github.com/poga/beaker.git","svn_url":"https://github.com/poga/beaker","homepage":"","size":4769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfrazee:master","ref":"master","sha":"34b86e7672c10aff466dbd6fee03cbfd9d538b7c","user":{"login":"pfrazee","id":1270099,"avatar_url":"https://avatars.githubusercontent.com/u/1270099?v=3","gravatar_id":"","url":"https://api.github.com/users/pfrazee","html_url":"https://github.com/pfrazee","followers_url":"https://api.github.com/users/pfrazee/followers","following_url":"https://api.github.com/users/pfrazee/following{/other_user}","gists_url":"https://api.github.com/users/pfrazee/gists{/gist_id}","starred_url":"https://api.github.com/users/pfrazee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfrazee/subscriptions","organizations_url":"https://api.github.com/users/pfrazee/orgs","repos_url":"https://api.github.com/users/pfrazee/repos","events_url":"https://api.github.com/users/pfrazee/events{/privacy}","received_events_url":"https://api.github.com/users/pfrazee/received_events","type":"User","site_admin":false},"repo":{"id":59700207,"name":"beaker","full_name":"pfrazee/beaker","owner":{"login":"pfrazee","id":1270099,"avatar_url":"https://avatars.githubusercontent.com/u/1270099?v=3","gravatar_id":"","url":"https://api.github.com/users/pfrazee","html_url":"https://github.com/pfrazee","followers_url":"https://api.github.com/users/pfrazee/followers","following_url":"https://api.github.com/users/pfrazee/following{/other_user}","gists_url":"https://api.github.com/users/pfrazee/gists{/gist_id}","starred_url":"https://api.github.com/users/pfrazee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfrazee/subscriptions","organizations_url":"https://api.github.com/users/pfrazee/orgs","repos_url":"https://api.github.com/users/pfrazee/repos","events_url":"https://api.github.com/users/pfrazee/events{/privacy}","received_events_url":"https://api.github.com/users/pfrazee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfrazee/beaker","description":"Beaker is a browser for IPFS and Dat. It's licensed MIT, and supports plugins for adding new protocols and Web APIs.","fork":false,"url":"https://api.github.com/repos/pfrazee/beaker","forks_url":"https://api.github.com/repos/pfrazee/beaker/forks","keys_url":"https://api.github.com/repos/pfrazee/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfrazee/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfrazee/beaker/teams","hooks_url":"https://api.github.com/repos/pfrazee/beaker/hooks","issue_events_url":"https://api.github.com/repos/pfrazee/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/pfrazee/beaker/events","assignees_url":"https://api.github.com/repos/pfrazee/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/pfrazee/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/pfrazee/beaker/tags","blobs_url":"https://api.github.com/repos/pfrazee/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfrazee/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfrazee/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfrazee/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfrazee/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/pfrazee/beaker/languages","stargazers_url":"https://api.github.com/repos/pfrazee/beaker/stargazers","contributors_url":"https://api.github.com/repos/pfrazee/beaker/contributors","subscribers_url":"https://api.github.com/repos/pfrazee/beaker/subscribers","subscription_url":"https://api.github.com/repos/pfrazee/beaker/subscription","commits_url":"https://api.github.com/repos/pfrazee/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfrazee/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfrazee/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfrazee/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfrazee/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/pfrazee/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfrazee/beaker/merges","archive_url":"https://api.github.com/repos/pfrazee/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfrazee/beaker/downloads","issues_url":"https://api.github.com/repos/pfrazee/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/pfrazee/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/pfrazee/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/pfrazee/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfrazee/beaker/labels{/name}","releases_url":"https://api.github.com/repos/pfrazee/beaker/releases{/id}","deployments_url":"https://api.github.com/repos/pfrazee/beaker/deployments","created_at":"2016-05-25T21:51:48Z","updated_at":"2016-09-06T11:56:37Z","pushed_at":"2016-09-06T14:42:17Z","git_url":"git://github.com/pfrazee/beaker.git","ssh_url":"git@github.com:pfrazee/beaker.git","clone_url":"https://github.com/pfrazee/beaker.git","svn_url":"https://github.com/pfrazee/beaker","homepage":"","size":4856,"stargazers_count":326,"watchers_count":326,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":30,"forks":15,"open_issues":30,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/80"},"html":{"href":"https://github.com/pfrazee/beaker/pull/80"},"issue":{"href":"https://api.github.com/repos/pfrazee/beaker/issues/80"},"comments":{"href":"https://api.github.com/repos/pfrazee/beaker/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfrazee/beaker/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/pfrazee/beaker/statuses/867a36fa02771d1e2bbf069fff0d284dc120ee8e"}}}}
{"actor":{"display_login":"pfrazee"}}