{"action":"created","issue":{"url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/74","labels_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/74/comments","events_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/74/events","html_url":"https://github.com/DamienCassou/lille-game-framework/pull/74","id":125236502,"number":74,"title":"heritage test MoveStrategyKeyboard","user":{"login":"AymericDu","id":7973460,"avatar_url":"https://avatars.githubusercontent.com/u/7973460?v=3","gravatar_id":"","url":"https://api.github.com/users/AymericDu","html_url":"https://github.com/AymericDu","followers_url":"https://api.github.com/users/AymericDu/followers","following_url":"https://api.github.com/users/AymericDu/following{/other_user}","gists_url":"https://api.github.com/users/AymericDu/gists{/gist_id}","starred_url":"https://api.github.com/users/AymericDu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AymericDu/subscriptions","organizations_url":"https://api.github.com/users/AymericDu/orgs","repos_url":"https://api.github.com/users/AymericDu/repos","events_url":"https://api.github.com/users/AymericDu/events{/privacy}","received_events_url":"https://api.github.com/users/AymericDu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-06T18:44:24Z","updated_at":"2016-01-07T05:54:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DamienCassou/lille-game-framework/pulls/74","html_url":"https://github.com/DamienCassou/lille-game-framework/pull/74","diff_url":"https://github.com/DamienCassou/lille-game-framework/pull/74.diff","patch_url":"https://github.com/DamienCassou/lille-game-framework/pull/74.patch"},"body":"--Team 5--\r\n\r\nWe noticed that the \"keyReleased\" method in \"MoveStrategyKeyboardDir\" was not tested. The problem comes from several tests in 'MoveStrategyKeyboardTest' which directly call builders of \"MoveStrategyKeyboard\". By creating the heritage of tests, we had to do builders of \"MoveStrategyKeyboard8Dir\" again. Also, these changes have highlighted an error in the \"keyReleased\" method in \"MoveStrategyKeyboard8Dir\"."},"comment":{"url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/comments/169562908","html_url":"https://github.com/DamienCassou/lille-game-framework/pull/74#issuecomment-169562908","issue_url":"https://api.github.com/repos/DamienCassou/lille-game-framework/issues/74","id":169562908,"user":{"login":"DamienCassou","id":217543,"avatar_url":"https://avatars.githubusercontent.com/u/217543?v=3","gravatar_id":"","url":"https://api.github.com/users/DamienCassou","html_url":"https://github.com/DamienCassou","followers_url":"https://api.github.com/users/DamienCassou/followers","following_url":"https://api.github.com/users/DamienCassou/following{/other_user}","gists_url":"https://api.github.com/users/DamienCassou/gists{/gist_id}","starred_url":"https://api.github.com/users/DamienCassou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DamienCassou/subscriptions","organizations_url":"https://api.github.com/users/DamienCassou/orgs","repos_url":"https://api.github.com/users/DamienCassou/repos","events_url":"https://api.github.com/users/DamienCassou/events{/privacy}","received_events_url":"https://api.github.com/users/DamienCassou/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T05:54:49Z","updated_at":"2016-01-07T05:54:49Z","body":"I think what you present are 2 separate pull requests:\r\n\r\n- test reorganization\r\n- bug fix + it's test\r\n\r\nSeparating distinct activities in distinct commits facilitates code review, reversion, and integration of these commits. It also makes historical analyses of the project more reliable (see [our paper](https://hal.inria.fr/hal-01116225))"}}