{"action":"created","comment":{"url":"https://api.github.com/repos/pulkit4tech/reel/pulls/comments/68981186","id":68981186,"diff_hunk":"@@ -27,13 +27,14 @@ def self.timers_hash\n     end\n \n     # changing/modifying configuration\n-    def self.configuration options={}\n-      if @options\n-        @options.merge! options if options.is_a? Hash\n+    def self.configuration server, options={}\n+      @options ||= {}\n+      if @options[server]\n+        @options[server].merge! options if Hash === options\n       else\n-        @options = DEFAULT_CONFIG.merge options if options.is_a? Hash\n+        @options[server] = DEFAULT_CONFIG.merge options if Hash === options\n       end\n-      @options\n+      @options[server]\n     end","path":"lib/reel/session.rb","position":17,"original_position":17,"commit_id":"8d77626154a4cbc74fd8b7908a431406e2921137","original_commit_id":"8d77626154a4cbc74fd8b7908a431406e2921137","user":{"login":"kenichi","id":933055,"avatar_url":"https://avatars.githubusercontent.com/u/933055?v=3","gravatar_id":"","url":"https://api.github.com/users/kenichi","html_url":"https://github.com/kenichi","followers_url":"https://api.github.com/users/kenichi/followers","following_url":"https://api.github.com/users/kenichi/following{/other_user}","gists_url":"https://api.github.com/users/kenichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kenichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenichi/subscriptions","organizations_url":"https://api.github.com/users/kenichi/orgs","repos_url":"https://api.github.com/users/kenichi/repos","events_url":"https://api.github.com/users/kenichi/events{/privacy}","received_events_url":"https://api.github.com/users/kenichi/received_events","type":"User","site_admin":false},"body":"all of this looks great, i'd like to see a test using different mock servers to make sure different configuration hashes are kept.","created_at":"2016-06-29T16:32:49Z","updated_at":"2016-06-29T16:32:49Z","html_url":"https://github.com/pulkit4tech/reel/pull/17#discussion_r68981186","pull_request_url":"https://api.github.com/repos/pulkit4tech/reel/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/comments/68981186"},"html":{"href":"https://github.com/pulkit4tech/reel/pull/17#discussion_r68981186"},"pull_request":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/pulkit4tech/reel/pulls/17","id":75679918,"html_url":"https://github.com/pulkit4tech/reel/pull/17","diff_url":"https://github.com/pulkit4tech/reel/pull/17.diff","patch_url":"https://github.com/pulkit4tech/reel/pull/17.patch","issue_url":"https://api.github.com/repos/pulkit4tech/reel/issues/17","number":17,"state":"open","locked":false,"title":"Tweaking configuration","user":{"login":"kenichi","id":933055,"avatar_url":"https://avatars.githubusercontent.com/u/933055?v=3","gravatar_id":"","url":"https://api.github.com/users/kenichi","html_url":"https://github.com/kenichi","followers_url":"https://api.github.com/users/kenichi/followers","following_url":"https://api.github.com/users/kenichi/following{/other_user}","gists_url":"https://api.github.com/users/kenichi/gists{/gist_id}","starred_url":"https://api.github.com/users/kenichi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenichi/subscriptions","organizations_url":"https://api.github.com/users/kenichi/orgs","repos_url":"https://api.github.com/users/kenichi/repos","events_url":"https://api.github.com/users/kenichi/events{/privacy}","received_events_url":"https://api.github.com/users/kenichi/received_events","type":"User","site_admin":false},"body":"PR for commenting, merge if ok","created_at":"2016-06-29T16:29:02Z","updated_at":"2016-06-29T16:32:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb7bbaf4f455b9fac3271433f787f3676eabdb51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulkit4tech/reel/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pulkit4tech/reel/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pulkit4tech/reel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulkit4tech/reel/issues/17/comments","statuses_url":"https://api.github.com/repos/pulkit4tech/reel/statuses/8d77626154a4cbc74fd8b7908a431406e2921137","head":{"label":"pulkit4tech:tweaking_configuration","ref":"tweaking_configuration","sha":"8d77626154a4cbc74fd8b7908a431406e2921137","user":{"login":"pulkit4tech","id":12037184,"avatar_url":"https://avatars.githubusercontent.com/u/12037184?v=3","gravatar_id":"","url":"https://api.github.com/users/pulkit4tech","html_url":"https://github.com/pulkit4tech","followers_url":"https://api.github.com/users/pulkit4tech/followers","following_url":"https://api.github.com/users/pulkit4tech/following{/other_user}","gists_url":"https://api.github.com/users/pulkit4tech/gists{/gist_id}","starred_url":"https://api.github.com/users/pulkit4tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulkit4tech/subscriptions","organizations_url":"https://api.github.com/users/pulkit4tech/orgs","repos_url":"https://api.github.com/users/pulkit4tech/repos","events_url":"https://api.github.com/users/pulkit4tech/events{/privacy}","received_events_url":"https://api.github.com/users/pulkit4tech/received_events","type":"User","site_admin":false},"repo":{"id":57428960,"name":"reel","full_name":"pulkit4tech/reel","owner":{"login":"pulkit4tech","id":12037184,"avatar_url":"https://avatars.githubusercontent.com/u/12037184?v=3","gravatar_id":"","url":"https://api.github.com/users/pulkit4tech","html_url":"https://github.com/pulkit4tech","followers_url":"https://api.github.com/users/pulkit4tech/followers","following_url":"https://api.github.com/users/pulkit4tech/following{/other_user}","gists_url":"https://api.github.com/users/pulkit4tech/gists{/gist_id}","starred_url":"https://api.github.com/users/pulkit4tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulkit4tech/subscriptions","organizations_url":"https://api.github.com/users/pulkit4tech/orgs","repos_url":"https://api.github.com/users/pulkit4tech/repos","events_url":"https://api.github.com/users/pulkit4tech/events{/privacy}","received_events_url":"https://api.github.com/users/pulkit4tech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pulkit4tech/reel","description":"Celluloid::IO-powered web server","fork":true,"url":"https://api.github.com/repos/pulkit4tech/reel","forks_url":"https://api.github.com/repos/pulkit4tech/reel/forks","keys_url":"https://api.github.com/repos/pulkit4tech/reel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulkit4tech/reel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulkit4tech/reel/teams","hooks_url":"https://api.github.com/repos/pulkit4tech/reel/hooks","issue_events_url":"https://api.github.com/repos/pulkit4tech/reel/issues/events{/number}","events_url":"https://api.github.com/repos/pulkit4tech/reel/events","assignees_url":"https://api.github.com/repos/pulkit4tech/reel/assignees{/user}","branches_url":"https://api.github.com/repos/pulkit4tech/reel/branches{/branch}","tags_url":"https://api.github.com/repos/pulkit4tech/reel/tags","blobs_url":"https://api.github.com/repos/pulkit4tech/reel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulkit4tech/reel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulkit4tech/reel/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulkit4tech/reel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulkit4tech/reel/statuses/{sha}","languages_url":"https://api.github.com/repos/pulkit4tech/reel/languages","stargazers_url":"https://api.github.com/repos/pulkit4tech/reel/stargazers","contributors_url":"https://api.github.com/repos/pulkit4tech/reel/contributors","subscribers_url":"https://api.github.com/repos/pulkit4tech/reel/subscribers","subscription_url":"https://api.github.com/repos/pulkit4tech/reel/subscription","commits_url":"https://api.github.com/repos/pulkit4tech/reel/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulkit4tech/reel/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulkit4tech/reel/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulkit4tech/reel/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulkit4tech/reel/contents/{+path}","compare_url":"https://api.github.com/repos/pulkit4tech/reel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulkit4tech/reel/merges","archive_url":"https://api.github.com/repos/pulkit4tech/reel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulkit4tech/reel/downloads","issues_url":"https://api.github.com/repos/pulkit4tech/reel/issues{/number}","pulls_url":"https://api.github.com/repos/pulkit4tech/reel/pulls{/number}","milestones_url":"https://api.github.com/repos/pulkit4tech/reel/milestones{/number}","notifications_url":"https://api.github.com/repos/pulkit4tech/reel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulkit4tech/reel/labels{/name}","releases_url":"https://api.github.com/repos/pulkit4tech/reel/releases{/id}","deployments_url":"https://api.github.com/repos/pulkit4tech/reel/deployments","created_at":"2016-04-30T05:43:06Z","updated_at":"2016-04-30T05:43:07Z","pushed_at":"2016-06-29T16:31:35Z","git_url":"git://github.com/pulkit4tech/reel.git","ssh_url":"git@github.com:pulkit4tech/reel.git","clone_url":"https://github.com/pulkit4tech/reel.git","svn_url":"https://github.com/pulkit4tech/reel","homepage":"https://celluloid.io","size":705,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"pulkit4tech:deleting_session","ref":"deleting_session","sha":"4788b63d5d0044e3491bfcadb4d880acf0c96edc","user":{"login":"pulkit4tech","id":12037184,"avatar_url":"https://avatars.githubusercontent.com/u/12037184?v=3","gravatar_id":"","url":"https://api.github.com/users/pulkit4tech","html_url":"https://github.com/pulkit4tech","followers_url":"https://api.github.com/users/pulkit4tech/followers","following_url":"https://api.github.com/users/pulkit4tech/following{/other_user}","gists_url":"https://api.github.com/users/pulkit4tech/gists{/gist_id}","starred_url":"https://api.github.com/users/pulkit4tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulkit4tech/subscriptions","organizations_url":"https://api.github.com/users/pulkit4tech/orgs","repos_url":"https://api.github.com/users/pulkit4tech/repos","events_url":"https://api.github.com/users/pulkit4tech/events{/privacy}","received_events_url":"https://api.github.com/users/pulkit4tech/received_events","type":"User","site_admin":false},"repo":{"id":57428960,"name":"reel","full_name":"pulkit4tech/reel","owner":{"login":"pulkit4tech","id":12037184,"avatar_url":"https://avatars.githubusercontent.com/u/12037184?v=3","gravatar_id":"","url":"https://api.github.com/users/pulkit4tech","html_url":"https://github.com/pulkit4tech","followers_url":"https://api.github.com/users/pulkit4tech/followers","following_url":"https://api.github.com/users/pulkit4tech/following{/other_user}","gists_url":"https://api.github.com/users/pulkit4tech/gists{/gist_id}","starred_url":"https://api.github.com/users/pulkit4tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulkit4tech/subscriptions","organizations_url":"https://api.github.com/users/pulkit4tech/orgs","repos_url":"https://api.github.com/users/pulkit4tech/repos","events_url":"https://api.github.com/users/pulkit4tech/events{/privacy}","received_events_url":"https://api.github.com/users/pulkit4tech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pulkit4tech/reel","description":"Celluloid::IO-powered web server","fork":true,"url":"https://api.github.com/repos/pulkit4tech/reel","forks_url":"https://api.github.com/repos/pulkit4tech/reel/forks","keys_url":"https://api.github.com/repos/pulkit4tech/reel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulkit4tech/reel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulkit4tech/reel/teams","hooks_url":"https://api.github.com/repos/pulkit4tech/reel/hooks","issue_events_url":"https://api.github.com/repos/pulkit4tech/reel/issues/events{/number}","events_url":"https://api.github.com/repos/pulkit4tech/reel/events","assignees_url":"https://api.github.com/repos/pulkit4tech/reel/assignees{/user}","branches_url":"https://api.github.com/repos/pulkit4tech/reel/branches{/branch}","tags_url":"https://api.github.com/repos/pulkit4tech/reel/tags","blobs_url":"https://api.github.com/repos/pulkit4tech/reel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulkit4tech/reel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulkit4tech/reel/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulkit4tech/reel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulkit4tech/reel/statuses/{sha}","languages_url":"https://api.github.com/repos/pulkit4tech/reel/languages","stargazers_url":"https://api.github.com/repos/pulkit4tech/reel/stargazers","contributors_url":"https://api.github.com/repos/pulkit4tech/reel/contributors","subscribers_url":"https://api.github.com/repos/pulkit4tech/reel/subscribers","subscription_url":"https://api.github.com/repos/pulkit4tech/reel/subscription","commits_url":"https://api.github.com/repos/pulkit4tech/reel/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulkit4tech/reel/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulkit4tech/reel/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulkit4tech/reel/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulkit4tech/reel/contents/{+path}","compare_url":"https://api.github.com/repos/pulkit4tech/reel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulkit4tech/reel/merges","archive_url":"https://api.github.com/repos/pulkit4tech/reel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulkit4tech/reel/downloads","issues_url":"https://api.github.com/repos/pulkit4tech/reel/issues{/number}","pulls_url":"https://api.github.com/repos/pulkit4tech/reel/pulls{/number}","milestones_url":"https://api.github.com/repos/pulkit4tech/reel/milestones{/number}","notifications_url":"https://api.github.com/repos/pulkit4tech/reel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulkit4tech/reel/labels{/name}","releases_url":"https://api.github.com/repos/pulkit4tech/reel/releases{/id}","deployments_url":"https://api.github.com/repos/pulkit4tech/reel/deployments","created_at":"2016-04-30T05:43:06Z","updated_at":"2016-04-30T05:43:07Z","pushed_at":"2016-06-29T16:31:35Z","git_url":"git://github.com/pulkit4tech/reel.git","ssh_url":"git@github.com:pulkit4tech/reel.git","clone_url":"https://github.com/pulkit4tech/reel.git","svn_url":"https://github.com/pulkit4tech/reel","homepage":"https://celluloid.io","size":705,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/17"},"html":{"href":"https://github.com/pulkit4tech/reel/pull/17"},"issue":{"href":"https://api.github.com/repos/pulkit4tech/reel/issues/17"},"comments":{"href":"https://api.github.com/repos/pulkit4tech/reel/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulkit4tech/reel/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pulkit4tech/reel/statuses/8d77626154a4cbc74fd8b7908a431406e2921137"}}}}
{"actor":{"display_login":"kenichi"}}