{"push_id":1048039366,"size":18,"distinct_size":18,"ref":"refs/heads/master","head":"44f399768a39865f28d9a73daea8f08297f852fe","before":"7231803ffd6a4677ee82a4e2f8f3c6d69dfe9f04","commits":[{"sha":"f36688382fb513f10e20444df3e71886badf7e2a","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Reindex: Support generic indexes\n\nThe only remaining change-specific code is the command line options;\nwe still need to add one option per new index we add.\n\nChange-Id: I8d5b27bb73bac5286c31ca6b01e6f3b3d2fdb744","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/f36688382fb513f10e20444df3e71886badf7e2a"},{"sha":"12b82499579b3d2adcc8bd616a18582664946074","author":{"email":"3269a793d567baa2fa5b041e3e5e0a5039790a2f@google.com","name":"Han-Wen Nienhuys"},"message":"PolyGerrit: use more explicit filenames for globbing files under app/test/ .\n\nThis prevents administrative editor files (backups, etc.) from\ninterfering with Buck.\n\nChange-Id: Ie5dd6e981f4cab9e543ccf27b117da3b3fd8f34f","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/12b82499579b3d2adcc8bd616a18582664946074"},{"sha":"b72d544130735a0ba441a4d5438bf33457a6cfa2","author":{"email":"3269a793d567baa2fa5b041e3e5e0a5039790a2f@google.com","name":"Han-Wen Nienhuys"},"message":"PolyGerrit: introduce gr-account-chip which supports a remove button.\n\nBug: Issue 3917\nChange-Id: Ibe4d62786b0625bad34e651b715a2085c4a2da52","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/b72d544130735a0ba441a4d5438bf33457a6cfa2"},{"sha":"dc86ab526e6c58a94cad8c8c33effb16f8b5bfd9","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Fix PUBLISH_ALL_REVISIONS in NoteDb\n\nThere was a bug in the PUBLISH_ALL_REVISIONS case where we passed the\nwrong PatchSet to PatchLineCommentsUtil.setCommentRevId, resulting in\nsaving comments on the wrong side. Add a checkArgument to\nsetCommentRevId that exposes this error, and fix it by passing the\nright PatchSet object. This means we may have to look up additional\nPatchSets for the change when writing to NoteDb. There is no way\naround this: if we publish a comment for PS1 when posting a review\nfor PS2, we have not previously loaded PS1 to get the RevId, so we\nneed to do that now.\n\nTest in CommentsIT for publishing comments on both sides\nsimultaneously.\n\nChange-Id: Idbbc8d905a9e37ca6be9d45f8bddd0ca1fe0b248","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/dc86ab526e6c58a94cad8c8c33effb16f8b5bfd9"},{"sha":"f449ad4ce72c3870edcdb77003f21bb8216d7744","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"NoteDbChecker: Refactor to support checking without rebuilding\n\nChange-Id: Idd6a154b25dc7e54bb8105ab8e75b4c36560422c","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/f449ad4ce72c3870edcdb77003f21bb8216d7744"},{"sha":"d2c9c2ed936faac252ef465c4364da9236b53527","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"NoteDb: Avoid writing partial change graphs\n\nIf we naively turn on notedb.writeChanges without previously running\nRebuildNoteDb to backfill existing changes, a single ChangeUpdate may\nend up writing a partial note graph, for example containing a single\ncommit with only a \"Topic\" field and no other information. Such a\npartial graph will almost certainly fail to parse; better to avoid\nwriting them out in the first place.\n\nTeach NoteDbUpdateManager to skip writing updates unless the first\nupdate in the list has a special allowWriteToNewRef. This means\nwriting a change will automatically \"turn on\" on a per-change basis as\nsoon as a backfill is completed, whether in a running server or in\nbetween restarts.\n\nThere are three cases where we want to allow writing updates to new\nrefs:\n - Any ChangeDraftUpdate, since having a \"partial\" draft notes ref\n   doesn't cause parsing to fail, and executing the same update\n   multiple times is idempotent with respect to the note data.\n - A ChangeUpdate that creates a change for the first time, which is\n   by definition not a partial graph. This is handled in BatchUpdate,\n   which already knows which ChangeUpdates correspond to new changes.\n - In ChangeRebuilder, which again is guaranteed to write a complete\n   graph.\n\nChange-Id: Ic8c6c28e68aef22be7569d2b0cb409eae22e3034","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/d2c9c2ed936faac252ef465c4364da9236b53527"},{"sha":"d625218ab3f79ac604f9826d7124fbd18e2abda8","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Add REST API endpoint to rebuild changes in NoteDb\n\nReturns 404 if NoteDb is disabled, and is intentionally undocumented.\n\nChange-Id: I7a00f8364df5c0bd215697845657b6dd5fef8be6","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/d625218ab3f79ac604f9826d7124fbd18e2abda8"},{"sha":"fcac9455339383327338136ffca8558b9025d1c2","author":{"email":"a7f3b1612c245dae606b3b9617b4f52187fddb65@google.com","name":"Stefan Beller"},"message":"SubmoduleOp: make superProjectSubscriptionsForSubmoduleBranch public\n\nWe need access to that method in the delete-project plugin,\nsee I456346f67dac4d906fcd016b2dad5fea12459150.\n\nRefactor SubmoduleOp and GitModules in a way that we convert IOExceptions\nto SubmoduleException late instead of in each method. By doing that we\ndo not need to expose the SubmoduleException for\nsuperProjectSubscriptionsForSubmoduleBranch.\n\nChange-Id: Ic6c05fad9f8581b132f17eebb624d6aa2362bd00\nSigned-off-by: Stefan Beller <sbeller@google.com>","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/fcac9455339383327338136ffca8558b9025d1c2"},{"sha":"a9c96339f8d8215619f463b2eea696f56455f3b1","author":{"email":"28b26a7f2d02f59edbe1a8798a1135f2e2d7db0c@gmail.com","name":"Saša Živkov"},"message":"Merge \"Reindex: Support generic indexes\"","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/a9c96339f8d8215619f463b2eea696f56455f3b1"},{"sha":"5cc94ac915f55f8caa97d0682ac794405f5d4cde","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Merge changes from topics 'notedb-endpoint', 'notedb-partial-write', 'notedb-publish-all-revisions'\n\n* changes:\n  Add REST API endpoint to rebuild changes in NoteDb\n  NoteDb: Avoid writing partial change graphs\n  NoteDbChecker: Refactor to support checking without rebuilding\n  Fix PUBLISH_ALL_REVISIONS in NoteDb","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/5cc94ac915f55f8caa97d0682ac794405f5d4cde"},{"sha":"6bf36088348f16d245b85fd8e56f9b2a7393c047","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Merge \"SubmoduleOp: make superProjectSubscriptionsForSubmoduleBranch public\"","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/6bf36088348f16d245b85fd8e56f9b2a7393c047"},{"sha":"65476a5660482c8e86fa4e80a9d34db7669dea0d","author":{"email":"ac39666f39dfa5b37bad5e19ae3f186528808854@google.com","name":"Dave Borowitz"},"message":"Merge \"PolyGerrit: use more explicit filenames for globbing files under app/test/ .\"","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/65476a5660482c8e86fa4e80a9d34db7669dea0d"},{"sha":"782e6ddbc85431baa88a301924a2edd6e354051c","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Coerce relative preference into boolean to fix time not showing\n\nSome properties within preferences and other REST responses are not\nset when they have a false value. This can cause issues when a\nPolymer computed value relies on the value to be !== undefined.\n\nChange-Id: I8d20f3576a015b76c67f3436f753de29f529c3c5","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/782e6ddbc85431baa88a301924a2edd6e354051c"},{"sha":"eedd8a3b9bc5167f5b00e218c677d0682d83d360","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Merge \"PolyGerrit: introduce gr-account-chip which supports a remove button.\"","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/eedd8a3b9bc5167f5b00e218c677d0682d83d360"},{"sha":"791f33909065d5041c4110f17fceb5f8b0ab1c99","author":{"email":"b7d2b1bc786b4d0774f17ea6ad686cd694f288c7@codeaurora.org","name":"Raviteja Sunkara"},"message":"Add a way to change the destination of open changes\n\nWhen the development is moved from one branch to next in a git project\nand we want to get all the open changes from old branch to the new branch,\nwe have to create a new copy of those changes for the new branch.\n\nSince these changes are not required on the old branch, moving would be\na better fit than other propagation methods (cherrypicking, manual upload).\n\nThis change provides a REST API '/changes/{change-id}/move' to\nmove an open change to a different branch.\n\nChange-Id: I44c68be1d08e2e1f4eab4e4f1724047f20072ac3","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/791f33909065d5041c4110f17fceb5f8b0ab1c99"},{"sha":"941da77c1190ae53c5a531c8765a0f6ce6c95079","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Cleanup gr-account-chip\n\nChange-Id: I4ad4c5929b193a3eb46378896658191317772c89","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/941da77c1190ae53c5a531c8765a0f6ce6c95079"},{"sha":"247144205a064d8ff81b3138a2dd4554067fd85f","author":{"email":"682ad9f487f614f19e8b7cc5d340bdc8e1c1b128@chromium.org","name":"Andrew Bonventre"},"message":"Merge \"Cleanup gr-account-chip\"","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/247144205a064d8ff81b3138a2dd4554067fd85f"},{"sha":"44f399768a39865f28d9a73daea8f08297f852fe","author":{"email":"d97133394f73ea329221f93b2759894ae8bf31ce@gmail.com","name":"joshuawilson"},"message":"Merge remote-tracking branch 'gerrit/master'","distinct":true,"url":"https://api.github.com/repos/joshuawilson/merrit/commits/44f399768a39865f28d9a73daea8f08297f852fe"}]}