{"action":"created","issue":{"url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/811","repository_url":"https://api.github.com/repos/sparkle-project/Sparkle","labels_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/811/labels{/name}","comments_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/811/comments","events_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/811/events","html_url":"https://github.com/sparkle-project/Sparkle/pull/811","id":155165082,"number":811,"title":"bsdiff fixes","user":{"login":"zorgiepoo","id":857267,"avatar_url":"https://avatars.githubusercontent.com/u/857267?v=3","gravatar_id":"","url":"https://api.github.com/users/zorgiepoo","html_url":"https://github.com/zorgiepoo","followers_url":"https://api.github.com/users/zorgiepoo/followers","following_url":"https://api.github.com/users/zorgiepoo/following{/other_user}","gists_url":"https://api.github.com/users/zorgiepoo/gists{/gist_id}","starred_url":"https://api.github.com/users/zorgiepoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorgiepoo/subscriptions","organizations_url":"https://api.github.com/users/zorgiepoo/orgs","repos_url":"https://api.github.com/users/zorgiepoo/repos","events_url":"https://api.github.com/users/zorgiepoo/events{/privacy}","received_events_url":"https://api.github.com/users/zorgiepoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-17T02:42:05Z","updated_at":"2016-05-17T02:55:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sparkle-project/Sparkle/pulls/811","html_url":"https://github.com/sparkle-project/Sparkle/pull/811","diff_url":"https://github.com/sparkle-project/Sparkle/pull/811.diff","patch_url":"https://github.com/sparkle-project/Sparkle/pull/811.patch"},"body":"1. Fix and don't hide compiler warnings for bspatch or bsdiff (can we please decide not to do this for files in the future?)\r\n2. Use `FILE*` fread/fwrite functions instead of read() and write() to resolve #810\r\n3. Change `err()`/`errx()` to use `warn()`/`warnx()`, cleanup, and return. Since we are invoking bsdiff/bspatch ourselves, we want to handle failures gracefully."},"comment":{"url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/comments/219606895","html_url":"https://github.com/sparkle-project/Sparkle/pull/811#issuecomment-219606895","issue_url":"https://api.github.com/repos/sparkle-project/Sparkle/issues/811","id":219606895,"user":{"login":"zorgiepoo","id":857267,"avatar_url":"https://avatars.githubusercontent.com/u/857267?v=3","gravatar_id":"","url":"https://api.github.com/users/zorgiepoo","html_url":"https://github.com/zorgiepoo","followers_url":"https://api.github.com/users/zorgiepoo/followers","following_url":"https://api.github.com/users/zorgiepoo/following{/other_user}","gists_url":"https://api.github.com/users/zorgiepoo/gists{/gist_id}","starred_url":"https://api.github.com/users/zorgiepoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorgiepoo/subscriptions","organizations_url":"https://api.github.com/users/zorgiepoo/orgs","repos_url":"https://api.github.com/users/zorgiepoo/repos","events_url":"https://api.github.com/users/zorgiepoo/events{/privacy}","received_events_url":"https://api.github.com/users/zorgiepoo/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T02:55:11Z","updated_at":"2016-05-17T02:55:11Z","body":"As far as I can tell, bsdiff isn't maintained and there are only significant forks out there (ours is a significant fork too, even prior to these changes). One of the reasons why I want to look into xdelta at some point."}}