{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4184","repository_url":"https://api.github.com/repos/w3c/web-platform-tests","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4184/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4184/comments","events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4184/events","html_url":"https://github.com/w3c/web-platform-tests/pull/4184","id":188122939,"number":4184,"title":"Update Windows instructions in README.md","user":{"login":"thejohnjansen","id":2119039,"avatar_url":"https://avatars.githubusercontent.com/u/2119039?v=3","gravatar_id":"","url":"https://api.github.com/users/thejohnjansen","html_url":"https://github.com/thejohnjansen","followers_url":"https://api.github.com/users/thejohnjansen/followers","following_url":"https://api.github.com/users/thejohnjansen/following{/other_user}","gists_url":"https://api.github.com/users/thejohnjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/thejohnjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thejohnjansen/subscriptions","organizations_url":"https://api.github.com/users/thejohnjansen/orgs","repos_url":"https://api.github.com/users/thejohnjansen/repos","events_url":"https://api.github.com/users/thejohnjansen/events{/privacy}","received_events_url":"https://api.github.com/users/thejohnjansen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-08T22:36:02Z","updated_at":"2016-11-25T02:21:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4184","html_url":"https://github.com/w3c/web-platform-tests/pull/4184","diff_url":"https://github.com/w3c/web-platform-tests/pull/4184.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/4184.patch"},"body":"* Update readme for windows\r\n\r\nI had a tough time getting this working on windows. Updated readme to\r\nhelp."},"comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments/262868214","html_url":"https://github.com/w3c/web-platform-tests/pull/4184#issuecomment-262868214","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4184","id":262868214,"user":{"login":"sideshowbarker","id":194984,"avatar_url":"https://avatars.githubusercontent.com/u/194984?v=3","gravatar_id":"","url":"https://api.github.com/users/sideshowbarker","html_url":"https://github.com/sideshowbarker","followers_url":"https://api.github.com/users/sideshowbarker/followers","following_url":"https://api.github.com/users/sideshowbarker/following{/other_user}","gists_url":"https://api.github.com/users/sideshowbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/sideshowbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sideshowbarker/subscriptions","organizations_url":"https://api.github.com/users/sideshowbarker/orgs","repos_url":"https://api.github.com/users/sideshowbarker/repos","events_url":"https://api.github.com/users/sideshowbarker/events{/privacy}","received_events_url":"https://api.github.com/users/sideshowbarker/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T02:21:58Z","updated_at":"2016-11-25T02:21:58Z","body":"@thejohnjansen seems the “Add ECMAScript 6 Modules test cases” change (https://github.com/w3c/web-platform-tests/pull/4184/commits/e6fdc7d91a288d29ca07257ff74b87acb97a3928 / https://github.com/w3c/web-platform-tests/pull/4184/commits/360d873e28174948f1ee2ba4b4ea110619cc9ec4) got inadvertently committed to the branch. I guess that happened because the PR was made from the `master` branch of https://github.com/MicrosoftEdge/web-platform-tests.\r\n\r\nTo prevent things like this, it’s always better to create a branch in your wpt fork for each PR and commit there instead of `master`, and then open the PR from that non-`master` branch.\r\n\r\nIf you want, I can fix this so we can merge this PR, but it means I would need to force-push to the https://github.com/MicrosoftEdge/web-platform-tests `master` branch to cause the “Add ECMAScript 6 Modules test cases” change (https://github.com/MicrosoftEdge/web-platform-tests/commit/e6fdc7d91a288d29ca07257ff74b87acb97a3928) to be (temporarily) dropped from it.\r\n\r\nAfter I did that and merge this PR you’d need to pull from https://github.com/MicrosoftEdge/web-platform-tests and then re-merge that “ES6 Modules test cases” change to `master` there again.\r\n\r\nIf you prefer to do it yourself (rather me being the one doing the force-push), what you’d need to is:\r\n\r\n1. `git rebase -i 2782308f4187e73043324272552cf1bd90edc784`\r\n   Your text editor will open and show you something like this:  <img width=\"545\" alt=\"untitled\" src=\"https://cloud.githubusercontent.com/assets/194984/20612639/66756088-b2ff-11e6-8056-5b23b8e4c0a8.png\">\r\n\r\n2. Change the above in your text editor so it looks like this: <img width=\"543\" alt=\"untitled\" src=\"https://cloud.githubusercontent.com/assets/194984/20612701/f2405546-b2ff-11e6-8bc5-bc38f9431646.png\">\r\n\r\n   That is, change the `pick e6fdc7d Add ECMAScript 6 Modules test cases` line to:\r\n   `d e6fdc7d Add ECMAScript 6 Modules test cases`\r\n    …and change the `pick 50a9973 Code review feedback` line to:\r\n    `s 50a9973 Code review feedback`\r\n\r\n3. Save and close your editor.\r\n    Your editor will re-open. Just save what it shows as-is and close.\r\n\r\n4. `git push -f`\r\n\r\nAfter that we merge this PR but you’d still need to pull from https://github.com/MicrosoftEdge/web-platform-tests and then re-merge that “ES6 Modules test cases” change to `master` there again.\r\n"}}
{"actor":{"display_login":"sideshowbarker"}}