{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/3824","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/3824/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3824/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/3824/events","html_url":"https://github.com/theforeman/foreman/pull/3824","id":175526091,"number":3824,"title":"Fixes #16463 - Fix with_taxonomy_scope when taxable_ids = []","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman/labels/Ready%20to%20merge","name":"Ready to merge","color":"bfe5bf"}],"state":"open","locked":false,"assignee":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"assignees":[{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-07T15:00:54Z","updated_at":"2016-09-08T08:34:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3824","html_url":"https://github.com/theforeman/foreman/pull/3824","diff_url":"https://github.com/theforeman/foreman/pull/3824.diff","patch_url":"https://github.com/theforeman/foreman/pull/3824.patch"},"body":"The old implementation of taxonomy_scope was relying on calling\r\n`scope.where(:id => [])`, it did it 'if taxable_ids'. A recent change\r\nintroduced more checking into that condition (taxable_ids.present?)\r\nwhich made the case when taxable_ids == [] not run any scope.\r\n\r\nThat results in objects not being scoped at all when taxable_ids\r\nis an empty array.\r\n\r\nTo reproduce, simply go to any page with scoped content, like\r\nsmart proxies or compute resources, and see how the scoped content\r\nstill shows up when choosing the wrong taxonomy.\r\n\r\n![](http://i.imgur.com/Qu4zSk6.png)"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/245530399","html_url":"https://github.com/theforeman/foreman/pull/3824#issuecomment-245530399","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3824","id":245530399,"user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"created_at":"2016-09-08T08:34:55Z","updated_at":"2016-09-08T08:34:55Z","body":"Green! @ares "}}
{"actor":{"display_login":"dLobatog"}}