{"action":"closed","number":4381,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381","id":99011644,"html_url":"https://github.com/w3c/web-platform-tests/pull/4381","diff_url":"https://github.com/w3c/web-platform-tests/pull/4381.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/4381.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4381","number":4381,"state":"closed","locked":false,"title":"Sync requestFullscreen() and exitFullscreen() algorithms with the spec\n","user":{"login":"jeffcarp","id":916028,"avatar_url":"https://avatars.githubusercontent.com/u/916028?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffcarp","html_url":"https://github.com/jeffcarp","followers_url":"https://api.github.com/users/jeffcarp/followers","following_url":"https://api.github.com/users/jeffcarp/following{/other_user}","gists_url":"https://api.github.com/users/jeffcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffcarp/subscriptions","organizations_url":"https://api.github.com/users/jeffcarp/orgs","repos_url":"https://api.github.com/users/jeffcarp/repos","events_url":"https://api.github.com/users/jeffcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jeffcarp/received_events","type":"User","site_admin":false},"body":"The central change is the timing for when the fullscreen element stack\nis modified and when the events fire. This makes it possible to make\nwebkitCurrentFullScreenElement an alias of fullscreenElement, as the old\nnotion of a single fullscreen element is gone.\n\nPreviously, fullscreen requests did:\n 1. In Fullscreen::requestFullscreen(), synchronously modify\n    m_fullscreenElementStack, visible in document.fullscreenElement, but\n    not document.webkitCurrentFullScreenElement. Also enqueue events to\n    fire, without starting the timer to fire them.\n 2. As soon as the resize happens, in Fullscreen::didEnterFullscreen(),\n    set m_currentFullScreenElement, affecting :-webkit-full-screen\n    document.webkitCurrentFullScreenElement. Start the event timer.\n 3. When the timer fires, events are dispatched. If the tree has changed\n    since the events were enqueued, additional events may be fired.\n\nAnd similarly for exit. For errors, requestFullscreen() would itself\nstart the timer to fire the events.\n\nNow, fullscreen requests will:\n 1. In Fullscreen::requestFullscreen(), append to a list of pending\n    requests.\n 2. When the resize happens, enqueue an animation frame task for each\n    pending request.\n 3. In the animation frame task, apply all changes, decide which events\n    to fire and then fire them.\n\nTEST=run-webkit-tests fullscreen/ imported/wpt/fullscreen/\n     webkit_unit_tests --gtest_filter=*Fullscreen*\n     interactive_ui_tests --gtest_filter=SitePerProcessInteractiveBrowserTest.Fullscreen*\nBUG=402376,402421\nCQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2\n\nReview-Url: https://codereview.chromium.org/2573773002\nCr-Commit-Position: refs/heads/master@{#439607}\n\n","created_at":"2016-12-21T21:55:12Z","updated_at":"2016-12-21T22:05:12Z","closed_at":"2016-12-21T22:05:12Z","merged_at":"2016-12-21T22:05:11Z","merge_commit_sha":"59fa71ecf0f7e6e1d5c283309ccb6d623aaab893","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4381/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/916eea43083b0815cfe5afa139fef534849597d4","head":{"label":"w3c:chromium-export-try","ref":"chromium-export-try","sha":"916eea43083b0815cfe5afa139fef534849597d4","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-12-20T01:28:52Z","pushed_at":"2016-12-21T22:05:11Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":169793,"stargazers_count":903,"watchers_count":903,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":438,"forks":982,"open_issues":438,"watchers":903,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"dd5544fa666a77a69b39a2e30fa84ad588ac097d","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-12-20T01:28:52Z","pushed_at":"2016-12-21T22:05:11Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":169793,"stargazers_count":903,"watchers_count":903,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":438,"forks":982,"open_issues":438,"watchers":903,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/4381"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4381"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4381/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4381/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/916eea43083b0815cfe5afa139fef534849597d4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeffcarp","id":916028,"avatar_url":"https://avatars.githubusercontent.com/u/916028?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffcarp","html_url":"https://github.com/jeffcarp","followers_url":"https://api.github.com/users/jeffcarp/followers","following_url":"https://api.github.com/users/jeffcarp/following{/other_user}","gists_url":"https://api.github.com/users/jeffcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffcarp/subscriptions","organizations_url":"https://api.github.com/users/jeffcarp/orgs","repos_url":"https://api.github.com/users/jeffcarp/repos","events_url":"https://api.github.com/users/jeffcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jeffcarp/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jeffcarp"}}