{"action":"closed","number":2947,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947","id":72599780,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2947","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2947.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/2947.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2947","number":2947,"state":"closed","locked":false,"title":"Fix #2918 Make dispensers with buckets work with modded fluids","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"body":"Tested many variations.\r\n\r\nIf the universal bucket is registered, everything can be picked up and placed.\r\nIf it isn't, the vanilla fluids can be picked up and placed, but the modded ones cannot. The empty bucket is ejected as an item instead of turning modded fluids into water or lava.\r\n\r\nIf milk is registered as a fluid block, it can be placed and picked up. If it is not, the milk bucket is ejected as an item.\r\n\r\nAll of these behaviors are abstracted away by IFluidHandler, you can see the logic here has no special cases.","created_at":"2016-06-04T10:54:21Z","updated_at":"2016-06-18T23:29:28Z","closed_at":"2016-06-18T23:29:28Z","merged_at":"2016-06-18T23:29:28Z","merge_commit_sha":"eca97de272d49e430f407559f2173af32b0c6787","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2947/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/919bb66bac8c43b6ef67cf0049ea7edadc9b329a","head":{"label":"mezz:dispenser","ref":"dispenser","sha":"919bb66bac8c43b6ef67cf0049ea7edadc9b329a","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"repo":{"id":22802638,"name":"MinecraftForge","full_name":"mezz/MinecraftForge","owner":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mezz/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/mezz/MinecraftForge","forks_url":"https://api.github.com/repos/mezz/MinecraftForge/forks","keys_url":"https://api.github.com/repos/mezz/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mezz/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mezz/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/mezz/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/mezz/MinecraftForge/events","assignees_url":"https://api.github.com/repos/mezz/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/mezz/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/mezz/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mezz/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/mezz/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mezz/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/mezz/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/mezz/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/mezz/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/mezz/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/mezz/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/mezz/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/mezz/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/mezz/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/mezz/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/mezz/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mezz/MinecraftForge/merges","archive_url":"https://api.github.com/repos/mezz/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mezz/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/mezz/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/mezz/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/mezz/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/mezz/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mezz/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/mezz/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/mezz/MinecraftForge/deployments","created_at":"2014-08-10T05:48:41Z","updated_at":"2016-05-06T23:35:24Z","pushed_at":"2016-06-18T03:48:12Z","git_url":"git://github.com/mezz/MinecraftForge.git","ssh_url":"git@github.com:mezz/MinecraftForge.git","clone_url":"https://github.com/mezz/MinecraftForge.git","svn_url":"https://github.com/mezz/MinecraftForge","homepage":"","size":86996,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"9cd2c697e5a56c2b9b3318bfd5f3d47639a61524","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-06-18T18:36:58Z","pushed_at":"2016-06-18T23:29:28Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":150035,"stargazers_count":1425,"watchers_count":1425,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":791,"mirror_url":null,"open_issues_count":239,"forks":791,"open_issues":239,"watchers":1425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/2947"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2947"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/2947/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/2947/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/919bb66bac8c43b6ef67cf0049ea7edadc9b329a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":121,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"LexManos"}}