{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/55703000","id":55703000,"diff_hunk":"@@ -0,0 +1,11 @@\n+-----BEGIN CERTIFICATE-----\n+MIIBpTCCAQ6gAwIBAgIIKnZDlD8+8K4wDQYJKoZIhvcNAQENBQAwFDESMBAGA1UE\n+AwwJbG9jYWxob3N0MCAXDTE1MDIyMDIzNDMxOFoYDzk5OTkxMjMxMjM1OTU5WjAU\n+MRIwEAYDVQQDDAlsb2NhbGhvc3QwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGB\n+AKaHbaGN3di5waF2sUi5hd2WqG2LVYzkFwMBvelLfhlZ2HNBRhYbvI03XhFBN6Tp\n+yEPEHXuWgHLFan4OdWpl6EsGAlJZ/PdWnRIIfI5mdtu4QxPeo3z3xQvBM8CjLHOu\n+ZtKfqFQmw0rLOIG/3X2WC42E97S3KxwThY+a8L2tSmptAgMBAAEwDQYJKoZIhvcN\n+AQENBQADgYEAE0OQnI3YQePCx3N18NJxoZrc4Vh2i6GR3AUFCcHRajZVBWago7o0\n+q4aPDArKCKWGg3E5DMgDv5YK8FJVUDIG+YDVo6SuLQO6mXbkde0kKGLy/2Vhievo\n+zFKQRM4gkRGBSJ/BhPQQwRH3uMGAtp/9XfooZ/rQViMOuH5Vxd3GoSE=\n+-----END CERTIFICATE-----","path":"community/neo4j-harness/neo4j-home/ssl/snakeoil.cert","position":11,"original_position":11,"commit_id":"833c0bfc93a86bad774fb886dd6a7806727dc1ef","original_commit_id":"833c0bfc93a86bad774fb886dd6a7806727dc1ef","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"please remove this","created_at":"2016-03-10T16:10:22Z","updated_at":"2016-03-10T16:10:22Z","html_url":"https://github.com/neo4j/neo4j/pull/6659#discussion_r55703000","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6659","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/55703000"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6659#discussion_r55703000"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6659"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/6659","id":62358789,"html_url":"https://github.com/neo4j/neo4j/pull/6659","diff_url":"https://github.com/neo4j/neo4j/pull/6659.diff","patch_url":"https://github.com/neo4j/neo4j/pull/6659.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/6659","number":6659,"state":"open","locked":false,"title":"Call procedures from within Cypher queries","user":{"login":"boggle","id":50886,"avatar_url":"https://avatars.githubusercontent.com/u/50886?v=3","gravatar_id":"","url":"https://api.github.com/users/boggle","html_url":"https://github.com/boggle","followers_url":"https://api.github.com/users/boggle/followers","following_url":"https://api.github.com/users/boggle/following{/other_user}","gists_url":"https://api.github.com/users/boggle/gists{/gist_id}","starred_url":"https://api.github.com/users/boggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boggle/subscriptions","organizations_url":"https://api.github.com/users/boggle/orgs","repos_url":"https://api.github.com/users/boggle/repos","events_url":"https://api.github.com/users/boggle/events{/privacy}","received_events_url":"https://api.github.com/users/boggle/received_events","type":"User","site_admin":false},"body":"This change allows queries like\r\n\r\n     MATCH (e:Episode)\r\n     CALL my.awesome.proc(\"energize\", e.id) YIELD maxWarp AS factor, tribbles AS pets\r\n     RETURN factor, count(pets)\r\n\r\nThis works now (assuming the build is green) but is not yet complete:\r\n\r\n- The CLG still needs to finalize syntax\r\n- There are some TODOs left and tests missing\r\n\r\nThe architecturally most interesting change is moving the first round of semantic checking over to plan building. This became necessary since type checking now depends on information obtained from the planning context - namely the procedure's signature. Even though today that's static it's quite plausible to assume it will by dynamic in the mid term future hence the move seemed like right thing to do.\r\n\r\nThe commits meander a bit as it took me a while to figure this out and solidify the model used.\r\n\r\nAlso noteworthy, this change preserves the fast code path developed for just calling procedures and only goes through the old run time when Cypher and procedures are mixed. This change does not add procedure calling to birk, this can happen later.\r\n\r\n\r\n","created_at":"2016-03-10T09:09:49Z","updated_at":"2016-03-10T16:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8009b54f6feefc9b800ce861b5ac556eb40593b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6659/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6659/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/6659/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/833c0bfc93a86bad774fb886dd6a7806727dc1ef","head":{"label":"boggle:3.0-call-procs-2","ref":"3.0-call-procs-2","sha":"833c0bfc93a86bad774fb886dd6a7806727dc1ef","user":{"login":"boggle","id":50886,"avatar_url":"https://avatars.githubusercontent.com/u/50886?v=3","gravatar_id":"","url":"https://api.github.com/users/boggle","html_url":"https://github.com/boggle","followers_url":"https://api.github.com/users/boggle/followers","following_url":"https://api.github.com/users/boggle/following{/other_user}","gists_url":"https://api.github.com/users/boggle/gists{/gist_id}","starred_url":"https://api.github.com/users/boggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boggle/subscriptions","organizations_url":"https://api.github.com/users/boggle/orgs","repos_url":"https://api.github.com/users/boggle/repos","events_url":"https://api.github.com/users/boggle/events{/privacy}","received_events_url":"https://api.github.com/users/boggle/received_events","type":"User","site_admin":false},"repo":{"id":7520917,"name":"neo4j","full_name":"boggle/neo4j","owner":{"login":"boggle","id":50886,"avatar_url":"https://avatars.githubusercontent.com/u/50886?v=3","gravatar_id":"","url":"https://api.github.com/users/boggle","html_url":"https://github.com/boggle","followers_url":"https://api.github.com/users/boggle/followers","following_url":"https://api.github.com/users/boggle/following{/other_user}","gists_url":"https://api.github.com/users/boggle/gists{/gist_id}","starred_url":"https://api.github.com/users/boggle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boggle/subscriptions","organizations_url":"https://api.github.com/users/boggle/orgs","repos_url":"https://api.github.com/users/boggle/repos","events_url":"https://api.github.com/users/boggle/events{/privacy}","received_events_url":"https://api.github.com/users/boggle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boggle/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/boggle/neo4j","forks_url":"https://api.github.com/repos/boggle/neo4j/forks","keys_url":"https://api.github.com/repos/boggle/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boggle/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boggle/neo4j/teams","hooks_url":"https://api.github.com/repos/boggle/neo4j/hooks","issue_events_url":"https://api.github.com/repos/boggle/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/boggle/neo4j/events","assignees_url":"https://api.github.com/repos/boggle/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/boggle/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/boggle/neo4j/tags","blobs_url":"https://api.github.com/repos/boggle/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boggle/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boggle/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/boggle/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boggle/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/boggle/neo4j/languages","stargazers_url":"https://api.github.com/repos/boggle/neo4j/stargazers","contributors_url":"https://api.github.com/repos/boggle/neo4j/contributors","subscribers_url":"https://api.github.com/repos/boggle/neo4j/subscribers","subscription_url":"https://api.github.com/repos/boggle/neo4j/subscription","commits_url":"https://api.github.com/repos/boggle/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/boggle/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/boggle/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/boggle/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/boggle/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/boggle/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boggle/neo4j/merges","archive_url":"https://api.github.com/repos/boggle/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boggle/neo4j/downloads","issues_url":"https://api.github.com/repos/boggle/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/boggle/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/boggle/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/boggle/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boggle/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/boggle/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/boggle/neo4j/deployments","created_at":"2013-01-09T12:50:34Z","updated_at":"2015-03-19T16:18:07Z","pushed_at":"2016-03-10T12:19:12Z","git_url":"git://github.com/boggle/neo4j.git","ssh_url":"git@github.com:boggle/neo4j.git","clone_url":"https://github.com/boggle/neo4j.git","svn_url":"https://github.com/boggle/neo4j","homepage":"http://neo4j.org","size":302947,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.0"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"005d940004b9e70473a44703ae374619a2bd3b03","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-03-10T13:15:16Z","pushed_at":"2016-03-10T15:49:09Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":339945,"stargazers_count":2406,"watchers_count":2406,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":856,"mirror_url":null,"open_issues_count":384,"forks":856,"open_issues":384,"watchers":2406,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6659"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6659"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6659"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6659/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6659/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6659/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/833c0bfc93a86bad774fb886dd6a7806727dc1ef"}}}}