{"action":"closed","number":5542,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5542","id":93394095,"html_url":"https://github.com/callemall/material-ui/pull/5542","diff_url":"https://github.com/callemall/material-ui/pull/5542.diff","patch_url":"https://github.com/callemall/material-ui/pull/5542.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5542","number":5542,"state":"closed","locked":false,"title":"[style] Add a withStyles HoC","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\nI think that this HoC can be used for one main purpose:\r\nIt's for users looking for synergy in their styling solution.\r\n\r\nIt's a **tradeoff** between hiding implementation detail and performances.\r\nCreating one additional React Component isn't free but always worth it.\r\nThe API is pretty close to https://github.com/airbnb/react-with-styles.\r\n\r\nE.g. of use case:\r\n```jsx\r\n//...\r\n\r\nexport default compose(\r\n  pure,\r\n  withStyles(styleSheet),\r\n  withWidth(),\r\n  connect((state, ownProps) => {\r\n    return {\r\n      moveUp: ownProps.width === SMALL ?\r\n        state.getIn(['snackbar', 'open']) :\r\n        false,\r\n    };\r\n  }),\r\n)(MainActionButton);\r\n```","created_at":"2016-11-11T20:36:27Z","updated_at":"2016-11-12T11:17:52Z","closed_at":"2016-11-12T11:17:52Z","merged_at":"2016-11-12T11:17:52Z","merge_commit_sha":"13e554d528b0b652681f87378baf16b6c46e4407","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5542/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5542/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5542/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/4ab56b6ee258e1af7550d8824ea32d81038bb0e9","head":{"label":"oliviertassinari:withStyle","ref":"withStyle","sha":"4ab56b6ee258e1af7550d8824ea32d81038bb0e9","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"repo":{"id":31391995,"name":"material-ui","full_name":"oliviertassinari/material-ui","owner":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oliviertassinari/material-ui","description":"A CSS Framework and a Set of React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/oliviertassinari/material-ui","forks_url":"https://api.github.com/repos/oliviertassinari/material-ui/forks","keys_url":"https://api.github.com/repos/oliviertassinari/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oliviertassinari/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oliviertassinari/material-ui/teams","hooks_url":"https://api.github.com/repos/oliviertassinari/material-ui/hooks","issue_events_url":"https://api.github.com/repos/oliviertassinari/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/oliviertassinari/material-ui/events","assignees_url":"https://api.github.com/repos/oliviertassinari/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/oliviertassinari/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/oliviertassinari/material-ui/tags","blobs_url":"https://api.github.com/repos/oliviertassinari/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oliviertassinari/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oliviertassinari/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/oliviertassinari/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oliviertassinari/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/oliviertassinari/material-ui/languages","stargazers_url":"https://api.github.com/repos/oliviertassinari/material-ui/stargazers","contributors_url":"https://api.github.com/repos/oliviertassinari/material-ui/contributors","subscribers_url":"https://api.github.com/repos/oliviertassinari/material-ui/subscribers","subscription_url":"https://api.github.com/repos/oliviertassinari/material-ui/subscription","commits_url":"https://api.github.com/repos/oliviertassinari/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/oliviertassinari/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/oliviertassinari/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/oliviertassinari/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/oliviertassinari/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/oliviertassinari/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oliviertassinari/material-ui/merges","archive_url":"https://api.github.com/repos/oliviertassinari/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oliviertassinari/material-ui/downloads","issues_url":"https://api.github.com/repos/oliviertassinari/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/oliviertassinari/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/oliviertassinari/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/oliviertassinari/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oliviertassinari/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/oliviertassinari/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/oliviertassinari/material-ui/deployments","created_at":"2015-02-26T22:23:03Z","updated_at":"2016-09-27T14:09:29Z","pushed_at":"2016-11-12T11:15:13Z","git_url":"git://github.com/oliviertassinari/material-ui.git","ssh_url":"git@github.com:oliviertassinari/material-ui.git","clone_url":"https://github.com/oliviertassinari/material-ui.git","svn_url":"https://github.com/oliviertassinari/material-ui","homepage":"http://material-ui.com","size":17757,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"callemall:next","ref":"next","sha":"aa61ee97de26c793a53ac1974f258e67a50886c1","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-11-12T09:07:26Z","pushed_at":"2016-11-12T11:17:52Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":82464,"stargazers_count":20911,"watchers_count":20911,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3741,"mirror_url":null,"open_issues_count":660,"forks":3741,"open_issues":660,"watchers":20911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5542"},"html":{"href":"https://github.com/callemall/material-ui/pull/5542"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5542"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5542/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5542/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5542/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/4ab56b6ee258e1af7550d8824ea32d81038bb0e9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":58,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"oliviertassinari"}}