{"action":"created","issue":{"url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/316","repository_url":"https://api.github.com/repos/neutrinolabs/xrdp","labels_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/316/labels{/name}","comments_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/316/comments","events_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/316/events","html_url":"https://github.com/neutrinolabs/xrdp/pull/316","id":132647805,"number":316,"title":"Make it possible to use Xvnc with 32 bpp","user":{"login":"proski","id":1317472,"avatar_url":"https://avatars.githubusercontent.com/u/1317472?v=3","gravatar_id":"","url":"https://api.github.com/users/proski","html_url":"https://github.com/proski","followers_url":"https://api.github.com/users/proski/followers","following_url":"https://api.github.com/users/proski/following{/other_user}","gists_url":"https://api.github.com/users/proski/gists{/gist_id}","starred_url":"https://api.github.com/users/proski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proski/subscriptions","organizations_url":"https://api.github.com/users/proski/orgs","repos_url":"https://api.github.com/users/proski/repos","events_url":"https://api.github.com/users/proski/events{/privacy}","received_events_url":"https://api.github.com/users/proski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-10T09:32:11Z","updated_at":"2016-02-12T01:50:20Z","closed_at":"2016-02-11T13:50:47Z","pull_request":{"url":"https://api.github.com/repos/neutrinolabs/xrdp/pulls/316","html_url":"https://github.com/neutrinolabs/xrdp/pull/316","diff_url":"https://github.com/neutrinolabs/xrdp/pull/316.diff","patch_url":"https://github.com/neutrinolabs/xrdp/pull/316.patch"},"body":"The support is not ideal, acceptable. For some clients, 32 bpp is the only option.\r\n\r\nscp_session_set_bpp() was essentially setting bpp to 0 if 32 bpp was requested. Check the error now, log errors, don't continue with \"0 bpp\".\r\n\r\nAllow 32 bpp in scp_session_set_bpp() - that's the global switch.\r\n\r\nAllow 32 bpp in VNC, use switch statement for readability."},"comment":{"url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/comments/183146297","html_url":"https://github.com/neutrinolabs/xrdp/pull/316#issuecomment-183146297","issue_url":"https://api.github.com/repos/neutrinolabs/xrdp/issues/316","id":183146297,"user":{"login":"jsorg71","id":666160,"avatar_url":"https://avatars.githubusercontent.com/u/666160?v=3","gravatar_id":"","url":"https://api.github.com/users/jsorg71","html_url":"https://github.com/jsorg71","followers_url":"https://api.github.com/users/jsorg71/followers","following_url":"https://api.github.com/users/jsorg71/following{/other_user}","gists_url":"https://api.github.com/users/jsorg71/gists{/gist_id}","starred_url":"https://api.github.com/users/jsorg71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsorg71/subscriptions","organizations_url":"https://api.github.com/users/jsorg71/orgs","repos_url":"https://api.github.com/users/jsorg71/repos","events_url":"https://api.github.com/users/jsorg71/events{/privacy}","received_events_url":"https://api.github.com/users/jsorg71/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T01:50:20Z","updated_at":"2016-02-12T01:50:20Z","body":"\r\nIt looks like there is a missing break here.\r\n\r\n```c\r\n          case 15:\r\n         case 16:\r\n         case 24:\r\n+        case 32:\r\n             s->bpp = bpp;\r\n         default:\r\n             return 1;\r\n```"}}