{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3cluster/pulls/comments/93952541","pull_request_review_id":14483471,"id":93952541,"diff_hunk":"@@ -0,0 +1,292 @@\n+// Copyright (c) 2016 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package etcd\n+\n+import (\n+\t\"fmt\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\t\"github.com/coreos/etcd/clientv3\"\n+\t\"github.com/golang/protobuf/proto\"\n+\t\"github.com/m3db/m3cluster/kv\"\n+\t\"github.com/m3db/m3x/log\"\n+\t\"github.com/m3db/m3x/retry\"\n+\t\"github.com/uber-go/tally\"\n+\t\"golang.org/x/net/context\"\n+)\n+\n+var noopCancel func()\n+\n+// NewStore creates a kv store based on etcd\n+func NewStore(etcd *clientv3.Client, opts Options) kv.Store {","path":"kv/etcd/etcd.go","position":null,"original_position":40,"commit_id":"264f6bbfd1707a052a4761f1cb70819863de2a3e","original_commit_id":"16fcdf3d2a9c50ecac33ad5045cdf5ab18a87bef","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars.githubusercontent.com/u/6710599?v=3","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"sure, will do","created_at":"2016-12-27T17:22:20Z","updated_at":"2016-12-27T17:22:20Z","html_url":"https://github.com/m3db/m3cluster/pull/46#discussion_r93952541","pull_request_url":"https://api.github.com/repos/m3db/m3cluster/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/comments/93952541"},"html":{"href":"https://github.com/m3db/m3cluster/pull/46#discussion_r93952541"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3cluster/pulls/46","id":98462117,"html_url":"https://github.com/m3db/m3cluster/pull/46","diff_url":"https://github.com/m3db/m3cluster/pull/46.diff","patch_url":"https://github.com/m3db/m3cluster/pull/46.patch","issue_url":"https://api.github.com/repos/m3db/m3cluster/issues/46","number":46,"state":"open","locked":false,"title":"KV client based on etcd","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars.githubusercontent.com/u/6710599?v=3","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"@xichen2020 @robskillington ","created_at":"2016-12-18T02:04:05Z","updated_at":"2016-12-27T17:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"479536a26528c6aa398483006e8e03cc55219371","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3cluster/pulls/46/commits","review_comments_url":"https://api.github.com/repos/m3db/m3cluster/pulls/46/comments","review_comment_url":"https://api.github.com/repos/m3db/m3cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3cluster/issues/46/comments","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/264f6bbfd1707a052a4761f1cb70819863de2a3e","head":{"label":"m3db:chao-kv-refactor","ref":"chao-kv-refactor","sha":"264f6bbfd1707a052a4761f1cb70819863de2a3e","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64314919,"name":"m3cluster","full_name":"m3db/m3cluster","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3cluster","description":"Cluster management interfaces (service discovery, config distribution) supporting pluggable backends","fork":false,"url":"https://api.github.com/repos/m3db/m3cluster","forks_url":"https://api.github.com/repos/m3db/m3cluster/forks","keys_url":"https://api.github.com/repos/m3db/m3cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3cluster/teams","hooks_url":"https://api.github.com/repos/m3db/m3cluster/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3cluster/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3cluster/events","assignees_url":"https://api.github.com/repos/m3db/m3cluster/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3cluster/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3cluster/tags","blobs_url":"https://api.github.com/repos/m3db/m3cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3cluster/languages","stargazers_url":"https://api.github.com/repos/m3db/m3cluster/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3cluster/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3cluster/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3cluster/subscription","commits_url":"https://api.github.com/repos/m3db/m3cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3cluster/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3cluster/merges","archive_url":"https://api.github.com/repos/m3db/m3cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3cluster/downloads","issues_url":"https://api.github.com/repos/m3db/m3cluster/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3cluster/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3cluster/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3cluster/deployments","created_at":"2016-07-27T14:22:38Z","updated_at":"2016-10-31T21:32:10Z","pushed_at":"2016-12-27T17:21:09Z","git_url":"git://github.com/m3db/m3cluster.git","ssh_url":"git@github.com:m3db/m3cluster.git","clone_url":"https://github.com/m3db/m3cluster.git","svn_url":"https://github.com/m3db/m3cluster","homepage":"","size":194,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"1a1fdbdca001178782699079a0b5229ef4740886","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64314919,"name":"m3cluster","full_name":"m3db/m3cluster","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3cluster","description":"Cluster management interfaces (service discovery, config distribution) supporting pluggable backends","fork":false,"url":"https://api.github.com/repos/m3db/m3cluster","forks_url":"https://api.github.com/repos/m3db/m3cluster/forks","keys_url":"https://api.github.com/repos/m3db/m3cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3cluster/teams","hooks_url":"https://api.github.com/repos/m3db/m3cluster/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3cluster/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3cluster/events","assignees_url":"https://api.github.com/repos/m3db/m3cluster/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3cluster/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3cluster/tags","blobs_url":"https://api.github.com/repos/m3db/m3cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3cluster/languages","stargazers_url":"https://api.github.com/repos/m3db/m3cluster/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3cluster/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3cluster/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3cluster/subscription","commits_url":"https://api.github.com/repos/m3db/m3cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3cluster/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3cluster/merges","archive_url":"https://api.github.com/repos/m3db/m3cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3cluster/downloads","issues_url":"https://api.github.com/repos/m3db/m3cluster/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3cluster/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3cluster/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3cluster/deployments","created_at":"2016-07-27T14:22:38Z","updated_at":"2016-10-31T21:32:10Z","pushed_at":"2016-12-27T17:21:09Z","git_url":"git://github.com/m3db/m3cluster.git","ssh_url":"git@github.com:m3db/m3cluster.git","clone_url":"https://github.com/m3db/m3cluster.git","svn_url":"https://github.com/m3db/m3cluster","homepage":"","size":194,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/46"},"html":{"href":"https://github.com/m3db/m3cluster/pull/46"},"issue":{"href":"https://api.github.com/repos/m3db/m3cluster/issues/46"},"comments":{"href":"https://api.github.com/repos/m3db/m3cluster/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3cluster/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3cluster/statuses/264f6bbfd1707a052a4761f1cb70819863de2a3e"}}}}
{"actor":{"display_login":"cw9"}}