{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/77438890","id":77438890,"diff_hunk":"@@ -922,38 +922,34 @@ var JpegStream = (function JpegStreamClosure() {\n     if (this.bufferLength) {\n       return;\n     }\n-    try {\n-      var jpegImage = new JpegImage();\n-\n-      // checking if values needs to be transformed before conversion\n-      if (this.forceRGB && this.dict && isArray(this.dict.get('Decode'))) {\n-        var decodeArr = this.dict.getArray('Decode');\n-        var bitsPerComponent = this.dict.get('BitsPerComponent') || 8;\n-        var decodeArrLength = decodeArr.length;\n-        var transform = new Int32Array(decodeArrLength);\n-        var transformNeeded = false;\n-        var maxValue = (1 << bitsPerComponent) - 1;\n-        for (var i = 0; i < decodeArrLength; i += 2) {\n-          transform[i] = ((decodeArr[i + 1] - decodeArr[i]) * 256) | 0;\n-          transform[i + 1] = (decodeArr[i] * maxValue) | 0;\n-          if (transform[i] !== 256 || transform[i + 1] !== 0) {\n-            transformNeeded = true;\n-          }\n-        }\n-        if (transformNeeded) {\n-          jpegImage.decodeTransform = transform;\n+    var jpegImage = new JpegImage();\n+\n+    // Checking if values needs to be transformed before conversion.","path":"src/core/stream.js","position":26,"original_position":26,"commit_id":"6b38ee4f1130ce9404b3d3d82c2a7ea938aa3e54","original_commit_id":"6b38ee4f1130ce9404b3d3d82c2a7ea938aa3e54","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Since this comment was pre-existing, I only capitalized the first letter and added a period at the end, but somehow I didn't notice the other grammatical issue here.\r\nFixed now, thanks for noticing!","created_at":"2016-09-03T16:18:15Z","updated_at":"2016-09-03T16:18:15Z","html_url":"https://github.com/mozilla/pdf.js/pull/7591#discussion_r77438890","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/77438890"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/7591#discussion_r77438890"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591","id":83892875,"html_url":"https://github.com/mozilla/pdf.js/pull/7591","diff_url":"https://github.com/mozilla/pdf.js/pull/7591.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/7591.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7591","number":7591,"state":"open","locked":false,"title":"Change `src/core/jpg.js` to use the `error` utility function instead of `throw`ing","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"This allows us to remove the `try/catch` statements used in `src/core/stream.js` when parsing JPEG images.\r\nAs far as I can tell, the only reason for the current usage of plain `throw` is that `jpg.js` originally was external code. Given that this code now lives in our repo, this patch brings the JPEG code more in line with e.g. `src/core/jpx.js` and `src/core/jbig2.js`.\r\n\r\n**Edit:** Easier reviewing with https://github.com/mozilla/pdf.js/pull/7591/files?w=1.","created_at":"2016-09-03T11:06:03Z","updated_at":"2016-09-03T16:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f122e4763aa70de663a362fe3f2e464760a08ba3","assignee":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"assignees":[{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7591/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/6b38ee4f1130ce9404b3d3d82c2a7ea938aa3e54","head":{"label":"Snuffleupagus:jpeg-error","ref":"jpeg-error","sha":"6b38ee4f1130ce9404b3d3d82c2a7ea938aa3e54","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"repo":{"id":7120249,"name":"pdf.js","full_name":"Snuffleupagus/pdf.js","owner":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Snuffleupagus/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/Snuffleupagus/pdf.js","forks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/forks","keys_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/teams","hooks_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/events","assignees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/tags","blobs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/languages","stargazers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/subscription","commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/merges","archive_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/downloads","issues_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/Snuffleupagus/pdf.js/deployments","created_at":"2012-12-11T22:06:46Z","updated_at":"2015-05-08T20:06:28Z","pushed_at":"2016-09-03T11:18:08Z","git_url":"git://github.com/Snuffleupagus/pdf.js.git","ssh_url":"git@github.com:Snuffleupagus/pdf.js.git","clone_url":"https://github.com/Snuffleupagus/pdf.js.git","svn_url":"https://github.com/Snuffleupagus/pdf.js","homepage":"","size":58223,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8522625da243c530d9dce0c1816b790240272ffa","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2016-09-03T15:45:18Z","pushed_at":"2016-09-03T11:18:10Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":938010,"stargazers_count":15444,"watchers_count":15444,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3671,"mirror_url":null,"open_issues_count":623,"forks":3671,"open_issues":623,"watchers":15444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/7591"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/7591"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/7591/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7591/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/6b38ee4f1130ce9404b3d3d82c2a7ea938aa3e54"}}}}
{"actor":{"display_login":"Snuffleupagus"}}