{"action":"created","comment":{"url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/comments/69287757","id":69287757,"diff_hunk":"@@ -243,6 +245,71 @@ indexWrapper(Rcpp::CharacterVector & dbpath, Rcpp::DataFrame & dataFrame, Rcpp::\n \t    }\n \t}\n \n+\t//Add value slots\n+\tfor (Rcpp::List::iterator it = slotList.begin(); it != slotList.end(); ++it) {\n+\t    Rcpp::List list = it.operator*();\n+\t    bool serialiseVal = false;\n+\t    bool dfVal = true; // use original row values in data frame\n+\t    int slot;\n+\t    std::string val;\n+\n+\t    try {\n+\t\tslot = Rcpp::as<int>(list[\"slot\"]);\n+\t    } catch (...) {\n+\t\tRcpp::stop(\"Slot number should be specified.\");\n+\t    }\n+\n+\t    if (list.containsElementNamed(\"serialise\")) serialiseVal = Rcpp::as<bool>(list[\"serialise\"]);\n+\t    if (list.containsElementNamed(\"values\")) dfVal = false; // use a column vector of modified row values\n+\n+\t    if (dfVal) {\n+\t\tint colNo;\n+\n+\t\ttry {\n+\t\t    if (list.containsElementNamed(\"index\")) {\n+\t\t\tcolNo = Rcpp::as<int>(list[\"index\"]);\n+\t\t    } else {\n+\t\t\tstd::string colName = Rcpp::as<std::string>(list[\"name\"]);\n+\t\t\tcolNo = colIndex(df, colName);\n+\t\t    }\n+\t\t} catch (...) {\n+\t\t    Rcpp::stop(\"Either name or index of the columns should be specified.\");\n+\t\t}\n+\n+\t\tif (colNo < 0 || colNo > dfCols) Rcpp::stop(\"Invalid argument for valueSlots\");","path":"src/IndexingWrapper.cpp","position":53,"original_position":53,"commit_id":"4e02e68fe0801ec7bf4aafdf8db90225372e1a29","original_commit_id":"4e02e68fe0801ec7bf4aafdf8db90225372e1a29","user":{"login":"jaylett","id":80187,"avatar_url":"https://avatars.githubusercontent.com/u/80187?v=3","gravatar_id":"","url":"https://api.github.com/users/jaylett","html_url":"https://github.com/jaylett","followers_url":"https://api.github.com/users/jaylett/followers","following_url":"https://api.github.com/users/jaylett/following{/other_user}","gists_url":"https://api.github.com/users/jaylett/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylett/subscriptions","organizations_url":"https://api.github.com/users/jaylett/orgs","repos_url":"https://api.github.com/users/jaylett/repos","events_url":"https://api.github.com/users/jaylett/events{/privacy}","received_events_url":"https://api.github.com/users/jaylett/received_events","type":"User","site_admin":false},"body":"I'd be more explicit, mentioning what the acceptable bounds are.","created_at":"2016-07-01T11:48:39Z","updated_at":"2016-07-01T11:48:39Z","html_url":"https://github.com/amandaJayanetti/RXapian/pull/10#discussion_r69287757","pull_request_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/comments/69287757"},"html":{"href":"https://github.com/amandaJayanetti/RXapian/pull/10#discussion_r69287757"},"pull_request":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10","id":75918106,"html_url":"https://github.com/amandaJayanetti/RXapian/pull/10","diff_url":"https://github.com/amandaJayanetti/RXapian/pull/10.diff","patch_url":"https://github.com/amandaJayanetti/RXapian/pull/10.patch","issue_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/10","number":10,"state":"open","locked":false,"title":"Add valueSlots parameter","user":{"login":"amandaJayanetti","id":8381238,"avatar_url":"https://avatars.githubusercontent.com/u/8381238?v=3","gravatar_id":"","url":"https://api.github.com/users/amandaJayanetti","html_url":"https://github.com/amandaJayanetti","followers_url":"https://api.github.com/users/amandaJayanetti/followers","following_url":"https://api.github.com/users/amandaJayanetti/following{/other_user}","gists_url":"https://api.github.com/users/amandaJayanetti/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaJayanetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaJayanetti/subscriptions","organizations_url":"https://api.github.com/users/amandaJayanetti/orgs","repos_url":"https://api.github.com/users/amandaJayanetti/repos","events_url":"https://api.github.com/users/amandaJayanetti/events{/privacy}","received_events_url":"https://api.github.com/users/amandaJayanetti/received_events","type":"User","site_admin":false},"body":"By providing relevant optional arguments to valueSlots parameter, advanced indexing features of Xapian can be used with xapian_index function.","created_at":"2016-07-01T02:10:54Z","updated_at":"2016-07-01T11:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e60956558b91c9e8222281f1ae5f95ab53b96d3a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10/commits","review_comments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10/comments","review_comment_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/10/comments","statuses_url":"https://api.github.com/repos/amandaJayanetti/RXapian/statuses/4e02e68fe0801ec7bf4aafdf8db90225372e1a29","head":{"label":"amandaJayanetti:dev","ref":"dev","sha":"4e02e68fe0801ec7bf4aafdf8db90225372e1a29","user":{"login":"amandaJayanetti","id":8381238,"avatar_url":"https://avatars.githubusercontent.com/u/8381238?v=3","gravatar_id":"","url":"https://api.github.com/users/amandaJayanetti","html_url":"https://github.com/amandaJayanetti","followers_url":"https://api.github.com/users/amandaJayanetti/followers","following_url":"https://api.github.com/users/amandaJayanetti/following{/other_user}","gists_url":"https://api.github.com/users/amandaJayanetti/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaJayanetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaJayanetti/subscriptions","organizations_url":"https://api.github.com/users/amandaJayanetti/orgs","repos_url":"https://api.github.com/users/amandaJayanetti/repos","events_url":"https://api.github.com/users/amandaJayanetti/events{/privacy}","received_events_url":"https://api.github.com/users/amandaJayanetti/received_events","type":"User","site_admin":false},"repo":{"id":59979615,"name":"RXapian","full_name":"amandaJayanetti/RXapian","owner":{"login":"amandaJayanetti","id":8381238,"avatar_url":"https://avatars.githubusercontent.com/u/8381238?v=3","gravatar_id":"","url":"https://api.github.com/users/amandaJayanetti","html_url":"https://github.com/amandaJayanetti","followers_url":"https://api.github.com/users/amandaJayanetti/followers","following_url":"https://api.github.com/users/amandaJayanetti/following{/other_user}","gists_url":"https://api.github.com/users/amandaJayanetti/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaJayanetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaJayanetti/subscriptions","organizations_url":"https://api.github.com/users/amandaJayanetti/orgs","repos_url":"https://api.github.com/users/amandaJayanetti/repos","events_url":"https://api.github.com/users/amandaJayanetti/events{/privacy}","received_events_url":"https://api.github.com/users/amandaJayanetti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amandaJayanetti/RXapian","description":"R bindings for Xapian search engine library.","fork":false,"url":"https://api.github.com/repos/amandaJayanetti/RXapian","forks_url":"https://api.github.com/repos/amandaJayanetti/RXapian/forks","keys_url":"https://api.github.com/repos/amandaJayanetti/RXapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amandaJayanetti/RXapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amandaJayanetti/RXapian/teams","hooks_url":"https://api.github.com/repos/amandaJayanetti/RXapian/hooks","issue_events_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/events{/number}","events_url":"https://api.github.com/repos/amandaJayanetti/RXapian/events","assignees_url":"https://api.github.com/repos/amandaJayanetti/RXapian/assignees{/user}","branches_url":"https://api.github.com/repos/amandaJayanetti/RXapian/branches{/branch}","tags_url":"https://api.github.com/repos/amandaJayanetti/RXapian/tags","blobs_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amandaJayanetti/RXapian/statuses/{sha}","languages_url":"https://api.github.com/repos/amandaJayanetti/RXapian/languages","stargazers_url":"https://api.github.com/repos/amandaJayanetti/RXapian/stargazers","contributors_url":"https://api.github.com/repos/amandaJayanetti/RXapian/contributors","subscribers_url":"https://api.github.com/repos/amandaJayanetti/RXapian/subscribers","subscription_url":"https://api.github.com/repos/amandaJayanetti/RXapian/subscription","commits_url":"https://api.github.com/repos/amandaJayanetti/RXapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/amandaJayanetti/RXapian/contents/{+path}","compare_url":"https://api.github.com/repos/amandaJayanetti/RXapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amandaJayanetti/RXapian/merges","archive_url":"https://api.github.com/repos/amandaJayanetti/RXapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amandaJayanetti/RXapian/downloads","issues_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues{/number}","pulls_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls{/number}","milestones_url":"https://api.github.com/repos/amandaJayanetti/RXapian/milestones{/number}","notifications_url":"https://api.github.com/repos/amandaJayanetti/RXapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amandaJayanetti/RXapian/labels{/name}","releases_url":"https://api.github.com/repos/amandaJayanetti/RXapian/releases{/id}","deployments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/deployments","created_at":"2016-05-30T04:08:03Z","updated_at":"2016-06-07T19:00:52Z","pushed_at":"2016-07-01T02:28:35Z","git_url":"git://github.com/amandaJayanetti/RXapian.git","ssh_url":"git@github.com:amandaJayanetti/RXapian.git","clone_url":"https://github.com/amandaJayanetti/RXapian.git","svn_url":"https://github.com/amandaJayanetti/RXapian","homepage":"","size":760,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"amandaJayanetti:master","ref":"master","sha":"e681f60fcef27944c345dcf6bc192d6d58e19ddd","user":{"login":"amandaJayanetti","id":8381238,"avatar_url":"https://avatars.githubusercontent.com/u/8381238?v=3","gravatar_id":"","url":"https://api.github.com/users/amandaJayanetti","html_url":"https://github.com/amandaJayanetti","followers_url":"https://api.github.com/users/amandaJayanetti/followers","following_url":"https://api.github.com/users/amandaJayanetti/following{/other_user}","gists_url":"https://api.github.com/users/amandaJayanetti/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaJayanetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaJayanetti/subscriptions","organizations_url":"https://api.github.com/users/amandaJayanetti/orgs","repos_url":"https://api.github.com/users/amandaJayanetti/repos","events_url":"https://api.github.com/users/amandaJayanetti/events{/privacy}","received_events_url":"https://api.github.com/users/amandaJayanetti/received_events","type":"User","site_admin":false},"repo":{"id":59979615,"name":"RXapian","full_name":"amandaJayanetti/RXapian","owner":{"login":"amandaJayanetti","id":8381238,"avatar_url":"https://avatars.githubusercontent.com/u/8381238?v=3","gravatar_id":"","url":"https://api.github.com/users/amandaJayanetti","html_url":"https://github.com/amandaJayanetti","followers_url":"https://api.github.com/users/amandaJayanetti/followers","following_url":"https://api.github.com/users/amandaJayanetti/following{/other_user}","gists_url":"https://api.github.com/users/amandaJayanetti/gists{/gist_id}","starred_url":"https://api.github.com/users/amandaJayanetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandaJayanetti/subscriptions","organizations_url":"https://api.github.com/users/amandaJayanetti/orgs","repos_url":"https://api.github.com/users/amandaJayanetti/repos","events_url":"https://api.github.com/users/amandaJayanetti/events{/privacy}","received_events_url":"https://api.github.com/users/amandaJayanetti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amandaJayanetti/RXapian","description":"R bindings for Xapian search engine library.","fork":false,"url":"https://api.github.com/repos/amandaJayanetti/RXapian","forks_url":"https://api.github.com/repos/amandaJayanetti/RXapian/forks","keys_url":"https://api.github.com/repos/amandaJayanetti/RXapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amandaJayanetti/RXapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amandaJayanetti/RXapian/teams","hooks_url":"https://api.github.com/repos/amandaJayanetti/RXapian/hooks","issue_events_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/events{/number}","events_url":"https://api.github.com/repos/amandaJayanetti/RXapian/events","assignees_url":"https://api.github.com/repos/amandaJayanetti/RXapian/assignees{/user}","branches_url":"https://api.github.com/repos/amandaJayanetti/RXapian/branches{/branch}","tags_url":"https://api.github.com/repos/amandaJayanetti/RXapian/tags","blobs_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amandaJayanetti/RXapian/statuses/{sha}","languages_url":"https://api.github.com/repos/amandaJayanetti/RXapian/languages","stargazers_url":"https://api.github.com/repos/amandaJayanetti/RXapian/stargazers","contributors_url":"https://api.github.com/repos/amandaJayanetti/RXapian/contributors","subscribers_url":"https://api.github.com/repos/amandaJayanetti/RXapian/subscribers","subscription_url":"https://api.github.com/repos/amandaJayanetti/RXapian/subscription","commits_url":"https://api.github.com/repos/amandaJayanetti/RXapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/amandaJayanetti/RXapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/amandaJayanetti/RXapian/contents/{+path}","compare_url":"https://api.github.com/repos/amandaJayanetti/RXapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amandaJayanetti/RXapian/merges","archive_url":"https://api.github.com/repos/amandaJayanetti/RXapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amandaJayanetti/RXapian/downloads","issues_url":"https://api.github.com/repos/amandaJayanetti/RXapian/issues{/number}","pulls_url":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls{/number}","milestones_url":"https://api.github.com/repos/amandaJayanetti/RXapian/milestones{/number}","notifications_url":"https://api.github.com/repos/amandaJayanetti/RXapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amandaJayanetti/RXapian/labels{/name}","releases_url":"https://api.github.com/repos/amandaJayanetti/RXapian/releases{/id}","deployments_url":"https://api.github.com/repos/amandaJayanetti/RXapian/deployments","created_at":"2016-05-30T04:08:03Z","updated_at":"2016-06-07T19:00:52Z","pushed_at":"2016-07-01T02:28:35Z","git_url":"git://github.com/amandaJayanetti/RXapian.git","ssh_url":"git@github.com:amandaJayanetti/RXapian.git","clone_url":"https://github.com/amandaJayanetti/RXapian.git","svn_url":"https://github.com/amandaJayanetti/RXapian","homepage":"","size":760,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10"},"html":{"href":"https://github.com/amandaJayanetti/RXapian/pull/10"},"issue":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/10"},"comments":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/amandaJayanetti/RXapian/statuses/4e02e68fe0801ec7bf4aafdf8db90225372e1a29"}}}}
{"actor":{"display_login":"jaylett"}}