{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/sebi2k1/node-can/pulls/13","id":55487325,"html_url":"https://github.com/sebi2k1/node-can/pull/13","diff_url":"https://github.com/sebi2k1/node-can/pull/13.diff","patch_url":"https://github.com/sebi2k1/node-can/pull/13.patch","issue_url":"https://api.github.com/repos/sebi2k1/node-can/issues/13","number":13,"state":"closed","locked":false,"title":"revert change which broke little endian encode/decode. Fix signal conversion test.","user":{"login":"dmahurin","id":2797413,"avatar_url":"https://avatars.githubusercontent.com/u/2797413?v=3","gravatar_id":"","url":"https://api.github.com/users/dmahurin","html_url":"https://github.com/dmahurin","followers_url":"https://api.github.com/users/dmahurin/followers","following_url":"https://api.github.com/users/dmahurin/following{/other_user}","gists_url":"https://api.github.com/users/dmahurin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmahurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmahurin/subscriptions","organizations_url":"https://api.github.com/users/dmahurin/orgs","repos_url":"https://api.github.com/users/dmahurin/repos","events_url":"https://api.github.com/users/dmahurin/events{/privacy}","received_events_url":"https://api.github.com/users/dmahurin/received_events","type":"User","site_admin":false},"body":"Revert \"Changes for little Endianess and intra-Byte signal definitions\", as it broke little endian encoding and decoding.  It is not clear what the change was attempting to fix.\r\n\r\nReverting this change and correcting array->buffer in the tests allows all signal conversion tests to pass.  Without reverting the mentioned change, the little endian bit order is wrong and 11 assertions fail.\r\n\r\n test-signal_conversion.js\r\n-Buffer 01 00 00 00 00 00 00 00\r\n-Buffer 03 00 00 00 00 00 00 00\r\n-Buffer 03 00 00 00 00 00 00 00\r\n-Buffer 0b 00 00 00 00 00 00 00\r\n-✖ little_endian_encode\r\n-✖ little_endian_decode\r\n+Buffer 80 00 00 00 00 00 00 00\r\n+Buffer c0 00 00 00 00 00 00 00\r\n+Buffer c0 00 00 00 00 00 00 00\r\n+Buffer d0 00 00 00 00 00 00 00\r\n+✔ little_endian_encode\r\n+✔ little_endian_decode\r\n ✔ little_endian_signed_decode\r\n ✔ little_endian_signed_encode\r\n ✔ big_endian_encode\r\n@@ -13,4 +13,4 @@\r\n ✔ big_endian_signed_encode\r\n ✔ big_endian_signed_decode\r\n \r\n-FAILURES: 11/36 assertions failed (12ms)\r\n+OK: 36 assertions (9ms)\r\n\r\n","created_at":"2016-01-08T17:24:32Z","updated_at":"2016-01-12T00:22:25Z","closed_at":"2016-01-12T00:22:25Z","merged_at":null,"merge_commit_sha":"18902b48ba82c8a322dc4825f9c5909901796af7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sebi2k1/node-can/pulls/13/commits","review_comments_url":"https://api.github.com/repos/sebi2k1/node-can/pulls/13/comments","review_comment_url":"https://api.github.com/repos/sebi2k1/node-can/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sebi2k1/node-can/issues/13/comments","statuses_url":"https://api.github.com/repos/sebi2k1/node-can/statuses/60eb06e607c7750065415dfb6edccffc24b61490","head":{"label":"dmahurin:master","ref":"master","sha":"60eb06e607c7750065415dfb6edccffc24b61490","user":{"login":"dmahurin","id":2797413,"avatar_url":"https://avatars.githubusercontent.com/u/2797413?v=3","gravatar_id":"","url":"https://api.github.com/users/dmahurin","html_url":"https://github.com/dmahurin","followers_url":"https://api.github.com/users/dmahurin/followers","following_url":"https://api.github.com/users/dmahurin/following{/other_user}","gists_url":"https://api.github.com/users/dmahurin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmahurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmahurin/subscriptions","organizations_url":"https://api.github.com/users/dmahurin/orgs","repos_url":"https://api.github.com/users/dmahurin/repos","events_url":"https://api.github.com/users/dmahurin/events{/privacy}","received_events_url":"https://api.github.com/users/dmahurin/received_events","type":"User","site_admin":false},"repo":{"id":49285313,"name":"node-can","full_name":"dmahurin/node-can","owner":{"login":"dmahurin","id":2797413,"avatar_url":"https://avatars.githubusercontent.com/u/2797413?v=3","gravatar_id":"","url":"https://api.github.com/users/dmahurin","html_url":"https://github.com/dmahurin","followers_url":"https://api.github.com/users/dmahurin/followers","following_url":"https://api.github.com/users/dmahurin/following{/other_user}","gists_url":"https://api.github.com/users/dmahurin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmahurin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmahurin/subscriptions","organizations_url":"https://api.github.com/users/dmahurin/orgs","repos_url":"https://api.github.com/users/dmahurin/repos","events_url":"https://api.github.com/users/dmahurin/events{/privacy}","received_events_url":"https://api.github.com/users/dmahurin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmahurin/node-can","description":"NodeJS SocketCAN extension","fork":true,"url":"https://api.github.com/repos/dmahurin/node-can","forks_url":"https://api.github.com/repos/dmahurin/node-can/forks","keys_url":"https://api.github.com/repos/dmahurin/node-can/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmahurin/node-can/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmahurin/node-can/teams","hooks_url":"https://api.github.com/repos/dmahurin/node-can/hooks","issue_events_url":"https://api.github.com/repos/dmahurin/node-can/issues/events{/number}","events_url":"https://api.github.com/repos/dmahurin/node-can/events","assignees_url":"https://api.github.com/repos/dmahurin/node-can/assignees{/user}","branches_url":"https://api.github.com/repos/dmahurin/node-can/branches{/branch}","tags_url":"https://api.github.com/repos/dmahurin/node-can/tags","blobs_url":"https://api.github.com/repos/dmahurin/node-can/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmahurin/node-can/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmahurin/node-can/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmahurin/node-can/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmahurin/node-can/statuses/{sha}","languages_url":"https://api.github.com/repos/dmahurin/node-can/languages","stargazers_url":"https://api.github.com/repos/dmahurin/node-can/stargazers","contributors_url":"https://api.github.com/repos/dmahurin/node-can/contributors","subscribers_url":"https://api.github.com/repos/dmahurin/node-can/subscribers","subscription_url":"https://api.github.com/repos/dmahurin/node-can/subscription","commits_url":"https://api.github.com/repos/dmahurin/node-can/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmahurin/node-can/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmahurin/node-can/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmahurin/node-can/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmahurin/node-can/contents/{+path}","compare_url":"https://api.github.com/repos/dmahurin/node-can/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmahurin/node-can/merges","archive_url":"https://api.github.com/repos/dmahurin/node-can/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmahurin/node-can/downloads","issues_url":"https://api.github.com/repos/dmahurin/node-can/issues{/number}","pulls_url":"https://api.github.com/repos/dmahurin/node-can/pulls{/number}","milestones_url":"https://api.github.com/repos/dmahurin/node-can/milestones{/number}","notifications_url":"https://api.github.com/repos/dmahurin/node-can/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmahurin/node-can/labels{/name}","releases_url":"https://api.github.com/repos/dmahurin/node-can/releases{/id}","created_at":"2016-01-08T17:10:50Z","updated_at":"2016-01-08T17:10:51Z","pushed_at":"2016-01-08T17:13:33Z","git_url":"git://github.com/dmahurin/node-can.git","ssh_url":"git@github.com:dmahurin/node-can.git","clone_url":"https://github.com/dmahurin/node-can.git","svn_url":"https://github.com/dmahurin/node-can","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sebi2k1:master","ref":"master","sha":"d573f3923c251501eb2d48f9d607c5390b6a44f7","user":{"login":"sebi2k1","id":1223463,"avatar_url":"https://avatars.githubusercontent.com/u/1223463?v=3","gravatar_id":"","url":"https://api.github.com/users/sebi2k1","html_url":"https://github.com/sebi2k1","followers_url":"https://api.github.com/users/sebi2k1/followers","following_url":"https://api.github.com/users/sebi2k1/following{/other_user}","gists_url":"https://api.github.com/users/sebi2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/sebi2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebi2k1/subscriptions","organizations_url":"https://api.github.com/users/sebi2k1/orgs","repos_url":"https://api.github.com/users/sebi2k1/repos","events_url":"https://api.github.com/users/sebi2k1/events{/privacy}","received_events_url":"https://api.github.com/users/sebi2k1/received_events","type":"User","site_admin":false},"repo":{"id":7387779,"name":"node-can","full_name":"sebi2k1/node-can","owner":{"login":"sebi2k1","id":1223463,"avatar_url":"https://avatars.githubusercontent.com/u/1223463?v=3","gravatar_id":"","url":"https://api.github.com/users/sebi2k1","html_url":"https://github.com/sebi2k1","followers_url":"https://api.github.com/users/sebi2k1/followers","following_url":"https://api.github.com/users/sebi2k1/following{/other_user}","gists_url":"https://api.github.com/users/sebi2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/sebi2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebi2k1/subscriptions","organizations_url":"https://api.github.com/users/sebi2k1/orgs","repos_url":"https://api.github.com/users/sebi2k1/repos","events_url":"https://api.github.com/users/sebi2k1/events{/privacy}","received_events_url":"https://api.github.com/users/sebi2k1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebi2k1/node-can","description":"NodeJS SocketCAN extension","fork":false,"url":"https://api.github.com/repos/sebi2k1/node-can","forks_url":"https://api.github.com/repos/sebi2k1/node-can/forks","keys_url":"https://api.github.com/repos/sebi2k1/node-can/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebi2k1/node-can/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebi2k1/node-can/teams","hooks_url":"https://api.github.com/repos/sebi2k1/node-can/hooks","issue_events_url":"https://api.github.com/repos/sebi2k1/node-can/issues/events{/number}","events_url":"https://api.github.com/repos/sebi2k1/node-can/events","assignees_url":"https://api.github.com/repos/sebi2k1/node-can/assignees{/user}","branches_url":"https://api.github.com/repos/sebi2k1/node-can/branches{/branch}","tags_url":"https://api.github.com/repos/sebi2k1/node-can/tags","blobs_url":"https://api.github.com/repos/sebi2k1/node-can/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebi2k1/node-can/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebi2k1/node-can/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebi2k1/node-can/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebi2k1/node-can/statuses/{sha}","languages_url":"https://api.github.com/repos/sebi2k1/node-can/languages","stargazers_url":"https://api.github.com/repos/sebi2k1/node-can/stargazers","contributors_url":"https://api.github.com/repos/sebi2k1/node-can/contributors","subscribers_url":"https://api.github.com/repos/sebi2k1/node-can/subscribers","subscription_url":"https://api.github.com/repos/sebi2k1/node-can/subscription","commits_url":"https://api.github.com/repos/sebi2k1/node-can/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebi2k1/node-can/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebi2k1/node-can/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebi2k1/node-can/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebi2k1/node-can/contents/{+path}","compare_url":"https://api.github.com/repos/sebi2k1/node-can/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebi2k1/node-can/merges","archive_url":"https://api.github.com/repos/sebi2k1/node-can/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebi2k1/node-can/downloads","issues_url":"https://api.github.com/repos/sebi2k1/node-can/issues{/number}","pulls_url":"https://api.github.com/repos/sebi2k1/node-can/pulls{/number}","milestones_url":"https://api.github.com/repos/sebi2k1/node-can/milestones{/number}","notifications_url":"https://api.github.com/repos/sebi2k1/node-can/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebi2k1/node-can/labels{/name}","releases_url":"https://api.github.com/repos/sebi2k1/node-can/releases{/id}","created_at":"2012-12-31T14:32:27Z","updated_at":"2015-11-09T17:37:25Z","pushed_at":"2016-01-08T17:24:32Z","git_url":"git://github.com/sebi2k1/node-can.git","ssh_url":"git@github.com:sebi2k1/node-can.git","clone_url":"https://github.com/sebi2k1/node-can.git","svn_url":"https://github.com/sebi2k1/node-can","homepage":null,"size":134,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebi2k1/node-can/pulls/13"},"html":{"href":"https://github.com/sebi2k1/node-can/pull/13"},"issue":{"href":"https://api.github.com/repos/sebi2k1/node-can/issues/13"},"comments":{"href":"https://api.github.com/repos/sebi2k1/node-can/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/sebi2k1/node-can/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/sebi2k1/node-can/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sebi2k1/node-can/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/sebi2k1/node-can/statuses/60eb06e607c7750065415dfb6edccffc24b61490"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":12,"review_comments":0,"commits":2,"additions":38,"deletions":76,"changed_files":2}}