{"action":"created","comment":{"url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/comments/85496554","pull_request_review_id":6209563,"id":85496554,"diff_hunk":"@@ -34,36 +31,43 @@\n \n         Logger DEFAULT = new Logger() {\n             @Override\n-            public void logSubscribe(@NonNull String tag, @Nonnull String observableTag) {\n+            public void logOnSubscribe(@Nonnull final String tag, @Nonnull final String observableTag) {\n                 final java.util.logging.Logger logger = java.util.logging.Logger.getLogger(tag);\n-                logger.log(Level.INFO, observableTag + \" -> onSubscribe\");\n+                if (logger.isLoggable(Level.INFO)) {","path":"rx-extensions/src/main/java/com/appunite/rx/util/LogTransformer.java","position":20,"original_position":20,"commit_id":"573abd84268060b20943cb227f6e837089fc2869","original_commit_id":"573abd84268060b20943cb227f6e837089fc2869","user":{"login":"jacek-marchwicki","id":689211,"avatar_url":"https://avatars.githubusercontent.com/u/689211?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-marchwicki","html_url":"https://github.com/jacek-marchwicki","followers_url":"https://api.github.com/users/jacek-marchwicki/followers","following_url":"https://api.github.com/users/jacek-marchwicki/following{/other_user}","gists_url":"https://api.github.com/users/jacek-marchwicki/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-marchwicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-marchwicki/subscriptions","organizations_url":"https://api.github.com/users/jacek-marchwicki/orgs","repos_url":"https://api.github.com/users/jacek-marchwicki/repos","events_url":"https://api.github.com/users/jacek-marchwicki/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-marchwicki/received_events","type":"User","site_admin":false},"body":"actually I think It make sens to check because if it's not logable it will not create object `observableTag + \" -> onSubscribe\"`","created_at":"2016-10-28T09:13:21Z","updated_at":"2016-10-28T09:13:21Z","html_url":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122#discussion_r85496554","pull_request_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/comments/85496554"},"html":{"href":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122#discussion_r85496554"},"pull_request":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122","id":90608125,"html_url":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122","diff_url":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122.diff","patch_url":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122.patch","issue_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/122","number":122,"state":"open","locked":false,"title":"Cleaned LogTransformer up","user":{"login":"pawel-schmidt","id":2522029,"avatar_url":"https://avatars.githubusercontent.com/u/2522029?v=3","gravatar_id":"","url":"https://api.github.com/users/pawel-schmidt","html_url":"https://github.com/pawel-schmidt","followers_url":"https://api.github.com/users/pawel-schmidt/followers","following_url":"https://api.github.com/users/pawel-schmidt/following{/other_user}","gists_url":"https://api.github.com/users/pawel-schmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/pawel-schmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawel-schmidt/subscriptions","organizations_url":"https://api.github.com/users/pawel-schmidt/orgs","repos_url":"https://api.github.com/users/pawel-schmidt/repos","events_url":"https://api.github.com/users/pawel-schmidt/events{/privacy}","received_events_url":"https://api.github.com/users/pawel-schmidt/received_events","type":"User","site_admin":false},"body":"Made `LogTransformer` pure Java class.\r\nAdded Android implementation of `Logger`.","created_at":"2016-10-24T13:07:02Z","updated_at":"2016-10-28T09:13:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9293a8e1a7680d05c4eb45d954d2f049c690da19","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122/commits","review_comments_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122/comments","review_comment_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/122/comments","statuses_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/statuses/573abd84268060b20943cb227f6e837089fc2869","head":{"label":"pawel-schmidt:logger","ref":"logger","sha":"573abd84268060b20943cb227f6e837089fc2869","user":{"login":"pawel-schmidt","id":2522029,"avatar_url":"https://avatars.githubusercontent.com/u/2522029?v=3","gravatar_id":"","url":"https://api.github.com/users/pawel-schmidt","html_url":"https://github.com/pawel-schmidt","followers_url":"https://api.github.com/users/pawel-schmidt/followers","following_url":"https://api.github.com/users/pawel-schmidt/following{/other_user}","gists_url":"https://api.github.com/users/pawel-schmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/pawel-schmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawel-schmidt/subscriptions","organizations_url":"https://api.github.com/users/pawel-schmidt/orgs","repos_url":"https://api.github.com/users/pawel-schmidt/repos","events_url":"https://api.github.com/users/pawel-schmidt/events{/privacy}","received_events_url":"https://api.github.com/users/pawel-schmidt/received_events","type":"User","site_admin":false},"repo":{"id":36740236,"name":"rx-java-extensions","full_name":"pawel-schmidt/rx-java-extensions","owner":{"login":"pawel-schmidt","id":2522029,"avatar_url":"https://avatars.githubusercontent.com/u/2522029?v=3","gravatar_id":"","url":"https://api.github.com/users/pawel-schmidt","html_url":"https://github.com/pawel-schmidt","followers_url":"https://api.github.com/users/pawel-schmidt/followers","following_url":"https://api.github.com/users/pawel-schmidt/following{/other_user}","gists_url":"https://api.github.com/users/pawel-schmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/pawel-schmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawel-schmidt/subscriptions","organizations_url":"https://api.github.com/users/pawel-schmidt/orgs","repos_url":"https://api.github.com/users/pawel-schmidt/repos","events_url":"https://api.github.com/users/pawel-schmidt/events{/privacy}","received_events_url":"https://api.github.com/users/pawel-schmidt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pawel-schmidt/rx-java-extensions","description":"Simple Rx for Android","fork":true,"url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions","forks_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/forks","keys_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/teams","hooks_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/hooks","issue_events_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/events","assignees_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/tags","blobs_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/languages","stargazers_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/stargazers","contributors_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/contributors","subscribers_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/subscribers","subscription_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/subscription","commits_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/merges","archive_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/downloads","issues_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/labels{/name}","releases_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/pawel-schmidt/rx-java-extensions/deployments","created_at":"2015-06-02T14:50:16Z","updated_at":"2016-01-22T10:38:18Z","pushed_at":"2016-10-24T04:08:31Z","git_url":"git://github.com/pawel-schmidt/rx-java-extensions.git","ssh_url":"git@github.com:pawel-schmidt/rx-java-extensions.git","clone_url":"https://github.com/pawel-schmidt/rx-java-extensions.git","svn_url":"https://github.com/pawel-schmidt/rx-java-extensions","homepage":"","size":966,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jacek-marchwicki:master","ref":"master","sha":"b7d36a782c54e06a97cf8cf24e4be790019eaf76","user":{"login":"jacek-marchwicki","id":689211,"avatar_url":"https://avatars.githubusercontent.com/u/689211?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-marchwicki","html_url":"https://github.com/jacek-marchwicki","followers_url":"https://api.github.com/users/jacek-marchwicki/followers","following_url":"https://api.github.com/users/jacek-marchwicki/following{/other_user}","gists_url":"https://api.github.com/users/jacek-marchwicki/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-marchwicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-marchwicki/subscriptions","organizations_url":"https://api.github.com/users/jacek-marchwicki/orgs","repos_url":"https://api.github.com/users/jacek-marchwicki/repos","events_url":"https://api.github.com/users/jacek-marchwicki/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-marchwicki/received_events","type":"User","site_admin":false},"repo":{"id":32398593,"name":"rx-java-extensions","full_name":"jacek-marchwicki/rx-java-extensions","owner":{"login":"jacek-marchwicki","id":689211,"avatar_url":"https://avatars.githubusercontent.com/u/689211?v=3","gravatar_id":"","url":"https://api.github.com/users/jacek-marchwicki","html_url":"https://github.com/jacek-marchwicki","followers_url":"https://api.github.com/users/jacek-marchwicki/followers","following_url":"https://api.github.com/users/jacek-marchwicki/following{/other_user}","gists_url":"https://api.github.com/users/jacek-marchwicki/gists{/gist_id}","starred_url":"https://api.github.com/users/jacek-marchwicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacek-marchwicki/subscriptions","organizations_url":"https://api.github.com/users/jacek-marchwicki/orgs","repos_url":"https://api.github.com/users/jacek-marchwicki/repos","events_url":"https://api.github.com/users/jacek-marchwicki/events{/privacy}","received_events_url":"https://api.github.com/users/jacek-marchwicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacek-marchwicki/rx-java-extensions","description":"Simple Rx for Android","fork":false,"url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions","forks_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/forks","keys_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/teams","hooks_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/hooks","issue_events_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/events","assignees_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/tags","blobs_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/languages","stargazers_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/stargazers","contributors_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/contributors","subscribers_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/subscribers","subscription_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/subscription","commits_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/merges","archive_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/downloads","issues_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/labels{/name}","releases_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/deployments","created_at":"2015-03-17T14:33:40Z","updated_at":"2016-10-28T09:11:03Z","pushed_at":"2016-10-24T13:07:02Z","git_url":"git://github.com/jacek-marchwicki/rx-java-extensions.git","ssh_url":"git@github.com:jacek-marchwicki/rx-java-extensions.git","clone_url":"https://github.com/jacek-marchwicki/rx-java-extensions.git","svn_url":"https://github.com/jacek-marchwicki/rx-java-extensions","homepage":"","size":1016,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122"},"html":{"href":"https://github.com/jacek-marchwicki/rx-java-extensions/pull/122"},"issue":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/122"},"comments":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/jacek-marchwicki/rx-java-extensions/statuses/573abd84268060b20943cb227f6e837089fc2869"}}}}
{"actor":{"display_login":"jacek-marchwicki"}}