{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/63630520","id":63630520,"diff_hunk":"@@ -81,6 +85,9 @@\n  * <li>A failed bundle will cause messages to be resent. Thus we rely on the Pubsub consumer\n  * to dedup messages.\n  * </ul>\n+ *\n+ * <p>NOTE: This is not the implementation used when running on the Google Dataflow hosted\n+ * service.","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubUnboundedSink.java","position":31,"original_position":31,"commit_id":"aafcf5f9d0286ec5a6ed0d634df8ff0902897cdc","original_commit_id":"aafcf5f9d0286ec5a6ed0d634df8ff0902897cdc","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"Google Cloud Dataflow service.","created_at":"2016-05-18T00:58:16Z","updated_at":"2016-05-18T00:58:16Z","html_url":"https://github.com/apache/incubator-beam/pull/346#discussion_r63630520","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/63630520"},"html":{"href":"https://github.com/apache/incubator-beam/pull/346#discussion_r63630520"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/346","id":70449422,"html_url":"https://github.com/apache/incubator-beam/pull/346","diff_url":"https://github.com/apache/incubator-beam/pull/346.diff","patch_url":"https://github.com/apache/incubator-beam/pull/346.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/346","number":346,"state":"open","locked":false,"title":"[BEAM-53] Wire PubsubUnbounded{Source,Sink} into PubsubIO","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"body":"This also refines the handling of record ids in the sink to be random-but-reused-on-failure, using the same trick as we do for the BigQuery sink.\r\n\r\nStill need to re-do the load tests I did a few weeks back with the actual change.\r\nNote that last time I tested the DataflowPipelineTranslator does not kick in and replace the new transforms with the correct native transforms. Need to dig deeper.\r\n\r\nR: @dhalperi ","created_at":"2016-05-17T23:48:04Z","updated_at":"2016-05-18T00:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9efab768a94d68275ca39594c2535a44005cefdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/346/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/346/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/346/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/aafcf5f9d0286ec5a6ed0d634df8ff0902897cdc","head":{"label":"mshields822:pubsub-runner","ref":"pubsub-runner","sha":"aafcf5f9d0286ec5a6ed0d634df8ff0902897cdc","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"repo":{"id":52641502,"name":"incubator-beam","full_name":"mshields822/incubator-beam","owner":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mshields822/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/mshields822/incubator-beam","forks_url":"https://api.github.com/repos/mshields822/incubator-beam/forks","keys_url":"https://api.github.com/repos/mshields822/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mshields822/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mshields822/incubator-beam/teams","hooks_url":"https://api.github.com/repos/mshields822/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/mshields822/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/mshields822/incubator-beam/events","assignees_url":"https://api.github.com/repos/mshields822/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/mshields822/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/mshields822/incubator-beam/tags","blobs_url":"https://api.github.com/repos/mshields822/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mshields822/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mshields822/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/mshields822/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mshields822/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/mshields822/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/mshields822/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/mshields822/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/mshields822/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/mshields822/incubator-beam/subscription","commits_url":"https://api.github.com/repos/mshields822/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/mshields822/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/mshields822/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/mshields822/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/mshields822/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/mshields822/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mshields822/incubator-beam/merges","archive_url":"https://api.github.com/repos/mshields822/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mshields822/incubator-beam/downloads","issues_url":"https://api.github.com/repos/mshields822/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/mshields822/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/mshields822/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/mshields822/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mshields822/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/mshields822/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/mshields822/incubator-beam/deployments","created_at":"2016-02-27T00:22:15Z","updated_at":"2016-02-27T00:22:17Z","pushed_at":"2016-05-17T23:44:48Z","git_url":"git://github.com/mshields822/incubator-beam.git","ssh_url":"git@github.com:mshields822/incubator-beam.git","clone_url":"https://github.com/mshields822/incubator-beam.git","svn_url":"https://github.com/mshields822/incubator-beam","homepage":null,"size":14244,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3edae9b8b4d7afefb5c803c19bb0a1c21ebba89d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-05-17T18:12:41Z","pushed_at":"2016-05-17T23:48:04Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":16863,"stargazers_count":186,"watchers_count":186,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":25,"forks":93,"open_issues":25,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/346"},"html":{"href":"https://github.com/apache/incubator-beam/pull/346"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/346"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/aafcf5f9d0286ec5a6ed0d634df8ff0902897cdc"}}}}