{"action":"created","comment":{"url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/comments/84220293","pull_request_review_id":5010284,"id":84220293,"diff_hunk":"@@ -720,11 +720,11 @@ class StorageNodeService @Inject() (\n     }\n   }\n \n-  def getCurrentObjectLocation(mid: MuseumId, oid: Long): Future[MusitResult[Option[GenericStorageNode]]] = {\n+  def getCurrentObjectLocation(mid: MuseumId, oid: Long): Future[MusitResult[Option[StorageNode]]] = {\n     val currentNodeId = localObjectDao.currentLocation(oid)\n     val genNode = currentNodeId.flatMap { optCurrentNodeId =>\n       optCurrentNodeId.map { id =>\n-        unitDao.getNodeById(mid, id).map(MusitSuccess.apply)\n+        getNodeById(mid, id)","path":"service_storagefacility/src/main/scala/no/uio/musit/microservice/storagefacility/service/StorageNodeService.scala","position":10,"original_position":10,"commit_id":"c8596c8313a77fba410e53f890579e27ba5432e2","original_commit_id":"c8596c8313a77fba410e53f890579e27ba5432e2","user":{"login":"jarlah","id":404102,"avatar_url":"https://avatars.githubusercontent.com/u/404102?v=3","gravatar_id":"","url":"https://api.github.com/users/jarlah","html_url":"https://github.com/jarlah","followers_url":"https://api.github.com/users/jarlah/followers","following_url":"https://api.github.com/users/jarlah/following{/other_user}","gists_url":"https://api.github.com/users/jarlah/gists{/gist_id}","starred_url":"https://api.github.com/users/jarlah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarlah/subscriptions","organizations_url":"https://api.github.com/users/jarlah/orgs","repos_url":"https://api.github.com/users/jarlah/repos","events_url":"https://api.github.com/users/jarlah/events{/privacy}","received_events_url":"https://api.github.com/users/jarlah/received_events","type":"User","site_admin":false},"body":"hmm but is there a test for it? integration test?","created_at":"2016-10-20T06:37:46Z","updated_at":"2016-10-20T06:37:54Z","html_url":"https://github.com/MUSIT-Norway/musit/pull/185#discussion_r84220293","pull_request_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/comments/84220293"},"html":{"href":"https://github.com/MUSIT-Norway/musit/pull/185#discussion_r84220293"},"pull_request":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185","id":90140191,"html_url":"https://github.com/MUSIT-Norway/musit/pull/185","diff_url":"https://github.com/MUSIT-Norway/musit/pull/185.diff","patch_url":"https://github.com/MUSIT-Norway/musit/pull/185.patch","issue_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/185","number":185,"state":"open","locked":false,"title":"fixed problem for JAG","user":{"login":"ellenjo","id":17901949,"avatar_url":"https://avatars.githubusercontent.com/u/17901949?v=3","gravatar_id":"","url":"https://api.github.com/users/ellenjo","html_url":"https://github.com/ellenjo","followers_url":"https://api.github.com/users/ellenjo/followers","following_url":"https://api.github.com/users/ellenjo/following{/other_user}","gists_url":"https://api.github.com/users/ellenjo/gists{/gist_id}","starred_url":"https://api.github.com/users/ellenjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellenjo/subscriptions","organizations_url":"https://api.github.com/users/ellenjo/orgs","repos_url":"https://api.github.com/users/ellenjo/repos","events_url":"https://api.github.com/users/ellenjo/events{/privacy}","received_events_url":"https://api.github.com/users/ellenjo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-20T06:27:09Z","updated_at":"2016-10-20T06:37:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2606ff656d7fdb5d93143cd6388153e3c7bed14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185/commits","review_comments_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185/comments","review_comment_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/185/comments","statuses_url":"https://api.github.com/repos/MUSIT-Norway/musit/statuses/c8596c8313a77fba410e53f890579e27ba5432e2","head":{"label":"MUSIT-Norway:MUSARK-CURRlOCPATCH","ref":"MUSARK-CURRlOCPATCH","sha":"c8596c8313a77fba410e53f890579e27ba5432e2","user":{"login":"MUSIT-Norway","id":17343809,"avatar_url":"https://avatars.githubusercontent.com/u/17343809?v=3","gravatar_id":"","url":"https://api.github.com/users/MUSIT-Norway","html_url":"https://github.com/MUSIT-Norway","followers_url":"https://api.github.com/users/MUSIT-Norway/followers","following_url":"https://api.github.com/users/MUSIT-Norway/following{/other_user}","gists_url":"https://api.github.com/users/MUSIT-Norway/gists{/gist_id}","starred_url":"https://api.github.com/users/MUSIT-Norway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUSIT-Norway/subscriptions","organizations_url":"https://api.github.com/users/MUSIT-Norway/orgs","repos_url":"https://api.github.com/users/MUSIT-Norway/repos","events_url":"https://api.github.com/users/MUSIT-Norway/events{/privacy}","received_events_url":"https://api.github.com/users/MUSIT-Norway/received_events","type":"Organization","site_admin":false},"repo":{"id":52344845,"name":"musit","full_name":"MUSIT-Norway/musit","owner":{"login":"MUSIT-Norway","id":17343809,"avatar_url":"https://avatars.githubusercontent.com/u/17343809?v=3","gravatar_id":"","url":"https://api.github.com/users/MUSIT-Norway","html_url":"https://github.com/MUSIT-Norway","followers_url":"https://api.github.com/users/MUSIT-Norway/followers","following_url":"https://api.github.com/users/MUSIT-Norway/following{/other_user}","gists_url":"https://api.github.com/users/MUSIT-Norway/gists{/gist_id}","starred_url":"https://api.github.com/users/MUSIT-Norway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUSIT-Norway/subscriptions","organizations_url":"https://api.github.com/users/MUSIT-Norway/orgs","repos_url":"https://api.github.com/users/MUSIT-Norway/repos","events_url":"https://api.github.com/users/MUSIT-Norway/events{/privacy}","received_events_url":"https://api.github.com/users/MUSIT-Norway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MUSIT-Norway/musit","description":"Norwegian university museums IT organization (MUSIT); cultural history and natural history database with store integration","fork":false,"url":"https://api.github.com/repos/MUSIT-Norway/musit","forks_url":"https://api.github.com/repos/MUSIT-Norway/musit/forks","keys_url":"https://api.github.com/repos/MUSIT-Norway/musit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MUSIT-Norway/musit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MUSIT-Norway/musit/teams","hooks_url":"https://api.github.com/repos/MUSIT-Norway/musit/hooks","issue_events_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/events{/number}","events_url":"https://api.github.com/repos/MUSIT-Norway/musit/events","assignees_url":"https://api.github.com/repos/MUSIT-Norway/musit/assignees{/user}","branches_url":"https://api.github.com/repos/MUSIT-Norway/musit/branches{/branch}","tags_url":"https://api.github.com/repos/MUSIT-Norway/musit/tags","blobs_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/refs{/sha}","trees_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MUSIT-Norway/musit/statuses/{sha}","languages_url":"https://api.github.com/repos/MUSIT-Norway/musit/languages","stargazers_url":"https://api.github.com/repos/MUSIT-Norway/musit/stargazers","contributors_url":"https://api.github.com/repos/MUSIT-Norway/musit/contributors","subscribers_url":"https://api.github.com/repos/MUSIT-Norway/musit/subscribers","subscription_url":"https://api.github.com/repos/MUSIT-Norway/musit/subscription","commits_url":"https://api.github.com/repos/MUSIT-Norway/musit/commits{/sha}","git_commits_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/commits{/sha}","comments_url":"https://api.github.com/repos/MUSIT-Norway/musit/comments{/number}","issue_comment_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/comments{/number}","contents_url":"https://api.github.com/repos/MUSIT-Norway/musit/contents/{+path}","compare_url":"https://api.github.com/repos/MUSIT-Norway/musit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MUSIT-Norway/musit/merges","archive_url":"https://api.github.com/repos/MUSIT-Norway/musit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MUSIT-Norway/musit/downloads","issues_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues{/number}","pulls_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls{/number}","milestones_url":"https://api.github.com/repos/MUSIT-Norway/musit/milestones{/number}","notifications_url":"https://api.github.com/repos/MUSIT-Norway/musit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MUSIT-Norway/musit/labels{/name}","releases_url":"https://api.github.com/repos/MUSIT-Norway/musit/releases{/id}","deployments_url":"https://api.github.com/repos/MUSIT-Norway/musit/deployments","created_at":"2016-02-23T08:53:04Z","updated_at":"2016-10-11T21:15:10Z","pushed_at":"2016-10-20T06:33:01Z","git_url":"git://github.com/MUSIT-Norway/musit.git","ssh_url":"git@github.com:MUSIT-Norway/musit.git","clone_url":"https://github.com/MUSIT-Norway/musit.git","svn_url":"https://github.com/MUSIT-Norway/musit","homepage":"","size":15409,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"MUSIT-Norway:master","ref":"master","sha":"63028e64ad1affeafc735f078d6cd34b8110ccb4","user":{"login":"MUSIT-Norway","id":17343809,"avatar_url":"https://avatars.githubusercontent.com/u/17343809?v=3","gravatar_id":"","url":"https://api.github.com/users/MUSIT-Norway","html_url":"https://github.com/MUSIT-Norway","followers_url":"https://api.github.com/users/MUSIT-Norway/followers","following_url":"https://api.github.com/users/MUSIT-Norway/following{/other_user}","gists_url":"https://api.github.com/users/MUSIT-Norway/gists{/gist_id}","starred_url":"https://api.github.com/users/MUSIT-Norway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUSIT-Norway/subscriptions","organizations_url":"https://api.github.com/users/MUSIT-Norway/orgs","repos_url":"https://api.github.com/users/MUSIT-Norway/repos","events_url":"https://api.github.com/users/MUSIT-Norway/events{/privacy}","received_events_url":"https://api.github.com/users/MUSIT-Norway/received_events","type":"Organization","site_admin":false},"repo":{"id":52344845,"name":"musit","full_name":"MUSIT-Norway/musit","owner":{"login":"MUSIT-Norway","id":17343809,"avatar_url":"https://avatars.githubusercontent.com/u/17343809?v=3","gravatar_id":"","url":"https://api.github.com/users/MUSIT-Norway","html_url":"https://github.com/MUSIT-Norway","followers_url":"https://api.github.com/users/MUSIT-Norway/followers","following_url":"https://api.github.com/users/MUSIT-Norway/following{/other_user}","gists_url":"https://api.github.com/users/MUSIT-Norway/gists{/gist_id}","starred_url":"https://api.github.com/users/MUSIT-Norway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUSIT-Norway/subscriptions","organizations_url":"https://api.github.com/users/MUSIT-Norway/orgs","repos_url":"https://api.github.com/users/MUSIT-Norway/repos","events_url":"https://api.github.com/users/MUSIT-Norway/events{/privacy}","received_events_url":"https://api.github.com/users/MUSIT-Norway/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MUSIT-Norway/musit","description":"Norwegian university museums IT organization (MUSIT); cultural history and natural history database with store integration","fork":false,"url":"https://api.github.com/repos/MUSIT-Norway/musit","forks_url":"https://api.github.com/repos/MUSIT-Norway/musit/forks","keys_url":"https://api.github.com/repos/MUSIT-Norway/musit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MUSIT-Norway/musit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MUSIT-Norway/musit/teams","hooks_url":"https://api.github.com/repos/MUSIT-Norway/musit/hooks","issue_events_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/events{/number}","events_url":"https://api.github.com/repos/MUSIT-Norway/musit/events","assignees_url":"https://api.github.com/repos/MUSIT-Norway/musit/assignees{/user}","branches_url":"https://api.github.com/repos/MUSIT-Norway/musit/branches{/branch}","tags_url":"https://api.github.com/repos/MUSIT-Norway/musit/tags","blobs_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/refs{/sha}","trees_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MUSIT-Norway/musit/statuses/{sha}","languages_url":"https://api.github.com/repos/MUSIT-Norway/musit/languages","stargazers_url":"https://api.github.com/repos/MUSIT-Norway/musit/stargazers","contributors_url":"https://api.github.com/repos/MUSIT-Norway/musit/contributors","subscribers_url":"https://api.github.com/repos/MUSIT-Norway/musit/subscribers","subscription_url":"https://api.github.com/repos/MUSIT-Norway/musit/subscription","commits_url":"https://api.github.com/repos/MUSIT-Norway/musit/commits{/sha}","git_commits_url":"https://api.github.com/repos/MUSIT-Norway/musit/git/commits{/sha}","comments_url":"https://api.github.com/repos/MUSIT-Norway/musit/comments{/number}","issue_comment_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues/comments{/number}","contents_url":"https://api.github.com/repos/MUSIT-Norway/musit/contents/{+path}","compare_url":"https://api.github.com/repos/MUSIT-Norway/musit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MUSIT-Norway/musit/merges","archive_url":"https://api.github.com/repos/MUSIT-Norway/musit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MUSIT-Norway/musit/downloads","issues_url":"https://api.github.com/repos/MUSIT-Norway/musit/issues{/number}","pulls_url":"https://api.github.com/repos/MUSIT-Norway/musit/pulls{/number}","milestones_url":"https://api.github.com/repos/MUSIT-Norway/musit/milestones{/number}","notifications_url":"https://api.github.com/repos/MUSIT-Norway/musit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MUSIT-Norway/musit/labels{/name}","releases_url":"https://api.github.com/repos/MUSIT-Norway/musit/releases{/id}","deployments_url":"https://api.github.com/repos/MUSIT-Norway/musit/deployments","created_at":"2016-02-23T08:53:04Z","updated_at":"2016-10-11T21:15:10Z","pushed_at":"2016-10-20T06:33:01Z","git_url":"git://github.com/MUSIT-Norway/musit.git","ssh_url":"git@github.com:MUSIT-Norway/musit.git","clone_url":"https://github.com/MUSIT-Norway/musit.git","svn_url":"https://github.com/MUSIT-Norway/musit","homepage":"","size":15409,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185"},"html":{"href":"https://github.com/MUSIT-Norway/musit/pull/185"},"issue":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/issues/185"},"comments":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/MUSIT-Norway/musit/statuses/c8596c8313a77fba410e53f890579e27ba5432e2"}}}}
{"actor":{"display_login":"jarlah"}}