{"action":"created","issue":{"url":"https://api.github.com/repos/CanalTP/navitia/issues/1843","repository_url":"https://api.github.com/repos/CanalTP/navitia","labels_url":"https://api.github.com/repos/CanalTP/navitia/issues/1843/labels{/name}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1843/comments","events_url":"https://api.github.com/repos/CanalTP/navitia/issues/1843/events","html_url":"https://github.com/CanalTP/navitia/pull/1843","id":188230253,"number":1843,"title":"Ed: refacto osm2ed to allow one poi-type from multi osm tags","user":{"login":"pbougue","id":12812530,"avatar_url":"https://avatars.githubusercontent.com/u/12812530?v=3","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"labels":[{"id":137698177,"url":"https://api.github.com/repos/CanalTP/navitia/labels/do_not_merge","name":"do_not_merge","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-09T11:57:01Z","updated_at":"2016-11-09T17:19:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1843","html_url":"https://github.com/CanalTP/navitia/pull/1843","diff_url":"https://github.com/CanalTP/navitia/pull/1843.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1843.patch"},"body":"POI-type params will now:\r\n* allow to create one POI-type from multiple OSM-tags (all are required for the OSM-object to to be typed)\r\n* allow to use OSM-tag key or value that includes a `:`\r\n* fill POI name with its POI-type label if no name is provided by OSM\r\n* allow a simple check of params: call `osm2ed -p {<my json poi-type params>}` and test that it returns OK (`0`) \r\n\r\nDefault poi-type param: see source/ed/default_poi_types.h\r\n\r\nWARNING: does not compile on debian7, as it uses `boost::property_tree::read_json` which has the bug https://svn.boost.org/trac/boost/ticket/6785 in boost 1.49.\r\nSo after the merge of this PR, no coming back on debian7.\r\n\r\nTODO:\r\n\r\n- [x] cleanup (pass on \"poi-type\" and \"amenity\" elsewhere, rm to_string)\r\n- [x] allow simple json-param check\r\n- [ ] tests ?"},"comment":{"url":"https://api.github.com/repos/CanalTP/navitia/issues/comments/259470922","html_url":"https://github.com/CanalTP/navitia/pull/1843#issuecomment-259470922","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1843","id":259470922,"user":{"login":"pbougue","id":12812530,"avatar_url":"https://avatars.githubusercontent.com/u/12812530?v=3","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T17:19:14Z","updated_at":"2016-11-09T17:19:14Z","body":"Jenkins, test this please"}}
{"actor":{"display_login":"pbougue"}}