{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/2749","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/2749/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/2749/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/2749/events","html_url":"https://github.com/systemd/systemd/pull/2749","id":136722564,"number":2749,"title":"More tolerant parsing of /etc/adjtime","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-26T15:08:47Z","updated_at":"2016-02-29T07:52:22Z","closed_at":"2016-02-28T23:58:44Z","pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/2749","html_url":"https://github.com/systemd/systemd/pull/2749","diff_url":"https://github.com/systemd/systemd/pull/2749.diff","patch_url":"https://github.com/systemd/systemd/pull/2749.patch"},"body":"Adjust parsing of `/etc/adjtime` in `clock_is_localtime()` (with unit tests) and timedated to be more liberal with ancient/broken files which only have one or two lines, and/or no final newline.\r\n\r\nFor now I created some integration tests for this part of timedated: http://paste.ubuntu.com/15206193/ I'll commit them if/when this lands (as otherwise all other PRs will start to fail). If you don't like that, we could also move timedated's `context_write_data_local_rtc()` to `src/basic/clock-util.c` as `clock_set_localtime()` and give it a path and a boolean as argument (not the full `Context` thing which should remain local to timedated) -- then we could create unit tests instead. This would slightly increase the shared library, even though the function is only being used in one place.\r\n\r\nThis fixes issue #2638."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/190082350","html_url":"https://github.com/systemd/systemd/pull/2749#issuecomment-190082350","issue_url":"https://api.github.com/repos/systemd/systemd/issues/2749","id":190082350,"user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T07:52:22Z","updated_at":"2016-02-29T07:52:22Z","body":"Thanks. I pushed the timedated integration tests too."}}