{"action":"closed","issue":{"url":"https://api.github.com/repos/MiniProfiler/dotnet/issues/114","repository_url":"https://api.github.com/repos/MiniProfiler/dotnet","labels_url":"https://api.github.com/repos/MiniProfiler/dotnet/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/MiniProfiler/dotnet/issues/114/comments","events_url":"https://api.github.com/repos/MiniProfiler/dotnet/issues/114/events","html_url":"https://github.com/MiniProfiler/dotnet/issues/114","id":91621131,"number":114,"title":"`IsTrivial` impl in `Timing`","user":{"login":"wqweto","id":987963,"avatar_url":"https://avatars.githubusercontent.com/u/987963?v=3","gravatar_id":"","url":"https://api.github.com/users/wqweto","html_url":"https://github.com/wqweto","followers_url":"https://api.github.com/users/wqweto/followers","following_url":"https://api.github.com/users/wqweto/following{/other_user}","gists_url":"https://api.github.com/users/wqweto/gists{/gist_id}","starred_url":"https://api.github.com/users/wqweto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wqweto/subscriptions","organizations_url":"https://api.github.com/users/wqweto/orgs","repos_url":"https://api.github.com/users/wqweto/repos","events_url":"https://api.github.com/users/wqweto/events{/privacy}","received_events_url":"https://api.github.com/users/wqweto/received_events","type":"User","site_admin":false},"labels":[{"id":50817021,"url":"https://api.github.com/repos/MiniProfiler/dotnet/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MiniProfiler/dotnet/milestones/1","html_url":"https://github.com/MiniProfiler/dotnet/milestones/4.0","labels_url":"https://api.github.com/repos/MiniProfiler/dotnet/milestones/1/labels","id":2151183,"number":1,"title":"4.0","description":"4.0 release supporting `net45`+ and `netstandard`, ASP.NET Core, MonogoDB 2.x drivers, `async`, etc.","creator":{"login":"NickCraver","id":454813,"avatar_url":"https://avatars.githubusercontent.com/u/454813?v=3","gravatar_id":"","url":"https://api.github.com/users/NickCraver","html_url":"https://github.com/NickCraver","followers_url":"https://api.github.com/users/NickCraver/followers","following_url":"https://api.github.com/users/NickCraver/following{/other_user}","gists_url":"https://api.github.com/users/NickCraver/gists{/gist_id}","starred_url":"https://api.github.com/users/NickCraver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickCraver/subscriptions","organizations_url":"https://api.github.com/users/NickCraver/orgs","repos_url":"https://api.github.com/users/NickCraver/repos","events_url":"https://api.github.com/users/NickCraver/events{/privacy}","received_events_url":"https://api.github.com/users/NickCraver/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2016-11-22T11:18:47Z","updated_at":"2016-11-29T02:52:42Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-06-28T18:03:06Z","updated_at":"2016-11-29T02:52:42Z","closed_at":"2016-11-29T02:52:42Z","body":"Currently it checks if `DurationWithoutChildrenMilliseconds` is below a certain threshold. Can this be altered to use the whole `DurationMilliseconds` instead?\n\nHere is the use-case I'm facing. Notice this collapsed view on profiling\n\n![Confusion w/o trivials](https://dl.unicontsoft.com/upload/pix/ss_mini_1.png)\n\nIt seems that the partial view tool 3.2 ms _including_ children but then each of the children took longer! WTF?!\n\nMystery explained when trivials shown\n\n![Expanded](https://dl.unicontsoft.com/upload/pix/ss_mini_2.png)\n\nThere is a hidden parent `Controller: HomeController._HeaderFunctionali...` that's been marked trivial as being timed below 2 ms _without_ children. \n\nIs there some kind of special purpose for using `DurationWithoutChildrenMilliseconds` that I'm missing here?\n"}}
{"actor":{"display_login":"NickCraver"}}