{"action":"closed","number":191,"pull_request":{"url":"https://api.github.com/repos/airbnb/synapse/pulls/191","id":71632975,"html_url":"https://github.com/airbnb/synapse/pull/191","diff_url":"https://github.com/airbnb/synapse/pull/191.diff","patch_url":"https://github.com/airbnb/synapse/pull/191.patch","issue_url":"https://api.github.com/repos/airbnb/synapse/issues/191","number":191,"state":"closed","locked":false,"title":"Haproxy tests","user":{"login":"igor47","id":200575,"avatar_url":"https://avatars.githubusercontent.com/u/200575?v=3","gravatar_id":"","url":"https://api.github.com/users/igor47","html_url":"https://github.com/igor47","followers_url":"https://api.github.com/users/igor47/followers","following_url":"https://api.github.com/users/igor47/following{/other_user}","gists_url":"https://api.github.com/users/igor47/gists{/gist_id}","starred_url":"https://api.github.com/users/igor47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor47/subscriptions","organizations_url":"https://api.github.com/users/igor47/orgs","repos_url":"https://api.github.com/users/igor47/repos","events_url":"https://api.github.com/users/igor47/events{/privacy}","received_events_url":"https://api.github.com/users/igor47/received_events","type":"User","site_admin":false},"body":"This PR contains no functional changes to Synapse. Instead, it adds a bunch of tests for the Haproxy class. We refactor the Haproxy class slightly to make testing easier. The main goal was to cover the state file handling with tests, since we're about to start using the state file at Airbnb. No bugs were found!\r\n\r\nIdeally, we would only test the public methods of Haproxy -- `initialize`, `tick`, and `update_config`. however, if I set all of the other methods to private, we fail lots of existing tests, and testing the deep functionality of Haproxy via the public interface seems very tedious. So, although I intended to make that change here, I decided to save it for some other time.\r\n\r\nto: @jolynch @scarletmeow ","created_at":"2016-05-26T22:10:49Z","updated_at":"2016-05-26T22:54:50Z","closed_at":"2016-05-26T22:54:50Z","merged_at":"2016-05-26T22:54:50Z","merge_commit_sha":"257cd9c995d6e4e2faa3a82ebdb879a9872b653e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/synapse/pulls/191/commits","review_comments_url":"https://api.github.com/repos/airbnb/synapse/pulls/191/comments","review_comment_url":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/synapse/issues/191/comments","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/6cf3c853319dec335ddf1d5cee8f4567f955093e","head":{"label":"airbnb:haproxy_tests","ref":"haproxy_tests","sha":"6cf3c853319dec335ddf1d5cee8f4567f955093e","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6607851,"name":"synapse","full_name":"airbnb/synapse","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":false,"url":"https://api.github.com/repos/airbnb/synapse","forks_url":"https://api.github.com/repos/airbnb/synapse/forks","keys_url":"https://api.github.com/repos/airbnb/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/synapse/teams","hooks_url":"https://api.github.com/repos/airbnb/synapse/hooks","issue_events_url":"https://api.github.com/repos/airbnb/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/synapse/events","assignees_url":"https://api.github.com/repos/airbnb/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/synapse/tags","blobs_url":"https://api.github.com/repos/airbnb/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/synapse/languages","stargazers_url":"https://api.github.com/repos/airbnb/synapse/stargazers","contributors_url":"https://api.github.com/repos/airbnb/synapse/contributors","subscribers_url":"https://api.github.com/repos/airbnb/synapse/subscribers","subscription_url":"https://api.github.com/repos/airbnb/synapse/subscription","commits_url":"https://api.github.com/repos/airbnb/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/synapse/merges","archive_url":"https://api.github.com/repos/airbnb/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/synapse/downloads","issues_url":"https://api.github.com/repos/airbnb/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/synapse/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/synapse/deployments","created_at":"2012-11-09T03:03:06Z","updated_at":"2016-05-21T14:43:36Z","pushed_at":"2016-05-26T22:54:50Z","git_url":"git://github.com/airbnb/synapse.git","ssh_url":"git@github.com:airbnb/synapse.git","clone_url":"https://github.com/airbnb/synapse.git","svn_url":"https://github.com/airbnb/synapse","homepage":"","size":817,"stargazers_count":1369,"watchers_count":1369,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":42,"forks":174,"open_issues":42,"watchers":1369,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"297a38ab5cbb4b3a09d997c307cc66946a78a2c7","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6607851,"name":"synapse","full_name":"airbnb/synapse","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/synapse","description":"A transparent service discovery framework for connecting an SOA","fork":false,"url":"https://api.github.com/repos/airbnb/synapse","forks_url":"https://api.github.com/repos/airbnb/synapse/forks","keys_url":"https://api.github.com/repos/airbnb/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/synapse/teams","hooks_url":"https://api.github.com/repos/airbnb/synapse/hooks","issue_events_url":"https://api.github.com/repos/airbnb/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/synapse/events","assignees_url":"https://api.github.com/repos/airbnb/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/synapse/tags","blobs_url":"https://api.github.com/repos/airbnb/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/synapse/languages","stargazers_url":"https://api.github.com/repos/airbnb/synapse/stargazers","contributors_url":"https://api.github.com/repos/airbnb/synapse/contributors","subscribers_url":"https://api.github.com/repos/airbnb/synapse/subscribers","subscription_url":"https://api.github.com/repos/airbnb/synapse/subscription","commits_url":"https://api.github.com/repos/airbnb/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/synapse/merges","archive_url":"https://api.github.com/repos/airbnb/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/synapse/downloads","issues_url":"https://api.github.com/repos/airbnb/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/synapse/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/synapse/deployments","created_at":"2012-11-09T03:03:06Z","updated_at":"2016-05-21T14:43:36Z","pushed_at":"2016-05-26T22:54:50Z","git_url":"git://github.com/airbnb/synapse.git","ssh_url":"git@github.com:airbnb/synapse.git","clone_url":"https://github.com/airbnb/synapse.git","svn_url":"https://github.com/airbnb/synapse","homepage":"","size":817,"stargazers_count":1369,"watchers_count":1369,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":42,"forks":174,"open_issues":42,"watchers":1369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/191"},"html":{"href":"https://github.com/airbnb/synapse/pull/191"},"issue":{"href":"https://api.github.com/repos/airbnb/synapse/issues/191"},"comments":{"href":"https://api.github.com/repos/airbnb/synapse/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/synapse/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/synapse/statuses/6cf3c853319dec335ddf1d5cee8f4567f955093e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"igor47","id":200575,"avatar_url":"https://avatars.githubusercontent.com/u/200575?v=3","gravatar_id":"","url":"https://api.github.com/users/igor47","html_url":"https://github.com/igor47","followers_url":"https://api.github.com/users/igor47/followers","following_url":"https://api.github.com/users/igor47/following{/other_user}","gists_url":"https://api.github.com/users/igor47/gists{/gist_id}","starred_url":"https://api.github.com/users/igor47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor47/subscriptions","organizations_url":"https://api.github.com/users/igor47/orgs","repos_url":"https://api.github.com/users/igor47/repos","events_url":"https://api.github.com/users/igor47/events{/privacy}","received_events_url":"https://api.github.com/users/igor47/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"commits":7,"additions":212,"deletions":43,"changed_files":5}}
{"actor":{"display_login":"igor47"}}