{"action":"created","comment":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76367373","id":76367373,"diff_hunk":"@@ -0,0 +1,30 @@\n+package gmgen.plugin.dice;\n+\n+import java.util.Random;\n+\n+public class AppendModifier implements ResultModifier\n+{\n+\n+\tprivate final int count;\n+\tprivate final int max;\n+\tprivate final Random rand;\n+\n+\tpublic AppendModifier(final int count, final int max, final Random rand) {\n+\t\tthis.count = count;\n+\t\tthis.max = max;\n+\t\tthis.rand = rand;\n+\t}\n+\n+\t@Override\n+\tpublic int[] resultAsModified(int[] in)\n+\t{\n+\t\tint[] newResults = new int[count + in.length];\n+\t\tSystem.arraycopy(in, 0, newResults, 0, in.length);\n+\t\tfor (int i = 0; i < count; ++i)\n+\t\t{\n+\t\t\tint thisRoll = rand.nextInt(max) + 1;\n+\t\t\tnewResults[in.length + i] = thisRoll;\n+\t\t}\n+\t\treturn newResults;\n+\t}\n+}","path":"code/src/java/gmgen/plugin/dice/AppendModifier.java","position":30,"original_position":30,"commit_id":"24ade462134f9ec69e7f759aa4e845524211596e","original_commit_id":"24ade462134f9ec69e7f759aa4e845524211596e","user":{"login":"cpmeister","id":1217471,"avatar_url":"https://avatars.githubusercontent.com/u/1217471?v=3","gravatar_id":"","url":"https://api.github.com/users/cpmeister","html_url":"https://github.com/cpmeister","followers_url":"https://api.github.com/users/cpmeister/followers","following_url":"https://api.github.com/users/cpmeister/following{/other_user}","gists_url":"https://api.github.com/users/cpmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/cpmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpmeister/subscriptions","organizations_url":"https://api.github.com/users/cpmeister/orgs","repos_url":"https://api.github.com/users/cpmeister/repos","events_url":"https://api.github.com/users/cpmeister/events{/privacy}","received_events_url":"https://api.github.com/users/cpmeister/received_events","type":"User","site_admin":false},"body":"Thanks I forgot to notice the ones you added prior","created_at":"2016-08-26T05:54:32Z","updated_at":"2016-08-26T05:54:32Z","html_url":"https://github.com/PCGen/pcgen/pull/1446#discussion_r76367373","pull_request_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1446","_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments/76367373"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1446#discussion_r76367373"},"pull_request":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1446"}}},"pull_request":{"url":"https://api.github.com/repos/PCGen/pcgen/pulls/1446","id":82739126,"html_url":"https://github.com/PCGen/pcgen/pull/1446","diff_url":"https://github.com/PCGen/pcgen/pull/1446.diff","patch_url":"https://github.com/PCGen/pcgen/pull/1446.patch","issue_url":"https://api.github.com/repos/PCGen/pcgen/issues/1446","number":1446,"state":"open","locked":false,"title":"further the Die abstraction work","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"This furthers the die abstraction work but moving the addition of new values out of the Die and into a DieModifier.\r\n\r\nIn the old world there are multiple levels of abstraction:\r\nDie, Dice, DieEx, SystemDie\r\nall of which provide very specific features.\r\n\r\nIn the new world these will all be replaced by a DiceConfiguration which is just a sequence of filters ","created_at":"2016-08-25T15:16:06Z","updated_at":"2016-08-26T05:54:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6e925eea2968ca934775e4174a076f3ea3eefbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1446/commits","review_comments_url":"https://api.github.com/repos/PCGen/pcgen/pulls/1446/comments","review_comment_url":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCGen/pcgen/issues/1446/comments","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/24ade462134f9ec69e7f759aa4e845524211596e","head":{"label":"grimreaper:eax/modern-part-13","ref":"eax/modern-part-13","sha":"24ade462134f9ec69e7f759aa4e845524211596e","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"repo":{"id":43053313,"name":"pcgen","full_name":"grimreaper/pcgen","owner":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grimreaper/pcgen","description":"Main code and data development for pcgen program release","fork":true,"url":"https://api.github.com/repos/grimreaper/pcgen","forks_url":"https://api.github.com/repos/grimreaper/pcgen/forks","keys_url":"https://api.github.com/repos/grimreaper/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grimreaper/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grimreaper/pcgen/teams","hooks_url":"https://api.github.com/repos/grimreaper/pcgen/hooks","issue_events_url":"https://api.github.com/repos/grimreaper/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/grimreaper/pcgen/events","assignees_url":"https://api.github.com/repos/grimreaper/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/grimreaper/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/grimreaper/pcgen/tags","blobs_url":"https://api.github.com/repos/grimreaper/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grimreaper/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grimreaper/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/grimreaper/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grimreaper/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/grimreaper/pcgen/languages","stargazers_url":"https://api.github.com/repos/grimreaper/pcgen/stargazers","contributors_url":"https://api.github.com/repos/grimreaper/pcgen/contributors","subscribers_url":"https://api.github.com/repos/grimreaper/pcgen/subscribers","subscription_url":"https://api.github.com/repos/grimreaper/pcgen/subscription","commits_url":"https://api.github.com/repos/grimreaper/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/grimreaper/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/grimreaper/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/grimreaper/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/grimreaper/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/grimreaper/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grimreaper/pcgen/merges","archive_url":"https://api.github.com/repos/grimreaper/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grimreaper/pcgen/downloads","issues_url":"https://api.github.com/repos/grimreaper/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/grimreaper/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/grimreaper/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/grimreaper/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grimreaper/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/grimreaper/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/grimreaper/pcgen/deployments","created_at":"2015-09-24T08:01:43Z","updated_at":"2015-09-24T08:02:48Z","pushed_at":"2016-08-26T02:08:04Z","git_url":"git://github.com/grimreaper/pcgen.git","ssh_url":"git@github.com:grimreaper/pcgen.git","clone_url":"https://github.com/grimreaper/pcgen.git","svn_url":"https://github.com/grimreaper/pcgen","homepage":"http://pcgen.org","size":217126,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCGen:master","ref":"master","sha":"af2b6480e67494e6153be11612a60763f8e79558","user":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"repo":{"id":28585874,"name":"pcgen","full_name":"PCGen/pcgen","owner":{"login":"PCGen","id":2158677,"avatar_url":"https://avatars.githubusercontent.com/u/2158677?v=3","gravatar_id":"","url":"https://api.github.com/users/PCGen","html_url":"https://github.com/PCGen","followers_url":"https://api.github.com/users/PCGen/followers","following_url":"https://api.github.com/users/PCGen/following{/other_user}","gists_url":"https://api.github.com/users/PCGen/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGen/subscriptions","organizations_url":"https://api.github.com/users/PCGen/orgs","repos_url":"https://api.github.com/users/PCGen/repos","events_url":"https://api.github.com/users/PCGen/events{/privacy}","received_events_url":"https://api.github.com/users/PCGen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCGen/pcgen","description":"Main code and data development for pcgen program release","fork":false,"url":"https://api.github.com/repos/PCGen/pcgen","forks_url":"https://api.github.com/repos/PCGen/pcgen/forks","keys_url":"https://api.github.com/repos/PCGen/pcgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCGen/pcgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCGen/pcgen/teams","hooks_url":"https://api.github.com/repos/PCGen/pcgen/hooks","issue_events_url":"https://api.github.com/repos/PCGen/pcgen/issues/events{/number}","events_url":"https://api.github.com/repos/PCGen/pcgen/events","assignees_url":"https://api.github.com/repos/PCGen/pcgen/assignees{/user}","branches_url":"https://api.github.com/repos/PCGen/pcgen/branches{/branch}","tags_url":"https://api.github.com/repos/PCGen/pcgen/tags","blobs_url":"https://api.github.com/repos/PCGen/pcgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCGen/pcgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCGen/pcgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCGen/pcgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCGen/pcgen/statuses/{sha}","languages_url":"https://api.github.com/repos/PCGen/pcgen/languages","stargazers_url":"https://api.github.com/repos/PCGen/pcgen/stargazers","contributors_url":"https://api.github.com/repos/PCGen/pcgen/contributors","subscribers_url":"https://api.github.com/repos/PCGen/pcgen/subscribers","subscription_url":"https://api.github.com/repos/PCGen/pcgen/subscription","commits_url":"https://api.github.com/repos/PCGen/pcgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCGen/pcgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCGen/pcgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCGen/pcgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCGen/pcgen/contents/{+path}","compare_url":"https://api.github.com/repos/PCGen/pcgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCGen/pcgen/merges","archive_url":"https://api.github.com/repos/PCGen/pcgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCGen/pcgen/downloads","issues_url":"https://api.github.com/repos/PCGen/pcgen/issues{/number}","pulls_url":"https://api.github.com/repos/PCGen/pcgen/pulls{/number}","milestones_url":"https://api.github.com/repos/PCGen/pcgen/milestones{/number}","notifications_url":"https://api.github.com/repos/PCGen/pcgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCGen/pcgen/labels{/name}","releases_url":"https://api.github.com/repos/PCGen/pcgen/releases{/id}","deployments_url":"https://api.github.com/repos/PCGen/pcgen/deployments","created_at":"2014-12-29T08:41:04Z","updated_at":"2016-08-23T17:12:52Z","pushed_at":"2016-08-26T02:08:04Z","git_url":"git://github.com/PCGen/pcgen.git","ssh_url":"git@github.com:PCGen/pcgen.git","clone_url":"https://github.com/PCGen/pcgen.git","svn_url":"https://github.com/PCGen/pcgen","homepage":"http://pcgen.org","size":237101,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":11,"forks":80,"open_issues":11,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1446"},"html":{"href":"https://github.com/PCGen/pcgen/pull/1446"},"issue":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1446"},"comments":{"href":"https://api.github.com/repos/PCGen/pcgen/issues/1446/comments"},"review_comments":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1446/comments"},"review_comment":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCGen/pcgen/pulls/1446/commits"},"statuses":{"href":"https://api.github.com/repos/PCGen/pcgen/statuses/24ade462134f9ec69e7f759aa4e845524211596e"}}}}
{"actor":{"display_login":"cpmeister"}}