{"action":"created","issue":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/3167","repository_url":"https://api.github.com/repos/sakaiproject/sakai","labels_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3167/labels{/name}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3167/comments","events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3167/events","html_url":"https://github.com/sakaiproject/sakai/pull/3167","id":170177070,"number":3167,"title":"SAK-31656 Override defaults first in SCSS skin.","user":{"login":"buckett","id":5921,"avatar_url":"https://avatars.githubusercontent.com/u/5921?v=3","gravatar_id":"","url":"https://api.github.com/users/buckett","html_url":"https://github.com/buckett","followers_url":"https://api.github.com/users/buckett/followers","following_url":"https://api.github.com/users/buckett/following{/other_user}","gists_url":"https://api.github.com/users/buckett/gists{/gist_id}","starred_url":"https://api.github.com/users/buckett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buckett/subscriptions","organizations_url":"https://api.github.com/users/buckett/orgs","repos_url":"https://api.github.com/users/buckett/repos","events_url":"https://api.github.com/users/buckett/events{/privacy}","received_events_url":"https://api.github.com/users/buckett/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sakaiproject/sakai/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-09T14:14:00Z","updated_at":"2016-09-06T16:23:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3167","html_url":"https://github.com/sakaiproject/sakai/pull/3167","diff_url":"https://github.com/sakaiproject/sakai/pull/3167.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/3167.patch"},"body":"Locally at Oxford we've got our own changes to the Sakai default skin and these are in a customisations file. By default this customisation file in pulled in at the end of the _defaults.css file so you can override any of the variables in _defaults.css. As an example in _defaults.scss there is a primary colour defined as:\r\n\r\n    $primary-color: #2a94c0 !default;\r\n\r\nwe then in our customizations file re-define the primary colour to be:\r\n\r\n    $primary-color: #002147;\r\n\r\nthe problem is that if this primary colour is referenced anywhere else in _defaults.scss our re-define doesn't work because the value is already copied into the new variables, as an example:\r\n\r\n    $tool-menu-current-color: $primary-color !default;\r\n\r\nhere the tool menu current color will be the standard Sakai one, rather than our Oxford one. The !default on the end of the line says to only assign a value if one isn't already present so it seems that the sensible option is to import the customisations at the start of the defaults file rather than the end so that re-definitions take effect in all locations in the file."},"comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments/245006561","html_url":"https://github.com/sakaiproject/sakai/pull/3167#issuecomment-245006561","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3167","id":245006561,"user":{"login":"ottenhoff","id":810505,"avatar_url":"https://avatars.githubusercontent.com/u/810505?v=3","gravatar_id":"","url":"https://api.github.com/users/ottenhoff","html_url":"https://github.com/ottenhoff","followers_url":"https://api.github.com/users/ottenhoff/followers","following_url":"https://api.github.com/users/ottenhoff/following{/other_user}","gists_url":"https://api.github.com/users/ottenhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ottenhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottenhoff/subscriptions","organizations_url":"https://api.github.com/users/ottenhoff/orgs","repos_url":"https://api.github.com/users/ottenhoff/repos","events_url":"https://api.github.com/users/ottenhoff/events{/privacy}","received_events_url":"https://api.github.com/users/ottenhoff/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T16:23:51Z","updated_at":"2016-09-06T16:23:51Z","body":"/CC: @SedueRey "}}
{"actor":{"display_login":"ottenhoff"}}