{"push_id":1099947912,"size":1000,"distinct_size":21,"ref":"refs/heads/housebound","head":"3ee012f5b3bb54ce831b480bccf9439548e5768c","before":"01dae2c5a103601fde380742ff78a2802462b1b1","commits":[{"sha":"9afc8e96f3d173a3998cbec2a4ad7ceaf506e49a","author":{"email":"426f625364c21a69b07917eef7216c63bee01f3a@veron.ch","name":"Marc Véron"},"message":"Bug 14015 - Checkout: Fix software error if barcode '0' is given\n\nTo reproduce the bug:\n- Go to Home > Circulation > Checkouts > [a patron]\n- Enter 0 (zero) in barcode field and hit Enter\n\nResult:\nSoftware error\n  Can't use string (\"1\") as a HASH ref while \"strict refs\" in use\n  at /usr/share/kohaclone/circ/circulation.pl line 473\n\nTo test:\n- Apply patch\n- Repeat steps above\n- Verify that the sofware error is gone and that you get a\n  message as with other invalid barcodes.\n- Test with other values: '00', '000', existing barcode,\n  and a barcode that does not exist\n- Test with empty barcode (for printing slip)\n- Search for regressions\n\nThis patch implements Jonathan's solution (see comment #15)\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/9afc8e96f3d173a3998cbec2a4ad7ceaf506e49a"},{"sha":"b9e5aee1b66be893354733b6710b1df1b04edeb1","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":" Bug 13177: Help page for Rotating Collections\n\nTo test:\n\nGo to Tools -> Rotating Collections and click Help in the top-right. Confirm the Help page shows and gives correct accurate instructions with no typos or grammatical errors.\n\nHelp displays as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Nicole Engard <nengard@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/b9e5aee1b66be893354733b6710b1df1b04edeb1"},{"sha":"eacbfb2069b155af80ef88473c46bfc130c6c070","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":" Bug 13177: Accidental copy/paste error fix\n\nConfirm it now says Rotating Collections instead of Patron Import in the last line, and the link is correct.\n\nSigned-off-by: Nicole Engard <nengard@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/eacbfb2069b155af80ef88473c46bfc130c6c070"},{"sha":"1d99fa026bb05225df93e56740456ba185a5937d","author":{"email":"a4ed5d8b9e88a5c4401757374b1604745a5e46b6@rijksmuseum.nl","name":"Marcel de Rooy"},"message":" Bug 9754: koha-remove optionally includes var/lib and var/spool\n\nCurrently, the files in the folder /var/lib/koha/[instance] and also\nin /var/spool/koha/[instance] are not removed.\nThis patch adds the option -p|--purge-all to include those two\ndirectories when removing files.\n\nNote: There was a small bug in the for loop. On the -k line the extra\nshift statement is one too much.\n\nNOTE: Verify that you use the adjusted koha-remove in the test plan\nand not accidentally an older version of this script.\n\nTest plan:\n[1] Create an instance test.\n[2] Run koha-remove and verify that /var/lib/koha/test still exists.\n[3] Create an instance test2.\n[4] Run koha-remove -k -p and verify that the sql database still exists\n    but the two instance folders in var/lib/koha and var/spool/koha are\n    gone.\n\nSigned-off-by: Chris Cormack <chrisc@catalyst.net.nz>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/1d99fa026bb05225df93e56740456ba185a5937d"},{"sha":"2923cfdff4466efed55dd3d3dbee8ba37f6ff882","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":" Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off\n\nIf the user knows the URL for OPAC lists they can access them even with\nthe virtualshelves preference turned off. This patch copies the solution\nadded to opac-topissues.pl by Bug 10595 and applies it to OPAC lists\npages.\n\nTo test, apply the patch and set the virtualshelves system preference to\n\"don't allow.\"\n\n- Navigate to /cgi-bin/koha/opac-shelves.pl. You should be redirected to\n  an Error 404 page.\n- Also check:\n  - /cgi-bin/koha/opac-shareshelf.pl.\n  - /cgi-bin/koha/opac-downloadshelf.pl\n  - /cgi-bin/koha/opac-sendshelf.pl\n  - /cgi-bin/koha/opac-addbybiblionumber.pl\n- Turn virtualshelves back on. Access to lists and list sharing should\n  be restored.\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/2923cfdff4466efed55dd3d3dbee8ba37f6ff882"},{"sha":"6a2bf8d31b1fbe1d83a66d314bc97be41af65ca7","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":" Bug 4912: Redirect to the appropriate view after editing/deleting a list\n\nThere are 2 places where a list can be edited/deleted: on the list view\nand the list content view. After the edition, the user expect to be\nredirect to the previous page.\nThis patch implements that.\n\nTest plan:\nAt the OPAC, delete and edit a list from the 2 differents places.\nConfirm that you are redirect to the page you come from.\n\nWith patch, redirects work as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/6a2bf8d31b1fbe1d83a66d314bc97be41af65ca7"},{"sha":"bb6658c2e680d615bccd6d5d2f4c971035a44ea1","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":" Bug 2669: Change checkboxes to radio buttons on dictionary\n\nOn creating new dictionary for report, the choice between \"All dates\"\nand \"Date range\" should be a real radio button, not 2 radio buttons with\ndifferent names (which means they could be selected altogether...)\n\nNote that I don't understand what means 'All dates', there is no\ncondition generated for the dictionary. We should not have to select a\nfield if we don't want to add a condition on it :)\n\nTest plan:\nCreate a new dictionary for the Patron module, then a date field\n(dateenrolled or birthdate, etc.)\n\nConfirm that the radio buttons now behave as radio buttons...\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\n\nLooks so much nicer too!\n\nRadio buttons display as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/bb6658c2e680d615bccd6d5d2f4c971035a44ea1"},{"sha":"f37ce198feae78b82b751f1c3d682010b4db0305","author":{"email":"0a829083c0ec9386a016e7524537f0816c24ff22@gmail.com","name":"Chloe"},"message":" Bug 15609 - spelling mistake in :692: writen ==> written\n\nTo test:\n\nCheck that \"writen\" has been changed to \"written\" on line 692\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/f37ce198feae78b82b751f1c3d682010b4db0305"},{"sha":"70086f1681155d8e63c9ee1b149c3f812df8f125","author":{"email":"0a829083c0ec9386a016e7524537f0816c24ff22@gmail.com","name":"Chloe"},"message":" Bug 15592 - spelling mistake in ~/Koha/koha-tmpl/intranet-tmpl/p./plugins/plugins-upload.tt\n\nTo Test:\n\ncheckthat \"extention\" has been changed to \"extension\" on line 27\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/70086f1681155d8e63c9ee1b149c3f812df8f125"},{"sha":"5b6457087d0c8be00cbe3d54a7e157706f74908b","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":" Bug 15577: Correcting link redirect\n\nTo test:\n1) Add a restriction to a user\n2) Log in as that user in the OPAC\n3) Click 'your account page' link in the yellow mesage\n4) Confirm you are taken to opac-account.pl\n\nSigned-off-by: Hector Castro <hector.hecaxmmx@gmail.com>\nWorks as advertised\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/5b6457087d0c8be00cbe3d54a7e157706f74908b"},{"sha":"3815915a3338c4380da7773acc675b07ac82562d","author":{"email":"85dd01236de5c6051a212977cd06f2aecf349d45@inlibro.com","name":"Blou"},"message":" Bug 15553 - [SIGNED-OFF] cgisess_ files polluting the /tmp directory\n\nWhen some users want to improve performance, one suggestion is to switch the syspref \"sessionstorage\" to 'tmp',\nwhich store the session info in the /tmp directory instead of the database.\n\nDepending on the frequency of the cleaning process (or lack thereof),\nthis can be heavy pollution into the /tmp directory, making it unusable.\n\"rm cgi*\" would not even work since cgi* extends to over 8000 items...\n\nA simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess.\n\nTesting scenario:\n1) change the syspref SessionStorage to 'tmp'\n2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created\n3) Apply the patch\n4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created\n\nSigned-off-by: Magnus Enger <magnus@libriotech.no>\nWorks as advertised. Session files are created in /tmp/cgisess/ instead\nof directly in /tmp. I usually store sessions in memcached, but a\ncouple of times memcached has died on me, and before I knew it, /tmp\nwas so full of sessions files, I could not easily delete them with\n\"rm /tmp/cgisess*\". Being able to delete /tmp/cgisess/ should be a\nbit easier.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/3815915a3338c4380da7773acc675b07ac82562d"},{"sha":"c4934b2dab427da4304913b3f0f26e0a24606896","author":{"email":"a4ed5d8b9e88a5c4401757374b1604745a5e46b6@rijksmuseum.nl","name":"Marcel de Rooy"},"message":" Bug 15553: [QA Follow-up] Replace hardcoded tmp and add instance to dirname\n\nIf you use multiple instances on one server, you could have the situation\nthat instance A creates the cgisess subfolder and instance B could have a\npermission problem. This patch resolves that by allowing each instance to\nhave its own cgisess subfolder.\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/c4934b2dab427da4304913b3f0f26e0a24606896"},{"sha":"df13a5d3e7727f6a7db67aac618fb85c135b2723","author":{"email":"426f625364c21a69b07917eef7216c63bee01f3a@veron.ch","name":"Marc Véron"},"message":" Bug 15476: Listname not always displayed in shelves.pl\n\nTo reproduce:\n  - In staff client, go to List and click on the name of an\n    existing list.\n  - At the bottom of the screen, you see a title \"Add an item to \"\n    but no list name.\n\nTo test:\n  - Apply patch\n  - Verify that listname appears after \"Add an item to \"\n\nSigned-off-by: Hector Castro <hector.hecaxmmx@gmail.com>\nWorks as advertised. Label/legend for listname displayed Ok\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/df13a5d3e7727f6a7db67aac618fb85c135b2723"},{"sha":"6d9a75014e1f1ef7dc84a3d14643271658eacc2e","author":{"email":"0a829083c0ec9386a016e7524537f0816c24ff22@gmail.com","name":"Chloe"},"message":" Bug 15468 - Search links on callnumbers with parentheses fails on OPAC results page\n\nTo Test:\n1-before plugin search in opac for a call number with either a \"(\" or a \")\" in it\n2-it should come back with no results\n3-use plugin\n4-re-search the call number with \"(\" or \")\"\n5-the search should come back with results\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\nSigned-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>\nIt seems this only works with OPAC XSLT for results page turned off\nand OPACItemsResultsDisplay turned on. - Then the callnumbers\nin the result list will be linked for searching.\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/6d9a75014e1f1ef7dc84a3d14643271658eacc2e"},{"sha":"1c5f75fde534db8a2b1329d5dfb83d34d9d29982","author":{"email":"d35ee1b563a3999321098a410d812da7c17df04d@gmail.com","name":"Winona Salesky"},"message":" Bug 15444 - MARC21: Repeated 508 not correctly formatted (missing separator)\n\nThis patch adds a separator for multiple 508 fields to the XSLT display in the staff and OPAC detail view.\nSeparator is wrapped in span with class=‘separator’ for easy manipulation via css.\n\nTo test:\n* Search the OPAC\n* Click the title with multiple 508 fields\n* Make sure the fields display properly\n* Repeat for a few more titles\n* Repeat in the Staff Client\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/1c5f75fde534db8a2b1329d5dfb83d34d9d29982"},{"sha":"ee64d19fab61bc2e4f4e78e698802cf3d4bc3d1c","author":{"email":"426f625364c21a69b07917eef7216c63bee01f3a@veron.ch","name":"Marc Véron"},"message":" Bug 15355: Translatability: Fix issues on check in page\n\nThis patch fixes translatability issues on checkin page, due to sentence splitting by html tags at\nseveral places and ambiguous word 'to'.\n\nAdditionally, fix message related to syspref AllowReturnToBranch set to 'only the library where the\nitem is checked out from' (it wrongly displays the home library instead of the holding library),\nand streamline the display of similar messages to look more consistent.\n\nTo test:\n- Apply patch\n- Go to Home > Circulation > Check in\n- Do check ins with different expected results / messages\n- Verify that the messages are meaningful and display nicely\n- Play with items checked out / checked in at different branches (home branch, holding branch, other\n  branch) and different settings for syspref 'AllowREturnToBranch' and verify that the messages display\n  properly (with correct home rsp. holding branch)\n- Carfully review code changes.\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/ee64d19fab61bc2e4f4e78e698802cf3d4bc3d1c"},{"sha":"8b23b13d38c51cc10f9fcdf78f4afe1028119ad4","author":{"email":"da26059dcf7dd5383b97c4d6fa42fb7d5e02862f@hotmail.com","name":"Natasha"},"message":" Bug 15195 - patron details should open in tab\n\nDeleted View record link and made patron details open in a new tab.\n\nTo Test: Edit personal details for a user on opac and submit update\nrequest.\n\nIn staff client go to patrons requesting modifications.\nConfirm view record link is gone and patron details opens in new tab.\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nI don't think it's a good idea to open a new tab (let the user decide)\nbut the behavior already existed before this patch.\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/8b23b13d38c51cc10f9fcdf78f4afe1028119ad4"},{"sha":"2f85d659a1ce76cc48bf53e07ce908b47fdce3c6","author":{"email":"8bf4de7d20b37969080dc26f52a336a016210a46@web.de","name":"Katrin Fischer"},"message":" Bug 15100: MARC21 - make display of \"Dates associated with a name\" optional\n\nWith the changes for RDA now more subfields for the fields\n100, 110, 111, and 700, 710, 711 are displayed.\nOne of them is $d - Dates associated with a name\n\nThis patch adds separate treatment of the $d subfield and\nwraps it in a span with the class \"authordates\".\nThis makes it possible to hide the information with CSS.\n\nTo test:\n- Make sure you have several records with $d catalogued\n- Check the display in result list and detail page\n  with and without the page.\n- Check, if there is a difference in display\n- Check if the dates are correctly wrapped in a span\n- Try to hide the information, using the following\n  entry in your *UserCSS preferences:\n  .authordates { display: none; }\n\nSigned-off-by: Hector Castro <hector.hecaxmmx@gmail.com>\nWorks as advertised\n\nSigned-off-by: Jesse Weaver <jweaver@bywatersolutions.com>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/2f85d659a1ce76cc48bf53e07ce908b47fdce3c6"},{"sha":"e38564d2132e1e102cec23d239fb81cd987b3de8","author":{"email":"0ce2cf104f5dd7fe8a64cb2aeb276ba3411cd58c@gmail.com","name":"Briana"},"message":" Bug 14810 Improve messages in patron anonymizing tool\n\nTo test:\nCreate circulation records\nGo to 'http://localhost:8081/cgi-bin/koha/tools/cleanborrowers.pl'\nAnonymize patron checkout history\nMessage should read 'All checkouts older than [date] have been\n anonymized\nWhen patch is not applied, message reads 'All patrons with checkouts\n older than [date]  have been anonymized\"\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/e38564d2132e1e102cec23d239fb81cd987b3de8"},{"sha":"fe7940257537042ff6ffab9c7b718e5b8a5dc368","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":" Bug 14641: [SIGNED-OFF] Warns in subscription-add.pl\n\nRemoves warn using Jonathan's suggestion!\n\nTo test:\n1) Reproduce warns by clicking New Subscription\n2) Apply patch\n3) Click New Subscription again\n4) Confirm warns are gone\n\nSigned-off-by: Magnus Enger <magnus@libriotech.no>\nPatch removes the warn that come when clicking \"New subscription\"\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>","distinct":false,"url":"https://api.github.com/repos/PTFS-Europe/koha/commits/fe7940257537042ff6ffab9c7b718e5b8a5dc368"}]}