{"action":"created","issue":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/945","repository_url":"https://api.github.com/repos/xonsh/xonsh","labels_url":"https://api.github.com/repos/xonsh/xonsh/issues/945/labels{/name}","comments_url":"https://api.github.com/repos/xonsh/xonsh/issues/945/comments","events_url":"https://api.github.com/repos/xonsh/xonsh/issues/945/events","html_url":"https://github.com/xonsh/xonsh/pull/945","id":155818228,"number":945,"title":"[WIP] Pytest port","user":{"login":"gforsyth","id":3596999,"avatar_url":"https://avatars.githubusercontent.com/u/3596999?v=3","gravatar_id":"","url":"https://api.github.com/users/gforsyth","html_url":"https://github.com/gforsyth","followers_url":"https://api.github.com/users/gforsyth/followers","following_url":"https://api.github.com/users/gforsyth/following{/other_user}","gists_url":"https://api.github.com/users/gforsyth/gists{/gist_id}","starred_url":"https://api.github.com/users/gforsyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforsyth/subscriptions","organizations_url":"https://api.github.com/users/gforsyth/orgs","repos_url":"https://api.github.com/users/gforsyth/repos","events_url":"https://api.github.com/users/gforsyth/events{/privacy}","received_events_url":"https://api.github.com/users/gforsyth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xonsh/xonsh/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xonsh/xonsh/milestones/4","html_url":"https://github.com/xonsh/xonsh/milestones/v0.4.0","labels_url":"https://api.github.com/repos/xonsh/xonsh/milestones/4/labels","id":1779851,"number":4,"title":"v0.4.0","description":"","creator":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"open_issues":185,"closed_issues":168,"state":"open","created_at":"2016-05-20T22:54:44Z","updated_at":"2016-06-22T21:49:29Z","due_on":"2016-06-30T04:00:00Z","closed_at":null},"comments":26,"created_at":"2016-05-19T19:40:40Z","updated_at":"2016-06-22T23:39:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xonsh/xonsh/pulls/945","html_url":"https://github.com/xonsh/xonsh/pull/945","diff_url":"https://github.com/xonsh/xonsh/pull/945.diff","patch_url":"https://github.com/xonsh/xonsh/pull/945.patch"},"body":"This shouldn't go in yet and others are welcome to work on it if they want.  \r\nRegarding several issues:\r\n#942 \r\n#940 \r\n#918 \r\nand others, this is a first stab at changing the testing framework from nose to pytest.  \r\n\r\nIt's actually not too bad.  The following tests work without any changes needed:\r\n```\r\ntest_aliases\r\ntest_builtins\r\ntest_dirstack\r\ntest_foreign_shells\r\ntest_inspectors\r\ntest_lazy_json\r\ntest_lexer\r\ntest_ptk_history\r\ntest_ptk_multiline\r\ntest_replay\r\ntest_wizard\r\n```\r\n\r\nA few need only minimal changes (some already applied in #944)\r\n\r\n```\r\nenviron\r\n change ~from test.tools import~ to ~from tools import~\r\nexecer\r\n change ~setup~ to ~setup_module~\r\nparser\r\n change ~setup~ to ~setup_module~\r\nhistory\r\n change ~from test.tools import~ to ~from tools import~\r\nreplay\r\n works but weird error about command not found: the\r\n```\r\n\r\nThe only major problems are the following (which I have not addressed):\r\n\r\n1. `test_imphooks` -- fails, i think due to differences in mock/patch support\r\n2. `test_main` -- again, patch problem (I think)\r\n3. `test_tools` -- Ok, this works, but on my machine now runs 131680 tests, which is crazy.\r\n\r\nAnyway, I'm putting this here so others don't duplicate the effort (which again, wasn't that much).  I'm surprised that there isn't TOO much to do.  That said, if we want to support both nose and pytest, things might get hairy."},"comment":{"url":"https://api.github.com/repos/xonsh/xonsh/issues/comments/227909402","html_url":"https://github.com/xonsh/xonsh/pull/945#issuecomment-227909402","issue_url":"https://api.github.com/repos/xonsh/xonsh/issues/945","id":227909402,"user":{"login":"laerus","id":6930157,"avatar_url":"https://avatars.githubusercontent.com/u/6930157?v=3","gravatar_id":"","url":"https://api.github.com/users/laerus","html_url":"https://github.com/laerus","followers_url":"https://api.github.com/users/laerus/followers","following_url":"https://api.github.com/users/laerus/following{/other_user}","gists_url":"https://api.github.com/users/laerus/gists{/gist_id}","starred_url":"https://api.github.com/users/laerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laerus/subscriptions","organizations_url":"https://api.github.com/users/laerus/orgs","repos_url":"https://api.github.com/users/laerus/repos","events_url":"https://api.github.com/users/laerus/events{/privacy}","received_events_url":"https://api.github.com/users/laerus/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T23:39:54Z","updated_at":"2016-06-22T23:39:54Z","body":"i'm getting an error in `test_parser.py` in python3.4 :\r\n\r\n```\r\nE           x(*[(\"a\", 2)], *[(\"v\", 3)], **{\"c\": 5})\r\nE                          ^\r\nE       SyntaxError: invalid syntax\r\n```"}}
{"actor":{"display_login":"laerus"}}