{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/89142822","pull_request_review_id":9691421,"id":89142822,"diff_hunk":"@@ -116,6 +122,15 @@ class ClusterFormationTasks {\n         project.dependencies.add(configuration.name, \"org.elasticsearch.distribution.${distro}:elasticsearch:${elasticsearchVersion}@${packaging}\")\n     }\n \n+    /** Adds a dependency on a different version of the given plugin, which will be retrieved using gradle's dependency resolution */\n+    static void configureBwcPluginDependency(Project project, Project pluginProject, Configuration configuration, String elasticsearchVersion) {\n+        if (pluginProject.plugins.hasPlugin(PluginBuildPlugin) == false) {\n+            throw new GradleException(\"Cannot use project ${pluginProject.path} which is not an esplugin\")","path":"buildSrc/src/main/groovy/org/elasticsearch/gradle/test/ClusterFormationTasks.groovy","position":null,"original_position":41,"commit_id":"b46b77d9f3ecd59ac405dbc211e8dc783fe3a0ea","original_commit_id":"75da291490048a25345d541092334152e96c7369","user":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"body":"Thanks for the message, I incorporated it","created_at":"2016-11-22T15:42:00Z","updated_at":"2016-11-22T15:42:00Z","html_url":"https://github.com/elastic/elasticsearch/pull/21718#discussion_r89142822","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/89142822"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/21718#discussion_r89142822"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718","id":94692006,"html_url":"https://github.com/elastic/elasticsearch/pull/21718","diff_url":"https://github.com/elastic/elasticsearch/pull/21718.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/21718.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21718","number":21718,"state":"open","locked":false,"title":"Build: add the ability to support plugins in BWC tests","user":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"body":"This commit adds the ability to support running with plugins in tests that make use of\r\nbackwards compatibility nodes. This can be used to test rolling upgrades with plugins\r\nto ensure they do not cause issues during a rolling upgrade of elasticsearch.","created_at":"2016-11-21T20:38:18Z","updated_at":"2016-11-22T15:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6944bf1af42ca8a6ecf4be881a3ef93e7afc7757","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/21718/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/b46b77d9f3ecd59ac405dbc211e8dc783fe3a0ea","head":{"label":"jaymode:bwc_plugins_changes","ref":"bwc_plugins_changes","sha":"b46b77d9f3ecd59ac405dbc211e8dc783fe3a0ea","user":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"repo":{"id":16960752,"name":"elasticsearch","full_name":"jaymode/elasticsearch","owner":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaymode/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jaymode/elasticsearch","forks_url":"https://api.github.com/repos/jaymode/elasticsearch/forks","keys_url":"https://api.github.com/repos/jaymode/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaymode/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaymode/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jaymode/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jaymode/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jaymode/elasticsearch/events","assignees_url":"https://api.github.com/repos/jaymode/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jaymode/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jaymode/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jaymode/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaymode/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaymode/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaymode/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaymode/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jaymode/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jaymode/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jaymode/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jaymode/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jaymode/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jaymode/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaymode/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaymode/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaymode/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaymode/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jaymode/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaymode/elasticsearch/merges","archive_url":"https://api.github.com/repos/jaymode/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaymode/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jaymode/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jaymode/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jaymode/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jaymode/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaymode/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jaymode/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jaymode/elasticsearch/deployments","created_at":"2014-02-18T19:25:41Z","updated_at":"2014-11-18T16:25:52Z","pushed_at":"2016-11-22T15:40:51Z","git_url":"git://github.com/jaymode/elasticsearch.git","ssh_url":"git@github.com:jaymode/elasticsearch.git","clone_url":"https://github.com/jaymode/elasticsearch.git","svn_url":"https://github.com/jaymode/elasticsearch","homepage":"http://elasticsearch.org","size":228820,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"284dedfb5f858b3b48b31271832d331035182496","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-11-22T15:15:51Z","pushed_at":"2016-11-22T15:40:52Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":374946,"stargazers_count":19444,"watchers_count":19444,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6666,"mirror_url":null,"open_issues_count":1199,"forks":6666,"open_issues":1199,"watchers":19444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/21718"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/21718"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/21718/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/21718/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/b46b77d9f3ecd59ac405dbc211e8dc783fe3a0ea"}}}}
{"actor":{"display_login":"jaymode"}}