{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments/69117717","id":69117717,"diff_hunk":"@@ -48,43 +48,108 @@ static const size_t minElemInNode = 16;\n \n namespace fivox\n {\n+\n+enum EventOffset\n+{\n+    POSX = 0,\n+    POSY,\n+    POSZ,\n+    RADIUS,\n+    VALUE,\n+    NUM_OFFSETS\n+};\n+\n class EventSource::Impl\n {\n public:\n-    Impl( const URIHandler& params )\n+    explicit Impl( const URIHandler& params )\n         : dt( params.getDt( ))\n         , currentTime( -1.f )\n         , cutOffDistance( params.getCutoffDistance( ))\n+        , alignBoundary( 32 )\n+        , numEvents( 0 )\n+        , events( 0 )\n     {}\n \n+    ~Impl()\n+    {\n+        free( events );","path":"fivox/eventSource.cpp","position":30,"original_position":30,"commit_id":"4b4f5cc0ba1cc51324d80609b9ca22aab1a16eb6","original_commit_id":"4b4f5cc0ba1cc51324d80609b9ca22aab1a16eb6","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"use a unique_ptr?","created_at":"2016-06-30T11:46:23Z","updated_at":"2016-06-30T11:46:23Z","html_url":"https://github.com/BlueBrain/Fivox/pull/40#discussion_r69117717","pull_request_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments/69117717"},"html":{"href":"https://github.com/BlueBrain/Fivox/pull/40#discussion_r69117717"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40","id":74937611,"html_url":"https://github.com/BlueBrain/Fivox/pull/40","diff_url":"https://github.com/BlueBrain/Fivox/pull/40.diff","patch_url":"https://github.com/BlueBrain/Fivox/pull/40.patch","issue_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/40","number":40,"state":"open","locked":false,"title":"Improve performance","user":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"body":"Modify memory layout in EventSource so computations can be\r\nvectorized to gain performance.\r\nStore all the events in a single array, memory aligned","created_at":"2016-06-23T11:21:36Z","updated_at":"2016-06-30T11:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53ffbd8979d474aed3a669b6aeb3a30e8ee4a3e9","assignee":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"assignees":[{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/40/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Fivox/statuses/4b4f5cc0ba1cc51324d80609b9ca22aab1a16eb6","head":{"label":"jafyvilla:perf_changes","ref":"perf_changes","sha":"4b4f5cc0ba1cc51324d80609b9ca22aab1a16eb6","user":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"repo":{"id":50598283,"name":"Fivox","full_name":"jafyvilla/Fivox","owner":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jafyvilla/Fivox","description":"ITK library to sample events into regular volumes","fork":true,"url":"https://api.github.com/repos/jafyvilla/Fivox","forks_url":"https://api.github.com/repos/jafyvilla/Fivox/forks","keys_url":"https://api.github.com/repos/jafyvilla/Fivox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jafyvilla/Fivox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jafyvilla/Fivox/teams","hooks_url":"https://api.github.com/repos/jafyvilla/Fivox/hooks","issue_events_url":"https://api.github.com/repos/jafyvilla/Fivox/issues/events{/number}","events_url":"https://api.github.com/repos/jafyvilla/Fivox/events","assignees_url":"https://api.github.com/repos/jafyvilla/Fivox/assignees{/user}","branches_url":"https://api.github.com/repos/jafyvilla/Fivox/branches{/branch}","tags_url":"https://api.github.com/repos/jafyvilla/Fivox/tags","blobs_url":"https://api.github.com/repos/jafyvilla/Fivox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jafyvilla/Fivox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jafyvilla/Fivox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jafyvilla/Fivox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jafyvilla/Fivox/statuses/{sha}","languages_url":"https://api.github.com/repos/jafyvilla/Fivox/languages","stargazers_url":"https://api.github.com/repos/jafyvilla/Fivox/stargazers","contributors_url":"https://api.github.com/repos/jafyvilla/Fivox/contributors","subscribers_url":"https://api.github.com/repos/jafyvilla/Fivox/subscribers","subscription_url":"https://api.github.com/repos/jafyvilla/Fivox/subscription","commits_url":"https://api.github.com/repos/jafyvilla/Fivox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jafyvilla/Fivox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jafyvilla/Fivox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jafyvilla/Fivox/issues/comments{/number}","contents_url":"https://api.github.com/repos/jafyvilla/Fivox/contents/{+path}","compare_url":"https://api.github.com/repos/jafyvilla/Fivox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jafyvilla/Fivox/merges","archive_url":"https://api.github.com/repos/jafyvilla/Fivox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jafyvilla/Fivox/downloads","issues_url":"https://api.github.com/repos/jafyvilla/Fivox/issues{/number}","pulls_url":"https://api.github.com/repos/jafyvilla/Fivox/pulls{/number}","milestones_url":"https://api.github.com/repos/jafyvilla/Fivox/milestones{/number}","notifications_url":"https://api.github.com/repos/jafyvilla/Fivox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jafyvilla/Fivox/labels{/name}","releases_url":"https://api.github.com/repos/jafyvilla/Fivox/releases{/id}","deployments_url":"https://api.github.com/repos/jafyvilla/Fivox/deployments","created_at":"2016-01-28T16:55:40Z","updated_at":"2016-01-28T16:55:41Z","pushed_at":"2016-06-30T08:27:59Z","git_url":"git://github.com/jafyvilla/Fivox.git","ssh_url":"git@github.com:jafyvilla/Fivox.git","clone_url":"https://github.com/jafyvilla/Fivox.git","svn_url":"https://github.com/jafyvilla/Fivox","homepage":null,"size":720,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:perf","ref":"perf","sha":"55a5d312cd42fc247074b330d39194254d84dafc","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":50582920,"name":"Fivox","full_name":"BlueBrain/Fivox","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Fivox","description":"ITK library to sample events into regular volumes","fork":false,"url":"https://api.github.com/repos/BlueBrain/Fivox","forks_url":"https://api.github.com/repos/BlueBrain/Fivox/forks","keys_url":"https://api.github.com/repos/BlueBrain/Fivox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Fivox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Fivox/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Fivox/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Fivox/events","assignees_url":"https://api.github.com/repos/BlueBrain/Fivox/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Fivox/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Fivox/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Fivox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Fivox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Fivox/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Fivox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Fivox/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Fivox/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Fivox/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Fivox/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Fivox/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Fivox/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Fivox/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Fivox/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Fivox/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Fivox/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Fivox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Fivox/merges","archive_url":"https://api.github.com/repos/BlueBrain/Fivox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Fivox/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Fivox/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Fivox/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Fivox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Fivox/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Fivox/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Fivox/deployments","created_at":"2016-01-28T12:56:11Z","updated_at":"2016-01-28T12:57:47Z","pushed_at":"2016-06-30T08:27:59Z","git_url":"git://github.com/BlueBrain/Fivox.git","ssh_url":"git@github.com:BlueBrain/Fivox.git","clone_url":"https://github.com/BlueBrain/Fivox.git","svn_url":"https://github.com/BlueBrain/Fivox","homepage":null,"size":727,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40"},"html":{"href":"https://github.com/BlueBrain/Fivox/pull/40"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Fivox/issues/40"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Fivox/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Fivox/statuses/4b4f5cc0ba1cc51324d80609b9ca22aab1a16eb6"}}}}
{"actor":{"display_login":"eile"}}