{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/78110883","id":78110883,"diff_hunk":"@@ -811,6 +851,60 @@ Object.assign( BufferGeometry.prototype, EventDispatcher.prototype, {\n \n \t},\n \n+\t/**\n+\t * Checks for duplicate vertices with hashmap.\n+\t * Faces with duplicate vertices are rewired to point to the first instance.\n+\t * Unused vertices are not removed.\n+\t * @param  {THREE.BufferGeometry} geom Geometry to merge\n+\t */\n+\tmergeVertices: function( geom ) {","path":"src/core/BufferGeometry.js","position":61,"original_position":61,"commit_id":"8a589531c8cd30eac431d76004331707fbca31b2","original_commit_id":"8a589531c8cd30eac431d76004331707fbca31b2","user":{"login":"WestLangley","id":1000017,"avatar_url":"https://avatars.githubusercontent.com/u/1000017?v=3","gravatar_id":"","url":"https://api.github.com/users/WestLangley","html_url":"https://github.com/WestLangley","followers_url":"https://api.github.com/users/WestLangley/followers","following_url":"https://api.github.com/users/WestLangley/following{/other_user}","gists_url":"https://api.github.com/users/WestLangley/gists{/gist_id}","starred_url":"https://api.github.com/users/WestLangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WestLangley/subscriptions","organizations_url":"https://api.github.com/users/WestLangley/orgs","repos_url":"https://api.github.com/users/WestLangley/repos","events_url":"https://api.github.com/users/WestLangley/events{/privacy}","received_events_url":"https://api.github.com/users/WestLangley/received_events","type":"User","site_admin":false},"body":"`this` is not referenced in this method.\r\n\r\nCan you please explain in more detail what this method does -- and how it is intended to be used?","created_at":"2016-09-09T00:04:54Z","updated_at":"2016-09-09T00:04:54Z","html_url":"https://github.com/mrdoob/three.js/pull/9529#discussion_r78110883","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9529","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/78110883"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9529#discussion_r78110883"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9529"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/9529","id":81554843,"html_url":"https://github.com/mrdoob/three.js/pull/9529","diff_url":"https://github.com/mrdoob/three.js/pull/9529.diff","patch_url":"https://github.com/mrdoob/three.js/pull/9529.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/9529","number":9529,"state":"open","locked":false,"title":"Adding buffer geometry utilities for merging.","user":{"login":"kylegmaxwell","id":11025081,"avatar_url":"https://avatars.githubusercontent.com/u/11025081?v=3","gravatar_id":"","url":"https://api.github.com/users/kylegmaxwell","html_url":"https://github.com/kylegmaxwell","followers_url":"https://api.github.com/users/kylegmaxwell/followers","following_url":"https://api.github.com/users/kylegmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/kylegmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/kylegmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylegmaxwell/subscriptions","organizations_url":"https://api.github.com/users/kylegmaxwell/orgs","repos_url":"https://api.github.com/users/kylegmaxwell/repos","events_url":"https://api.github.com/users/kylegmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/kylegmaxwell/received_events","type":"User","site_admin":false},"body":"These are some buffer geometry utilities that I wrote for merging geometry and related operations. I am submitting this after discussion on {mrdoob}/three.js#8162 with @WestLangley \r\nhttps://github.com/mrdoob/three.js/pull/8162#issuecomment-238746823\r\nThe main idea is that to merge buffer geometry requires creating a new geometry, hence the functions are static on the BufferGeometry class. I also created a jsfiddle as an example.\r\nhttps://jsfiddle.net/kylu/c1rt9dnb/","created_at":"2016-08-16T22:19:56Z","updated_at":"2016-09-09T00:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d53b005152f5da6567596258fcbdf111bb7d5c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9529/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/9529/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/9529/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/8a589531c8cd30eac431d76004331707fbca31b2","head":{"label":"fluxio:buffer-geom-merge","ref":"buffer-geom-merge","sha":"8a589531c8cd30eac431d76004331707fbca31b2","user":{"login":"fluxio","id":1861148,"avatar_url":"https://avatars.githubusercontent.com/u/1861148?v=3","gravatar_id":"","url":"https://api.github.com/users/fluxio","html_url":"https://github.com/fluxio","followers_url":"https://api.github.com/users/fluxio/followers","following_url":"https://api.github.com/users/fluxio/following{/other_user}","gists_url":"https://api.github.com/users/fluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/fluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluxio/subscriptions","organizations_url":"https://api.github.com/users/fluxio/orgs","repos_url":"https://api.github.com/users/fluxio/repos","events_url":"https://api.github.com/users/fluxio/events{/privacy}","received_events_url":"https://api.github.com/users/fluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":24404063,"name":"three.js","full_name":"fluxio/three.js","owner":{"login":"fluxio","id":1861148,"avatar_url":"https://avatars.githubusercontent.com/u/1861148?v=3","gravatar_id":"","url":"https://api.github.com/users/fluxio","html_url":"https://github.com/fluxio","followers_url":"https://api.github.com/users/fluxio/followers","following_url":"https://api.github.com/users/fluxio/following{/other_user}","gists_url":"https://api.github.com/users/fluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/fluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluxio/subscriptions","organizations_url":"https://api.github.com/users/fluxio/orgs","repos_url":"https://api.github.com/users/fluxio/repos","events_url":"https://api.github.com/users/fluxio/events{/privacy}","received_events_url":"https://api.github.com/users/fluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluxio/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/fluxio/three.js","forks_url":"https://api.github.com/repos/fluxio/three.js/forks","keys_url":"https://api.github.com/repos/fluxio/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluxio/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluxio/three.js/teams","hooks_url":"https://api.github.com/repos/fluxio/three.js/hooks","issue_events_url":"https://api.github.com/repos/fluxio/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/fluxio/three.js/events","assignees_url":"https://api.github.com/repos/fluxio/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/fluxio/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/fluxio/three.js/tags","blobs_url":"https://api.github.com/repos/fluxio/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluxio/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluxio/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluxio/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluxio/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/fluxio/three.js/languages","stargazers_url":"https://api.github.com/repos/fluxio/three.js/stargazers","contributors_url":"https://api.github.com/repos/fluxio/three.js/contributors","subscribers_url":"https://api.github.com/repos/fluxio/three.js/subscribers","subscription_url":"https://api.github.com/repos/fluxio/three.js/subscription","commits_url":"https://api.github.com/repos/fluxio/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluxio/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluxio/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluxio/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluxio/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/fluxio/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluxio/three.js/merges","archive_url":"https://api.github.com/repos/fluxio/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluxio/three.js/downloads","issues_url":"https://api.github.com/repos/fluxio/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/fluxio/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/fluxio/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/fluxio/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluxio/three.js/labels{/name}","releases_url":"https://api.github.com/repos/fluxio/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/fluxio/three.js/deployments","created_at":"2014-09-24T06:55:54Z","updated_at":"2016-05-10T00:49:03Z","pushed_at":"2016-09-08T23:05:17Z","git_url":"git://github.com/fluxio/three.js.git","ssh_url":"git@github.com:fluxio/three.js.git","clone_url":"https://github.com/fluxio/three.js.git","svn_url":"https://github.com/fluxio/three.js","homepage":"http://threejs.org/","size":395838,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"c9e7d511f33447681f8789392dfb9236546f0143","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-09-09T00:03:48Z","pushed_at":"2016-09-08T23:05:17Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":622082,"stargazers_count":27347,"watchers_count":27347,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":9336,"mirror_url":null,"open_issues_count":800,"forks":9336,"open_issues":800,"watchers":27347,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9529"},"html":{"href":"https://github.com/mrdoob/three.js/pull/9529"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9529"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/9529/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9529/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/9529/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/8a589531c8cd30eac431d76004331707fbca31b2"}}}}
{"actor":{"display_login":"WestLangley"}}