{"action":"created","issue":{"url":"https://api.github.com/repos/opencog/atomspace/issues/733","repository_url":"https://api.github.com/repos/opencog/atomspace","labels_url":"https://api.github.com/repos/opencog/atomspace/issues/733/labels{/name}","comments_url":"https://api.github.com/repos/opencog/atomspace/issues/733/comments","events_url":"https://api.github.com/repos/opencog/atomspace/issues/733/events","html_url":"https://github.com/opencog/atomspace/pull/733","id":143736995,"number":733,"title":"Separate degenerate-case from deep link tests","user":{"login":"inflector","id":1048706,"avatar_url":"https://avatars.githubusercontent.com/u/1048706?v=3","gravatar_id":"","url":"https://api.github.com/users/inflector","html_url":"https://github.com/inflector","followers_url":"https://api.github.com/users/inflector/followers","following_url":"https://api.github.com/users/inflector/following{/other_user}","gists_url":"https://api.github.com/users/inflector/gists{/gist_id}","starred_url":"https://api.github.com/users/inflector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inflector/subscriptions","organizations_url":"https://api.github.com/users/inflector/orgs","repos_url":"https://api.github.com/users/inflector/repos","events_url":"https://api.github.com/users/inflector/events{/privacy}","received_events_url":"https://api.github.com/users/inflector/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-26T18:11:23Z","updated_at":"2016-03-27T00:36:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencog/atomspace/pulls/733","html_url":"https://github.com/opencog/atomspace/pull/733","diff_url":"https://github.com/opencog/atomspace/pull/733.diff","patch_url":"https://github.com/opencog/atomspace/pull/733.patch"},"body":"The degenerate link case created a depth^2 traversal time for recursive visiting of atoms in the recursive outgoing set. So `AtomSpace::add_link` for depths more than about 20 took long since `add_link` required a traversal checking for atoms to ignore which should not be added to the backing store.\r\n\r\nSo I created a separate test which tests deep links where each link has an outgoing set that contains two atoms: a single node shared by all links, and the prior link. Then I bumped the second test to depth 1000 to test high-depth links."},"comment":{"url":"https://api.github.com/repos/opencog/atomspace/issues/comments/201962384","html_url":"https://github.com/opencog/atomspace/pull/733#issuecomment-201962384","issue_url":"https://api.github.com/repos/opencog/atomspace/issues/733","id":201962384,"user":{"login":"linas","id":94368,"avatar_url":"https://avatars.githubusercontent.com/u/94368?v=3","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"created_at":"2016-03-27T00:36:44Z","updated_at":"2016-03-27T00:36:44Z","body":"Looks OK to me. Merge this if you are ready."}}