{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/comments/89286971","pull_request_review_id":9831572,"id":89286971,"diff_hunk":"@@ -205,12 +205,7 @@ fn administrative_regions(pbf: &mut OsmPbfReader, levels: BTreeSet<u32>) -> Admi\n }\n \n fn make_admin_geofinder(admins: &AdminsVec) -> AdminGeoFinder {\n-    let mut geofinder = AdminGeoFinder::new();\n-\n-    for a in admins {\n-        geofinder.insert(a.clone());\n-    }\n-    geofinder\n+    admins.iter().cloned().collect()\n }","path":"src/bin/osm2mimir.rs","position":11,"original_position":11,"commit_id":"9395079015097cf7d740dc77dfbc54f626576d6f","original_commit_id":"9395079015097cf7d740dc77dfbc54f626576d6f","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"This function become quite useless, no?","created_at":"2016-11-23T10:19:16Z","updated_at":"2016-11-23T10:19:16Z","html_url":"https://github.com/CanalTP/mimirsbrunn/pull/97#discussion_r89286971","pull_request_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/comments/89286971"},"html":{"href":"https://github.com/CanalTP/mimirsbrunn/pull/97#discussion_r89286971"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97","id":94966711,"html_url":"https://github.com/CanalTP/mimirsbrunn/pull/97","diff_url":"https://github.com/CanalTP/mimirsbrunn/pull/97.diff","patch_url":"https://github.com/CanalTP/mimirsbrunn/pull/97.patch","issue_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/97","number":97,"state":"open","locked":false,"title":"AdminGeoFinder implements FromIterator","user":{"login":"datanel","id":187239,"avatar_url":"https://avatars.githubusercontent.com/u/187239?v=3","gravatar_id":"","url":"https://api.github.com/users/datanel","html_url":"https://github.com/datanel","followers_url":"https://api.github.com/users/datanel/followers","following_url":"https://api.github.com/users/datanel/following{/other_user}","gists_url":"https://api.github.com/users/datanel/gists{/gist_id}","starred_url":"https://api.github.com/users/datanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datanel/subscriptions","organizations_url":"https://api.github.com/users/datanel/orgs","repos_url":"https://api.github.com/users/datanel/repos","events_url":"https://api.github.com/users/datanel/events{/privacy}","received_events_url":"https://api.github.com/users/datanel/received_events","type":"User","site_admin":false},"body":"fix https://github.com/CanalTP/mimirsbrunn/issues/96\r\n\r\nthanks to @TeXitoi ","created_at":"2016-11-23T09:20:30Z","updated_at":"2016-11-23T10:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd24b39bc83ba529f3b44c803d52ca447dabf7d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97/commits","review_comments_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97/comments","review_comment_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/97/comments","statuses_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/statuses/9395079015097cf7d740dc77dfbc54f626576d6f","head":{"label":"datanel:geofinder-fromiterator","ref":"geofinder-fromiterator","sha":"9395079015097cf7d740dc77dfbc54f626576d6f","user":{"login":"datanel","id":187239,"avatar_url":"https://avatars.githubusercontent.com/u/187239?v=3","gravatar_id":"","url":"https://api.github.com/users/datanel","html_url":"https://github.com/datanel","followers_url":"https://api.github.com/users/datanel/followers","following_url":"https://api.github.com/users/datanel/following{/other_user}","gists_url":"https://api.github.com/users/datanel/gists{/gist_id}","starred_url":"https://api.github.com/users/datanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datanel/subscriptions","organizations_url":"https://api.github.com/users/datanel/orgs","repos_url":"https://api.github.com/users/datanel/repos","events_url":"https://api.github.com/users/datanel/events{/privacy}","received_events_url":"https://api.github.com/users/datanel/received_events","type":"User","site_admin":false},"repo":{"id":67719448,"name":"mimirsbrunn","full_name":"datanel/mimirsbrunn","owner":{"login":"datanel","id":187239,"avatar_url":"https://avatars.githubusercontent.com/u/187239?v=3","gravatar_id":"","url":"https://api.github.com/users/datanel","html_url":"https://github.com/datanel","followers_url":"https://api.github.com/users/datanel/followers","following_url":"https://api.github.com/users/datanel/following{/other_user}","gists_url":"https://api.github.com/users/datanel/gists{/gist_id}","starred_url":"https://api.github.com/users/datanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datanel/subscriptions","organizations_url":"https://api.github.com/users/datanel/orgs","repos_url":"https://api.github.com/users/datanel/repos","events_url":"https://api.github.com/users/datanel/events{/privacy}","received_events_url":"https://api.github.com/users/datanel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/datanel/mimirsbrunn","description":"mimir data import","fork":true,"url":"https://api.github.com/repos/datanel/mimirsbrunn","forks_url":"https://api.github.com/repos/datanel/mimirsbrunn/forks","keys_url":"https://api.github.com/repos/datanel/mimirsbrunn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datanel/mimirsbrunn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datanel/mimirsbrunn/teams","hooks_url":"https://api.github.com/repos/datanel/mimirsbrunn/hooks","issue_events_url":"https://api.github.com/repos/datanel/mimirsbrunn/issues/events{/number}","events_url":"https://api.github.com/repos/datanel/mimirsbrunn/events","assignees_url":"https://api.github.com/repos/datanel/mimirsbrunn/assignees{/user}","branches_url":"https://api.github.com/repos/datanel/mimirsbrunn/branches{/branch}","tags_url":"https://api.github.com/repos/datanel/mimirsbrunn/tags","blobs_url":"https://api.github.com/repos/datanel/mimirsbrunn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datanel/mimirsbrunn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datanel/mimirsbrunn/git/refs{/sha}","trees_url":"https://api.github.com/repos/datanel/mimirsbrunn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datanel/mimirsbrunn/statuses/{sha}","languages_url":"https://api.github.com/repos/datanel/mimirsbrunn/languages","stargazers_url":"https://api.github.com/repos/datanel/mimirsbrunn/stargazers","contributors_url":"https://api.github.com/repos/datanel/mimirsbrunn/contributors","subscribers_url":"https://api.github.com/repos/datanel/mimirsbrunn/subscribers","subscription_url":"https://api.github.com/repos/datanel/mimirsbrunn/subscription","commits_url":"https://api.github.com/repos/datanel/mimirsbrunn/commits{/sha}","git_commits_url":"https://api.github.com/repos/datanel/mimirsbrunn/git/commits{/sha}","comments_url":"https://api.github.com/repos/datanel/mimirsbrunn/comments{/number}","issue_comment_url":"https://api.github.com/repos/datanel/mimirsbrunn/issues/comments{/number}","contents_url":"https://api.github.com/repos/datanel/mimirsbrunn/contents/{+path}","compare_url":"https://api.github.com/repos/datanel/mimirsbrunn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datanel/mimirsbrunn/merges","archive_url":"https://api.github.com/repos/datanel/mimirsbrunn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datanel/mimirsbrunn/downloads","issues_url":"https://api.github.com/repos/datanel/mimirsbrunn/issues{/number}","pulls_url":"https://api.github.com/repos/datanel/mimirsbrunn/pulls{/number}","milestones_url":"https://api.github.com/repos/datanel/mimirsbrunn/milestones{/number}","notifications_url":"https://api.github.com/repos/datanel/mimirsbrunn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datanel/mimirsbrunn/labels{/name}","releases_url":"https://api.github.com/repos/datanel/mimirsbrunn/releases{/id}","deployments_url":"https://api.github.com/repos/datanel/mimirsbrunn/deployments","created_at":"2016-09-08T16:12:45Z","updated_at":"2016-09-08T16:12:47Z","pushed_at":"2016-11-23T09:21:09Z","git_url":"git://github.com/datanel/mimirsbrunn.git","ssh_url":"git@github.com:datanel/mimirsbrunn.git","clone_url":"https://github.com/datanel/mimirsbrunn.git","svn_url":"https://github.com/datanel/mimirsbrunn","homepage":null,"size":570,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanalTP:master","ref":"master","sha":"2d3e0ea343c28de47828c5800b49f6eba9dd8ab9","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":55155075,"name":"mimirsbrunn","full_name":"CanalTP/mimirsbrunn","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/mimirsbrunn","description":"mimir data import","fork":false,"url":"https://api.github.com/repos/CanalTP/mimirsbrunn","forks_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/forks","keys_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/teams","hooks_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/events","assignees_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/tags","blobs_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/languages","stargazers_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/subscription","commits_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/merges","archive_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/downloads","issues_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/mimirsbrunn/deployments","created_at":"2016-03-31T14:02:09Z","updated_at":"2016-11-12T22:38:35Z","pushed_at":"2016-11-23T09:21:09Z","git_url":"git://github.com/CanalTP/mimirsbrunn.git","ssh_url":"git@github.com:CanalTP/mimirsbrunn.git","clone_url":"https://github.com/CanalTP/mimirsbrunn.git","svn_url":"https://github.com/CanalTP/mimirsbrunn","homepage":null,"size":579,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97"},"html":{"href":"https://github.com/CanalTP/mimirsbrunn/pull/97"},"issue":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/97"},"comments":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/mimirsbrunn/statuses/9395079015097cf7d740dc77dfbc54f626576d6f"}}}}
{"actor":{"display_login":"TeXitoi"}}