{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/62504273","id":62504273,"diff_hunk":"@@ -586,6 +586,20 @@ func (e *UniversalExecutor) createCheck(check *structs.ServiceCheck, checkID str\n \t\t}, nil\n \n \t}\n+\n+\tif check.Type == structs.ServiceCheckScript && e.ctx.Driver == \"raw_exec\" {","path":"client/driver/executor/executor.go","position":5,"original_position":5,"commit_id":"f6460ebdd427d9865f099c95b9c395647bd5370c","original_commit_id":"f6460ebdd427d9865f099c95b9c395647bd5370c","user":{"login":"diptanu","id":21833,"avatar_url":"https://avatars.githubusercontent.com/u/21833?v=3","gravatar_id":"","url":"https://api.github.com/users/diptanu","html_url":"https://github.com/diptanu","followers_url":"https://api.github.com/users/diptanu/followers","following_url":"https://api.github.com/users/diptanu/following{/other_user}","gists_url":"https://api.github.com/users/diptanu/gists{/gist_id}","starred_url":"https://api.github.com/users/diptanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diptanu/subscriptions","organizations_url":"https://api.github.com/users/diptanu/orgs","repos_url":"https://api.github.com/users/diptanu/repos","events_url":"https://api.github.com/users/diptanu/events{/privacy}","received_events_url":"https://api.github.com/users/diptanu/received_events","type":"User","site_admin":false},"body":"Ah, this was an overlook. Can you just merge this branch with the previous one please?\r\n\r\n`if check.Type == structs.ServiceCheckScript && (e.ctx.Driver == \"raw_exec\" || e.ctx.Driver == \"exec\" || e.ctx.Driver == \"java\")`","created_at":"2016-05-09T14:13:34Z","updated_at":"2016-05-09T14:13:34Z","html_url":"https://github.com/hashicorp/nomad/pull/1159#discussion_r62504273","pull_request_url":"https://api.github.com/repos/hashicorp/nomad/pulls/1159","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments/62504273"},"html":{"href":"https://github.com/hashicorp/nomad/pull/1159#discussion_r62504273"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/1159"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/1159","id":69326405,"html_url":"https://github.com/hashicorp/nomad/pull/1159","diff_url":"https://github.com/hashicorp/nomad/pull/1159.diff","patch_url":"https://github.com/hashicorp/nomad/pull/1159.patch","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/1159","number":1159,"state":"open","locked":false,"title":"Enable consul script checks for raw_exec driver","user":{"login":"capone212","id":3605134,"avatar_url":"https://avatars.githubusercontent.com/u/3605134?v=3","gravatar_id":"","url":"https://api.github.com/users/capone212","html_url":"https://github.com/capone212","followers_url":"https://api.github.com/users/capone212/followers","following_url":"https://api.github.com/users/capone212/following{/other_user}","gists_url":"https://api.github.com/users/capone212/gists{/gist_id}","starred_url":"https://api.github.com/users/capone212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capone212/subscriptions","organizations_url":"https://api.github.com/users/capone212/orgs","repos_url":"https://api.github.com/users/capone212/repos","events_url":"https://api.github.com/users/capone212/events{/privacy}","received_events_url":"https://api.github.com/users/capone212/received_events","type":"User","site_admin":false},"body":"Hi, I use nomad on windows platform. raw_exec is the only available driver there and it is fine to me. This request enables consul script checks that does not work currently with raw_exec","created_at":"2016-05-09T10:44:14Z","updated_at":"2016-05-09T14:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6eb72576325c9e222f28378f368cc0cabc01469","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/nomad/pulls/1159/commits","review_comments_url":"https://api.github.com/repos/hashicorp/nomad/pulls/1159/comments","review_comment_url":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/1159/comments","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/f6460ebdd427d9865f099c95b9c395647bd5370c","head":{"label":"capone212:master","ref":"master","sha":"f6460ebdd427d9865f099c95b9c395647bd5370c","user":{"login":"capone212","id":3605134,"avatar_url":"https://avatars.githubusercontent.com/u/3605134?v=3","gravatar_id":"","url":"https://api.github.com/users/capone212","html_url":"https://github.com/capone212","followers_url":"https://api.github.com/users/capone212/followers","following_url":"https://api.github.com/users/capone212/following{/other_user}","gists_url":"https://api.github.com/users/capone212/gists{/gist_id}","starred_url":"https://api.github.com/users/capone212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capone212/subscriptions","organizations_url":"https://api.github.com/users/capone212/orgs","repos_url":"https://api.github.com/users/capone212/repos","events_url":"https://api.github.com/users/capone212/events{/privacy}","received_events_url":"https://api.github.com/users/capone212/received_events","type":"User","site_admin":false},"repo":{"id":58368674,"name":"nomad","full_name":"capone212/nomad","owner":{"login":"capone212","id":3605134,"avatar_url":"https://avatars.githubusercontent.com/u/3605134?v=3","gravatar_id":"","url":"https://api.github.com/users/capone212","html_url":"https://github.com/capone212","followers_url":"https://api.github.com/users/capone212/followers","following_url":"https://api.github.com/users/capone212/following{/other_user}","gists_url":"https://api.github.com/users/capone212/gists{/gist_id}","starred_url":"https://api.github.com/users/capone212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capone212/subscriptions","organizations_url":"https://api.github.com/users/capone212/orgs","repos_url":"https://api.github.com/users/capone212/repos","events_url":"https://api.github.com/users/capone212/events{/privacy}","received_events_url":"https://api.github.com/users/capone212/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/capone212/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":true,"url":"https://api.github.com/repos/capone212/nomad","forks_url":"https://api.github.com/repos/capone212/nomad/forks","keys_url":"https://api.github.com/repos/capone212/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capone212/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capone212/nomad/teams","hooks_url":"https://api.github.com/repos/capone212/nomad/hooks","issue_events_url":"https://api.github.com/repos/capone212/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/capone212/nomad/events","assignees_url":"https://api.github.com/repos/capone212/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/capone212/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/capone212/nomad/tags","blobs_url":"https://api.github.com/repos/capone212/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capone212/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capone212/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/capone212/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capone212/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/capone212/nomad/languages","stargazers_url":"https://api.github.com/repos/capone212/nomad/stargazers","contributors_url":"https://api.github.com/repos/capone212/nomad/contributors","subscribers_url":"https://api.github.com/repos/capone212/nomad/subscribers","subscription_url":"https://api.github.com/repos/capone212/nomad/subscription","commits_url":"https://api.github.com/repos/capone212/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/capone212/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/capone212/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/capone212/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/capone212/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/capone212/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capone212/nomad/merges","archive_url":"https://api.github.com/repos/capone212/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capone212/nomad/downloads","issues_url":"https://api.github.com/repos/capone212/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/capone212/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/capone212/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/capone212/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capone212/nomad/labels{/name}","releases_url":"https://api.github.com/repos/capone212/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/capone212/nomad/deployments","created_at":"2016-05-09T10:31:25Z","updated_at":"2016-05-09T10:31:27Z","pushed_at":"2016-05-09T10:38:59Z","git_url":"git://github.com/capone212/nomad.git","ssh_url":"git@github.com:capone212/nomad.git","clone_url":"https://github.com/capone212/nomad.git","svn_url":"https://github.com/capone212/nomad","homepage":"https://www.nomadproject.io/","size":22379,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"6a0d3ed8c57b0ebc129c73ff7a5af09e57282388","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":36653430,"name":"nomad","full_name":"hashicorp/nomad","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/nomad","description":"A Distributed, Highly Available, Datacenter-Aware Scheduler","fork":false,"url":"https://api.github.com/repos/hashicorp/nomad","forks_url":"https://api.github.com/repos/hashicorp/nomad/forks","keys_url":"https://api.github.com/repos/hashicorp/nomad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/nomad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/nomad/teams","hooks_url":"https://api.github.com/repos/hashicorp/nomad/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/nomad/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/nomad/events","assignees_url":"https://api.github.com/repos/hashicorp/nomad/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/nomad/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/nomad/tags","blobs_url":"https://api.github.com/repos/hashicorp/nomad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/nomad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/nomad/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/nomad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/nomad/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/nomad/languages","stargazers_url":"https://api.github.com/repos/hashicorp/nomad/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/nomad/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/nomad/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/nomad/subscription","commits_url":"https://api.github.com/repos/hashicorp/nomad/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/nomad/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/nomad/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/nomad/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/nomad/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/nomad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/nomad/merges","archive_url":"https://api.github.com/repos/hashicorp/nomad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/nomad/downloads","issues_url":"https://api.github.com/repos/hashicorp/nomad/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/nomad/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/nomad/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/nomad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/nomad/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/nomad/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/nomad/deployments","created_at":"2015-06-01T10:21:00Z","updated_at":"2016-05-09T02:12:14Z","pushed_at":"2016-05-09T13:57:44Z","git_url":"git://github.com/hashicorp/nomad.git","ssh_url":"git@github.com:hashicorp/nomad.git","clone_url":"https://github.com/hashicorp/nomad.git","svn_url":"https://github.com/hashicorp/nomad","homepage":"https://www.nomadproject.io/","size":24526,"stargazers_count":1550,"watchers_count":1550,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":107,"forks":212,"open_issues":107,"watchers":1550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/1159"},"html":{"href":"https://github.com/hashicorp/nomad/pull/1159"},"issue":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/1159"},"comments":{"href":"https://api.github.com/repos/hashicorp/nomad/issues/1159/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/1159/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/nomad/pulls/1159/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/nomad/statuses/f6460ebdd427d9865f099c95b9c395647bd5370c"}}}}