{"action":"created","comment":{"url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments/76826371","id":76826371,"diff_hunk":"@@ -31,41 +33,44 @@\n     /**\n      * The received IEEE addresses.\n      */\n-    private Map<Integer, IeeeAddressResponse> ieeeAddresses =\n-            Collections.synchronizedMap(new HashMap<Integer, IeeeAddressResponse>());\n+    private Map<Integer, IeeeAddressResponse> ieeeAddresses = Collections\n+            .synchronizedMap(new HashMap<Integer, IeeeAddressResponse>());\n     /**\n      * The received node descriptors.\n      */\n-    private Map<Integer, NodeDescriptorResponse> nodeDescriptors =\n-            Collections.synchronizedMap(new HashMap<Integer, NodeDescriptorResponse>());\n+    private Map<Integer, NodeDescriptorResponse> nodeDescriptors = Collections\n+            .synchronizedMap(new HashMap<Integer, NodeDescriptorResponse>());\n     /**\n      * Map of IEEE address request times.\n      */\n-    final Map<Integer, Long> ieeeAddressRequestTimes =\n-            Collections.synchronizedMap(new HashMap<Integer, Long>());\n+    final Map<Integer, Long> ieeeAddressRequestTimes = Collections\n+            .synchronizedMap(new HashMap<Integer, Long>());\n     /**\n      * Map of node descriptor request times.\n      */\n-    final Map<Integer, Long> nodeDescriptorRequestTimes =\n-            Collections.synchronizedMap(new HashMap<Integer, Long>());\n+    final Map<Integer, Long> nodeDescriptorRequestTimes = Collections\n+            .synchronizedMap(new HashMap<Integer, Long>());\n     /**\n      * Map of active endpoints request times.\n      */\n-    final Map<Integer, Long> activeEndpointsRequestTimes =\n-            Collections.synchronizedMap(new HashMap<Integer, Long>());\n+    final Map<Integer, Long> activeEndpointsRequestTimes = Collections\n+            .synchronizedMap(new HashMap<Integer, Long>());\n     /**\n      * Map of endpoint descriptor request times.\n      */\n-    final Map<String, Long> endpointDescriptorRequestTimes =\n-            Collections.synchronizedMap(new HashMap<String, Long>());\n+    final Map<String, Long> endpointDescriptorRequestTimes = Collections","path":"zigbee-common/src/main/java/org/bubblecloud/zigbee/v3/ZigBeeNetworkDiscoverer.java","position":64,"original_position":64,"commit_id":"d2104167d75173994ce35a370efca80a76881651","original_commit_id":"d2104167d75173994ce35a370efca80a76881651","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Variable access definition in wrong order.](https://www.codacy.com/app/tommi-s-e-laukkanen/zigbee4java/file/3661021647/issues/source?bid=3322503&fileBranchId=3645655#l61)","created_at":"2016-08-30T16:05:49Z","updated_at":"2016-08-30T16:05:49Z","html_url":"https://github.com/tlaukkan/zigbee4java/pull/101#discussion_r76826371","pull_request_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments/76826371"},"html":{"href":"https://github.com/tlaukkan/zigbee4java/pull/101#discussion_r76826371"},"pull_request":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101","id":83159012,"html_url":"https://github.com/tlaukkan/zigbee4java/pull/101","diff_url":"https://github.com/tlaukkan/zigbee4java/pull/101.diff","patch_url":"https://github.com/tlaukkan/zigbee4java/pull/101.patch","issue_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/101","number":101,"state":"open","locked":false,"title":"Destination device address","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"body":"This is an updated version of #95. I've now updated the doc and removed commented code.\r\n\r\nThis changes the ZigBeeDestination to ZigBeeAddress, and then has two address classes - ZigBeeGroupAddress, and ZigBeeDeviceAddress. ZigBeeDevice no longer extends ZigBeeDestination - nothing relied on this extension, and it seems much better not to have this link.\r\n\r\nIt also makes ZigBeeAddress abstract, and then move the isGroup method into the implementation classes rather than having the parent class check for subclasses to see if it's a group which doesn't seem nice.\r\n\r\nIn general, everywhere where we had a network address and endpoint, I'm now using the address. It likely needs a bit more work, but I'd welcome your thoughts on wether or not you're happy with this approach.","created_at":"2016-08-29T20:08:10Z","updated_at":"2016-08-30T16:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"210cf169504ae938bd945a5514b479bbdc7bb98c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101/commits","review_comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101/comments","review_comment_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/101/comments","statuses_url":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/d2104167d75173994ce35a370efca80a76881651","head":{"label":"cdjackson:destination_device_address","ref":"destination_device_address","sha":"d2104167d75173994ce35a370efca80a76881651","user":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"repo":{"id":66854112,"name":"zigbee4java","full_name":"cdjackson/zigbee4java","owner":{"login":"cdjackson","id":1041475,"avatar_url":"https://avatars.githubusercontent.com/u/1041475?v=3","gravatar_id":"","url":"https://api.github.com/users/cdjackson","html_url":"https://github.com/cdjackson","followers_url":"https://api.github.com/users/cdjackson/followers","following_url":"https://api.github.com/users/cdjackson/following{/other_user}","gists_url":"https://api.github.com/users/cdjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/cdjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdjackson/subscriptions","organizations_url":"https://api.github.com/users/cdjackson/orgs","repos_url":"https://api.github.com/users/cdjackson/repos","events_url":"https://api.github.com/users/cdjackson/events{/privacy}","received_events_url":"https://api.github.com/users/cdjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdjackson/zigbee4java","description":"Zigbee API for Java provides simple Java interface to ZigBee network.","fork":true,"url":"https://api.github.com/repos/cdjackson/zigbee4java","forks_url":"https://api.github.com/repos/cdjackson/zigbee4java/forks","keys_url":"https://api.github.com/repos/cdjackson/zigbee4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdjackson/zigbee4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdjackson/zigbee4java/teams","hooks_url":"https://api.github.com/repos/cdjackson/zigbee4java/hooks","issue_events_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues/events{/number}","events_url":"https://api.github.com/repos/cdjackson/zigbee4java/events","assignees_url":"https://api.github.com/repos/cdjackson/zigbee4java/assignees{/user}","branches_url":"https://api.github.com/repos/cdjackson/zigbee4java/branches{/branch}","tags_url":"https://api.github.com/repos/cdjackson/zigbee4java/tags","blobs_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdjackson/zigbee4java/statuses/{sha}","languages_url":"https://api.github.com/repos/cdjackson/zigbee4java/languages","stargazers_url":"https://api.github.com/repos/cdjackson/zigbee4java/stargazers","contributors_url":"https://api.github.com/repos/cdjackson/zigbee4java/contributors","subscribers_url":"https://api.github.com/repos/cdjackson/zigbee4java/subscribers","subscription_url":"https://api.github.com/repos/cdjackson/zigbee4java/subscription","commits_url":"https://api.github.com/repos/cdjackson/zigbee4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdjackson/zigbee4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdjackson/zigbee4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdjackson/zigbee4java/contents/{+path}","compare_url":"https://api.github.com/repos/cdjackson/zigbee4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdjackson/zigbee4java/merges","archive_url":"https://api.github.com/repos/cdjackson/zigbee4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdjackson/zigbee4java/downloads","issues_url":"https://api.github.com/repos/cdjackson/zigbee4java/issues{/number}","pulls_url":"https://api.github.com/repos/cdjackson/zigbee4java/pulls{/number}","milestones_url":"https://api.github.com/repos/cdjackson/zigbee4java/milestones{/number}","notifications_url":"https://api.github.com/repos/cdjackson/zigbee4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdjackson/zigbee4java/labels{/name}","releases_url":"https://api.github.com/repos/cdjackson/zigbee4java/releases{/id}","deployments_url":"https://api.github.com/repos/cdjackson/zigbee4java/deployments","created_at":"2016-08-29T15:05:29Z","updated_at":"2016-08-29T15:05:35Z","pushed_at":"2016-08-30T16:03:33Z","git_url":"git://github.com/cdjackson/zigbee4java.git","ssh_url":"git@github.com:cdjackson/zigbee4java.git","clone_url":"https://github.com/cdjackson/zigbee4java.git","svn_url":"https://github.com/cdjackson/zigbee4java","homepage":"","size":2746,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlaukkan:master","ref":"master","sha":"11165c0d346640227ccacab7ed5f2c2636e674ef","user":{"login":"tlaukkan","id":232774,"avatar_url":"https://avatars.githubusercontent.com/u/232774?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaukkan","html_url":"https://github.com/tlaukkan","followers_url":"https://api.github.com/users/tlaukkan/followers","following_url":"https://api.github.com/users/tlaukkan/following{/other_user}","gists_url":"https://api.github.com/users/tlaukkan/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaukkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaukkan/subscriptions","organizations_url":"https://api.github.com/users/tlaukkan/orgs","repos_url":"https://api.github.com/users/tlaukkan/repos","events_url":"https://api.github.com/users/tlaukkan/events{/privacy}","received_events_url":"https://api.github.com/users/tlaukkan/received_events","type":"User","site_admin":false},"repo":{"id":15199543,"name":"zigbee4java","full_name":"tlaukkan/zigbee4java","owner":{"login":"tlaukkan","id":232774,"avatar_url":"https://avatars.githubusercontent.com/u/232774?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaukkan","html_url":"https://github.com/tlaukkan","followers_url":"https://api.github.com/users/tlaukkan/followers","following_url":"https://api.github.com/users/tlaukkan/following{/other_user}","gists_url":"https://api.github.com/users/tlaukkan/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaukkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaukkan/subscriptions","organizations_url":"https://api.github.com/users/tlaukkan/orgs","repos_url":"https://api.github.com/users/tlaukkan/repos","events_url":"https://api.github.com/users/tlaukkan/events{/privacy}","received_events_url":"https://api.github.com/users/tlaukkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlaukkan/zigbee4java","description":"Zigbee API for Java provides simple Java interface to ZigBee network.","fork":false,"url":"https://api.github.com/repos/tlaukkan/zigbee4java","forks_url":"https://api.github.com/repos/tlaukkan/zigbee4java/forks","keys_url":"https://api.github.com/repos/tlaukkan/zigbee4java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlaukkan/zigbee4java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlaukkan/zigbee4java/teams","hooks_url":"https://api.github.com/repos/tlaukkan/zigbee4java/hooks","issue_events_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/events{/number}","events_url":"https://api.github.com/repos/tlaukkan/zigbee4java/events","assignees_url":"https://api.github.com/repos/tlaukkan/zigbee4java/assignees{/user}","branches_url":"https://api.github.com/repos/tlaukkan/zigbee4java/branches{/branch}","tags_url":"https://api.github.com/repos/tlaukkan/zigbee4java/tags","blobs_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/{sha}","languages_url":"https://api.github.com/repos/tlaukkan/zigbee4java/languages","stargazers_url":"https://api.github.com/repos/tlaukkan/zigbee4java/stargazers","contributors_url":"https://api.github.com/repos/tlaukkan/zigbee4java/contributors","subscribers_url":"https://api.github.com/repos/tlaukkan/zigbee4java/subscribers","subscription_url":"https://api.github.com/repos/tlaukkan/zigbee4java/subscription","commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlaukkan/zigbee4java/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlaukkan/zigbee4java/contents/{+path}","compare_url":"https://api.github.com/repos/tlaukkan/zigbee4java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlaukkan/zigbee4java/merges","archive_url":"https://api.github.com/repos/tlaukkan/zigbee4java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlaukkan/zigbee4java/downloads","issues_url":"https://api.github.com/repos/tlaukkan/zigbee4java/issues{/number}","pulls_url":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls{/number}","milestones_url":"https://api.github.com/repos/tlaukkan/zigbee4java/milestones{/number}","notifications_url":"https://api.github.com/repos/tlaukkan/zigbee4java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlaukkan/zigbee4java/labels{/name}","releases_url":"https://api.github.com/repos/tlaukkan/zigbee4java/releases{/id}","deployments_url":"https://api.github.com/repos/tlaukkan/zigbee4java/deployments","created_at":"2013-12-15T07:20:58Z","updated_at":"2016-08-01T16:09:07Z","pushed_at":"2016-08-30T16:03:34Z","git_url":"git://github.com/tlaukkan/zigbee4java.git","ssh_url":"git@github.com:tlaukkan/zigbee4java.git","clone_url":"https://github.com/tlaukkan/zigbee4java.git","svn_url":"https://github.com/tlaukkan/zigbee4java","homepage":"","size":6334,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":14,"forks":33,"open_issues":14,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101"},"html":{"href":"https://github.com/tlaukkan/zigbee4java/pull/101"},"issue":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/101"},"comments":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/tlaukkan/zigbee4java/statuses/d2104167d75173994ce35a370efca80a76881651"}}}}
{"actor":{"display_login":"codacy-bot"}}