{"action":"opened","number":31,"pull_request":{"url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31","id":94541690,"html_url":"https://github.com/me-no-dev/ESPAsyncTCP/pull/31","diff_url":"https://github.com/me-no-dev/ESPAsyncTCP/pull/31.diff","patch_url":"https://github.com/me-no-dev/ESPAsyncTCP/pull/31.patch","issue_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/31","number":31,"state":"open","locked":false,"title":"fix: SyncClient memory leak, handling connect() errors","user":{"login":"michalfapso","id":1621436,"avatar_url":"https://avatars.githubusercontent.com/u/1621436?v=3","gravatar_id":"","url":"https://api.github.com/users/michalfapso","html_url":"https://github.com/michalfapso","followers_url":"https://api.github.com/users/michalfapso/followers","following_url":"https://api.github.com/users/michalfapso/following{/other_user}","gists_url":"https://api.github.com/users/michalfapso/gists{/gist_id}","starred_url":"https://api.github.com/users/michalfapso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalfapso/subscriptions","organizations_url":"https://api.github.com/users/michalfapso/orgs","repos_url":"https://api.github.com/users/michalfapso/repos","events_url":"https://api.github.com/users/michalfapso/events{/privacy}","received_events_url":"https://api.github.com/users/michalfapso/received_events","type":"User","site_admin":false},"body":"Hi me-no-dev! Thanks a lot for your async library.\r\n\r\nI just found a bug, which occurs e.g. when the connect() call times out. It gets stuck in an infinite loop [here](https://github.com/me-no-dev/ESPAsyncTCP/blob/master/src/SyncClient.cpp#L92), so I think that we only need to attach the onDisconnect callback before calling _client->connect(). Of course feel free to rename the new methods as you wish :o)\r\n\r\nCheers,\r\nMichal","created_at":"2016-11-21T01:13:43Z","updated_at":"2016-11-21T01:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f419885a65b29723edce863e53346ac818f3b5df","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31/commits","review_comments_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31/comments","review_comment_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/31/comments","statuses_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/statuses/7c7a980307ee135498ea482089cf20456e6fd609","head":{"label":"michalfapso:master","ref":"master","sha":"7c7a980307ee135498ea482089cf20456e6fd609","user":{"login":"michalfapso","id":1621436,"avatar_url":"https://avatars.githubusercontent.com/u/1621436?v=3","gravatar_id":"","url":"https://api.github.com/users/michalfapso","html_url":"https://github.com/michalfapso","followers_url":"https://api.github.com/users/michalfapso/followers","following_url":"https://api.github.com/users/michalfapso/following{/other_user}","gists_url":"https://api.github.com/users/michalfapso/gists{/gist_id}","starred_url":"https://api.github.com/users/michalfapso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalfapso/subscriptions","organizations_url":"https://api.github.com/users/michalfapso/orgs","repos_url":"https://api.github.com/users/michalfapso/repos","events_url":"https://api.github.com/users/michalfapso/events{/privacy}","received_events_url":"https://api.github.com/users/michalfapso/received_events","type":"User","site_admin":false},"repo":{"id":74313044,"name":"ESPAsyncTCP","full_name":"michalfapso/ESPAsyncTCP","owner":{"login":"michalfapso","id":1621436,"avatar_url":"https://avatars.githubusercontent.com/u/1621436?v=3","gravatar_id":"","url":"https://api.github.com/users/michalfapso","html_url":"https://github.com/michalfapso","followers_url":"https://api.github.com/users/michalfapso/followers","following_url":"https://api.github.com/users/michalfapso/following{/other_user}","gists_url":"https://api.github.com/users/michalfapso/gists{/gist_id}","starred_url":"https://api.github.com/users/michalfapso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalfapso/subscriptions","organizations_url":"https://api.github.com/users/michalfapso/orgs","repos_url":"https://api.github.com/users/michalfapso/repos","events_url":"https://api.github.com/users/michalfapso/events{/privacy}","received_events_url":"https://api.github.com/users/michalfapso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michalfapso/ESPAsyncTCP","description":"Async TCP Library for ESP8266 Arduino","fork":true,"url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP","forks_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/forks","keys_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/teams","hooks_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/hooks","issue_events_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/issues/events{/number}","events_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/events","assignees_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/assignees{/user}","branches_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/branches{/branch}","tags_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/tags","blobs_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/statuses/{sha}","languages_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/languages","stargazers_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/stargazers","contributors_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/contributors","subscribers_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/subscribers","subscription_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/subscription","commits_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/contents/{+path}","compare_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/merges","archive_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/downloads","issues_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/issues{/number}","pulls_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/pulls{/number}","milestones_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/milestones{/number}","notifications_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/labels{/name}","releases_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/releases{/id}","deployments_url":"https://api.github.com/repos/michalfapso/ESPAsyncTCP/deployments","created_at":"2016-11-21T00:52:41Z","updated_at":"2016-11-21T00:52:42Z","pushed_at":"2016-11-21T01:10:36Z","git_url":"git://github.com/michalfapso/ESPAsyncTCP.git","ssh_url":"git@github.com:michalfapso/ESPAsyncTCP.git","clone_url":"https://github.com/michalfapso/ESPAsyncTCP.git","svn_url":"https://github.com/michalfapso/ESPAsyncTCP","homepage":null,"size":124,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"me-no-dev:master","ref":"master","sha":"e3ef50bdecdc551d2c9986375e432f884e25edeb","user":{"login":"me-no-dev","id":12663778,"avatar_url":"https://avatars.githubusercontent.com/u/12663778?v=3","gravatar_id":"","url":"https://api.github.com/users/me-no-dev","html_url":"https://github.com/me-no-dev","followers_url":"https://api.github.com/users/me-no-dev/followers","following_url":"https://api.github.com/users/me-no-dev/following{/other_user}","gists_url":"https://api.github.com/users/me-no-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/me-no-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/me-no-dev/subscriptions","organizations_url":"https://api.github.com/users/me-no-dev/orgs","repos_url":"https://api.github.com/users/me-no-dev/repos","events_url":"https://api.github.com/users/me-no-dev/events{/privacy}","received_events_url":"https://api.github.com/users/me-no-dev/received_events","type":"User","site_admin":false},"repo":{"id":48289725,"name":"ESPAsyncTCP","full_name":"me-no-dev/ESPAsyncTCP","owner":{"login":"me-no-dev","id":12663778,"avatar_url":"https://avatars.githubusercontent.com/u/12663778?v=3","gravatar_id":"","url":"https://api.github.com/users/me-no-dev","html_url":"https://github.com/me-no-dev","followers_url":"https://api.github.com/users/me-no-dev/followers","following_url":"https://api.github.com/users/me-no-dev/following{/other_user}","gists_url":"https://api.github.com/users/me-no-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/me-no-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/me-no-dev/subscriptions","organizations_url":"https://api.github.com/users/me-no-dev/orgs","repos_url":"https://api.github.com/users/me-no-dev/repos","events_url":"https://api.github.com/users/me-no-dev/events{/privacy}","received_events_url":"https://api.github.com/users/me-no-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/me-no-dev/ESPAsyncTCP","description":"Async TCP Library for ESP8266 Arduino","fork":false,"url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP","forks_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/forks","keys_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/teams","hooks_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/hooks","issue_events_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/events{/number}","events_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/events","assignees_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/assignees{/user}","branches_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/branches{/branch}","tags_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/tags","blobs_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/git/refs{/sha}","trees_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/statuses/{sha}","languages_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/languages","stargazers_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/stargazers","contributors_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/contributors","subscribers_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/subscribers","subscription_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/subscription","commits_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/commits{/sha}","git_commits_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/git/commits{/sha}","comments_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/comments{/number}","issue_comment_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/comments{/number}","contents_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/contents/{+path}","compare_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/merges","archive_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/downloads","issues_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues{/number}","pulls_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls{/number}","milestones_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/milestones{/number}","notifications_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/labels{/name}","releases_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/releases{/id}","deployments_url":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/deployments","created_at":"2015-12-19T16:47:30Z","updated_at":"2016-11-19T15:54:10Z","pushed_at":"2016-11-21T01:13:43Z","git_url":"git://github.com/me-no-dev/ESPAsyncTCP.git","ssh_url":"git@github.com:me-no-dev/ESPAsyncTCP.git","clone_url":"https://github.com/me-no-dev/ESPAsyncTCP.git","svn_url":"https://github.com/me-no-dev/ESPAsyncTCP","homepage":null,"size":124,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":9,"forks":14,"open_issues":9,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31"},"html":{"href":"https://github.com/me-no-dev/ESPAsyncTCP/pull/31"},"issue":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/31"},"comments":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/me-no-dev/ESPAsyncTCP/statuses/7c7a980307ee135498ea482089cf20456e6fd609"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":14,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"michalfapso"}}