{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/48815369","id":48815369,"diff_hunk":"@@ -179,20 +179,25 @@ def expire_topbar_cache(sweeper)\n     (users+User.only_admin).each { |u| u.expire_topbar_cache(sweeper) }\n   end\n \n-  # returns self and parent parameters as a hash\n-  def parameters(include_source = false)\n+  def parent_params(include_source = false)\n     hash = {}\n     ids = ancestor_ids\n-    ids << id unless new_record? or self.frozen?\n     # need to pull out the locations to ensure they are sorted first,\n     # otherwise we might be overwriting the hash in the wrong order.\n-    elements = ids.size == 1 ? [self] : self.class.sort_by_ancestry(self.class.includes(\"#{type.downcase}_parameters\".to_sym).find(ids))\n+    elements = self.class.sort_by_ancestry(self.class.includes(\"#{type.downcase}_parameters\".to_sym).find(ids))\n     elements.each do |el|\n       el.send(\"#{type.downcase}_parameters\".to_sym).each {|p| hash[p.name] = include_source ? {:value => p.value, :source => sti_name, :safe_value => p.safe_value, :source_name => el.title} : p.value }\n     end\n     hash\n   end\n \n+  # returns self and parent parameters as a hash","path":"app/models/taxonomy.rb","position":20,"original_position":20,"commit_id":"dd48530af60588a9f96146334769917b02b5b241","original_commit_id":"dd48530af60588a9f96146334769917b02b5b241","user":{"login":"orrabin","id":7894647,"avatar_url":"https://avatars.githubusercontent.com/u/7894647?v=3","gravatar_id":"","url":"https://api.github.com/users/orrabin","html_url":"https://github.com/orrabin","followers_url":"https://api.github.com/users/orrabin/followers","following_url":"https://api.github.com/users/orrabin/following{/other_user}","gists_url":"https://api.github.com/users/orrabin/gists{/gist_id}","starred_url":"https://api.github.com/users/orrabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrabin/subscriptions","organizations_url":"https://api.github.com/users/orrabin/orgs","repos_url":"https://api.github.com/users/orrabin/repos","events_url":"https://api.github.com/users/orrabin/events{/privacy}","received_events_url":"https://api.github.com/users/orrabin/received_events","type":"User","site_admin":false},"body":"`parameters` should have the same behavior as before so existing tests already cover this.\r\nI'll add a test to check that `parent_params` is working correctly.","created_at":"2016-01-05T06:17:50Z","updated_at":"2016-01-05T06:17:50Z","html_url":"https://github.com/theforeman/foreman/pull/3003#discussion_r48815369","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3003","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/48815369"},"html":{"href":"https://github.com/theforeman/foreman/pull/3003#discussion_r48815369"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3003"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3003","id":54538732,"html_url":"https://github.com/theforeman/foreman/pull/3003","diff_url":"https://github.com/theforeman/foreman/pull/3003.diff","patch_url":"https://github.com/theforeman/foreman/pull/3003.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3003","number":3003,"state":"open","locked":false,"title":"Fixes #12931 - Locations/Organization show parent parameters","user":{"login":"orrabin","id":7894647,"avatar_url":"https://avatars.githubusercontent.com/u/7894647?v=3","gravatar_id":"","url":"https://api.github.com/users/orrabin","html_url":"https://github.com/orrabin","followers_url":"https://api.github.com/users/orrabin/followers","following_url":"https://api.github.com/users/orrabin/following{/other_user}","gists_url":"https://api.github.com/users/orrabin/gists{/gist_id}","starred_url":"https://api.github.com/users/orrabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrabin/subscriptions","organizations_url":"https://api.github.com/users/orrabin/orgs","repos_url":"https://api.github.com/users/orrabin/repos","events_url":"https://api.github.com/users/orrabin/events{/privacy}","received_events_url":"https://api.github.com/users/orrabin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-24T09:26:16Z","updated_at":"2016-01-05T06:17:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df2b88d98585ce68ab7087f3f4b2a9fb10384e00","assignee":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3003/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3003/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3003/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/dd48530af60588a9f96146334769917b02b5b241","head":{"label":"orrabin:12931","ref":"12931","sha":"dd48530af60588a9f96146334769917b02b5b241","user":{"login":"orrabin","id":7894647,"avatar_url":"https://avatars.githubusercontent.com/u/7894647?v=3","gravatar_id":"","url":"https://api.github.com/users/orrabin","html_url":"https://github.com/orrabin","followers_url":"https://api.github.com/users/orrabin/followers","following_url":"https://api.github.com/users/orrabin/following{/other_user}","gists_url":"https://api.github.com/users/orrabin/gists{/gist_id}","starred_url":"https://api.github.com/users/orrabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrabin/subscriptions","organizations_url":"https://api.github.com/users/orrabin/orgs","repos_url":"https://api.github.com/users/orrabin/repos","events_url":"https://api.github.com/users/orrabin/events{/privacy}","received_events_url":"https://api.github.com/users/orrabin/received_events","type":"User","site_admin":false},"repo":{"id":20857418,"name":"foreman","full_name":"orrabin/foreman","owner":{"login":"orrabin","id":7894647,"avatar_url":"https://avatars.githubusercontent.com/u/7894647?v=3","gravatar_id":"","url":"https://api.github.com/users/orrabin","html_url":"https://github.com/orrabin","followers_url":"https://api.github.com/users/orrabin/followers","following_url":"https://api.github.com/users/orrabin/following{/other_user}","gists_url":"https://api.github.com/users/orrabin/gists{/gist_id}","starred_url":"https://api.github.com/users/orrabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orrabin/subscriptions","organizations_url":"https://api.github.com/users/orrabin/orgs","repos_url":"https://api.github.com/users/orrabin/repos","events_url":"https://api.github.com/users/orrabin/events{/privacy}","received_events_url":"https://api.github.com/users/orrabin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/orrabin/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/orrabin/foreman","forks_url":"https://api.github.com/repos/orrabin/foreman/forks","keys_url":"https://api.github.com/repos/orrabin/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orrabin/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orrabin/foreman/teams","hooks_url":"https://api.github.com/repos/orrabin/foreman/hooks","issue_events_url":"https://api.github.com/repos/orrabin/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/orrabin/foreman/events","assignees_url":"https://api.github.com/repos/orrabin/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/orrabin/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/orrabin/foreman/tags","blobs_url":"https://api.github.com/repos/orrabin/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orrabin/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orrabin/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/orrabin/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orrabin/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/orrabin/foreman/languages","stargazers_url":"https://api.github.com/repos/orrabin/foreman/stargazers","contributors_url":"https://api.github.com/repos/orrabin/foreman/contributors","subscribers_url":"https://api.github.com/repos/orrabin/foreman/subscribers","subscription_url":"https://api.github.com/repos/orrabin/foreman/subscription","commits_url":"https://api.github.com/repos/orrabin/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/orrabin/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/orrabin/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/orrabin/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/orrabin/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/orrabin/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orrabin/foreman/merges","archive_url":"https://api.github.com/repos/orrabin/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orrabin/foreman/downloads","issues_url":"https://api.github.com/repos/orrabin/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/orrabin/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/orrabin/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/orrabin/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orrabin/foreman/labels{/name}","releases_url":"https://api.github.com/repos/orrabin/foreman/releases{/id}","created_at":"2014-06-15T14:38:41Z","updated_at":"2014-06-29T14:44:11Z","pushed_at":"2016-01-04T15:28:48Z","git_url":"git://github.com/orrabin/foreman.git","ssh_url":"git@github.com:orrabin/foreman.git","clone_url":"https://github.com/orrabin/foreman.git","svn_url":"https://github.com/orrabin/foreman","homepage":"http://theforeman.org","size":29480,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"824ca59bc2d14e443d52377c642f1342befb14e8","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-01-04T20:39:58Z","pushed_at":"2016-01-04T21:39:07Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":54980,"stargazers_count":920,"watchers_count":920,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":460,"mirror_url":null,"open_issues_count":90,"forks":460,"open_issues":90,"watchers":920,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3003"},"html":{"href":"https://github.com/theforeman/foreman/pull/3003"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3003"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3003/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3003/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3003/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/dd48530af60588a9f96146334769917b02b5b241"}}}}