{"action":"created","issue":{"url":"https://api.github.com/repos/JMRI/JMRI/issues/2577","repository_url":"https://api.github.com/repos/JMRI/JMRI","labels_url":"https://api.github.com/repos/JMRI/JMRI/issues/2577/labels{/name}","comments_url":"https://api.github.com/repos/JMRI/JMRI/issues/2577/comments","events_url":"https://api.github.com/repos/JMRI/JMRI/issues/2577/events","html_url":"https://github.com/JMRI/JMRI/issues/2577","id":191503385,"number":2577,"title":"RPS Algorithm Test Failures","user":{"login":"rhwood","id":297232,"avatar_url":"https://avatars.githubusercontent.com/u/297232?v=3","gravatar_id":"","url":"https://api.github.com/users/rhwood","html_url":"https://github.com/rhwood","followers_url":"https://api.github.com/users/rhwood/followers","following_url":"https://api.github.com/users/rhwood/following{/other_user}","gists_url":"https://api.github.com/users/rhwood/gists{/gist_id}","starred_url":"https://api.github.com/users/rhwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhwood/subscriptions","organizations_url":"https://api.github.com/users/rhwood/orgs","repos_url":"https://api.github.com/users/rhwood/repos","events_url":"https://api.github.com/users/rhwood/events{/privacy}","received_events_url":"https://api.github.com/users/rhwood/received_events","type":"User","site_admin":false},"labels":[{"id":299186645,"url":"https://api.github.com/repos/JMRI/JMRI/labels/dev/test/publish%20infrastructure","name":"dev/test/publish infrastructure","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-24T12:01:51Z","updated_at":"2016-11-24T13:13:24Z","closed_at":null,"body":"The following tests throw errors:\r\n```\r\nCalculus:JMRI rhwood$ ./runtest.csh jmri.jmrix.rps.Ash1_0AlgorithmTest\r\n.ERROR - Mismatch: 4 readings, 5 receivers [main] jmri.jmrix.rps.Ash1_0Algorithm.?()\r\n.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_0Algorithm.?()\r\nE.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_0Algorithm.?()\r\n.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_0Algorithm.?()\r\nE\r\nTime: 2.814\r\nThere were 2 errors:\r\n1) testCalc4_not1(jmri.jmrix.rps.Ash1_0AlgorithmTest)java.lang.AssertionError: z close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.Ash1_0AlgorithmTest.testCalc4_not1(Ash1_0AlgorithmTest.java:60)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Ash1_0AlgorithmTest.main(Ash1_0AlgorithmTest.java:109)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n2) testCalc4_not3(jmri.jmrix.rps.Ash1_0AlgorithmTest)java.lang.AssertionError: x close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.Ash1_0AlgorithmTest.testCalc4_not3(Ash1_0AlgorithmTest.java:96)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Ash1_0AlgorithmTest.main(Ash1_0AlgorithmTest.java:109)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n\r\nFAILURES!!!\r\nTests run: 4,  Failures: 0,  Errors: 2\r\n\r\nCalculus:JMRI rhwood$ ./runtest.csh jmri.jmrix.rps.Ash1_1AlgorithmTest\r\n.ERROR - Mismatch: 4 readings, 5 receivers [main] jmri.jmrix.rps.Ash1_1Algorithm.?()\r\n.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_1Algorithm.?()\r\n.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_1Algorithm.?()\r\n.ERROR - Mismatch: 3 readings, 4 receivers [main] jmri.jmrix.rps.Ash1_1Algorithm.?()\r\n\r\nTime: 6.058\r\n\r\nOK (4 tests)\r\n\r\nCalculus:JMRI rhwood$ ./runtest.csh jmri.jmrix.rps.Analytic_AAlgorithmTest\r\n....Test 4 x not close -99999.0 3.0\r\nERROR - Can't solve, iteration limit exceeded.  it = 6 [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nERROR - failed to converge [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nE.Test 5 x not close -99999.0 3.0\r\nERROR - Can't solve, iteration limit exceeded.  it = 6 [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nERROR - failed to converge [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nE.Test 6 x not close -99999.0 3.0\r\nERROR - Can't solve, iteration limit exceeded.  it = 6 [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nERROR - failed to converge [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nE.Test 7 x not close -99999.0 3.0\r\nERROR - Can't solve, iteration limit exceeded.  it = 6 [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nERROR - failed to converge [main] jmri.jmrix.rps.Analytic_AAlgorithm.?()\r\nE\r\nTime: 2.4\r\nThere were 4 errors:\r\n1) testCalc4(jmri.jmrix.rps.Analytic_AAlgorithmTest)java.lang.AssertionError: Test 4 x close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc(AbstractAlgorithmTest.java:176)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc4(AbstractAlgorithmTest.java:90)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Analytic_AAlgorithmTest.main(Analytic_AAlgorithmTest.java:23)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n2) testCalc5(jmri.jmrix.rps.Analytic_AAlgorithmTest)java.lang.AssertionError: Test 5 x close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc(AbstractAlgorithmTest.java:176)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc5(AbstractAlgorithmTest.java:104)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Analytic_AAlgorithmTest.main(Analytic_AAlgorithmTest.java:23)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n3) testCalc6(jmri.jmrix.rps.Analytic_AAlgorithmTest)java.lang.AssertionError: Test 6 x close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc(AbstractAlgorithmTest.java:176)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc6(AbstractAlgorithmTest.java:118)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Analytic_AAlgorithmTest.main(Analytic_AAlgorithmTest.java:23)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n4) testCalc7(jmri.jmrix.rps.Analytic_AAlgorithmTest)java.lang.AssertionError: Test 7 x close expected:<true> but was:<false>\r\n\tat org.junit.Assert.fail(Assert.java:88)\r\n\tat org.junit.Assert.failNotEquals(Assert.java:834)\r\n\tat org.junit.Assert.assertEquals(Assert.java:118)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc(AbstractAlgorithmTest.java:176)\r\n\tat jmri.jmrix.rps.AbstractAlgorithmTest.testCalc7(AbstractAlgorithmTest.java:132)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.jmrix.rps.Analytic_AAlgorithmTest.main(Analytic_AAlgorithmTest.java:23)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat jmri.util.junit.TestClassMainMethod.main(TestClassMainMethod.java:21)\r\n\r\nFAILURES!!!\r\nTests run: 7,  Failures: 0,  Errors: 4\r\n```\r\n\r\nThese tests were commented out of any suites in 2008 (739482aa42c28ec65997a703cd2931a41c3b850f), but I do not know if they were bad then, or removed for some other reason. Should these tests be removed (they aren't in use), and if not, how should they be fixed (I do not understand the code enough to know if the test is failing correctly)?  \r\n\r\n(I added logging setup and teardown configurations to these tests in #2576 to get the Mismatch error statements instead of improper logging configuration warnings.)"},"comment":{"url":"https://api.github.com/repos/JMRI/JMRI/issues/comments/262773582","html_url":"https://github.com/JMRI/JMRI/issues/2577#issuecomment-262773582","issue_url":"https://api.github.com/repos/JMRI/JMRI/issues/2577","id":262773582,"user":{"login":"pabender","id":14183416,"avatar_url":"https://avatars.githubusercontent.com/u/14183416?v=3","gravatar_id":"","url":"https://api.github.com/users/pabender","html_url":"https://github.com/pabender","followers_url":"https://api.github.com/users/pabender/followers","following_url":"https://api.github.com/users/pabender/following{/other_user}","gists_url":"https://api.github.com/users/pabender/gists{/gist_id}","starred_url":"https://api.github.com/users/pabender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabender/subscriptions","organizations_url":"https://api.github.com/users/pabender/orgs","repos_url":"https://api.github.com/users/pabender/repos","events_url":"https://api.github.com/users/pabender/events{/privacy}","received_events_url":"https://api.github.com/users/pabender/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T13:13:24Z","updated_at":"2016-11-24T13:13:24Z","body":"\n\nOn Nov 24, 2016, at 7:01 AM, Randall Wood <notifications@github.com> wrote:\n\n> These tests were commented out of any suites in 2008 (739482a), but I do not know if they were bad then, or removed for some other reason. Should these tests be removed (they aren't in use), and if not, how should they be fixed (I do not understand the code enough to know if the test is failing correctly)?\n> \n\nBob would be the one to know if they ever worked.\n\nI would:\n1) convert the. Test class to JUnit4 ( if they aren't already )\n2) mark these tests with an ignore annotation that explains how they fail.\n\nPaul"}}
{"actor":{"display_login":"pabender"}}