{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/62148826","id":62148826,"diff_hunk":"@@ -0,0 +1,36 @@\n+/*\n+ * This file is part of SpongeAPI, licensed under the MIT License (MIT).\n+ *\n+ * Copyright (c) SpongePowered <https://www.spongepowered.org>\n+ * Copyright (c) contributors\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.spongepowered.api.text.translation.dictionary;\n+\n+/**\n+ * A {@link TranslationDictionary} that can cache values.\n+ */\n+public interface CachingTranslationDictionary extends TranslationDictionary {","path":"src/main/java/org/spongepowered/api/text/translation/dictionary/CachingTranslationDictionary.java","position":30,"original_position":30,"commit_id":"0c948ff41f0febb92332be0f45f667652857288c","original_commit_id":"1282e3f0db7cf65c8bc19ca365f84b492f812b8f","user":{"login":"windy1","id":755713,"avatar_url":"https://avatars.githubusercontent.com/u/755713?v=3","gravatar_id":"","url":"https://api.github.com/users/windy1","html_url":"https://github.com/windy1","followers_url":"https://api.github.com/users/windy1/followers","following_url":"https://api.github.com/users/windy1/following{/other_user}","gists_url":"https://api.github.com/users/windy1/gists{/gist_id}","starred_url":"https://api.github.com/users/windy1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windy1/subscriptions","organizations_url":"https://api.github.com/users/windy1/orgs","repos_url":"https://api.github.com/users/windy1/repos","events_url":"https://api.github.com/users/windy1/events{/privacy}","received_events_url":"https://api.github.com/users/windy1/received_events","type":"User","site_admin":false},"body":"Oh true, I just realized that `SimpleResourceBundle` isn't a `CachingTranslationDictionary`","created_at":"2016-05-05T05:01:09Z","updated_at":"2016-05-05T05:01:09Z","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/1224#discussion_r62148826","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/62148826"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/1224#discussion_r62148826"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224","id":68961184,"html_url":"https://github.com/SpongePowered/SpongeAPI/pull/1224","diff_url":"https://github.com/SpongePowered/SpongeAPI/pull/1224.diff","patch_url":"https://github.com/SpongePowered/SpongeAPI/pull/1224.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/1224","number":1224,"state":"open","locked":false,"title":"Translation dictionaries","user":{"login":"kashike","id":5474071,"avatar_url":"https://avatars.githubusercontent.com/u/5474071?v=3","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"body":"Supersedes #1088, #1206\r\n___\r\nThis PR adds a translation dictionary API to SpongeAPI.","created_at":"2016-05-05T02:59:54Z","updated_at":"2016-05-05T05:01:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"468d0e26dfa8744be193c6de7becc8481863cf06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/1224/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/0c948ff41f0febb92332be0f45f667652857288c","head":{"label":"kashike:feature/translations","ref":"feature/translations","sha":"0c948ff41f0febb92332be0f45f667652857288c","user":{"login":"kashike","id":5474071,"avatar_url":"https://avatars.githubusercontent.com/u/5474071?v=3","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"repo":{"id":38179414,"name":"SpongeAPI","full_name":"kashike/SpongeAPI","owner":{"login":"kashike","id":5474071,"avatar_url":"https://avatars.githubusercontent.com/u/5474071?v=3","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kashike/SpongeAPI","description":"A Minecraft plugin API","fork":true,"url":"https://api.github.com/repos/kashike/SpongeAPI","forks_url":"https://api.github.com/repos/kashike/SpongeAPI/forks","keys_url":"https://api.github.com/repos/kashike/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kashike/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kashike/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/kashike/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/kashike/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/kashike/SpongeAPI/events","assignees_url":"https://api.github.com/repos/kashike/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/kashike/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/kashike/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/kashike/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kashike/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kashike/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/kashike/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kashike/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/kashike/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/kashike/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/kashike/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/kashike/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/kashike/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/kashike/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/kashike/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/kashike/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/kashike/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/kashike/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/kashike/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kashike/SpongeAPI/merges","archive_url":"https://api.github.com/repos/kashike/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kashike/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/kashike/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/kashike/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/kashike/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/kashike/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kashike/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/kashike/SpongeAPI/releases{/id}","deployments_url":"https://api.github.com/repos/kashike/SpongeAPI/deployments","created_at":"2015-06-27T23:40:23Z","updated_at":"2016-01-12T01:35:53Z","pushed_at":"2016-05-05T04:53:45Z","git_url":"git://github.com/kashike/SpongeAPI.git","ssh_url":"git@github.com:kashike/SpongeAPI.git","clone_url":"https://github.com/kashike/SpongeAPI.git","svn_url":"https://github.com/kashike/SpongeAPI","homepage":"http://www.spongepowered.org/","size":12841,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"fdf51377e17f953838e35d7bdfd21dbe3762b94c","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23770421,"name":"SpongeAPI","full_name":"SpongePowered/SpongeAPI","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeAPI","description":"A Minecraft plugin API","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeAPI","forks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/deployments","created_at":"2014-09-07T20:39:25Z","updated_at":"2016-05-02T17:48:13Z","pushed_at":"2016-05-05T04:53:46Z","git_url":"git://github.com/SpongePowered/SpongeAPI.git","ssh_url":"git@github.com:SpongePowered/SpongeAPI.git","clone_url":"https://github.com/SpongePowered/SpongeAPI.git","svn_url":"https://github.com/SpongePowered/SpongeAPI","homepage":"http://www.spongepowered.org/","size":22631,"stargazers_count":851,"watchers_count":851,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":354,"mirror_url":null,"open_issues_count":129,"forks":354,"open_issues":129,"watchers":851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/1224"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/1224"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/1224/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/1224/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/0c948ff41f0febb92332be0f45f667652857288c"}}}}