{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/comments/94006821","pull_request_review_id":14536577,"id":94006821,"diff_hunk":"@@ -0,0 +1,161 @@\n+abstract ODEIterAlgorithm <: AbstractODEAlgorithm\n+immutable feuler <: ODEIterAlgorithm end\n+immutable rk23 <: ODEIterAlgorithm end\n+immutable rk45 <: ODEIterAlgorithm end\n+immutable feh78 <: ODEIterAlgorithm end\n+immutable ModifiedRosenbrock <: ODEIterAlgorithm end\n+immutable midpoint <: ODEIterAlgorithm end\n+immutable heun <: ODEIterAlgorithm end\n+immutable rk4 <: ODEIterAlgorithm end\n+immutable feh45 <: ODEIterAlgorithm end\n+\n+typealias KW Dict{Symbol,Any}\n+\n+function solve{uType,tType,isinplace,algType<:ODEIterAlgorithm,F}(prob::AbstractODEProblem{uType,tType,isinplace,F},\n+    alg::algType,timeseries=[],ts=[],ks=[];dense=true,save_timeseries=true,\n+    saveat=[],callback=()->nothing,timeseries_errors=true,dense_errors=false,\n+    kwargs...)\n+  tspan = prob.tspan\n+\n+  if tspan[end]-tspan[1]<tType(0)","path":"src/common.jl","position":20,"original_position":20,"commit_id":"40f0ace7356a0415b46f9bc68b4dbe63c0197fe0","original_commit_id":"40f0ace7356a0415b46f9bc68b4dbe63c0197fe0","user":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars.githubusercontent.com/u/1814174?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"body":">What about the sort(unique(...)) thing?\r\n\r\nThat's for \"saveat\" style chosen outputs. The things I tried didn't work, so I just don't have saveat implemented at all in this. ","created_at":"2016-12-28T08:38:52Z","updated_at":"2016-12-28T08:38:52Z","html_url":"https://github.com/JuliaODE/ODE.jl/pull/28#discussion_r94006821","pull_request_url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/comments/94006821"},"html":{"href":"https://github.com/JuliaODE/ODE.jl/pull/28#discussion_r94006821"},"pull_request":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28","id":97500611,"html_url":"https://github.com/JuliaODE/ODE.jl/pull/28","diff_url":"https://github.com/JuliaODE/ODE.jl/pull/28.diff","patch_url":"https://github.com/JuliaODE/ODE.jl/pull/28.patch","issue_url":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/28","number":28,"state":"open","locked":false,"title":"add common interface bindings and tests","user":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars.githubusercontent.com/u/1814174?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"body":"This moves the common interface bindings and the tests for PR49 to this package.","created_at":"2016-12-12T06:26:24Z","updated_at":"2016-12-28T08:38:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dba484b02c86d1c04b6e60014d0113b785d59478","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28/commits","review_comments_url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28/comments","review_comment_url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/28/comments","statuses_url":"https://api.github.com/repos/JuliaODE/ODE.jl/statuses/40f0ace7356a0415b46f9bc68b4dbe63c0197fe0","head":{"label":"ChrisRackauckas:common","ref":"common","sha":"40f0ace7356a0415b46f9bc68b4dbe63c0197fe0","user":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars.githubusercontent.com/u/1814174?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"repo":{"id":76228095,"name":"ODE.jl-1","full_name":"ChrisRackauckas/ODE.jl-1","owner":{"login":"ChrisRackauckas","id":1814174,"avatar_url":"https://avatars.githubusercontent.com/u/1814174?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChrisRackauckas/ODE.jl-1","description":"Assorted basic Ordinary Differential Equation solvers","fork":true,"url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1","forks_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/forks","keys_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/teams","hooks_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/hooks","issue_events_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/events","assignees_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/tags","blobs_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/languages","stargazers_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/stargazers","contributors_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/contributors","subscribers_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/subscribers","subscription_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/subscription","commits_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/merges","archive_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/downloads","issues_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/labels{/name}","releases_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisRackauckas/ODE.jl-1/deployments","created_at":"2016-12-12T06:23:33Z","updated_at":"2016-12-12T06:23:34Z","pushed_at":"2016-12-12T06:25:41Z","git_url":"git://github.com/ChrisRackauckas/ODE.jl-1.git","ssh_url":"git@github.com:ChrisRackauckas/ODE.jl-1.git","clone_url":"https://github.com/ChrisRackauckas/ODE.jl-1.git","svn_url":"https://github.com/ChrisRackauckas/ODE.jl-1","homepage":null,"size":1199,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaODE:master","ref":"master","sha":"e47748ba852ebf4f9b1acf4ce0771e577bbe92e5","user":{"login":"JuliaODE","id":20297481,"avatar_url":"https://avatars.githubusercontent.com/u/20297481?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaODE","html_url":"https://github.com/JuliaODE","followers_url":"https://api.github.com/users/JuliaODE/followers","following_url":"https://api.github.com/users/JuliaODE/following{/other_user}","gists_url":"https://api.github.com/users/JuliaODE/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaODE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaODE/subscriptions","organizations_url":"https://api.github.com/users/JuliaODE/orgs","repos_url":"https://api.github.com/users/JuliaODE/repos","events_url":"https://api.github.com/users/JuliaODE/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaODE/received_events","type":"Organization","site_admin":false},"repo":{"id":25534896,"name":"ODE.jl","full_name":"JuliaODE/ODE.jl","owner":{"login":"JuliaODE","id":20297481,"avatar_url":"https://avatars.githubusercontent.com/u/20297481?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaODE","html_url":"https://github.com/JuliaODE","followers_url":"https://api.github.com/users/JuliaODE/followers","following_url":"https://api.github.com/users/JuliaODE/following{/other_user}","gists_url":"https://api.github.com/users/JuliaODE/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaODE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaODE/subscriptions","organizations_url":"https://api.github.com/users/JuliaODE/orgs","repos_url":"https://api.github.com/users/JuliaODE/repos","events_url":"https://api.github.com/users/JuliaODE/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaODE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaODE/ODE.jl","description":"Assorted basic Ordinary Differential Equation solvers","fork":false,"url":"https://api.github.com/repos/JuliaODE/ODE.jl","forks_url":"https://api.github.com/repos/JuliaODE/ODE.jl/forks","keys_url":"https://api.github.com/repos/JuliaODE/ODE.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaODE/ODE.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaODE/ODE.jl/teams","hooks_url":"https://api.github.com/repos/JuliaODE/ODE.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaODE/ODE.jl/events","assignees_url":"https://api.github.com/repos/JuliaODE/ODE.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaODE/ODE.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaODE/ODE.jl/tags","blobs_url":"https://api.github.com/repos/JuliaODE/ODE.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaODE/ODE.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaODE/ODE.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaODE/ODE.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaODE/ODE.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaODE/ODE.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaODE/ODE.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaODE/ODE.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaODE/ODE.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaODE/ODE.jl/subscription","commits_url":"https://api.github.com/repos/JuliaODE/ODE.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaODE/ODE.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaODE/ODE.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaODE/ODE.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaODE/ODE.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaODE/ODE.jl/merges","archive_url":"https://api.github.com/repos/JuliaODE/ODE.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaODE/ODE.jl/downloads","issues_url":"https://api.github.com/repos/JuliaODE/ODE.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaODE/ODE.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaODE/ODE.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaODE/ODE.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaODE/ODE.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaODE/ODE.jl/deployments","created_at":"2014-10-21T17:07:13Z","updated_at":"2016-12-22T12:19:10Z","pushed_at":"2016-12-12T06:26:24Z","git_url":"git://github.com/JuliaODE/ODE.jl.git","ssh_url":"git@github.com:JuliaODE/ODE.jl.git","clone_url":"https://github.com/JuliaODE/ODE.jl.git","svn_url":"https://github.com/JuliaODE/ODE.jl","homepage":null,"size":1203,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28"},"html":{"href":"https://github.com/JuliaODE/ODE.jl/pull/28"},"issue":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/28"},"comments":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaODE/ODE.jl/statuses/40f0ace7356a0415b46f9bc68b4dbe63c0197fe0"}}}}
{"actor":{"display_login":"ChrisRackauckas"}}