{"action":"created","issue":{"url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/2","repository_url":"https://api.github.com/repos/koldmit/GeekHubHomeworks","labels_url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/2/comments","events_url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/2/events","html_url":"https://github.com/koldmit/GeekHubHomeworks/issues/2","id":187566217,"number":2,"title":"Homework 3","user":{"login":"pistriak","id":2580478,"avatar_url":"https://avatars.githubusercontent.com/u/2580478?v=3","gravatar_id":"","url":"https://api.github.com/users/pistriak","html_url":"https://github.com/pistriak","followers_url":"https://api.github.com/users/pistriak/followers","following_url":"https://api.github.com/users/pistriak/following{/other_user}","gists_url":"https://api.github.com/users/pistriak/gists{/gist_id}","starred_url":"https://api.github.com/users/pistriak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pistriak/subscriptions","organizations_url":"https://api.github.com/users/pistriak/orgs","repos_url":"https://api.github.com/users/pistriak/repos","events_url":"https://api.github.com/users/pistriak/events{/privacy}","received_events_url":"https://api.github.com/users/pistriak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-06T14:57:42Z","updated_at":"2016-11-06T19:47:07Z","closed_at":"2016-11-06T19:47:07Z","body":"1. Package names should be in lowercase. Store -> store;\r\n2. Code is not formatted properly; `abstract public class Bike extends Product{` -> `abstract public class Bike extends Product {`;\r\n3.  `abstract public class Bike` ->  `public abstract class Bike` in Cyclocross.java;\r\n4. Not needed: `public static final boolean isBestBikeTypeEver = true;`;\r\n5. Delete comment `//to calc our profit when sell by price of product` in Lot.java;\r\n6. Use StringBuilder instead of StringBuffer;\r\n7. Don't include 'List' in method names if method doesn't return a List; (BikeStore.getListOfProdLot);\r\n8. I would return a list of products in this method BikeStore.getListOfProducts; \r\nList<Product> getAllProducts(); \r\nIf the there are no products just return empty list. (Collections.emptyList());\r\n9. Don't use short names for public methods \r\n`    public Product getProdByName(String name)` -> `getProductByName`\r\n10. String getListOfProdLot (Product prod) ->` List<Lot>getLotsForProduct(Product product)`;\r\n 11. Then create some class witch takes products and lots and prints them to console. \r\n12. `public double getCostOfProd(String prodName)` -> getCostOfProduct(String productName)\r\n"},"comment":{"url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/comments/258705437","html_url":"https://github.com/koldmit/GeekHubHomeworks/issues/2#issuecomment-258705437","issue_url":"https://api.github.com/repos/koldmit/GeekHubHomeworks/issues/2","id":258705437,"user":{"login":"koldmit","id":22935515,"avatar_url":"https://avatars.githubusercontent.com/u/22935515?v=3","gravatar_id":"","url":"https://api.github.com/users/koldmit","html_url":"https://github.com/koldmit","followers_url":"https://api.github.com/users/koldmit/followers","following_url":"https://api.github.com/users/koldmit/following{/other_user}","gists_url":"https://api.github.com/users/koldmit/gists{/gist_id}","starred_url":"https://api.github.com/users/koldmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldmit/subscriptions","organizations_url":"https://api.github.com/users/koldmit/orgs","repos_url":"https://api.github.com/users/koldmit/repos","events_url":"https://api.github.com/users/koldmit/events{/privacy}","received_events_url":"https://api.github.com/users/koldmit/received_events","type":"User","site_admin":false},"created_at":"2016-11-06T19:47:07Z","updated_at":"2016-11-06T19:47:07Z","body":"Done.\r\nI don't need StringBuilder with new output class for list and map now, because write data dirrectly to console. But I read differences between StringBuilder and StringBuffer and remember them."}}
{"actor":{"display_login":"koldmit"}}