{"action":"closed","number":11696,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/11696","id":85169942,"html_url":"https://github.com/dotnet/corefx/pull/11696","diff_url":"https://github.com/dotnet/corefx/pull/11696.diff","patch_url":"https://github.com/dotnet/corefx/pull/11696.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/11696","number":11696,"state":"closed","locked":false,"title":"Adding various tests for LambdaCompiler","user":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"body":"Adds a bunch of tests for `LambdaCompiler` mostly focusing on:\r\n\r\n* `ILGen` for some cases of calls\r\n* `ILGen` for `decimal` types in various ranges, using different `System.Decimal` constructors\r\n* `ILGen` involving `ldtoken` for `MethodInfo` objects, and calls to runtime helpers for generics\r\n* Treatment of live constants including hitting the caching heuristic in `VariableBinder`\r\n* Various cases for generated closures, including accessing `HoistedLocals` and cached boxes\r\n* `ILGen` for switch tables for `string`\r\n* `ILGen` for various `ref` cases for primitives, leading to `ldind` and `stind` instructions\r\n* Type system checks for conversion of delegate types with co- and contra-variant type parameters\r\n\r\nThis addresses part of issue #11409 with more to follow in separate PRs. It brings code coverage for `System.Linq.Expressions` over 85%.","created_at":"2016-09-14T05:47:11Z","updated_at":"2016-09-14T11:42:28Z","closed_at":"2016-09-14T11:42:28Z","merged_at":"2016-09-14T11:42:28Z","merge_commit_sha":"402bb5cbe1832d91fa9e0e1ee29ac60925e52fcd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/11696/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/11696/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/11696/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/697f45911fe1858dd342c830f6baad7de0374a41","head":{"label":"bartdesmet:Issue-11409","ref":"Issue-11409","sha":"697f45911fe1858dd342c830f6baad7de0374a41","user":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"repo":{"id":42419903,"name":"corefx","full_name":"bartdesmet/corefx","owner":{"login":"bartdesmet","id":7324746,"avatar_url":"https://avatars.githubusercontent.com/u/7324746?v=3","gravatar_id":"","url":"https://api.github.com/users/bartdesmet","html_url":"https://github.com/bartdesmet","followers_url":"https://api.github.com/users/bartdesmet/followers","following_url":"https://api.github.com/users/bartdesmet/following{/other_user}","gists_url":"https://api.github.com/users/bartdesmet/gists{/gist_id}","starred_url":"https://api.github.com/users/bartdesmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartdesmet/subscriptions","organizations_url":"https://api.github.com/users/bartdesmet/orgs","repos_url":"https://api.github.com/users/bartdesmet/repos","events_url":"https://api.github.com/users/bartdesmet/events{/privacy}","received_events_url":"https://api.github.com/users/bartdesmet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartdesmet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/bartdesmet/corefx","forks_url":"https://api.github.com/repos/bartdesmet/corefx/forks","keys_url":"https://api.github.com/repos/bartdesmet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartdesmet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartdesmet/corefx/teams","hooks_url":"https://api.github.com/repos/bartdesmet/corefx/hooks","issue_events_url":"https://api.github.com/repos/bartdesmet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/bartdesmet/corefx/events","assignees_url":"https://api.github.com/repos/bartdesmet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/bartdesmet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/bartdesmet/corefx/tags","blobs_url":"https://api.github.com/repos/bartdesmet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartdesmet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartdesmet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartdesmet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartdesmet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/bartdesmet/corefx/languages","stargazers_url":"https://api.github.com/repos/bartdesmet/corefx/stargazers","contributors_url":"https://api.github.com/repos/bartdesmet/corefx/contributors","subscribers_url":"https://api.github.com/repos/bartdesmet/corefx/subscribers","subscription_url":"https://api.github.com/repos/bartdesmet/corefx/subscription","commits_url":"https://api.github.com/repos/bartdesmet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartdesmet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartdesmet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartdesmet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartdesmet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/bartdesmet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartdesmet/corefx/merges","archive_url":"https://api.github.com/repos/bartdesmet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartdesmet/corefx/downloads","issues_url":"https://api.github.com/repos/bartdesmet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/bartdesmet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/bartdesmet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/bartdesmet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartdesmet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/bartdesmet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/bartdesmet/corefx/deployments","created_at":"2015-09-14T01:23:19Z","updated_at":"2016-07-30T23:55:33Z","pushed_at":"2016-09-14T05:39:36Z","git_url":"git://github.com/bartdesmet/corefx.git","ssh_url":"git@github.com:bartdesmet/corefx.git","clone_url":"https://github.com/bartdesmet/corefx.git","svn_url":"https://github.com/bartdesmet/corefx","homepage":"http://dotnet.github.io/core/","size":97051,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"049095e854df07d110477de1ac04e45a1df34cad","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-09-14T10:50:24Z","pushed_at":"2016-09-14T11:42:28Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":139864,"stargazers_count":10513,"watchers_count":10513,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2611,"mirror_url":null,"open_issues_count":1472,"forks":2611,"open_issues":1472,"watchers":10513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11696"},"html":{"href":"https://github.com/dotnet/corefx/pull/11696"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11696"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/11696/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11696/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/11696/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/697f45911fe1858dd342c830f6baad7de0374a41"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":420,"deletions":2,"changed_files":6}}
{"actor":{"display_login":"stephentoub"}}