{"action":"created","comment":{"url":"https://api.github.com/repos/zopim/txconnpool/pulls/comments/74733825","id":74733825,"diff_hunk":"@@ -62,14 +65,17 @@ def clientConnectionLost(self, connector, reason):\n             connector,\n             reason)\n \n-\n     def clientConnectionFailed(self, connector, reason):\n         \"\"\"\n         Notify the connectionPool that we're unable to connect\n         \"\"\"\n+\n         if self._protocolInstance is not None:\n             self.connectionPool.clientBusy(self._protocolInstance)\n \n+        self.connectionPool.clientFailed(\n+            self._protocolInstance, connector.host, connector.port)","path":"txconnpool/pool.py","position":45,"original_position":45,"commit_id":"988c4e223a628dde8748f2ae8ed9476a63df435b","original_commit_id":"988c4e223a628dde8748f2ae8ed9476a63df435b","user":{"login":"arnavk","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/arnavk","html_url":"https://github.com/arnavk","followers_url":"https://api.github.com/users/arnavk/followers","following_url":"https://api.github.com/users/arnavk/following{/other_user}","gists_url":"https://api.github.com/users/arnavk/gists{/gist_id}","starred_url":"https://api.github.com/users/arnavk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnavk/subscriptions","organizations_url":"https://api.github.com/users/arnavk/orgs","repos_url":"https://api.github.com/users/arnavk/repos","events_url":"https://api.github.com/users/arnavk/events{/privacy}","received_events_url":"https://api.github.com/users/arnavk/received_events","type":"User","site_admin":false},"body":"OH! I couldn't find it. This would be a much better way. Thanks","created_at":"2016-08-15T08:42:00Z","updated_at":"2016-08-15T08:42:00Z","html_url":"https://github.com/zopim/txconnpool/pull/2#discussion_r74733825","pull_request_url":"https://api.github.com/repos/zopim/txconnpool/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/comments/74733825"},"html":{"href":"https://github.com/zopim/txconnpool/pull/2#discussion_r74733825"},"pull_request":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/zopim/txconnpool/pulls/2","id":81279193,"html_url":"https://github.com/zopim/txconnpool/pull/2","diff_url":"https://github.com/zopim/txconnpool/pull/2.diff","patch_url":"https://github.com/zopim/txconnpool/pull/2.patch","issue_url":"https://api.github.com/repos/zopim/txconnpool/issues/2","number":2,"state":"open","locked":false,"title":"Add support for connecting to a pool of servers","user":{"login":"arnavk","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/arnavk","html_url":"https://github.com/arnavk","followers_url":"https://api.github.com/users/arnavk/followers","following_url":"https://api.github.com/users/arnavk/following{/other_user}","gists_url":"https://api.github.com/users/arnavk/gists{/gist_id}","starred_url":"https://api.github.com/users/arnavk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnavk/subscriptions","organizations_url":"https://api.github.com/users/arnavk/orgs","repos_url":"https://api.github.com/users/arnavk/repos","events_url":"https://api.github.com/users/arnavk/events{/privacy}","received_events_url":"https://api.github.com/users/arnavk/received_events","type":"User","site_admin":false},"body":"on `connectionFailed`, tell the pool to try with the next server address. The old messages will get retried on the previous server address till they eventually fail. ¯\\_(ツ)_/¯ \r\n\r\nTODO \r\n- [ ] Add tests\r\n- [ ] Add requirements file\r\n- [ ] Travis?\r\n\r\n@zopim/basketcases ","created_at":"2016-08-15T07:35:17Z","updated_at":"2016-08-15T08:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb84e411fdbe76020f4b4711ef014300efe42db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopim/txconnpool/pulls/2/commits","review_comments_url":"https://api.github.com/repos/zopim/txconnpool/pulls/2/comments","review_comment_url":"https://api.github.com/repos/zopim/txconnpool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopim/txconnpool/issues/2/comments","statuses_url":"https://api.github.com/repos/zopim/txconnpool/statuses/988c4e223a628dde8748f2ae8ed9476a63df435b","head":{"label":"arnavk:arnav/pool_to_multiple_servers","ref":"arnav/pool_to_multiple_servers","sha":"988c4e223a628dde8748f2ae8ed9476a63df435b","user":{"login":"arnavk","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/arnavk","html_url":"https://github.com/arnavk","followers_url":"https://api.github.com/users/arnavk/followers","following_url":"https://api.github.com/users/arnavk/following{/other_user}","gists_url":"https://api.github.com/users/arnavk/gists{/gist_id}","starred_url":"https://api.github.com/users/arnavk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnavk/subscriptions","organizations_url":"https://api.github.com/users/arnavk/orgs","repos_url":"https://api.github.com/users/arnavk/repos","events_url":"https://api.github.com/users/arnavk/events{/privacy}","received_events_url":"https://api.github.com/users/arnavk/received_events","type":"User","site_admin":false},"repo":{"id":64160648,"name":"txconnpool","full_name":"arnavk/txconnpool","owner":{"login":"arnavk","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/arnavk","html_url":"https://github.com/arnavk","followers_url":"https://api.github.com/users/arnavk/followers","following_url":"https://api.github.com/users/arnavk/following{/other_user}","gists_url":"https://api.github.com/users/arnavk/gists{/gist_id}","starred_url":"https://api.github.com/users/arnavk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnavk/subscriptions","organizations_url":"https://api.github.com/users/arnavk/orgs","repos_url":"https://api.github.com/users/arnavk/repos","events_url":"https://api.github.com/users/arnavk/events{/privacy}","received_events_url":"https://api.github.com/users/arnavk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnavk/txconnpool","description":"A generalized connection pooling library for Twisted.","fork":true,"url":"https://api.github.com/repos/arnavk/txconnpool","forks_url":"https://api.github.com/repos/arnavk/txconnpool/forks","keys_url":"https://api.github.com/repos/arnavk/txconnpool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnavk/txconnpool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnavk/txconnpool/teams","hooks_url":"https://api.github.com/repos/arnavk/txconnpool/hooks","issue_events_url":"https://api.github.com/repos/arnavk/txconnpool/issues/events{/number}","events_url":"https://api.github.com/repos/arnavk/txconnpool/events","assignees_url":"https://api.github.com/repos/arnavk/txconnpool/assignees{/user}","branches_url":"https://api.github.com/repos/arnavk/txconnpool/branches{/branch}","tags_url":"https://api.github.com/repos/arnavk/txconnpool/tags","blobs_url":"https://api.github.com/repos/arnavk/txconnpool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnavk/txconnpool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnavk/txconnpool/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnavk/txconnpool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnavk/txconnpool/statuses/{sha}","languages_url":"https://api.github.com/repos/arnavk/txconnpool/languages","stargazers_url":"https://api.github.com/repos/arnavk/txconnpool/stargazers","contributors_url":"https://api.github.com/repos/arnavk/txconnpool/contributors","subscribers_url":"https://api.github.com/repos/arnavk/txconnpool/subscribers","subscription_url":"https://api.github.com/repos/arnavk/txconnpool/subscription","commits_url":"https://api.github.com/repos/arnavk/txconnpool/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnavk/txconnpool/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnavk/txconnpool/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnavk/txconnpool/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnavk/txconnpool/contents/{+path}","compare_url":"https://api.github.com/repos/arnavk/txconnpool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnavk/txconnpool/merges","archive_url":"https://api.github.com/repos/arnavk/txconnpool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnavk/txconnpool/downloads","issues_url":"https://api.github.com/repos/arnavk/txconnpool/issues{/number}","pulls_url":"https://api.github.com/repos/arnavk/txconnpool/pulls{/number}","milestones_url":"https://api.github.com/repos/arnavk/txconnpool/milestones{/number}","notifications_url":"https://api.github.com/repos/arnavk/txconnpool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnavk/txconnpool/labels{/name}","releases_url":"https://api.github.com/repos/arnavk/txconnpool/releases{/id}","deployments_url":"https://api.github.com/repos/arnavk/txconnpool/deployments","created_at":"2016-07-25T19:04:40Z","updated_at":"2016-07-25T19:04:41Z","pushed_at":"2016-08-15T07:33:40Z","git_url":"git://github.com/arnavk/txconnpool.git","ssh_url":"git@github.com:arnavk/txconnpool.git","clone_url":"https://github.com/arnavk/txconnpool.git","svn_url":"https://github.com/arnavk/txconnpool","homepage":"","size":23,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zopim:master","ref":"master","sha":"aa327a150036610b358bae9084056dcc38a64afb","user":{"login":"zopim","id":390118,"avatar_url":"https://avatars.githubusercontent.com/u/390118?v=3","gravatar_id":"","url":"https://api.github.com/users/zopim","html_url":"https://github.com/zopim","followers_url":"https://api.github.com/users/zopim/followers","following_url":"https://api.github.com/users/zopim/following{/other_user}","gists_url":"https://api.github.com/users/zopim/gists{/gist_id}","starred_url":"https://api.github.com/users/zopim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopim/subscriptions","organizations_url":"https://api.github.com/users/zopim/orgs","repos_url":"https://api.github.com/users/zopim/repos","events_url":"https://api.github.com/users/zopim/events{/privacy}","received_events_url":"https://api.github.com/users/zopim/received_events","type":"Organization","site_admin":false},"repo":{"id":65713141,"name":"txconnpool","full_name":"zopim/txconnpool","owner":{"login":"zopim","id":390118,"avatar_url":"https://avatars.githubusercontent.com/u/390118?v=3","gravatar_id":"","url":"https://api.github.com/users/zopim","html_url":"https://github.com/zopim","followers_url":"https://api.github.com/users/zopim/followers","following_url":"https://api.github.com/users/zopim/following{/other_user}","gists_url":"https://api.github.com/users/zopim/gists{/gist_id}","starred_url":"https://api.github.com/users/zopim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopim/subscriptions","organizations_url":"https://api.github.com/users/zopim/orgs","repos_url":"https://api.github.com/users/zopim/repos","events_url":"https://api.github.com/users/zopim/events{/privacy}","received_events_url":"https://api.github.com/users/zopim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopim/txconnpool","description":"A generalized connection pooling library for Twisted.","fork":true,"url":"https://api.github.com/repos/zopim/txconnpool","forks_url":"https://api.github.com/repos/zopim/txconnpool/forks","keys_url":"https://api.github.com/repos/zopim/txconnpool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopim/txconnpool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopim/txconnpool/teams","hooks_url":"https://api.github.com/repos/zopim/txconnpool/hooks","issue_events_url":"https://api.github.com/repos/zopim/txconnpool/issues/events{/number}","events_url":"https://api.github.com/repos/zopim/txconnpool/events","assignees_url":"https://api.github.com/repos/zopim/txconnpool/assignees{/user}","branches_url":"https://api.github.com/repos/zopim/txconnpool/branches{/branch}","tags_url":"https://api.github.com/repos/zopim/txconnpool/tags","blobs_url":"https://api.github.com/repos/zopim/txconnpool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopim/txconnpool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopim/txconnpool/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopim/txconnpool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopim/txconnpool/statuses/{sha}","languages_url":"https://api.github.com/repos/zopim/txconnpool/languages","stargazers_url":"https://api.github.com/repos/zopim/txconnpool/stargazers","contributors_url":"https://api.github.com/repos/zopim/txconnpool/contributors","subscribers_url":"https://api.github.com/repos/zopim/txconnpool/subscribers","subscription_url":"https://api.github.com/repos/zopim/txconnpool/subscription","commits_url":"https://api.github.com/repos/zopim/txconnpool/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopim/txconnpool/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopim/txconnpool/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopim/txconnpool/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopim/txconnpool/contents/{+path}","compare_url":"https://api.github.com/repos/zopim/txconnpool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopim/txconnpool/merges","archive_url":"https://api.github.com/repos/zopim/txconnpool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopim/txconnpool/downloads","issues_url":"https://api.github.com/repos/zopim/txconnpool/issues{/number}","pulls_url":"https://api.github.com/repos/zopim/txconnpool/pulls{/number}","milestones_url":"https://api.github.com/repos/zopim/txconnpool/milestones{/number}","notifications_url":"https://api.github.com/repos/zopim/txconnpool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopim/txconnpool/labels{/name}","releases_url":"https://api.github.com/repos/zopim/txconnpool/releases{/id}","deployments_url":"https://api.github.com/repos/zopim/txconnpool/deployments","created_at":"2016-08-15T07:26:36Z","updated_at":"2016-08-15T07:26:38Z","pushed_at":"2016-08-15T07:35:26Z","git_url":"git://github.com/zopim/txconnpool.git","ssh_url":"git@github.com:zopim/txconnpool.git","clone_url":"https://github.com/zopim/txconnpool.git","svn_url":"https://github.com/zopim/txconnpool","homepage":"","size":24,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/2"},"html":{"href":"https://github.com/zopim/txconnpool/pull/2"},"issue":{"href":"https://api.github.com/repos/zopim/txconnpool/issues/2"},"comments":{"href":"https://api.github.com/repos/zopim/txconnpool/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopim/txconnpool/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/zopim/txconnpool/statuses/988c4e223a628dde8748f2ae8ed9476a63df435b"}}}}
{"actor":{"display_login":"arnavk"}}