{"action":"created","issue":{"url":"https://api.github.com/repos/bensie/sshkey/issues/13","repository_url":"https://api.github.com/repos/bensie/sshkey","labels_url":"https://api.github.com/repos/bensie/sshkey/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/bensie/sshkey/issues/13/comments","events_url":"https://api.github.com/repos/bensie/sshkey/issues/13/events","html_url":"https://github.com/bensie/sshkey/pull/13","id":22541239,"number":13,"title":"simplify some functions","user":{"login":"arnehormann","id":1011413,"avatar_url":"https://avatars.githubusercontent.com/u/1011413?v=3","gravatar_id":"","url":"https://api.github.com/users/arnehormann","html_url":"https://github.com/arnehormann","followers_url":"https://api.github.com/users/arnehormann/followers","following_url":"https://api.github.com/users/arnehormann/following{/other_user}","gists_url":"https://api.github.com/users/arnehormann/gists{/gist_id}","starred_url":"https://api.github.com/users/arnehormann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnehormann/subscriptions","organizations_url":"https://api.github.com/users/arnehormann/orgs","repos_url":"https://api.github.com/users/arnehormann/repos","events_url":"https://api.github.com/users/arnehormann/events{/privacy}","received_events_url":"https://api.github.com/users/arnehormann/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2013-11-12T18:49:42Z","updated_at":"2016-04-28T04:31:16Z","closed_at":"2013-11-13T17:29:38Z","pull_request":{"url":"https://api.github.com/repos/bensie/sshkey/pulls/13","html_url":"https://github.com/bensie/sshkey/pull/13","diff_url":"https://github.com/bensie/sshkey/pull/13.diff","patch_url":"https://github.com/bensie/sshkey/pull/13.patch"},"body":"* use `OpenSSL::BN` functionality to speed up and simplify `ssh_public_key_conversion`\r\n* same for `unpacked_byte_array` (which has to be *exceptionally* convoluted to avoid api breakage)\r\n* use `Base64::strict_encoding` and `Base64::strict_decoding` to avoid the `gsub` call\r\n* delete obsolete functions and a test for one of them\r\n\r\nPotentially controversial:\r\n`unpacked_byte_array` returns an array of `OpenSSL::BN` objects instead of `Bigint`. There were no tests requiring the previous behavior, so I felt free to change it - the function is private anyway and `OpenSSL::BN` is more useful in this case."},"comment":{"url":"https://api.github.com/repos/bensie/sshkey/issues/comments/215307581","html_url":"https://github.com/bensie/sshkey/pull/13#issuecomment-215307581","issue_url":"https://api.github.com/repos/bensie/sshkey/issues/13","id":215307581,"user":{"login":"arnehormann","id":1011413,"avatar_url":"https://avatars.githubusercontent.com/u/1011413?v=3","gravatar_id":"","url":"https://api.github.com/users/arnehormann","html_url":"https://github.com/arnehormann","followers_url":"https://api.github.com/users/arnehormann/followers","following_url":"https://api.github.com/users/arnehormann/following{/other_user}","gists_url":"https://api.github.com/users/arnehormann/gists{/gist_id}","starred_url":"https://api.github.com/users/arnehormann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnehormann/subscriptions","organizations_url":"https://api.github.com/users/arnehormann/orgs","repos_url":"https://api.github.com/users/arnehormann/repos","events_url":"https://api.github.com/users/arnehormann/events{/privacy}","received_events_url":"https://api.github.com/users/arnehormann/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T04:31:16Z","updated_at":"2016-04-28T04:31:16Z","body":"@bensie no, I didn't get around to it. I'd rather wait until TLS 1.3 is finished so openssl has to support ed25519. And then I'd just use that and skip the other EC stuff. I'm using ed25519 keys wherever I can for a while now.\r\nIn other words, stab away 😀 "}}