{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/88669791","pull_request_review_id":9237569,"id":88669791,"diff_hunk":"@@ -64,7 +64,7 @@ public static EntryRecord read( ReadableChannel channel, ChannelMarshal<Replicat\n         }\n         catch ( ReadPastEndException e )\n         {\n-            throw EndOfStreamException.INSTANCE;\n+            throw new EndOfStreamException( e );","path":"enterprise/causal-clustering/src/main/java/org/neo4j/causalclustering/core/consensus/log/EntryRecord.java","position":5,"original_position":5,"commit_id":"ceb411108ca6c8f16b546e0ade3296b5ac59adf3","original_commit_id":"ceb411108ca6c8f16b546e0ade3296b5ac59adf3","user":{"login":"mneedham","id":13220,"avatar_url":"https://avatars.githubusercontent.com/u/13220?v=3","gravatar_id":"","url":"https://api.github.com/users/mneedham","html_url":"https://github.com/mneedham","followers_url":"https://api.github.com/users/mneedham/followers","following_url":"https://api.github.com/users/mneedham/following{/other_user}","gists_url":"https://api.github.com/users/mneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/mneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneedham/subscriptions","organizations_url":"https://api.github.com/users/mneedham/orgs","repos_url":"https://api.github.com/users/mneedham/repos","events_url":"https://api.github.com/users/mneedham/events{/privacy}","received_events_url":"https://api.github.com/users/mneedham/received_events","type":"User","site_admin":false},"body":"We were losing the underlying exception so it wasn't obvious which line threw the ReadPastEndException","created_at":"2016-11-18T14:49:05Z","updated_at":"2016-11-18T14:49:05Z","html_url":"https://github.com/neo4j/neo4j/pull/8397#discussion_r88669791","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8397","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/88669791"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8397#discussion_r88669791"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8397"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/8397","id":94196663,"html_url":"https://github.com/neo4j/neo4j/pull/8397","diff_url":"https://github.com/neo4j/neo4j/pull/8397.diff","patch_url":"https://github.com/neo4j/neo4j/pull/8397.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/8397","number":8397,"state":"open","locked":false,"title":"Fixing store copy to use netty chunking","user":{"login":"mneedham","id":13220,"avatar_url":"https://avatars.githubusercontent.com/u/13220?v=3","gravatar_id":"","url":"https://api.github.com/users/mneedham","html_url":"https://github.com/mneedham","followers_url":"https://api.github.com/users/mneedham/followers","following_url":"https://api.github.com/users/mneedham/following{/other_user}","gists_url":"https://api.github.com/users/mneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/mneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneedham/subscriptions","organizations_url":"https://api.github.com/users/mneedham/orgs","repos_url":"https://api.github.com/users/mneedham/repos","events_url":"https://api.github.com/users/mneedham/events{/privacy}","received_events_url":"https://api.github.com/users/mneedham/received_events","type":"User","site_admin":false},"body":"We're now wiring our chunking into ChunkedInput so\r\nit does chunking at multiple levels. We were previously\r\nhaving a problem where we probably flooded Netty on the\r\nserver side and then nothing would be sent for 5 minutes.\r\n\r\nWith this change we let Netty handle the flow control.","created_at":"2016-11-17T16:05:15Z","updated_at":"2016-11-18T14:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc1168a8506541a360e73978b3158bd8198c01fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8397/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/8397/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/8397/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/ceb411108ca6c8f16b546e0ade3296b5ac59adf3","head":{"label":"mneedham:3.1-chunking-store-copy","ref":"3.1-chunking-store-copy","sha":"ceb411108ca6c8f16b546e0ade3296b5ac59adf3","user":{"login":"mneedham","id":13220,"avatar_url":"https://avatars.githubusercontent.com/u/13220?v=3","gravatar_id":"","url":"https://api.github.com/users/mneedham","html_url":"https://github.com/mneedham","followers_url":"https://api.github.com/users/mneedham/followers","following_url":"https://api.github.com/users/mneedham/following{/other_user}","gists_url":"https://api.github.com/users/mneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/mneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneedham/subscriptions","organizations_url":"https://api.github.com/users/mneedham/orgs","repos_url":"https://api.github.com/users/mneedham/repos","events_url":"https://api.github.com/users/mneedham/events{/privacy}","received_events_url":"https://api.github.com/users/mneedham/received_events","type":"User","site_admin":false},"repo":{"id":8568336,"name":"neo4j","full_name":"mneedham/neo4j","owner":{"login":"mneedham","id":13220,"avatar_url":"https://avatars.githubusercontent.com/u/13220?v=3","gravatar_id":"","url":"https://api.github.com/users/mneedham","html_url":"https://github.com/mneedham","followers_url":"https://api.github.com/users/mneedham/followers","following_url":"https://api.github.com/users/mneedham/following{/other_user}","gists_url":"https://api.github.com/users/mneedham/gists{/gist_id}","starred_url":"https://api.github.com/users/mneedham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneedham/subscriptions","organizations_url":"https://api.github.com/users/mneedham/orgs","repos_url":"https://api.github.com/users/mneedham/repos","events_url":"https://api.github.com/users/mneedham/events{/privacy}","received_events_url":"https://api.github.com/users/mneedham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mneedham/neo4j","description":null,"fork":true,"url":"https://api.github.com/repos/mneedham/neo4j","forks_url":"https://api.github.com/repos/mneedham/neo4j/forks","keys_url":"https://api.github.com/repos/mneedham/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mneedham/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mneedham/neo4j/teams","hooks_url":"https://api.github.com/repos/mneedham/neo4j/hooks","issue_events_url":"https://api.github.com/repos/mneedham/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/mneedham/neo4j/events","assignees_url":"https://api.github.com/repos/mneedham/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/mneedham/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/mneedham/neo4j/tags","blobs_url":"https://api.github.com/repos/mneedham/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mneedham/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mneedham/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/mneedham/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mneedham/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/mneedham/neo4j/languages","stargazers_url":"https://api.github.com/repos/mneedham/neo4j/stargazers","contributors_url":"https://api.github.com/repos/mneedham/neo4j/contributors","subscribers_url":"https://api.github.com/repos/mneedham/neo4j/subscribers","subscription_url":"https://api.github.com/repos/mneedham/neo4j/subscription","commits_url":"https://api.github.com/repos/mneedham/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/mneedham/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/mneedham/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/mneedham/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/mneedham/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/mneedham/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mneedham/neo4j/merges","archive_url":"https://api.github.com/repos/mneedham/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mneedham/neo4j/downloads","issues_url":"https://api.github.com/repos/mneedham/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/mneedham/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/mneedham/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/mneedham/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mneedham/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/mneedham/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/mneedham/neo4j/deployments","created_at":"2013-03-05T00:21:33Z","updated_at":"2014-05-16T14:01:18Z","pushed_at":"2016-11-18T13:43:45Z","git_url":"git://github.com/mneedham/neo4j.git","ssh_url":"git@github.com:mneedham/neo4j.git","clone_url":"https://github.com/mneedham/neo4j.git","svn_url":"https://github.com/mneedham/neo4j","homepage":"http://neo4j.org","size":316083,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"d365ac545b3bd00abcab9a8c34734667d0b9ff6b","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-11-18T12:15:48Z","pushed_at":"2016-11-18T14:46:09Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":387325,"stargazers_count":3213,"watchers_count":3213,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1026,"mirror_url":null,"open_issues_count":402,"forks":1026,"open_issues":402,"watchers":3213,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8397"},"html":{"href":"https://github.com/neo4j/neo4j/pull/8397"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8397"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/8397/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8397/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/8397/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/ceb411108ca6c8f16b546e0ade3296b5ac59adf3"}}}}
{"actor":{"display_login":"mneedham"}}