{"action":"created","comment":{"url":"https://api.github.com/repos/crsmithdev/arrow/pulls/comments/68842413","id":68842413,"diff_hunk":"@@ -88,11 +96,17 @@ def utcnow(cls):\n \n     @classmethod\n     def fromtimestamp(cls, timestamp, tzinfo=None):\n-        ''' Constructs an :class:`Arrow <arrow.arrow.Arrow>` object from a timestamp.\n+        ''' Constructs an :class:`Arrow <arrow.arrow.Arrow>` object from a timestamp, converted to\n+        the given timezone.\n \n         :param timestamp: an ``int`` or ``float`` timestamp, or a ``str`` that converts to either.\n         :param tzinfo: (optional) a ``tzinfo`` object.  Defaults to local time.\n \n+        Timestamps should always be UTC. If you have a non-UTC timestamp::\n+\n+            >>> arrow.Arrow.utcfromtimestamp(1367900664).replace(tzinfo='US/Pacific')\n+            <Arrow [2013-05-07T04:24:24-07:00]>","path":"arrow/arrow.py","position":43,"original_position":43,"commit_id":"6563b8405776de864c1eb74d9bd92bc1bc2bcc53","original_commit_id":"6563b8405776de864c1eb74d9bd92bc1bc2bcc53","user":{"login":"Syeberman","id":4551516,"avatar_url":"https://avatars.githubusercontent.com/u/4551516?v=3","gravatar_id":"","url":"https://api.github.com/users/Syeberman","html_url":"https://github.com/Syeberman","followers_url":"https://api.github.com/users/Syeberman/followers","following_url":"https://api.github.com/users/Syeberman/following{/other_user}","gists_url":"https://api.github.com/users/Syeberman/gists{/gist_id}","starred_url":"https://api.github.com/users/Syeberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syeberman/subscriptions","organizations_url":"https://api.github.com/users/Syeberman/orgs","repos_url":"https://api.github.com/users/Syeberman/repos","events_url":"https://api.github.com/users/Syeberman/events{/privacy}","received_events_url":"https://api.github.com/users/Syeberman/received_events","type":"User","site_admin":false},"body":"This helps to highlight that `tzinfo` replaces the timezone.","created_at":"2016-06-28T21:01:11Z","updated_at":"2016-06-28T21:01:11Z","html_url":"https://github.com/crsmithdev/arrow/pull/342#discussion_r68842413","pull_request_url":"https://api.github.com/repos/crsmithdev/arrow/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/comments/68842413"},"html":{"href":"https://github.com/crsmithdev/arrow/pull/342#discussion_r68842413"},"pull_request":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/crsmithdev/arrow/pulls/342","id":75549225,"html_url":"https://github.com/crsmithdev/arrow/pull/342","diff_url":"https://github.com/crsmithdev/arrow/pull/342.diff","patch_url":"https://github.com/crsmithdev/arrow/pull/342.patch","issue_url":"https://api.github.com/repos/crsmithdev/arrow/issues/342","number":342,"state":"open","locked":false,"title":"Documentation: clarify timezone replacement vs conversion","user":{"login":"Syeberman","id":4551516,"avatar_url":"https://avatars.githubusercontent.com/u/4551516?v=3","gravatar_id":"","url":"https://api.github.com/users/Syeberman","html_url":"https://github.com/Syeberman","followers_url":"https://api.github.com/users/Syeberman/followers","following_url":"https://api.github.com/users/Syeberman/following{/other_user}","gists_url":"https://api.github.com/users/Syeberman/gists{/gist_id}","starred_url":"https://api.github.com/users/Syeberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syeberman/subscriptions","organizations_url":"https://api.github.com/users/Syeberman/orgs","repos_url":"https://api.github.com/users/Syeberman/repos","events_url":"https://api.github.com/users/Syeberman/events{/privacy}","received_events_url":"https://api.github.com/users/Syeberman/received_events","type":"User","site_admin":false},"body":"I'm often confused about which methods perform a timezone conversion (possibly modifying the hour and other attributes) and which simply replace the timezone (leaving all other attributes the same).  So I've updated the documentation to clarify this.\r\n\r\nI've also made other improvements to the documentation, which I'll describe in-line.","created_at":"2016-06-28T20:58:16Z","updated_at":"2016-06-28T21:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9e09361f2ffe21e32b2bdbcff43312a6426a797","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crsmithdev/arrow/pulls/342/commits","review_comments_url":"https://api.github.com/repos/crsmithdev/arrow/pulls/342/comments","review_comment_url":"https://api.github.com/repos/crsmithdev/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crsmithdev/arrow/issues/342/comments","statuses_url":"https://api.github.com/repos/crsmithdev/arrow/statuses/6563b8405776de864c1eb74d9bd92bc1bc2bcc53","head":{"label":"Syeberman:doc_replace_vs_convert","ref":"doc_replace_vs_convert","sha":"6563b8405776de864c1eb74d9bd92bc1bc2bcc53","user":{"login":"Syeberman","id":4551516,"avatar_url":"https://avatars.githubusercontent.com/u/4551516?v=3","gravatar_id":"","url":"https://api.github.com/users/Syeberman","html_url":"https://github.com/Syeberman","followers_url":"https://api.github.com/users/Syeberman/followers","following_url":"https://api.github.com/users/Syeberman/following{/other_user}","gists_url":"https://api.github.com/users/Syeberman/gists{/gist_id}","starred_url":"https://api.github.com/users/Syeberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syeberman/subscriptions","organizations_url":"https://api.github.com/users/Syeberman/orgs","repos_url":"https://api.github.com/users/Syeberman/repos","events_url":"https://api.github.com/users/Syeberman/events{/privacy}","received_events_url":"https://api.github.com/users/Syeberman/received_events","type":"User","site_admin":false},"repo":{"id":61638638,"name":"arrow","full_name":"Syeberman/arrow","owner":{"login":"Syeberman","id":4551516,"avatar_url":"https://avatars.githubusercontent.com/u/4551516?v=3","gravatar_id":"","url":"https://api.github.com/users/Syeberman","html_url":"https://github.com/Syeberman","followers_url":"https://api.github.com/users/Syeberman/followers","following_url":"https://api.github.com/users/Syeberman/following{/other_user}","gists_url":"https://api.github.com/users/Syeberman/gists{/gist_id}","starred_url":"https://api.github.com/users/Syeberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syeberman/subscriptions","organizations_url":"https://api.github.com/users/Syeberman/orgs","repos_url":"https://api.github.com/users/Syeberman/repos","events_url":"https://api.github.com/users/Syeberman/events{/privacy}","received_events_url":"https://api.github.com/users/Syeberman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Syeberman/arrow","description":"Better dates & times for Python","fork":true,"url":"https://api.github.com/repos/Syeberman/arrow","forks_url":"https://api.github.com/repos/Syeberman/arrow/forks","keys_url":"https://api.github.com/repos/Syeberman/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Syeberman/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Syeberman/arrow/teams","hooks_url":"https://api.github.com/repos/Syeberman/arrow/hooks","issue_events_url":"https://api.github.com/repos/Syeberman/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/Syeberman/arrow/events","assignees_url":"https://api.github.com/repos/Syeberman/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/Syeberman/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/Syeberman/arrow/tags","blobs_url":"https://api.github.com/repos/Syeberman/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Syeberman/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Syeberman/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Syeberman/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Syeberman/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/Syeberman/arrow/languages","stargazers_url":"https://api.github.com/repos/Syeberman/arrow/stargazers","contributors_url":"https://api.github.com/repos/Syeberman/arrow/contributors","subscribers_url":"https://api.github.com/repos/Syeberman/arrow/subscribers","subscription_url":"https://api.github.com/repos/Syeberman/arrow/subscription","commits_url":"https://api.github.com/repos/Syeberman/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Syeberman/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Syeberman/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Syeberman/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Syeberman/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/Syeberman/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Syeberman/arrow/merges","archive_url":"https://api.github.com/repos/Syeberman/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Syeberman/arrow/downloads","issues_url":"https://api.github.com/repos/Syeberman/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/Syeberman/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/Syeberman/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/Syeberman/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Syeberman/arrow/labels{/name}","releases_url":"https://api.github.com/repos/Syeberman/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/Syeberman/arrow/deployments","created_at":"2016-06-21T14:04:36Z","updated_at":"2016-06-21T14:04:37Z","pushed_at":"2016-06-28T20:54:55Z","git_url":"git://github.com/Syeberman/arrow.git","ssh_url":"git@github.com:Syeberman/arrow.git","clone_url":"https://github.com/Syeberman/arrow.git","svn_url":"https://github.com/Syeberman/arrow","homepage":"https://arrow.readthedocs.org","size":1699,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crsmithdev:master","ref":"master","sha":"319f2d0651b2832445022fa2d4fa1a57a319b725","user":{"login":"crsmithdev","id":1596037,"avatar_url":"https://avatars.githubusercontent.com/u/1596037?v=3","gravatar_id":"","url":"https://api.github.com/users/crsmithdev","html_url":"https://github.com/crsmithdev","followers_url":"https://api.github.com/users/crsmithdev/followers","following_url":"https://api.github.com/users/crsmithdev/following{/other_user}","gists_url":"https://api.github.com/users/crsmithdev/gists{/gist_id}","starred_url":"https://api.github.com/users/crsmithdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crsmithdev/subscriptions","organizations_url":"https://api.github.com/users/crsmithdev/orgs","repos_url":"https://api.github.com/users/crsmithdev/repos","events_url":"https://api.github.com/users/crsmithdev/events{/privacy}","received_events_url":"https://api.github.com/users/crsmithdev/received_events","type":"User","site_admin":false},"repo":{"id":6750871,"name":"arrow","full_name":"crsmithdev/arrow","owner":{"login":"crsmithdev","id":1596037,"avatar_url":"https://avatars.githubusercontent.com/u/1596037?v=3","gravatar_id":"","url":"https://api.github.com/users/crsmithdev","html_url":"https://github.com/crsmithdev","followers_url":"https://api.github.com/users/crsmithdev/followers","following_url":"https://api.github.com/users/crsmithdev/following{/other_user}","gists_url":"https://api.github.com/users/crsmithdev/gists{/gist_id}","starred_url":"https://api.github.com/users/crsmithdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crsmithdev/subscriptions","organizations_url":"https://api.github.com/users/crsmithdev/orgs","repos_url":"https://api.github.com/users/crsmithdev/repos","events_url":"https://api.github.com/users/crsmithdev/events{/privacy}","received_events_url":"https://api.github.com/users/crsmithdev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crsmithdev/arrow","description":"Better dates & times for Python","fork":false,"url":"https://api.github.com/repos/crsmithdev/arrow","forks_url":"https://api.github.com/repos/crsmithdev/arrow/forks","keys_url":"https://api.github.com/repos/crsmithdev/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crsmithdev/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crsmithdev/arrow/teams","hooks_url":"https://api.github.com/repos/crsmithdev/arrow/hooks","issue_events_url":"https://api.github.com/repos/crsmithdev/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/crsmithdev/arrow/events","assignees_url":"https://api.github.com/repos/crsmithdev/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/crsmithdev/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/crsmithdev/arrow/tags","blobs_url":"https://api.github.com/repos/crsmithdev/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crsmithdev/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crsmithdev/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/crsmithdev/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crsmithdev/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/crsmithdev/arrow/languages","stargazers_url":"https://api.github.com/repos/crsmithdev/arrow/stargazers","contributors_url":"https://api.github.com/repos/crsmithdev/arrow/contributors","subscribers_url":"https://api.github.com/repos/crsmithdev/arrow/subscribers","subscription_url":"https://api.github.com/repos/crsmithdev/arrow/subscription","commits_url":"https://api.github.com/repos/crsmithdev/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/crsmithdev/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/crsmithdev/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/crsmithdev/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/crsmithdev/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/crsmithdev/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crsmithdev/arrow/merges","archive_url":"https://api.github.com/repos/crsmithdev/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crsmithdev/arrow/downloads","issues_url":"https://api.github.com/repos/crsmithdev/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/crsmithdev/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/crsmithdev/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/crsmithdev/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crsmithdev/arrow/labels{/name}","releases_url":"https://api.github.com/repos/crsmithdev/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/crsmithdev/arrow/deployments","created_at":"2012-11-18T20:23:27Z","updated_at":"2016-06-28T19:44:33Z","pushed_at":"2016-06-28T20:58:16Z","git_url":"git://github.com/crsmithdev/arrow.git","ssh_url":"git@github.com:crsmithdev/arrow.git","clone_url":"https://github.com/crsmithdev/arrow.git","svn_url":"https://github.com/crsmithdev/arrow","homepage":"https://arrow.readthedocs.org","size":1669,"stargazers_count":3111,"watchers_count":3111,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":263,"mirror_url":null,"open_issues_count":82,"forks":263,"open_issues":82,"watchers":3111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/342"},"html":{"href":"https://github.com/crsmithdev/arrow/pull/342"},"issue":{"href":"https://api.github.com/repos/crsmithdev/arrow/issues/342"},"comments":{"href":"https://api.github.com/repos/crsmithdev/arrow/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crsmithdev/arrow/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/crsmithdev/arrow/statuses/6563b8405776de864c1eb74d9bd92bc1bc2bcc53"}}}}
{"actor":{"display_login":"Syeberman"}}