{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/77907019","id":77907019,"diff_hunk":"@@ -0,0 +1,438 @@\n+// ---------------------------------------------------------------------\n+//\n+// Copyright (C) 2015 - 2016 by the deal.II authors\n+//\n+// This file is part of the deal.II library.\n+//\n+// The deal.II library is free software; you can use it, redistribute\n+// it, and/or modify it under the terms of the GNU Lesser General\n+// Public License as published by the Free Software Foundation; either\n+// version 2.1 of the License, or (at your option) any later version.\n+// The full text of the license can be found in the file LICENSE at\n+// the top level of the deal.II distribution.\n+//\n+// ---------------------------------------------------------------------\n+\n+\n+#include <deal.II/fe/fe_p1nc.h>\n+\n+DEAL_II_NAMESPACE_OPEN\n+\n+\n+FE_P1NC::FE_P1NC()\n+  :\n+  FiniteElement<2,2>(FiniteElementData<2>(get_dpo_vector(),\n+                                          1,\n+                                          1,\n+                                          FiniteElementData<2>::L2),\n+                     std::vector<bool> (1, false),\n+                     get_nonzero_component())\n+{\n+\n+  // face support points: 2 end vertices\n+  unit_face_support_points.resize(2);\n+  unit_face_support_points[0][0] = 0.0 ;\n+  unit_face_support_points[1][0] = 1.0 ;\n+\n+\n+  // initialize constraints matrix\n+  initialize_constraints () ;\n+}\n+\n+\n+\n+std::string FE_P1NC::get_name () const\n+{\n+  return \"FE_P1NC\";\n+}\n+\n+\n+UpdateFlags     FE_P1NC::requires_update_flags (const UpdateFlags flags) const\n+{\n+  UpdateFlags out = update_default;\n+\n+  if (flags & update_values)\n+    out |= update_values | update_quadrature_points ;\n+  if (flags & update_gradients)\n+    out |= update_gradients ;\n+  if (flags & update_cell_normal_vectors)\n+    out |= update_cell_normal_vectors | update_JxW_values;\n+  if (flags & update_hessians)\n+    out |= update_hessians;\n+  if (flags & update_hessians)\n+    out |= update_hessians;","path":"source/fe/fe_p1nc.cc","position":63,"original_position":63,"commit_id":"121efe69c35d70076cb488f52f8e756c34025b45","original_commit_id":"121efe69c35d70076cb488f52f8e756c34025b45","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars.githubusercontent.com/u/368538?v=3","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"body":"Thes two lines are identical to 60 and 61","created_at":"2016-09-07T21:25:53Z","updated_at":"2016-09-07T21:25:53Z","html_url":"https://github.com/dealii/dealii/pull/2851#discussion_r77907019","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/2851","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/77907019"},"html":{"href":"https://github.com/dealii/dealii/pull/2851#discussion_r77907019"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2851"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2851","id":78440012,"html_url":"https://github.com/dealii/dealii/pull/2851","diff_url":"https://github.com/dealii/dealii/pull/2851.diff","patch_url":"https://github.com/dealii/dealii/pull/2851.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2851","number":2851,"state":"open","locked":false,"title":"P1 nonconforming finite element on quads : FE_P1NC","user":{"login":"JaeryunYim","id":13589524,"avatar_url":"https://avatars.githubusercontent.com/u/13589524?v=3","gravatar_id":"","url":"https://api.github.com/users/JaeryunYim","html_url":"https://github.com/JaeryunYim","followers_url":"https://api.github.com/users/JaeryunYim/followers","following_url":"https://api.github.com/users/JaeryunYim/following{/other_user}","gists_url":"https://api.github.com/users/JaeryunYim/gists{/gist_id}","starred_url":"https://api.github.com/users/JaeryunYim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaeryunYim/subscriptions","organizations_url":"https://api.github.com/users/JaeryunYim/orgs","repos_url":"https://api.github.com/users/JaeryunYim/repos","events_url":"https://api.github.com/users/JaeryunYim/events{/privacy}","received_events_url":"https://api.github.com/users/JaeryunYim/received_events","type":"User","site_admin":false},"body":"This is an implementation for the P1 nonconforming finite element on quadrilaterals (P1NC)\r\nand tests for this element.\r\n\r\nP1NC element consists of only piecewise linear polynomials on each cell even though target cell is a quadrilateral. And it doesn't require the basis on the reference cell because the local basis functions are constructed on each cell independently.\r\n\r\nYou can find the paper about the detail description for P1NC element at\r\nhttp://epubs.siam.org/doi/abs/10.1137/S0036142902404923.\r\n\r\nI think that the current code support the simple problems, but have no idea for the complex cases. \r\n\r\nI hope a lot of comments and suggests about it!\r\n","created_at":"2016-07-22T08:15:57Z","updated_at":"2016-09-07T21:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ab26631c875b624f49f29dd400d43ee26b6366c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/2851/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/2851/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2851/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/121efe69c35d70076cb488f52f8e756c34025b45","head":{"label":"JaeryunYim:master","ref":"master","sha":"121efe69c35d70076cb488f52f8e756c34025b45","user":{"login":"JaeryunYim","id":13589524,"avatar_url":"https://avatars.githubusercontent.com/u/13589524?v=3","gravatar_id":"","url":"https://api.github.com/users/JaeryunYim","html_url":"https://github.com/JaeryunYim","followers_url":"https://api.github.com/users/JaeryunYim/followers","following_url":"https://api.github.com/users/JaeryunYim/following{/other_user}","gists_url":"https://api.github.com/users/JaeryunYim/gists{/gist_id}","starred_url":"https://api.github.com/users/JaeryunYim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaeryunYim/subscriptions","organizations_url":"https://api.github.com/users/JaeryunYim/orgs","repos_url":"https://api.github.com/users/JaeryunYim/repos","events_url":"https://api.github.com/users/JaeryunYim/events{/privacy}","received_events_url":"https://api.github.com/users/JaeryunYim/received_events","type":"User","site_admin":false},"repo":{"id":40010364,"name":"dealii","full_name":"JaeryunYim/dealii","owner":{"login":"JaeryunYim","id":13589524,"avatar_url":"https://avatars.githubusercontent.com/u/13589524?v=3","gravatar_id":"","url":"https://api.github.com/users/JaeryunYim","html_url":"https://github.com/JaeryunYim","followers_url":"https://api.github.com/users/JaeryunYim/followers","following_url":"https://api.github.com/users/JaeryunYim/following{/other_user}","gists_url":"https://api.github.com/users/JaeryunYim/gists{/gist_id}","starred_url":"https://api.github.com/users/JaeryunYim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaeryunYim/subscriptions","organizations_url":"https://api.github.com/users/JaeryunYim/orgs","repos_url":"https://api.github.com/users/JaeryunYim/repos","events_url":"https://api.github.com/users/JaeryunYim/events{/privacy}","received_events_url":"https://api.github.com/users/JaeryunYim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JaeryunYim/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/JaeryunYim/dealii","forks_url":"https://api.github.com/repos/JaeryunYim/dealii/forks","keys_url":"https://api.github.com/repos/JaeryunYim/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JaeryunYim/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JaeryunYim/dealii/teams","hooks_url":"https://api.github.com/repos/JaeryunYim/dealii/hooks","issue_events_url":"https://api.github.com/repos/JaeryunYim/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/JaeryunYim/dealii/events","assignees_url":"https://api.github.com/repos/JaeryunYim/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/JaeryunYim/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/JaeryunYim/dealii/tags","blobs_url":"https://api.github.com/repos/JaeryunYim/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JaeryunYim/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JaeryunYim/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/JaeryunYim/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JaeryunYim/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/JaeryunYim/dealii/languages","stargazers_url":"https://api.github.com/repos/JaeryunYim/dealii/stargazers","contributors_url":"https://api.github.com/repos/JaeryunYim/dealii/contributors","subscribers_url":"https://api.github.com/repos/JaeryunYim/dealii/subscribers","subscription_url":"https://api.github.com/repos/JaeryunYim/dealii/subscription","commits_url":"https://api.github.com/repos/JaeryunYim/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/JaeryunYim/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/JaeryunYim/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/JaeryunYim/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/JaeryunYim/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/JaeryunYim/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JaeryunYim/dealii/merges","archive_url":"https://api.github.com/repos/JaeryunYim/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JaeryunYim/dealii/downloads","issues_url":"https://api.github.com/repos/JaeryunYim/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/JaeryunYim/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/JaeryunYim/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/JaeryunYim/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JaeryunYim/dealii/labels{/name}","releases_url":"https://api.github.com/repos/JaeryunYim/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/JaeryunYim/dealii/deployments","created_at":"2015-07-31T14:56:59Z","updated_at":"2016-01-26T09:59:17Z","pushed_at":"2016-09-01T17:15:01Z","git_url":"git://github.com/JaeryunYim/dealii.git","ssh_url":"git@github.com:JaeryunYim/dealii.git","clone_url":"https://github.com/JaeryunYim/dealii.git","svn_url":"https://github.com/JaeryunYim/dealii","homepage":"http://www.dealii.org/","size":146167,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"70badcaeef55ff8dba0c72728bd53e649ae72bfb","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-09-01T08:48:03Z","pushed_at":"2016-09-07T19:29:39Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":167128,"stargazers_count":169,"watchers_count":169,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":182,"forks":184,"open_issues":182,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2851"},"html":{"href":"https://github.com/dealii/dealii/pull/2851"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/2851"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/2851/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2851/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2851/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/121efe69c35d70076cb488f52f8e756c34025b45"}}}}
{"actor":{"display_login":"Rombur"}}