{"action":"created","comment":{"url":"https://api.github.com/repos/nodeca/mincer/pulls/comments/72264804","id":72264804,"diff_hunk":"@@ -176,6 +176,7 @@ function gzip(data) {\n  *  - `embedMappingComments` (false) - set `true` to embed sourcemap url\n  *    into created files\n  *  - `compress` (false) - set `true` to also create gzipped files\n+ *  - `preventXSSI` (true) - set `false` to skip adding XSSI protection header","path":"lib/mincer/manifest.js","position":4,"original_position":4,"commit_id":"2a7693e900c427842a88931b4818b8644bc9dd34","original_commit_id":"2a7693e900c427842a88931b4818b8644bc9dd34","user":{"login":"puzrin","id":319465,"avatar_url":"https://avatars.githubusercontent.com/u/319465?v=3","gravatar_id":"","url":"https://api.github.com/users/puzrin","html_url":"https://github.com/puzrin","followers_url":"https://api.github.com/users/puzrin/followers","following_url":"https://api.github.com/users/puzrin/following{/other_user}","gists_url":"https://api.github.com/users/puzrin/gists{/gist_id}","starred_url":"https://api.github.com/users/puzrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puzrin/subscriptions","organizations_url":"https://api.github.com/users/puzrin/orgs","repos_url":"https://api.github.com/users/puzrin/repos","events_url":"https://api.github.com/users/puzrin/events{/privacy}","received_events_url":"https://api.github.com/users/puzrin/received_events","type":"User","site_admin":false},"body":"IMHO active inverse flags are dangerous. I'd suggest something like `noSourceMapProtection` (may be need clarification). ","created_at":"2016-07-26T14:50:26Z","updated_at":"2016-07-26T14:50:26Z","html_url":"https://github.com/nodeca/mincer/pull/227#discussion_r72264804","pull_request_url":"https://api.github.com/repos/nodeca/mincer/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/comments/72264804"},"html":{"href":"https://github.com/nodeca/mincer/pull/227#discussion_r72264804"},"pull_request":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/nodeca/mincer/pulls/227","id":78864535,"html_url":"https://github.com/nodeca/mincer/pull/227","diff_url":"https://github.com/nodeca/mincer/pull/227.diff","patch_url":"https://github.com/nodeca/mincer/pull/227.patch","issue_url":"https://api.github.com/repos/nodeca/mincer/issues/227","number":227,"state":"open","locked":false,"title":"Add option to skip XSSI protection header when writing sourcemap to file","user":{"login":"codynguyen","id":252787,"avatar_url":"https://avatars.githubusercontent.com/u/252787?v=3","gravatar_id":"","url":"https://api.github.com/users/codynguyen","html_url":"https://github.com/codynguyen","followers_url":"https://api.github.com/users/codynguyen/followers","following_url":"https://api.github.com/users/codynguyen/following{/other_user}","gists_url":"https://api.github.com/users/codynguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/codynguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codynguyen/subscriptions","organizations_url":"https://api.github.com/users/codynguyen/orgs","repos_url":"https://api.github.com/users/codynguyen/repos","events_url":"https://api.github.com/users/codynguyen/events{/privacy}","received_events_url":"https://api.github.com/users/codynguyen/received_events","type":"User","site_admin":false},"body":"When serving the source map files directly, it is true a protection header is a must. However in certain use cases where we need a valid source map file for some other private reader (Raygun for example), the XSSI protection header turns out to be problematic.\r\n\r\nPlease see the original discussion over at connect-assets: https://github.com/adunkman/connect-assets/issues/345\r\n\r\n","created_at":"2016-07-26T14:44:10Z","updated_at":"2016-07-26T14:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25693a441d6c071fa993af43adfff05b4b198ab7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodeca/mincer/pulls/227/commits","review_comments_url":"https://api.github.com/repos/nodeca/mincer/pulls/227/comments","review_comment_url":"https://api.github.com/repos/nodeca/mincer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodeca/mincer/issues/227/comments","statuses_url":"https://api.github.com/repos/nodeca/mincer/statuses/2a7693e900c427842a88931b4818b8644bc9dd34","head":{"label":"codynguyen:optional-xssi-header","ref":"optional-xssi-header","sha":"2a7693e900c427842a88931b4818b8644bc9dd34","user":{"login":"codynguyen","id":252787,"avatar_url":"https://avatars.githubusercontent.com/u/252787?v=3","gravatar_id":"","url":"https://api.github.com/users/codynguyen","html_url":"https://github.com/codynguyen","followers_url":"https://api.github.com/users/codynguyen/followers","following_url":"https://api.github.com/users/codynguyen/following{/other_user}","gists_url":"https://api.github.com/users/codynguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/codynguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codynguyen/subscriptions","organizations_url":"https://api.github.com/users/codynguyen/orgs","repos_url":"https://api.github.com/users/codynguyen/repos","events_url":"https://api.github.com/users/codynguyen/events{/privacy}","received_events_url":"https://api.github.com/users/codynguyen/received_events","type":"User","site_admin":false},"repo":{"id":43701836,"name":"mincer","full_name":"codynguyen/mincer","owner":{"login":"codynguyen","id":252787,"avatar_url":"https://avatars.githubusercontent.com/u/252787?v=3","gravatar_id":"","url":"https://api.github.com/users/codynguyen","html_url":"https://github.com/codynguyen","followers_url":"https://api.github.com/users/codynguyen/followers","following_url":"https://api.github.com/users/codynguyen/following{/other_user}","gists_url":"https://api.github.com/users/codynguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/codynguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codynguyen/subscriptions","organizations_url":"https://api.github.com/users/codynguyen/orgs","repos_url":"https://api.github.com/users/codynguyen/repos","events_url":"https://api.github.com/users/codynguyen/events{/privacy}","received_events_url":"https://api.github.com/users/codynguyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codynguyen/mincer","description":"Sprockets inspired web assets compiler for Node.JS","fork":true,"url":"https://api.github.com/repos/codynguyen/mincer","forks_url":"https://api.github.com/repos/codynguyen/mincer/forks","keys_url":"https://api.github.com/repos/codynguyen/mincer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codynguyen/mincer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codynguyen/mincer/teams","hooks_url":"https://api.github.com/repos/codynguyen/mincer/hooks","issue_events_url":"https://api.github.com/repos/codynguyen/mincer/issues/events{/number}","events_url":"https://api.github.com/repos/codynguyen/mincer/events","assignees_url":"https://api.github.com/repos/codynguyen/mincer/assignees{/user}","branches_url":"https://api.github.com/repos/codynguyen/mincer/branches{/branch}","tags_url":"https://api.github.com/repos/codynguyen/mincer/tags","blobs_url":"https://api.github.com/repos/codynguyen/mincer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codynguyen/mincer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codynguyen/mincer/git/refs{/sha}","trees_url":"https://api.github.com/repos/codynguyen/mincer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codynguyen/mincer/statuses/{sha}","languages_url":"https://api.github.com/repos/codynguyen/mincer/languages","stargazers_url":"https://api.github.com/repos/codynguyen/mincer/stargazers","contributors_url":"https://api.github.com/repos/codynguyen/mincer/contributors","subscribers_url":"https://api.github.com/repos/codynguyen/mincer/subscribers","subscription_url":"https://api.github.com/repos/codynguyen/mincer/subscription","commits_url":"https://api.github.com/repos/codynguyen/mincer/commits{/sha}","git_commits_url":"https://api.github.com/repos/codynguyen/mincer/git/commits{/sha}","comments_url":"https://api.github.com/repos/codynguyen/mincer/comments{/number}","issue_comment_url":"https://api.github.com/repos/codynguyen/mincer/issues/comments{/number}","contents_url":"https://api.github.com/repos/codynguyen/mincer/contents/{+path}","compare_url":"https://api.github.com/repos/codynguyen/mincer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codynguyen/mincer/merges","archive_url":"https://api.github.com/repos/codynguyen/mincer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codynguyen/mincer/downloads","issues_url":"https://api.github.com/repos/codynguyen/mincer/issues{/number}","pulls_url":"https://api.github.com/repos/codynguyen/mincer/pulls{/number}","milestones_url":"https://api.github.com/repos/codynguyen/mincer/milestones{/number}","notifications_url":"https://api.github.com/repos/codynguyen/mincer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codynguyen/mincer/labels{/name}","releases_url":"https://api.github.com/repos/codynguyen/mincer/releases{/id}","deployments_url":"https://api.github.com/repos/codynguyen/mincer/deployments","created_at":"2015-10-05T17:34:43Z","updated_at":"2016-07-26T14:28:54Z","pushed_at":"2016-07-26T14:40:46Z","git_url":"git://github.com/codynguyen/mincer.git","ssh_url":"git@github.com:codynguyen/mincer.git","clone_url":"https://github.com/codynguyen/mincer.git","svn_url":"https://github.com/codynguyen/mincer","homepage":"http://nodeca.github.com/mincer/","size":1526,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodeca:master","ref":"master","sha":"71465d340b417131251fc1ff38e096208f9473f9","user":{"login":"nodeca","id":723678,"avatar_url":"https://avatars.githubusercontent.com/u/723678?v=3","gravatar_id":"","url":"https://api.github.com/users/nodeca","html_url":"https://github.com/nodeca","followers_url":"https://api.github.com/users/nodeca/followers","following_url":"https://api.github.com/users/nodeca/following{/other_user}","gists_url":"https://api.github.com/users/nodeca/gists{/gist_id}","starred_url":"https://api.github.com/users/nodeca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodeca/subscriptions","organizations_url":"https://api.github.com/users/nodeca/orgs","repos_url":"https://api.github.com/users/nodeca/repos","events_url":"https://api.github.com/users/nodeca/events{/privacy}","received_events_url":"https://api.github.com/users/nodeca/received_events","type":"Organization","site_admin":false},"repo":{"id":4079740,"name":"mincer","full_name":"nodeca/mincer","owner":{"login":"nodeca","id":723678,"avatar_url":"https://avatars.githubusercontent.com/u/723678?v=3","gravatar_id":"","url":"https://api.github.com/users/nodeca","html_url":"https://github.com/nodeca","followers_url":"https://api.github.com/users/nodeca/followers","following_url":"https://api.github.com/users/nodeca/following{/other_user}","gists_url":"https://api.github.com/users/nodeca/gists{/gist_id}","starred_url":"https://api.github.com/users/nodeca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodeca/subscriptions","organizations_url":"https://api.github.com/users/nodeca/orgs","repos_url":"https://api.github.com/users/nodeca/repos","events_url":"https://api.github.com/users/nodeca/events{/privacy}","received_events_url":"https://api.github.com/users/nodeca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodeca/mincer","description":"Sprockets inspired web assets compiler for Node.JS","fork":false,"url":"https://api.github.com/repos/nodeca/mincer","forks_url":"https://api.github.com/repos/nodeca/mincer/forks","keys_url":"https://api.github.com/repos/nodeca/mincer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodeca/mincer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodeca/mincer/teams","hooks_url":"https://api.github.com/repos/nodeca/mincer/hooks","issue_events_url":"https://api.github.com/repos/nodeca/mincer/issues/events{/number}","events_url":"https://api.github.com/repos/nodeca/mincer/events","assignees_url":"https://api.github.com/repos/nodeca/mincer/assignees{/user}","branches_url":"https://api.github.com/repos/nodeca/mincer/branches{/branch}","tags_url":"https://api.github.com/repos/nodeca/mincer/tags","blobs_url":"https://api.github.com/repos/nodeca/mincer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodeca/mincer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodeca/mincer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodeca/mincer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodeca/mincer/statuses/{sha}","languages_url":"https://api.github.com/repos/nodeca/mincer/languages","stargazers_url":"https://api.github.com/repos/nodeca/mincer/stargazers","contributors_url":"https://api.github.com/repos/nodeca/mincer/contributors","subscribers_url":"https://api.github.com/repos/nodeca/mincer/subscribers","subscription_url":"https://api.github.com/repos/nodeca/mincer/subscription","commits_url":"https://api.github.com/repos/nodeca/mincer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodeca/mincer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodeca/mincer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodeca/mincer/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodeca/mincer/contents/{+path}","compare_url":"https://api.github.com/repos/nodeca/mincer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodeca/mincer/merges","archive_url":"https://api.github.com/repos/nodeca/mincer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodeca/mincer/downloads","issues_url":"https://api.github.com/repos/nodeca/mincer/issues{/number}","pulls_url":"https://api.github.com/repos/nodeca/mincer/pulls{/number}","milestones_url":"https://api.github.com/repos/nodeca/mincer/milestones{/number}","notifications_url":"https://api.github.com/repos/nodeca/mincer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodeca/mincer/labels{/name}","releases_url":"https://api.github.com/repos/nodeca/mincer/releases{/id}","deployments_url":"https://api.github.com/repos/nodeca/mincer/deployments","created_at":"2012-04-19T20:13:14Z","updated_at":"2016-07-25T17:50:25Z","pushed_at":"2016-07-26T14:44:10Z","git_url":"git://github.com/nodeca/mincer.git","ssh_url":"git@github.com:nodeca/mincer.git","clone_url":"https://github.com/nodeca/mincer.git","svn_url":"https://github.com/nodeca/mincer","homepage":"http://nodeca.github.com/mincer/","size":1915,"stargazers_count":608,"watchers_count":608,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":5,"forks":64,"open_issues":5,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/227"},"html":{"href":"https://github.com/nodeca/mincer/pull/227"},"issue":{"href":"https://api.github.com/repos/nodeca/mincer/issues/227"},"comments":{"href":"https://api.github.com/repos/nodeca/mincer/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodeca/mincer/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/nodeca/mincer/statuses/2a7693e900c427842a88931b4818b8644bc9dd34"}}}}
{"actor":{"display_login":"puzrin"}}