{"action":"closed","number":1947,"pull_request":{"url":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947","id":81903364,"html_url":"https://github.com/xpressengine/xe-core/pull/1947","diff_url":"https://github.com/xpressengine/xe-core/pull/1947.diff","patch_url":"https://github.com/xpressengine/xe-core/pull/1947.patch","issue_url":"https://api.github.com/repos/xpressengine/xe-core/issues/1947","number":1947,"state":"closed","locked":false,"title":"디버그의 기능을 추가합니다.","user":{"login":"bjrambo","id":4381756,"avatar_url":"https://avatars.githubusercontent.com/u/4381756?v=3","gravatar_id":"","url":"https://api.github.com/users/bjrambo","html_url":"https://github.com/bjrambo","followers_url":"https://api.github.com/users/bjrambo/followers","following_url":"https://api.github.com/users/bjrambo/following{/other_user}","gists_url":"https://api.github.com/users/bjrambo/gists{/gist_id}","starred_url":"https://api.github.com/users/bjrambo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjrambo/subscriptions","organizations_url":"https://api.github.com/users/bjrambo/orgs","repos_url":"https://api.github.com/users/bjrambo/repos","events_url":"https://api.github.com/users/bjrambo/events{/privacy}","received_events_url":"https://api.github.com/users/bjrambo/received_events","type":"User","site_admin":false},"body":"라이믹스 만큼은 안되지만, 디버그 기능을 개선하고 에러로그기능을 추가합니다.\r\n\r\n기존의  #1872 에서 @kijin 님의 의견에 따라 기존의 error로그 부분에 치명적인 에러도 기록할 수 있도록 개선하고\r\n현재의 가독성이 떨어지는 디버그 항목을 좀 더 개선하여 가독성을 유리하도록 하는것이 목표입니다.\r\n\r\n디버그 기능의 원활한 사용을 위해서는 다음과 같은 추가작업이 필요합니다.\r\n`xe/config/config.user.inc.php`\r\n파일에서 `define('__ERROR_LOG__', 1);`\r\n을 추가해야 하며, `__DEBUG_PROTECT__`, 의 설정에 따라 1일경우 `__DEBUG_PROTECT_IP__`을 정상적으로 재대로 세팅을 하고, 지정된 아이피에서만 출력되도록 설정되어있습니다.\r\n\r\n더불어 이 기능이 어디서 어떻게 실행되오는 과정(stack trace)기능을 추가합니다.\r\n\r\n`stack trace` 기능의 경우 현재 XE의 필수 설치요건의 PHP버전의 최소값보다 약간 높은 버전에서 사용이 가능한 `debug_backtrace`함수를 이용함으로 이기능은 PHP5.3.6 이상에서만 가능합니다...\r\nPHP 5.3.6 이하의 경우 `debug_backtrace` 내용을 제외한 기능을 추가하는것으로 목표를 잡고 작업을 진행하도록 하겠습니다.\r\n\r\n* [x] 기본 에러 및 치명적인 에러 로그를 debug_message.php 에 함께 추가하도록 개선.\r\n* [x] debug_backtrace 함수를 이용하여 trace 기능을 추가.\r\n* [x] debugPrint의 내용들을 가독성있게 출력하도록 개선.","created_at":"2016-08-18T23:09:20Z","updated_at":"2016-08-30T06:05:41Z","closed_at":"2016-08-30T06:05:40Z","merged_at":"2016-08-30T06:05:40Z","merge_commit_sha":"3cb0fc8dd94295981bde7b8220b99fa91cc396a1","assignee":{"login":"bnu","id":53764,"avatar_url":"https://avatars.githubusercontent.com/u/53764?v=3","gravatar_id":"","url":"https://api.github.com/users/bnu","html_url":"https://github.com/bnu","followers_url":"https://api.github.com/users/bnu/followers","following_url":"https://api.github.com/users/bnu/following{/other_user}","gists_url":"https://api.github.com/users/bnu/gists{/gist_id}","starred_url":"https://api.github.com/users/bnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnu/subscriptions","organizations_url":"https://api.github.com/users/bnu/orgs","repos_url":"https://api.github.com/users/bnu/repos","events_url":"https://api.github.com/users/bnu/events{/privacy}","received_events_url":"https://api.github.com/users/bnu/received_events","type":"User","site_admin":false},"assignees":[{"login":"bnu","id":53764,"avatar_url":"https://avatars.githubusercontent.com/u/53764?v=3","gravatar_id":"","url":"https://api.github.com/users/bnu","html_url":"https://github.com/bnu","followers_url":"https://api.github.com/users/bnu/followers","following_url":"https://api.github.com/users/bnu/following{/other_user}","gists_url":"https://api.github.com/users/bnu/gists{/gist_id}","starred_url":"https://api.github.com/users/bnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnu/subscriptions","organizations_url":"https://api.github.com/users/bnu/orgs","repos_url":"https://api.github.com/users/bnu/repos","events_url":"https://api.github.com/users/bnu/events{/privacy}","received_events_url":"https://api.github.com/users/bnu/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xpressengine/xe-core/milestones/49","html_url":"https://github.com/xpressengine/xe-core/milestones/1.8.25","labels_url":"https://api.github.com/repos/xpressengine/xe-core/milestones/49/labels","id":1922797,"number":49,"title":"1.8.25","description":"","creator":{"login":"bnu","id":53764,"avatar_url":"https://avatars.githubusercontent.com/u/53764?v=3","gravatar_id":"","url":"https://api.github.com/users/bnu","html_url":"https://github.com/bnu","followers_url":"https://api.github.com/users/bnu/followers","following_url":"https://api.github.com/users/bnu/following{/other_user}","gists_url":"https://api.github.com/users/bnu/gists{/gist_id}","starred_url":"https://api.github.com/users/bnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnu/subscriptions","organizations_url":"https://api.github.com/users/bnu/orgs","repos_url":"https://api.github.com/users/bnu/repos","events_url":"https://api.github.com/users/bnu/events{/privacy}","received_events_url":"https://api.github.com/users/bnu/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"open","created_at":"2016-08-04T04:04:45Z","updated_at":"2016-08-30T06:05:40Z","due_on":"2016-09-11T15:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947/commits","review_comments_url":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947/comments","review_comment_url":"https://api.github.com/repos/xpressengine/xe-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xpressengine/xe-core/issues/1947/comments","statuses_url":"https://api.github.com/repos/xpressengine/xe-core/statuses/659a333277f2cc93bde022ce02658ade5ac3803a","head":{"label":"bjrambo:pr/debug-errorlog","ref":"pr/debug-errorlog","sha":"659a333277f2cc93bde022ce02658ade5ac3803a","user":{"login":"bjrambo","id":4381756,"avatar_url":"https://avatars.githubusercontent.com/u/4381756?v=3","gravatar_id":"","url":"https://api.github.com/users/bjrambo","html_url":"https://github.com/bjrambo","followers_url":"https://api.github.com/users/bjrambo/followers","following_url":"https://api.github.com/users/bjrambo/following{/other_user}","gists_url":"https://api.github.com/users/bjrambo/gists{/gist_id}","starred_url":"https://api.github.com/users/bjrambo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjrambo/subscriptions","organizations_url":"https://api.github.com/users/bjrambo/orgs","repos_url":"https://api.github.com/users/bjrambo/repos","events_url":"https://api.github.com/users/bjrambo/events{/privacy}","received_events_url":"https://api.github.com/users/bjrambo/received_events","type":"User","site_admin":false},"repo":{"id":66032937,"name":"xe-core","full_name":"bjrambo/xe-core","owner":{"login":"bjrambo","id":4381756,"avatar_url":"https://avatars.githubusercontent.com/u/4381756?v=3","gravatar_id":"","url":"https://api.github.com/users/bjrambo","html_url":"https://github.com/bjrambo","followers_url":"https://api.github.com/users/bjrambo/followers","following_url":"https://api.github.com/users/bjrambo/following{/other_user}","gists_url":"https://api.github.com/users/bjrambo/gists{/gist_id}","starred_url":"https://api.github.com/users/bjrambo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjrambo/subscriptions","organizations_url":"https://api.github.com/users/bjrambo/orgs","repos_url":"https://api.github.com/users/bjrambo/repos","events_url":"https://api.github.com/users/bjrambo/events{/privacy}","received_events_url":"https://api.github.com/users/bjrambo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjrambo/xe-core","description":"PHP Open Source CMS","fork":true,"url":"https://api.github.com/repos/bjrambo/xe-core","forks_url":"https://api.github.com/repos/bjrambo/xe-core/forks","keys_url":"https://api.github.com/repos/bjrambo/xe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjrambo/xe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjrambo/xe-core/teams","hooks_url":"https://api.github.com/repos/bjrambo/xe-core/hooks","issue_events_url":"https://api.github.com/repos/bjrambo/xe-core/issues/events{/number}","events_url":"https://api.github.com/repos/bjrambo/xe-core/events","assignees_url":"https://api.github.com/repos/bjrambo/xe-core/assignees{/user}","branches_url":"https://api.github.com/repos/bjrambo/xe-core/branches{/branch}","tags_url":"https://api.github.com/repos/bjrambo/xe-core/tags","blobs_url":"https://api.github.com/repos/bjrambo/xe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjrambo/xe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjrambo/xe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjrambo/xe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjrambo/xe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bjrambo/xe-core/languages","stargazers_url":"https://api.github.com/repos/bjrambo/xe-core/stargazers","contributors_url":"https://api.github.com/repos/bjrambo/xe-core/contributors","subscribers_url":"https://api.github.com/repos/bjrambo/xe-core/subscribers","subscription_url":"https://api.github.com/repos/bjrambo/xe-core/subscription","commits_url":"https://api.github.com/repos/bjrambo/xe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjrambo/xe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjrambo/xe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjrambo/xe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjrambo/xe-core/contents/{+path}","compare_url":"https://api.github.com/repos/bjrambo/xe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjrambo/xe-core/merges","archive_url":"https://api.github.com/repos/bjrambo/xe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjrambo/xe-core/downloads","issues_url":"https://api.github.com/repos/bjrambo/xe-core/issues{/number}","pulls_url":"https://api.github.com/repos/bjrambo/xe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bjrambo/xe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bjrambo/xe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjrambo/xe-core/labels{/name}","releases_url":"https://api.github.com/repos/bjrambo/xe-core/releases{/id}","deployments_url":"https://api.github.com/repos/bjrambo/xe-core/deployments","created_at":"2016-08-18T21:50:07Z","updated_at":"2016-08-18T21:50:14Z","pushed_at":"2016-08-20T03:29:23Z","git_url":"git://github.com/bjrambo/xe-core.git","ssh_url":"git@github.com:bjrambo/xe-core.git","clone_url":"https://github.com/bjrambo/xe-core.git","svn_url":"https://github.com/bjrambo/xe-core","homepage":"https://www.xpressengine.com","size":85222,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"xpressengine:develop","ref":"develop","sha":"237fa9040d81716e2bfbe6dab1153af0ce0f6b94","user":{"login":"xpressengine","id":1429259,"avatar_url":"https://avatars.githubusercontent.com/u/1429259?v=3","gravatar_id":"","url":"https://api.github.com/users/xpressengine","html_url":"https://github.com/xpressengine","followers_url":"https://api.github.com/users/xpressengine/followers","following_url":"https://api.github.com/users/xpressengine/following{/other_user}","gists_url":"https://api.github.com/users/xpressengine/gists{/gist_id}","starred_url":"https://api.github.com/users/xpressengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpressengine/subscriptions","organizations_url":"https://api.github.com/users/xpressengine/orgs","repos_url":"https://api.github.com/users/xpressengine/repos","events_url":"https://api.github.com/users/xpressengine/events{/privacy}","received_events_url":"https://api.github.com/users/xpressengine/received_events","type":"Organization","site_admin":false},"repo":{"id":7953576,"name":"xe-core","full_name":"xpressengine/xe-core","owner":{"login":"xpressengine","id":1429259,"avatar_url":"https://avatars.githubusercontent.com/u/1429259?v=3","gravatar_id":"","url":"https://api.github.com/users/xpressengine","html_url":"https://github.com/xpressengine","followers_url":"https://api.github.com/users/xpressengine/followers","following_url":"https://api.github.com/users/xpressengine/following{/other_user}","gists_url":"https://api.github.com/users/xpressengine/gists{/gist_id}","starred_url":"https://api.github.com/users/xpressengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpressengine/subscriptions","organizations_url":"https://api.github.com/users/xpressengine/orgs","repos_url":"https://api.github.com/users/xpressengine/repos","events_url":"https://api.github.com/users/xpressengine/events{/privacy}","received_events_url":"https://api.github.com/users/xpressengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xpressengine/xe-core","description":"XpressEngine 1.x","fork":false,"url":"https://api.github.com/repos/xpressengine/xe-core","forks_url":"https://api.github.com/repos/xpressengine/xe-core/forks","keys_url":"https://api.github.com/repos/xpressengine/xe-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xpressengine/xe-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xpressengine/xe-core/teams","hooks_url":"https://api.github.com/repos/xpressengine/xe-core/hooks","issue_events_url":"https://api.github.com/repos/xpressengine/xe-core/issues/events{/number}","events_url":"https://api.github.com/repos/xpressengine/xe-core/events","assignees_url":"https://api.github.com/repos/xpressengine/xe-core/assignees{/user}","branches_url":"https://api.github.com/repos/xpressengine/xe-core/branches{/branch}","tags_url":"https://api.github.com/repos/xpressengine/xe-core/tags","blobs_url":"https://api.github.com/repos/xpressengine/xe-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xpressengine/xe-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xpressengine/xe-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xpressengine/xe-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xpressengine/xe-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xpressengine/xe-core/languages","stargazers_url":"https://api.github.com/repos/xpressengine/xe-core/stargazers","contributors_url":"https://api.github.com/repos/xpressengine/xe-core/contributors","subscribers_url":"https://api.github.com/repos/xpressengine/xe-core/subscribers","subscription_url":"https://api.github.com/repos/xpressengine/xe-core/subscription","commits_url":"https://api.github.com/repos/xpressengine/xe-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xpressengine/xe-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xpressengine/xe-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xpressengine/xe-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xpressengine/xe-core/contents/{+path}","compare_url":"https://api.github.com/repos/xpressengine/xe-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xpressengine/xe-core/merges","archive_url":"https://api.github.com/repos/xpressengine/xe-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xpressengine/xe-core/downloads","issues_url":"https://api.github.com/repos/xpressengine/xe-core/issues{/number}","pulls_url":"https://api.github.com/repos/xpressengine/xe-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xpressengine/xe-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xpressengine/xe-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xpressengine/xe-core/labels{/name}","releases_url":"https://api.github.com/repos/xpressengine/xe-core/releases{/id}","deployments_url":"https://api.github.com/repos/xpressengine/xe-core/deployments","created_at":"2013-02-01T07:16:05Z","updated_at":"2016-08-29T01:43:42Z","pushed_at":"2016-08-30T06:05:41Z","git_url":"git://github.com/xpressengine/xe-core.git","ssh_url":"git@github.com:xpressengine/xe-core.git","clone_url":"https://github.com/xpressengine/xe-core.git","svn_url":"https://github.com/xpressengine/xe-core","homepage":"https://www.xpressengine.com","size":99478,"stargazers_count":249,"watchers_count":249,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":338,"forks":227,"open_issues":338,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947"},"html":{"href":"https://github.com/xpressengine/xe-core/pull/1947"},"issue":{"href":"https://api.github.com/repos/xpressengine/xe-core/issues/1947"},"comments":{"href":"https://api.github.com/repos/xpressengine/xe-core/issues/1947/comments"},"review_comments":{"href":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947/comments"},"review_comment":{"href":"https://api.github.com/repos/xpressengine/xe-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xpressengine/xe-core/pulls/1947/commits"},"statuses":{"href":"https://api.github.com/repos/xpressengine/xe-core/statuses/659a333277f2cc93bde022ce02658ade5ac3803a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bnu","id":53764,"avatar_url":"https://avatars.githubusercontent.com/u/53764?v=3","gravatar_id":"","url":"https://api.github.com/users/bnu","html_url":"https://github.com/bnu","followers_url":"https://api.github.com/users/bnu/followers","following_url":"https://api.github.com/users/bnu/following{/other_user}","gists_url":"https://api.github.com/users/bnu/gists{/gist_id}","starred_url":"https://api.github.com/users/bnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnu/subscriptions","organizations_url":"https://api.github.com/users/bnu/orgs","repos_url":"https://api.github.com/users/bnu/repos","events_url":"https://api.github.com/users/bnu/events{/privacy}","received_events_url":"https://api.github.com/users/bnu/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":5,"additions":129,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"bnu"}}