{"action":"opened","number":58,"pull_request":{"url":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58","id":65720372,"html_url":"https://github.com/jonesguy14/footballcoach/pull/58","diff_url":"https://github.com/jonesguy14/footballcoach/pull/58.diff","patch_url":"https://github.com/jonesguy14/footballcoach/pull/58.patch","issue_url":"https://api.github.com/repos/jonesguy14/footballcoach/issues/58","number":58,"state":"open","locked":false,"title":"Completed story about upperclassmen hazing and scaring off recruit","user":{"login":"destilla","id":11052658,"avatar_url":"https://avatars.githubusercontent.com/u/11052658?v=3","gravatar_id":"","url":"https://api.github.com/users/destilla","html_url":"https://github.com/destilla","followers_url":"https://api.github.com/users/destilla/followers","following_url":"https://api.github.com/users/destilla/following{/other_user}","gists_url":"https://api.github.com/users/destilla/gists{/gist_id}","starred_url":"https://api.github.com/users/destilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destilla/subscriptions","organizations_url":"https://api.github.com/users/destilla/orgs","repos_url":"https://api.github.com/users/destilla/repos","events_url":"https://api.github.com/users/destilla/events{/privacy}","received_events_url":"https://api.github.com/users/destilla/received_events","type":"User","site_admin":false},"body":"Story progresses from Weeks 0 to 2 and essentially goes: Player implicates himself as ring leader and user is informed that one saveCurse's rival's Freshman is a flip commit from saveCurse resulting from the hazing, following week it's reported that no players missed time and the coach is silent, final week (2) there's a 50/50 chance to have the coach release a statement saying nothing or that the team will be responsible for giving back to the community.\r\n\r\nSlightly restructured the switch statement for developing stories to allow for more flexibility in having multi week stories (previously you could only have one extra story appear on the week you specified). Stories can now be set to appear whenever by indicating how far beyond the original development the new story should appear.\r\n\r\nFinally, introduced Arraylists containing players grouped by class status (FR, SO, JR, etc) for use in stats, news stories, etc. Currently these arraylists are only populated with the player's class, name, and position and exist separately from the arraylists for each position (PlayerQBs, PlayerCBs, etc).\r\n\r\nThoughts: Is there a cleaner way to handle finding specific freshman/sophomore/etc players on a team rather than grouping them together? Or is grouping them fine (i.e. not too expensive and doesn't make the code confusing). Also I'm basically making any variable I need to reference later or in another .java file public. Not sure if this is the correct practice or if there's anything dangerous about this, etc. As usual, noobie coder so I'm not familiar with many best practices.\r\n\r\n\r\nExtra note: I had the WORST time trying to merge this. I accidentally forgot to pull your changes to my fork before committing mine, so Github wouldn't let me auto merge my new stuff. Sooooo, I had to do all of this by hand. I've double checked for issues but if something even looks kind of strange, please ask if I meant for that.","created_at":"2016-04-08T00:18:45Z","updated_at":"2016-04-08T00:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58/commits","review_comments_url":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58/comments","review_comment_url":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonesguy14/footballcoach/issues/58/comments","statuses_url":"https://api.github.com/repos/jonesguy14/footballcoach/statuses/264dc9f602a82f449856563d66b1434b441e631d","head":{"label":"destilla:patch-1","ref":"patch-1","sha":"264dc9f602a82f449856563d66b1434b441e631d","user":{"login":"destilla","id":11052658,"avatar_url":"https://avatars.githubusercontent.com/u/11052658?v=3","gravatar_id":"","url":"https://api.github.com/users/destilla","html_url":"https://github.com/destilla","followers_url":"https://api.github.com/users/destilla/followers","following_url":"https://api.github.com/users/destilla/following{/other_user}","gists_url":"https://api.github.com/users/destilla/gists{/gist_id}","starred_url":"https://api.github.com/users/destilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destilla/subscriptions","organizations_url":"https://api.github.com/users/destilla/orgs","repos_url":"https://api.github.com/users/destilla/repos","events_url":"https://api.github.com/users/destilla/events{/privacy}","received_events_url":"https://api.github.com/users/destilla/received_events","type":"User","site_admin":false},"repo":{"id":54420114,"name":"footballcoach","full_name":"destilla/footballcoach","owner":{"login":"destilla","id":11052658,"avatar_url":"https://avatars.githubusercontent.com/u/11052658?v=3","gravatar_id":"","url":"https://api.github.com/users/destilla","html_url":"https://github.com/destilla","followers_url":"https://api.github.com/users/destilla/followers","following_url":"https://api.github.com/users/destilla/following{/other_user}","gists_url":"https://api.github.com/users/destilla/gists{/gist_id}","starred_url":"https://api.github.com/users/destilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destilla/subscriptions","organizations_url":"https://api.github.com/users/destilla/orgs","repos_url":"https://api.github.com/users/destilla/repos","events_url":"https://api.github.com/users/destilla/events{/privacy}","received_events_url":"https://api.github.com/users/destilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/destilla/footballcoach","description":"My fork of jonesguys14's awesome app Football Coach","fork":true,"url":"https://api.github.com/repos/destilla/footballcoach","forks_url":"https://api.github.com/repos/destilla/footballcoach/forks","keys_url":"https://api.github.com/repos/destilla/footballcoach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/destilla/footballcoach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/destilla/footballcoach/teams","hooks_url":"https://api.github.com/repos/destilla/footballcoach/hooks","issue_events_url":"https://api.github.com/repos/destilla/footballcoach/issues/events{/number}","events_url":"https://api.github.com/repos/destilla/footballcoach/events","assignees_url":"https://api.github.com/repos/destilla/footballcoach/assignees{/user}","branches_url":"https://api.github.com/repos/destilla/footballcoach/branches{/branch}","tags_url":"https://api.github.com/repos/destilla/footballcoach/tags","blobs_url":"https://api.github.com/repos/destilla/footballcoach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/destilla/footballcoach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/destilla/footballcoach/git/refs{/sha}","trees_url":"https://api.github.com/repos/destilla/footballcoach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/destilla/footballcoach/statuses/{sha}","languages_url":"https://api.github.com/repos/destilla/footballcoach/languages","stargazers_url":"https://api.github.com/repos/destilla/footballcoach/stargazers","contributors_url":"https://api.github.com/repos/destilla/footballcoach/contributors","subscribers_url":"https://api.github.com/repos/destilla/footballcoach/subscribers","subscription_url":"https://api.github.com/repos/destilla/footballcoach/subscription","commits_url":"https://api.github.com/repos/destilla/footballcoach/commits{/sha}","git_commits_url":"https://api.github.com/repos/destilla/footballcoach/git/commits{/sha}","comments_url":"https://api.github.com/repos/destilla/footballcoach/comments{/number}","issue_comment_url":"https://api.github.com/repos/destilla/footballcoach/issues/comments{/number}","contents_url":"https://api.github.com/repos/destilla/footballcoach/contents/{+path}","compare_url":"https://api.github.com/repos/destilla/footballcoach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/destilla/footballcoach/merges","archive_url":"https://api.github.com/repos/destilla/footballcoach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/destilla/footballcoach/downloads","issues_url":"https://api.github.com/repos/destilla/footballcoach/issues{/number}","pulls_url":"https://api.github.com/repos/destilla/footballcoach/pulls{/number}","milestones_url":"https://api.github.com/repos/destilla/footballcoach/milestones{/number}","notifications_url":"https://api.github.com/repos/destilla/footballcoach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/destilla/footballcoach/labels{/name}","releases_url":"https://api.github.com/repos/destilla/footballcoach/releases{/id}","deployments_url":"https://api.github.com/repos/destilla/footballcoach/deployments","created_at":"2016-03-21T20:24:28Z","updated_at":"2016-03-26T21:04:55Z","pushed_at":"2016-04-08T00:15:33Z","git_url":"git://github.com/destilla/footballcoach.git","ssh_url":"git@github.com:destilla/footballcoach.git","clone_url":"https://github.com/destilla/footballcoach.git","svn_url":"https://github.com/destilla/footballcoach","homepage":"","size":22393,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jonesguy14:master","ref":"master","sha":"6b386dd4dae76b1f318fb09a801c5f0326ae5b5b","user":{"login":"jonesguy14","id":5642625,"avatar_url":"https://avatars.githubusercontent.com/u/5642625?v=3","gravatar_id":"","url":"https://api.github.com/users/jonesguy14","html_url":"https://github.com/jonesguy14","followers_url":"https://api.github.com/users/jonesguy14/followers","following_url":"https://api.github.com/users/jonesguy14/following{/other_user}","gists_url":"https://api.github.com/users/jonesguy14/gists{/gist_id}","starred_url":"https://api.github.com/users/jonesguy14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonesguy14/subscriptions","organizations_url":"https://api.github.com/users/jonesguy14/orgs","repos_url":"https://api.github.com/users/jonesguy14/repos","events_url":"https://api.github.com/users/jonesguy14/events{/privacy}","received_events_url":"https://api.github.com/users/jonesguy14/received_events","type":"User","site_admin":false},"repo":{"id":53294759,"name":"footballcoach","full_name":"jonesguy14/footballcoach","owner":{"login":"jonesguy14","id":5642625,"avatar_url":"https://avatars.githubusercontent.com/u/5642625?v=3","gravatar_id":"","url":"https://api.github.com/users/jonesguy14","html_url":"https://github.com/jonesguy14","followers_url":"https://api.github.com/users/jonesguy14/followers","following_url":"https://api.github.com/users/jonesguy14/following{/other_user}","gists_url":"https://api.github.com/users/jonesguy14/gists{/gist_id}","starred_url":"https://api.github.com/users/jonesguy14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonesguy14/subscriptions","organizations_url":"https://api.github.com/users/jonesguy14/orgs","repos_url":"https://api.github.com/users/jonesguy14/repos","events_url":"https://api.github.com/users/jonesguy14/events{/privacy}","received_events_url":"https://api.github.com/users/jonesguy14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonesguy14/footballcoach","description":"Android App for playing/simulating/recruiting as a college football coach","fork":false,"url":"https://api.github.com/repos/jonesguy14/footballcoach","forks_url":"https://api.github.com/repos/jonesguy14/footballcoach/forks","keys_url":"https://api.github.com/repos/jonesguy14/footballcoach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonesguy14/footballcoach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonesguy14/footballcoach/teams","hooks_url":"https://api.github.com/repos/jonesguy14/footballcoach/hooks","issue_events_url":"https://api.github.com/repos/jonesguy14/footballcoach/issues/events{/number}","events_url":"https://api.github.com/repos/jonesguy14/footballcoach/events","assignees_url":"https://api.github.com/repos/jonesguy14/footballcoach/assignees{/user}","branches_url":"https://api.github.com/repos/jonesguy14/footballcoach/branches{/branch}","tags_url":"https://api.github.com/repos/jonesguy14/footballcoach/tags","blobs_url":"https://api.github.com/repos/jonesguy14/footballcoach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonesguy14/footballcoach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonesguy14/footballcoach/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonesguy14/footballcoach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonesguy14/footballcoach/statuses/{sha}","languages_url":"https://api.github.com/repos/jonesguy14/footballcoach/languages","stargazers_url":"https://api.github.com/repos/jonesguy14/footballcoach/stargazers","contributors_url":"https://api.github.com/repos/jonesguy14/footballcoach/contributors","subscribers_url":"https://api.github.com/repos/jonesguy14/footballcoach/subscribers","subscription_url":"https://api.github.com/repos/jonesguy14/footballcoach/subscription","commits_url":"https://api.github.com/repos/jonesguy14/footballcoach/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonesguy14/footballcoach/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonesguy14/footballcoach/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonesguy14/footballcoach/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonesguy14/footballcoach/contents/{+path}","compare_url":"https://api.github.com/repos/jonesguy14/footballcoach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonesguy14/footballcoach/merges","archive_url":"https://api.github.com/repos/jonesguy14/footballcoach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonesguy14/footballcoach/downloads","issues_url":"https://api.github.com/repos/jonesguy14/footballcoach/issues{/number}","pulls_url":"https://api.github.com/repos/jonesguy14/footballcoach/pulls{/number}","milestones_url":"https://api.github.com/repos/jonesguy14/footballcoach/milestones{/number}","notifications_url":"https://api.github.com/repos/jonesguy14/footballcoach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonesguy14/footballcoach/labels{/name}","releases_url":"https://api.github.com/repos/jonesguy14/footballcoach/releases{/id}","deployments_url":"https://api.github.com/repos/jonesguy14/footballcoach/deployments","created_at":"2016-03-07T04:02:36Z","updated_at":"2016-04-07T23:02:18Z","pushed_at":"2016-04-06T23:40:01Z","git_url":"git://github.com/jonesguy14/footballcoach.git","ssh_url":"git@github.com:jonesguy14/footballcoach.git","clone_url":"https://github.com/jonesguy14/footballcoach.git","svn_url":"https://github.com/jonesguy14/footballcoach","homepage":null,"size":22553,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58"},"html":{"href":"https://github.com/jonesguy14/footballcoach/pull/58"},"issue":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/issues/58"},"comments":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/jonesguy14/footballcoach/statuses/264dc9f602a82f449856563d66b1434b441e631d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":147,"deletions":23,"changed_files":2}}