{"action":"created","issue":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/494","repository_url":"https://api.github.com/repos/mit-crpg/openmc","labels_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494/comments","events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494/events","html_url":"https://github.com/mit-crpg/openmc/pull/494","id":115759085,"number":494,"title":"Addition of MultiGroup Capability","user":{"login":"nelsonag","id":1037107,"avatar_url":"https://avatars.githubusercontent.com/u/1037107?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonag","html_url":"https://github.com/nelsonag","followers_url":"https://api.github.com/users/nelsonag/followers","following_url":"https://api.github.com/users/nelsonag/following{/other_user}","gists_url":"https://api.github.com/users/nelsonag/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonag/subscriptions","organizations_url":"https://api.github.com/users/nelsonag/orgs","repos_url":"https://api.github.com/users/nelsonag/repos","events_url":"https://api.github.com/users/nelsonag/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mit-crpg/openmc/milestones/14","html_url":"https://github.com/mit-crpg/openmc/milestones/v0.8","labels_url":"https://api.github.com/repos/mit-crpg/openmc/milestones/14/labels","id":1241750,"number":14,"title":"v0.8","description":"","creator":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":18,"state":"open","created_at":"2015-08-05T10:39:23Z","updated_at":"2016-02-08T03:42:41Z","due_on":"2016-04-30T05:00:00Z","closed_at":null},"comments":48,"created_at":"2015-11-08T20:50:21Z","updated_at":"2016-02-12T16:36:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/494","html_url":"https://github.com/mit-crpg/openmc/pull/494","diff_url":"https://github.com/mit-crpg/openmc/pull/494.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/494.patch"},"body":"As discussed in #336, this PR contains the Multi-group capability.  The list below contains remaining work before this can be considered ready for merge.  \r\n\r\nOverall, I have a decent balance between not touching CE mode, but getting MG close to as fast as when I had it in its own standalone form.  I did this with usage of: extended types, procedure pointers, and a sprinkling of if (run_CE) here and there.\r\n\r\nRight now the only actual issue I am aware of is that CMFD does not work when feedback is enabled; however the CMFD solution is correct when it is not.  My hunch is that this is due to CMFD, which is left living in energy space (vice group space), has some term not being communicated properly back to energy space from the group space.  I haven't been able to find that yet, however.\r\n\r\nI have a question for you guys regarding testing: would you prefer there be specific MG tests in its own sub-directory within /tests/, that there be test_mg_* tests for everything that possibly  could have been touched by this new capability, or that the test harness be taught how to run both a CE and MG problem so we test both modes concurrently?  How were you thinking about attacking this for photon transport @paulromano?  \r\n\r\n- [x] Get CMFD Running (see discussion)\r\n- [x] General optimizations/cleanup (open to ideas for efficiency)\r\n- [x] Add example C5G7 problems\r\n- [x] Add User's Guide Documentation\r\n- [x] Add testing (see discussion)\r\n- [x] Add RelaxNG schema\r\n- [x] Update Python for general API\r\n\r\nReserved for future PRs:\r\n- Support HDF5 cross section files\r\n- Update Methods Documentation\r\n- Update MGXS Module of Python API to support types needed to have CE mode create MG mode data.\r\n"},"comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments/183400400","html_url":"https://github.com/mit-crpg/openmc/pull/494#issuecomment-183400400","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/494","id":183400400,"user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T16:36:22Z","updated_at":"2016-02-12T16:36:22Z","body":"Takeda is all isotropic scattering."}}