{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/394","repository_url":"https://api.github.com/repos/Azure/azure-sdk-for-go","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/394/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/394/comments","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/394/events","html_url":"https://github.com/Azure/azure-sdk-for-go/pull/394","id":174818326,"number":394,"title":"Version v5.0.0-beta","user":{"login":"garimakhulbe","id":9362976,"avatar_url":"https://avatars.githubusercontent.com/u/9362976?v=3","gravatar_id":"","url":"https://api.github.com/users/garimakhulbe","html_url":"https://github.com/garimakhulbe","followers_url":"https://api.github.com/users/garimakhulbe/followers","following_url":"https://api.github.com/users/garimakhulbe/following{/other_user}","gists_url":"https://api.github.com/users/garimakhulbe/gists{/gist_id}","starred_url":"https://api.github.com/users/garimakhulbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garimakhulbe/subscriptions","organizations_url":"https://api.github.com/users/garimakhulbe/orgs","repos_url":"https://api.github.com/users/garimakhulbe/repos","events_url":"https://api.github.com/users/garimakhulbe/events{/privacy}","received_events_url":"https://api.github.com/users/garimakhulbe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-09-02T18:14:31Z","updated_at":"2016-09-30T17:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/pulls/394","html_url":"https://github.com/Azure/azure-sdk-for-go/pull/394","diff_url":"https://github.com/Azure/azure-sdk-for-go/pull/394.diff","patch_url":"https://github.com/Azure/azure-sdk-for-go/pull/394.patch"},"body":"1.This PR includes fix for name conflicts in swagger types and variables/methods defined by us in Go SDK(UserAgent(), Version(), etc..). \r\nFor duplicate types, it will add package name in type name, for example `Version` type from swagger conflicts with function `Version()`  therefore update to..\r\n```Go\r\ntype VersionServerMangement struct {\r\n\tMajor         *int32 `json:\"major,omitempty\"`\r\n\tMinor         *int32 `json:\"minor,omitempty\"`\r\n        .....\r\n}\r\n```\r\n```Go\r\n// PowerShellSessionResourceProperties is\r\ntype PowerShellSessionResourceProperties struct {\r\n       ....\r\n\tVersion              *VersionServerManageMent  `json:\"version,omitempty\"`\r\n\t.....\r\n}\r\n```\r\nFor enum duplicates, enum type is being added to name. \r\n\r\n```Go\r\nconst (\r\n\t....\r\n\t// StateNew specifies the state new state for state.\r\n\tStateNew State = \"New\"  \r\n\r\n     // Earlier\r\n   New State = \"New\"  //conflicting with method New()\r\n\t...\r\n```\r\n\r\n\r\n2.Added check to not trim package name if group name is plural of package name.\r\nWe trim package name from method group name to avoid lint error in go.\r\n\r\n> Storage.StorageAccounts  (golint error for stuttering name)  ---> Storage.Accounts\r\n\r\nThere is new swagger for `EventHub` and it has method group `EventHubs`. After trimming package name from group `EventHubs`... \r\n> EventHubs -> s ( again results in lint error for improper name)\r\n\r\nTo avoid this, I have added a check for plural before trim.\r\n\r\n\r\n3.Removed Container Service until it is discussion. \r\n\r\n4.New APIs added: Server management, Datalake Analytics - Account and Job, Eventhub. "},"comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/comments/250809392","html_url":"https://github.com/Azure/azure-sdk-for-go/pull/394#issuecomment-250809392","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-go/issues/394","id":250809392,"user":{"login":"mcardosos","id":18688426,"avatar_url":"https://avatars.githubusercontent.com/u/18688426?v=3","gravatar_id":"","url":"https://api.github.com/users/mcardosos","html_url":"https://github.com/mcardosos","followers_url":"https://api.github.com/users/mcardosos/followers","following_url":"https://api.github.com/users/mcardosos/following{/other_user}","gists_url":"https://api.github.com/users/mcardosos/gists{/gist_id}","starred_url":"https://api.github.com/users/mcardosos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcardosos/subscriptions","organizations_url":"https://api.github.com/users/mcardosos/orgs","repos_url":"https://api.github.com/users/mcardosos/repos","events_url":"https://api.github.com/users/mcardosos/events{/privacy}","received_events_url":"https://api.github.com/users/mcardosos/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T17:52:11Z","updated_at":"2016-09-30T17:52:11Z","body":"LGTM, just waiting for travis :D"}}
{"actor":{"display_login":"mcardosos"}}