{"action":"created","issue":{"url":"https://api.github.com/repos/docker/swarm/issues/2551","repository_url":"https://api.github.com/repos/docker/swarm","labels_url":"https://api.github.com/repos/docker/swarm/issues/2551/labels{/name}","comments_url":"https://api.github.com/repos/docker/swarm/issues/2551/comments","events_url":"https://api.github.com/repos/docker/swarm/issues/2551/events","html_url":"https://github.com/docker/swarm/pull/2551","id":191410608,"number":2551,"title":"Add a node whitelist filter","user":{"login":"alexmavr","id":680441,"avatar_url":"https://avatars.githubusercontent.com/u/680441?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmavr","html_url":"https://github.com/alexmavr","followers_url":"https://api.github.com/users/alexmavr/followers","following_url":"https://api.github.com/users/alexmavr/following{/other_user}","gists_url":"https://api.github.com/users/alexmavr/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmavr/subscriptions","organizations_url":"https://api.github.com/users/alexmavr/orgs","repos_url":"https://api.github.com/users/alexmavr/repos","events_url":"https://api.github.com/users/alexmavr/events{/privacy}","received_events_url":"https://api.github.com/users/alexmavr/received_events","type":"User","site_admin":false},"labels":[{"id":166279550,"url":"https://api.github.com/repos/docker/swarm/labels/area/scheduler","name":"area/scheduler","color":"fbca04","default":false},{"id":211244097,"url":"https://api.github.com/repos/docker/swarm/labels/priority/P1","name":"priority/P1","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"nishanttotla","id":1872537,"avatar_url":"https://avatars.githubusercontent.com/u/1872537?v=3","gravatar_id":"","url":"https://api.github.com/users/nishanttotla","html_url":"https://github.com/nishanttotla","followers_url":"https://api.github.com/users/nishanttotla/followers","following_url":"https://api.github.com/users/nishanttotla/following{/other_user}","gists_url":"https://api.github.com/users/nishanttotla/gists{/gist_id}","starred_url":"https://api.github.com/users/nishanttotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishanttotla/subscriptions","organizations_url":"https://api.github.com/users/nishanttotla/orgs","repos_url":"https://api.github.com/users/nishanttotla/repos","events_url":"https://api.github.com/users/nishanttotla/events{/privacy}","received_events_url":"https://api.github.com/users/nishanttotla/received_events","type":"User","site_admin":false},"assignees":[{"login":"nishanttotla","id":1872537,"avatar_url":"https://avatars.githubusercontent.com/u/1872537?v=3","gravatar_id":"","url":"https://api.github.com/users/nishanttotla","html_url":"https://github.com/nishanttotla","followers_url":"https://api.github.com/users/nishanttotla/followers","following_url":"https://api.github.com/users/nishanttotla/following{/other_user}","gists_url":"https://api.github.com/users/nishanttotla/gists{/gist_id}","starred_url":"https://api.github.com/users/nishanttotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishanttotla/subscriptions","organizations_url":"https://api.github.com/users/nishanttotla/orgs","repos_url":"https://api.github.com/users/nishanttotla/repos","events_url":"https://api.github.com/users/nishanttotla/events{/privacy}","received_events_url":"https://api.github.com/users/nishanttotla/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/swarm/milestones/16","html_url":"https://github.com/docker/swarm/milestone/16","labels_url":"https://api.github.com/repos/docker/swarm/milestones/16/labels","id":1937879,"number":16,"title":"1.2.6","description":"","creator":{"login":"dongluochen","id":14985073,"avatar_url":"https://avatars.githubusercontent.com/u/14985073?v=3","gravatar_id":"","url":"https://api.github.com/users/dongluochen","html_url":"https://github.com/dongluochen","followers_url":"https://api.github.com/users/dongluochen/followers","following_url":"https://api.github.com/users/dongluochen/following{/other_user}","gists_url":"https://api.github.com/users/dongluochen/gists{/gist_id}","starred_url":"https://api.github.com/users/dongluochen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongluochen/subscriptions","organizations_url":"https://api.github.com/users/dongluochen/orgs","repos_url":"https://api.github.com/users/dongluochen/repos","events_url":"https://api.github.com/users/dongluochen/events{/privacy}","received_events_url":"https://api.github.com/users/dongluochen/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":11,"state":"open","created_at":"2016-08-11T21:13:12Z","updated_at":"2016-12-07T21:37:38Z","due_on":"2017-01-10T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-11-24T00:50:25Z","updated_at":"2016-12-10T00:30:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/swarm/pulls/2551","html_url":"https://github.com/docker/swarm/pull/2551","diff_url":"https://github.com/docker/swarm/pull/2551.diff","patch_url":"https://github.com/docker/swarm/pull/2551.patch"},"body":"This PR adds support for a new scheduling filter that selects candidates based on a provided list of nodes, effectively implementing a \"whitelist\". This is meant to cover use cases where setting engine labels may not be practical.\r\n\r\nThe usage is currently implemented as `-e whitelist:node==node-1-name|node-2-name|node-3-name`, and I am definitely open to suggestions for a better UX.\r\n\r\nA similar approach that is available today is to use a series of `constraint:name!=<name>` constraints to implement a \"blacklist\" of nodes. However, that method is not equivalent to a whitelist filter during rescheduling."},"comment":{"url":"https://api.github.com/repos/docker/swarm/issues/comments/266160755","html_url":"https://github.com/docker/swarm/pull/2551#issuecomment-266160755","issue_url":"https://api.github.com/repos/docker/swarm/issues/2551","id":266160755,"user":{"login":"alexmavr","id":680441,"avatar_url":"https://avatars.githubusercontent.com/u/680441?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmavr","html_url":"https://github.com/alexmavr","followers_url":"https://api.github.com/users/alexmavr/followers","following_url":"https://api.github.com/users/alexmavr/following{/other_user}","gists_url":"https://api.github.com/users/alexmavr/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmavr/subscriptions","organizations_url":"https://api.github.com/users/alexmavr/orgs","repos_url":"https://api.github.com/users/alexmavr/repos","events_url":"https://api.github.com/users/alexmavr/events{/privacy}","received_events_url":"https://api.github.com/users/alexmavr/received_events","type":"User","site_admin":false},"created_at":"2016-12-10T00:30:18Z","updated_at":"2016-12-10T00:30:18Z","body":"Rebased and addressed line comment (moved whitelist filter last).\r\n\r\nI still don't understand why you say this is a different case for a filter, the use case is to have all types of filters apply, but ignore any candidate nodes that are not part of the whitelisted nodes."}}
{"actor":{"display_login":"alexmavr"}}