{"push_id":1275790900,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"85ec579564402fad9b6f0d593decf686846fb61f","before":"29649b991045c05394dc42641068934b9d494e80","commits":[{"sha":"85ec579564402fad9b6f0d593decf686846fb61f","author":{"name":"ricea","email":"1e9d98b13926f27415f0d1eb902bd4c86cbfa4ca@chromium.org"},"message":"Re-write many calls to WrapUnique() with MakeUnique()\n\nA mostly-automated change to convert instances of WrapUnique(new Foo(...)) to\nMakeUnique<Foo>(...). See the thread at\nhttps://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k\nfor background.\n\nTo avoid requiring too many manual fixups, the change skips some cases that are\nfrequently problematic. In particular, in methods named Foo::Method() it will\nnot try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because\nFoo::Method() may be accessing an internal constructor of Foo.\n\nCases where MakeUnique<NestedClass>(...) is called within a method of\nOuterClass are common but hard to detect automatically, so have been fixed-up\nmanually.\n\nThe only types of manual fix ups applied are:\n1) Revert MakeUnique back to WrapUnique\n2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL\n   correctly)\n3) Add base:: namespace qualifier where missing.\n\nWrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might\nchange behaviour if Foo does not have a user-defined constructor. For example,\nWrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()\ncreates an integer initialised to 0.\n\ngit cl format has been been run over the CL. Spot-checking has uncovered no\ncases of mis-formatting.\n\n  BUG=637812\n\nReview-Url: https://codereview.chromium.org/2257793002\nCr-Commit-Position: refs/heads/master@{#415593}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/85ec579564402fad9b6f0d593decf686846fb61f"}]}
{"actor":{"display_login":"dstockwell"}}