{"action":"created","issue":{"url":"https://api.github.com/repos/unioslo/tsdfx/issues/95","repository_url":"https://api.github.com/repos/unioslo/tsdfx","labels_url":"https://api.github.com/repos/unioslo/tsdfx/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/unioslo/tsdfx/issues/95/comments","events_url":"https://api.github.com/repos/unioslo/tsdfx/issues/95/events","html_url":"https://github.com/unioslo/tsdfx/pull/95","id":160853030,"number":95,"title":"scanner - log time","user":{"login":"angainor","id":11975720,"avatar_url":"https://avatars.githubusercontent.com/u/11975720?v=3","gravatar_id":"","url":"https://api.github.com/users/angainor","html_url":"https://github.com/angainor","followers_url":"https://api.github.com/users/angainor/followers","following_url":"https://api.github.com/users/angainor/following{/other_user}","gists_url":"https://api.github.com/users/angainor/gists{/gist_id}","starred_url":"https://api.github.com/users/angainor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angainor/subscriptions","organizations_url":"https://api.github.com/users/angainor/orgs","repos_url":"https://api.github.com/users/angainor/repos","events_url":"https://api.github.com/users/angainor/events{/privacy}","received_events_url":"https://api.github.com/users/angainor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-17T09:57:18Z","updated_at":"2016-06-17T10:41:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/unioslo/tsdfx/pulls/95","html_url":"https://github.com/unioslo/tsdfx/pull/95","diff_url":"https://github.com/unioslo/tsdfx/pull/95.diff","patch_url":"https://github.com/unioslo/tsdfx/pull/95.patch"},"body":"add syslog that prints time it takes to perform a given scanner task"},"comment":{"url":"https://api.github.com/repos/unioslo/tsdfx/issues/comments/226738175","html_url":"https://github.com/unioslo/tsdfx/pull/95#issuecomment-226738175","issue_url":"https://api.github.com/repos/unioslo/tsdfx/issues/95","id":226738175,"user":{"login":"petterreinholdtsen","id":731031,"avatar_url":"https://avatars.githubusercontent.com/u/731031?v=3","gravatar_id":"","url":"https://api.github.com/users/petterreinholdtsen","html_url":"https://github.com/petterreinholdtsen","followers_url":"https://api.github.com/users/petterreinholdtsen/followers","following_url":"https://api.github.com/users/petterreinholdtsen/following{/other_user}","gists_url":"https://api.github.com/users/petterreinholdtsen/gists{/gist_id}","starred_url":"https://api.github.com/users/petterreinholdtsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petterreinholdtsen/subscriptions","organizations_url":"https://api.github.com/users/petterreinholdtsen/orgs","repos_url":"https://api.github.com/users/petterreinholdtsen/repos","events_url":"https://api.github.com/users/petterreinholdtsen/events{/privacy}","received_events_url":"https://api.github.com/users/petterreinholdtsen/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T10:41:27Z","updated_at":"2016-06-17T10:41:27Z","body":"Look like the automatic testing no longer work with this patch.  Did your 'make check' run work?\r\n\r\nLooking at the code, I suspect the new log functions belong in log.h and tsd_log.c, not it a new file.  It would be great if the code also had a test script to verify that it work.  Can you add a test to t/ for this?\r\n\r\nFinally, I believe it is more common in the current code to use start/stop idioms, and suggest to change the tic/toc function names to timer_start/timer_stop or something like that."}}
{"actor":{"display_login":"petterreinholdtsen"}}