{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/84311737","pull_request_review_id":5097180,"id":84311737,"diff_hunk":"@@ -29,13 +37,10 @@ function isInDocument(node) {\n  */\n var ReactInputSelection = {\n \n-  hasSelectionCapabilities: function(elem) {\n-    var nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();\n-    return nodeName && (\n-      (nodeName === 'input' && elem.type === 'text') ||\n-      nodeName === 'textarea' ||\n-      elem.contentEditable === 'true'\n-    );\n+  hasSelectionCapabilities: function(elem : HTMLElement) {\n+    return (elem instanceof HTMLInputElement && elem.type === 'text') ||","path":"src/renderers/dom/client/ReactInputSelection.js","position":36,"original_position":36,"commit_id":"9c046a80423fcbce90c10a9ec2f790ad2ac62e23","original_commit_id":"9c046a80423fcbce90c10a9ec2f790ad2ac62e23","user":{"login":"Aweary","id":6886061,"avatar_url":"https://avatars.githubusercontent.com/u/6886061?v=3","gravatar_id":"","url":"https://api.github.com/users/Aweary","html_url":"https://github.com/Aweary","followers_url":"https://api.github.com/users/Aweary/followers","following_url":"https://api.github.com/users/Aweary/following{/other_user}","gists_url":"https://api.github.com/users/Aweary/gists{/gist_id}","starred_url":"https://api.github.com/users/Aweary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aweary/subscriptions","organizations_url":"https://api.github.com/users/Aweary/orgs","repos_url":"https://api.github.com/users/Aweary/repos","events_url":"https://api.github.com/users/Aweary/events{/privacy}","received_events_url":"https://api.github.com/users/Aweary/received_events","type":"User","site_admin":false},"body":"Why did you change this logic here? We shouldn't change implementation logic unless there's a good reason to do it. We also don't want to include changes like this alongside stylistic changes like flowtype annotations, as it would make it hard to revert just this change if we needed to.","created_at":"2016-10-20T15:39:24Z","updated_at":"2016-10-20T15:41:02Z","html_url":"https://github.com/facebook/react/pull/8024#discussion_r84311737","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8024","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/84311737"},"html":{"href":"https://github.com/facebook/react/pull/8024#discussion_r84311737"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8024"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8024","id":90155798,"html_url":"https://github.com/facebook/react/pull/8024","diff_url":"https://github.com/facebook/react/pull/8024.diff","patch_url":"https://github.com/facebook/react/pull/8024.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8024","number":8024,"state":"open","locked":false,"title":"Add Flow annotations for ReactInputSelection.js","user":{"login":"cmatheson","id":35404,"avatar_url":"https://avatars.githubusercontent.com/u/35404?v=3","gravatar_id":"","url":"https://api.github.com/users/cmatheson","html_url":"https://github.com/cmatheson","followers_url":"https://api.github.com/users/cmatheson/followers","following_url":"https://api.github.com/users/cmatheson/following{/other_user}","gists_url":"https://api.github.com/users/cmatheson/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatheson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatheson/subscriptions","organizations_url":"https://api.github.com/users/cmatheson/orgs","repos_url":"https://api.github.com/users/cmatheson/repos","events_url":"https://api.github.com/users/cmatheson/events{/privacy}","received_events_url":"https://api.github.com/users/cmatheson/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI added some type checks to this relatively easy-looking area of React.\r\n\r\nThanks!","created_at":"2016-10-20T08:40:25Z","updated_at":"2016-10-20T15:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"750634a99e711506b4626e15298dbdfb03c75a2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8024/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8024/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8024/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/9c046a80423fcbce90c10a9ec2f790ad2ac62e23","head":{"label":"cmatheson:master","ref":"master","sha":"9c046a80423fcbce90c10a9ec2f790ad2ac62e23","user":{"login":"cmatheson","id":35404,"avatar_url":"https://avatars.githubusercontent.com/u/35404?v=3","gravatar_id":"","url":"https://api.github.com/users/cmatheson","html_url":"https://github.com/cmatheson","followers_url":"https://api.github.com/users/cmatheson/followers","following_url":"https://api.github.com/users/cmatheson/following{/other_user}","gists_url":"https://api.github.com/users/cmatheson/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatheson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatheson/subscriptions","organizations_url":"https://api.github.com/users/cmatheson/orgs","repos_url":"https://api.github.com/users/cmatheson/repos","events_url":"https://api.github.com/users/cmatheson/events{/privacy}","received_events_url":"https://api.github.com/users/cmatheson/received_events","type":"User","site_admin":false},"repo":{"id":44159170,"name":"react","full_name":"cmatheson/react","owner":{"login":"cmatheson","id":35404,"avatar_url":"https://avatars.githubusercontent.com/u/35404?v=3","gravatar_id":"","url":"https://api.github.com/users/cmatheson","html_url":"https://github.com/cmatheson","followers_url":"https://api.github.com/users/cmatheson/followers","following_url":"https://api.github.com/users/cmatheson/following{/other_user}","gists_url":"https://api.github.com/users/cmatheson/gists{/gist_id}","starred_url":"https://api.github.com/users/cmatheson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmatheson/subscriptions","organizations_url":"https://api.github.com/users/cmatheson/orgs","repos_url":"https://api.github.com/users/cmatheson/repos","events_url":"https://api.github.com/users/cmatheson/events{/privacy}","received_events_url":"https://api.github.com/users/cmatheson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmatheson/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/cmatheson/react","forks_url":"https://api.github.com/repos/cmatheson/react/forks","keys_url":"https://api.github.com/repos/cmatheson/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmatheson/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmatheson/react/teams","hooks_url":"https://api.github.com/repos/cmatheson/react/hooks","issue_events_url":"https://api.github.com/repos/cmatheson/react/issues/events{/number}","events_url":"https://api.github.com/repos/cmatheson/react/events","assignees_url":"https://api.github.com/repos/cmatheson/react/assignees{/user}","branches_url":"https://api.github.com/repos/cmatheson/react/branches{/branch}","tags_url":"https://api.github.com/repos/cmatheson/react/tags","blobs_url":"https://api.github.com/repos/cmatheson/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmatheson/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmatheson/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmatheson/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmatheson/react/statuses/{sha}","languages_url":"https://api.github.com/repos/cmatheson/react/languages","stargazers_url":"https://api.github.com/repos/cmatheson/react/stargazers","contributors_url":"https://api.github.com/repos/cmatheson/react/contributors","subscribers_url":"https://api.github.com/repos/cmatheson/react/subscribers","subscription_url":"https://api.github.com/repos/cmatheson/react/subscription","commits_url":"https://api.github.com/repos/cmatheson/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmatheson/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmatheson/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmatheson/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmatheson/react/contents/{+path}","compare_url":"https://api.github.com/repos/cmatheson/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmatheson/react/merges","archive_url":"https://api.github.com/repos/cmatheson/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmatheson/react/downloads","issues_url":"https://api.github.com/repos/cmatheson/react/issues{/number}","pulls_url":"https://api.github.com/repos/cmatheson/react/pulls{/number}","milestones_url":"https://api.github.com/repos/cmatheson/react/milestones{/number}","notifications_url":"https://api.github.com/repos/cmatheson/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmatheson/react/labels{/name}","releases_url":"https://api.github.com/repos/cmatheson/react/releases{/id}","deployments_url":"https://api.github.com/repos/cmatheson/react/deployments","created_at":"2015-10-13T07:21:24Z","updated_at":"2016-10-20T08:37:09Z","pushed_at":"2016-10-20T08:36:02Z","git_url":"git://github.com/cmatheson/react.git","ssh_url":"git@github.com:cmatheson/react.git","clone_url":"https://github.com/cmatheson/react.git","svn_url":"https://github.com/cmatheson/react","homepage":"https://facebook.github.io/react/","size":85952,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a5195102d4278cd4e2c36612afa7f1fc09b201fd","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-10-20T15:36:52Z","pushed_at":"2016-10-20T08:40:25Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":141293,"stargazers_count":52121,"watchers_count":52121,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9125,"mirror_url":null,"open_issues_count":722,"forks":9125,"open_issues":722,"watchers":52121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8024"},"html":{"href":"https://github.com/facebook/react/pull/8024"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8024"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8024/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8024/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8024/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/9c046a80423fcbce90c10a9ec2f790ad2ac62e23"}}}}
{"actor":{"display_login":"Aweary"}}