{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/55674100","id":55674100,"diff_hunk":"@@ -225,6 +255,21 @@ func (m *memberlist) MakeLeave(address string, incarnation int64) []Change {\n \treturn m.MakeChange(address, incarnation, Leave)\n }\n \n+func (m *memberlist) MakeTombstone(address string, incarnation int64) []Change {\n+\tm.node.emit(MakeNodeStatusEvent{Tombstone})\n+\treturn m.MakeChange(address, incarnation, Tombstone)\n+}\n+\n+func (m *memberlist) Evict(address string) {\n+\tif m.local.Address == address {\n+\t\t// We should not evict ourselves from the memberlist. This should not be reached, but we will make noise in the logs\n+\t\tm.logger.Error(\"ringpop tried to evict the local member from the memberlist, action has been prevented\")","path":"swim/memberlist.go","position":56,"original_position":56,"commit_id":"01120eaefb88753c081434bee1b0a6ae8c1b5c45","original_commit_id":"01120eaefb88753c081434bee1b0a6ae8c1b5c45","user":{"login":"Motiejus","id":107720,"avatar_url":"https://avatars.githubusercontent.com/u/107720?v=3","gravatar_id":"","url":"https://api.github.com/users/Motiejus","html_url":"https://github.com/Motiejus","followers_url":"https://api.github.com/users/Motiejus/followers","following_url":"https://api.github.com/users/Motiejus/following{/other_user}","gists_url":"https://api.github.com/users/Motiejus/gists{/gist_id}","starred_url":"https://api.github.com/users/Motiejus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Motiejus/subscriptions","organizations_url":"https://api.github.com/users/Motiejus/orgs","repos_url":"https://api.github.com/users/Motiejus/repos","events_url":"https://api.github.com/users/Motiejus/events{/privacy}","received_events_url":"https://api.github.com/users/Motiejus/received_events","type":"User","site_admin":false},"body":"`... This  is a bug, please report to ringpop team.`","created_at":"2016-03-10T12:54:14Z","updated_at":"2016-03-10T12:54:14Z","html_url":"https://github.com/uber/ringpop-go/pull/123#discussion_r55674100","pull_request_url":"https://api.github.com/repos/uber/ringpop-go/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/55674100"},"html":{"href":"https://github.com/uber/ringpop-go/pull/123#discussion_r55674100"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/123","id":61963965,"html_url":"https://github.com/uber/ringpop-go/pull/123","diff_url":"https://github.com/uber/ringpop-go/pull/123.diff","patch_url":"https://github.com/uber/ringpop-go/pull/123.patch","issue_url":"https://api.github.com/repos/uber/ringpop-go/issues/123","number":123,"state":"open","locked":false,"title":"Reaping Faulty Nodes","user":{"login":"thanodnl","id":273145,"avatar_url":"https://avatars.githubusercontent.com/u/273145?v=3","gravatar_id":"","url":"https://api.github.com/users/thanodnl","html_url":"https://github.com/thanodnl","followers_url":"https://api.github.com/users/thanodnl/followers","following_url":"https://api.github.com/users/thanodnl/following{/other_user}","gists_url":"https://api.github.com/users/thanodnl/gists{/gist_id}","starred_url":"https://api.github.com/users/thanodnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanodnl/subscriptions","organizations_url":"https://api.github.com/users/thanodnl/orgs","repos_url":"https://api.github.com/users/thanodnl/repos","events_url":"https://api.github.com/users/thanodnl/events{/privacy}","received_events_url":"https://api.github.com/users/thanodnl/received_events","type":"User","site_admin":false},"body":"This branch is an implementation of reaping faulty nodes.\r\n\r\nThe basic design is:\r\n\r\n1. Add extra status for a node that is called `tombstone`\r\n2. A member that has the `tombstone` state will not be added to the checksum of the membership. The membership list with the tombstone has the same checksum as the membership list without the member. This makes it possible to remove the `tombstone` member from the membership list later on without the possibility for full sync mechanism of ringpop to make the deleted member appear again.\r\n3. If a node joins a cluster where a tombstone is in the member list, or when a node receives an update of a `tombstone` for an unknown member it will be ignored.\r\n\r\nThese 3 rules together make it possible to 'forget' about a faulty node in a distributed system.","created_at":"2016-03-07T19:07:20Z","updated_at":"2016-03-10T12:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68edf59b8652257d4dc634f9a8c84f1ae524ea7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop-go/pulls/123/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop-go/pulls/123/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop-go/issues/123/comments","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/01120eaefb88753c081434bee1b0a6ae8c1b5c45","head":{"label":"uber:feature/rfn","ref":"feature/rfn","sha":"01120eaefb88753c081434bee1b0a6ae8c1b5c45","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/ringpop-go/deployments","created_at":"2015-06-05T22:48:53Z","updated_at":"2016-03-10T11:57:02Z","pushed_at":"2016-03-10T12:42:45Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":2505,"stargazers_count":64,"watchers_count":64,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":64,"default_branch":"dev"}},"base":{"label":"uber:dev","ref":"dev","sha":"6fc7d846b3c98320b07610772e4960790ebbc840","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","deployments_url":"https://api.github.com/repos/uber/ringpop-go/deployments","created_at":"2015-06-05T22:48:53Z","updated_at":"2016-03-10T11:57:02Z","pushed_at":"2016-03-10T12:42:45Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":2505,"stargazers_count":64,"watchers_count":64,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":18,"forks":7,"open_issues":18,"watchers":64,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/123"},"html":{"href":"https://github.com/uber/ringpop-go/pull/123"},"issue":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/123"},"comments":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop-go/statuses/01120eaefb88753c081434bee1b0a6ae8c1b5c45"}}}}