{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/trendmicro/tlsh/pulls/19","id":57484456,"html_url":"https://github.com/trendmicro/tlsh/pull/19","diff_url":"https://github.com/trendmicro/tlsh/pull/19.diff","patch_url":"https://github.com/trendmicro/tlsh/pull/19.patch","issue_url":"https://api.github.com/repos/trendmicro/tlsh/issues/19","number":19,"state":"closed","locked":false,"title":"do not set RPATH for tlsh_unittest","user":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"body":"Using RPATH leads to problem when linked libraries have their own\r\ndependencies. See: https://wiki.debian.org/RpathIssue.\r\nAlso its considered \"evil\" in general and should be avoided (mainly\r\nwhen I want to package this software for Arch Linux).\r\n\r\nThe second patch adds a proper LD_PRELOAD in cmake to the\r\n'make test' target dynamically links against the in source-tree\r\nversion of libtlsh.so and the tests all work as expected and there is\r\nneither RPATH required nor a system-wide installation.","created_at":"2016-01-28T10:46:34Z","updated_at":"2016-01-29T03:48:57Z","closed_at":"2016-01-29T03:48:57Z","merged_at":"2016-01-29T03:48:57Z","merge_commit_sha":"ecd8829ce5d7366a98cffd4db35433b78ad88edb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trendmicro/tlsh/pulls/19/commits","review_comments_url":"https://api.github.com/repos/trendmicro/tlsh/pulls/19/comments","review_comment_url":"https://api.github.com/repos/trendmicro/tlsh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trendmicro/tlsh/issues/19/comments","statuses_url":"https://api.github.com/repos/trendmicro/tlsh/statuses/9f6f94efe8c900a522607e2cbf7f2d443511c3b5","head":{"label":"anthraxx:no-rpath","ref":"no-rpath","sha":"9f6f94efe8c900a522607e2cbf7f2d443511c3b5","user":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"repo":{"id":46734525,"name":"tlsh","full_name":"anthraxx/tlsh","owner":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthraxx/tlsh","description":"","fork":true,"url":"https://api.github.com/repos/anthraxx/tlsh","forks_url":"https://api.github.com/repos/anthraxx/tlsh/forks","keys_url":"https://api.github.com/repos/anthraxx/tlsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthraxx/tlsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthraxx/tlsh/teams","hooks_url":"https://api.github.com/repos/anthraxx/tlsh/hooks","issue_events_url":"https://api.github.com/repos/anthraxx/tlsh/issues/events{/number}","events_url":"https://api.github.com/repos/anthraxx/tlsh/events","assignees_url":"https://api.github.com/repos/anthraxx/tlsh/assignees{/user}","branches_url":"https://api.github.com/repos/anthraxx/tlsh/branches{/branch}","tags_url":"https://api.github.com/repos/anthraxx/tlsh/tags","blobs_url":"https://api.github.com/repos/anthraxx/tlsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthraxx/tlsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthraxx/tlsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthraxx/tlsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthraxx/tlsh/statuses/{sha}","languages_url":"https://api.github.com/repos/anthraxx/tlsh/languages","stargazers_url":"https://api.github.com/repos/anthraxx/tlsh/stargazers","contributors_url":"https://api.github.com/repos/anthraxx/tlsh/contributors","subscribers_url":"https://api.github.com/repos/anthraxx/tlsh/subscribers","subscription_url":"https://api.github.com/repos/anthraxx/tlsh/subscription","commits_url":"https://api.github.com/repos/anthraxx/tlsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthraxx/tlsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthraxx/tlsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthraxx/tlsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthraxx/tlsh/contents/{+path}","compare_url":"https://api.github.com/repos/anthraxx/tlsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthraxx/tlsh/merges","archive_url":"https://api.github.com/repos/anthraxx/tlsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthraxx/tlsh/downloads","issues_url":"https://api.github.com/repos/anthraxx/tlsh/issues{/number}","pulls_url":"https://api.github.com/repos/anthraxx/tlsh/pulls{/number}","milestones_url":"https://api.github.com/repos/anthraxx/tlsh/milestones{/number}","notifications_url":"https://api.github.com/repos/anthraxx/tlsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthraxx/tlsh/labels{/name}","releases_url":"https://api.github.com/repos/anthraxx/tlsh/releases{/id}","deployments_url":"https://api.github.com/repos/anthraxx/tlsh/deployments","created_at":"2015-11-23T16:49:34Z","updated_at":"2016-01-27T16:27:56Z","pushed_at":"2016-01-27T18:03:14Z","git_url":"git://github.com/anthraxx/tlsh.git","ssh_url":"git@github.com:anthraxx/tlsh.git","clone_url":"https://github.com/anthraxx/tlsh.git","svn_url":"https://github.com/anthraxx/tlsh","homepage":null,"size":2430,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trendmicro:master","ref":"master","sha":"b53fef82c579906d6a6234bccfc3536c5abd28f0","user":{"login":"trendmicro","id":427106,"avatar_url":"https://avatars.githubusercontent.com/u/427106?v=3","gravatar_id":"","url":"https://api.github.com/users/trendmicro","html_url":"https://github.com/trendmicro","followers_url":"https://api.github.com/users/trendmicro/followers","following_url":"https://api.github.com/users/trendmicro/following{/other_user}","gists_url":"https://api.github.com/users/trendmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/trendmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trendmicro/subscriptions","organizations_url":"https://api.github.com/users/trendmicro/orgs","repos_url":"https://api.github.com/users/trendmicro/repos","events_url":"https://api.github.com/users/trendmicro/events{/privacy}","received_events_url":"https://api.github.com/users/trendmicro/received_events","type":"Organization","site_admin":false},"repo":{"id":13511038,"name":"tlsh","full_name":"trendmicro/tlsh","owner":{"login":"trendmicro","id":427106,"avatar_url":"https://avatars.githubusercontent.com/u/427106?v=3","gravatar_id":"","url":"https://api.github.com/users/trendmicro","html_url":"https://github.com/trendmicro","followers_url":"https://api.github.com/users/trendmicro/followers","following_url":"https://api.github.com/users/trendmicro/following{/other_user}","gists_url":"https://api.github.com/users/trendmicro/gists{/gist_id}","starred_url":"https://api.github.com/users/trendmicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trendmicro/subscriptions","organizations_url":"https://api.github.com/users/trendmicro/orgs","repos_url":"https://api.github.com/users/trendmicro/repos","events_url":"https://api.github.com/users/trendmicro/events{/privacy}","received_events_url":"https://api.github.com/users/trendmicro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trendmicro/tlsh","description":"","fork":false,"url":"https://api.github.com/repos/trendmicro/tlsh","forks_url":"https://api.github.com/repos/trendmicro/tlsh/forks","keys_url":"https://api.github.com/repos/trendmicro/tlsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trendmicro/tlsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trendmicro/tlsh/teams","hooks_url":"https://api.github.com/repos/trendmicro/tlsh/hooks","issue_events_url":"https://api.github.com/repos/trendmicro/tlsh/issues/events{/number}","events_url":"https://api.github.com/repos/trendmicro/tlsh/events","assignees_url":"https://api.github.com/repos/trendmicro/tlsh/assignees{/user}","branches_url":"https://api.github.com/repos/trendmicro/tlsh/branches{/branch}","tags_url":"https://api.github.com/repos/trendmicro/tlsh/tags","blobs_url":"https://api.github.com/repos/trendmicro/tlsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trendmicro/tlsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trendmicro/tlsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/trendmicro/tlsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trendmicro/tlsh/statuses/{sha}","languages_url":"https://api.github.com/repos/trendmicro/tlsh/languages","stargazers_url":"https://api.github.com/repos/trendmicro/tlsh/stargazers","contributors_url":"https://api.github.com/repos/trendmicro/tlsh/contributors","subscribers_url":"https://api.github.com/repos/trendmicro/tlsh/subscribers","subscription_url":"https://api.github.com/repos/trendmicro/tlsh/subscription","commits_url":"https://api.github.com/repos/trendmicro/tlsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/trendmicro/tlsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/trendmicro/tlsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/trendmicro/tlsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/trendmicro/tlsh/contents/{+path}","compare_url":"https://api.github.com/repos/trendmicro/tlsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trendmicro/tlsh/merges","archive_url":"https://api.github.com/repos/trendmicro/tlsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trendmicro/tlsh/downloads","issues_url":"https://api.github.com/repos/trendmicro/tlsh/issues{/number}","pulls_url":"https://api.github.com/repos/trendmicro/tlsh/pulls{/number}","milestones_url":"https://api.github.com/repos/trendmicro/tlsh/milestones{/number}","notifications_url":"https://api.github.com/repos/trendmicro/tlsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trendmicro/tlsh/labels{/name}","releases_url":"https://api.github.com/repos/trendmicro/tlsh/releases{/id}","deployments_url":"https://api.github.com/repos/trendmicro/tlsh/deployments","created_at":"2013-10-11T22:21:54Z","updated_at":"2016-01-28T17:19:21Z","pushed_at":"2016-01-29T03:48:57Z","git_url":"git://github.com/trendmicro/tlsh.git","ssh_url":"git@github.com:trendmicro/tlsh.git","clone_url":"https://github.com/trendmicro/tlsh.git","svn_url":"https://github.com/trendmicro/tlsh","homepage":null,"size":2453,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trendmicro/tlsh/pulls/19"},"html":{"href":"https://github.com/trendmicro/tlsh/pull/19"},"issue":{"href":"https://api.github.com/repos/trendmicro/tlsh/issues/19"},"comments":{"href":"https://api.github.com/repos/trendmicro/tlsh/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/trendmicro/tlsh/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/trendmicro/tlsh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trendmicro/tlsh/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/trendmicro/tlsh/statuses/9f6f94efe8c900a522607e2cbf7f2d443511c3b5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Scott4man","id":1845212,"avatar_url":"https://avatars.githubusercontent.com/u/1845212?v=3","gravatar_id":"","url":"https://api.github.com/users/Scott4man","html_url":"https://github.com/Scott4man","followers_url":"https://api.github.com/users/Scott4man/followers","following_url":"https://api.github.com/users/Scott4man/following{/other_user}","gists_url":"https://api.github.com/users/Scott4man/gists{/gist_id}","starred_url":"https://api.github.com/users/Scott4man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scott4man/subscriptions","organizations_url":"https://api.github.com/users/Scott4man/orgs","repos_url":"https://api.github.com/users/Scott4man/repos","events_url":"https://api.github.com/users/Scott4man/events{/privacy}","received_events_url":"https://api.github.com/users/Scott4man/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":0,"changed_files":2}}