{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/openconfig/goyang/pulls/27","id":90229933,"html_url":"https://github.com/openconfig/goyang/pull/27","diff_url":"https://github.com/openconfig/goyang/pull/27.diff","patch_url":"https://github.com/openconfig/goyang/pull/27.patch","issue_url":"https://api.github.com/repos/openconfig/goyang/issues/27","number":27,"state":"closed","locked":false,"title":"Add tests for IsDefined and GetValue for Identity.","user":{"login":"robshakir","id":4836821,"avatar_url":"https://avatars.githubusercontent.com/u/4836821?v=3","gravatar_id":"","url":"https://api.github.com/users/robshakir","html_url":"https://github.com/robshakir","followers_url":"https://api.github.com/users/robshakir/followers","following_url":"https://api.github.com/users/robshakir/following{/other_user}","gists_url":"https://api.github.com/users/robshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/robshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robshakir/subscriptions","organizations_url":"https://api.github.com/users/robshakir/orgs","repos_url":"https://api.github.com/users/robshakir/repos","events_url":"https://api.github.com/users/robshakir/events{/privacy}","received_events_url":"https://api.github.com/users/robshakir/received_events","type":"User","site_admin":false},"body":"This PR adds some missing tests for the methods on the Identity struct which went missing when refactoring the test structure there. They didn't require any changes to the methods themselves, but are included so we can catch any future regression.\r\n\r\n```\r\n * (M) pkg/yang/identity_test.go:\r\n    - Add missing tests for the IsDefined and GetValue methods on\r\n      identity including checking that non-existent values are not\r\n      erroneously reported as existing.\r\n```","created_at":"2016-10-20T15:57:38Z","updated_at":"2016-10-20T16:04:14Z","closed_at":"2016-10-20T16:04:14Z","merged_at":"2016-10-20T16:04:14Z","merge_commit_sha":"a1786458688b3fa16ca6c303b64611fd494e8674","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openconfig/goyang/pulls/27/commits","review_comments_url":"https://api.github.com/repos/openconfig/goyang/pulls/27/comments","review_comment_url":"https://api.github.com/repos/openconfig/goyang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openconfig/goyang/issues/27/comments","statuses_url":"https://api.github.com/repos/openconfig/goyang/statuses/b0ffe965f5ce79ad8a062d007f67ff2dc92d9ac9","head":{"label":"robshakir:robjs-identity-additional-tests","ref":"robjs-identity-additional-tests","sha":"b0ffe965f5ce79ad8a062d007f67ff2dc92d9ac9","user":{"login":"robshakir","id":4836821,"avatar_url":"https://avatars.githubusercontent.com/u/4836821?v=3","gravatar_id":"","url":"https://api.github.com/users/robshakir","html_url":"https://github.com/robshakir","followers_url":"https://api.github.com/users/robshakir/followers","following_url":"https://api.github.com/users/robshakir/following{/other_user}","gists_url":"https://api.github.com/users/robshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/robshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robshakir/subscriptions","organizations_url":"https://api.github.com/users/robshakir/orgs","repos_url":"https://api.github.com/users/robshakir/repos","events_url":"https://api.github.com/users/robshakir/events{/privacy}","received_events_url":"https://api.github.com/users/robshakir/received_events","type":"User","site_admin":false},"repo":{"id":68062451,"name":"goyang","full_name":"robshakir/goyang","owner":{"login":"robshakir","id":4836821,"avatar_url":"https://avatars.githubusercontent.com/u/4836821?v=3","gravatar_id":"","url":"https://api.github.com/users/robshakir","html_url":"https://github.com/robshakir","followers_url":"https://api.github.com/users/robshakir/followers","following_url":"https://api.github.com/users/robshakir/following{/other_user}","gists_url":"https://api.github.com/users/robshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/robshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robshakir/subscriptions","organizations_url":"https://api.github.com/users/robshakir/orgs","repos_url":"https://api.github.com/users/robshakir/repos","events_url":"https://api.github.com/users/robshakir/events{/privacy}","received_events_url":"https://api.github.com/users/robshakir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robshakir/goyang","description":"YANG parser and compiler to produce Go language objects","fork":true,"url":"https://api.github.com/repos/robshakir/goyang","forks_url":"https://api.github.com/repos/robshakir/goyang/forks","keys_url":"https://api.github.com/repos/robshakir/goyang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robshakir/goyang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robshakir/goyang/teams","hooks_url":"https://api.github.com/repos/robshakir/goyang/hooks","issue_events_url":"https://api.github.com/repos/robshakir/goyang/issues/events{/number}","events_url":"https://api.github.com/repos/robshakir/goyang/events","assignees_url":"https://api.github.com/repos/robshakir/goyang/assignees{/user}","branches_url":"https://api.github.com/repos/robshakir/goyang/branches{/branch}","tags_url":"https://api.github.com/repos/robshakir/goyang/tags","blobs_url":"https://api.github.com/repos/robshakir/goyang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robshakir/goyang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robshakir/goyang/git/refs{/sha}","trees_url":"https://api.github.com/repos/robshakir/goyang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robshakir/goyang/statuses/{sha}","languages_url":"https://api.github.com/repos/robshakir/goyang/languages","stargazers_url":"https://api.github.com/repos/robshakir/goyang/stargazers","contributors_url":"https://api.github.com/repos/robshakir/goyang/contributors","subscribers_url":"https://api.github.com/repos/robshakir/goyang/subscribers","subscription_url":"https://api.github.com/repos/robshakir/goyang/subscription","commits_url":"https://api.github.com/repos/robshakir/goyang/commits{/sha}","git_commits_url":"https://api.github.com/repos/robshakir/goyang/git/commits{/sha}","comments_url":"https://api.github.com/repos/robshakir/goyang/comments{/number}","issue_comment_url":"https://api.github.com/repos/robshakir/goyang/issues/comments{/number}","contents_url":"https://api.github.com/repos/robshakir/goyang/contents/{+path}","compare_url":"https://api.github.com/repos/robshakir/goyang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robshakir/goyang/merges","archive_url":"https://api.github.com/repos/robshakir/goyang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robshakir/goyang/downloads","issues_url":"https://api.github.com/repos/robshakir/goyang/issues{/number}","pulls_url":"https://api.github.com/repos/robshakir/goyang/pulls{/number}","milestones_url":"https://api.github.com/repos/robshakir/goyang/milestones{/number}","notifications_url":"https://api.github.com/repos/robshakir/goyang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robshakir/goyang/labels{/name}","releases_url":"https://api.github.com/repos/robshakir/goyang/releases{/id}","deployments_url":"https://api.github.com/repos/robshakir/goyang/deployments","created_at":"2016-09-13T01:26:58Z","updated_at":"2016-09-13T01:26:59Z","pushed_at":"2016-10-20T15:53:42Z","git_url":"git://github.com/robshakir/goyang.git","ssh_url":"git@github.com:robshakir/goyang.git","clone_url":"https://github.com/robshakir/goyang.git","svn_url":"https://github.com/robshakir/goyang","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openconfig:master","ref":"master","sha":"a1ed847def7547100ac302549102b1d9dc537355","user":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars.githubusercontent.com/u/8780263?v=3","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"repo":{"id":36744413,"name":"goyang","full_name":"openconfig/goyang","owner":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars.githubusercontent.com/u/8780263?v=3","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openconfig/goyang","description":"YANG parser and compiler to produce Go language objects","fork":false,"url":"https://api.github.com/repos/openconfig/goyang","forks_url":"https://api.github.com/repos/openconfig/goyang/forks","keys_url":"https://api.github.com/repos/openconfig/goyang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openconfig/goyang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openconfig/goyang/teams","hooks_url":"https://api.github.com/repos/openconfig/goyang/hooks","issue_events_url":"https://api.github.com/repos/openconfig/goyang/issues/events{/number}","events_url":"https://api.github.com/repos/openconfig/goyang/events","assignees_url":"https://api.github.com/repos/openconfig/goyang/assignees{/user}","branches_url":"https://api.github.com/repos/openconfig/goyang/branches{/branch}","tags_url":"https://api.github.com/repos/openconfig/goyang/tags","blobs_url":"https://api.github.com/repos/openconfig/goyang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openconfig/goyang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openconfig/goyang/git/refs{/sha}","trees_url":"https://api.github.com/repos/openconfig/goyang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openconfig/goyang/statuses/{sha}","languages_url":"https://api.github.com/repos/openconfig/goyang/languages","stargazers_url":"https://api.github.com/repos/openconfig/goyang/stargazers","contributors_url":"https://api.github.com/repos/openconfig/goyang/contributors","subscribers_url":"https://api.github.com/repos/openconfig/goyang/subscribers","subscription_url":"https://api.github.com/repos/openconfig/goyang/subscription","commits_url":"https://api.github.com/repos/openconfig/goyang/commits{/sha}","git_commits_url":"https://api.github.com/repos/openconfig/goyang/git/commits{/sha}","comments_url":"https://api.github.com/repos/openconfig/goyang/comments{/number}","issue_comment_url":"https://api.github.com/repos/openconfig/goyang/issues/comments{/number}","contents_url":"https://api.github.com/repos/openconfig/goyang/contents/{+path}","compare_url":"https://api.github.com/repos/openconfig/goyang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openconfig/goyang/merges","archive_url":"https://api.github.com/repos/openconfig/goyang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openconfig/goyang/downloads","issues_url":"https://api.github.com/repos/openconfig/goyang/issues{/number}","pulls_url":"https://api.github.com/repos/openconfig/goyang/pulls{/number}","milestones_url":"https://api.github.com/repos/openconfig/goyang/milestones{/number}","notifications_url":"https://api.github.com/repos/openconfig/goyang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openconfig/goyang/labels{/name}","releases_url":"https://api.github.com/repos/openconfig/goyang/releases{/id}","deployments_url":"https://api.github.com/repos/openconfig/goyang/deployments","created_at":"2015-06-02T15:57:01Z","updated_at":"2016-10-10T20:20:29Z","pushed_at":"2016-10-20T16:04:14Z","git_url":"git://github.com/openconfig/goyang.git","ssh_url":"git@github.com:openconfig/goyang.git","clone_url":"https://github.com/openconfig/goyang.git","svn_url":"https://github.com/openconfig/goyang","homepage":null,"size":189,"stargazers_count":28,"watchers_count":28,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openconfig/goyang/pulls/27"},"html":{"href":"https://github.com/openconfig/goyang/pull/27"},"issue":{"href":"https://api.github.com/repos/openconfig/goyang/issues/27"},"comments":{"href":"https://api.github.com/repos/openconfig/goyang/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/openconfig/goyang/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/openconfig/goyang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openconfig/goyang/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/openconfig/goyang/statuses/b0ffe965f5ce79ad8a062d007f67ff2dc92d9ac9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pborman","id":5115933,"avatar_url":"https://avatars.githubusercontent.com/u/5115933?v=3","gravatar_id":"","url":"https://api.github.com/users/pborman","html_url":"https://github.com/pborman","followers_url":"https://api.github.com/users/pborman/followers","following_url":"https://api.github.com/users/pborman/following{/other_user}","gists_url":"https://api.github.com/users/pborman/gists{/gist_id}","starred_url":"https://api.github.com/users/pborman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pborman/subscriptions","organizations_url":"https://api.github.com/users/pborman/orgs","repos_url":"https://api.github.com/users/pborman/repos","events_url":"https://api.github.com/users/pborman/events{/privacy}","received_events_url":"https://api.github.com/users/pborman/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"pborman"}}