{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/65354499","id":65354499,"diff_hunk":"@@ -1496,31 +1515,49 @@ public function testCopy()\n \n         $client->request(\n             'POST',\n-            '/api/nodes/' . $data[0]['id'] . '?webspace=sulu_io&language=en&action=copy&destination=' . $data[1]['id']\n+            '/api/nodes/' . $data[4]['id'] . '?webspace=sulu_io&language=en&action=copy&destination=' . $data[2]['id']\n         );\n         $this->assertHttpStatusCode(200, $client->getResponse());\n         $response = json_decode($client->getResponse()->getContent(), true);\n \n         // check some properties\n-        $this->assertNotEquals($data[0]['id'], $response['id']);\n-        $this->assertEquals('test1', $response['title']);\n-        $this->assertEquals('/test2/test1', $response['path']);\n-        $this->assertEquals('/test2/test1', $response['url']);\n+        $this->assertNotEquals($data[4]['id'], $response['id']);\n+        $this->assertEquals('test5', $response['title']);\n+        $this->assertEquals('/test2/test3/test5', $response['path']);\n+        $this->assertEquals('/test2/test3/testing5', $response['url']);\n \n         // check old node\n         $client->request(\n             'GET',\n-            '/api/nodes/' . $data[0]['id'] . '?webspace=sulu_io&language=en'\n+            '/api/nodes/' . $data[4]['id'] . '?webspace=sulu_io&language=en'\n         );\n         $this->assertHttpStatusCode(200, $client->getResponse());\n         $response = json_decode($client->getResponse()->getContent(), true);\n \n-        $this->assertEquals($data[0]['id'], $response['id']);\n-        $this->assertEquals($data[0]['title'], $response['title']);\n-        $this->assertEquals($data[0]['path'], $response['path']);\n-        $this->assertEquals($data[0]['template'], $response['template']);\n-        $this->assertEquals($data[0]['url'], $response['url']);\n-        $this->assertEquals($data[0]['article'], $response['article']);\n+        $this->assertEquals($data[4]['id'], $response['id']);\n+        $this->assertEquals($data[4]['title'], $response['title']);\n+        $this->assertEquals($data[4]['path'], $response['path']);\n+        $this->assertEquals($data[4]['template'], $response['template']);\n+        $this->assertEquals($data[4]['url'], $response['url']);\n+        $this->assertEquals($data[4]['article'], $response['article']);\n+\n+        $englishRouteNode = $this->session->getNode('/cmf/sulu_io/routes/en/test2/test3/testing5');\n+        $this->assertNotEquals(\n+            $englishRouteNode->getPropertyValue('sulu:content', PropertyType::REFERENCE),\n+            $data[4]['id']\n+        );\n+        $germanRouteNode = $this->session->getNode('/cmf/sulu_io/routes/de/test2/test3/testing5');\n+        $this->assertNotEquals(\n+            $germanRouteNode->getPropertyValue('sulu:content', PropertyType::REFERENCE),","path":"src/Sulu/Bundle/ContentBundle/Tests/Functional/Controller/NodeControllerTest.php","position":115,"original_position":115,"commit_id":"05ac8ff2e2fba410ab78e0492c41156e31c45b1b","original_commit_id":"05ac8ff2e2fba410ab78e0492c41156e31c45b1b","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2016-06-01T12:57:52Z","updated_at":"2016-06-01T12:57:52Z","html_url":"https://github.com/sulu/sulu/pull/2428#discussion_r65354499","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/2428","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/65354499"},"html":{"href":"https://github.com/sulu/sulu/pull/2428#discussion_r65354499"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2428"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2428","id":72054215,"html_url":"https://github.com/sulu/sulu/pull/2428","diff_url":"https://github.com/sulu/sulu/pull/2428.diff","patch_url":"https://github.com/sulu/sulu/pull/2428.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2428","number":2428,"state":"open","locked":false,"title":"removed move and copy methods from ContentMapper","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | no\r\n| New feature? | no\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | none\r\n| Related issues/PRs | none\r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nThis PR removes the `move` method from the `ContentMapper`.\r\n\r\n#### Why?\r\n\r\nBecause it is a prerequisite for #2361 to make it possible to update the URL when pages are moved correctly. In order to make this happen there must not be a `persist` call, as there were in the `copyOrMove` method in the `ContentMapper`.\r\n\r\n#### To Do\r\n\r\n- [ ] Also remove the `copy` method.","created_at":"2016-05-31T17:25:08Z","updated_at":"2016-06-01T12:57:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73ba1fc7d6f477e3c75c47e7901385ee172d7fb1","assignee":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2428/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2428/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2428/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/05ac8ff2e2fba410ab78e0492c41156e31c45b1b","head":{"label":"danrot:enhancement/content-mapper-move-copy","ref":"enhancement/content-mapper-move-copy","sha":"05ac8ff2e2fba410ab78e0492c41156e31c45b1b","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"repo":{"id":52616950,"name":"sulu","full_name":"danrot/sulu","owner":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrot/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/danrot/sulu","forks_url":"https://api.github.com/repos/danrot/sulu/forks","keys_url":"https://api.github.com/repos/danrot/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrot/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrot/sulu/teams","hooks_url":"https://api.github.com/repos/danrot/sulu/hooks","issue_events_url":"https://api.github.com/repos/danrot/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/danrot/sulu/events","assignees_url":"https://api.github.com/repos/danrot/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/danrot/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/danrot/sulu/tags","blobs_url":"https://api.github.com/repos/danrot/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrot/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrot/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrot/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrot/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/danrot/sulu/languages","stargazers_url":"https://api.github.com/repos/danrot/sulu/stargazers","contributors_url":"https://api.github.com/repos/danrot/sulu/contributors","subscribers_url":"https://api.github.com/repos/danrot/sulu/subscribers","subscription_url":"https://api.github.com/repos/danrot/sulu/subscription","commits_url":"https://api.github.com/repos/danrot/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrot/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrot/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrot/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/danrot/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/danrot/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrot/sulu/merges","archive_url":"https://api.github.com/repos/danrot/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrot/sulu/downloads","issues_url":"https://api.github.com/repos/danrot/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/danrot/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/danrot/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/danrot/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrot/sulu/labels{/name}","releases_url":"https://api.github.com/repos/danrot/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/danrot/sulu/deployments","created_at":"2016-02-26T16:22:17Z","updated_at":"2016-02-26T16:22:24Z","pushed_at":"2016-06-01T11:40:26Z","git_url":"git://github.com/danrot/sulu.git","ssh_url":"git@github.com:danrot/sulu.git","clone_url":"https://github.com/danrot/sulu.git","svn_url":"https://github.com/danrot/sulu","homepage":"sulu.io","size":67704,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"5c1572730f616ba1506bee7d68f265d356c60cb2","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-05-24T11:18:57Z","pushed_at":"2016-06-01T12:35:36Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":78371,"stargazers_count":126,"watchers_count":126,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":381,"forks":35,"open_issues":381,"watchers":126,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2428"},"html":{"href":"https://github.com/sulu/sulu/pull/2428"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2428"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2428/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2428/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2428/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/05ac8ff2e2fba410ab78e0492c41156e31c45b1b"}}}}
{"actor":{"display_login":"wachterjohannes"}}