{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/comments/53465635","id":53465635,"diff_hunk":"@@ -52,6 +53,7 @@\n #\n class testing(\n   $version = '1.0',\n+  $sub_version = \"beta\",","path":"test/test_helper.rb","position":12,"original_position":12,"commit_id":"cdaccc8cd6bbf33221a4e683cbbaa7b939dd11e1","original_commit_id":"cdaccc8cd6bbf33221a4e683cbbaa7b939dd11e1","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"Shouldn't the old parser tests also check for the variable?","created_at":"2016-02-19T14:23:34Z","updated_at":"2016-02-19T14:23:34Z","html_url":"https://github.com/theforeman/kafo_parsers/pull/13#discussion_r53465635","pull_request_url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/comments/53465635"},"html":{"href":"https://github.com/theforeman/kafo_parsers/pull/13#discussion_r53465635"},"pull_request":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13","id":59953927,"html_url":"https://github.com/theforeman/kafo_parsers/pull/13","diff_url":"https://github.com/theforeman/kafo_parsers/pull/13.diff","patch_url":"https://github.com/theforeman/kafo_parsers/pull/13.patch","issue_url":"https://api.github.com/repos/theforeman/kafo_parsers/issues/13","number":13,"state":"open","locked":false,"title":"[PoC] Fixes #7848 - introduce parser based on puppet-strings module","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"This PR adds new manifest parser based on [puppet-strings](https://github.com/puppetlabs/puppetlabs-strings). To test you must install it from source since we need features from unreleased version. Note that it does not bring any advanced stuff from puppet 4 dsl (e.g. parameter types) but as longs as types are documented in rdoc syntax, parsing this new dsl should work. It should be possible to add more features later (e.g. use puppet types and fallback to rdoc). The only limitation is that we don't have validations support since we don't parse the code directly.\r\n\r\n - [ ] puppet-strings must be released by puppet labs, existing version does not have json output support\r\n - [ ] packaging of puppet-strings module to be available when we call puppet (install into AIO stack?)\r\n - [ ] switch kafo to start using PuppetStringsModuleParser (trivial)\r\n - [ ] optionally add an extra layer that would choose right parser for local environment","created_at":"2016-02-19T14:12:40Z","updated_at":"2016-02-19T14:23:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea5968de21b93c86fa1c250c7c5abd5c25749760","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13/commits","review_comments_url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13/comments","review_comment_url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/kafo_parsers/issues/13/comments","statuses_url":"https://api.github.com/repos/theforeman/kafo_parsers/statuses/cdaccc8cd6bbf33221a4e683cbbaa7b939dd11e1","head":{"label":"ares:fix/7848","ref":"fix/7848","sha":"cdaccc8cd6bbf33221a4e683cbbaa7b939dd11e1","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"repo":{"id":17594644,"name":"kafo_parsers","full_name":"ares/kafo_parsers","owner":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ares/kafo_parsers","description":"This gem can parse values, validations, documentation, types, groups and conditions of parameters from your puppet modules","fork":true,"url":"https://api.github.com/repos/ares/kafo_parsers","forks_url":"https://api.github.com/repos/ares/kafo_parsers/forks","keys_url":"https://api.github.com/repos/ares/kafo_parsers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ares/kafo_parsers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ares/kafo_parsers/teams","hooks_url":"https://api.github.com/repos/ares/kafo_parsers/hooks","issue_events_url":"https://api.github.com/repos/ares/kafo_parsers/issues/events{/number}","events_url":"https://api.github.com/repos/ares/kafo_parsers/events","assignees_url":"https://api.github.com/repos/ares/kafo_parsers/assignees{/user}","branches_url":"https://api.github.com/repos/ares/kafo_parsers/branches{/branch}","tags_url":"https://api.github.com/repos/ares/kafo_parsers/tags","blobs_url":"https://api.github.com/repos/ares/kafo_parsers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ares/kafo_parsers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ares/kafo_parsers/git/refs{/sha}","trees_url":"https://api.github.com/repos/ares/kafo_parsers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ares/kafo_parsers/statuses/{sha}","languages_url":"https://api.github.com/repos/ares/kafo_parsers/languages","stargazers_url":"https://api.github.com/repos/ares/kafo_parsers/stargazers","contributors_url":"https://api.github.com/repos/ares/kafo_parsers/contributors","subscribers_url":"https://api.github.com/repos/ares/kafo_parsers/subscribers","subscription_url":"https://api.github.com/repos/ares/kafo_parsers/subscription","commits_url":"https://api.github.com/repos/ares/kafo_parsers/commits{/sha}","git_commits_url":"https://api.github.com/repos/ares/kafo_parsers/git/commits{/sha}","comments_url":"https://api.github.com/repos/ares/kafo_parsers/comments{/number}","issue_comment_url":"https://api.github.com/repos/ares/kafo_parsers/issues/comments{/number}","contents_url":"https://api.github.com/repos/ares/kafo_parsers/contents/{+path}","compare_url":"https://api.github.com/repos/ares/kafo_parsers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ares/kafo_parsers/merges","archive_url":"https://api.github.com/repos/ares/kafo_parsers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ares/kafo_parsers/downloads","issues_url":"https://api.github.com/repos/ares/kafo_parsers/issues{/number}","pulls_url":"https://api.github.com/repos/ares/kafo_parsers/pulls{/number}","milestones_url":"https://api.github.com/repos/ares/kafo_parsers/milestones{/number}","notifications_url":"https://api.github.com/repos/ares/kafo_parsers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ares/kafo_parsers/labels{/name}","releases_url":"https://api.github.com/repos/ares/kafo_parsers/releases{/id}","deployments_url":"https://api.github.com/repos/ares/kafo_parsers/deployments","created_at":"2014-03-10T14:03:10Z","updated_at":"2016-02-19T08:44:43Z","pushed_at":"2016-02-19T14:04:24Z","git_url":"git://github.com/ares/kafo_parsers.git","ssh_url":"git@github.com:ares/kafo_parsers.git","clone_url":"https://github.com/ares/kafo_parsers.git","svn_url":"https://github.com/ares/kafo_parsers","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"7a595fa015b6a357d939ff4f57f236af963aaebb","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":17594518,"name":"kafo_parsers","full_name":"theforeman/kafo_parsers","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/kafo_parsers","description":"This gem can parse values, validations, documentation, types, groups and conditions of parameters from your puppet modules","fork":false,"url":"https://api.github.com/repos/theforeman/kafo_parsers","forks_url":"https://api.github.com/repos/theforeman/kafo_parsers/forks","keys_url":"https://api.github.com/repos/theforeman/kafo_parsers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/kafo_parsers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/kafo_parsers/teams","hooks_url":"https://api.github.com/repos/theforeman/kafo_parsers/hooks","issue_events_url":"https://api.github.com/repos/theforeman/kafo_parsers/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/kafo_parsers/events","assignees_url":"https://api.github.com/repos/theforeman/kafo_parsers/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/kafo_parsers/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/kafo_parsers/tags","blobs_url":"https://api.github.com/repos/theforeman/kafo_parsers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/kafo_parsers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/kafo_parsers/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/kafo_parsers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/kafo_parsers/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/kafo_parsers/languages","stargazers_url":"https://api.github.com/repos/theforeman/kafo_parsers/stargazers","contributors_url":"https://api.github.com/repos/theforeman/kafo_parsers/contributors","subscribers_url":"https://api.github.com/repos/theforeman/kafo_parsers/subscribers","subscription_url":"https://api.github.com/repos/theforeman/kafo_parsers/subscription","commits_url":"https://api.github.com/repos/theforeman/kafo_parsers/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/kafo_parsers/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/kafo_parsers/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/kafo_parsers/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/kafo_parsers/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/kafo_parsers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/kafo_parsers/merges","archive_url":"https://api.github.com/repos/theforeman/kafo_parsers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/kafo_parsers/downloads","issues_url":"https://api.github.com/repos/theforeman/kafo_parsers/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/kafo_parsers/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/kafo_parsers/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/kafo_parsers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/kafo_parsers/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/kafo_parsers/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/kafo_parsers/deployments","created_at":"2014-03-10T13:59:41Z","updated_at":"2016-02-11T08:01:32Z","pushed_at":"2016-02-19T14:12:40Z","git_url":"git://github.com/theforeman/kafo_parsers.git","ssh_url":"git@github.com:theforeman/kafo_parsers.git","clone_url":"https://github.com/theforeman/kafo_parsers.git","svn_url":"https://github.com/theforeman/kafo_parsers","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13"},"html":{"href":"https://github.com/theforeman/kafo_parsers/pull/13"},"issue":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/issues/13"},"comments":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/kafo_parsers/statuses/cdaccc8cd6bbf33221a4e683cbbaa7b939dd11e1"}}}}