{"action":"created","comment":{"url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/comments/81102903","pull_request_review_id":1943263,"id":81102903,"diff_hunk":"@@ -11,25 +11,26 @@\n   (start [this]\n     (reset! running? true)\n     (let [engine (future\n-                   (loop [;; TODO naming?\n-                          transformation (.take queue)]\n-                     (when-not (identical? transformation sentinel)\n-                       (let [{:keys [completion-promise tenant-conn job-id dataset-id command]} transformation]\n-                         (condp = (:type command)\n-                           :transformation\n-                           (engine/execute-transformation completion-promise\n-                                                          tenant-conn\n-                                                          job-id\n-                                                          dataset-id\n-                                                          (:transformation command))\n+                   (loop [transformation (.take queue)]\n+                     (try\n+                       (when-not (identical? transformation sentinel)\n+                         (let [{:keys [completion-promise tenant-conn job-id dataset-id command]} transformation]\n+                           (condp = (:type command)\n+                             :transformation\n+                             (engine/execute-transformation completion-promise\n+                                                            tenant-conn\n+                                                            job-id\n+                                                            dataset-id\n+                                                            (:transformation command))\n ","path":"backend/src/org/akvo/lumen/component/transformation_engine.clj","position":null,"original_position":26,"commit_id":"77e37e80df8fe5dc0ea46fb04c11d6c26a58cb44","original_commit_id":"d2947bcd1a92b9d19f5c04340c8f2671cf915762","user":{"login":"kardan","id":31837,"avatar_url":"https://avatars.githubusercontent.com/u/31837?v=3","gravatar_id":"","url":"https://api.github.com/users/kardan","html_url":"https://github.com/kardan","followers_url":"https://api.github.com/users/kardan/followers","following_url":"https://api.github.com/users/kardan/following{/other_user}","gists_url":"https://api.github.com/users/kardan/gists{/gist_id}","starred_url":"https://api.github.com/users/kardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kardan/subscriptions","organizations_url":"https://api.github.com/users/kardan/orgs","repos_url":"https://api.github.com/users/kardan/repos","events_url":"https://api.github.com/users/kardan/events{/privacy}","received_events_url":"https://api.github.com/users/kardan/received_events","type":"User","site_admin":false},"body":"Is this line a misstake?","created_at":"2016-09-29T10:00:54Z","updated_at":"2016-09-29T10:00:54Z","html_url":"https://github.com/akvo/akvo-lumen/pull/375#discussion_r81102903","pull_request_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375","_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/comments/81102903"},"html":{"href":"https://github.com/akvo/akvo-lumen/pull/375#discussion_r81102903"},"pull_request":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375","id":87092676,"html_url":"https://github.com/akvo/akvo-lumen/pull/375","diff_url":"https://github.com/akvo/akvo-lumen/pull/375.diff","patch_url":"https://github.com/akvo/akvo-lumen/pull/375.patch","issue_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/375","number":375,"state":"open","locked":false,"title":"Issue/361 transformation refactor","user":{"login":"jonase","id":101023,"avatar_url":"https://avatars.githubusercontent.com/u/101023?v=3","gravatar_id":"","url":"https://api.github.com/users/jonase","html_url":"https://github.com/jonase","followers_url":"https://api.github.com/users/jonase/followers","following_url":"https://api.github.com/users/jonase/following{/other_user}","gists_url":"https://api.github.com/users/jonase/gists{/gist_id}","starred_url":"https://api.github.com/users/jonase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonase/subscriptions","organizations_url":"https://api.github.com/users/jonase/orgs","repos_url":"https://api.github.com/users/jonase/repos","events_url":"https://api.github.com/users/jonase/events{/privacy}","received_events_url":"https://api.github.com/users/jonase/received_events","type":"User","site_admin":false},"body":"- [x] Test plan | Unit test | Integration test\r\n- [ ] Copyright header\r\n- [x] Code formatting\r\n- [ ] Documentation\r\n","created_at":"2016-09-28T10:24:56Z","updated_at":"2016-09-29T10:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d18628f7bffdb16a5004a7730aa437a7a75a15e8","assignee":{"login":"kardan","id":31837,"avatar_url":"https://avatars.githubusercontent.com/u/31837?v=3","gravatar_id":"","url":"https://api.github.com/users/kardan","html_url":"https://github.com/kardan","followers_url":"https://api.github.com/users/kardan/followers","following_url":"https://api.github.com/users/kardan/following{/other_user}","gists_url":"https://api.github.com/users/kardan/gists{/gist_id}","starred_url":"https://api.github.com/users/kardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kardan/subscriptions","organizations_url":"https://api.github.com/users/kardan/orgs","repos_url":"https://api.github.com/users/kardan/repos","events_url":"https://api.github.com/users/kardan/events{/privacy}","received_events_url":"https://api.github.com/users/kardan/received_events","type":"User","site_admin":false},"assignees":[{"login":"kardan","id":31837,"avatar_url":"https://avatars.githubusercontent.com/u/31837?v=3","gravatar_id":"","url":"https://api.github.com/users/kardan","html_url":"https://github.com/kardan","followers_url":"https://api.github.com/users/kardan/followers","following_url":"https://api.github.com/users/kardan/following{/other_user}","gists_url":"https://api.github.com/users/kardan/gists{/gist_id}","starred_url":"https://api.github.com/users/kardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kardan/subscriptions","organizations_url":"https://api.github.com/users/kardan/orgs","repos_url":"https://api.github.com/users/kardan/repos","events_url":"https://api.github.com/users/kardan/events{/privacy}","received_events_url":"https://api.github.com/users/kardan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375/commits","review_comments_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375/comments","review_comment_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/375/comments","statuses_url":"https://api.github.com/repos/akvo/akvo-lumen/statuses/77e37e80df8fe5dc0ea46fb04c11d6c26a58cb44","head":{"label":"akvo:issue/361-transformation-refactor","ref":"issue/361-transformation-refactor","sha":"77e37e80df8fe5dc0ea46fb04c11d6c26a58cb44","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":44529983,"name":"akvo-lumen","full_name":"akvo/akvo-lumen","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-lumen","description":"Akvo Lumen - An open-source, easy to use data mashup, analysis and publishing platform","fork":false,"url":"https://api.github.com/repos/akvo/akvo-lumen","forks_url":"https://api.github.com/repos/akvo/akvo-lumen/forks","keys_url":"https://api.github.com/repos/akvo/akvo-lumen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-lumen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-lumen/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-lumen/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-lumen/events","assignees_url":"https://api.github.com/repos/akvo/akvo-lumen/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-lumen/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-lumen/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-lumen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-lumen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-lumen/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-lumen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-lumen/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-lumen/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-lumen/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-lumen/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-lumen/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-lumen/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-lumen/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-lumen/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-lumen/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-lumen/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-lumen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-lumen/merges","archive_url":"https://api.github.com/repos/akvo/akvo-lumen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-lumen/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-lumen/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-lumen/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-lumen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-lumen/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-lumen/releases{/id}","deployments_url":"https://api.github.com/repos/akvo/akvo-lumen/deployments","created_at":"2015-10-19T11:25:53Z","updated_at":"2016-09-19T12:49:22Z","pushed_at":"2016-09-29T06:04:13Z","git_url":"git://github.com/akvo/akvo-lumen.git","ssh_url":"git@github.com:akvo/akvo-lumen.git","clone_url":"https://github.com/akvo/akvo-lumen.git","svn_url":"https://github.com/akvo/akvo-lumen","homepage":"http://akvo.org/akvo-lumen/","size":2465,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":43,"forks":1,"open_issues":43,"watchers":3,"default_branch":"develop"}},"base":{"label":"akvo:develop","ref":"develop","sha":"bac484a3ec14625c8ed5751a36bd7de7d4322e93","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":44529983,"name":"akvo-lumen","full_name":"akvo/akvo-lumen","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars.githubusercontent.com/u/159843?v=3","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-lumen","description":"Akvo Lumen - An open-source, easy to use data mashup, analysis and publishing platform","fork":false,"url":"https://api.github.com/repos/akvo/akvo-lumen","forks_url":"https://api.github.com/repos/akvo/akvo-lumen/forks","keys_url":"https://api.github.com/repos/akvo/akvo-lumen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-lumen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-lumen/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-lumen/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-lumen/events","assignees_url":"https://api.github.com/repos/akvo/akvo-lumen/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-lumen/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-lumen/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-lumen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-lumen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-lumen/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-lumen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-lumen/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-lumen/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-lumen/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-lumen/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-lumen/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-lumen/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-lumen/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-lumen/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-lumen/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-lumen/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-lumen/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-lumen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-lumen/merges","archive_url":"https://api.github.com/repos/akvo/akvo-lumen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-lumen/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-lumen/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-lumen/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-lumen/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-lumen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-lumen/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-lumen/releases{/id}","deployments_url":"https://api.github.com/repos/akvo/akvo-lumen/deployments","created_at":"2015-10-19T11:25:53Z","updated_at":"2016-09-19T12:49:22Z","pushed_at":"2016-09-29T06:04:13Z","git_url":"git://github.com/akvo/akvo-lumen.git","ssh_url":"git@github.com:akvo/akvo-lumen.git","clone_url":"https://github.com/akvo/akvo-lumen.git","svn_url":"https://github.com/akvo/akvo-lumen","homepage":"http://akvo.org/akvo-lumen/","size":2465,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":43,"forks":1,"open_issues":43,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375"},"html":{"href":"https://github.com/akvo/akvo-lumen/pull/375"},"issue":{"href":"https://api.github.com/repos/akvo/akvo-lumen/issues/375"},"comments":{"href":"https://api.github.com/repos/akvo/akvo-lumen/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akvo/akvo-lumen/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/akvo/akvo-lumen/statuses/77e37e80df8fe5dc0ea46fb04c11d6c26a58cb44"}}}}
{"actor":{"display_login":"kardan"}}