{"action":"created","comment":{"url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/comments/83784959","pull_request_review_id":4603435,"id":83784959,"diff_hunk":"@@ -16,6 +16,7 @@\n               disableCertificateValidation=\"true\"\n               send_mode=\"%user_send_mode%\"\n               middleware=\"%user_middleware%\"\n+              send_full_throwable=\"%user_send_full_throwable%\"","path":"src/test/resources/log4j2_template.xml","position":4,"original_position":4,"commit_id":"230c5183ec81c3749260e6041b860b4a4b9b0d96","original_commit_id":"230c5183ec81c3749260e6041b860b4a4b9b0d96","user":{"login":"shakeelmohamed","id":1480063,"avatar_url":"https://avatars.githubusercontent.com/u/1480063?v=3","gravatar_id":"","url":"https://api.github.com/users/shakeelmohamed","html_url":"https://github.com/shakeelmohamed","followers_url":"https://api.github.com/users/shakeelmohamed/followers","following_url":"https://api.github.com/users/shakeelmohamed/following{/other_user}","gists_url":"https://api.github.com/users/shakeelmohamed/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelmohamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelmohamed/subscriptions","organizations_url":"https://api.github.com/users/shakeelmohamed/orgs","repos_url":"https://api.github.com/users/shakeelmohamed/repos","events_url":"https://api.github.com/users/shakeelmohamed/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelmohamed/received_events","type":"User","site_admin":false},"body":"`send_throwable`","created_at":"2016-10-18T05:46:36Z","updated_at":"2016-10-18T05:47:19Z","html_url":"https://github.com/splunk/splunk-library-javalogging/pull/40#discussion_r83784959","pull_request_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/comments/83784959"},"html":{"href":"https://github.com/splunk/splunk-library-javalogging/pull/40#discussion_r83784959"},"pull_request":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40","id":89739973,"html_url":"https://github.com/splunk/splunk-library-javalogging/pull/40","diff_url":"https://github.com/splunk/splunk-library-javalogging/pull/40.diff","patch_url":"https://github.com/splunk/splunk-library-javalogging/pull/40.patch","issue_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/40","number":40,"state":"open","locked":false,"title":"Add support to send full exception information in events in log4j2","user":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"body":"Addresses #39.\r\n\r\nCurrently, only log4j2 is configurable to use the new capability, although all logger implementations with access to the Throwable should be able to make use of it.\r\n\r\nProduces messages like:\r\n\r\n```\r\n{  \r\n   \"severity\":\"ERROR\",\r\n   \"logger\":\"splunkLogger4j2\",\r\n   \"throwable\":{  \r\n      \"throwable_class\":\"java.lang.RuntimeException\",\r\n      \"cause\":{  \r\n         \"throwable_class\":\"java.lang.IllegalArgumentException\",\r\n         \"cause\":{  \r\n            \"throwable_class\":\"java.lang.IllegalArgumentException\",\r\n            \"stack_trace\":[  \r\n               \"HttpEventCollector_Log4j2Test.canSendEventWithNestedThrowableUsingLog4j2(HttpEventCollector_Log4j2Test.java:114)\"\r\n            ],\r\n            \"throwable_message\":\"cause cause\"\r\n         },\r\n         \"stack_trace\":[  \r\n            \"HttpEventCollector_Log4j2Test.canSendEventWithNestedThrowableUsingLog4j2(HttpEventCollector_Log4j2Test.java:115)\"\r\n         ],\r\n         \"throwable_message\":\"cause\"\r\n      },\r\n      \"stack_trace\":[  \r\n         \"HttpEventCollector_Log4j2Test.canSendEventWithNestedThrowableUsingLog4j2(HttpEventCollector_Log4j2Test.java:116)\",\r\n         \"sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\",\r\n         \"sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\",\r\n         \"sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\",\r\n         \"java.lang.reflect.Method.invoke(Method.java:497)\",\r\n         \"org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)\",\r\n         \"org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)\",\r\n         \"org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)\",\r\n         \"org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)\",\r\n         \"org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)\",\r\n         \"org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)\",\r\n         \"org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)\",\r\n         \"org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)\",\r\n         \"org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)\",\r\n         \"org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)\",\r\n         \"org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)\",\r\n         \"org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)\",\r\n         \"org.junit.runners.ParentRunner.run(ParentRunner.java:309)\",\r\n         \"org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)\",\r\n         \"org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)\",\r\n         \"org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)\",\r\n         \"org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)\",\r\n         \"org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)\",\r\n         \"org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)\"\r\n      ],\r\n      \"throwable_message\":\"fail whale\"\r\n   },\r\n   \"thread\":\"main\",\r\n   \"message\":\"this is an error message c1712273-38f5-4e52-9718-e0eb9754ed96\"\r\n}\r\n```\r\nwhen the `send_full_throwable` property is set to true. Otherwise, will follow current behaviour of sending exception message only.","created_at":"2016-10-18T03:14:07Z","updated_at":"2016-10-18T05:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bac56440fa6374e621bc09fa98f1689ff51dc445","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40/commits","review_comments_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40/comments","review_comment_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/40/comments","statuses_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/statuses/230c5183ec81c3749260e6041b860b4a4b9b0d96","head":{"label":"dspasojevic:master","ref":"master","sha":"230c5183ec81c3749260e6041b860b4a4b9b0d96","user":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"repo":{"id":71193945,"name":"splunk-library-javalogging","full_name":"dspasojevic/splunk-library-javalogging","owner":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dspasojevic/splunk-library-javalogging","description":"Splunk logging appenders for popular Java Logging frameworks","fork":true,"url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging","forks_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/forks","keys_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/teams","hooks_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/hooks","issue_events_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/issues/events{/number}","events_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/events","assignees_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/assignees{/user}","branches_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/branches{/branch}","tags_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/tags","blobs_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/git/refs{/sha}","trees_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/statuses/{sha}","languages_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/languages","stargazers_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/stargazers","contributors_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/contributors","subscribers_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/subscribers","subscription_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/subscription","commits_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/commits{/sha}","git_commits_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/git/commits{/sha}","comments_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/comments{/number}","issue_comment_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/issues/comments{/number}","contents_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/contents/{+path}","compare_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/merges","archive_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/downloads","issues_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/issues{/number}","pulls_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/pulls{/number}","milestones_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/milestones{/number}","notifications_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/labels{/name}","releases_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/releases{/id}","deployments_url":"https://api.github.com/repos/dspasojevic/splunk-library-javalogging/deployments","created_at":"2016-10-18T00:49:59Z","updated_at":"2016-10-18T00:50:01Z","pushed_at":"2016-10-18T05:33:23Z","git_url":"git://github.com/dspasojevic/splunk-library-javalogging.git","ssh_url":"git@github.com:dspasojevic/splunk-library-javalogging.git","clone_url":"https://github.com/dspasojevic/splunk-library-javalogging.git","svn_url":"https://github.com/dspasojevic/splunk-library-javalogging","homepage":"","size":26969,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"splunk:develop","ref":"develop","sha":"acefac5b2bf3d0e63f8d1e690c0ebd88c5e7a578","user":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"repo":{"id":3371841,"name":"splunk-library-javalogging","full_name":"splunk/splunk-library-javalogging","owner":{"login":"splunk","id":651467,"avatar_url":"https://avatars.githubusercontent.com/u/651467?v=3","gravatar_id":"","url":"https://api.github.com/users/splunk","html_url":"https://github.com/splunk","followers_url":"https://api.github.com/users/splunk/followers","following_url":"https://api.github.com/users/splunk/following{/other_user}","gists_url":"https://api.github.com/users/splunk/gists{/gist_id}","starred_url":"https://api.github.com/users/splunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splunk/subscriptions","organizations_url":"https://api.github.com/users/splunk/orgs","repos_url":"https://api.github.com/users/splunk/repos","events_url":"https://api.github.com/users/splunk/events{/privacy}","received_events_url":"https://api.github.com/users/splunk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splunk/splunk-library-javalogging","description":"Splunk logging appenders for popular Java Logging frameworks","fork":false,"url":"https://api.github.com/repos/splunk/splunk-library-javalogging","forks_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/forks","keys_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/teams","hooks_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/hooks","issue_events_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/events{/number}","events_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/events","assignees_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/assignees{/user}","branches_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/branches{/branch}","tags_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/tags","blobs_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/git/refs{/sha}","trees_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/statuses/{sha}","languages_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/languages","stargazers_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/stargazers","contributors_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/contributors","subscribers_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/subscribers","subscription_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/subscription","commits_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/commits{/sha}","git_commits_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/git/commits{/sha}","comments_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/comments{/number}","issue_comment_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/comments{/number}","contents_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/contents/{+path}","compare_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/merges","archive_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/downloads","issues_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues{/number}","pulls_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls{/number}","milestones_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/milestones{/number}","notifications_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/labels{/name}","releases_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/releases{/id}","deployments_url":"https://api.github.com/repos/splunk/splunk-library-javalogging/deployments","created_at":"2012-02-06T22:34:13Z","updated_at":"2016-09-11T23:17:50Z","pushed_at":"2016-10-18T05:40:19Z","git_url":"git://github.com/splunk/splunk-library-javalogging.git","ssh_url":"git@github.com:splunk/splunk-library-javalogging.git","clone_url":"https://github.com/splunk/splunk-library-javalogging.git","svn_url":"https://github.com/splunk/splunk-library-javalogging","homepage":"","size":27197,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":15,"forks":46,"open_issues":15,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40"},"html":{"href":"https://github.com/splunk/splunk-library-javalogging/pull/40"},"issue":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/40"},"comments":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/splunk/splunk-library-javalogging/statuses/230c5183ec81c3749260e6041b860b4a4b9b0d96"}}}}
{"actor":{"display_login":"shakeelmohamed"}}