{"action":"created","issue":{"url":"https://api.github.com/repos/weecology/retriever/issues/511","repository_url":"https://api.github.com/repos/weecology/retriever","labels_url":"https://api.github.com/repos/weecology/retriever/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/weecology/retriever/issues/511/comments","events_url":"https://api.github.com/repos/weecology/retriever/issues/511/events","html_url":"https://github.com/weecology/retriever/pull/511","id":158974509,"number":511,"title":"improve tests platform","user":{"login":"henrykironde","id":5192965,"avatar_url":"https://avatars.githubusercontent.com/u/5192965?v=3","gravatar_id":"","url":"https://api.github.com/users/henrykironde","html_url":"https://github.com/henrykironde","followers_url":"https://api.github.com/users/henrykironde/followers","following_url":"https://api.github.com/users/henrykironde/following{/other_user}","gists_url":"https://api.github.com/users/henrykironde/gists{/gist_id}","starred_url":"https://api.github.com/users/henrykironde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrykironde/subscriptions","organizations_url":"https://api.github.com/users/henrykironde/orgs","repos_url":"https://api.github.com/users/henrykironde/repos","events_url":"https://api.github.com/users/henrykironde/events{/privacy}","received_events_url":"https://api.github.com/users/henrykironde/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/weecology/retriever/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-07T17:02:42Z","updated_at":"2016-06-08T01:02:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weecology/retriever/pulls/511","html_url":"https://github.com/weecology/retriever/pull/511","diff_url":"https://github.com/weecology/retriever/pull/511.diff","patch_url":"https://github.com/weecology/retriever/pull/511.patch"},"body":"Add appveyor\r\nimprove regression tests\r\nremove server dependency by dumping csv files using the excel dialect(function to_csv)\r\nsort files when getting md5sums for files in directory\r\nadd xml and json tests\r\nadd unit tests for the functions used in testing"},"comment":{"url":"https://api.github.com/repos/weecology/retriever/issues/comments/224458742","html_url":"https://github.com/weecology/retriever/pull/511#issuecomment-224458742","issue_url":"https://api.github.com/repos/weecology/retriever/issues/511","id":224458742,"user":{"login":"ethanwhite","id":744427,"avatar_url":"https://avatars.githubusercontent.com/u/744427?v=3","gravatar_id":"","url":"https://api.github.com/users/ethanwhite","html_url":"https://github.com/ethanwhite","followers_url":"https://api.github.com/users/ethanwhite/followers","following_url":"https://api.github.com/users/ethanwhite/following{/other_user}","gists_url":"https://api.github.com/users/ethanwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/ethanwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethanwhite/subscriptions","organizations_url":"https://api.github.com/users/ethanwhite/orgs","repos_url":"https://api.github.com/users/ethanwhite/repos","events_url":"https://api.github.com/users/ethanwhite/events{/privacy}","received_events_url":"https://api.github.com/users/ethanwhite/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T01:02:30Z","updated_at":"2016-06-08T01:02:30Z","body":"This looks really great @henrykironde! I've made some minor cleanup suggestions in-line.\r\n\r\nThe one more major suggestion relates tests you've added to the end of `test_retriever.py`. In general I don't think we want to use hashes for unit tests like these, because we can't easily see if the hash represents the answer we want or not. Instead we want to compare the resulting file directly to what it should look like as a string. There are some examples of this in `test_integration.py`.\r\n\r\nThanks again for all your hard work on this. It's getting super close."}}
{"actor":{"display_login":"ethanwhite"}}