{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/350","repository_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/350/comments","events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/350/events","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/350","id":155888048,"number":350,"title":"Add global notices","user":{"login":"jkudish","id":260253,"avatar_url":"https://avatars.githubusercontent.com/u/260253?v=3","gravatar_id":"","url":"https://api.github.com/users/jkudish","html_url":"https://github.com/jkudish","followers_url":"https://api.github.com/users/jkudish/followers","following_url":"https://api.github.com/users/jkudish/following{/other_user}","gists_url":"https://api.github.com/users/jkudish/gists{/gist_id}","starred_url":"https://api.github.com/users/jkudish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkudish/subscriptions","organizations_url":"https://api.github.com/users/jkudish/orgs","repos_url":"https://api.github.com/users/jkudish/repos","events_url":"https://api.github.com/users/jkudish/events{/privacy}","received_events_url":"https://api.github.com/users/jkudish/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/UI%20/%20UX","name":"UI / UX","color":"0e8a16"},{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"jkudish","id":260253,"avatar_url":"https://avatars.githubusercontent.com/u/260253?v=3","gravatar_id":"","url":"https://api.github.com/users/jkudish","html_url":"https://github.com/jkudish","followers_url":"https://api.github.com/users/jkudish/followers","following_url":"https://api.github.com/users/jkudish/following{/other_user}","gists_url":"https://api.github.com/users/jkudish/gists{/gist_id}","starred_url":"https://api.github.com/users/jkudish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkudish/subscriptions","organizations_url":"https://api.github.com/users/jkudish/orgs","repos_url":"https://api.github.com/users/jkudish/repos","events_url":"https://api.github.com/users/jkudish/events{/privacy}","received_events_url":"https://api.github.com/users/jkudish/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/2","html_url":"https://github.com/Automattic/woocommerce-connect-client/milestones/Beta%20(5/26)","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/2/labels","id":1593823,"number":2,"title":"Beta (5/26)","description":"includes\r\n- USPS service selection and adjustment\r\n- package definition\r\n- USPS form being completely schema/layout driven\r\n- showing packing details in Edit Order, My Account\r\n\r\nstretch goal, includes\r\n- Canada Post","creator":{"login":"allendav","id":1595739,"avatar_url":"https://avatars.githubusercontent.com/u/1595739?v=3","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":79,"state":"open","created_at":"2016-02-19T19:18:19Z","updated_at":"2016-05-20T18:10:07Z","due_on":"2016-05-26T07:00:00Z","closed_at":null},"comments":5,"created_at":"2016-05-20T05:09:15Z","updated_at":"2016-05-23T18:19:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/350","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/350","diff_url":"https://github.com/Automattic/woocommerce-connect-client/pull/350.diff","patch_url":"https://github.com/Automattic/woocommerce-connect-client/pull/350.patch"},"body":"This PR seeks to replace the existing inline save/error notices and add global notices instead. It re-uses the Calypso `GlobalNotices` component and the associated state tree (reducer/actions). In order to get that to work properly, this PR also introduces some changes to the i18n boot/mixin system so that it works with `this.translate` in Calypso components properly.\r\n\r\nSuccess:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/260253/15450331/26433e72-1f4d-11e6-8337-7a7710e0ff3f.png)\r\n\r\nError:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/260253/15450350/a42b0860-1f4d-11e6-92ad-8395dee1b102.png)\r\n\r\n\r\nTo test:\r\n\r\n* Checkout this PR\r\n* Ensure everything compiles as expected\r\n* Save the USPS form with different conditions generating error and success states\r\n* Ensure that notices are generated as expected\r\n* Success notices should disappear after 2250ms\r\n* Error notices persist for 7s. I chose this semi-arbitrarily, so definitely welcome to change this up.\r\n\r\nNote: the global notices may generate a React Warning, which has been addressed here: https://github.com/Automattic/wp-calypso/pull/5506 -- You can update your npm checkout of Calypso to fix the warning.\r\n\r\ncc @kellychoffman for a design review (there's definitely a few small css tweaks to be made here)\r\n\r\ncc @nabsul @allendav @jeffstieler \r\n\r\n Fixes #322"},"comment":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/comments/221052318","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/350#issuecomment-221052318","issue_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/350","id":221052318,"user":{"login":"kellychoffman","id":5835847,"avatar_url":"https://avatars.githubusercontent.com/u/5835847?v=3","gravatar_id":"","url":"https://api.github.com/users/kellychoffman","html_url":"https://github.com/kellychoffman","followers_url":"https://api.github.com/users/kellychoffman/followers","following_url":"https://api.github.com/users/kellychoffman/following{/other_user}","gists_url":"https://api.github.com/users/kellychoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/kellychoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellychoffman/subscriptions","organizations_url":"https://api.github.com/users/kellychoffman/orgs","repos_url":"https://api.github.com/users/kellychoffman/repos","events_url":"https://api.github.com/users/kellychoffman/events{/privacy}","received_events_url":"https://api.github.com/users/kellychoffman/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T18:19:20Z","updated_at":"2016-05-23T18:19:20Z","body":"Thanks for the heads up. None of my messages were that long when I tested :/ \r\n\r\nShould be all good now. "}}
{"actor":{"display_login":"kellychoffman"}}