{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/comments/65689204","id":65689204,"diff_hunk":"@@ -114,6 +114,11 @@ $brexit-control-button-size: 28px;\n     min-height: $baseline * 2;\n     padding-bottom: $baseline * 1.5;\n }\n+.brexit__content {","path":"src/css/embed.scss","position":4,"original_position":4,"commit_id":"c683caab028a35d3830789dad192ec1cedffce3b","original_commit_id":"4c221d02731fb44afd791e9ad40284c30f0469f6","user":{"login":"SiAdcock","id":5931528,"avatar_url":"https://avatars.githubusercontent.com/u/5931528?v=3","gravatar_id":"","url":"https://api.github.com/users/SiAdcock","html_url":"https://github.com/SiAdcock","followers_url":"https://api.github.com/users/SiAdcock/followers","following_url":"https://api.github.com/users/SiAdcock/following{/other_user}","gists_url":"https://api.github.com/users/SiAdcock/gists{/gist_id}","starred_url":"https://api.github.com/users/SiAdcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiAdcock/subscriptions","organizations_url":"https://api.github.com/users/SiAdcock/orgs","repos_url":"https://api.github.com/users/SiAdcock/repos","events_url":"https://api.github.com/users/SiAdcock/events{/privacy}","received_events_url":"https://api.github.com/users/SiAdcock/received_events","type":"User","site_admin":false},"body":"This is used in the big number carousel. It is unaffected as all styles are overridden. Arguably this CSS needs a bit of TLC. ","created_at":"2016-06-03T10:45:10Z","updated_at":"2016-06-03T10:45:10Z","html_url":"https://github.com/guardian/interactive-brexit-companion/pull/33#discussion_r65689204","pull_request_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/comments/65689204"},"html":{"href":"https://github.com/guardian/interactive-brexit-companion/pull/33#discussion_r65689204"},"pull_request":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33","id":72469180,"html_url":"https://github.com/guardian/interactive-brexit-companion/pull/33","diff_url":"https://github.com/guardian/interactive-brexit-companion/pull/33.diff","patch_url":"https://github.com/guardian/interactive-brexit-companion/pull/33.patch","issue_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/33","number":33,"state":"open","locked":false,"title":"Expandable content splitting","user":{"login":"SiAdcock","id":5931528,"avatar_url":"https://avatars.githubusercontent.com/u/5931528?v=3","gravatar_id":"","url":"https://api.github.com/users/SiAdcock","html_url":"https://github.com/SiAdcock","followers_url":"https://api.github.com/users/SiAdcock/followers","following_url":"https://api.github.com/users/SiAdcock/following{/other_user}","gists_url":"https://api.github.com/users/SiAdcock/gists{/gist_id}","starred_url":"https://api.github.com/users/SiAdcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiAdcock/subscriptions","organizations_url":"https://api.github.com/users/SiAdcock/orgs","repos_url":"https://api.github.com/users/SiAdcock/repos","events_url":"https://api.github.com/users/SiAdcock/events{/privacy}","received_events_url":"https://api.github.com/users/SiAdcock/received_events","type":"User","site_admin":false},"body":"Currently, copy for expandable atoms is split at 65 words. Initially, the first 65 words are shown and if the user clicks \"Show more...\" the remainder of the words are shown.\r\n\r\nThis change shows the first 65 words initially in its own `div`. If the user clicks \"Show more...\", this `div` is hidden and another `div` containing all the content is shown. If the user clicks \"Show less\", the `div` containing all content is hidden and the `div` containing the first 65 words is shown.\r\n\r\n![picture 13](https://cloud.githubusercontent.com/assets/5931528/15772849/7e86ade4-296b-11e6-9db4-6c7006dc1f0d.png)\r\n\r\nThe purpose of this PR is to better support HTML embedded in copy in the gudocs spreadsheet.\r\n\r\n## Known limitations\r\n\r\n1. If the content is split midway through an element (e.g. if word 64 is `<a` and word 65 is `href=\"http://example.com\">`), the tag is never closed and the behaviour becomes unpredictable. In the future we could support a basic markdown-like syntax to avoid HTML injection altogether.\r\n2. If content in the spreadsheet is wrapped in a block element (e.g. `<ul> ... </ul>`), the \"Show less\" link will not appear inline with the content, and will appear below the content.\r\n\r\n![picture 14](https://cloud.githubusercontent.com/assets/5931528/15772903/d43ceba4-296b-11e6-9104-f21de3a365c0.png)\r\n","created_at":"2016-06-03T08:12:32Z","updated_at":"2016-06-03T10:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e8113e694b724b5afe7cb21f9b0413bb79c20ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33/commits","review_comments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33/comments","review_comment_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/33/comments","statuses_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/statuses/c683caab028a35d3830789dad192ec1cedffce3b","head":{"label":"guardian:expandable-content-splitting","ref":"expandable-content-splitting","sha":"c683caab028a35d3830789dad192ec1cedffce3b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":57047245,"name":"interactive-brexit-companion","full_name":"guardian/interactive-brexit-companion","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/interactive-brexit-companion","description":"Placeholder description: @joelochlann created this with repo-genesis","fork":false,"url":"https://api.github.com/repos/guardian/interactive-brexit-companion","forks_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/forks","keys_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/teams","hooks_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/hooks","issue_events_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/events","assignees_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/tags","blobs_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/languages","stargazers_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/stargazers","contributors_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/contributors","subscribers_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/subscribers","subscription_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/subscription","commits_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/merges","archive_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/downloads","issues_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/labels{/name}","releases_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/deployments","created_at":"2016-04-25T14:13:57Z","updated_at":"2016-04-25T14:20:34Z","pushed_at":"2016-06-03T10:44:21Z","git_url":"git://github.com/guardian/interactive-brexit-companion.git","ssh_url":"git@github.com:guardian/interactive-brexit-companion.git","clone_url":"https://github.com/guardian/interactive-brexit-companion.git","svn_url":"https://github.com/guardian/interactive-brexit-companion","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"29db1eb503e8dfdc9050678b3c626ded70254c8b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":57047245,"name":"interactive-brexit-companion","full_name":"guardian/interactive-brexit-companion","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/interactive-brexit-companion","description":"Placeholder description: @joelochlann created this with repo-genesis","fork":false,"url":"https://api.github.com/repos/guardian/interactive-brexit-companion","forks_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/forks","keys_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/teams","hooks_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/hooks","issue_events_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/events","assignees_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/tags","blobs_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/languages","stargazers_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/stargazers","contributors_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/contributors","subscribers_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/subscribers","subscription_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/subscription","commits_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/merges","archive_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/downloads","issues_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/labels{/name}","releases_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/interactive-brexit-companion/deployments","created_at":"2016-04-25T14:13:57Z","updated_at":"2016-04-25T14:20:34Z","pushed_at":"2016-06-03T10:44:21Z","git_url":"git://github.com/guardian/interactive-brexit-companion.git","ssh_url":"git@github.com:guardian/interactive-brexit-companion.git","clone_url":"https://github.com/guardian/interactive-brexit-companion.git","svn_url":"https://github.com/guardian/interactive-brexit-companion","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33"},"html":{"href":"https://github.com/guardian/interactive-brexit-companion/pull/33"},"issue":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/33"},"comments":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/interactive-brexit-companion/statuses/c683caab028a35d3830789dad192ec1cedffce3b"}}}}
{"actor":{"display_login":"SiAdcock"}}