{"action":"closed","number":929,"pull_request":{"url":"https://api.github.com/repos/falconry/falcon/pulls/929","id":88367587,"html_url":"https://github.com/falconry/falcon/pull/929","diff_url":"https://github.com/falconry/falcon/pull/929.diff","patch_url":"https://github.com/falconry/falcon/pull/929.patch","issue_url":"https://api.github.com/repos/falconry/falcon/issues/929","number":929,"state":"closed","locked":false,"title":"fix(Response): Convert header values to str if needed","user":{"login":"kgriffs","id":719939,"avatar_url":"https://avatars.githubusercontent.com/u/719939?v=3","gravatar_id":"","url":"https://api.github.com/users/kgriffs","html_url":"https://github.com/kgriffs","followers_url":"https://api.github.com/users/kgriffs/followers","following_url":"https://api.github.com/users/kgriffs/following{/other_user}","gists_url":"https://api.github.com/users/kgriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/kgriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgriffs/subscriptions","organizations_url":"https://api.github.com/users/kgriffs/orgs","repos_url":"https://api.github.com/users/kgriffs/repos","events_url":"https://api.github.com/users/kgriffs/events{/privacy}","received_events_url":"https://api.github.com/users/kgriffs/received_events","type":"User","site_admin":false},"body":"[Note: merge before cutting 1.1rc1]\r\n\r\nThis issue was partially addressed by #490. In this patch, also\r\nensure that header property setters are converting to str. Also\r\noptimize the logic by inlining it and using str() instead of\r\nstr.encode().\r\n\r\nAlso update docstrings to reference \"US-ASCII\" instead of\r\n\"ISO-8559-1\". The latter is technically what is specified in the\r\nWSGI spec, but the HTTP RFCs restrict header text to \"US-ASCII\" so\r\nthere is no reason to expect/allow additional characters.\r\n\r\nFixes #413","created_at":"2016-10-07T01:12:00Z","updated_at":"2016-10-12T18:47:27Z","closed_at":"2016-10-12T18:47:26Z","merged_at":"2016-10-12T18:47:26Z","merge_commit_sha":"1df06003c429c4d392beda5ee3a534f4938a2891","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/falconry/falcon/pulls/929/commits","review_comments_url":"https://api.github.com/repos/falconry/falcon/pulls/929/comments","review_comment_url":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/falconry/falcon/issues/929/comments","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/a863223751ab9cc4ee65c9519eb93ede18d20d47","head":{"label":"kgriffs:issues/413","ref":"issues/413","sha":"a863223751ab9cc4ee65c9519eb93ede18d20d47","user":{"login":"kgriffs","id":719939,"avatar_url":"https://avatars.githubusercontent.com/u/719939?v=3","gravatar_id":"","url":"https://api.github.com/users/kgriffs","html_url":"https://github.com/kgriffs","followers_url":"https://api.github.com/users/kgriffs/followers","following_url":"https://api.github.com/users/kgriffs/following{/other_user}","gists_url":"https://api.github.com/users/kgriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/kgriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgriffs/subscriptions","organizations_url":"https://api.github.com/users/kgriffs/orgs","repos_url":"https://api.github.com/users/kgriffs/repos","events_url":"https://api.github.com/users/kgriffs/events{/privacy}","received_events_url":"https://api.github.com/users/kgriffs/received_events","type":"User","site_admin":false},"repo":{"id":7903192,"name":"falcon","full_name":"kgriffs/falcon","owner":{"login":"kgriffs","id":719939,"avatar_url":"https://avatars.githubusercontent.com/u/719939?v=3","gravatar_id":"","url":"https://api.github.com/users/kgriffs","html_url":"https://github.com/kgriffs","followers_url":"https://api.github.com/users/kgriffs/followers","following_url":"https://api.github.com/users/kgriffs/following{/other_user}","gists_url":"https://api.github.com/users/kgriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/kgriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgriffs/subscriptions","organizations_url":"https://api.github.com/users/kgriffs/orgs","repos_url":"https://api.github.com/users/kgriffs/repos","events_url":"https://api.github.com/users/kgriffs/events{/privacy}","received_events_url":"https://api.github.com/users/kgriffs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgriffs/falcon","description":"Falcon is a fast, light-weight framework for building cloud APIs.","fork":true,"url":"https://api.github.com/repos/kgriffs/falcon","forks_url":"https://api.github.com/repos/kgriffs/falcon/forks","keys_url":"https://api.github.com/repos/kgriffs/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgriffs/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgriffs/falcon/teams","hooks_url":"https://api.github.com/repos/kgriffs/falcon/hooks","issue_events_url":"https://api.github.com/repos/kgriffs/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/kgriffs/falcon/events","assignees_url":"https://api.github.com/repos/kgriffs/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/kgriffs/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/kgriffs/falcon/tags","blobs_url":"https://api.github.com/repos/kgriffs/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgriffs/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgriffs/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgriffs/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgriffs/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/kgriffs/falcon/languages","stargazers_url":"https://api.github.com/repos/kgriffs/falcon/stargazers","contributors_url":"https://api.github.com/repos/kgriffs/falcon/contributors","subscribers_url":"https://api.github.com/repos/kgriffs/falcon/subscribers","subscription_url":"https://api.github.com/repos/kgriffs/falcon/subscription","commits_url":"https://api.github.com/repos/kgriffs/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgriffs/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgriffs/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgriffs/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgriffs/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/kgriffs/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgriffs/falcon/merges","archive_url":"https://api.github.com/repos/kgriffs/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgriffs/falcon/downloads","issues_url":"https://api.github.com/repos/kgriffs/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/kgriffs/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/kgriffs/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/kgriffs/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgriffs/falcon/labels{/name}","releases_url":"https://api.github.com/repos/kgriffs/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/kgriffs/falcon/deployments","created_at":"2013-01-29T22:58:41Z","updated_at":"2015-05-08T17:32:40Z","pushed_at":"2016-10-11T23:28:01Z","git_url":"git://github.com/kgriffs/falcon.git","ssh_url":"git@github.com:kgriffs/falcon.git","clone_url":"https://github.com/kgriffs/falcon.git","svn_url":"https://github.com/kgriffs/falcon","homepage":"http://falconframework.org","size":3138,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"falconry:master","ref":"master","sha":"12ddc48e34e817d90b3b7d3b12c11ae64aa72bc1","user":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"repo":{"id":7040500,"name":"falcon","full_name":"falconry/falcon","owner":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/falconry/falcon","description":"Falcon is a low-level, high-performance Python framework for building HTTP APIs, app backends, and higher-level frameworks.","fork":false,"url":"https://api.github.com/repos/falconry/falcon","forks_url":"https://api.github.com/repos/falconry/falcon/forks","keys_url":"https://api.github.com/repos/falconry/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falconry/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falconry/falcon/teams","hooks_url":"https://api.github.com/repos/falconry/falcon/hooks","issue_events_url":"https://api.github.com/repos/falconry/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/falconry/falcon/events","assignees_url":"https://api.github.com/repos/falconry/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/falconry/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/falconry/falcon/tags","blobs_url":"https://api.github.com/repos/falconry/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falconry/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falconry/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/falconry/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/falconry/falcon/languages","stargazers_url":"https://api.github.com/repos/falconry/falcon/stargazers","contributors_url":"https://api.github.com/repos/falconry/falcon/contributors","subscribers_url":"https://api.github.com/repos/falconry/falcon/subscribers","subscription_url":"https://api.github.com/repos/falconry/falcon/subscription","commits_url":"https://api.github.com/repos/falconry/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/falconry/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/falconry/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/falconry/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/falconry/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/falconry/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falconry/falcon/merges","archive_url":"https://api.github.com/repos/falconry/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falconry/falcon/downloads","issues_url":"https://api.github.com/repos/falconry/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/falconry/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/falconry/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/falconry/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falconry/falcon/labels{/name}","releases_url":"https://api.github.com/repos/falconry/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/falconry/falcon/deployments","created_at":"2012-12-06T18:17:51Z","updated_at":"2016-10-12T13:40:23Z","pushed_at":"2016-10-12T18:47:26Z","git_url":"git://github.com/falconry/falcon.git","ssh_url":"git@github.com:falconry/falcon.git","clone_url":"https://github.com/falconry/falcon.git","svn_url":"https://github.com/falconry/falcon","homepage":"https://falcon.readthedocs.io/en/stable/","size":27187,"stargazers_count":3276,"watchers_count":3276,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":374,"mirror_url":null,"open_issues_count":144,"forks":374,"open_issues":144,"watchers":3276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/929"},"html":{"href":"https://github.com/falconry/falcon/pull/929"},"issue":{"href":"https://api.github.com/repos/falconry/falcon/issues/929"},"comments":{"href":"https://api.github.com/repos/falconry/falcon/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/falconry/falcon/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/falconry/falcon/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/falconry/falcon/statuses/a863223751ab9cc4ee65c9519eb93ede18d20d47"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fxfitz","id":6355826,"avatar_url":"https://avatars.githubusercontent.com/u/6355826?v=3","gravatar_id":"","url":"https://api.github.com/users/fxfitz","html_url":"https://github.com/fxfitz","followers_url":"https://api.github.com/users/fxfitz/followers","following_url":"https://api.github.com/users/fxfitz/following{/other_user}","gists_url":"https://api.github.com/users/fxfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/fxfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxfitz/subscriptions","organizations_url":"https://api.github.com/users/fxfitz/orgs","repos_url":"https://api.github.com/users/fxfitz/repos","events_url":"https://api.github.com/users/fxfitz/events{/privacy}","received_events_url":"https://api.github.com/users/fxfitz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":99,"deletions":40,"changed_files":3}}
{"actor":{"display_login":"fxfitz"}}