{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/3723","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/3723/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/3723/comments","events_url":"https://api.github.com/repos/keybase/client/issues/3723/events","html_url":"https://github.com/keybase/client/pull/3723","id":169020119,"number":3723,"title":"Engine based libkbfs.KeybaseService impl instead of loopback","user":{"login":"gabriel","id":2669,"avatar_url":"https://avatars.githubusercontent.com/u/2669?v=3","gravatar_id":"","url":"https://api.github.com/users/gabriel","html_url":"https://github.com/gabriel","followers_url":"https://api.github.com/users/gabriel/followers","following_url":"https://api.github.com/users/gabriel/following{/other_user}","gists_url":"https://api.github.com/users/gabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel/subscriptions","organizations_url":"https://api.github.com/users/gabriel/orgs","repos_url":"https://api.github.com/users/gabriel/repos","events_url":"https://api.github.com/users/gabriel/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-03T00:29:42Z","updated_at":"2016-08-04T23:43:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3723","html_url":"https://github.com/keybase/client/pull/3723","diff_url":"https://github.com/keybase/client/pull/3723.diff","patch_url":"https://github.com/keybase/client/pull/3723.patch"},"body":"This is still in progress but the idea is, instead of reading/writing to a socket file that the service is listening to and doing RPC socket msgpack stuff, you can call the engine directly.\r\n\r\nKBFS has a very clear interface/definition of what it needs from the service. We can implement it directly by calling into the engine stuff."},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/237718564","html_url":"https://github.com/keybase/client/pull/3723#issuecomment-237718564","issue_url":"https://api.github.com/repos/keybase/client/issues/3723","id":237718564,"user":{"login":"gabriel","id":2669,"avatar_url":"https://avatars.githubusercontent.com/u/2669?v=3","gravatar_id":"","url":"https://api.github.com/users/gabriel","html_url":"https://github.com/gabriel","followers_url":"https://api.github.com/users/gabriel/followers","following_url":"https://api.github.com/users/gabriel/following{/other_user}","gists_url":"https://api.github.com/users/gabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/gabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabriel/subscriptions","organizations_url":"https://api.github.com/users/gabriel/orgs","repos_url":"https://api.github.com/users/gabriel/repos","events_url":"https://api.github.com/users/gabriel/events{/privacy}","received_events_url":"https://api.github.com/users/gabriel/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T23:43:55Z","updated_at":"2016-08-04T23:43:55Z","body":"Ok, I did a FS list of a private folder (hooked up a button in search tab to trigger it) and was able to look at my files in `/keybase/private/gabrielh`.\r\n\r\nI had to add a temporary (only for debug) auto confirming `IdentifyUI` impl for mobile, until we implement that for real.\r\n\r\nJust wanted to re-iterate that this doesn't bypass the protocol, this PR is mostly code thats connecting/configuring stuff to bypass the connection/serialization layer and straight into the engine but it still uses the protocol stuff of course.\r\n\r\nFor example, this line:\r\n\r\n```go\r\nsrv.Register(keybase1.FsProtocol(fsrpc.NewFS(kbfsConfig, kbCtx.Log)))\r\n```\r\n\r\nThis is telling the service to use the FsProtocol in keybase/kbfs/fsrpc instead of the RPC one (use it directly). The RPC one would eventually get to this same class but would have to go through serialization and connection to do it, which is a little awkward because we are go talking to go in the same runtime."}}
{"actor":{"display_login":"gabriel"}}