{"action":"created","issue":{"url":"https://api.github.com/repos/craffel/mir_eval/issues/165","repository_url":"https://api.github.com/repos/craffel/mir_eval","labels_url":"https://api.github.com/repos/craffel/mir_eval/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/craffel/mir_eval/issues/165/comments","events_url":"https://api.github.com/repos/craffel/mir_eval/issues/165/events","html_url":"https://github.com/craffel/mir_eval/issues/165","id":131366868,"number":165,"title":"filter_kwargs parameter name collision","user":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/craffel/mir_eval/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-04T14:37:54Z","updated_at":"2016-02-04T15:11:20Z","closed_at":null,"body":"I'm trying to use `util.filter_kwargs` on sonify functions, and hitting a collision with the argument `function`.\r\n\r\nThis would be fixed by renaming `filter_kwargs`'s `function` argument (not a keyword argument) to something unique, like `wrapped_function`.\r\n\r\nThis should be a trivial change, and I can PR if it sounds reasonable."},"comment":{"url":"https://api.github.com/repos/craffel/mir_eval/issues/comments/179890440","html_url":"https://github.com/craffel/mir_eval/issues/165#issuecomment-179890440","issue_url":"https://api.github.com/repos/craffel/mir_eval/issues/165","id":179890440,"user":{"login":"craffel","id":417568,"avatar_url":"https://avatars.githubusercontent.com/u/417568?v=3","gravatar_id":"","url":"https://api.github.com/users/craffel","html_url":"https://github.com/craffel","followers_url":"https://api.github.com/users/craffel/followers","following_url":"https://api.github.com/users/craffel/following{/other_user}","gists_url":"https://api.github.com/users/craffel/gists{/gist_id}","starred_url":"https://api.github.com/users/craffel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffel/subscriptions","organizations_url":"https://api.github.com/users/craffel/orgs","repos_url":"https://api.github.com/users/craffel/repos","events_url":"https://api.github.com/users/craffel/events{/privacy}","received_events_url":"https://api.github.com/users/craffel/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T15:11:20Z","updated_at":"2016-02-04T15:11:20Z","body":"> I'm trying to use util.filter_kwargs on sonify functions\r\n\r\nI'm curious what the context is.\r\n\r\n> This would be fixed by renaming filter_kwargs's function argument (not a keyword argument) to something unique, like wrapped_function.\r\n\r\nI see.  That's no problem, of course.  Though maybe we should be extra sure that a collision with the arg name doesn't happen, and call it something like `wrapped_function_87h12ry3b7926fyubun38796tyiuh2ig5uwte87v6fyvub2in5` (/s but only sort of)."}}