{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/rkt/issues/2398","repository_url":"https://api.github.com/repos/coreos/rkt","labels_url":"https://api.github.com/repos/coreos/rkt/issues/2398/labels{/name}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2398/comments","events_url":"https://api.github.com/repos/coreos/rkt/issues/2398/events","html_url":"https://github.com/coreos/rkt/pull/2398","id":146933757,"number":2398,"title":"rkt/image: render images on fetch","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/coreos/rkt/labels/area/performance","name":"area/performance","color":"bfe5bf"},{"url":"https://api.github.com/repos/coreos/rkt/labels/component/stage0","name":"component/stage0","color":"0052cc"},{"url":"https://api.github.com/repos/coreos/rkt/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/coreos/rkt/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/coreos/rkt/labels/reviewed/lgtm","name":"reviewed/lgtm","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/36","html_url":"https://github.com/coreos/rkt/milestones/v1.5.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/36/labels","id":1676113,"number":36,"title":"v1.5.0","description":"","creator":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":18,"state":"open","created_at":"2016-03-31T14:05:09Z","updated_at":"2016-04-21T16:08:25Z","due_on":"2016-04-27T22:00:00Z","closed_at":null},"comments":17,"created_at":"2016-04-08T13:48:04Z","updated_at":"2016-04-21T18:04:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2398","html_url":"https://github.com/coreos/rkt/pull/2398","diff_url":"https://github.com/coreos/rkt/pull/2398.diff","patch_url":"https://github.com/coreos/rkt/pull/2398.patch"},"body":"rkt was delaying rendering images to the tree store until they were\r\nabout to run for the first time which caused that first run to be slow\r\nfor big images.\r\n\r\nThis commit renders the image to the tree store at fetch time.\r\n\r\nIf the system doesn't support overlayfs, we don't render it because we\r\ndon't use the tree store when overlayfs is not used.\r\n\r\nStartup time benchmark:\r\n\r\nrkt run a Docker nginx image, pre-fetched. Size = 188MiB when unextracted\r\nThe insecure option `ondisk` was used.\r\n\r\ncommand | time (rkt master) | time (rkt master + https://github.com/coreos/rkt/pull/2398)\r\n--------|-------------------|---------------------------\r\n1st time run | real 0m4.964s, user 0m3.570s, sys 0m0.813s | real 0m0.333s, user 0m0.097s, sys 0m0.050s\r\n2nd time run | real 0m0.350s, user 0m0.063s, sys 0m0.077s | real 0m0.343s, user 0m0.073s, sys 0m0.070s\r\n\r\nFixes #2388 "},"comment":{"url":"https://api.github.com/repos/coreos/rkt/issues/comments/213040626","html_url":"https://github.com/coreos/rkt/pull/2398#issuecomment-213040626","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2398","id":213040626,"user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T18:04:06Z","updated_at":"2016-04-21T18:04:06Z","body":"LGTM"}}