{"action":"created","comment":{"url":"https://api.github.com/repos/manala/manala/pulls/comments/81067914","pull_request_review_id":2074811,"id":81067914,"diff_hunk":"@@ -0,0 +1,176 @@\n+<?php\n+\n+/*\n+ * This file is part of the Manala package.\n+ *\n+ * (c) Manala <contact@manala.io>\n+ *\n+ * For the full copyright and license information, please refer to the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Manala\\Config\\Requirement\\Violation;\n+\n+use Manala\\Config\\Requirement\\Common\\RequirementLevel;\n+\n+/**\n+ * Iterable collection of requirement violations.\n+ *\n+ * @author Xavier Roldo <xavier.roldo@elao.com>\n+ */\n+class RequirementViolationList implements \\Iterator, \\ArrayAccess, \\Countable","path":"src/Config/Requirement/Violation/RequirementViolationList.php","position":null,"original_position":21,"commit_id":"97630b6fc21bf0e321715fbe59a5a16eecf1daf8","original_commit_id":"32781dac3f2e3cf900e468ea26360477d46535ae","user":{"login":"xavier-rdo","id":1587796,"avatar_url":"https://avatars.githubusercontent.com/u/1587796?v=3","gravatar_id":"","url":"https://api.github.com/users/xavier-rdo","html_url":"https://github.com/xavier-rdo","followers_url":"https://api.github.com/users/xavier-rdo/followers","following_url":"https://api.github.com/users/xavier-rdo/following{/other_user}","gists_url":"https://api.github.com/users/xavier-rdo/gists{/gist_id}","starred_url":"https://api.github.com/users/xavier-rdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavier-rdo/subscriptions","organizations_url":"https://api.github.com/users/xavier-rdo/orgs","repos_url":"https://api.github.com/users/xavier-rdo/repos","events_url":"https://api.github.com/users/xavier-rdo/events{/privacy}","received_events_url":"https://api.github.com/users/xavier-rdo/received_events","type":"User","site_admin":false},"body":"Eh eh, i didn't really understand the \\ArrayObject SPL class but i think i will use it intensively in the future (your recommendations about it are welcome !).","created_at":"2016-09-29T05:42:46Z","updated_at":"2016-09-29T05:42:46Z","html_url":"https://github.com/manala/manala/pull/19#discussion_r81067914","pull_request_url":"https://api.github.com/repos/manala/manala/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/manala/manala/pulls/comments/81067914"},"html":{"href":"https://github.com/manala/manala/pull/19#discussion_r81067914"},"pull_request":{"href":"https://api.github.com/repos/manala/manala/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/manala/manala/pulls/19","id":86483721,"html_url":"https://github.com/manala/manala/pull/19","diff_url":"https://github.com/manala/manala/pull/19.diff","patch_url":"https://github.com/manala/manala/pull/19.patch","issue_url":"https://api.github.com/repos/manala/manala/issues/19","number":19,"state":"open","locked":false,"title":"Add Requirement checks command","user":{"login":"xavier-rdo","id":1587796,"avatar_url":"https://avatars.githubusercontent.com/u/1587796?v=3","gravatar_id":"","url":"https://api.github.com/users/xavier-rdo","html_url":"https://github.com/xavier-rdo","followers_url":"https://api.github.com/users/xavier-rdo/followers","following_url":"https://api.github.com/users/xavier-rdo/following{/other_user}","gists_url":"https://api.github.com/users/xavier-rdo/gists{/gist_id}","starred_url":"https://api.github.com/users/xavier-rdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavier-rdo/subscriptions","organizations_url":"https://api.github.com/users/xavier-rdo/orgs","repos_url":"https://api.github.com/users/xavier-rdo/repos","events_url":"https://api.github.com/users/xavier-rdo/events{/privacy}","received_events_url":"https://api.github.com/users/xavier-rdo/received_events","type":"User","site_admin":false},"body":"**Acceptance criteria:**\r\n\r\n- [x] Distinguish between requirements & suggestions (1)\r\n- [x] Introduce checking processors that can be mocked (to make tests environment-agnostic) (2)\r\n- [x] Introduce different checker types : binary checker, vagrant plugin checker, etc. (3)\r\n- [x] Required version: semver-formatted (4)\r\n- [x] Unit tests\r\n- [x] Console output colored according to requirement level (required, recommended, etc.)\r\n\r\n(1) vagrant & vagrant plugin landrush are required, ansible is suggested (required to deploy, not to provision VM)\r\n\r\n(2) Processing a binary != processing a vagrant plugin\r\n\r\n(3) Check vagrant & ansible (binaries) but also check landrush (vagrant plugin) : \r\n\r\n* check that a binary is OK: `<binary> --version`\r\n* check that a vagrant plugin is OK: `vagrant plugin list` and check that the expected plugin is in the list\r\n\r\n(4) See https://github.com/composer/semver ; Example: \"~1.8\"\r\n\r\nTODO LATER : \r\n\r\n- Functional test (with venv - virtual environments - https://docs.python.org/3/library/venv.html ?)","created_at":"2016-09-23T09:49:30Z","updated_at":"2016-09-29T05:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88e6d2d087655b7ea914b7cbd77f0267ca60649b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/manala/manala/pulls/19/commits","review_comments_url":"https://api.github.com/repos/manala/manala/pulls/19/comments","review_comment_url":"https://api.github.com/repos/manala/manala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manala/manala/issues/19/comments","statuses_url":"https://api.github.com/repos/manala/manala/statuses/97630b6fc21bf0e321715fbe59a5a16eecf1daf8","head":{"label":"manala:feature/17-host-requirements","ref":"feature/17-host-requirements","sha":"97630b6fc21bf0e321715fbe59a5a16eecf1daf8","user":{"login":"manala","id":17640904,"avatar_url":"https://avatars.githubusercontent.com/u/17640904?v=3","gravatar_id":"","url":"https://api.github.com/users/manala","html_url":"https://github.com/manala","followers_url":"https://api.github.com/users/manala/followers","following_url":"https://api.github.com/users/manala/following{/other_user}","gists_url":"https://api.github.com/users/manala/gists{/gist_id}","starred_url":"https://api.github.com/users/manala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manala/subscriptions","organizations_url":"https://api.github.com/users/manala/orgs","repos_url":"https://api.github.com/users/manala/repos","events_url":"https://api.github.com/users/manala/events{/privacy}","received_events_url":"https://api.github.com/users/manala/received_events","type":"Organization","site_admin":false},"repo":{"id":62733701,"name":"manala","full_name":"manala/manala","owner":{"login":"manala","id":17640904,"avatar_url":"https://avatars.githubusercontent.com/u/17640904?v=3","gravatar_id":"","url":"https://api.github.com/users/manala","html_url":"https://github.com/manala","followers_url":"https://api.github.com/users/manala/followers","following_url":"https://api.github.com/users/manala/following{/other_user}","gists_url":"https://api.github.com/users/manala/gists{/gist_id}","starred_url":"https://api.github.com/users/manala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manala/subscriptions","organizations_url":"https://api.github.com/users/manala/orgs","repos_url":"https://api.github.com/users/manala/repos","events_url":"https://api.github.com/users/manala/events{/privacy}","received_events_url":"https://api.github.com/users/manala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/manala/manala","description":"Entry point of Manala' ansible roles providing vagrants stacks on the fly","fork":false,"url":"https://api.github.com/repos/manala/manala","forks_url":"https://api.github.com/repos/manala/manala/forks","keys_url":"https://api.github.com/repos/manala/manala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manala/manala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manala/manala/teams","hooks_url":"https://api.github.com/repos/manala/manala/hooks","issue_events_url":"https://api.github.com/repos/manala/manala/issues/events{/number}","events_url":"https://api.github.com/repos/manala/manala/events","assignees_url":"https://api.github.com/repos/manala/manala/assignees{/user}","branches_url":"https://api.github.com/repos/manala/manala/branches{/branch}","tags_url":"https://api.github.com/repos/manala/manala/tags","blobs_url":"https://api.github.com/repos/manala/manala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manala/manala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manala/manala/git/refs{/sha}","trees_url":"https://api.github.com/repos/manala/manala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manala/manala/statuses/{sha}","languages_url":"https://api.github.com/repos/manala/manala/languages","stargazers_url":"https://api.github.com/repos/manala/manala/stargazers","contributors_url":"https://api.github.com/repos/manala/manala/contributors","subscribers_url":"https://api.github.com/repos/manala/manala/subscribers","subscription_url":"https://api.github.com/repos/manala/manala/subscription","commits_url":"https://api.github.com/repos/manala/manala/commits{/sha}","git_commits_url":"https://api.github.com/repos/manala/manala/git/commits{/sha}","comments_url":"https://api.github.com/repos/manala/manala/comments{/number}","issue_comment_url":"https://api.github.com/repos/manala/manala/issues/comments{/number}","contents_url":"https://api.github.com/repos/manala/manala/contents/{+path}","compare_url":"https://api.github.com/repos/manala/manala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manala/manala/merges","archive_url":"https://api.github.com/repos/manala/manala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manala/manala/downloads","issues_url":"https://api.github.com/repos/manala/manala/issues{/number}","pulls_url":"https://api.github.com/repos/manala/manala/pulls{/number}","milestones_url":"https://api.github.com/repos/manala/manala/milestones{/number}","notifications_url":"https://api.github.com/repos/manala/manala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manala/manala/labels{/name}","releases_url":"https://api.github.com/repos/manala/manala/releases{/id}","deployments_url":"https://api.github.com/repos/manala/manala/deployments","created_at":"2016-07-06T15:49:26Z","updated_at":"2016-09-28T22:12:55Z","pushed_at":"2016-09-29T05:31:32Z","git_url":"git://github.com/manala/manala.git","ssh_url":"git@github.com:manala/manala.git","clone_url":"https://github.com/manala/manala.git","svn_url":"https://github.com/manala/manala","homepage":"http://www.manala.io","size":130,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"manala:master","ref":"master","sha":"0343f983c342d64e4cd40d1722786ecbf37a08af","user":{"login":"manala","id":17640904,"avatar_url":"https://avatars.githubusercontent.com/u/17640904?v=3","gravatar_id":"","url":"https://api.github.com/users/manala","html_url":"https://github.com/manala","followers_url":"https://api.github.com/users/manala/followers","following_url":"https://api.github.com/users/manala/following{/other_user}","gists_url":"https://api.github.com/users/manala/gists{/gist_id}","starred_url":"https://api.github.com/users/manala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manala/subscriptions","organizations_url":"https://api.github.com/users/manala/orgs","repos_url":"https://api.github.com/users/manala/repos","events_url":"https://api.github.com/users/manala/events{/privacy}","received_events_url":"https://api.github.com/users/manala/received_events","type":"Organization","site_admin":false},"repo":{"id":62733701,"name":"manala","full_name":"manala/manala","owner":{"login":"manala","id":17640904,"avatar_url":"https://avatars.githubusercontent.com/u/17640904?v=3","gravatar_id":"","url":"https://api.github.com/users/manala","html_url":"https://github.com/manala","followers_url":"https://api.github.com/users/manala/followers","following_url":"https://api.github.com/users/manala/following{/other_user}","gists_url":"https://api.github.com/users/manala/gists{/gist_id}","starred_url":"https://api.github.com/users/manala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manala/subscriptions","organizations_url":"https://api.github.com/users/manala/orgs","repos_url":"https://api.github.com/users/manala/repos","events_url":"https://api.github.com/users/manala/events{/privacy}","received_events_url":"https://api.github.com/users/manala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/manala/manala","description":"Entry point of Manala' ansible roles providing vagrants stacks on the fly","fork":false,"url":"https://api.github.com/repos/manala/manala","forks_url":"https://api.github.com/repos/manala/manala/forks","keys_url":"https://api.github.com/repos/manala/manala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manala/manala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manala/manala/teams","hooks_url":"https://api.github.com/repos/manala/manala/hooks","issue_events_url":"https://api.github.com/repos/manala/manala/issues/events{/number}","events_url":"https://api.github.com/repos/manala/manala/events","assignees_url":"https://api.github.com/repos/manala/manala/assignees{/user}","branches_url":"https://api.github.com/repos/manala/manala/branches{/branch}","tags_url":"https://api.github.com/repos/manala/manala/tags","blobs_url":"https://api.github.com/repos/manala/manala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manala/manala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manala/manala/git/refs{/sha}","trees_url":"https://api.github.com/repos/manala/manala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manala/manala/statuses/{sha}","languages_url":"https://api.github.com/repos/manala/manala/languages","stargazers_url":"https://api.github.com/repos/manala/manala/stargazers","contributors_url":"https://api.github.com/repos/manala/manala/contributors","subscribers_url":"https://api.github.com/repos/manala/manala/subscribers","subscription_url":"https://api.github.com/repos/manala/manala/subscription","commits_url":"https://api.github.com/repos/manala/manala/commits{/sha}","git_commits_url":"https://api.github.com/repos/manala/manala/git/commits{/sha}","comments_url":"https://api.github.com/repos/manala/manala/comments{/number}","issue_comment_url":"https://api.github.com/repos/manala/manala/issues/comments{/number}","contents_url":"https://api.github.com/repos/manala/manala/contents/{+path}","compare_url":"https://api.github.com/repos/manala/manala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manala/manala/merges","archive_url":"https://api.github.com/repos/manala/manala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manala/manala/downloads","issues_url":"https://api.github.com/repos/manala/manala/issues{/number}","pulls_url":"https://api.github.com/repos/manala/manala/pulls{/number}","milestones_url":"https://api.github.com/repos/manala/manala/milestones{/number}","notifications_url":"https://api.github.com/repos/manala/manala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manala/manala/labels{/name}","releases_url":"https://api.github.com/repos/manala/manala/releases{/id}","deployments_url":"https://api.github.com/repos/manala/manala/deployments","created_at":"2016-07-06T15:49:26Z","updated_at":"2016-09-28T22:12:55Z","pushed_at":"2016-09-29T05:31:32Z","git_url":"git://github.com/manala/manala.git","ssh_url":"git@github.com:manala/manala.git","clone_url":"https://github.com/manala/manala.git","svn_url":"https://github.com/manala/manala","homepage":"http://www.manala.io","size":130,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manala/manala/pulls/19"},"html":{"href":"https://github.com/manala/manala/pull/19"},"issue":{"href":"https://api.github.com/repos/manala/manala/issues/19"},"comments":{"href":"https://api.github.com/repos/manala/manala/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/manala/manala/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/manala/manala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manala/manala/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/manala/manala/statuses/97630b6fc21bf0e321715fbe59a5a16eecf1daf8"}}}}
{"actor":{"display_login":"xavier-rdo"}}