{"action":"created","comment":{"url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/comments/50100030","id":50100030,"diff_hunk":"@@ -194,4 +196,10 @@ var Store = Ember.Object.extend({\n     }\n });\n \n+if (!isModern) {\n+    Store.reopenClass({","path":"addon/store.js","position":28,"original_position":28,"commit_id":"5571ae7fcd95744d71460c3d549a42ac332c6d71","original_commit_id":"5571ae7fcd95744d71460c3d549a42ac332c6d71","user":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"body":"what does this buy you? I assumed Ember.Service had a flag itself?","created_at":"2016-01-19T11:12:26Z","updated_at":"2016-01-19T11:12:26Z","html_url":"https://github.com/toranb/ember-cli-simple-store/pull/44#discussion_r50100030","pull_request_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/comments/50100030"},"html":{"href":"https://github.com/toranb/ember-cli-simple-store/pull/44#discussion_r50100030"},"pull_request":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44","id":56419679,"html_url":"https://github.com/toranb/ember-cli-simple-store/pull/44","diff_url":"https://github.com/toranb/ember-cli-simple-store/pull/44.diff","patch_url":"https://github.com/toranb/ember-cli-simple-store/pull/44.patch","issue_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/44","number":44,"state":"open","locked":false,"title":"Expose Store as an Ember Service","user":{"login":"jasonmit","id":3108309,"avatar_url":"https://avatars.githubusercontent.com/u/3108309?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmit","html_url":"https://github.com/jasonmit","followers_url":"https://api.github.com/users/jasonmit/followers","following_url":"https://api.github.com/users/jasonmit/following{/other_user}","gists_url":"https://api.github.com/users/jasonmit/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmit/subscriptions","organizations_url":"https://api.github.com/users/jasonmit/orgs","repos_url":"https://api.github.com/users/jasonmit/repos","events_url":"https://api.github.com/users/jasonmit/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmit/received_events","type":"User","site_admin":false},"body":"Fixes #34 \r\n\r\nSo long as no one is resolving via the lookup name `store:main` directly and instead just relying on injection, then this is not an API breaking change so it's safe for 4.0.  This removes the need to inject via ember-cli-injections and to use the Ember.inject.service API.\r\n\r\nAnywhere `ember-cli-injections` was used, can be replaced with `Ember.inject.service`","created_at":"2016-01-19T04:05:23Z","updated_at":"2016-01-19T11:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b2bc66662486e029fa267de3ab8c8abe93e238b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44/commits","review_comments_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44/comments","review_comment_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/44/comments","statuses_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/statuses/5571ae7fcd95744d71460c3d549a42ac332c6d71","head":{"label":"toranb:service","ref":"service","sha":"5571ae7fcd95744d71460c3d549a42ac332c6d71","user":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"repo":{"id":28704264,"name":"ember-cli-simple-store","full_name":"toranb/ember-cli-simple-store","owner":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toranb/ember-cli-simple-store","description":"ember-cli addon that provides a simple identity map for ember.js web applications","fork":false,"url":"https://api.github.com/repos/toranb/ember-cli-simple-store","forks_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/forks","keys_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/teams","hooks_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/hooks","issue_events_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/events{/number}","events_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/events","assignees_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/assignees{/user}","branches_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/branches{/branch}","tags_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/tags","blobs_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/statuses/{sha}","languages_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/languages","stargazers_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/stargazers","contributors_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/contributors","subscribers_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/subscribers","subscription_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/subscription","commits_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/contents/{+path}","compare_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/merges","archive_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/downloads","issues_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues{/number}","pulls_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls{/number}","milestones_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/milestones{/number}","notifications_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/labels{/name}","releases_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/releases{/id}","created_at":"2015-01-02T05:14:31Z","updated_at":"2016-01-19T01:36:13Z","pushed_at":"2016-01-19T04:51:38Z","git_url":"git://github.com/toranb/ember-cli-simple-store.git","ssh_url":"git@github.com:toranb/ember-cli-simple-store.git","clone_url":"https://github.com/toranb/ember-cli-simple-store.git","svn_url":"https://github.com/toranb/ember-cli-simple-store","homepage":null,"size":221,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":38,"default_branch":"master"}},"base":{"label":"toranb:master","ref":"master","sha":"ac2cb57feb02469862510fdea627d9b7d3aa432c","user":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"repo":{"id":28704264,"name":"ember-cli-simple-store","full_name":"toranb/ember-cli-simple-store","owner":{"login":"toranb","id":147411,"avatar_url":"https://avatars.githubusercontent.com/u/147411?v=3","gravatar_id":"","url":"https://api.github.com/users/toranb","html_url":"https://github.com/toranb","followers_url":"https://api.github.com/users/toranb/followers","following_url":"https://api.github.com/users/toranb/following{/other_user}","gists_url":"https://api.github.com/users/toranb/gists{/gist_id}","starred_url":"https://api.github.com/users/toranb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toranb/subscriptions","organizations_url":"https://api.github.com/users/toranb/orgs","repos_url":"https://api.github.com/users/toranb/repos","events_url":"https://api.github.com/users/toranb/events{/privacy}","received_events_url":"https://api.github.com/users/toranb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toranb/ember-cli-simple-store","description":"ember-cli addon that provides a simple identity map for ember.js web applications","fork":false,"url":"https://api.github.com/repos/toranb/ember-cli-simple-store","forks_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/forks","keys_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/teams","hooks_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/hooks","issue_events_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/events{/number}","events_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/events","assignees_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/assignees{/user}","branches_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/branches{/branch}","tags_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/tags","blobs_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/statuses/{sha}","languages_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/languages","stargazers_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/stargazers","contributors_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/contributors","subscribers_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/subscribers","subscription_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/subscription","commits_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/contents/{+path}","compare_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/merges","archive_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/downloads","issues_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues{/number}","pulls_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls{/number}","milestones_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/milestones{/number}","notifications_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/labels{/name}","releases_url":"https://api.github.com/repos/toranb/ember-cli-simple-store/releases{/id}","created_at":"2015-01-02T05:14:31Z","updated_at":"2016-01-19T01:36:13Z","pushed_at":"2016-01-19T04:51:38Z","git_url":"git://github.com/toranb/ember-cli-simple-store.git","ssh_url":"git@github.com:toranb/ember-cli-simple-store.git","clone_url":"https://github.com/toranb/ember-cli-simple-store.git","svn_url":"https://github.com/toranb/ember-cli-simple-store","homepage":null,"size":221,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44"},"html":{"href":"https://github.com/toranb/ember-cli-simple-store/pull/44"},"issue":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/44"},"comments":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/toranb/ember-cli-simple-store/statuses/5571ae7fcd95744d71460c3d549a42ac332c6d71"}}}}