{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/56262205","id":56262205,"diff_hunk":"@@ -0,0 +1,31 @@\n+/**\n+ * Copyright 2016 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import {loadScript, checkData, validateDataExists} from '../src/3p';\n+\n+/** Created by Webedia on 07/03/16 */\n+export function webediads(global, data) {\n+  checkData(data, ['site', 'page', 'position', 'query']);\n+  validateDataExists(data, ['site', 'page', 'position', 'query']);","path":"ads/webediads.js","position":22,"original_position":22,"commit_id":"6e15a4deef6abede394edb85754febd4265455ef","original_commit_id":"6e15a4deef6abede394edb85754febd4265455ef","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"In particular, I'm asking because I believe `validateDataExists` would assert on empty `data-query` as in the example.","created_at":"2016-03-15T23:59:12Z","updated_at":"2016-03-15T23:59:12Z","html_url":"https://github.com/ampproject/amphtml/pull/2562#discussion_r56262205","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2562","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/56262205"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2562#discussion_r56262205"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2562"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/2562","id":62568781,"html_url":"https://github.com/ampproject/amphtml/pull/2562","diff_url":"https://github.com/ampproject/amphtml/pull/2562.diff","patch_url":"https://github.com/ampproject/amphtml/pull/2562.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/2562","number":2562,"state":"open","locked":false,"title":"Webediads : amp-ad submission","user":{"login":"Lith","id":605495,"avatar_url":"https://avatars.githubusercontent.com/u/605495?v=3","gravatar_id":"","url":"https://api.github.com/users/Lith","html_url":"https://github.com/Lith","followers_url":"https://api.github.com/users/Lith/followers","following_url":"https://api.github.com/users/Lith/following{/other_user}","gists_url":"https://api.github.com/users/Lith/gists{/gist_id}","starred_url":"https://api.github.com/users/Lith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lith/subscriptions","organizations_url":"https://api.github.com/users/Lith/orgs","repos_url":"https://api.github.com/users/Lith/repos","events_url":"https://api.github.com/users/Lith/events{/privacy}","received_events_url":"https://api.github.com/users/Lith/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-11T16:39:51Z","updated_at":"2016-03-15T23:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aacc0dc3c5fccd573f477f01e820f55cec88e6aa","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2562/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2562/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/2562/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/6e15a4deef6abede394edb85754febd4265455ef","head":{"label":"Lith:master","ref":"master","sha":"6e15a4deef6abede394edb85754febd4265455ef","user":{"login":"Lith","id":605495,"avatar_url":"https://avatars.githubusercontent.com/u/605495?v=3","gravatar_id":"","url":"https://api.github.com/users/Lith","html_url":"https://github.com/Lith","followers_url":"https://api.github.com/users/Lith/followers","following_url":"https://api.github.com/users/Lith/following{/other_user}","gists_url":"https://api.github.com/users/Lith/gists{/gist_id}","starred_url":"https://api.github.com/users/Lith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lith/subscriptions","organizations_url":"https://api.github.com/users/Lith/orgs","repos_url":"https://api.github.com/users/Lith/repos","events_url":"https://api.github.com/users/Lith/events{/privacy}","received_events_url":"https://api.github.com/users/Lith/received_events","type":"User","site_admin":false},"repo":{"id":53316719,"name":"amphtml","full_name":"Lith/amphtml","owner":{"login":"Lith","id":605495,"avatar_url":"https://avatars.githubusercontent.com/u/605495?v=3","gravatar_id":"","url":"https://api.github.com/users/Lith","html_url":"https://github.com/Lith","followers_url":"https://api.github.com/users/Lith/followers","following_url":"https://api.github.com/users/Lith/following{/other_user}","gists_url":"https://api.github.com/users/Lith/gists{/gist_id}","starred_url":"https://api.github.com/users/Lith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lith/subscriptions","organizations_url":"https://api.github.com/users/Lith/orgs","repos_url":"https://api.github.com/users/Lith/repos","events_url":"https://api.github.com/users/Lith/events{/privacy}","received_events_url":"https://api.github.com/users/Lith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lith/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/Lith/amphtml","forks_url":"https://api.github.com/repos/Lith/amphtml/forks","keys_url":"https://api.github.com/repos/Lith/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lith/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lith/amphtml/teams","hooks_url":"https://api.github.com/repos/Lith/amphtml/hooks","issue_events_url":"https://api.github.com/repos/Lith/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/Lith/amphtml/events","assignees_url":"https://api.github.com/repos/Lith/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/Lith/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/Lith/amphtml/tags","blobs_url":"https://api.github.com/repos/Lith/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lith/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lith/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lith/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lith/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/Lith/amphtml/languages","stargazers_url":"https://api.github.com/repos/Lith/amphtml/stargazers","contributors_url":"https://api.github.com/repos/Lith/amphtml/contributors","subscribers_url":"https://api.github.com/repos/Lith/amphtml/subscribers","subscription_url":"https://api.github.com/repos/Lith/amphtml/subscription","commits_url":"https://api.github.com/repos/Lith/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lith/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lith/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lith/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lith/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/Lith/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lith/amphtml/merges","archive_url":"https://api.github.com/repos/Lith/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lith/amphtml/downloads","issues_url":"https://api.github.com/repos/Lith/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/Lith/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/Lith/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/Lith/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lith/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/Lith/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/Lith/amphtml/deployments","created_at":"2016-03-07T10:26:46Z","updated_at":"2016-03-07T10:26:48Z","pushed_at":"2016-03-13T09:56:32Z","git_url":"git://github.com/Lith/amphtml.git","ssh_url":"git@github.com:Lith/amphtml.git","clone_url":"https://github.com/Lith/amphtml.git","svn_url":"https://github.com/Lith/amphtml","homepage":"https://ampproject.org","size":30908,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"439874633ac40b77b4efac5f2736a86129ead5cf","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-03-15T23:54:06Z","pushed_at":"2016-03-15T23:54:08Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":36515,"stargazers_count":6847,"watchers_count":6847,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":831,"mirror_url":null,"open_issues_count":362,"forks":831,"open_issues":362,"watchers":6847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2562"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2562"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2562"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2562/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2562/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2562/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/6e15a4deef6abede394edb85754febd4265455ef"}}}}