{"action":"opened","number":490,"pull_request":{"url":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490","id":84685895,"html_url":"https://github.com/miguelcobain/ember-paper/pull/490","diff_url":"https://github.com/miguelcobain/ember-paper/pull/490.diff","patch_url":"https://github.com/miguelcobain/ember-paper/pull/490.patch","issue_url":"https://api.github.com/repos/miguelcobain/ember-paper/issues/490","number":490,"state":"open","locked":false,"title":"extracted validation to a mixin and added the mixin to paper-select","user":{"login":"ibarrick","id":7854927,"avatar_url":"https://avatars.githubusercontent.com/u/7854927?v=3","gravatar_id":"","url":"https://api.github.com/users/ibarrick","html_url":"https://github.com/ibarrick","followers_url":"https://api.github.com/users/ibarrick/followers","following_url":"https://api.github.com/users/ibarrick/following{/other_user}","gists_url":"https://api.github.com/users/ibarrick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarrick/subscriptions","organizations_url":"https://api.github.com/users/ibarrick/orgs","repos_url":"https://api.github.com/users/ibarrick/repos","events_url":"https://api.github.com/users/ibarrick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarrick/received_events","type":"User","site_admin":false},"body":"Since it is no longer possible for paper-select to inherit paper-input like it was before, I extracted the validation logic that wasn't specific to paper-input into a mixin. Components only need to add the mixin and set validationProperty to be the name of the property validations will be run against. Components that use the mixin will also be responsible for calling this.notifyValidityChange() whenever they want to recheck for validity.\r\n\r\nI think moving validation to a mixin will be a big help in including validation in future components such as chips and date picker. This PR is independent of the PR for adding labels so it will have to be adjusted slightly once that is merged.","created_at":"2016-09-09T17:13:53Z","updated_at":"2016-09-09T17:13:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490/commits","review_comments_url":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490/comments","review_comment_url":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miguelcobain/ember-paper/issues/490/comments","statuses_url":"https://api.github.com/repos/miguelcobain/ember-paper/statuses/9c2d5899625534567fb443b716a362a2279760a1","head":{"label":"ibarrick:select-validation","ref":"select-validation","sha":"9c2d5899625534567fb443b716a362a2279760a1","user":{"login":"ibarrick","id":7854927,"avatar_url":"https://avatars.githubusercontent.com/u/7854927?v=3","gravatar_id":"","url":"https://api.github.com/users/ibarrick","html_url":"https://github.com/ibarrick","followers_url":"https://api.github.com/users/ibarrick/followers","following_url":"https://api.github.com/users/ibarrick/following{/other_user}","gists_url":"https://api.github.com/users/ibarrick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarrick/subscriptions","organizations_url":"https://api.github.com/users/ibarrick/orgs","repos_url":"https://api.github.com/users/ibarrick/repos","events_url":"https://api.github.com/users/ibarrick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarrick/received_events","type":"User","site_admin":false},"repo":{"id":59525936,"name":"ember-paper","full_name":"ibarrick/ember-paper","owner":{"login":"ibarrick","id":7854927,"avatar_url":"https://avatars.githubusercontent.com/u/7854927?v=3","gravatar_id":"","url":"https://api.github.com/users/ibarrick","html_url":"https://github.com/ibarrick","followers_url":"https://api.github.com/users/ibarrick/followers","following_url":"https://api.github.com/users/ibarrick/following{/other_user}","gists_url":"https://api.github.com/users/ibarrick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarrick/subscriptions","organizations_url":"https://api.github.com/users/ibarrick/orgs","repos_url":"https://api.github.com/users/ibarrick/repos","events_url":"https://api.github.com/users/ibarrick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibarrick/ember-paper","description":"The Ember approach to Material Design.","fork":true,"url":"https://api.github.com/repos/ibarrick/ember-paper","forks_url":"https://api.github.com/repos/ibarrick/ember-paper/forks","keys_url":"https://api.github.com/repos/ibarrick/ember-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibarrick/ember-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibarrick/ember-paper/teams","hooks_url":"https://api.github.com/repos/ibarrick/ember-paper/hooks","issue_events_url":"https://api.github.com/repos/ibarrick/ember-paper/issues/events{/number}","events_url":"https://api.github.com/repos/ibarrick/ember-paper/events","assignees_url":"https://api.github.com/repos/ibarrick/ember-paper/assignees{/user}","branches_url":"https://api.github.com/repos/ibarrick/ember-paper/branches{/branch}","tags_url":"https://api.github.com/repos/ibarrick/ember-paper/tags","blobs_url":"https://api.github.com/repos/ibarrick/ember-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibarrick/ember-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibarrick/ember-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibarrick/ember-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibarrick/ember-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/ibarrick/ember-paper/languages","stargazers_url":"https://api.github.com/repos/ibarrick/ember-paper/stargazers","contributors_url":"https://api.github.com/repos/ibarrick/ember-paper/contributors","subscribers_url":"https://api.github.com/repos/ibarrick/ember-paper/subscribers","subscription_url":"https://api.github.com/repos/ibarrick/ember-paper/subscription","commits_url":"https://api.github.com/repos/ibarrick/ember-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibarrick/ember-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibarrick/ember-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibarrick/ember-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibarrick/ember-paper/contents/{+path}","compare_url":"https://api.github.com/repos/ibarrick/ember-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibarrick/ember-paper/merges","archive_url":"https://api.github.com/repos/ibarrick/ember-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibarrick/ember-paper/downloads","issues_url":"https://api.github.com/repos/ibarrick/ember-paper/issues{/number}","pulls_url":"https://api.github.com/repos/ibarrick/ember-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/ibarrick/ember-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/ibarrick/ember-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibarrick/ember-paper/labels{/name}","releases_url":"https://api.github.com/repos/ibarrick/ember-paper/releases{/id}","deployments_url":"https://api.github.com/repos/ibarrick/ember-paper/deployments","created_at":"2016-05-23T23:45:00Z","updated_at":"2016-05-23T23:45:01Z","pushed_at":"2016-09-09T17:07:35Z","git_url":"git://github.com/ibarrick/ember-paper.git","ssh_url":"git@github.com:ibarrick/ember-paper.git","clone_url":"https://github.com/ibarrick/ember-paper.git","svn_url":"https://github.com/ibarrick/ember-paper","homepage":"http://miguelcobain.github.io/ember-paper","size":4944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miguelcobain:paper-menu","ref":"paper-menu","sha":"a7f4e89b29f12b90b97be451f39811e6dcad6086","user":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"repo":{"id":25473816,"name":"ember-paper","full_name":"miguelcobain/ember-paper","owner":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelcobain/ember-paper","description":"The Ember approach to Material Design.","fork":false,"url":"https://api.github.com/repos/miguelcobain/ember-paper","forks_url":"https://api.github.com/repos/miguelcobain/ember-paper/forks","keys_url":"https://api.github.com/repos/miguelcobain/ember-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelcobain/ember-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelcobain/ember-paper/teams","hooks_url":"https://api.github.com/repos/miguelcobain/ember-paper/hooks","issue_events_url":"https://api.github.com/repos/miguelcobain/ember-paper/issues/events{/number}","events_url":"https://api.github.com/repos/miguelcobain/ember-paper/events","assignees_url":"https://api.github.com/repos/miguelcobain/ember-paper/assignees{/user}","branches_url":"https://api.github.com/repos/miguelcobain/ember-paper/branches{/branch}","tags_url":"https://api.github.com/repos/miguelcobain/ember-paper/tags","blobs_url":"https://api.github.com/repos/miguelcobain/ember-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelcobain/ember-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelcobain/ember-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelcobain/ember-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelcobain/ember-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelcobain/ember-paper/languages","stargazers_url":"https://api.github.com/repos/miguelcobain/ember-paper/stargazers","contributors_url":"https://api.github.com/repos/miguelcobain/ember-paper/contributors","subscribers_url":"https://api.github.com/repos/miguelcobain/ember-paper/subscribers","subscription_url":"https://api.github.com/repos/miguelcobain/ember-paper/subscription","commits_url":"https://api.github.com/repos/miguelcobain/ember-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelcobain/ember-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelcobain/ember-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelcobain/ember-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelcobain/ember-paper/contents/{+path}","compare_url":"https://api.github.com/repos/miguelcobain/ember-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelcobain/ember-paper/merges","archive_url":"https://api.github.com/repos/miguelcobain/ember-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelcobain/ember-paper/downloads","issues_url":"https://api.github.com/repos/miguelcobain/ember-paper/issues{/number}","pulls_url":"https://api.github.com/repos/miguelcobain/ember-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelcobain/ember-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelcobain/ember-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelcobain/ember-paper/labels{/name}","releases_url":"https://api.github.com/repos/miguelcobain/ember-paper/releases{/id}","deployments_url":"https://api.github.com/repos/miguelcobain/ember-paper/deployments","created_at":"2014-10-20T15:50:07Z","updated_at":"2016-08-31T14:34:23Z","pushed_at":"2016-09-09T17:13:53Z","git_url":"git://github.com/miguelcobain/ember-paper.git","ssh_url":"git@github.com:miguelcobain/ember-paper.git","clone_url":"https://github.com/miguelcobain/ember-paper.git","svn_url":"https://github.com/miguelcobain/ember-paper","homepage":"http://miguelcobain.github.io/ember-paper","size":8739,"stargazers_count":565,"watchers_count":565,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":158,"mirror_url":null,"open_issues_count":79,"forks":158,"open_issues":79,"watchers":565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490"},"html":{"href":"https://github.com/miguelcobain/ember-paper/pull/490"},"issue":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/issues/490"},"comments":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/miguelcobain/ember-paper/statuses/9c2d5899625534567fb443b716a362a2279760a1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":187,"deletions":104,"changed_files":4}}
{"actor":{"display_login":"ibarrick"}}