{"action":"closed","number":434,"pull_request":{"url":"https://api.github.com/repos/tangrams/tangram-play/pulls/434","id":75560852,"html_url":"https://github.com/tangrams/tangram-play/pull/434","diff_url":"https://github.com/tangrams/tangram-play/pull/434.diff","patch_url":"https://github.com/tangrams/tangram-play/pull/434.patch","issue_url":"https://api.github.com/repos/tangrams/tangram-play/issues/434","number":434,"state":"closed","locked":false,"title":"Add thumbnail images locally, with a script to fetch them","user":{"login":"louh","id":2553268,"avatar_url":"https://avatars.githubusercontent.com/u/2553268?v=3","gravatar_id":"","url":"https://api.github.com/users/louh","html_url":"https://github.com/louh","followers_url":"https://api.github.com/users/louh/followers","following_url":"https://api.github.com/users/louh/following{/other_user}","gists_url":"https://api.github.com/users/louh/gists{/gist_id}","starred_url":"https://api.github.com/users/louh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louh/subscriptions","organizations_url":"https://api.github.com/users/louh/orgs","repos_url":"https://api.github.com/users/louh/repos","events_url":"https://api.github.com/users/louh/events{/privacy}","received_events_url":"https://api.github.com/users/louh/received_events","type":"User","site_admin":false},"body":"Image thumbnails in the \"Open an example\" modal are loaded directly from the Rawgit cache of https://github.com/tangrams/tangram-sandbox. These images are very large (due to the size at which they were originally displayed at) and are not optimized. And yet we are loading them and shoving them into a smaller image container. This creates noticeable loading lag when the dialog box is opened and images are downloaded all at once -- about 10 seconds of loading time, and 18MB (!) of images are downloaded!\r\n\r\nThis PR introduces the thumbnails as pre-optimized images at the correct resolution and Retina-resolution, stored locally, with a script to download and process images. The script is designed to run rarely (whenever we update the examples list) so it is not made part of the build or deployment process; instead, project maintainers are expected to run this script to easily generate thumbnails when examples change, or if the UI changes thumbnail dimensions. Loading these optimized images is much faster: we are only loading 1.2MB of images, a dramatic savings even if there are only Retina versions available.\r\n\r\nThis is also one step forward in addressing #293, because Rawgit occasionally goes down. This prevents Rawgit's failure from impacting the availability of this feature in Tangram Play (the next step to complete it would be local copying of the YAML scene files, as well, but will be introduced in a later PR if this is acceptable).\r\n","created_at":"2016-06-28T22:25:24Z","updated_at":"2016-06-29T12:35:08Z","closed_at":"2016-06-29T12:35:08Z","merged_at":"2016-06-29T12:35:08Z","merge_commit_sha":"4ec7a94dd1e52a92911b4627444e70bea2be96c4","assignee":{"login":"patriciogonzalezvivo","id":346914,"avatar_url":"https://avatars.githubusercontent.com/u/346914?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciogonzalezvivo","html_url":"https://github.com/patriciogonzalezvivo","followers_url":"https://api.github.com/users/patriciogonzalezvivo/followers","following_url":"https://api.github.com/users/patriciogonzalezvivo/following{/other_user}","gists_url":"https://api.github.com/users/patriciogonzalezvivo/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciogonzalezvivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciogonzalezvivo/subscriptions","organizations_url":"https://api.github.com/users/patriciogonzalezvivo/orgs","repos_url":"https://api.github.com/users/patriciogonzalezvivo/repos","events_url":"https://api.github.com/users/patriciogonzalezvivo/events{/privacy}","received_events_url":"https://api.github.com/users/patriciogonzalezvivo/received_events","type":"User","site_admin":false},"assignees":[{"login":"patriciogonzalezvivo","id":346914,"avatar_url":"https://avatars.githubusercontent.com/u/346914?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciogonzalezvivo","html_url":"https://github.com/patriciogonzalezvivo","followers_url":"https://api.github.com/users/patriciogonzalezvivo/followers","following_url":"https://api.github.com/users/patriciogonzalezvivo/following{/other_user}","gists_url":"https://api.github.com/users/patriciogonzalezvivo/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciogonzalezvivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciogonzalezvivo/subscriptions","organizations_url":"https://api.github.com/users/patriciogonzalezvivo/orgs","repos_url":"https://api.github.com/users/patriciogonzalezvivo/repos","events_url":"https://api.github.com/users/patriciogonzalezvivo/events{/privacy}","received_events_url":"https://api.github.com/users/patriciogonzalezvivo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tangrams/tangram-play/pulls/434/commits","review_comments_url":"https://api.github.com/repos/tangrams/tangram-play/pulls/434/comments","review_comment_url":"https://api.github.com/repos/tangrams/tangram-play/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tangrams/tangram-play/issues/434/comments","statuses_url":"https://api.github.com/repos/tangrams/tangram-play/statuses/8f740db6b9fe13fd4da5c8a49f83c50e7ea8ecd3","head":{"label":"tangrams:images","ref":"images","sha":"8f740db6b9fe13fd4da5c8a49f83c50e7ea8ecd3","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":36521942,"name":"tangram-play","full_name":"tangrams/tangram-play","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram-play","description":"GUI editor for Tangram scenes","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-play","forks_url":"https://api.github.com/repos/tangrams/tangram-play/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-play/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-play/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-play/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-play/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-play/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-play/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-play/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-play/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-play/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-play/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-play/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-play/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-play/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-play/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-play/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-play/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-play/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-play/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-play/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-play/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-play/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-play/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-play/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-play/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-play/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-play/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-play/deployments","created_at":"2015-05-29T18:27:43Z","updated_at":"2016-06-17T15:17:28Z","pushed_at":"2016-06-29T12:35:09Z","git_url":"git://github.com/tangrams/tangram-play.git","ssh_url":"git@github.com:tangrams/tangram-play.git","clone_url":"https://github.com/tangrams/tangram-play.git","svn_url":"https://github.com/tangrams/tangram-play","homepage":"https://mapzen.com/tangram/play/","size":57060,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":68,"forks":5,"open_issues":68,"watchers":20,"default_branch":"master"}},"base":{"label":"tangrams:master","ref":"master","sha":"6b9658c812a795a7cbb5736ccda4537f93d1064d","user":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"repo":{"id":36521942,"name":"tangram-play","full_name":"tangrams/tangram-play","owner":{"login":"tangrams","id":8495302,"avatar_url":"https://avatars.githubusercontent.com/u/8495302?v=3","gravatar_id":"","url":"https://api.github.com/users/tangrams","html_url":"https://github.com/tangrams","followers_url":"https://api.github.com/users/tangrams/followers","following_url":"https://api.github.com/users/tangrams/following{/other_user}","gists_url":"https://api.github.com/users/tangrams/gists{/gist_id}","starred_url":"https://api.github.com/users/tangrams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tangrams/subscriptions","organizations_url":"https://api.github.com/users/tangrams/orgs","repos_url":"https://api.github.com/users/tangrams/repos","events_url":"https://api.github.com/users/tangrams/events{/privacy}","received_events_url":"https://api.github.com/users/tangrams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tangrams/tangram-play","description":"GUI editor for Tangram scenes","fork":false,"url":"https://api.github.com/repos/tangrams/tangram-play","forks_url":"https://api.github.com/repos/tangrams/tangram-play/forks","keys_url":"https://api.github.com/repos/tangrams/tangram-play/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tangrams/tangram-play/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tangrams/tangram-play/teams","hooks_url":"https://api.github.com/repos/tangrams/tangram-play/hooks","issue_events_url":"https://api.github.com/repos/tangrams/tangram-play/issues/events{/number}","events_url":"https://api.github.com/repos/tangrams/tangram-play/events","assignees_url":"https://api.github.com/repos/tangrams/tangram-play/assignees{/user}","branches_url":"https://api.github.com/repos/tangrams/tangram-play/branches{/branch}","tags_url":"https://api.github.com/repos/tangrams/tangram-play/tags","blobs_url":"https://api.github.com/repos/tangrams/tangram-play/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tangrams/tangram-play/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tangrams/tangram-play/git/refs{/sha}","trees_url":"https://api.github.com/repos/tangrams/tangram-play/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tangrams/tangram-play/statuses/{sha}","languages_url":"https://api.github.com/repos/tangrams/tangram-play/languages","stargazers_url":"https://api.github.com/repos/tangrams/tangram-play/stargazers","contributors_url":"https://api.github.com/repos/tangrams/tangram-play/contributors","subscribers_url":"https://api.github.com/repos/tangrams/tangram-play/subscribers","subscription_url":"https://api.github.com/repos/tangrams/tangram-play/subscription","commits_url":"https://api.github.com/repos/tangrams/tangram-play/commits{/sha}","git_commits_url":"https://api.github.com/repos/tangrams/tangram-play/git/commits{/sha}","comments_url":"https://api.github.com/repos/tangrams/tangram-play/comments{/number}","issue_comment_url":"https://api.github.com/repos/tangrams/tangram-play/issues/comments{/number}","contents_url":"https://api.github.com/repos/tangrams/tangram-play/contents/{+path}","compare_url":"https://api.github.com/repos/tangrams/tangram-play/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tangrams/tangram-play/merges","archive_url":"https://api.github.com/repos/tangrams/tangram-play/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tangrams/tangram-play/downloads","issues_url":"https://api.github.com/repos/tangrams/tangram-play/issues{/number}","pulls_url":"https://api.github.com/repos/tangrams/tangram-play/pulls{/number}","milestones_url":"https://api.github.com/repos/tangrams/tangram-play/milestones{/number}","notifications_url":"https://api.github.com/repos/tangrams/tangram-play/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tangrams/tangram-play/labels{/name}","releases_url":"https://api.github.com/repos/tangrams/tangram-play/releases{/id}","deployments_url":"https://api.github.com/repos/tangrams/tangram-play/deployments","created_at":"2015-05-29T18:27:43Z","updated_at":"2016-06-17T15:17:28Z","pushed_at":"2016-06-29T12:35:09Z","git_url":"git://github.com/tangrams/tangram-play.git","ssh_url":"git@github.com:tangrams/tangram-play.git","clone_url":"https://github.com/tangrams/tangram-play.git","svn_url":"https://github.com/tangrams/tangram-play","homepage":"https://mapzen.com/tangram/play/","size":57060,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":68,"forks":5,"open_issues":68,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tangrams/tangram-play/pulls/434"},"html":{"href":"https://github.com/tangrams/tangram-play/pull/434"},"issue":{"href":"https://api.github.com/repos/tangrams/tangram-play/issues/434"},"comments":{"href":"https://api.github.com/repos/tangrams/tangram-play/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/tangrams/tangram-play/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/tangrams/tangram-play/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tangrams/tangram-play/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/tangrams/tangram-play/statuses/8f740db6b9fe13fd4da5c8a49f83c50e7ea8ecd3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"patriciogonzalezvivo","id":346914,"avatar_url":"https://avatars.githubusercontent.com/u/346914?v=3","gravatar_id":"","url":"https://api.github.com/users/patriciogonzalezvivo","html_url":"https://github.com/patriciogonzalezvivo","followers_url":"https://api.github.com/users/patriciogonzalezvivo/followers","following_url":"https://api.github.com/users/patriciogonzalezvivo/following{/other_user}","gists_url":"https://api.github.com/users/patriciogonzalezvivo/gists{/gist_id}","starred_url":"https://api.github.com/users/patriciogonzalezvivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriciogonzalezvivo/subscriptions","organizations_url":"https://api.github.com/users/patriciogonzalezvivo/orgs","repos_url":"https://api.github.com/users/patriciogonzalezvivo/repos","events_url":"https://api.github.com/users/patriciogonzalezvivo/events{/privacy}","received_events_url":"https://api.github.com/users/patriciogonzalezvivo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":151,"deletions":20,"changed_files":22}}
{"actor":{"display_login":"patriciogonzalezvivo"}}