{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/57632693","id":57632693,"diff_hunk":"@@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) {\n     if (!(eventEmitter instanceof EventEmitter))\n         throw new Error('Cordova events could be redirected to another EventEmitter instance only');\n \n-    EVENTS_RECEIVER = eventEmitter;\n+    // Skipping forwarding to self to avoid infinite recursion.\n+    // This is the case when the modules are npm-linked.\n+    if(this !== eventEmitter) {","path":"cordova-common/src/events.js","position":7,"original_position":7,"commit_id":"9760a9c11189df15c1a28d0b34f5ddb4644f018d","original_commit_id":"9760a9c11189df15c1a28d0b34f5ddb4644f018d","user":{"login":"vladimir-kotikov","id":3857604,"avatar_url":"https://avatars.githubusercontent.com/u/3857604?v=3","gravatar_id":"","url":"https://api.github.com/users/vladimir-kotikov","html_url":"https://github.com/vladimir-kotikov","followers_url":"https://api.github.com/users/vladimir-kotikov/followers","following_url":"https://api.github.com/users/vladimir-kotikov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-kotikov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-kotikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-kotikov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-kotikov/orgs","repos_url":"https://api.github.com/users/vladimir-kotikov/repos","events_url":"https://api.github.com/users/vladimir-kotikov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-kotikov/received_events","type":"User","site_admin":false},"body":"nit: please add space after `if`. Also could you please reference JIRA here so it'd be more clear why we're checking this","created_at":"2016-03-28T20:58:50Z","updated_at":"2016-03-28T20:58:50Z","html_url":"https://github.com/apache/cordova-lib/pull/418#discussion_r57632693","pull_request_url":"https://api.github.com/repos/apache/cordova-lib/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/comments/57632693"},"html":{"href":"https://github.com/apache/cordova-lib/pull/418#discussion_r57632693"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-lib/pulls/418","id":64351996,"html_url":"https://github.com/apache/cordova-lib/pull/418","diff_url":"https://github.com/apache/cordova-lib/pull/418.diff","patch_url":"https://github.com/apache/cordova-lib/pull/418.patch","issue_url":"https://api.github.com/repos/apache/cordova-lib/issues/418","number":418,"state":"open","locked":false,"title":"CB-10940 Can't add Android platform from path","user":{"login":"daserge","id":4272078,"avatar_url":"https://avatars.githubusercontent.com/u/4272078?v=3","gravatar_id":"","url":"https://api.github.com/users/daserge","html_url":"https://github.com/daserge","followers_url":"https://api.github.com/users/daserge/followers","following_url":"https://api.github.com/users/daserge/following{/other_user}","gists_url":"https://api.github.com/users/daserge/gists{/gist_id}","starred_url":"https://api.github.com/users/daserge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daserge/subscriptions","organizations_url":"https://api.github.com/users/daserge/orgs","repos_url":"https://api.github.com/users/daserge/repos","events_url":"https://api.github.com/users/daserge/events{/privacy}","received_events_url":"https://api.github.com/users/daserge/received_events","type":"User","site_admin":false},"body":"Added a corresponding test for events.forwardEventsTo\r\n\r\n[Jira issue](https://issues.apache.org/jira/browse/CB-10940)","created_at":"2016-03-28T18:07:54Z","updated_at":"2016-03-28T20:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2fc0ec17cc643b504c17ac15864935bfa9d9443","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-lib/pulls/418/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-lib/pulls/418/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-lib/issues/418/comments","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/9760a9c11189df15c1a28d0b34f5ddb4644f018d","head":{"label":"MSOpenTech:CB-10940","ref":"CB-10940","sha":"9760a9c11189df15c1a28d0b34f5ddb4644f018d","user":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=3","gravatar_id":"","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"repo":{"id":19624574,"name":"cordova-lib","full_name":"MSOpenTech/cordova-lib","owner":{"login":"MSOpenTech","id":1638184,"avatar_url":"https://avatars.githubusercontent.com/u/1638184?v=3","gravatar_id":"","url":"https://api.github.com/users/MSOpenTech","html_url":"https://github.com/MSOpenTech","followers_url":"https://api.github.com/users/MSOpenTech/followers","following_url":"https://api.github.com/users/MSOpenTech/following{/other_user}","gists_url":"https://api.github.com/users/MSOpenTech/gists{/gist_id}","starred_url":"https://api.github.com/users/MSOpenTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSOpenTech/subscriptions","organizations_url":"https://api.github.com/users/MSOpenTech/orgs","repos_url":"https://api.github.com/users/MSOpenTech/repos","events_url":"https://api.github.com/users/MSOpenTech/events{/privacy}","received_events_url":"https://api.github.com/users/MSOpenTech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MSOpenTech/cordova-lib","description":"Mirror of Apache Cordova","fork":true,"url":"https://api.github.com/repos/MSOpenTech/cordova-lib","forks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/forks","keys_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/teams","hooks_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/events","assignees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/tags","blobs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/subscription","commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/merges","archive_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/downloads","issues_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/releases{/id}","deployments_url":"https://api.github.com/repos/MSOpenTech/cordova-lib/deployments","created_at":"2014-05-09T20:30:32Z","updated_at":"2015-05-06T08:16:48Z","pushed_at":"2016-03-28T18:07:15Z","git_url":"git://github.com/MSOpenTech/cordova-lib.git","ssh_url":"git@github.com:MSOpenTech/cordova-lib.git","clone_url":"https://github.com/MSOpenTech/cordova-lib.git","svn_url":"https://github.com/MSOpenTech/cordova-lib","homepage":null,"size":44200,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9f630271d9c02824c0031ea4cdc0e4955b53d9e2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19524397,"name":"cordova-lib","full_name":"apache/cordova-lib","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-lib","description":"Mirror of Apache Cordova","fork":false,"url":"https://api.github.com/repos/apache/cordova-lib","forks_url":"https://api.github.com/repos/apache/cordova-lib/forks","keys_url":"https://api.github.com/repos/apache/cordova-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-lib/teams","hooks_url":"https://api.github.com/repos/apache/cordova-lib/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-lib/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-lib/events","assignees_url":"https://api.github.com/repos/apache/cordova-lib/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-lib/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-lib/tags","blobs_url":"https://api.github.com/repos/apache/cordova-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-lib/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-lib/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-lib/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-lib/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-lib/subscription","commits_url":"https://api.github.com/repos/apache/cordova-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-lib/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-lib/merges","archive_url":"https://api.github.com/repos/apache/cordova-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-lib/downloads","issues_url":"https://api.github.com/repos/apache/cordova-lib/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-lib/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-lib/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-lib/deployments","created_at":"2014-05-07T07:00:06Z","updated_at":"2016-03-26T18:06:49Z","pushed_at":"2016-03-28T18:07:55Z","git_url":"git://github.com/apache/cordova-lib.git","ssh_url":"git@github.com:apache/cordova-lib.git","clone_url":"https://github.com/apache/cordova-lib.git","svn_url":"https://github.com/apache/cordova-lib","homepage":null,"size":46723,"stargazers_count":119,"watchers_count":119,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":"git://git.apache.org/cordova-lib.git","open_issues_count":23,"forks":191,"open_issues":23,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/418"},"html":{"href":"https://github.com/apache/cordova-lib/pull/418"},"issue":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/418"},"comments":{"href":"https://api.github.com/repos/apache/cordova-lib/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-lib/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-lib/statuses/9760a9c11189df15c1a28d0b34f5ddb4644f018d"}}}}