{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/58297485","id":58297485,"diff_hunk":"@@ -79,6 +79,7 @@ public function getConfigTreeBuilder()\n                 ->scalarNode('title')->end()\n                 ->scalarNode('description')->end()\n                 ->scalarNode('original_route_pattern')->defaultValue(SeoPresentation::ORIGINAL_URL_CANONICAL)->end()\n+                ->scalarNode('locale')->defaultNull()->end()","path":"DependencyInjection/Configuration.php","position":4,"original_position":4,"commit_id":"963a765bc0bcefa8597dfbd7e95fe13049d0d769","original_commit_id":"963a765bc0bcefa8597dfbd7e95fe13049d0d769","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"The parameter is used to render the `http-equiv` language meta tag (see referenced PR).","created_at":"2016-04-02T18:17:43Z","updated_at":"2016-04-02T18:17:43Z","html_url":"https://github.com/symfony-cmf/SeoBundle/pull/278#discussion_r58297485","pull_request_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/58297485"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/278#discussion_r58297485"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278","id":65044851,"html_url":"https://github.com/symfony-cmf/SeoBundle/pull/278","diff_url":"https://github.com/symfony-cmf/SeoBundle/pull/278.diff","patch_url":"https://github.com/symfony-cmf/SeoBundle/pull/278.patch","issue_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/278","number":278,"state":"open","locked":false,"title":"Don't rely on a locale parameter being set","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"The `%locale%` parameter is just a convention used in the Standard Edition. This bundle can not assume that this parameter is available. Instead, a custom config option should be introduced.\r\n\r\nThis bug was introduced in https://github.com/symfony-cmf/SeoBundle/pull/262. I found this while trying to update the CMF website.\r\n\r\n/cc @dbu please merge this before releasing stable","created_at":"2016-04-02T17:48:40Z","updated_at":"2016-04-02T18:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ecbc059ec101d9b0ab842b7404a6b529f94729c","assignee":null,"milestone":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones/3","html_url":"https://github.com/symfony-cmf/SeoBundle/milestones/1.2","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones/3/labels","id":817296,"number":3,"title":"1.2","description":"","creator":{"login":"ElectricMaxxx","id":2905834,"avatar_url":"https://avatars.githubusercontent.com/u/2905834?v=3","gravatar_id":"","url":"https://api.github.com/users/ElectricMaxxx","html_url":"https://github.com/ElectricMaxxx","followers_url":"https://api.github.com/users/ElectricMaxxx/followers","following_url":"https://api.github.com/users/ElectricMaxxx/following{/other_user}","gists_url":"https://api.github.com/users/ElectricMaxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/ElectricMaxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElectricMaxxx/subscriptions","organizations_url":"https://api.github.com/users/ElectricMaxxx/orgs","repos_url":"https://api.github.com/users/ElectricMaxxx/repos","events_url":"https://api.github.com/users/ElectricMaxxx/events{/privacy}","received_events_url":"https://api.github.com/users/ElectricMaxxx/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":19,"state":"closed","created_at":"2014-10-07T18:42:19Z","updated_at":"2016-04-02T17:48:40Z","due_on":"2014-11-30T08:00:00Z","closed_at":"2016-04-01T11:46:47Z"},"commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/278/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/963a765bc0bcefa8597dfbd7e95fe13049d0d769","head":{"label":"symfony-cmf:locale_parameter_issue","ref":"locale_parameter_issue","sha":"963a765bc0bcefa8597dfbd7e95fe13049d0d769","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/deployments","created_at":"2014-01-30T09:17:14Z","updated_at":"2016-03-17T11:05:22Z","pushed_at":"2016-04-02T17:48:42Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":1018,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":13,"forks":21,"open_issues":13,"watchers":22,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"2d80990252a4dc448ba9a24c24afdd9b35100a1e","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/deployments","created_at":"2014-01-30T09:17:14Z","updated_at":"2016-03-17T11:05:22Z","pushed_at":"2016-04-02T17:48:42Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":1018,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":13,"forks":21,"open_issues":13,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/278"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/278"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/963a765bc0bcefa8597dfbd7e95fe13049d0d769"}}}}