{"action":"closed","number":33779,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/33779","id":72619026,"html_url":"https://github.com/saltstack/salt/pull/33779","diff_url":"https://github.com/saltstack/salt/pull/33779.diff","patch_url":"https://github.com/saltstack/salt/pull/33779.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/33779","number":33779,"state":"closed","locked":false,"title":"INFRA-1594 - Add various S3 functions needed for optionally emptying …","user":{"login":"tkwilliams","id":6216055,"avatar_url":"https://avatars.githubusercontent.com/u/6216055?v=3","gravatar_id":"","url":"https://api.github.com/users/tkwilliams","html_url":"https://github.com/tkwilliams","followers_url":"https://api.github.com/users/tkwilliams/followers","following_url":"https://api.github.com/users/tkwilliams/following{/other_user}","gists_url":"https://api.github.com/users/tkwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/tkwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkwilliams/subscriptions","organizations_url":"https://api.github.com/users/tkwilliams/orgs","repos_url":"https://api.github.com/users/tkwilliams/repos","events_url":"https://api.github.com/users/tkwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/tkwilliams/received_events","type":"User","site_admin":false},"body":"Add several useful bucket/object management functions to the boto_s3_bucket module, to in turn enable a Force param in the boto_s3_bucket state module, which allows one to optionally force deletion of a non-empty bucket, by emptying it first.\r\n\r\nAlso found that Type not being returned in the boto3 ACL description code was a bug (fixed in https://github.com/boto/botocore/pull/759) which was being worked around in the salt modules by unilaterally deleting the Type member from all ACL defs to permit clean comparisons against ACLs returned from searches.  Since the fix was shipped in botocore back in January, it seemed reasonable to remove this workaround code since it breaks comparisons on any boto versions shipped since then.  I then updated the utils module to require a recent-ish boto3 version.  Also added a check for the botocore version, since boto3 is actually just a very thin wrapper around botocore, and most breakage tends to actually be in the latter (and fixed there as well).\r\n","created_at":"2016-06-05T02:52:04Z","updated_at":"2016-06-06T21:52:08Z","closed_at":"2016-06-06T21:52:08Z","merged_at":"2016-06-06T21:52:08Z","merge_commit_sha":"db3cc8dceeac1cde87c9f888b8e054d11d069a0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/33779/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/33779/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/33779/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/102d696460b1939c89fd72ce2fd5b52d8eb76068","head":{"label":"bodhi-space:develop","ref":"develop","sha":"102d696460b1939c89fd72ce2fd5b52d8eb76068","user":{"login":"bodhi-space","id":11184220,"avatar_url":"https://avatars.githubusercontent.com/u/11184220?v=3","gravatar_id":"","url":"https://api.github.com/users/bodhi-space","html_url":"https://github.com/bodhi-space","followers_url":"https://api.github.com/users/bodhi-space/followers","following_url":"https://api.github.com/users/bodhi-space/following{/other_user}","gists_url":"https://api.github.com/users/bodhi-space/gists{/gist_id}","starred_url":"https://api.github.com/users/bodhi-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodhi-space/subscriptions","organizations_url":"https://api.github.com/users/bodhi-space/orgs","repos_url":"https://api.github.com/users/bodhi-space/repos","events_url":"https://api.github.com/users/bodhi-space/events{/privacy}","received_events_url":"https://api.github.com/users/bodhi-space/received_events","type":"Organization","site_admin":false},"repo":{"id":43849303,"name":"salt","full_name":"bodhi-space/salt","owner":{"login":"bodhi-space","id":11184220,"avatar_url":"https://avatars.githubusercontent.com/u/11184220?v=3","gravatar_id":"","url":"https://api.github.com/users/bodhi-space","html_url":"https://github.com/bodhi-space","followers_url":"https://api.github.com/users/bodhi-space/followers","following_url":"https://api.github.com/users/bodhi-space/following{/other_user}","gists_url":"https://api.github.com/users/bodhi-space/gists{/gist_id}","starred_url":"https://api.github.com/users/bodhi-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodhi-space/subscriptions","organizations_url":"https://api.github.com/users/bodhi-space/orgs","repos_url":"https://api.github.com/users/bodhi-space/repos","events_url":"https://api.github.com/users/bodhi-space/events{/privacy}","received_events_url":"https://api.github.com/users/bodhi-space/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bodhi-space/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/bodhi-space/salt","forks_url":"https://api.github.com/repos/bodhi-space/salt/forks","keys_url":"https://api.github.com/repos/bodhi-space/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bodhi-space/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bodhi-space/salt/teams","hooks_url":"https://api.github.com/repos/bodhi-space/salt/hooks","issue_events_url":"https://api.github.com/repos/bodhi-space/salt/issues/events{/number}","events_url":"https://api.github.com/repos/bodhi-space/salt/events","assignees_url":"https://api.github.com/repos/bodhi-space/salt/assignees{/user}","branches_url":"https://api.github.com/repos/bodhi-space/salt/branches{/branch}","tags_url":"https://api.github.com/repos/bodhi-space/salt/tags","blobs_url":"https://api.github.com/repos/bodhi-space/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bodhi-space/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bodhi-space/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bodhi-space/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bodhi-space/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/bodhi-space/salt/languages","stargazers_url":"https://api.github.com/repos/bodhi-space/salt/stargazers","contributors_url":"https://api.github.com/repos/bodhi-space/salt/contributors","subscribers_url":"https://api.github.com/repos/bodhi-space/salt/subscribers","subscription_url":"https://api.github.com/repos/bodhi-space/salt/subscription","commits_url":"https://api.github.com/repos/bodhi-space/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bodhi-space/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bodhi-space/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bodhi-space/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bodhi-space/salt/contents/{+path}","compare_url":"https://api.github.com/repos/bodhi-space/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bodhi-space/salt/merges","archive_url":"https://api.github.com/repos/bodhi-space/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bodhi-space/salt/downloads","issues_url":"https://api.github.com/repos/bodhi-space/salt/issues{/number}","pulls_url":"https://api.github.com/repos/bodhi-space/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/bodhi-space/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/bodhi-space/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bodhi-space/salt/labels{/name}","releases_url":"https://api.github.com/repos/bodhi-space/salt/releases{/id}","deployments_url":"https://api.github.com/repos/bodhi-space/salt/deployments","created_at":"2015-10-07T22:53:40Z","updated_at":"2016-01-22T18:32:24Z","pushed_at":"2016-06-06T18:38:21Z","git_url":"git://github.com/bodhi-space/salt.git","ssh_url":"git@github.com:bodhi-space/salt.git","clone_url":"https://github.com/bodhi-space/salt.git","svn_url":"https://github.com/bodhi-space/salt","homepage":"saltstack.com","size":163351,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"d90448a3c310716215d04cf6bc538a4b53aa881e","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-06-06T16:19:19Z","pushed_at":"2016-06-06T21:52:08Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":231650,"stargazers_count":6582,"watchers_count":6582,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2927,"mirror_url":null,"open_issues_count":3561,"forks":2927,"open_issues":3561,"watchers":6582,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33779"},"html":{"href":"https://github.com/saltstack/salt/pull/33779"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/33779"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/33779/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33779/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/33779/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/102d696460b1939c89fd72ce2fd5b52d8eb76068"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":6,"additions":196,"deletions":28,"changed_files":5}}
{"actor":{"display_login":"cachedout"}}