{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6459","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6459/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6459/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6459/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6459","id":152688758,"number":6459,"title":"remove non-test dependency on testutils","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-03T02:39:10Z","updated_at":"2016-05-03T12:25:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6459","html_url":"https://github.com/cockroachdb/cockroach/pull/6459","diff_url":"https://github.com/cockroachdb/cockroach/pull/6459.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6459.patch"},"body":"`LocalTestCluster` has a dependency on `testutils` which is easily removed by\r\nhaving the caller pass a context. This is testing code but is part of the kv\r\npackage because it is used from a test in another package. The dependency\r\nblocked the addition of new functionality that involves `testing`.\r\n\r\nAdding a dummy dependency on `testing` so this doesn't happen in the future.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6459)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/216512026","html_url":"https://github.com/cockroachdb/cockroach/pull/6459#issuecomment-216512026","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6459","id":216512026,"user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T12:25:19Z","updated_at":"2016-05-03T12:25:19Z","body":"TFTR! Good idea, switched to checking in `TestNoLinkForbidden`. Also removed dependency on `storageutils` so we can forbid everything under `testutils`.\n\n---\n\nReview status: 0 of 21 files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/6459#-:-KGqZu7DO4Tlnd7KHhJT:-1193796060)*\n<!-- Sent from Reviewable.io -->\n"}}