{"action":"closed","number":4802,"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802","id":73497336,"html_url":"https://github.com/elixir-lang/elixir/pull/4802","diff_url":"https://github.com/elixir-lang/elixir/pull/4802.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/4802.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4802","number":4802,"state":"closed","locked":false,"title":"Some improvements to the Map module","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"body":"In this PR I mostly\r\n\r\n* polished docs for the `Map` module (first commit)\r\n* added some `is_function/2` guards to some functions in `Map` (second commit)\r\n* made some errors better in `Map` (e.g., `:erlang.error({:badkey, key})` becomes `raise KeyError, ...` (third commit)\r\n\r\nThe first commit should be an instamerge, but I was not 100% sure about the other two as they may be considered to break backwards compatibilty (I'm not sure because people shouldn't rely on unspecified behaviours). This is why I split the PR into separate commits, I can nuke them singularly if needed :)","created_at":"2016-06-12T14:13:14Z","updated_at":"2016-06-15T14:37:24Z","closed_at":"2016-06-15T14:37:24Z","merged_at":"2016-06-15T14:37:24Z","merge_commit_sha":"ce96254cef6e59179c6ced23b6dd6e547cce0b3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4802/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/28dbc1abe977c1b770342e46f3ee6c154fd5d9bc","head":{"label":"whatyouhide:better-maps","ref":"better-maps","sha":"28dbc1abe977c1b770342e46f3ee6c154fd5d9bc","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"repo":{"id":27794017,"name":"elixir","full_name":"whatyouhide/elixir","owner":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whatyouhide/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/whatyouhide/elixir","forks_url":"https://api.github.com/repos/whatyouhide/elixir/forks","keys_url":"https://api.github.com/repos/whatyouhide/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatyouhide/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatyouhide/elixir/teams","hooks_url":"https://api.github.com/repos/whatyouhide/elixir/hooks","issue_events_url":"https://api.github.com/repos/whatyouhide/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/whatyouhide/elixir/events","assignees_url":"https://api.github.com/repos/whatyouhide/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/whatyouhide/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/whatyouhide/elixir/tags","blobs_url":"https://api.github.com/repos/whatyouhide/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatyouhide/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatyouhide/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatyouhide/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatyouhide/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/whatyouhide/elixir/languages","stargazers_url":"https://api.github.com/repos/whatyouhide/elixir/stargazers","contributors_url":"https://api.github.com/repos/whatyouhide/elixir/contributors","subscribers_url":"https://api.github.com/repos/whatyouhide/elixir/subscribers","subscription_url":"https://api.github.com/repos/whatyouhide/elixir/subscription","commits_url":"https://api.github.com/repos/whatyouhide/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatyouhide/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatyouhide/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatyouhide/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatyouhide/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/whatyouhide/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatyouhide/elixir/merges","archive_url":"https://api.github.com/repos/whatyouhide/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatyouhide/elixir/downloads","issues_url":"https://api.github.com/repos/whatyouhide/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/whatyouhide/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/whatyouhide/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/whatyouhide/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatyouhide/elixir/labels{/name}","releases_url":"https://api.github.com/repos/whatyouhide/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/whatyouhide/elixir/deployments","created_at":"2014-12-10T00:12:42Z","updated_at":"2015-02-14T09:28:19Z","pushed_at":"2016-06-12T16:45:58Z","git_url":"git://github.com/whatyouhide/elixir.git","ssh_url":"git@github.com:whatyouhide/elixir.git","clone_url":"https://github.com/whatyouhide/elixir.git","svn_url":"https://github.com/whatyouhide/elixir","homepage":"http://elixir-lang.org/","size":34283,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"9a74ea7520f719975810027ee332d6284b9861df","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2016-06-15T09:32:34Z","pushed_at":"2016-06-15T14:37:24Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":43190,"stargazers_count":7266,"watchers_count":7266,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1002,"mirror_url":null,"open_issues_count":8,"forks":1002,"open_issues":8,"watchers":7266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4802"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4802"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4802/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4802/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/28dbc1abe977c1b770342e46f3ee6c154fd5d9bc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":3,"additions":77,"deletions":51,"changed_files":1}}
{"actor":{"display_login":"whatyouhide"}}