{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/client/pulls/comments/68988330","id":68988330,"diff_hunk":"@@ -1,36 +1,77 @@\n // @flow\n \n import React, {Component} from 'react'\n+import {Image, TouchableWithoutFeedback} from 'react-native'\n import type {Props} from './avatar'\n-import {Box, Icon} from '../common-adapters'\n+import {Box} from '../common-adapters'\n+import {images} from './icon.paths.native'\n+import {globalStyles} from '../styles/style-guide'\n+import * as shared from './avatar.shared'\n \n-export default class Avatar extends Component {\n-  props: Props;\n+type State = {\n+  avatarLoaded: boolean,\n+}\n \n-  state: {\n-    avatarLoaded: boolean\n-  };\n+export default class Avatar extends Component<void, Props, State> {\n+  props: Props;\n+  state: State;\n \n   constructor (props: Props) {\n     super(props)\n     this.state = {avatarLoaded: false}\n   }\n \n   render () {\n-    return (\n-      <Box style={{justifyContent: 'flex-end', ...this.props.style}} onClick={this.props.onClick}>\n-        <Icon style={{...avatarStyle(this.props.size - 2)}}\n-          type='placeholder-avatar' />\n+    const {size} = this.props\n+    const uri = {uri: shared.createAvatarUrl(this.props)}\n+    console.log('uri & state & props', uri, this.state, this.props)","path":"shared/common-adapters/avatar.native.js","position":37,"original_position":37,"commit_id":"b8f0fb056d6d934e541ab2de6c589764e4c0bb33","original_commit_id":"b8f0fb056d6d934e541ab2de6c589764e4c0bb33","user":{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false},"body":"This will be fixed promptly 😞","created_at":"2016-06-29T17:15:22Z","updated_at":"2016-06-29T17:15:22Z","html_url":"https://github.com/keybase/client/pull/3231#discussion_r68988330","pull_request_url":"https://api.github.com/repos/keybase/client/pulls/3231","_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/comments/68988330"},"html":{"href":"https://github.com/keybase/client/pull/3231#discussion_r68988330"},"pull_request":{"href":"https://api.github.com/repos/keybase/client/pulls/3231"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3231","id":75403048,"html_url":"https://github.com/keybase/client/pull/3231","diff_url":"https://github.com/keybase/client/pull/3231.diff","patch_url":"https://github.com/keybase/client/pull/3231.patch","issue_url":"https://api.github.com/repos/keybase/client/issues/3231","number":3231,"state":"open","locked":false,"title":"Mobile avatars w/o badging DESKTOP-1096","user":{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false},"body":"Placeholder icons are used when no network is available. Attempts are made to keep the view hierarchy as simple as possible (and to avoid unexpected click interceptions), so a TouchableWithoutHighlight wrapper is only added if their is an onClick method supplied.\r\n\r\nThis fixes the issues mentioned in [PR #2949, WIP: Setup avatars on mobile DESKTOP-1096](https://github.com/keybase/client/pull/2949). Thanks @MarcoPolo for the update to RN 0.27!\r\n\r\nA following PR will be necessary to bring avatar badging to mobile.\r\n\r\n<img width=\"432\" alt=\"screen shot 2016-06-27 at 5 46 03 pm\" src=\"https://cloud.githubusercontent.com/assets/1152104/16400320/1c6f1be6-3c8f-11e6-8840-11baa2cbf22e.png\">\r\n<img width=\"418\" alt=\"screen shot 2016-06-27 at 5 46 01 pm\" src=\"https://cloud.githubusercontent.com/assets/1152104/16400321/1c7e04bc-3c8f-11e6-9949-ce5f1d82ca5f.png\">\r\n\r\nThe problem of https://github.com/keybase/client/pull/2949 was that RN doesn't properly handle `borderRadius` on Android when the Image `resizeMode` is set to `contain`. This was an undocumented bug which has now been brought to light (but not yet fixed).\r\n\r\n@keybase/react-hackers ","created_at":"2016-06-28T00:52:02Z","updated_at":"2016-06-29T17:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c09b432f7a84f5c4611ae3fbb78c197c6f5629a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/client/pulls/3231/commits","review_comments_url":"https://api.github.com/repos/keybase/client/pulls/3231/comments","review_comment_url":"https://api.github.com/repos/keybase/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/client/issues/3231/comments","statuses_url":"https://api.github.com/repos/keybase/client/statuses/b8f0fb056d6d934e541ab2de6c589764e4c0bb33","head":{"label":"keybase:awendland/DESKTOP-1096-mobile-avatars","ref":"awendland/DESKTOP-1096-mobile-avatars","sha":"b8f0fb056d6d934e541ab2de6c589764e4c0bb33","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-06-29T17:12:41Z","pushed_at":"2016-06-29T17:09:54Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":155144,"stargazers_count":563,"watchers_count":563,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":248,"forks":43,"open_issues":248,"watchers":563,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"84496723ca2fd84719dd8a4511846ee69849eb5f","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":29099181,"name":"client","full_name":"keybase/client","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/client","description":"Keybase Go Library, Client, Service, OS X, iOS, Android, Electron","fork":false,"url":"https://api.github.com/repos/keybase/client","forks_url":"https://api.github.com/repos/keybase/client/forks","keys_url":"https://api.github.com/repos/keybase/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/client/teams","hooks_url":"https://api.github.com/repos/keybase/client/hooks","issue_events_url":"https://api.github.com/repos/keybase/client/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/client/events","assignees_url":"https://api.github.com/repos/keybase/client/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/client/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/client/tags","blobs_url":"https://api.github.com/repos/keybase/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/client/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/client/languages","stargazers_url":"https://api.github.com/repos/keybase/client/stargazers","contributors_url":"https://api.github.com/repos/keybase/client/contributors","subscribers_url":"https://api.github.com/repos/keybase/client/subscribers","subscription_url":"https://api.github.com/repos/keybase/client/subscription","commits_url":"https://api.github.com/repos/keybase/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/client/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/client/merges","archive_url":"https://api.github.com/repos/keybase/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/client/downloads","issues_url":"https://api.github.com/repos/keybase/client/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/client/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/client/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/client/labels{/name}","releases_url":"https://api.github.com/repos/keybase/client/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/client/deployments","created_at":"2015-01-11T17:17:12Z","updated_at":"2016-06-29T17:12:41Z","pushed_at":"2016-06-29T17:09:54Z","git_url":"git://github.com/keybase/client.git","ssh_url":"git@github.com:keybase/client.git","clone_url":"https://github.com/keybase/client.git","svn_url":"https://github.com/keybase/client","homepage":"","size":155144,"stargazers_count":563,"watchers_count":563,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":248,"forks":43,"open_issues":248,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/client/pulls/3231"},"html":{"href":"https://github.com/keybase/client/pull/3231"},"issue":{"href":"https://api.github.com/repos/keybase/client/issues/3231"},"comments":{"href":"https://api.github.com/repos/keybase/client/issues/3231/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/client/pulls/3231/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/client/pulls/3231/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/client/statuses/b8f0fb056d6d934e541ab2de6c589764e4c0bb33"}}}}
{"actor":{"display_login":"awendland"}}