{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/55920177","id":55920177,"diff_hunk":"@@ -28,7 +28,7 @@\n         \"symfony/property-info\": \"~2.8|3.0\",\n         \"symfony/security\": \"~2.8|~3.0\",\n         \"symfony/expression-language\": \"~2.8|~3.0\",\n-        \"symfony/validator\": \"~2.8|~3.0\",\n+        \"symfony/validator\": \"~3.1\",","path":"src/Symfony/Bridge/Doctrine/composer.json","position":5,"original_position":5,"commit_id":"d4ff6fff78ff575c57dfb04ec1aff71e1ca7d0d8","original_commit_id":"cbf1f77ceafdb60c7318b8ef65e70ae26765e11d","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"So the solution would be to keep both classes (new and old) and use the old one in the core libraries, so we can still properly support and test 2.8 and 3.0?","created_at":"2016-03-12T11:26:53Z","updated_at":"2016-03-12T11:26:53Z","html_url":"https://github.com/symfony/symfony/pull/17203#discussion_r55920177","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/17203","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/55920177"},"html":{"href":"https://github.com/symfony/symfony/pull/17203#discussion_r55920177"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17203"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/17203","id":54870874,"html_url":"https://github.com/symfony/symfony/pull/17203","diff_url":"https://github.com/symfony/symfony/pull/17203.diff","patch_url":"https://github.com/symfony/symfony/pull/17203.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/17203","number":17203,"state":"open","locked":false,"title":"Move Constraint validator test case to Test namespace","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | kinda\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThe Validator component has a very usefull test utility to test constraint validators. It's only hidden deep in the Tests namespace. Just as was done with the TypeTestCase of the Form component some years ago, I think it's usefull to move the constraint test case to the Test namespace as well.\r\n\r\n*Btw, my last PR of the year and the first deprecation of 3.1* :fireworks:","created_at":"2015-12-31T16:41:57Z","updated_at":"2016-03-12T11:26:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca1479a76f3677312aafda15e78518f6d4eac30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/17203/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/17203/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/17203/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/d4ff6fff78ff575c57dfb04ec1aff71e1ca7d0d8","head":{"label":"WouterJ:validator-move_constraint_test","ref":"validator-move_constraint_test","sha":"d4ff6fff78ff575c57dfb04ec1aff71e1ca7d0d8","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"WouterJ/symfony","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony","forks_url":"https://api.github.com/repos/WouterJ/symfony/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/WouterJ/symfony/deployments","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2016-02-29T20:04:55Z","git_url":"git://github.com/WouterJ/symfony.git","ssh_url":"git@github.com:WouterJ/symfony.git","clone_url":"https://github.com/WouterJ/symfony.git","svn_url":"https://github.com/WouterJ/symfony","homepage":"symfony.com","size":67808,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"c55babaf950dbb647f508e240c36ce7db3d78ae7","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-03-12T09:57:41Z","pushed_at":"2016-03-12T10:20:51Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":103518,"stargazers_count":11914,"watchers_count":11914,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4666,"mirror_url":null,"open_issues_count":701,"forks":4666,"open_issues":701,"watchers":11914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17203"},"html":{"href":"https://github.com/symfony/symfony/pull/17203"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/17203"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/17203/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17203/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17203/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/d4ff6fff78ff575c57dfb04ec1aff71e1ca7d0d8"}}}}