{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/comments/63406653","id":63406653,"diff_hunk":"@@ -333,7 +333,7 @@ private static void grep(File dir, String text, String prefix, Set<String> match\n                 p.setDefinition(new CpsFlowDefinition(\n                         \"node {\\n\" +\n                                 \"     def busybox = docker.image('busybox');\\n\" +\n-                                \"     busybox.run('--rm', 'echo \\\"Hello\\\"');\\n\" +\n+                                \"     busybox.run('--tty', 'echo \\\"Hello\\\"').stop();\\n\" +","path":"src/test/java/org/jenkinsci/plugins/docker/workflow/DockerDSLTest.java","position":5,"original_position":5,"commit_id":"4ca7a15d2b2d70595a61638a242522c2f8095d80","original_commit_id":"4ca7a15d2b2d70595a61638a242522c2f8095d80","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"`stop` deletes it.","created_at":"2016-05-16T19:02:42Z","updated_at":"2016-05-16T19:02:42Z","html_url":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43#discussion_r63406653","pull_request_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/comments/63406653"},"html":{"href":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43#discussion_r63406653"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43","id":69908367,"html_url":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43","diff_url":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43.diff","patch_url":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43.patch","issue_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/43","number":43,"state":"open","locked":false,"title":"Fixing test","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"The test from #37 was broken, at least when using Docker 1.11.1:\r\n\r\n```\r\n+ docker run -d --rm busybox echo Hello\r\nConflicting options: --rm and -d\r\n```\r\n\r\nAlso the test neglected to call `Container.stop`, so it was creating a zombie container on every run.\r\n\r\n@reviewbybees esp. @vfarcic","created_at":"2016-05-12T21:16:34Z","updated_at":"2016-05-16T19:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ded8b70c682357a2e31a1752706fc4fce8a2fde9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/43/comments","statuses_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/statuses/4ca7a15d2b2d70595a61638a242522c2f8095d80","head":{"label":"jglick:fix-test","ref":"fix-test","sha":"4ca7a15d2b2d70595a61638a242522c2f8095d80","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":36393694,"name":"docker-workflow-plugin","full_name":"jglick/docker-workflow-plugin","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/docker-workflow-plugin","description":"","fork":true,"url":"https://api.github.com/repos/jglick/docker-workflow-plugin","forks_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/forks","keys_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/events","assignees_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/merges","archive_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/docker-workflow-plugin/deployments","created_at":"2015-05-27T20:26:02Z","updated_at":"2015-05-27T20:26:02Z","pushed_at":"2016-05-12T21:15:15Z","git_url":"git://github.com/jglick/docker-workflow-plugin.git","ssh_url":"git@github.com:jglick/docker-workflow-plugin.git","clone_url":"https://github.com/jglick/docker-workflow-plugin.git","svn_url":"https://github.com/jglick/docker-workflow-plugin","homepage":"","size":264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"cdb0000bee2ab0320a4c30f5bb2d05b6fa6cb027","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":36385785,"name":"docker-workflow-plugin","full_name":"jenkinsci/docker-workflow-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/docker-workflow-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin","forks_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/deployments","created_at":"2015-05-27T18:02:51Z","updated_at":"2016-05-06T00:15:51Z","pushed_at":"2016-05-12T21:16:34Z","git_url":"git://github.com/jenkinsci/docker-workflow-plugin.git","ssh_url":"git@github.com:jenkinsci/docker-workflow-plugin.git","clone_url":"https://github.com/jenkinsci/docker-workflow-plugin.git","svn_url":"https://github.com/jenkinsci/docker-workflow-plugin","homepage":"","size":302,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":5,"forks":37,"open_issues":5,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43"},"html":{"href":"https://github.com/jenkinsci/docker-workflow-plugin/pull/43"},"issue":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/43"},"comments":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/docker-workflow-plugin/statuses/4ca7a15d2b2d70595a61638a242522c2f8095d80"}}}}