{"action":"closed","number":160,"pull_request":{"url":"https://api.github.com/repos/Microsoft/code-push/pulls/160","id":62480476,"html_url":"https://github.com/Microsoft/code-push/pull/160","diff_url":"https://github.com/Microsoft/code-push/pull/160.diff","patch_url":"https://github.com/Microsoft/code-push/pull/160.patch","issue_url":"https://api.github.com/repos/Microsoft/code-push/issues/160","number":160,"state":"closed","locked":false,"title":"Gradle parsing issue","user":{"login":"geof90","id":8598682,"avatar_url":"https://avatars.githubusercontent.com/u/8598682?v=3","gravatar_id":"","url":"https://api.github.com/users/geof90","html_url":"https://github.com/geof90","followers_url":"https://api.github.com/users/geof90/followers","following_url":"https://api.github.com/users/geof90/following{/other_user}","gists_url":"https://api.github.com/users/geof90/gists{/gist_id}","starred_url":"https://api.github.com/users/geof90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geof90/subscriptions","organizations_url":"https://api.github.com/users/geof90/orgs","repos_url":"https://api.github.com/users/geof90/repos","events_url":"https://api.github.com/users/geof90/events{/privacy}","received_events_url":"https://api.github.com/users/geof90/received_events","type":"User","site_admin":false},"body":"The gradle-to-js npm module will parse a versionName of \"1.0\" as the Javascript number \"1\". With that, we have no way to tell whether it has a minor version or not. I forked the project and changed the parser to always return strings as the obvious but workable solution for our purposes. https://github.com/geof90/gradle-to-js/commit/ccd3362ad227203319f799dda03a6db3577c56a8","created_at":"2016-03-11T00:34:41Z","updated_at":"2016-03-11T01:14:44Z","closed_at":"2016-03-11T01:14:44Z","merged_at":"2016-03-11T01:14:44Z","merge_commit_sha":"e229faceb08ece2f5e37c568ab3a12db18142aa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/code-push/pulls/160/commits","review_comments_url":"https://api.github.com/repos/Microsoft/code-push/pulls/160/comments","review_comment_url":"https://api.github.com/repos/Microsoft/code-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/code-push/issues/160/comments","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/2400975007490daa8f7b909ac28f4bd440e09cf8","head":{"label":"Microsoft:gradle-parsing-issue","ref":"gradle-parsing-issue","sha":"2400975007490daa8f7b909ac28f4bd440e09cf8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43459513,"name":"code-push","full_name":"Microsoft/code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/code-push","description":"A cloud service that enables Cordova and React Native developers to deploy mobile app updates directly to their users’ devices","fork":false,"url":"https://api.github.com/repos/Microsoft/code-push","forks_url":"https://api.github.com/repos/Microsoft/code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/code-push/deployments","created_at":"2015-09-30T21:12:55Z","updated_at":"2016-03-11T00:12:04Z","pushed_at":"2016-03-11T01:14:44Z","git_url":"git://github.com/Microsoft/code-push.git","ssh_url":"git@github.com:Microsoft/code-push.git","clone_url":"https://github.com/Microsoft/code-push.git","svn_url":"https://github.com/Microsoft/code-push","homepage":"http://codepush.tools","size":5668,"stargazers_count":1061,"watchers_count":1061,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":2,"forks":69,"open_issues":2,"watchers":1061,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3f11ff6cef6a3cc552e90ce882edf4c13ee7406a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43459513,"name":"code-push","full_name":"Microsoft/code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/code-push","description":"A cloud service that enables Cordova and React Native developers to deploy mobile app updates directly to their users’ devices","fork":false,"url":"https://api.github.com/repos/Microsoft/code-push","forks_url":"https://api.github.com/repos/Microsoft/code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/code-push/deployments","created_at":"2015-09-30T21:12:55Z","updated_at":"2016-03-11T00:12:04Z","pushed_at":"2016-03-11T01:14:44Z","git_url":"git://github.com/Microsoft/code-push.git","ssh_url":"git@github.com:Microsoft/code-push.git","clone_url":"https://github.com/Microsoft/code-push.git","svn_url":"https://github.com/Microsoft/code-push","homepage":"http://codepush.tools","size":5668,"stargazers_count":1061,"watchers_count":1061,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":2,"forks":69,"open_issues":2,"watchers":1061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/160"},"html":{"href":"https://github.com/Microsoft/code-push/pull/160"},"issue":{"href":"https://api.github.com/repos/Microsoft/code-push/issues/160"},"comments":{"href":"https://api.github.com/repos/Microsoft/code-push/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/code-push/statuses/2400975007490daa8f7b909ac28f4bd440e09cf8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"geof90","id":8598682,"avatar_url":"https://avatars.githubusercontent.com/u/8598682?v=3","gravatar_id":"","url":"https://api.github.com/users/geof90","html_url":"https://github.com/geof90","followers_url":"https://api.github.com/users/geof90/followers","following_url":"https://api.github.com/users/geof90/following{/other_user}","gists_url":"https://api.github.com/users/geof90/gists{/gist_id}","starred_url":"https://api.github.com/users/geof90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geof90/subscriptions","organizations_url":"https://api.github.com/users/geof90/orgs","repos_url":"https://api.github.com/users/geof90/repos","events_url":"https://api.github.com/users/geof90/events{/privacy}","received_events_url":"https://api.github.com/users/geof90/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":1,"deletions":1,"changed_files":1}}