{"action":"created","issue":{"url":"https://api.github.com/repos/toranb/ember-redux/issues/63","repository_url":"https://api.github.com/repos/toranb/ember-redux","labels_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/comments","events_url":"https://api.github.com/repos/toranb/ember-redux/issues/63/events","html_url":"https://github.com/toranb/ember-redux/pull/63","id":195107728,"number":63,"title":"Use Ember shims for redux packages instead of ember-browserify","user":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-12-12T22:43:26Z","updated_at":"2016-12-16T06:44:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/toranb/ember-redux/pulls/63","html_url":"https://github.com/toranb/ember-redux/pull/63","diff_url":"https://github.com/toranb/ember-redux/pull/63.diff","patch_url":"https://github.com/toranb/ember-redux/pull/63.patch"},"body":"In an effort to remove the dependency of `ember-browserify` I've created three new shims for packages previously being included via `ember-browserify`:\r\n\r\n* [ember-redux-shim](https://github.com/ciena-blueplanet/ember-redux-shim)\r\n* [ember-redux-thunk](https://github.com/ciena-blueplanet/ember-redux-thunk)\r\n* [ember-redux-saga](https://github.com/ciena-blueplanet/ember-redux-saga)\r\n\r\nThis pull request is an alternative approach to what has been done in #57 "},"comment":{"url":"https://api.github.com/repos/toranb/ember-redux/issues/comments/267528766","html_url":"https://github.com/toranb/ember-redux/pull/63#issuecomment-267528766","issue_url":"https://api.github.com/repos/toranb/ember-redux/issues/63","id":267528766,"user":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T06:44:57Z","updated_at":"2016-12-16T06:44:57Z","body":"Probably stemming from the two copies of redux in your vendor bundle before you remove \"npm:\" prefixes.  So potentially two redux stores (one probably not initialized). when you npmRedux.dispatch and redux.dispatch you get different results, etc..\n\nAll the more reason to make this clear in the release notes; and since this actually breaks, sounds like a major bump after all.\n\n> On Dec 16, 2016, at 2:34 PM, Miguel Madero <notifications@github.com> wrote:\n> \n> I don't see any blockers. It works on my machine and I tried that in one our project.\n> \n> re: v2.0/breaking change. It's debatable, but IMO, it seems like an interface change. We were importing npm:redux explicitly and I had to update all the imports, not only to reduce the payload size, but something wasn't working. I didn't look too deep into the issue, maybe just PEBCAK, but I can have another look tomorrow if that would make a difference.\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub <https://github.com/toranb/ember-redux/pull/63#issuecomment-267527499>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCWvcj3RZBYwtUrt_LBB-wzGat6AKMJks5rIjDogaJpZM4LLHnU>.\n> \n\n-- \nDustin Farris\n\n\n\n"}}
{"actor":{"display_login":"dustinfarris"}}