{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16030","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16030/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16030/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16030/events","html_url":"https://github.com/cms-sw/cmssw/pull/16030","id":179991010,"number":16030,"title":"Extension of infrastructure to readout tau discriminators from miniAOD to anti-electron discriminator","user":{"login":"roger-wolf","id":4981329,"avatar_url":"https://avatars.githubusercontent.com/u/4981329?v=3","gravatar_id":"","url":"https://api.github.com/users/roger-wolf","html_url":"https://github.com/roger-wolf","followers_url":"https://api.github.com/users/roger-wolf/followers","following_url":"https://api.github.com/users/roger-wolf/following{/other_user}","gists_url":"https://api.github.com/users/roger-wolf/gists{/gist_id}","starred_url":"https://api.github.com/users/roger-wolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roger-wolf/subscriptions","organizations_url":"https://api.github.com/users/roger-wolf/orgs","repos_url":"https://api.github.com/users/roger-wolf/repos","events_url":"https://api.github.com/users/roger-wolf/events{/privacy}","received_events_url":"https://api.github.com/users/roger-wolf/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":1551,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-30T09:57:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-09-29T09:05:20Z","updated_at":"2016-09-30T10:23:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16030","html_url":"https://github.com/cms-sw/cmssw/pull/16030","diff_url":"https://github.com/cms-sw/cmssw/pull/16030.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16030.patch"},"body":"Hi all, \r\n\r\nthis is the extension of the infrastructure also to be able to readout the tau anti-electron discriminator from existing miniAOD event content on the final analysis level. The pull requests https://github.com/cms-sw/cmssw/pull/15778 and https://github.com/cms-sw/cmssw/pull/15995 have laid out much of the ground for this pull request. The pull request has been announced since we started the overall integration campaign and discussed e.g. in the last RECO/AT meeting (*).\r\n\r\nThe changes in the following files are actually part of https://github.com/cms-sw/cmssw/pull/15995 and should just be merged:\r\n - DataFormats/PatCandidates/interface/Tau.h\r\n - DataFormats/PatCandidates/interface/TauPFEssential.h\r\n - DataFormats/PatCandidates/src/TauPFEssential.cc\r\n - DataFormats/PatCandidates/src/classes_def_objects.xml\r\n - PhysicsTools/PatAlgos/plugins/PATTauProducer.cc\r\n\r\nThe following changes are only small modifications to files to enable the plugin for readout from pat::Taus:\r\n - RecoTauTag/RecoTau/interface/AntiElectronIDMVA6.h\r\n - RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc\r\n\r\nThe following files have been added to form the new plugin:\r\n - RecoTauTag/RecoTau/plugins/PATTauDiscriminationAgainstElectronMVA6.cc\r\n - RecoTauTag/RecoTau/python/PATTauDiscriminationAgainstElectronMVA6_cfi.py\r\n\r\nThe last two files contain modifications that have been made for our internal testing of the new (on miniAOD) and old (from AOD/standard) readout and to proof in a unit test that both lead to the same output:\r\n - RecoTauTag/RecoTau/test/rerunMVAIsolationOnMiniAOD.cc\r\n - RecoTauTag/RecoTau/test/rerunMVAIsolationOnMiniAOD.py \r\n\r\nSimilar statements apply as for https://github.com/cms-sw/cmssw/pull/15778: the code changes concern code that is run on user level. They are detached from standard reconstruction sequences. In addition this pull request makes use of the infrastructure that has been introduced for https://github.com/cms-sw/cmssw/pull/15778. It thus is not as extended as I had thought initially. \r\n\r\nUsual tests have been made and no problems have been spotted. Additional tests that we do internally have been positive. We do not expect any change to the outcome of existing RelVal tests. There might be minor cosmetic items during visual review (like removing commented lines) but I'm pushing this pull request already now to get the static testing done since I've to leave in a few minutes and will be off for the rest of the day. I can react to comments from tonight on again. \r\n\r\nThis PR (for the time being) closes the development cycle we expected for 81X in spring this year. Thanx a lot for the quick integration of the preceding PR's, on which this one relies.\r\n\r\nCheers,\r\nRoger\r\n\r\n(*)\r\nhttps://indico.cern.ch/event/570119/contributions/2305878/attachments/1340889/2019361/TauPOG-2016-09-21-RECO-AT.pdf"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/250711334","html_url":"https://github.com/cms-sw/cmssw/pull/16030#issuecomment-250711334","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16030","id":250711334,"user":{"login":"roger-wolf","id":4981329,"avatar_url":"https://avatars.githubusercontent.com/u/4981329?v=3","gravatar_id":"","url":"https://api.github.com/users/roger-wolf","html_url":"https://github.com/roger-wolf","followers_url":"https://api.github.com/users/roger-wolf/followers","following_url":"https://api.github.com/users/roger-wolf/following{/other_user}","gists_url":"https://api.github.com/users/roger-wolf/gists{/gist_id}","starred_url":"https://api.github.com/users/roger-wolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roger-wolf/subscriptions","organizations_url":"https://api.github.com/users/roger-wolf/orgs","repos_url":"https://api.github.com/users/roger-wolf/repos","events_url":"https://api.github.com/users/roger-wolf/events{/privacy}","received_events_url":"https://api.github.com/users/roger-wolf/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T10:23:08Z","updated_at":"2016-09-30T10:23:08Z","body":"Hi Slava, \r\n\r\nthe PR was based on CMSSW_8_1_0_pre12, this is why I still needed these modifications. I've now merged the PR with CMSSW_8_1_X_2016-09-29-2300, which has https://github.com/cms-sw/cmssw/pull/15995 already integrated. I hope this satisfies your request.\r\n\r\nCheers,\r\nRoger"}}
{"actor":{"display_login":"roger-wolf"}}