{"action":"created","issue":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/99","repository_url":"https://api.github.com/repos/AtheMathmo/rulinalg","labels_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/99/comments","events_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/99/events","html_url":"https://github.com/AtheMathmo/rulinalg/pull/99","id":193130726,"number":99,"title":"Updating get_row functions to return MatrixSlice","user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-02T14:36:57Z","updated_at":"2016-12-08T16:39:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/pulls/99","html_url":"https://github.com/AtheMathmo/rulinalg/pull/99","diff_url":"https://github.com/AtheMathmo/rulinalg/pull/99.diff","patch_url":"https://github.com/AtheMathmo/rulinalg/pull/99.patch"},"body":"This is a very incomplete PR. I'm just putting in the request so I can track outstanding work more easily. Still to do:\r\n\r\n- [x] Add column equivalents\r\n- [x] Update row iterator\r\n- [x] Rename functions to remove `get_` prefix. (Does this make the unchecked functions look weird?)\r\n- [x] Explore custom types for `Row` and `Col`.\r\n- [x] Benchmarks to compare performance\r\n- [ ] Basic evaluation of vectorization issues. (Do we need to keep casting to contiguous slices?)\r\n\r\nThere is some discussion in issue #87 . There are other ideas here which I would like to explore if I have time.\r\n\r\nWith this PR I'll try to work towards an agreeable API for these changes.\r\n\r\nAlso resolved #85 with this PR."},"comment":{"url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/comments/265787704","html_url":"https://github.com/AtheMathmo/rulinalg/pull/99#issuecomment-265787704","issue_url":"https://api.github.com/repos/AtheMathmo/rulinalg/issues/99","id":265787704,"user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T16:39:49Z","updated_at":"2016-12-08T16:39:49Z","body":"I did a little digging into vectorization - for the most part it looks good to me. All of the operations break down into per-row operations. We may incur some cost for creating the row iterator unnecessarily (instead of the user iterating through the slice) but I don't think it will be significant.\r\n\r\nOtherwise I can't find any cases where treating the row as a matrix instead of a `&[T]` would break vectorization. It's likely I've missed something but given the gain in utility here I'm happy to tick that box too."}}
{"actor":{"display_login":"AtheMathmo"}}