{"action":"created","comment":{"url":"https://api.github.com/repos/nodules/luster/pulls/comments/85616838","pull_request_review_id":6325764,"id":85616838,"diff_hunk":"@@ -0,0 +1,171 @@\n+'use strict';\n+var Configurable = require('../../lib/configurable'),\n+    LusterConfigurationError = require('../../lib/errors').LusterConfigurationError,\n+    fixturesConf = require('../fixtures/luster.conf'),\n+    extend = require('extend');\n+\n+// suppress stderr from terror\n+LusterConfigurationError.setLogger(function() {});\n+\n+describe('Configurable', function() {\n+    var configurable,\n+        sandbox = sinon.sandbox.create();\n+\n+    afterEach(function() {\n+        sandbox.restore();\n+    });\n+\n+    describe('configure', function() {\n+        var config;\n+\n+        beforeEach(function() {\n+            configurable = new Configurable();\n+            config = extend({}, fixturesConf, true);\n+            configurable.addListener('error', function() {});\n+        });\n+\n+        afterEach(function() {\n+            configurable.removeAllListeners('error');\n+        });\n+\n+        it('should emit \"configured\" event on configuration success', function() {\n+            sandbox.spy(configurable, 'emit');","path":"test/lib/configurable.js","position":32,"original_position":32,"commit_id":"15f5ed134b98bdb4987c706118c170efb2d64f42","original_commit_id":"15f5ed134b98bdb4987c706118c170efb2d64f42","user":{"login":"narqo","id":88045,"avatar_url":"https://avatars.githubusercontent.com/u/88045?v=3","gravatar_id":"","url":"https://api.github.com/users/narqo","html_url":"https://github.com/narqo","followers_url":"https://api.github.com/users/narqo/followers","following_url":"https://api.github.com/users/narqo/following{/other_user}","gists_url":"https://api.github.com/users/narqo/gists{/gist_id}","starred_url":"https://api.github.com/users/narqo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narqo/subscriptions","organizations_url":"https://api.github.com/users/narqo/orgs","repos_url":"https://api.github.com/users/narqo/repos","events_url":"https://api.github.com/users/narqo/events{/privacy}","received_events_url":"https://api.github.com/users/narqo/received_events","type":"User","site_admin":false},"body":"Maybe we could check EventEmiter's behaviour here, not it's internals? E.g.\r\n\r\n```js\r\nvar spy = sinon.spy();\r\n\r\nconfigurable.on('configured', spy);\r\nconfigurable.configure(config);\r\n\r\nassert.calledOnce(spy);\r\n```","created_at":"2016-10-28T21:55:10Z","updated_at":"2016-10-28T22:01:36Z","html_url":"https://github.com/nodules/luster/pull/38#discussion_r85616838","pull_request_url":"https://api.github.com/repos/nodules/luster/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/nodules/luster/pulls/comments/85616838"},"html":{"href":"https://github.com/nodules/luster/pull/38#discussion_r85616838"},"pull_request":{"href":"https://api.github.com/repos/nodules/luster/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/nodules/luster/pulls/38","id":91385465,"html_url":"https://github.com/nodules/luster/pull/38","diff_url":"https://github.com/nodules/luster/pull/38.diff","patch_url":"https://github.com/nodules/luster/pull/38.patch","issue_url":"https://api.github.com/repos/nodules/luster/issues/38","number":38,"state":"open","locked":false,"title":"Configurable: nested property override via LUSTER_CONF is broken","user":{"login":"Flackus","id":644960,"avatar_url":"https://avatars.githubusercontent.com/u/644960?v=3","gravatar_id":"","url":"https://api.github.com/users/Flackus","html_url":"https://github.com/Flackus","followers_url":"https://api.github.com/users/Flackus/followers","following_url":"https://api.github.com/users/Flackus/following{/other_user}","gists_url":"https://api.github.com/users/Flackus/gists{/gist_id}","starred_url":"https://api.github.com/users/Flackus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flackus/subscriptions","organizations_url":"https://api.github.com/users/Flackus/orgs","repos_url":"https://api.github.com/users/Flackus/repos","events_url":"https://api.github.com/users/Flackus/events{/privacy}","received_events_url":"https://api.github.com/users/Flackus/received_events","type":"User","site_admin":false},"body":"//cc @narqo @kaero ","created_at":"2016-10-28T13:53:10Z","updated_at":"2016-10-28T22:01:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2a11b5d4ca32fa304db068c477633383f905069","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodules/luster/pulls/38/commits","review_comments_url":"https://api.github.com/repos/nodules/luster/pulls/38/comments","review_comment_url":"https://api.github.com/repos/nodules/luster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodules/luster/issues/38/comments","statuses_url":"https://api.github.com/repos/nodules/luster/statuses/15f5ed134b98bdb4987c706118c170efb2d64f42","head":{"label":"nodules:tests/configurable","ref":"tests/configurable","sha":"15f5ed134b98bdb4987c706118c170efb2d64f42","user":{"login":"nodules","id":4501174,"avatar_url":"https://avatars.githubusercontent.com/u/4501174?v=3","gravatar_id":"","url":"https://api.github.com/users/nodules","html_url":"https://github.com/nodules","followers_url":"https://api.github.com/users/nodules/followers","following_url":"https://api.github.com/users/nodules/following{/other_user}","gists_url":"https://api.github.com/users/nodules/gists{/gist_id}","starred_url":"https://api.github.com/users/nodules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodules/subscriptions","organizations_url":"https://api.github.com/users/nodules/orgs","repos_url":"https://api.github.com/users/nodules/repos","events_url":"https://api.github.com/users/nodules/events{/privacy}","received_events_url":"https://api.github.com/users/nodules/received_events","type":"Organization","site_admin":false},"repo":{"id":10702768,"name":"luster","full_name":"nodules/luster","owner":{"login":"nodules","id":4501174,"avatar_url":"https://avatars.githubusercontent.com/u/4501174?v=3","gravatar_id":"","url":"https://api.github.com/users/nodules","html_url":"https://github.com/nodules","followers_url":"https://api.github.com/users/nodules/followers","following_url":"https://api.github.com/users/nodules/following{/other_user}","gists_url":"https://api.github.com/users/nodules/gists{/gist_id}","starred_url":"https://api.github.com/users/nodules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodules/subscriptions","organizations_url":"https://api.github.com/users/nodules/orgs","repos_url":"https://api.github.com/users/nodules/repos","events_url":"https://api.github.com/users/nodules/events{/privacy}","received_events_url":"https://api.github.com/users/nodules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodules/luster","description":"The library to develop Master–Worker interactions","fork":false,"url":"https://api.github.com/repos/nodules/luster","forks_url":"https://api.github.com/repos/nodules/luster/forks","keys_url":"https://api.github.com/repos/nodules/luster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodules/luster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodules/luster/teams","hooks_url":"https://api.github.com/repos/nodules/luster/hooks","issue_events_url":"https://api.github.com/repos/nodules/luster/issues/events{/number}","events_url":"https://api.github.com/repos/nodules/luster/events","assignees_url":"https://api.github.com/repos/nodules/luster/assignees{/user}","branches_url":"https://api.github.com/repos/nodules/luster/branches{/branch}","tags_url":"https://api.github.com/repos/nodules/luster/tags","blobs_url":"https://api.github.com/repos/nodules/luster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodules/luster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodules/luster/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodules/luster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodules/luster/statuses/{sha}","languages_url":"https://api.github.com/repos/nodules/luster/languages","stargazers_url":"https://api.github.com/repos/nodules/luster/stargazers","contributors_url":"https://api.github.com/repos/nodules/luster/contributors","subscribers_url":"https://api.github.com/repos/nodules/luster/subscribers","subscription_url":"https://api.github.com/repos/nodules/luster/subscription","commits_url":"https://api.github.com/repos/nodules/luster/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodules/luster/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodules/luster/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodules/luster/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodules/luster/contents/{+path}","compare_url":"https://api.github.com/repos/nodules/luster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodules/luster/merges","archive_url":"https://api.github.com/repos/nodules/luster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodules/luster/downloads","issues_url":"https://api.github.com/repos/nodules/luster/issues{/number}","pulls_url":"https://api.github.com/repos/nodules/luster/pulls{/number}","milestones_url":"https://api.github.com/repos/nodules/luster/milestones{/number}","notifications_url":"https://api.github.com/repos/nodules/luster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodules/luster/labels{/name}","releases_url":"https://api.github.com/repos/nodules/luster/releases{/id}","deployments_url":"https://api.github.com/repos/nodules/luster/deployments","created_at":"2013-06-15T06:02:52Z","updated_at":"2016-07-01T13:35:48Z","pushed_at":"2016-10-28T19:12:15Z","git_url":"git://github.com/nodules/luster.git","ssh_url":"git@github.com:nodules/luster.git","clone_url":"https://github.com/nodules/luster.git","svn_url":"https://github.com/nodules/luster","homepage":"https://github.com/nodules/luster/wiki/Intro","size":103,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":39,"default_branch":"master"}},"base":{"label":"nodules:master","ref":"master","sha":"49cbaaff44a356374b287f8e0539e1046c71ca3c","user":{"login":"nodules","id":4501174,"avatar_url":"https://avatars.githubusercontent.com/u/4501174?v=3","gravatar_id":"","url":"https://api.github.com/users/nodules","html_url":"https://github.com/nodules","followers_url":"https://api.github.com/users/nodules/followers","following_url":"https://api.github.com/users/nodules/following{/other_user}","gists_url":"https://api.github.com/users/nodules/gists{/gist_id}","starred_url":"https://api.github.com/users/nodules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodules/subscriptions","organizations_url":"https://api.github.com/users/nodules/orgs","repos_url":"https://api.github.com/users/nodules/repos","events_url":"https://api.github.com/users/nodules/events{/privacy}","received_events_url":"https://api.github.com/users/nodules/received_events","type":"Organization","site_admin":false},"repo":{"id":10702768,"name":"luster","full_name":"nodules/luster","owner":{"login":"nodules","id":4501174,"avatar_url":"https://avatars.githubusercontent.com/u/4501174?v=3","gravatar_id":"","url":"https://api.github.com/users/nodules","html_url":"https://github.com/nodules","followers_url":"https://api.github.com/users/nodules/followers","following_url":"https://api.github.com/users/nodules/following{/other_user}","gists_url":"https://api.github.com/users/nodules/gists{/gist_id}","starred_url":"https://api.github.com/users/nodules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodules/subscriptions","organizations_url":"https://api.github.com/users/nodules/orgs","repos_url":"https://api.github.com/users/nodules/repos","events_url":"https://api.github.com/users/nodules/events{/privacy}","received_events_url":"https://api.github.com/users/nodules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodules/luster","description":"The library to develop Master–Worker interactions","fork":false,"url":"https://api.github.com/repos/nodules/luster","forks_url":"https://api.github.com/repos/nodules/luster/forks","keys_url":"https://api.github.com/repos/nodules/luster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodules/luster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodules/luster/teams","hooks_url":"https://api.github.com/repos/nodules/luster/hooks","issue_events_url":"https://api.github.com/repos/nodules/luster/issues/events{/number}","events_url":"https://api.github.com/repos/nodules/luster/events","assignees_url":"https://api.github.com/repos/nodules/luster/assignees{/user}","branches_url":"https://api.github.com/repos/nodules/luster/branches{/branch}","tags_url":"https://api.github.com/repos/nodules/luster/tags","blobs_url":"https://api.github.com/repos/nodules/luster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodules/luster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodules/luster/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodules/luster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodules/luster/statuses/{sha}","languages_url":"https://api.github.com/repos/nodules/luster/languages","stargazers_url":"https://api.github.com/repos/nodules/luster/stargazers","contributors_url":"https://api.github.com/repos/nodules/luster/contributors","subscribers_url":"https://api.github.com/repos/nodules/luster/subscribers","subscription_url":"https://api.github.com/repos/nodules/luster/subscription","commits_url":"https://api.github.com/repos/nodules/luster/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodules/luster/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodules/luster/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodules/luster/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodules/luster/contents/{+path}","compare_url":"https://api.github.com/repos/nodules/luster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodules/luster/merges","archive_url":"https://api.github.com/repos/nodules/luster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodules/luster/downloads","issues_url":"https://api.github.com/repos/nodules/luster/issues{/number}","pulls_url":"https://api.github.com/repos/nodules/luster/pulls{/number}","milestones_url":"https://api.github.com/repos/nodules/luster/milestones{/number}","notifications_url":"https://api.github.com/repos/nodules/luster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodules/luster/labels{/name}","releases_url":"https://api.github.com/repos/nodules/luster/releases{/id}","deployments_url":"https://api.github.com/repos/nodules/luster/deployments","created_at":"2013-06-15T06:02:52Z","updated_at":"2016-07-01T13:35:48Z","pushed_at":"2016-10-28T19:12:15Z","git_url":"git://github.com/nodules/luster.git","ssh_url":"git@github.com:nodules/luster.git","clone_url":"https://github.com/nodules/luster.git","svn_url":"https://github.com/nodules/luster","homepage":"https://github.com/nodules/luster/wiki/Intro","size":103,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodules/luster/pulls/38"},"html":{"href":"https://github.com/nodules/luster/pull/38"},"issue":{"href":"https://api.github.com/repos/nodules/luster/issues/38"},"comments":{"href":"https://api.github.com/repos/nodules/luster/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/nodules/luster/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/nodules/luster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodules/luster/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/nodules/luster/statuses/15f5ed134b98bdb4987c706118c170efb2d64f42"}}}}
{"actor":{"display_login":"narqo"}}