{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38750","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38750/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38750/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38750/events","html_url":"https://github.com/kubernetes/kubernetes/pull/38750","id":195476074,"number":38750,"title":"[Federation] Stop cleaning federation namespace in e2e tests","user":{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars.githubusercontent.com/u/8734900?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"assignees":[{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-14T09:07:49Z","updated_at":"2016-12-14T19:09:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/38750","html_url":"https://github.com/kubernetes/kubernetes/pull/38750","diff_url":"https://github.com/kubernetes/kubernetes/pull/38750.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/38750.patch"},"body":"when --clean-start=true flag is provided to e2e tests it would cleanup all the leftover namespaces except `default` and `kube-system` and because of this when we run e2e tests in federation soak test job, the federation control plane is destroyed before it runs the tests and all tests start to fail.\r\n\r\nSo adding federation-system to the list of namespace to be left intact and also changed the default federation namespace name from `federation` to `federation-system` to be consistent with the newer method of deploying federation using kubefed.\r\n\r\n@madhusudancs  @nikhiljindal "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/267126090","html_url":"https://github.com/kubernetes/kubernetes/pull/38750#issuecomment-267126090","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/38750","id":267126090,"user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T19:09:09Z","updated_at":"2016-12-14T19:09:09Z","body":"Oh wow! Nice sleuthing @shashidharatd! LGTM from me. I think we should define this as a constant in the same vein as api.NamespaceSystem. But I suggest defining it in `federation/apis/federation/v1beta1/types.go`."}}
{"actor":{"display_login":"madhusudancs"}}