{"action":"created","comment":{"url":"https://api.github.com/repos/holidayextras/make-up/pulls/comments/64244398","id":64244398,"diff_hunk":"@@ -8,13 +8,14 @@ var argv = require('minimist')(process.argv.slice(2));\n \n var options = {\n   dirs: argv._,\n+  integrations: argv.i,\n   since: argv.s,\n   gitBranch: argv.b\n };\n MakeUp.check(options, function(err, result) {\n-  console.log(result);\n   if (err) {\n     console.log('ERROR: ' + err.message);\n     process.exit(1); // eslint-disable-line no-process-exit\n   }\n+  console.log(result);","path":"bin/make-up.js","position":null,"original_position":14,"commit_id":"711817336ab7f69ed0cbc1888d25c70b07fa1115","original_commit_id":"1d9f3540dec38b722910f2507f3c2ba3d8f020c4","user":{"login":"pmcnr-hx","id":10811943,"avatar_url":"https://avatars.githubusercontent.com/u/10811943?v=3","gravatar_id":"","url":"https://api.github.com/users/pmcnr-hx","html_url":"https://github.com/pmcnr-hx","followers_url":"https://api.github.com/users/pmcnr-hx/followers","following_url":"https://api.github.com/users/pmcnr-hx/following{/other_user}","gists_url":"https://api.github.com/users/pmcnr-hx/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcnr-hx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcnr-hx/subscriptions","organizations_url":"https://api.github.com/users/pmcnr-hx/orgs","repos_url":"https://api.github.com/users/pmcnr-hx/repos","events_url":"https://api.github.com/users/pmcnr-hx/events{/privacy}","received_events_url":"https://api.github.com/users/pmcnr-hx/received_events","type":"User","site_admin":false},"body":"Agreed. I'll check if it exists, before printing though. I moved it because it was printing an unsightly `undefined` in case of error.","created_at":"2016-05-23T15:59:12Z","updated_at":"2016-05-23T15:59:12Z","html_url":"https://github.com/holidayextras/make-up/pull/47#discussion_r64244398","pull_request_url":"https://api.github.com/repos/holidayextras/make-up/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/comments/64244398"},"html":{"href":"https://github.com/holidayextras/make-up/pull/47#discussion_r64244398"},"pull_request":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/holidayextras/make-up/pulls/47","id":70277673,"html_url":"https://github.com/holidayextras/make-up/pull/47","diff_url":"https://github.com/holidayextras/make-up/pull/47.diff","patch_url":"https://github.com/holidayextras/make-up/pull/47.patch","issue_url":"https://api.github.com/repos/holidayextras/make-up/issues/47","number":47,"state":"open","locked":false,"title":"Selective integrations","user":{"login":"pmcnr-hx","id":10811943,"avatar_url":"https://avatars.githubusercontent.com/u/10811943?v=3","gravatar_id":"","url":"https://api.github.com/users/pmcnr-hx","html_url":"https://github.com/pmcnr-hx","followers_url":"https://api.github.com/users/pmcnr-hx/followers","following_url":"https://api.github.com/users/pmcnr-hx/following{/other_user}","gists_url":"https://api.github.com/users/pmcnr-hx/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcnr-hx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcnr-hx/subscriptions","organizations_url":"https://api.github.com/users/pmcnr-hx/orgs","repos_url":"https://api.github.com/users/pmcnr-hx/repos","events_url":"https://api.github.com/users/pmcnr-hx/events{/privacy}","received_events_url":"https://api.github.com/users/pmcnr-hx/received_events","type":"User","site_admin":false},"body":"#### What does this PR do? (please provide any background)\r\nNew `-i` command line switch that enables selecting which integrations should be run with ESLint enabled by default if no integrations are specified explicitly.\r\n\r\n#### What tests does this PR have?\r\nImproved unit test coverage.\r\n\r\n#### How can this be tested?\r\nVerify that:\r\n* `bin/make-up.js lib bin script test`: runs both ESLint and Snyk\r\n* `bin/make-up.js -i eslint lib bin script test`: only runs ESLint\r\n* `bin/make-up.js -i snyk lib bin script test`: only runs Snyk\r\n* `bin/make-up.js -i eslint,snyk lib bin script test`: runs both ESLint and Snyk\r\n\r\n#### Screenshots / Screencast\r\nN/A\r\n\r\n#### What gif best describes how you feel about this work?\r\n![Zoidberg Slinky](http://big.assets.huffingtonpost.com/zoidbergslinky.gif)\r\n\r\n---\r\n\r\n- [x] I have checked our general [contributing document](https://github.com/holidayextras/culture/blob/master/CONTRIBUTING.md) and the project specific [contributing document](../blob/master/CONTRIBUTING.md) (if present) and I'm happy for this to be reviewed.\r\n\r\n#### Reviewers\r\n\r\n**Review 1**\r\n- [ ] :+1:\r\n\r\n**Review 2**\r\n- [x] :+1:\r\n\r\n**Review 3**\r\n- [x] :+1:\r\n\r\nBy adding a +1 you are confirming you have...\r\n- Witnessed the work behaving as expected (this could be on the author's machine or screencast).\r\n- Checked for coding anti-patterns.\r\n- Checked for appropriate test coverage.\r\n- Checked all the tests are passing.\r\n","created_at":"2016-05-16T23:21:35Z","updated_at":"2016-05-23T15:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d95e91a7a00e6cfea9983f55eac5f77f77db85e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/make-up/pulls/47/commits","review_comments_url":"https://api.github.com/repos/holidayextras/make-up/pulls/47/comments","review_comment_url":"https://api.github.com/repos/holidayextras/make-up/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/make-up/issues/47/comments","statuses_url":"https://api.github.com/repos/holidayextras/make-up/statuses/711817336ab7f69ed0cbc1888d25c70b07fa1115","head":{"label":"holidayextras:selective-integrations","ref":"selective-integrations","sha":"711817336ab7f69ed0cbc1888d25c70b07fa1115","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":30864754,"name":"make-up","full_name":"holidayextras/make-up","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/make-up","description":"All of the checks for all of the linters.","fork":false,"url":"https://api.github.com/repos/holidayextras/make-up","forks_url":"https://api.github.com/repos/holidayextras/make-up/forks","keys_url":"https://api.github.com/repos/holidayextras/make-up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/make-up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/make-up/teams","hooks_url":"https://api.github.com/repos/holidayextras/make-up/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/make-up/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/make-up/events","assignees_url":"https://api.github.com/repos/holidayextras/make-up/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/make-up/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/make-up/tags","blobs_url":"https://api.github.com/repos/holidayextras/make-up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/make-up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/make-up/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/make-up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/make-up/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/make-up/languages","stargazers_url":"https://api.github.com/repos/holidayextras/make-up/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/make-up/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/make-up/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/make-up/subscription","commits_url":"https://api.github.com/repos/holidayextras/make-up/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/make-up/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/make-up/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/make-up/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/make-up/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/make-up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/make-up/merges","archive_url":"https://api.github.com/repos/holidayextras/make-up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/make-up/downloads","issues_url":"https://api.github.com/repos/holidayextras/make-up/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/make-up/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/make-up/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/make-up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/make-up/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/make-up/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/make-up/deployments","created_at":"2015-02-16T11:09:03Z","updated_at":"2016-03-15T17:18:20Z","pushed_at":"2016-05-23T09:58:55Z","git_url":"git://github.com/holidayextras/make-up.git","ssh_url":"git@github.com:holidayextras/make-up.git","clone_url":"https://github.com/holidayextras/make-up.git","svn_url":"https://github.com/holidayextras/make-up","homepage":"","size":2359,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"61278716f5142d0cba1fe0b51fc950a58718ac1b","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":30864754,"name":"make-up","full_name":"holidayextras/make-up","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/make-up","description":"All of the checks for all of the linters.","fork":false,"url":"https://api.github.com/repos/holidayextras/make-up","forks_url":"https://api.github.com/repos/holidayextras/make-up/forks","keys_url":"https://api.github.com/repos/holidayextras/make-up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/make-up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/make-up/teams","hooks_url":"https://api.github.com/repos/holidayextras/make-up/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/make-up/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/make-up/events","assignees_url":"https://api.github.com/repos/holidayextras/make-up/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/make-up/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/make-up/tags","blobs_url":"https://api.github.com/repos/holidayextras/make-up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/make-up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/make-up/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/make-up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/make-up/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/make-up/languages","stargazers_url":"https://api.github.com/repos/holidayextras/make-up/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/make-up/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/make-up/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/make-up/subscription","commits_url":"https://api.github.com/repos/holidayextras/make-up/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/make-up/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/make-up/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/make-up/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/make-up/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/make-up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/make-up/merges","archive_url":"https://api.github.com/repos/holidayextras/make-up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/make-up/downloads","issues_url":"https://api.github.com/repos/holidayextras/make-up/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/make-up/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/make-up/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/make-up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/make-up/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/make-up/releases{/id}","deployments_url":"https://api.github.com/repos/holidayextras/make-up/deployments","created_at":"2015-02-16T11:09:03Z","updated_at":"2016-03-15T17:18:20Z","pushed_at":"2016-05-23T09:58:55Z","git_url":"git://github.com/holidayextras/make-up.git","ssh_url":"git@github.com:holidayextras/make-up.git","clone_url":"https://github.com/holidayextras/make-up.git","svn_url":"https://github.com/holidayextras/make-up","homepage":"","size":2359,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/47"},"html":{"href":"https://github.com/holidayextras/make-up/pull/47"},"issue":{"href":"https://api.github.com/repos/holidayextras/make-up/issues/47"},"comments":{"href":"https://api.github.com/repos/holidayextras/make-up/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/make-up/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/make-up/statuses/711817336ab7f69ed0cbc1888d25c70b07fa1115"}}}}
{"actor":{"display_login":"pmcnr-hx"}}