{"action":"created","issue":{"url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/6","repository_url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn","labels_url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/6/comments","events_url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/6/events","html_url":"https://github.com/PythagorStudios/pythagorsaturn/pull/6","id":169360061,"number":6,"title":"Key logging changes","user":{"login":"gamester543","id":20526314,"avatar_url":"https://avatars.githubusercontent.com/u/20526314?v=3","gravatar_id":"","url":"https://api.github.com/users/gamester543","html_url":"https://github.com/gamester543","followers_url":"https://api.github.com/users/gamester543/followers","following_url":"https://api.github.com/users/gamester543/following{/other_user}","gists_url":"https://api.github.com/users/gamester543/gists{/gist_id}","starred_url":"https://api.github.com/users/gamester543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamester543/subscriptions","organizations_url":"https://api.github.com/users/gamester543/orgs","repos_url":"https://api.github.com/users/gamester543/repos","events_url":"https://api.github.com/users/gamester543/events{/privacy}","received_events_url":"https://api.github.com/users/gamester543/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-04T12:14:39Z","updated_at":"2016-08-05T04:22:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/pulls/6","html_url":"https://github.com/PythagorStudios/pythagorsaturn/pull/6","diff_url":"https://github.com/PythagorStudios/pythagorsaturn/pull/6.diff","patch_url":"https://github.com/PythagorStudios/pythagorsaturn/pull/6.patch"},"body":"Changed storage of keys to boolean values\r\nSimplified getKeysPressed"},"comment":{"url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/comments/237751887","html_url":"https://github.com/PythagorStudios/pythagorsaturn/pull/6#issuecomment-237751887","issue_url":"https://api.github.com/repos/PythagorStudios/pythagorsaturn/issues/6","id":237751887,"user":{"login":"finnbear","id":20015102,"avatar_url":"https://avatars.githubusercontent.com/u/20015102?v=3","gravatar_id":"","url":"https://api.github.com/users/finnbear","html_url":"https://github.com/finnbear","followers_url":"https://api.github.com/users/finnbear/followers","following_url":"https://api.github.com/users/finnbear/following{/other_user}","gists_url":"https://api.github.com/users/finnbear/gists{/gist_id}","starred_url":"https://api.github.com/users/finnbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnbear/subscriptions","organizations_url":"https://api.github.com/users/finnbear/orgs","repos_url":"https://api.github.com/users/finnbear/repos","events_url":"https://api.github.com/users/finnbear/events{/privacy}","received_events_url":"https://api.github.com/users/finnbear/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T04:22:58Z","updated_at":"2016-08-05T04:22:58Z","body":"Your right, there is a problem, but I think the solution would be to make the index 0-Infinity and the data stored be the keycode, not the other way around.\r\n\r\n_In other words..._\r\n**In-efficient & Bad:** `keys[e.keyCode] = e.keyCode;`\r\n**Efficient & Bad** `keys[e.keyCode] = true`\r\n**Efficient & Good** `keys[i] = e.keyCode`\r\nThat way, when you want to iterate through the list, you dont have to check if the item at the index is `null`, `NaN`, or invalid.\r\n\r\nYour way does work, and if you would like, I will implement it.\r\n"}}
{"actor":{"display_login":"finnbear"}}