{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/32335","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/32335/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/32335/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/32335/events","html_url":"https://github.com/saltstack/salt/pull/32335","id":145773304,"number":32335,"title":"Change order of precedence in opts when executing minion_runner","user":{"login":"carlpett","id":214867,"avatar_url":"https://avatars.githubusercontent.com/u/214867?v=3","gravatar_id":"","url":"https://api.github.com/users/carlpett","html_url":"https://github.com/carlpett","followers_url":"https://api.github.com/users/carlpett/followers","following_url":"https://api.github.com/users/carlpett/following{/other_user}","gists_url":"https://api.github.com/users/carlpett/gists{/gist_id}","starred_url":"https://api.github.com/users/carlpett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlpett/subscriptions","organizations_url":"https://api.github.com/users/carlpett/orgs","repos_url":"https://api.github.com/users/carlpett/repos","events_url":"https://api.github.com/users/carlpett/events{/privacy}","received_events_url":"https://api.github.com/users/carlpett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-04T18:56:05Z","updated_at":"2016-04-04T20:48:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/32335","html_url":"https://github.com/saltstack/salt/pull/32335","diff_url":"https://github.com/saltstack/salt/pull/32335.diff","patch_url":"https://github.com/saltstack/salt/pull/32335.patch"},"body":"### What does this PR do?\r\nWhen executing a runner in `publish.runner`, it is not possible to know what minion initiated the run, due to `id` being overridden with the master's `opts`. This PR changes the construction order so that `publish.runner` opts have precedence over the master `opts`.\r\n\r\n### What issues does this PR fix or reference?\r\n#20337\r\n\r\n### Previous Behavior\r\n`__opts__['id'] = 'master-id'`\r\n\r\n### New Behavior\r\n`__opts__['id'] = 'initiating-minion-id'`\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Caveats\r\nI'm _fairly_ sure that nothing within salt depends on this currently, and that the new behavior is actually what is intended to happen, but it is not clear that it is so. Would be great if someone with more historical insight could have a look!"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/205489500","html_url":"https://github.com/saltstack/salt/pull/32335#issuecomment-205489500","issue_url":"https://api.github.com/repos/saltstack/salt/issues/32335","id":205489500,"user":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T20:48:01Z","updated_at":"2016-04-04T20:48:01Z","body":"Yes, you are correct, thanks for the catch!"}}