{"action":"created","issue":{"url":"https://api.github.com/repos/drublic/css-modal/issues/200","repository_url":"https://api.github.com/repos/drublic/css-modal","labels_url":"https://api.github.com/repos/drublic/css-modal/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/drublic/css-modal/issues/200/comments","events_url":"https://api.github.com/repos/drublic/css-modal/issues/200/events","html_url":"https://github.com/drublic/css-modal/pull/200","id":116126549,"number":200,"title":"Make sure iframes don't interfere with modal events [fixes #199]","user":{"login":"adriaanbaelus","id":139090,"avatar_url":"https://avatars.githubusercontent.com/u/139090?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanbaelus","html_url":"https://github.com/adriaanbaelus","followers_url":"https://api.github.com/users/adriaanbaelus/followers","following_url":"https://api.github.com/users/adriaanbaelus/following{/other_user}","gists_url":"https://api.github.com/users/adriaanbaelus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanbaelus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanbaelus/subscriptions","organizations_url":"https://api.github.com/users/adriaanbaelus/orgs","repos_url":"https://api.github.com/users/adriaanbaelus/repos","events_url":"https://api.github.com/users/adriaanbaelus/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanbaelus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T15:15:25Z","updated_at":"2016-04-18T19:01:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/drublic/css-modal/pulls/200","html_url":"https://github.com/drublic/css-modal/pull/200","diff_url":"https://github.com/drublic/css-modal/pull/200.diff","patch_url":"https://github.com/drublic/css-modal/pull/200.patch"},"body":"If a window contains at least one (i)frame, it will behave array-like, see https://developer.mozilla.org/en-US/docs/Web/API/Window/length\r\nDue to this, event listeners were added to the frame windows instead of the root window.\r\n\r\nAlso noticed your tests have some issues (you're using setTimeout, but not waiting for the result). I modified the relevant test for this issue. If you remove the change in `modal.js`, the `has class is-active when hash is set` test will now (correctly) fail.\r\n\r\nI also set one test to ignored, since it fails on the current master (unrelated to the issue at hand)."},"comment":{"url":"https://api.github.com/repos/drublic/css-modal/issues/comments/211530214","html_url":"https://github.com/drublic/css-modal/pull/200#issuecomment-211530214","issue_url":"https://api.github.com/repos/drublic/css-modal/issues/200","id":211530214,"user":{"login":"drublic","id":502487,"avatar_url":"https://avatars.githubusercontent.com/u/502487?v=3","gravatar_id":"","url":"https://api.github.com/users/drublic","html_url":"https://github.com/drublic","followers_url":"https://api.github.com/users/drublic/followers","following_url":"https://api.github.com/users/drublic/following{/other_user}","gists_url":"https://api.github.com/users/drublic/gists{/gist_id}","starred_url":"https://api.github.com/users/drublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drublic/subscriptions","organizations_url":"https://api.github.com/users/drublic/orgs","repos_url":"https://api.github.com/users/drublic/repos","events_url":"https://api.github.com/users/drublic/events{/privacy}","received_events_url":"https://api.github.com/users/drublic/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T19:01:00Z","updated_at":"2016-04-18T19:01:00Z","body":"Very nice. Thank you!"}}