{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63757435","id":63757435,"diff_hunk":"@@ -0,0 +1,80 @@\n+#!/bin/bash\n+\n+# Copyright 2016 The Kubernetes Authors All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+# This script is for master and node instance health monitoring, which is\n+# packed in kube-manifest tarball. It is executed through a systemd service\n+# in cluster/gce/gci/<master/node>.yaml. The env variables come from an env\n+# file provided by the systemd service.\n+\n+set -o errexit\n+set -o nounset\n+set -o pipefail\n+\n+# We simply kill the process when there is a failure. Another systemd service will\n+# automatically restart the process.\n+function docker_monitoring {\n+  while [ 1 ]; do\n+    if ! timeout 10 docker version > /dev/null; then","path":"cluster/gce/gci/health-monitor.sh","position":30,"original_position":30,"commit_id":"ea3aad2cc2150a0670991673023c7b1b83d0f7fa","original_commit_id":"ea3aad2cc2150a0670991673023c7b1b83d0f7fa","user":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"body":"https://github.com/kubernetes/kubernetes/blob/master/cluster/saltbase/salt/supervisor/docker-checker.sh has switched to using `docker ps` instead of `docker version`. We should make this consistent. \r\n\r\n/cc @dchen1107 ","created_at":"2016-05-18T18:33:54Z","updated_at":"2016-05-18T18:33:54Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25425#discussion_r63757435","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63757435"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25425#discussion_r63757435"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425","id":69577767,"html_url":"https://github.com/kubernetes/kubernetes/pull/25425","diff_url":"https://github.com/kubernetes/kubernetes/pull/25425.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25425.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25425","number":25425,"state":"open","locked":false,"title":"Add support for running GCI on the GCE cloud provider","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"body":"The supports and configs for GCI added here will be used in 1.3 release and upwards. For 1.2.X releases, we will still use cluster/gce/trusty code. Therefore, we will keep maintaining the trusty code as long as 1.2-release branch is not deprecated. Unlike the trusty code, the GCI cluster initialization is through systemd.\r\n\r\nThis PR is fully tested using e2e tests. I wrote a script to repeatedly spin up a cluster, run CI and slow tests, and then tear down for 15 times for both pure GCI cluster and hybrid cluster (master on GCI, nodes on containervm). The entire tests lasted for more than 3 days, and no failure was shown. I also verified creating trusty cluster, as this PR revises some places affecting it.\r\n\r\n@roberthbailey @dchen1107 please review it.\r\n\r\ncc/ @fabioy @wonderfly @kubernetes/goog-image FYI.","created_at":"2016-05-10T21:06:09Z","updated_at":"2016-05-18T18:33:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0edbd02495bb4114e34d34d88940b9f7a8bec214","assignee":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25425/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ea3aad2cc2150a0670991673023c7b1b83d0f7fa","head":{"label":"andyzheng0831:real-gci","ref":"real-gci","sha":"ea3aad2cc2150a0670991673023c7b1b83d0f7fa","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"repo":{"id":44209465,"name":"kubernetes","full_name":"andyzheng0831/kubernetes","owner":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyzheng0831/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/andyzheng0831/kubernetes","forks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/forks","keys_url":"https://api.github.com/repos/andyzheng0831/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyzheng0831/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyzheng0831/kubernetes/teams","hooks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/events","assignees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/andyzheng0831/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/tags","blobs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyzheng0831/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/andyzheng0831/kubernetes/languages","stargazers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscription","commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyzheng0831/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/andyzheng0831/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyzheng0831/kubernetes/merges","archive_url":"https://api.github.com/repos/andyzheng0831/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyzheng0831/kubernetes/downloads","issues_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/andyzheng0831/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/andyzheng0831/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/andyzheng0831/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyzheng0831/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/andyzheng0831/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/andyzheng0831/kubernetes/deployments","created_at":"2015-10-13T22:35:08Z","updated_at":"2016-01-30T17:40:02Z","pushed_at":"2016-05-18T17:36:09Z","git_url":"git://github.com/andyzheng0831/kubernetes.git","ssh_url":"git@github.com:andyzheng0831/kubernetes.git","clone_url":"https://github.com/andyzheng0831/kubernetes.git","svn_url":"https://github.com/andyzheng0831/kubernetes","homepage":"http://kubernetes.io","size":223137,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3a5d53d4679df921a6f79d20b69f4982953493f5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-18T18:20:49Z","pushed_at":"2016-05-18T18:23:35Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":451273,"stargazers_count":14436,"watchers_count":14436,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4368,"mirror_url":null,"open_issues_count":3560,"forks":4368,"open_issues":3560,"watchers":14436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25425"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25425"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25425/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25425/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ea3aad2cc2150a0670991673023c7b1b83d0f7fa"}}}}