{"action":"created","comment":{"url":"https://api.github.com/repos/01org/ciao/pulls/comments/65888249","id":65888249,"diff_hunk":"@@ -291,3 +292,14 @@ func (f Frame) DumpTrace() (*payloads.FrameTrace, error) {\n \n \treturn &s, nil\n }\n+\n+// OriginUUID is the frame first sender and creator UUID.\n+// When a SSNTP frame is forwarded by a server, the client\n+// then only sees a new frame coming but it can not tell\n+// who the frame creator and first sender is. This method\n+// allows to fetch such information from a frame.\n+func (f Frame) OriginUUID() (origin uuid.UUID) {\n+\tcopy(origin[:], f.Origin[:16])","path":"ssntp/frame.go","position":36,"original_position":36,"commit_id":"bf25bc9f07eec629b5580b3eec37f24efb884fab","original_commit_id":"edfd0ea3028363e1126935388a6c3f96c7b32d09","user":{"login":"markdryan","id":984073,"avatar_url":"https://avatars.githubusercontent.com/u/984073?v=3","gravatar_id":"","url":"https://api.github.com/users/markdryan","html_url":"https://github.com/markdryan","followers_url":"https://api.github.com/users/markdryan/followers","following_url":"https://api.github.com/users/markdryan/following{/other_user}","gists_url":"https://api.github.com/users/markdryan/gists{/gist_id}","starred_url":"https://api.github.com/users/markdryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdryan/subscriptions","organizations_url":"https://api.github.com/users/markdryan/orgs","repos_url":"https://api.github.com/users/markdryan/repos","events_url":"https://api.github.com/users/markdryan/events{/privacy}","received_events_url":"https://api.github.com/users/markdryan/received_events","type":"User","site_admin":false},"body":"I'm trying to figure out whether the [:16] slice is safe here.  As far as I can tell we're slicing a slice here and not an array, so there's no compile time guarantee that the slice will work.  But what I don't know is whether it's actually possible to for a SSNTP client to craft a frame with an Origin UUID of  less than 16 bytes?","created_at":"2016-06-06T13:23:32Z","updated_at":"2016-06-06T13:23:32Z","html_url":"https://github.com/01org/ciao/pull/205#discussion_r65888249","pull_request_url":"https://api.github.com/repos/01org/ciao/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments/65888249"},"html":{"href":"https://github.com/01org/ciao/pull/205#discussion_r65888249"},"pull_request":{"href":"https://api.github.com/repos/01org/ciao/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/01org/ciao/pulls/205","id":72694908,"html_url":"https://github.com/01org/ciao/pull/205","diff_url":"https://github.com/01org/ciao/pull/205.diff","patch_url":"https://github.com/01org/ciao/pull/205.patch","issue_url":"https://api.github.com/repos/01org/ciao/issues/205","number":205,"state":"open","locked":false,"title":"ssntp: Add SSNTP Frame Origin field","user":{"login":"sameo","id":1043863,"avatar_url":"https://avatars.githubusercontent.com/u/1043863?v=3","gravatar_id":"","url":"https://api.github.com/users/sameo","html_url":"https://github.com/sameo","followers_url":"https://api.github.com/users/sameo/followers","following_url":"https://api.github.com/users/sameo/following{/other_user}","gists_url":"https://api.github.com/users/sameo/gists{/gist_id}","starred_url":"https://api.github.com/users/sameo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameo/subscriptions","organizations_url":"https://api.github.com/users/sameo/orgs","repos_url":"https://api.github.com/users/sameo/repos","events_url":"https://api.github.com/users/sameo/events{/privacy}","received_events_url":"https://api.github.com/users/sameo/received_events","type":"User","site_admin":false},"body":"Origin tracks the first creator and sender of an SSNTP frame.\r\nThis allows for any frame receiver to track who the first sender is, even across SSNTP forwarding.\r\n\r\nNo significant throughput regressions were identified with this new field added to the SSNTP frames.","created_at":"2016-06-06T11:34:08Z","updated_at":"2016-06-06T13:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03084c6224531c235c3f25ebb919b771e0fcad20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/ciao/pulls/205/commits","review_comments_url":"https://api.github.com/repos/01org/ciao/pulls/205/comments","review_comment_url":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/ciao/issues/205/comments","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/bf25bc9f07eec629b5580b3eec37f24efb884fab","head":{"label":"01org:sameo/issues/19","ref":"sameo/issues/19","sha":"bf25bc9f07eec629b5580b3eec37f24efb884fab","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"01org/ciao","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/01org/ciao","forks_url":"https://api.github.com/repos/01org/ciao/forks","keys_url":"https://api.github.com/repos/01org/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/ciao/teams","hooks_url":"https://api.github.com/repos/01org/ciao/hooks","issue_events_url":"https://api.github.com/repos/01org/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/01org/ciao/events","assignees_url":"https://api.github.com/repos/01org/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/01org/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/01org/ciao/tags","blobs_url":"https://api.github.com/repos/01org/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/ciao/languages","stargazers_url":"https://api.github.com/repos/01org/ciao/stargazers","contributors_url":"https://api.github.com/repos/01org/ciao/contributors","subscribers_url":"https://api.github.com/repos/01org/ciao/subscribers","subscription_url":"https://api.github.com/repos/01org/ciao/subscription","commits_url":"https://api.github.com/repos/01org/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/01org/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/ciao/merges","archive_url":"https://api.github.com/repos/01org/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/ciao/downloads","issues_url":"https://api.github.com/repos/01org/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/01org/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/ciao/labels{/name}","releases_url":"https://api.github.com/repos/01org/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/01org/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2016-05-25T19:18:55Z","pushed_at":"2016-06-06T11:34:08Z","git_url":"git://github.com/01org/ciao.git","ssh_url":"git@github.com:01org/ciao.git","clone_url":"https://github.com/01org/ciao.git","svn_url":"https://github.com/01org/ciao","homepage":"","size":3458,"stargazers_count":31,"watchers_count":31,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":82,"forks":17,"open_issues":82,"watchers":31,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"5cce820d65ab68c6d4d4145f8f8d66df3debfd00","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":54660486,"name":"ciao","full_name":"01org/ciao","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/ciao","description":"Ciao - Cloud Integrated Advanced Orchestrator","fork":false,"url":"https://api.github.com/repos/01org/ciao","forks_url":"https://api.github.com/repos/01org/ciao/forks","keys_url":"https://api.github.com/repos/01org/ciao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/ciao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/ciao/teams","hooks_url":"https://api.github.com/repos/01org/ciao/hooks","issue_events_url":"https://api.github.com/repos/01org/ciao/issues/events{/number}","events_url":"https://api.github.com/repos/01org/ciao/events","assignees_url":"https://api.github.com/repos/01org/ciao/assignees{/user}","branches_url":"https://api.github.com/repos/01org/ciao/branches{/branch}","tags_url":"https://api.github.com/repos/01org/ciao/tags","blobs_url":"https://api.github.com/repos/01org/ciao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/ciao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/ciao/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/ciao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/ciao/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/ciao/languages","stargazers_url":"https://api.github.com/repos/01org/ciao/stargazers","contributors_url":"https://api.github.com/repos/01org/ciao/contributors","subscribers_url":"https://api.github.com/repos/01org/ciao/subscribers","subscription_url":"https://api.github.com/repos/01org/ciao/subscription","commits_url":"https://api.github.com/repos/01org/ciao/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/ciao/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/ciao/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/ciao/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/ciao/contents/{+path}","compare_url":"https://api.github.com/repos/01org/ciao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/ciao/merges","archive_url":"https://api.github.com/repos/01org/ciao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/ciao/downloads","issues_url":"https://api.github.com/repos/01org/ciao/issues{/number}","pulls_url":"https://api.github.com/repos/01org/ciao/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/ciao/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/ciao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/ciao/labels{/name}","releases_url":"https://api.github.com/repos/01org/ciao/releases{/id}","deployments_url":"https://api.github.com/repos/01org/ciao/deployments","created_at":"2016-03-24T17:19:34Z","updated_at":"2016-05-25T19:18:55Z","pushed_at":"2016-06-06T11:34:08Z","git_url":"git://github.com/01org/ciao.git","ssh_url":"git@github.com:01org/ciao.git","clone_url":"https://github.com/01org/ciao.git","svn_url":"https://github.com/01org/ciao","homepage":"","size":3458,"stargazers_count":31,"watchers_count":31,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":82,"forks":17,"open_issues":82,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/ciao/pulls/205"},"html":{"href":"https://github.com/01org/ciao/pull/205"},"issue":{"href":"https://api.github.com/repos/01org/ciao/issues/205"},"comments":{"href":"https://api.github.com/repos/01org/ciao/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/ciao/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/ciao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/ciao/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/01org/ciao/statuses/bf25bc9f07eec629b5580b3eec37f24efb884fab"}}}}
{"actor":{"display_login":"markdryan"}}