{"action":"created","issue":{"url":"https://api.github.com/repos/dealii/dealii/issues/2992","repository_url":"https://api.github.com/repos/dealii/dealii","labels_url":"https://api.github.com/repos/dealii/dealii/issues/2992/labels{/name}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2992/comments","events_url":"https://api.github.com/repos/dealii/dealii/issues/2992/events","html_url":"https://github.com/dealii/dealii/pull/2992","id":172239674,"number":2992,"title":"Reduce use of Quadrature objects in Manifolds.","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dealii/dealii/labels/Ready%20to%20merge","name":"Ready to merge","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-08-19T23:42:02Z","updated_at":"2016-09-02T16:52:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2992","html_url":"https://github.com/dealii/dealii/pull/2992","diff_url":"https://github.com/dealii/dealii/pull/2992.diff","patch_url":"https://github.com/dealii/dealii/pull/2992.patch"},"body":"This should help with #2896 as discussed in #2990. \r\n@kronbichler is this approximately what you imagined?\r\nFor now I only deprecated the old functions, maybe some of them are not used from the outside, and can be removed immediately? Not sure about that.\r\nI have not checked the speedup for other Manifolds, but for the SphericalManifold not using the `Quadrature` in `get_new_point` reduced its compute cycles by about 20 %, and there are more savings further up in the calling functions that do not longer construct Quadrature objects (get_intermediate_points in total saves 30% of its cycles). For simpler Manifolds this might be even higher, because their `get_intermediate_point` functions are likely cheaper.\r\nBefore merging this PR I would like to do some tests in 3D first, to make sure the O(N^2) sort in `get_new_point` does not outscale the benefits of not allocating memory, but this is not relevant for any other Manifold than `SphericalManifold`."},"comment":{"url":"https://api.github.com/repos/dealii/dealii/issues/comments/244429231","html_url":"https://github.com/dealii/dealii/pull/2992#issuecomment-244429231","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2992","id":244429231,"user":{"login":"tamiko","id":3432917,"avatar_url":"https://avatars.githubusercontent.com/u/3432917?v=3","gravatar_id":"","url":"https://api.github.com/users/tamiko","html_url":"https://github.com/tamiko","followers_url":"https://api.github.com/users/tamiko/followers","following_url":"https://api.github.com/users/tamiko/following{/other_user}","gists_url":"https://api.github.com/users/tamiko/gists{/gist_id}","starred_url":"https://api.github.com/users/tamiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamiko/subscriptions","organizations_url":"https://api.github.com/users/tamiko/orgs","repos_url":"https://api.github.com/users/tamiko/repos","events_url":"https://api.github.com/users/tamiko/events{/privacy}","received_events_url":"https://api.github.com/users/tamiko/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T16:52:41Z","updated_at":"2016-09-02T16:52:41Z","body":"@gassmoeller Can you please rebase on current master for the merge?"}}
{"actor":{"display_login":"tamiko"}}