{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1668","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1668/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1668/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1668/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1668","id":142496746,"number":1668,"title":"Abstracted create and queryOne out of the multiselect","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-21T23:10:25Z","updated_at":"2016-03-23T18:49:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1668","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1668","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/1668.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/1668.patch"},"body":"Abstracted create and queryOne out of the multiselect\r\n\r\n## Additions\r\n\r\n- Creates elem creation helper for standardizing elem creation\r\n  - Adds option for creating an elem inside another (including in memory, reducing dom changes)\r\n  - Adds option for creating an elem around another\r\n- Creates elem query helper for standardizing elem search (necessary for appending elems to others in memory)\r\n- Adds tests for both of these\r\n\r\n## Changes\r\n\r\n- Updated the multiselect to use the abstracted helpers\r\n\r\n## Testing\r\n\r\n- `gulp build` and test the multiselect, shouldn't be any changes\r\n- `gulp test:unit:scripts` and open `./test/unit_test_coverage/lcov-report/modules/util/index.html` to view the stats on both of these specs\r\n\r\n## Review\r\n\r\n- @KimberlyMunoz \r\n- @sebworks \r\n- @anselmbradford \r\n\r\n## Screenshots\r\n\r\n\r\n## Notes\r\n\r\n__Before__\r\n\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 26.64% ( 712/2673 )\r\nBranches     : 21.97% ( 192/874 )\r\nFunctions    : 19.58% ( 84/429 )\r\nLines        : 26.74% ( 708/2648 )\r\n================================================================================\r\n```\r\n\r\n__After__\r\n\r\n```\r\n=============================== Coverage summary ===============================\r\nStatements   : 27.3% ( 731/2678 )\r\nBranches     : 23.34% ( 204/874 )\r\nFunctions    : 20.05% ( 86/429 )\r\nLines        : 27.4% ( 727/2653 )\r\n================================================================================\r\n```\r\n\r\n## Todos\r\n\r\n- Abstract and test the rest of the multiselect, I didn't want to make this PR too large.\r\n\r\n## Checklist\r\n\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/200492110","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1668#issuecomment-200492110","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1668","id":200492110,"user":{"login":"sebworks","id":1696212,"avatar_url":"https://avatars.githubusercontent.com/u/1696212?v=3","gravatar_id":"","url":"https://api.github.com/users/sebworks","html_url":"https://github.com/sebworks","followers_url":"https://api.github.com/users/sebworks/followers","following_url":"https://api.github.com/users/sebworks/following{/other_user}","gists_url":"https://api.github.com/users/sebworks/gists{/gist_id}","starred_url":"https://api.github.com/users/sebworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebworks/subscriptions","organizations_url":"https://api.github.com/users/sebworks/orgs","repos_url":"https://api.github.com/users/sebworks/repos","events_url":"https://api.github.com/users/sebworks/events{/privacy}","received_events_url":"https://api.github.com/users/sebworks/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T18:49:10Z","updated_at":"2016-03-23T18:49:10Z","body":":+1: "}}