{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2345","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2345/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2345/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2345/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2345","id":176810240,"number":2345,"title":"Label oceans and large seas from a static file","user":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"labels":[{"id":92420788,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/shapefiles","name":"shapefiles","color":"666666","default":false},{"id":92406700,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/water","name":"water","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"assignees":[{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2016-09-14T04:11:12Z","updated_at":"2016-10-27T19:59:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2345","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2345","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2345.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2345.patch"},"body":"This is a proof of concept of using a static file to label seas and large oceans with hand-placed labels.\r\n\r\n* The placements are designed for a webmap which wraps around +/- 180. This allows placement of a single North Pacific label, while many printed maps use two, one on each edge. Other webmaps use a single label but place it so it doesn't cross 180. I believe what I am doing is unique among webmaps. Not worrying about the +/- 180 allows for more flexibility in positions\r\n* Positions and sea selections are designed for Mercator. osm-carto will never make a good map for viewing the entire world at once with its projection, but it's what we use.\r\n\r\n\r\nThere are a number of outstanding issues\r\n\r\n* [ ] Even with the increased size, the smallest labels seem faint. We might need to adjust the water colour. Many maps use white.\r\n* [ ] With the syntax used it seems necessary to specify the same point multiple times even when it's at the same location in order to increase its size on higher zooms.\r\n* [ ] Labels on z4+ haven't been given huge consideration\r\n* [x] I'm not sure what to do with the southern ocean. It's geometry is unlike other oceans because the on-globe centroid is on land, and in Mercator it is a very large ocean.\r\n* [ ] ~~Some of the seas should probably be in the local language~~\r\n* [x] Right now line breaks are done through wrapping. Since these are manual labels it might make more sense to turn off wrapping and use manual newlines\r\n\r\nI drew technical ideas from [osm2vectortiles seas.geojson](https://github.com/osm2vectortiles/osm2vectortiles/pull/394#issuecomment-238073484) and cartographic/labeling ideas from Natural Earth and [Tim Patterson's Physical Map of the World](http://shadedrelief.com/world/). I specifically avoided looking at MapBox Streets as they have falsely [claimed ownership over similar files to what I was making](https://github.com/osm2vectortiles/osm2vectortiles/issues/387#issuecomment-238060253)."},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/256752553","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2345#issuecomment-256752553","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2345","id":256752553,"user":{"login":"imagico","id":5408119,"avatar_url":"https://avatars.githubusercontent.com/u/5408119?v=3","gravatar_id":"","url":"https://api.github.com/users/imagico","html_url":"https://github.com/imagico","followers_url":"https://api.github.com/users/imagico/followers","following_url":"https://api.github.com/users/imagico/following{/other_user}","gists_url":"https://api.github.com/users/imagico/gists{/gist_id}","starred_url":"https://api.github.com/users/imagico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imagico/subscriptions","organizations_url":"https://api.github.com/users/imagico/orgs","repos_url":"https://api.github.com/users/imagico/repos","events_url":"https://api.github.com/users/imagico/events{/privacy}","received_events_url":"https://api.github.com/users/imagico/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T19:59:54Z","updated_at":"2016-10-27T19:59:54Z","body":"I think no one would deny we already have a de facto English default for the name tag in many cases where there is no obvious most common language for the feature in question.  But this is just a de facto situation the OSM community can change any time if it feels like it.  And i don't think this style has any kind of mandate to cast this de facto situation as it is right now into static code.\r\n\r\nAnother point to consider:  There are many derivatives of this style implementing maps with localized labels like the German and French styles.  Currently this requires only modifying references to the name tag from within SQL in some way.  If we add a hardcoded list of features with name attributes in English this list would need to be modified as well complicating things quite a bit."}}
{"actor":{"display_login":"imagico"}}