{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/85015334","pull_request_review_id":5756939,"id":85015334,"diff_hunk":"@@ -42,9 +42,9 @@\n #allowed_units = {'hours': 'hours', 'days': 'days', 'weeks': 'weeks', 'months': 'months'}\n allowed_units = {'days': 'days', 'weeks': 'weeks', 'months': 'months'}\n \n-# allowed operations, currently we'll just allow delete\n-allowed_operations = {'delete': 'delete'}\n-curator_settings = {'delete': {}}\n+# allowed operations, currently we'll just allow delete, close, and optimize\n+allowed_operations = {'delete': 'delete', 'close': 'close', 'optimize': 'optimize'}","path":"curator/run_cron.py","position":8,"original_position":8,"commit_id":"cd9973c642e028058588a4123e4b56e8ce8e4c52","original_commit_id":"cd9973c642e028058588a4123e4b56e8ce8e4c52","user":{"login":"portante","id":949097,"avatar_url":"https://avatars.githubusercontent.com/u/949097?v=3","gravatar_id":"","url":"https://api.github.com/users/portante","html_url":"https://github.com/portante","followers_url":"https://api.github.com/users/portante/followers","following_url":"https://api.github.com/users/portante/following{/other_user}","gists_url":"https://api.github.com/users/portante/gists{/gist_id}","starred_url":"https://api.github.com/users/portante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portante/subscriptions","organizations_url":"https://api.github.com/users/portante/orgs","repos_url":"https://api.github.com/users/portante/repos","events_url":"https://api.github.com/users/portante/events{/privacy}","received_events_url":"https://api.github.com/users/portante/received_events","type":"User","site_admin":false},"body":"Why does this need to be a dictionary?","created_at":"2016-10-25T22:27:01Z","updated_at":"2016-10-25T22:27:01Z","html_url":"https://github.com/openshift/origin-aggregated-logging/pull/223#discussion_r85015334","pull_request_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments/85015334"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/223#discussion_r85015334"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223","id":84359811,"html_url":"https://github.com/openshift/origin-aggregated-logging/pull/223","diff_url":"https://github.com/openshift/origin-aggregated-logging/pull/223.diff","patch_url":"https://github.com/openshift/origin-aggregated-logging/pull/223.patch","issue_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/223","number":223,"state":"open","locked":false,"title":"[WIP] Enable optimizing and closing indices for curator","user":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"body":"`close` has the same parameters [1] as `delete` and `optimize` has a few others [2], but the default seems to be okay for now. \r\n\r\n[1] https://www.elastic.co/guide/en/elasticsearch/client/curator/3.5/close.html\r\n[2] https://www.elastic.co/guide/en/elasticsearch/client/curator/3.5/optimize.html\r\n\r\ntests will be needed","created_at":"2016-09-07T19:35:53Z","updated_at":"2016-10-25T22:27:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8692cc6118dd47d7d367371c04e65fa82f82230a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/223/comments","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/cd9973c642e028058588a4123e4b56e8ce8e4c52","head":{"label":"ewolinetz:new_curator_operations","ref":"new_curator_operations","sha":"cd9973c642e028058588a4123e4b56e8ce8e4c52","user":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"repo":{"id":42482798,"name":"origin-aggregated-logging","full_name":"ewolinetz/origin-aggregated-logging","owner":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewolinetz/origin-aggregated-logging","description":null,"fork":true,"url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging","forks_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/ewolinetz/origin-aggregated-logging/deployments","created_at":"2015-09-14T23:25:49Z","updated_at":"2016-10-24T22:29:10Z","pushed_at":"2016-10-25T21:48:30Z","git_url":"git://github.com/ewolinetz/origin-aggregated-logging.git","ssh_url":"git@github.com:ewolinetz/origin-aggregated-logging.git","clone_url":"https://github.com/ewolinetz/origin-aggregated-logging.git","svn_url":"https://github.com/ewolinetz/origin-aggregated-logging","homepage":null,"size":18936,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c8e917cd9584aa862bd6ccac8f0ee64a69fc11f0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":42467822,"name":"origin-aggregated-logging","full_name":"openshift/origin-aggregated-logging","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-aggregated-logging","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-aggregated-logging","forks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/forks","keys_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/teams","hooks_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/events","assignees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/tags","blobs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/subscription","commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/merges","archive_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/downloads","issues_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-aggregated-logging/deployments","created_at":"2015-09-14T18:14:19Z","updated_at":"2016-10-24T14:55:59Z","pushed_at":"2016-10-25T21:51:54Z","git_url":"git://github.com/openshift/origin-aggregated-logging.git","ssh_url":"git@github.com:openshift/origin-aggregated-logging.git","clone_url":"https://github.com/openshift/origin-aggregated-logging.git","svn_url":"https://github.com/openshift/origin-aggregated-logging","homepage":null,"size":8837,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":37,"forks":39,"open_issues":37,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223"},"html":{"href":"https://github.com/openshift/origin-aggregated-logging/pull/223"},"issue":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/223"},"comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-aggregated-logging/statuses/cd9973c642e028058588a4123e4b56e8ce8e4c52"}}}}
{"actor":{"display_login":"portante"}}