{"action":"closed","number":1370,"pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370","id":87054712,"html_url":"https://github.com/BabylonJS/Babylon.js/pull/1370","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/1370.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/1370.patch","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/1370","number":1370,"state":"closed","locked":false,"title":"Make tasks and waitingTasksCount protected","user":{"login":"Swiftwork","id":455178,"avatar_url":"https://avatars.githubusercontent.com/u/455178?v=3","gravatar_id":"","url":"https://api.github.com/users/Swiftwork","html_url":"https://github.com/Swiftwork","followers_url":"https://api.github.com/users/Swiftwork/followers","following_url":"https://api.github.com/users/Swiftwork/following{/other_user}","gists_url":"https://api.github.com/users/Swiftwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Swiftwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swiftwork/subscriptions","organizations_url":"https://api.github.com/users/Swiftwork/orgs","repos_url":"https://api.github.com/users/Swiftwork/repos","events_url":"https://api.github.com/users/Swiftwork/events{/privacy}","received_events_url":"https://api.github.com/users/Swiftwork/received_events","type":"User","site_admin":false},"body":"Making tasks array and waitingTasksCount protected would allow developers to extend the AssetsManager and add custom tasks, such as a FontFileAssetTask. This would be useful for situations like http://www.html5gamedevs.com/topic/23989-custom-fonts-in-canvas2d/ where a third party library is used to load font faces before Text2D renders. BabylonJS might not want to add a FontFileAssetTask due to the overhead, but it would be helpful for developers that want to maintain the AssetsManager pattern without duplicating the entire code.","created_at":"2016-09-28T04:56:00Z","updated_at":"2016-09-28T17:38:28Z","closed_at":"2016-09-28T17:38:28Z","merged_at":"2016-09-28T17:38:28Z","merge_commit_sha":"74a253d64f0ef4deb392e550aae6dcf34e45be1e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370/commits","review_comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370/comments","review_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/1370/comments","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/3b6065461829e463ea2622350fb80eb3a5679fad","head":{"label":"Swiftwork:master","ref":"master","sha":"3b6065461829e463ea2622350fb80eb3a5679fad","user":{"login":"Swiftwork","id":455178,"avatar_url":"https://avatars.githubusercontent.com/u/455178?v=3","gravatar_id":"","url":"https://api.github.com/users/Swiftwork","html_url":"https://github.com/Swiftwork","followers_url":"https://api.github.com/users/Swiftwork/followers","following_url":"https://api.github.com/users/Swiftwork/following{/other_user}","gists_url":"https://api.github.com/users/Swiftwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Swiftwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swiftwork/subscriptions","organizations_url":"https://api.github.com/users/Swiftwork/orgs","repos_url":"https://api.github.com/users/Swiftwork/repos","events_url":"https://api.github.com/users/Swiftwork/events{/privacy}","received_events_url":"https://api.github.com/users/Swiftwork/received_events","type":"User","site_admin":false},"repo":{"id":69426451,"name":"Babylon.js","full_name":"Swiftwork/Babylon.js","owner":{"login":"Swiftwork","id":455178,"avatar_url":"https://avatars.githubusercontent.com/u/455178?v=3","gravatar_id":"","url":"https://api.github.com/users/Swiftwork","html_url":"https://github.com/Swiftwork","followers_url":"https://api.github.com/users/Swiftwork/followers","following_url":"https://api.github.com/users/Swiftwork/following{/other_user}","gists_url":"https://api.github.com/users/Swiftwork/gists{/gist_id}","starred_url":"https://api.github.com/users/Swiftwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swiftwork/subscriptions","organizations_url":"https://api.github.com/users/Swiftwork/orgs","repos_url":"https://api.github.com/users/Swiftwork/repos","events_url":"https://api.github.com/users/Swiftwork/events{/privacy}","received_events_url":"https://api.github.com/users/Swiftwork/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Swiftwork/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":true,"url":"https://api.github.com/repos/Swiftwork/Babylon.js","forks_url":"https://api.github.com/repos/Swiftwork/Babylon.js/forks","keys_url":"https://api.github.com/repos/Swiftwork/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Swiftwork/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Swiftwork/Babylon.js/teams","hooks_url":"https://api.github.com/repos/Swiftwork/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/Swiftwork/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/Swiftwork/Babylon.js/events","assignees_url":"https://api.github.com/repos/Swiftwork/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/Swiftwork/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/Swiftwork/Babylon.js/tags","blobs_url":"https://api.github.com/repos/Swiftwork/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Swiftwork/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Swiftwork/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Swiftwork/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Swiftwork/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Swiftwork/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/Swiftwork/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/Swiftwork/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/Swiftwork/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/Swiftwork/Babylon.js/subscription","commits_url":"https://api.github.com/repos/Swiftwork/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Swiftwork/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Swiftwork/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Swiftwork/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Swiftwork/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/Swiftwork/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Swiftwork/Babylon.js/merges","archive_url":"https://api.github.com/repos/Swiftwork/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Swiftwork/Babylon.js/downloads","issues_url":"https://api.github.com/repos/Swiftwork/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/Swiftwork/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Swiftwork/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Swiftwork/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Swiftwork/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/Swiftwork/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/Swiftwork/Babylon.js/deployments","created_at":"2016-09-28T04:44:46Z","updated_at":"2016-09-28T04:44:52Z","pushed_at":"2016-09-28T04:54:41Z","git_url":"git://github.com/Swiftwork/Babylon.js.git","ssh_url":"git@github.com:Swiftwork/Babylon.js.git","clone_url":"https://github.com/Swiftwork/Babylon.js.git","svn_url":"https://github.com/Swiftwork/Babylon.js","homepage":"http://www.babylonjs.com","size":616452,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BabylonJS:master","ref":"master","sha":"7a3662d5f86bb30010ebb9b4e51330d67e7d36ac","user":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11007313,"name":"Babylon.js","full_name":"BabylonJS/Babylon.js","owner":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BabylonJS/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":false,"url":"https://api.github.com/repos/BabylonJS/Babylon.js","forks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/forks","keys_url":"https://api.github.com/repos/BabylonJS/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabylonJS/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabylonJS/Babylon.js/teams","hooks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/events","assignees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/BabylonJS/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/tags","blobs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BabylonJS/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscription","commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/BabylonJS/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabylonJS/Babylon.js/merges","archive_url":"https://api.github.com/repos/BabylonJS/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabylonJS/Babylon.js/downloads","issues_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BabylonJS/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BabylonJS/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/BabylonJS/Babylon.js/releases{/id}","deployments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/deployments","created_at":"2013-06-27T20:40:42Z","updated_at":"2016-09-28T11:44:06Z","pushed_at":"2016-09-28T17:38:28Z","git_url":"git://github.com/BabylonJS/Babylon.js.git","ssh_url":"git@github.com:BabylonJS/Babylon.js.git","clone_url":"https://github.com/BabylonJS/Babylon.js.git","svn_url":"https://github.com/BabylonJS/Babylon.js","homepage":"http://www.babylonjs.com","size":619492,"stargazers_count":3658,"watchers_count":3658,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":949,"mirror_url":null,"open_issues_count":2,"forks":949,"open_issues":2,"watchers":3658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370"},"html":{"href":"https://github.com/BabylonJS/Babylon.js/pull/1370"},"issue":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/1370"},"comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/1370/comments"},"review_comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370/comments"},"review_comment":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/1370/commits"},"statuses":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/3b6065461829e463ea2622350fb80eb3a5679fad"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"deltakosh","id":1306056,"avatar_url":"https://avatars.githubusercontent.com/u/1306056?v=3","gravatar_id":"","url":"https://api.github.com/users/deltakosh","html_url":"https://github.com/deltakosh","followers_url":"https://api.github.com/users/deltakosh/followers","following_url":"https://api.github.com/users/deltakosh/following{/other_user}","gists_url":"https://api.github.com/users/deltakosh/gists{/gist_id}","starred_url":"https://api.github.com/users/deltakosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltakosh/subscriptions","organizations_url":"https://api.github.com/users/deltakosh/orgs","repos_url":"https://api.github.com/users/deltakosh/repos","events_url":"https://api.github.com/users/deltakosh/events{/privacy}","received_events_url":"https://api.github.com/users/deltakosh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"deltakosh"}}