{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/57937099","id":57937099,"diff_hunk":"@@ -13,4 +15,18 @@ class V220Spec extends PropSpec with PropertyChecks with MustMatchers with LarGe\n       }\n     }\n   }\n+\n+  val badLoanTypeGen: Gen[Int] = {\n+    val belowRange = Gen.choose(Integer.MIN_VALUE, 0)\n+    val aboveRange = Gen.choose(5, Integer.MAX_VALUE)\n+    Gen.oneOf(belowRange, aboveRange)\n+  }\n+\n+  property(\"Loan Type other than 1,2,3,4 is invalid\") {\n+    forAll(larGen, badLoanTypeGen) { (lar: LoanApplicationRegister, x: Int) =>\n+      val invalidLoan: Loan = lar.loan.copy(loanType = x)\n+      V220(invalidLoan) mustBe Failure(\"is not contained in valid values domain\")","path":"validation/src/test/scala/hmda/validation/rules/lar/validity/V220Spec.scala","position":25,"original_position":25,"commit_id":"374e4b6efdd69277d88ee150eb63714ab6ca38da","original_commit_id":"2dcfd0b55a2251f0c25ad65a48318050b6857229","user":{"login":"schbetsy","id":4295388,"avatar_url":"https://avatars.githubusercontent.com/u/4295388?v=3","gravatar_id":"","url":"https://api.github.com/users/schbetsy","html_url":"https://github.com/schbetsy","followers_url":"https://api.github.com/users/schbetsy/followers","following_url":"https://api.github.com/users/schbetsy/following{/other_user}","gists_url":"https://api.github.com/users/schbetsy/gists{/gist_id}","starred_url":"https://api.github.com/users/schbetsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schbetsy/subscriptions","organizations_url":"https://api.github.com/users/schbetsy/orgs","repos_url":"https://api.github.com/users/schbetsy/repos","events_url":"https://api.github.com/users/schbetsy/events{/privacy}","received_events_url":"https://api.github.com/users/schbetsy/received_events","type":"User","site_admin":false},"body":"Where is this being discussed? I'm interested in what options we're considering.","created_at":"2016-03-30T18:17:15Z","updated_at":"2016-03-30T18:17:15Z","html_url":"https://github.com/cfpb/hmda-platform/pull/267#discussion_r57937099","pull_request_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/57937099"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/267#discussion_r57937099"},"pull_request":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267","id":64541774,"html_url":"https://github.com/cfpb/hmda-platform/pull/267","diff_url":"https://github.com/cfpb/hmda-platform/pull/267.diff","patch_url":"https://github.com/cfpb/hmda-platform/pull/267.patch","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/267","number":267,"state":"closed","locked":false,"title":"Test the failure case for V220","user":{"login":"schbetsy","id":4295388,"avatar_url":"https://avatars.githubusercontent.com/u/4295388?v=3","gravatar_id":"","url":"https://api.github.com/users/schbetsy","html_url":"https://github.com/schbetsy","followers_url":"https://api.github.com/users/schbetsy/followers","following_url":"https://api.github.com/users/schbetsy/following{/other_user}","gists_url":"https://api.github.com/users/schbetsy/gists{/gist_id}","starred_url":"https://api.github.com/users/schbetsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schbetsy/subscriptions","organizations_url":"https://api.github.com/users/schbetsy/orgs","repos_url":"https://api.github.com/users/schbetsy/repos","events_url":"https://api.github.com/users/schbetsy/events{/privacy}","received_events_url":"https://api.github.com/users/schbetsy/received_events","type":"User","site_admin":false},"body":"LoanType must be 1,2,3, or 4.\r\n\r\nAddresses #115 ","created_at":"2016-03-29T22:04:27Z","updated_at":"2016-03-30T18:17:15Z","closed_at":"2016-03-30T15:33:54Z","merged_at":"2016-03-30T15:33:54Z","merge_commit_sha":"ca46ffccdefebc61c375f4d932323b037e951074","assignee":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267/commits","review_comments_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267/comments","review_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/267/comments","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/374e4b6efdd69277d88ee150eb63714ab6ca38da","head":{"label":"schbetsy:V220","ref":"V220","sha":"374e4b6efdd69277d88ee150eb63714ab6ca38da","user":{"login":"schbetsy","id":4295388,"avatar_url":"https://avatars.githubusercontent.com/u/4295388?v=3","gravatar_id":"","url":"https://api.github.com/users/schbetsy","html_url":"https://github.com/schbetsy","followers_url":"https://api.github.com/users/schbetsy/followers","following_url":"https://api.github.com/users/schbetsy/following{/other_user}","gists_url":"https://api.github.com/users/schbetsy/gists{/gist_id}","starred_url":"https://api.github.com/users/schbetsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schbetsy/subscriptions","organizations_url":"https://api.github.com/users/schbetsy/orgs","repos_url":"https://api.github.com/users/schbetsy/repos","events_url":"https://api.github.com/users/schbetsy/events{/privacy}","received_events_url":"https://api.github.com/users/schbetsy/received_events","type":"User","site_admin":false},"repo":{"id":50669588,"name":"hmda-platform","full_name":"schbetsy/hmda-platform","owner":{"login":"schbetsy","id":4295388,"avatar_url":"https://avatars.githubusercontent.com/u/4295388?v=3","gravatar_id":"","url":"https://api.github.com/users/schbetsy","html_url":"https://github.com/schbetsy","followers_url":"https://api.github.com/users/schbetsy/followers","following_url":"https://api.github.com/users/schbetsy/following{/other_user}","gists_url":"https://api.github.com/users/schbetsy/gists{/gist_id}","starred_url":"https://api.github.com/users/schbetsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schbetsy/subscriptions","organizations_url":"https://api.github.com/users/schbetsy/orgs","repos_url":"https://api.github.com/users/schbetsy/repos","events_url":"https://api.github.com/users/schbetsy/events{/privacy}","received_events_url":"https://api.github.com/users/schbetsy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schbetsy/hmda-platform","description":"","fork":true,"url":"https://api.github.com/repos/schbetsy/hmda-platform","forks_url":"https://api.github.com/repos/schbetsy/hmda-platform/forks","keys_url":"https://api.github.com/repos/schbetsy/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schbetsy/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schbetsy/hmda-platform/teams","hooks_url":"https://api.github.com/repos/schbetsy/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/schbetsy/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/schbetsy/hmda-platform/events","assignees_url":"https://api.github.com/repos/schbetsy/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/schbetsy/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/schbetsy/hmda-platform/tags","blobs_url":"https://api.github.com/repos/schbetsy/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schbetsy/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schbetsy/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/schbetsy/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schbetsy/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/schbetsy/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/schbetsy/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/schbetsy/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/schbetsy/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/schbetsy/hmda-platform/subscription","commits_url":"https://api.github.com/repos/schbetsy/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/schbetsy/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/schbetsy/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/schbetsy/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/schbetsy/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/schbetsy/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schbetsy/hmda-platform/merges","archive_url":"https://api.github.com/repos/schbetsy/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schbetsy/hmda-platform/downloads","issues_url":"https://api.github.com/repos/schbetsy/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/schbetsy/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/schbetsy/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/schbetsy/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schbetsy/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/schbetsy/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/schbetsy/hmda-platform/deployments","created_at":"2016-01-29T15:04:38Z","updated_at":"2016-02-22T17:40:33Z","pushed_at":"2016-03-30T14:43:24Z","git_url":"git://github.com/schbetsy/hmda-platform.git","ssh_url":"git@github.com:schbetsy/hmda-platform.git","clone_url":"https://github.com/schbetsy/hmda-platform.git","svn_url":"https://github.com/schbetsy/hmda-platform","homepage":"","size":716,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"256a49b4dfbe2a29dfcc4b5893370cc34ac86796","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":50141662,"name":"hmda-platform","full_name":"cfpb/hmda-platform","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/hmda-platform","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/hmda-platform","forks_url":"https://api.github.com/repos/cfpb/hmda-platform/forks","keys_url":"https://api.github.com/repos/cfpb/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/hmda-platform/teams","hooks_url":"https://api.github.com/repos/cfpb/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/hmda-platform/events","assignees_url":"https://api.github.com/repos/cfpb/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/hmda-platform/tags","blobs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/cfpb/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/cfpb/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/cfpb/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/cfpb/hmda-platform/subscription","commits_url":"https://api.github.com/repos/cfpb/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/hmda-platform/merges","archive_url":"https://api.github.com/repos/cfpb/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/hmda-platform/downloads","issues_url":"https://api.github.com/repos/cfpb/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/hmda-platform/deployments","created_at":"2016-01-21T22:39:17Z","updated_at":"2016-03-18T23:37:13Z","pushed_at":"2016-03-30T15:33:54Z","git_url":"git://github.com/cfpb/hmda-platform.git","ssh_url":"git@github.com:cfpb/hmda-platform.git","clone_url":"https://github.com/cfpb/hmda-platform.git","svn_url":"https://github.com/cfpb/hmda-platform","homepage":"","size":720,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":202,"forks":6,"open_issues":202,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/267"},"issue":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/267"},"comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/hmda-platform/statuses/374e4b6efdd69277d88ee150eb63714ab6ca38da"}}}}