{"action":"created","comment":{"url":"https://api.github.com/repos/square/Valet/pulls/comments/49906849","id":49906849,"diff_hunk":"@@ -21,19 +21,56 @@\n #import <Valet/VALValet.h>\n \n \n-/// Reads and writes keychain elements that are stored on the Secure Enclave (supported on iOS 8.0 or later) using accessibility attribute VALAccessibilityWhenPasscodeSetThisDeviceOnly. Accessing or modifying these items will require the user to confirm their presence via Touch ID or passcode entry. If no passcode is set on the device, the below methods will fail. Data is removed from the Secure Enclave when the user removes a passcode from the device. Use the userPrompt methods to display custom text to the user in Apple's Touch ID and passcode entry UI.\n-NS_CLASS_AVAILABLE_IOS(8_0)\n+/// Compile flag for building against an SDK where Secure Enclave is available.","path":"Valet/VALSecureEnclaveValet.h","position":6,"original_position":6,"commit_id":"c0c1356928af393069a4015fb3eb96c24e90b44f","original_commit_id":"c0c1356928af393069a4015fb3eb96c24e90b44f","user":{"login":"EricMuller22","id":1934212,"avatar_url":"https://avatars.githubusercontent.com/u/1934212?v=3","gravatar_id":"","url":"https://api.github.com/users/EricMuller22","html_url":"https://github.com/EricMuller22","followers_url":"https://api.github.com/users/EricMuller22/followers","following_url":"https://api.github.com/users/EricMuller22/following{/other_user}","gists_url":"https://api.github.com/users/EricMuller22/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMuller22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMuller22/subscriptions","organizations_url":"https://api.github.com/users/EricMuller22/orgs","repos_url":"https://api.github.com/users/EricMuller22/repos","events_url":"https://api.github.com/users/EricMuller22/events{/privacy}","received_events_url":"https://api.github.com/users/EricMuller22/received_events","type":"User","site_admin":false},"body":"Super nit: I would say *nit","created_at":"2016-01-15T21:24:54Z","updated_at":"2016-01-15T21:24:54Z","html_url":"https://github.com/square/Valet/pull/66#discussion_r49906849","pull_request_url":"https://api.github.com/repos/square/Valet/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/square/Valet/pulls/comments/49906849"},"html":{"href":"https://github.com/square/Valet/pull/66#discussion_r49906849"},"pull_request":{"href":"https://api.github.com/repos/square/Valet/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/square/Valet/pulls/66","id":56121004,"html_url":"https://github.com/square/Valet/pull/66","diff_url":"https://github.com/square/Valet/pull/66.diff","patch_url":"https://github.com/square/Valet/pull/66.patch","issue_url":"https://api.github.com/repos/square/Valet/issues/66","number":66,"state":"open","locked":false,"title":"Valet to 2.1","user":{"login":"dfed","id":139364,"avatar_url":"https://avatars.githubusercontent.com/u/139364?v=3","gravatar_id":"","url":"https://api.github.com/users/dfed","html_url":"https://github.com/dfed","followers_url":"https://api.github.com/users/dfed/followers","following_url":"https://api.github.com/users/dfed/following{/other_user}","gists_url":"https://api.github.com/users/dfed/gists{/gist_id}","starred_url":"https://api.github.com/users/dfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfed/subscriptions","organizations_url":"https://api.github.com/users/dfed/orgs","repos_url":"https://api.github.com/users/dfed/repos","events_url":"https://api.github.com/users/dfed/events{/privacy}","received_events_url":"https://api.github.com/users/dfed/received_events","type":"User","site_admin":false},"body":"- VALSecureEnclaveValet can now store keychain elements under different AccessControl rules (UserPresence, TouchIDAnyFingerprint, TouchIDCurrentFingerprintSet, DevicePasscode)\r\n- VALSecureEnclaveValet available on Mac OS 10.11\r\n- Properly made VALValet_Protected.h private under CocoaPods (it was already private via submodules and Carthage)\r\n- Properly made ValetDefines.h private\r\n\r\nFixes #48\r\n\r\ncc @EricMuller22 @nicwise ","created_at":"2016-01-15T01:47:28Z","updated_at":"2016-01-15T21:24:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c3b22002200dc5154b737eaab1f482c6b0e1759","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/Valet/pulls/66/commits","review_comments_url":"https://api.github.com/repos/square/Valet/pulls/66/comments","review_comment_url":"https://api.github.com/repos/square/Valet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/Valet/issues/66/comments","statuses_url":"https://api.github.com/repos/square/Valet/statuses/c0c1356928af393069a4015fb3eb96c24e90b44f","head":{"label":"square:federman/secaccesscontrolflags","ref":"federman/secaccesscontrolflags","sha":"c0c1356928af393069a4015fb3eb96c24e90b44f","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":36665359,"name":"Valet","full_name":"square/Valet","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/Valet","description":"Valet lets you securely store data in the iOS or OS X Keychain without knowing a thing about how the Keychain works. It’s easy. We promise.","fork":false,"url":"https://api.github.com/repos/square/Valet","forks_url":"https://api.github.com/repos/square/Valet/forks","keys_url":"https://api.github.com/repos/square/Valet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/Valet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/Valet/teams","hooks_url":"https://api.github.com/repos/square/Valet/hooks","issue_events_url":"https://api.github.com/repos/square/Valet/issues/events{/number}","events_url":"https://api.github.com/repos/square/Valet/events","assignees_url":"https://api.github.com/repos/square/Valet/assignees{/user}","branches_url":"https://api.github.com/repos/square/Valet/branches{/branch}","tags_url":"https://api.github.com/repos/square/Valet/tags","blobs_url":"https://api.github.com/repos/square/Valet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/Valet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/Valet/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/Valet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/Valet/statuses/{sha}","languages_url":"https://api.github.com/repos/square/Valet/languages","stargazers_url":"https://api.github.com/repos/square/Valet/stargazers","contributors_url":"https://api.github.com/repos/square/Valet/contributors","subscribers_url":"https://api.github.com/repos/square/Valet/subscribers","subscription_url":"https://api.github.com/repos/square/Valet/subscription","commits_url":"https://api.github.com/repos/square/Valet/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/Valet/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/Valet/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/Valet/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/Valet/contents/{+path}","compare_url":"https://api.github.com/repos/square/Valet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/Valet/merges","archive_url":"https://api.github.com/repos/square/Valet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/Valet/downloads","issues_url":"https://api.github.com/repos/square/Valet/issues{/number}","pulls_url":"https://api.github.com/repos/square/Valet/pulls{/number}","milestones_url":"https://api.github.com/repos/square/Valet/milestones{/number}","notifications_url":"https://api.github.com/repos/square/Valet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/Valet/labels{/name}","releases_url":"https://api.github.com/repos/square/Valet/releases{/id}","created_at":"2015-06-01T14:17:12Z","updated_at":"2016-01-15T03:21:38Z","pushed_at":"2016-01-15T19:15:59Z","git_url":"git://github.com/square/Valet.git","ssh_url":"git@github.com:square/Valet.git","clone_url":"https://github.com/square/Valet.git","svn_url":"https://github.com/square/Valet","homepage":null,"size":272,"stargazers_count":1467,"watchers_count":1467,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":3,"forks":66,"open_issues":3,"watchers":1467,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"447c7831300d15e685b249494a9eb3e8fc31b1aa","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":36665359,"name":"Valet","full_name":"square/Valet","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/Valet","description":"Valet lets you securely store data in the iOS or OS X Keychain without knowing a thing about how the Keychain works. It’s easy. We promise.","fork":false,"url":"https://api.github.com/repos/square/Valet","forks_url":"https://api.github.com/repos/square/Valet/forks","keys_url":"https://api.github.com/repos/square/Valet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/Valet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/Valet/teams","hooks_url":"https://api.github.com/repos/square/Valet/hooks","issue_events_url":"https://api.github.com/repos/square/Valet/issues/events{/number}","events_url":"https://api.github.com/repos/square/Valet/events","assignees_url":"https://api.github.com/repos/square/Valet/assignees{/user}","branches_url":"https://api.github.com/repos/square/Valet/branches{/branch}","tags_url":"https://api.github.com/repos/square/Valet/tags","blobs_url":"https://api.github.com/repos/square/Valet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/Valet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/Valet/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/Valet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/Valet/statuses/{sha}","languages_url":"https://api.github.com/repos/square/Valet/languages","stargazers_url":"https://api.github.com/repos/square/Valet/stargazers","contributors_url":"https://api.github.com/repos/square/Valet/contributors","subscribers_url":"https://api.github.com/repos/square/Valet/subscribers","subscription_url":"https://api.github.com/repos/square/Valet/subscription","commits_url":"https://api.github.com/repos/square/Valet/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/Valet/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/Valet/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/Valet/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/Valet/contents/{+path}","compare_url":"https://api.github.com/repos/square/Valet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/Valet/merges","archive_url":"https://api.github.com/repos/square/Valet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/Valet/downloads","issues_url":"https://api.github.com/repos/square/Valet/issues{/number}","pulls_url":"https://api.github.com/repos/square/Valet/pulls{/number}","milestones_url":"https://api.github.com/repos/square/Valet/milestones{/number}","notifications_url":"https://api.github.com/repos/square/Valet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/Valet/labels{/name}","releases_url":"https://api.github.com/repos/square/Valet/releases{/id}","created_at":"2015-06-01T14:17:12Z","updated_at":"2016-01-15T03:21:38Z","pushed_at":"2016-01-15T19:15:59Z","git_url":"git://github.com/square/Valet.git","ssh_url":"git@github.com:square/Valet.git","clone_url":"https://github.com/square/Valet.git","svn_url":"https://github.com/square/Valet","homepage":null,"size":272,"stargazers_count":1467,"watchers_count":1467,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":3,"forks":66,"open_issues":3,"watchers":1467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/Valet/pulls/66"},"html":{"href":"https://github.com/square/Valet/pull/66"},"issue":{"href":"https://api.github.com/repos/square/Valet/issues/66"},"comments":{"href":"https://api.github.com/repos/square/Valet/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/square/Valet/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/square/Valet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/Valet/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/square/Valet/statuses/c0c1356928af393069a4015fb3eb96c24e90b44f"}}}}