{"action":"created","comment":{"url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/comments/85071789","pull_request_review_id":5807893,"id":85071789,"diff_hunk":"@@ -57,6 +57,14 @@ def whyrun_supported?\n         end\n       end\n \n+      # If logging rules are not provided, then create a rule to disable them (windows default)\n+      unless new_resource.rules['windows'].key?('set currentprofile logging droppedconnections enable')","path":"libraries/provider_firewall_windows.rb","position":5,"original_position":5,"commit_id":"9e47af7a3d7c9ea51599db79487497d253ce073e","original_commit_id":"9e47af7a3d7c9ea51599db79487497d253ce073e","user":{"login":"martinb3","id":103033,"avatar_url":"https://avatars.githubusercontent.com/u/103033?v=3","gravatar_id":"","url":"https://api.github.com/users/martinb3","html_url":"https://github.com/martinb3","followers_url":"https://api.github.com/users/martinb3/followers","following_url":"https://api.github.com/users/martinb3/following{/other_user}","gists_url":"https://api.github.com/users/martinb3/gists{/gist_id}","starred_url":"https://api.github.com/users/martinb3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinb3/subscriptions","organizations_url":"https://api.github.com/users/martinb3/orgs","repos_url":"https://api.github.com/users/martinb3/repos","events_url":"https://api.github.com/users/martinb3/events{/privacy}","received_events_url":"https://api.github.com/users/martinb3/received_events","type":"User","site_admin":false},"body":"Shouldn't we do nothing if there aren't existing logging rules provided? I don't want to maintain Windows defaults in this cookbook long term.","created_at":"2016-10-26T08:26:42Z","updated_at":"2016-10-26T08:26:42Z","html_url":"https://github.com/chef-cookbooks/firewall/pull/144#discussion_r85071789","pull_request_url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/comments/85071789"},"html":{"href":"https://github.com/chef-cookbooks/firewall/pull/144#discussion_r85071789"},"pull_request":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144","id":77631511,"html_url":"https://github.com/chef-cookbooks/firewall/pull/144","diff_url":"https://github.com/chef-cookbooks/firewall/pull/144.diff","patch_url":"https://github.com/chef-cookbooks/firewall/pull/144.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/144","number":144,"state":"open","locked":false,"title":"Feature to add Windows firewall logging","user":{"login":"snkutlu","id":1405454,"avatar_url":"https://avatars.githubusercontent.com/u/1405454?v=3","gravatar_id":"","url":"https://api.github.com/users/snkutlu","html_url":"https://github.com/snkutlu","followers_url":"https://api.github.com/users/snkutlu/followers","following_url":"https://api.github.com/users/snkutlu/following{/other_user}","gists_url":"https://api.github.com/users/snkutlu/gists{/gist_id}","starred_url":"https://api.github.com/users/snkutlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snkutlu/subscriptions","organizations_url":"https://api.github.com/users/snkutlu/orgs","repos_url":"https://api.github.com/users/snkutlu/repos","events_url":"https://api.github.com/users/snkutlu/events{/privacy}","received_events_url":"https://api.github.com/users/snkutlu/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nFeature to enable logging for Windows Firewall.\r\n\r\n### Issues Resolved\r\n\r\n### Check List\r\n- [x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD\r\n- [x] New functionality includes testing.\r\n- [x] New functionality has been documented in the README if applicable\r\n- [x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD\r\n\r\n\r\n","created_at":"2016-07-15T15:13:11Z","updated_at":"2016-10-26T08:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ae6685ac859c1c535f062fcb8c36dd3f61c3cde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/144/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/firewall/statuses/9e47af7a3d7c9ea51599db79487497d253ce073e","head":{"label":"snkutlu:feature_windows_logging","ref":"feature_windows_logging","sha":"9e47af7a3d7c9ea51599db79487497d253ce073e","user":{"login":"snkutlu","id":1405454,"avatar_url":"https://avatars.githubusercontent.com/u/1405454?v=3","gravatar_id":"","url":"https://api.github.com/users/snkutlu","html_url":"https://github.com/snkutlu","followers_url":"https://api.github.com/users/snkutlu/followers","following_url":"https://api.github.com/users/snkutlu/following{/other_user}","gists_url":"https://api.github.com/users/snkutlu/gists{/gist_id}","starred_url":"https://api.github.com/users/snkutlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snkutlu/subscriptions","organizations_url":"https://api.github.com/users/snkutlu/orgs","repos_url":"https://api.github.com/users/snkutlu/repos","events_url":"https://api.github.com/users/snkutlu/events{/privacy}","received_events_url":"https://api.github.com/users/snkutlu/received_events","type":"User","site_admin":false},"repo":{"id":63060818,"name":"firewall","full_name":"snkutlu/firewall","owner":{"login":"snkutlu","id":1405454,"avatar_url":"https://avatars.githubusercontent.com/u/1405454?v=3","gravatar_id":"","url":"https://api.github.com/users/snkutlu","html_url":"https://github.com/snkutlu","followers_url":"https://api.github.com/users/snkutlu/followers","following_url":"https://api.github.com/users/snkutlu/following{/other_user}","gists_url":"https://api.github.com/users/snkutlu/gists{/gist_id}","starred_url":"https://api.github.com/users/snkutlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snkutlu/subscriptions","organizations_url":"https://api.github.com/users/snkutlu/orgs","repos_url":"https://api.github.com/users/snkutlu/repos","events_url":"https://api.github.com/users/snkutlu/events{/privacy}","received_events_url":"https://api.github.com/users/snkutlu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snkutlu/firewall","description":"Development repository for generic firewall cookbook","fork":true,"url":"https://api.github.com/repos/snkutlu/firewall","forks_url":"https://api.github.com/repos/snkutlu/firewall/forks","keys_url":"https://api.github.com/repos/snkutlu/firewall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snkutlu/firewall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snkutlu/firewall/teams","hooks_url":"https://api.github.com/repos/snkutlu/firewall/hooks","issue_events_url":"https://api.github.com/repos/snkutlu/firewall/issues/events{/number}","events_url":"https://api.github.com/repos/snkutlu/firewall/events","assignees_url":"https://api.github.com/repos/snkutlu/firewall/assignees{/user}","branches_url":"https://api.github.com/repos/snkutlu/firewall/branches{/branch}","tags_url":"https://api.github.com/repos/snkutlu/firewall/tags","blobs_url":"https://api.github.com/repos/snkutlu/firewall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snkutlu/firewall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snkutlu/firewall/git/refs{/sha}","trees_url":"https://api.github.com/repos/snkutlu/firewall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snkutlu/firewall/statuses/{sha}","languages_url":"https://api.github.com/repos/snkutlu/firewall/languages","stargazers_url":"https://api.github.com/repos/snkutlu/firewall/stargazers","contributors_url":"https://api.github.com/repos/snkutlu/firewall/contributors","subscribers_url":"https://api.github.com/repos/snkutlu/firewall/subscribers","subscription_url":"https://api.github.com/repos/snkutlu/firewall/subscription","commits_url":"https://api.github.com/repos/snkutlu/firewall/commits{/sha}","git_commits_url":"https://api.github.com/repos/snkutlu/firewall/git/commits{/sha}","comments_url":"https://api.github.com/repos/snkutlu/firewall/comments{/number}","issue_comment_url":"https://api.github.com/repos/snkutlu/firewall/issues/comments{/number}","contents_url":"https://api.github.com/repos/snkutlu/firewall/contents/{+path}","compare_url":"https://api.github.com/repos/snkutlu/firewall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snkutlu/firewall/merges","archive_url":"https://api.github.com/repos/snkutlu/firewall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snkutlu/firewall/downloads","issues_url":"https://api.github.com/repos/snkutlu/firewall/issues{/number}","pulls_url":"https://api.github.com/repos/snkutlu/firewall/pulls{/number}","milestones_url":"https://api.github.com/repos/snkutlu/firewall/milestones{/number}","notifications_url":"https://api.github.com/repos/snkutlu/firewall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snkutlu/firewall/labels{/name}","releases_url":"https://api.github.com/repos/snkutlu/firewall/releases{/id}","deployments_url":"https://api.github.com/repos/snkutlu/firewall/deployments","created_at":"2016-07-11T11:03:44Z","updated_at":"2016-07-11T11:03:46Z","pushed_at":"2016-08-24T15:12:33Z","git_url":"git://github.com/snkutlu/firewall.git","ssh_url":"git@github.com:snkutlu/firewall.git","clone_url":"https://github.com/snkutlu/firewall.git","svn_url":"https://github.com/snkutlu/firewall","homepage":"http://supermarket.chef.io/cookbooks/firewall","size":406,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"4aa07d71cdb0721d4a9879be54f01a4c8dbb8d4a","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720591,"name":"firewall","full_name":"chef-cookbooks/firewall","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/firewall","description":"Development repository for generic firewall cookbook","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/firewall","forks_url":"https://api.github.com/repos/chef-cookbooks/firewall/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/firewall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/firewall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/firewall/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/firewall/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/firewall/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/firewall/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/firewall/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/firewall/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/firewall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/firewall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/firewall/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/firewall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/firewall/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/firewall/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/firewall/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/firewall/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/firewall/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/firewall/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/firewall/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/firewall/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/firewall/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/firewall/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/firewall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/firewall/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/firewall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/firewall/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/firewall/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/firewall/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/firewall/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/firewall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/firewall/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/firewall/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/firewall/deployments","created_at":"2012-03-14T18:13:54Z","updated_at":"2016-10-23T17:22:12Z","pushed_at":"2016-10-26T08:19:42Z","git_url":"git://github.com/chef-cookbooks/firewall.git","ssh_url":"git@github.com:chef-cookbooks/firewall.git","clone_url":"https://github.com/chef-cookbooks/firewall.git","svn_url":"https://github.com/chef-cookbooks/firewall","homepage":"http://supermarket.chef.io/cookbooks/firewall","size":514,"stargazers_count":59,"watchers_count":59,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":9,"forks":119,"open_issues":9,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144"},"html":{"href":"https://github.com/chef-cookbooks/firewall/pull/144"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/issues/144"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/firewall/statuses/9e47af7a3d7c9ea51599db79487497d253ce073e"}}}}
{"actor":{"display_login":"martinb3"}}