{"action":"created","comment":{"url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/comments/70585520","id":70585520,"diff_hunk":"@@ -522,7 +522,12 @@ def load_nfp_modules(conf, controller):\n         modules_dir = base_module.__path__[0]\n         try:\n             files = os.listdir(modules_dir)\n-            for pyfile in set([f for f in files if f.endswith(\".py\")]):\n+            pyfiles = set([f for f in files if f.endswith(\".py\")])\n+            for pyfile in pyfiles:\n+                module_name = pyfile.strip('.py')\n+                nsd_module_name = module_name + '_NSD.py'","path":"gbpservice/nfp/core/controller.py","position":8,"original_position":8,"commit_id":"c654f7ef1d3cbd3d5dcc4ca393feaa5cf65da0de","original_commit_id":"c654f7ef1d3cbd3d5dcc4ca393feaa5cf65da0de","user":{"login":"mak-454","id":11626269,"avatar_url":"https://avatars.githubusercontent.com/u/11626269?v=3","gravatar_id":"","url":"https://api.github.com/users/mak-454","html_url":"https://github.com/mak-454","followers_url":"https://api.github.com/users/mak-454/followers","following_url":"https://api.github.com/users/mak-454/following{/other_user}","gists_url":"https://api.github.com/users/mak-454/gists{/gist_id}","starred_url":"https://api.github.com/users/mak-454/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mak-454/subscriptions","organizations_url":"https://api.github.com/users/mak-454/orgs","repos_url":"https://api.github.com/users/mak-454/repos","events_url":"https://api.github.com/users/mak-454/events{/privacy}","received_events_url":"https://api.github.com/users/mak-454/received_events","type":"User","site_admin":false},"body":"we want to skip _NSD.py here ?\r\ncan this file be put outside of 'modules/' folder ?","created_at":"2016-07-13T08:40:29Z","updated_at":"2016-07-13T08:40:29Z","html_url":"https://github.com/oneconvergence/group-based-policy/pull/494#discussion_r70585520","pull_request_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494","_links":{"self":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/comments/70585520"},"html":{"href":"https://github.com/oneconvergence/group-based-policy/pull/494#discussion_r70585520"},"pull_request":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494","id":77105522,"html_url":"https://github.com/oneconvergence/group-based-policy/pull/494","diff_url":"https://github.com/oneconvergence/group-based-policy/pull/494.diff","patch_url":"https://github.com/oneconvergence/group-based-policy/pull/494.patch","issue_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/494","number":494,"state":"open","locked":false,"title":"Orch enterprise split","user":{"login":"ashutosh-mishra","id":2832480,"avatar_url":"https://avatars.githubusercontent.com/u/2832480?v=3","gravatar_id":"","url":"https://api.github.com/users/ashutosh-mishra","html_url":"https://github.com/ashutosh-mishra","followers_url":"https://api.github.com/users/ashutosh-mishra/followers","following_url":"https://api.github.com/users/ashutosh-mishra/following{/other_user}","gists_url":"https://api.github.com/users/ashutosh-mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/ashutosh-mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashutosh-mishra/subscriptions","organizations_url":"https://api.github.com/users/ashutosh-mishra/orgs","repos_url":"https://api.github.com/users/ashutosh-mishra/repos","events_url":"https://api.github.com/users/ashutosh-mishra/events{/privacy}","received_events_url":"https://api.github.com/users/ashutosh-mishra/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-12T11:44:35Z","updated_at":"2016-07-13T08:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd1a4710b04bfcfa0688b4271befcaae6fb61003","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494/commits","review_comments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494/comments","review_comment_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/494/comments","statuses_url":"https://api.github.com/repos/oneconvergence/group-based-policy/statuses/c654f7ef1d3cbd3d5dcc4ca393feaa5cf65da0de","head":{"label":"oneconvergence:orch_enterprise_split","ref":"orch_enterprise_split","sha":"c654f7ef1d3cbd3d5dcc4ca393feaa5cf65da0de","user":{"login":"oneconvergence","id":8160602,"avatar_url":"https://avatars.githubusercontent.com/u/8160602?v=3","gravatar_id":"","url":"https://api.github.com/users/oneconvergence","html_url":"https://github.com/oneconvergence","followers_url":"https://api.github.com/users/oneconvergence/followers","following_url":"https://api.github.com/users/oneconvergence/following{/other_user}","gists_url":"https://api.github.com/users/oneconvergence/gists{/gist_id}","starred_url":"https://api.github.com/users/oneconvergence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneconvergence/subscriptions","organizations_url":"https://api.github.com/users/oneconvergence/orgs","repos_url":"https://api.github.com/users/oneconvergence/repos","events_url":"https://api.github.com/users/oneconvergence/events{/privacy}","received_events_url":"https://api.github.com/users/oneconvergence/received_events","type":"Organization","site_admin":false},"repo":{"id":34099604,"name":"group-based-policy","full_name":"oneconvergence/group-based-policy","owner":{"login":"oneconvergence","id":8160602,"avatar_url":"https://avatars.githubusercontent.com/u/8160602?v=3","gravatar_id":"","url":"https://api.github.com/users/oneconvergence","html_url":"https://github.com/oneconvergence","followers_url":"https://api.github.com/users/oneconvergence/followers","following_url":"https://api.github.com/users/oneconvergence/following{/other_user}","gists_url":"https://api.github.com/users/oneconvergence/gists{/gist_id}","starred_url":"https://api.github.com/users/oneconvergence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneconvergence/subscriptions","organizations_url":"https://api.github.com/users/oneconvergence/orgs","repos_url":"https://api.github.com/users/oneconvergence/repos","events_url":"https://api.github.com/users/oneconvergence/events{/privacy}","received_events_url":"https://api.github.com/users/oneconvergence/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oneconvergence/group-based-policy","description":"Group Based Policy","fork":true,"url":"https://api.github.com/repos/oneconvergence/group-based-policy","forks_url":"https://api.github.com/repos/oneconvergence/group-based-policy/forks","keys_url":"https://api.github.com/repos/oneconvergence/group-based-policy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oneconvergence/group-based-policy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oneconvergence/group-based-policy/teams","hooks_url":"https://api.github.com/repos/oneconvergence/group-based-policy/hooks","issue_events_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/events{/number}","events_url":"https://api.github.com/repos/oneconvergence/group-based-policy/events","assignees_url":"https://api.github.com/repos/oneconvergence/group-based-policy/assignees{/user}","branches_url":"https://api.github.com/repos/oneconvergence/group-based-policy/branches{/branch}","tags_url":"https://api.github.com/repos/oneconvergence/group-based-policy/tags","blobs_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/refs{/sha}","trees_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oneconvergence/group-based-policy/statuses/{sha}","languages_url":"https://api.github.com/repos/oneconvergence/group-based-policy/languages","stargazers_url":"https://api.github.com/repos/oneconvergence/group-based-policy/stargazers","contributors_url":"https://api.github.com/repos/oneconvergence/group-based-policy/contributors","subscribers_url":"https://api.github.com/repos/oneconvergence/group-based-policy/subscribers","subscription_url":"https://api.github.com/repos/oneconvergence/group-based-policy/subscription","commits_url":"https://api.github.com/repos/oneconvergence/group-based-policy/commits{/sha}","git_commits_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/commits{/sha}","comments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/comments{/number}","issue_comment_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/comments{/number}","contents_url":"https://api.github.com/repos/oneconvergence/group-based-policy/contents/{+path}","compare_url":"https://api.github.com/repos/oneconvergence/group-based-policy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oneconvergence/group-based-policy/merges","archive_url":"https://api.github.com/repos/oneconvergence/group-based-policy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oneconvergence/group-based-policy/downloads","issues_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues{/number}","pulls_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls{/number}","milestones_url":"https://api.github.com/repos/oneconvergence/group-based-policy/milestones{/number}","notifications_url":"https://api.github.com/repos/oneconvergence/group-based-policy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oneconvergence/group-based-policy/labels{/name}","releases_url":"https://api.github.com/repos/oneconvergence/group-based-policy/releases{/id}","deployments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/deployments","created_at":"2015-04-17T06:06:34Z","updated_at":"2016-03-09T19:50:22Z","pushed_at":"2016-07-13T08:38:09Z","git_url":"git://github.com/oneconvergence/group-based-policy.git","ssh_url":"git@github.com:oneconvergence/group-based-policy.git","clone_url":"https://github.com/oneconvergence/group-based-policy.git","svn_url":"https://github.com/oneconvergence/group-based-policy","homepage":"http://openstack.org","size":9150,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":26,"forks":4,"open_issues":26,"watchers":1,"default_branch":"oneconvergence_service_node_driver"}},"base":{"label":"oneconvergence:mitaka_21st_march_base","ref":"mitaka_21st_march_base","sha":"c52f6699181b68b0d94009d662ecd674dc9172c8","user":{"login":"oneconvergence","id":8160602,"avatar_url":"https://avatars.githubusercontent.com/u/8160602?v=3","gravatar_id":"","url":"https://api.github.com/users/oneconvergence","html_url":"https://github.com/oneconvergence","followers_url":"https://api.github.com/users/oneconvergence/followers","following_url":"https://api.github.com/users/oneconvergence/following{/other_user}","gists_url":"https://api.github.com/users/oneconvergence/gists{/gist_id}","starred_url":"https://api.github.com/users/oneconvergence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneconvergence/subscriptions","organizations_url":"https://api.github.com/users/oneconvergence/orgs","repos_url":"https://api.github.com/users/oneconvergence/repos","events_url":"https://api.github.com/users/oneconvergence/events{/privacy}","received_events_url":"https://api.github.com/users/oneconvergence/received_events","type":"Organization","site_admin":false},"repo":{"id":34099604,"name":"group-based-policy","full_name":"oneconvergence/group-based-policy","owner":{"login":"oneconvergence","id":8160602,"avatar_url":"https://avatars.githubusercontent.com/u/8160602?v=3","gravatar_id":"","url":"https://api.github.com/users/oneconvergence","html_url":"https://github.com/oneconvergence","followers_url":"https://api.github.com/users/oneconvergence/followers","following_url":"https://api.github.com/users/oneconvergence/following{/other_user}","gists_url":"https://api.github.com/users/oneconvergence/gists{/gist_id}","starred_url":"https://api.github.com/users/oneconvergence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oneconvergence/subscriptions","organizations_url":"https://api.github.com/users/oneconvergence/orgs","repos_url":"https://api.github.com/users/oneconvergence/repos","events_url":"https://api.github.com/users/oneconvergence/events{/privacy}","received_events_url":"https://api.github.com/users/oneconvergence/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oneconvergence/group-based-policy","description":"Group Based Policy","fork":true,"url":"https://api.github.com/repos/oneconvergence/group-based-policy","forks_url":"https://api.github.com/repos/oneconvergence/group-based-policy/forks","keys_url":"https://api.github.com/repos/oneconvergence/group-based-policy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oneconvergence/group-based-policy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oneconvergence/group-based-policy/teams","hooks_url":"https://api.github.com/repos/oneconvergence/group-based-policy/hooks","issue_events_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/events{/number}","events_url":"https://api.github.com/repos/oneconvergence/group-based-policy/events","assignees_url":"https://api.github.com/repos/oneconvergence/group-based-policy/assignees{/user}","branches_url":"https://api.github.com/repos/oneconvergence/group-based-policy/branches{/branch}","tags_url":"https://api.github.com/repos/oneconvergence/group-based-policy/tags","blobs_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/refs{/sha}","trees_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oneconvergence/group-based-policy/statuses/{sha}","languages_url":"https://api.github.com/repos/oneconvergence/group-based-policy/languages","stargazers_url":"https://api.github.com/repos/oneconvergence/group-based-policy/stargazers","contributors_url":"https://api.github.com/repos/oneconvergence/group-based-policy/contributors","subscribers_url":"https://api.github.com/repos/oneconvergence/group-based-policy/subscribers","subscription_url":"https://api.github.com/repos/oneconvergence/group-based-policy/subscription","commits_url":"https://api.github.com/repos/oneconvergence/group-based-policy/commits{/sha}","git_commits_url":"https://api.github.com/repos/oneconvergence/group-based-policy/git/commits{/sha}","comments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/comments{/number}","issue_comment_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/comments{/number}","contents_url":"https://api.github.com/repos/oneconvergence/group-based-policy/contents/{+path}","compare_url":"https://api.github.com/repos/oneconvergence/group-based-policy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oneconvergence/group-based-policy/merges","archive_url":"https://api.github.com/repos/oneconvergence/group-based-policy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oneconvergence/group-based-policy/downloads","issues_url":"https://api.github.com/repos/oneconvergence/group-based-policy/issues{/number}","pulls_url":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls{/number}","milestones_url":"https://api.github.com/repos/oneconvergence/group-based-policy/milestones{/number}","notifications_url":"https://api.github.com/repos/oneconvergence/group-based-policy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oneconvergence/group-based-policy/labels{/name}","releases_url":"https://api.github.com/repos/oneconvergence/group-based-policy/releases{/id}","deployments_url":"https://api.github.com/repos/oneconvergence/group-based-policy/deployments","created_at":"2015-04-17T06:06:34Z","updated_at":"2016-03-09T19:50:22Z","pushed_at":"2016-07-13T08:38:09Z","git_url":"git://github.com/oneconvergence/group-based-policy.git","ssh_url":"git@github.com:oneconvergence/group-based-policy.git","clone_url":"https://github.com/oneconvergence/group-based-policy.git","svn_url":"https://github.com/oneconvergence/group-based-policy","homepage":"http://openstack.org","size":9150,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":26,"forks":4,"open_issues":26,"watchers":1,"default_branch":"oneconvergence_service_node_driver"}},"_links":{"self":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494"},"html":{"href":"https://github.com/oneconvergence/group-based-policy/pull/494"},"issue":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/494"},"comments":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/oneconvergence/group-based-policy/statuses/c654f7ef1d3cbd3d5dcc4ca393feaa5cf65da0de"}}}}
{"actor":{"display_login":"mak-454"}}