{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/88980762","pull_request_review_id":9535235,"id":88980762,"diff_hunk":"@@ -800,14 +800,33 @@ class LogFormatter(Formatter):\n     \"\"\"\n     Format values for log axis.\n     \"\"\"\n-    def __init__(self, base=10.0, labelOnlyBase=True):\n+    def __init__(self, base=10.0, labelOnlyBase=False,\n+                 minor_thresholds=(1, 0.4)):\n         \"\"\"\n         `base` is used to locate the decade tick, which will be the only\n         one to be labeled if `labelOnlyBase` is ``True``.\n+\n+        Parameters\n+        ----------\n+        base : float, optional, default: 10.\n+            base of the logarithm.\n+\n+        labelOnlyBase : bool, optional, default: False\n+            whether label ticks only at integer multiples of base.","path":"lib/matplotlib/ticker.py","position":17,"original_position":17,"commit_id":"95f0501d6838d2c78d0be6f96dbb94e1e790b5c5","original_commit_id":"95f0501d6838d2c78d0be6f96dbb94e1e790b5c5","user":{"login":"dopplershift","id":221526,"avatar_url":"https://avatars.githubusercontent.com/u/221526?v=3","gravatar_id":"","url":"https://api.github.com/users/dopplershift","html_url":"https://github.com/dopplershift","followers_url":"https://api.github.com/users/dopplershift/followers","following_url":"https://api.github.com/users/dopplershift/following{/other_user}","gists_url":"https://api.github.com/users/dopplershift/gists{/gist_id}","starred_url":"https://api.github.com/users/dopplershift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dopplershift/subscriptions","organizations_url":"https://api.github.com/users/dopplershift/orgs","repos_url":"https://api.github.com/users/dopplershift/repos","events_url":"https://api.github.com/users/dopplershift/events{/privacy}","received_events_url":"https://api.github.com/users/dopplershift/received_events","type":"User","site_admin":false},"body":"\"multiples\" -> \"powers\"","created_at":"2016-11-21T20:27:10Z","updated_at":"2016-11-21T20:48:43Z","html_url":"https://github.com/matplotlib/matplotlib/pull/7438#discussion_r88980762","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/88980762"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7438#discussion_r88980762"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438","id":93205821,"html_url":"https://github.com/matplotlib/matplotlib/pull/7438","diff_url":"https://github.com/matplotlib/matplotlib/pull/7438.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/7438.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7438","number":7438,"state":"open","locked":false,"title":"[MRG] ENH ticks sublabel display is now an option","user":{"login":"NelleV","id":184798,"avatar_url":"https://avatars.githubusercontent.com/u/184798?v=3","gravatar_id":"","url":"https://api.github.com/users/NelleV","html_url":"https://github.com/NelleV","followers_url":"https://api.github.com/users/NelleV/followers","following_url":"https://api.github.com/users/NelleV/following{/other_user}","gists_url":"https://api.github.com/users/NelleV/gists{/gist_id}","starred_url":"https://api.github.com/users/NelleV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NelleV/subscriptions","organizations_url":"https://api.github.com/users/NelleV/orgs","repos_url":"https://api.github.com/users/NelleV/repos","events_url":"https://api.github.com/users/NelleV/events{/privacy}","received_events_url":"https://api.github.com/users/NelleV/received_events","type":"User","site_admin":false},"body":"This is work in progress.\r\n\r\nfixes #7202 and supersedes #7211 \r\n\r\nHere how the defaults behave:\r\n\r\n![symlog](https://cloud.githubusercontent.com/assets/184798/20190843/f08209c6-a737-11e6-910f-44f5f378dae5.png)\r\n\r\nUsing the formatter's directly yields the expected behaviour, even on colorbar:\r\n![log_colorbar_default](https://cloud.githubusercontent.com/assets/184798/20191290/af6f11de-a739-11e6-8391-f4fd63a94bd0.png)\r\n\r\nHere is the code to reproduce those plots:\r\n\r\n```python\r\nimport numpy as np\r\nimport matplotlib.pyplot as plt\r\n\r\nX_1 = np.random.randint(12000, 90000, size=(1000,))\r\nX_1.sort()\r\nX_2 = np.random.randint(1e5, 1e12, size=(1000,))\r\nX_2.sort()\r\nX_3 = np.random.randint(1e5, 1e16, size=(1000,))\r\nX_3.sort()\r\n\r\nX = [X_1, X_2, X_3]\r\n\r\nfig, ax = plt.subplots(ncols=len(X), figsize=(12, 6))\r\nfor i, x in enumerate(X):\r\n    ax[i].plot(x)\r\n    ax[i].set_yscale(\"log\")\r\n ```\r\n\r\n```python\r\nimport numpy as np\r\n\r\nimport matplotlib.pyplot as plt\r\nfrom matplotlib import ticker, colors\r\n\r\nX_1 = -np.random.randint(10000, 90000, size=(100, 100))\r\nX_2 = np.random.randint(10000, 1000000, size=(100, 100))\r\n\r\nformatter = ticker.LogFormatter(\r\n    10)\r\nsciformatter = ticker.LogFormatterSciNotation(\r\n    10)\r\n\r\nX = [X_1, X_2]\r\n\r\nfig, axes = plt.subplots(ncols=2, nrows=2, figsize=(10, 10))\r\nfor i, x in enumerate(X):\r\n    ax = axes[0, i]\r\n    m = ax.imshow(x, norm=colors.SymLogNorm(1))\r\n    ax.set_title(\"Log Formatter\")\r\n\r\n    cb = fig.colorbar(m, format=formatter, ax=ax, shrink=0.9, )\r\n    ax = axes[1, i]\r\n    m = ax.imshow(x, norm=colors.SymLogNorm(1))\r\n    ax.set_title(\"Log Formatter Sci\")\r\n    cb = fig.colorbar(m, format=sciformatter, ax=ax, shrink=0.9, )\r\n```\r\n\r\n\r\n\r\n","created_at":"2016-11-10T18:34:35Z","updated_at":"2016-11-21T20:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"110b42b80695ae2870647903a1b534e1fa3da015","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.0%20(style%20change%20major%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/14/labels","id":662004,"number":14,"title":"2.0 (style change major release)","description":"Style changes only","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":640,"state":"open","created_at":"2014-05-17T14:28:22Z","updated_at":"2016-11-21T20:18:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/7438/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/95f0501d6838d2c78d0be6f96dbb94e1e790b5c5","head":{"label":"NelleV:7202_symlog_colorbar_","ref":"7202_symlog_colorbar_","sha":"95f0501d6838d2c78d0be6f96dbb94e1e790b5c5","user":{"login":"NelleV","id":184798,"avatar_url":"https://avatars.githubusercontent.com/u/184798?v=3","gravatar_id":"","url":"https://api.github.com/users/NelleV","html_url":"https://github.com/NelleV","followers_url":"https://api.github.com/users/NelleV/followers","following_url":"https://api.github.com/users/NelleV/following{/other_user}","gists_url":"https://api.github.com/users/NelleV/gists{/gist_id}","starred_url":"https://api.github.com/users/NelleV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NelleV/subscriptions","organizations_url":"https://api.github.com/users/NelleV/orgs","repos_url":"https://api.github.com/users/NelleV/repos","events_url":"https://api.github.com/users/NelleV/events{/privacy}","received_events_url":"https://api.github.com/users/NelleV/received_events","type":"User","site_admin":false},"repo":{"id":5577200,"name":"matplotlib","full_name":"NelleV/matplotlib","owner":{"login":"NelleV","id":184798,"avatar_url":"https://avatars.githubusercontent.com/u/184798?v=3","gravatar_id":"","url":"https://api.github.com/users/NelleV","html_url":"https://github.com/NelleV","followers_url":"https://api.github.com/users/NelleV/followers","following_url":"https://api.github.com/users/NelleV/following{/other_user}","gists_url":"https://api.github.com/users/NelleV/gists{/gist_id}","starred_url":"https://api.github.com/users/NelleV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NelleV/subscriptions","organizations_url":"https://api.github.com/users/NelleV/orgs","repos_url":"https://api.github.com/users/NelleV/repos","events_url":"https://api.github.com/users/NelleV/events{/privacy}","received_events_url":"https://api.github.com/users/NelleV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NelleV/matplotlib","description":null,"fork":true,"url":"https://api.github.com/repos/NelleV/matplotlib","forks_url":"https://api.github.com/repos/NelleV/matplotlib/forks","keys_url":"https://api.github.com/repos/NelleV/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NelleV/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NelleV/matplotlib/teams","hooks_url":"https://api.github.com/repos/NelleV/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/NelleV/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/NelleV/matplotlib/events","assignees_url":"https://api.github.com/repos/NelleV/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/NelleV/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/NelleV/matplotlib/tags","blobs_url":"https://api.github.com/repos/NelleV/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NelleV/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NelleV/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/NelleV/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NelleV/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/NelleV/matplotlib/languages","stargazers_url":"https://api.github.com/repos/NelleV/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/NelleV/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/NelleV/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/NelleV/matplotlib/subscription","commits_url":"https://api.github.com/repos/NelleV/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/NelleV/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/NelleV/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/NelleV/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/NelleV/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/NelleV/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NelleV/matplotlib/merges","archive_url":"https://api.github.com/repos/NelleV/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NelleV/matplotlib/downloads","issues_url":"https://api.github.com/repos/NelleV/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/NelleV/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/NelleV/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/NelleV/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NelleV/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/NelleV/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/NelleV/matplotlib/deployments","created_at":"2012-08-27T21:14:58Z","updated_at":"2015-02-17T09:16:29Z","pushed_at":"2016-11-16T22:56:46Z","git_url":"git://github.com/NelleV/matplotlib.git","ssh_url":"git@github.com:NelleV/matplotlib.git","clone_url":"https://github.com/NelleV/matplotlib.git","svn_url":"https://github.com/NelleV/matplotlib","homepage":"","size":290699,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:v2.x","ref":"v2.x","sha":"f87100a02b4baa88ba399914743a45a05edf8429","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2016-11-21T20:38:50Z","pushed_at":"2016-11-21T20:18:55Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":405642,"stargazers_count":4362,"watchers_count":4362,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2145,"mirror_url":null,"open_issues_count":1046,"forks":2145,"open_issues":1046,"watchers":4362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/7438"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7438"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/7438/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/7438/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/95f0501d6838d2c78d0be6f96dbb94e1e790b5c5"}}}}
{"actor":{"display_login":"dopplershift"}}