{"action":"created","issue":{"url":"https://api.github.com/repos/SFML/SFML/issues/1103","repository_url":"https://api.github.com/repos/SFML/SFML","labels_url":"https://api.github.com/repos/SFML/SFML/issues/1103/labels{/name}","comments_url":"https://api.github.com/repos/SFML/SFML/issues/1103/comments","events_url":"https://api.github.com/repos/SFML/SFML/issues/1103/events","html_url":"https://github.com/SFML/SFML/pull/1103","id":161197199,"number":1103,"title":"No need to check *_FOUND because REQUIRED already specified","user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-20T13:39:13Z","updated_at":"2016-06-21T05:18:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SFML/SFML/pulls/1103","html_url":"https://github.com/SFML/SFML/pull/1103","diff_url":"https://github.com/SFML/SFML/pull/1103.diff","patch_url":"https://github.com/SFML/SFML/pull/1103.patch"},"body":"When REQUIRED used in find_package there is no need to check *_FOUND\r\nvariable since processing already will stop with error.\r\n\r\nFrom documentation (https://cmake.org/cmake/help/v2.8.3/cmake.html#command:find_package):\r\n\r\n  The REQUIRED option stops processing with an error message if the package cannot be found."},"comment":{"url":"https://api.github.com/repos/SFML/SFML/issues/comments/227342853","html_url":"https://github.com/SFML/SFML/pull/1103#issuecomment-227342853","issue_url":"https://api.github.com/repos/SFML/SFML/issues/1103","id":227342853,"user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T05:18:07Z","updated_at":"2016-06-21T05:18:07Z","body":"one... two... three... deep breath...\r\n\r\n\r\n> So you remove nine, add two lines\r\n\r\n> If you had written a brand new part of SFML we could leave your name in the copyright, but not here\r\n\r\n> For such a small change there is absolutely no reason to write a copyright notice, especially when you only added a small piece of functionality (arguably a bugfix)\r\n\r\nAgain I don't see what is the difference between writing small module about 100 lines or removing 2 lines of code - it's work, I spent my fucking time to solve problems in your code. If you have any kind of respect to developers please never mention such stupid arguments.\r\n\r\n> If you're part of the copyright, it means that we can't modify this whole file\r\n\r\nI'm not a lawyer but as far as I know this copyright note (or absent of that!) literally means nothing until somebody sign some papers digitally or physically. Anyway that is something that you should care about, not me. I don't give a fuck, really.\r\n\r\nOne more time `I just add my name (feel free to add yours). That's what I usually do`, I did it for:\r\n* [Qt](https://github.com/qtproject/qtmultimedia/blob/579a7d620284c277966e590518374aefa141c481/src/plugins/android/src/mediacapture/qandroidviewfindersettingscontrol.h#L4)\r\n* [Boost](https://github.com/boostorg/thread/blob/382ac5a4269045fc5431c2f445c430f10f5b0420/include/boost/thread/with_lock_guard.hpp#L1)\r\n* [spdlog](https://github.com/gabime/spdlog/blob/cef7eb0667d998ace38e5f5122805107f22b5042/CMakeLists.txt#L2)\r\n* or even [CMake itself](https://github.com/Kitware/CMake/blob/7d2a0aa76c25d92f1e2a03778f5666bdd7e56b92/Source/cmFileLock.h#L3)\r\n\r\nI think that this talking can be continued for:\r\n* we can discuss technical details of pull request\r\n* I can update copyright notice in any form you think it will be better\r\n\r\nAny other discussion make no sense to me. You have enough courage to start this crap, please have enough courage to close this pull request yourself.\r\n\r\nCheers, Ruslo"}}
{"actor":{"display_login":"ruslo"}}