{"action":"closed","issue":{"url":"https://api.github.com/repos/cognoma/machine-learning/issues/57","repository_url":"https://api.github.com/repos/cognoma/machine-learning","labels_url":"https://api.github.com/repos/cognoma/machine-learning/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/cognoma/machine-learning/issues/57/comments","events_url":"https://api.github.com/repos/cognoma/machine-learning/issues/57/events","html_url":"https://github.com/cognoma/machine-learning/issues/57","id":182416996,"number":57,"title":"Fix cognoml package","user":{"login":"awm33","id":3846080,"avatar_url":"https://avatars.githubusercontent.com/u/3846080?v=3","gravatar_id":"","url":"https://api.github.com/users/awm33","html_url":"https://github.com/awm33","followers_url":"https://api.github.com/users/awm33/followers","following_url":"https://api.github.com/users/awm33/following{/other_user}","gists_url":"https://api.github.com/users/awm33/gists{/gist_id}","starred_url":"https://api.github.com/users/awm33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awm33/subscriptions","organizations_url":"https://api.github.com/users/awm33/orgs","repos_url":"https://api.github.com/users/awm33/repos","events_url":"https://api.github.com/users/awm33/events{/privacy}","received_events_url":"https://api.github.com/users/awm33/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-12T02:01:40Z","updated_at":"2016-10-25T01:03:47Z","closed_at":"2016-10-25T01:03:47Z","body":"Trying to run the cognoml package, I found a couple issues.\r\n\r\n- The requirements are not in setup.py, so a consumer has to manually install them. I manually installed them by looking at the repo's environment.yml file. The following were needed before the next issue was raised.\r\n    - pandas==0.18.1\r\n    - numpy==1.11.1\r\n    - scikit-learn==0.18.0\r\n    - scipy==0.17.1\r\n\r\n    Take a look at [https://packaging.python.org/requirements/](https://packaging.python.org/requirements/)\r\n\r\n- Looks like cogoml.classifiers is not included in the package\r\n\r\n```\r\n>>> from cognoml analysis\r\n  File \"<stdin>\", line 1\r\n    from cognoml analysis\r\n                        ^\r\nSyntaxError: invalid syntax\r\n>>> from cognoml import analysis\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\n  File \"/Users/amadonna/Documents/ml-workers/env/lib/python3.5/site-packages/cognoml/analysis.py\", line 11, in <module>\r\n    from cognoml.classifiers.logistic_regression import grid_search\r\nImportError: No module named 'cognoml.classifiers'\r\n```\r\nMight have to be included [here](https://github.com/cognoma/machine-learning/blob/master/setup.py#L48).\r\n\r\nI'd suggest testing the module in a clean environment.\r\n\r\nInstalled using `pip install git+git://github.com/cognoma/machine-learning`"}}
{"actor":{"display_login":"dhimmel"}}