{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/etcd/pulls/comments/69381181","id":69381181,"diff_hunk":"@@ -102,7 +102,7 @@ func getClusterFromRemotePeers(urls []string, timeout time.Duration, logerr bool\n // getRemotePeerURLs returns peer urls of remote members in the cluster. The\n // returned list is sorted in ascending lexicographical order.\n func getRemotePeerURLs(cl *membership.RaftCluster, local string) []string {\n-\tus := make([]string, 0)\n+\tvar us []string","path":"etcdserver/cluster_util.go","position":5,"original_position":5,"commit_id":"ad1c945b5265ae4e87cafc9ef3bf48426ac86a80","original_commit_id":"ad1c945b5265ae4e87cafc9ef3bf48426ac86a80","user":{"login":"gyuho","id":6799218,"avatar_url":"https://avatars.githubusercontent.com/u/6799218?v=3","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"body":"`var us []string` is nil, but `us := make([]string, 0)` is not.\r\n\r\nWe need to fix the test too.\r\n","created_at":"2016-07-02T18:16:09Z","updated_at":"2016-07-02T18:16:09Z","html_url":"https://github.com/coreos/etcd/pull/5853#discussion_r69381181","pull_request_url":"https://api.github.com/repos/coreos/etcd/pulls/5853","_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments/69381181"},"html":{"href":"https://github.com/coreos/etcd/pull/5853#discussion_r69381181"},"pull_request":{"href":"https://api.github.com/repos/coreos/etcd/pulls/5853"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/5853","id":76064600,"html_url":"https://github.com/coreos/etcd/pull/5853","diff_url":"https://github.com/coreos/etcd/pull/5853.diff","patch_url":"https://github.com/coreos/etcd/pull/5853.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/5853","number":5853,"state":"open","locked":false,"title":"etcdserver: check code style","user":{"login":"davygeek","id":12783140,"avatar_url":"https://avatars.githubusercontent.com/u/12783140?v=3","gravatar_id":"","url":"https://api.github.com/users/davygeek","html_url":"https://github.com/davygeek","followers_url":"https://api.github.com/users/davygeek/followers","following_url":"https://api.github.com/users/davygeek/following{/other_user}","gists_url":"https://api.github.com/users/davygeek/gists{/gist_id}","starred_url":"https://api.github.com/users/davygeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davygeek/subscriptions","organizations_url":"https://api.github.com/users/davygeek/orgs","repos_url":"https://api.github.com/users/davygeek/repos","events_url":"https://api.github.com/users/davygeek/events{/privacy}","received_events_url":"https://api.github.com/users/davygeek/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-02T13:03:12Z","updated_at":"2016-07-02T18:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89205e7118d8c3a356291e8d0e707a00ce666732","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/5853/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/5853/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/5853/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/ad1c945b5265ae4e87cafc9ef3bf48426ac86a80","head":{"label":"davygeek:checketcdserver","ref":"checketcdserver","sha":"ad1c945b5265ae4e87cafc9ef3bf48426ac86a80","user":{"login":"davygeek","id":12783140,"avatar_url":"https://avatars.githubusercontent.com/u/12783140?v=3","gravatar_id":"","url":"https://api.github.com/users/davygeek","html_url":"https://github.com/davygeek","followers_url":"https://api.github.com/users/davygeek/followers","following_url":"https://api.github.com/users/davygeek/following{/other_user}","gists_url":"https://api.github.com/users/davygeek/gists{/gist_id}","starred_url":"https://api.github.com/users/davygeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davygeek/subscriptions","organizations_url":"https://api.github.com/users/davygeek/orgs","repos_url":"https://api.github.com/users/davygeek/repos","events_url":"https://api.github.com/users/davygeek/events{/privacy}","received_events_url":"https://api.github.com/users/davygeek/received_events","type":"User","site_admin":false},"repo":{"id":56165933,"name":"etcd","full_name":"davygeek/etcd","owner":{"login":"davygeek","id":12783140,"avatar_url":"https://avatars.githubusercontent.com/u/12783140?v=3","gravatar_id":"","url":"https://api.github.com/users/davygeek","html_url":"https://github.com/davygeek","followers_url":"https://api.github.com/users/davygeek/followers","following_url":"https://api.github.com/users/davygeek/following{/other_user}","gists_url":"https://api.github.com/users/davygeek/gists{/gist_id}","starred_url":"https://api.github.com/users/davygeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davygeek/subscriptions","organizations_url":"https://api.github.com/users/davygeek/orgs","repos_url":"https://api.github.com/users/davygeek/repos","events_url":"https://api.github.com/users/davygeek/events{/privacy}","received_events_url":"https://api.github.com/users/davygeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davygeek/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/davygeek/etcd","forks_url":"https://api.github.com/repos/davygeek/etcd/forks","keys_url":"https://api.github.com/repos/davygeek/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davygeek/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davygeek/etcd/teams","hooks_url":"https://api.github.com/repos/davygeek/etcd/hooks","issue_events_url":"https://api.github.com/repos/davygeek/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/davygeek/etcd/events","assignees_url":"https://api.github.com/repos/davygeek/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/davygeek/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/davygeek/etcd/tags","blobs_url":"https://api.github.com/repos/davygeek/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davygeek/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davygeek/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/davygeek/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davygeek/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/davygeek/etcd/languages","stargazers_url":"https://api.github.com/repos/davygeek/etcd/stargazers","contributors_url":"https://api.github.com/repos/davygeek/etcd/contributors","subscribers_url":"https://api.github.com/repos/davygeek/etcd/subscribers","subscription_url":"https://api.github.com/repos/davygeek/etcd/subscription","commits_url":"https://api.github.com/repos/davygeek/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/davygeek/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/davygeek/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/davygeek/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/davygeek/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/davygeek/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davygeek/etcd/merges","archive_url":"https://api.github.com/repos/davygeek/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davygeek/etcd/downloads","issues_url":"https://api.github.com/repos/davygeek/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/davygeek/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/davygeek/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/davygeek/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davygeek/etcd/labels{/name}","releases_url":"https://api.github.com/repos/davygeek/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/davygeek/etcd/deployments","created_at":"2016-04-13T15:55:58Z","updated_at":"2016-04-13T15:56:07Z","pushed_at":"2016-07-02T13:02:35Z","git_url":"git://github.com/davygeek/etcd.git","ssh_url":"git@github.com:davygeek/etcd.git","clone_url":"https://github.com/davygeek/etcd.git","svn_url":"https://github.com/davygeek/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":22029,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"7cc4596ebd796f82843c2b43cc9777ab52c80604","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-07-02T16:01:49Z","pushed_at":"2016-07-02T18:05:36Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":28704,"stargazers_count":10101,"watchers_count":10101,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1701,"mirror_url":null,"open_issues_count":130,"forks":1701,"open_issues":130,"watchers":10101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/5853"},"html":{"href":"https://github.com/coreos/etcd/pull/5853"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/5853"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/5853/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/5853/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/5853/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/ad1c945b5265ae4e87cafc9ef3bf48426ac86a80"}}}}
{"actor":{"display_login":"gyuho"}}