{"action":"created","comment":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments/79578859","id":79578859,"diff_hunk":"@@ -0,0 +1,52 @@\n+/*\n+ * Copyright Terracotta, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.terracotta.runnel;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+/**\n+ * @author Ludovic Orban\n+ */\n+public class EnmBuilder<E extends Enum<E>> {\n+\n+  private final Map<E, Integer> enumToInteger = new HashMap<E, Integer>();","path":"runnel/src/main/java/org/terracotta/runnel/EnmBuilder.java","position":26,"original_position":26,"commit_id":"16baff2e96bac54e095371ac20907a2141a26db7","original_commit_id":"29d1248c493eacf53f168f840f807f410b10b9b5","user":{"login":"ChrisGreenaway","id":20089496,"avatar_url":"https://avatars.githubusercontent.com/u/20089496?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisGreenaway","html_url":"https://github.com/ChrisGreenaway","followers_url":"https://api.github.com/users/ChrisGreenaway/followers","following_url":"https://api.github.com/users/ChrisGreenaway/following{/other_user}","gists_url":"https://api.github.com/users/ChrisGreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisGreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisGreenaway/subscriptions","organizations_url":"https://api.github.com/users/ChrisGreenaway/orgs","repos_url":"https://api.github.com/users/ChrisGreenaway/repos","events_url":"https://api.github.com/users/ChrisGreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisGreenaway/received_events","type":"User","site_admin":false},"body":"EnumMap would be faster.","created_at":"2016-09-20T10:22:07Z","updated_at":"2016-09-20T10:29:18Z","html_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151#discussion_r79578859","pull_request_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments/79578859"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151#discussion_r79578859"},"pull_request":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151","id":85575832,"html_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151","diff_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151.diff","patch_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151.patch","issue_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/151","number":151,"state":"open","locked":false,"title":"marshalling lib with basic feature set","user":{"login":"lorban","id":622925,"avatar_url":"https://avatars.githubusercontent.com/u/622925?v=3","gravatar_id":"","url":"https://api.github.com/users/lorban","html_url":"https://github.com/lorban","followers_url":"https://api.github.com/users/lorban/followers","following_url":"https://api.github.com/users/lorban/following{/other_user}","gists_url":"https://api.github.com/users/lorban/gists{/gist_id}","starred_url":"https://api.github.com/users/lorban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorban/subscriptions","organizations_url":"https://api.github.com/users/lorban/orgs","repos_url":"https://api.github.com/users/lorban/repos","events_url":"https://api.github.com/users/lorban/events{/privacy}","received_events_url":"https://api.github.com/users/lorban/received_events","type":"User","site_admin":false},"body":"This is the (un-)marshalling lib we're going to use to write codecs. At this moment, it supports the following types: int32, int64, ByteBuffer, String, array and structures but more will come (double, enums...) and can easily be added.","created_at":"2016-09-16T13:44:49Z","updated_at":"2016-09-20T10:29:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6329d79ec18533f7c76895768d6b6df2e231505b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151/commits","review_comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151/comments","review_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/151/comments","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/16baff2e96bac54e095371ac20907a2141a26db7","head":{"label":"lorban:runnel","ref":"runnel","sha":"16baff2e96bac54e095371ac20907a2141a26db7","user":{"login":"lorban","id":622925,"avatar_url":"https://avatars.githubusercontent.com/u/622925?v=3","gravatar_id":"","url":"https://api.github.com/users/lorban","html_url":"https://github.com/lorban","followers_url":"https://api.github.com/users/lorban/followers","following_url":"https://api.github.com/users/lorban/following{/other_user}","gists_url":"https://api.github.com/users/lorban/gists{/gist_id}","starred_url":"https://api.github.com/users/lorban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorban/subscriptions","organizations_url":"https://api.github.com/users/lorban/orgs","repos_url":"https://api.github.com/users/lorban/repos","events_url":"https://api.github.com/users/lorban/events{/privacy}","received_events_url":"https://api.github.com/users/lorban/received_events","type":"User","site_admin":false},"repo":{"id":56497768,"name":"terracotta-platform","full_name":"lorban/terracotta-platform","owner":{"login":"lorban","id":622925,"avatar_url":"https://avatars.githubusercontent.com/u/622925?v=3","gravatar_id":"","url":"https://api.github.com/users/lorban","html_url":"https://github.com/lorban","followers_url":"https://api.github.com/users/lorban/followers","following_url":"https://api.github.com/users/lorban/following{/other_user}","gists_url":"https://api.github.com/users/lorban/gists{/gist_id}","starred_url":"https://api.github.com/users/lorban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorban/subscriptions","organizations_url":"https://api.github.com/users/lorban/orgs","repos_url":"https://api.github.com/users/lorban/repos","events_url":"https://api.github.com/users/lorban/events{/privacy}","received_events_url":"https://api.github.com/users/lorban/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorban/terracotta-platform","description":"","fork":true,"url":"https://api.github.com/repos/lorban/terracotta-platform","forks_url":"https://api.github.com/repos/lorban/terracotta-platform/forks","keys_url":"https://api.github.com/repos/lorban/terracotta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorban/terracotta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorban/terracotta-platform/teams","hooks_url":"https://api.github.com/repos/lorban/terracotta-platform/hooks","issue_events_url":"https://api.github.com/repos/lorban/terracotta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/lorban/terracotta-platform/events","assignees_url":"https://api.github.com/repos/lorban/terracotta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/lorban/terracotta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/lorban/terracotta-platform/tags","blobs_url":"https://api.github.com/repos/lorban/terracotta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorban/terracotta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorban/terracotta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorban/terracotta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorban/terracotta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/lorban/terracotta-platform/languages","stargazers_url":"https://api.github.com/repos/lorban/terracotta-platform/stargazers","contributors_url":"https://api.github.com/repos/lorban/terracotta-platform/contributors","subscribers_url":"https://api.github.com/repos/lorban/terracotta-platform/subscribers","subscription_url":"https://api.github.com/repos/lorban/terracotta-platform/subscription","commits_url":"https://api.github.com/repos/lorban/terracotta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorban/terracotta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorban/terracotta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorban/terracotta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorban/terracotta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/lorban/terracotta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorban/terracotta-platform/merges","archive_url":"https://api.github.com/repos/lorban/terracotta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorban/terracotta-platform/downloads","issues_url":"https://api.github.com/repos/lorban/terracotta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/lorban/terracotta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/lorban/terracotta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/lorban/terracotta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorban/terracotta-platform/labels{/name}","releases_url":"https://api.github.com/repos/lorban/terracotta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/lorban/terracotta-platform/deployments","created_at":"2016-04-18T10:12:02Z","updated_at":"2016-04-18T10:12:04Z","pushed_at":"2016-09-20T10:27:16Z","git_url":"git://github.com/lorban/terracotta-platform.git","ssh_url":"git@github.com:lorban/terracotta-platform.git","clone_url":"https://github.com/lorban/terracotta-platform.git","svn_url":"https://github.com/lorban/terracotta-platform","homepage":"http://terracotta.org","size":1235,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Terracotta-OSS:master","ref":"master","sha":"71703c1da56139134af797d604d96ab0625890ef","user":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"repo":{"id":44253742,"name":"terracotta-platform","full_name":"Terracotta-OSS/terracotta-platform","owner":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terracotta-OSS/terracotta-platform","description":"","fork":false,"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform","forks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/forks","keys_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/teams","hooks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/hooks","issue_events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/events","assignees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/tags","blobs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/languages","stargazers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/stargazers","contributors_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/contributors","subscribers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/subscribers","subscription_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/subscription","commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/merges","archive_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/downloads","issues_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/labels{/name}","releases_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/deployments","created_at":"2015-10-14T14:37:13Z","updated_at":"2016-08-29T05:44:20Z","pushed_at":"2016-09-20T10:27:16Z","git_url":"git://github.com/Terracotta-OSS/terracotta-platform.git","ssh_url":"git@github.com:Terracotta-OSS/terracotta-platform.git","clone_url":"https://github.com/Terracotta-OSS/terracotta-platform.git","svn_url":"https://github.com/Terracotta-OSS/terracotta-platform","homepage":"http://terracotta.org","size":1396,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-platform/pull/151"},"issue":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/151"},"comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/16baff2e96bac54e095371ac20907a2141a26db7"}}}}
{"actor":{"display_login":"ChrisGreenaway"}}