{"action":"created","comment":{"url":"https://api.github.com/repos/alexbrainman/odbc/pulls/comments/65006207","id":65006207,"diff_hunk":"@@ -101,7 +101,6 @@ func NewColumn(h api.SQLHSTMT, idx int) (Column, error) {\n \tdefault:\n \t\treturn nil, fmt.Errorf(\"unsupported column type %d\", sqltype)\n \t}\n-\tpanic(\"unreachable\")","path":"column.go","position":4,"original_position":4,"commit_id":"57530d816e667ae97413a38a2f27436cc5c12631","original_commit_id":"80c96ad5a6a58cc9c573344805d6dfdedd7abe16","user":{"login":"alexbrainman","id":9796621,"avatar_url":"https://avatars.githubusercontent.com/u/9796621?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbrainman","html_url":"https://github.com/alexbrainman","followers_url":"https://api.github.com/users/alexbrainman/followers","following_url":"https://api.github.com/users/alexbrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexbrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrainman/subscriptions","organizations_url":"https://api.github.com/users/alexbrainman/orgs","repos_url":"https://api.github.com/users/alexbrainman/repos","events_url":"https://api.github.com/users/alexbrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrainman/received_events","type":"User","site_admin":false},"body":"Drop this change. This panic was inserted for a reason - Go compiler used to complain about \"no return statement\". So people who use old versions of Go will have problem compiling this code. This code hurts no one.","created_at":"2016-05-29T14:50:31Z","updated_at":"2016-05-29T14:50:31Z","html_url":"https://github.com/alexbrainman/odbc/pull/69#discussion_r65006207","pull_request_url":"https://api.github.com/repos/alexbrainman/odbc/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/comments/65006207"},"html":{"href":"https://github.com/alexbrainman/odbc/pull/69#discussion_r65006207"},"pull_request":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/alexbrainman/odbc/pulls/69","id":71818714,"html_url":"https://github.com/alexbrainman/odbc/pull/69","diff_url":"https://github.com/alexbrainman/odbc/pull/69.diff","patch_url":"https://github.com/alexbrainman/odbc/pull/69.patch","issue_url":"https://api.github.com/repos/alexbrainman/odbc/issues/69","number":69,"state":"open","locked":false,"title":"Minor cleanup","user":{"login":"judwhite","id":729716,"avatar_url":"https://avatars.githubusercontent.com/u/729716?v=3","gravatar_id":"","url":"https://api.github.com/users/judwhite","html_url":"https://github.com/judwhite","followers_url":"https://api.github.com/users/judwhite/followers","following_url":"https://api.github.com/users/judwhite/following{/other_user}","gists_url":"https://api.github.com/users/judwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/judwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judwhite/subscriptions","organizations_url":"https://api.github.com/users/judwhite/orgs","repos_url":"https://api.github.com/users/judwhite/repos","events_url":"https://api.github.com/users/judwhite/events{/privacy}","received_events_url":"https://api.github.com/users/judwhite/received_events","type":"User","site_admin":false},"body":"- mssql_test.go: return error in updateConnAddress\r\n- mssql_test.go: use %f for weight in TestMSSQLCreateInsertDelete\r\n- column.go: remove unreachable code\r\n- odbcstmt.go: return error from BindValue in Exec\r\n- result.go: fix typo\r\n\r\n/cc @ChrisHines ","created_at":"2016-05-29T05:25:44Z","updated_at":"2016-05-29T14:50:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9d7e559b17f2d2d11e7092c883a117902222422","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexbrainman/odbc/pulls/69/commits","review_comments_url":"https://api.github.com/repos/alexbrainman/odbc/pulls/69/comments","review_comment_url":"https://api.github.com/repos/alexbrainman/odbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexbrainman/odbc/issues/69/comments","statuses_url":"https://api.github.com/repos/alexbrainman/odbc/statuses/57530d816e667ae97413a38a2f27436cc5c12631","head":{"label":"judwhite:feature/minor-cleanup","ref":"feature/minor-cleanup","sha":"57530d816e667ae97413a38a2f27436cc5c12631","user":{"login":"judwhite","id":729716,"avatar_url":"https://avatars.githubusercontent.com/u/729716?v=3","gravatar_id":"","url":"https://api.github.com/users/judwhite","html_url":"https://github.com/judwhite","followers_url":"https://api.github.com/users/judwhite/followers","following_url":"https://api.github.com/users/judwhite/following{/other_user}","gists_url":"https://api.github.com/users/judwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/judwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judwhite/subscriptions","organizations_url":"https://api.github.com/users/judwhite/orgs","repos_url":"https://api.github.com/users/judwhite/repos","events_url":"https://api.github.com/users/judwhite/events{/privacy}","received_events_url":"https://api.github.com/users/judwhite/received_events","type":"User","site_admin":false},"repo":{"id":59875904,"name":"odbc","full_name":"judwhite/odbc","owner":{"login":"judwhite","id":729716,"avatar_url":"https://avatars.githubusercontent.com/u/729716?v=3","gravatar_id":"","url":"https://api.github.com/users/judwhite","html_url":"https://github.com/judwhite","followers_url":"https://api.github.com/users/judwhite/followers","following_url":"https://api.github.com/users/judwhite/following{/other_user}","gists_url":"https://api.github.com/users/judwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/judwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judwhite/subscriptions","organizations_url":"https://api.github.com/users/judwhite/orgs","repos_url":"https://api.github.com/users/judwhite/repos","events_url":"https://api.github.com/users/judwhite/events{/privacy}","received_events_url":"https://api.github.com/users/judwhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/judwhite/odbc","description":"odbc driver written in go","fork":true,"url":"https://api.github.com/repos/judwhite/odbc","forks_url":"https://api.github.com/repos/judwhite/odbc/forks","keys_url":"https://api.github.com/repos/judwhite/odbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/judwhite/odbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/judwhite/odbc/teams","hooks_url":"https://api.github.com/repos/judwhite/odbc/hooks","issue_events_url":"https://api.github.com/repos/judwhite/odbc/issues/events{/number}","events_url":"https://api.github.com/repos/judwhite/odbc/events","assignees_url":"https://api.github.com/repos/judwhite/odbc/assignees{/user}","branches_url":"https://api.github.com/repos/judwhite/odbc/branches{/branch}","tags_url":"https://api.github.com/repos/judwhite/odbc/tags","blobs_url":"https://api.github.com/repos/judwhite/odbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/judwhite/odbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/judwhite/odbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/judwhite/odbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/judwhite/odbc/statuses/{sha}","languages_url":"https://api.github.com/repos/judwhite/odbc/languages","stargazers_url":"https://api.github.com/repos/judwhite/odbc/stargazers","contributors_url":"https://api.github.com/repos/judwhite/odbc/contributors","subscribers_url":"https://api.github.com/repos/judwhite/odbc/subscribers","subscription_url":"https://api.github.com/repos/judwhite/odbc/subscription","commits_url":"https://api.github.com/repos/judwhite/odbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/judwhite/odbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/judwhite/odbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/judwhite/odbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/judwhite/odbc/contents/{+path}","compare_url":"https://api.github.com/repos/judwhite/odbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/judwhite/odbc/merges","archive_url":"https://api.github.com/repos/judwhite/odbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/judwhite/odbc/downloads","issues_url":"https://api.github.com/repos/judwhite/odbc/issues{/number}","pulls_url":"https://api.github.com/repos/judwhite/odbc/pulls{/number}","milestones_url":"https://api.github.com/repos/judwhite/odbc/milestones{/number}","notifications_url":"https://api.github.com/repos/judwhite/odbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/judwhite/odbc/labels{/name}","releases_url":"https://api.github.com/repos/judwhite/odbc/releases{/id}","deployments_url":"https://api.github.com/repos/judwhite/odbc/deployments","created_at":"2016-05-28T03:44:16Z","updated_at":"2016-05-28T03:44:17Z","pushed_at":"2016-05-29T05:22:11Z","git_url":"git://github.com/judwhite/odbc.git","ssh_url":"git@github.com:judwhite/odbc.git","clone_url":"https://github.com/judwhite/odbc.git","svn_url":"https://github.com/judwhite/odbc","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexbrainman:master","ref":"master","sha":"91d3dd47f412dd27d83cdd20510c4c6ee0c44899","user":{"login":"alexbrainman","id":9796621,"avatar_url":"https://avatars.githubusercontent.com/u/9796621?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbrainman","html_url":"https://github.com/alexbrainman","followers_url":"https://api.github.com/users/alexbrainman/followers","following_url":"https://api.github.com/users/alexbrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexbrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrainman/subscriptions","organizations_url":"https://api.github.com/users/alexbrainman/orgs","repos_url":"https://api.github.com/users/alexbrainman/repos","events_url":"https://api.github.com/users/alexbrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrainman/received_events","type":"User","site_admin":false},"repo":{"id":37445421,"name":"odbc","full_name":"alexbrainman/odbc","owner":{"login":"alexbrainman","id":9796621,"avatar_url":"https://avatars.githubusercontent.com/u/9796621?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbrainman","html_url":"https://github.com/alexbrainman","followers_url":"https://api.github.com/users/alexbrainman/followers","following_url":"https://api.github.com/users/alexbrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexbrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrainman/subscriptions","organizations_url":"https://api.github.com/users/alexbrainman/orgs","repos_url":"https://api.github.com/users/alexbrainman/repos","events_url":"https://api.github.com/users/alexbrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrainman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexbrainman/odbc","description":"odbc driver written in go","fork":false,"url":"https://api.github.com/repos/alexbrainman/odbc","forks_url":"https://api.github.com/repos/alexbrainman/odbc/forks","keys_url":"https://api.github.com/repos/alexbrainman/odbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexbrainman/odbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexbrainman/odbc/teams","hooks_url":"https://api.github.com/repos/alexbrainman/odbc/hooks","issue_events_url":"https://api.github.com/repos/alexbrainman/odbc/issues/events{/number}","events_url":"https://api.github.com/repos/alexbrainman/odbc/events","assignees_url":"https://api.github.com/repos/alexbrainman/odbc/assignees{/user}","branches_url":"https://api.github.com/repos/alexbrainman/odbc/branches{/branch}","tags_url":"https://api.github.com/repos/alexbrainman/odbc/tags","blobs_url":"https://api.github.com/repos/alexbrainman/odbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexbrainman/odbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexbrainman/odbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexbrainman/odbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexbrainman/odbc/statuses/{sha}","languages_url":"https://api.github.com/repos/alexbrainman/odbc/languages","stargazers_url":"https://api.github.com/repos/alexbrainman/odbc/stargazers","contributors_url":"https://api.github.com/repos/alexbrainman/odbc/contributors","subscribers_url":"https://api.github.com/repos/alexbrainman/odbc/subscribers","subscription_url":"https://api.github.com/repos/alexbrainman/odbc/subscription","commits_url":"https://api.github.com/repos/alexbrainman/odbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexbrainman/odbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexbrainman/odbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexbrainman/odbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexbrainman/odbc/contents/{+path}","compare_url":"https://api.github.com/repos/alexbrainman/odbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexbrainman/odbc/merges","archive_url":"https://api.github.com/repos/alexbrainman/odbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexbrainman/odbc/downloads","issues_url":"https://api.github.com/repos/alexbrainman/odbc/issues{/number}","pulls_url":"https://api.github.com/repos/alexbrainman/odbc/pulls{/number}","milestones_url":"https://api.github.com/repos/alexbrainman/odbc/milestones{/number}","notifications_url":"https://api.github.com/repos/alexbrainman/odbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexbrainman/odbc/labels{/name}","releases_url":"https://api.github.com/repos/alexbrainman/odbc/releases{/id}","deployments_url":"https://api.github.com/repos/alexbrainman/odbc/deployments","created_at":"2015-06-15T05:30:49Z","updated_at":"2016-05-20T15:29:00Z","pushed_at":"2016-05-29T05:25:44Z","git_url":"git://github.com/alexbrainman/odbc.git","ssh_url":"git@github.com:alexbrainman/odbc.git","clone_url":"https://github.com/alexbrainman/odbc.git","svn_url":"https://github.com/alexbrainman/odbc","homepage":"","size":101,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/69"},"html":{"href":"https://github.com/alexbrainman/odbc/pull/69"},"issue":{"href":"https://api.github.com/repos/alexbrainman/odbc/issues/69"},"comments":{"href":"https://api.github.com/repos/alexbrainman/odbc/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexbrainman/odbc/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/alexbrainman/odbc/statuses/57530d816e667ae97413a38a2f27436cc5c12631"}}}}
{"actor":{"display_login":"alexbrainman"}}