{"action":"created","issue":{"url":"https://api.github.com/repos/opf/openproject/issues/4356","repository_url":"https://api.github.com/repos/opf/openproject","labels_url":"https://api.github.com/repos/opf/openproject/issues/4356/labels{/name}","comments_url":"https://api.github.com/repos/opf/openproject/issues/4356/comments","events_url":"https://api.github.com/repos/opf/openproject/issues/4356/events","html_url":"https://github.com/opf/openproject/pull/4356","id":150959286,"number":4356,"title":"Remove gulp and add tasks with simple npm tasks","user":{"login":"oliverguenther","id":459462,"avatar_url":"https://avatars.githubusercontent.com/u/459462?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverguenther","html_url":"https://github.com/oliverguenther","followers_url":"https://api.github.com/users/oliverguenther/followers","following_url":"https://api.github.com/users/oliverguenther/following{/other_user}","gists_url":"https://api.github.com/users/oliverguenther/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverguenther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverguenther/subscriptions","organizations_url":"https://api.github.com/users/oliverguenther/orgs","repos_url":"https://api.github.com/users/oliverguenther/repos","events_url":"https://api.github.com/users/oliverguenther/events{/privacy}","received_events_url":"https://api.github.com/users/oliverguenther/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opf/openproject/labels/housekeeping","name":"housekeeping","color":"dd99dd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-25T19:33:35Z","updated_at":"2016-04-26T08:13:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/4356","html_url":"https://github.com/opf/openproject/pull/4356","diff_url":"https://github.com/opf/openproject/pull/4356.diff","patch_url":"https://github.com/opf/openproject/pull/4356.patch"},"body":"This removes `gulp` and provides a simpler `karma` and `webpack`,\r\n`webpack-watch` npm scripts.\r\n\r\nFor actual development, users will need the Rails stack anyway, so it\r\nwon't make sense to keep a separate set of dependencies up to date.\r\n\r\n* Instead of `gulp webpack`, use `npm run webpack`.\r\n* Instead of `gulp watch`, use `npm run webpack-watch`, which is *drastically* faster than gulp watch-polling.\r\n* Instead of `gulp tests:karma` use `npm run karma`, or just `npm test`.\r\n\r\nThis also removes all traces of express and restores the Rails styleguide. It is not whitelisted for precompilation and is only available in the context of the development mode.\r\nTo access the styleguide, use `localhost:5000/styleguide`, which is now rendered through the Rails stack.\r\n\r\nIt also replaces the unicorn web server in the `Procfile.dev, which causes code reloading for asset requests and is terribly slow compared to thin in that context.\r\n\r\n/cc @opf/frontend "},"comment":{"url":"https://api.github.com/repos/opf/openproject/issues/comments/214663464","html_url":"https://github.com/opf/openproject/pull/4356#issuecomment-214663464","issue_url":"https://api.github.com/repos/opf/openproject/issues/4356","id":214663464,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T08:13:30Z","updated_at":"2016-04-26T08:13:30Z","body":"## [Current coverage][cc-pull] is **92.85%**\n> Merging [#4356][cc-pull] into [dev][cc-base-branch] will decrease coverage by **-0.57%**\n\n```diff\n@@                dev      #4356   diff @@\n==========================================\n  Files           734        729     -5   \n  Lines         32507      32464    -43   \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n- Hits          30372      30143   -229   \n- Misses         2135       2321   +186   \n  Partials          0          0          \n```\n\n1. 6 files (not in diff) in `lib/api/v3` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6C69622F6170692F7633) \n  - Misses `+27` \n  - Hits `-27`\n1. 3 files (not in diff) in `lib` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6C6962) \n  - Misses `+9` \n  - Hits `-9`\n1. 2 files (not in diff) in `app/workers/scm` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F776F726B6572732F73636D) \n  - Misses `+3` \n  - Hits `-3`\n1. 2 files (not in diff) in `app/services/scm` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F73657276696365732F73636D) \n  - Misses `+13` \n  - Hits `-13`\n1. 2 files (not in diff) in `app/services` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F7365727669636573) \n  - Misses `+10` \n  - Hits `-10`\n1. 2 files (not in diff) in `...pp/models/repository` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F6D6F64656C732F7265706F7369746F7279) \n  - Misses `+2` \n  - Hits `-2`\n1. 4 files (not in diff) in `app/models` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F6D6F64656C73) \n  - Misses `+8` \n  - Hits `-8`\n1. 4 files (not in diff) in `app/helpers` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F68656C70657273) \n  - Misses `+12` \n  - Hits `-12`\n1. 4 files (not in diff) in `...p/controllers/api/v2` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F636F6E74726F6C6C6572732F6170692F7632) \n  - Misses `+13` \n  - Hits `-13`\n1. 2 files (not in diff) in `...ers/api/experimental` were modified. [more](https://codecov.io/gh/opf/openproject/commit/77604b388eb9c8c7828a32ec6c732b843cabca57/changes?src=pr#6170702F636F6E74726F6C6C6572732F6170692F6578706572696D656E74616C) \n  - Misses `+15` \n  - Hits `-15`\n\n[![Sunburst](https://codecov.io/gh/opf/openproject/pull/4356/graphs/sunburst.svg?size=660&src=pr)][cc-pull]\n\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 77604b3\n[cc-base-branch]: https://codecov.io/gh/opf/openproject/branch/dev?src=pr\n[cc-pull]: https://codecov.io/gh/opf/openproject/pull/4356?src=pr"}}