{"action":"closed","issue":{"url":"https://api.github.com/repos/Sylius/Sylius/issues/7137","repository_url":"https://api.github.com/repos/Sylius/Sylius","labels_url":"https://api.github.com/repos/Sylius/Sylius/issues/7137/labels{/name}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/7137/comments","events_url":"https://api.github.com/repos/Sylius/Sylius/issues/7137/events","html_url":"https://github.com/Sylius/Sylius/issues/7137","id":196790181,"number":7137,"title":"[Core][DX] Make private properties and methods in StateResolvers protected","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"labels":[{"id":236064219,"url":"https://api.github.com/repos/Sylius/Sylius/labels/DX","name":"DX","color":"5319e7","default":false},{"id":58897715,"url":"https://api.github.com/repos/Sylius/Sylius/labels/RFC","name":"RFC","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-20T21:50:28Z","updated_at":"2016-12-21T22:34:20Z","closed_at":"2016-12-21T22:34:20Z","body":"Hello,\r\nThe provided StateResolvers like https://github.com/Sylius/Sylius/blob/master/src/Sylius/Component/Core/StateResolver/OrderPaymentStateResolver.php have only private and public properties and methods. \r\n\r\nThis make more difficult to extend them as you almost need to duplicate all code in the classes. And  extending this is probably needed if you add more states in place. \r\n\r\nI suggest to change those private to protected. ¿Thoughts?"}}
{"actor":{"display_login":"pjedrzejewski"}}