{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/77794291","id":77794291,"diff_hunk":"@@ -33,7 +33,11 @@ trait PredefinedToResponseMarshallers extends LowPriorityToResponseMarshallerImp\n \n   implicit val fromStatusCode: TRM[StatusCode] =\n     Marshaller.withOpenCharset(`text/plain`) { (status, charset) ⇒\n-      HttpResponse(status, entity = HttpEntity(ContentType(`text/plain`, charset), status.defaultMessage))\n+      HttpResponse(status, entity = if (status.allowsEntity) {","path":"akka-http/src/main/scala/akka/http/scaladsl/marshalling/PredefinedToResponseMarshallers.scala","position":5,"original_position":5,"commit_id":"45118236d638de1c72111a9e5009ee04055b74bb","original_commit_id":"68a8b17ceb3524a9644a6d23eba1b7c2c97df232","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"body":"Just a cosmetic thing: move entity into a val for better readability. You can then also just use `HttpEntity(status.defaultMessage)`.","created_at":"2016-09-07T10:05:44Z","updated_at":"2016-09-07T10:05:44Z","html_url":"https://github.com/akka/akka/pull/21385#discussion_r77794291","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/21385","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/77794291"},"html":{"href":"https://github.com/akka/akka/pull/21385#discussion_r77794291"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/21385"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/21385","id":84180314,"html_url":"https://github.com/akka/akka/pull/21385","diff_url":"https://github.com/akka/akka/pull/21385.diff","patch_url":"https://github.com/akka/akka/pull/21385.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/21385","number":21385,"state":"open","locked":false,"title":"=htc #20793 do not emit body for statuses that don't allow one","user":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"body":"This is to change the default fromStatusCode toResponse marshaller to avoid situation where HttpResponse entity with actual body gets generated for statuses that do not allow for such as per RFC. Those malformed responses would get later rejected by the require filter.","created_at":"2016-09-06T19:20:34Z","updated_at":"2016-09-07T10:05:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ccbfc6a4a02426938ee8bed61025b93a65aa97b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/21385/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/21385/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/21385/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/45118236d638de1c72111a9e5009ee04055b74bb","head":{"label":"gosubpl:wip/20793-do-not-emit-body-for-statuses-that-dont-allow-one","ref":"wip/20793-do-not-emit-body-for-statuses-that-dont-allow-one","sha":"45118236d638de1c72111a9e5009ee04055b74bb","user":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"repo":{"id":59877074,"name":"akka","full_name":"gosubpl/akka","owner":{"login":"gosubpl","id":7828991,"avatar_url":"https://avatars.githubusercontent.com/u/7828991?v=3","gravatar_id":"","url":"https://api.github.com/users/gosubpl","html_url":"https://github.com/gosubpl","followers_url":"https://api.github.com/users/gosubpl/followers","following_url":"https://api.github.com/users/gosubpl/following{/other_user}","gists_url":"https://api.github.com/users/gosubpl/gists{/gist_id}","starred_url":"https://api.github.com/users/gosubpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosubpl/subscriptions","organizations_url":"https://api.github.com/users/gosubpl/orgs","repos_url":"https://api.github.com/users/gosubpl/repos","events_url":"https://api.github.com/users/gosubpl/events{/privacy}","received_events_url":"https://api.github.com/users/gosubpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gosubpl/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/gosubpl/akka","forks_url":"https://api.github.com/repos/gosubpl/akka/forks","keys_url":"https://api.github.com/repos/gosubpl/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosubpl/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosubpl/akka/teams","hooks_url":"https://api.github.com/repos/gosubpl/akka/hooks","issue_events_url":"https://api.github.com/repos/gosubpl/akka/issues/events{/number}","events_url":"https://api.github.com/repos/gosubpl/akka/events","assignees_url":"https://api.github.com/repos/gosubpl/akka/assignees{/user}","branches_url":"https://api.github.com/repos/gosubpl/akka/branches{/branch}","tags_url":"https://api.github.com/repos/gosubpl/akka/tags","blobs_url":"https://api.github.com/repos/gosubpl/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosubpl/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosubpl/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosubpl/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosubpl/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/gosubpl/akka/languages","stargazers_url":"https://api.github.com/repos/gosubpl/akka/stargazers","contributors_url":"https://api.github.com/repos/gosubpl/akka/contributors","subscribers_url":"https://api.github.com/repos/gosubpl/akka/subscribers","subscription_url":"https://api.github.com/repos/gosubpl/akka/subscription","commits_url":"https://api.github.com/repos/gosubpl/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosubpl/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosubpl/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosubpl/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosubpl/akka/contents/{+path}","compare_url":"https://api.github.com/repos/gosubpl/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosubpl/akka/merges","archive_url":"https://api.github.com/repos/gosubpl/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosubpl/akka/downloads","issues_url":"https://api.github.com/repos/gosubpl/akka/issues{/number}","pulls_url":"https://api.github.com/repos/gosubpl/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/gosubpl/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/gosubpl/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosubpl/akka/labels{/name}","releases_url":"https://api.github.com/repos/gosubpl/akka/releases{/id}","deployments_url":"https://api.github.com/repos/gosubpl/akka/deployments","created_at":"2016-05-28T04:22:07Z","updated_at":"2016-05-28T04:22:19Z","pushed_at":"2016-09-06T19:15:09Z","git_url":"git://github.com/gosubpl/akka.git","ssh_url":"git@github.com:gosubpl/akka.git","clone_url":"https://github.com/gosubpl/akka.git","svn_url":"https://github.com/gosubpl/akka","homepage":"http://akka.io","size":188679,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"f5f37fbc395c3f479f02833b0e351a2bf50e6516","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-09-07T06:13:34Z","pushed_at":"2016-09-07T09:57:50Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":228821,"stargazers_count":5985,"watchers_count":5985,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1908,"mirror_url":null,"open_issues_count":719,"forks":1908,"open_issues":719,"watchers":5985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/21385"},"html":{"href":"https://github.com/akka/akka/pull/21385"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/21385"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/21385/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/21385/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/21385/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/45118236d638de1c72111a9e5009ee04055b74bb"}}}}
{"actor":{"display_login":"jrudolph"}}