{"action":"created","comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/72931234","id":72931234,"diff_hunk":"@@ -118,56 +121,66 @@ function render(element, state) {\n     const transitionDuration = defaultValue(state.transitionDuration, defaultTransitionDuration);\n     const hasData = (data.length > 0 && data[0].points.length > 0);\n \n-    const d3Element = d3.select(element);\n+    const d3Element = d3Selection.select(element);\n     const svg = d3Element.select('svg')\n         .attr('width', state.width)\n         .attr('height', state.height);\n \n-    const g = d3.select(element).selectAll('.line-chart');\n+    const g = d3Selection.select(element).selectAll('.line-chart');\n+\n+    const t = d3Transition.transition().duration(transitionDuration);\n \n     const lines = g.selectAll('.line').data(data, d => d.id).attr('class', 'line');\n-    const isFirstLine = (!defined(lines[0][0]));\n+    // NOTE","path":"lib/Charts/LineChart.js","position":46,"original_position":46,"commit_id":"2ffc665ce83c45d20e6c810283c9d6558c2507a9","original_commit_id":"2ffc665ce83c45d20e6c810283c9d6558c2507a9","user":{"login":"RacingTadpole","id":1757858,"avatar_url":"https://avatars.githubusercontent.com/u/1757858?v=3","gravatar_id":"","url":"https://api.github.com/users/RacingTadpole","html_url":"https://github.com/RacingTadpole","followers_url":"https://api.github.com/users/RacingTadpole/followers","following_url":"https://api.github.com/users/RacingTadpole/following{/other_user}","gists_url":"https://api.github.com/users/RacingTadpole/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingTadpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingTadpole/subscriptions","organizations_url":"https://api.github.com/users/RacingTadpole/orgs","repos_url":"https://api.github.com/users/RacingTadpole/repos","events_url":"https://api.github.com/users/RacingTadpole/events{/privacy}","received_events_url":"https://api.github.com/users/RacingTadpole/received_events","type":"User","site_admin":false},"body":"Note what?","created_at":"2016-08-01T07:01:02Z","updated_at":"2016-08-01T07:01:02Z","html_url":"https://github.com/TerriaJS/terriajs/pull/1889#discussion_r72931234","pull_request_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889","_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/72931234"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/1889#discussion_r72931234"},"pull_request":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889"}}},"pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889","id":79297411,"html_url":"https://github.com/TerriaJS/terriajs/pull/1889","diff_url":"https://github.com/TerriaJS/terriajs/pull/1889.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/1889.patch","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1889","number":1889,"state":"open","locked":false,"title":"D4","user":{"login":"chloeleichen","id":7508939,"avatar_url":"https://avatars.githubusercontent.com/u/7508939?v=3","gravatar_id":"","url":"https://api.github.com/users/chloeleichen","html_url":"https://github.com/chloeleichen","followers_url":"https://api.github.com/users/chloeleichen/followers","following_url":"https://api.github.com/users/chloeleichen/following{/other_user}","gists_url":"https://api.github.com/users/chloeleichen/gists{/gist_id}","starred_url":"https://api.github.com/users/chloeleichen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chloeleichen/subscriptions","organizations_url":"https://api.github.com/users/chloeleichen/orgs","repos_url":"https://api.github.com/users/chloeleichen/repos","events_url":"https://api.github.com/users/chloeleichen/events{/privacy}","received_events_url":"https://api.github.com/users/chloeleichen/received_events","type":"User","site_admin":false},"body":"@RacingTadpole 😄 ","created_at":"2016-07-29T02:16:38Z","updated_at":"2016-08-01T07:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f01a1ec3ae8487b1964a60f10ef078b3734e8407","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1889/comments","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/2ffc665ce83c45d20e6c810283c9d6558c2507a9","head":{"label":"TerriaJS:d4","ref":"d4","sha":"2ffc665ce83c45d20e6c810283c9d6558c2507a9","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-07-26T19:32:58Z","pushed_at":"2016-08-01T06:59:02Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":58149,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":255,"forks":68,"open_issues":255,"watchers":118,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"6d8ce38f9e96b255104f9c59d121220186d16aab","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-07-26T19:32:58Z","pushed_at":"2016-08-01T06:59:02Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":58149,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":255,"forks":68,"open_issues":255,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/1889"},"issue":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/1889"},"comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/terriajs/statuses/2ffc665ce83c45d20e6c810283c9d6558c2507a9"}}}}
{"actor":{"display_login":"RacingTadpole"}}