{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/51078946","id":51078946,"diff_hunk":"@@ -69,7 +70,8 @@ public WebInterfaceDownloadServlet(FileSystemMaster fsMaster) {\n   @Override\n   protected void doGet(HttpServletRequest request, HttpServletResponse response)\n       throws ServletException, IOException {\n-    if (PlainSaslServer.AuthorizedClientUser.get() == null) {\n+    if (SecurityUtils.isSecurityEnabled(MasterContext.getConf())","path":"core/server/src/main/java/tachyon/web/WebInterfaceDownloadServlet.java","position":13,"original_position":13,"commit_id":"46c763f3a7c2c1134b2e2be50e1ce86ffc41c3fa","original_commit_id":"46c763f3a7c2c1134b2e2be50e1ce86ffc41c3fa","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"Would it make sense to check if security is enabled in `PlainSaslServer.AuthorizedClientUser.get()`?","created_at":"2016-01-28T04:33:27Z","updated_at":"2016-01-28T04:33:27Z","html_url":"https://github.com/amplab/tachyon/pull/2585#discussion_r51078946","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2585","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/51078946"},"html":{"href":"https://github.com/amplab/tachyon/pull/2585#discussion_r51078946"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2585"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2585","id":57449507,"html_url":"https://github.com/amplab/tachyon/pull/2585","diff_url":"https://github.com/amplab/tachyon/pull/2585.diff","patch_url":"https://github.com/amplab/tachyon/pull/2585.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2585","number":2585,"state":"open","locked":false,"title":"[TACHYON-1668] Tachyon UI is broken because of security checking","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"body":"JIRA: https://tachyon.atlassian.net/browse/TACHYON-1668\r\n\r\nBug fixed. Check whether security is enabled at first. If not, which is the default conf in Tachyon, the if branch should be bypassed.\r\n\r\n@apc999 , @yupeng9 , @sundapeng ","created_at":"2016-01-28T03:19:14Z","updated_at":"2016-01-28T04:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f6460cdb9501c1a9135035bb831aacd7ddff8a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2585/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2585/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2585/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/46c763f3a7c2c1134b2e2be50e1ce86ffc41c3fa","head":{"label":"dongche:tachyon-1668","ref":"tachyon-1668","sha":"46c763f3a7c2c1134b2e2be50e1ce86ffc41c3fa","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"repo":{"id":38419009,"name":"tachyon","full_name":"dongche/tachyon","owner":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dongche/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/dongche/tachyon","forks_url":"https://api.github.com/repos/dongche/tachyon/forks","keys_url":"https://api.github.com/repos/dongche/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dongche/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dongche/tachyon/teams","hooks_url":"https://api.github.com/repos/dongche/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dongche/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dongche/tachyon/events","assignees_url":"https://api.github.com/repos/dongche/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dongche/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dongche/tachyon/tags","blobs_url":"https://api.github.com/repos/dongche/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dongche/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dongche/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dongche/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dongche/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dongche/tachyon/languages","stargazers_url":"https://api.github.com/repos/dongche/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dongche/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dongche/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dongche/tachyon/subscription","commits_url":"https://api.github.com/repos/dongche/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dongche/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dongche/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dongche/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dongche/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dongche/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dongche/tachyon/merges","archive_url":"https://api.github.com/repos/dongche/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dongche/tachyon/downloads","issues_url":"https://api.github.com/repos/dongche/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dongche/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dongche/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dongche/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dongche/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dongche/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/dongche/tachyon/deployments","created_at":"2015-07-02T07:53:56Z","updated_at":"2015-07-02T07:53:58Z","pushed_at":"2016-01-28T03:14:45Z","git_url":"git://github.com/dongche/tachyon.git","ssh_url":"git@github.com:dongche/tachyon.git","clone_url":"https://github.com/dongche/tachyon.git","svn_url":"https://github.com/dongche/tachyon","homepage":"http://tachyon-project.org","size":39487,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"e7868467bea1747411a75c1dd9b48e563c4ac058","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/amplab/tachyon/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-01-26T17:01:25Z","pushed_at":"2016-01-28T04:31:10Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":47365,"stargazers_count":1927,"watchers_count":1927,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":762,"mirror_url":null,"open_issues_count":18,"forks":762,"open_issues":18,"watchers":1927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2585"},"html":{"href":"https://github.com/amplab/tachyon/pull/2585"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2585"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2585/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2585/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2585/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/46c763f3a7c2c1134b2e2be50e1ce86ffc41c3fa"}}}}