{"action":"closed","number":1935,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935","id":84772620,"html_url":"https://github.com/ReactiveX/rxjs/pull/1935","diff_url":"https://github.com/ReactiveX/rxjs/pull/1935.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/1935.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1935","number":1935,"state":"closed","locked":false,"title":"Fixes 1921","user":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you very much for your pull request!\r\n\r\nIf your PR is the addition of a new operator, please make sure all these boxes are ticked with an x:\r\n\r\n- [ ] Add the operator to Rx\r\n- [ ] It must have a `-spec.ts` tests file covering the canonical corner cases, with marble diagram tests\r\n- [ ] If possible, write a `asDiagram` test case too, for PNG diagram generation purposes\r\n- [ ] The spec file should have a type definition test at the end of the spec to verify type definition for various use cases\r\n- [ ] The operator must be documented in JSDoc style in the implementation file, including also the PNG marble diagram image\r\n- [ ] The operator should be listed in `doc/operators.md` in a category of operators\r\n- [ ] It should also be inserted in the operator decision tree file `doc/decision-tree-widget/tree.yml`\r\n- [ ] You may need to update `MIGRATION.md` if the operator differs from the corresponding one in RxJS v4\r\n-->\r\n\r\n**Description:**\r\nSupply the Subscriber constructor the empty observer destination if `Observable.subscribe` is called with no arguments. This ensures the Subscriber wraps the empty Observer in a `SafeSubscriber` which will catch `error` messages and dispose of the subscription.\r\n\r\n**Related issue (if exists):**\r\n#1921","created_at":"2016-09-11T00:30:41Z","updated_at":"2016-09-11T00:43:55Z","closed_at":"2016-09-11T00:43:55Z","merged_at":"2016-09-11T00:43:55Z","merge_commit_sha":"d876a35c46ced37868f1f4fa73d3b7fbb581e9c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/1935/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/4d23f87b92e01cb252a75431686b7c63981e64fa","head":{"label":"trxcllnt:fix-1921","ref":"fix-1921","sha":"4d23f87b92e01cb252a75431686b7c63981e64fa","user":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"repo":{"id":42749612,"name":"RxJS","full_name":"trxcllnt/RxJS","owner":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trxcllnt/RxJS","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/trxcllnt/RxJS","forks_url":"https://api.github.com/repos/trxcllnt/RxJS/forks","keys_url":"https://api.github.com/repos/trxcllnt/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trxcllnt/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trxcllnt/RxJS/teams","hooks_url":"https://api.github.com/repos/trxcllnt/RxJS/hooks","issue_events_url":"https://api.github.com/repos/trxcllnt/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/trxcllnt/RxJS/events","assignees_url":"https://api.github.com/repos/trxcllnt/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/trxcllnt/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/trxcllnt/RxJS/tags","blobs_url":"https://api.github.com/repos/trxcllnt/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trxcllnt/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trxcllnt/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/trxcllnt/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trxcllnt/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/trxcllnt/RxJS/languages","stargazers_url":"https://api.github.com/repos/trxcllnt/RxJS/stargazers","contributors_url":"https://api.github.com/repos/trxcllnt/RxJS/contributors","subscribers_url":"https://api.github.com/repos/trxcllnt/RxJS/subscribers","subscription_url":"https://api.github.com/repos/trxcllnt/RxJS/subscription","commits_url":"https://api.github.com/repos/trxcllnt/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/trxcllnt/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/trxcllnt/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/trxcllnt/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/trxcllnt/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/trxcllnt/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trxcllnt/RxJS/merges","archive_url":"https://api.github.com/repos/trxcllnt/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trxcllnt/RxJS/downloads","issues_url":"https://api.github.com/repos/trxcllnt/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/trxcllnt/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/trxcllnt/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/trxcllnt/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trxcllnt/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/trxcllnt/RxJS/releases{/id}","deployments_url":"https://api.github.com/repos/trxcllnt/RxJS/deployments","created_at":"2015-09-18T22:19:34Z","updated_at":"2016-03-02T01:37:50Z","pushed_at":"2016-09-11T00:32:26Z","git_url":"git://github.com/trxcllnt/RxJS.git","ssh_url":"git@github.com:trxcllnt/RxJS.git","clone_url":"https://github.com/trxcllnt/RxJS.git","svn_url":"https://github.com/trxcllnt/RxJS","homepage":null,"size":6786,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"f63dde9fed737c0f5f5e70e89b86abeb1961b2c6","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"rxjs","full_name":"ReactiveX/rxjs","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2016-09-10T23:02:29Z","pushed_at":"2016-09-11T00:43:55Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":48192,"stargazers_count":3083,"watchers_count":3083,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":287,"mirror_url":null,"open_issues_count":102,"forks":287,"open_issues":102,"watchers":3083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/1935"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/1935"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/1935/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/1935/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/4d23f87b92e01cb252a75431686b7c63981e64fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":58,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"jayphelps"}}