{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments/93538723","pull_request_review_id":14068929,"id":93538723,"diff_hunk":"@@ -9,22 +9,61 @@ const uuid = require('node-uuid');\n \n describe('nodejs-docker', () => {\n \n-  it('serves traffic on 8080', (done) => {\n-    runDocker('test/express', 8080, (host, callback) => {\n-      setTimeout(() => {\n-        request(`http://${host}:8080`, (err, res, body) => {\n-          if (err) {\n-            console.error(`Error requesting content: ${util.inspect(err)}`);\n-            throw err;\n-          }\n-          assert.equal(body, 'Hello World!');\n-          callback(() => {\n-            done();\n+  function verifyOutput(description, dockerImage, expectedOutput) {\n+    it(description, (done) => {\n+      runDocker(dockerImage, 8080, (host, callback) => {\n+        setTimeout(() => {\n+          request(`http://${host}:8080`, (err, res, body) => {\n+            try {\n+              if (err) {\n+                console.error(`Error requesting content: ${util.inspect(err)}`);\n+                throw err;\n+              }\n+              assert.equal(body, expectedOutput);\n+            }\n+            finally {\n+              callback(() => {\n+                done();","path":"test/test.js","position":29,"original_position":29,"commit_id":"b151db7076e9103bfe3469d4bfc2f587f01799f7","original_commit_id":"b151db7076e9103bfe3469d4bfc2f587f01799f7","user":{"login":"DominicKramer","id":14253877,"avatar_url":"https://avatars.githubusercontent.com/u/14253877?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicKramer","html_url":"https://github.com/DominicKramer","followers_url":"https://api.github.com/users/DominicKramer/followers","following_url":"https://api.github.com/users/DominicKramer/following{/other_user}","gists_url":"https://api.github.com/users/DominicKramer/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicKramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicKramer/subscriptions","organizations_url":"https://api.github.com/users/DominicKramer/orgs","repos_url":"https://api.github.com/users/DominicKramer/repos","events_url":"https://api.github.com/users/DominicKramer/events{/privacy}","received_events_url":"https://api.github.com/users/DominicKramer/received_events","type":"User","site_admin":false},"body":"I have confirmed that the test do fail if the actual output does not equal the expected output.","created_at":"2016-12-21T23:11:32Z","updated_at":"2016-12-21T23:11:32Z","html_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74#discussion_r93538723","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments/93538723"},"html":{"href":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74#discussion_r93538723"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74","id":98673932,"html_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74","diff_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74.diff","patch_url":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/74","number":74,"state":"open","locked":false,"title":"Add binary signature verification","user":{"login":"DominicKramer","id":14253877,"avatar_url":"https://avatars.githubusercontent.com/u/14253877?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicKramer","html_url":"https://github.com/DominicKramer","followers_url":"https://api.github.com/users/DominicKramer/followers","following_url":"https://api.github.com/users/DominicKramer/following{/other_user}","gists_url":"https://api.github.com/users/DominicKramer/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicKramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicKramer/subscriptions","organizations_url":"https://api.github.com/users/DominicKramer/orgs","repos_url":"https://api.github.com/users/DominicKramer/repos","events_url":"https://api.github.com/users/DominicKramer/events{/privacy}","received_events_url":"https://api.github.com/users/DominicKramer/received_events","type":"User","site_admin":false},"body":"With this PR, the base Docker image will fail to build if the version of Node it tries to install cannot be verified as legitimate.","created_at":"2016-12-20T01:59:10Z","updated_at":"2016-12-21T23:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21a5e74f4a6fddbc9ca63077543b5ee307b855f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/74/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/b151db7076e9103bfe3469d4bfc2f587f01799f7","head":{"label":"DominicKramer:feature/add-binary-signature-verification","ref":"feature/add-binary-signature-verification","sha":"b151db7076e9103bfe3469d4bfc2f587f01799f7","user":{"login":"DominicKramer","id":14253877,"avatar_url":"https://avatars.githubusercontent.com/u/14253877?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicKramer","html_url":"https://github.com/DominicKramer","followers_url":"https://api.github.com/users/DominicKramer/followers","following_url":"https://api.github.com/users/DominicKramer/following{/other_user}","gists_url":"https://api.github.com/users/DominicKramer/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicKramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicKramer/subscriptions","organizations_url":"https://api.github.com/users/DominicKramer/orgs","repos_url":"https://api.github.com/users/DominicKramer/repos","events_url":"https://api.github.com/users/DominicKramer/events{/privacy}","received_events_url":"https://api.github.com/users/DominicKramer/received_events","type":"User","site_admin":false},"repo":{"id":73518937,"name":"nodejs-docker","full_name":"DominicKramer/nodejs-docker","owner":{"login":"DominicKramer","id":14253877,"avatar_url":"https://avatars.githubusercontent.com/u/14253877?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicKramer","html_url":"https://github.com/DominicKramer","followers_url":"https://api.github.com/users/DominicKramer/followers","following_url":"https://api.github.com/users/DominicKramer/following{/other_user}","gists_url":"https://api.github.com/users/DominicKramer/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicKramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicKramer/subscriptions","organizations_url":"https://api.github.com/users/DominicKramer/orgs","repos_url":"https://api.github.com/users/DominicKramer/repos","events_url":"https://api.github.com/users/DominicKramer/events{/privacy}","received_events_url":"https://api.github.com/users/DominicKramer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DominicKramer/nodejs-docker","description":"The Node.js Docker image used by Google App Engine Flexible.","fork":true,"url":"https://api.github.com/repos/DominicKramer/nodejs-docker","forks_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/forks","keys_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/teams","hooks_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/hooks","issue_events_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/issues/events{/number}","events_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/events","assignees_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/assignees{/user}","branches_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/branches{/branch}","tags_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/tags","blobs_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/languages","stargazers_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/stargazers","contributors_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/contributors","subscribers_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/subscribers","subscription_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/subscription","commits_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/contents/{+path}","compare_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/merges","archive_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/downloads","issues_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/issues{/number}","pulls_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/labels{/name}","releases_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/releases{/id}","deployments_url":"https://api.github.com/repos/DominicKramer/nodejs-docker/deployments","created_at":"2016-11-11T23:21:55Z","updated_at":"2016-11-11T23:21:56Z","pushed_at":"2016-12-20T04:52:11Z","git_url":"git://github.com/DominicKramer/nodejs-docker.git","ssh_url":"git@github.com:DominicKramer/nodejs-docker.git","clone_url":"https://github.com/DominicKramer/nodejs-docker.git","svn_url":"https://github.com/DominicKramer/nodejs-docker","homepage":"https://cloud.google.com/nodejs","size":141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"fa0c63d16add7d1eecba448c027ec0abc68f5263","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19798221,"name":"nodejs-docker","full_name":"GoogleCloudPlatform/nodejs-docker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/nodejs-docker","description":"The Node.js Docker image used by Google App Engine Flexible.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/deployments","created_at":"2014-05-14T22:22:56Z","updated_at":"2016-12-17T04:07:27Z","pushed_at":"2016-12-20T04:52:13Z","git_url":"git://github.com/GoogleCloudPlatform/nodejs-docker.git","ssh_url":"git@github.com:GoogleCloudPlatform/nodejs-docker.git","clone_url":"https://github.com/GoogleCloudPlatform/nodejs-docker.git","svn_url":"https://github.com/GoogleCloudPlatform/nodejs-docker","homepage":"https://cloud.google.com/nodejs","size":152,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":5,"forks":51,"open_issues":5,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74"},"html":{"href":"https://github.com/GoogleCloudPlatform/nodejs-docker/pull/74"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/74"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/nodejs-docker/statuses/b151db7076e9103bfe3469d4bfc2f587f01799f7"}}}}
{"actor":{"display_login":"DominicKramer"}}