{"action":"created","issue":{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/271","repository_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle","labels_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/271/comments","events_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/271/events","html_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/271","id":159832895,"number":271,"title":"Webtestcase: Extract some fixtures methods","user":{"login":"alexislefebvre","id":2071331,"avatar_url":"https://avatars.githubusercontent.com/u/2071331?v=3","gravatar_id":"","url":"https://api.github.com/users/alexislefebvre","html_url":"https://github.com/alexislefebvre","followers_url":"https://api.github.com/users/alexislefebvre/followers","following_url":"https://api.github.com/users/alexislefebvre/following{/other_user}","gists_url":"https://api.github.com/users/alexislefebvre/gists{/gist_id}","starred_url":"https://api.github.com/users/alexislefebvre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexislefebvre/subscriptions","organizations_url":"https://api.github.com/users/alexislefebvre/orgs","repos_url":"https://api.github.com/users/alexislefebvre/repos","events_url":"https://api.github.com/users/alexislefebvre/events{/privacy}","received_events_url":"https://api.github.com/users/alexislefebvre/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/labels/in%20review","name":"in review","color":"ededed"},{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/labels/RFC","name":"RFC","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-12T15:26:06Z","updated_at":"2016-07-23T15:06:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/271","html_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/271","diff_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/271.diff","patch_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/271.patch"},"body":"to the new FixturesLoader class"},"comment":{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/comments/234722962","html_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/271#issuecomment-234722962","issue_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/271","id":234722962,"user":{"login":"alexislefebvre","id":2071331,"avatar_url":"https://avatars.githubusercontent.com/u/2071331?v=3","gravatar_id":"","url":"https://api.github.com/users/alexislefebvre","html_url":"https://github.com/alexislefebvre","followers_url":"https://api.github.com/users/alexislefebvre/followers","following_url":"https://api.github.com/users/alexislefebvre/following{/other_user}","gists_url":"https://api.github.com/users/alexislefebvre/gists{/gist_id}","starred_url":"https://api.github.com/users/alexislefebvre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexislefebvre/subscriptions","organizations_url":"https://api.github.com/users/alexislefebvre/orgs","repos_url":"https://api.github.com/users/alexislefebvre/repos","events_url":"https://api.github.com/users/alexislefebvre/events{/privacy}","received_events_url":"https://api.github.com/users/alexislefebvre/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T15:06:49Z","updated_at":"2016-07-23T15:06:49Z","body":"I remember now why I declared static methods: it was easier to use them since it doesn't require to instantiate an object before calling the methods from `FixturesLoader`.\r\n\r\n> well if you add a factory method to the base class or make it an optional parameter then yes ..\r\n\r\nI think that I understand your idea now.\r\n\r\nWould adding a method like `protected function getFixturesLoader() {}` in `WebTestCase` that\r\n\r\n1. return an instance of `FixturesLoader` or instantiate an object then return it\r\n2. can be overridden by any child class\r\n\r\nis a good solution?"}}
{"actor":{"display_login":"alexislefebvre"}}