{"action":"closed","number":434,"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly/pulls/434","id":82576862,"html_url":"https://github.com/patternfly/patternfly/pull/434","diff_url":"https://github.com/patternfly/patternfly/pull/434.diff","patch_url":"https://github.com/patternfly/patternfly/pull/434.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly/issues/434","number":434,"state":"closed","locked":false,"title":"Removing css that caused issue with borders displaying in secondary a…","user":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars.githubusercontent.com/u/21063328?v=3","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"body":"## Description\r\nA previous update, #400, to list-group.less resulted in unwanted borders displaying for list group items in the secondary and tertiary nav panels. To fix the issue I removed the css that resulted in these borders displaying. \r\n\r\n**NOTE,** the border style updates in #400 modified the display of borders in the list view, so that when a row was selected, a top AND bottom blue border displayed. With this CSS removed, only a top blue border will display for selected items (for any row except first). In the design document, blue borders do not display at all so I'm not sure what the actual expected look is. If further updates are needed for this, please let me know. \r\n\r\nI also moved the css that fixed the original issue addressed by #400 from list-group.less to list-view.less as suggested by Andres.\r\n\r\n## Examples of updates\r\n\r\nNavigation Before\r\n![screen shot 2016-08-24 at 12 36 43 pm](https://cloud.githubusercontent.com/assets/21063328/17939191/7246f86e-69f7-11e6-8342-0a3e5d70f7f9.png)\r\n\r\nNavigation After\r\n![After](https://cloud.githubusercontent.com/assets/21063328/17939123/0cc37594-69f7-11e6-99d9-6d6139ff12a0.png)\r\n\r\nList View Before\r\n![screen shot 2016-08-24 at 12 37 24 pm](https://cloud.githubusercontent.com/assets/21063328/17939210/8c515c4a-69f7-11e6-86fa-2b7329f046d3.png)\r\n\r\nList View After\r\n![After](https://cloud.githubusercontent.com/assets/21063328/17939137/1aab55b4-69f7-11e6-893a-b3ae0ea191f7.png)\r\n\r\n","created_at":"2016-08-24T16:39:34Z","updated_at":"2016-08-24T17:04:00Z","closed_at":"2016-08-24T17:04:00Z","merged_at":"2016-08-24T17:04:00Z","merge_commit_sha":"28230d02a55aecb022c3730511c7ed901ad896c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly/pulls/434/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly/pulls/434/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly/issues/434/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/b6ab3891d45be53f002ecac0809108c2e49d39a1","head":{"label":"jgiardino:VerticalNav","ref":"VerticalNav","sha":"b6ab3891d45be53f002ecac0809108c2e49d39a1","user":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars.githubusercontent.com/u/21063328?v=3","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"repo":{"id":66385137,"name":"patternfly","full_name":"jgiardino/patternfly","owner":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars.githubusercontent.com/u/21063328?v=3","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgiardino/patternfly","description":"PatternFly open interface project","fork":true,"url":"https://api.github.com/repos/jgiardino/patternfly","forks_url":"https://api.github.com/repos/jgiardino/patternfly/forks","keys_url":"https://api.github.com/repos/jgiardino/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgiardino/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgiardino/patternfly/teams","hooks_url":"https://api.github.com/repos/jgiardino/patternfly/hooks","issue_events_url":"https://api.github.com/repos/jgiardino/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/jgiardino/patternfly/events","assignees_url":"https://api.github.com/repos/jgiardino/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/jgiardino/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/jgiardino/patternfly/tags","blobs_url":"https://api.github.com/repos/jgiardino/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgiardino/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgiardino/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgiardino/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgiardino/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/jgiardino/patternfly/languages","stargazers_url":"https://api.github.com/repos/jgiardino/patternfly/stargazers","contributors_url":"https://api.github.com/repos/jgiardino/patternfly/contributors","subscribers_url":"https://api.github.com/repos/jgiardino/patternfly/subscribers","subscription_url":"https://api.github.com/repos/jgiardino/patternfly/subscription","commits_url":"https://api.github.com/repos/jgiardino/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgiardino/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgiardino/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgiardino/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgiardino/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/jgiardino/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgiardino/patternfly/merges","archive_url":"https://api.github.com/repos/jgiardino/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgiardino/patternfly/downloads","issues_url":"https://api.github.com/repos/jgiardino/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/jgiardino/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/jgiardino/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/jgiardino/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgiardino/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/jgiardino/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/jgiardino/patternfly/deployments","created_at":"2016-08-23T16:42:41Z","updated_at":"2016-08-23T16:42:42Z","pushed_at":"2016-08-24T15:44:54Z","git_url":"git://github.com/jgiardino/patternfly.git","ssh_url":"git@github.com:jgiardino/patternfly.git","clone_url":"https://github.com/jgiardino/patternfly.git","svn_url":"https://github.com/jgiardino/patternfly","homepage":"https://www.patternfly.org/","size":13841,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"eb59d2e86d8d5efdd634a45325b0aa7f763225d6","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":16493298,"name":"patternfly","full_name":"patternfly/patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly","description":"PatternFly open interface project","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly","forks_url":"https://api.github.com/repos/patternfly/patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly/deployments","created_at":"2014-02-03T21:18:00Z","updated_at":"2016-08-24T14:39:52Z","pushed_at":"2016-08-24T17:04:00Z","git_url":"git://github.com/patternfly/patternfly.git","ssh_url":"git@github.com:patternfly/patternfly.git","clone_url":"https://github.com/patternfly/patternfly.git","svn_url":"https://github.com/patternfly/patternfly","homepage":"https://www.patternfly.org/","size":14631,"stargazers_count":460,"watchers_count":460,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":45,"forks":137,"open_issues":45,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/434"},"html":{"href":"https://github.com/patternfly/patternfly/pull/434"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/434"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly/statuses/b6ab3891d45be53f002ecac0809108c2e49d39a1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andresgalante","id":1832037,"avatar_url":"https://avatars.githubusercontent.com/u/1832037?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"andresgalante"}}