{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/54947505","id":54947505,"diff_hunk":"@@ -394,6 +401,10 @@ export class AccessService {\n       this.toggleTopClass_('amp-access-loading', false);\n       this.toggleTopClass_('amp-access-error', true);\n     });\n+    // At least one promise should succeed.","path":"extensions/amp-access/0.1/amp-access.js","position":67,"original_position":67,"commit_id":"855c7054d2ec5dbe27ce560f5a659befc3df864d","original_commit_id":"855c7054d2ec5dbe27ce560f5a659befc3df864d","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"Updated comment. The right wording \"first promise is always required to complete\".","created_at":"2016-03-03T20:59:59Z","updated_at":"2016-03-03T20:59:59Z","html_url":"https://github.com/ampproject/amphtml/pull/2417#discussion_r54947505","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2417","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/54947505"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2417#discussion_r54947505"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2417"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/2417","id":61616602,"html_url":"https://github.com/ampproject/amphtml/pull/2417","diff_url":"https://github.com/ampproject/amphtml/pull/2417.diff","patch_url":"https://github.com/ampproject/amphtml/pull/2417.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/2417","number":2417,"state":"open","locked":false,"title":"Resend pingback after successfull and wait for the most recent auth request to resolve analytics values","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"body":"Two important changes in spec:\r\n\r\n1. Pingback will be resend after successful login to signify a new view with the new access profile.\r\n2. The analytics values and pingback wait for the most recent authorization call to complete, but do tolerate some failures.\r\n\r\nCloses #2340\r\n\r\n/cc @ashwinlimaye @rudygalfi @sebastianbenz @andreban @adaybujeda @georgecrawford","created_at":"2016-03-03T20:04:34Z","updated_at":"2016-03-03T20:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70a16a50ad60cb30aeb94eddde738e07496294e0","assignee":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2417/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/2417/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/2417/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/855c7054d2ec5dbe27ce560f5a659befc3df864d","head":{"label":"dvoytenko:access55","ref":"access55","sha":"855c7054d2ec5dbe27ce560f5a659befc3df864d","user":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"repo":{"id":43817704,"name":"amphtml","full_name":"dvoytenko/amphtml","owner":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dvoytenko/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/dvoytenko/amphtml","forks_url":"https://api.github.com/repos/dvoytenko/amphtml/forks","keys_url":"https://api.github.com/repos/dvoytenko/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvoytenko/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvoytenko/amphtml/teams","hooks_url":"https://api.github.com/repos/dvoytenko/amphtml/hooks","issue_events_url":"https://api.github.com/repos/dvoytenko/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/dvoytenko/amphtml/events","assignees_url":"https://api.github.com/repos/dvoytenko/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/dvoytenko/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/dvoytenko/amphtml/tags","blobs_url":"https://api.github.com/repos/dvoytenko/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvoytenko/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvoytenko/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvoytenko/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvoytenko/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/dvoytenko/amphtml/languages","stargazers_url":"https://api.github.com/repos/dvoytenko/amphtml/stargazers","contributors_url":"https://api.github.com/repos/dvoytenko/amphtml/contributors","subscribers_url":"https://api.github.com/repos/dvoytenko/amphtml/subscribers","subscription_url":"https://api.github.com/repos/dvoytenko/amphtml/subscription","commits_url":"https://api.github.com/repos/dvoytenko/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvoytenko/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvoytenko/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvoytenko/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvoytenko/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/dvoytenko/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvoytenko/amphtml/merges","archive_url":"https://api.github.com/repos/dvoytenko/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvoytenko/amphtml/downloads","issues_url":"https://api.github.com/repos/dvoytenko/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/dvoytenko/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/dvoytenko/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/dvoytenko/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvoytenko/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/dvoytenko/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/dvoytenko/amphtml/deployments","created_at":"2015-10-07T13:30:20Z","updated_at":"2016-01-11T18:44:41Z","pushed_at":"2016-03-03T20:06:18Z","git_url":"git://github.com/dvoytenko/amphtml.git","ssh_url":"git@github.com:dvoytenko/amphtml.git","clone_url":"https://github.com/dvoytenko/amphtml.git","svn_url":"https://github.com/dvoytenko/amphtml","homepage":"","size":32126,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"c39c185318a1f512315da46fdf3e86cedb3d503a","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-03-03T20:44:53Z","pushed_at":"2016-03-03T20:06:56Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":36212,"stargazers_count":6607,"watchers_count":6607,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":778,"mirror_url":null,"open_issues_count":325,"forks":778,"open_issues":325,"watchers":6607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2417"},"html":{"href":"https://github.com/ampproject/amphtml/pull/2417"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2417"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/2417/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2417/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/2417/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/855c7054d2ec5dbe27ce560f5a659befc3df864d"}}}}