{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/63679370","id":63679370,"diff_hunk":"@@ -20,11 +20,16 @@ import scala.collection.generic.CanBuildFrom\n import scala.reflect.ClassTag\n \n \n-/** The trait that represents futures.\n+/** \n  *\n- *  Asynchronous computations that yield futures are created with the `Future.apply` call:\n+ *  A `Future` represents a value which may or may not *currently* be available,","path":"src/library/scala/concurrent/Future.scala","position":8,"original_position":8,"commit_id":"967a75989d758e16f0be5839b7500a50a7647b88","original_commit_id":"967a75989d758e16f0be5839b7500a50a7647b88","user":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"?","created_at":"2016-05-18T10:25:26Z","updated_at":"2016-05-18T10:25:26Z","html_url":"https://github.com/scala/scala/pull/5164#discussion_r63679370","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/5164","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/63679370"},"html":{"href":"https://github.com/scala/scala/pull/5164#discussion_r63679370"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/5164"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/5164","id":70132991,"html_url":"https://github.com/scala/scala/pull/5164","diff_url":"https://github.com/scala/scala/pull/5164.diff","patch_url":"https://github.com/scala/scala/pull/5164.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/5164","number":5164,"state":"open","locked":false,"title":"Improve Future documentation (+ minor code cleanups)","user":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"Primarily improves the documentation but also makes some minor adjustments to implementation, without semantical difference.\r\n\r\nAlso adds a \"missing\" test case to ensure that it is possible to add numerous callbacks in a chain and still have the correct number of invocations. (this is an important test esp. if the representation of the callbacks for the standard implementation changes down the line)","created_at":"2016-05-15T20:58:54Z","updated_at":"2016-05-18T10:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39adba323f8f0dbfad185d493e44af6ded37e613","assignee":null,"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/52","html_url":"https://github.com/scala/scala/milestones/2.12.0-M5","labels_url":"https://api.github.com/repos/scala/scala/milestones/52/labels","id":1355301,"number":52,"title":"2.12.0-M5","description":"Merge to 2.12.x. \r\n\r\nLead: @lrytz\r\n\r\nIn order to meet our deadline, we will only accept new PRs that fix an issue scheduled for M5 over at https://github.com/scala/scala-dev/milestones/2.12.0-M5 (no longer accepting new issues as of May 2). \r\n\r\nNOTE: We always accept more tests/docs -- this restriction aims to avoid PRs that change functionality or may otherwise cause regressions and release date slips.\r\n\r\nLukas informed scala-internals about this on April 22nd. For urgent/critical issues, exceptions will be considered after discussion on scala-internals.\r\n\r\nThe deadline currently stands at June 3rd (originally it was one week earlier). We're working hard to beat this date, and will cut the release as soon as we've made our way through the PR queue.","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":64,"state":"open","created_at":"2015-10-14T13:06:29Z","updated_at":"2016-05-18T07:45:24Z","due_on":"2016-06-03T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/5164/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/5164/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/5164/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/967a75989d758e16f0be5839b7500a50a7647b88","head":{"label":"viktorklang:wip-future-docs-√","ref":"wip-future-docs-√","sha":"967a75989d758e16f0be5839b7500a50a7647b88","user":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"repo":{"id":54978305,"name":"scala","full_name":"viktorklang/scala","owner":{"login":"viktorklang","id":10871,"avatar_url":"https://avatars.githubusercontent.com/u/10871?v=3","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viktorklang/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/viktorklang/scala","forks_url":"https://api.github.com/repos/viktorklang/scala/forks","keys_url":"https://api.github.com/repos/viktorklang/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viktorklang/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viktorklang/scala/teams","hooks_url":"https://api.github.com/repos/viktorklang/scala/hooks","issue_events_url":"https://api.github.com/repos/viktorklang/scala/issues/events{/number}","events_url":"https://api.github.com/repos/viktorklang/scala/events","assignees_url":"https://api.github.com/repos/viktorklang/scala/assignees{/user}","branches_url":"https://api.github.com/repos/viktorklang/scala/branches{/branch}","tags_url":"https://api.github.com/repos/viktorklang/scala/tags","blobs_url":"https://api.github.com/repos/viktorklang/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viktorklang/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viktorklang/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/viktorklang/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viktorklang/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/viktorklang/scala/languages","stargazers_url":"https://api.github.com/repos/viktorklang/scala/stargazers","contributors_url":"https://api.github.com/repos/viktorklang/scala/contributors","subscribers_url":"https://api.github.com/repos/viktorklang/scala/subscribers","subscription_url":"https://api.github.com/repos/viktorklang/scala/subscription","commits_url":"https://api.github.com/repos/viktorklang/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/viktorklang/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/viktorklang/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/viktorklang/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/viktorklang/scala/contents/{+path}","compare_url":"https://api.github.com/repos/viktorklang/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viktorklang/scala/merges","archive_url":"https://api.github.com/repos/viktorklang/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viktorklang/scala/downloads","issues_url":"https://api.github.com/repos/viktorklang/scala/issues{/number}","pulls_url":"https://api.github.com/repos/viktorklang/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/viktorklang/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/viktorklang/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viktorklang/scala/labels{/name}","releases_url":"https://api.github.com/repos/viktorklang/scala/releases{/id}","deployments_url":"https://api.github.com/repos/viktorklang/scala/deployments","created_at":"2016-03-29T13:31:48Z","updated_at":"2016-03-29T13:32:09Z","pushed_at":"2016-05-17T11:28:20Z","git_url":"git://github.com/viktorklang/scala.git","ssh_url":"git@github.com:viktorklang/scala.git","clone_url":"https://github.com/viktorklang/scala.git","svn_url":"https://github.com/viktorklang/scala","homepage":"http://www.scala-lang.org/","size":85298,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"2.12.x"}},"base":{"label":"scala:2.12.x","ref":"2.12.x","sha":"eac1af364e99a6712c5e54e257216027b2ab127e","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","deployments_url":"https://api.github.com/repos/scala/scala/deployments","created_at":"2011-12-01T05:02:34Z","updated_at":"2016-05-18T09:43:33Z","pushed_at":"2016-05-18T07:45:24Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":143513,"stargazers_count":6153,"watchers_count":6153,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1551,"mirror_url":null,"open_issues_count":51,"forks":1551,"open_issues":51,"watchers":6153,"default_branch":"2.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/5164"},"html":{"href":"https://github.com/scala/scala/pull/5164"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/5164"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/5164/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/5164/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/5164/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/967a75989d758e16f0be5839b7500a50a7647b88"}}}}