{"action":"created","issue":{"url":"https://api.github.com/repos/domenic/chai-as-promised/issues/122","repository_url":"https://api.github.com/repos/domenic/chai-as-promised","labels_url":"https://api.github.com/repos/domenic/chai-as-promised/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/domenic/chai-as-promised/issues/122/comments","events_url":"https://api.github.com/repos/domenic/chai-as-promised/issues/122/events","html_url":"https://github.com/domenic/chai-as-promised/pull/122","id":103103771,"number":122,"title":"Support jQuery >= 3.0.0","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-25T19:57:21Z","updated_at":"2016-03-15T00:16:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/domenic/chai-as-promised/pulls/122","html_url":"https://github.com/domenic/chai-as-promised/pull/122","diff_url":"https://github.com/domenic/chai-as-promised/pull/122.diff","patch_url":"https://github.com/domenic/chai-as-promised/pull/122.patch"},"body":"I need some help here. I tried to mimick `when` config; when I run `npm run test-browser-jquery`, I get 3 failures (much better than >100 of them with jQuery 2.1.4 but still):\r\n![screen shot 2015-08-25 at 21 53 47](https://cloud.githubusercontent.com/assets/1758366/9477749/e2c55458-4b73-11e5-889a-8e218e74183e.png)\r\n![screen shot 2015-08-25 at 21 53 57](https://cloud.githubusercontent.com/assets/1758366/9477751/e54c8be2-4b73-11e5-8f13-c529c17be89d.png)\r\n\r\nFirst of them is in [lib/chai-as-promised.js#L308](https://github.com/mzgol/chai-as-promised/blob/c90ec43884a960da64c026b3c809ee9a88c7cfcf/lib/chai-as-promised.js#L308) where `args` is set to `\"test it\"` and should be an array-like.\r\n\r\nWhat's the expected definition of `global.waitAll`? Test results didn't change when I removed it; is it needed?\r\n\r\nI wasn't sure what version you want to include so I used the link to the latest `master` one as I believe that's what you have for `when`. I can change it to `3.0.0-alpha1` if you prefer it to be more deterministic.\r\n\r\nThere are two bugs related to jQuery Deferreds that I linked in the adapter file (they should both be fixed before the final 3.0.0) but they're both with `jQuery.when`, not `thenable.then`; the latter should work."},"comment":{"url":"https://api.github.com/repos/domenic/chai-as-promised/issues/comments/196581612","html_url":"https://github.com/domenic/chai-as-promised/pull/122#issuecomment-196581612","issue_url":"https://api.github.com/repos/domenic/chai-as-promised/issues/122","id":196581612,"user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T00:16:25Z","updated_at":"2016-03-15T00:16:25Z","body":"@domenic Done."}}