{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/comments/80843820","pull_request_review_id":1868221,"id":80843820,"diff_hunk":"@@ -74,11 +74,16 @@ public UserDto findUserById(@PathVariable final String email, final HttpServletR\n             @ApiResponse(code = 201, message=\"User created\", responseHeaders = { @ResponseHeader(name = \"Location\", description = \"The URL to retrieve created resource\", response = String.class) }),\n             @ApiResponse(code = 204, message=\"User updated\", responseHeaders = { @ResponseHeader(name = \"Location\", description = \"The URL to retrieve created resource\", response = String.class) })\n     })\n-    public UserDto saveStudent(@RequestBody final UserDto userDto, final HttpServletRequest request, final HttpServletResponse response) throws IOException {\n-        UserUpsert userUpsert = externalUserService.upsertUser(UserMapper.mapTo(userDto));\n-        response.setStatus(userUpsert.isInsert() ? HttpServletResponse.SC_CREATED : HttpServletResponse.SC_NO_CONTENT);\n-        response.setHeader(\"Location\", request.getRequestURL().toString() + \"/\" + userUpsert.getUser().getEmail() + \"/details\");\n-        return UserMapper.mapFrom(userUpsert.getUser());\n+    public String saveStudent(@RequestBody final UserDto userDto, final HttpServletRequest request, final HttpServletResponse response) throws Exception {\n+        try {\n+            UserUpsert userUpsert = externalUserService.upsertUser(UserMapper.mapTo(userDto));","path":"rest/src/main/java/org/opentestsystem/delivery/testreg/rest/ExternalUserController.java","position":11,"original_position":11,"commit_id":"750504ee86ba68c08b0062784b2288ea99846193","original_commit_id":"750504ee86ba68c08b0062784b2288ea99846193","user":{"login":"jtreuting","id":341584,"avatar_url":"https://avatars.githubusercontent.com/u/341584?v=3","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},"body":"I forget exactly how their interceptor works but I'm tempted to say that we should keep it the same for consistency since we aren't rewriting this.  But we should probably go over that offline.","created_at":"2016-09-28T05:07:10Z","updated_at":"2016-09-28T05:12:32Z","html_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2#discussion_r80843820","pull_request_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/comments/80843820"},"html":{"href":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2#discussion_r80843820"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2","id":87025546,"html_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2","diff_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2.diff","patch_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2.patch","issue_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/2","number":2,"state":"open","locked":false,"title":"Feature/userapibug","user":{"login":"hbgwhite","id":1069704,"avatar_url":"https://avatars.githubusercontent.com/u/1069704?v=3","gravatar_id":"","url":"https://api.github.com/users/hbgwhite","html_url":"https://github.com/hbgwhite","followers_url":"https://api.github.com/users/hbgwhite/followers","following_url":"https://api.github.com/users/hbgwhite/following{/other_user}","gists_url":"https://api.github.com/users/hbgwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/hbgwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbgwhite/subscriptions","organizations_url":"https://api.github.com/users/hbgwhite/orgs","repos_url":"https://api.github.com/users/hbgwhite/repos","events_url":"https://api.github.com/users/hbgwhite/events{/privacy}","received_events_url":"https://api.github.com/users/hbgwhite/received_events","type":"User","site_admin":false},"body":"Please review if you have time!","created_at":"2016-09-27T22:39:04Z","updated_at":"2016-09-28T05:12:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8177e191467d1b2dfe9eb678549504f8115cddf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/2/comments","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/statuses/750504ee86ba68c08b0062784b2288ea99846193","head":{"label":"SmarterApp:feature/userapibug","ref":"feature/userapibug","sha":"750504ee86ba68c08b0062784b2288ea99846193","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60313658,"name":"TDS_AdministrationAndRegistrationTools","full_name":"SmarterApp/TDS_AdministrationAndRegistrationTools","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools","description":"","fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools","forks_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/deployments","created_at":"2016-06-03T02:54:34Z","updated_at":"2016-06-29T23:30:41Z","pushed_at":"2016-09-27T22:39:05Z","git_url":"git://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools.git","ssh_url":"git@github.com:SmarterApp/TDS_AdministrationAndRegistrationTools.git","clone_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools.git","svn_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools","homepage":null,"size":38706,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"1a83e06d47446b20f86d1171705f40400b5ec925","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60313658,"name":"TDS_AdministrationAndRegistrationTools","full_name":"SmarterApp/TDS_AdministrationAndRegistrationTools","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools","description":"","fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools","forks_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/deployments","created_at":"2016-06-03T02:54:34Z","updated_at":"2016-06-29T23:30:41Z","pushed_at":"2016-09-27T22:39:05Z","git_url":"git://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools.git","ssh_url":"git@github.com:SmarterApp/TDS_AdministrationAndRegistrationTools.git","clone_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools.git","svn_url":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools","homepage":null,"size":38706,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2"},"html":{"href":"https://github.com/SmarterApp/TDS_AdministrationAndRegistrationTools/pull/2"},"issue":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/2"},"comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/TDS_AdministrationAndRegistrationTools/statuses/750504ee86ba68c08b0062784b2288ea99846193"}}}}
{"actor":{"display_login":"jtreuting"}}