{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/75426948","id":75426948,"diff_hunk":"@@ -438,13 +438,13 @@ class QSorted : public Quadrature<dim>\n   /**\n    * The constructor takes an arbitrary quadrature formula.\n    */\n-  QSorted (const Quadrature<dim>);\n+  QSorted (const Quadrature<dim> &quad);\n \n   /**\n    * A rule to reorder pairs of points and weights.\n    */\n-  bool operator()(const std::pair<double, Point<dim> > &a,\n-                  const std::pair<double, Point<dim> > &b);\n+  bool operator()(const std::size_t &a,\n+                  const std::size_t &b) const;","path":"include/deal.II/base/quadrature_lib.h","position":13,"original_position":13,"commit_id":"e38693c67e5be5afd5270696320eca596e564053","original_commit_id":"e38693c67e5be5afd5270696320eca596e564053","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"maybe mentioning `std::sort` as well, so that it's clear why this function is here.","created_at":"2016-08-19T04:44:39Z","updated_at":"2016-08-19T04:44:39Z","html_url":"https://github.com/dealii/dealii/pull/2989#discussion_r75426948","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/2989","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/75426948"},"html":{"href":"https://github.com/dealii/dealii/pull/2989#discussion_r75426948"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2989"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2989","id":81911889,"html_url":"https://github.com/dealii/dealii/pull/2989","diff_url":"https://github.com/dealii/dealii/pull/2989.diff","patch_url":"https://github.com/dealii/dealii/pull/2989.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2989","number":2989,"state":"open","locked":false,"title":"Improve QSorted constructor","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"body":"When profiling an ASPECT model I noticed that we spend significant time (~15 % of total runtime in my biased test case) in the constructor of QSorted. This puzzled me, and I will open another PR that suggests to reduce the number of times QSorted is constructed. As a first step this PR optimizes the constructor itself. According to callgrind this change should reduce the number of CPU cycles by around 15%, which I could confirm for my 2D test case (a total model runtime reduction of 2-4% or so in debug and even more in release mode). Since this change should be not critical, I open this as a separate PR.\r\nLet me know if you see other possible improvements, or problems.","created_at":"2016-08-19T00:54:28Z","updated_at":"2016-08-19T04:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09e4572fb366b4cb0bf480e68bf45fdb648a2319","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/2989/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/2989/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2989/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/e38693c67e5be5afd5270696320eca596e564053","head":{"label":"gassmoeller:optimize_qsorted_constructor","ref":"optimize_qsorted_constructor","sha":"e38693c67e5be5afd5270696320eca596e564053","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"repo":{"id":42511636,"name":"dealii","full_name":"gassmoeller/dealii","owner":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars.githubusercontent.com/u/7582930?v=3","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gassmoeller/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/gassmoeller/dealii","forks_url":"https://api.github.com/repos/gassmoeller/dealii/forks","keys_url":"https://api.github.com/repos/gassmoeller/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gassmoeller/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gassmoeller/dealii/teams","hooks_url":"https://api.github.com/repos/gassmoeller/dealii/hooks","issue_events_url":"https://api.github.com/repos/gassmoeller/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/gassmoeller/dealii/events","assignees_url":"https://api.github.com/repos/gassmoeller/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/gassmoeller/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/gassmoeller/dealii/tags","blobs_url":"https://api.github.com/repos/gassmoeller/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gassmoeller/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gassmoeller/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/gassmoeller/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gassmoeller/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/gassmoeller/dealii/languages","stargazers_url":"https://api.github.com/repos/gassmoeller/dealii/stargazers","contributors_url":"https://api.github.com/repos/gassmoeller/dealii/contributors","subscribers_url":"https://api.github.com/repos/gassmoeller/dealii/subscribers","subscription_url":"https://api.github.com/repos/gassmoeller/dealii/subscription","commits_url":"https://api.github.com/repos/gassmoeller/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/gassmoeller/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/gassmoeller/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/gassmoeller/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/gassmoeller/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/gassmoeller/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gassmoeller/dealii/merges","archive_url":"https://api.github.com/repos/gassmoeller/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gassmoeller/dealii/downloads","issues_url":"https://api.github.com/repos/gassmoeller/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/gassmoeller/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/gassmoeller/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/gassmoeller/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gassmoeller/dealii/labels{/name}","releases_url":"https://api.github.com/repos/gassmoeller/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/gassmoeller/dealii/deployments","created_at":"2015-09-15T10:33:38Z","updated_at":"2015-09-15T10:34:47Z","pushed_at":"2016-08-19T00:56:14Z","git_url":"git://github.com/gassmoeller/dealii.git","ssh_url":"git@github.com:gassmoeller/dealii.git","clone_url":"https://github.com/gassmoeller/dealii.git","svn_url":"https://github.com/gassmoeller/dealii","homepage":"http://www.dealii.org/","size":145881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"674234a2d09776ee18e6b1a8145677415d8f91fa","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-08-14T06:42:22Z","pushed_at":"2016-08-19T02:41:55Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":166582,"stargazers_count":165,"watchers_count":165,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":178,"forks":181,"open_issues":178,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2989"},"html":{"href":"https://github.com/dealii/dealii/pull/2989"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/2989"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/2989/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2989/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2989/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/e38693c67e5be5afd5270696320eca596e564053"}}}}
{"actor":{"display_login":"davydden"}}