{"action":"closed","number":259,"pull_request":{"url":"https://api.github.com/repos/dropbox/djinni/pulls/259","id":79121613,"html_url":"https://github.com/dropbox/djinni/pull/259","diff_url":"https://github.com/dropbox/djinni/pull/259.diff","patch_url":"https://github.com/dropbox/djinni/pull/259.patch","issue_url":"https://api.github.com/repos/dropbox/djinni/issues/259","number":259,"state":"closed","locked":false,"title":"Fix enum compile issue in C++11","user":{"login":"artwyman","id":1761206,"avatar_url":"https://avatars.githubusercontent.com/u/1761206?v=3","gravatar_id":"","url":"https://api.github.com/users/artwyman","html_url":"https://github.com/artwyman","followers_url":"https://api.github.com/users/artwyman/followers","following_url":"https://api.github.com/users/artwyman/following{/other_user}","gists_url":"https://api.github.com/users/artwyman/gists{/gist_id}","starred_url":"https://api.github.com/users/artwyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artwyman/subscriptions","organizations_url":"https://api.github.com/users/artwyman/orgs","repos_url":"https://api.github.com/users/artwyman/repos","events_url":"https://api.github.com/users/artwyman/events{/privacy}","received_events_url":"https://api.github.com/users/artwyman/received_events","type":"User","site_admin":false},"body":"Fix for #213 and alternative to #251.\r\n\r\nThe fix involved introducing a DBMyEnum+Private.h generated file, in order to include my_enum.hpp only where necessary (in the ObjC++ private sources).  I needed to generate the new files to maintain the assumption (in the generators, and yams definitions) that each type needs only one header for marshaling.\r\n\r\nIn order to validate this properly, I converted the test-suite to use C++11 rather than C++14, which is a good idea since Djinni is intended to work with C++11.  This conversion required importing a reference definition of std::experimental::optional.\r\n\r\nI can merge this myself, but am posting here for comment.  I'm particularly hoping that @steweg will try this out to confirm that it fixes his issue, and that @xianwen and @mknejp will take a look and comment.","created_at":"2016-07-28T00:45:57Z","updated_at":"2016-08-05T02:03:32Z","closed_at":"2016-08-05T02:03:32Z","merged_at":"2016-08-05T02:03:32Z","merge_commit_sha":"3a24d6fc632923de61ac1582fdc02e346348db77","assignee":{"login":"artwyman","id":1761206,"avatar_url":"https://avatars.githubusercontent.com/u/1761206?v=3","gravatar_id":"","url":"https://api.github.com/users/artwyman","html_url":"https://github.com/artwyman","followers_url":"https://api.github.com/users/artwyman/followers","following_url":"https://api.github.com/users/artwyman/following{/other_user}","gists_url":"https://api.github.com/users/artwyman/gists{/gist_id}","starred_url":"https://api.github.com/users/artwyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artwyman/subscriptions","organizations_url":"https://api.github.com/users/artwyman/orgs","repos_url":"https://api.github.com/users/artwyman/repos","events_url":"https://api.github.com/users/artwyman/events{/privacy}","received_events_url":"https://api.github.com/users/artwyman/received_events","type":"User","site_admin":false},"assignees":[{"login":"artwyman","id":1761206,"avatar_url":"https://avatars.githubusercontent.com/u/1761206?v=3","gravatar_id":"","url":"https://api.github.com/users/artwyman","html_url":"https://github.com/artwyman","followers_url":"https://api.github.com/users/artwyman/followers","following_url":"https://api.github.com/users/artwyman/following{/other_user}","gists_url":"https://api.github.com/users/artwyman/gists{/gist_id}","starred_url":"https://api.github.com/users/artwyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artwyman/subscriptions","organizations_url":"https://api.github.com/users/artwyman/orgs","repos_url":"https://api.github.com/users/artwyman/repos","events_url":"https://api.github.com/users/artwyman/events{/privacy}","received_events_url":"https://api.github.com/users/artwyman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/djinni/pulls/259/commits","review_comments_url":"https://api.github.com/repos/dropbox/djinni/pulls/259/comments","review_comment_url":"https://api.github.com/repos/dropbox/djinni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/djinni/issues/259/comments","statuses_url":"https://api.github.com/repos/dropbox/djinni/statuses/22fb0167035ab5807bff7b78a40c1166a61046a9","head":{"label":"dropbox:AT/WIP/EnumFix","ref":"AT/WIP/EnumFix","sha":"22fb0167035ab5807bff7b78a40c1166a61046a9","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":23806326,"name":"djinni","full_name":"dropbox/djinni","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/djinni","description":"A tool for generating cross-language type declarations and interface bindings.","fork":false,"url":"https://api.github.com/repos/dropbox/djinni","forks_url":"https://api.github.com/repos/dropbox/djinni/forks","keys_url":"https://api.github.com/repos/dropbox/djinni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/djinni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/djinni/teams","hooks_url":"https://api.github.com/repos/dropbox/djinni/hooks","issue_events_url":"https://api.github.com/repos/dropbox/djinni/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/djinni/events","assignees_url":"https://api.github.com/repos/dropbox/djinni/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/djinni/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/djinni/tags","blobs_url":"https://api.github.com/repos/dropbox/djinni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/djinni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/djinni/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/djinni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/djinni/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/djinni/languages","stargazers_url":"https://api.github.com/repos/dropbox/djinni/stargazers","contributors_url":"https://api.github.com/repos/dropbox/djinni/contributors","subscribers_url":"https://api.github.com/repos/dropbox/djinni/subscribers","subscription_url":"https://api.github.com/repos/dropbox/djinni/subscription","commits_url":"https://api.github.com/repos/dropbox/djinni/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/djinni/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/djinni/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/djinni/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/djinni/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/djinni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/djinni/merges","archive_url":"https://api.github.com/repos/dropbox/djinni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/djinni/downloads","issues_url":"https://api.github.com/repos/dropbox/djinni/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/djinni/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/djinni/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/djinni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/djinni/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/djinni/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/djinni/deployments","created_at":"2014-09-08T20:09:32Z","updated_at":"2016-08-04T20:27:02Z","pushed_at":"2016-08-05T02:03:32Z","git_url":"git://github.com/dropbox/djinni.git","ssh_url":"git@github.com:dropbox/djinni.git","clone_url":"https://github.com/dropbox/djinni.git","svn_url":"https://github.com/dropbox/djinni","homepage":"","size":3960,"stargazers_count":1214,"watchers_count":1214,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":56,"forks":192,"open_issues":56,"watchers":1214,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"f4ce76016ddd1a06243b2db4218345536e5e9793","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":23806326,"name":"djinni","full_name":"dropbox/djinni","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/djinni","description":"A tool for generating cross-language type declarations and interface bindings.","fork":false,"url":"https://api.github.com/repos/dropbox/djinni","forks_url":"https://api.github.com/repos/dropbox/djinni/forks","keys_url":"https://api.github.com/repos/dropbox/djinni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/djinni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/djinni/teams","hooks_url":"https://api.github.com/repos/dropbox/djinni/hooks","issue_events_url":"https://api.github.com/repos/dropbox/djinni/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/djinni/events","assignees_url":"https://api.github.com/repos/dropbox/djinni/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/djinni/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/djinni/tags","blobs_url":"https://api.github.com/repos/dropbox/djinni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/djinni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/djinni/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/djinni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/djinni/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/djinni/languages","stargazers_url":"https://api.github.com/repos/dropbox/djinni/stargazers","contributors_url":"https://api.github.com/repos/dropbox/djinni/contributors","subscribers_url":"https://api.github.com/repos/dropbox/djinni/subscribers","subscription_url":"https://api.github.com/repos/dropbox/djinni/subscription","commits_url":"https://api.github.com/repos/dropbox/djinni/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/djinni/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/djinni/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/djinni/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/djinni/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/djinni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/djinni/merges","archive_url":"https://api.github.com/repos/dropbox/djinni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/djinni/downloads","issues_url":"https://api.github.com/repos/dropbox/djinni/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/djinni/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/djinni/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/djinni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/djinni/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/djinni/releases{/id}","deployments_url":"https://api.github.com/repos/dropbox/djinni/deployments","created_at":"2014-09-08T20:09:32Z","updated_at":"2016-08-04T20:27:02Z","pushed_at":"2016-08-05T02:03:32Z","git_url":"git://github.com/dropbox/djinni.git","ssh_url":"git@github.com:dropbox/djinni.git","clone_url":"https://github.com/dropbox/djinni.git","svn_url":"https://github.com/dropbox/djinni","homepage":"","size":3960,"stargazers_count":1214,"watchers_count":1214,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":56,"forks":192,"open_issues":56,"watchers":1214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/259"},"html":{"href":"https://github.com/dropbox/djinni/pull/259"},"issue":{"href":"https://api.github.com/repos/dropbox/djinni/issues/259"},"comments":{"href":"https://api.github.com/repos/dropbox/djinni/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/djinni/statuses/22fb0167035ab5807bff7b78a40c1166a61046a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"artwyman","id":1761206,"avatar_url":"https://avatars.githubusercontent.com/u/1761206?v=3","gravatar_id":"","url":"https://api.github.com/users/artwyman","html_url":"https://github.com/artwyman","followers_url":"https://api.github.com/users/artwyman/followers","following_url":"https://api.github.com/users/artwyman/following{/other_user}","gists_url":"https://api.github.com/users/artwyman/gists{/gist_id}","starred_url":"https://api.github.com/users/artwyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artwyman/subscriptions","organizations_url":"https://api.github.com/users/artwyman/orgs","repos_url":"https://api.github.com/users/artwyman/repos","events_url":"https://api.github.com/users/artwyman/events{/privacy}","received_events_url":"https://api.github.com/users/artwyman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":3,"commits":4,"additions":1879,"deletions":290,"changed_files":46}}
{"actor":{"display_login":"artwyman"}}