{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/90742829","pull_request_review_id":11263919,"id":90742829,"diff_hunk":"@@ -496,8 +496,35 @@ function _getI18nAttr(p: html.Element): html.Attribute {\n   return p.attrs.find(attr => attr.name === _I18N_ATTR) || null;\n }\n \n-function _splitMeaningAndDesc(i18n: string): [string, string] {\n-  if (!i18n) return ['', ''];\n+function _parseI18nAttribute(i18n: string): [string, string, string] {","path":"modules/@angular/compiler/src/i18n/extractor_merger.ts","position":44,"original_position":44,"commit_id":"201332f6602bb28cc612cb3c49d5501fa0c94f8a","original_commit_id":"201332f6602bb28cc612cb3c49d5501fa0c94f8a","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"open question: change the return type to `{m, d, id}` ?","created_at":"2016-12-03T00:24:02Z","updated_at":"2016-12-03T00:24:02Z","html_url":"https://github.com/angular/angular/pull/13201#discussion_r90742829","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/13201","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/90742829"},"html":{"href":"https://github.com/angular/angular/pull/13201#discussion_r90742829"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/13201"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/13201","id":96282340,"html_url":"https://github.com/angular/angular/pull/13201","diff_url":"https://github.com/angular/angular/pull/13201.diff","patch_url":"https://github.com/angular/angular/pull/13201.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/13201","number":13201,"state":"open","locked":false,"title":"I18n explicit ids","user":{"login":"maxime-allex","id":1384415,"avatar_url":"https://avatars.githubusercontent.com/u/1384415?v=3","gravatar_id":"","url":"https://api.github.com/users/maxime-allex","html_url":"https://github.com/maxime-allex","followers_url":"https://api.github.com/users/maxime-allex/followers","following_url":"https://api.github.com/users/maxime-allex/following{/other_user}","gists_url":"https://api.github.com/users/maxime-allex/gists{/gist_id}","starred_url":"https://api.github.com/users/maxime-allex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxime-allex/subscriptions","organizations_url":"https://api.github.com/users/maxime-allex/orgs","repos_url":"https://api.github.com/users/maxime-allex/repos","events_url":"https://api.github.com/users/maxime-allex/events{/privacy}","received_events_url":"https://api.github.com/users/maxime-allex/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[ ] Bugfix\r\n[x] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nSee [[i18n] enable control over translation message ID](https://github.com/angular/angular/issues/12941)\r\n\r\n\r\n**What is the new behavior?**\r\nDeveloper can now use specific ID in translations by adding a new \"parameter\" in the i18n attribute : \r\n```html\r\n<p i18n=\"meaning|description@id\">foo</p>\r\n<!-- i18n: meaning1|desc1@id1 -->bar<!-- /i18n -->\r\n```\r\n\r\nwill produce for XMB : \r\n\r\n```xml\r\n<msg id=\"id\" meaning=\"meaning\" description=\"description\">foo</msg>\r\n<msg id=\"id1\" meaning=\"meaning1\" description=\"description1\">foo</msg>\r\n```\r\n\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n","created_at":"2016-12-02T13:48:19Z","updated_at":"2016-12-03T00:24:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4467b95a7baf0f13443d687a096c17438b2dee1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/13201/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/13201/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/13201/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/201332f6602bb28cc612cb3c49d5501fa0c94f8a","head":{"label":"Linkurious:i18n-explicitID","ref":"i18n-explicitID","sha":"201332f6602bb28cc612cb3c49d5501fa0c94f8a","user":{"login":"Linkurious","id":5114457,"avatar_url":"https://avatars.githubusercontent.com/u/5114457?v=3","gravatar_id":"","url":"https://api.github.com/users/Linkurious","html_url":"https://github.com/Linkurious","followers_url":"https://api.github.com/users/Linkurious/followers","following_url":"https://api.github.com/users/Linkurious/following{/other_user}","gists_url":"https://api.github.com/users/Linkurious/gists{/gist_id}","starred_url":"https://api.github.com/users/Linkurious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linkurious/subscriptions","organizations_url":"https://api.github.com/users/Linkurious/orgs","repos_url":"https://api.github.com/users/Linkurious/repos","events_url":"https://api.github.com/users/Linkurious/events{/privacy}","received_events_url":"https://api.github.com/users/Linkurious/received_events","type":"Organization","site_admin":false},"repo":{"id":75290693,"name":"angular","full_name":"Linkurious/angular","owner":{"login":"Linkurious","id":5114457,"avatar_url":"https://avatars.githubusercontent.com/u/5114457?v=3","gravatar_id":"","url":"https://api.github.com/users/Linkurious","html_url":"https://github.com/Linkurious","followers_url":"https://api.github.com/users/Linkurious/followers","following_url":"https://api.github.com/users/Linkurious/following{/other_user}","gists_url":"https://api.github.com/users/Linkurious/gists{/gist_id}","starred_url":"https://api.github.com/users/Linkurious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linkurious/subscriptions","organizations_url":"https://api.github.com/users/Linkurious/orgs","repos_url":"https://api.github.com/users/Linkurious/repos","events_url":"https://api.github.com/users/Linkurious/events{/privacy}","received_events_url":"https://api.github.com/users/Linkurious/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linkurious/angular","description":null,"fork":true,"url":"https://api.github.com/repos/Linkurious/angular","forks_url":"https://api.github.com/repos/Linkurious/angular/forks","keys_url":"https://api.github.com/repos/Linkurious/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linkurious/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linkurious/angular/teams","hooks_url":"https://api.github.com/repos/Linkurious/angular/hooks","issue_events_url":"https://api.github.com/repos/Linkurious/angular/issues/events{/number}","events_url":"https://api.github.com/repos/Linkurious/angular/events","assignees_url":"https://api.github.com/repos/Linkurious/angular/assignees{/user}","branches_url":"https://api.github.com/repos/Linkurious/angular/branches{/branch}","tags_url":"https://api.github.com/repos/Linkurious/angular/tags","blobs_url":"https://api.github.com/repos/Linkurious/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linkurious/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linkurious/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linkurious/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linkurious/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/Linkurious/angular/languages","stargazers_url":"https://api.github.com/repos/Linkurious/angular/stargazers","contributors_url":"https://api.github.com/repos/Linkurious/angular/contributors","subscribers_url":"https://api.github.com/repos/Linkurious/angular/subscribers","subscription_url":"https://api.github.com/repos/Linkurious/angular/subscription","commits_url":"https://api.github.com/repos/Linkurious/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linkurious/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linkurious/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linkurious/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linkurious/angular/contents/{+path}","compare_url":"https://api.github.com/repos/Linkurious/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linkurious/angular/merges","archive_url":"https://api.github.com/repos/Linkurious/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linkurious/angular/downloads","issues_url":"https://api.github.com/repos/Linkurious/angular/issues{/number}","pulls_url":"https://api.github.com/repos/Linkurious/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/Linkurious/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/Linkurious/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linkurious/angular/labels{/name}","releases_url":"https://api.github.com/repos/Linkurious/angular/releases{/id}","deployments_url":"https://api.github.com/repos/Linkurious/angular/deployments","created_at":"2016-12-01T12:31:25Z","updated_at":"2016-12-01T12:31:46Z","pushed_at":"2016-12-02T14:03:36Z","git_url":"git://github.com/Linkurious/angular.git","ssh_url":"git@github.com:Linkurious/angular.git","clone_url":"https://github.com/Linkurious/angular.git","svn_url":"https://github.com/Linkurious/angular","homepage":"https://angular.io","size":33843,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"614a35d53982d6d15b3a2f53904f03c7840f8822","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":null,"fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-12-02T23:04:13Z","pushed_at":"2016-12-02T23:43:34Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":652868,"stargazers_count":18520,"watchers_count":18520,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4759,"mirror_url":null,"open_issues_count":970,"forks":4759,"open_issues":970,"watchers":18520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/13201"},"html":{"href":"https://github.com/angular/angular/pull/13201"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/13201"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/13201/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/13201/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/13201/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/201332f6602bb28cc612cb3c49d5501fa0c94f8a"}}}}
{"actor":{"display_login":"vicb"}}