{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/93960891","pull_request_review_id":14492038,"id":93960891,"diff_hunk":"@@ -5,8 +5,37 @@ CHANGELOG\n -----\n \n  * added `AppVariable::getToken()`\n- * Deprecated the possibility to inject the Form Twig Renderer into the form\n-   extension. Inject it on TwigRendererEngine instead.\n+ * Deprecated the possibility to inject the Form `TwigRenderer` into the `FormExtension`.\n+ * [BC BREAK] Registering the `FormExtension` without configuring a runtime loader for the `TwigRenderer` \n+   doesn't work anymore.\n+   \n+   Before:\n+\n+   ```php\n+   use Symfony\\Bridge\\Twig\\Extension\\FormExtension;\n+   use Symfony\\Bridge\\Twig\\Form\\TwigRenderer;\n+   use Symfony\\Bridge\\Twig\\Form\\TwigRendererEngine;\n+\n+   // ...\n+   $rendererEngine = new TwigRendererEngine(array('form_div_layout.html.twig'));\n+   $rendererEngine->setEnvironment($twig);\n+   $twig->addExtension(new FormExtension(new TwigRenderer($rendererEngine, $csrfTokenManager)));\n+   ```\n+\n+   After:\n+\n+   ```php\n+   // ...\n+   $rendererEngine = new TwigRendererEngine(array('form_div_layout.html.twig'), $twig);\n+   // require Twig 1.30+\n+   $twig->addRuntimeLoader(new Twig_FactoryRuntimeLoader(array(","path":"src/Symfony/Bridge/Twig/CHANGELOG.md","position":null,"original_position":29,"commit_id":"a7ebe9c1a4b22f163bb5da4eea39c1fe19ce57a0","original_commit_id":"dd6c21edf383c1d9908002ecb105ebc9588373b9","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2016-12-27T19:04:54Z","updated_at":"2016-12-27T19:04:54Z","html_url":"https://github.com/symfony/symfony/pull/21022#discussion_r93960891","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/21022","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/93960891"},"html":{"href":"https://github.com/symfony/symfony/pull/21022#discussion_r93960891"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21022"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/21022","id":99087457,"html_url":"https://github.com/symfony/symfony/pull/21022","diff_url":"https://github.com/symfony/symfony/pull/21022.diff","patch_url":"https://github.com/symfony/symfony/pull/21022.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/21022","number":21022,"state":"open","locked":false,"title":"[TwigBridge] Fix upgrade/changelog notes","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.2\r\n\r\nThe current upgrade note is wrong, the renderer cannot be injected in the `TwigRendererEngine`, only the Twig Environment can be.\r\nAlso added a missing note about the deprecated `TwigRendererEngineInterface`.","created_at":"2016-12-22T11:14:28Z","updated_at":"2016-12-27T19:04:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24806e2e35629a53bc5c35762c0364c06f898f09","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/9","html_url":"https://github.com/symfony/symfony/milestone/9","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/9/labels","id":2117463,"number":9,"title":"3.2","description":"https://symfony.com/roadmap?version=3.2#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":55,"state":"open","created_at":"2016-11-06T20:24:00Z","updated_at":"2016-12-27T09:59:41Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/21022/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/21022/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/21022/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/a7ebe9c1a4b22f163bb5da4eea39c1fe19ce57a0","head":{"label":"chalasr:twig-bridge/fix-upgrade-notes","ref":"twig-bridge/fix-upgrade-notes","sha":"a7ebe9c1a4b22f163bb5da4eea39c1fe19ce57a0","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"repo":{"id":56510160,"name":"symfony","full_name":"chalasr/symfony","owner":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalasr/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/chalasr/symfony","forks_url":"https://api.github.com/repos/chalasr/symfony/forks","keys_url":"https://api.github.com/repos/chalasr/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalasr/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalasr/symfony/teams","hooks_url":"https://api.github.com/repos/chalasr/symfony/hooks","issue_events_url":"https://api.github.com/repos/chalasr/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/chalasr/symfony/events","assignees_url":"https://api.github.com/repos/chalasr/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/chalasr/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/chalasr/symfony/tags","blobs_url":"https://api.github.com/repos/chalasr/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalasr/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalasr/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalasr/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalasr/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/chalasr/symfony/languages","stargazers_url":"https://api.github.com/repos/chalasr/symfony/stargazers","contributors_url":"https://api.github.com/repos/chalasr/symfony/contributors","subscribers_url":"https://api.github.com/repos/chalasr/symfony/subscribers","subscription_url":"https://api.github.com/repos/chalasr/symfony/subscription","commits_url":"https://api.github.com/repos/chalasr/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalasr/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalasr/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalasr/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalasr/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/chalasr/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalasr/symfony/merges","archive_url":"https://api.github.com/repos/chalasr/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalasr/symfony/downloads","issues_url":"https://api.github.com/repos/chalasr/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/chalasr/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/chalasr/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/chalasr/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalasr/symfony/labels{/name}","releases_url":"https://api.github.com/repos/chalasr/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/chalasr/symfony/deployments","created_at":"2016-04-18T13:30:14Z","updated_at":"2016-04-18T13:30:30Z","pushed_at":"2016-12-27T19:04:31Z","git_url":"git://github.com/chalasr/symfony.git","ssh_url":"git@github.com:chalasr/symfony.git","clone_url":"https://github.com/chalasr/symfony.git","svn_url":"https://github.com/chalasr/symfony","homepage":"symfony.com","size":78961,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:3.2","ref":"3.2","sha":"31e79ef3498fb10f5238657e81ef4a567364bcd6","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-12-27T17:31:02Z","pushed_at":"2016-12-27T19:04:35Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":82099,"stargazers_count":13532,"watchers_count":13532,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5252,"mirror_url":null,"open_issues_count":888,"forks":5252,"open_issues":888,"watchers":13532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21022"},"html":{"href":"https://github.com/symfony/symfony/pull/21022"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/21022"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/21022/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21022/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21022/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/a7ebe9c1a4b22f163bb5da4eea39c1fe19ce57a0"}}}}
{"actor":{"display_login":"chalasr"}}