{"action":"created","comment":{"url":"https://api.github.com/repos/fog/fog-openstack/pulls/comments/79442728","id":79442728,"diff_hunk":"@@ -12,13 +12,13 @@\n \n # setup the service object\n       @service = Fog::Image::OpenStack.new({\n-                                               :openstack_auth_url => \"#{@os_auth_url}/auth/tokens\",\n-                                               :openstack_region => ENV['OS_REGION_NAME'] || 'RegionOne',\n-                                               :openstack_api_key => ENV['OS_PASSWORD'] || 'password',\n-                                               :openstack_username => ENV['OS_USERNAME'] || 'admin',\n-                                               :openstack_domain_name => ENV['OS_USER_DOMAIN_NAME'] || 'Default',\n-                                               :openstack_project_name => ENV['OS_PROJECT_NAME'] || 'admin'\n-                                           }) unless @service\n+        :openstack_auth_url       => \"#{@os_auth_url}/auth/tokens\",","path":"spec/image_v2_upload_spec.rb","position":11,"original_position":11,"commit_id":"99a4879013f6b44d891b7dc6ea6f50f5dcc50dc3","original_commit_id":"99a4879013f6b44d891b7dc6ea6f50f5dcc50dc3","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Align the elements of a hash literal if they span more than one line.<br>Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.","created_at":"2016-09-19T17:22:55Z","updated_at":"2016-09-19T17:22:55Z","html_url":"https://github.com/fog/fog-openstack/pull/170#discussion_r79442728","pull_request_url":"https://api.github.com/repos/fog/fog-openstack/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/comments/79442728"},"html":{"href":"https://github.com/fog/fog-openstack/pull/170#discussion_r79442728"},"pull_request":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/fog/fog-openstack/pulls/170","id":79963794,"html_url":"https://github.com/fog/fog-openstack/pull/170","diff_url":"https://github.com/fog/fog-openstack/pull/170.diff","patch_url":"https://github.com/fog/fog-openstack/pull/170.patch","issue_url":"https://api.github.com/repos/fog/fog-openstack/issues/170","number":170,"state":"open","locked":false,"title":"Make image_v2 models more consistent with Fog API","user":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"body":"We would like our project to support both v1 and v2 Image APIs as some OpenStack deployments might only support one or the other. However, this gem makes a couple breaking changes in the v2 Image implementation:\r\n- Images cannot be reloaded\r\n- `image.save` always calls create even if the image already exists\r\n- `image.update` must be passed a hash, which breaks the pattern of setting instance variables then calling `image.save`\r\n\r\nWe also made a couple cosmetic changes, such as allowing `identity_v3_spec.rb` to use the VCR variables when `use_recorded` is true.\r\n\r\nAfter this patch is merged, https://github.com/fog/fog-openstack/issues/78 can be closed.\r\n\r\nLet us know if something looks amiss and we'll take another crack at it. Thanks!","created_at":"2016-08-03T19:25:39Z","updated_at":"2016-09-19T17:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ef82daaf8f69f529a1663327d52786283be4a15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fog/fog-openstack/pulls/170/commits","review_comments_url":"https://api.github.com/repos/fog/fog-openstack/pulls/170/comments","review_comment_url":"https://api.github.com/repos/fog/fog-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fog/fog-openstack/issues/170/comments","statuses_url":"https://api.github.com/repos/fog/fog-openstack/statuses/99a4879013f6b44d891b7dc6ea6f50f5dcc50dc3","head":{"label":"ljfranklin:PR-image-v2-update-identity","ref":"PR-image-v2-update-identity","sha":"99a4879013f6b44d891b7dc6ea6f50f5dcc50dc3","user":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"repo":{"id":64801313,"name":"fog-openstack","full_name":"ljfranklin/fog-openstack","owner":{"login":"ljfranklin","id":1923644,"avatar_url":"https://avatars.githubusercontent.com/u/1923644?v=3","gravatar_id":"","url":"https://api.github.com/users/ljfranklin","html_url":"https://github.com/ljfranklin","followers_url":"https://api.github.com/users/ljfranklin/followers","following_url":"https://api.github.com/users/ljfranklin/following{/other_user}","gists_url":"https://api.github.com/users/ljfranklin/gists{/gist_id}","starred_url":"https://api.github.com/users/ljfranklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljfranklin/subscriptions","organizations_url":"https://api.github.com/users/ljfranklin/orgs","repos_url":"https://api.github.com/users/ljfranklin/repos","events_url":"https://api.github.com/users/ljfranklin/events{/privacy}","received_events_url":"https://api.github.com/users/ljfranklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljfranklin/fog-openstack","description":"Fog for OpenStack Platform","fork":true,"url":"https://api.github.com/repos/ljfranklin/fog-openstack","forks_url":"https://api.github.com/repos/ljfranklin/fog-openstack/forks","keys_url":"https://api.github.com/repos/ljfranklin/fog-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljfranklin/fog-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljfranklin/fog-openstack/teams","hooks_url":"https://api.github.com/repos/ljfranklin/fog-openstack/hooks","issue_events_url":"https://api.github.com/repos/ljfranklin/fog-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/ljfranklin/fog-openstack/events","assignees_url":"https://api.github.com/repos/ljfranklin/fog-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/ljfranklin/fog-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/ljfranklin/fog-openstack/tags","blobs_url":"https://api.github.com/repos/ljfranklin/fog-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljfranklin/fog-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljfranklin/fog-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljfranklin/fog-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljfranklin/fog-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/ljfranklin/fog-openstack/languages","stargazers_url":"https://api.github.com/repos/ljfranklin/fog-openstack/stargazers","contributors_url":"https://api.github.com/repos/ljfranklin/fog-openstack/contributors","subscribers_url":"https://api.github.com/repos/ljfranklin/fog-openstack/subscribers","subscription_url":"https://api.github.com/repos/ljfranklin/fog-openstack/subscription","commits_url":"https://api.github.com/repos/ljfranklin/fog-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljfranklin/fog-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljfranklin/fog-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljfranklin/fog-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljfranklin/fog-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/ljfranklin/fog-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljfranklin/fog-openstack/merges","archive_url":"https://api.github.com/repos/ljfranklin/fog-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljfranklin/fog-openstack/downloads","issues_url":"https://api.github.com/repos/ljfranklin/fog-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/ljfranklin/fog-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/ljfranklin/fog-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/ljfranklin/fog-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljfranklin/fog-openstack/labels{/name}","releases_url":"https://api.github.com/repos/ljfranklin/fog-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/ljfranklin/fog-openstack/deployments","created_at":"2016-08-03T00:19:10Z","updated_at":"2016-08-03T00:19:11Z","pushed_at":"2016-09-19T17:22:31Z","git_url":"git://github.com/ljfranklin/fog-openstack.git","ssh_url":"git@github.com:ljfranklin/fog-openstack.git","clone_url":"https://github.com/ljfranklin/fog-openstack.git","svn_url":"https://github.com/ljfranklin/fog-openstack","homepage":"","size":1292,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fog:master","ref":"master","sha":"4217d76368aa0c570b268e96a3cf21f760ccc967","user":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"repo":{"id":52039406,"name":"fog-openstack","full_name":"fog/fog-openstack","owner":{"login":"fog","id":991149,"avatar_url":"https://avatars.githubusercontent.com/u/991149?v=3","gravatar_id":"","url":"https://api.github.com/users/fog","html_url":"https://github.com/fog","followers_url":"https://api.github.com/users/fog/followers","following_url":"https://api.github.com/users/fog/following{/other_user}","gists_url":"https://api.github.com/users/fog/gists{/gist_id}","starred_url":"https://api.github.com/users/fog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fog/subscriptions","organizations_url":"https://api.github.com/users/fog/orgs","repos_url":"https://api.github.com/users/fog/repos","events_url":"https://api.github.com/users/fog/events{/privacy}","received_events_url":"https://api.github.com/users/fog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fog/fog-openstack","description":"Fog for OpenStack Platform","fork":false,"url":"https://api.github.com/repos/fog/fog-openstack","forks_url":"https://api.github.com/repos/fog/fog-openstack/forks","keys_url":"https://api.github.com/repos/fog/fog-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fog/fog-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fog/fog-openstack/teams","hooks_url":"https://api.github.com/repos/fog/fog-openstack/hooks","issue_events_url":"https://api.github.com/repos/fog/fog-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/fog/fog-openstack/events","assignees_url":"https://api.github.com/repos/fog/fog-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/fog/fog-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/fog/fog-openstack/tags","blobs_url":"https://api.github.com/repos/fog/fog-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fog/fog-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fog/fog-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/fog/fog-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fog/fog-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/fog/fog-openstack/languages","stargazers_url":"https://api.github.com/repos/fog/fog-openstack/stargazers","contributors_url":"https://api.github.com/repos/fog/fog-openstack/contributors","subscribers_url":"https://api.github.com/repos/fog/fog-openstack/subscribers","subscription_url":"https://api.github.com/repos/fog/fog-openstack/subscription","commits_url":"https://api.github.com/repos/fog/fog-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/fog/fog-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/fog/fog-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/fog/fog-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/fog/fog-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/fog/fog-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fog/fog-openstack/merges","archive_url":"https://api.github.com/repos/fog/fog-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fog/fog-openstack/downloads","issues_url":"https://api.github.com/repos/fog/fog-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/fog/fog-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/fog/fog-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/fog/fog-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fog/fog-openstack/labels{/name}","releases_url":"https://api.github.com/repos/fog/fog-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/fog/fog-openstack/deployments","created_at":"2016-02-18T21:16:52Z","updated_at":"2016-09-16T20:49:12Z","pushed_at":"2016-09-19T17:22:32Z","git_url":"git://github.com/fog/fog-openstack.git","ssh_url":"git@github.com:fog/fog-openstack.git","clone_url":"https://github.com/fog/fog-openstack.git","svn_url":"https://github.com/fog/fog-openstack","homepage":"","size":1490,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":53,"forks":38,"open_issues":53,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/170"},"html":{"href":"https://github.com/fog/fog-openstack/pull/170"},"issue":{"href":"https://api.github.com/repos/fog/fog-openstack/issues/170"},"comments":{"href":"https://api.github.com/repos/fog/fog-openstack/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fog/fog-openstack/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/fog/fog-openstack/statuses/99a4879013f6b44d891b7dc6ea6f50f5dcc50dc3"}}}}
{"actor":{"display_login":"houndci-bot"}}