{"action":"closed","number":1307,"pull_request":{"url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307","id":55273612,"html_url":"https://github.com/matethurzo/liferay-portal/pull/1307","diff_url":"https://github.com/matethurzo/liferay-portal/pull/1307.diff","patch_url":"https://github.com/matethurzo/liferay-portal/pull/1307.patch","issue_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1307","number":1307,"state":"closed","locked":false,"title":"LPS-61794 PermissionChecker for Staging","user":{"login":"topolik","id":148147,"avatar_url":"https://avatars.githubusercontent.com/u/148147?v=3","gravatar_id":"","url":"https://api.github.com/users/topolik","html_url":"https://github.com/topolik","followers_url":"https://api.github.com/users/topolik/followers","following_url":"https://api.github.com/users/topolik/following{/other_user}","gists_url":"https://api.github.com/users/topolik/gists{/gist_id}","starred_url":"https://api.github.com/users/topolik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolik/subscriptions","organizations_url":"https://api.github.com/users/topolik/orgs","repos_url":"https://api.github.com/users/topolik/repos","events_url":"https://api.github.com/users/topolik/events{/privacy}","received_events_url":"https://api.github.com/users/topolik/received_events","type":"User","site_admin":false},"body":"Hi Mate,\r\n\r\nit's a first part of https://github.com/topolik/liferay-portal/pull/228\r\n\r\nHere I made sure the groupId coming into PermissionChecker is always from live group.\r\n\r\nSometimes code in portal use staging groupId, sometimes live groupId, but site membership and site/org roles are preserved on the original-live group.\r\n\r\nI believe it's better to fix here then to fix those places in portal and check it each month again :)\r\n\r\nThanks.","created_at":"2016-01-06T22:22:56Z","updated_at":"2016-01-10T21:30:26Z","closed_at":"2016-01-10T21:30:26Z","merged_at":null,"merge_commit_sha":"06376b5afe206672f02eceb9313a35f06fe43974","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307/commits","review_comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307/comments","review_comment_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1307/comments","statuses_url":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/bf9f3c2f662d5201d498a5b81cedf78e88d7ea96","head":{"label":"topolik:LPS-61794","ref":"LPS-61794","sha":"bf9f3c2f662d5201d498a5b81cedf78e88d7ea96","user":{"login":"topolik","id":148147,"avatar_url":"https://avatars.githubusercontent.com/u/148147?v=3","gravatar_id":"","url":"https://api.github.com/users/topolik","html_url":"https://github.com/topolik","followers_url":"https://api.github.com/users/topolik/followers","following_url":"https://api.github.com/users/topolik/following{/other_user}","gists_url":"https://api.github.com/users/topolik/gists{/gist_id}","starred_url":"https://api.github.com/users/topolik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolik/subscriptions","organizations_url":"https://api.github.com/users/topolik/orgs","repos_url":"https://api.github.com/users/topolik/repos","events_url":"https://api.github.com/users/topolik/events{/privacy}","received_events_url":"https://api.github.com/users/topolik/received_events","type":"User","site_admin":false},"repo":{"id":3853423,"name":"liferay-portal","full_name":"topolik/liferay-portal","owner":{"login":"topolik","id":148147,"avatar_url":"https://avatars.githubusercontent.com/u/148147?v=3","gravatar_id":"","url":"https://api.github.com/users/topolik","html_url":"https://github.com/topolik","followers_url":"https://api.github.com/users/topolik/followers","following_url":"https://api.github.com/users/topolik/following{/other_user}","gists_url":"https://api.github.com/users/topolik/gists{/gist_id}","starred_url":"https://api.github.com/users/topolik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topolik/subscriptions","organizations_url":"https://api.github.com/users/topolik/orgs","repos_url":"https://api.github.com/users/topolik/repos","events_url":"https://api.github.com/users/topolik/events{/privacy}","received_events_url":"https://api.github.com/users/topolik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/topolik/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/topolik/liferay-portal","forks_url":"https://api.github.com/repos/topolik/liferay-portal/forks","keys_url":"https://api.github.com/repos/topolik/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topolik/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topolik/liferay-portal/teams","hooks_url":"https://api.github.com/repos/topolik/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/topolik/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/topolik/liferay-portal/events","assignees_url":"https://api.github.com/repos/topolik/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/topolik/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/topolik/liferay-portal/tags","blobs_url":"https://api.github.com/repos/topolik/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topolik/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topolik/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/topolik/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topolik/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/topolik/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/topolik/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/topolik/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/topolik/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/topolik/liferay-portal/subscription","commits_url":"https://api.github.com/repos/topolik/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/topolik/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/topolik/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/topolik/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/topolik/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/topolik/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topolik/liferay-portal/merges","archive_url":"https://api.github.com/repos/topolik/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topolik/liferay-portal/downloads","issues_url":"https://api.github.com/repos/topolik/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/topolik/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/topolik/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/topolik/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topolik/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/topolik/liferay-portal/releases{/id}","created_at":"2012-03-28T09:17:44Z","updated_at":"2015-05-30T15:49:29Z","pushed_at":"2016-01-08T15:27:11Z","git_url":"git://github.com/topolik/liferay-portal.git","ssh_url":"git@github.com:topolik/liferay-portal.git","clone_url":"https://github.com/topolik/liferay-portal.git","svn_url":"https://github.com/topolik/liferay-portal","homepage":"http://liferay.com","size":5544192,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"matethurzo:master","ref":"master","sha":"875a30a60847897283c26cb8266ace953e2499a5","user":{"login":"matethurzo","id":861774,"avatar_url":"https://avatars.githubusercontent.com/u/861774?v=3","gravatar_id":"","url":"https://api.github.com/users/matethurzo","html_url":"https://github.com/matethurzo","followers_url":"https://api.github.com/users/matethurzo/followers","following_url":"https://api.github.com/users/matethurzo/following{/other_user}","gists_url":"https://api.github.com/users/matethurzo/gists{/gist_id}","starred_url":"https://api.github.com/users/matethurzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matethurzo/subscriptions","organizations_url":"https://api.github.com/users/matethurzo/orgs","repos_url":"https://api.github.com/users/matethurzo/repos","events_url":"https://api.github.com/users/matethurzo/events{/privacy}","received_events_url":"https://api.github.com/users/matethurzo/received_events","type":"User","site_admin":false},"repo":{"id":1923779,"name":"liferay-portal","full_name":"matethurzo/liferay-portal","owner":{"login":"matethurzo","id":861774,"avatar_url":"https://avatars.githubusercontent.com/u/861774?v=3","gravatar_id":"","url":"https://api.github.com/users/matethurzo","html_url":"https://github.com/matethurzo","followers_url":"https://api.github.com/users/matethurzo/followers","following_url":"https://api.github.com/users/matethurzo/following{/other_user}","gists_url":"https://api.github.com/users/matethurzo/gists{/gist_id}","starred_url":"https://api.github.com/users/matethurzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matethurzo/subscriptions","organizations_url":"https://api.github.com/users/matethurzo/orgs","repos_url":"https://api.github.com/users/matethurzo/repos","events_url":"https://api.github.com/users/matethurzo/events{/privacy}","received_events_url":"https://api.github.com/users/matethurzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matethurzo/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/matethurzo/liferay-portal","forks_url":"https://api.github.com/repos/matethurzo/liferay-portal/forks","keys_url":"https://api.github.com/repos/matethurzo/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matethurzo/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matethurzo/liferay-portal/teams","hooks_url":"https://api.github.com/repos/matethurzo/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/matethurzo/liferay-portal/events","assignees_url":"https://api.github.com/repos/matethurzo/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/matethurzo/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/matethurzo/liferay-portal/tags","blobs_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/matethurzo/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/matethurzo/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/matethurzo/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/matethurzo/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/matethurzo/liferay-portal/subscription","commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/matethurzo/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/matethurzo/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matethurzo/liferay-portal/merges","archive_url":"https://api.github.com/repos/matethurzo/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matethurzo/liferay-portal/downloads","issues_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/matethurzo/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/matethurzo/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matethurzo/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/matethurzo/liferay-portal/releases{/id}","created_at":"2011-06-20T13:56:19Z","updated_at":"2015-05-08T07:33:50Z","pushed_at":"2016-01-10T21:30:18Z","git_url":"git://github.com/matethurzo/liferay-portal.git","ssh_url":"git@github.com:matethurzo/liferay-portal.git","clone_url":"https://github.com/matethurzo/liferay-portal.git","svn_url":"https://github.com/matethurzo/liferay-portal","homepage":"http://liferay.com","size":5614300,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307"},"html":{"href":"https://github.com/matethurzo/liferay-portal/pull/1307"},"issue":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1307"},"comments":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1307/comments"},"review_comments":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307/comments"},"review_comment":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1307/commits"},"statuses":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/bf9f3c2f662d5201d498a5b81cedf78e88d7ea96"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":5,"additions":349,"deletions":11,"changed_files":6}}