{"action":"created","issue":{"url":"https://api.github.com/repos/codenvy/codenvy/issues/1195","repository_url":"https://api.github.com/repos/codenvy/codenvy","labels_url":"https://api.github.com/repos/codenvy/codenvy/issues/1195/labels{/name}","comments_url":"https://api.github.com/repos/codenvy/codenvy/issues/1195/comments","events_url":"https://api.github.com/repos/codenvy/codenvy/issues/1195/events","html_url":"https://github.com/codenvy/codenvy/pull/1195","id":190829264,"number":1195,"title":"Fix dev mode and improve cli code","user":{"login":"riuvshin","id":1636732,"avatar_url":"https://avatars.githubusercontent.com/u/1636732?v=3","gravatar_id":"","url":"https://api.github.com/users/riuvshin","html_url":"https://github.com/riuvshin","followers_url":"https://api.github.com/users/riuvshin/followers","following_url":"https://api.github.com/users/riuvshin/following{/other_user}","gists_url":"https://api.github.com/users/riuvshin/gists{/gist_id}","starred_url":"https://api.github.com/users/riuvshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riuvshin/subscriptions","organizations_url":"https://api.github.com/users/riuvshin/orgs","repos_url":"https://api.github.com/users/riuvshin/repos","events_url":"https://api.github.com/users/riuvshin/events{/privacy}","received_events_url":"https://api.github.com/users/riuvshin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-21T20:37:03Z","updated_at":"2016-11-22T11:51:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codenvy/codenvy/pulls/1195","html_url":"https://github.com/codenvy/codenvy/pull/1195","diff_url":"https://github.com/codenvy/codenvy/pull/1195.diff","patch_url":"https://github.com/codenvy/codenvy/pull/1195.patch"},"body":"Here is a fix for dev mode which was broken by https://github.com/codenvy/codenvy/commit/c4b41b0b83ab857c5dc3cf4ec1ad50a43347d67d\r\nWe thought that we don't need `CODENVY_DEVELOPMENT_TOMCAT` var in `codenvy.env`\r\nbut we actually need it, we have set this var in CLI \"runtime\" but this var should be passed to container with puppet and there is two ways how to fix it revert it back to `codenvy.env` OR pass it as env var to container with puppet. I've picked first one because I found references like https://github.com/codenvy/codenvy/blob/master/dockerfiles/cli/cmd_init.sh#L117 here we still doing `sed` to set `CODENVY_DEVELOPMENT_TOMCAT` in `codenvy.env` so that PR fixes that sed command.\r\n\r\nAlso I;ve improved `cmd_config`  code as I've promised after that https://github.com/codenvy/codenvy/pull/1157 PR\r\n\r\n@TylerJewell @garagatyi @benoitf please review guys"},"comment":{"url":"https://api.github.com/repos/codenvy/codenvy/issues/comments/262221645","html_url":"https://github.com/codenvy/codenvy/pull/1195#issuecomment-262221645","issue_url":"https://api.github.com/repos/codenvy/codenvy/issues/1195","id":262221645,"user":{"login":"riuvshin","id":1636732,"avatar_url":"https://avatars.githubusercontent.com/u/1636732?v=3","gravatar_id":"","url":"https://api.github.com/users/riuvshin","html_url":"https://github.com/riuvshin","followers_url":"https://api.github.com/users/riuvshin/followers","following_url":"https://api.github.com/users/riuvshin/following{/other_user}","gists_url":"https://api.github.com/users/riuvshin/gists{/gist_id}","starred_url":"https://api.github.com/users/riuvshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riuvshin/subscriptions","organizations_url":"https://api.github.com/users/riuvshin/orgs","repos_url":"https://api.github.com/users/riuvshin/repos","events_url":"https://api.github.com/users/riuvshin/events{/privacy}","received_events_url":"https://api.github.com/users/riuvshin/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T11:51:32Z","updated_at":"2016-11-22T11:51:32Z","body":"@TylerJewell \r\n1) done, but due to this we now have 2 codenvy.env files in the end 1 is still in manifests folder and second one as it was in CODENVY_CONFIG/codenvy.env which probably OK because user should touch only second one and first one is more like source it always will be in original state.\r\n\r\n2) I would like to keep those sed commands in CLI because it is easier to find them in if needed and it is more clear as for me. Unfortunately we can't get rid of those two sed commands because if we will do same what I've did for others like CODENVY_CONFIG they will be always overwrite what user defined in `codenvy.env`."}}
{"actor":{"display_login":"riuvshin"}}