{"action":"created","issue":{"url":"https://api.github.com/repos/onelogin/python-saml/issues/122","repository_url":"https://api.github.com/repos/onelogin/python-saml","labels_url":"https://api.github.com/repos/onelogin/python-saml/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/onelogin/python-saml/issues/122/comments","events_url":"https://api.github.com/repos/onelogin/python-saml/issues/122/events","html_url":"https://github.com/onelogin/python-saml/issues/122","id":144824133,"number":122,"title":"Why use real private class field?","user":{"login":"sunmoonone","id":3196473,"avatar_url":"https://avatars.githubusercontent.com/u/3196473?v=3","gravatar_id":"","url":"https://api.github.com/users/sunmoonone","html_url":"https://github.com/sunmoonone","followers_url":"https://api.github.com/users/sunmoonone/followers","following_url":"https://api.github.com/users/sunmoonone/following{/other_user}","gists_url":"https://api.github.com/users/sunmoonone/gists{/gist_id}","starred_url":"https://api.github.com/users/sunmoonone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunmoonone/subscriptions","organizations_url":"https://api.github.com/users/sunmoonone/orgs","repos_url":"https://api.github.com/users/sunmoonone/repos","events_url":"https://api.github.com/users/sunmoonone/events{/privacy}","received_events_url":"https://api.github.com/users/sunmoonone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-31T08:22:05Z","updated_at":"2016-04-04T09:18:43Z","closed_at":null,"body":"I want to implement a Post sso request to my IdP service, but \r\nclass `OneLogin_Saml2_Auth`, `OneLogin_Saml2_Authn_Request` etc. declare private field by using two underscore `__`, which makes impossible to override methods.\r\n\r\nI recommend use one underscore `_` to declare private field conventionaly\r\n\r\nplease check pull request: #123 "},"comment":{"url":"https://api.github.com/repos/onelogin/python-saml/issues/comments/205207619","html_url":"https://github.com/onelogin/python-saml/issues/122#issuecomment-205207619","issue_url":"https://api.github.com/repos/onelogin/python-saml/issues/122","id":205207619,"user":{"login":"pitbulk","id":600897,"avatar_url":"https://avatars.githubusercontent.com/u/600897?v=3","gravatar_id":"","url":"https://api.github.com/users/pitbulk","html_url":"https://github.com/pitbulk","followers_url":"https://api.github.com/users/pitbulk/followers","following_url":"https://api.github.com/users/pitbulk/following{/other_user}","gists_url":"https://api.github.com/users/pitbulk/gists{/gist_id}","starred_url":"https://api.github.com/users/pitbulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitbulk/subscriptions","organizations_url":"https://api.github.com/users/pitbulk/orgs","repos_url":"https://api.github.com/users/pitbulk/repos","events_url":"https://api.github.com/users/pitbulk/events{/privacy}","received_events_url":"https://api.github.com/users/pitbulk/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T09:18:42Z","updated_at":"2016-04-04T09:18:42Z","body":"@sunmoonone \r\nI made [deflate process optional](https://github.com/onelogin/python-saml/commit/3b3ec183355486d5fab7ae027b5110aa7fade7f6)\r\nso now you only need to\r\n\r\n```\r\nclass Child_Of_Saml2_Auth(OneLogin_Saml2_Auth):\r\n    def login_post(self,return_to=None, force_authn=False, is_passive=False):\r\n        authn_request = OneLogin_Saml2_Authn_Request(self.__settings, force_authn, is_passive)\r\n\r\n        self.__last_request_id = authn_request.get_id()\r\n\r\n        saml_request = authn_request.get_request(False)\r\n        parameters = {'SAMLRequest': saml_request}\r\n\r\n        if return_to is not None:\r\n            parameters['RelayState'] = return_to\r\n        else:\r\n            parameters['RelayState'] = OneLogin_Saml2_Utils.get_self_url_no_query(self.__request_data)\r\n\r\n        security = self.__settings.get_security_data()\r\n        if security.get('authnRequestsSigned', False):\r\n            parameters['SigAlg'] = security['signatureAlgorithm']\r\n            parameters['Signature'] = self.build_request_signature(saml_request, parameters['RelayState'], security['signatureAlgorithm'])\r\n\r\n        parameters['url']=self.get_sso_url()\r\n        return parameters\r\n```"}}