{"action":"created","issue":{"url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/131","repository_url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2","labels_url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/131/comments","events_url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/131/events","html_url":"https://github.com/eliatlarge/FEMultiPlayer-V2/pull/131","id":192462343,"number":131,"title":"Fixed issue in LobbyStage where game could not start with multiple spectators","user":{"login":"Zogzer","id":10085851,"avatar_url":"https://avatars.githubusercontent.com/u/10085851?v=3","gravatar_id":"","url":"https://api.github.com/users/Zogzer","html_url":"https://github.com/Zogzer","followers_url":"https://api.github.com/users/Zogzer/followers","following_url":"https://api.github.com/users/Zogzer/following{/other_user}","gists_url":"https://api.github.com/users/Zogzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Zogzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zogzer/subscriptions","organizations_url":"https://api.github.com/users/Zogzer/orgs","repos_url":"https://api.github.com/users/Zogzer/repos","events_url":"https://api.github.com/users/Zogzer/events{/privacy}","received_events_url":"https://api.github.com/users/Zogzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-30T02:55:53Z","updated_at":"2016-11-30T03:38:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/pulls/131","html_url":"https://github.com/eliatlarge/FEMultiPlayer-V2/pull/131","diff_url":"https://github.com/eliatlarge/FEMultiPlayer-V2/pull/131.diff","patch_url":"https://github.com/eliatlarge/FEMultiPlayer-V2/pull/131.patch"},"body":"Spectators are classed as a team and as such the logic here would break if there was more than one as it would think there is more than one player on a \"team\" and not start, one work around was to make sure that the last player who joined was one who was going to be playing, this caused the iteration of in HashMap to place them first. Either way this bug did also allow multiple players to be one on team if the order of the HashMap was manipulated correctly. \r\n\r\nNote: I don't actually have a Java development environment so please make sure to run tests! :)"},"comment":{"url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/comments/263774675","html_url":"https://github.com/eliatlarge/FEMultiPlayer-V2/pull/131#issuecomment-263774675","issue_url":"https://api.github.com/repos/eliatlarge/FEMultiPlayer-V2/issues/131","id":263774675,"user":{"login":"Zogzer","id":10085851,"avatar_url":"https://avatars.githubusercontent.com/u/10085851?v=3","gravatar_id":"","url":"https://api.github.com/users/Zogzer","html_url":"https://github.com/Zogzer","followers_url":"https://api.github.com/users/Zogzer/followers","following_url":"https://api.github.com/users/Zogzer/following{/other_user}","gists_url":"https://api.github.com/users/Zogzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Zogzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zogzer/subscriptions","organizations_url":"https://api.github.com/users/Zogzer/orgs","repos_url":"https://api.github.com/users/Zogzer/repos","events_url":"https://api.github.com/users/Zogzer/events{/privacy}","received_events_url":"https://api.github.com/users/Zogzer/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T03:38:11Z","updated_at":"2016-11-30T03:38:11Z","body":"Compiles under IntellIJ 2016.1.2.\r\nGenerally speaking people who care specifically about external testing on their project would use a continuous integration tool to test for them, not all develop with IDEs and toolkits avalaible."}}
{"actor":{"display_login":"Zogzer"}}