{"action":"created","comment":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/comments/60690186","id":60690186,"diff_hunk":"@@ -1,12 +1,13 @@\n #!/usr/bin/env bash\n-bin=`readlink \"$0\"`\n-if [ \"$bin\" == \"\" ]; then\n- bin=$0\n+\n+script_dir_path=`readlink \"$0\"`\n+if [ \"$script_dir_path\" == \"\" ]; then\n+ script_dir_path=$0\n fi\n-bin=`dirname \"$bin\"`\n-bin=`cd \"$bin\"; pwd`\n+script_dir_path=`dirname \"$script_dir_path\"`\n+script_dir_path=`cd \"$script_dir_path\"; pwd`\n \n-. \"$bin\"/chorus-config.sh\n+. \"$script_dir_path\"/chorus-config.sh","path":"packaging/chorus_control.sh","position":16,"original_position":16,"commit_id":"e3bdff2f74b3582ad89979ae2cf0ecd2b99a558c","original_commit_id":"36558b33152605ead39d258b2f833af6da7dbef8","user":{"login":"kevinmtrowbridge","id":486640,"avatar_url":"https://avatars.githubusercontent.com/u/486640?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinmtrowbridge","html_url":"https://github.com/kevinmtrowbridge","followers_url":"https://api.github.com/users/kevinmtrowbridge/followers","following_url":"https://api.github.com/users/kevinmtrowbridge/following{/other_user}","gists_url":"https://api.github.com/users/kevinmtrowbridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmtrowbridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmtrowbridge/subscriptions","organizations_url":"https://api.github.com/users/kevinmtrowbridge/orgs","repos_url":"https://api.github.com/users/kevinmtrowbridge/repos","events_url":"https://api.github.com/users/kevinmtrowbridge/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmtrowbridge/received_events","type":"User","site_admin":false},"body":"Hi @haozou: renaming this isn't really necessary, I just found it hard to understand that all this is just a way of getting the absolute path to the directory where the script is located ... `$bin` wasn't communicating that to me, so I renamed it, but I didn't do it consistently, so we should either change it back or, change the other places where we use `$bin` still in these scripts.","created_at":"2016-04-22T04:35:14Z","updated_at":"2016-04-22T04:35:14Z","html_url":"https://github.com/Chorus/chorus/pull/299#discussion_r60690186","pull_request_url":"https://api.github.com/repos/Chorus/chorus/pulls/299","_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments/60690186"},"html":{"href":"https://github.com/Chorus/chorus/pull/299#discussion_r60690186"},"pull_request":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/Chorus/chorus/pulls/299","id":67284493,"html_url":"https://github.com/Chorus/chorus/pull/299","diff_url":"https://github.com/Chorus/chorus/pull/299.diff","patch_url":"https://github.com/Chorus/chorus/pull/299.patch","issue_url":"https://api.github.com/repos/Chorus/chorus/issues/299","number":299,"state":"open","locked":false,"title":"MONITORING 6.0 supervisord -- 2nd time's the charm","user":{"login":"kevinmtrowbridge","id":486640,"avatar_url":"https://avatars.githubusercontent.com/u/486640?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinmtrowbridge","html_url":"https://github.com/kevinmtrowbridge","followers_url":"https://api.github.com/users/kevinmtrowbridge/followers","following_url":"https://api.github.com/users/kevinmtrowbridge/following{/other_user}","gists_url":"https://api.github.com/users/kevinmtrowbridge/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinmtrowbridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinmtrowbridge/subscriptions","organizations_url":"https://api.github.com/users/kevinmtrowbridge/orgs","repos_url":"https://api.github.com/users/kevinmtrowbridge/repos","events_url":"https://api.github.com/users/kevinmtrowbridge/events{/privacy}","received_events_url":"https://api.github.com/users/kevinmtrowbridge/received_events","type":"User","site_admin":false},"body":"@jleealpine and I will collaborate around this new PR to try again to get the \"upgrading\" case for the installer working with supervisord.\r\n\r\nWe'll hopefully merge this in early next week.  Apologies.  Thank you for your patience.","created_at":"2016-04-21T01:40:45Z","updated_at":"2016-04-22T04:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63f8bcf50215e021953004c019565294e2835072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Chorus/chorus/pulls/299/commits","review_comments_url":"https://api.github.com/repos/Chorus/chorus/pulls/299/comments","review_comment_url":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chorus/chorus/issues/299/comments","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/e3bdff2f74b3582ad89979ae2cf0ecd2b99a558c","head":{"label":"Chorus:monitoring-6.0-supervisord-try-again","ref":"monitoring-6.0-supervisord-try-again","sha":"e3bdff2f74b3582ad89979ae2cf0ecd2b99a558c","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/Chorus/chorus/deployments","created_at":"2011-11-10T20:30:13Z","updated_at":"2016-04-05T14:28:50Z","pushed_at":"2016-04-22T04:11:15Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":907924,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":13,"forks":73,"open_issues":13,"watchers":182,"default_branch":"master"}},"base":{"label":"Chorus:master","ref":"master","sha":"c9b48c1dfe91824be69b8dc2d556144f88a91df8","user":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"repo":{"id":2751440,"name":"chorus","full_name":"Chorus/chorus","owner":{"login":"Chorus","id":5614676,"avatar_url":"https://avatars.githubusercontent.com/u/5614676?v=3","gravatar_id":"","url":"https://api.github.com/users/Chorus","html_url":"https://github.com/Chorus","followers_url":"https://api.github.com/users/Chorus/followers","following_url":"https://api.github.com/users/Chorus/following{/other_user}","gists_url":"https://api.github.com/users/Chorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Chorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chorus/subscriptions","organizations_url":"https://api.github.com/users/Chorus/orgs","repos_url":"https://api.github.com/users/Chorus/repos","events_url":"https://api.github.com/users/Chorus/events{/privacy}","received_events_url":"https://api.github.com/users/Chorus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Chorus/chorus","description":"Chorus allows customers, partners, developers, and data scientists to collaboratively realize the potential of Big Data.","fork":false,"url":"https://api.github.com/repos/Chorus/chorus","forks_url":"https://api.github.com/repos/Chorus/chorus/forks","keys_url":"https://api.github.com/repos/Chorus/chorus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chorus/chorus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chorus/chorus/teams","hooks_url":"https://api.github.com/repos/Chorus/chorus/hooks","issue_events_url":"https://api.github.com/repos/Chorus/chorus/issues/events{/number}","events_url":"https://api.github.com/repos/Chorus/chorus/events","assignees_url":"https://api.github.com/repos/Chorus/chorus/assignees{/user}","branches_url":"https://api.github.com/repos/Chorus/chorus/branches{/branch}","tags_url":"https://api.github.com/repos/Chorus/chorus/tags","blobs_url":"https://api.github.com/repos/Chorus/chorus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chorus/chorus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chorus/chorus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chorus/chorus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chorus/chorus/statuses/{sha}","languages_url":"https://api.github.com/repos/Chorus/chorus/languages","stargazers_url":"https://api.github.com/repos/Chorus/chorus/stargazers","contributors_url":"https://api.github.com/repos/Chorus/chorus/contributors","subscribers_url":"https://api.github.com/repos/Chorus/chorus/subscribers","subscription_url":"https://api.github.com/repos/Chorus/chorus/subscription","commits_url":"https://api.github.com/repos/Chorus/chorus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chorus/chorus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chorus/chorus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chorus/chorus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chorus/chorus/contents/{+path}","compare_url":"https://api.github.com/repos/Chorus/chorus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chorus/chorus/merges","archive_url":"https://api.github.com/repos/Chorus/chorus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chorus/chorus/downloads","issues_url":"https://api.github.com/repos/Chorus/chorus/issues{/number}","pulls_url":"https://api.github.com/repos/Chorus/chorus/pulls{/number}","milestones_url":"https://api.github.com/repos/Chorus/chorus/milestones{/number}","notifications_url":"https://api.github.com/repos/Chorus/chorus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chorus/chorus/labels{/name}","releases_url":"https://api.github.com/repos/Chorus/chorus/releases{/id}","deployments_url":"https://api.github.com/repos/Chorus/chorus/deployments","created_at":"2011-11-10T20:30:13Z","updated_at":"2016-04-05T14:28:50Z","pushed_at":"2016-04-22T04:11:15Z","git_url":"git://github.com/Chorus/chorus.git","ssh_url":"git@github.com:Chorus/chorus.git","clone_url":"https://github.com/Chorus/chorus.git","svn_url":"https://github.com/Chorus/chorus","homepage":"","size":907924,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":13,"forks":73,"open_issues":13,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/299"},"html":{"href":"https://github.com/Chorus/chorus/pull/299"},"issue":{"href":"https://api.github.com/repos/Chorus/chorus/issues/299"},"comments":{"href":"https://api.github.com/repos/Chorus/chorus/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chorus/chorus/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/Chorus/chorus/statuses/e3bdff2f74b3582ad89979ae2cf0ecd2b99a558c"}}}}