{"action":"closed","issue":{"url":"https://api.github.com/repos/github/gh-ost/issues/285","repository_url":"https://api.github.com/repos/github/gh-ost","labels_url":"https://api.github.com/repos/github/gh-ost/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/github/gh-ost/issues/285/comments","events_url":"https://api.github.com/repos/github/gh-ost/issues/285/events","html_url":"https://github.com/github/gh-ost/issues/285","id":184553337,"number":285,"title":"Make `-concurrent-rowcount` default to true","user":{"login":"ggunson","id":6044312,"avatar_url":"https://avatars.githubusercontent.com/u/6044312?v=3","gravatar_id":"","url":"https://api.github.com/users/ggunson","html_url":"https://github.com/ggunson","followers_url":"https://api.github.com/users/ggunson/followers","following_url":"https://api.github.com/users/ggunson/following{/other_user}","gists_url":"https://api.github.com/users/ggunson/gists{/gist_id}","starred_url":"https://api.github.com/users/ggunson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggunson/subscriptions","organizations_url":"https://api.github.com/users/ggunson/orgs","repos_url":"https://api.github.com/users/ggunson/repos","events_url":"https://api.github.com/users/ggunson/events{/privacy}","received_events_url":"https://api.github.com/users/ggunson/received_events","type":"User","site_admin":true},"labels":[{"id":345034646,"url":"https://api.github.com/repos/github/gh-ost/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"shlomi-noach","id":2607934,"avatar_url":"https://avatars.githubusercontent.com/u/2607934?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":true},"assignees":[{"login":"shlomi-noach","id":2607934,"avatar_url":"https://avatars.githubusercontent.com/u/2607934?v=3","gravatar_id":"","url":"https://api.github.com/users/shlomi-noach","html_url":"https://github.com/shlomi-noach","followers_url":"https://api.github.com/users/shlomi-noach/followers","following_url":"https://api.github.com/users/shlomi-noach/following{/other_user}","gists_url":"https://api.github.com/users/shlomi-noach/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomi-noach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomi-noach/subscriptions","organizations_url":"https://api.github.com/users/shlomi-noach/orgs","repos_url":"https://api.github.com/users/shlomi-noach/repos","events_url":"https://api.github.com/users/shlomi-noach/events{/privacy}","received_events_url":"https://api.github.com/users/shlomi-noach/received_events","type":"User","site_admin":true}],"milestone":null,"comments":1,"created_at":"2016-10-21T19:40:49Z","updated_at":"2016-11-01T11:23:10Z","closed_at":"2016-11-01T11:23:10Z","body":"Based on conversations as a result of the Pythian blog post https://www.pythian.com/blog/using-gh-ost-online-schema-changes/ \n\nRight now if you choose `--exact-rowcount` the migration will wait until the select finishes because it's only if you also use `--concurrent-rowcount` that it'll do the select in a separate thread. And if the non-concurrent select takes 5 minutes, the count is 5 minutes old when the migration starts, which can leave the progress calculations inaccurate (hence the FR https://github.com/github/gh-ost/issues/194). \n- do we want `--concurrent-rowcount` to default to true if `--exact-rowcount` is true?\n- or do we want both of these defaulting to true?\n- or do we want `--exact-rowcount` to just be concurrent and drop the other flag?\n- how is babby formed?\n\nIs there any use case for having a not-concurrent count run and finish before the migration starts?\n"}}
{"actor":{"display_login":"shlomi-noach"}}