{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/124","repository_url":"https://api.github.com/repos/aspnet/DependencyInjection","labels_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/124/comments","events_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/124/events","html_url":"https://github.com/aspnet/DependencyInjection/issues/124","id":46135567,"number":124,"title":"Benchmark and profile the ServiceProvider","user":{"login":"halter73","id":54385,"avatar_url":"https://avatars.githubusercontent.com/u/54385?v=3","gravatar_id":"","url":"https://api.github.com/users/halter73","html_url":"https://github.com/halter73","followers_url":"https://api.github.com/users/halter73/followers","following_url":"https://api.github.com/users/halter73/following{/other_user}","gists_url":"https://api.github.com/users/halter73/gists{/gist_id}","starred_url":"https://api.github.com/users/halter73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halter73/subscriptions","organizations_url":"https://api.github.com/users/halter73/orgs","repos_url":"https://api.github.com/users/halter73/repos","events_url":"https://api.github.com/users/halter73/events{/privacy}","received_events_url":"https://api.github.com/users/halter73/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/milestones/11","html_url":"https://github.com/aspnet/DependencyInjection/milestone/11","labels_url":"https://api.github.com/repos/aspnet/DependencyInjection/milestones/11/labels","id":870454,"number":11,"title":"Backlog","description":null,"creator":{"login":"glennc","id":234688,"avatar_url":"https://avatars.githubusercontent.com/u/234688?v=3","gravatar_id":"","url":"https://api.github.com/users/glennc","html_url":"https://github.com/glennc","followers_url":"https://api.github.com/users/glennc/followers","following_url":"https://api.github.com/users/glennc/following{/other_user}","gists_url":"https://api.github.com/users/glennc/gists{/gist_id}","starred_url":"https://api.github.com/users/glennc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennc/subscriptions","organizations_url":"https://api.github.com/users/glennc/orgs","repos_url":"https://api.github.com/users/glennc/repos","events_url":"https://api.github.com/users/glennc/events{/privacy}","received_events_url":"https://api.github.com/users/glennc/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":8,"state":"open","created_at":"2014-11-18T00:37:53Z","updated_at":"2016-12-20T21:51:12Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2014-10-17T19:33:12Z","updated_at":"2016-12-20T21:51:12Z","closed_at":"2016-12-20T21:51:12Z","body":"As part of PR https://github.com/aspnet/DependencyInjection/pull/121, we made some changes to improve the performance of service resolution from ServiceProvider.\n\nHowever, as of yet, we have not specifically benchmarked the performance of ServiceProvider. We should create some microbenchmarks for ServiceProvider so we can measure the performance impact of the changes we make to ServiceProvider and profile the ServiceProvider code. Microbenchmarks can be a useful tool even though they do not reflect real-world usage patterns.\n\n@GrabYourPitchforks has suggested that it isn't necessary to use compiled expression trees to replace code that does not use reflection. If the performance impact is negligible, it might be better to use expression trees sparingly just for things like constructor invocation to make the code simpler and easier to debug. Once we have benchmarks, we can measure what the performance difference of compiling more or less. This should help us decide which approach we should take.\n"},"comment":{"url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/comments/268369747","html_url":"https://github.com/aspnet/DependencyInjection/issues/124#issuecomment-268369747","issue_url":"https://api.github.com/repos/aspnet/DependencyInjection/issues/124","id":268369747,"user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=3","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T21:51:12Z","updated_at":"2016-12-20T21:51:12Z","body":"Closing because we have already done other investigations in this space, so this bug isn't needed."}}
{"actor":{"display_login":"Eilon"}}