{"action":"created","comment":{"url":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments/86450063","pull_request_review_id":7110467,"id":86450063,"diff_hunk":"@@ -46,75 +104,118 @@ Each Smart Device will be assigned an 88-bit UID with the following data.\n     |      (16 bits)    |   (8 bits)   |          (64 bits)          |\n     +-------------------+--------------+-----------------------------+\n \n-Device Type - 16-bit ID specifying the type device the Smart Device controller is attached to.\n-              Device types are enumerated in Section 4\n+- Device Type\n+    - 16-bit ID specifying the Type of a Smart Device\n+    - Device types are enumerated in Section 5\n+\n+- Year\n+  - 8-bit ID corresponding to the competition year that the Smart Device was manufactured for. \n+  - The 2015-2016 season will correspond to 0x00\n+\n+- ID\n+    - Randomly generated 64-bit number that will uniquely identify each Smart Device within a specific device type and year.\n+    - With 64-bit IDs, the probability of a hash collision with 1000 of 1 type of device per year is roughly 0.05%\n+\n+\n+## Section 3: Parameters and bitmaps\n+- Hibike abstracts every smart device as a set of parameters that map to values\n+- Each smart device contains some number of paramaters, which can be read/written to.\n \n-Year        - 8-bit ID corresponding to the competition year that the Smart Device was manufactured\n-              for. The 2015-2016 season will correspond to 0x00\n+- Paramaters can have many types, such as bool, int, short, byte, float, etc.\n+- Some paramaters are read only, some are write only, and some support both.\n+- A config file will describe the paramaters for each Device Type (name, type, permissions).\n+- Some packets encode sets of parameters in the form of bitmaps.\n \n-ID          - Randomly generated 64-bit number that will uniquely identify each Smart Device within\n-              a specific device type and year. With 64-bit IDs, the probability of a hash collision \n-              with 1000 of 1 type of device per year is roughly 0.05%\n \n-## Section 3: Enumerations\n+\n+\n+    ```\n+    +-------------------+-----------------------------+     +-----------------------------+\n+    |      Params       |         Value 0             | ... |         Value 15            |","path":"hibike/README.md","position":154,"original_position":154,"commit_id":"0c821e61a677cd38a8228fcd5304fa312bb00ac3","original_commit_id":"0c821e61a677cd38a8228fcd5304fa312bb00ac3","user":{"login":"karthik-shanmugam","id":7821859,"avatar_url":"https://avatars.githubusercontent.com/u/7821859?v=3","gravatar_id":"","url":"https://api.github.com/users/karthik-shanmugam","html_url":"https://github.com/karthik-shanmugam","followers_url":"https://api.github.com/users/karthik-shanmugam/followers","following_url":"https://api.github.com/users/karthik-shanmugam/following{/other_user}","gists_url":"https://api.github.com/users/karthik-shanmugam/gists{/gist_id}","starred_url":"https://api.github.com/users/karthik-shanmugam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthik-shanmugam/subscriptions","organizations_url":"https://api.github.com/users/karthik-shanmugam/orgs","repos_url":"https://api.github.com/users/karthik-shanmugam/repos","events_url":"https://api.github.com/users/karthik-shanmugam/events{/privacy}","received_events_url":"https://api.github.com/users/karthik-shanmugam/received_events","type":"User","site_admin":false},"body":"It will only contain data for the two requested via bitmask","created_at":"2016-11-03T21:44:53Z","updated_at":"2016-11-03T21:44:53Z","html_url":"https://github.com/pioneers/PieCentral/pull/64#discussion_r86450063","pull_request_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments/86450063"},"html":{"href":"https://github.com/pioneers/PieCentral/pull/64#discussion_r86450063"},"pull_request":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/pioneers/PieCentral/pulls/64","id":91715888,"html_url":"https://github.com/pioneers/PieCentral/pull/64","diff_url":"https://github.com/pioneers/PieCentral/pull/64.diff","patch_url":"https://github.com/pioneers/PieCentral/pull/64.patch","issue_url":"https://api.github.com/repos/pioneers/PieCentral/issues/64","number":64,"state":"open","locked":false,"title":"[HIBIKE] create hibike simulator for runtime integration","user":{"login":"karthik-shanmugam","id":7821859,"avatar_url":"https://avatars.githubusercontent.com/u/7821859?v=3","gravatar_id":"","url":"https://api.github.com/users/karthik-shanmugam","html_url":"https://github.com/karthik-shanmugam","followers_url":"https://api.github.com/users/karthik-shanmugam/followers","following_url":"https://api.github.com/users/karthik-shanmugam/following{/other_user}","gists_url":"https://api.github.com/users/karthik-shanmugam/gists{/gist_id}","starred_url":"https://api.github.com/users/karthik-shanmugam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karthik-shanmugam/subscriptions","organizations_url":"https://api.github.com/users/karthik-shanmugam/orgs","repos_url":"https://api.github.com/users/karthik-shanmugam/repos","events_url":"https://api.github.com/users/karthik-shanmugam/events{/privacy}","received_events_url":"https://api.github.com/users/karthik-shanmugam/received_events","type":"User","site_admin":false},"body":"- rewrite `hibike_simulator.py` and add a function `hibike_process`, which takes in various Queues and Pipes and simulates the behavior described in `ATALANDA_INTEGRATION.md`\r\n\r\n- rewrite `README.md`, `hibikeDevices.json`, and `hibike_message.py` with protocol changes\r\n\r\n- add an `__init__.py` so hibike can be imported from runtime","created_at":"2016-11-01T00:32:42Z","updated_at":"2016-11-03T21:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79355e91e07145d5eaf1c6407f2744845923deb8","assignee":{"login":"nikitakit","id":252225,"avatar_url":"https://avatars.githubusercontent.com/u/252225?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitakit","html_url":"https://github.com/nikitakit","followers_url":"https://api.github.com/users/nikitakit/followers","following_url":"https://api.github.com/users/nikitakit/following{/other_user}","gists_url":"https://api.github.com/users/nikitakit/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitakit/subscriptions","organizations_url":"https://api.github.com/users/nikitakit/orgs","repos_url":"https://api.github.com/users/nikitakit/repos","events_url":"https://api.github.com/users/nikitakit/events{/privacy}","received_events_url":"https://api.github.com/users/nikitakit/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikitakit","id":252225,"avatar_url":"https://avatars.githubusercontent.com/u/252225?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitakit","html_url":"https://github.com/nikitakit","followers_url":"https://api.github.com/users/nikitakit/followers","following_url":"https://api.github.com/users/nikitakit/following{/other_user}","gists_url":"https://api.github.com/users/nikitakit/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitakit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitakit/subscriptions","organizations_url":"https://api.github.com/users/nikitakit/orgs","repos_url":"https://api.github.com/users/nikitakit/repos","events_url":"https://api.github.com/users/nikitakit/events{/privacy}","received_events_url":"https://api.github.com/users/nikitakit/received_events","type":"User","site_admin":false},{"login":"yizow","id":7284555,"avatar_url":"https://avatars.githubusercontent.com/u/7284555?v=3","gravatar_id":"","url":"https://api.github.com/users/yizow","html_url":"https://github.com/yizow","followers_url":"https://api.github.com/users/yizow/followers","following_url":"https://api.github.com/users/yizow/following{/other_user}","gists_url":"https://api.github.com/users/yizow/gists{/gist_id}","starred_url":"https://api.github.com/users/yizow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yizow/subscriptions","organizations_url":"https://api.github.com/users/yizow/orgs","repos_url":"https://api.github.com/users/yizow/repos","events_url":"https://api.github.com/users/yizow/events{/privacy}","received_events_url":"https://api.github.com/users/yizow/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/64/commits","review_comments_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/64/comments","review_comment_url":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/issues/64/comments","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/0c821e61a677cd38a8228fcd5304fa312bb00ac3","head":{"label":"pioneers:hibike/integration","ref":"hibike/integration","sha":"0c821e61a677cd38a8228fcd5304fa312bb00ac3","user":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"repo":{"id":67092938,"name":"PieCentral","full_name":"pioneers/PieCentral","owner":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneers/PieCentral","description":null,"fork":false,"url":"https://api.github.com/repos/pioneers/PieCentral","forks_url":"https://api.github.com/repos/pioneers/PieCentral/forks","keys_url":"https://api.github.com/repos/pioneers/PieCentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneers/PieCentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneers/PieCentral/teams","hooks_url":"https://api.github.com/repos/pioneers/PieCentral/hooks","issue_events_url":"https://api.github.com/repos/pioneers/PieCentral/issues/events{/number}","events_url":"https://api.github.com/repos/pioneers/PieCentral/events","assignees_url":"https://api.github.com/repos/pioneers/PieCentral/assignees{/user}","branches_url":"https://api.github.com/repos/pioneers/PieCentral/branches{/branch}","tags_url":"https://api.github.com/repos/pioneers/PieCentral/tags","blobs_url":"https://api.github.com/repos/pioneers/PieCentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneers/PieCentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneers/PieCentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneers/PieCentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneers/PieCentral/languages","stargazers_url":"https://api.github.com/repos/pioneers/PieCentral/stargazers","contributors_url":"https://api.github.com/repos/pioneers/PieCentral/contributors","subscribers_url":"https://api.github.com/repos/pioneers/PieCentral/subscribers","subscription_url":"https://api.github.com/repos/pioneers/PieCentral/subscription","commits_url":"https://api.github.com/repos/pioneers/PieCentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneers/PieCentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneers/PieCentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneers/PieCentral/contents/{+path}","compare_url":"https://api.github.com/repos/pioneers/PieCentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneers/PieCentral/merges","archive_url":"https://api.github.com/repos/pioneers/PieCentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneers/PieCentral/downloads","issues_url":"https://api.github.com/repos/pioneers/PieCentral/issues{/number}","pulls_url":"https://api.github.com/repos/pioneers/PieCentral/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneers/PieCentral/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneers/PieCentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneers/PieCentral/labels{/name}","releases_url":"https://api.github.com/repos/pioneers/PieCentral/releases{/id}","deployments_url":"https://api.github.com/repos/pioneers/PieCentral/deployments","created_at":"2016-09-01T03:00:13Z","updated_at":"2016-10-24T23:22:07Z","pushed_at":"2016-11-03T20:30:14Z","git_url":"git://github.com/pioneers/PieCentral.git","ssh_url":"git@github.com:pioneers/PieCentral.git","clone_url":"https://github.com/pioneers/PieCentral.git","svn_url":"https://github.com/pioneers/PieCentral","homepage":null,"size":3591,"stargazers_count":2,"watchers_count":2,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"pioneers:master","ref":"master","sha":"3833449441f1a994fb808a682f7da160c692f446","user":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"repo":{"id":67092938,"name":"PieCentral","full_name":"pioneers/PieCentral","owner":{"login":"pioneers","id":5135404,"avatar_url":"https://avatars.githubusercontent.com/u/5135404?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneers","html_url":"https://github.com/pioneers","followers_url":"https://api.github.com/users/pioneers/followers","following_url":"https://api.github.com/users/pioneers/following{/other_user}","gists_url":"https://api.github.com/users/pioneers/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneers/subscriptions","organizations_url":"https://api.github.com/users/pioneers/orgs","repos_url":"https://api.github.com/users/pioneers/repos","events_url":"https://api.github.com/users/pioneers/events{/privacy}","received_events_url":"https://api.github.com/users/pioneers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneers/PieCentral","description":null,"fork":false,"url":"https://api.github.com/repos/pioneers/PieCentral","forks_url":"https://api.github.com/repos/pioneers/PieCentral/forks","keys_url":"https://api.github.com/repos/pioneers/PieCentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneers/PieCentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneers/PieCentral/teams","hooks_url":"https://api.github.com/repos/pioneers/PieCentral/hooks","issue_events_url":"https://api.github.com/repos/pioneers/PieCentral/issues/events{/number}","events_url":"https://api.github.com/repos/pioneers/PieCentral/events","assignees_url":"https://api.github.com/repos/pioneers/PieCentral/assignees{/user}","branches_url":"https://api.github.com/repos/pioneers/PieCentral/branches{/branch}","tags_url":"https://api.github.com/repos/pioneers/PieCentral/tags","blobs_url":"https://api.github.com/repos/pioneers/PieCentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneers/PieCentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneers/PieCentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneers/PieCentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneers/PieCentral/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneers/PieCentral/languages","stargazers_url":"https://api.github.com/repos/pioneers/PieCentral/stargazers","contributors_url":"https://api.github.com/repos/pioneers/PieCentral/contributors","subscribers_url":"https://api.github.com/repos/pioneers/PieCentral/subscribers","subscription_url":"https://api.github.com/repos/pioneers/PieCentral/subscription","commits_url":"https://api.github.com/repos/pioneers/PieCentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneers/PieCentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneers/PieCentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneers/PieCentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneers/PieCentral/contents/{+path}","compare_url":"https://api.github.com/repos/pioneers/PieCentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneers/PieCentral/merges","archive_url":"https://api.github.com/repos/pioneers/PieCentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneers/PieCentral/downloads","issues_url":"https://api.github.com/repos/pioneers/PieCentral/issues{/number}","pulls_url":"https://api.github.com/repos/pioneers/PieCentral/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneers/PieCentral/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneers/PieCentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneers/PieCentral/labels{/name}","releases_url":"https://api.github.com/repos/pioneers/PieCentral/releases{/id}","deployments_url":"https://api.github.com/repos/pioneers/PieCentral/deployments","created_at":"2016-09-01T03:00:13Z","updated_at":"2016-10-24T23:22:07Z","pushed_at":"2016-11-03T20:30:14Z","git_url":"git://github.com/pioneers/PieCentral.git","ssh_url":"git@github.com:pioneers/PieCentral.git","clone_url":"https://github.com/pioneers/PieCentral.git","svn_url":"https://github.com/pioneers/PieCentral","homepage":null,"size":3591,"stargazers_count":2,"watchers_count":2,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/64"},"html":{"href":"https://github.com/pioneers/PieCentral/pull/64"},"issue":{"href":"https://api.github.com/repos/pioneers/PieCentral/issues/64"},"comments":{"href":"https://api.github.com/repos/pioneers/PieCentral/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pioneers/PieCentral/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/pioneers/PieCentral/statuses/0c821e61a677cd38a8228fcd5304fa312bb00ac3"}}}}
{"actor":{"display_login":"karthik-shanmugam"}}