{"action":"created","comment":{"url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/comments/80427953","id":80427953,"diff_hunk":"@@ -100,8 +101,8 @@ function gsd(x, yIn, options) {\n     // By the intermediate value theorem We cannot find 2 consecutive maximum or minimum\n     for (let i = 1; i < Y.length - 1; ++i) {\n         // Minimum in first derivative\n-        if ((dY[i] < dY[i - 1]) && (dY[i] <= dY[i + 1]) ||\n-            (dY[i] <= dY[i - 1]) && (dY[i] < dY[i + 1])) {\n+        if ((dY[i] - dY[i - 1] <  -options.derivativeThreshold) && (dY[i] - dY[i + 1] <= -options.derivativeThreshold) ||","path":"src/gsd.js","position":null,"original_position":16,"commit_id":"1b222df1f85578874cb3fdfffeb3ac1669904ccf","original_commit_id":"4cd0fbb4692125ccf2a14c56f1085475575993e8","user":{"login":"maasencioh","id":7273940,"avatar_url":"https://avatars.githubusercontent.com/u/7273940?v=3","gravatar_id":"","url":"https://api.github.com/users/maasencioh","html_url":"https://github.com/maasencioh","followers_url":"https://api.github.com/users/maasencioh/followers","following_url":"https://api.github.com/users/maasencioh/following{/other_user}","gists_url":"https://api.github.com/users/maasencioh/gists{/gist_id}","starred_url":"https://api.github.com/users/maasencioh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maasencioh/subscriptions","organizations_url":"https://api.github.com/users/maasencioh/orgs","repos_url":"https://api.github.com/users/maasencioh/repos","events_url":"https://api.github.com/users/maasencioh/events{/privacy}","received_events_url":"https://api.github.com/users/maasencioh/received_events","type":"User","site_admin":false},"body":"I've changed the file to do what we discussed, you're right","created_at":"2016-09-26T08:31:29Z","updated_at":"2016-09-26T08:31:29Z","html_url":"https://github.com/mljs/global-spectral-deconvolution/pull/5#discussion_r80427953","pull_request_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/comments/80427953"},"html":{"href":"https://github.com/mljs/global-spectral-deconvolution/pull/5#discussion_r80427953"},"pull_request":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5","id":83987336,"html_url":"https://github.com/mljs/global-spectral-deconvolution/pull/5","diff_url":"https://github.com/mljs/global-spectral-deconvolution/pull/5.diff","patch_url":"https://github.com/mljs/global-spectral-deconvolution/pull/5.patch","issue_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/5","number":5,"state":"open","locked":false,"title":"Height of each peak","user":{"login":"maasencioh","id":7273940,"avatar_url":"https://avatars.githubusercontent.com/u/7273940?v=3","gravatar_id":"","url":"https://api.github.com/users/maasencioh","html_url":"https://github.com/maasencioh","followers_url":"https://api.github.com/users/maasencioh/followers","following_url":"https://api.github.com/users/maasencioh/following{/other_user}","gists_url":"https://api.github.com/users/maasencioh/gists{/gist_id}","starred_url":"https://api.github.com/users/maasencioh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maasencioh/subscriptions","organizations_url":"https://api.github.com/users/maasencioh/orgs","repos_url":"https://api.github.com/users/maasencioh/repos","events_url":"https://api.github.com/users/maasencioh/events{/privacy}","received_events_url":"https://api.github.com/users/maasencioh/received_events","type":"User","site_admin":false},"body":"Hello @mljs/collaborators, the proposed changes are:\r\n  * Add eslint style checker\r\n  * Returns an estimate of the height based in the inflection points\r\n  * Returns the peaks boundaries\r\n  * Filters by a threshold in the first derivative","created_at":"2016-09-05T11:18:28Z","updated_at":"2016-09-26T08:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c05bb0a52dc3a0ff8ecd17ff7c6c3d646657331b","assignee":{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"assignees":[{"login":"targos","id":2352663,"avatar_url":"https://avatars.githubusercontent.com/u/2352663?v=3","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},{"login":"andcastillo","id":3810292,"avatar_url":"https://avatars.githubusercontent.com/u/3810292?v=3","gravatar_id":"","url":"https://api.github.com/users/andcastillo","html_url":"https://github.com/andcastillo","followers_url":"https://api.github.com/users/andcastillo/followers","following_url":"https://api.github.com/users/andcastillo/following{/other_user}","gists_url":"https://api.github.com/users/andcastillo/gists{/gist_id}","starred_url":"https://api.github.com/users/andcastillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andcastillo/subscriptions","organizations_url":"https://api.github.com/users/andcastillo/orgs","repos_url":"https://api.github.com/users/andcastillo/repos","events_url":"https://api.github.com/users/andcastillo/events{/privacy}","received_events_url":"https://api.github.com/users/andcastillo/received_events","type":"User","site_admin":false},{"login":"maasencioh","id":7273940,"avatar_url":"https://avatars.githubusercontent.com/u/7273940?v=3","gravatar_id":"","url":"https://api.github.com/users/maasencioh","html_url":"https://github.com/maasencioh","followers_url":"https://api.github.com/users/maasencioh/followers","following_url":"https://api.github.com/users/maasencioh/following{/other_user}","gists_url":"https://api.github.com/users/maasencioh/gists{/gist_id}","starred_url":"https://api.github.com/users/maasencioh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maasencioh/subscriptions","organizations_url":"https://api.github.com/users/maasencioh/orgs","repos_url":"https://api.github.com/users/maasencioh/repos","events_url":"https://api.github.com/users/maasencioh/events{/privacy}","received_events_url":"https://api.github.com/users/maasencioh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/5/comments","statuses_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/statuses/1b222df1f85578874cb3fdfffeb3ac1669904ccf","head":{"label":"mljs:peak-high","ref":"peak-high","sha":"1b222df1f85578874cb3fdfffeb3ac1669904ccf","user":{"login":"mljs","id":9335229,"avatar_url":"https://avatars.githubusercontent.com/u/9335229?v=3","gravatar_id":"","url":"https://api.github.com/users/mljs","html_url":"https://github.com/mljs","followers_url":"https://api.github.com/users/mljs/followers","following_url":"https://api.github.com/users/mljs/following{/other_user}","gists_url":"https://api.github.com/users/mljs/gists{/gist_id}","starred_url":"https://api.github.com/users/mljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljs/subscriptions","organizations_url":"https://api.github.com/users/mljs/orgs","repos_url":"https://api.github.com/users/mljs/repos","events_url":"https://api.github.com/users/mljs/events{/privacy}","received_events_url":"https://api.github.com/users/mljs/received_events","type":"Organization","site_admin":false},"repo":{"id":41678509,"name":"global-spectral-deconvolution","full_name":"mljs/global-spectral-deconvolution","owner":{"login":"mljs","id":9335229,"avatar_url":"https://avatars.githubusercontent.com/u/9335229?v=3","gravatar_id":"","url":"https://api.github.com/users/mljs","html_url":"https://github.com/mljs","followers_url":"https://api.github.com/users/mljs/followers","following_url":"https://api.github.com/users/mljs/following{/other_user}","gists_url":"https://api.github.com/users/mljs/gists{/gist_id}","starred_url":"https://api.github.com/users/mljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljs/subscriptions","organizations_url":"https://api.github.com/users/mljs/orgs","repos_url":"https://api.github.com/users/mljs/repos","events_url":"https://api.github.com/users/mljs/events{/privacy}","received_events_url":"https://api.github.com/users/mljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mljs/global-spectral-deconvolution","description":"Global Spectra Deconvolution + Peak optimizer","fork":false,"url":"https://api.github.com/repos/mljs/global-spectral-deconvolution","forks_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/forks","keys_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/teams","hooks_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/hooks","issue_events_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/events{/number}","events_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/events","assignees_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/assignees{/user}","branches_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/branches{/branch}","tags_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/tags","blobs_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/statuses/{sha}","languages_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/languages","stargazers_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/stargazers","contributors_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/contributors","subscribers_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/subscribers","subscription_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/subscription","commits_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/contents/{+path}","compare_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/merges","archive_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/downloads","issues_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues{/number}","pulls_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls{/number}","milestones_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/milestones{/number}","notifications_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/labels{/name}","releases_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/releases{/id}","deployments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/deployments","created_at":"2015-08-31T14:00:13Z","updated_at":"2016-09-14T10:49:08Z","pushed_at":"2016-09-23T08:21:47Z","git_url":"git://github.com/mljs/global-spectral-deconvolution.git","ssh_url":"git@github.com:mljs/global-spectral-deconvolution.git","clone_url":"https://github.com/mljs/global-spectral-deconvolution.git","svn_url":"https://github.com/mljs/global-spectral-deconvolution","homepage":"","size":3902,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"mljs:master","ref":"master","sha":"069bb8e6ef7bf6caf24c1a79cc191d26ffbfe44b","user":{"login":"mljs","id":9335229,"avatar_url":"https://avatars.githubusercontent.com/u/9335229?v=3","gravatar_id":"","url":"https://api.github.com/users/mljs","html_url":"https://github.com/mljs","followers_url":"https://api.github.com/users/mljs/followers","following_url":"https://api.github.com/users/mljs/following{/other_user}","gists_url":"https://api.github.com/users/mljs/gists{/gist_id}","starred_url":"https://api.github.com/users/mljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljs/subscriptions","organizations_url":"https://api.github.com/users/mljs/orgs","repos_url":"https://api.github.com/users/mljs/repos","events_url":"https://api.github.com/users/mljs/events{/privacy}","received_events_url":"https://api.github.com/users/mljs/received_events","type":"Organization","site_admin":false},"repo":{"id":41678509,"name":"global-spectral-deconvolution","full_name":"mljs/global-spectral-deconvolution","owner":{"login":"mljs","id":9335229,"avatar_url":"https://avatars.githubusercontent.com/u/9335229?v=3","gravatar_id":"","url":"https://api.github.com/users/mljs","html_url":"https://github.com/mljs","followers_url":"https://api.github.com/users/mljs/followers","following_url":"https://api.github.com/users/mljs/following{/other_user}","gists_url":"https://api.github.com/users/mljs/gists{/gist_id}","starred_url":"https://api.github.com/users/mljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mljs/subscriptions","organizations_url":"https://api.github.com/users/mljs/orgs","repos_url":"https://api.github.com/users/mljs/repos","events_url":"https://api.github.com/users/mljs/events{/privacy}","received_events_url":"https://api.github.com/users/mljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mljs/global-spectral-deconvolution","description":"Global Spectra Deconvolution + Peak optimizer","fork":false,"url":"https://api.github.com/repos/mljs/global-spectral-deconvolution","forks_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/forks","keys_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/teams","hooks_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/hooks","issue_events_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/events{/number}","events_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/events","assignees_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/assignees{/user}","branches_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/branches{/branch}","tags_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/tags","blobs_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/statuses/{sha}","languages_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/languages","stargazers_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/stargazers","contributors_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/contributors","subscribers_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/subscribers","subscription_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/subscription","commits_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/contents/{+path}","compare_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/merges","archive_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/downloads","issues_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues{/number}","pulls_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls{/number}","milestones_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/milestones{/number}","notifications_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/labels{/name}","releases_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/releases{/id}","deployments_url":"https://api.github.com/repos/mljs/global-spectral-deconvolution/deployments","created_at":"2015-08-31T14:00:13Z","updated_at":"2016-09-14T10:49:08Z","pushed_at":"2016-09-23T08:21:47Z","git_url":"git://github.com/mljs/global-spectral-deconvolution.git","ssh_url":"git@github.com:mljs/global-spectral-deconvolution.git","clone_url":"https://github.com/mljs/global-spectral-deconvolution.git","svn_url":"https://github.com/mljs/global-spectral-deconvolution","homepage":"","size":3902,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5"},"html":{"href":"https://github.com/mljs/global-spectral-deconvolution/pull/5"},"issue":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/5"},"comments":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mljs/global-spectral-deconvolution/statuses/1b222df1f85578874cb3fdfffeb3ac1669904ccf"}}}}
{"actor":{"display_login":"maasencioh"}}