{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments/51401893","id":51401893,"diff_hunk":"@@ -15,7 +15,7 @@ public TaskCompletionSourceAdapter(object taskCompletionSource)\n \n         public void SetResult(object result)\n         {\n-            var method = taskCompletionSource.GetType().GetMethod(\"SetResult\");\n+            var method = taskCompletionSource.GetType().GetMethod(\"TrySetResult\");","path":"src/NServiceBus.Callbacks/TaskCompletionSourceAdapter.cs","position":5,"original_position":5,"commit_id":"5eea0e8eba9b4834d4a11250f2d3707b09fd58f2","original_commit_id":"d57f62131039f6f75fd93af999e1951c4f42a1fd","user":{"login":"SzymonPobiega","id":163318,"avatar_url":"https://avatars.githubusercontent.com/u/163318?v=3","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-02-01T10:34:09Z","updated_at":"2016-02-01T10:34:09Z","html_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/10#discussion_r51401893","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments/51401893"},"html":{"href":"https://github.com/Particular/NServiceBus.Callbacks/pull/10#discussion_r51401893"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10","id":57813806,"html_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/10","diff_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/10.diff","patch_url":"https://github.com/Particular/NServiceBus.Callbacks/pull/10.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/10","number":10,"state":"open","locked":false,"title":"[WIP] Fixed the callbacks based on the routing spike","user":{"login":"SzymonPobiega","id":163318,"avatar_url":"https://avatars.githubusercontent.com/u/163318?v=3","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/Particular/NServiceBus/pull/3374\r\n\r\n * Fixed `TaskCompletionSourceAdapter` to properly handle cancelled tasks\r\n * Moved behavior classes to proper folders\r\n * Added a stable generator for instance ids\r\n * Adjusted the scale out sample\r\n\r\nWeather we should provide these default instance IDs (based on file or anything else) is still debatable.","created_at":"2016-02-01T09:21:49Z","updated_at":"2016-02-01T10:34:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a38e3ce43b71a0b4a90af61f59076940c479220","assignee":{"login":"SzymonPobiega","id":163318,"avatar_url":"https://avatars.githubusercontent.com/u/163318?v=3","gravatar_id":"","url":"https://api.github.com/users/SzymonPobiega","html_url":"https://github.com/SzymonPobiega","followers_url":"https://api.github.com/users/SzymonPobiega/followers","following_url":"https://api.github.com/users/SzymonPobiega/following{/other_user}","gists_url":"https://api.github.com/users/SzymonPobiega/gists{/gist_id}","starred_url":"https://api.github.com/users/SzymonPobiega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SzymonPobiega/subscriptions","organizations_url":"https://api.github.com/users/SzymonPobiega/orgs","repos_url":"https://api.github.com/users/SzymonPobiega/repos","events_url":"https://api.github.com/users/SzymonPobiega/events{/privacy}","received_events_url":"https://api.github.com/users/SzymonPobiega/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/10/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/5eea0e8eba9b4834d4a11250f2d3707b09fd58f2","head":{"label":"Particular:routing-based-callbacks","ref":"routing-based-callbacks","sha":"5eea0e8eba9b4834d4a11250f2d3707b09fd58f2","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":39256075,"name":"NServiceBus.Callbacks","full_name":"Particular/NServiceBus.Callbacks","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Callbacks","description":"","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/deployments","created_at":"2015-07-17T13:43:45Z","updated_at":"2016-01-27T11:15:12Z","pushed_at":"2016-02-01T10:23:39Z","git_url":"git://github.com/Particular/NServiceBus.Callbacks.git","ssh_url":"git@github.com:Particular/NServiceBus.Callbacks.git","clone_url":"https://github.com/Particular/NServiceBus.Callbacks.git","svn_url":"https://github.com/Particular/NServiceBus.Callbacks","homepage":null,"size":96,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"21adde99b78f94a222dd33e2653b5cd0485ea7fb","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":39256075,"name":"NServiceBus.Callbacks","full_name":"Particular/NServiceBus.Callbacks","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.Callbacks","description":"","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks","forks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/deployments","created_at":"2015-07-17T13:43:45Z","updated_at":"2016-01-27T11:15:12Z","pushed_at":"2016-02-01T10:23:39Z","git_url":"git://github.com/Particular/NServiceBus.Callbacks.git","ssh_url":"git@github.com:Particular/NServiceBus.Callbacks.git","clone_url":"https://github.com/Particular/NServiceBus.Callbacks.git","svn_url":"https://github.com/Particular/NServiceBus.Callbacks","homepage":null,"size":96,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10"},"html":{"href":"https://github.com/Particular/NServiceBus.Callbacks/pull/10"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/10"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.Callbacks/statuses/5eea0e8eba9b4834d4a11250f2d3707b09fd58f2"}}}}