{"action":"created","comment":{"url":"https://api.github.com/repos/gopherjs/vecty/pulls/comments/63285963","id":63285963,"diff_hunk":"@@ -173,7 +203,7 @@ func (e *Element) Reconcile(oldComp Component) {\n \t\t\treplaceNode(newChild.Node(), oldChild.Node())\n \t\t}\n \t\tfor i := len(e.Children); i < len(oldElement.Children); i++ {\n-\t\t\tremoveNode(oldElement.Children[i].Node())\n+\t\t\toldElement.Children[i].Unmount()","path":"dom.go","position":null,"original_position":63,"commit_id":"5d56a90127582094c8f0d28fb633b85a24b06576","original_commit_id":"f91790ade2b404b2a9be3b254e7b4fcd543169f1","user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"body":"Fixed in 5d56a90127582094c8f0d28fb633b85a24b06576","created_at":"2016-05-15T04:16:35Z","updated_at":"2016-05-15T04:16:36Z","html_url":"https://github.com/gopherjs/vecty/pull/40#discussion_r63285963","pull_request_url":"https://api.github.com/repos/gopherjs/vecty/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/comments/63285963"},"html":{"href":"https://github.com/gopherjs/vecty/pull/40#discussion_r63285963"},"pull_request":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/gopherjs/vecty/pulls/40","id":67613524,"html_url":"https://github.com/gopherjs/vecty/pull/40","diff_url":"https://github.com/gopherjs/vecty/pull/40.diff","patch_url":"https://github.com/gopherjs/vecty/pull/40.patch","issue_url":"https://api.github.com/repos/gopherjs/vecty/issues/40","number":40,"state":"open","locked":false,"title":"component architecture changes","user":{"login":"slimsag","id":3173176,"avatar_url":"https://avatars.githubusercontent.com/u/3173176?v=3","gravatar_id":"","url":"https://api.github.com/users/slimsag","html_url":"https://github.com/slimsag","followers_url":"https://api.github.com/users/slimsag/followers","following_url":"https://api.github.com/users/slimsag/following{/other_user}","gists_url":"https://api.github.com/users/slimsag/gists{/gist_id}","starred_url":"https://api.github.com/users/slimsag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimsag/subscriptions","organizations_url":"https://api.github.com/users/slimsag/orgs","repos_url":"https://api.github.com/users/slimsag/repos","events_url":"https://api.github.com/users/slimsag/events{/privacy}","received_events_url":"https://api.github.com/users/slimsag/received_events","type":"User","site_admin":false},"body":"Over the past months I've been looking into the component architecture, and in particular, how to document it and explain it to others efficiently. I've tried probably 7+ different approaches at this point, and this is the one that I've settled into / feel the most comfortable with.\r\n\r\nStart by reading the commit message of f91790a to get an idea for motivation, and please compare the todomvc example after that change to the todomvc example before that change.\r\n\r\nI would be very curious to get the opinions of @shurcooL and @neelance here, although I understand this is a more controversial change and probably much less likely to be accepted. I'm okay with that and with this change taking longer to review, potentially not being merged, etc.","created_at":"2016-04-23T17:49:16Z","updated_at":"2016-05-15T04:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b0346daca3fee51f0334b6d5d7ddd0bbb0b5d1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gopherjs/vecty/pulls/40/commits","review_comments_url":"https://api.github.com/repos/gopherjs/vecty/pulls/40/comments","review_comment_url":"https://api.github.com/repos/gopherjs/vecty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gopherjs/vecty/issues/40/comments","statuses_url":"https://api.github.com/repos/gopherjs/vecty/statuses/5d56a90127582094c8f0d28fb633b85a24b06576","head":{"label":"gopherjs:sg/arch","ref":"sg/arch","sha":"5d56a90127582094c8f0d28fb633b85a24b06576","user":{"login":"gopherjs","id":6654647,"avatar_url":"https://avatars.githubusercontent.com/u/6654647?v=3","gravatar_id":"","url":"https://api.github.com/users/gopherjs","html_url":"https://github.com/gopherjs","followers_url":"https://api.github.com/users/gopherjs/followers","following_url":"https://api.github.com/users/gopherjs/following{/other_user}","gists_url":"https://api.github.com/users/gopherjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherjs/subscriptions","organizations_url":"https://api.github.com/users/gopherjs/orgs","repos_url":"https://api.github.com/users/gopherjs/repos","events_url":"https://api.github.com/users/gopherjs/events{/privacy}","received_events_url":"https://api.github.com/users/gopherjs/received_events","type":"Organization","site_admin":false},"repo":{"id":26097793,"name":"vecty","full_name":"gopherjs/vecty","owner":{"login":"gopherjs","id":6654647,"avatar_url":"https://avatars.githubusercontent.com/u/6654647?v=3","gravatar_id":"","url":"https://api.github.com/users/gopherjs","html_url":"https://github.com/gopherjs","followers_url":"https://api.github.com/users/gopherjs/followers","following_url":"https://api.github.com/users/gopherjs/following{/other_user}","gists_url":"https://api.github.com/users/gopherjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherjs/subscriptions","organizations_url":"https://api.github.com/users/gopherjs/orgs","repos_url":"https://api.github.com/users/gopherjs/repos","events_url":"https://api.github.com/users/gopherjs/events{/privacy}","received_events_url":"https://api.github.com/users/gopherjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gopherjs/vecty","description":"Vecty: a frontend toolkit for Go","fork":false,"url":"https://api.github.com/repos/gopherjs/vecty","forks_url":"https://api.github.com/repos/gopherjs/vecty/forks","keys_url":"https://api.github.com/repos/gopherjs/vecty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gopherjs/vecty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gopherjs/vecty/teams","hooks_url":"https://api.github.com/repos/gopherjs/vecty/hooks","issue_events_url":"https://api.github.com/repos/gopherjs/vecty/issues/events{/number}","events_url":"https://api.github.com/repos/gopherjs/vecty/events","assignees_url":"https://api.github.com/repos/gopherjs/vecty/assignees{/user}","branches_url":"https://api.github.com/repos/gopherjs/vecty/branches{/branch}","tags_url":"https://api.github.com/repos/gopherjs/vecty/tags","blobs_url":"https://api.github.com/repos/gopherjs/vecty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gopherjs/vecty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gopherjs/vecty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gopherjs/vecty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gopherjs/vecty/statuses/{sha}","languages_url":"https://api.github.com/repos/gopherjs/vecty/languages","stargazers_url":"https://api.github.com/repos/gopherjs/vecty/stargazers","contributors_url":"https://api.github.com/repos/gopherjs/vecty/contributors","subscribers_url":"https://api.github.com/repos/gopherjs/vecty/subscribers","subscription_url":"https://api.github.com/repos/gopherjs/vecty/subscription","commits_url":"https://api.github.com/repos/gopherjs/vecty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gopherjs/vecty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gopherjs/vecty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gopherjs/vecty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gopherjs/vecty/contents/{+path}","compare_url":"https://api.github.com/repos/gopherjs/vecty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gopherjs/vecty/merges","archive_url":"https://api.github.com/repos/gopherjs/vecty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gopherjs/vecty/downloads","issues_url":"https://api.github.com/repos/gopherjs/vecty/issues{/number}","pulls_url":"https://api.github.com/repos/gopherjs/vecty/pulls{/number}","milestones_url":"https://api.github.com/repos/gopherjs/vecty/milestones{/number}","notifications_url":"https://api.github.com/repos/gopherjs/vecty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gopherjs/vecty/labels{/name}","releases_url":"https://api.github.com/repos/gopherjs/vecty/releases{/id}","deployments_url":"https://api.github.com/repos/gopherjs/vecty/deployments","created_at":"2014-11-03T00:32:48Z","updated_at":"2016-05-12T15:48:28Z","pushed_at":"2016-05-15T04:16:30Z","git_url":"git://github.com/gopherjs/vecty.git","ssh_url":"git@github.com:gopherjs/vecty.git","clone_url":"https://github.com/gopherjs/vecty.git","svn_url":"https://github.com/gopherjs/vecty","homepage":"","size":419,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":42,"default_branch":"master"}},"base":{"label":"gopherjs:master","ref":"master","sha":"86ed62aab01682520c8740c22a8e8f1e1c2298b8","user":{"login":"gopherjs","id":6654647,"avatar_url":"https://avatars.githubusercontent.com/u/6654647?v=3","gravatar_id":"","url":"https://api.github.com/users/gopherjs","html_url":"https://github.com/gopherjs","followers_url":"https://api.github.com/users/gopherjs/followers","following_url":"https://api.github.com/users/gopherjs/following{/other_user}","gists_url":"https://api.github.com/users/gopherjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherjs/subscriptions","organizations_url":"https://api.github.com/users/gopherjs/orgs","repos_url":"https://api.github.com/users/gopherjs/repos","events_url":"https://api.github.com/users/gopherjs/events{/privacy}","received_events_url":"https://api.github.com/users/gopherjs/received_events","type":"Organization","site_admin":false},"repo":{"id":26097793,"name":"vecty","full_name":"gopherjs/vecty","owner":{"login":"gopherjs","id":6654647,"avatar_url":"https://avatars.githubusercontent.com/u/6654647?v=3","gravatar_id":"","url":"https://api.github.com/users/gopherjs","html_url":"https://github.com/gopherjs","followers_url":"https://api.github.com/users/gopherjs/followers","following_url":"https://api.github.com/users/gopherjs/following{/other_user}","gists_url":"https://api.github.com/users/gopherjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherjs/subscriptions","organizations_url":"https://api.github.com/users/gopherjs/orgs","repos_url":"https://api.github.com/users/gopherjs/repos","events_url":"https://api.github.com/users/gopherjs/events{/privacy}","received_events_url":"https://api.github.com/users/gopherjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gopherjs/vecty","description":"Vecty: a frontend toolkit for Go","fork":false,"url":"https://api.github.com/repos/gopherjs/vecty","forks_url":"https://api.github.com/repos/gopherjs/vecty/forks","keys_url":"https://api.github.com/repos/gopherjs/vecty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gopherjs/vecty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gopherjs/vecty/teams","hooks_url":"https://api.github.com/repos/gopherjs/vecty/hooks","issue_events_url":"https://api.github.com/repos/gopherjs/vecty/issues/events{/number}","events_url":"https://api.github.com/repos/gopherjs/vecty/events","assignees_url":"https://api.github.com/repos/gopherjs/vecty/assignees{/user}","branches_url":"https://api.github.com/repos/gopherjs/vecty/branches{/branch}","tags_url":"https://api.github.com/repos/gopherjs/vecty/tags","blobs_url":"https://api.github.com/repos/gopherjs/vecty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gopherjs/vecty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gopherjs/vecty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gopherjs/vecty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gopherjs/vecty/statuses/{sha}","languages_url":"https://api.github.com/repos/gopherjs/vecty/languages","stargazers_url":"https://api.github.com/repos/gopherjs/vecty/stargazers","contributors_url":"https://api.github.com/repos/gopherjs/vecty/contributors","subscribers_url":"https://api.github.com/repos/gopherjs/vecty/subscribers","subscription_url":"https://api.github.com/repos/gopherjs/vecty/subscription","commits_url":"https://api.github.com/repos/gopherjs/vecty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gopherjs/vecty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gopherjs/vecty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gopherjs/vecty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gopherjs/vecty/contents/{+path}","compare_url":"https://api.github.com/repos/gopherjs/vecty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gopherjs/vecty/merges","archive_url":"https://api.github.com/repos/gopherjs/vecty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gopherjs/vecty/downloads","issues_url":"https://api.github.com/repos/gopherjs/vecty/issues{/number}","pulls_url":"https://api.github.com/repos/gopherjs/vecty/pulls{/number}","milestones_url":"https://api.github.com/repos/gopherjs/vecty/milestones{/number}","notifications_url":"https://api.github.com/repos/gopherjs/vecty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gopherjs/vecty/labels{/name}","releases_url":"https://api.github.com/repos/gopherjs/vecty/releases{/id}","deployments_url":"https://api.github.com/repos/gopherjs/vecty/deployments","created_at":"2014-11-03T00:32:48Z","updated_at":"2016-05-12T15:48:28Z","pushed_at":"2016-05-15T04:16:30Z","git_url":"git://github.com/gopherjs/vecty.git","ssh_url":"git@github.com:gopherjs/vecty.git","clone_url":"https://github.com/gopherjs/vecty.git","svn_url":"https://github.com/gopherjs/vecty","homepage":"","size":419,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":11,"forks":5,"open_issues":11,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/40"},"html":{"href":"https://github.com/gopherjs/vecty/pull/40"},"issue":{"href":"https://api.github.com/repos/gopherjs/vecty/issues/40"},"comments":{"href":"https://api.github.com/repos/gopherjs/vecty/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gopherjs/vecty/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/gopherjs/vecty/statuses/5d56a90127582094c8f0d28fb633b85a24b06576"}}}}