{"action":"created","issue":{"url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/14","repository_url":"https://api.github.com/repos/fluentsoftware/data-driven","labels_url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/14/comments","events_url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/14/events","html_url":"https://github.com/fluentsoftware/data-driven/issues/14","id":169424748,"number":14,"title":"Promise support","user":{"login":"antony","id":218949,"avatar_url":"https://avatars.githubusercontent.com/u/218949?v=3","gravatar_id":"","url":"https://api.github.com/users/antony","html_url":"https://github.com/antony","followers_url":"https://api.github.com/users/antony/followers","following_url":"https://api.github.com/users/antony/following{/other_user}","gists_url":"https://api.github.com/users/antony/gists{/gist_id}","starred_url":"https://api.github.com/users/antony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antony/subscriptions","organizations_url":"https://api.github.com/users/antony/orgs","repos_url":"https://api.github.com/users/antony/repos","events_url":"https://api.github.com/users/antony/events{/privacy}","received_events_url":"https://api.github.com/users/antony/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-04T17:05:22Z","updated_at":"2016-08-04T18:28:05Z","closed_at":null,"body":"A question, really.\r\n\r\nWe've started using promises for a lot of our tests in order to get a cleaner, more readable structure.\r\nWe're using mocha-as-promised (previously just used co), which gives us tests which look like this:\r\n\r\n```\r\nit('some stuff', function * () {\r\n  const value = yield someService.somePromise()\r\n  expect(value).to.equal(5)\r\n})\r\n```\r\n\r\nI can't seem to get `data-driven` to wrap this, as much as I'd like to. How difficult would it be (or is it already possible) to use data-driven along with generator functions?\r\n\r\nHappy to do a PR if it's something that you think could be accomplished."},"comment":{"url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/comments/237641090","html_url":"https://github.com/fluentsoftware/data-driven/issues/14#issuecomment-237641090","issue_url":"https://api.github.com/repos/fluentsoftware/data-driven/issues/14","id":237641090,"user":{"login":"mjtodd","id":551593,"avatar_url":"https://avatars.githubusercontent.com/u/551593?v=3","gravatar_id":"","url":"https://api.github.com/users/mjtodd","html_url":"https://github.com/mjtodd","followers_url":"https://api.github.com/users/mjtodd/followers","following_url":"https://api.github.com/users/mjtodd/following{/other_user}","gists_url":"https://api.github.com/users/mjtodd/gists{/gist_id}","starred_url":"https://api.github.com/users/mjtodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjtodd/subscriptions","organizations_url":"https://api.github.com/users/mjtodd/orgs","repos_url":"https://api.github.com/users/mjtodd/repos","events_url":"https://api.github.com/users/mjtodd/events{/privacy}","received_events_url":"https://api.github.com/users/mjtodd/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T18:28:04Z","updated_at":"2016-08-04T18:28:04Z","body":"Hi. That's really interesting. I have used co before but not mocha-as-promised. From your sample it looks really nice.\n\nI will take a look at trying it with data-driven and let you know.\n\nMatt\n\nOn 4 Aug 2016, 18:05 +0100, Antony Jones <notifications@github.com>, wrote:\n>\n> A question, really.\n>\n>\n> We've started using promises for a lot of our tests in order to get a cleaner, more readable structure.\n> We're using mocha-as-promised (previously just used co), which gives us tests which look like this:\n>\n> it('some stuff', function * () { const value = yield someService.somePromise() expect(value).to.equal(5) })\n>\n> I can't seem to get data-driven to wrap this, as much as I'd like to. How difficult would it be (or is it already possible) to use data-driven along with generator functions?\n>\n>\n> Happy to do a PR if it's something that you think could be accomplished.\n>\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub (https://github.com/fluentsoftware/data-driven/issues/14), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAhqqaTK9JQQQY_vf5TwEfiZXQoUI9YVks5qchvSgaJpZM4Jc6cR).\n>\n>\n>\n\n"}}
{"actor":{"display_login":"mjtodd"}}