{"action":"created","issue":{"url":"https://api.github.com/repos/steveire/grantlee/issues/20","repository_url":"https://api.github.com/repos/steveire/grantlee","labels_url":"https://api.github.com/repos/steveire/grantlee/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/steveire/grantlee/issues/20/comments","events_url":"https://api.github.com/repos/steveire/grantlee/issues/20/events","html_url":"https://github.com/steveire/grantlee/pull/20","id":144915875,"number":20,"title":"Add support for rendering associative containers","user":{"login":"dantti","id":29507,"avatar_url":"https://avatars.githubusercontent.com/u/29507?v=3","gravatar_id":"","url":"https://api.github.com/users/dantti","html_url":"https://github.com/dantti","followers_url":"https://api.github.com/users/dantti/followers","following_url":"https://api.github.com/users/dantti/following{/other_user}","gists_url":"https://api.github.com/users/dantti/gists{/gist_id}","starred_url":"https://api.github.com/users/dantti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantti/subscriptions","organizations_url":"https://api.github.com/users/dantti/orgs","repos_url":"https://api.github.com/users/dantti/repos","events_url":"https://api.github.com/users/dantti/events{/privacy}","received_events_url":"https://api.github.com/users/dantti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-31T14:21:07Z","updated_at":"2016-04-05T20:35:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/steveire/grantlee/pulls/20","html_url":"https://github.com/steveire/grantlee/pull/20","diff_url":"https://github.com/steveire/grantlee/pull/20.diff","patch_url":"https://github.com/steveire/grantlee/pull/20.patch"},"body":"Having a QVariant that can be converted to QVariantHash\r\nor QVariantMap, is now rendered if a pair or single key\r\nargument is provided, allowing template like this to\r\nbe valid:\r\n{% for key, value in items %}\r\n  {{ key }}:{{ value }}\r\n{% endfo %}\r\nThe code also fixes some tests that should give syntax\r\nerrors, based on DJango tests."},"comment":{"url":"https://api.github.com/repos/steveire/grantlee/issues/comments/205979499","html_url":"https://github.com/steveire/grantlee/pull/20#issuecomment-205979499","issue_url":"https://api.github.com/repos/steveire/grantlee/issues/20","id":205979499,"user":{"login":"steveire","id":37486,"avatar_url":"https://avatars.githubusercontent.com/u/37486?v=3","gravatar_id":"","url":"https://api.github.com/users/steveire","html_url":"https://github.com/steveire","followers_url":"https://api.github.com/users/steveire/followers","following_url":"https://api.github.com/users/steveire/following{/other_user}","gists_url":"https://api.github.com/users/steveire/gists{/gist_id}","starred_url":"https://api.github.com/users/steveire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveire/subscriptions","organizations_url":"https://api.github.com/users/steveire/orgs","repos_url":"https://api.github.com/users/steveire/repos","events_url":"https://api.github.com/users/steveire/events{/privacy}","received_events_url":"https://api.github.com/users/steveire/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T20:35:46Z","updated_at":"2016-04-05T20:35:46Z","body":"I spent some time cleaning up your branch and pushed the result as the `clean-up-for-tag` branch. \r\n\r\nIt would be really helpful if you would ensure that you do one thing per commit. See for example how I split out a dedicated commit for the comma errors and another one for dead code removal. It makes review much easier because the commit message only describes one thing and the code is only doing one thing. \r\n\r\nPlease have a look at the branch and update commit messages etc if needed. I'm not finished reviewing yet. I'm wondering for example why the Grantlee code here seems more complex than the equivalent django code. It may simply be that python makes this kind of thing easier. That is the kind of comparison that should be made (and explained) in the commit message one way or the other. Having things like that already explained in the commit message (if you already know the answers) also makes review easier.\r\n\r\nI'll continue with this soon. Thanks!"}}