{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/62136289","id":62136289,"diff_hunk":"@@ -98,6 +100,11 @@ EmuWindow_SDL2::EmuWindow_SDL2() {\n         exit(1);\n     }\n \n+    if (!gladLoadGLLoader((GLADloadproc)SDL_GL_GetProcAddress)) {","path":"src/citra/emu_window/emu_window_sdl2.cpp","position":13,"original_position":13,"commit_id":"3cb7d0bdb9c1e028093dba9f2e84a7e4c4fcff05","original_commit_id":"3cb7d0bdb9c1e028093dba9f2e84a7e4c4fcff05","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"This cast looks.. bad?\r\n1. We don't use C Style casts anymore\r\n2. Casting function pointers is a really bad idea because it's possible to break the stack etc. by passing a callback with wrong signature (without a warning!).","created_at":"2016-05-05T00:25:46Z","updated_at":"2016-05-05T00:25:46Z","html_url":"https://github.com/citra-emu/citra/pull/1544#discussion_r62136289","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/1544","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/62136289"},"html":{"href":"https://github.com/citra-emu/citra/pull/1544#discussion_r62136289"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1544"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1544","id":63455361,"html_url":"https://github.com/citra-emu/citra/pull/1544","diff_url":"https://github.com/citra-emu/citra/pull/1544.diff","patch_url":"https://github.com/citra-emu/citra/pull/1544.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1544","number":1544,"state":"open","locked":false,"title":"Move glad initialisation to the frontend","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"body":"On SDL2 this allows it to use SDL_GL_GetProcAddress() instead of the\r\ndefault function loader, and fixes a crash when using apitrace with an\r\nEGL context.\r\n\r\nOn Qt we will need to migrate from QGLWidget to QOpenGLWidget and\r\nQOpenGLContext before we can use gladLoadGLLoader() instead of\r\ngladLoadGL(), since the former doesn’t expose a function loader.","created_at":"2016-03-19T01:46:31Z","updated_at":"2016-05-05T00:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0526f8925bfef084e6bccdb6ba0822e8ce01ff48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/1544/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/1544/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1544/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/3cb7d0bdb9c1e028093dba9f2e84a7e4c4fcff05","head":{"label":"linkmauve:move-glad-init","ref":"move-glad-init","sha":"3cb7d0bdb9c1e028093dba9f2e84a7e4c4fcff05","user":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"repo":{"id":23252208,"name":"citra","full_name":"linkmauve/citra","owner":{"login":"linkmauve","id":7755816,"avatar_url":"https://avatars.githubusercontent.com/u/7755816?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmauve","html_url":"https://github.com/linkmauve","followers_url":"https://api.github.com/users/linkmauve/followers","following_url":"https://api.github.com/users/linkmauve/following{/other_user}","gists_url":"https://api.github.com/users/linkmauve/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmauve/subscriptions","organizations_url":"https://api.github.com/users/linkmauve/orgs","repos_url":"https://api.github.com/users/linkmauve/repos","events_url":"https://api.github.com/users/linkmauve/events{/privacy}","received_events_url":"https://api.github.com/users/linkmauve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linkmauve/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/linkmauve/citra","forks_url":"https://api.github.com/repos/linkmauve/citra/forks","keys_url":"https://api.github.com/repos/linkmauve/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkmauve/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkmauve/citra/teams","hooks_url":"https://api.github.com/repos/linkmauve/citra/hooks","issue_events_url":"https://api.github.com/repos/linkmauve/citra/issues/events{/number}","events_url":"https://api.github.com/repos/linkmauve/citra/events","assignees_url":"https://api.github.com/repos/linkmauve/citra/assignees{/user}","branches_url":"https://api.github.com/repos/linkmauve/citra/branches{/branch}","tags_url":"https://api.github.com/repos/linkmauve/citra/tags","blobs_url":"https://api.github.com/repos/linkmauve/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkmauve/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkmauve/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkmauve/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkmauve/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/linkmauve/citra/languages","stargazers_url":"https://api.github.com/repos/linkmauve/citra/stargazers","contributors_url":"https://api.github.com/repos/linkmauve/citra/contributors","subscribers_url":"https://api.github.com/repos/linkmauve/citra/subscribers","subscription_url":"https://api.github.com/repos/linkmauve/citra/subscription","commits_url":"https://api.github.com/repos/linkmauve/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkmauve/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkmauve/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkmauve/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkmauve/citra/contents/{+path}","compare_url":"https://api.github.com/repos/linkmauve/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkmauve/citra/merges","archive_url":"https://api.github.com/repos/linkmauve/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkmauve/citra/downloads","issues_url":"https://api.github.com/repos/linkmauve/citra/issues{/number}","pulls_url":"https://api.github.com/repos/linkmauve/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/linkmauve/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/linkmauve/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkmauve/citra/labels{/name}","releases_url":"https://api.github.com/repos/linkmauve/citra/releases{/id}","deployments_url":"https://api.github.com/repos/linkmauve/citra/deployments","created_at":"2014-08-23T09:07:09Z","updated_at":"2016-05-03T02:18:24Z","pushed_at":"2016-05-03T11:08:24Z","git_url":"git://github.com/linkmauve/citra.git","ssh_url":"git@github.com:linkmauve/citra.git","clone_url":"https://github.com/linkmauve/citra.git","svn_url":"https://github.com/linkmauve/citra","homepage":null,"size":12457,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"6d02fe39f50436e0d1751b81e097b412645e4418","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-05-04T22:59:11Z","pushed_at":"2016-05-04T17:00:55Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":20059,"stargazers_count":1814,"watchers_count":1814,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":422,"mirror_url":null,"open_issues_count":198,"forks":422,"open_issues":198,"watchers":1814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1544"},"html":{"href":"https://github.com/citra-emu/citra/pull/1544"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1544"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1544/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1544/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1544/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/3cb7d0bdb9c1e028093dba9f2e84a7e4c4fcff05"}}}}