{"action":"created","issue":{"url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/719","repository_url":"https://api.github.com/repos/Geeklog-Core/geeklog","labels_url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/719/labels{/name}","comments_url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/719/comments","events_url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/719/events","html_url":"https://github.com/Geeklog-Core/geeklog/issues/719","id":197905842,"number":719,"title":"Default of COM_errorLog variable changed from writing to error log to displaying on screen","user":{"login":"eSilverStrike","id":11776861,"avatar_url":"https://avatars.githubusercontent.com/u/11776861?v=3","gravatar_id":"","url":"https://api.github.com/users/eSilverStrike","html_url":"https://github.com/eSilverStrike","followers_url":"https://api.github.com/users/eSilverStrike/followers","following_url":"https://api.github.com/users/eSilverStrike/following{/other_user}","gists_url":"https://api.github.com/users/eSilverStrike/gists{/gist_id}","starred_url":"https://api.github.com/users/eSilverStrike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eSilverStrike/subscriptions","organizations_url":"https://api.github.com/users/eSilverStrike/orgs","repos_url":"https://api.github.com/users/eSilverStrike/repos","events_url":"https://api.github.com/users/eSilverStrike/events{/privacy}","received_events_url":"https://api.github.com/users/eSilverStrike/received_events","type":"User","site_admin":false},"labels":[{"id":305727206,"url":"https://api.github.com/repos/Geeklog-Core/geeklog/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"mystralkk","id":2015377,"avatar_url":"https://avatars.githubusercontent.com/u/2015377?v=3","gravatar_id":"","url":"https://api.github.com/users/mystralkk","html_url":"https://github.com/mystralkk","followers_url":"https://api.github.com/users/mystralkk/followers","following_url":"https://api.github.com/users/mystralkk/following{/other_user}","gists_url":"https://api.github.com/users/mystralkk/gists{/gist_id}","starred_url":"https://api.github.com/users/mystralkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystralkk/subscriptions","organizations_url":"https://api.github.com/users/mystralkk/orgs","repos_url":"https://api.github.com/users/mystralkk/repos","events_url":"https://api.github.com/users/mystralkk/events{/privacy}","received_events_url":"https://api.github.com/users/mystralkk/received_events","type":"User","site_admin":false},"assignees":[{"login":"mystralkk","id":2015377,"avatar_url":"https://avatars.githubusercontent.com/u/2015377?v=3","gravatar_id":"","url":"https://api.github.com/users/mystralkk","html_url":"https://github.com/mystralkk","followers_url":"https://api.github.com/users/mystralkk/followers","following_url":"https://api.github.com/users/mystralkk/following{/other_user}","gists_url":"https://api.github.com/users/mystralkk/gists{/gist_id}","starred_url":"https://api.github.com/users/mystralkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystralkk/subscriptions","organizations_url":"https://api.github.com/users/mystralkk/orgs","repos_url":"https://api.github.com/users/mystralkk/repos","events_url":"https://api.github.com/users/mystralkk/events{/privacy}","received_events_url":"https://api.github.com/users/mystralkk/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Geeklog-Core/geeklog/milestones/42","html_url":"https://github.com/Geeklog-Core/geeklog/milestone/42","labels_url":"https://api.github.com/repos/Geeklog-Core/geeklog/milestones/42/labels","id":1484694,"number":42,"title":"2.1.2","description":null,"creator":{"login":"mystralkk","id":2015377,"avatar_url":"https://avatars.githubusercontent.com/u/2015377?v=3","gravatar_id":"","url":"https://api.github.com/users/mystralkk","html_url":"https://github.com/mystralkk","followers_url":"https://api.github.com/users/mystralkk/followers","following_url":"https://api.github.com/users/mystralkk/following{/other_user}","gists_url":"https://api.github.com/users/mystralkk/gists{/gist_id}","starred_url":"https://api.github.com/users/mystralkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystralkk/subscriptions","organizations_url":"https://api.github.com/users/mystralkk/orgs","repos_url":"https://api.github.com/users/mystralkk/repos","events_url":"https://api.github.com/users/mystralkk/events{/privacy}","received_events_url":"https://api.github.com/users/mystralkk/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":56,"state":"open","created_at":"2016-01-05T12:13:33Z","updated_at":"2016-12-31T02:46:24Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-12-28T19:42:33Z","updated_at":"2016-12-31T02:46:24Z","closed_at":"2016-12-31T02:46:24Z","body":"```\r\nfunction COM_errorLog($logEntry, $actionId = '')\r\n```\r\n\r\nwas changed to\r\n\r\n```\r\nfunction COM_errorLog($logEntry, $actionId = 2)\r\n```\r\n\r\nwhich results in the default behavior of writing to the error log changed to displaying on screen.\r\n\r\nNot sure if this is a good idea as in a few spots (like the oauth class (which is now fixed but other areas are not)) rely on this default behaviour of writing to the error log. Especially since if  COM_errorLog is not set to anything and wasn't planned to be display on the screen.\r\n\r\nWe should either change it back or double check all of the COM_errorlog calls in core and the plugins to be on the safe side (and this may still cause problems in 3rd party plugins)."},"comment":{"url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/comments/269845106","html_url":"https://github.com/Geeklog-Core/geeklog/issues/719#issuecomment-269845106","issue_url":"https://api.github.com/repos/Geeklog-Core/geeklog/issues/719","id":269845106,"user":{"login":"mystralkk","id":2015377,"avatar_url":"https://avatars.githubusercontent.com/u/2015377?v=3","gravatar_id":"","url":"https://api.github.com/users/mystralkk","html_url":"https://github.com/mystralkk","followers_url":"https://api.github.com/users/mystralkk/followers","following_url":"https://api.github.com/users/mystralkk/following{/other_user}","gists_url":"https://api.github.com/users/mystralkk/gists{/gist_id}","starred_url":"https://api.github.com/users/mystralkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystralkk/subscriptions","organizations_url":"https://api.github.com/users/mystralkk/orgs","repos_url":"https://api.github.com/users/mystralkk/repos","events_url":"https://api.github.com/users/mystralkk/events{/privacy}","received_events_url":"https://api.github.com/users/mystralkk/received_events","type":"User","site_admin":false},"created_at":"2016-12-31T02:46:24Z","updated_at":"2016-12-31T02:46:24Z","body":"I added conditional logging (only when $_CONF['rootdebug'] is set) with chanse set b12d6bc."}}
{"actor":{"display_login":"mystralkk"}}