{"action":"created","issue":{"url":"https://api.github.com/repos/certbot/certbot/issues/3347","repository_url":"https://api.github.com/repos/certbot/certbot","labels_url":"https://api.github.com/repos/certbot/certbot/issues/3347/labels{/name}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/3347/comments","events_url":"https://api.github.com/repos/certbot/certbot/issues/3347/events","html_url":"https://github.com/certbot/certbot/issues/3347","id":168176514,"number":3347,"title":"Error message for empty domain name is incorrect","user":{"login":"ye","id":133924,"avatar_url":"https://avatars.githubusercontent.com/u/133924?v=3","gravatar_id":"","url":"https://api.github.com/users/ye","html_url":"https://github.com/ye","followers_url":"https://api.github.com/users/ye/followers","following_url":"https://api.github.com/users/ye/following{/other_user}","gists_url":"https://api.github.com/users/ye/gists{/gist_id}","starred_url":"https://api.github.com/users/ye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye/subscriptions","organizations_url":"https://api.github.com/users/ye/orgs","repos_url":"https://api.github.com/users/ye/repos","events_url":"https://api.github.com/users/ye/events{/privacy}","received_events_url":"https://api.github.com/users/ye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/certbot/certbot/labels/easy-fix","name":"easy-fix","color":"207de5"},{"url":"https://api.github.com/repos/certbot/certbot/labels/error%20handling","name":"error handling","color":"eb6420"},{"url":"https://api.github.com/repos/certbot/certbot/labels/Good%20Volunteer%20Task","name":"Good Volunteer Task","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/certbot/certbot/milestones/8","html_url":"https://github.com/certbot/certbot/milestones/1.0.0","labels_url":"https://api.github.com/repos/certbot/certbot/milestones/8/labels","id":1353913,"number":8,"title":"1.0.0","description":"In theory, this milestone should be for things we consider necessary to consider the client solid and out of beta.  But it's become something of a holding place for many kinds of polishing tickets, and will probably need to be triaged further.","creator":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"open_issues":141,"closed_issues":42,"state":"open","created_at":"2015-10-13T19:41:13Z","updated_at":"2016-08-18T21:24:20Z","due_on":"2016-09-15T07:00:00Z","closed_at":null},"comments":2,"created_at":"2016-07-28T19:26:54Z","updated_at":"2016-08-19T17:39:31Z","closed_at":null,"body":"In a recent commit that [Fix FQDN checks](https://github.com/certbot/certbot/commit/6156b452bcf7c924f12c334e7094ff5a9049ee37),\r\n the error message fails to address the case where domain name is an empty string. See below.\r\n\r\n`--domain` is a CSV string, but the 2nd DNS name is parsed to be an empty string, which caused \r\nand error message `Requested domain  is not a FQDN because label  is too long.`. \r\n\r\nIt would have been more logically to say `Requested domain \"\" is not a FQDN because label  is either empty or too long.`\r\n\r\nThe check it failed is here: https://github.com/certbot/certbot/blob/6156b452bcf7c924f12c334e7094ff5a9049ee37/certbot/util.py#L432\r\n\r\n\r\n```bash\r\n$ docker run --rm -it --entrypoint bash quay.io/letsencrypt/letsencrypt:latest\r\nroot@4b80271cdd6c:/opt/certbot# certbot certonly \\\r\n>     --webroot \\\r\n>     --non-interactive \\\r\n>     --agree-tos \\\r\n>     --email test@test.com \\\r\n>     --webroot-path /var/lib/letsencrypt \\\r\n>     --domain www.example.com,,test1.example.com \\\r\n>     --no-verify-ssl \\\r\n>     --debug \\\r\n>    --test-cert\r\nRequested domain  is not a FQDN because label  is too long.\r\n```"},"comment":{"url":"https://api.github.com/repos/certbot/certbot/issues/comments/241084267","html_url":"https://github.com/certbot/certbot/issues/3347#issuecomment-241084267","issue_url":"https://api.github.com/repos/certbot/certbot/issues/3347","id":241084267,"user":{"login":"ye","id":133924,"avatar_url":"https://avatars.githubusercontent.com/u/133924?v=3","gravatar_id":"","url":"https://api.github.com/users/ye","html_url":"https://github.com/ye","followers_url":"https://api.github.com/users/ye/followers","following_url":"https://api.github.com/users/ye/following{/other_user}","gists_url":"https://api.github.com/users/ye/gists{/gist_id}","starred_url":"https://api.github.com/users/ye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye/subscriptions","organizations_url":"https://api.github.com/users/ye/orgs","repos_url":"https://api.github.com/users/ye/repos","events_url":"https://api.github.com/users/ye/events{/privacy}","received_events_url":"https://api.github.com/users/ye/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T17:39:30Z","updated_at":"2016-08-19T17:39:30Z","body":"@jpluimers by whom? Shouldn't this be mentioned so that an association can be established?"}}
{"actor":{"display_login":"ye"}}