{"action":"created","comment":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/86873801","pull_request_review_id":7509829,"id":86873801,"diff_hunk":"@@ -59,6 +59,9 @@\n $ADODB_FETCH_MODE = ADODB_FETCH_ASSOC;\n define( 'ADODB_ASSOC_CASE', ADODB_ASSOC_CASE_LOWER );\n \n+# Stores the functional database type based on db driver\n+$g_db_functional_type;","path":"core/database_api.php","position":5,"original_position":5,"commit_id":"2552b618c31efdbf073cc60caa7282a5cec92d6c","original_commit_id":"2552b618c31efdbf073cc60caa7282a5cec92d6c","user":{"login":"cproensa","id":14123811,"avatar_url":"https://avatars.githubusercontent.com/u/14123811?v=3","gravatar_id":"","url":"https://api.github.com/users/cproensa","html_url":"https://github.com/cproensa","followers_url":"https://api.github.com/users/cproensa/followers","following_url":"https://api.github.com/users/cproensa/following{/other_user}","gists_url":"https://api.github.com/users/cproensa/gists{/gist_id}","starred_url":"https://api.github.com/users/cproensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproensa/subscriptions","organizations_url":"https://api.github.com/users/cproensa/orgs","repos_url":"https://api.github.com/users/cproensa/repos","events_url":"https://api.github.com/users/cproensa/events{/privacy}","received_events_url":"https://api.github.com/users/cproensa/received_events","type":"User","site_admin":false},"body":"Undefined at that point. But present for the sake of documenting it.\r\nThis could be initialized there, or as it is now, from db_connect()","created_at":"2016-11-07T21:31:49Z","updated_at":"2016-11-07T21:31:49Z","html_url":"https://github.com/mantisbt/mantisbt/pull/942#discussion_r86873801","pull_request_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942","_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/86873801"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/942#discussion_r86873801"},"pull_request":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942"}}},"pull_request":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942","id":92505927,"html_url":"https://github.com/mantisbt/mantisbt/pull/942","diff_url":"https://github.com/mantisbt/mantisbt/pull/942.diff","patch_url":"https://github.com/mantisbt/mantisbt/pull/942.patch","issue_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/942","number":942,"state":"open","locked":false,"title":"Improve db_fetch_array performance","user":{"login":"cproensa","id":14123811,"avatar_url":"https://avatars.githubusercontent.com/u/14123811?v=3","gravatar_id":"","url":"https://api.github.com/users/cproensa","html_url":"https://github.com/cproensa","followers_url":"https://api.github.com/users/cproensa/followers","following_url":"https://api.github.com/users/cproensa/following{/other_user}","gists_url":"https://api.github.com/users/cproensa/gists{/gist_id}","starred_url":"https://api.github.com/users/cproensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproensa/subscriptions","organizations_url":"https://api.github.com/users/cproensa/orgs","repos_url":"https://api.github.com/users/cproensa/repos","events_url":"https://api.github.com/users/cproensa/events{/privacy}","received_events_url":"https://api.github.com/users/cproensa/received_events","type":"User","site_admin":false},"body":"Improve db_fetch_array performance by caching the result from:\r\ndb_is_pgsql()\r\ndb_is_oracle()\r\n\r\nBased on profiling, the repeated calls were using up to 20% of total time\r\nfor the db_fetch_array execution.\r\n\r\nFixes: #21871","created_at":"2016-11-06T22:41:08Z","updated_at":"2016-11-07T21:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d141d916191f30a081f8d504288e4b4d992ddeda","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942/commits","review_comments_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942/comments","review_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/942/comments","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/2552b618c31efdbf073cc60caa7282a5cec92d6c","head":{"label":"cproensa:m13_0021871_db_fetch_array_performance","ref":"m13_0021871_db_fetch_array_performance","sha":"2552b618c31efdbf073cc60caa7282a5cec92d6c","user":{"login":"cproensa","id":14123811,"avatar_url":"https://avatars.githubusercontent.com/u/14123811?v=3","gravatar_id":"","url":"https://api.github.com/users/cproensa","html_url":"https://github.com/cproensa","followers_url":"https://api.github.com/users/cproensa/followers","following_url":"https://api.github.com/users/cproensa/following{/other_user}","gists_url":"https://api.github.com/users/cproensa/gists{/gist_id}","starred_url":"https://api.github.com/users/cproensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproensa/subscriptions","organizations_url":"https://api.github.com/users/cproensa/orgs","repos_url":"https://api.github.com/users/cproensa/repos","events_url":"https://api.github.com/users/cproensa/events{/privacy}","received_events_url":"https://api.github.com/users/cproensa/received_events","type":"User","site_admin":false},"repo":{"id":42000375,"name":"mantisbt","full_name":"cproensa/mantisbt","owner":{"login":"cproensa","id":14123811,"avatar_url":"https://avatars.githubusercontent.com/u/14123811?v=3","gravatar_id":"","url":"https://api.github.com/users/cproensa","html_url":"https://github.com/cproensa","followers_url":"https://api.github.com/users/cproensa/followers","following_url":"https://api.github.com/users/cproensa/following{/other_user}","gists_url":"https://api.github.com/users/cproensa/gists{/gist_id}","starred_url":"https://api.github.com/users/cproensa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproensa/subscriptions","organizations_url":"https://api.github.com/users/cproensa/orgs","repos_url":"https://api.github.com/users/cproensa/repos","events_url":"https://api.github.com/users/cproensa/events{/privacy}","received_events_url":"https://api.github.com/users/cproensa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cproensa/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":true,"url":"https://api.github.com/repos/cproensa/mantisbt","forks_url":"https://api.github.com/repos/cproensa/mantisbt/forks","keys_url":"https://api.github.com/repos/cproensa/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cproensa/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cproensa/mantisbt/teams","hooks_url":"https://api.github.com/repos/cproensa/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/cproensa/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/cproensa/mantisbt/events","assignees_url":"https://api.github.com/repos/cproensa/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/cproensa/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/cproensa/mantisbt/tags","blobs_url":"https://api.github.com/repos/cproensa/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cproensa/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cproensa/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cproensa/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cproensa/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/cproensa/mantisbt/languages","stargazers_url":"https://api.github.com/repos/cproensa/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/cproensa/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/cproensa/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/cproensa/mantisbt/subscription","commits_url":"https://api.github.com/repos/cproensa/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cproensa/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cproensa/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cproensa/mantisbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cproensa/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/cproensa/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cproensa/mantisbt/merges","archive_url":"https://api.github.com/repos/cproensa/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cproensa/mantisbt/downloads","issues_url":"https://api.github.com/repos/cproensa/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/cproensa/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/cproensa/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/cproensa/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cproensa/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/cproensa/mantisbt/releases{/id}","deployments_url":"https://api.github.com/repos/cproensa/mantisbt/deployments","created_at":"2015-09-06T11:36:59Z","updated_at":"2016-01-15T10:15:25Z","pushed_at":"2016-11-07T20:05:05Z","git_url":"git://github.com/cproensa/mantisbt.git","ssh_url":"git@github.com:cproensa/mantisbt.git","clone_url":"https://github.com/cproensa/mantisbt.git","svn_url":"https://github.com/cproensa/mantisbt","homepage":"http://www.mantisbt.org","size":56266,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mantisbt:master-1.3.x","ref":"master-1.3.x","sha":"fcad5753d5beecf25a509e37d0a01a549b06a05f","user":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=3","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"repo":{"id":747755,"name":"mantisbt","full_name":"mantisbt/mantisbt","owner":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=3","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantisbt/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":false,"url":"https://api.github.com/repos/mantisbt/mantisbt","forks_url":"https://api.github.com/repos/mantisbt/mantisbt/forks","keys_url":"https://api.github.com/repos/mantisbt/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantisbt/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantisbt/mantisbt/teams","hooks_url":"https://api.github.com/repos/mantisbt/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/mantisbt/mantisbt/events","assignees_url":"https://api.github.com/repos/mantisbt/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/mantisbt/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/mantisbt/mantisbt/tags","blobs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantisbt/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantisbt/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/mantisbt/mantisbt/languages","stargazers_url":"https://api.github.com/repos/mantisbt/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/mantisbt/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/mantisbt/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/mantisbt/mantisbt/subscription","commits_url":"https://api.github.com/repos/mantisbt/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantisbt/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantisbt/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/mantisbt/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantisbt/mantisbt/merges","archive_url":"https://api.github.com/repos/mantisbt/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantisbt/mantisbt/downloads","issues_url":"https://api.github.com/repos/mantisbt/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/mantisbt/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/mantisbt/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantisbt/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/mantisbt/mantisbt/releases{/id}","deployments_url":"https://api.github.com/repos/mantisbt/mantisbt/deployments","created_at":"2010-06-29T21:42:07Z","updated_at":"2016-11-05T16:45:20Z","pushed_at":"2016-11-07T20:05:06Z","git_url":"git://github.com/mantisbt/mantisbt.git","ssh_url":"git@github.com:mantisbt/mantisbt.git","clone_url":"https://github.com/mantisbt/mantisbt.git","svn_url":"https://github.com/mantisbt/mantisbt","homepage":"http://www.mantisbt.org","size":81669,"stargazers_count":649,"watchers_count":649,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":364,"mirror_url":null,"open_issues_count":72,"forks":364,"open_issues":72,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/942"},"issue":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/942"},"comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/mantisbt/mantisbt/statuses/2552b618c31efdbf073cc60caa7282a5cec92d6c"}}}}
{"actor":{"display_login":"cproensa"}}