{"action":"opened","number":92,"pull_request":{"url":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92","id":57303167,"html_url":"https://github.com/Shopify/toxiproxy/pull/92","diff_url":"https://github.com/Shopify/toxiproxy/pull/92.diff","patch_url":"https://github.com/Shopify/toxiproxy/pull/92.patch","issue_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/92","number":92,"state":"open","locked":false,"title":"api: toxics are sent to client as array rather than map","user":{"login":"jpittis","id":5767836,"avatar_url":"https://avatars.githubusercontent.com/u/5767836?v=3","gravatar_id":"","url":"https://api.github.com/users/jpittis","html_url":"https://github.com/jpittis","followers_url":"https://api.github.com/users/jpittis/followers","following_url":"https://api.github.com/users/jpittis/following{/other_user}","gists_url":"https://api.github.com/users/jpittis/gists{/gist_id}","starred_url":"https://api.github.com/users/jpittis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpittis/subscriptions","organizations_url":"https://api.github.com/users/jpittis/orgs","repos_url":"https://api.github.com/users/jpittis/repos","events_url":"https://api.github.com/users/jpittis/events{/privacy}","received_events_url":"https://api.github.com/users/jpittis/received_events","type":"User","site_admin":false},"body":"> Would it be simpler to return an array of toxics instead of a map with the names as keys?\r\n\r\nThis changes the api to return a list of toxics rather than a map of name to toxic.\r\n\r\nI did not change how toxics are implemented internally. Instead, this is a front end change.\r\n\r\n@Sirupsen and @xthexder were unsure about whether this is needed.\r\n\r\n## Before\r\n```\r\n\"toxics\": {\r\n    \"myToxic1\": {\"name\": \"myToxic1\"...},\r\n    \"myToxic2\": {\"name\": \"myToxic2\"...}\r\n}\r\n```\r\n## After\r\n```\r\n\"toxics\": [\r\n    {\"name\": \"myToxic1\"...},\r\n    {\"name\": \"myToxic2\"...}\r\n]\r\n```\r\n","created_at":"2016-01-27T01:56:01Z","updated_at":"2016-01-27T01:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92/commits","review_comments_url":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92/comments","review_comment_url":"https://api.github.com/repos/Shopify/toxiproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/92/comments","statuses_url":"https://api.github.com/repos/Shopify/toxiproxy/statuses/93625a1b2b7903ed2d31a9838f104289989d0dca","head":{"label":"Shopify:array-toxics","ref":"array-toxics","sha":"93625a1b2b7903ed2d31a9838f104289989d0dca","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":23664475,"name":"toxiproxy","full_name":"Shopify/toxiproxy","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/toxiproxy","description":":alarm_clock: :fire: A proxy to simulate network and system conditions","fork":false,"url":"https://api.github.com/repos/Shopify/toxiproxy","forks_url":"https://api.github.com/repos/Shopify/toxiproxy/forks","keys_url":"https://api.github.com/repos/Shopify/toxiproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/toxiproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/toxiproxy/teams","hooks_url":"https://api.github.com/repos/Shopify/toxiproxy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/toxiproxy/events","assignees_url":"https://api.github.com/repos/Shopify/toxiproxy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/toxiproxy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/toxiproxy/tags","blobs_url":"https://api.github.com/repos/Shopify/toxiproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/toxiproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/toxiproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/toxiproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/toxiproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/toxiproxy/languages","stargazers_url":"https://api.github.com/repos/Shopify/toxiproxy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/toxiproxy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/toxiproxy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/toxiproxy/subscription","commits_url":"https://api.github.com/repos/Shopify/toxiproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/toxiproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/toxiproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/toxiproxy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/toxiproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/toxiproxy/merges","archive_url":"https://api.github.com/repos/Shopify/toxiproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/toxiproxy/downloads","issues_url":"https://api.github.com/repos/Shopify/toxiproxy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/toxiproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/toxiproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/toxiproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/toxiproxy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/toxiproxy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/toxiproxy/deployments","created_at":"2014-09-04T13:56:38Z","updated_at":"2016-01-26T00:24:57Z","pushed_at":"2016-01-27T01:14:41Z","git_url":"git://github.com/Shopify/toxiproxy.git","ssh_url":"git@github.com:Shopify/toxiproxy.git","clone_url":"https://github.com/Shopify/toxiproxy.git","svn_url":"https://github.com/Shopify/toxiproxy","homepage":"http://toxiproxy.io","size":2336,"stargazers_count":1083,"watchers_count":1083,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":13,"forks":39,"open_issues":13,"watchers":1083,"default_branch":"master"}},"base":{"label":"Shopify:2.0-dev","ref":"2.0-dev","sha":"70ac2edcc151bd04e39436307429bf679c70a5f4","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":23664475,"name":"toxiproxy","full_name":"Shopify/toxiproxy","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/toxiproxy","description":":alarm_clock: :fire: A proxy to simulate network and system conditions","fork":false,"url":"https://api.github.com/repos/Shopify/toxiproxy","forks_url":"https://api.github.com/repos/Shopify/toxiproxy/forks","keys_url":"https://api.github.com/repos/Shopify/toxiproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/toxiproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/toxiproxy/teams","hooks_url":"https://api.github.com/repos/Shopify/toxiproxy/hooks","issue_events_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/toxiproxy/events","assignees_url":"https://api.github.com/repos/Shopify/toxiproxy/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/toxiproxy/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/toxiproxy/tags","blobs_url":"https://api.github.com/repos/Shopify/toxiproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/toxiproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/toxiproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/toxiproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/toxiproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/toxiproxy/languages","stargazers_url":"https://api.github.com/repos/Shopify/toxiproxy/stargazers","contributors_url":"https://api.github.com/repos/Shopify/toxiproxy/contributors","subscribers_url":"https://api.github.com/repos/Shopify/toxiproxy/subscribers","subscription_url":"https://api.github.com/repos/Shopify/toxiproxy/subscription","commits_url":"https://api.github.com/repos/Shopify/toxiproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/toxiproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/toxiproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/toxiproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/toxiproxy/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/toxiproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/toxiproxy/merges","archive_url":"https://api.github.com/repos/Shopify/toxiproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/toxiproxy/downloads","issues_url":"https://api.github.com/repos/Shopify/toxiproxy/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/toxiproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/toxiproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/toxiproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/toxiproxy/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/toxiproxy/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/toxiproxy/deployments","created_at":"2014-09-04T13:56:38Z","updated_at":"2016-01-26T00:24:57Z","pushed_at":"2016-01-27T01:14:41Z","git_url":"git://github.com/Shopify/toxiproxy.git","ssh_url":"git@github.com:Shopify/toxiproxy.git","clone_url":"https://github.com/Shopify/toxiproxy.git","svn_url":"https://github.com/Shopify/toxiproxy","homepage":"http://toxiproxy.io","size":2336,"stargazers_count":1083,"watchers_count":1083,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":13,"forks":39,"open_issues":13,"watchers":1083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92"},"html":{"href":"https://github.com/Shopify/toxiproxy/pull/92"},"issue":{"href":"https://api.github.com/repos/Shopify/toxiproxy/issues/92"},"comments":{"href":"https://api.github.com/repos/Shopify/toxiproxy/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/toxiproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/toxiproxy/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/toxiproxy/statuses/93625a1b2b7903ed2d31a9838f104289989d0dca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":9,"changed_files":4}}