{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/66649985","id":66649985,"diff_hunk":"@@ -37,19 +37,32 @@\n   end\n \n   describe \".default\" do\n-    let!(:store)    { create(:store) }\n-    let!(:store_2)  { create(:store, default: true) }\n+    before do\n+      Spree::Store.delete_all","path":"core/spec/models/spree/store_spec.rb","position":null,"original_position":7,"commit_id":"b9fed03b254aab4e5616dea28ae6057dbb7d6a5b","original_commit_id":"131eb9874cd3dbfb3a0824f98268f089a5b5791f","user":{"login":"jordan-brough","id":23050,"avatar_url":"https://avatars.githubusercontent.com/u/23050?v=3","gravatar_id":"","url":"https://api.github.com/users/jordan-brough","html_url":"https://github.com/jordan-brough","followers_url":"https://api.github.com/users/jordan-brough/followers","following_url":"https://api.github.com/users/jordan-brough/following{/other_user}","gists_url":"https://api.github.com/users/jordan-brough/gists{/gist_id}","starred_url":"https://api.github.com/users/jordan-brough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordan-brough/subscriptions","organizations_url":"https://api.github.com/users/jordan-brough/orgs","repos_url":"https://api.github.com/users/jordan-brough/repos","events_url":"https://api.github.com/users/jordan-brough/events{/privacy}","received_events_url":"https://api.github.com/users/jordan-brough/received_events","type":"User","site_admin":false},"body":"> I still have no idea how a bunch of other tests (especially controller/feature tests) are managing to pass without any apparent creation of a spree default store\r\n\r\n@jrochkind are there any in particular that you see that look weird? I was curious about this also so I took a look at a few specs and the ones I looked at all seemed to be creating a default store in one way or another:\r\n\r\n- [frontend/spec/features/checkout_spec.rb](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/frontend/spec/features/checkout_spec.rb#L4) (via [\"checkout setup\"](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/frontend/spec/support/shared_contexts/checkout_setup.rb))\r\n- [frontend/spec/features/order_spec.rb](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/frontend/spec/features/order_spec.rb#L4) (via [OrderWalkthrough](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/core/lib/spree/testing_support/order_walkthrough.rb#L23))\r\n- [api/spec/controllers/spree/api/orders_controller_spec.rb](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/api/spec/controllers/spree/api/orders_controller_spec.rb#L7) (via [order factory](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/core/lib/spree/testing_support/factories/order_factory.rb#L15))\r\n- [backend/spec/controllers/spree/admin/orders_controller_spec.rb](https://github.com/solidusio/solidus/blob/3a8592d6861f12a9edd063858652729facfde377/backend/spec/controllers/spree/admin/orders_controller_spec.rb#L6)","created_at":"2016-06-10T17:23:30Z","updated_at":"2016-06-10T17:23:30Z","html_url":"https://github.com/solidusio/solidus/pull/1227#discussion_r66649985","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/1227","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/66649985"},"html":{"href":"https://github.com/solidusio/solidus/pull/1227#discussion_r66649985"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1227"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1227","id":73071380,"html_url":"https://github.com/solidusio/solidus/pull/1227","diff_url":"https://github.com/solidusio/solidus/pull/1227.diff","patch_url":"https://github.com/solidusio/solidus/pull/1227.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1227","number":1227,"state":"open","locked":false,"title":"Actually working tests for Spree::Store.default","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"body":"The previous tests weren't actually testing what they were described to test,\nthey weren't testing anything but their own setup.\n\nI think these tests effectively test what was meant to be tested.","created_at":"2016-06-08T15:45:57Z","updated_at":"2016-06-10T17:23:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c25ca2ed2ec3cbf88e6795f936e910e0210be31a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/1227/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/1227/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1227/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/b9fed03b254aab4e5616dea28ae6057dbb7d6a5b","head":{"label":"jrochkind:effective_store_default_specs","ref":"effective_store_default_specs","sha":"b9fed03b254aab4e5616dea28ae6057dbb7d6a5b","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"repo":{"id":49728060,"name":"solidus","full_name":"jrochkind/solidus","owner":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochkind/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/jrochkind/solidus","forks_url":"https://api.github.com/repos/jrochkind/solidus/forks","keys_url":"https://api.github.com/repos/jrochkind/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochkind/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochkind/solidus/teams","hooks_url":"https://api.github.com/repos/jrochkind/solidus/hooks","issue_events_url":"https://api.github.com/repos/jrochkind/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/jrochkind/solidus/events","assignees_url":"https://api.github.com/repos/jrochkind/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/jrochkind/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/jrochkind/solidus/tags","blobs_url":"https://api.github.com/repos/jrochkind/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochkind/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochkind/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochkind/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochkind/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochkind/solidus/languages","stargazers_url":"https://api.github.com/repos/jrochkind/solidus/stargazers","contributors_url":"https://api.github.com/repos/jrochkind/solidus/contributors","subscribers_url":"https://api.github.com/repos/jrochkind/solidus/subscribers","subscription_url":"https://api.github.com/repos/jrochkind/solidus/subscription","commits_url":"https://api.github.com/repos/jrochkind/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochkind/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochkind/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochkind/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochkind/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/jrochkind/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochkind/solidus/merges","archive_url":"https://api.github.com/repos/jrochkind/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochkind/solidus/downloads","issues_url":"https://api.github.com/repos/jrochkind/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/jrochkind/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochkind/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochkind/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochkind/solidus/labels{/name}","releases_url":"https://api.github.com/repos/jrochkind/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/jrochkind/solidus/deployments","created_at":"2016-01-15T15:42:18Z","updated_at":"2016-01-15T15:42:21Z","pushed_at":"2016-06-09T14:38:35Z","git_url":"git://github.com/jrochkind/solidus.git","ssh_url":"git@github.com:jrochkind/solidus.git","clone_url":"https://github.com/jrochkind/solidus.git","svn_url":"https://github.com/jrochkind/solidus","homepage":"http://solidus.io/","size":63554,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"3a8592d6861f12a9edd063858652729facfde377","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-06-10T06:33:30Z","pushed_at":"2016-06-10T15:27:36Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":69473,"stargazers_count":952,"watchers_count":952,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"open_issues_count":130,"forks":273,"open_issues":130,"watchers":952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1227"},"html":{"href":"https://github.com/solidusio/solidus/pull/1227"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1227"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/1227/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1227/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/1227/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/b9fed03b254aab4e5616dea28ae6057dbb7d6a5b"}}}}
{"actor":{"display_login":"jordan-brough"}}