{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/90558207","pull_request_review_id":11077975,"id":90558207,"diff_hunk":"@@ -780,15 +783,21 @@ static void verify_total_carnage_round_robin(const servers_fixture *f,\n     }\n   }\n \n-  /* no server is ever available. The persistent state is TRANSIENT_FAILURE */\n+  /* no server is ever available. The persistent state is TRANSIENT_FAILURE. May\n+   * also be CONNECTING if, under load, this check took too long to run and some\n+   * subchannel already transitioned to retrying. */\n   for (size_t i = 0; i < sequences->n; i++) {\n     const grpc_connectivity_state actual = sequences->connectivity_states[i];\n-    const grpc_connectivity_state expected = GRPC_CHANNEL_TRANSIENT_FAILURE;\n-    if (actual != expected) {\n+    uint32_t expected_bitset;","path":"test/core/client_channel/lb_policies_test.c","position":null,"original_position":35,"commit_id":"2239ebc966b68325475d90237f0aaffb99c5c4b7","original_commit_id":"731a8e6db3a31968dfc3d4d9a5011e3f433f343d","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"body":"Must demonstrate complexity :) JK, fair point. Done.","created_at":"2016-12-01T23:13:04Z","updated_at":"2016-12-01T23:13:04Z","html_url":"https://github.com/grpc/grpc/pull/8915#discussion_r90558207","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/8915","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/90558207"},"html":{"href":"https://github.com/grpc/grpc/pull/8915#discussion_r90558207"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8915"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/8915","id":95990935,"html_url":"https://github.com/grpc/grpc/pull/8915","diff_url":"https://github.com/grpc/grpc/pull/8915.diff","patch_url":"https://github.com/grpc/grpc/pull/8915.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/8915","number":8915,"state":"open","locked":false,"title":"Deflaked lb_policies_test","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-30T22:52:55Z","updated_at":"2016-12-01T23:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"914f8169bee35f9e349bba1588d4fb8ef6106123","assignee":{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},"assignees":[{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},{"login":"markdroth","id":18664614,"avatar_url":"https://avatars.githubusercontent.com/u/18664614?v=3","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/8915/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/8915/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/8915/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/2239ebc966b68325475d90237f0aaffb99c5c4b7","head":{"label":"dgquintas:lb_pol_test_deflake","ref":"lb_pol_test_deflake","sha":"2239ebc966b68325475d90237f0aaffb99c5c4b7","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"repo":{"id":34546298,"name":"grpc","full_name":"dgquintas/grpc","owner":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgquintas/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/dgquintas/grpc","forks_url":"https://api.github.com/repos/dgquintas/grpc/forks","keys_url":"https://api.github.com/repos/dgquintas/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgquintas/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgquintas/grpc/teams","hooks_url":"https://api.github.com/repos/dgquintas/grpc/hooks","issue_events_url":"https://api.github.com/repos/dgquintas/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/dgquintas/grpc/events","assignees_url":"https://api.github.com/repos/dgquintas/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/dgquintas/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/dgquintas/grpc/tags","blobs_url":"https://api.github.com/repos/dgquintas/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgquintas/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgquintas/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgquintas/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgquintas/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/dgquintas/grpc/languages","stargazers_url":"https://api.github.com/repos/dgquintas/grpc/stargazers","contributors_url":"https://api.github.com/repos/dgquintas/grpc/contributors","subscribers_url":"https://api.github.com/repos/dgquintas/grpc/subscribers","subscription_url":"https://api.github.com/repos/dgquintas/grpc/subscription","commits_url":"https://api.github.com/repos/dgquintas/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgquintas/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgquintas/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgquintas/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgquintas/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/dgquintas/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgquintas/grpc/merges","archive_url":"https://api.github.com/repos/dgquintas/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgquintas/grpc/downloads","issues_url":"https://api.github.com/repos/dgquintas/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/dgquintas/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/dgquintas/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/dgquintas/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgquintas/grpc/labels{/name}","releases_url":"https://api.github.com/repos/dgquintas/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/dgquintas/grpc/deployments","created_at":"2015-04-24T23:07:11Z","updated_at":"2016-02-03T02:19:19Z","pushed_at":"2016-12-01T23:12:36Z","git_url":"git://github.com/dgquintas/grpc.git","ssh_url":"git@github.com:dgquintas/grpc.git","clone_url":"https://github.com/dgquintas/grpc.git","svn_url":"https://github.com/dgquintas/grpc","homepage":"","size":86718,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"94298fbb955c1bc059e75f4c8c82f252c1cfeae9","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-12-01T19:47:19Z","pushed_at":"2016-12-01T23:12:37Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":224198,"stargazers_count":7883,"watchers_count":7883,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1535,"mirror_url":null,"open_issues_count":819,"forks":1535,"open_issues":819,"watchers":7883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8915"},"html":{"href":"https://github.com/grpc/grpc/pull/8915"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/8915"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/8915/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8915/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/8915/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/2239ebc966b68325475d90237f0aaffb99c5c4b7"}}}}
{"actor":{"display_login":"dgquintas"}}