{"action":"created","issue":{"url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/6","repository_url":"https://api.github.com/repos/devkitPro/3ds_portlibs","labels_url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/6/comments","events_url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/6/events","html_url":"https://github.com/devkitPro/3ds_portlibs/pull/6","id":156117738,"number":6,"title":"Libraries","user":{"login":"kitling","id":7027737,"avatar_url":"https://avatars.githubusercontent.com/u/7027737?v=3","gravatar_id":"","url":"https://api.github.com/users/kitling","html_url":"https://github.com/kitling","followers_url":"https://api.github.com/users/kitling/followers","following_url":"https://api.github.com/users/kitling/following{/other_user}","gists_url":"https://api.github.com/users/kitling/gists{/gist_id}","starred_url":"https://api.github.com/users/kitling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitling/subscriptions","organizations_url":"https://api.github.com/users/kitling/orgs","repos_url":"https://api.github.com/users/kitling/repos","events_url":"https://api.github.com/users/kitling/events{/privacy}","received_events_url":"https://api.github.com/users/kitling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-21T19:29:52Z","updated_at":"2016-05-22T19:27:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/devkitPro/3ds_portlibs/pulls/6","html_url":"https://github.com/devkitPro/3ds_portlibs/pull/6","diff_url":"https://github.com/devkitPro/3ds_portlibs/pull/6.diff","patch_url":"https://github.com/devkitPro/3ds_portlibs/pull/6.patch"},"body":"This includes all the libraries that are in cpp3ds's fork of 3ds_portlibs (except for two, OpenAL and PhysFS because of build errors), as well as MbedTLS, in a PR to 3ds_portlibs (cpp3ds/3ds_portlibs#3).\r\n\r\nDue to errors in net.c of MbedTLS, I disabled it in the config.h. More work can go into that later, presumably."},"comment":{"url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/comments/220850971","html_url":"https://github.com/devkitPro/3ds_portlibs/pull/6#issuecomment-220850971","issue_url":"https://api.github.com/repos/devkitPro/3ds_portlibs/issues/6","id":220850971,"user":{"login":"kitling","id":7027737,"avatar_url":"https://avatars.githubusercontent.com/u/7027737?v=3","gravatar_id":"","url":"https://api.github.com/users/kitling","html_url":"https://github.com/kitling","followers_url":"https://api.github.com/users/kitling/followers","following_url":"https://api.github.com/users/kitling/following{/other_user}","gists_url":"https://api.github.com/users/kitling/gists{/gist_id}","starred_url":"https://api.github.com/users/kitling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitling/subscriptions","organizations_url":"https://api.github.com/users/kitling/orgs","repos_url":"https://api.github.com/users/kitling/repos","events_url":"https://api.github.com/users/kitling/events{/privacy}","received_events_url":"https://api.github.com/users/kitling/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T19:27:11Z","updated_at":"2016-05-22T19:27:11Z","body":"That makes sense\r\n- I agree with that. I'm not quite sure why all three (unless they did remove one) xml libraries were in cpp3ds' portlibs. Perhaps they were experimenting wuth tradeoffs? Though... brief glances through their code tell me that they aren't using an xml parser at all? (I'm probably just missing it...) Hey, @Cruel, any thoughts?\r\n- I didn't want to remove libvorbis, so people have options, etc... but I am _glad_ to. I've had a first hand experience on how terrible libvorbis works on the 3ds.\r\n- For squashing, well...\r\n\r\n```<Kitlith> ... Mind if I just submit all the new ones (libraries) in 1 PR?```<br\\>\r\n```<@mtheall> 1 PR is fine, so long as each library is a seperate commit``` <br\\>\r\n```<@mtheall> roughly```\r\n\r\nSo, that's what I tried to stick to. If you want, after everything is addressed, I will definately squash. First though, time to remove libvorbis. :smile:\r\n\r\nI have my own concerns, too:\r\n\r\n- Is the style consistant with everything else? I tried as much as possible, but I'm still concerned because...\r\n- I messed stuff up *a lot*. The only reason you don't see that here is because I went back over and over with ```git commit --amend``` and ```git rebase -i HEAD~(N)``` whenever I saw an issue. That said, I think I got it down now, but I may have still missed something somewhere."}}
{"actor":{"display_login":"kitling"}}