{"action":"created","comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments/54804607","id":54804607,"diff_hunk":"@@ -160,6 +160,36 @@ def increment_year(self):\n         self.policy.set_year(self.policy.current_year + 1)\n         self.behavior.set_year(self.policy.current_year)\n \n+    def year_increment(self, advance_to_year):\n+        '''\n+        The year_increment function gives an optional way of implementing\n+        increment year functionality by immediately specifying the year\n+        as input. Robustness has been added to ensure input is of good shape.\n+        '''\n+        if isinstance(advance_to_year, int):","path":"taxcalc/calculate.py","position":10,"original_position":10,"commit_id":"a5117fc8733d3ad8c27ac8b9b468a2f61f04dc6b","original_commit_id":"a5117fc8733d3ad8c27ac8b9b468a2f61f04dc6b","user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=3","gravatar_id":"","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"body":"In Python, we typically try to avoid type checking unless we really need to. Here I think it is not necessary.","created_at":"2016-03-02T22:36:26Z","updated_at":"2016-03-02T22:36:26Z","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/628#discussion_r54804607","pull_request_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628","_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments/54804607"},"html":{"href":"https://github.com/open-source-economics/Tax-Calculator/pull/628#discussion_r54804607"},"pull_request":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628"}}},"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628","id":61461611,"html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/628","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/628.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/628.patch","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/628","number":628,"state":"open","locked":false,"title":"Enhancement of `increment year`","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"body":"This PR adds an optional way of doing increment year. Previously, increment year could be achieved by \r\n```\r\nfor i in range(4):\r\n    calc.increment_year()\r\nassert calc.current_year == 2017\r\n```\r\n\r\nRight now, alternatively, we could use\r\n```\r\ncalc.year_increment(2017)\r\n```\r\nto specify the desired tax year. Iteration and assertion will be automatically made. \r\n\r\nPrevious `increment_year()` option was still retained, as it was excessively used in testing suite.\r\n\r\n@Amy-Xu @MattHJensen @martinholmer \r\nPlease take a look, any comments, concerns or remarks would be appreciated.","created_at":"2016-03-02T20:27:28Z","updated_at":"2016-03-02T22:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a11b529e58328943dd3dbea0f6809c7fe4afee5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/628/comments","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/a5117fc8733d3ad8c27ac8b9b468a2f61f04dc6b","head":{"label":"GoFroggyRun:in_year","ref":"in_year","sha":"a5117fc8733d3ad8c27ac8b9b468a2f61f04dc6b","user":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"repo":{"id":39048671,"name":"Tax-Calculator","full_name":"GoFroggyRun/Tax-Calculator","owner":{"login":"GoFroggyRun","id":13324931,"avatar_url":"https://avatars.githubusercontent.com/u/13324931?v=3","gravatar_id":"","url":"https://api.github.com/users/GoFroggyRun","html_url":"https://github.com/GoFroggyRun","followers_url":"https://api.github.com/users/GoFroggyRun/followers","following_url":"https://api.github.com/users/GoFroggyRun/following{/other_user}","gists_url":"https://api.github.com/users/GoFroggyRun/gists{/gist_id}","starred_url":"https://api.github.com/users/GoFroggyRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoFroggyRun/subscriptions","organizations_url":"https://api.github.com/users/GoFroggyRun/orgs","repos_url":"https://api.github.com/users/GoFroggyRun/repos","events_url":"https://api.github.com/users/GoFroggyRun/events{/privacy}","received_events_url":"https://api.github.com/users/GoFroggyRun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoFroggyRun/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":true,"url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator","forks_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/GoFroggyRun/Tax-Calculator/deployments","created_at":"2015-07-14T02:20:22Z","updated_at":"2016-01-12T19:15:12Z","pushed_at":"2016-03-02T22:18:26Z","git_url":"git://github.com/GoFroggyRun/Tax-Calculator.git","ssh_url":"git@github.com:GoFroggyRun/Tax-Calculator.git","clone_url":"https://github.com/GoFroggyRun/Tax-Calculator.git","svn_url":"https://github.com/GoFroggyRun/Tax-Calculator","homepage":"","size":265361,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"145d7a7d284aed0b0b11c77d59b919f1faa06469","user":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":22389485,"name":"Tax-Calculator","full_name":"open-source-economics/Tax-Calculator","owner":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","forks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/deployments","created_at":"2014-07-29T17:49:09Z","updated_at":"2016-02-29T15:47:31Z","pushed_at":"2016-03-02T22:18:27Z","git_url":"git://github.com/open-source-economics/Tax-Calculator.git","ssh_url":"git@github.com:open-source-economics/Tax-Calculator.git","clone_url":"https://github.com/open-source-economics/Tax-Calculator.git","svn_url":"https://github.com/open-source-economics/Tax-Calculator","homepage":"","size":294170,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":68,"forks":33,"open_issues":68,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628"},"html":{"href":"https://github.com/open-source-economics/Tax-Calculator/pull/628"},"issue":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/628"},"comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/628/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/628/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/a5117fc8733d3ad8c27ac8b9b468a2f61f04dc6b"}}}}