{"action":"created","issue":{"url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/10","repository_url":"https://api.github.com/repos/Infinideastudio/NEWorld","labels_url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/10/comments","events_url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/10/events","html_url":"https://github.com/Infinideastudio/NEWorld/issues/10","id":147230797,"number":10,"title":"论@DREAMWORLDVOID 的代码质量问题","user":{"login":"ascchrvalstr","id":12978630,"avatar_url":"https://avatars.githubusercontent.com/u/12978630?v=3","gravatar_id":"","url":"https://api.github.com/users/ascchrvalstr","html_url":"https://github.com/ascchrvalstr","followers_url":"https://api.github.com/users/ascchrvalstr/followers","following_url":"https://api.github.com/users/ascchrvalstr/following{/other_user}","gists_url":"https://api.github.com/users/ascchrvalstr/gists{/gist_id}","starred_url":"https://api.github.com/users/ascchrvalstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascchrvalstr/subscriptions","organizations_url":"https://api.github.com/users/ascchrvalstr/orgs","repos_url":"https://api.github.com/users/ascchrvalstr/repos","events_url":"https://api.github.com/users/ascchrvalstr/events{/privacy}","received_events_url":"https://api.github.com/users/ascchrvalstr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Infinideastudio/NEWorld/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Infinideastudio/NEWorld/milestones/1","html_url":"https://github.com/Infinideastudio/NEWorld/milestones/Project%20Theseus","labels_url":"https://api.github.com/repos/Infinideastudio/NEWorld/milestones/1/labels","id":1706931,"number":1,"title":"Project Theseus","description":"此工程的主要内容有三大改造：\r\n\r\n1. 移除Git库中不必要的文件。  (在路上)\r\n\r\n2. 大规模改造现有的代码结构。 (天坑)\r\n\r\n3. 在UNIX平台上能够编译。 (已完成)\r\n\r\n大力推行整风运动，坚决反对肮脏的代码。","creator":{"login":"DLaboratory","id":5671495,"avatar_url":"https://avatars.githubusercontent.com/u/5671495?v=3","gravatar_id":"","url":"https://api.github.com/users/DLaboratory","html_url":"https://github.com/DLaboratory","followers_url":"https://api.github.com/users/DLaboratory/followers","following_url":"https://api.github.com/users/DLaboratory/following{/other_user}","gists_url":"https://api.github.com/users/DLaboratory/gists{/gist_id}","starred_url":"https://api.github.com/users/DLaboratory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLaboratory/subscriptions","organizations_url":"https://api.github.com/users/DLaboratory/orgs","repos_url":"https://api.github.com/users/DLaboratory/repos","events_url":"https://api.github.com/users/DLaboratory/events{/privacy}","received_events_url":"https://api.github.com/users/DLaboratory/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":6,"state":"open","created_at":"2016-04-14T14:35:40Z","updated_at":"2016-06-05T01:46:21Z","due_on":"2016-05-31T16:00:00Z","closed_at":null},"comments":41,"created_at":"2016-04-10T14:47:32Z","updated_at":"2016-06-05T11:56:59Z","closed_at":"2016-06-05T01:46:21Z","body":"```C++\r\n// DataKit.cpp : 定义 DLL 应用程序的导出函数。\r\n//\r\n\r\n#include \"stdafx.h\"\r\n#include \"DataKit.h\"\r\n#include <stdio.h>\r\n#include <sstream>\r\n\r\n// 这是导出变量的一个示例\r\nDATAKIT_API int nDataKit=0;\r\n\r\n// 这是导出函数的一个示例。\r\nDATAKIT_API int fnDataKit(void)\r\n{\r\n    return 42;\r\n}\r\n\r\n// 这是已导出类的构造函数。\r\n// 有关类定义的信息，请参阅 DataKit.h\r\nCDataKit::CDataKit()\r\n{\r\n    return;\r\n}\r\n```\r\n问题一：不用UTF-8；\r\n问题二：Microsoft的示例代码你都不删；\r\n问题三：你加入一个DLL都不通知一声；\r\n17行代码，3个错，平均5行多代码1个错，不合格儿。\r\n\r\n```C++\r\n    void object::read(std::fstream & file)\r\n    {\r\n    }\r\n\r\n    void object::write(std::fstream & file)\r\n    {\r\n    }\r\n\r\n    object::~object()\r\n    {\r\n    }\r\n```\r\n代码没写完，一个错儿。\r\n\r\n```C++\r\n    typedef std::map<unsigned long long, object*> _sd;\r\n```\r\n_sd意义不明，并且没有注释，一个错儿。\r\n\r\n```C++\r\n        if (i != ((_st*)val)->end())\r\n        {\r\n            ((_st*)val)->erase(i->first);\r\n        }\r\n\r\n        if (!res||(res->type!=DK_LIST)) {\r\n                addsub(key.substr(0, found), DK_LIST);\r\n                ((cl_list*)((*this)[key.substr(0, found)]))->createdir(key.substr(found + 2));\r\n        }\r\n```\r\n两段相隔8行的代码，一个是Allman/ANSI Bracket Style，一个是Java Bracket Style，一个错儿。\r\n\r\n```C++\r\n\tclass DATAKIT_API cl_file : public cl_list {\r\n\t\tstd::wstring fname;\r\n\tpublic:\r\n\t\tvoid open(std::wstring name);\r\n\t\tvoid save();\r\n\t};\r\n```\r\n不把public成员写前面，一个错儿。"},"comment":{"url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/comments/223809131","html_url":"https://github.com/Infinideastudio/NEWorld/issues/10#issuecomment-223809131","issue_url":"https://api.github.com/repos/Infinideastudio/NEWorld/issues/10","id":223809131,"user":{"login":"qiaozhanrong","id":7543093,"avatar_url":"https://avatars.githubusercontent.com/u/7543093?v=3","gravatar_id":"","url":"https://api.github.com/users/qiaozhanrong","html_url":"https://github.com/qiaozhanrong","followers_url":"https://api.github.com/users/qiaozhanrong/followers","following_url":"https://api.github.com/users/qiaozhanrong/following{/other_user}","gists_url":"https://api.github.com/users/qiaozhanrong/gists{/gist_id}","starred_url":"https://api.github.com/users/qiaozhanrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiaozhanrong/subscriptions","organizations_url":"https://api.github.com/users/qiaozhanrong/orgs","repos_url":"https://api.github.com/users/qiaozhanrong/repos","events_url":"https://api.github.com/users/qiaozhanrong/events{/privacy}","received_events_url":"https://api.github.com/users/qiaozhanrong/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T11:56:59Z","updated_at":"2016-06-05T11:56:59Z","body":"@DREAMWORLDVOID DYT貌似有点不同意宽松版规范，他一直想把规范改得更严格"}}
{"actor":{"display_login":"qiaozhanrong"}}