{"action":"created","issue":{"url":"https://api.github.com/repos/deis/deisrel/issues/147","repository_url":"https://api.github.com/repos/deis/deisrel","labels_url":"https://api.github.com/repos/deis/deisrel/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/deis/deisrel/issues/147/comments","events_url":"https://api.github.com/repos/deis/deisrel/issues/147/events","html_url":"https://github.com/deis/deisrel/pull/147","id":186637598,"number":147,"title":"feat(*): show skipped commits in full changelog format","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"labels":[{"id":366360704,"url":"https://api.github.com/repos/deis/deisrel/labels/awaiting%20review","name":"awaiting review","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"assignees":[{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/deis/deisrel/milestones/17","html_url":"https://github.com/deis/deisrel/milestones/v2.9","labels_url":"https://api.github.com/repos/deis/deisrel/milestones/17/labels","id":2065458,"number":17,"title":"v2.9","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2016-10-12T16:53:20Z","updated_at":"2016-11-01T20:27:26Z","due_on":"2016-11-08T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-11-01T20:27:26Z","updated_at":"2016-11-01T21:31:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/deisrel/pulls/147","html_url":"https://github.com/deis/deisrel/pull/147","diff_url":"https://github.com/deis/deisrel/pull/147.diff","patch_url":"https://github.com/deis/deisrel/pull/147.patch"},"body":"Currently via `--show-skipped-commits` flag.  \r\n\r\nHowever, I might also propose we go further and remove this new option and just show the full skipped changelog message as a default -- I find it only helps to be sure all skipped commits indeed should not be included.  \r\n\r\nFor example, compare the two (original sha-only format first):\r\n\r\n```\r\n$ ./deisrel changelog individual workflow unknown\r\nskipping the following commits:\r\n- 6f1c46686e889d0f09af5878fa924577db5d3351\r\n- 027509f3fb79904dbe9c974357e3c97a711fc077\r\n- 1d70f53f1748981e7aa40e71948cdd76b56b53ca\r\n- 6a620266d3e160a53d9a3278f9e01f818dad9d7e\r\n- 3b5069dfde8ed7cc448a45825401549a14b5ad4a\r\n- f2f270b486ab9b64ca7c71188b22365a9fd55d1a\r\n- bc54566d6b9167191301cf2e8f05fc0ab1ec7324\r\n- 5c52d0430604c3149fd382252a9bd9121dbe32b3\r\n...\r\n```\r\n\r\n```\r\n$ ./deisrel changelog individual workflow unknown --show-skipped-commits\r\nskipping the following commits:\r\n- [`6f1c466`](https://github.com/deis/workflow/commit/6f1c46686e889d0f09af5878fa924577db5d3351) *: Merge pull request #579 from kmala/charts\r\n- [`027509f`](https://github.com/deis/workflow/commit/027509f3fb79904dbe9c974357e3c97a711fc077) *: Merge pull request #578 from mboersma/contrib-projects\r\n- [`1d70f53`](https://github.com/deis/workflow/commit/1d70f53f1748981e7aa40e71948cdd76b56b53ca) *: Merge pull request #581 from mboersma/fix-objectstorage-link\r\n- [`6a62026`](https://github.com/deis/workflow/commit/6a620266d3e160a53d9a3278f9e01f818dad9d7e) *: Merge pull request #582 from vdice/release-v2.8.0-doc-update\r\n- [`3b5069d`](https://github.com/deis/workflow/commit/3b5069dfde8ed7cc448a45825401549a14b5ad4a) *: Merge pull request #588 from kmala/doc\r\n- [`f2f270b`](https://github.com/deis/workflow/commit/f2f270b486ab9b64ca7c71188b22365a9fd55d1a) index: word wrap to 99 characters\r\n- [`bc54566`](https://github.com/deis/workflow/commit/bc54566d6b9167191301cf2e8f05fc0ab1ec7324) *: Merge pull request #592 from bacongobbler/contributing-to-homepage\r\n- [`5c52d04`](https://github.com/deis/workflow/commit/5c52d0430604c3149fd382252a9bd9121dbe32b3) *: Merge pull request #535 from mboersma/automate-component-release\r\n...\r\n```\r\n\r\nWe'd then want to include the one incorrectly skipped commit into the changelog, and it's all set for the copy/paste:\r\n```\r\n- [`f2f270b`](https://github.com/deis/workflow/commit/f2f270b486ab9b64ca7c71188b22365a9fd55d1a) index: word wrap to 99 characters\r\n```\r\n\r\nOtherwise, if consensus endorses the new flag, that's fine too.  I can make a note in the release docs...\r\n\r\nTODO\r\n - [ ] correlating docs PR, if necessary\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/deis/deisrel/issues/comments/257704582","html_url":"https://github.com/deis/deisrel/pull/147#issuecomment-257704582","issue_url":"https://api.github.com/repos/deis/deisrel/issues/147","id":257704582,"user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T21:31:13Z","updated_at":"2016-11-01T21:31:13Z","body":"I agree that the second view is much easier to search for. It displays the repo, the commit sha, and the commit message which gives us a better idea if it's something we can safely ignore."}}
{"actor":{"display_login":"bacongobbler"}}