{"action":"created","comment":{"url":"https://api.github.com/repos/luislavena/radix/pulls/comments/86669282","pull_request_review_id":7318098,"id":86669282,"diff_hunk":"@@ -392,7 +392,7 @@ module Radix\n         key_reader.next_char\n       end\n \n-      (!key_reader.has_next? && !different) &&\n+      (!different) &&","path":"src/radix/tree.cr","position":5,"original_position":5,"commit_id":"3d9ee493f11a25e238d40698eb628cc8d817eff9","original_commit_id":"3d9ee493f11a25e238d40698eb628cc8d817eff9","user":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"body":"Definitely we should add a comment indicating what `_same_key?` does or how it reached to this result?","created_at":"2016-11-05T17:05:26Z","updated_at":"2016-11-05T17:05:39Z","html_url":"https://github.com/luislavena/radix/pull/10#discussion_r86669282","pull_request_url":"https://api.github.com/repos/luislavena/radix/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/luislavena/radix/pulls/comments/86669282"},"html":{"href":"https://github.com/luislavena/radix/pull/10#discussion_r86669282"},"pull_request":{"href":"https://api.github.com/repos/luislavena/radix/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/luislavena/radix/pulls/10","id":92459396,"html_url":"https://github.com/luislavena/radix/pull/10","diff_url":"https://github.com/luislavena/radix/pull/10.diff","patch_url":"https://github.com/luislavena/radix/pull/10.patch","issue_url":"https://api.github.com/repos/luislavena/radix/issues/10","number":10,"state":"open","locked":false,"title":"Allow insert paths with shared keys unordered","user":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"body":"When adding new nodes into the tree, the lookup mechanism failed to detect same named parameter was already added to it, raising an exception.\r\n\r\nExample:\r\n\r\n```crystal\r\ntree = Radix::Tree(Symbol).new\r\ntree.add \"/members/:id/edit\", :member_edit\r\ntree.add \"/members/export\",   :members_export\r\ntree.add \"/members/:id/videos\", :member_videos # Exception\r\n```\r\n\r\nThis fix ensures that comparison is done key by key, even if they are inserted into the tree in a different order.\r\n\r\nCloses #9","created_at":"2016-11-05T16:55:48Z","updated_at":"2016-11-05T17:05:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"591320e5a2a19fdeab0bf4022be84e4193556f3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/luislavena/radix/pulls/10/commits","review_comments_url":"https://api.github.com/repos/luislavena/radix/pulls/10/comments","review_comment_url":"https://api.github.com/repos/luislavena/radix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luislavena/radix/issues/10/comments","statuses_url":"https://api.github.com/repos/luislavena/radix/statuses/3d9ee493f11a25e238d40698eb628cc8d817eff9","head":{"label":"luislavena:fix-shared-key-branching","ref":"fix-shared-key-branching","sha":"3d9ee493f11a25e238d40698eb628cc8d817eff9","user":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"repo":{"id":50311237,"name":"radix","full_name":"luislavena/radix","owner":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luislavena/radix","description":"Radix Tree implementation for Crystal","fork":false,"url":"https://api.github.com/repos/luislavena/radix","forks_url":"https://api.github.com/repos/luislavena/radix/forks","keys_url":"https://api.github.com/repos/luislavena/radix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luislavena/radix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luislavena/radix/teams","hooks_url":"https://api.github.com/repos/luislavena/radix/hooks","issue_events_url":"https://api.github.com/repos/luislavena/radix/issues/events{/number}","events_url":"https://api.github.com/repos/luislavena/radix/events","assignees_url":"https://api.github.com/repos/luislavena/radix/assignees{/user}","branches_url":"https://api.github.com/repos/luislavena/radix/branches{/branch}","tags_url":"https://api.github.com/repos/luislavena/radix/tags","blobs_url":"https://api.github.com/repos/luislavena/radix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luislavena/radix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luislavena/radix/git/refs{/sha}","trees_url":"https://api.github.com/repos/luislavena/radix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luislavena/radix/statuses/{sha}","languages_url":"https://api.github.com/repos/luislavena/radix/languages","stargazers_url":"https://api.github.com/repos/luislavena/radix/stargazers","contributors_url":"https://api.github.com/repos/luislavena/radix/contributors","subscribers_url":"https://api.github.com/repos/luislavena/radix/subscribers","subscription_url":"https://api.github.com/repos/luislavena/radix/subscription","commits_url":"https://api.github.com/repos/luislavena/radix/commits{/sha}","git_commits_url":"https://api.github.com/repos/luislavena/radix/git/commits{/sha}","comments_url":"https://api.github.com/repos/luislavena/radix/comments{/number}","issue_comment_url":"https://api.github.com/repos/luislavena/radix/issues/comments{/number}","contents_url":"https://api.github.com/repos/luislavena/radix/contents/{+path}","compare_url":"https://api.github.com/repos/luislavena/radix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luislavena/radix/merges","archive_url":"https://api.github.com/repos/luislavena/radix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luislavena/radix/downloads","issues_url":"https://api.github.com/repos/luislavena/radix/issues{/number}","pulls_url":"https://api.github.com/repos/luislavena/radix/pulls{/number}","milestones_url":"https://api.github.com/repos/luislavena/radix/milestones{/number}","notifications_url":"https://api.github.com/repos/luislavena/radix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luislavena/radix/labels{/name}","releases_url":"https://api.github.com/repos/luislavena/radix/releases{/id}","deployments_url":"https://api.github.com/repos/luislavena/radix/deployments","created_at":"2016-01-24T22:22:32Z","updated_at":"2016-08-29T05:06:20Z","pushed_at":"2016-11-05T16:55:48Z","git_url":"git://github.com/luislavena/radix.git","ssh_url":"git@github.com:luislavena/radix.git","clone_url":"https://github.com/luislavena/radix.git","svn_url":"https://github.com/luislavena/radix","homepage":null,"size":44,"stargazers_count":14,"watchers_count":14,"language":"Crystal","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"base":{"label":"luislavena:master","ref":"master","sha":"e55d1444138c2ed7831512d10fd3d79682999e55","user":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"repo":{"id":50311237,"name":"radix","full_name":"luislavena/radix","owner":{"login":"luislavena","id":4182,"avatar_url":"https://avatars.githubusercontent.com/u/4182?v=3","gravatar_id":"","url":"https://api.github.com/users/luislavena","html_url":"https://github.com/luislavena","followers_url":"https://api.github.com/users/luislavena/followers","following_url":"https://api.github.com/users/luislavena/following{/other_user}","gists_url":"https://api.github.com/users/luislavena/gists{/gist_id}","starred_url":"https://api.github.com/users/luislavena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luislavena/subscriptions","organizations_url":"https://api.github.com/users/luislavena/orgs","repos_url":"https://api.github.com/users/luislavena/repos","events_url":"https://api.github.com/users/luislavena/events{/privacy}","received_events_url":"https://api.github.com/users/luislavena/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luislavena/radix","description":"Radix Tree implementation for Crystal","fork":false,"url":"https://api.github.com/repos/luislavena/radix","forks_url":"https://api.github.com/repos/luislavena/radix/forks","keys_url":"https://api.github.com/repos/luislavena/radix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luislavena/radix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luislavena/radix/teams","hooks_url":"https://api.github.com/repos/luislavena/radix/hooks","issue_events_url":"https://api.github.com/repos/luislavena/radix/issues/events{/number}","events_url":"https://api.github.com/repos/luislavena/radix/events","assignees_url":"https://api.github.com/repos/luislavena/radix/assignees{/user}","branches_url":"https://api.github.com/repos/luislavena/radix/branches{/branch}","tags_url":"https://api.github.com/repos/luislavena/radix/tags","blobs_url":"https://api.github.com/repos/luislavena/radix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luislavena/radix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luislavena/radix/git/refs{/sha}","trees_url":"https://api.github.com/repos/luislavena/radix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luislavena/radix/statuses/{sha}","languages_url":"https://api.github.com/repos/luislavena/radix/languages","stargazers_url":"https://api.github.com/repos/luislavena/radix/stargazers","contributors_url":"https://api.github.com/repos/luislavena/radix/contributors","subscribers_url":"https://api.github.com/repos/luislavena/radix/subscribers","subscription_url":"https://api.github.com/repos/luislavena/radix/subscription","commits_url":"https://api.github.com/repos/luislavena/radix/commits{/sha}","git_commits_url":"https://api.github.com/repos/luislavena/radix/git/commits{/sha}","comments_url":"https://api.github.com/repos/luislavena/radix/comments{/number}","issue_comment_url":"https://api.github.com/repos/luislavena/radix/issues/comments{/number}","contents_url":"https://api.github.com/repos/luislavena/radix/contents/{+path}","compare_url":"https://api.github.com/repos/luislavena/radix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luislavena/radix/merges","archive_url":"https://api.github.com/repos/luislavena/radix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luislavena/radix/downloads","issues_url":"https://api.github.com/repos/luislavena/radix/issues{/number}","pulls_url":"https://api.github.com/repos/luislavena/radix/pulls{/number}","milestones_url":"https://api.github.com/repos/luislavena/radix/milestones{/number}","notifications_url":"https://api.github.com/repos/luislavena/radix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luislavena/radix/labels{/name}","releases_url":"https://api.github.com/repos/luislavena/radix/releases{/id}","deployments_url":"https://api.github.com/repos/luislavena/radix/deployments","created_at":"2016-01-24T22:22:32Z","updated_at":"2016-08-29T05:06:20Z","pushed_at":"2016-11-05T16:55:48Z","git_url":"git://github.com/luislavena/radix.git","ssh_url":"git@github.com:luislavena/radix.git","clone_url":"https://github.com/luislavena/radix.git","svn_url":"https://github.com/luislavena/radix","homepage":null,"size":44,"stargazers_count":14,"watchers_count":14,"language":"Crystal","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luislavena/radix/pulls/10"},"html":{"href":"https://github.com/luislavena/radix/pull/10"},"issue":{"href":"https://api.github.com/repos/luislavena/radix/issues/10"},"comments":{"href":"https://api.github.com/repos/luislavena/radix/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/luislavena/radix/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/luislavena/radix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luislavena/radix/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/luislavena/radix/statuses/3d9ee493f11a25e238d40698eb628cc8d817eff9"}}}}
{"actor":{"display_login":"luislavena"}}