{"action":"opened","number":61,"pull_request":{"url":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61","id":79208161,"html_url":"https://github.com/2createStudio/postcss-sprites/pull/61","diff_url":"https://github.com/2createStudio/postcss-sprites/pull/61.diff","patch_url":"https://github.com/2createStudio/postcss-sprites/pull/61.patch","issue_url":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/61","number":61,"state":"open","locked":false,"title":"SVG sprites support","user":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"body":"I’ve started with SVG support so that this plugin can handle backgroud-position based SVG images instead of only rasters.\r\n\r\nThis is a very crude implementation, but I’m submitting a PR to see if you’re willing to merge changes and implement additional feature to this plugin. SVG icons and images are used more and more and it would be great to have seamless support with this plugin rather with some additional plugin.\r\n\r\n* I’m using svg-sprite module to generate everything SVG related\r\n* It uses custom template to generate JSON string in the format Spritesmith uses so that there shouldn’t be too much changes regarding tests and core functionality\r\n* `makeSpritesheetPath` function now takes third argument which is output extension determined based on grouped images extension (similar to `areRetinaImages` tester)\r\n* I’ve used ES5 syntax for spriter factory but will change it to ES2015 when the final details are defined\r\n* Basic tests are written and it passes basic functionality\r\n* I’ve encountered the problem on line https://github.com/2createStudio/postcss-sprites/compare/master...niksy:svg-sprite-support?expand=1#diff-c4452a5b3534ba594edf670191abc3f7R14 where getting external file (JSON template) is inproperly resolved since it’s not copied from `src` to `lib`, do you have an idea how to solve this?","created_at":"2016-07-28T14:41:29Z","updated_at":"2016-07-28T14:41:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61/commits","review_comments_url":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61/comments","review_comment_url":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/comments{/number}","comments_url":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/61/comments","statuses_url":"https://api.github.com/repos/2createStudio/postcss-sprites/statuses/01fd46c02c209e938ce90f2053b2e4e41c24892f","head":{"label":"niksy:svg-sprite-support","ref":"svg-sprite-support","sha":"01fd46c02c209e938ce90f2053b2e4e41c24892f","user":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"repo":{"id":63960910,"name":"postcss-sprites","full_name":"niksy/postcss-sprites","owner":{"login":"niksy","id":389286,"avatar_url":"https://avatars.githubusercontent.com/u/389286?v=3","gravatar_id":"","url":"https://api.github.com/users/niksy","html_url":"https://github.com/niksy","followers_url":"https://api.github.com/users/niksy/followers","following_url":"https://api.github.com/users/niksy/following{/other_user}","gists_url":"https://api.github.com/users/niksy/gists{/gist_id}","starred_url":"https://api.github.com/users/niksy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niksy/subscriptions","organizations_url":"https://api.github.com/users/niksy/orgs","repos_url":"https://api.github.com/users/niksy/repos","events_url":"https://api.github.com/users/niksy/events{/privacy}","received_events_url":"https://api.github.com/users/niksy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niksy/postcss-sprites","description":"Generate sprites from stylesheets.","fork":true,"url":"https://api.github.com/repos/niksy/postcss-sprites","forks_url":"https://api.github.com/repos/niksy/postcss-sprites/forks","keys_url":"https://api.github.com/repos/niksy/postcss-sprites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niksy/postcss-sprites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niksy/postcss-sprites/teams","hooks_url":"https://api.github.com/repos/niksy/postcss-sprites/hooks","issue_events_url":"https://api.github.com/repos/niksy/postcss-sprites/issues/events{/number}","events_url":"https://api.github.com/repos/niksy/postcss-sprites/events","assignees_url":"https://api.github.com/repos/niksy/postcss-sprites/assignees{/user}","branches_url":"https://api.github.com/repos/niksy/postcss-sprites/branches{/branch}","tags_url":"https://api.github.com/repos/niksy/postcss-sprites/tags","blobs_url":"https://api.github.com/repos/niksy/postcss-sprites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niksy/postcss-sprites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niksy/postcss-sprites/git/refs{/sha}","trees_url":"https://api.github.com/repos/niksy/postcss-sprites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niksy/postcss-sprites/statuses/{sha}","languages_url":"https://api.github.com/repos/niksy/postcss-sprites/languages","stargazers_url":"https://api.github.com/repos/niksy/postcss-sprites/stargazers","contributors_url":"https://api.github.com/repos/niksy/postcss-sprites/contributors","subscribers_url":"https://api.github.com/repos/niksy/postcss-sprites/subscribers","subscription_url":"https://api.github.com/repos/niksy/postcss-sprites/subscription","commits_url":"https://api.github.com/repos/niksy/postcss-sprites/commits{/sha}","git_commits_url":"https://api.github.com/repos/niksy/postcss-sprites/git/commits{/sha}","comments_url":"https://api.github.com/repos/niksy/postcss-sprites/comments{/number}","issue_comment_url":"https://api.github.com/repos/niksy/postcss-sprites/issues/comments{/number}","contents_url":"https://api.github.com/repos/niksy/postcss-sprites/contents/{+path}","compare_url":"https://api.github.com/repos/niksy/postcss-sprites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niksy/postcss-sprites/merges","archive_url":"https://api.github.com/repos/niksy/postcss-sprites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niksy/postcss-sprites/downloads","issues_url":"https://api.github.com/repos/niksy/postcss-sprites/issues{/number}","pulls_url":"https://api.github.com/repos/niksy/postcss-sprites/pulls{/number}","milestones_url":"https://api.github.com/repos/niksy/postcss-sprites/milestones{/number}","notifications_url":"https://api.github.com/repos/niksy/postcss-sprites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niksy/postcss-sprites/labels{/name}","releases_url":"https://api.github.com/repos/niksy/postcss-sprites/releases{/id}","deployments_url":"https://api.github.com/repos/niksy/postcss-sprites/deployments","created_at":"2016-07-22T14:47:25Z","updated_at":"2016-07-22T14:47:26Z","pushed_at":"2016-07-28T14:34:16Z","git_url":"git://github.com/niksy/postcss-sprites.git","ssh_url":"git@github.com:niksy/postcss-sprites.git","clone_url":"https://github.com/niksy/postcss-sprites.git","svn_url":"https://github.com/niksy/postcss-sprites","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"2createStudio:master","ref":"master","sha":"c668ce92f8137290a58e12f5ed3b3ad22324d9d4","user":{"login":"2createStudio","id":6463957,"avatar_url":"https://avatars.githubusercontent.com/u/6463957?v=3","gravatar_id":"","url":"https://api.github.com/users/2createStudio","html_url":"https://github.com/2createStudio","followers_url":"https://api.github.com/users/2createStudio/followers","following_url":"https://api.github.com/users/2createStudio/following{/other_user}","gists_url":"https://api.github.com/users/2createStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/2createStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2createStudio/subscriptions","organizations_url":"https://api.github.com/users/2createStudio/orgs","repos_url":"https://api.github.com/users/2createStudio/repos","events_url":"https://api.github.com/users/2createStudio/events{/privacy}","received_events_url":"https://api.github.com/users/2createStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":36354941,"name":"postcss-sprites","full_name":"2createStudio/postcss-sprites","owner":{"login":"2createStudio","id":6463957,"avatar_url":"https://avatars.githubusercontent.com/u/6463957?v=3","gravatar_id":"","url":"https://api.github.com/users/2createStudio","html_url":"https://github.com/2createStudio","followers_url":"https://api.github.com/users/2createStudio/followers","following_url":"https://api.github.com/users/2createStudio/following{/other_user}","gists_url":"https://api.github.com/users/2createStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/2createStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2createStudio/subscriptions","organizations_url":"https://api.github.com/users/2createStudio/orgs","repos_url":"https://api.github.com/users/2createStudio/repos","events_url":"https://api.github.com/users/2createStudio/events{/privacy}","received_events_url":"https://api.github.com/users/2createStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2createStudio/postcss-sprites","description":"Generate sprites from stylesheets.","fork":false,"url":"https://api.github.com/repos/2createStudio/postcss-sprites","forks_url":"https://api.github.com/repos/2createStudio/postcss-sprites/forks","keys_url":"https://api.github.com/repos/2createStudio/postcss-sprites/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2createStudio/postcss-sprites/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2createStudio/postcss-sprites/teams","hooks_url":"https://api.github.com/repos/2createStudio/postcss-sprites/hooks","issue_events_url":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/events{/number}","events_url":"https://api.github.com/repos/2createStudio/postcss-sprites/events","assignees_url":"https://api.github.com/repos/2createStudio/postcss-sprites/assignees{/user}","branches_url":"https://api.github.com/repos/2createStudio/postcss-sprites/branches{/branch}","tags_url":"https://api.github.com/repos/2createStudio/postcss-sprites/tags","blobs_url":"https://api.github.com/repos/2createStudio/postcss-sprites/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2createStudio/postcss-sprites/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2createStudio/postcss-sprites/git/refs{/sha}","trees_url":"https://api.github.com/repos/2createStudio/postcss-sprites/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2createStudio/postcss-sprites/statuses/{sha}","languages_url":"https://api.github.com/repos/2createStudio/postcss-sprites/languages","stargazers_url":"https://api.github.com/repos/2createStudio/postcss-sprites/stargazers","contributors_url":"https://api.github.com/repos/2createStudio/postcss-sprites/contributors","subscribers_url":"https://api.github.com/repos/2createStudio/postcss-sprites/subscribers","subscription_url":"https://api.github.com/repos/2createStudio/postcss-sprites/subscription","commits_url":"https://api.github.com/repos/2createStudio/postcss-sprites/commits{/sha}","git_commits_url":"https://api.github.com/repos/2createStudio/postcss-sprites/git/commits{/sha}","comments_url":"https://api.github.com/repos/2createStudio/postcss-sprites/comments{/number}","issue_comment_url":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/comments{/number}","contents_url":"https://api.github.com/repos/2createStudio/postcss-sprites/contents/{+path}","compare_url":"https://api.github.com/repos/2createStudio/postcss-sprites/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2createStudio/postcss-sprites/merges","archive_url":"https://api.github.com/repos/2createStudio/postcss-sprites/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2createStudio/postcss-sprites/downloads","issues_url":"https://api.github.com/repos/2createStudio/postcss-sprites/issues{/number}","pulls_url":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls{/number}","milestones_url":"https://api.github.com/repos/2createStudio/postcss-sprites/milestones{/number}","notifications_url":"https://api.github.com/repos/2createStudio/postcss-sprites/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2createStudio/postcss-sprites/labels{/name}","releases_url":"https://api.github.com/repos/2createStudio/postcss-sprites/releases{/id}","deployments_url":"https://api.github.com/repos/2createStudio/postcss-sprites/deployments","created_at":"2015-05-27T08:50:43Z","updated_at":"2016-07-28T09:39:30Z","pushed_at":"2016-07-28T14:41:29Z","git_url":"git://github.com/2createStudio/postcss-sprites.git","ssh_url":"git@github.com:2createStudio/postcss-sprites.git","clone_url":"https://github.com/2createStudio/postcss-sprites.git","svn_url":"https://github.com/2createStudio/postcss-sprites","homepage":null,"size":121,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":2,"forks":19,"open_issues":2,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61"},"html":{"href":"https://github.com/2createStudio/postcss-sprites/pull/61"},"issue":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/61"},"comments":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/2createStudio/postcss-sprites/statuses/01fd46c02c209e938ce90f2053b2e4e41c24892f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1073,"deletions":11,"changed_files":11}}
{"actor":{"display_login":"niksy"}}