{"action":"created","issue":{"url":"https://api.github.com/repos/SFTtech/openage/issues/683","repository_url":"https://api.github.com/repos/SFTtech/openage","labels_url":"https://api.github.com/repos/SFTtech/openage/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/SFTtech/openage/issues/683/comments","events_url":"https://api.github.com/repos/SFTtech/openage/issues/683/events","html_url":"https://github.com/SFTtech/openage/pull/683","id":198016985,"number":683,"title":"[WIP] Attributes system improvements","user":{"login":"MaanooAk","id":6997990,"avatar_url":"https://avatars.githubusercontent.com/u/6997990?v=3","gravatar_id":"","url":"https://api.github.com/users/MaanooAk","html_url":"https://github.com/MaanooAk","followers_url":"https://api.github.com/users/MaanooAk/followers","following_url":"https://api.github.com/users/MaanooAk/following{/other_user}","gists_url":"https://api.github.com/users/MaanooAk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaanooAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaanooAk/subscriptions","organizations_url":"https://api.github.com/users/MaanooAk/orgs","repos_url":"https://api.github.com/users/MaanooAk/repos","events_url":"https://api.github.com/users/MaanooAk/events{/privacy}","received_events_url":"https://api.github.com/users/MaanooAk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-29T14:38:28Z","updated_at":"2016-12-29T19:30:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SFTtech/openage/pulls/683","html_url":"https://github.com/SFTtech/openage/pull/683","diff_url":"https://github.com/SFTtech/openage/pull/683.diff","patch_url":"https://github.com/SFTtech/openage/pull/683.patch"},"body":"### Attributes system improvements goals:\r\n\r\n- [ ] Abstract shared and ushared attributes\r\n  - [x] share method\r\n  - [ ] copy method (change(= implement) or remove ?)\r\n- [ ] Convert `attr_map_t` into a proper class (`Attributes`?)\r\n  - [ ] implement\r\n    - [ ] add `attributes.cpp` (?)\r\n  - [ ] refactor\r\n- [ ] Split attributes and refactor changes\r\n  - [ ] hitpoints -> hitpoints + current hitpoints (issue #651)\r\n  - [ ] building -> construction + building\r\n- [ ] Change the worker atrribute\r\n  - [ ] rename\r\n  - [ ] move attack type here from attack (?)\r\n- [ ] Add doc\r\n- [ ] Unit type\r\n  - [ ] ?\r\n\r\n### Notes\r\n\r\n- All files including `attributes.h`: `unit_type.h`, `unit.h`, `action.h`\r\n- `Attributes` methods:\r\n  - bool add/has/removeAttribute (hide all map methods)\r\n  - Attribute get<attr_type>"},"comment":{"url":"https://api.github.com/repos/SFTtech/openage/issues/comments/269680754","html_url":"https://github.com/SFTtech/openage/pull/683#issuecomment-269680754","issue_url":"https://api.github.com/repos/SFTtech/openage/issues/683","id":269680754,"user":{"login":"MaanooAk","id":6997990,"avatar_url":"https://avatars.githubusercontent.com/u/6997990?v=3","gravatar_id":"","url":"https://api.github.com/users/MaanooAk","html_url":"https://github.com/MaanooAk","followers_url":"https://api.github.com/users/MaanooAk/followers","following_url":"https://api.github.com/users/MaanooAk/following{/other_user}","gists_url":"https://api.github.com/users/MaanooAk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaanooAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaanooAk/subscriptions","organizations_url":"https://api.github.com/users/MaanooAk/orgs","repos_url":"https://api.github.com/users/MaanooAk/repos","events_url":"https://api.github.com/users/MaanooAk/events{/privacy}","received_events_url":"https://api.github.com/users/MaanooAk/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T19:30:56Z","updated_at":"2016-12-29T19:30:56Z","body":"After a lot of time, I cant find a way to improve the the copypaste `copy()` methods."}}
{"actor":{"display_login":"MaanooAk"}}