{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/814","repository_url":"https://api.github.com/repos/shazow/urllib3","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/814/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/814/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/814/events","html_url":"https://github.com/shazow/urllib3/issues/814","id":141001746,"number":814,"title":"parse_url fails when given credentials in the URL with '/', '#', or '?'","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-15T15:10:48Z","updated_at":"2016-03-16T18:11:58Z","closed_at":"2016-03-16T12:08:16Z","body":"Technically, this behavior is compliant with RFC-3986 in that the \"authority\" section should end at the next instance of one of those characters. However, RFC-2617, which specifies the HTTP Basic Auth scheme, does not specifically exclude those characters as valid, which means that there are valid RFC-2617 usernames and passwords which cannot currently be transmitted inside the URL for handling.\r\n\r\nThis behavior has received an issue filing on pip in the context of an HTTP proxy.\r\n\r\nThe attached pull request changes behavior such that any authorization information (separated from the rest of the URL by the reserved character '@') is pulled from the URL prior to scanning for the end of the authority section (separated from the rest of the URL by the aforementioned reserved characters). The PR also includes regression tests to ensure that this behavior change stays in place.\r\n\r\nSources:\r\nhttps://github.com/pypa/pip/issues/3267\r\nhttp://tools.ietf.org/html/rfc3986#section-3.2\r\nhttps://tools.ietf.org/html/rfc2617#section-2"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/197463694","html_url":"https://github.com/shazow/urllib3/issues/814#issuecomment-197463694","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/814","id":197463694,"user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T18:11:58Z","updated_at":"2016-03-16T18:11:58Z","body":"@haikuginger Thanks for giving it a shot! :)"}}