{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/52059202","id":52059202,"diff_hunk":"@@ -316,71 +70,6 @@ QUnit.test('properties within an if statement should not fail on re-render', fun\n   equal(view.$().text(), '');\n });\n \n-QUnit.test('should update the block when object passed to #if helper changes', function() {\n-  owner.register('template:menu', compile('<h1>{{#if view.inception}}{{view.INCEPTION}}{{/if}}</h1>'));\n-\n-  view = EmberView.create({\n-    [OWNER]: owner,\n-    templateName: 'menu',\n-    INCEPTION: 'BOOOOOOOONG doodoodoodoodooodoodoodoo',\n-    inception: 'OOOOoooooOOOOOOooooooo'\n-  });\n-\n-  runAppend(view);\n-\n-  equal(view.$('h1').text(), 'BOOOOOOOONG doodoodoodoodooodoodoodoo', 'renders block if a string');\n-\n-  var tests = [false, null, undefined, [], '', 0];\n-\n-  tests.forEach(function(val) {\n-    run(function() {\n-      set(view, 'inception', val);\n-    });\n-\n-    equal(view.$('h1').text(), '', `hides block when conditional is \"${val}\"`);\n-\n-    run(function() {\n-      set(view, 'inception', true);\n-    });\n-\n-    equal(view.$('h1').text(), 'BOOOOOOOONG doodoodoodoodooodoodoodoo', 'precond - renders block when conditional is true');\n-  });\n-});\n-\n-QUnit.test('should update the block when object passed to #if helper changes and an inverse is supplied', function() {","path":"packages/ember-htmlbars/tests/helpers/if_unless_test.js","position":299,"original_position":299,"commit_id":"0a74d30ad4b450d2aa4fc7a2921ef344e34b2393","original_commit_id":"0a74d30ad4b450d2aa4fc7a2921ef344e34b2393","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"Removed without replacement (?). Seems like this is about the content of the bock get updated? I can add it back if it is important. (This compared to the above is to test with or without inverse. Do we need both in the new tests?)","created_at":"2016-02-05T19:11:22Z","updated_at":"2016-02-05T19:11:22Z","html_url":"https://github.com/emberjs/ember.js/pull/12914#discussion_r52059202","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12914","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/52059202"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12914#discussion_r52059202"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12914"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12914","id":58387323,"html_url":"https://github.com/emberjs/ember.js/pull/12914","diff_url":"https://github.com/emberjs/ember.js/pull/12914.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12914.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12914","number":12914,"state":"open","locked":false,"title":"Implement Ember semantics for {{#if}}/{{#unless}}","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"Also ported most of the basic test cases to the new format. I expect the super classes here can be extracted into a different file and we should be able to reuse all the test cases for the inline (if …) and (unless …) helpers as well, because of the test cases go through the `templateFor` abstraction.\r\n\r\nI have not figured out a good way to abstract the “without inverse” tests, so they are duplicated in the leaf subclasses.\r\n\r\nThe rest of the tests in the `if_unless_test` requires some more careful reading/git-history-digging to see if they are still relevant, which I do not have time for at the moment (maybe someone else can pick up where I left off).\r\n\r\nIn any case, implementing the Ember semantics should be enough to unblock porting other tests that depends on them. I did not implement the inline `(if …)` and `(unless …)` helpers or port their tests, but that should be pretty easy given the `{{concat}}` example and the `toBool` function in here.\r\n\r\nNote: please don’t add the inline `(if …)` and `(unless …)` tests here. Instead, please add them to `integration/helpers/if-unless-test.js` (and extract the shared test cases to a different file too).\r\n\r\ncc @wycats @rwjblue @mmun @Serabe","created_at":"2016-02-05T04:29:31Z","updated_at":"2016-02-05T19:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f785a0b45f4a8a295279e1e8ef46a60ba48c7e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12914/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/12914/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12914/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/0a74d30ad4b450d2aa4fc7a2921ef344e34b2393","head":{"label":"tildeio:if-unless-tests","ref":"if-unless-tests","sha":"0a74d30ad4b450d2aa4fc7a2921ef344e34b2393","user":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"repo":{"id":41574884,"name":"ember.js","full_name":"tildeio/ember.js","owner":{"login":"tildeio","id":1355851,"avatar_url":"https://avatars.githubusercontent.com/u/1355851?v=3","gravatar_id":"","url":"https://api.github.com/users/tildeio","html_url":"https://github.com/tildeio","followers_url":"https://api.github.com/users/tildeio/followers","following_url":"https://api.github.com/users/tildeio/following{/other_user}","gists_url":"https://api.github.com/users/tildeio/gists{/gist_id}","starred_url":"https://api.github.com/users/tildeio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tildeio/subscriptions","organizations_url":"https://api.github.com/users/tildeio/orgs","repos_url":"https://api.github.com/users/tildeio/repos","events_url":"https://api.github.com/users/tildeio/events{/privacy}","received_events_url":"https://api.github.com/users/tildeio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tildeio/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/tildeio/ember.js","forks_url":"https://api.github.com/repos/tildeio/ember.js/forks","keys_url":"https://api.github.com/repos/tildeio/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tildeio/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tildeio/ember.js/teams","hooks_url":"https://api.github.com/repos/tildeio/ember.js/hooks","issue_events_url":"https://api.github.com/repos/tildeio/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/tildeio/ember.js/events","assignees_url":"https://api.github.com/repos/tildeio/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/tildeio/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/tildeio/ember.js/tags","blobs_url":"https://api.github.com/repos/tildeio/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tildeio/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tildeio/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tildeio/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tildeio/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/tildeio/ember.js/languages","stargazers_url":"https://api.github.com/repos/tildeio/ember.js/stargazers","contributors_url":"https://api.github.com/repos/tildeio/ember.js/contributors","subscribers_url":"https://api.github.com/repos/tildeio/ember.js/subscribers","subscription_url":"https://api.github.com/repos/tildeio/ember.js/subscription","commits_url":"https://api.github.com/repos/tildeio/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tildeio/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tildeio/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tildeio/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tildeio/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/tildeio/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tildeio/ember.js/merges","archive_url":"https://api.github.com/repos/tildeio/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tildeio/ember.js/downloads","issues_url":"https://api.github.com/repos/tildeio/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/tildeio/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/tildeio/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/tildeio/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tildeio/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/tildeio/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/tildeio/ember.js/deployments","created_at":"2015-08-29T00:27:16Z","updated_at":"2016-01-15T05:11:15Z","pushed_at":"2016-02-05T18:45:28Z","git_url":"git://github.com/tildeio/ember.js.git","ssh_url":"git@github.com:tildeio/ember.js.git","clone_url":"https://github.com/tildeio/ember.js.git","svn_url":"https://github.com/tildeio/ember.js","homepage":"http://www.emberjs.com","size":30951,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"d5b6c8a8cca2bf31ce6f0cb072413fff106d4b83","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-02-05T15:24:44Z","pushed_at":"2016-02-05T18:45:33Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":66322,"stargazers_count":15634,"watchers_count":15634,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3372,"mirror_url":null,"open_issues_count":400,"forks":3372,"open_issues":400,"watchers":15634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12914"},"html":{"href":"https://github.com/emberjs/ember.js/pull/12914"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12914"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/12914/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12914/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/12914/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/0a74d30ad4b450d2aa4fc7a2921ef344e34b2393"}}}}