{"action":"created","issue":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/192","repository_url":"https://api.github.com/repos/isetbio/isetbio","labels_url":"https://api.github.com/repos/isetbio/isetbio/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/isetbio/isetbio/issues/192/comments","events_url":"https://api.github.com/repos/isetbio/isetbio/issues/192/events","html_url":"https://github.com/isetbio/isetbio/issues/192","id":193331223,"number":192,"title":"coneMosaic.compute","user":{"login":"wandell","id":1837145,"avatar_url":"https://avatars.githubusercontent.com/u/1837145?v=3","gravatar_id":"","url":"https://api.github.com/users/wandell","html_url":"https://github.com/wandell","followers_url":"https://api.github.com/users/wandell/followers","following_url":"https://api.github.com/users/wandell/following{/other_user}","gists_url":"https://api.github.com/users/wandell/gists{/gist_id}","starred_url":"https://api.github.com/users/wandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandell/subscriptions","organizations_url":"https://api.github.com/users/wandell/orgs","repos_url":"https://api.github.com/users/wandell/repos","events_url":"https://api.github.com/users/wandell/events{/privacy}","received_events_url":"https://api.github.com/users/wandell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-04T04:35:35Z","updated_at":"2016-12-04T06:21:19Z","closed_at":"2016-12-04T06:21:19Z","body":"I am in the process of fixing up the noiseFlag for random/frozen/none.  \r\n\r\nIn that process, I noticed that we manage the emPath in coneMosaic.compute a little oddly.  When absorptions is empty we simply place 'emPath' to the current emPositions.  But if there are absorptions, we add emPath to the existing positions. \r\n\r\nI would prefer getting rid of this 'emPath' parameter altogether and just having people set the coneMosaic.emPositions before we get here.  But if we can't do that, then I would prefer doing the same thing with emPath (i.e., setting emPositions to emPath) no matter the current state.\r\n\r\nHere is the current code that I would like to replace.  I think the behavior is too subtle for a blunt guy like me.\r\n\r\n   ```\r\n%% set or add to eye movement path\r\n   if isempty(p.Results.emPath)\r\n     emPath = obj.emPositions;\r\n    else\r\n     emPath = p.Results.emPath;\r\n     if isempty(obj.absorptions), obj.emPositions = emPath;\r\n     else\r\n        obj.emPositions = [obj.emPositions; emPath];\r\n     end\r\n    end\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/comments/264687005","html_url":"https://github.com/isetbio/isetbio/issues/192#issuecomment-264687005","issue_url":"https://api.github.com/repos/isetbio/isetbio/issues/192","id":264687005,"user":{"login":"wandell","id":1837145,"avatar_url":"https://avatars.githubusercontent.com/u/1837145?v=3","gravatar_id":"","url":"https://api.github.com/users/wandell","html_url":"https://github.com/wandell","followers_url":"https://api.github.com/users/wandell/followers","following_url":"https://api.github.com/users/wandell/following{/other_user}","gists_url":"https://api.github.com/users/wandell/gists{/gist_id}","starred_url":"https://api.github.com/users/wandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wandell/subscriptions","organizations_url":"https://api.github.com/users/wandell/orgs","repos_url":"https://api.github.com/users/wandell/repos","events_url":"https://api.github.com/users/wandell/events{/privacy}","received_events_url":"https://api.github.com/users/wandell/received_events","type":"User","site_admin":false},"created_at":"2016-12-04T06:21:19Z","updated_at":"2016-12-04T06:21:19Z","body":"You're up too late.\r\nOK, done.  And we will keep the emPath flag because it is necessary, as you point out.\r\nI have implemented this already on the bipolar branch, so let's close this."}}
{"actor":{"display_login":"wandell"}}