{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/1970","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/1970/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1970/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/1970/events","html_url":"https://github.com/apache/kafka/pull/1970","id":181113377,"number":1970,"title":"KAFKA-4253: Fix Kafka Stream thread shutting down process ordering","user":{"login":"dguy","id":54829,"avatar_url":"https://avatars.githubusercontent.com/u/54829?v=3","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-05T10:08:23Z","updated_at":"2016-10-06T16:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1970","html_url":"https://github.com/apache/kafka/pull/1970","diff_url":"https://github.com/apache/kafka/pull/1970.diff","patch_url":"https://github.com/apache/kafka/pull/1970.patch"},"body":"Changed the ordering in `StreamThread.shutdown`\r\n1. commitAll (we need to commit so that any cached data is flushed through the topology)\r\n2. close all tasks\r\n3. producer.flush() - so any records produced during close are flushed and we have offsets for them\r\n4. close all state managers\r\n5. close producers/consumers\r\n6. remove the tasks\r\n\r\nAlso in `onPartitionsRevoked`\r\n1. commitAll\r\n2. close all tasks\r\n3. producer.flush\r\n4. close all state managers\r\n"},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/252020052","html_url":"https://github.com/apache/kafka/pull/1970#issuecomment-252020052","issue_url":"https://api.github.com/repos/apache/kafka/issues/1970","id":252020052,"user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T16:42:54Z","updated_at":"2016-10-06T16:42:54Z","body":"Yes I ran it locally and cannot see it either. Let's create a JIRA for it."}}
{"actor":{"display_login":"guozhangwang"}}