{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/17037","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17037/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17037/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17037/events","html_url":"https://github.com/cms-sw/cmssw/pull/17037","id":195543640,"number":17037,"title":"HBHE: use proper quantization noise in the M2","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64","html_url":"https://github.com/cms-sw/cmssw/milestone/64","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64/labels","id":2138657,"number":64,"title":"Next CMSSW_9_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":82,"closed_issues":231,"state":"open","created_at":"2016-11-16T08:55:18Z","updated_at":"2016-12-14T15:07:04Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-12-14T14:24:03Z","updated_at":"2016-12-14T15:08:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17037","html_url":"https://github.com/cms-sw/cmssw/pull/17037","diff_url":"https://github.com/cms-sw/cmssw/pull/17037.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/17037.patch"},"body":"Hi.\r\nAdded proper quantization noise introduced in #16951\u0000\r\nValidation test in\r\nhttp://dalfonso.web.cern.ch/dalfonso/dalfonso_M2adcFIX.pdf\r\n\r\nFix both the HB and HE.\r\nFix only the 2017 scenario, run2 is left unchanged"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/267057880","html_url":"https://github.com/cms-sw/cmssw/pull/17037#issuecomment-267057880","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17037","id":267057880,"user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T15:08:15Z","updated_at":"2016-12-14T15:08:15Z","body":"@slava77\r\n\r\nTo have in the 2016 scenario as well I have to clone the function here\r\nhttps://github.com/cms-sw/cmssw/pull/16951/files#diff-5bffd97385f18e7da1326160e40795c1R139\r\ninside the RecoLocalCalo/HcalRecAlgos/src/PulseShapeFitOOTPileupCorrection.cc\r\n\r\nI do think is better to have the fix for whole new 2017 detector (HB,HE) as we should aim to have the best hcal reco.\r\nWhat is the pre-2017 use ?\r\n1) comparison of the relVal ?\r\n2) The \"phase1\" code can also be used for the run2 legacy re-reco and in case we have the full detector with the HPD thanks to the switch channelData.hasTimeInfo()\r\n@igv4321 \r\n\r\n\r\n"}}
{"actor":{"display_login":"mariadalfonso"}}