{"action":"created","issue":{"url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/4","repository_url":"https://api.github.com/repos/HackerResidency/bitcoin","labels_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/4/comments","events_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/4/events","html_url":"https://github.com/HackerResidency/bitcoin/pull/4","id":178497180,"number":4,"title":"refactor TxToJSON() and ScriptPubKeyToJSON()","user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-22T00:58:31Z","updated_at":"2016-09-29T14:36:34Z","closed_at":"2016-09-29T14:36:34Z","pull_request":{"url":"https://api.github.com/repos/HackerResidency/bitcoin/pulls/4","html_url":"https://github.com/HackerResidency/bitcoin/pull/4","diff_url":"https://github.com/HackerResidency/bitcoin/pull/4.diff","patch_url":"https://github.com/HackerResidency/bitcoin/pull/4.patch"},"body":"This PR removes almost all of the `TxToJSON()` and `ScriptPubKeyToJSON()` code from bitcoin-rpc and places it in bitcoin-common, removing about 80 lines of duplicate code. The only part that can't be moved into bitcoin-common is parsing block contextual information (confirmations and blocktime), which are not available to bitcoin-common.\r\n\r\nThis PR should be merged along with https://github.com/HackerResidency/bitcoin/pull/3 , which ensures that witness data gets returned from calls to `TxToUniv()`"},"comment":{"url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/comments/250484953","html_url":"https://github.com/HackerResidency/bitcoin/pull/4#issuecomment-250484953","issue_url":"https://api.github.com/repos/HackerResidency/bitcoin/issues/4","id":250484953,"user":{"login":"jnewbery","id":1063656,"avatar_url":"https://avatars.githubusercontent.com/u/1063656?v=3","gravatar_id":"","url":"https://api.github.com/users/jnewbery","html_url":"https://github.com/jnewbery","followers_url":"https://api.github.com/users/jnewbery/followers","following_url":"https://api.github.com/users/jnewbery/following{/other_user}","gists_url":"https://api.github.com/users/jnewbery/gists{/gist_id}","starred_url":"https://api.github.com/users/jnewbery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnewbery/subscriptions","organizations_url":"https://api.github.com/users/jnewbery/orgs","repos_url":"https://api.github.com/users/jnewbery/repos","events_url":"https://api.github.com/users/jnewbery/events{/privacy}","received_events_url":"https://api.github.com/users/jnewbery/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T14:36:34Z","updated_at":"2016-09-29T14:36:34Z","body":"I've opened a PR to bitcoin/bitcoin. Closing this PR."}}
{"actor":{"display_login":"jnewbery"}}