{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15990","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15990/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15990/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15990/events","html_url":"https://github.com/mantidproject/mantid/pull/15990","id":151076117,"number":15990,"title":" Vesuvio - VesuvioThickness algorithm","user":{"login":"ElliotAOram","id":13132128,"avatar_url":"https://avatars.githubusercontent.com/u/13132128?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliotAOram","html_url":"https://github.com/ElliotAOram","followers_url":"https://api.github.com/users/ElliotAOram/followers","following_url":"https://api.github.com/users/ElliotAOram/following{/other_user}","gists_url":"https://api.github.com/users/ElliotAOram/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliotAOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliotAOram/subscriptions","organizations_url":"https://api.github.com/users/ElliotAOram/orgs","repos_url":"https://api.github.com/users/ElliotAOram/repos","events_url":"https://api.github.com/users/ElliotAOram/events{/privacy}","received_events_url":"https://api.github.com/users/ElliotAOram/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Indirect%20Inelastic","name":"Component: Indirect Inelastic","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"Code Freeze:13-May-2016\r\nBeta Testing: 17-May-2016 to 31-May-2016\r\n","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":593,"closed_issues":664,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-05-03T14:25:34Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":2,"created_at":"2016-04-26T08:41:13Z","updated_at":"2016-05-03T14:34:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15990","html_url":"https://github.com/mantidproject/mantid/pull/15990","diff_url":"https://github.com/mantidproject/mantid/pull/15990.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15990.patch"},"body":"The VesuvioThickness algorithm has been implemented with documentation and tests. This has not yet been added into the driver script as I still need to discuss with Matthew how/where in the workflow he would like this algorithm to be executed. Perhaps this could take place as part of the discussion for #15660 \r\n\r\n**To test:**\r\n\r\n* Run the following script:\r\n    ```\r\n    # Algorithm inputs\r\n    masses = \"1.0079,27.0,91.0\"\r\n    amplitudes = \"0.9301589,2.9496644e-02,4.0345035e-02\"\r\n    trans_guess = 0.831\r\n    thickness = 5.0\r\n    number_density = 1.0\r\n    \r\n    # Run algorithm\r\n    dens_tbl, trans_tbl = VesuvioThickness(masses, amplitudes, trans_guess, thickness, \r\n    number_density)\r\n    ```\r\n* You should see two table workspaces produced (`dens_tbl` and `trans_tbl`)\r\n* `dens_tbl`:\r\n  * 10 Iteration[X]: values 1-10\r\n  * 10 Density[Y]: values start at 22.4062 and then converge at 24.4515\r\n* `trans_tbl`:\r\n  * 10 Iteration[X]: values 1-10\r\n  * 10 Transmisson[Y]: values start at 0.992457 and then converge at 0.831\r\n\r\n\r\nFixes #15816\r\n\r\n[Release notes](https://github.com/mantidproject/mantid/blob/15816_VesuvioThickness_algorithm/docs/source/release/v3.7.0/indirect_inelastic.rst#vesuvio)\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/216548366","html_url":"https://github.com/mantidproject/mantid/pull/15990#issuecomment-216548366","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15990","id":216548366,"user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T14:34:25Z","updated_at":"2016-05-03T14:34:25Z","body":"@ElliotAOram Unfortunately `pylint` is unhappy."}}