{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/64233926","id":64233926,"diff_hunk":"@@ -35,5 +35,60 @@\n +// --------------\n +\n +\n++// setTimeout and clearTimeout monitoring\n++// ---------------\n++\n++// Set up container to hold timeout and interval state\n++window.testing = {\n++  timeouts: {}\n++};\n++\n++// Make a copy of the original setTimeout function\n++window._setTimeout = window.setTimeout;\n++window.setTimeout = function(callback, timeout) {\n++  // We need a handle to store our timeout under, we can't just use the\n++  // timeout ID because we don't know it until after we create the timeout\n++  var handle = _.uniqueId();","path":"data/patches/miq_application.js.diff","position":27,"original_position":27,"commit_id":"6184e8cc5a7093219109a7b06a26c13a65cb7224","original_commit_id":"01d19203d32abcc025a1803baa1b5c7bd0ec42bb","user":{"login":"jkrocil","id":964523,"avatar_url":"https://avatars.githubusercontent.com/u/964523?v=3","gravatar_id":"","url":"https://api.github.com/users/jkrocil","html_url":"https://github.com/jkrocil","followers_url":"https://api.github.com/users/jkrocil/followers","following_url":"https://api.github.com/users/jkrocil/following{/other_user}","gists_url":"https://api.github.com/users/jkrocil/gists{/gist_id}","starred_url":"https://api.github.com/users/jkrocil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkrocil/subscriptions","organizations_url":"https://api.github.com/users/jkrocil/orgs","repos_url":"https://api.github.com/users/jkrocil/repos","events_url":"https://api.github.com/users/jkrocil/events{/privacy}","received_events_url":"https://api.github.com/users/jkrocil/received_events","type":"User","site_admin":false},"body":"So... we have underscore.js available?","created_at":"2016-05-23T14:39:26Z","updated_at":"2016-05-23T14:39:26Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/3004#discussion_r64233926","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/64233926"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/3004#discussion_r64233926"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004"}}},"pull_request":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004","id":70755385,"html_url":"https://github.com/RedHatQE/cfme_tests/pull/3004","diff_url":"https://github.com/RedHatQE/cfme_tests/pull/3004.diff","patch_url":"https://github.com/RedHatQE/cfme_tests/pull/3004.patch","issue_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/3004","number":3004,"state":"open","locked":false,"title":"[WIPTEST] Fix wait_for_ajax","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"body":"I've been running into\r\n``[E] Message: Element <cfme.web_ui.Input _names=('hostname',), _use_id=False> not found on page.``\r\nwhen adding the 'OpenShift Enterprise' containers provider. The 'hostname' field is displayed only after the provider type is selected using the drop down menu. The test was not waiting for the field to appear even though the 'wait_for_ajax' method was called in the process.\r\nI debugged the the provider page, added new check to the 'wait_for_ajax' method and verified that the problem is no longer present.\r\nUsing the trace log it can be verified that the new check makes sense:\r\n``2016-05-19 19:22:07,714 [I] Ajax running: miqQE: 0, jquery: 0, prototype: 0, miqProcessing: True, spinner: False, miq: None, autofocus: 0, document: complete (cfme/fixtures/pytest_selenium.py:335)``","created_at":"2016-05-19T19:58:46Z","updated_at":"2016-05-23T14:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"293746bfed98e5ce82f78698de68f7fbcba455fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004/commits","review_comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004/comments","review_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/3004/comments","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/6184e8cc5a7093219109a7b06a26c13a65cb7224","head":{"label":"mkoura:wait_for_ajax","ref":"wait_for_ajax","sha":"6184e8cc5a7093219109a7b06a26c13a65cb7224","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"repo":{"id":58528439,"name":"cfme_tests","full_name":"mkoura/cfme_tests","owner":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkoura/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/mkoura/cfme_tests","forks_url":"https://api.github.com/repos/mkoura/cfme_tests/forks","keys_url":"https://api.github.com/repos/mkoura/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoura/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoura/cfme_tests/teams","hooks_url":"https://api.github.com/repos/mkoura/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/mkoura/cfme_tests/events","assignees_url":"https://api.github.com/repos/mkoura/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/mkoura/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/mkoura/cfme_tests/tags","blobs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoura/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoura/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoura/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoura/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/mkoura/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/mkoura/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/mkoura/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/mkoura/cfme_tests/subscription","commits_url":"https://api.github.com/repos/mkoura/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoura/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoura/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoura/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/mkoura/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoura/cfme_tests/merges","archive_url":"https://api.github.com/repos/mkoura/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoura/cfme_tests/downloads","issues_url":"https://api.github.com/repos/mkoura/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/mkoura/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoura/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoura/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoura/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/mkoura/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/mkoura/cfme_tests/deployments","created_at":"2016-05-11T08:44:27Z","updated_at":"2016-05-11T08:44:29Z","pushed_at":"2016-05-23T14:37:25Z","git_url":"git://github.com/mkoura/cfme_tests.git","ssh_url":"git@github.com:mkoura/cfme_tests.git","clone_url":"https://github.com/mkoura/cfme_tests.git","svn_url":"https://github.com/mkoura/cfme_tests","homepage":"","size":10042,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatQE:master","ref":"master","sha":"b17267fb96403fdb69c6c7d58f235d48d7eb80fc","user":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"cfme_tests","full_name":"RedHatQE/cfme_tests","owner":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatQE/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":false,"url":"https://api.github.com/repos/RedHatQE/cfme_tests","forks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/forks","keys_url":"https://api.github.com/repos/RedHatQE/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatQE/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatQE/cfme_tests/teams","hooks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/events","assignees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatQE/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/tags","blobs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatQE/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscription","commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatQE/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatQE/cfme_tests/merges","archive_url":"https://api.github.com/repos/RedHatQE/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatQE/cfme_tests/downloads","issues_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatQE/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatQE/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatQE/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/RedHatQE/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2016-05-13T07:12:38Z","pushed_at":"2016-05-23T14:37:26Z","git_url":"git://github.com/RedHatQE/cfme_tests.git","ssh_url":"git@github.com:RedHatQE/cfme_tests.git","clone_url":"https://github.com/RedHatQE/cfme_tests.git","svn_url":"https://github.com/RedHatQE/cfme_tests","homepage":"","size":14295,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":72,"forks":55,"open_issues":72,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/3004"},"issue":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/3004"},"comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/3004/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/3004/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/6184e8cc5a7093219109a7b06a26c13a65cb7224"}}}}
{"actor":{"display_login":"jkrocil"}}