{"action":"created","comment":{"url":"https://api.github.com/repos/serverless/serverless/pulls/comments/78268996","id":78268996,"diff_hunk":"@@ -765,8 +766,11 @@ describe('PluginManager', () => {\n   describe('Plugin/CLI integration', () => {","path":"tests/classes/PluginManager.js","position":9,"original_position":9,"commit_id":"049aec6bc0cdf4fa16273ffb87a88f9637f7f83e","original_commit_id":"049aec6bc0cdf4fa16273ffb87a88f9637f7f83e","user":{"login":"dougmoscrop","id":586516,"avatar_url":"https://avatars.githubusercontent.com/u/586516?v=3","gravatar_id":"","url":"https://api.github.com/users/dougmoscrop","html_url":"https://github.com/dougmoscrop","followers_url":"https://api.github.com/users/dougmoscrop/followers","following_url":"https://api.github.com/users/dougmoscrop/following{/other_user}","gists_url":"https://api.github.com/users/dougmoscrop/gists{/gist_id}","starred_url":"https://api.github.com/users/dougmoscrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougmoscrop/subscriptions","organizations_url":"https://api.github.com/users/dougmoscrop/orgs","repos_url":"https://api.github.com/users/dougmoscrop/repos","events_url":"https://api.github.com/users/dougmoscrop/events{/privacy}","received_events_url":"https://api.github.com/users/dougmoscrop/received_events","type":"User","site_admin":false},"body":"oh also, does it make sense to move this test to the integration_test.js file instead of here?","created_at":"2016-09-10T02:00:47Z","updated_at":"2016-09-10T02:00:47Z","html_url":"https://github.com/serverless/serverless/pull/2045#discussion_r78268996","pull_request_url":"https://api.github.com/repos/serverless/serverless/pulls/2045","_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments/78268996"},"html":{"href":"https://github.com/serverless/serverless/pull/2045#discussion_r78268996"},"pull_request":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2045"}}},"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2045","id":84212574,"html_url":"https://github.com/serverless/serverless/pull/2045","diff_url":"https://github.com/serverless/serverless/pull/2045.diff","patch_url":"https://github.com/serverless/serverless/pull/2045.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2045","number":2045,"state":"open","locked":false,"title":"Windows contrib blockers","user":{"login":"gwsii","id":1920378,"avatar_url":"https://avatars.githubusercontent.com/u/1920378?v=3","gravatar_id":"","url":"https://api.github.com/users/gwsii","html_url":"https://github.com/gwsii","followers_url":"https://api.github.com/users/gwsii/followers","following_url":"https://api.github.com/users/gwsii/following{/other_user}","gists_url":"https://api.github.com/users/gwsii/gists{/gist_id}","starred_url":"https://api.github.com/users/gwsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwsii/subscriptions","organizations_url":"https://api.github.com/users/gwsii/orgs","repos_url":"https://api.github.com/users/gwsii/repos","events_url":"https://api.github.com/users/gwsii/events{/privacy}","received_events_url":"https://api.github.com/users/gwsii/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Fill out the whole template so we have a good overview on the issue\r\n3. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it\r\n-->\r\n\r\n## What did you implement:\r\n\r\n***Implementing Issue:*** #2044 \r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\nTo enable running tests, provided a relative path to \"_mocha\" in the package.json.\r\nAddressed the test invocation of the \"serverless\" JS script in Windows by adding \"node\" to the command used to invoke.\r\n\r\n## How can we verify it:\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works, e.g. an example serverless.yml\r\nor AWS CLI commands to trigger something.\r\n-->\r\n\r\nCan verify that this works on Windows by running the 'npm test' command in the root directory. The unit tests should all run. There is currently *ONE* test failure which will need to be addressed.\r\n\r\n## Todos:\r\n\r\n- [ ] Write tests\r\n- [ ] Write documentation\r\n- [ ] Fix linting errors\r\n- [ ] Make sure code coverage hasn't dropped\r\n- [ ] Provide verification config/commands/resources\r\n- [ ] Leave a comment that this is ready for review once you've finished the implementation\r\n","created_at":"2016-09-06T23:15:15Z","updated_at":"2016-09-10T02:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b67580fa1ceddfffb6d6db145a7aa290ea692f9b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/2045/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/2045/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2045/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/049aec6bc0cdf4fa16273ffb87a88f9637f7f83e","head":{"label":"Nordstrom:windows-contrib-blockers","ref":"windows-contrib-blockers","sha":"049aec6bc0cdf4fa16273ffb87a88f9637f7f83e","user":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars.githubusercontent.com/u/2488485?v=3","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"repo":{"id":67551950,"name":"serverless","full_name":"Nordstrom/serverless","owner":{"login":"Nordstrom","id":2488485,"avatar_url":"https://avatars.githubusercontent.com/u/2488485?v=3","gravatar_id":"","url":"https://api.github.com/users/Nordstrom","html_url":"https://github.com/Nordstrom","followers_url":"https://api.github.com/users/Nordstrom/followers","following_url":"https://api.github.com/users/Nordstrom/following{/other_user}","gists_url":"https://api.github.com/users/Nordstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/Nordstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nordstrom/subscriptions","organizations_url":"https://api.github.com/users/Nordstrom/orgs","repos_url":"https://api.github.com/users/Nordstrom/repos","events_url":"https://api.github.com/users/Nordstrom/events{/privacy}","received_events_url":"https://api.github.com/users/Nordstrom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nordstrom/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/Nordstrom/serverless","forks_url":"https://api.github.com/repos/Nordstrom/serverless/forks","keys_url":"https://api.github.com/repos/Nordstrom/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nordstrom/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nordstrom/serverless/teams","hooks_url":"https://api.github.com/repos/Nordstrom/serverless/hooks","issue_events_url":"https://api.github.com/repos/Nordstrom/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/Nordstrom/serverless/events","assignees_url":"https://api.github.com/repos/Nordstrom/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/Nordstrom/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/Nordstrom/serverless/tags","blobs_url":"https://api.github.com/repos/Nordstrom/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nordstrom/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nordstrom/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nordstrom/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nordstrom/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/Nordstrom/serverless/languages","stargazers_url":"https://api.github.com/repos/Nordstrom/serverless/stargazers","contributors_url":"https://api.github.com/repos/Nordstrom/serverless/contributors","subscribers_url":"https://api.github.com/repos/Nordstrom/serverless/subscribers","subscription_url":"https://api.github.com/repos/Nordstrom/serverless/subscription","commits_url":"https://api.github.com/repos/Nordstrom/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nordstrom/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nordstrom/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nordstrom/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nordstrom/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/Nordstrom/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nordstrom/serverless/merges","archive_url":"https://api.github.com/repos/Nordstrom/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nordstrom/serverless/downloads","issues_url":"https://api.github.com/repos/Nordstrom/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/Nordstrom/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/Nordstrom/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/Nordstrom/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nordstrom/serverless/labels{/name}","releases_url":"https://api.github.com/repos/Nordstrom/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/Nordstrom/serverless/deployments","created_at":"2016-09-06T22:39:19Z","updated_at":"2016-09-06T22:39:21Z","pushed_at":"2016-09-09T00:49:31Z","git_url":"git://github.com/Nordstrom/serverless.git","ssh_url":"git@github.com:Nordstrom/serverless.git","clone_url":"https://github.com/Nordstrom/serverless.git","svn_url":"https://github.com/Nordstrom/serverless","homepage":"http://www.serverless.com","size":71212,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"f9c23ad573e3e07fde49e3955004bcfde1d96a93","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2016-09-10T00:49:59Z","pushed_at":"2016-09-10T01:09:16Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":89361,"stargazers_count":10585,"watchers_count":10585,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":769,"mirror_url":null,"open_issues_count":128,"forks":769,"open_issues":128,"watchers":10585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2045"},"html":{"href":"https://github.com/serverless/serverless/pull/2045"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/2045"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/2045/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2045/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2045/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/049aec6bc0cdf4fa16273ffb87a88f9637f7f83e"}}}}
{"actor":{"display_login":"dougmoscrop"}}