{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/spack/issues/1722","repository_url":"https://api.github.com/repos/LLNL/spack","labels_url":"https://api.github.com/repos/LLNL/spack/issues/1722/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/1722/comments","events_url":"https://api.github.com/repos/LLNL/spack/issues/1722/events","html_url":"https://github.com/LLNL/spack/issues/1722","id":174872962,"number":1722,"title":"Report on Running QA Stuff","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-03T01:45:15Z","updated_at":"2016-09-05T21:29:02Z","closed_at":null,"body":"@adamjstewart The new separation of unit, doc and flake8 tests is really nice.  Here's my report on trying to run them, I think another round of improvements is probably needed.\r\n\r\n**flake8**\r\n------------\r\nWorked like a charm:\r\n```\r\nspack install py-flake8\r\nspack load py-flake8\r\ncd spack/lib/spack/docs\r\nflake8 my-file.py\r\n```\r\nBTW: I would consider just naming the package flake8, not py-flake8.  Because it's (sort of) a top-level app, the fact that it's implemented in Python is not so important.  Admittedly, this is a grey area.\r\n\r\nflake8 reports line numbers but no context.  That makes it really hard to follow and correct its errors off of Travis.  You really need to install flake8 yourself.  Luckily, installing it myself worked.\r\n\r\n**Unit tests**\r\n---------------\r\nI tried running unit tests as I always have before (go to the directory, run it with nosetest or python), and that failed miserably.  I see now, there's a qa script.\r\n\r\nBut that script is not useful for my needs.  To be useful in rapid debugging, we need a way to run a SINGLE unit test, even a SINGLE test case within a single unit test.  We also need a way to run a SINGLE directory of unit tests, plus all unit tests.  Nosetest gives this  out of the box, but that functionality has now been obscured by a single run-all-the-tests script.\r\n\r\nUltimately, I copied out the one unit test I needed to a different directory, put an 'if __main__' at the end, hacked my PYTHONPATH to point to Spack, and ran it with python.  Hack, hack, hack.  This needs to be set up better so I can run single (or a selection of) tests without those kinds of hacks.\r\n\r\n**sphinx**\r\n-----------\r\nI could not get Sphinx working.  See console log:\r\n```\r\nvpn-128-154-224-57:docs me$ spack find py-sphinx\r\n==> 1 installed packages.\r\n-- darwin-elcapitan-x86_64 / clang@7.3.0-apple ------------------\r\npy-sphinx@1.3.1\r\nvpn-128-154-224-57:docs me$ spack load py-sphinx\r\nvpn-128-154-224-57:docs me$ make\r\nsphinx-apidoc -T -o . ../../spack/spack\r\nTraceback (most recent call last):\r\n  File \"/Users/me/spack/opt/spack/darwin-elcapitan-x86_64/clang-7.3.0-apple/py-sphinx-1.3.1-t4j2snyy2fwja5rknsbbp6mkf5norpbs/bin/sphinx-apidoc\", line 5, in <module>\r\n    from pkg_resources import load_entry_point\r\n  File \"/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py\", line 2793, in <module>\r\n    working_set.require(__requires__)\r\n  File \"/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py\", line 673, in require\r\n    needed = self.resolve(parse_requirements(requirements))\r\n  File \"/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py\", line 576, in resolve\r\n    raise DistributionNotFound(req)\r\npkg_resources.DistributionNotFound: Sphinx==1.3.1\r\nmake: *** [apidoc] Error 1\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LLNL/spack/issues/comments/244813177","html_url":"https://github.com/LLNL/spack/issues/1722#issuecomment-244813177","issue_url":"https://api.github.com/repos/LLNL/spack/issues/1722","id":244813177,"user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"created_at":"2016-09-05T21:29:02Z","updated_at":"2016-09-05T21:29:02Z","body":"> Now I ran into the issues that py-sphinx has a lot of stealth dependencies that are handled by PIP, not Spack. \r\n\r\n@citibeth Are you using the latest Spack develop? `py-sphinx` now depends_on `py-sphinx-rtd-theme` as of #1563. If it's still trying to use pip to find that dependency, then we have other problems."}}
{"actor":{"display_login":"adamjstewart"}}