{"action":"created","issue":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/779","repository_url":"https://api.github.com/repos/mesonbuild/meson","labels_url":"https://api.github.com/repos/mesonbuild/meson/issues/779/labels{/name}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/779/comments","events_url":"https://api.github.com/repos/mesonbuild/meson/issues/779/events","html_url":"https://github.com/mesonbuild/meson/pull/779","id":176246305,"number":779,"title":"Add dependency support to the checks using the compiler","user":{"login":"ystreet","id":1631425,"avatar_url":"https://avatars.githubusercontent.com/u/1631425?v=3","gravatar_id":"","url":"https://api.github.com/users/ystreet","html_url":"https://github.com/ystreet","followers_url":"https://api.github.com/users/ystreet/followers","following_url":"https://api.github.com/users/ystreet/following{/other_user}","gists_url":"https://api.github.com/users/ystreet/gists{/gist_id}","starred_url":"https://api.github.com/users/ystreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystreet/subscriptions","organizations_url":"https://api.github.com/users/ystreet/orgs","repos_url":"https://api.github.com/users/ystreet/repos","events_url":"https://api.github.com/users/ystreet/events{/privacy}","received_events_url":"https://api.github.com/users/ystreet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mesonbuild/meson/labels/gstreamer","name":"gstreamer","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-11T14:25:23Z","updated_at":"2016-09-12T22:46:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/779","html_url":"https://github.com/mesonbuild/meson/pull/779","diff_url":"https://github.com/mesonbuild/meson/pull/779.diff","patch_url":"https://github.com/mesonbuild/meson/pull/779.patch"},"body":"It is extremely common to need to know within a given dependency if\r\na given header, symbol, member, function, etc exists that cannot be\r\ndetermined from the version number alone.\r\n\r\nWithout passing dependency objects to the various compiler/linker\r\nchecks and with many libraries headers/libraries being located in\r\ntheir own subdirs of the standard prefix, the check for the library\r\nwould not find the header/function/symbol/etc.\r\n\r\nThis commit allows passing dependency objects to the compiler checks so\r\nthat the test program can be compiled/linked/run with the necessary\r\ncompilation and/or linking flags for that library.\r\n\r\nFixes #134 and #367 \r\n\r\n---\r\nNote: For the test, I originally tried to implement my own small library that I could depend on however that became a nightmare for numerous reasons.\r\n1. Such a setup would require building the library so/dll/dylib before the parent meson.build checks for things in it.  This limits the allowed dependencies to only allow external deps.\r\n2.1. Or, would require setting up pkg-config to point to some test directory which means that the aforementioned library would have to be installed as well.\r\n2.1. Which means it would have to be in a path without spaces as both pkg-config and meson get this wrong for cflags/libs.\r\n\r\nInstead the test just uses some other common libraries (glib and zlib) like the other tests do."},"comment":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/comments/246519765","html_url":"https://github.com/mesonbuild/meson/pull/779#issuecomment-246519765","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/779","id":246519765,"user":{"login":"ystreet","id":1631425,"avatar_url":"https://avatars.githubusercontent.com/u/1631425?v=3","gravatar_id":"","url":"https://api.github.com/users/ystreet","html_url":"https://github.com/ystreet","followers_url":"https://api.github.com/users/ystreet/followers","following_url":"https://api.github.com/users/ystreet/following{/other_user}","gists_url":"https://api.github.com/users/ystreet/gists{/gist_id}","starred_url":"https://api.github.com/users/ystreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystreet/subscriptions","organizations_url":"https://api.github.com/users/ystreet/orgs","repos_url":"https://api.github.com/users/ystreet/repos","events_url":"https://api.github.com/users/ystreet/events{/privacy}","received_events_url":"https://api.github.com/users/ystreet/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T22:46:53Z","updated_at":"2016-09-12T22:46:53Z","body":"Correct, that is point 1. above.\r\n\r\nThe commit limits it to external deps as is done elsewhere."}}
{"actor":{"display_login":"ystreet"}}