{"action":"created","issue":{"url":"https://api.github.com/repos/apache/arrow/issues/29","repository_url":"https://api.github.com/repos/apache/arrow","labels_url":"https://api.github.com/repos/apache/arrow/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/apache/arrow/issues/29/comments","events_url":"https://api.github.com/repos/apache/arrow/issues/29/events","html_url":"https://github.com/apache/arrow/pull/29","id":141796264,"number":29,"title":"ARROW-28: Adding google's benchmark library to the toolchain","user":{"login":"emkornfield","id":17869838,"avatar_url":"https://avatars.githubusercontent.com/u/17869838?v=3","gravatar_id":"","url":"https://api.github.com/users/emkornfield","html_url":"https://github.com/emkornfield","followers_url":"https://api.github.com/users/emkornfield/followers","following_url":"https://api.github.com/users/emkornfield/following{/other_user}","gists_url":"https://api.github.com/users/emkornfield/gists{/gist_id}","starred_url":"https://api.github.com/users/emkornfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkornfield/subscriptions","organizations_url":"https://api.github.com/users/emkornfield/orgs","repos_url":"https://api.github.com/users/emkornfield/repos","events_url":"https://api.github.com/users/emkornfield/events{/privacy}","received_events_url":"https://api.github.com/users/emkornfield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-03-18T07:41:04Z","updated_at":"2016-03-22T15:48:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/29","html_url":"https://github.com/apache/arrow/pull/29","diff_url":"https://github.com/apache/arrow/pull/29.diff","patch_url":"https://github.com/apache/arrow/pull/29.patch"},"body":"This isn't yet complete, but before I go further I think its worth asking some questions on peoples' preferences:\r\n\r\n1.  It seems that the build third-party script is setting up an install directory that it is not making use of.   Do we want to keep this functionality and start adding new libraries to be placed there?  The gtest component of the tool-chain assumes it is in its own location, and this how I patterned google benchmark integration.  \r\n\r\n2.  Do we want to couple unit test builds with benchmark builds?  I am currently aiming for having them decoupled and having benchmarks off by default.\r\n\r\n3.  I am not familiar with the Darwin/mac build environment and it is not clear if the CXX flags are required universally.  (I need to fix it anyways to move -DGTEST_USE_OWN_TR1_TUPLE=1 back to be gtest only).  Travis-ci might provide the answer.\r\n\r\n4.  Any other basic features in the benchmark toolchain people would like to see as part of this PR?  Wes mentioned starting to create benchmarking tools lib, but I think that likely belongs in a separate PR."},"comment":{"url":"https://api.github.com/repos/apache/arrow/issues/comments/199875452","html_url":"https://github.com/apache/arrow/pull/29#issuecomment-199875452","issue_url":"https://api.github.com/repos/apache/arrow/issues/29","id":199875452,"user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T15:48:59Z","updated_at":"2016-03-22T15:48:59Z","body":"+1, thank you very much. "}}