{"action":"closed","number":5430,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5430","id":90686623,"html_url":"https://github.com/apple/swift/pull/5430","diff_url":"https://github.com/apple/swift/pull/5430.diff","patch_url":"https://github.com/apple/swift/pull/5430.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5430","number":5430,"state":"closed","locked":false,"title":"SourceKit: checking context match before calling TypeBase:: getMemberSubstitutions.","user":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"body":" SourceKit: checking context match before calling TypeBase::getMemberSubstitutions(const DeclContext *dc). rdar://28780008\r\n\r\n    TypeBase::getMemberSubstitutions(const DeclContext *dc) collects type\r\n    substitution information when a decl context can be treated as part of the\r\n    type definition. However, we call it without checking whether the\r\n    part-of-whole relationship really holds. This patch checks the\r\n    pre-condition before calling it to fix a crash.","created_at":"2016-10-24T20:30:21Z","updated_at":"2016-10-24T20:56:53Z","closed_at":"2016-10-24T20:56:53Z","merged_at":"2016-10-24T20:56:53Z","merge_commit_sha":"260d908aa7859f71702cdeed77932b7fc4470bfc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5430/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5430/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5430/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/64082e122f8283b6263ce9d0e623b595074753cd","head":{"label":"nkcsgexi:substitution-crash","ref":"substitution-crash","sha":"64082e122f8283b6263ce9d0e623b595074753cd","user":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"repo":{"id":71506838,"name":"swift","full_name":"nkcsgexi/swift","owner":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkcsgexi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/nkcsgexi/swift","forks_url":"https://api.github.com/repos/nkcsgexi/swift/forks","keys_url":"https://api.github.com/repos/nkcsgexi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkcsgexi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkcsgexi/swift/teams","hooks_url":"https://api.github.com/repos/nkcsgexi/swift/hooks","issue_events_url":"https://api.github.com/repos/nkcsgexi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/nkcsgexi/swift/events","assignees_url":"https://api.github.com/repos/nkcsgexi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/nkcsgexi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/nkcsgexi/swift/tags","blobs_url":"https://api.github.com/repos/nkcsgexi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkcsgexi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkcsgexi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkcsgexi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkcsgexi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/nkcsgexi/swift/languages","stargazers_url":"https://api.github.com/repos/nkcsgexi/swift/stargazers","contributors_url":"https://api.github.com/repos/nkcsgexi/swift/contributors","subscribers_url":"https://api.github.com/repos/nkcsgexi/swift/subscribers","subscription_url":"https://api.github.com/repos/nkcsgexi/swift/subscription","commits_url":"https://api.github.com/repos/nkcsgexi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkcsgexi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkcsgexi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkcsgexi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkcsgexi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/nkcsgexi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkcsgexi/swift/merges","archive_url":"https://api.github.com/repos/nkcsgexi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkcsgexi/swift/downloads","issues_url":"https://api.github.com/repos/nkcsgexi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/nkcsgexi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/nkcsgexi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/nkcsgexi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkcsgexi/swift/labels{/name}","releases_url":"https://api.github.com/repos/nkcsgexi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/nkcsgexi/swift/deployments","created_at":"2016-10-20T21:44:17Z","updated_at":"2016-10-20T21:44:40Z","pushed_at":"2016-10-24T20:33:13Z","git_url":"git://github.com/nkcsgexi/swift.git","ssh_url":"git@github.com:nkcsgexi/swift.git","clone_url":"https://github.com/nkcsgexi/swift.git","svn_url":"https://github.com/nkcsgexi/swift","homepage":"https://swift.org/","size":126841,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0f5f1c2898cabfa4683604c28e38f434d1f528cc","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-10-24T20:48:27Z","pushed_at":"2016-10-24T20:56:53Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":191801,"stargazers_count":34679,"watchers_count":34679,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4978,"mirror_url":null,"open_issues_count":103,"forks":4978,"open_issues":103,"watchers":34679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5430"},"html":{"href":"https://github.com/apple/swift/pull/5430"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5430"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5430/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5430/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5430/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/64082e122f8283b6263ce9d0e623b595074753cd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"swift-ci","id":15467072,"avatar_url":"https://avatars.githubusercontent.com/u/15467072?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-ci","html_url":"https://github.com/swift-ci","followers_url":"https://api.github.com/users/swift-ci/followers","following_url":"https://api.github.com/users/swift-ci/following{/other_user}","gists_url":"https://api.github.com/users/swift-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-ci/subscriptions","organizations_url":"https://api.github.com/users/swift-ci/orgs","repos_url":"https://api.github.com/users/swift-ci/repos","events_url":"https://api.github.com/users/swift-ci/events{/privacy}","received_events_url":"https://api.github.com/users/swift-ci/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":410,"deletions":133,"changed_files":5}}
{"actor":{"display_login":"swift-ci"}}