{"action":"created","issue":{"url":"https://api.github.com/repos/Eyescale/CMake/issues/512","repository_url":"https://api.github.com/repos/Eyescale/CMake","labels_url":"https://api.github.com/repos/Eyescale/CMake/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/Eyescale/CMake/issues/512/comments","events_url":"https://api.github.com/repos/Eyescale/CMake/issues/512/events","html_url":"https://github.com/Eyescale/CMake/issues/512","id":182241060,"number":512,"title":"-WError abuse","user":{"login":"adevress","id":1773511,"avatar_url":"https://avatars.githubusercontent.com/u/1773511?v=3","gravatar_id":"","url":"https://api.github.com/users/adevress","html_url":"https://github.com/adevress","followers_url":"https://api.github.com/users/adevress/followers","following_url":"https://api.github.com/users/adevress/following{/other_user}","gists_url":"https://api.github.com/users/adevress/gists{/gist_id}","starred_url":"https://api.github.com/users/adevress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adevress/subscriptions","organizations_url":"https://api.github.com/users/adevress/orgs","repos_url":"https://api.github.com/users/adevress/repos","events_url":"https://api.github.com/users/adevress/events{/privacy}","received_events_url":"https://api.github.com/users/adevress/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-11T11:35:52Z","updated_at":"2016-10-11T12:16:17Z","closed_at":null,"body":"The file CommonCompiler.cmake force the usage of the flag -WError.\r\n\r\nHis usage is completely understandable and justified for build in \"Debug\" mode.\r\nIt is however a bad practice to enable it by default for release build due to its tendency to break the build each time a new compiler implement new warning reporting.\r\n\r\nCould you please, enable this flag only when the build is configured in \"Debug\" mode ?\r\n\r\nThank you in advance,\r\nAdev"},"comment":{"url":"https://api.github.com/repos/Eyescale/CMake/issues/comments/252900619","html_url":"https://github.com/Eyescale/CMake/issues/512#issuecomment-252900619","issue_url":"https://api.github.com/repos/Eyescale/CMake/issues/512","id":252900619,"user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T12:16:17Z","updated_at":"2016-10-11T12:16:17Z","body":"Support for different compilers other than the supported ones aka gcc 4.8 and 5.4 should be added then. Having a warning is one thing, but you might get real errors as well which have to be addressed similarly.\r\n\r\nWarnings from out-of-our-control dependencies are a non-issue with -isystem, so I'm still wondering if it's crucial to have the option, because on a generalization one disables all warnings and hell breaks loose.\r\n\r\nI'm not super-positive with adding the option, but it seems to be the shortest path to success."}}
{"actor":{"display_login":"tribal-tec"}}