{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/58354453","id":58354453,"diff_hunk":"@@ -0,0 +1,34 @@\n+/**\n+ * @license\n+ * Copyright 2016 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+'use strict';\n+\n+/**\n+ * @param  {Number} sizePx\n+ * @param  {any} manifest\n+ */\n+module.exports = function iconsAtLeast(sizePx, manifest) {\n+  const iconValues = manifest.value.icons;\n+  const nestedSizes = iconValues.value.map(icon => icon.value.sizes.value);\n+  const flattenedSizes = [].concat.apply([], nestedSizes);\n+\n+  return flattenedSizes\n+      .filter(size => typeof size === 'string')\n+      .map(size => size.split(/x/i))\n+      .map(pairStr => [parseFloat(pairStr[0]), parseFloat(pairStr[1])])\n+      .filter(pair => pair[0] >= sizePx)\n+      .filter(pair => pair[1] >= sizePx);","path":"helpers/icons-at-least.js","position":33,"original_position":33,"commit_id":"2aa9e0b70fe6c6619b5ba8fe0acdac2490cb714b","original_commit_id":"2aa9e0b70fe6c6619b5ba8fe0acdac2490cb714b","user":{"login":"paullewis","id":617438,"avatar_url":"https://avatars.githubusercontent.com/u/617438?v=3","gravatar_id":"","url":"https://api.github.com/users/paullewis","html_url":"https://github.com/paullewis","followers_url":"https://api.github.com/users/paullewis/followers","following_url":"https://api.github.com/users/paullewis/following{/other_user}","gists_url":"https://api.github.com/users/paullewis/gists{/gist_id}","starred_url":"https://api.github.com/users/paullewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paullewis/subscriptions","organizations_url":"https://api.github.com/users/paullewis/orgs","repos_url":"https://api.github.com/users/paullewis/repos","events_url":"https://api.github.com/users/paullewis/events{/privacy}","received_events_url":"https://api.github.com/users/paullewis/received_events","type":"User","site_admin":false},"body":"Add comments for each step of that plz :smile: ","created_at":"2016-04-04T10:15:04Z","updated_at":"2016-04-04T10:15:04Z","html_url":"https://github.com/GoogleChrome/lighthouse/pull/116#discussion_r58354453","pull_request_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments/58354453"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/116#discussion_r58354453"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116","id":64979715,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/116","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/116.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/116.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/116","number":116,"state":"open","locked":false,"title":"manifest icons at least {144 192}","user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"body":"Comments welcome.   ","created_at":"2016-04-01T17:43:38Z","updated_at":"2016-04-04T10:15:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc450b9592f09d5afe29fd3640414d3d50207c92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/116/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/2aa9e0b70fe6c6619b5ba8fe0acdac2490cb714b","head":{"label":"paulirish:144px","ref":"144px","sha":"2aa9e0b70fe6c6619b5ba8fe0acdac2490cb714b","user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"repo":{"id":53765650,"name":"lighthouse","full_name":"paulirish/lighthouse","owner":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulirish/lighthouse","description":null,"fork":true,"url":"https://api.github.com/repos/paulirish/lighthouse","forks_url":"https://api.github.com/repos/paulirish/lighthouse/forks","keys_url":"https://api.github.com/repos/paulirish/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulirish/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulirish/lighthouse/teams","hooks_url":"https://api.github.com/repos/paulirish/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/paulirish/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/paulirish/lighthouse/events","assignees_url":"https://api.github.com/repos/paulirish/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/paulirish/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/paulirish/lighthouse/tags","blobs_url":"https://api.github.com/repos/paulirish/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulirish/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulirish/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulirish/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulirish/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/paulirish/lighthouse/languages","stargazers_url":"https://api.github.com/repos/paulirish/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/paulirish/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/paulirish/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/paulirish/lighthouse/subscription","commits_url":"https://api.github.com/repos/paulirish/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulirish/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulirish/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulirish/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulirish/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/paulirish/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulirish/lighthouse/merges","archive_url":"https://api.github.com/repos/paulirish/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulirish/lighthouse/downloads","issues_url":"https://api.github.com/repos/paulirish/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/paulirish/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/paulirish/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/paulirish/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulirish/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/paulirish/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/paulirish/lighthouse/deployments","created_at":"2016-03-13T03:28:47Z","updated_at":"2016-03-13T03:28:48Z","pushed_at":"2016-04-04T07:18:52Z","git_url":"git://github.com/paulirish/lighthouse.git","ssh_url":"git@github.com:paulirish/lighthouse.git","clone_url":"https://github.com/paulirish/lighthouse.git","svn_url":"https://github.com/paulirish/lighthouse","homepage":null,"size":2535,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"8ada139e574d5e93e352f3af00a66343ef50ac67","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-04-04T06:57:53Z","pushed_at":"2016-04-04T10:07:46Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":null,"size":2443,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":28,"forks":11,"open_issues":28,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/116"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/116"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/2aa9e0b70fe6c6619b5ba8fe0acdac2490cb714b"}}}}