{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/71871048","id":71871048,"diff_hunk":"@@ -507,30 +506,38 @@ ldc::DISubroutineType ldc::DIBuilder::CreateFunctionType(Type *type) {\n #endif\n }\n \n-ldc::DISubroutineType ldc::DIBuilder::CreateDelegateType(Type *type) {\n-  // FIXME: Implement\n-  TypeDelegate *t = static_cast<TypeDelegate *>(type);\n+ldc::DIType ldc::DIBuilder::CreateDelegateType(Type *type) {\n+  ldc::DICompileUnit CU(GetCU());\n+  assert(CU && \"Compilation unit missing or corrupted\");\n \n-// Create \"dummy\" subroutine type for the return type\n-#if LDC_LLVM_VER >= 306\n-  llvm::SmallVector<llvm::Metadata *, 16> Elts;\n-#else\n-  llvm::SmallVector<llvm::Value *, 16> Elts;\n-#endif\n-  Elts.push_back(DBuilder.createUnspecifiedType(type->toChars()));\n+  Loc loc(IR->dmodule->srcfile->toChars(), 0, 0);\n+  ldc::DIFile file(CreateFile(loc));\n+\n+  DIType voidPtrType = CreatePointerType(Type::tvoidptr);\n #if LDC_LLVM_VER >= 306\n-  auto EltTypeArray = DBuilder.getOrCreateTypeArray(Elts);\n+  llvm::Metadata *elems[] =\n #else\n-  auto EltTypeArray = DBuilder.getOrCreateArray(Elts);\n+  llvm::Value *elems[] =\n #endif\n+      {voidPtrType, voidPtrType};\n+  llvm::DINodeArray elemsArray = DBuilder.getOrCreateArray(elems);","path":"gen/dibuilder.cpp","position":52,"original_position":52,"commit_id":"2855a26e9f652fd118833aa5b7479d39aff70ded","original_commit_id":"2855a26e9f652fd118833aa5b7479d39aff70ded","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"Just represent a delegate as pair of void pointers, at least for now.","created_at":"2016-07-22T12:32:29Z","updated_at":"2016-07-22T12:32:29Z","html_url":"https://github.com/ldc-developers/ldc/pull/1633#discussion_r71871048","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/71871048"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1633#discussion_r71871048"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633","id":78469579,"html_url":"https://github.com/ldc-developers/ldc/pull/1633","diff_url":"https://github.com/ldc-developers/ldc/pull/1633.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/1633.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1633","number":1633,"state":"open","locked":false,"title":"Misc. debuginfo fixes + new LLVM 3.9 for AppVeyor","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-22T12:30:46Z","updated_at":"2016-07-22T12:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14bc8b614ef0118b128354a8e81e1cf12ee15910","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/1633/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/2855a26e9f652fd118833aa5b7479d39aff70ded","head":{"label":"kinke:appveyor","ref":"appveyor","sha":"2855a26e9f652fd118833aa5b7479d39aff70ded","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":7853031,"name":"ldc","full_name":"kinke/ldc","owner":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinke/ldc","description":"The LLVM D compiler.","fork":true,"url":"https://api.github.com/repos/kinke/ldc","forks_url":"https://api.github.com/repos/kinke/ldc/forks","keys_url":"https://api.github.com/repos/kinke/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/ldc/teams","hooks_url":"https://api.github.com/repos/kinke/ldc/hooks","issue_events_url":"https://api.github.com/repos/kinke/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/ldc/events","assignees_url":"https://api.github.com/repos/kinke/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/ldc/tags","blobs_url":"https://api.github.com/repos/kinke/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/ldc/languages","stargazers_url":"https://api.github.com/repos/kinke/ldc/stargazers","contributors_url":"https://api.github.com/repos/kinke/ldc/contributors","subscribers_url":"https://api.github.com/repos/kinke/ldc/subscribers","subscription_url":"https://api.github.com/repos/kinke/ldc/subscription","commits_url":"https://api.github.com/repos/kinke/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/ldc/merges","archive_url":"https://api.github.com/repos/kinke/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/ldc/downloads","issues_url":"https://api.github.com/repos/kinke/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/ldc/labels{/name}","releases_url":"https://api.github.com/repos/kinke/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/ldc/deployments","created_at":"2013-01-27T14:20:48Z","updated_at":"2015-08-08T16:02:35Z","pushed_at":"2016-07-22T12:29:35Z","git_url":"git://github.com/kinke/ldc.git","ssh_url":"git@github.com:kinke/ldc.git","clone_url":"https://github.com/kinke/ldc.git","svn_url":"https://github.com/kinke/ldc","homepage":"http://wiki.dlang.org/LDC","size":25066,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"win64"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"d034ede92e6d6778a80f22fe837270b7e709893b","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars.githubusercontent.com/u/960112?v=3","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2016-07-19T10:08:59Z","pushed_at":"2016-07-22T12:30:46Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":29165,"stargazers_count":476,"watchers_count":476,"language":"D","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":180,"forks":99,"open_issues":180,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/1633"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1633"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/1633/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/1633/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/2855a26e9f652fd118833aa5b7479d39aff70ded"}}}}
{"actor":{"display_login":"kinke"}}