{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/comments/77139112","id":77139112,"diff_hunk":"@@ -25,7 +32,13 @@ public Address(String address, boolean isPrivate) throws IllegalValueException {\n         if (!isValidAddress(address)) {\n             throw new IllegalValueException(MESSAGE_ADDRESS_CONSTRAINTS);\n         }\n-        this.value = address;\n+        \n+        Pattern p = Pattern.compile(ADDRESS_SPLIT_REGEX);\n+        String[] items = p.split(address);\n+        block = new Block(items[0]);","path":"src/seedu/addressbook/data/person/Address.java","position":39,"original_position":39,"commit_id":"10e2a11d6443a3247ea071b5dfb6d7bf3979a5f2","original_commit_id":"10e2a11d6443a3247ea071b5dfb6d7bf3979a5f2","user":{"login":"nirandiw","id":1713871,"avatar_url":"https://avatars.githubusercontent.com/u/1713871?v=3","gravatar_id":"","url":"https://api.github.com/users/nirandiw","html_url":"https://github.com/nirandiw","followers_url":"https://api.github.com/users/nirandiw/followers","following_url":"https://api.github.com/users/nirandiw/following{/other_user}","gists_url":"https://api.github.com/users/nirandiw/gists{/gist_id}","starred_url":"https://api.github.com/users/nirandiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirandiw/subscriptions","organizations_url":"https://api.github.com/users/nirandiw/orgs","repos_url":"https://api.github.com/users/nirandiw/repos","events_url":"https://api.github.com/users/nirandiw/events{/privacy}","received_events_url":"https://api.github.com/users/nirandiw/received_events","type":"User","site_admin":false},"body":"What is one component is missing. can try to handle it rather than forcing 4 components.","created_at":"2016-09-01T09:10:28Z","updated_at":"2016-09-01T09:10:28Z","html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568#discussion_r77139112","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/comments/77139112"},"html":{"href":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568#discussion_r77139112"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568","id":83590173,"html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568","diff_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568.diff","patch_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/568","number":568,"state":"open","locked":false,"title":"[T3A3][T10-A1] Lim Zhiming","user":{"login":"zhiminglim","id":21197092,"avatar_url":"https://avatars.githubusercontent.com/u/21197092?v=3","gravatar_id":"","url":"https://api.github.com/users/zhiminglim","html_url":"https://github.com/zhiminglim","followers_url":"https://api.github.com/users/zhiminglim/followers","following_url":"https://api.github.com/users/zhiminglim/following{/other_user}","gists_url":"https://api.github.com/users/zhiminglim/gists{/gist_id}","starred_url":"https://api.github.com/users/zhiminglim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhiminglim/subscriptions","organizations_url":"https://api.github.com/users/zhiminglim/orgs","repos_url":"https://api.github.com/users/zhiminglim/repos","events_url":"https://api.github.com/users/zhiminglim/events{/privacy}","received_events_url":"https://api.github.com/users/zhiminglim/received_events","type":"User","site_admin":false},"body":"Ready for review\r\n\r\nSome code adapted from #293 (followed same technique and some code for Address class)","created_at":"2016-09-01T08:27:58Z","updated_at":"2016-09-01T09:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fab6ffff071c55bd612794eb6dfe323bc34ed6b","assignee":{"login":"nirandiw","id":1713871,"avatar_url":"https://avatars.githubusercontent.com/u/1713871?v=3","gravatar_id":"","url":"https://api.github.com/users/nirandiw","html_url":"https://github.com/nirandiw","followers_url":"https://api.github.com/users/nirandiw/followers","following_url":"https://api.github.com/users/nirandiw/following{/other_user}","gists_url":"https://api.github.com/users/nirandiw/gists{/gist_id}","starred_url":"https://api.github.com/users/nirandiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirandiw/subscriptions","organizations_url":"https://api.github.com/users/nirandiw/orgs","repos_url":"https://api.github.com/users/nirandiw/repos","events_url":"https://api.github.com/users/nirandiw/events{/privacy}","received_events_url":"https://api.github.com/users/nirandiw/received_events","type":"User","site_admin":false},"assignees":[{"login":"nirandiw","id":1713871,"avatar_url":"https://avatars.githubusercontent.com/u/1713871?v=3","gravatar_id":"","url":"https://api.github.com/users/nirandiw","html_url":"https://github.com/nirandiw","followers_url":"https://api.github.com/users/nirandiw/followers","following_url":"https://api.github.com/users/nirandiw/following{/other_user}","gists_url":"https://api.github.com/users/nirandiw/gists{/gist_id}","starred_url":"https://api.github.com/users/nirandiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirandiw/subscriptions","organizations_url":"https://api.github.com/users/nirandiw/orgs","repos_url":"https://api.github.com/users/nirandiw/repos","events_url":"https://api.github.com/users/nirandiw/events{/privacy}","received_events_url":"https://api.github.com/users/nirandiw/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/568/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/statuses/10e2a11d6443a3247ea071b5dfb6d7bf3979a5f2","head":{"label":"zhiminglim:T3A3","ref":"T3A3","sha":"10e2a11d6443a3247ea071b5dfb6d7bf3979a5f2","user":{"login":"zhiminglim","id":21197092,"avatar_url":"https://avatars.githubusercontent.com/u/21197092?v=3","gravatar_id":"","url":"https://api.github.com/users/zhiminglim","html_url":"https://github.com/zhiminglim","followers_url":"https://api.github.com/users/zhiminglim/followers","following_url":"https://api.github.com/users/zhiminglim/following{/other_user}","gists_url":"https://api.github.com/users/zhiminglim/gists{/gist_id}","starred_url":"https://api.github.com/users/zhiminglim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhiminglim/subscriptions","organizations_url":"https://api.github.com/users/zhiminglim/orgs","repos_url":"https://api.github.com/users/zhiminglim/repos","events_url":"https://api.github.com/users/zhiminglim/events{/privacy}","received_events_url":"https://api.github.com/users/zhiminglim/received_events","type":"User","site_admin":false},"repo":{"id":66829987,"name":"addressbook-level2","full_name":"zhiminglim/addressbook-level2","owner":{"login":"zhiminglim","id":21197092,"avatar_url":"https://avatars.githubusercontent.com/u/21197092?v=3","gravatar_id":"","url":"https://api.github.com/users/zhiminglim","html_url":"https://github.com/zhiminglim","followers_url":"https://api.github.com/users/zhiminglim/followers","following_url":"https://api.github.com/users/zhiminglim/following{/other_user}","gists_url":"https://api.github.com/users/zhiminglim/gists{/gist_id}","starred_url":"https://api.github.com/users/zhiminglim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhiminglim/subscriptions","organizations_url":"https://api.github.com/users/zhiminglim/orgs","repos_url":"https://api.github.com/users/zhiminglim/repos","events_url":"https://api.github.com/users/zhiminglim/events{/privacy}","received_events_url":"https://api.github.com/users/zhiminglim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhiminglim/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/zhiminglim/addressbook-level2","forks_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/forks","keys_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/events","assignees_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/merges","archive_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/zhiminglim/addressbook-level2/deployments","created_at":"2016-08-29T09:26:38Z","updated_at":"2016-08-29T09:26:39Z","pushed_at":"2016-09-01T08:18:13Z","git_url":"git://github.com/zhiminglim/addressbook-level2.git","ssh_url":"git@github.com:zhiminglim/addressbook-level2.git","clone_url":"https://github.com/zhiminglim/addressbook-level2.git","svn_url":"https://github.com/zhiminglim/addressbook-level2","homepage":null,"size":2993,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1617S1:master","ref":"master","sha":"19f22e05d9fa4c555d2526f2ed3e70fb336eb43a","user":{"login":"nus-cs2103-AY1617S1","id":20475842,"avatar_url":"https://avatars.githubusercontent.com/u/20475842?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S1","html_url":"https://github.com/nus-cs2103-AY1617S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/received_events","type":"Organization","site_admin":false},"repo":{"id":66551047,"name":"addressbook-level2","full_name":"nus-cs2103-AY1617S1/addressbook-level2","owner":{"login":"nus-cs2103-AY1617S1","id":20475842,"avatar_url":"https://avatars.githubusercontent.com/u/20475842?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S1","html_url":"https://github.com/nus-cs2103-AY1617S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/deployments","created_at":"2016-08-25T11:09:03Z","updated_at":"2016-08-31T14:24:36Z","pushed_at":"2016-09-01T09:07:50Z","git_url":"git://github.com/nus-cs2103-AY1617S1/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1617S1/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2","homepage":null,"size":3960,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":465,"forks":238,"open_issues":465,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568"},"html":{"href":"https://github.com/nus-cs2103-AY1617S1/addressbook-level2/pull/568"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/568"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S1/addressbook-level2/statuses/10e2a11d6443a3247ea071b5dfb6d7bf3979a5f2"}}}}
{"actor":{"display_login":"nirandiw"}}