{"action":"created","comment":{"url":"https://api.github.com/repos/matheuss/aperture.js/pulls/comments/91439965","pull_request_review_id":11947798,"id":91439965,"diff_hunk":"@@ -36,7 +36,10 @@ public class Recorder: NSObject, AVCaptureFileOutputRecordingDelegate {\n     }\n \n     self.output = AVCaptureMovieFileOutput();\n-    self.output?.movieFragmentInterval = CMTimeMake(1,1); // write data to file every 1 second\n+\n+    // write data to file every 2 seconds\n+    // writing every 1 second causes intermittent errors\n+    self.output?.movieFragmentInterval = CMTimeMakeWithSeconds(2, 1);","path":"swift/aperture/Recorder.swift","position":8,"original_position":8,"commit_id":"911a34c955fb5f521be64a842848d17d27f05aa3","original_commit_id":"911a34c955fb5f521be64a842848d17d27f05aa3","user":{"login":"doot0","id":1171137,"avatar_url":"https://avatars.githubusercontent.com/u/1171137?v=3","gravatar_id":"","url":"https://api.github.com/users/doot0","html_url":"https://github.com/doot0","followers_url":"https://api.github.com/users/doot0/followers","following_url":"https://api.github.com/users/doot0/following{/other_user}","gists_url":"https://api.github.com/users/doot0/gists{/gist_id}","starred_url":"https://api.github.com/users/doot0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doot0/subscriptions","organizations_url":"https://api.github.com/users/doot0/orgs","repos_url":"https://api.github.com/users/doot0/repos","events_url":"https://api.github.com/users/doot0/events{/privacy}","received_events_url":"https://api.github.com/users/doot0/received_events","type":"User","site_admin":false},"body":"This is a great workaround. The fact this works alludes to the problem being buffer related. Maybe we should investigate buffering filesystem writes in a more comprehensive manner.\r\n\r\ncc @matheuss ","created_at":"2016-12-08T04:10:09Z","updated_at":"2016-12-08T04:10:09Z","html_url":"https://github.com/matheuss/aperture.js/pull/1#discussion_r91439965","pull_request_url":"https://api.github.com/repos/matheuss/aperture.js/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/comments/91439965"},"html":{"href":"https://github.com/matheuss/aperture.js/pull/1#discussion_r91439965"},"pull_request":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/matheuss/aperture.js/pulls/1","id":97055092,"html_url":"https://github.com/matheuss/aperture.js/pull/1","diff_url":"https://github.com/matheuss/aperture.js/pull/1.diff","patch_url":"https://github.com/matheuss/aperture.js/pull/1.patch","issue_url":"https://api.github.com/repos/matheuss/aperture.js/issues/1","number":1,"state":"open","locked":false,"title":"Fix intermittent error when recording using specified mic","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"No more \"FigMovieFormatFileWriter::PostProcessMovie: WriteMovie() errored!!! -12780\"!","created_at":"2016-12-08T03:55:31Z","updated_at":"2016-12-08T04:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d342e0e54a18271691cb0af811f14044c0b7363","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matheuss/aperture.js/pulls/1/commits","review_comments_url":"https://api.github.com/repos/matheuss/aperture.js/pulls/1/comments","review_comment_url":"https://api.github.com/repos/matheuss/aperture.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matheuss/aperture.js/issues/1/comments","statuses_url":"https://api.github.com/repos/matheuss/aperture.js/statuses/911a34c955fb5f521be64a842848d17d27f05aa3","head":{"label":"sindresorhus:fix-error-with-recording-mic","ref":"fix-error-with-recording-mic","sha":"911a34c955fb5f521be64a842848d17d27f05aa3","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":75901017,"name":"aperture.js","full_name":"sindresorhus/aperture.js","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/aperture.js","description":"A library for screen recording","fork":true,"url":"https://api.github.com/repos/sindresorhus/aperture.js","forks_url":"https://api.github.com/repos/sindresorhus/aperture.js/forks","keys_url":"https://api.github.com/repos/sindresorhus/aperture.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/aperture.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/aperture.js/teams","hooks_url":"https://api.github.com/repos/sindresorhus/aperture.js/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/aperture.js/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/aperture.js/events","assignees_url":"https://api.github.com/repos/sindresorhus/aperture.js/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/aperture.js/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/aperture.js/tags","blobs_url":"https://api.github.com/repos/sindresorhus/aperture.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/aperture.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/aperture.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/aperture.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/aperture.js/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/aperture.js/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/aperture.js/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/aperture.js/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/aperture.js/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/aperture.js/subscription","commits_url":"https://api.github.com/repos/sindresorhus/aperture.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/aperture.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/aperture.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/aperture.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/aperture.js/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/aperture.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/aperture.js/merges","archive_url":"https://api.github.com/repos/sindresorhus/aperture.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/aperture.js/downloads","issues_url":"https://api.github.com/repos/sindresorhus/aperture.js/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/aperture.js/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/aperture.js/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/aperture.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/aperture.js/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/aperture.js/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/aperture.js/deployments","created_at":"2016-12-08T03:53:51Z","updated_at":"2016-12-08T03:53:52Z","pushed_at":"2016-12-08T03:56:45Z","git_url":"git://github.com/sindresorhus/aperture.js.git","ssh_url":"git@github.com:sindresorhus/aperture.js.git","clone_url":"https://github.com/sindresorhus/aperture.js.git","svn_url":"https://github.com/sindresorhus/aperture.js","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matheuss:record-audio","ref":"record-audio","sha":"c53bccbb1e60ed1f17664d6926287a43c232be12","user":{"login":"matheuss","id":4721750,"avatar_url":"https://avatars.githubusercontent.com/u/4721750?v=3","gravatar_id":"","url":"https://api.github.com/users/matheuss","html_url":"https://github.com/matheuss","followers_url":"https://api.github.com/users/matheuss/followers","following_url":"https://api.github.com/users/matheuss/following{/other_user}","gists_url":"https://api.github.com/users/matheuss/gists{/gist_id}","starred_url":"https://api.github.com/users/matheuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheuss/subscriptions","organizations_url":"https://api.github.com/users/matheuss/orgs","repos_url":"https://api.github.com/users/matheuss/repos","events_url":"https://api.github.com/users/matheuss/events{/privacy}","received_events_url":"https://api.github.com/users/matheuss/received_events","type":"User","site_admin":false},"repo":{"id":75754374,"name":"aperture.js","full_name":"matheuss/aperture.js","owner":{"login":"matheuss","id":4721750,"avatar_url":"https://avatars.githubusercontent.com/u/4721750?v=3","gravatar_id":"","url":"https://api.github.com/users/matheuss","html_url":"https://github.com/matheuss","followers_url":"https://api.github.com/users/matheuss/followers","following_url":"https://api.github.com/users/matheuss/following{/other_user}","gists_url":"https://api.github.com/users/matheuss/gists{/gist_id}","starred_url":"https://api.github.com/users/matheuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheuss/subscriptions","organizations_url":"https://api.github.com/users/matheuss/orgs","repos_url":"https://api.github.com/users/matheuss/repos","events_url":"https://api.github.com/users/matheuss/events{/privacy}","received_events_url":"https://api.github.com/users/matheuss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matheuss/aperture.js","description":"A library for screen recording","fork":true,"url":"https://api.github.com/repos/matheuss/aperture.js","forks_url":"https://api.github.com/repos/matheuss/aperture.js/forks","keys_url":"https://api.github.com/repos/matheuss/aperture.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matheuss/aperture.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matheuss/aperture.js/teams","hooks_url":"https://api.github.com/repos/matheuss/aperture.js/hooks","issue_events_url":"https://api.github.com/repos/matheuss/aperture.js/issues/events{/number}","events_url":"https://api.github.com/repos/matheuss/aperture.js/events","assignees_url":"https://api.github.com/repos/matheuss/aperture.js/assignees{/user}","branches_url":"https://api.github.com/repos/matheuss/aperture.js/branches{/branch}","tags_url":"https://api.github.com/repos/matheuss/aperture.js/tags","blobs_url":"https://api.github.com/repos/matheuss/aperture.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matheuss/aperture.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matheuss/aperture.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/matheuss/aperture.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matheuss/aperture.js/statuses/{sha}","languages_url":"https://api.github.com/repos/matheuss/aperture.js/languages","stargazers_url":"https://api.github.com/repos/matheuss/aperture.js/stargazers","contributors_url":"https://api.github.com/repos/matheuss/aperture.js/contributors","subscribers_url":"https://api.github.com/repos/matheuss/aperture.js/subscribers","subscription_url":"https://api.github.com/repos/matheuss/aperture.js/subscription","commits_url":"https://api.github.com/repos/matheuss/aperture.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/matheuss/aperture.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/matheuss/aperture.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/matheuss/aperture.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/matheuss/aperture.js/contents/{+path}","compare_url":"https://api.github.com/repos/matheuss/aperture.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matheuss/aperture.js/merges","archive_url":"https://api.github.com/repos/matheuss/aperture.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matheuss/aperture.js/downloads","issues_url":"https://api.github.com/repos/matheuss/aperture.js/issues{/number}","pulls_url":"https://api.github.com/repos/matheuss/aperture.js/pulls{/number}","milestones_url":"https://api.github.com/repos/matheuss/aperture.js/milestones{/number}","notifications_url":"https://api.github.com/repos/matheuss/aperture.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matheuss/aperture.js/labels{/name}","releases_url":"https://api.github.com/repos/matheuss/aperture.js/releases{/id}","deployments_url":"https://api.github.com/repos/matheuss/aperture.js/deployments","created_at":"2016-12-06T17:22:29Z","updated_at":"2016-12-06T17:22:30Z","pushed_at":"2016-12-08T03:56:45Z","git_url":"git://github.com/matheuss/aperture.js.git","ssh_url":"git@github.com:matheuss/aperture.js.git","clone_url":"https://github.com/matheuss/aperture.js.git","svn_url":"https://github.com/matheuss/aperture.js","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/1"},"html":{"href":"https://github.com/matheuss/aperture.js/pull/1"},"issue":{"href":"https://api.github.com/repos/matheuss/aperture.js/issues/1"},"comments":{"href":"https://api.github.com/repos/matheuss/aperture.js/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matheuss/aperture.js/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/matheuss/aperture.js/statuses/911a34c955fb5f521be64a842848d17d27f05aa3"}}}}
{"actor":{"display_login":"doot0"}}