{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/comments/90223157","pull_request_review_id":10744268,"id":90223157,"diff_hunk":"@@ -123,6 +123,32 @@ - (void)pluginInitialize\n                name:UIApplicationWillEnterForegroundNotification object:nil];\n \n     NSLog(@\"Using WKWebView\");\n+\n+    [self addURLObserver];\n+}\n+\n+- (void)onReset {\n+    [self addURLObserver];\n+}\n+\n+static void * KVOContext = &KVOContext;\n+\n+- (void)addURLObserver {\n+    if(![[NSProcessInfo processInfo] isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9, .minorVersion = 0, .patchVersion = 0 }]){","path":"src/ios/CDVWKWebViewEngine.m","position":null,"original_position":15,"commit_id":"980b3201c38c00bb995c70b5b4b7786721b40822","original_commit_id":"d9d30f2cf91f307b44ecc5efe1763ae7d0b3bdb3","user":{"login":"cjpearson","id":2095133,"avatar_url":"https://avatars.githubusercontent.com/u/2095133?v=3","gravatar_id":"","url":"https://api.github.com/users/cjpearson","html_url":"https://github.com/cjpearson","followers_url":"https://api.github.com/users/cjpearson/followers","following_url":"https://api.github.com/users/cjpearson/following{/other_user}","gists_url":"https://api.github.com/users/cjpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpearson/subscriptions","organizations_url":"https://api.github.com/users/cjpearson/orgs","repos_url":"https://api.github.com/users/cjpearson/repos","events_url":"https://api.github.com/users/cjpearson/events{/privacy}","received_events_url":"https://api.github.com/users/cjpearson/received_events","type":"User","site_admin":false},"body":"Yeah I was using the local webserver plugin to support iOS 8.","created_at":"2016-11-30T12:30:47Z","updated_at":"2016-11-30T12:30:47Z","html_url":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157","pull_request_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/comments/90223157"},"html":{"href":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23","id":88882026,"html_url":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23","diff_url":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23.diff","patch_url":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23.patch","issue_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/23","number":23,"state":"open","locked":false,"title":"CB-11997: Add crash recovery for iOS 8","user":{"login":"cjpearson","id":2095133,"avatar_url":"https://avatars.githubusercontent.com/u/2095133?v=3","gravatar_id":"","url":"https://api.github.com/users/cjpearson","html_url":"https://github.com/cjpearson","followers_url":"https://api.github.com/users/cjpearson/followers","following_url":"https://api.github.com/users/cjpearson/following{/other_user}","gists_url":"https://api.github.com/users/cjpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpearson/subscriptions","organizations_url":"https://api.github.com/users/cjpearson/orgs","repos_url":"https://api.github.com/users/cjpearson/repos","events_url":"https://api.github.com/users/cjpearson/events{/privacy}","received_events_url":"https://api.github.com/users/cjpearson/received_events","type":"User","site_admin":false},"body":"<!--\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\n\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\n\nThanks!\n-->\n### Platforms affected\n\niOS\n### What does this PR do?\n\nReloads the WebView when it crashes. This behavior already exists on iOS >= 9, but has not been added for iOS 8.\n### What testing has been done on this change?\n\nI've tried consuming a bunch of memory in javascript to cause a crash. The app reloads successfully.\n### Checklist\n- [x] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\n- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\n- [ ] Added automated test coverage as appropriate for this change.\n","created_at":"2016-10-11T18:08:58Z","updated_at":"2016-11-30T12:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe31935e6ff54b9c5e9dd3e4cb92926e77eaf898","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/23/comments","statuses_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/statuses/980b3201c38c00bb995c70b5b4b7786721b40822","head":{"label":"cjpearson:master","ref":"master","sha":"980b3201c38c00bb995c70b5b4b7786721b40822","user":{"login":"cjpearson","id":2095133,"avatar_url":"https://avatars.githubusercontent.com/u/2095133?v=3","gravatar_id":"","url":"https://api.github.com/users/cjpearson","html_url":"https://github.com/cjpearson","followers_url":"https://api.github.com/users/cjpearson/followers","following_url":"https://api.github.com/users/cjpearson/following{/other_user}","gists_url":"https://api.github.com/users/cjpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpearson/subscriptions","organizations_url":"https://api.github.com/users/cjpearson/orgs","repos_url":"https://api.github.com/users/cjpearson/repos","events_url":"https://api.github.com/users/cjpearson/events{/privacy}","received_events_url":"https://api.github.com/users/cjpearson/received_events","type":"User","site_admin":false},"repo":{"id":63990262,"name":"cordova-plugin-wkwebview-engine","full_name":"cjpearson/cordova-plugin-wkwebview-engine","owner":{"login":"cjpearson","id":2095133,"avatar_url":"https://avatars.githubusercontent.com/u/2095133?v=3","gravatar_id":"","url":"https://api.github.com/users/cjpearson","html_url":"https://github.com/cjpearson","followers_url":"https://api.github.com/users/cjpearson/followers","following_url":"https://api.github.com/users/cjpearson/following{/other_user}","gists_url":"https://api.github.com/users/cjpearson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpearson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpearson/subscriptions","organizations_url":"https://api.github.com/users/cjpearson/orgs","repos_url":"https://api.github.com/users/cjpearson/repos","events_url":"https://api.github.com/users/cjpearson/events{/privacy}","received_events_url":"https://api.github.com/users/cjpearson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjpearson/cordova-plugin-wkwebview-engine","description":"Mirror of Apache Cordova wkwebview engine plugin","fork":true,"url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine","forks_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/forks","keys_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/teams","hooks_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/hooks","issue_events_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/issues/events{/number}","events_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/events","assignees_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/assignees{/user}","branches_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/branches{/branch}","tags_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/tags","blobs_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/languages","stargazers_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/stargazers","contributors_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/contributors","subscribers_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/subscribers","subscription_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/subscription","commits_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/contents/{+path}","compare_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/merges","archive_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/downloads","issues_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/issues{/number}","pulls_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/labels{/name}","releases_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/releases{/id}","deployments_url":"https://api.github.com/repos/cjpearson/cordova-plugin-wkwebview-engine/deployments","created_at":"2016-07-22T23:55:26Z","updated_at":"2016-07-22T23:55:26Z","pushed_at":"2016-11-30T12:29:18Z","git_url":"git://github.com/cjpearson/cordova-plugin-wkwebview-engine.git","ssh_url":"git@github.com:cjpearson/cordova-plugin-wkwebview-engine.git","clone_url":"https://github.com/cjpearson/cordova-plugin-wkwebview-engine.git","svn_url":"https://github.com/cjpearson/cordova-plugin-wkwebview-engine","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"81e889854a5ca8b7bd620f91e945998a280305c3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":42161741,"name":"cordova-plugin-wkwebview-engine","full_name":"apache/cordova-plugin-wkwebview-engine","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-plugin-wkwebview-engine","description":"Mirror of Apache Cordova wkwebview engine plugin","fork":false,"url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine","forks_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/forks","keys_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/teams","hooks_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/events","assignees_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/tags","blobs_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/subscription","commits_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/merges","archive_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/downloads","issues_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/deployments","created_at":"2015-09-09T07:00:05Z","updated_at":"2016-11-29T17:04:38Z","pushed_at":"2016-11-30T12:29:19Z","git_url":"git://github.com/apache/cordova-plugin-wkwebview-engine.git","ssh_url":"git@github.com:apache/cordova-plugin-wkwebview-engine.git","clone_url":"https://github.com/apache/cordova-plugin-wkwebview-engine.git","svn_url":"https://github.com/apache/cordova-plugin-wkwebview-engine","homepage":null,"size":162,"stargazers_count":185,"watchers_count":185,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":"git://git.apache.org/cordova-plugin-wkwebview-engine.git","open_issues_count":5,"forks":100,"open_issues":5,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23"},"html":{"href":"https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23"},"issue":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/23"},"comments":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-plugin-wkwebview-engine/statuses/980b3201c38c00bb995c70b5b4b7786721b40822"}}}}
{"actor":{"display_login":"cjpearson"}}