{"action":"created","comment":{"url":"https://api.github.com/repos/bolt/bolt/pulls/comments/94280116","pull_request_review_id":14810100,"id":94280116,"diff_hunk":"@@ -44,11 +44,11 @@ public function createFirstUserTest(\\AcceptanceTester $I)\n         $I->see('Please create the first user');\n \n         // Fill in the form and submit\n-        $I->fillField('form[username]',              $this->user['admin']['username']);\n-        $I->fillField('form[password]',              $this->user['admin']['password']);\n-        $I->fillField('form[password_confirmation]', $this->user['admin']['password']);\n-        $I->fillField('form[email]',                 $this->user['admin']['email']);\n-        $I->fillField('form[displayname]',           $this->user['admin']['displayname']);\n+        $I->fillField('user_new[username]',         $this->user['admin']['username']);","path":"tests/codeception/acceptance/000-FirstUser/FirstUserCest.php","position":9,"original_position":9,"commit_id":"dd21ae600f7f00e4b918de6ceeec2e621e3bde58","original_commit_id":"dd21ae600f7f00e4b918de6ceeec2e621e3bde58","user":{"login":"Nitpick-CI","id":12626182,"avatar_url":"https://avatars.githubusercontent.com/u/12626182?v=3","gravatar_id":"","url":"https://api.github.com/users/Nitpick-CI","html_url":"https://github.com/Nitpick-CI","followers_url":"https://api.github.com/users/Nitpick-CI/followers","following_url":"https://api.github.com/users/Nitpick-CI/following{/other_user}","gists_url":"https://api.github.com/users/Nitpick-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/Nitpick-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nitpick-CI/subscriptions","organizations_url":"https://api.github.com/users/Nitpick-CI/orgs","repos_url":"https://api.github.com/users/Nitpick-CI/repos","events_url":"https://api.github.com/users/Nitpick-CI/events{/privacy}","received_events_url":"https://api.github.com/users/Nitpick-CI/received_events","type":"User","site_admin":false},"body":"Expected 1 space after comma in function call; 9 found","created_at":"2017-01-01T05:22:10Z","updated_at":"2017-01-01T05:22:10Z","html_url":"https://github.com/bolt/bolt/pull/6214#discussion_r94280116","pull_request_url":"https://api.github.com/repos/bolt/bolt/pulls/6214","_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments/94280116"},"html":{"href":"https://github.com/bolt/bolt/pull/6214#discussion_r94280116"},"pull_request":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6214"}}},"pull_request":{"url":"https://api.github.com/repos/bolt/bolt/pulls/6214","id":99818006,"html_url":"https://github.com/bolt/bolt/pull/6214","diff_url":"https://github.com/bolt/bolt/pull/6214.diff","patch_url":"https://github.com/bolt/bolt/pull/6214.patch","issue_url":"https://api.github.com/repos/bolt/bolt/issues/6214","number":6214,"state":"open","locked":false,"title":"Rouge Logic 1","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"body":"This introduces Phase I of Symfony Forms use for the back-end in 3.4.\r\n\r\nThe end goal is to remove logic from controllers, templates, and other services, that is better handled by configurable upstream components.\r\n\r\n* Remove form logic from `Bolt\\Controller\\Backend\\Users` :tada: :balloon: :cake: \r\n* Custom validation constraints for:\r\n  * Entity does not match a persisted entity type, based on one or more fields (lazy loaded)\r\n  * Matching field values, e.g. user name !== password\r\n  * Field value is contained inside another field value, e.g. password is not a part of a display name\r\n* `UserRoleType` that handles disabling of roles that a user shouldn't modify\r\n* Themed form widgets where needed\r\n\r\nThis is, in part, brought forward by keeping #5496 moving — which I have a  clean up branch for — as this would be a nice feature to cap-off the start of _this_ work.\r\n\r\nFollow-up work:\r\n* Login form & controllers\r\n* Content record editor :gun: (lots of work)","created_at":"2017-01-01T05:21:37Z","updated_at":"2017-01-01T05:22:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56d8e536581089305503b6c6f8fd1d049259b138","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bolt/bolt/milestones/22","html_url":"https://github.com/bolt/bolt/milestone/22","labels_url":"https://api.github.com/repos/bolt/bolt/milestones/22/labels","id":1940201,"number":22,"title":"Bolt 3.4 - Feature release","description":"","creator":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-08-13T11:31:03Z","updated_at":"2017-01-01T05:21:37Z","due_on":"2017-03-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/bolt/bolt/pulls/6214/commits","review_comments_url":"https://api.github.com/repos/bolt/bolt/pulls/6214/comments","review_comment_url":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bolt/bolt/issues/6214/comments","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/dd21ae600f7f00e4b918de6ceeec2e621e3bde58","head":{"label":"GawainLynch:feature/symfony-forms-phase-i","ref":"feature/symfony-forms-phase-i","sha":"dd21ae600f7f00e4b918de6ceeec2e621e3bde58","user":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"repo":{"id":17311922,"name":"bolt","full_name":"GawainLynch/bolt","owner":{"login":"GawainLynch","id":1427081,"avatar_url":"https://avatars.githubusercontent.com/u/1427081?v=3","gravatar_id":"","url":"https://api.github.com/users/GawainLynch","html_url":"https://github.com/GawainLynch","followers_url":"https://api.github.com/users/GawainLynch/followers","following_url":"https://api.github.com/users/GawainLynch/following{/other_user}","gists_url":"https://api.github.com/users/GawainLynch/gists{/gist_id}","starred_url":"https://api.github.com/users/GawainLynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GawainLynch/subscriptions","organizations_url":"https://api.github.com/users/GawainLynch/orgs","repos_url":"https://api.github.com/users/GawainLynch/repos","events_url":"https://api.github.com/users/GawainLynch/events{/privacy}","received_events_url":"https://api.github.com/users/GawainLynch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GawainLynch/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":true,"url":"https://api.github.com/repos/GawainLynch/bolt","forks_url":"https://api.github.com/repos/GawainLynch/bolt/forks","keys_url":"https://api.github.com/repos/GawainLynch/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GawainLynch/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GawainLynch/bolt/teams","hooks_url":"https://api.github.com/repos/GawainLynch/bolt/hooks","issue_events_url":"https://api.github.com/repos/GawainLynch/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/GawainLynch/bolt/events","assignees_url":"https://api.github.com/repos/GawainLynch/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/GawainLynch/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/GawainLynch/bolt/tags","blobs_url":"https://api.github.com/repos/GawainLynch/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GawainLynch/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GawainLynch/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/GawainLynch/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GawainLynch/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/GawainLynch/bolt/languages","stargazers_url":"https://api.github.com/repos/GawainLynch/bolt/stargazers","contributors_url":"https://api.github.com/repos/GawainLynch/bolt/contributors","subscribers_url":"https://api.github.com/repos/GawainLynch/bolt/subscribers","subscription_url":"https://api.github.com/repos/GawainLynch/bolt/subscription","commits_url":"https://api.github.com/repos/GawainLynch/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/GawainLynch/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/GawainLynch/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/GawainLynch/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/GawainLynch/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/GawainLynch/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GawainLynch/bolt/merges","archive_url":"https://api.github.com/repos/GawainLynch/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GawainLynch/bolt/downloads","issues_url":"https://api.github.com/repos/GawainLynch/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/GawainLynch/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/GawainLynch/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/GawainLynch/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GawainLynch/bolt/labels{/name}","releases_url":"https://api.github.com/repos/GawainLynch/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/GawainLynch/bolt/deployments","created_at":"2014-03-01T09:31:48Z","updated_at":"2016-10-22T09:23:42Z","pushed_at":"2017-01-01T05:15:18Z","git_url":"git://github.com/GawainLynch/bolt.git","ssh_url":"git@github.com:GawainLynch/bolt.git","clone_url":"https://github.com/GawainLynch/bolt.git","svn_url":"https://github.com/GawainLynch/bolt","homepage":"","size":68006,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bolt:release/3.4","ref":"release/3.4","sha":"c1f90222dd7dec72585680436ee3f043faba17b1","user":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"repo":{"id":4665416,"name":"bolt","full_name":"bolt/bolt","owner":{"login":"bolt","id":3869752,"avatar_url":"https://avatars.githubusercontent.com/u/3869752?v=3","gravatar_id":"","url":"https://api.github.com/users/bolt","html_url":"https://github.com/bolt","followers_url":"https://api.github.com/users/bolt/followers","following_url":"https://api.github.com/users/bolt/following{/other_user}","gists_url":"https://api.github.com/users/bolt/gists{/gist_id}","starred_url":"https://api.github.com/users/bolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bolt/subscriptions","organizations_url":"https://api.github.com/users/bolt/orgs","repos_url":"https://api.github.com/users/bolt/repos","events_url":"https://api.github.com/users/bolt/events{/privacy}","received_events_url":"https://api.github.com/users/bolt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bolt/bolt","description":"Bolt is a simple CMS written in PHP. It is based on Silex and Symfony components, uses Twig and either SQLite, MySQL or PostgreSQL.","fork":false,"url":"https://api.github.com/repos/bolt/bolt","forks_url":"https://api.github.com/repos/bolt/bolt/forks","keys_url":"https://api.github.com/repos/bolt/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bolt/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bolt/bolt/teams","hooks_url":"https://api.github.com/repos/bolt/bolt/hooks","issue_events_url":"https://api.github.com/repos/bolt/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/bolt/bolt/events","assignees_url":"https://api.github.com/repos/bolt/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/bolt/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/bolt/bolt/tags","blobs_url":"https://api.github.com/repos/bolt/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bolt/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bolt/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bolt/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bolt/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/bolt/bolt/languages","stargazers_url":"https://api.github.com/repos/bolt/bolt/stargazers","contributors_url":"https://api.github.com/repos/bolt/bolt/contributors","subscribers_url":"https://api.github.com/repos/bolt/bolt/subscribers","subscription_url":"https://api.github.com/repos/bolt/bolt/subscription","commits_url":"https://api.github.com/repos/bolt/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bolt/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bolt/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bolt/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bolt/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/bolt/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bolt/bolt/merges","archive_url":"https://api.github.com/repos/bolt/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bolt/bolt/downloads","issues_url":"https://api.github.com/repos/bolt/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/bolt/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/bolt/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/bolt/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bolt/bolt/labels{/name}","releases_url":"https://api.github.com/repos/bolt/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/bolt/bolt/deployments","created_at":"2012-06-14T16:07:54Z","updated_at":"2016-12-31T11:47:24Z","pushed_at":"2017-01-01T05:21:38Z","git_url":"git://github.com/bolt/bolt.git","ssh_url":"git@github.com:bolt/bolt.git","clone_url":"https://github.com/bolt/bolt.git","svn_url":"https://github.com/bolt/bolt","homepage":"","size":67877,"stargazers_count":3075,"watchers_count":3075,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":705,"mirror_url":null,"open_issues_count":143,"forks":705,"open_issues":143,"watchers":3075,"default_branch":"release/3.2"}},"_links":{"self":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6214"},"html":{"href":"https://github.com/bolt/bolt/pull/6214"},"issue":{"href":"https://api.github.com/repos/bolt/bolt/issues/6214"},"comments":{"href":"https://api.github.com/repos/bolt/bolt/issues/6214/comments"},"review_comments":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6214/comments"},"review_comment":{"href":"https://api.github.com/repos/bolt/bolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bolt/bolt/pulls/6214/commits"},"statuses":{"href":"https://api.github.com/repos/bolt/bolt/statuses/dd21ae600f7f00e4b918de6ceeec2e621e3bde58"}}}}
{"actor":{"display_login":"Nitpick-CI"}}