{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64446169","id":64446169,"diff_hunk":"@@ -942,6 +942,9 @@ func (gce *GCECloud) firewallObject(name, region, desc string, sourceRanges nets\n \tif err != nil {","path":"pkg/cloudprovider/providers/gce/gce.go","position":1,"original_position":1,"commit_id":"8926362b8c2e76c45e939ed21ed0e214a7ab31cb","original_commit_id":"8926362b8c2e76c45e939ed21ed0e214a7ab31cb","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"the computeHostTags method is kind of weird. I'd expect user supplied input to be used, and if not supplied (eg: empyt list) to use some default, but the method has an early return that ignores the given list of hosts. \r\n\r\nLooks like there's only 1 call site for computeHostTags, can you move the check:\r\n```\r\n\tif len(gce.nodeTags) > 0 {\r\n\t\treturn gce.nodeTags, nil\r\n\t}\r\n```\r\nup into the caller, so it's clear that we're not actually using the supplied hosts if the tags are supplied?","created_at":"2016-05-24T18:15:32Z","updated_at":"2016-05-24T18:15:32Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25929#discussion_r64446169","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64446169"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25929#discussion_r64446169"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929","id":70785680,"html_url":"https://github.com/kubernetes/kubernetes/pull/25929","diff_url":"https://github.com/kubernetes/kubernetes/pull/25929.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25929.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25929","number":25929,"state":"open","locked":false,"title":"refuse to create a firewall rule with no target tag","user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"body":"fixes #25145\r\n\r\nThis modification in gce.firewallObject() will return error when trying\r\nto create or update firewall rule if no node tag can be found. Also add\r\nunit test for this modification.","created_at":"2016-05-20T00:20:18Z","updated_at":"2016-05-24T18:15:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6d8fe1dc624c45bb93b14acbe0f068ba25f8eb9","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25929/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8926362b8c2e76c45e939ed21ed0e214a7ab31cb","head":{"label":"jingxu97:bug-notag","ref":"bug-notag","sha":"8926362b8c2e76c45e939ed21ed0e214a7ab31cb","user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"repo":{"id":58414660,"name":"kubernetes","full_name":"jingxu97/kubernetes","owner":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars.githubusercontent.com/u/19172805?v=3","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jingxu97/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/jingxu97/kubernetes","forks_url":"https://api.github.com/repos/jingxu97/kubernetes/forks","keys_url":"https://api.github.com/repos/jingxu97/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jingxu97/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jingxu97/kubernetes/teams","hooks_url":"https://api.github.com/repos/jingxu97/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jingxu97/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jingxu97/kubernetes/events","assignees_url":"https://api.github.com/repos/jingxu97/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jingxu97/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jingxu97/kubernetes/tags","blobs_url":"https://api.github.com/repos/jingxu97/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jingxu97/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jingxu97/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jingxu97/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jingxu97/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jingxu97/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jingxu97/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jingxu97/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jingxu97/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jingxu97/kubernetes/subscription","commits_url":"https://api.github.com/repos/jingxu97/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jingxu97/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jingxu97/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jingxu97/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jingxu97/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jingxu97/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jingxu97/kubernetes/merges","archive_url":"https://api.github.com/repos/jingxu97/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jingxu97/kubernetes/downloads","issues_url":"https://api.github.com/repos/jingxu97/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jingxu97/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jingxu97/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jingxu97/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jingxu97/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jingxu97/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jingxu97/kubernetes/deployments","created_at":"2016-05-09T23:28:27Z","updated_at":"2016-05-09T23:28:42Z","pushed_at":"2016-05-20T21:12:30Z","git_url":"git://github.com/jingxu97/kubernetes.git","ssh_url":"git@github.com:jingxu97/kubernetes.git","clone_url":"https://github.com/jingxu97/kubernetes.git","svn_url":"https://github.com/jingxu97/kubernetes","homepage":"http://kubernetes.io","size":240841,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"505fb857260bc2f661d70c59037e6a1328020891","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-24T17:25:22Z","pushed_at":"2016-05-24T18:13:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":447626,"stargazers_count":14536,"watchers_count":14536,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4421,"mirror_url":null,"open_issues_count":3659,"forks":4421,"open_issues":3659,"watchers":14536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25929"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25929"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25929/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25929/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8926362b8c2e76c45e939ed21ed0e214a7ab31cb"}}}}
{"actor":{"display_login":"bprashanth"}}