{"action":"opened","number":175,"pull_request":{"url":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175","id":95718427,"html_url":"https://github.com/andrewgaul/s3proxy/pull/175","diff_url":"https://github.com/andrewgaul/s3proxy/pull/175.diff","patch_url":"https://github.com/andrewgaul/s3proxy/pull/175.patch","issue_url":"https://api.github.com/repos/andrewgaul/s3proxy/issues/175","number":175,"state":"open","locked":false,"title":"Allow endpoint of s3proxy to have service path (aka context)","user":{"login":"shenghu","id":9978192,"avatar_url":"https://avatars.githubusercontent.com/u/9978192?v=3","gravatar_id":"","url":"https://api.github.com/users/shenghu","html_url":"https://github.com/shenghu","followers_url":"https://api.github.com/users/shenghu/followers","following_url":"https://api.github.com/users/shenghu/following{/other_user}","gists_url":"https://api.github.com/users/shenghu/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghu/subscriptions","organizations_url":"https://api.github.com/users/shenghu/orgs","repos_url":"https://api.github.com/users/shenghu/repos","events_url":"https://api.github.com/users/shenghu/events{/privacy}","received_events_url":"https://api.github.com/users/shenghu/received_events","type":"User","site_admin":false},"body":"Sometimes service is not the only service under a domain(hostname).\r\nThis work adds s3proxy.service-path to allow s3proxy to be deployed\r\nwith a context path. The issues resolved by adding service path are\r\n1) properly extract bucket and key, 2) properly validate signagure\r\nfor authentication, 3) properly validate signagure for presigend url.\r\nTest cases are changed to run when s3proxy.service-path is set.\r\nRight now the setting is commented out so that all tests without\r\nsetting it. We need figure out a way to enable it in tests.","created_at":"2016-11-29T15:49:46Z","updated_at":"2016-11-29T15:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e020a95cfe183f21b37c07781eef1a7c1587fd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175/commits","review_comments_url":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175/comments","review_comment_url":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andrewgaul/s3proxy/issues/175/comments","statuses_url":"https://api.github.com/repos/andrewgaul/s3proxy/statuses/51bee2f95f98f2bb0e5802f305ea52d05f6a779e","head":{"label":"shenghu:master","ref":"master","sha":"51bee2f95f98f2bb0e5802f305ea52d05f6a779e","user":{"login":"shenghu","id":9978192,"avatar_url":"https://avatars.githubusercontent.com/u/9978192?v=3","gravatar_id":"","url":"https://api.github.com/users/shenghu","html_url":"https://github.com/shenghu","followers_url":"https://api.github.com/users/shenghu/followers","following_url":"https://api.github.com/users/shenghu/following{/other_user}","gists_url":"https://api.github.com/users/shenghu/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghu/subscriptions","organizations_url":"https://api.github.com/users/shenghu/orgs","repos_url":"https://api.github.com/users/shenghu/repos","events_url":"https://api.github.com/users/shenghu/events{/privacy}","received_events_url":"https://api.github.com/users/shenghu/received_events","type":"User","site_admin":false},"repo":{"id":63235661,"name":"s3proxy","full_name":"shenghu/s3proxy","owner":{"login":"shenghu","id":9978192,"avatar_url":"https://avatars.githubusercontent.com/u/9978192?v=3","gravatar_id":"","url":"https://api.github.com/users/shenghu","html_url":"https://github.com/shenghu","followers_url":"https://api.github.com/users/shenghu/followers","following_url":"https://api.github.com/users/shenghu/following{/other_user}","gists_url":"https://api.github.com/users/shenghu/gists{/gist_id}","starred_url":"https://api.github.com/users/shenghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenghu/subscriptions","organizations_url":"https://api.github.com/users/shenghu/orgs","repos_url":"https://api.github.com/users/shenghu/repos","events_url":"https://api.github.com/users/shenghu/events{/privacy}","received_events_url":"https://api.github.com/users/shenghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shenghu/s3proxy","description":"Access other storage backends via the S3 API","fork":true,"url":"https://api.github.com/repos/shenghu/s3proxy","forks_url":"https://api.github.com/repos/shenghu/s3proxy/forks","keys_url":"https://api.github.com/repos/shenghu/s3proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shenghu/s3proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shenghu/s3proxy/teams","hooks_url":"https://api.github.com/repos/shenghu/s3proxy/hooks","issue_events_url":"https://api.github.com/repos/shenghu/s3proxy/issues/events{/number}","events_url":"https://api.github.com/repos/shenghu/s3proxy/events","assignees_url":"https://api.github.com/repos/shenghu/s3proxy/assignees{/user}","branches_url":"https://api.github.com/repos/shenghu/s3proxy/branches{/branch}","tags_url":"https://api.github.com/repos/shenghu/s3proxy/tags","blobs_url":"https://api.github.com/repos/shenghu/s3proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shenghu/s3proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shenghu/s3proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/shenghu/s3proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shenghu/s3proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/shenghu/s3proxy/languages","stargazers_url":"https://api.github.com/repos/shenghu/s3proxy/stargazers","contributors_url":"https://api.github.com/repos/shenghu/s3proxy/contributors","subscribers_url":"https://api.github.com/repos/shenghu/s3proxy/subscribers","subscription_url":"https://api.github.com/repos/shenghu/s3proxy/subscription","commits_url":"https://api.github.com/repos/shenghu/s3proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/shenghu/s3proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/shenghu/s3proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/shenghu/s3proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/shenghu/s3proxy/contents/{+path}","compare_url":"https://api.github.com/repos/shenghu/s3proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shenghu/s3proxy/merges","archive_url":"https://api.github.com/repos/shenghu/s3proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shenghu/s3proxy/downloads","issues_url":"https://api.github.com/repos/shenghu/s3proxy/issues{/number}","pulls_url":"https://api.github.com/repos/shenghu/s3proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/shenghu/s3proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/shenghu/s3proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shenghu/s3proxy/labels{/name}","releases_url":"https://api.github.com/repos/shenghu/s3proxy/releases{/id}","deployments_url":"https://api.github.com/repos/shenghu/s3proxy/deployments","created_at":"2016-07-13T10:04:41Z","updated_at":"2016-07-13T10:04:42Z","pushed_at":"2016-11-29T15:32:46Z","git_url":"git://github.com/shenghu/s3proxy.git","ssh_url":"git@github.com:shenghu/s3proxy.git","clone_url":"https://github.com/shenghu/s3proxy.git","svn_url":"https://github.com/shenghu/s3proxy","homepage":"","size":1011,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andrewgaul:master","ref":"master","sha":"8052e67eac0b1e4cc44676da405a57e04d26e42a","user":{"login":"andrewgaul","id":848247,"avatar_url":"https://avatars.githubusercontent.com/u/848247?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewgaul","html_url":"https://github.com/andrewgaul","followers_url":"https://api.github.com/users/andrewgaul/followers","following_url":"https://api.github.com/users/andrewgaul/following{/other_user}","gists_url":"https://api.github.com/users/andrewgaul/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewgaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewgaul/subscriptions","organizations_url":"https://api.github.com/users/andrewgaul/orgs","repos_url":"https://api.github.com/users/andrewgaul/repos","events_url":"https://api.github.com/users/andrewgaul/events{/privacy}","received_events_url":"https://api.github.com/users/andrewgaul/received_events","type":"User","site_admin":false},"repo":{"id":22321368,"name":"s3proxy","full_name":"andrewgaul/s3proxy","owner":{"login":"andrewgaul","id":848247,"avatar_url":"https://avatars.githubusercontent.com/u/848247?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewgaul","html_url":"https://github.com/andrewgaul","followers_url":"https://api.github.com/users/andrewgaul/followers","following_url":"https://api.github.com/users/andrewgaul/following{/other_user}","gists_url":"https://api.github.com/users/andrewgaul/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewgaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewgaul/subscriptions","organizations_url":"https://api.github.com/users/andrewgaul/orgs","repos_url":"https://api.github.com/users/andrewgaul/repos","events_url":"https://api.github.com/users/andrewgaul/events{/privacy}","received_events_url":"https://api.github.com/users/andrewgaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewgaul/s3proxy","description":"Access other storage backends via the S3 API","fork":false,"url":"https://api.github.com/repos/andrewgaul/s3proxy","forks_url":"https://api.github.com/repos/andrewgaul/s3proxy/forks","keys_url":"https://api.github.com/repos/andrewgaul/s3proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewgaul/s3proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewgaul/s3proxy/teams","hooks_url":"https://api.github.com/repos/andrewgaul/s3proxy/hooks","issue_events_url":"https://api.github.com/repos/andrewgaul/s3proxy/issues/events{/number}","events_url":"https://api.github.com/repos/andrewgaul/s3proxy/events","assignees_url":"https://api.github.com/repos/andrewgaul/s3proxy/assignees{/user}","branches_url":"https://api.github.com/repos/andrewgaul/s3proxy/branches{/branch}","tags_url":"https://api.github.com/repos/andrewgaul/s3proxy/tags","blobs_url":"https://api.github.com/repos/andrewgaul/s3proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewgaul/s3proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewgaul/s3proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewgaul/s3proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewgaul/s3proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewgaul/s3proxy/languages","stargazers_url":"https://api.github.com/repos/andrewgaul/s3proxy/stargazers","contributors_url":"https://api.github.com/repos/andrewgaul/s3proxy/contributors","subscribers_url":"https://api.github.com/repos/andrewgaul/s3proxy/subscribers","subscription_url":"https://api.github.com/repos/andrewgaul/s3proxy/subscription","commits_url":"https://api.github.com/repos/andrewgaul/s3proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewgaul/s3proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewgaul/s3proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewgaul/s3proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewgaul/s3proxy/contents/{+path}","compare_url":"https://api.github.com/repos/andrewgaul/s3proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewgaul/s3proxy/merges","archive_url":"https://api.github.com/repos/andrewgaul/s3proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewgaul/s3proxy/downloads","issues_url":"https://api.github.com/repos/andrewgaul/s3proxy/issues{/number}","pulls_url":"https://api.github.com/repos/andrewgaul/s3proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewgaul/s3proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewgaul/s3proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewgaul/s3proxy/labels{/name}","releases_url":"https://api.github.com/repos/andrewgaul/s3proxy/releases{/id}","deployments_url":"https://api.github.com/repos/andrewgaul/s3proxy/deployments","created_at":"2014-07-27T20:32:24Z","updated_at":"2016-11-24T05:23:19Z","pushed_at":"2016-11-29T15:49:46Z","git_url":"git://github.com/andrewgaul/s3proxy.git","ssh_url":"git@github.com:andrewgaul/s3proxy.git","clone_url":"https://github.com/andrewgaul/s3proxy.git","svn_url":"https://github.com/andrewgaul/s3proxy","homepage":"","size":1203,"stargazers_count":407,"watchers_count":407,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":31,"forks":42,"open_issues":31,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175"},"html":{"href":"https://github.com/andrewgaul/s3proxy/pull/175"},"issue":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/issues/175"},"comments":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/andrewgaul/s3proxy/statuses/51bee2f95f98f2bb0e5802f305ea52d05f6a779e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":113,"deletions":22,"changed_files":14}}
{"actor":{"display_login":"shenghu"}}