{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/comments/63070180","id":63070180,"diff_hunk":"@@ -17,26 +17,31 @@ parallel(longerTests: {\n     runTests(servers, 20)\n })\n \n-stage name: 'Staging', concurrency: 1\n-node {\n-    servers.deploy 'staging'\n-}\n+milestone ordinal: 1\n+lock (resource: 'staging-server', inversePrecedence: true) {\n+    stage name: 'Staging'\n+    node {\n+        servers.deploy 'staging'\n+    }\n \n-input message: \"Does ${jettyUrl}staging/ look good?\"\n-try {\n-    checkpoint('Before production')\n-} catch (NoSuchMethodError _) {\n-    echo 'Checkpoint feature available in CloudBees Jenkins Enterprise.'\n+    input message: \"Does ${jettyUrl}staging/ look good?\"\n+    try {\n+        checkpoint('Before production')\n+    } catch (NoSuchMethodError _) {\n+        echo 'Checkpoint feature available in CloudBees Jenkins Enterprise.'\n+    }\n }\n \n-stage name: 'Production', concurrency: 1\n-node {\n-    sh \"wget -O - -S ${jettyUrl}staging/\"\n-    echo 'Production server looks to be alive'\n-    servers.deploy 'production'\n-    echo \"Deployed to ${jettyUrl}production/\"\n+milestone()","path":"demo/repo/Jenkinsfile","position":30,"original_position":34,"commit_id":"80a65fb2353103ef2b8a017dfbd9a2d606c4aecc","original_commit_id":"de9dfeb0c167948e1f7a76a81a147f6e81325039","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":":ant: the demo should show explicit ordinals:\r\n\r\n```groovy\r\nmilestone 1\r\n// …\r\nmilestone 2\r\n```","created_at":"2016-05-12T18:16:51Z","updated_at":"2016-05-12T18:16:51Z","html_url":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3#discussion_r63070180","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/comments/63070180"},"html":{"href":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3#discussion_r63070180"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3","id":67000233,"html_url":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3","diff_url":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3.diff","patch_url":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/3","number":3,"state":"open","locked":false,"title":"Adding milestone and lock steps to the demo","user":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"body":"Downstream of https://github.com/jenkinsci/pipeline-milestone-step-plugin/pull/1 and https://github.com/jenkinsci/lockable-resources-plugin/pull/25\r\n\r\n@reviewbybees","created_at":"2016-04-19T11:13:43Z","updated_at":"2016-05-12T18:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"812b59f2909e16067e5e6c263d64b7678f29c4ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/3/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/statuses/80a65fb2353103ef2b8a017dfbd9a2d606c4aecc","head":{"label":"amuniz:milestone-and-lock-demo","ref":"milestone-and-lock-demo","sha":"80a65fb2353103ef2b8a017dfbd9a2d606c4aecc","user":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"repo":{"id":55685766,"name":"workflow-aggregator-plugin","full_name":"amuniz/workflow-aggregator-plugin","owner":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amuniz/workflow-aggregator-plugin","description":"","fork":true,"url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin","forks_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/forks","keys_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/teams","hooks_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/hooks","issue_events_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/events","assignees_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/tags","blobs_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/languages","stargazers_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/stargazers","contributors_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/contributors","subscribers_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/subscribers","subscription_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/subscription","commits_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/merges","archive_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/downloads","issues_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/labels{/name}","releases_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/amuniz/workflow-aggregator-plugin/deployments","created_at":"2016-04-07T10:30:04Z","updated_at":"2016-04-07T10:30:05Z","pushed_at":"2016-05-12T17:57:31Z","git_url":"git://github.com/amuniz/workflow-aggregator-plugin.git","ssh_url":"git@github.com:amuniz/workflow-aggregator-plugin.git","clone_url":"https://github.com/amuniz/workflow-aggregator-plugin.git","svn_url":"https://github.com/amuniz/workflow-aggregator-plugin","homepage":"","size":216,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"af97cc2013a9567a03f994752244fdd890bc91d5","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543660,"name":"workflow-aggregator-plugin","full_name":"jenkinsci/workflow-aggregator-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-aggregator-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/deployments","created_at":"2016-04-05T20:30:59Z","updated_at":"2016-05-12T13:27:29Z","pushed_at":"2016-05-12T17:57:31Z","git_url":"git://github.com/jenkinsci/workflow-aggregator-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-aggregator-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-aggregator-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-aggregator-plugin","homepage":"","size":215,"stargazers_count":16,"watchers_count":16,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3"},"html":{"href":"https://github.com/jenkinsci/workflow-aggregator-plugin/pull/3"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/3"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-aggregator-plugin/statuses/80a65fb2353103ef2b8a017dfbd9a2d606c4aecc"}}}}