{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/493","repository_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/493/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/493/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/493/events","html_url":"https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/493","id":170505266,"number":493,"title":"repos and version fixes","user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-10T20:01:04Z","updated_at":"2016-08-11T18:27:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/pulls/493","html_url":"https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/493","diff_url":"https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/493.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/493.patch"},"body":"**Note**: This is a pretty big changeset. I will get it passing automated tests, but I'd love code review, and would love for folks to do some more manual testing.\r\n\r\nThis is some basic cleanup, and to drop support for installing brute force based on hard-coded version (i.e., only support using the official RabbitMQ packages via the packagecloud repo (for RHEL / CentOS), and continue supporting the Debian repo directly on the rabbitmq site).\r\n\r\nI'm not sure if having \r\n```\r\nclass rabbitmq::repo::apt(\r\n  $key_source   = 'https://www.rabbitmq.com/rabbitmq-release-signing-key.asc',\r\n) {\r\n  apt::source { 'rabbitmq':\r\n[...]\r\n    key_source   => $key_source,\r\n```\r\n(in `repo/apt.pp`, and the equivalent in `repo/rhel.pp`) is better than just using `$package_gpg_key` from the main scope; is there any reason not to do it that way?\r\n\r\nShould probably do a version bump for this, but thus far have not touched the CHANGELOG or the version in metdata.json. If this gets merged in, maybe someone in the modules team could do that?\r\n\r\nSLES support is untested, and may be broken now that we're not directly grabbing RPM for $version from the Rabbitmq site. Would appreciate suggestions / ideas about how to properly support this using the \r\n\r\nDropped Archlinux support.\r\nLeft in the OpenBSD stuff, which I believe should work without explicit version, but have not tested."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/comments/239248224","html_url":"https://github.com/puppetlabs/puppetlabs-rabbitmq/pull/493#issuecomment-239248224","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rabbitmq/issues/493","id":239248224,"user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T18:27:16Z","updated_at":"2016-08-11T18:27:16Z","body":"Hopefully SLES support would still work (just not in the case of $repos_ensure), since there is an available package: https://software.opensuse.org/package/rabbitmq-server"}}
{"actor":{"display_login":"wyardley"}}