{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/53565299","id":53565299,"diff_hunk":"@@ -498,13 +503,22 @@ function setupChannel(target, channel) {\n     });\n   });\n \n-  target.send = function(message, handle, callback) {\n+  target.send = function(message, handle, options, callback) {\n     if (typeof handle === 'function') {\n       callback = handle;\n       handle = undefined;\n+    } else if (typeof options === 'function') {\n+      callback = options;\n+    } else if (options !== undefined &&\n+               (options === null || typeof options !== 'object')) {\n+      throw new TypeError('\"options\" argument must be an object');\n     }\n+\n+    options = options || {};\n+    options.swallowErrors = false;","path":"lib/internal/child_process.js","position":104,"original_position":104,"commit_id":"c3c9dd05db2c2f3fd4e7f4479e5911f3fe149e21","original_commit_id":"c3c9dd05db2c2f3fd4e7f4479e5911f3fe149e21","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"This modifies the options object that the user passes in.","created_at":"2016-02-21T11:27:21Z","updated_at":"2016-02-21T11:27:21Z","html_url":"https://github.com/nodejs/node/pull/5283#discussion_r53565299","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/5283","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/53565299"},"html":{"href":"https://github.com/nodejs/node/pull/5283#discussion_r53565299"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/5283"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5283","id":59662468,"html_url":"https://github.com/nodejs/node/pull/5283","diff_url":"https://github.com/nodejs/node/pull/5283.diff","patch_url":"https://github.com/nodejs/node/pull/5283.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5283","number":5283,"state":"open","locked":false,"title":"Allow options to be provided to child_process.send()","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"This PR adds an `options` argument to `child_process.send()` and `process.send()`. The second commit adds a `keepOpen` option that allows `net.Socket` instances to be kept open in multiple processes.\r\n\r\nOne limitation of the current implementation is that the new `options` argument can only be specified if the optional `sendHandle` argument is also provided. It's an unfortunate side effect of allowing multiple optional arguments of the same data type consecutively in function arguments. It can be worked around by duplicating code in `_send()`, but I'd rather save that for a semver-major change.\r\n\r\nCloses #4271","created_at":"2016-02-17T15:44:29Z","updated_at":"2016-02-21T11:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e980dc33a3b95b1d16db9094d8eaec0850326a69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5283/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5283/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5283/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c3c9dd05db2c2f3fd4e7f4479e5911f3fe149e21","head":{"label":"cjihrig:send-opts","ref":"send-opts","sha":"c3c9dd05db2c2f3fd4e7f4479e5911f3fe149e21","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"repo":{"id":40613511,"name":"node-1","full_name":"cjihrig/node-1","owner":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjihrig/node-1","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/cjihrig/node-1","forks_url":"https://api.github.com/repos/cjihrig/node-1/forks","keys_url":"https://api.github.com/repos/cjihrig/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjihrig/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjihrig/node-1/teams","hooks_url":"https://api.github.com/repos/cjihrig/node-1/hooks","issue_events_url":"https://api.github.com/repos/cjihrig/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/cjihrig/node-1/events","assignees_url":"https://api.github.com/repos/cjihrig/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/cjihrig/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/cjihrig/node-1/tags","blobs_url":"https://api.github.com/repos/cjihrig/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjihrig/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjihrig/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjihrig/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjihrig/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/cjihrig/node-1/languages","stargazers_url":"https://api.github.com/repos/cjihrig/node-1/stargazers","contributors_url":"https://api.github.com/repos/cjihrig/node-1/contributors","subscribers_url":"https://api.github.com/repos/cjihrig/node-1/subscribers","subscription_url":"https://api.github.com/repos/cjihrig/node-1/subscription","commits_url":"https://api.github.com/repos/cjihrig/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjihrig/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjihrig/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjihrig/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjihrig/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/cjihrig/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjihrig/node-1/merges","archive_url":"https://api.github.com/repos/cjihrig/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjihrig/node-1/downloads","issues_url":"https://api.github.com/repos/cjihrig/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/cjihrig/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/cjihrig/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/cjihrig/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjihrig/node-1/labels{/name}","releases_url":"https://api.github.com/repos/cjihrig/node-1/releases{/id}","deployments_url":"https://api.github.com/repos/cjihrig/node-1/deployments","created_at":"2015-08-12T17:07:21Z","updated_at":"2015-08-12T17:07:25Z","pushed_at":"2016-02-17T17:21:56Z","git_url":"git://github.com/cjihrig/node-1.git","ssh_url":"git@github.com:cjihrig/node-1.git","clone_url":"https://github.com/cjihrig/node-1.git","svn_url":"https://github.com/cjihrig/node-1","homepage":"https://iojs.org","size":172175,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"7550160e2b93888328c9a3b1fb12bfd052bbf137","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-02-21T05:55:57Z","pushed_at":"2016-02-21T11:24:14Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":215624,"stargazers_count":20376,"watchers_count":20376,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2530,"mirror_url":null,"open_issues_count":740,"forks":2530,"open_issues":740,"watchers":20376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5283"},"html":{"href":"https://github.com/nodejs/node/pull/5283"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5283"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5283/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5283/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5283/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c3c9dd05db2c2f3fd4e7f4479e5911f3fe149e21"}}}}