{"action":"created","comment":{"url":"https://api.github.com/repos/bmcage/odes/pulls/comments/85487570","pull_request_review_id":6200985,"id":85487570,"diff_hunk":"@@ -257,15 +264,15 @@ cdef int _jacdense(long int Neq, realtype tt,\n         jac_tmp = aux_data.jac_tmp\n \n         nv_s2ndarray(yy, yy_tmp)\n-    aux_data.jac.evaluate(tt, yy_tmp, jac_tmp)\n+    user_flag = aux_data.jac.evaluate(tt, yy_tmp, jac_tmp)\n \n     if parallel_implementation:\n         raise NotImplemented\n     else:\n         #we convert the python jac_tmp array to DslMat of sundials\n         ndarray2DlsMatd(Jac, jac_tmp)\n \n-    return 0\n+    return user_flag","path":"scikits/odes/sundials/cvode.pyx","position":146,"original_position":146,"commit_id":"1caec94452b5719d5ec0cc45a9d6074b79aab59a","original_commit_id":"1caec94452b5719d5ec0cc45a9d6074b79aab59a","user":{"login":"bmcage","id":1011414,"avatar_url":"https://avatars.githubusercontent.com/u/1011414?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcage","html_url":"https://github.com/bmcage","followers_url":"https://api.github.com/users/bmcage/followers","following_url":"https://api.github.com/users/bmcage/following{/other_user}","gists_url":"https://api.github.com/users/bmcage/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcage/subscriptions","organizations_url":"https://api.github.com/users/bmcage/orgs","repos_url":"https://api.github.com/users/bmcage/repos","events_url":"https://api.github.com/users/bmcage/events{/privacy}","received_events_url":"https://api.github.com/users/bmcage/received_events","type":"User","site_admin":false},"body":"In order not to test too much on None, and leave code as is, perhaps in the generic classes, only update the documentation of them?\r\nFor example\r\n``` \r\n# Jacobian function\r\ncdef class CV_JacRhsFunction:\r\n    cpdef int evaluate(self, DTYPE_t t,\r\n                       np.ndarray[DTYPE_t, ndim=1] y,\r\n                       np.ndarray J) except? -1:\r\n        \"\"\"\r\n        Returns the Jacobi matrix of the right hand side function, as\r\n            d(rhs)/d y\r\n        (for dense the full matrix, for band only bands). Result has to be\r\n        stored in the variable J, which is preallocated to the corresponding\r\n        size.\r\n\r\n        This is a generic class, you should subclass is for the problem specific\r\n        purposes.\"\r\n        \"\"\"\r\n        return 0\r\n```\r\nto add that evaluate must return 0 on success, and -1 can be used to interrupt the solver.","created_at":"2016-10-28T08:05:20Z","updated_at":"2016-10-28T08:05:20Z","html_url":"https://github.com/bmcage/odes/pull/36#discussion_r85487570","pull_request_url":"https://api.github.com/repos/bmcage/odes/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/bmcage/odes/pulls/comments/85487570"},"html":{"href":"https://github.com/bmcage/odes/pull/36#discussion_r85487570"},"pull_request":{"href":"https://api.github.com/repos/bmcage/odes/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/bmcage/odes/pulls/36","id":89477911,"html_url":"https://github.com/bmcage/odes/pull/36","diff_url":"https://github.com/bmcage/odes/pull/36.diff","patch_url":"https://github.com/bmcage/odes/pull/36.patch","issue_url":"https://api.github.com/repos/bmcage/odes/issues/36","number":36,"state":"open","locked":false,"title":"Add support for return values from user provided functions.","user":{"login":"aragilar","id":1281144,"avatar_url":"https://avatars.githubusercontent.com/u/1281144?v=3","gravatar_id":"","url":"https://api.github.com/users/aragilar","html_url":"https://github.com/aragilar","followers_url":"https://api.github.com/users/aragilar/followers","following_url":"https://api.github.com/users/aragilar/following{/other_user}","gists_url":"https://api.github.com/users/aragilar/gists{/gist_id}","starred_url":"https://api.github.com/users/aragilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragilar/subscriptions","organizations_url":"https://api.github.com/users/aragilar/orgs","repos_url":"https://api.github.com/users/aragilar/repos","events_url":"https://api.github.com/users/aragilar/events{/privacy}","received_events_url":"https://api.github.com/users/aragilar/received_events","type":"User","site_admin":false},"body":"This replaces #27 and #26. New tests are added. The only thing not tested is the preconditioning code, as I'm not entirely sure what a simple example is in that case. I'll try to add some tests once I spend some time understanding the preconditioning code.","created_at":"2016-10-15T01:57:10Z","updated_at":"2016-10-28T08:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d789fe5e1a67b486eb1fbcb1a80c5aa5f4934edb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bmcage/odes/pulls/36/commits","review_comments_url":"https://api.github.com/repos/bmcage/odes/pulls/36/comments","review_comment_url":"https://api.github.com/repos/bmcage/odes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bmcage/odes/issues/36/comments","statuses_url":"https://api.github.com/repos/bmcage/odes/statuses/1caec94452b5719d5ec0cc45a9d6074b79aab59a","head":{"label":"aragilar:fix_user_flag","ref":"fix_user_flag","sha":"1caec94452b5719d5ec0cc45a9d6074b79aab59a","user":{"login":"aragilar","id":1281144,"avatar_url":"https://avatars.githubusercontent.com/u/1281144?v=3","gravatar_id":"","url":"https://api.github.com/users/aragilar","html_url":"https://github.com/aragilar","followers_url":"https://api.github.com/users/aragilar/followers","following_url":"https://api.github.com/users/aragilar/following{/other_user}","gists_url":"https://api.github.com/users/aragilar/gists{/gist_id}","starred_url":"https://api.github.com/users/aragilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragilar/subscriptions","organizations_url":"https://api.github.com/users/aragilar/orgs","repos_url":"https://api.github.com/users/aragilar/repos","events_url":"https://api.github.com/users/aragilar/events{/privacy}","received_events_url":"https://api.github.com/users/aragilar/received_events","type":"User","site_admin":false},"repo":{"id":4805859,"name":"odes","full_name":"aragilar/odes","owner":{"login":"aragilar","id":1281144,"avatar_url":"https://avatars.githubusercontent.com/u/1281144?v=3","gravatar_id":"","url":"https://api.github.com/users/aragilar","html_url":"https://github.com/aragilar","followers_url":"https://api.github.com/users/aragilar/followers","following_url":"https://api.github.com/users/aragilar/following{/other_user}","gists_url":"https://api.github.com/users/aragilar/gists{/gist_id}","starred_url":"https://api.github.com/users/aragilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragilar/subscriptions","organizations_url":"https://api.github.com/users/aragilar/orgs","repos_url":"https://api.github.com/users/aragilar/repos","events_url":"https://api.github.com/users/aragilar/events{/privacy}","received_events_url":"https://api.github.com/users/aragilar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aragilar/odes","description":"git repo of the odes scikit for scipy","fork":true,"url":"https://api.github.com/repos/aragilar/odes","forks_url":"https://api.github.com/repos/aragilar/odes/forks","keys_url":"https://api.github.com/repos/aragilar/odes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragilar/odes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragilar/odes/teams","hooks_url":"https://api.github.com/repos/aragilar/odes/hooks","issue_events_url":"https://api.github.com/repos/aragilar/odes/issues/events{/number}","events_url":"https://api.github.com/repos/aragilar/odes/events","assignees_url":"https://api.github.com/repos/aragilar/odes/assignees{/user}","branches_url":"https://api.github.com/repos/aragilar/odes/branches{/branch}","tags_url":"https://api.github.com/repos/aragilar/odes/tags","blobs_url":"https://api.github.com/repos/aragilar/odes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragilar/odes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragilar/odes/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragilar/odes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragilar/odes/statuses/{sha}","languages_url":"https://api.github.com/repos/aragilar/odes/languages","stargazers_url":"https://api.github.com/repos/aragilar/odes/stargazers","contributors_url":"https://api.github.com/repos/aragilar/odes/contributors","subscribers_url":"https://api.github.com/repos/aragilar/odes/subscribers","subscription_url":"https://api.github.com/repos/aragilar/odes/subscription","commits_url":"https://api.github.com/repos/aragilar/odes/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragilar/odes/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragilar/odes/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragilar/odes/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragilar/odes/contents/{+path}","compare_url":"https://api.github.com/repos/aragilar/odes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragilar/odes/merges","archive_url":"https://api.github.com/repos/aragilar/odes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragilar/odes/downloads","issues_url":"https://api.github.com/repos/aragilar/odes/issues{/number}","pulls_url":"https://api.github.com/repos/aragilar/odes/pulls{/number}","milestones_url":"https://api.github.com/repos/aragilar/odes/milestones{/number}","notifications_url":"https://api.github.com/repos/aragilar/odes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragilar/odes/labels{/name}","releases_url":"https://api.github.com/repos/aragilar/odes/releases{/id}","deployments_url":"https://api.github.com/repos/aragilar/odes/deployments","created_at":"2012-06-27T08:16:24Z","updated_at":"2015-09-29T06:09:31Z","pushed_at":"2016-10-15T02:19:36Z","git_url":"git://github.com/aragilar/odes.git","ssh_url":"git@github.com:aragilar/odes.git","clone_url":"https://github.com/aragilar/odes.git","svn_url":"https://github.com/aragilar/odes","homepage":"http://cage.ugent.be/~bm/progs.html","size":3968,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bmcage:master","ref":"master","sha":"0e260a6c0a652fd2412ef4bab427953ad95cf51b","user":{"login":"bmcage","id":1011414,"avatar_url":"https://avatars.githubusercontent.com/u/1011414?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcage","html_url":"https://github.com/bmcage","followers_url":"https://api.github.com/users/bmcage/followers","following_url":"https://api.github.com/users/bmcage/following{/other_user}","gists_url":"https://api.github.com/users/bmcage/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcage/subscriptions","organizations_url":"https://api.github.com/users/bmcage/orgs","repos_url":"https://api.github.com/users/bmcage/repos","events_url":"https://api.github.com/users/bmcage/events{/privacy}","received_events_url":"https://api.github.com/users/bmcage/received_events","type":"User","site_admin":false},"repo":{"id":2301629,"name":"odes","full_name":"bmcage/odes","owner":{"login":"bmcage","id":1011414,"avatar_url":"https://avatars.githubusercontent.com/u/1011414?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcage","html_url":"https://github.com/bmcage","followers_url":"https://api.github.com/users/bmcage/followers","following_url":"https://api.github.com/users/bmcage/following{/other_user}","gists_url":"https://api.github.com/users/bmcage/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcage/subscriptions","organizations_url":"https://api.github.com/users/bmcage/orgs","repos_url":"https://api.github.com/users/bmcage/repos","events_url":"https://api.github.com/users/bmcage/events{/privacy}","received_events_url":"https://api.github.com/users/bmcage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmcage/odes","description":"git repo of the odes scikit for scipy","fork":false,"url":"https://api.github.com/repos/bmcage/odes","forks_url":"https://api.github.com/repos/bmcage/odes/forks","keys_url":"https://api.github.com/repos/bmcage/odes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmcage/odes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmcage/odes/teams","hooks_url":"https://api.github.com/repos/bmcage/odes/hooks","issue_events_url":"https://api.github.com/repos/bmcage/odes/issues/events{/number}","events_url":"https://api.github.com/repos/bmcage/odes/events","assignees_url":"https://api.github.com/repos/bmcage/odes/assignees{/user}","branches_url":"https://api.github.com/repos/bmcage/odes/branches{/branch}","tags_url":"https://api.github.com/repos/bmcage/odes/tags","blobs_url":"https://api.github.com/repos/bmcage/odes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmcage/odes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmcage/odes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmcage/odes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmcage/odes/statuses/{sha}","languages_url":"https://api.github.com/repos/bmcage/odes/languages","stargazers_url":"https://api.github.com/repos/bmcage/odes/stargazers","contributors_url":"https://api.github.com/repos/bmcage/odes/contributors","subscribers_url":"https://api.github.com/repos/bmcage/odes/subscribers","subscription_url":"https://api.github.com/repos/bmcage/odes/subscription","commits_url":"https://api.github.com/repos/bmcage/odes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmcage/odes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmcage/odes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmcage/odes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmcage/odes/contents/{+path}","compare_url":"https://api.github.com/repos/bmcage/odes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmcage/odes/merges","archive_url":"https://api.github.com/repos/bmcage/odes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmcage/odes/downloads","issues_url":"https://api.github.com/repos/bmcage/odes/issues{/number}","pulls_url":"https://api.github.com/repos/bmcage/odes/pulls{/number}","milestones_url":"https://api.github.com/repos/bmcage/odes/milestones{/number}","notifications_url":"https://api.github.com/repos/bmcage/odes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmcage/odes/labels{/name}","releases_url":"https://api.github.com/repos/bmcage/odes/releases{/id}","deployments_url":"https://api.github.com/repos/bmcage/odes/deployments","created_at":"2011-08-31T13:22:36Z","updated_at":"2016-10-25T16:08:07Z","pushed_at":"2016-10-15T01:57:10Z","git_url":"git://github.com/bmcage/odes.git","ssh_url":"git@github.com:bmcage/odes.git","clone_url":"https://github.com/bmcage/odes.git","svn_url":"https://github.com/bmcage/odes","homepage":"https://github.com/bmcage/odes","size":4024,"stargazers_count":32,"watchers_count":32,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bmcage/odes/pulls/36"},"html":{"href":"https://github.com/bmcage/odes/pull/36"},"issue":{"href":"https://api.github.com/repos/bmcage/odes/issues/36"},"comments":{"href":"https://api.github.com/repos/bmcage/odes/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/bmcage/odes/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/bmcage/odes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bmcage/odes/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/bmcage/odes/statuses/1caec94452b5719d5ec0cc45a9d6074b79aab59a"}}}}
{"actor":{"display_login":"bmcage"}}