{"action":"created","comment":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments/92402041","pull_request_review_id":12915852,"id":92402041,"diff_hunk":"@@ -77,7 +84,27 @@ public void destroy() {\n     // Don't care I think\n   }\n \n-  protected void fireAndForgetMessage(Object message, ClientDescriptor ... clients) {\n-    target.fireAndForgetMessage(message, clients);\n+  protected void synchronizeKeyToPassive(int concurrencyKey) {\n+  }\n+\n+  protected <M> void fireMessage(Class<M> type, M message, boolean echo) {invoker.fireMessage(type, message, echo);}\n+\n+  protected <M> void fireMessage(Class<M> type, M message, ClientDescriptor[] clients) {invoker.fireMessage(type, message, clients);}","path":"voltron-proxy/voltron-proxy-server/src/main/java/org/terracotta/voltron/proxy/server/ActiveProxiedServerEntity.java","position":84,"original_position":84,"commit_id":"08acdbeed239212d56edc7e593d9db2fef54527b","original_commit_id":"08acdbeed239212d56edc7e593d9db2fef54527b","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"body":"we have to leave them. it's public api. it allows an entity to fire message to specific clients or all clients. we are using one of the methods in the sample. feature was already there before.","created_at":"2016-12-14T14:24:13Z","updated_at":"2016-12-14T14:24:13Z","html_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229#discussion_r92402041","pull_request_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments/92402041"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229#discussion_r92402041"},"pull_request":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229","id":97399647,"html_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229","diff_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229.diff","patch_url":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229.patch","issue_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/229","number":229,"state":"open","locked":false,"title":"Close #162: Passive entities for management","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"body":"- Add passive entities for M&M\r\n- Add concurrency strategy support in voltron-proxy\r\n- Add execution strategy support in voltron-proxy\r\n- Add passive support in voltron-proxy\r\n- Add sync support in voltron-proxy\r\n- Add passive entities for test sample\r\n- Added more tests","created_at":"2016-12-09T23:41:25Z","updated_at":"2016-12-14T14:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c4289c2a5f5763ca44db260b1679613c0aee99","assignee":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"assignees":[{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/milestones/8","html_url":"https://github.com/Terracotta-OSS/terracotta-platform/milestone/8","labels_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/milestones/8/labels","id":2095544,"number":8,"title":"BF-4939","description":"","creator":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":8,"state":"open","created_at":"2016-10-26T18:14:35Z","updated_at":"2016-12-09T23:41:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229/commits","review_comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229/comments","review_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/229/comments","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/08acdbeed239212d56edc7e593d9db2fef54527b","head":{"label":"mathieucarbou:issue-162","ref":"issue-162","sha":"08acdbeed239212d56edc7e593d9db2fef54527b","user":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"repo":{"id":44820939,"name":"terracotta-platform","full_name":"mathieucarbou/terracotta-platform","owner":{"login":"mathieucarbou","id":61346,"avatar_url":"https://avatars.githubusercontent.com/u/61346?v=3","gravatar_id":"","url":"https://api.github.com/users/mathieucarbou","html_url":"https://github.com/mathieucarbou","followers_url":"https://api.github.com/users/mathieucarbou/followers","following_url":"https://api.github.com/users/mathieucarbou/following{/other_user}","gists_url":"https://api.github.com/users/mathieucarbou/gists{/gist_id}","starred_url":"https://api.github.com/users/mathieucarbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathieucarbou/subscriptions","organizations_url":"https://api.github.com/users/mathieucarbou/orgs","repos_url":"https://api.github.com/users/mathieucarbou/repos","events_url":"https://api.github.com/users/mathieucarbou/events{/privacy}","received_events_url":"https://api.github.com/users/mathieucarbou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathieucarbou/terracotta-platform","description":null,"fork":true,"url":"https://api.github.com/repos/mathieucarbou/terracotta-platform","forks_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/forks","keys_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/teams","hooks_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/hooks","issue_events_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/events","assignees_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/tags","blobs_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/languages","stargazers_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/stargazers","contributors_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/contributors","subscribers_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/subscribers","subscription_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/subscription","commits_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/merges","archive_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/downloads","issues_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/labels{/name}","releases_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/mathieucarbou/terracotta-platform/deployments","created_at":"2015-10-23T15:17:29Z","updated_at":"2016-02-05T21:53:04Z","pushed_at":"2016-12-14T00:50:19Z","git_url":"git://github.com/mathieucarbou/terracotta-platform.git","ssh_url":"git@github.com:mathieucarbou/terracotta-platform.git","clone_url":"https://github.com/mathieucarbou/terracotta-platform.git","svn_url":"https://github.com/mathieucarbou/terracotta-platform","homepage":null,"size":1800,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Terracotta-OSS:master","ref":"master","sha":"945bc7c92877e0f45091c1ca25c5e69b0830b7e0","user":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"repo":{"id":44253742,"name":"terracotta-platform","full_name":"Terracotta-OSS/terracotta-platform","owner":{"login":"Terracotta-OSS","id":4680389,"avatar_url":"https://avatars.githubusercontent.com/u/4680389?v=3","gravatar_id":"","url":"https://api.github.com/users/Terracotta-OSS","html_url":"https://github.com/Terracotta-OSS","followers_url":"https://api.github.com/users/Terracotta-OSS/followers","following_url":"https://api.github.com/users/Terracotta-OSS/following{/other_user}","gists_url":"https://api.github.com/users/Terracotta-OSS/gists{/gist_id}","starred_url":"https://api.github.com/users/Terracotta-OSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terracotta-OSS/subscriptions","organizations_url":"https://api.github.com/users/Terracotta-OSS/orgs","repos_url":"https://api.github.com/users/Terracotta-OSS/repos","events_url":"https://api.github.com/users/Terracotta-OSS/events{/privacy}","received_events_url":"https://api.github.com/users/Terracotta-OSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Terracotta-OSS/terracotta-platform","description":null,"fork":false,"url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform","forks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/forks","keys_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/teams","hooks_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/hooks","issue_events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/events","assignees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/tags","blobs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/languages","stargazers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/stargazers","contributors_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/contributors","subscribers_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/subscribers","subscription_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/subscription","commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/merges","archive_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/downloads","issues_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/labels{/name}","releases_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/deployments","created_at":"2015-10-14T14:37:13Z","updated_at":"2016-10-24T17:32:10Z","pushed_at":"2016-12-14T00:55:42Z","git_url":"git://github.com/Terracotta-OSS/terracotta-platform.git","ssh_url":"git@github.com:Terracotta-OSS/terracotta-platform.git","clone_url":"https://github.com/Terracotta-OSS/terracotta-platform.git","svn_url":"https://github.com/Terracotta-OSS/terracotta-platform","homepage":"http://terracotta.org","size":2077,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":17,"forks":17,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229"},"html":{"href":"https://github.com/Terracotta-OSS/terracotta-platform/pull/229"},"issue":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/229"},"comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/Terracotta-OSS/terracotta-platform/statuses/08acdbeed239212d56edc7e593d9db2fef54527b"}}}}
{"actor":{"display_login":"mathieucarbou"}}