{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/12628","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/12628/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/12628/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/12628/events","html_url":"https://github.com/Microsoft/vscode/pull/12628","id":179213062,"number":12628,"title":"Inline the toolbar for macOS","user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/vscode/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"assignees":[{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false}],"milestone":null,"comments":38,"created_at":"2016-09-26T12:19:21Z","updated_at":"2016-10-11T08:40:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/12628","html_url":"https://github.com/Microsoft/vscode/pull/12628","diff_url":"https://github.com/Microsoft/vscode/pull/12628.diff","patch_url":"https://github.com/Microsoft/vscode/pull/12628.patch"},"body":"Moves the traffic buttons on the window into the space above the activity bar on macOS - for full context see #12377 \r\n\r\n![screen shot 2016-09-26 at 13 20 52](https://cloud.githubusercontent.com/assets/49038/18834108/108b589a-83ec-11e6-8fc8-fce934f77718.png)\r\n\r\n![screen shot 2016-09-26 at 13 20 44](https://cloud.githubusercontent.com/assets/49038/18834111/12d9b768-83ec-11e6-938e-474563bae646.png)\r\n\r\n---\r\n\r\nTODO: \r\n\r\n - [x] Wrap up the config setting\r\n - [x] migrate all CSS to be scoped by `.use-inline-toolbar`\r\n\r\nfixes #12377 "},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/252848581","html_url":"https://github.com/Microsoft/vscode/pull/12628#issuecomment-252848581","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/12628","id":252848581,"user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T08:40:22Z","updated_at":"2016-10-11T08:40:22Z","body":"I've merged this back up to master, and cleaned up the abstractions ( thanks @bpasero ) \r\n\r\nI've not made the changes to the traffic lights, @joaomoreno if you're sure on wanting Slack style ones - I can do that. \r\n\r\nI've started looking, but not pushed anything about making the sidebar zoom level agnostic, will look at that again soon. \r\n\r\nDoes anyone have any feedback WRT adding drag handlers for the tab gutter actions? \r\n<img width=\"158\" alt=\"screen shot 2016-10-11 at 09 38 44\" src=\"https://cloud.githubusercontent.com/assets/49038/19263932/a0023394-8f96-11e6-8bcb-70947a183ca4.png\">\r\n\r\n\r\n- [ ] Zoom\r\n- [ ] Traffic Lights?\r\n- [ ] Drag handles?\r\n\r\n"}}
{"actor":{"display_login":"orta"}}