{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10947","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10947/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10947/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10947/events","html_url":"https://github.com/servo/servo/issues/10947","id":152049576,"number":10947,"title":"Node::scroll_area should check if the element is potentially scrollable","user":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/A-content/dom","name":"A-content/dom","color":"d7e102"},{"url":"https://api.github.com/repos/servo/servo/labels/C-assigned","name":"C-assigned","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-04-30T19:56:57Z","updated_at":"2016-06-09T20:09:59Z","closed_at":null,"body":"[`Node::scroll_area`](https://github.com/servo/servo/blob/master/components/script/dom/node.rs#L585-L615) should check if the element is [`potentially_scrollable`](https://github.com/servo/servo/blob/master/components/script/dom/element.rs#L179-184) for the second condition of [line 607](https://github.com/servo/servo/blob/master/components/script/dom/node.rs#L607)\r\n\r\nrelevant specs:\r\n[scrollWidth](https://drafts.csswg.org/cssom-view/#dom-element-scrollwidth): Step 5\r\n[scrollHeight](https://drafts.csswg.org/cssom-view/#dom-element-scrollheight): Step 5\r\n[scrollLeft](https://drafts.csswg.org/cssom-view/#dom-element-scrollleft): Step 7\r\n[scrollTop](https://drafts.csswg.org/cssom-view/#dom-element-scrolltop): Step 7\r\n[potentially scrollable](https://drafts.csswg.org/cssom-view/#potentially-scrollable)"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/225011533","html_url":"https://github.com/servo/servo/issues/10947#issuecomment-225011533","issue_url":"https://api.github.com/repos/servo/servo/issues/10947","id":225011533,"user":{"login":"broesamle","id":4546533,"avatar_url":"https://avatars.githubusercontent.com/u/4546533?v=3","gravatar_id":"","url":"https://api.github.com/users/broesamle","html_url":"https://github.com/broesamle","followers_url":"https://api.github.com/users/broesamle/followers","following_url":"https://api.github.com/users/broesamle/following{/other_user}","gists_url":"https://api.github.com/users/broesamle/gists{/gist_id}","starred_url":"https://api.github.com/users/broesamle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broesamle/subscriptions","organizations_url":"https://api.github.com/users/broesamle/orgs","repos_url":"https://api.github.com/users/broesamle/repos","events_url":"https://api.github.com/users/broesamle/events{/privacy}","received_events_url":"https://api.github.com/users/broesamle/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T20:09:59Z","updated_at":"2016-06-09T20:09:59Z","body":"during adding the additional condition I find that `potentially_scrollable` always returns true on the example HTML file, which in Firefox provokes the two different behaviours defined in the specs for `scrollHeight`.\r\n\r\nSince I now scrambled the logic gatters of my brain back and forth quite a few times I suggest making a PR for the test, review it and then continue on fixing the bug in the servo code. This would ensure that I do not co-evolve a double-negate test and error logic."}}
{"actor":{"display_login":"broesamle"}}