{"action":"created","comment":{"url":"https://api.github.com/repos/luvit/lit/pulls/comments/75589020","id":75589020,"diff_hunk":"@@ -197,7 +197,7 @@ local function loader(dir, path, bundleOnly)\n         return package.loaded[key]\n       end\n       local code = bundle.readfile(fullPath)\n-      local module = loadstring(code, key)()\n+      local module = loadstring(code, key)(key)","path":"luvit-loader.lua","position":14,"original_position":14,"commit_id":"4414144709e654ea791a4c83bf56236df8423c99","original_commit_id":"4414144709e654ea791a4c83bf56236df8423c99","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"body":"Looks like I was right--appending '@' to the path results in module not found errors when lit is built (when using the `bundle:` prefix, this command works fine):\r\n\r\n```\r\nlit version: 3.4.3\r\nluvi version: v2.7.4\r\ncommand: ls\r\nfail: C:\\Users\\Ryan\\Programming\\Luvit\\lit.exe\\deps\\git\\init.lua:2: module './core' not found:\r\n```\r\n\r\nMaking bundles use the '@' prefix will require some restructuring of how `luvit-loader` checks the caller and decides whether or not to set the `bundleOnly` flag.","created_at":"2016-08-21T05:04:33Z","updated_at":"2016-08-21T05:04:33Z","html_url":"https://github.com/luvit/lit/pull/191#discussion_r75589020","pull_request_url":"https://api.github.com/repos/luvit/lit/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/luvit/lit/pulls/comments/75589020"},"html":{"href":"https://github.com/luvit/lit/pull/191#discussion_r75589020"},"pull_request":{"href":"https://api.github.com/repos/luvit/lit/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/luvit/lit/pulls/191","id":81923445,"html_url":"https://github.com/luvit/lit/pull/191","diff_url":"https://github.com/luvit/lit/pull/191.diff","patch_url":"https://github.com/luvit/lit/pull/191.patch","issue_url":"https://api.github.com/repos/luvit/lit/issues/191","number":191,"state":"open","locked":false,"title":"Some luvit-loader fixes/improvements","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"body":"Fixes for some some issues I ran into while making [luver](https://github.com/squeek502/luver).\r\n\r\nLet me know if you'd like any more information about any of the changes or if you see a better way to handle any of these issues.","created_at":"2016-08-19T03:59:42Z","updated_at":"2016-08-21T05:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ded7f60bf5d12b842196896e33f4338849e0e98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/luvit/lit/pulls/191/commits","review_comments_url":"https://api.github.com/repos/luvit/lit/pulls/191/comments","review_comment_url":"https://api.github.com/repos/luvit/lit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luvit/lit/issues/191/comments","statuses_url":"https://api.github.com/repos/luvit/lit/statuses/4414144709e654ea791a4c83bf56236df8423c99","head":{"label":"squeek502:luvit-loader","ref":"luvit-loader","sha":"4414144709e654ea791a4c83bf56236df8423c99","user":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"repo":{"id":34750069,"name":"lit","full_name":"squeek502/lit","owner":{"login":"squeek502","id":2389051,"avatar_url":"https://avatars.githubusercontent.com/u/2389051?v=3","gravatar_id":"","url":"https://api.github.com/users/squeek502","html_url":"https://github.com/squeek502","followers_url":"https://api.github.com/users/squeek502/followers","following_url":"https://api.github.com/users/squeek502/following{/other_user}","gists_url":"https://api.github.com/users/squeek502/gists{/gist_id}","starred_url":"https://api.github.com/users/squeek502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeek502/subscriptions","organizations_url":"https://api.github.com/users/squeek502/orgs","repos_url":"https://api.github.com/users/squeek502/repos","events_url":"https://api.github.com/users/squeek502/events{/privacy}","received_events_url":"https://api.github.com/users/squeek502/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squeek502/lit","description":"Toolkit for developing, sharing, and running luvit/lua programs and libraries.","fork":true,"url":"https://api.github.com/repos/squeek502/lit","forks_url":"https://api.github.com/repos/squeek502/lit/forks","keys_url":"https://api.github.com/repos/squeek502/lit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squeek502/lit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squeek502/lit/teams","hooks_url":"https://api.github.com/repos/squeek502/lit/hooks","issue_events_url":"https://api.github.com/repos/squeek502/lit/issues/events{/number}","events_url":"https://api.github.com/repos/squeek502/lit/events","assignees_url":"https://api.github.com/repos/squeek502/lit/assignees{/user}","branches_url":"https://api.github.com/repos/squeek502/lit/branches{/branch}","tags_url":"https://api.github.com/repos/squeek502/lit/tags","blobs_url":"https://api.github.com/repos/squeek502/lit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squeek502/lit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squeek502/lit/git/refs{/sha}","trees_url":"https://api.github.com/repos/squeek502/lit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squeek502/lit/statuses/{sha}","languages_url":"https://api.github.com/repos/squeek502/lit/languages","stargazers_url":"https://api.github.com/repos/squeek502/lit/stargazers","contributors_url":"https://api.github.com/repos/squeek502/lit/contributors","subscribers_url":"https://api.github.com/repos/squeek502/lit/subscribers","subscription_url":"https://api.github.com/repos/squeek502/lit/subscription","commits_url":"https://api.github.com/repos/squeek502/lit/commits{/sha}","git_commits_url":"https://api.github.com/repos/squeek502/lit/git/commits{/sha}","comments_url":"https://api.github.com/repos/squeek502/lit/comments{/number}","issue_comment_url":"https://api.github.com/repos/squeek502/lit/issues/comments{/number}","contents_url":"https://api.github.com/repos/squeek502/lit/contents/{+path}","compare_url":"https://api.github.com/repos/squeek502/lit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squeek502/lit/merges","archive_url":"https://api.github.com/repos/squeek502/lit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squeek502/lit/downloads","issues_url":"https://api.github.com/repos/squeek502/lit/issues{/number}","pulls_url":"https://api.github.com/repos/squeek502/lit/pulls{/number}","milestones_url":"https://api.github.com/repos/squeek502/lit/milestones{/number}","notifications_url":"https://api.github.com/repos/squeek502/lit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squeek502/lit/labels{/name}","releases_url":"https://api.github.com/repos/squeek502/lit/releases{/id}","deployments_url":"https://api.github.com/repos/squeek502/lit/deployments","created_at":"2015-04-28T19:03:49Z","updated_at":"2016-06-24T10:15:31Z","pushed_at":"2016-08-19T03:54:16Z","git_url":"git://github.com/squeek502/lit.git","ssh_url":"git@github.com:squeek502/lit.git","clone_url":"https://github.com/squeek502/lit.git","svn_url":"https://github.com/squeek502/lit","homepage":"http://lit.luvit.io/","size":1081,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luvit:master","ref":"master","sha":"d80d38407a9234988f2d70d49275b6eead120f9b","user":{"login":"luvit","id":1202929,"avatar_url":"https://avatars.githubusercontent.com/u/1202929?v=3","gravatar_id":"","url":"https://api.github.com/users/luvit","html_url":"https://github.com/luvit","followers_url":"https://api.github.com/users/luvit/followers","following_url":"https://api.github.com/users/luvit/following{/other_user}","gists_url":"https://api.github.com/users/luvit/gists{/gist_id}","starred_url":"https://api.github.com/users/luvit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luvit/subscriptions","organizations_url":"https://api.github.com/users/luvit/orgs","repos_url":"https://api.github.com/users/luvit/repos","events_url":"https://api.github.com/users/luvit/events{/privacy}","received_events_url":"https://api.github.com/users/luvit/received_events","type":"Organization","site_admin":false},"repo":{"id":26977863,"name":"lit","full_name":"luvit/lit","owner":{"login":"luvit","id":1202929,"avatar_url":"https://avatars.githubusercontent.com/u/1202929?v=3","gravatar_id":"","url":"https://api.github.com/users/luvit","html_url":"https://github.com/luvit","followers_url":"https://api.github.com/users/luvit/followers","following_url":"https://api.github.com/users/luvit/following{/other_user}","gists_url":"https://api.github.com/users/luvit/gists{/gist_id}","starred_url":"https://api.github.com/users/luvit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luvit/subscriptions","organizations_url":"https://api.github.com/users/luvit/orgs","repos_url":"https://api.github.com/users/luvit/repos","events_url":"https://api.github.com/users/luvit/events{/privacy}","received_events_url":"https://api.github.com/users/luvit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luvit/lit","description":"Toolkit for developing, sharing, and running luvit/lua programs and libraries.","fork":false,"url":"https://api.github.com/repos/luvit/lit","forks_url":"https://api.github.com/repos/luvit/lit/forks","keys_url":"https://api.github.com/repos/luvit/lit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luvit/lit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luvit/lit/teams","hooks_url":"https://api.github.com/repos/luvit/lit/hooks","issue_events_url":"https://api.github.com/repos/luvit/lit/issues/events{/number}","events_url":"https://api.github.com/repos/luvit/lit/events","assignees_url":"https://api.github.com/repos/luvit/lit/assignees{/user}","branches_url":"https://api.github.com/repos/luvit/lit/branches{/branch}","tags_url":"https://api.github.com/repos/luvit/lit/tags","blobs_url":"https://api.github.com/repos/luvit/lit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luvit/lit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luvit/lit/git/refs{/sha}","trees_url":"https://api.github.com/repos/luvit/lit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luvit/lit/statuses/{sha}","languages_url":"https://api.github.com/repos/luvit/lit/languages","stargazers_url":"https://api.github.com/repos/luvit/lit/stargazers","contributors_url":"https://api.github.com/repos/luvit/lit/contributors","subscribers_url":"https://api.github.com/repos/luvit/lit/subscribers","subscription_url":"https://api.github.com/repos/luvit/lit/subscription","commits_url":"https://api.github.com/repos/luvit/lit/commits{/sha}","git_commits_url":"https://api.github.com/repos/luvit/lit/git/commits{/sha}","comments_url":"https://api.github.com/repos/luvit/lit/comments{/number}","issue_comment_url":"https://api.github.com/repos/luvit/lit/issues/comments{/number}","contents_url":"https://api.github.com/repos/luvit/lit/contents/{+path}","compare_url":"https://api.github.com/repos/luvit/lit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luvit/lit/merges","archive_url":"https://api.github.com/repos/luvit/lit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luvit/lit/downloads","issues_url":"https://api.github.com/repos/luvit/lit/issues{/number}","pulls_url":"https://api.github.com/repos/luvit/lit/pulls{/number}","milestones_url":"https://api.github.com/repos/luvit/lit/milestones{/number}","notifications_url":"https://api.github.com/repos/luvit/lit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luvit/lit/labels{/name}","releases_url":"https://api.github.com/repos/luvit/lit/releases{/id}","deployments_url":"https://api.github.com/repos/luvit/lit/deployments","created_at":"2014-11-21T21:05:25Z","updated_at":"2016-08-14T16:48:20Z","pushed_at":"2016-08-19T03:59:42Z","git_url":"git://github.com/luvit/lit.git","ssh_url":"git@github.com:luvit/lit.git","clone_url":"https://github.com/luvit/lit.git","svn_url":"https://github.com/luvit/lit","homepage":"http://lit.luvit.io/","size":1399,"stargazers_count":83,"watchers_count":83,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":32,"forks":21,"open_issues":32,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luvit/lit/pulls/191"},"html":{"href":"https://github.com/luvit/lit/pull/191"},"issue":{"href":"https://api.github.com/repos/luvit/lit/issues/191"},"comments":{"href":"https://api.github.com/repos/luvit/lit/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/luvit/lit/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/luvit/lit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luvit/lit/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/luvit/lit/statuses/4414144709e654ea791a4c83bf56236df8423c99"}}}}
{"actor":{"display_login":"squeek502"}}