{"action":"created","issue":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1510","repository_url":"https://api.github.com/repos/rockstor/rockstor-core","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1510/labels{/name}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1510/comments","events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1510/events","html_url":"https://github.com/rockstor/rockstor-core/pull/1510","id":187528485,"number":1510,"title":"Issue#1503 migrating gevent socketio to python socketio","user":{"login":"MFlyer","id":17988902,"avatar_url":"https://avatars.githubusercontent.com/u/17988902?v=3","gravatar_id":"","url":"https://api.github.com/users/MFlyer","html_url":"https://github.com/MFlyer","followers_url":"https://api.github.com/users/MFlyer/followers","following_url":"https://api.github.com/users/MFlyer/following{/other_user}","gists_url":"https://api.github.com/users/MFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/MFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFlyer/subscriptions","organizations_url":"https://api.github.com/users/MFlyer/orgs","repos_url":"https://api.github.com/users/MFlyer/repos","events_url":"https://api.github.com/users/MFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/MFlyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-05T22:37:54Z","updated_at":"2016-11-15T04:05:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1510","html_url":"https://github.com/rockstor/rockstor-core/pull/1510","diff_url":"https://github.com/rockstor/rockstor-core/pull/1510.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1510.patch"},"body":"#1503 \r\nHi @schakrava,\r\nthis PR is ready for review / to be merged.\r\n\r\nHad some tests on every module using socketio (dashboard widgets, pincard, logs manager and services) and all seem fine, pls have some test again and confirm :)\r\n\r\nOther useful infos:\r\n- gevent now is 1.1.2\r\n- six now is 1.10.0\r\n- nginx now points to 127.0.0.1:8001 without /socket.io (python-socketio hasn't it)\r\n- socketio.namespace missing initialize()\r\n- emitting doesn't require namespace:event anymore (we just use it on key property to handle all functions), namespace auto in every func under a socketio.namespace class\r\n- For every @rockstor/developers pls read data_collector main() notes about naming conventions etc etc\r\n\r\nThis PR requires rockstor/rockstor-jslibs#9 to be merged (js libs update, socket io to latest 1.5.1 :smiley: )\r\n\r\nMirko"},"comment":{"url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments/260542041","html_url":"https://github.com/rockstor/rockstor-core/pull/1510#issuecomment-260542041","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1510","id":260542041,"user":{"login":"schakrava","id":1123552,"avatar_url":"https://avatars.githubusercontent.com/u/1123552?v=3","gravatar_id":"","url":"https://api.github.com/users/schakrava","html_url":"https://github.com/schakrava","followers_url":"https://api.github.com/users/schakrava/followers","following_url":"https://api.github.com/users/schakrava/following{/other_user}","gists_url":"https://api.github.com/users/schakrava/gists{/gist_id}","starred_url":"https://api.github.com/users/schakrava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schakrava/subscriptions","organizations_url":"https://api.github.com/users/schakrava/orgs","repos_url":"https://api.github.com/users/schakrava/repos","events_url":"https://api.github.com/users/schakrava/events{/privacy}","received_events_url":"https://api.github.com/users/schakrava/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T04:05:24Z","updated_at":"2016-11-15T04:05:24Z","body":"Nicely done @MFlyer . Removing gevent-socketio has been on my list for sometime now and I am glad you beat me to it. "}}
{"actor":{"display_login":"schakrava"}}