{"action":"created","comment":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments/88697213","pull_request_review_id":9265301,"id":88697213,"diff_hunk":"@@ -208,6 +216,11 @@ class C_Progress_display : public C_Progress\n     } // display_tic\n };\n \n+inline C_Progress& C_Progress::dummy()\n+{\n+  static C_Progress null;","path":"src/third_party/progress/progress.hpp","position":null,"original_position":99,"commit_id":"7003de0cadbfdb94173987b9b63677ca3e9f0707","original_commit_id":"1dd6091500a2a10f6bc4095eff0173f70572cfe8","user":{"login":"pmoulon","id":3235050,"avatar_url":"https://avatars.githubusercontent.com/u/3235050?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoulon","html_url":"https://github.com/pmoulon","followers_url":"https://api.github.com/users/pmoulon/followers","following_url":"https://api.github.com/users/pmoulon/following{/other_user}","gists_url":"https://api.github.com/users/pmoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoulon/subscriptions","organizations_url":"https://api.github.com/users/pmoulon/orgs","repos_url":"https://api.github.com/users/pmoulon/repos","events_url":"https://api.github.com/users/pmoulon/events{/privacy}","received_events_url":"https://api.github.com/users/pmoulon/received_events","type":"User","site_admin":false},"body":"Ok, thx for the info.\r\nI think it will be simpler to keep the static reference as you done it.\r\nI was just pointing you the call_once in order to let us know that there is new interesting C++11 feature to deal with singleton allocation in multithreaded context.","created_at":"2016-11-18T17:09:20Z","updated_at":"2016-11-18T17:09:20Z","html_url":"https://github.com/openMVG/openMVG/pull/674#discussion_r88697213","pull_request_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments/88697213"},"html":{"href":"https://github.com/openMVG/openMVG/pull/674#discussion_r88697213"},"pull_request":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/674","id":93179018,"html_url":"https://github.com/openMVG/openMVG/pull/674","diff_url":"https://github.com/openMVG/openMVG/pull/674.diff","patch_url":"https://github.com/openMVG/openMVG/pull/674.patch","issue_url":"https://api.github.com/repos/openMVG/openMVG/issues/674","number":674,"state":"open","locked":false,"title":"Added interface to pass abstract C_Progress& to some functions.","user":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"body":"The idea is that the caller decides how to display progress. Ideally the class C_Progress_Display should not be found in any library code, but only used in the command line tools. See main_computeMatches.\r\nI also added a function hasBeenCanceled(), which should be checked periodically during long operations.","created_at":"2016-11-10T16:04:58Z","updated_at":"2016-11-18T17:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f77cd5b3c08c912fac9ff1b65f64e6f42cbc0452","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674/commits","review_comments_url":"https://api.github.com/repos/openMVG/openMVG/pulls/674/comments","review_comment_url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openMVG/openMVG/issues/674/comments","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/7003de0cadbfdb94173987b9b63677ca3e9f0707","head":{"label":"bjornpiltz:develop","ref":"develop","sha":"7003de0cadbfdb94173987b9b63677ca3e9f0707","user":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"repo":{"id":73362696,"name":"openMVG","full_name":"bjornpiltz/openMVG","owner":{"login":"bjornpiltz","id":1873764,"avatar_url":"https://avatars.githubusercontent.com/u/1873764?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornpiltz","html_url":"https://github.com/bjornpiltz","followers_url":"https://api.github.com/users/bjornpiltz/followers","following_url":"https://api.github.com/users/bjornpiltz/following{/other_user}","gists_url":"https://api.github.com/users/bjornpiltz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornpiltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornpiltz/subscriptions","organizations_url":"https://api.github.com/users/bjornpiltz/orgs","repos_url":"https://api.github.com/users/bjornpiltz/repos","events_url":"https://api.github.com/users/bjornpiltz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornpiltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjornpiltz/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/bjornpiltz/openMVG","forks_url":"https://api.github.com/repos/bjornpiltz/openMVG/forks","keys_url":"https://api.github.com/repos/bjornpiltz/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjornpiltz/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjornpiltz/openMVG/teams","hooks_url":"https://api.github.com/repos/bjornpiltz/openMVG/hooks","issue_events_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/bjornpiltz/openMVG/events","assignees_url":"https://api.github.com/repos/bjornpiltz/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/bjornpiltz/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/bjornpiltz/openMVG/tags","blobs_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjornpiltz/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/bjornpiltz/openMVG/languages","stargazers_url":"https://api.github.com/repos/bjornpiltz/openMVG/stargazers","contributors_url":"https://api.github.com/repos/bjornpiltz/openMVG/contributors","subscribers_url":"https://api.github.com/repos/bjornpiltz/openMVG/subscribers","subscription_url":"https://api.github.com/repos/bjornpiltz/openMVG/subscription","commits_url":"https://api.github.com/repos/bjornpiltz/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjornpiltz/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjornpiltz/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjornpiltz/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/bjornpiltz/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjornpiltz/openMVG/merges","archive_url":"https://api.github.com/repos/bjornpiltz/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjornpiltz/openMVG/downloads","issues_url":"https://api.github.com/repos/bjornpiltz/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/bjornpiltz/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/bjornpiltz/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/bjornpiltz/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjornpiltz/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/bjornpiltz/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/bjornpiltz/openMVG/deployments","created_at":"2016-11-10T08:40:38Z","updated_at":"2016-11-10T08:40:41Z","pushed_at":"2016-11-18T16:57:55Z","git_url":"git://github.com/bjornpiltz/openMVG.git","ssh_url":"git@github.com:bjornpiltz/openMVG.git","clone_url":"https://github.com/bjornpiltz/openMVG.git","svn_url":"https://github.com/bjornpiltz/openMVG","homepage":"","size":23132,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openMVG:develop","ref":"develop","sha":"0e59a3aea5d554cca78c49cdd23604e1bb3e5f34","user":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"repo":{"id":8096326,"name":"openMVG","full_name":"openMVG/openMVG","owner":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openMVG/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/openMVG/openMVG","forks_url":"https://api.github.com/repos/openMVG/openMVG/forks","keys_url":"https://api.github.com/repos/openMVG/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openMVG/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openMVG/openMVG/teams","hooks_url":"https://api.github.com/repos/openMVG/openMVG/hooks","issue_events_url":"https://api.github.com/repos/openMVG/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/openMVG/openMVG/events","assignees_url":"https://api.github.com/repos/openMVG/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/openMVG/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/openMVG/openMVG/tags","blobs_url":"https://api.github.com/repos/openMVG/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openMVG/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openMVG/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/openMVG/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/openMVG/openMVG/languages","stargazers_url":"https://api.github.com/repos/openMVG/openMVG/stargazers","contributors_url":"https://api.github.com/repos/openMVG/openMVG/contributors","subscribers_url":"https://api.github.com/repos/openMVG/openMVG/subscribers","subscription_url":"https://api.github.com/repos/openMVG/openMVG/subscription","commits_url":"https://api.github.com/repos/openMVG/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/openMVG/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/openMVG/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/openMVG/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/openMVG/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/openMVG/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openMVG/openMVG/merges","archive_url":"https://api.github.com/repos/openMVG/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openMVG/openMVG/downloads","issues_url":"https://api.github.com/repos/openMVG/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/openMVG/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/openMVG/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/openMVG/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openMVG/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/openMVG/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/openMVG/openMVG/deployments","created_at":"2013-02-08T16:01:08Z","updated_at":"2016-11-18T14:15:54Z","pushed_at":"2016-11-18T16:57:57Z","git_url":"git://github.com/openMVG/openMVG.git","ssh_url":"git@github.com:openMVG/openMVG.git","clone_url":"https://github.com/openMVG/openMVG.git","svn_url":"https://github.com/openMVG/openMVG","homepage":"","size":27257,"stargazers_count":853,"watchers_count":853,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":413,"mirror_url":null,"open_issues_count":54,"forks":413,"open_issues":54,"watchers":853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674"},"html":{"href":"https://github.com/openMVG/openMVG/pull/674"},"issue":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/674"},"comments":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/openMVG/openMVG/statuses/7003de0cadbfdb94173987b9b63677ca3e9f0707"}}}}
{"actor":{"display_login":"pmoulon"}}