{"action":"created","comment":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/85424545","pull_request_review_id":6142948,"id":85424545,"diff_hunk":"@@ -0,0 +1,12 @@\n+class ConnectionCredentials(object):\n+    \"\"\"Connection Credentials for Workbooks and Datasources publish request.\n+\n+    Consider removing this object and other variables holding secrets\n+    as soon as poobible after use to avoid them hanging around in memory.","path":"tableauserverclient/models/connection_credentials.py","position":5,"original_position":5,"commit_id":"5f25ef992ad234656394ebff541a198b85dc684d","original_commit_id":"5f25ef992ad234656394ebff541a198b85dc684d","user":{"login":"t8y8","id":4370533,"avatar_url":"https://avatars.githubusercontent.com/u/4370533?v=3","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"body":"*possible*","created_at":"2016-10-27T20:49:00Z","updated_at":"2016-10-27T20:49:00Z","html_url":"https://github.com/tableau/server-client-python/pull/80#discussion_r85424545","pull_request_url":"https://api.github.com/repos/tableau/server-client-python/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments/85424545"},"html":{"href":"https://github.com/tableau/server-client-python/pull/80#discussion_r85424545"},"pull_request":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/tableau/server-client-python/pulls/80","id":91107192,"html_url":"https://github.com/tableau/server-client-python/pull/80","diff_url":"https://github.com/tableau/server-client-python/pull/80.diff","patch_url":"https://github.com/tableau/server-client-python/pull/80.patch","issue_url":"https://api.github.com/repos/tableau/server-client-python/issues/80","number":80,"state":"open","locked":false,"title":"Add connection credentials","user":{"login":"geordielad","id":1714622,"avatar_url":"https://avatars.githubusercontent.com/u/1714622?v=3","gravatar_id":"","url":"https://api.github.com/users/geordielad","html_url":"https://github.com/geordielad","followers_url":"https://api.github.com/users/geordielad/followers","following_url":"https://api.github.com/users/geordielad/following{/other_user}","gists_url":"https://api.github.com/users/geordielad/gists{/gist_id}","starred_url":"https://api.github.com/users/geordielad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geordielad/subscriptions","organizations_url":"https://api.github.com/users/geordielad/orgs","repos_url":"https://api.github.com/users/geordielad/repos","events_url":"https://api.github.com/users/geordielad/events{/privacy}","received_events_url":"https://api.github.com/users/geordielad/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-26T23:19:20Z","updated_at":"2016-10-27T20:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f634fd653fc735b5b575003618cb9da38b9cbf7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tableau/server-client-python/pulls/80/commits","review_comments_url":"https://api.github.com/repos/tableau/server-client-python/pulls/80/comments","review_comment_url":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tableau/server-client-python/issues/80/comments","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/5f25ef992ad234656394ebff541a198b85dc684d","head":{"label":"geordielad:Add-Connection-Credentials","ref":"Add-Connection-Credentials","sha":"5f25ef992ad234656394ebff541a198b85dc684d","user":{"login":"geordielad","id":1714622,"avatar_url":"https://avatars.githubusercontent.com/u/1714622?v=3","gravatar_id":"","url":"https://api.github.com/users/geordielad","html_url":"https://github.com/geordielad","followers_url":"https://api.github.com/users/geordielad/followers","following_url":"https://api.github.com/users/geordielad/following{/other_user}","gists_url":"https://api.github.com/users/geordielad/gists{/gist_id}","starred_url":"https://api.github.com/users/geordielad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geordielad/subscriptions","organizations_url":"https://api.github.com/users/geordielad/orgs","repos_url":"https://api.github.com/users/geordielad/repos","events_url":"https://api.github.com/users/geordielad/events{/privacy}","received_events_url":"https://api.github.com/users/geordielad/received_events","type":"User","site_admin":false},"repo":{"id":72051235,"name":"server-client-python","full_name":"geordielad/server-client-python","owner":{"login":"geordielad","id":1714622,"avatar_url":"https://avatars.githubusercontent.com/u/1714622?v=3","gravatar_id":"","url":"https://api.github.com/users/geordielad","html_url":"https://github.com/geordielad","followers_url":"https://api.github.com/users/geordielad/followers","following_url":"https://api.github.com/users/geordielad/following{/other_user}","gists_url":"https://api.github.com/users/geordielad/gists{/gist_id}","starred_url":"https://api.github.com/users/geordielad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geordielad/subscriptions","organizations_url":"https://api.github.com/users/geordielad/orgs","repos_url":"https://api.github.com/users/geordielad/repos","events_url":"https://api.github.com/users/geordielad/events{/privacy}","received_events_url":"https://api.github.com/users/geordielad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geordielad/server-client-python","description":"Python client library for Tableau Server","fork":true,"url":"https://api.github.com/repos/geordielad/server-client-python","forks_url":"https://api.github.com/repos/geordielad/server-client-python/forks","keys_url":"https://api.github.com/repos/geordielad/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geordielad/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geordielad/server-client-python/teams","hooks_url":"https://api.github.com/repos/geordielad/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/geordielad/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/geordielad/server-client-python/events","assignees_url":"https://api.github.com/repos/geordielad/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/geordielad/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/geordielad/server-client-python/tags","blobs_url":"https://api.github.com/repos/geordielad/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geordielad/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geordielad/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/geordielad/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geordielad/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/geordielad/server-client-python/languages","stargazers_url":"https://api.github.com/repos/geordielad/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/geordielad/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/geordielad/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/geordielad/server-client-python/subscription","commits_url":"https://api.github.com/repos/geordielad/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/geordielad/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/geordielad/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/geordielad/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/geordielad/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/geordielad/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geordielad/server-client-python/merges","archive_url":"https://api.github.com/repos/geordielad/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geordielad/server-client-python/downloads","issues_url":"https://api.github.com/repos/geordielad/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/geordielad/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/geordielad/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/geordielad/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geordielad/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/geordielad/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/geordielad/server-client-python/deployments","created_at":"2016-10-26T22:54:00Z","updated_at":"2016-10-26T22:54:01Z","pushed_at":"2016-10-27T20:42:10Z","git_url":"git://github.com/geordielad/server-client-python.git","ssh_url":"git@github.com:geordielad/server-client-python.git","clone_url":"https://github.com/geordielad/server-client-python.git","svn_url":"https://github.com/geordielad/server-client-python","homepage":null,"size":392,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tableau:development","ref":"development","sha":"e1f38a8a308ca36f26a21ce450f4a35d1dacfa22","user":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":62177327,"name":"server-client-python","full_name":"tableau/server-client-python","owner":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/server-client-python","description":"Python client library for Tableau Server","fork":false,"url":"https://api.github.com/repos/tableau/server-client-python","forks_url":"https://api.github.com/repos/tableau/server-client-python/forks","keys_url":"https://api.github.com/repos/tableau/server-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/server-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/server-client-python/teams","hooks_url":"https://api.github.com/repos/tableau/server-client-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/server-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/server-client-python/events","assignees_url":"https://api.github.com/repos/tableau/server-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/server-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/server-client-python/tags","blobs_url":"https://api.github.com/repos/tableau/server-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/server-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/server-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/server-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/server-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/server-client-python/languages","stargazers_url":"https://api.github.com/repos/tableau/server-client-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/server-client-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/server-client-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/server-client-python/subscription","commits_url":"https://api.github.com/repos/tableau/server-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/server-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/server-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/server-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/server-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/server-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/server-client-python/merges","archive_url":"https://api.github.com/repos/tableau/server-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/server-client-python/downloads","issues_url":"https://api.github.com/repos/tableau/server-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/server-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/server-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/server-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/server-client-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/server-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/server-client-python/deployments","created_at":"2016-06-28T22:05:32Z","updated_at":"2016-10-25T16:28:05Z","pushed_at":"2016-10-27T20:42:11Z","git_url":"git://github.com/tableau/server-client-python.git","ssh_url":"git@github.com:tableau/server-client-python.git","clone_url":"https://github.com/tableau/server-client-python.git","svn_url":"https://github.com/tableau/server-client-python","homepage":null,"size":451,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":24,"forks":5,"open_issues":24,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/80"},"html":{"href":"https://github.com/tableau/server-client-python/pull/80"},"issue":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/80"},"comments":{"href":"https://api.github.com/repos/tableau/server-client-python/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tableau/server-client-python/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/tableau/server-client-python/statuses/5f25ef992ad234656394ebff541a198b85dc684d"}}}}
{"actor":{"display_login":"t8y8"}}