{"action":"closed","issue":{"url":"https://api.github.com/repos/tripikad/trip2/issues/633","repository_url":"https://api.github.com/repos/tripikad/trip2","labels_url":"https://api.github.com/repos/tripikad/trip2/issues/633/labels{/name}","comments_url":"https://api.github.com/repos/tripikad/trip2/issues/633/comments","events_url":"https://api.github.com/repos/tripikad/trip2/issues/633/events","html_url":"https://github.com/tripikad/trip2/issues/633","id":140195796,"number":633,"title":"Remove hardcoded db passwords in provisioning","user":{"login":"kristjanjansen","id":241603,"avatar_url":"https://avatars.githubusercontent.com/u/241603?v=3","gravatar_id":"","url":"https://api.github.com/users/kristjanjansen","html_url":"https://github.com/kristjanjansen","followers_url":"https://api.github.com/users/kristjanjansen/followers","following_url":"https://api.github.com/users/kristjanjansen/following{/other_user}","gists_url":"https://api.github.com/users/kristjanjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjanjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjanjansen/subscriptions","organizations_url":"https://api.github.com/users/kristjanjansen/orgs","repos_url":"https://api.github.com/users/kristjanjansen/repos","events_url":"https://api.github.com/users/kristjanjansen/events{/privacy}","received_events_url":"https://api.github.com/users/kristjanjansen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tripikad/trip2/labels/security","name":"security","color":"bb0000"},{"url":"https://api.github.com/repos/tripikad/trip2/labels/server","name":"server","color":"444444"}],"state":"closed","locked":false,"assignee":{"login":"kristjanjansen","id":241603,"avatar_url":"https://avatars.githubusercontent.com/u/241603?v=3","gravatar_id":"","url":"https://api.github.com/users/kristjanjansen","html_url":"https://github.com/kristjanjansen","followers_url":"https://api.github.com/users/kristjanjansen/followers","following_url":"https://api.github.com/users/kristjanjansen/following{/other_user}","gists_url":"https://api.github.com/users/kristjanjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjanjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjanjansen/subscriptions","organizations_url":"https://api.github.com/users/kristjanjansen/orgs","repos_url":"https://api.github.com/users/kristjanjansen/repos","events_url":"https://api.github.com/users/kristjanjansen/events{/privacy}","received_events_url":"https://api.github.com/users/kristjanjansen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/tripikad/trip2/milestones/5","html_url":"https://github.com/tripikad/trip2/milestones/V1-critical","labels_url":"https://api.github.com/repos/tripikad/trip2/milestones/5/labels","id":1688775,"number":5,"title":"V1-critical","description":"","creator":{"login":"kristjanjansen","id":241603,"avatar_url":"https://avatars.githubusercontent.com/u/241603?v=3","gravatar_id":"","url":"https://api.github.com/users/kristjanjansen","html_url":"https://github.com/kristjanjansen","followers_url":"https://api.github.com/users/kristjanjansen/followers","following_url":"https://api.github.com/users/kristjanjansen/following{/other_user}","gists_url":"https://api.github.com/users/kristjanjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjanjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjanjansen/subscriptions","organizations_url":"https://api.github.com/users/kristjanjansen/orgs","repos_url":"https://api.github.com/users/kristjanjansen/repos","events_url":"https://api.github.com/users/kristjanjansen/events{/privacy}","received_events_url":"https://api.github.com/users/kristjanjansen/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":13,"state":"open","created_at":"2016-04-07T06:29:41Z","updated_at":"2016-04-26T19:36:58Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-03-11T14:24:09Z","updated_at":"2016-04-26T19:36:58Z","closed_at":"2016-04-26T19:36:58Z","body":"We currently hardcode 'secret' as password in provisioning. Get rid of it.\r\n\r\n1) Add ```db_password: secret``` to ```/example.settings.yml``` and ```/settings.yml```\r\n\r\n2) Add\r\n\r\n```ruby\r\n \"DB_PASSWORD\" => settings['db_password'] \r\n```\r\nto https://github.com/tripikad/trip2_vagrant/blob/master/Vagrantfile#L29\r\n\r\n3) Replace instances of ```secret``` with ```$DB_PASSWORD``` in ```/provision.sh```\r\n\r\n4) Test it\r\n"}}