{"action":"created","comment":{"url":"https://api.github.com/repos/tajo/react-portal/pulls/comments/77110689","id":77110689,"diff_hunk":"@@ -9,6 +9,27 @@ const KEYCODES = {\n \n export default class Portal extends React.Component {\n \n+  static defaultProps = {\n+    onOpen: () => {},\n+    onClose: () => {},\n+    onUpdate: () => {},\n+  };\n+\n+  static propTypes = {\n+    className: React.PropTypes.string,\n+    style: React.PropTypes.object,\n+    children: React.PropTypes.element.isRequired,\n+    target: React.PropTypes.instanceOf(window.HTMLElement),","path":"lib/portal.js","position":14,"original_position":14,"commit_id":"ffe9b4dee79b87c651edd9c6cee52db75d5b4bfe","original_commit_id":"ffe9b4dee79b87c651edd9c6cee52db75d5b4bfe","user":{"login":"helielson","id":1201847,"avatar_url":"https://avatars.githubusercontent.com/u/1201847?v=3","gravatar_id":"","url":"https://api.github.com/users/helielson","html_url":"https://github.com/helielson","followers_url":"https://api.github.com/users/helielson/followers","following_url":"https://api.github.com/users/helielson/following{/other_user}","gists_url":"https://api.github.com/users/helielson/gists{/gist_id}","starred_url":"https://api.github.com/users/helielson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helielson/subscriptions","organizations_url":"https://api.github.com/users/helielson/orgs","repos_url":"https://api.github.com/users/helielson/repos","events_url":"https://api.github.com/users/helielson/events{/privacy}","received_events_url":"https://api.github.com/users/helielson/received_events","type":"User","site_admin":false},"body":"What do you think about receive a string as `targetSelector` and query this element by `document.querySelector` on `componentDidMount`?","created_at":"2016-09-01T03:53:07Z","updated_at":"2016-09-01T03:53:07Z","html_url":"https://github.com/tajo/react-portal/pull/85#discussion_r77110689","pull_request_url":"https://api.github.com/repos/tajo/react-portal/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/comments/77110689"},"html":{"href":"https://github.com/tajo/react-portal/pull/85#discussion_r77110689"},"pull_request":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/tajo/react-portal/pulls/85","id":77765211,"html_url":"https://github.com/tajo/react-portal/pull/85","diff_url":"https://github.com/tajo/react-portal/pull/85.diff","patch_url":"https://github.com/tajo/react-portal/pull/85.patch","issue_url":"https://api.github.com/repos/tajo/react-portal/issues/85","number":85,"state":"open","locked":false,"title":"Add ability to use specified layers for portals","user":{"login":"luchkonikita","id":5495772,"avatar_url":"https://avatars.githubusercontent.com/u/5495772?v=3","gravatar_id":"","url":"https://api.github.com/users/luchkonikita","html_url":"https://github.com/luchkonikita","followers_url":"https://api.github.com/users/luchkonikita/followers","following_url":"https://api.github.com/users/luchkonikita/following{/other_user}","gists_url":"https://api.github.com/users/luchkonikita/gists{/gist_id}","starred_url":"https://api.github.com/users/luchkonikita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luchkonikita/subscriptions","organizations_url":"https://api.github.com/users/luchkonikita/orgs","repos_url":"https://api.github.com/users/luchkonikita/repos","events_url":"https://api.github.com/users/luchkonikita/events{/privacy}","received_events_url":"https://api.github.com/users/luchkonikita/received_events","type":"User","site_admin":false},"body":"Sometimes it is very useful to be able to explicitly set elements for Portal to be rendered into.\r\n\r\nExample:\r\n\r\n```jsx\r\nconst modalLayer = document.getElementById('modal')\r\n\r\n<Portal target={modalLayer}>\r\n  Move me to the modal layer, please.\r\n</Portal>\r\n```","created_at":"2016-07-18T06:45:05Z","updated_at":"2016-09-01T03:53:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82fa4b4fabb5c6283d25c295f15d95687c072764","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tajo/react-portal/pulls/85/commits","review_comments_url":"https://api.github.com/repos/tajo/react-portal/pulls/85/comments","review_comment_url":"https://api.github.com/repos/tajo/react-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tajo/react-portal/issues/85/comments","statuses_url":"https://api.github.com/repos/tajo/react-portal/statuses/ffe9b4dee79b87c651edd9c6cee52db75d5b4bfe","head":{"label":"luchkonikita:add-multiple-layers-support","ref":"add-multiple-layers-support","sha":"ffe9b4dee79b87c651edd9c6cee52db75d5b4bfe","user":{"login":"luchkonikita","id":5495772,"avatar_url":"https://avatars.githubusercontent.com/u/5495772?v=3","gravatar_id":"","url":"https://api.github.com/users/luchkonikita","html_url":"https://github.com/luchkonikita","followers_url":"https://api.github.com/users/luchkonikita/followers","following_url":"https://api.github.com/users/luchkonikita/following{/other_user}","gists_url":"https://api.github.com/users/luchkonikita/gists{/gist_id}","starred_url":"https://api.github.com/users/luchkonikita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luchkonikita/subscriptions","organizations_url":"https://api.github.com/users/luchkonikita/orgs","repos_url":"https://api.github.com/users/luchkonikita/repos","events_url":"https://api.github.com/users/luchkonikita/events{/privacy}","received_events_url":"https://api.github.com/users/luchkonikita/received_events","type":"User","site_admin":false},"repo":{"id":63434027,"name":"react-portal","full_name":"luchkonikita/react-portal","owner":{"login":"luchkonikita","id":5495772,"avatar_url":"https://avatars.githubusercontent.com/u/5495772?v=3","gravatar_id":"","url":"https://api.github.com/users/luchkonikita","html_url":"https://github.com/luchkonikita","followers_url":"https://api.github.com/users/luchkonikita/followers","following_url":"https://api.github.com/users/luchkonikita/following{/other_user}","gists_url":"https://api.github.com/users/luchkonikita/gists{/gist_id}","starred_url":"https://api.github.com/users/luchkonikita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luchkonikita/subscriptions","organizations_url":"https://api.github.com/users/luchkonikita/orgs","repos_url":"https://api.github.com/users/luchkonikita/repos","events_url":"https://api.github.com/users/luchkonikita/events{/privacy}","received_events_url":"https://api.github.com/users/luchkonikita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luchkonikita/react-portal","description":"React component for transportation of modals, lightboxes, loading bars... to document.body","fork":true,"url":"https://api.github.com/repos/luchkonikita/react-portal","forks_url":"https://api.github.com/repos/luchkonikita/react-portal/forks","keys_url":"https://api.github.com/repos/luchkonikita/react-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luchkonikita/react-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luchkonikita/react-portal/teams","hooks_url":"https://api.github.com/repos/luchkonikita/react-portal/hooks","issue_events_url":"https://api.github.com/repos/luchkonikita/react-portal/issues/events{/number}","events_url":"https://api.github.com/repos/luchkonikita/react-portal/events","assignees_url":"https://api.github.com/repos/luchkonikita/react-portal/assignees{/user}","branches_url":"https://api.github.com/repos/luchkonikita/react-portal/branches{/branch}","tags_url":"https://api.github.com/repos/luchkonikita/react-portal/tags","blobs_url":"https://api.github.com/repos/luchkonikita/react-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luchkonikita/react-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luchkonikita/react-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/luchkonikita/react-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luchkonikita/react-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/luchkonikita/react-portal/languages","stargazers_url":"https://api.github.com/repos/luchkonikita/react-portal/stargazers","contributors_url":"https://api.github.com/repos/luchkonikita/react-portal/contributors","subscribers_url":"https://api.github.com/repos/luchkonikita/react-portal/subscribers","subscription_url":"https://api.github.com/repos/luchkonikita/react-portal/subscription","commits_url":"https://api.github.com/repos/luchkonikita/react-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/luchkonikita/react-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/luchkonikita/react-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/luchkonikita/react-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/luchkonikita/react-portal/contents/{+path}","compare_url":"https://api.github.com/repos/luchkonikita/react-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luchkonikita/react-portal/merges","archive_url":"https://api.github.com/repos/luchkonikita/react-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luchkonikita/react-portal/downloads","issues_url":"https://api.github.com/repos/luchkonikita/react-portal/issues{/number}","pulls_url":"https://api.github.com/repos/luchkonikita/react-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/luchkonikita/react-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/luchkonikita/react-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luchkonikita/react-portal/labels{/name}","releases_url":"https://api.github.com/repos/luchkonikita/react-portal/releases{/id}","deployments_url":"https://api.github.com/repos/luchkonikita/react-portal/deployments","created_at":"2016-07-15T15:57:08Z","updated_at":"2016-07-15T15:57:09Z","pushed_at":"2016-07-19T15:44:46Z","git_url":"git://github.com/luchkonikita/react-portal.git","ssh_url":"git@github.com:luchkonikita/react-portal.git","clone_url":"https://github.com/luchkonikita/react-portal.git","svn_url":"https://github.com/luchkonikita/react-portal","homepage":"","size":3581,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tajo:master","ref":"master","sha":"af6cd34ab46281c62aca579be709d562692c34ba","user":{"login":"tajo","id":1387913,"avatar_url":"https://avatars.githubusercontent.com/u/1387913?v=3","gravatar_id":"","url":"https://api.github.com/users/tajo","html_url":"https://github.com/tajo","followers_url":"https://api.github.com/users/tajo/followers","following_url":"https://api.github.com/users/tajo/following{/other_user}","gists_url":"https://api.github.com/users/tajo/gists{/gist_id}","starred_url":"https://api.github.com/users/tajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajo/subscriptions","organizations_url":"https://api.github.com/users/tajo/orgs","repos_url":"https://api.github.com/users/tajo/repos","events_url":"https://api.github.com/users/tajo/events{/privacy}","received_events_url":"https://api.github.com/users/tajo/received_events","type":"User","site_admin":false},"repo":{"id":32820926,"name":"react-portal","full_name":"tajo/react-portal","owner":{"login":"tajo","id":1387913,"avatar_url":"https://avatars.githubusercontent.com/u/1387913?v=3","gravatar_id":"","url":"https://api.github.com/users/tajo","html_url":"https://github.com/tajo","followers_url":"https://api.github.com/users/tajo/followers","following_url":"https://api.github.com/users/tajo/following{/other_user}","gists_url":"https://api.github.com/users/tajo/gists{/gist_id}","starred_url":"https://api.github.com/users/tajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajo/subscriptions","organizations_url":"https://api.github.com/users/tajo/orgs","repos_url":"https://api.github.com/users/tajo/repos","events_url":"https://api.github.com/users/tajo/events{/privacy}","received_events_url":"https://api.github.com/users/tajo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tajo/react-portal","description":"React component for transportation of modals, lightboxes, loading bars... to document.body","fork":false,"url":"https://api.github.com/repos/tajo/react-portal","forks_url":"https://api.github.com/repos/tajo/react-portal/forks","keys_url":"https://api.github.com/repos/tajo/react-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tajo/react-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tajo/react-portal/teams","hooks_url":"https://api.github.com/repos/tajo/react-portal/hooks","issue_events_url":"https://api.github.com/repos/tajo/react-portal/issues/events{/number}","events_url":"https://api.github.com/repos/tajo/react-portal/events","assignees_url":"https://api.github.com/repos/tajo/react-portal/assignees{/user}","branches_url":"https://api.github.com/repos/tajo/react-portal/branches{/branch}","tags_url":"https://api.github.com/repos/tajo/react-portal/tags","blobs_url":"https://api.github.com/repos/tajo/react-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tajo/react-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tajo/react-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/tajo/react-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tajo/react-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/tajo/react-portal/languages","stargazers_url":"https://api.github.com/repos/tajo/react-portal/stargazers","contributors_url":"https://api.github.com/repos/tajo/react-portal/contributors","subscribers_url":"https://api.github.com/repos/tajo/react-portal/subscribers","subscription_url":"https://api.github.com/repos/tajo/react-portal/subscription","commits_url":"https://api.github.com/repos/tajo/react-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/tajo/react-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/tajo/react-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/tajo/react-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/tajo/react-portal/contents/{+path}","compare_url":"https://api.github.com/repos/tajo/react-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tajo/react-portal/merges","archive_url":"https://api.github.com/repos/tajo/react-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tajo/react-portal/downloads","issues_url":"https://api.github.com/repos/tajo/react-portal/issues{/number}","pulls_url":"https://api.github.com/repos/tajo/react-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/tajo/react-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/tajo/react-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tajo/react-portal/labels{/name}","releases_url":"https://api.github.com/repos/tajo/react-portal/releases{/id}","deployments_url":"https://api.github.com/repos/tajo/react-portal/deployments","created_at":"2015-03-24T19:42:56Z","updated_at":"2016-08-31T11:36:07Z","pushed_at":"2016-08-14T02:51:53Z","git_url":"git://github.com/tajo/react-portal.git","ssh_url":"git@github.com:tajo/react-portal.git","clone_url":"https://github.com/tajo/react-portal.git","svn_url":"https://github.com/tajo/react-portal","homepage":"","size":3577,"stargazers_count":478,"watchers_count":478,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":11,"forks":56,"open_issues":11,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/85"},"html":{"href":"https://github.com/tajo/react-portal/pull/85"},"issue":{"href":"https://api.github.com/repos/tajo/react-portal/issues/85"},"comments":{"href":"https://api.github.com/repos/tajo/react-portal/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tajo/react-portal/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/tajo/react-portal/statuses/ffe9b4dee79b87c651edd9c6cee52db75d5b4bfe"}}}}
{"actor":{"display_login":"helielson"}}