{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/code-push/pulls/comments/52835472","id":52835472,"diff_hunk":"@@ -59,8 +62,12 @@ export interface PackageWithMetrics {\n     metrics?: UpdateMetricsWithTotalActive;\n }\n \n-export var sdk: AccountManager;\n export var log = (message: string | Chalk.ChalkChain): void => console.log(message);\n+export var sdk: AccountManager;\n+export var spawn = childProcess.spawn;\n+export var getTmpDir = (): string => {","path":"cli/script/command-executor.ts","position":43,"original_position":43,"commit_id":"32b797fd48947af3bad10d50e85d94ce2914dd3e","original_commit_id":"32b797fd48947af3bad10d50e85d94ce2914dd3e","user":{"login":"lostintangent","id":116461,"avatar_url":"https://avatars.githubusercontent.com/u/116461?v=3","gravatar_id":"","url":"https://api.github.com/users/lostintangent","html_url":"https://github.com/lostintangent","followers_url":"https://api.github.com/users/lostintangent/followers","following_url":"https://api.github.com/users/lostintangent/following{/other_user}","gists_url":"https://api.github.com/users/lostintangent/gists{/gist_id}","starred_url":"https://api.github.com/users/lostintangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostintangent/subscriptions","organizations_url":"https://api.github.com/users/lostintangent/orgs","repos_url":"https://api.github.com/users/lostintangent/repos","events_url":"https://api.github.com/users/lostintangent/events{/privacy}","received_events_url":"https://api.github.com/users/lostintangent/received_events","type":"User","site_admin":false},"body":"I almost think it would be clearer to just use \"os.tmpdir()\" below instead of wrapping that expression in a method. If you wanted just a method, could t you do something like \"var {tmpdir} = os\"?","created_at":"2016-02-13T23:48:01Z","updated_at":"2016-02-13T23:48:01Z","html_url":"https://github.com/Microsoft/code-push/pull/134#discussion_r52835472","pull_request_url":"https://api.github.com/repos/Microsoft/code-push/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/comments/52835472"},"html":{"href":"https://github.com/Microsoft/code-push/pull/134#discussion_r52835472"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/code-push/pulls/134","id":59257917,"html_url":"https://github.com/Microsoft/code-push/pull/134","diff_url":"https://github.com/Microsoft/code-push/pull/134.diff","patch_url":"https://github.com/Microsoft/code-push/pull/134.patch","issue_url":"https://api.github.com/repos/Microsoft/code-push/issues/134","number":134,"state":"open","locked":false,"title":"release-react command","user":{"login":"geof90","id":8598682,"avatar_url":"https://avatars.githubusercontent.com/u/8598682?v=3","gravatar_id":"","url":"https://api.github.com/users/geof90","html_url":"https://github.com/geof90","followers_url":"https://api.github.com/users/geof90/followers","following_url":"https://api.github.com/users/geof90/following{/other_user}","gists_url":"https://api.github.com/users/geof90/gists{/gist_id}","starred_url":"https://api.github.com/users/geof90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geof90/subscriptions","organizations_url":"https://api.github.com/users/geof90/orgs","repos_url":"https://api.github.com/users/geof90/repos","events_url":"https://api.github.com/users/geof90/events{/privacy}","received_events_url":"https://api.github.com/users/geof90/received_events","type":"User","site_admin":false},"body":"Will update docs in a seperate PR.\r\n\r\n![screen shot 2016-02-12 at 8 07 38 pm](https://cloud.githubusercontent.com/assets/8598682/13025766/56a77104-d1c4-11e5-9d1f-8cb4f9d06d1e.png)\r\n","created_at":"2016-02-13T04:08:19Z","updated_at":"2016-02-13T23:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e94375c69e441bec656e9bc56b8c415f3cc9f13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/code-push/pulls/134/commits","review_comments_url":"https://api.github.com/repos/Microsoft/code-push/pulls/134/comments","review_comment_url":"https://api.github.com/repos/Microsoft/code-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/code-push/issues/134/comments","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/32b797fd48947af3bad10d50e85d94ce2914dd3e","head":{"label":"Microsoft:release-react-command","ref":"release-react-command","sha":"32b797fd48947af3bad10d50e85d94ce2914dd3e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43459513,"name":"code-push","full_name":"Microsoft/code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/code-push","description":"A cloud service that enables Cordova and React Native developers to deploy mobile app updates directly to their users’ devices","fork":false,"url":"https://api.github.com/repos/Microsoft/code-push","forks_url":"https://api.github.com/repos/Microsoft/code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/code-push/deployments","created_at":"2015-09-30T21:12:55Z","updated_at":"2016-02-13T20:38:46Z","pushed_at":"2016-02-13T08:28:08Z","git_url":"git://github.com/Microsoft/code-push.git","ssh_url":"git@github.com:Microsoft/code-push.git","clone_url":"https://github.com/Microsoft/code-push.git","svn_url":"https://github.com/Microsoft/code-push","homepage":"http://codepush.tools","size":4791,"stargazers_count":930,"watchers_count":930,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":4,"forks":57,"open_issues":4,"watchers":930,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5db320c09dd1cb4c32ea8067038db19109f89b7e","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":43459513,"name":"code-push","full_name":"Microsoft/code-push","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/code-push","description":"A cloud service that enables Cordova and React Native developers to deploy mobile app updates directly to their users’ devices","fork":false,"url":"https://api.github.com/repos/Microsoft/code-push","forks_url":"https://api.github.com/repos/Microsoft/code-push/forks","keys_url":"https://api.github.com/repos/Microsoft/code-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/code-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/code-push/teams","hooks_url":"https://api.github.com/repos/Microsoft/code-push/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/code-push/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/code-push/events","assignees_url":"https://api.github.com/repos/Microsoft/code-push/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/code-push/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/code-push/tags","blobs_url":"https://api.github.com/repos/Microsoft/code-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/code-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/code-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/code-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/code-push/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/code-push/languages","stargazers_url":"https://api.github.com/repos/Microsoft/code-push/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/code-push/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/code-push/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/code-push/subscription","commits_url":"https://api.github.com/repos/Microsoft/code-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/code-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/code-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/code-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/code-push/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/code-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/code-push/merges","archive_url":"https://api.github.com/repos/Microsoft/code-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/code-push/downloads","issues_url":"https://api.github.com/repos/Microsoft/code-push/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/code-push/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/code-push/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/code-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/code-push/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/code-push/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/code-push/deployments","created_at":"2015-09-30T21:12:55Z","updated_at":"2016-02-13T20:38:46Z","pushed_at":"2016-02-13T08:28:08Z","git_url":"git://github.com/Microsoft/code-push.git","ssh_url":"git@github.com:Microsoft/code-push.git","clone_url":"https://github.com/Microsoft/code-push.git","svn_url":"https://github.com/Microsoft/code-push","homepage":"http://codepush.tools","size":4791,"stargazers_count":930,"watchers_count":930,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":4,"forks":57,"open_issues":4,"watchers":930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/134"},"html":{"href":"https://github.com/Microsoft/code-push/pull/134"},"issue":{"href":"https://api.github.com/repos/Microsoft/code-push/issues/134"},"comments":{"href":"https://api.github.com/repos/Microsoft/code-push/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/code-push/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/code-push/statuses/32b797fd48947af3bad10d50e85d94ce2914dd3e"}}}}