{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/92868686","pull_request_review_id":13393232,"id":92868686,"diff_hunk":"@@ -62,13 +62,14 @@\n // Template color\n if ($this->params->get('templateColor'))\n {\n-\t$this->addStyleDeclaration(\"\n+\t$this->addStyleDeclaration(","path":"templates/protostar/index.php","position":14,"original_position":14,"commit_id":"9f4fdb5f192e018800796ac7fe756e530ad5e0ba","original_commit_id":"9f4fdb5f192e018800796ac7fe756e530ad5e0ba","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"It's in the formatting rule of the ide. Need to change it. Will make a new commit.\r\n\r\nBTW, why are you sometimes doing \"approvals\" only code and other times it's \"testing with code review\" ? I am asking because with the first procedure it seems to take longer to get through the process (to the next stage, RTC for example). This seems to correlate to the fact that in the first procedure the number of checks stay 2 instead of the 3 tests in the second procedure. (3rd being the human tests)","created_at":"2016-12-16T19:13:43Z","updated_at":"2016-12-16T19:13:43Z","html_url":"https://github.com/joomla/joomla-cms/pull/13245#discussion_r92868686","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/92868686"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13245#discussion_r92868686"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245","id":98352646,"html_url":"https://github.com/joomla/joomla-cms/pull/13245","diff_url":"https://github.com/joomla/joomla-cms/pull/13245.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13245.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13245","number":13245,"state":"open","locked":false,"title":"Replace unnecessary double quotes in templates","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n- Replace unnecessary double quotes\r\n\r\nThis PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the templates directory, which is still on hold (#12233).\r\nOnce the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.\r\n\r\nThe changes in this PR are only of two types and should be fairly easy to review. In hope that  this will get merged quickly. ;)\r\n\r\n### Testing Instructions\r\n\r\nNone, should not change behavior\r\n\r\n\r\n### Documentation Changes Required\r\n\r\nNone.\r\n","created_at":"2016-12-16T15:26:00Z","updated_at":"2016-12-16T19:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512327da195341008baebb4ddf84d9012f969e74","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13245/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/9f4fdb5f192e018800796ac7fe756e530ad5e0ba","head":{"label":"frankmayer:replace-unnecessary-double-quotes-in-templates","ref":"replace-unnecessary-double-quotes-in-templates","sha":"9f4fdb5f192e018800796ac7fe756e530ad5e0ba","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"repo":{"id":69169032,"name":"joomla-cms","full_name":"frankmayer/joomla-cms","owner":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frankmayer/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/frankmayer/joomla-cms","forks_url":"https://api.github.com/repos/frankmayer/joomla-cms/forks","keys_url":"https://api.github.com/repos/frankmayer/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frankmayer/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frankmayer/joomla-cms/teams","hooks_url":"https://api.github.com/repos/frankmayer/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/frankmayer/joomla-cms/events","assignees_url":"https://api.github.com/repos/frankmayer/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/frankmayer/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/tags","blobs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frankmayer/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/frankmayer/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/frankmayer/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/frankmayer/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscription","commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/frankmayer/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/frankmayer/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/frankmayer/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frankmayer/joomla-cms/merges","archive_url":"https://api.github.com/repos/frankmayer/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frankmayer/joomla-cms/downloads","issues_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/frankmayer/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/frankmayer/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/frankmayer/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frankmayer/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/frankmayer/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/frankmayer/joomla-cms/deployments","created_at":"2016-09-25T14:24:41Z","updated_at":"2016-09-25T14:24:55Z","pushed_at":"2016-12-16T15:25:42Z","git_url":"git://github.com/frankmayer/joomla-cms.git","ssh_url":"git@github.com:frankmayer/joomla-cms.git","clone_url":"https://github.com/frankmayer/joomla-cms.git","svn_url":"https://github.com/frankmayer/joomla-cms","homepage":"https://www.joomla.org","size":167599,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"18e2805d04b4953715608e4b32d8e16d0f92556d","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-12-16T08:20:00Z","pushed_at":"2016-12-16T18:57:34Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":168020,"stargazers_count":2212,"watchers_count":2212,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2358,"mirror_url":null,"open_issues_count":549,"forks":2358,"open_issues":549,"watchers":2212,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13245"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13245"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13245/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13245/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/9f4fdb5f192e018800796ac7fe756e530ad5e0ba"}}}}
{"actor":{"display_login":"frankmayer"}}