{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/63335817","id":63335817,"diff_hunk":"@@ -237,18 +237,23 @@ def initialize_network_lan_address(include_target)\n               )\n             )\n           ),\n-          \"label\"         => _(\"Bond &Slaves\"),\n+          \"label\"             => _(\"Bond &Slaves\"),\n           #        \"opt\": [`shrinkable],\n-          \"init\"          => fun_ref(\n+          \"init\"              => fun_ref(\n             method(:InitSlave),\n             \"void (string)\"\n           ),\n-          \"handle\"        => fun_ref(\n+          \"handle\"            => fun_ref(\n             method(:HandleSlave),\n             \"symbol (string, map)\"\n           ),\n-          \"store\"         => fun_ref(method(:StoreSlave), \"void (string, map)\"),\n-          \"help\"          => Ops.get_string(@help, \"bondslave\", \"\")\n+          \"validate_type\"     => :function,\n+          \"validate_function\" => fun_ref(\n+            method(:ValidateBond),","path":"src/include/network/lan/address.rb","position":32,"original_position":32,"commit_id":"cd4ee3df7782c989c375b22151b5b70c139106b5","original_commit_id":"cd4ee3df7782c989c375b22151b5b70c139106b5","user":{"login":"imobach","id":15836,"avatar_url":"https://avatars.githubusercontent.com/u/15836?v=3","gravatar_id":"","url":"https://api.github.com/users/imobach","html_url":"https://github.com/imobach","followers_url":"https://api.github.com/users/imobach/followers","following_url":"https://api.github.com/users/imobach/following{/other_user}","gists_url":"https://api.github.com/users/imobach/gists{/gist_id}","starred_url":"https://api.github.com/users/imobach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imobach/subscriptions","organizations_url":"https://api.github.com/users/imobach/orgs","repos_url":"https://api.github.com/users/imobach/repos","events_url":"https://api.github.com/users/imobach/events{/privacy}","received_events_url":"https://api.github.com/users/imobach/received_events","type":"User","site_admin":false},"body":"Please, use `downcase` names for methods (I know we have a lot of old code which is \"uppercased\", but we should avoid this for new code).","created_at":"2016-05-16T10:35:01Z","updated_at":"2016-05-16T10:35:01Z","html_url":"https://github.com/yast/yast-network/pull/403#discussion_r63335817","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/63335817"},"html":{"href":"https://github.com/yast/yast-network/pull/403#discussion_r63335817"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-network/pulls/403","id":69978843,"html_url":"https://github.com/yast/yast-network/pull/403","diff_url":"https://github.com/yast/yast-network/pull/403.diff","patch_url":"https://github.com/yast/yast-network/pull/403.patch","issue_url":"https://api.github.com/repos/yast/yast-network/issues/403","number":403,"state":"open","locked":false,"title":"Smart bonding with npar and sriov interfaces (fate#315995)","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"body":"An initial study was documented [here](https://gist.github.com/teclator/c1012f264b96bc39a191a4227320bce4) although it had to be updated and some parts were redacted quickly to discuss with UX Expert.\r\n\r\nThis is the [Trello Card](https://trello.com/c/UKTnEvME/534-5-sle-12-sp2-p6-i-feature-315995-include-support-for-smarter-bonding-of-virtual-functions-on-npar-sr-iov-devices).\r\n\r\nAn here are the screenshots of current state, any comment is appreciated\r\n\r\n### Device Overview\r\n\r\n![Device Overview](https://cloud.githubusercontent.com/assets/7056681/15180416/68eb5dda-1779-11e6-9cbe-0f6bca7636d8.png)\r\n\r\n\r\n### Physical Port id in Item description\r\n\r\n![bond_slaves](https://trello-attachments.s3.amazonaws.com/56c43586c0fb23f985367990/1920x1080/5417e3bf1e9b02297008700adce37935/Screenshot_from_2016-05-09_07-36-38.png)\r\n\r\n\r\n### Available devices for bonding are sorted properly\r\n\r\n![screenshot from 2016-05-11 07-52-44](https://cloud.githubusercontent.com/assets/7056681/15179779/c8251286-1775-11e6-9dfc-77d050461d87.png)\r\n\r\n\r\n### Warn the user in case two interfaces share same physical port id\r\n\r\n![screenshot from 2016-05-13 11-36-15](https://cloud.githubusercontent.com/assets/7056681/15246125/7176ff56-1902-11e6-883a-806586f850aa.png)\r\n\r\n\r\n","created_at":"2016-05-13T11:05:35Z","updated_at":"2016-05-16T10:35:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"460449d46b1d72ac00f73b85d5e306670baa70a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-network/pulls/403/commits","review_comments_url":"https://api.github.com/repos/yast/yast-network/pulls/403/comments","review_comment_url":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-network/issues/403/comments","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/cd4ee3df7782c989c375b22151b5b70c139106b5","head":{"label":"teclator:bonding_npar_sriov","ref":"bonding_npar_sriov","sha":"cd4ee3df7782c989c375b22151b5b70c139106b5","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"repo":{"id":46275383,"name":"yast-network","full_name":"teclator/yast-network","owner":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teclator/yast-network","description":"YaST module network","fork":true,"url":"https://api.github.com/repos/teclator/yast-network","forks_url":"https://api.github.com/repos/teclator/yast-network/forks","keys_url":"https://api.github.com/repos/teclator/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teclator/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teclator/yast-network/teams","hooks_url":"https://api.github.com/repos/teclator/yast-network/hooks","issue_events_url":"https://api.github.com/repos/teclator/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/teclator/yast-network/events","assignees_url":"https://api.github.com/repos/teclator/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/teclator/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/teclator/yast-network/tags","blobs_url":"https://api.github.com/repos/teclator/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teclator/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teclator/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/teclator/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teclator/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/teclator/yast-network/languages","stargazers_url":"https://api.github.com/repos/teclator/yast-network/stargazers","contributors_url":"https://api.github.com/repos/teclator/yast-network/contributors","subscribers_url":"https://api.github.com/repos/teclator/yast-network/subscribers","subscription_url":"https://api.github.com/repos/teclator/yast-network/subscription","commits_url":"https://api.github.com/repos/teclator/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/teclator/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/teclator/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/teclator/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/teclator/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/teclator/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teclator/yast-network/merges","archive_url":"https://api.github.com/repos/teclator/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teclator/yast-network/downloads","issues_url":"https://api.github.com/repos/teclator/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/teclator/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/teclator/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/teclator/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teclator/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/teclator/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/teclator/yast-network/deployments","created_at":"2015-11-16T13:13:08Z","updated_at":"2016-01-12T15:28:25Z","pushed_at":"2016-05-16T07:09:08Z","git_url":"git://github.com/teclator/yast-network.git","ssh_url":"git@github.com:teclator/yast-network.git","clone_url":"https://github.com/teclator/yast-network.git","svn_url":"https://github.com/teclator/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24367,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"de8dc4e22475080171635246b4e7fd7722f6c91a","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368160,"name":"yast-network","full_name":"yast/yast-network","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-network","description":"YaST module network","fork":false,"url":"https://api.github.com/repos/yast/yast-network","forks_url":"https://api.github.com/repos/yast/yast-network/forks","keys_url":"https://api.github.com/repos/yast/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-network/teams","hooks_url":"https://api.github.com/repos/yast/yast-network/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-network/events","assignees_url":"https://api.github.com/repos/yast/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-network/tags","blobs_url":"https://api.github.com/repos/yast/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-network/languages","stargazers_url":"https://api.github.com/repos/yast/yast-network/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-network/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-network/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-network/subscription","commits_url":"https://api.github.com/repos/yast/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-network/merges","archive_url":"https://api.github.com/repos/yast/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-network/downloads","issues_url":"https://api.github.com/repos/yast/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-network/deployments","created_at":"2012-05-18T10:24:50Z","updated_at":"2016-02-18T10:00:30Z","pushed_at":"2016-05-16T07:09:09Z","git_url":"git://github.com/yast/yast-network.git","ssh_url":"git@github.com:yast/yast-network.git","clone_url":"https://github.com/yast/yast-network.git","svn_url":"https://github.com/yast/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24608,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/403"},"html":{"href":"https://github.com/yast/yast-network/pull/403"},"issue":{"href":"https://api.github.com/repos/yast/yast-network/issues/403"},"comments":{"href":"https://api.github.com/repos/yast/yast-network/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-network/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-network/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-network/statuses/cd4ee3df7782c989c375b22151b5b70c139106b5"}}}}