{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/comments/87277353","pull_request_review_id":7896502,"id":87277353,"diff_hunk":"@@ -128,11 +128,11 @@ export default class ShowHeartbeatAction extends Action {\n     // A bit redundant but the action argument names shouldn't necessarily rely\n     // on the argument names showHeartbeat takes.\n     const heartbeatData = {\n-      surveyId,\n+      surveyId: `${surveyId}::${flow.id}`,","path":"client/actions/show-heartbeat/index.js","position":13,"original_position":13,"commit_id":"a1c86f39d07f1b9d6ee14bd487f08482b156e8ee","original_commit_id":"a1c86f39d07f1b9d6ee14bd487f08482b156e8ee","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"Ah, the UUID we want to append isn't the flow ID. The flow ID is unique per-interaction with the prompt, so the same user interacting with different surveys will have a different flow ID. We want to use the per-user ID that doesn't change so that S&I can target and correlate answers from the same users over time.\r\n\r\nWe want to use the `userId` made available to filter expressions (see the [filter expression docs](http://normandy.readthedocs.io/en/latest/user/filter_expressions.html#normandy.userId)). The `getUserId` function in `self_repair_runner.js` can fetch it. I suspect we probably want to include it in the client info returned from `driver.client()` so that actions can use it.","created_at":"2016-11-09T21:08:44Z","updated_at":"2016-11-09T21:26:18Z","html_url":"https://github.com/mozilla/normandy/pull/315#discussion_r87277353","pull_request_url":"https://api.github.com/repos/mozilla/normandy/pulls/315","_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments/87277353"},"html":{"href":"https://github.com/mozilla/normandy/pull/315#discussion_r87277353"},"pull_request":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/315","id":92875433,"html_url":"https://github.com/mozilla/normandy/pull/315","diff_url":"https://github.com/mozilla/normandy/pull/315.diff","patch_url":"https://github.com/mozilla/normandy/pull/315.patch","issue_url":"https://api.github.com/repos/mozilla/normandy/issues/315","number":315,"state":"open","locked":false,"title":"#309 Add UUID to surveyId","user":{"login":"andymikulski","id":2767162,"avatar_url":"https://avatars.githubusercontent.com/u/2767162?v=3","gravatar_id":"","url":"https://api.github.com/users/andymikulski","html_url":"https://github.com/andymikulski","followers_url":"https://api.github.com/users/andymikulski/followers","following_url":"https://api.github.com/users/andymikulski/following{/other_user}","gists_url":"https://api.github.com/users/andymikulski/gists{/gist_id}","starred_url":"https://api.github.com/users/andymikulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymikulski/subscriptions","organizations_url":"https://api.github.com/users/andymikulski/orgs","repos_url":"https://api.github.com/users/andymikulski/repos","events_url":"https://api.github.com/users/andymikulski/events{/privacy}","received_events_url":"https://api.github.com/users/andymikulski/received_events","type":"User","site_admin":false},"body":"- Add UUID to surveyId (e.g. `my-survey::USERS-UUID`)\r\n- Add `userId` to query param for the `postAnswerUrl` (for SurveyGizmo)\r\n\r\n*Note: I had to run `npm run watch -- --update-actions` to update the heartbeat action with new code - you may have to as well!*","created_at":"2016-11-08T22:49:44Z","updated_at":"2016-11-09T21:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a394951a263aa7854ac2c3be566d6c92a35edc7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/normandy/pulls/315/commits","review_comments_url":"https://api.github.com/repos/mozilla/normandy/pulls/315/comments","review_comment_url":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/normandy/issues/315/comments","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/a1c86f39d07f1b9d6ee14bd487f08482b156e8ee","head":{"label":"andymikulski:309-surveyid-uuid","ref":"309-surveyid-uuid","sha":"a1c86f39d07f1b9d6ee14bd487f08482b156e8ee","user":{"login":"andymikulski","id":2767162,"avatar_url":"https://avatars.githubusercontent.com/u/2767162?v=3","gravatar_id":"","url":"https://api.github.com/users/andymikulski","html_url":"https://github.com/andymikulski","followers_url":"https://api.github.com/users/andymikulski/followers","following_url":"https://api.github.com/users/andymikulski/following{/other_user}","gists_url":"https://api.github.com/users/andymikulski/gists{/gist_id}","starred_url":"https://api.github.com/users/andymikulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymikulski/subscriptions","organizations_url":"https://api.github.com/users/andymikulski/orgs","repos_url":"https://api.github.com/users/andymikulski/repos","events_url":"https://api.github.com/users/andymikulski/events{/privacy}","received_events_url":"https://api.github.com/users/andymikulski/received_events","type":"User","site_admin":false},"repo":{"id":73124724,"name":"normandy","full_name":"andymikulski/normandy","owner":{"login":"andymikulski","id":2767162,"avatar_url":"https://avatars.githubusercontent.com/u/2767162?v=3","gravatar_id":"","url":"https://api.github.com/users/andymikulski","html_url":"https://github.com/andymikulski","followers_url":"https://api.github.com/users/andymikulski/followers","following_url":"https://api.github.com/users/andymikulski/following{/other_user}","gists_url":"https://api.github.com/users/andymikulski/gists{/gist_id}","starred_url":"https://api.github.com/users/andymikulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymikulski/subscriptions","organizations_url":"https://api.github.com/users/andymikulski/orgs","repos_url":"https://api.github.com/users/andymikulski/repos","events_url":"https://api.github.com/users/andymikulski/events{/privacy}","received_events_url":"https://api.github.com/users/andymikulski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andymikulski/normandy","description":"Firefox recipe server","fork":true,"url":"https://api.github.com/repos/andymikulski/normandy","forks_url":"https://api.github.com/repos/andymikulski/normandy/forks","keys_url":"https://api.github.com/repos/andymikulski/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andymikulski/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andymikulski/normandy/teams","hooks_url":"https://api.github.com/repos/andymikulski/normandy/hooks","issue_events_url":"https://api.github.com/repos/andymikulski/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/andymikulski/normandy/events","assignees_url":"https://api.github.com/repos/andymikulski/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/andymikulski/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/andymikulski/normandy/tags","blobs_url":"https://api.github.com/repos/andymikulski/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andymikulski/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andymikulski/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andymikulski/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andymikulski/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/andymikulski/normandy/languages","stargazers_url":"https://api.github.com/repos/andymikulski/normandy/stargazers","contributors_url":"https://api.github.com/repos/andymikulski/normandy/contributors","subscribers_url":"https://api.github.com/repos/andymikulski/normandy/subscribers","subscription_url":"https://api.github.com/repos/andymikulski/normandy/subscription","commits_url":"https://api.github.com/repos/andymikulski/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andymikulski/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andymikulski/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andymikulski/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andymikulski/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/andymikulski/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andymikulski/normandy/merges","archive_url":"https://api.github.com/repos/andymikulski/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andymikulski/normandy/downloads","issues_url":"https://api.github.com/repos/andymikulski/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/andymikulski/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/andymikulski/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/andymikulski/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andymikulski/normandy/labels{/name}","releases_url":"https://api.github.com/repos/andymikulski/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/andymikulski/normandy/deployments","created_at":"2016-11-07T21:59:21Z","updated_at":"2016-11-07T21:59:23Z","pushed_at":"2016-11-09T18:31:49Z","git_url":"git://github.com/andymikulski/normandy.git","ssh_url":"git@github.com:andymikulski/normandy.git","clone_url":"https://github.com/andymikulski/normandy.git","svn_url":"https://github.com/andymikulski/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":2225,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"0401934d6eef2b44e7a8d45bebb4aaff3cc44840","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":48456638,"name":"normandy","full_name":"mozilla/normandy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/normandy","description":"Firefox recipe server","fork":false,"url":"https://api.github.com/repos/mozilla/normandy","forks_url":"https://api.github.com/repos/mozilla/normandy/forks","keys_url":"https://api.github.com/repos/mozilla/normandy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/normandy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/normandy/teams","hooks_url":"https://api.github.com/repos/mozilla/normandy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/normandy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/normandy/events","assignees_url":"https://api.github.com/repos/mozilla/normandy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/normandy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/normandy/tags","blobs_url":"https://api.github.com/repos/mozilla/normandy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/normandy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/normandy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/normandy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/normandy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/normandy/languages","stargazers_url":"https://api.github.com/repos/mozilla/normandy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/normandy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/normandy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/normandy/subscription","commits_url":"https://api.github.com/repos/mozilla/normandy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/normandy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/normandy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/normandy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/normandy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/normandy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/normandy/merges","archive_url":"https://api.github.com/repos/mozilla/normandy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/normandy/downloads","issues_url":"https://api.github.com/repos/mozilla/normandy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/normandy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/normandy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/normandy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/normandy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/normandy/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/normandy/deployments","created_at":"2015-12-22T22:18:19Z","updated_at":"2016-10-28T00:10:35Z","pushed_at":"2016-11-09T21:14:54Z","git_url":"git://github.com/mozilla/normandy.git","ssh_url":"git@github.com:mozilla/normandy.git","clone_url":"https://github.com/mozilla/normandy.git","svn_url":"https://github.com/mozilla/normandy","homepage":"https://wiki.mozilla.org/Firefox/Recipe_Server","size":2350,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/315"},"html":{"href":"https://github.com/mozilla/normandy/pull/315"},"issue":{"href":"https://api.github.com/repos/mozilla/normandy/issues/315"},"comments":{"href":"https://api.github.com/repos/mozilla/normandy/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/normandy/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/normandy/statuses/a1c86f39d07f1b9d6ee14bd487f08482b156e8ee"}}}}
{"actor":{"display_login":"Osmose"}}