{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/8283","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/8283/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/8283/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/8283/events","html_url":"https://github.com/elastic/kibana/pull/8283","id":176987779,"number":8283,"title":"Check plugin version on startup","user":{"login":"BigFunger","id":12193008,"avatar_url":"https://avatars.githubusercontent.com/u/12193008?v=3","gravatar_id":"","url":"https://api.github.com/users/BigFunger","html_url":"https://github.com/BigFunger","followers_url":"https://api.github.com/users/BigFunger/followers","following_url":"https://api.github.com/users/BigFunger/following{/other_user}","gists_url":"https://api.github.com/users/BigFunger/gists{/gist_id}","starred_url":"https://api.github.com/users/BigFunger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigFunger/subscriptions","organizations_url":"https://api.github.com/users/BigFunger/orgs","repos_url":"https://api.github.com/users/BigFunger/repos","events_url":"https://api.github.com/users/BigFunger/events{/privacy}","received_events_url":"https://api.github.com/users/BigFunger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"assignees":[{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},{"login":"Bargs","id":6239176,"avatar_url":"https://avatars.githubusercontent.com/u/6239176?v=3","gravatar_id":"","url":"https://api.github.com/users/Bargs","html_url":"https://github.com/Bargs","followers_url":"https://api.github.com/users/Bargs/followers","following_url":"https://api.github.com/users/Bargs/following{/other_user}","gists_url":"https://api.github.com/users/Bargs/gists{/gist_id}","starred_url":"https://api.github.com/users/Bargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bargs/subscriptions","organizations_url":"https://api.github.com/users/Bargs/orgs","repos_url":"https://api.github.com/users/Bargs/repos","events_url":"https://api.github.com/users/Bargs/events{/privacy}","received_events_url":"https://api.github.com/users/Bargs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-09-14T18:44:38Z","updated_at":"2016-09-15T21:36:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/8283","html_url":"https://github.com/elastic/kibana/pull/8283","diff_url":"https://github.com/elastic/kibana/pull/8283.diff","patch_url":"https://github.com/elastic/kibana/pull/8283.patch"},"body":"Closes #6652\r\n\r\nAdds a version check to the Kibana startup process.\r\n - Applies the same version checks that are applied during the plugin install process (including #8222 changes)\r\n - If the version of the plugin (pack) fails this check, a warning message is displayed in the console and the plugin is disabled.\r\n\r\nI also changed the `version` value of some test fixtures to 'kibana' instead of '0.0.0'. The version checker will ignore (and not disable) any plugins that have a version number of 'kibana'."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/247462630","html_url":"https://github.com/elastic/kibana/pull/8283#issuecomment-247462630","issue_url":"https://api.github.com/repos/elastic/kibana/issues/8283","id":247462630,"user":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T21:36:52Z","updated_at":"2016-09-15T21:36:52Z","body":"> But when I changed the version number of an individual plugin (reporting) it didn't report any errors and did not disabled the plugin.\r\n\r\nIMO, that's how it should work. Correct me if I'm wrong, but I'm pretty sure the top-level \"pack\" version is the only version that's required. If there are other \"plugins\" bundled in the \"pack\", they aren't required to have a package.json file, so we shouldn't be checking them even if they exist.\r\n\r\n> I guess at the moment the only reason a plugin would have a different version than its pack is due to a build error. \r\n\r\nOr the internals are developed differently and their versions aren't in line with the pack's. But that's really up to the pack author to keep straight then.\r\n\r\n> If someone has a broken pack, it seems like we should warn them and disable the entire pack? \r\n\r\nThis I agree with, but only if you are defining \"broken\" as \"the top level version doesn't pass the test.\" If that's the case, then yes, the whole pack should be disabled.\r\n\r\n"}}
{"actor":{"display_login":"w33ble"}}