{"action":"created","issue":{"url":"https://api.github.com/repos/nryoung/algorithms/issues/134","repository_url":"https://api.github.com/repos/nryoung/algorithms","labels_url":"https://api.github.com/repos/nryoung/algorithms/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/nryoung/algorithms/issues/134/comments","events_url":"https://api.github.com/repos/nryoung/algorithms/issues/134/events","html_url":"https://github.com/nryoung/algorithms/pull/134","id":131986873,"number":134,"title":"Missing tests - Adding two missing tests and re-ordering existing tests.","user":{"login":"karandesai-96","id":10494087,"avatar_url":"https://avatars.githubusercontent.com/u/10494087?v=3","gravatar_id":"","url":"https://api.github.com/users/karandesai-96","html_url":"https://github.com/karandesai-96","followers_url":"https://api.github.com/users/karandesai-96/followers","following_url":"https://api.github.com/users/karandesai-96/following{/other_user}","gists_url":"https://api.github.com/users/karandesai-96/gists{/gist_id}","starred_url":"https://api.github.com/users/karandesai-96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandesai-96/subscriptions","organizations_url":"https://api.github.com/users/karandesai-96/orgs","repos_url":"https://api.github.com/users/karandesai-96/repos","events_url":"https://api.github.com/users/karandesai-96/events{/privacy}","received_events_url":"https://api.github.com/users/karandesai-96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-02-07T17:12:18Z","updated_at":"2016-03-02T01:38:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nryoung/algorithms/pulls/134","html_url":"https://github.com/nryoung/algorithms/pull/134","diff_url":"https://github.com/nryoung/algorithms/pull/134.diff","patch_url":"https://github.com/nryoung/algorithms/pull/134.patch"},"body":"* I recently started using this library for practicing implementation of some algorithms and I decided to run some tests. I saw the tests were a little bit un-ordered so it was difficult to keep track. \r\n\r\n* The files in directory are arranged in alphabetical order and so if the tests are too arranged in that way, it is better to analyze the code for a third person viewing it.\r\n\r\n* So I have ordered the tests in each file alphabetically, and on the way I discovered that two tests were not written - bogo sort, and primality test. I have added them in too.\r\n\r\n* I develop in Pycharm IDE by Jetbrains community, and nowadays many python users do so. This IDE generates a `.idea/` directory which does not need to be on Github, so I also updated the gitignore file in the PR.\r\n\r\n* I do not intend to do more work in the PR unless there are issues with the current code written here. So if the checks pass and the reviewer feels it is proper, this PR is fit to be merged. :+1: "},"comment":{"url":"https://api.github.com/repos/nryoung/algorithms/issues/comments/191012544","html_url":"https://github.com/nryoung/algorithms/pull/134#issuecomment-191012544","issue_url":"https://api.github.com/repos/nryoung/algorithms/issues/134","id":191012544,"user":{"login":"nryoung","id":1323750,"avatar_url":"https://avatars.githubusercontent.com/u/1323750?v=3","gravatar_id":"","url":"https://api.github.com/users/nryoung","html_url":"https://github.com/nryoung","followers_url":"https://api.github.com/users/nryoung/followers","following_url":"https://api.github.com/users/nryoung/following{/other_user}","gists_url":"https://api.github.com/users/nryoung/gists{/gist_id}","starred_url":"https://api.github.com/users/nryoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nryoung/subscriptions","organizations_url":"https://api.github.com/users/nryoung/orgs","repos_url":"https://api.github.com/users/nryoung/repos","events_url":"https://api.github.com/users/nryoung/events{/privacy}","received_events_url":"https://api.github.com/users/nryoung/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T01:38:24Z","updated_at":"2016-03-02T01:38:24Z","body":"Thank you for your contribution! These changes look solid, just have one comment:\r\n\r\nCan you squash and rebase your commits to a single commit with a short but descriptive commit message about your changes. Take a look at: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request if you need help."}}