{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/Argo/issues/411","repository_url":"https://api.github.com/repos/thoughtbot/Argo","labels_url":"https://api.github.com/repos/thoughtbot/Argo/issues/411/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/Argo/issues/411/comments","events_url":"https://api.github.com/repos/thoughtbot/Argo/issues/411/events","html_url":"https://github.com/thoughtbot/Argo/pull/411","id":176121408,"number":411,"title":"Add Carthage directories to framework search paths","user":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-09T22:01:05Z","updated_at":"2016-09-11T18:16:54Z","closed_at":"2016-09-11T18:15:36Z","pull_request":{"url":"https://api.github.com/repos/thoughtbot/Argo/pulls/411","html_url":"https://github.com/thoughtbot/Argo/pull/411","diff_url":"https://github.com/thoughtbot/Argo/pull/411.diff","patch_url":"https://github.com/thoughtbot/Argo/pull/411.patch"},"body":"When building with Carthage locally, Argo uses the local checkouts of the\ndependencies to build and link against. However, when using Argo as a\ndependency, those checkouts don't exist. This means that when Argo tries to\nbuild, it can't find Runes and so the build fails.\n\nUnfortunately, if we move to a more carthage centric workflow where we use the\nbuilt binaries to link against, that ends up breaking the workflow for users\nthat want to use Git Submodules for their dependency management (because they\nwon't have those frameworks in those locations).\n\nWe can work around this while still allowing users to use submodules by adding\nthe build directories to the framework search paths _without_ explicitly using\nthose built frameworks in our project. This means that Carthage users will be\nable to see the Runes dependency, and submodules users will be able to use the\nproject and implicit dependencies.\n\nThe only downside here is that this might result in warnings for submodules\nusers. I think that's a reasonable trade-off."},"comment":{"url":"https://api.github.com/repos/thoughtbot/Argo/issues/comments/246194990","html_url":"https://github.com/thoughtbot/Argo/pull/411#issuecomment-246194990","issue_url":"https://api.github.com/repos/thoughtbot/Argo/issues/411","id":246194990,"user":{"login":"gfontenot","id":124499,"avatar_url":"https://avatars.githubusercontent.com/u/124499?v=3","gravatar_id":"","url":"https://api.github.com/users/gfontenot","html_url":"https://github.com/gfontenot","followers_url":"https://api.github.com/users/gfontenot/followers","following_url":"https://api.github.com/users/gfontenot/following{/other_user}","gists_url":"https://api.github.com/users/gfontenot/gists{/gist_id}","starred_url":"https://api.github.com/users/gfontenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfontenot/subscriptions","organizations_url":"https://api.github.com/users/gfontenot/orgs","repos_url":"https://api.github.com/users/gfontenot/repos","events_url":"https://api.github.com/users/gfontenot/events{/privacy}","received_events_url":"https://api.github.com/users/gfontenot/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T18:16:54Z","updated_at":"2016-09-11T18:16:54Z","body":"Oh, Carthage 0.18 is actually already released! Neato."}}
{"actor":{"display_login":"gfontenot"}}