{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1055","repository_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1055/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1055/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1055/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1055","id":167512409,"number":1055,"title":"retaining example tag in python lib","user":{"login":"gramhagen","id":5720537,"avatar_url":"https://avatars.githubusercontent.com/u/5720537?v=3","gravatar_id":"","url":"https://api.github.com/users/gramhagen","html_url":"https://github.com/gramhagen","followers_url":"https://api.github.com/users/gramhagen/followers","following_url":"https://api.github.com/users/gramhagen/following{/other_user}","gists_url":"https://api.github.com/users/gramhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/gramhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramhagen/subscriptions","organizations_url":"https://api.github.com/users/gramhagen/orgs","repos_url":"https://api.github.com/users/gramhagen/repos","events_url":"https://api.github.com/users/gramhagen/events{/privacy}","received_events_url":"https://api.github.com/users/gramhagen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-26T03:15:21Z","updated_at":"2016-07-26T13:09:49Z","closed_at":"2016-07-26T13:09:08Z","pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1055","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1055","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1055.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1055.patch"},"body":"this is to fix issue #758 \r\n\r\nthere was some hacky stuff in pylibvw which erased the tag and used it to store the label type because that was needed to deallocate memory when the example was destroyed.\r\n\r\nI couldn't find an easy way to retain the size_t labelType variable on it's own, and since example_counter was also being overridden to store this info I kept it there and used example_counter in the dealloc_example function.\r\n\r\nthis is still a bit hacky, but I didn't want to modify the base example class for this case, maybe someone has a better implementation for dealloc_example that can resolve this issue, but for now this works to get the tag.  The example counter information is still not valid, but that seems less relevant for the python library."},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/235262047","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1055#issuecomment-235262047","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1055","id":235262047,"user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T13:09:49Z","updated_at":"2016-07-26T13:09:49Z","body":"Thanks.  \r\n\r\nThis seems unpleasant.  I think we need to have explicit typing for labels and predictions."}}
{"actor":{"display_login":"JohnLangford"}}