{"action":"created","comment":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/55470805","id":55470805,"diff_hunk":"@@ -16,6 +16,19 @@ $wb-assets-path: \"#{$wb-core-path}/assets\" !default;\n // BOOTSTRAP VARIABLES\n //\n \n+//== Breadcrumb\n+//\n+//## Breacrumb enable/disable and colour settings.\n+\n+// WET Custom\n+$wb-bc-enable: true !default; // Enable or disable WET's breadcrumb SCSS. Themes that don't use breadcrumbs can set this to false.\n+$wb-bc-background-color: null !default; // Outer background colour. Override $breadcrumb-bg (Bootstrap variable) to change the inner background colour.\n+$wb-bc-separator-color: #333 !default; // Separator colour.\n+$wb-bc-separator-font-family: \"Glyphicons Halflings\" !default; // Separator font family.\n+$wb-bc-separator-font-size: 0.7em !default; // Separator font size.\n+$wb-bc-separator-content: \"\\e092\" !default; // Separator content.\n+$wb-bc-separator-content-rtl: \"\\e091\" !default; // Separator content (right to left).\n+","path":"src/_variables.scss","position":16,"original_position":16,"commit_id":"7ef50bf417050211d238c3fc08983194d4dc82e2","original_commit_id":"2c69b49769c332ae6344e1fb7b998bcc6cd9959a","user":{"login":"EricDunsworth","id":1907279,"avatar_url":"https://avatars.githubusercontent.com/u/1907279?v=3","gravatar_id":"","url":"https://api.github.com/users/EricDunsworth","html_url":"https://github.com/EricDunsworth","followers_url":"https://api.github.com/users/EricDunsworth/followers","following_url":"https://api.github.com/users/EricDunsworth/following{/other_user}","gists_url":"https://api.github.com/users/EricDunsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDunsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDunsworth/subscriptions","organizations_url":"https://api.github.com/users/EricDunsworth/orgs","repos_url":"https://api.github.com/users/EricDunsworth/repos","events_url":"https://api.github.com/users/EricDunsworth/events{/privacy}","received_events_url":"https://api.github.com/users/EricDunsworth/received_events","type":"User","site_admin":false},"body":"@LaurentGoderre Done :). Btw just out of curiosity, what was the reasoning behind your suggestion?\r\n\r\nWhen I initially placed the breadcrumb variables before the colour ones, I was thinking of putting things in alphabetical order. Felt kind of strange though, since it came right after the start of the Boostrap variables block. But on the other hand, that block already contained a mix of Bootstrap overrides and WET-specific variables, so it didn't feel any weirder than what was already being done.","created_at":"2016-03-09T04:28:02Z","updated_at":"2016-03-09T04:28:02Z","html_url":"https://github.com/wet-boew/wet-boew/pull/7423#discussion_r55470805","pull_request_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423","_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/55470805"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/7423#discussion_r55470805"},"pull_request":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423"}}},"pull_request":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423","id":60910360,"html_url":"https://github.com/wet-boew/wet-boew/pull/7423","diff_url":"https://github.com/wet-boew/wet-boew/pull/7423.diff","patch_url":"https://github.com/wet-boew/wet-boew/pull/7423.patch","issue_url":"https://api.github.com/repos/wet-boew/wet-boew/issues/7423","number":7423,"state":"open","locked":false,"title":"Breadcrumbs: Reworked into conditional base SCSS, added variables and fixed RTL issues.","user":{"login":"EricDunsworth","id":1907279,"avatar_url":"https://avatars.githubusercontent.com/u/1907279?v=3","gravatar_id":"","url":"https://api.github.com/users/EricDunsworth","html_url":"https://github.com/EricDunsworth","followers_url":"https://api.github.com/users/EricDunsworth/followers","following_url":"https://api.github.com/users/EricDunsworth/following{/other_user}","gists_url":"https://api.github.com/users/EricDunsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDunsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDunsworth/subscriptions","organizations_url":"https://api.github.com/users/EricDunsworth/orgs","repos_url":"https://api.github.com/users/EricDunsworth/repos","events_url":"https://api.github.com/users/EricDunsworth/events{/privacy}","received_events_url":"https://api.github.com/users/EricDunsworth/received_events","type":"User","site_admin":false},"body":"* Managing generic breadcrumb styles should now be easier since they're no longer repeated across all themes.\r\n* Added enable variable to allow themes to optionally exclude breadcrumb SCSS.\r\n* Added variables for inner/outer background colours and arrow colours.\r\n* RTL fixes:\r\n  * Prevents arrows from getting mispositioned between items.\r\n  * Prevents text from unexpectedly getting cutoff and replaced with ellipses in WebKit browsers.\r\n\r\nFixes #7422 and closes #7383.\r\n\r\n@LaurentGoderre @shawnthompson IMO this should've been good to go, except when I try running ``grunt css``to build it, I get a warning that falsely claims my ``breadcrumb-print`` mixin doesn't exist :S. AFAIK I didn't botch that mixin's declaration, include, nor imports to its file. Any ideas?\r\n\r\n**Screenshot:**\r\n![breadcrumb-print-mixin-warning](https://cloud.githubusercontent.com/assets/1907279/13366520/bdd5518a-dca9-11e5-9eae-fa0c1a82d27c.png)\r\n","created_at":"2016-02-26T21:56:25Z","updated_at":"2016-03-09T04:28:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dfb21d13f3e7d1ad0c65431cf2b75cd3d26daf2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423/commits","review_comments_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423/comments","review_comment_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wet-boew/wet-boew/issues/7423/comments","statuses_url":"https://api.github.com/repos/wet-boew/wet-boew/statuses/7ef50bf417050211d238c3fc08983194d4dc82e2","head":{"label":"EricDunsworth:v4.0-breadcrumb-mixin-rtl","ref":"v4.0-breadcrumb-mixin-rtl","sha":"7ef50bf417050211d238c3fc08983194d4dc82e2","user":{"login":"EricDunsworth","id":1907279,"avatar_url":"https://avatars.githubusercontent.com/u/1907279?v=3","gravatar_id":"","url":"https://api.github.com/users/EricDunsworth","html_url":"https://github.com/EricDunsworth","followers_url":"https://api.github.com/users/EricDunsworth/followers","following_url":"https://api.github.com/users/EricDunsworth/following{/other_user}","gists_url":"https://api.github.com/users/EricDunsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDunsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDunsworth/subscriptions","organizations_url":"https://api.github.com/users/EricDunsworth/orgs","repos_url":"https://api.github.com/users/EricDunsworth/repos","events_url":"https://api.github.com/users/EricDunsworth/events{/privacy}","received_events_url":"https://api.github.com/users/EricDunsworth/received_events","type":"User","site_admin":false},"repo":{"id":4874026,"name":"wet-boew","full_name":"EricDunsworth/wet-boew","owner":{"login":"EricDunsworth","id":1907279,"avatar_url":"https://avatars.githubusercontent.com/u/1907279?v=3","gravatar_id":"","url":"https://api.github.com/users/EricDunsworth","html_url":"https://github.com/EricDunsworth","followers_url":"https://api.github.com/users/EricDunsworth/followers","following_url":"https://api.github.com/users/EricDunsworth/following{/other_user}","gists_url":"https://api.github.com/users/EricDunsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDunsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDunsworth/subscriptions","organizations_url":"https://api.github.com/users/EricDunsworth/orgs","repos_url":"https://api.github.com/users/EricDunsworth/repos","events_url":"https://api.github.com/users/EricDunsworth/events{/privacy}","received_events_url":"https://api.github.com/users/EricDunsworth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricDunsworth/wet-boew","description":"Main repository of the Web Experience Toolkit (WET)","fork":true,"url":"https://api.github.com/repos/EricDunsworth/wet-boew","forks_url":"https://api.github.com/repos/EricDunsworth/wet-boew/forks","keys_url":"https://api.github.com/repos/EricDunsworth/wet-boew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricDunsworth/wet-boew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricDunsworth/wet-boew/teams","hooks_url":"https://api.github.com/repos/EricDunsworth/wet-boew/hooks","issue_events_url":"https://api.github.com/repos/EricDunsworth/wet-boew/issues/events{/number}","events_url":"https://api.github.com/repos/EricDunsworth/wet-boew/events","assignees_url":"https://api.github.com/repos/EricDunsworth/wet-boew/assignees{/user}","branches_url":"https://api.github.com/repos/EricDunsworth/wet-boew/branches{/branch}","tags_url":"https://api.github.com/repos/EricDunsworth/wet-boew/tags","blobs_url":"https://api.github.com/repos/EricDunsworth/wet-boew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricDunsworth/wet-boew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricDunsworth/wet-boew/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricDunsworth/wet-boew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricDunsworth/wet-boew/statuses/{sha}","languages_url":"https://api.github.com/repos/EricDunsworth/wet-boew/languages","stargazers_url":"https://api.github.com/repos/EricDunsworth/wet-boew/stargazers","contributors_url":"https://api.github.com/repos/EricDunsworth/wet-boew/contributors","subscribers_url":"https://api.github.com/repos/EricDunsworth/wet-boew/subscribers","subscription_url":"https://api.github.com/repos/EricDunsworth/wet-boew/subscription","commits_url":"https://api.github.com/repos/EricDunsworth/wet-boew/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricDunsworth/wet-boew/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricDunsworth/wet-boew/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricDunsworth/wet-boew/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricDunsworth/wet-boew/contents/{+path}","compare_url":"https://api.github.com/repos/EricDunsworth/wet-boew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricDunsworth/wet-boew/merges","archive_url":"https://api.github.com/repos/EricDunsworth/wet-boew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricDunsworth/wet-boew/downloads","issues_url":"https://api.github.com/repos/EricDunsworth/wet-boew/issues{/number}","pulls_url":"https://api.github.com/repos/EricDunsworth/wet-boew/pulls{/number}","milestones_url":"https://api.github.com/repos/EricDunsworth/wet-boew/milestones{/number}","notifications_url":"https://api.github.com/repos/EricDunsworth/wet-boew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricDunsworth/wet-boew/labels{/name}","releases_url":"https://api.github.com/repos/EricDunsworth/wet-boew/releases{/id}","deployments_url":"https://api.github.com/repos/EricDunsworth/wet-boew/deployments","created_at":"2012-07-03T15:36:45Z","updated_at":"2014-10-02T20:40:57Z","pushed_at":"2016-03-09T04:19:41Z","git_url":"git://github.com/EricDunsworth/wet-boew.git","ssh_url":"git@github.com:EricDunsworth/wet-boew.git","clone_url":"https://github.com/EricDunsworth/wet-boew.git","svn_url":"https://github.com/EricDunsworth/wet-boew","homepage":null,"size":112687,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wet-boew:master","ref":"master","sha":"d3977a65e38e83eb2568d14e8422617897da7b71","user":{"login":"wet-boew","id":1730142,"avatar_url":"https://avatars.githubusercontent.com/u/1730142?v=3","gravatar_id":"","url":"https://api.github.com/users/wet-boew","html_url":"https://github.com/wet-boew","followers_url":"https://api.github.com/users/wet-boew/followers","following_url":"https://api.github.com/users/wet-boew/following{/other_user}","gists_url":"https://api.github.com/users/wet-boew/gists{/gist_id}","starred_url":"https://api.github.com/users/wet-boew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wet-boew/subscriptions","organizations_url":"https://api.github.com/users/wet-boew/orgs","repos_url":"https://api.github.com/users/wet-boew/repos","events_url":"https://api.github.com/users/wet-boew/events{/privacy}","received_events_url":"https://api.github.com/users/wet-boew/received_events","type":"Organization","site_admin":false},"repo":{"id":4297273,"name":"wet-boew","full_name":"wet-boew/wet-boew","owner":{"login":"wet-boew","id":1730142,"avatar_url":"https://avatars.githubusercontent.com/u/1730142?v=3","gravatar_id":"","url":"https://api.github.com/users/wet-boew","html_url":"https://github.com/wet-boew","followers_url":"https://api.github.com/users/wet-boew/followers","following_url":"https://api.github.com/users/wet-boew/following{/other_user}","gists_url":"https://api.github.com/users/wet-boew/gists{/gist_id}","starred_url":"https://api.github.com/users/wet-boew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wet-boew/subscriptions","organizations_url":"https://api.github.com/users/wet-boew/orgs","repos_url":"https://api.github.com/users/wet-boew/repos","events_url":"https://api.github.com/users/wet-boew/events{/privacy}","received_events_url":"https://api.github.com/users/wet-boew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wet-boew/wet-boew","description":"Web Experience Toolkit (WET): Open source code library for building innovative websites that are accessible, usable, interoperable, mobile-friendly and multilingual. This collaborative open source project is led by the Government of Canada.","fork":false,"url":"https://api.github.com/repos/wet-boew/wet-boew","forks_url":"https://api.github.com/repos/wet-boew/wet-boew/forks","keys_url":"https://api.github.com/repos/wet-boew/wet-boew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wet-boew/wet-boew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wet-boew/wet-boew/teams","hooks_url":"https://api.github.com/repos/wet-boew/wet-boew/hooks","issue_events_url":"https://api.github.com/repos/wet-boew/wet-boew/issues/events{/number}","events_url":"https://api.github.com/repos/wet-boew/wet-boew/events","assignees_url":"https://api.github.com/repos/wet-boew/wet-boew/assignees{/user}","branches_url":"https://api.github.com/repos/wet-boew/wet-boew/branches{/branch}","tags_url":"https://api.github.com/repos/wet-boew/wet-boew/tags","blobs_url":"https://api.github.com/repos/wet-boew/wet-boew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wet-boew/wet-boew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wet-boew/wet-boew/git/refs{/sha}","trees_url":"https://api.github.com/repos/wet-boew/wet-boew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wet-boew/wet-boew/statuses/{sha}","languages_url":"https://api.github.com/repos/wet-boew/wet-boew/languages","stargazers_url":"https://api.github.com/repos/wet-boew/wet-boew/stargazers","contributors_url":"https://api.github.com/repos/wet-boew/wet-boew/contributors","subscribers_url":"https://api.github.com/repos/wet-boew/wet-boew/subscribers","subscription_url":"https://api.github.com/repos/wet-boew/wet-boew/subscription","commits_url":"https://api.github.com/repos/wet-boew/wet-boew/commits{/sha}","git_commits_url":"https://api.github.com/repos/wet-boew/wet-boew/git/commits{/sha}","comments_url":"https://api.github.com/repos/wet-boew/wet-boew/comments{/number}","issue_comment_url":"https://api.github.com/repos/wet-boew/wet-boew/issues/comments{/number}","contents_url":"https://api.github.com/repos/wet-boew/wet-boew/contents/{+path}","compare_url":"https://api.github.com/repos/wet-boew/wet-boew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wet-boew/wet-boew/merges","archive_url":"https://api.github.com/repos/wet-boew/wet-boew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wet-boew/wet-boew/downloads","issues_url":"https://api.github.com/repos/wet-boew/wet-boew/issues{/number}","pulls_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls{/number}","milestones_url":"https://api.github.com/repos/wet-boew/wet-boew/milestones{/number}","notifications_url":"https://api.github.com/repos/wet-boew/wet-boew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wet-boew/wet-boew/labels{/name}","releases_url":"https://api.github.com/repos/wet-boew/wet-boew/releases{/id}","deployments_url":"https://api.github.com/repos/wet-boew/wet-boew/deployments","created_at":"2012-05-11T13:31:20Z","updated_at":"2016-03-08T20:23:52Z","pushed_at":"2016-03-09T04:19:42Z","git_url":"git://github.com/wet-boew/wet-boew.git","ssh_url":"git@github.com:wet-boew/wet-boew.git","clone_url":"https://github.com/wet-boew/wet-boew.git","svn_url":"https://github.com/wet-boew/wet-boew","homepage":"http://wet-boew.github.io/wet-boew/index-en.html","size":134346,"stargazers_count":809,"watchers_count":809,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":475,"mirror_url":null,"open_issues_count":282,"forks":475,"open_issues":282,"watchers":809,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/7423"},"issue":{"href":"https://api.github.com/repos/wet-boew/wet-boew/issues/7423"},"comments":{"href":"https://api.github.com/repos/wet-boew/wet-boew/issues/7423/comments"},"review_comments":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423/comments"},"review_comment":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/7423/commits"},"statuses":{"href":"https://api.github.com/repos/wet-boew/wet-boew/statuses/7ef50bf417050211d238c3fc08983194d4dc82e2"}}}}