{"action":"created","issue":{"url":"https://api.github.com/repos/cshenry/Workspace/issues/24","labels_url":"https://api.github.com/repos/cshenry/Workspace/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/cshenry/Workspace/issues/24/comments","events_url":"https://api.github.com/repos/cshenry/Workspace/issues/24/events","html_url":"https://github.com/cshenry/Workspace/pull/24","id":129846048,"number":24,"title":"P3 workspace changes","user":{"login":"olsonanl","id":2152226,"avatar_url":"https://avatars.githubusercontent.com/u/2152226?v=3","gravatar_id":"","url":"https://api.github.com/users/olsonanl","html_url":"https://github.com/olsonanl","followers_url":"https://api.github.com/users/olsonanl/followers","following_url":"https://api.github.com/users/olsonanl/following{/other_user}","gists_url":"https://api.github.com/users/olsonanl/gists{/gist_id}","starred_url":"https://api.github.com/users/olsonanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olsonanl/subscriptions","organizations_url":"https://api.github.com/users/olsonanl/orgs","repos_url":"https://api.github.com/users/olsonanl/repos","events_url":"https://api.github.com/users/olsonanl/events{/privacy}","received_events_url":"https://api.github.com/users/olsonanl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-29T18:30:54Z","updated_at":"2016-01-29T19:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cshenry/Workspace/pulls/24","html_url":"https://github.com/cshenry/Workspace/pull/24","diff_url":"https://github.com/cshenry/Workspace/pull/24.diff","patch_url":"https://github.com/cshenry/Workspace/pull/24.patch"},"body":"Hey - the main point of this commit is to change the behavior of p3-login and p3-logout to update .kbase_config as well as the .p3 config so that the stock KBase tools work properly.\r\n\r\nThere is an old fix in here for the zero-size update bug we ran into last year; I'm not sure why it did not get rolled in before ..."},"comment":{"url":"https://api.github.com/repos/cshenry/Workspace/issues/comments/176923785","html_url":"https://github.com/cshenry/Workspace/pull/24#issuecomment-176923785","issue_url":"https://api.github.com/repos/cshenry/Workspace/issues/24","id":176923785,"user":{"login":"cshenry","id":1007394,"avatar_url":"https://avatars.githubusercontent.com/u/1007394?v=3","gravatar_id":"","url":"https://api.github.com/users/cshenry","html_url":"https://github.com/cshenry","followers_url":"https://api.github.com/users/cshenry/followers","following_url":"https://api.github.com/users/cshenry/following{/other_user}","gists_url":"https://api.github.com/users/cshenry/gists{/gist_id}","starred_url":"https://api.github.com/users/cshenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshenry/subscriptions","organizations_url":"https://api.github.com/users/cshenry/orgs","repos_url":"https://api.github.com/users/cshenry/repos","events_url":"https://api.github.com/users/cshenry/events{/privacy}","received_events_url":"https://api.github.com/users/cshenry/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T19:25:13Z","updated_at":"2016-01-29T19:25:13Z","body":"BTW, if this is really needed and there’s no reasonable work around, I’m willing to merge this. I just wanted to register my concerns.\nOn January 29, 2016 at 1:11:21 PM, Chris Henry (chrisshenry@gmail.com) wrote:\n\nI’m really not enamored with having the patric login changing the KBase config, as this essentially precludes one from using both PATRIC and KBase at the same time - a position that I find myself and my collaborators in quite often. The problem is, changes to the default config files persist even when one shifts the environment of the shell.\n\nCan we have kbase tools in PATRIC configured to point to the patric config file using the environment variable instead? Aren’t all KBase tools already configured to use an environment variable for the config? Couldn’t we make the setting of this environment variable as default part of user-env.sh in the PATRIC build? This seems like a better solution that trying to have two systems with different account types sharing a common config file for login, and thus forcing users to constantly log in and out of both services...\nOn January 29, 2016 at 12:30:57 PM, olsonanl (notifications@github.com) wrote:\n\nHey - the main point of this commit is to change the behavior of p3-login and p3-logout to update .kbase_config as well as the .p3 config so that the stock KBase tools work properly.\n\nThere is an old fix in here for the zero-size update bug we ran into last year; I'm not sure why it did not get rolled in before ...\n\nYou can view, comment on, or merge this pull request online at:\n\n  https://github.com/cshenry/Workspace/pull/24\n\nCommit Summary\n\nFix zero-size update bug\nMerge branch 'master' of https://github.com/cshenry/Workspace\nUpdate .kbase_config when p3-login is run.\nAlso update .kbase_config on p3-logout.\nFile Changes\n\nM lib/Bio/P3/Workspace/ScriptHelpers.pm (31)\nM lib/Bio/P3/Workspace/WorkspaceImpl.pm (4)\nPatch Links:\n\nhttps://github.com/cshenry/Workspace/pull/24.patch\nhttps://github.com/cshenry/Workspace/pull/24.diff\n—\nReply to this email directly or view it on GitHub.\n\n"}}