{"action":"closed","number":734,"pull_request":{"url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734","id":60291049,"html_url":"https://github.com/mail-in-a-box/mailinabox/pull/734","diff_url":"https://github.com/mail-in-a-box/mailinabox/pull/734.diff","patch_url":"https://github.com/mail-in-a-box/mailinabox/pull/734.patch","issue_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/734","number":734,"state":"closed","locked":false,"title":"Create a temporary multiprocessing pool","user":{"login":"yodax","id":5643940,"avatar_url":"https://avatars.githubusercontent.com/u/5643940?v=3","gravatar_id":"","url":"https://api.github.com/users/yodax","html_url":"https://github.com/yodax","followers_url":"https://api.github.com/users/yodax/followers","following_url":"https://api.github.com/users/yodax/following{/other_user}","gists_url":"https://api.github.com/users/yodax/gists{/gist_id}","starred_url":"https://api.github.com/users/yodax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodax/subscriptions","organizations_url":"https://api.github.com/users/yodax/orgs","repos_url":"https://api.github.com/users/yodax/repos","events_url":"https://api.github.com/users/yodax/events{/privacy}","received_events_url":"https://api.github.com/users/yodax/received_events","type":"User","site_admin":false},"body":"As discussed here: https://github.com/mail-in-a-box/mailinabox/issues/731\r\n\r\nThis PR uses a dynamically allocated pool of workers. The pool size is still static. This doesn't affect the speed of the status checks on my machine. The status check themselves won't report more free memory than with the previous PR because at that time the pool is allocated. However free -h, will show the additional free memory.\r\n\r\nThis [pool terminate](https://github.com/mail-in-a-box/mailinabox/compare/master...yodax:dynamicpool?expand=1#diff-096e716daee0c3907cb8e054e0352be5R436) is required to free the workers instead of waiting for garbage collection. Otherwise the system can be broken by refreshing the page to often.\r\n\r\nThoughts?\r\n\r\nSide note: I have added swap space to my DO droplet. This will prevent crashes if the memory runs full. Is this something to add to the install instructions or recommendations or even do this during the install if no swap is allocated?","created_at":"2016-02-23T05:42:59Z","updated_at":"2016-02-28T17:39:11Z","closed_at":"2016-02-28T17:39:11Z","merged_at":"2016-02-28T17:39:11Z","merge_commit_sha":"3979477275b3d8b01a80d91dd6c163f9ca7c5124","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734/commits","review_comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734/comments","review_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/734/comments","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/f53d3bc39058190082ac4e8b84a3478e5a219b8c","head":{"label":"yodax:dynamicpool","ref":"dynamicpool","sha":"f53d3bc39058190082ac4e8b84a3478e5a219b8c","user":{"login":"yodax","id":5643940,"avatar_url":"https://avatars.githubusercontent.com/u/5643940?v=3","gravatar_id":"","url":"https://api.github.com/users/yodax","html_url":"https://github.com/yodax","followers_url":"https://api.github.com/users/yodax/followers","following_url":"https://api.github.com/users/yodax/following{/other_user}","gists_url":"https://api.github.com/users/yodax/gists{/gist_id}","starred_url":"https://api.github.com/users/yodax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodax/subscriptions","organizations_url":"https://api.github.com/users/yodax/orgs","repos_url":"https://api.github.com/users/yodax/repos","events_url":"https://api.github.com/users/yodax/events{/privacy}","received_events_url":"https://api.github.com/users/yodax/received_events","type":"User","site_admin":false},"repo":{"id":44906607,"name":"mailinabox","full_name":"yodax/mailinabox","owner":{"login":"yodax","id":5643940,"avatar_url":"https://avatars.githubusercontent.com/u/5643940?v=3","gravatar_id":"","url":"https://api.github.com/users/yodax","html_url":"https://github.com/yodax","followers_url":"https://api.github.com/users/yodax/followers","following_url":"https://api.github.com/users/yodax/following{/other_user}","gists_url":"https://api.github.com/users/yodax/gists{/gist_id}","starred_url":"https://api.github.com/users/yodax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodax/subscriptions","organizations_url":"https://api.github.com/users/yodax/orgs","repos_url":"https://api.github.com/users/yodax/repos","events_url":"https://api.github.com/users/yodax/events{/privacy}","received_events_url":"https://api.github.com/users/yodax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yodax/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":true,"url":"https://api.github.com/repos/yodax/mailinabox","forks_url":"https://api.github.com/repos/yodax/mailinabox/forks","keys_url":"https://api.github.com/repos/yodax/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yodax/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yodax/mailinabox/teams","hooks_url":"https://api.github.com/repos/yodax/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/yodax/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/yodax/mailinabox/events","assignees_url":"https://api.github.com/repos/yodax/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/yodax/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/yodax/mailinabox/tags","blobs_url":"https://api.github.com/repos/yodax/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yodax/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yodax/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/yodax/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yodax/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/yodax/mailinabox/languages","stargazers_url":"https://api.github.com/repos/yodax/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/yodax/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/yodax/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/yodax/mailinabox/subscription","commits_url":"https://api.github.com/repos/yodax/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/yodax/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/yodax/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/yodax/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/yodax/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/yodax/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yodax/mailinabox/merges","archive_url":"https://api.github.com/repos/yodax/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yodax/mailinabox/downloads","issues_url":"https://api.github.com/repos/yodax/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/yodax/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/yodax/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/yodax/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yodax/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/yodax/mailinabox/releases{/id}","deployments_url":"https://api.github.com/repos/yodax/mailinabox/deployments","created_at":"2015-10-25T11:08:48Z","updated_at":"2016-01-25T18:50:28Z","pushed_at":"2016-02-28T13:18:29Z","git_url":"git://github.com/yodax/mailinabox.git","ssh_url":"git@github.com:yodax/mailinabox.git","clone_url":"https://github.com/yodax/mailinabox.git","svn_url":"https://github.com/yodax/mailinabox","homepage":"https://mailinabox.email/","size":2011,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mail-in-a-box:master","ref":"master","sha":"f9ca440ce80c8fc65a8815ae0ffd417014a6f4a0","user":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"repo":{"id":12271469,"name":"mailinabox","full_name":"mail-in-a-box/mailinabox","owner":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mail-in-a-box/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":false,"url":"https://api.github.com/repos/mail-in-a-box/mailinabox","forks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/forks","keys_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/teams","hooks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/events","assignees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/tags","blobs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/languages","stargazers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscription","commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/merges","archive_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/downloads","issues_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/releases{/id}","deployments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/deployments","created_at":"2013-08-21T13:56:50Z","updated_at":"2016-02-28T06:49:19Z","pushed_at":"2016-02-28T17:39:11Z","git_url":"git://github.com/mail-in-a-box/mailinabox.git","ssh_url":"git@github.com:mail-in-a-box/mailinabox.git","clone_url":"https://github.com/mail-in-a-box/mailinabox.git","svn_url":"https://github.com/mail-in-a-box/mailinabox","homepage":"https://mailinabox.email/","size":3075,"stargazers_count":4535,"watchers_count":4535,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":103,"forks":338,"open_issues":103,"watchers":4535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734"},"html":{"href":"https://github.com/mail-in-a-box/mailinabox/pull/734"},"issue":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/734"},"comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/734/comments"},"review_comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734/comments"},"review_comment":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/734/commits"},"statuses":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/f53d3bc39058190082ac4e8b84a3478e5a219b8c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JoshData","id":445875,"avatar_url":"https://avatars.githubusercontent.com/u/445875?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshData","html_url":"https://github.com/JoshData","followers_url":"https://api.github.com/users/JoshData/followers","following_url":"https://api.github.com/users/JoshData/following{/other_user}","gists_url":"https://api.github.com/users/JoshData/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshData/subscriptions","organizations_url":"https://api.github.com/users/JoshData/orgs","repos_url":"https://api.github.com/users/JoshData/repos","events_url":"https://api.github.com/users/JoshData/events{/privacy}","received_events_url":"https://api.github.com/users/JoshData/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":4,"deletions":7,"changed_files":1}}