{"action":"opened","number":17491,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/17491","id":56872434,"html_url":"https://github.com/symfony/symfony/pull/17491","diff_url":"https://github.com/symfony/symfony/pull/17491.diff","patch_url":"https://github.com/symfony/symfony/pull/17491.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/17491","number":17491,"state":"open","locked":false,"title":"[HttpKernel] Make Bundle::getContainerExtensionClass public","user":{"login":"kix","id":345754,"avatar_url":"https://avatars.githubusercontent.com/u/345754?v=3","gravatar_id":"","url":"https://api.github.com/users/kix","html_url":"https://github.com/kix","followers_url":"https://api.github.com/users/kix/followers","following_url":"https://api.github.com/users/kix/following{/other_user}","gists_url":"https://api.github.com/users/kix/gists{/gist_id}","starred_url":"https://api.github.com/users/kix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kix/subscriptions","organizations_url":"https://api.github.com/users/kix/orgs","repos_url":"https://api.github.com/users/kix/repos","events_url":"https://api.github.com/users/kix/events{/privacy}","received_events_url":"https://api.github.com/users/kix/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | none\r\n| License       | MIT\r\n| Doc PR        | none, will do\r\n\r\nThis adds more flexibility for bundle extension class names and also makes working with container extensions less error-prone. I think allowing end users to specify exact extension class names would make things more transparent, as now I as an end user can change the extension class name, but this would just break my bundle.\r\n\r\nImagine I got distracted in a middle of a bundle rename refactoring. I've renamed the bundle class, updated my AppKernel, moved stuff to a different namespace — quite a lot of things to do already — and yet I forget to rename the extension class. Since that moment, `Bundle::getContainerExtension()` would just always return `false` for no apparent reason (as it would look to me).\r\n\r\nHaving this merged, we'll be able to also handle the cases when we cannot accept `null` for an `ExtensionInterface` gracefully: if there's no extension returned, we'd be able to throw an exception describing the exact extension classname we expected to exist.\r\n\r\nAlso, we'll be able to allow end users to explicitly specify their bundles' extension classes, which would make things a bit more transparent (and this needs a doc PR [here](http://symfony.com/doc/current/cookbook/bundles/extension.html#creating-an-extension-class)).","created_at":"2016-01-22T10:47:22Z","updated_at":"2016-01-22T10:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/17491/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/17491/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/17491/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/97f572137a167e0de35e5f18453c187fb0c3c695","head":{"label":"kix:bundle-getcontainerextension-fix-2.8","ref":"bundle-getcontainerextension-fix-2.8","sha":"97f572137a167e0de35e5f18453c187fb0c3c695","user":{"login":"kix","id":345754,"avatar_url":"https://avatars.githubusercontent.com/u/345754?v=3","gravatar_id":"","url":"https://api.github.com/users/kix","html_url":"https://github.com/kix","followers_url":"https://api.github.com/users/kix/followers","following_url":"https://api.github.com/users/kix/following{/other_user}","gists_url":"https://api.github.com/users/kix/gists{/gist_id}","starred_url":"https://api.github.com/users/kix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kix/subscriptions","organizations_url":"https://api.github.com/users/kix/orgs","repos_url":"https://api.github.com/users/kix/repos","events_url":"https://api.github.com/users/kix/events{/privacy}","received_events_url":"https://api.github.com/users/kix/received_events","type":"User","site_admin":false},"repo":{"id":23077966,"name":"symfony","full_name":"kix/symfony","owner":{"login":"kix","id":345754,"avatar_url":"https://avatars.githubusercontent.com/u/345754?v=3","gravatar_id":"","url":"https://api.github.com/users/kix","html_url":"https://github.com/kix","followers_url":"https://api.github.com/users/kix/followers","following_url":"https://api.github.com/users/kix/following{/other_user}","gists_url":"https://api.github.com/users/kix/gists{/gist_id}","starred_url":"https://api.github.com/users/kix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kix/subscriptions","organizations_url":"https://api.github.com/users/kix/orgs","repos_url":"https://api.github.com/users/kix/repos","events_url":"https://api.github.com/users/kix/events{/privacy}","received_events_url":"https://api.github.com/users/kix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kix/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/kix/symfony","forks_url":"https://api.github.com/repos/kix/symfony/forks","keys_url":"https://api.github.com/repos/kix/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kix/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kix/symfony/teams","hooks_url":"https://api.github.com/repos/kix/symfony/hooks","issue_events_url":"https://api.github.com/repos/kix/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/kix/symfony/events","assignees_url":"https://api.github.com/repos/kix/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/kix/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/kix/symfony/tags","blobs_url":"https://api.github.com/repos/kix/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kix/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kix/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/kix/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kix/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/kix/symfony/languages","stargazers_url":"https://api.github.com/repos/kix/symfony/stargazers","contributors_url":"https://api.github.com/repos/kix/symfony/contributors","subscribers_url":"https://api.github.com/repos/kix/symfony/subscribers","subscription_url":"https://api.github.com/repos/kix/symfony/subscription","commits_url":"https://api.github.com/repos/kix/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/kix/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/kix/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/kix/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/kix/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/kix/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kix/symfony/merges","archive_url":"https://api.github.com/repos/kix/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kix/symfony/downloads","issues_url":"https://api.github.com/repos/kix/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/kix/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/kix/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/kix/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kix/symfony/labels{/name}","releases_url":"https://api.github.com/repos/kix/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/kix/symfony/deployments","created_at":"2014-08-18T16:15:37Z","updated_at":"2015-06-17T18:13:39Z","pushed_at":"2016-01-22T10:35:58Z","git_url":"git://github.com/kix/symfony.git","ssh_url":"git@github.com:kix/symfony.git","clone_url":"https://github.com/kix/symfony.git","svn_url":"https://github.com/kix/symfony","homepage":"symfony.com","size":65780,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"295f5ee6264c843a49e6bff27c90e6783ea0921f","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-01-22T09:18:19Z","pushed_at":"2016-01-22T10:28:37Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":99223,"stargazers_count":11568,"watchers_count":11568,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4560,"mirror_url":null,"open_issues_count":918,"forks":4560,"open_issues":918,"watchers":11568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17491"},"html":{"href":"https://github.com/symfony/symfony/pull/17491"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/17491"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/17491/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17491/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17491/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/97f572137a167e0de35e5f18453c187fb0c3c695"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}