{"action":"created","comment":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/comments/50660661","id":50660661,"diff_hunk":"@@ -1339,33 +1339,45 @@ sub _MigrateConfigs {\n     print \"...done.\\n\";\n     print \"--- Preferences group modules...\";\n \n-    # Preferences groups\n-    $Setting = $ConfigObject->Get('PreferencesGroups');\n+    # Preferences Modules\n+    my @PreferencesGroupTypes = (\n+        {\n+            Path => 'PreferencesGroups',","path":"scripts/DBUpdate-to-5.pl","position":9,"original_position":9,"commit_id":"3fc8cc7902db770d1341397fead47a4dccfd12a3","original_commit_id":"3fc8cc7902db770d1341397fead47a4dccfd12a3","user":{"login":"mgruner","id":211281,"avatar_url":"https://avatars.githubusercontent.com/u/211281?v=3","gravatar_id":"","url":"https://api.github.com/users/mgruner","html_url":"https://github.com/mgruner","followers_url":"https://api.github.com/users/mgruner/followers","following_url":"https://api.github.com/users/mgruner/following{/other_user}","gists_url":"https://api.github.com/users/mgruner/gists{/gist_id}","starred_url":"https://api.github.com/users/mgruner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgruner/subscriptions","organizations_url":"https://api.github.com/users/mgruner/orgs","repos_url":"https://api.github.com/users/mgruner/repos","events_url":"https://api.github.com/users/mgruner/events{/privacy}","received_events_url":"https://api.github.com/users/mgruner/received_events","type":"User","site_admin":false},"body":"This looks very good in general. However, I have one question: why do you use a list of hashes here? Would not a simple list ```@PreferencesGroupTypes = qw(PreferencesGroups CustomerPreferencesGroups)``` be enough? I see that it is already used on other places in this function, but maybe you could consider a simplification.","created_at":"2016-01-25T07:37:31Z","updated_at":"2016-01-25T07:37:31Z","html_url":"https://github.com/OTRS/otrs/pull/932#discussion_r50660661","pull_request_url":"https://api.github.com/repos/OTRS/otrs/pulls/932","_links":{"self":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/comments/50660661"},"html":{"href":"https://github.com/OTRS/otrs/pull/932#discussion_r50660661"},"pull_request":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/932"}}},"pull_request":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/932","id":56881225,"html_url":"https://github.com/OTRS/otrs/pull/932","diff_url":"https://github.com/OTRS/otrs/pull/932.diff","patch_url":"https://github.com/OTRS/otrs/pull/932.patch","issue_url":"https://api.github.com/repos/OTRS/otrs/issues/932","number":932,"state":"open","locked":false,"title":"[ Rel-5_0 Bug 11819 ] - Error when trying to edit/create new customer agent while SMIME activated ","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"body":"http://bugs.otrs.org/show_bug.cgi?id=11819\r\n\r\nHi Martin,\r\n\r\nThere was a problem because there did not updated some modules in the script  DBUpdate-to-5.pl\r\nNow, I check all sysconfig items which have Module param. I hope that now it works for all items. \r\n\r\nIf you want I can split this PR in two ones, because there is fixed bug with changes for   \"Preferences Modules\" and fixed \"Article View Modules\" that is not mentioned in the bug. I thought that it is better solve in one PR. \r\n\r\nRegards\r\nZoran\r\n","created_at":"2016-01-22T12:23:01Z","updated_at":"2016-01-25T07:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c76165108c5688b6222a0592366dd09648456f56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OTRS/otrs/pulls/932/commits","review_comments_url":"https://api.github.com/repos/OTRS/otrs/pulls/932/comments","review_comment_url":"https://api.github.com/repos/OTRS/otrs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OTRS/otrs/issues/932/comments","statuses_url":"https://api.github.com/repos/OTRS/otrs/statuses/3fc8cc7902db770d1341397fead47a4dccfd12a3","head":{"label":"s7design:rel-5_0_bug_11819","ref":"rel-5_0_bug_11819","sha":"3fc8cc7902db770d1341397fead47a4dccfd12a3","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"repo":{"id":16277254,"name":"otrs","full_name":"s7design/otrs","owner":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s7design/otrs","description":"The OTRS framework.","fork":true,"url":"https://api.github.com/repos/s7design/otrs","forks_url":"https://api.github.com/repos/s7design/otrs/forks","keys_url":"https://api.github.com/repos/s7design/otrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s7design/otrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s7design/otrs/teams","hooks_url":"https://api.github.com/repos/s7design/otrs/hooks","issue_events_url":"https://api.github.com/repos/s7design/otrs/issues/events{/number}","events_url":"https://api.github.com/repos/s7design/otrs/events","assignees_url":"https://api.github.com/repos/s7design/otrs/assignees{/user}","branches_url":"https://api.github.com/repos/s7design/otrs/branches{/branch}","tags_url":"https://api.github.com/repos/s7design/otrs/tags","blobs_url":"https://api.github.com/repos/s7design/otrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s7design/otrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s7design/otrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/s7design/otrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s7design/otrs/statuses/{sha}","languages_url":"https://api.github.com/repos/s7design/otrs/languages","stargazers_url":"https://api.github.com/repos/s7design/otrs/stargazers","contributors_url":"https://api.github.com/repos/s7design/otrs/contributors","subscribers_url":"https://api.github.com/repos/s7design/otrs/subscribers","subscription_url":"https://api.github.com/repos/s7design/otrs/subscription","commits_url":"https://api.github.com/repos/s7design/otrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/s7design/otrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/s7design/otrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/s7design/otrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/s7design/otrs/contents/{+path}","compare_url":"https://api.github.com/repos/s7design/otrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s7design/otrs/merges","archive_url":"https://api.github.com/repos/s7design/otrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s7design/otrs/downloads","issues_url":"https://api.github.com/repos/s7design/otrs/issues{/number}","pulls_url":"https://api.github.com/repos/s7design/otrs/pulls{/number}","milestones_url":"https://api.github.com/repos/s7design/otrs/milestones{/number}","notifications_url":"https://api.github.com/repos/s7design/otrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s7design/otrs/labels{/name}","releases_url":"https://api.github.com/repos/s7design/otrs/releases{/id}","deployments_url":"https://api.github.com/repos/s7design/otrs/deployments","created_at":"2014-01-27T11:35:20Z","updated_at":"2015-05-08T10:57:01Z","pushed_at":"2016-01-22T13:04:27Z","git_url":"git://github.com/s7design/otrs.git","ssh_url":"git@github.com:s7design/otrs.git","clone_url":"https://github.com/s7design/otrs.git","svn_url":"https://github.com/s7design/otrs","homepage":null,"size":300064,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OTRS:rel-5_0","ref":"rel-5_0","sha":"6b28d4aa9df0876221447368761cb74f4c3d65dd","user":{"login":"OTRS","id":3065906,"avatar_url":"https://avatars.githubusercontent.com/u/3065906?v=3","gravatar_id":"","url":"https://api.github.com/users/OTRS","html_url":"https://github.com/OTRS","followers_url":"https://api.github.com/users/OTRS/followers","following_url":"https://api.github.com/users/OTRS/following{/other_user}","gists_url":"https://api.github.com/users/OTRS/gists{/gist_id}","starred_url":"https://api.github.com/users/OTRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTRS/subscriptions","organizations_url":"https://api.github.com/users/OTRS/orgs","repos_url":"https://api.github.com/users/OTRS/repos","events_url":"https://api.github.com/users/OTRS/events{/privacy}","received_events_url":"https://api.github.com/users/OTRS/received_events","type":"Organization","site_admin":false},"repo":{"id":16276216,"name":"otrs","full_name":"OTRS/otrs","owner":{"login":"OTRS","id":3065906,"avatar_url":"https://avatars.githubusercontent.com/u/3065906?v=3","gravatar_id":"","url":"https://api.github.com/users/OTRS","html_url":"https://github.com/OTRS","followers_url":"https://api.github.com/users/OTRS/followers","following_url":"https://api.github.com/users/OTRS/following{/other_user}","gists_url":"https://api.github.com/users/OTRS/gists{/gist_id}","starred_url":"https://api.github.com/users/OTRS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OTRS/subscriptions","organizations_url":"https://api.github.com/users/OTRS/orgs","repos_url":"https://api.github.com/users/OTRS/repos","events_url":"https://api.github.com/users/OTRS/events{/privacy}","received_events_url":"https://api.github.com/users/OTRS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OTRS/otrs","description":"The OTRS framework.","fork":false,"url":"https://api.github.com/repos/OTRS/otrs","forks_url":"https://api.github.com/repos/OTRS/otrs/forks","keys_url":"https://api.github.com/repos/OTRS/otrs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OTRS/otrs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OTRS/otrs/teams","hooks_url":"https://api.github.com/repos/OTRS/otrs/hooks","issue_events_url":"https://api.github.com/repos/OTRS/otrs/issues/events{/number}","events_url":"https://api.github.com/repos/OTRS/otrs/events","assignees_url":"https://api.github.com/repos/OTRS/otrs/assignees{/user}","branches_url":"https://api.github.com/repos/OTRS/otrs/branches{/branch}","tags_url":"https://api.github.com/repos/OTRS/otrs/tags","blobs_url":"https://api.github.com/repos/OTRS/otrs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OTRS/otrs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OTRS/otrs/git/refs{/sha}","trees_url":"https://api.github.com/repos/OTRS/otrs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OTRS/otrs/statuses/{sha}","languages_url":"https://api.github.com/repos/OTRS/otrs/languages","stargazers_url":"https://api.github.com/repos/OTRS/otrs/stargazers","contributors_url":"https://api.github.com/repos/OTRS/otrs/contributors","subscribers_url":"https://api.github.com/repos/OTRS/otrs/subscribers","subscription_url":"https://api.github.com/repos/OTRS/otrs/subscription","commits_url":"https://api.github.com/repos/OTRS/otrs/commits{/sha}","git_commits_url":"https://api.github.com/repos/OTRS/otrs/git/commits{/sha}","comments_url":"https://api.github.com/repos/OTRS/otrs/comments{/number}","issue_comment_url":"https://api.github.com/repos/OTRS/otrs/issues/comments{/number}","contents_url":"https://api.github.com/repos/OTRS/otrs/contents/{+path}","compare_url":"https://api.github.com/repos/OTRS/otrs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OTRS/otrs/merges","archive_url":"https://api.github.com/repos/OTRS/otrs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OTRS/otrs/downloads","issues_url":"https://api.github.com/repos/OTRS/otrs/issues{/number}","pulls_url":"https://api.github.com/repos/OTRS/otrs/pulls{/number}","milestones_url":"https://api.github.com/repos/OTRS/otrs/milestones{/number}","notifications_url":"https://api.github.com/repos/OTRS/otrs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OTRS/otrs/labels{/name}","releases_url":"https://api.github.com/repos/OTRS/otrs/releases{/id}","deployments_url":"https://api.github.com/repos/OTRS/otrs/deployments","created_at":"2014-01-27T10:44:13Z","updated_at":"2016-01-22T19:24:19Z","pushed_at":"2016-01-22T19:40:21Z","git_url":"git://github.com/OTRS/otrs.git","ssh_url":"git@github.com:OTRS/otrs.git","clone_url":"https://github.com/OTRS/otrs.git","svn_url":"https://github.com/OTRS/otrs","homepage":null,"size":315024,"stargazers_count":185,"watchers_count":185,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":45,"forks":177,"open_issues":45,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/932"},"html":{"href":"https://github.com/OTRS/otrs/pull/932"},"issue":{"href":"https://api.github.com/repos/OTRS/otrs/issues/932"},"comments":{"href":"https://api.github.com/repos/OTRS/otrs/issues/932/comments"},"review_comments":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/932/comments"},"review_comment":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OTRS/otrs/pulls/932/commits"},"statuses":{"href":"https://api.github.com/repos/OTRS/otrs/statuses/3fc8cc7902db770d1341397fead47a4dccfd12a3"}}}}