{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/7455","repository_url":"https://api.github.com/repos/facebook/react","labels_url":"https://api.github.com/repos/facebook/react/issues/7455/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/7455/comments","events_url":"https://api.github.com/repos/facebook/react/issues/7455/events","html_url":"https://github.com/facebook/react/pull/7455","id":170300657,"number":7455,"title":"Change ReactChildrenMutationWarningHook to Object.freeze children","user":{"login":"keyanzhang","id":2268452,"avatar_url":"https://avatars.githubusercontent.com/u/2268452?v=3","gravatar_id":"","url":"https://api.github.com/users/keyanzhang","html_url":"https://github.com/keyanzhang","followers_url":"https://api.github.com/users/keyanzhang/followers","following_url":"https://api.github.com/users/keyanzhang/following{/other_user}","gists_url":"https://api.github.com/users/keyanzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/keyanzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyanzhang/subscriptions","organizations_url":"https://api.github.com/users/keyanzhang/orgs","repos_url":"https://api.github.com/users/keyanzhang/repos","events_url":"https://api.github.com/users/keyanzhang/events{/privacy}","received_events_url":"https://api.github.com/users/keyanzhang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-10T00:13:20Z","updated_at":"2016-08-30T20:06:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/7455","html_url":"https://github.com/facebook/react/pull/7455","diff_url":"https://github.com/facebook/react/pull/7455.diff","patch_url":"https://github.com/facebook/react/pull/7455.patch"},"body":"Alternative of #7410 that fixes #7406. This should also fix #7424 and #7426 (the false-positive warning).\r\nSaving and comparing the `shadowChildren` is pretty expensive -- we can `Object.freeze` the JSX children instead.\r\n\r\nBenchmark:\r\n```\r\nComparing master.txt (control) vs freeze.txt (test)\r\nSignificant differences marked by ***\r\n% change from control to test, with 99% CIs:\r\n\r\n* factory_ms_jsc_jit\r\n    % change:  +0.38% [ -6.59%,  +7.36%]\r\n    means: 27.6427 (control), 27.7558 (test)\r\n* factory_ms_jsc_nojit\r\n    % change: -10.22% [-15.03%,  -5.41%]  ***\r\n    means: 26.3667 (control), 23.6813 (test)\r\n* factory_ms_node\r\n    % change:  -9.60% [-13.73%,  -5.46%]  ***\r\n    means: 98.522 (control), 89.092 (test)\r\n* ssr_pe_cold_ms_jsc_jit\r\n    % change:  -8.47% [-11.57%,  -5.37%]  ***\r\n    means: 173.219 (control), 158.576 (test)\r\n* ssr_pe_cold_ms_jsc_nojit\r\n    % change: -12.49% [-16.45%,  -8.53%]  ***\r\n    means: 210.597 (control), 184.345 (test)\r\n* ssr_pe_cold_ms_node\r\n    % change:  -7.61% [-10.66%,  -4.56%]  ***\r\n    means: 219.05 (control), 202.417 (test)\r\n```\r\n\r\nReviewers:\r\n@jimfb @vjeux "},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/243562450","html_url":"https://github.com/facebook/react/pull/7455#issuecomment-243562450","issue_url":"https://api.github.com/repos/facebook/react/issues/7455","id":243562450,"user":{"login":"keyanzhang","id":2268452,"avatar_url":"https://avatars.githubusercontent.com/u/2268452?v=3","gravatar_id":"","url":"https://api.github.com/users/keyanzhang","html_url":"https://github.com/keyanzhang","followers_url":"https://api.github.com/users/keyanzhang/followers","following_url":"https://api.github.com/users/keyanzhang/following{/other_user}","gists_url":"https://api.github.com/users/keyanzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/keyanzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyanzhang/subscriptions","organizations_url":"https://api.github.com/users/keyanzhang/orgs","repos_url":"https://api.github.com/users/keyanzhang/repos","events_url":"https://api.github.com/users/keyanzhang/events{/privacy}","received_events_url":"https://api.github.com/users/keyanzhang/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T20:06:07Z","updated_at":"2016-08-30T20:06:07Z","body":"No, it only measures time. The percentages (`-2.74% [ -7.44%,  +1.97%]`) are mean, low, and high (https://github.com/facebook/react/blob/master/scripts/bench/analyze.py#L102-L107)."}}
{"actor":{"display_login":"keyanzhang"}}