{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/comments/56923872","id":56923872,"diff_hunk":"@@ -26,11 +26,15 @@ function createCaseID () {\n  */\n function setupCase (params) {\n   return co(function * () {\n-    const uniqueID = params.caseID || uuid()\n+    // the caseID param will be in the format of notary/cases/uuid,\n+    // only check if its uuid is less than 40 characters\n+    const uniqueID = params.caseID ? params.caseID.substring(params.caseID.indexOf('/cases/') + 7) : uuid()","path":"src/notaryUtils.js","position":7,"original_position":7,"commit_id":"155d457f215daeeeab5ccb02cf4723ea686da162","original_commit_id":"155d457f215daeeeab5ccb02cf4723ea686da162","user":{"login":"emschwartz","id":3262610,"avatar_url":"https://avatars.githubusercontent.com/u/3262610?v=3","gravatar_id":"","url":"https://api.github.com/users/emschwartz","html_url":"https://github.com/emschwartz","followers_url":"https://api.github.com/users/emschwartz/followers","following_url":"https://api.github.com/users/emschwartz/following{/other_user}","gists_url":"https://api.github.com/users/emschwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/emschwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emschwartz/subscriptions","organizations_url":"https://api.github.com/users/emschwartz/orgs","repos_url":"https://api.github.com/users/emschwartz/repos","events_url":"https://api.github.com/users/emschwartz/events{/privacy}","received_events_url":"https://api.github.com/users/emschwartz/received_events","type":"User","site_admin":false},"body":"Hmm, it seems a little bit odd that the `caseID` is the only parameter that gets validated at all. Is there a specific reason to have that check that the unique id is the right length?","created_at":"2016-03-22T01:05:19Z","updated_at":"2016-03-22T01:05:19Z","html_url":"https://github.com/interledger/five-bells-sender/pull/51#discussion_r56923872","pull_request_url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/comments/56923872"},"html":{"href":"https://github.com/interledger/five-bells-sender/pull/51#discussion_r56923872"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51","id":63652259,"html_url":"https://github.com/interledger/five-bells-sender/pull/51","diff_url":"https://github.com/interledger/five-bells-sender/pull/51.diff","patch_url":"https://github.com/interledger/five-bells-sender/pull/51.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-sender/issues/51","number":51,"state":"open","locked":false,"title":"Add caseID, executionCondition, and cancellationCondition parameters","user":{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false},"body":"Add additional optional parameters to the sendPayment and executePayment functions\r\nUpdate expected format for caseID parameter to: notary/cases/uuid","created_at":"2016-03-22T00:05:55Z","updated_at":"2016-03-22T01:05:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9479dfd4433dbc54fb638abcbd2fd9809e2a5d57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-sender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-sender/issues/51/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-sender/statuses/155d457f215daeeeab5ccb02cf4723ea686da162","head":{"label":"mwshortt:add-params","ref":"add-params","sha":"155d457f215daeeeab5ccb02cf4723ea686da162","user":{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false},"repo":{"id":49610328,"name":"five-bells-sender","full_name":"mwshortt/five-bells-sender","owner":{"login":"mwshortt","id":8865272,"avatar_url":"https://avatars.githubusercontent.com/u/8865272?v=3","gravatar_id":"","url":"https://api.github.com/users/mwshortt","html_url":"https://github.com/mwshortt","followers_url":"https://api.github.com/users/mwshortt/followers","following_url":"https://api.github.com/users/mwshortt/following{/other_user}","gists_url":"https://api.github.com/users/mwshortt/gists{/gist_id}","starred_url":"https://api.github.com/users/mwshortt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwshortt/subscriptions","organizations_url":"https://api.github.com/users/mwshortt/orgs","repos_url":"https://api.github.com/users/mwshortt/repos","events_url":"https://api.github.com/users/mwshortt/events{/privacy}","received_events_url":"https://api.github.com/users/mwshortt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwshortt/five-bells-sender","description":"","fork":true,"url":"https://api.github.com/repos/mwshortt/five-bells-sender","forks_url":"https://api.github.com/repos/mwshortt/five-bells-sender/forks","keys_url":"https://api.github.com/repos/mwshortt/five-bells-sender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwshortt/five-bells-sender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwshortt/five-bells-sender/teams","hooks_url":"https://api.github.com/repos/mwshortt/five-bells-sender/hooks","issue_events_url":"https://api.github.com/repos/mwshortt/five-bells-sender/issues/events{/number}","events_url":"https://api.github.com/repos/mwshortt/five-bells-sender/events","assignees_url":"https://api.github.com/repos/mwshortt/five-bells-sender/assignees{/user}","branches_url":"https://api.github.com/repos/mwshortt/five-bells-sender/branches{/branch}","tags_url":"https://api.github.com/repos/mwshortt/five-bells-sender/tags","blobs_url":"https://api.github.com/repos/mwshortt/five-bells-sender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwshortt/five-bells-sender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwshortt/five-bells-sender/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwshortt/five-bells-sender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwshortt/five-bells-sender/statuses/{sha}","languages_url":"https://api.github.com/repos/mwshortt/five-bells-sender/languages","stargazers_url":"https://api.github.com/repos/mwshortt/five-bells-sender/stargazers","contributors_url":"https://api.github.com/repos/mwshortt/five-bells-sender/contributors","subscribers_url":"https://api.github.com/repos/mwshortt/five-bells-sender/subscribers","subscription_url":"https://api.github.com/repos/mwshortt/five-bells-sender/subscription","commits_url":"https://api.github.com/repos/mwshortt/five-bells-sender/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwshortt/five-bells-sender/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwshortt/five-bells-sender/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwshortt/five-bells-sender/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwshortt/five-bells-sender/contents/{+path}","compare_url":"https://api.github.com/repos/mwshortt/five-bells-sender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwshortt/five-bells-sender/merges","archive_url":"https://api.github.com/repos/mwshortt/five-bells-sender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwshortt/five-bells-sender/downloads","issues_url":"https://api.github.com/repos/mwshortt/five-bells-sender/issues{/number}","pulls_url":"https://api.github.com/repos/mwshortt/five-bells-sender/pulls{/number}","milestones_url":"https://api.github.com/repos/mwshortt/five-bells-sender/milestones{/number}","notifications_url":"https://api.github.com/repos/mwshortt/five-bells-sender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwshortt/five-bells-sender/labels{/name}","releases_url":"https://api.github.com/repos/mwshortt/five-bells-sender/releases{/id}","deployments_url":"https://api.github.com/repos/mwshortt/five-bells-sender/deployments","created_at":"2016-01-14T00:00:34Z","updated_at":"2016-01-14T00:00:35Z","pushed_at":"2016-03-22T00:05:35Z","git_url":"git://github.com/mwshortt/five-bells-sender.git","ssh_url":"git@github.com:mwshortt/five-bells-sender.git","clone_url":"https://github.com/mwshortt/five-bells-sender.git","svn_url":"https://github.com/mwshortt/five-bells-sender","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"aa2211e52324488b1bb8343442bed4f385f19194","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":44267012,"name":"five-bells-sender","full_name":"interledger/five-bells-sender","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-sender","description":"","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-sender","forks_url":"https://api.github.com/repos/interledger/five-bells-sender/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-sender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-sender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-sender/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-sender/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-sender/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-sender/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-sender/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-sender/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-sender/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-sender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-sender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-sender/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-sender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-sender/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-sender/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-sender/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-sender/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-sender/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-sender/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-sender/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-sender/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-sender/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-sender/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-sender/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-sender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-sender/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-sender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-sender/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-sender/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-sender/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-sender/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-sender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-sender/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-sender/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-sender/deployments","created_at":"2015-10-14T18:11:04Z","updated_at":"2016-01-13T18:58:58Z","pushed_at":"2016-03-22T00:05:55Z","git_url":"git://github.com/interledger/five-bells-sender.git","ssh_url":"git@github.com:interledger/five-bells-sender.git","clone_url":"https://github.com/interledger/five-bells-sender.git","svn_url":"https://github.com/interledger/five-bells-sender","homepage":null,"size":87,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51"},"html":{"href":"https://github.com/interledger/five-bells-sender/pull/51"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-sender/issues/51"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-sender/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-sender/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-sender/statuses/155d457f215daeeeab5ccb02cf4723ea686da162"}}}}