{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/67936612","id":67936612,"diff_hunk":"@@ -239,64 +239,3 @@ class CompatForm(BaseCompatForm):\n     _ratio_choices = [('%.1f' % (x / 10.0), '%.0f%%' % (x * 10))\n                       for x in xrange(9, -1, -1)]\n     ratio = forms.ChoiceField(choices=_ratio_choices, required=False)\n-\n-\n-class GenerateErrorForm(happyforms.Form):\n-    error = forms.ChoiceField(choices=(\n-        ['zerodivisionerror', 'Zero Division Error (will email)'],\n-        ['iorequesterror', 'IORequest Error (no email)'],\n-        ['heka_statsd', 'Heka statsd message'],\n-        ['heka_json', 'Heka JSON message'],\n-        ['heka_cef', 'Heka CEF message'],\n-        ['heka_sentry', 'Heka Sentry message'],\n-        ['amo_cef', 'AMO CEF message']))","path":"src/olympia/zadmin/forms.py","position":14,"original_position":14,"commit_id":"91bb4a6f8d6b093ade069fd487066e77c166200d","original_commit_id":"91bb4a6f8d6b093ade069fd487066e77c166200d","user":{"login":"andymckay","id":74699,"avatar_url":"https://avatars.githubusercontent.com/u/74699?v=3","gravatar_id":"","url":"https://api.github.com/users/andymckay","html_url":"https://github.com/andymckay","followers_url":"https://api.github.com/users/andymckay/followers","following_url":"https://api.github.com/users/andymckay/following{/other_user}","gists_url":"https://api.github.com/users/andymckay/gists{/gist_id}","starred_url":"https://api.github.com/users/andymckay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymckay/subscriptions","organizations_url":"https://api.github.com/users/andymckay/orgs","repos_url":"https://api.github.com/users/andymckay/repos","events_url":"https://api.github.com/users/andymckay/events{/privacy}","received_events_url":"https://api.github.com/users/andymckay/received_events","type":"User","site_admin":false},"body":"Yeah I think was mostly around when heka and CEF was coming in, we needed it to check the error went where it was meant to go to. Remove it and lets see how things go.","created_at":"2016-06-21T19:34:06Z","updated_at":"2016-06-21T19:34:06Z","html_url":"https://github.com/mozilla/addons-server/pull/2931#discussion_r67936612","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2931","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/67936612"},"html":{"href":"https://github.com/mozilla/addons-server/pull/2931#discussion_r67936612"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2931"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/2931","id":74267177,"html_url":"https://github.com/mozilla/addons-server/pull/2931","diff_url":"https://github.com/mozilla/addons-server/pull/2931.diff","patch_url":"https://github.com/mozilla/addons-server/pull/2931.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/2931","number":2931,"state":"closed","locked":false,"title":"Remove cef and heka, change some cef related code to plain logging.","user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars.githubusercontent.com/u/139033?v=3","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"body":"@andymckay @jasonthomas can you take a look at this please? Just to make sure I understood everyone correctly regarding what we can remove and what is unused. All of the cef related logs now just use the general logging pipeline.","created_at":"2016-06-17T16:09:00Z","updated_at":"2016-06-21T19:34:06Z","closed_at":"2016-06-21T19:33:01Z","merged_at":"2016-06-21T19:33:01Z","merge_commit_sha":"da902b7c64dae42a9dbdc13b1dd460fbf3376892","assignee":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2931/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2931/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/2931/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/91bb4a6f8d6b093ade069fd487066e77c166200d","head":{"label":"mozilla:remove-cef-hera","ref":"remove-cef-hera","sha":"91bb4a6f8d6b093ade069fd487066e77c166200d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"addons.mozilla.org Django app","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-06-16T19:23:45Z","pushed_at":"2016-06-21T19:33:03Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":576919,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":235,"forks":154,"open_issues":235,"watchers":102,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c12a0811f0fa38efbf19cfc1080b6b6ac7fce021","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"addons.mozilla.org Django app","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-06-16T19:23:45Z","pushed_at":"2016-06-21T19:33:03Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":576919,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":235,"forks":154,"open_issues":235,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2931"},"html":{"href":"https://github.com/mozilla/addons-server/pull/2931"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/2931"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/2931/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2931/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2931/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/91bb4a6f8d6b093ade069fd487066e77c166200d"}}}}
{"actor":{"display_login":"andymckay"}}