{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/52232182","id":52232182,"diff_hunk":"@@ -0,0 +1,62 @@\n+/*\n+ * Copyright 2015 Palantir Technologies, Inc. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.palantir.ssl;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+\n+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;\n+import com.fasterxml.jackson.databind.annotation.JsonSerialize;\n+import com.google.common.base.Optional;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import org.immutables.value.Value;\n+import org.immutables.value.Value.Style.ImplementationVisibility;\n+\n+@JsonDeserialize(as = ImmutableSslConfiguration.class)\n+@JsonSerialize(as = ImmutableSslConfiguration.class)\n+@Value.Immutable\n+@Value.Style(visibility = ImplementationVisibility.PACKAGE)\n+public abstract class SslConfiguration {","path":"ssl-config/src/main/java/com/palantir/ssl/SslConfiguration.java","position":33,"original_position":33,"commit_id":"4828c422c3d298f02733a404eda7bb318fdea295","original_commit_id":"4828c422c3d298f02733a404eda7bb318fdea295","user":{"login":"nmiyake","id":4267425,"avatar_url":"https://avatars.githubusercontent.com/u/4267425?v=3","gravatar_id":"","url":"https://api.github.com/users/nmiyake","html_url":"https://github.com/nmiyake","followers_url":"https://api.github.com/users/nmiyake/followers","following_url":"https://api.github.com/users/nmiyake/following{/other_user}","gists_url":"https://api.github.com/users/nmiyake/gists{/gist_id}","starred_url":"https://api.github.com/users/nmiyake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmiyake/subscriptions","organizations_url":"https://api.github.com/users/nmiyake/orgs","repos_url":"https://api.github.com/users/nmiyake/repos","events_url":"https://api.github.com/users/nmiyake/events{/privacy}","received_events_url":"https://api.github.com/users/nmiyake/received_events","type":"User","site_admin":false},"body":"Might make sense to make that scenario easier, but I have some reservations about requiring that. In scenarios where the client actually has 2 separate JKS/PKCS 12 stores for trust and key, doing so would require them to run keytool to manually merge them, which is overhead at best and not possible for them to do at worst.","created_at":"2016-02-08T21:56:03Z","updated_at":"2016-02-08T21:56:03Z","html_url":"https://github.com/palantir/http-remoting/pull/35#discussion_r52232182","pull_request_url":"https://api.github.com/repos/palantir/http-remoting/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/52232182"},"html":{"href":"https://github.com/palantir/http-remoting/pull/35#discussion_r52232182"},"pull_request":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/35","id":58536382,"html_url":"https://github.com/palantir/http-remoting/pull/35","diff_url":"https://github.com/palantir/http-remoting/pull/35.diff","patch_url":"https://github.com/palantir/http-remoting/pull/35.patch","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/35","number":35,"state":"open","locked":false,"title":"Add ability to specify keystore for SSLSocketFactory","user":{"login":"nmiyake","id":4267425,"avatar_url":"https://avatars.githubusercontent.com/u/4267425?v=3","gravatar_id":"","url":"https://api.github.com/users/nmiyake","html_url":"https://github.com/nmiyake","followers_url":"https://api.github.com/users/nmiyake/followers","following_url":"https://api.github.com/users/nmiyake/following{/other_user}","gists_url":"https://api.github.com/users/nmiyake/gists{/gist_id}","starred_url":"https://api.github.com/users/nmiyake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmiyake/subscriptions","organizations_url":"https://api.github.com/users/nmiyake/orgs","repos_url":"https://api.github.com/users/nmiyake/repos","events_url":"https://api.github.com/users/nmiyake/events{/privacy}","received_events_url":"https://api.github.com/users/nmiyake/received_events","type":"User","site_admin":false},"body":"Fixes issue #22","created_at":"2016-02-07T02:11:30Z","updated_at":"2016-02-08T21:56:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215d85a46c785ac163a299df5d1c18dc7a8c539b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/http-remoting/pulls/35/commits","review_comments_url":"https://api.github.com/repos/palantir/http-remoting/pulls/35/comments","review_comment_url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/35/comments","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/4828c422c3d298f02733a404eda7bb318fdea295","head":{"label":"nmiyake:feature/keystore","ref":"feature/keystore","sha":"4828c422c3d298f02733a404eda7bb318fdea295","user":{"login":"nmiyake","id":4267425,"avatar_url":"https://avatars.githubusercontent.com/u/4267425?v=3","gravatar_id":"","url":"https://api.github.com/users/nmiyake","html_url":"https://github.com/nmiyake","followers_url":"https://api.github.com/users/nmiyake/followers","following_url":"https://api.github.com/users/nmiyake/following{/other_user}","gists_url":"https://api.github.com/users/nmiyake/gists{/gist_id}","starred_url":"https://api.github.com/users/nmiyake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmiyake/subscriptions","organizations_url":"https://api.github.com/users/nmiyake/orgs","repos_url":"https://api.github.com/users/nmiyake/repos","events_url":"https://api.github.com/users/nmiyake/events{/privacy}","received_events_url":"https://api.github.com/users/nmiyake/received_events","type":"User","site_admin":false},"repo":{"id":51133715,"name":"http-remoting","full_name":"nmiyake/http-remoting","owner":{"login":"nmiyake","id":4267425,"avatar_url":"https://avatars.githubusercontent.com/u/4267425?v=3","gravatar_id":"","url":"https://api.github.com/users/nmiyake","html_url":"https://github.com/nmiyake","followers_url":"https://api.github.com/users/nmiyake/followers","following_url":"https://api.github.com/users/nmiyake/following{/other_user}","gists_url":"https://api.github.com/users/nmiyake/gists{/gist_id}","starred_url":"https://api.github.com/users/nmiyake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmiyake/subscriptions","organizations_url":"https://api.github.com/users/nmiyake/orgs","repos_url":"https://api.github.com/users/nmiyake/repos","events_url":"https://api.github.com/users/nmiyake/events{/privacy}","received_events_url":"https://api.github.com/users/nmiyake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmiyake/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":true,"url":"https://api.github.com/repos/nmiyake/http-remoting","forks_url":"https://api.github.com/repos/nmiyake/http-remoting/forks","keys_url":"https://api.github.com/repos/nmiyake/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmiyake/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmiyake/http-remoting/teams","hooks_url":"https://api.github.com/repos/nmiyake/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/nmiyake/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/nmiyake/http-remoting/events","assignees_url":"https://api.github.com/repos/nmiyake/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/nmiyake/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/nmiyake/http-remoting/tags","blobs_url":"https://api.github.com/repos/nmiyake/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmiyake/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmiyake/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmiyake/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmiyake/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/nmiyake/http-remoting/languages","stargazers_url":"https://api.github.com/repos/nmiyake/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/nmiyake/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/nmiyake/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/nmiyake/http-remoting/subscription","commits_url":"https://api.github.com/repos/nmiyake/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmiyake/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmiyake/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmiyake/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmiyake/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/nmiyake/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmiyake/http-remoting/merges","archive_url":"https://api.github.com/repos/nmiyake/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmiyake/http-remoting/downloads","issues_url":"https://api.github.com/repos/nmiyake/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/nmiyake/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/nmiyake/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/nmiyake/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmiyake/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/nmiyake/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/nmiyake/http-remoting/deployments","created_at":"2016-02-05T07:58:45Z","updated_at":"2016-02-05T07:58:46Z","pushed_at":"2016-02-07T02:55:54Z","git_url":"git://github.com/nmiyake/http-remoting.git","ssh_url":"git@github.com:nmiyake/http-remoting.git","clone_url":"https://github.com/nmiyake/http-remoting.git","svn_url":"https://github.com/nmiyake/http-remoting","homepage":"","size":166,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"ae92703cd2b080f571fb5bdbf3d622b39381f4e8","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":43088077,"name":"http-remoting","full_name":"palantir/http-remoting","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":false,"url":"https://api.github.com/repos/palantir/http-remoting","forks_url":"https://api.github.com/repos/palantir/http-remoting/forks","keys_url":"https://api.github.com/repos/palantir/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/http-remoting/teams","hooks_url":"https://api.github.com/repos/palantir/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/palantir/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/http-remoting/events","assignees_url":"https://api.github.com/repos/palantir/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/http-remoting/tags","blobs_url":"https://api.github.com/repos/palantir/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/http-remoting/languages","stargazers_url":"https://api.github.com/repos/palantir/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/palantir/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/palantir/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/palantir/http-remoting/subscription","commits_url":"https://api.github.com/repos/palantir/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/http-remoting/merges","archive_url":"https://api.github.com/repos/palantir/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/http-remoting/downloads","issues_url":"https://api.github.com/repos/palantir/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/palantir/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/http-remoting/deployments","created_at":"2015-09-24T19:24:22Z","updated_at":"2016-02-07T22:25:28Z","pushed_at":"2016-02-08T20:56:27Z","git_url":"git://github.com/palantir/http-remoting.git","ssh_url":"git@github.com:palantir/http-remoting.git","clone_url":"https://github.com/palantir/http-remoting.git","svn_url":"https://github.com/palantir/http-remoting","homepage":"","size":189,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/35"},"html":{"href":"https://github.com/palantir/http-remoting/pull/35"},"issue":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/35"},"comments":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/http-remoting/statuses/4828c422c3d298f02733a404eda7bb318fdea295"}}}}