{"action":"created","issue":{"url":"https://api.github.com/repos/elmokki/nationgen/issues/519","repository_url":"https://api.github.com/repos/elmokki/nationgen","labels_url":"https://api.github.com/repos/elmokki/nationgen/issues/519/labels{/name}","comments_url":"https://api.github.com/repos/elmokki/nationgen/issues/519/comments","events_url":"https://api.github.com/repos/elmokki/nationgen/issues/519/events","html_url":"https://github.com/elmokki/nationgen/pull/519","id":159317272,"number":519,"title":"Fixed bug with highestcaponlychance","user":{"login":"Ealb","id":12613576,"avatar_url":"https://avatars.githubusercontent.com/u/12613576?v=3","gravatar_id":"","url":"https://api.github.com/users/Ealb","html_url":"https://github.com/Ealb","followers_url":"https://api.github.com/users/Ealb/followers","following_url":"https://api.github.com/users/Ealb/following{/other_user}","gists_url":"https://api.github.com/users/Ealb/gists{/gist_id}","starred_url":"https://api.github.com/users/Ealb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ealb/subscriptions","organizations_url":"https://api.github.com/users/Ealb/orgs","repos_url":"https://api.github.com/users/Ealb/repos","events_url":"https://api.github.com/users/Ealb/events{/privacy}","received_events_url":"https://api.github.com/users/Ealb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-09T02:37:19Z","updated_at":"2016-06-09T16:48:54Z","closed_at":"2016-06-09T02:37:38Z","pull_request":{"url":"https://api.github.com/repos/elmokki/nationgen/pulls/519","html_url":"https://github.com/elmokki/nationgen/pull/519","diff_url":"https://github.com/elmokki/nationgen/pull/519.diff","patch_url":"https://github.com/elmokki/nationgen/pull/519.patch"},"body":"I'm fairly certain this was a bug and not a data error, anyway: #caponlychance is currently used in the data files as a double from 0 - 1, and SacredGenerator was trying to read the arguments to #caponlychance by doing a cdr of the argument, so if the caponlychance was 1 (or 0) it would have an array index out of bounds exception."},"comment":{"url":"https://api.github.com/repos/elmokki/nationgen/issues/comments/224956280","html_url":"https://github.com/elmokki/nationgen/pull/519#issuecomment-224956280","issue_url":"https://api.github.com/repos/elmokki/nationgen/issues/519","id":224956280,"user":{"login":"Ealb","id":12613576,"avatar_url":"https://avatars.githubusercontent.com/u/12613576?v=3","gravatar_id":"","url":"https://api.github.com/users/Ealb","html_url":"https://github.com/Ealb","followers_url":"https://api.github.com/users/Ealb/followers","following_url":"https://api.github.com/users/Ealb/following{/other_user}","gists_url":"https://api.github.com/users/Ealb/gists{/gist_id}","starred_url":"https://api.github.com/users/Ealb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ealb/subscriptions","organizations_url":"https://api.github.com/users/Ealb/orgs","repos_url":"https://api.github.com/users/Ealb/repos","events_url":"https://api.github.com/users/Ealb/events{/privacy}","received_events_url":"https://api.github.com/users/Ealb/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T16:48:54Z","updated_at":"2016-06-09T16:48:54Z","body":"If str = [1], str = [1, OutOfBounds, OutOfBounds, OutOfBounds, etc]. substring(1) was always going to start reading with the first of those OutOfBounds if the double was a whole number.\r\n\r\nFrankly, I'm surprised I figured this out given how plainly and incoherently tired I was last night."}}
{"actor":{"display_login":"Ealb"}}