{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/86018078","pull_request_review_id":6698439,"id":86018078,"diff_hunk":"@@ -304,45 +304,62 @@ protected override Task<string> GenerateKeyAsync(object entity)\n             return Conventions.GenerateDocumentKeyAsync(DatabaseName, AsyncDatabaseCommands, entity);\n         }\n \n-        public async Task<BlittableJsonReaderObject> GetMetadataForAsync<T>(T instance)\n+        private readonly List<object> _entitiesWithMetadataInstance = new List<object>();","path":"src/Raven.Client/Documents/Async/AsyncDocumentSession.cs","position":38,"original_position":38,"commit_id":"df5ef7b5a43ef186dfe75d65e6d8be60023dbeeb","original_commit_id":"3628dd21affa2d877af6db6eccc8fd20a48fc9db","user":{"login":"ayende","id":116915,"avatar_url":"https://avatars.githubusercontent.com/u/116915?v=3","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"This needs to be removed, there is not need of it","created_at":"2016-11-01T20:33:14Z","updated_at":"2016-11-01T20:37:38Z","html_url":"https://github.com/ravendb/ravendb/pull/753#discussion_r86018078","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/753","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/86018078"},"html":{"href":"https://github.com/ravendb/ravendb/pull/753#discussion_r86018078"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/753"}}},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/753","id":91857695,"html_url":"https://github.com/ravendb/ravendb/pull/753","diff_url":"https://github.com/ravendb/ravendb/pull/753.diff","patch_url":"https://github.com/ravendb/ravendb/pull/753.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/753","number":753,"state":"open","locked":false,"title":"Reworking on PR #745","user":{"login":"ayende","id":116915,"avatar_url":"https://avatars.githubusercontent.com/u/116915?v=3","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"body":"Make it easier to review: https://github.com/ravendb/ravendb/pull/745","created_at":"2016-11-01T20:31:57Z","updated_at":"2016-11-01T20:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94a3cfeed676a7cf3dce3ec90c141f2110c8211f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/753/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/753/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/753/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/df5ef7b5a43ef186dfe75d65e6d8be60023dbeeb","head":{"label":"ayende:v4.0","ref":"v4.0","sha":"df5ef7b5a43ef186dfe75d65e6d8be60023dbeeb","user":{"login":"ayende","id":116915,"avatar_url":"https://avatars.githubusercontent.com/u/116915?v=3","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"repo":{"id":904641,"name":"ravendb","full_name":"ayende/ravendb","owner":{"login":"ayende","id":116915,"avatar_url":"https://avatars.githubusercontent.com/u/116915?v=3","gravatar_id":"","url":"https://api.github.com/users/ayende","html_url":"https://github.com/ayende","followers_url":"https://api.github.com/users/ayende/followers","following_url":"https://api.github.com/users/ayende/following{/other_user}","gists_url":"https://api.github.com/users/ayende/gists{/gist_id}","starred_url":"https://api.github.com/users/ayende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayende/subscriptions","organizations_url":"https://api.github.com/users/ayende/orgs","repos_url":"https://api.github.com/users/ayende/repos","events_url":"https://api.github.com/users/ayende/events{/privacy}","received_events_url":"https://api.github.com/users/ayende/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayende/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/ayende/ravendb","forks_url":"https://api.github.com/repos/ayende/ravendb/forks","keys_url":"https://api.github.com/repos/ayende/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayende/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayende/ravendb/teams","hooks_url":"https://api.github.com/repos/ayende/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ayende/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ayende/ravendb/events","assignees_url":"https://api.github.com/repos/ayende/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ayende/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ayende/ravendb/tags","blobs_url":"https://api.github.com/repos/ayende/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayende/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayende/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayende/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayende/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ayende/ravendb/languages","stargazers_url":"https://api.github.com/repos/ayende/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ayende/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ayende/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ayende/ravendb/subscription","commits_url":"https://api.github.com/repos/ayende/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayende/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayende/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayende/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayende/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ayende/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayende/ravendb/merges","archive_url":"https://api.github.com/repos/ayende/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayende/ravendb/downloads","issues_url":"https://api.github.com/repos/ayende/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ayende/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ayende/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ayende/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayende/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ayende/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ayende/ravendb/deployments","created_at":"2010-09-12T05:30:13Z","updated_at":"2016-10-29T19:23:13Z","pushed_at":"2016-11-01T20:30:44Z","git_url":"git://github.com/ayende/ravendb.git","ssh_url":"git@github.com:ayende/ravendb.git","clone_url":"https://github.com/ayende/ravendb.git","svn_url":"https://github.com/ayende/ravendb","homepage":"http://ayende.com/Blog/","size":505146,"stargazers_count":284,"watchers_count":284,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":0,"forks":146,"open_issues":0,"watchers":284,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.0","ref":"v4.0","sha":"6c1245794b4a03807b5364e68bf0fba1b0f91750","user":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"A linq enabled document database for .NET","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2016-11-01T05:30:17Z","pushed_at":"2016-11-01T20:31:57Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"http://ravendb.net","size":409713,"stargazers_count":1579,"watchers_count":1579,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":6,"forks":642,"open_issues":6,"watchers":1579,"default_branch":"v3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/753"},"html":{"href":"https://github.com/ravendb/ravendb/pull/753"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/753"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/df5ef7b5a43ef186dfe75d65e6d8be60023dbeeb"}}}}
{"actor":{"display_login":"ayende"}}