{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/81969163","pull_request_review_id":2909277,"id":81969163,"diff_hunk":"@@ -42,15 +42,17 @@ func TestGossipFirstRange(t *testing.T) {\n \n \terrors := make(chan error)\n \tdescs := make(chan *roachpb.RangeDescriptor)\n-\ttc.Servers[0].Gossip().RegisterCallback(gossip.KeyFirstRangeDescriptor,\n+\tunregister := tc.Servers[0].Gossip().RegisterCallback(gossip.KeyFirstRangeDescriptor,\n \t\tfunc(_ string, content roachpb.Value) {\n \t\t\tvar desc roachpb.RangeDescriptor\n \t\t\tif err := content.GetProto(&desc); err != nil {\n \t\t\t\terrors <- err\n \t\t\t} else {\n \t\t\t\tdescs <- &desc\n \t\t\t}\n-\t\t})\n+\t\t},\n+\t)\n+\tdefer unregister()","path":"storage/gossip_test.go","position":16,"original_position":16,"commit_id":"68b4a49ce624413aa8d724ba831a4d5e4fd4702a","original_commit_id":"68b4a49ce624413aa8d724ba831a4d5e4fd4702a","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"body":"Isn't this still flaky, at least in theory? You read `errors` for the last time in  line 105, so anytime after that a firing callback will still lose a goroutine.","created_at":"2016-10-05T13:18:45Z","updated_at":"2016-10-05T13:18:45Z","html_url":"https://github.com/cockroachdb/cockroach/pull/9747#discussion_r81969163","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/81969163"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/9747#discussion_r81969163"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747","id":88069149,"html_url":"https://github.com/cockroachdb/cockroach/pull/9747","diff_url":"https://github.com/cockroachdb/cockroach/pull/9747.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/9747.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9747","number":9747,"state":"open","locked":false,"title":"storage: deflake TestGossipFirstRange","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"The channel used in this test is unbuffered, so it was possible for an\r\n\"extra\" gossip callback to fire while the test is shutting down. This\r\ncommit unregisters the gossip callback before the test exits.\r\n\r\nFixes #9746.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/9747)\n<!-- Reviewable:end -->\n","created_at":"2016-10-05T12:36:15Z","updated_at":"2016-10-05T13:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"476a9ac035a328d602e30b4649ff401d77fc0941","assignee":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"assignees":[{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9747/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/68b4a49ce624413aa8d724ba831a4d5e4fd4702a","head":{"label":"tamird:deflake-gossip-first-range","ref":"deflake-gossip-first-range","sha":"68b4a49ce624413aa8d724ba831a4d5e4fd4702a","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":35114205,"name":"cockroach","full_name":"tamird/cockroach","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/tamird/cockroach","forks_url":"https://api.github.com/repos/tamird/cockroach/forks","keys_url":"https://api.github.com/repos/tamird/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/cockroach/teams","hooks_url":"https://api.github.com/repos/tamird/cockroach/hooks","issue_events_url":"https://api.github.com/repos/tamird/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/cockroach/events","assignees_url":"https://api.github.com/repos/tamird/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/cockroach/tags","blobs_url":"https://api.github.com/repos/tamird/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/cockroach/languages","stargazers_url":"https://api.github.com/repos/tamird/cockroach/stargazers","contributors_url":"https://api.github.com/repos/tamird/cockroach/contributors","subscribers_url":"https://api.github.com/repos/tamird/cockroach/subscribers","subscription_url":"https://api.github.com/repos/tamird/cockroach/subscription","commits_url":"https://api.github.com/repos/tamird/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/cockroach/merges","archive_url":"https://api.github.com/repos/tamird/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/cockroach/downloads","issues_url":"https://api.github.com/repos/tamird/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/tamird/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/tamird/cockroach/deployments","created_at":"2015-05-05T17:34:04Z","updated_at":"2016-01-11T18:59:48Z","pushed_at":"2016-10-05T13:13:22Z","git_url":"git://github.com/tamird/cockroach.git","ssh_url":"git@github.com:tamird/cockroach.git","clone_url":"https://github.com/tamird/cockroach.git","svn_url":"https://github.com/tamird/cockroach","homepage":null,"size":201113,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"1432e7be3c7efb4601a0d33f961ca392ad0805a7","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-10-05T13:11:24Z","pushed_at":"2016-10-05T13:13:27Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":361063,"stargazers_count":7665,"watchers_count":7665,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":764,"mirror_url":null,"open_issues_count":712,"forks":764,"open_issues":712,"watchers":7665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/9747"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/9747"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/9747/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9747/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/68b4a49ce624413aa8d724ba831a4d5e4fd4702a"}}}}
{"actor":{"display_login":"tschottdorf"}}