{"action":"closed","issue":{"url":"https://api.github.com/repos/Jasonette/documentation/issues/15","repository_url":"https://api.github.com/repos/Jasonette/documentation","labels_url":"https://api.github.com/repos/Jasonette/documentation/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Jasonette/documentation/issues/15/comments","events_url":"https://api.github.com/repos/Jasonette/documentation/issues/15/events","html_url":"https://github.com/Jasonette/documentation/issues/15","id":197469134,"number":15,"title":"Accepting suggestions for the loading indicator attribute name","user":{"login":"gliechtenstein","id":16613330,"avatar_url":"https://avatars.githubusercontent.com/u/16613330?v=3","gravatar_id":"","url":"https://api.github.com/users/gliechtenstein","html_url":"https://github.com/gliechtenstein","followers_url":"https://api.github.com/users/gliechtenstein/followers","following_url":"https://api.github.com/users/gliechtenstein/following{/other_user}","gists_url":"https://api.github.com/users/gliechtenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/gliechtenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gliechtenstein/subscriptions","organizations_url":"https://api.github.com/users/gliechtenstein/orgs","repos_url":"https://api.github.com/users/gliechtenstein/repos","events_url":"https://api.github.com/users/gliechtenstein/events{/privacy}","received_events_url":"https://api.github.com/users/gliechtenstein/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-12-24T16:25:22Z","updated_at":"2016-12-25T22:46:20Z","closed_at":"2016-12-25T22:46:20Z","body":"Here's a pull request by @wajahatch888 waiting to be merged for a loading indicator: https://github.com/Jasonette/JASONETTE-iOS/pull/87\r\n\r\nI've tried it and it works awesome. One thing I want to make sure is we name this attribute the best way possible. So far we're calling it `loading`, which looks like this:\r\n\r\n## For `href`\r\n\r\n```\r\n{\r\n  \"type\": \"label\",\r\n  \"text\": \"Go\",\r\n  \"href\": {\r\n    \"url\": \"https://....\",\r\n    \"loading\": \"true\"\r\n  }\r\n}\r\n```\r\n\r\n## For `$network.request`\r\n\r\n```\r\n{\r\n  \"type\": \"$network.request\",\r\n  \"options\": {\r\n    \"url\": \"https://....\"\r\n    \"loading\": \"true\"\r\n  }\r\n}\r\n```\r\n\r\nThe question is:  **Can we come up with a better naming than `loading`?**\r\n\r\nPlease feel free to share ideas if anyone has a better name suggestion for this attribute. Thanks!\r\n"}}
{"actor":{"display_login":"gliechtenstein"}}