{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13687","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13687/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13687/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13687/events","html_url":"https://github.com/edx/edx-platform/pull/13687","id":181572897,"number":13687,"title":"[ENT-17] Implement basics of UserDataSharingConsentAudit","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-07T02:32:10Z","updated_at":"2016-10-08T00:03:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13687","html_url":"https://github.com/edx/edx-platform/pull/13687","diff_url":"https://github.com/edx/edx-platform/pull/13687.diff","patch_url":"https://github.com/edx/edx-platform/pull/13687.patch"},"body":"This pull request brings into place the very basics of ENT-17, in the form of a consent audit model, as well as a historical record. Due to the necessity of manual testing, it also brings the basic form of additional views and form changes that are necessary to take advantage of the model change.\r\n\r\n**JIRA tickets**: Implements ENT-17\r\n\r\n**Discussions**: Discussion and discovery on ENT-24\r\n\r\n**Dependencies**: None\r\n\r\n**Sandbox URL**: TBD - sandbox is being provisioned.\r\n\r\n**Testing instructions**:\r\n\r\n1. In the sandbox admin, verify that the TestShib SAML IdP is set to neither require nor request data sharing consent.\r\n2. Register a new user, using the TestShib SAML IdP. Verify that the process is identical to the one that exists now.\r\n3. Disconnect that user from the IdP and sign out.\r\n4. Modify the TestShib SAML IdP setting to request data sharing consent.\r\n5. Register a new user, using the TestShib SAML IdP, noting that a checkbox for consent is present, checking it.\r\n6. In the admin panel, note that DataSharingConsentAudit object for this user notes that data sharing is permitted.\r\n7. Disconnect this user from the IdP and sign out.\r\n8. Register a new user, using the TestShib SAML IdP, noting that a checkbox for consent is present, but leaving it blank.\r\n9. Sign out of this user, but do not disconnect it from the IdP.\r\n10. In the admin panel, note that the DataSharingConsentAudit for this user notes that data sharing is not permitted.\r\n11. In the admin panel, set the TestShib SAML IdP to require data sharing consent.\r\n12. Attempt to sign in, using the TestShib SAML user account you registered previously. Note that it redirects you to a page stating that additional permissions are required, and that if you manually browse elsewhere, you are not logged in.\r\n13. In the admin panel, remove the requirement for data sharing consent on the TestShib SAML IdP.\r\n14. Log in with the TestShib user, noting that you can do so successfully.\r\n15. Disconnect the user from the IdP and sign out.\r\n16. In the admin panel, re-enable the requirement for data sharing consent on the TestShib SAML IdP.\r\n17. Attempt to register a new user using the TestShib SAML IdP. Note that the checkbox for data sharing consent is present; note that if you attempt to register a user without checking it, you encounter an error message.\r\n18. Note that once registered, the OpenEdX platform behaves normally.\r\n\r\n**Author notes and concerns**:\r\n\r\n1. There are a couple things included in this PR that are not required by ENT-17, but which were necessary to fully test behavior - for example, the addition of the data sharing consent checkbox to the registration form.\r\n\r\n**Reviewers**\r\n- [ ] @e-kolpakov \r\n- [ ] @douglashall \r\n- [ ] @mattdrayer \r\n- [ ] @edx/devops \r\n\r\n**Settings**\r\n```yaml\r\nEDXAPP_FEATURES:\r\n  ENABLE_COMBINED_LOGIN_REGISTRATION: true\r\n  ENABLE_THIRD_PARTY_AUTH: true\r\n```"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/252387620","html_url":"https://github.com/edx/edx-platform/pull/13687#issuecomment-252387620","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13687","id":252387620,"user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"created_at":"2016-10-08T00:03:48Z","updated_at":"2016-10-08T00:03:48Z","body":"jenkins run lettuce"}}
{"actor":{"display_login":"haikuginger"}}