{"action":"created","issue":{"url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40","repository_url":"https://api.github.com/repos/japaric/rustc-builtins","labels_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40/comments","events_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40/events","html_url":"https://github.com/japaric/rustc-builtins/pull/40","id":171570044,"number":40,"title":"Add x86_64 builtins","user":{"login":"mattico","id":853158,"avatar_url":"https://avatars.githubusercontent.com/u/853158?v=3","gravatar_id":"","url":"https://api.github.com/users/mattico","html_url":"https://github.com/mattico","followers_url":"https://api.github.com/users/mattico/followers","following_url":"https://api.github.com/users/mattico/following{/other_user}","gists_url":"https://api.github.com/users/mattico/gists{/gist_id}","starred_url":"https://api.github.com/users/mattico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattico/subscriptions","organizations_url":"https://api.github.com/users/mattico/orgs","repos_url":"https://api.github.com/users/mattico/repos","events_url":"https://api.github.com/users/mattico/events{/privacy}","received_events_url":"https://api.github.com/users/mattico/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-17T04:05:32Z","updated_at":"2016-08-19T01:32:07Z","closed_at":"2016-08-19T01:31:53Z","pull_request":{"url":"https://api.github.com/repos/japaric/rustc-builtins/pulls/40","html_url":"https://github.com/japaric/rustc-builtins/pull/40","diff_url":"https://github.com/japaric/rustc-builtins/pull/40.diff","patch_url":"https://github.com/japaric/rustc-builtins/pull/40.patch"},"body":"This is a fairly straightforward port of the original assembly files. I'm hoping to help port a whole bunch of these builtins over the next few days, so let me know if you have any style or other concerns. I don't believe that these functions have any tests in compiler-rt and they would be quite difficult functions to test. Nonetheless, I'm going to attempt to find a windows binary that exercises these and swap them in to see if anything breaks.\r\n\r\nTwo notes:\r\n- `__alloca` falls through to `___chkstk` in the original assembly. I think having a function call there is the best way to implement this reliably, other than duplicating the assembly.\r\n- The original assembly files don't appear to be conditionally compiled, but are noted as only being used on Windows, so I am conditionally compiling them now."},"comment":{"url":"https://api.github.com/repos/japaric/rustc-builtins/issues/comments/240904637","html_url":"https://github.com/japaric/rustc-builtins/pull/40#issuecomment-240904637","issue_url":"https://api.github.com/repos/japaric/rustc-builtins/issues/40","id":240904637,"user":{"login":"japaric","id":5018213,"avatar_url":"https://avatars.githubusercontent.com/u/5018213?v=3","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T01:32:07Z","updated_at":"2016-08-19T01:32:07Z","body":"Thank you @mattico!"}}
{"actor":{"display_login":"japaric"}}