{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63","id":87355399,"html_url":"https://github.com/peace-4-you/TI2206-2016-2017/pull/63","diff_url":"https://github.com/peace-4-you/TI2206-2016-2017/pull/63.diff","patch_url":"https://github.com/peace-4-you/TI2206-2016-2017/pull/63.patch","issue_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/63","number":63,"state":"closed","locked":false,"title":"Refactoring Arena (and a bit of Game) into Collision and BubbleStorage class","user":{"login":"defnoob","id":8947593,"avatar_url":"https://avatars.githubusercontent.com/u/8947593?v=3","gravatar_id":"","url":"https://api.github.com/users/defnoob","html_url":"https://github.com/defnoob","followers_url":"https://api.github.com/users/defnoob/followers","following_url":"https://api.github.com/users/defnoob/following{/other_user}","gists_url":"https://api.github.com/users/defnoob/gists{/gist_id}","starred_url":"https://api.github.com/users/defnoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defnoob/subscriptions","organizations_url":"https://api.github.com/users/defnoob/orgs","repos_url":"https://api.github.com/users/defnoob/repos","events_url":"https://api.github.com/users/defnoob/events{/privacy}","received_events_url":"https://api.github.com/users/defnoob/received_events","type":"User","site_admin":false},"body":"I probably plan on actually refactoring the code inside the methods themselves at some point, but seeing as there were new classes being added, I decided to refrain from that.\r\n\r\nThe remaining checkstyle violations are mostl TODO's, magic numbers and others.\r\n\r\nFull list of the rest:\r\n-avoid inline conditional(No, at least not now)\r\n-finals(which can't happen in these cases)\r\n-longer than 80 chars(I tried...)","created_at":"2016-09-29T17:14:14Z","updated_at":"2016-09-30T12:17:49Z","closed_at":"2016-09-30T12:17:49Z","merged_at":"2016-09-30T12:17:49Z","merge_commit_sha":"be1148dbae6ecb0364fb8218872f15b0d30c583d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63/commits","review_comments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63/comments","review_comment_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/comments{/number}","comments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/63/comments","statuses_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/statuses/9e26eaad769e8366e3df1279fd6242e3bddca900","head":{"label":"peace-4-you:restructuring","ref":"restructuring","sha":"9e26eaad769e8366e3df1279fd6242e3bddca900","user":{"login":"peace-4-you","id":14056877,"avatar_url":"https://avatars.githubusercontent.com/u/14056877?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-4-you","html_url":"https://github.com/peace-4-you","followers_url":"https://api.github.com/users/peace-4-you/followers","following_url":"https://api.github.com/users/peace-4-you/following{/other_user}","gists_url":"https://api.github.com/users/peace-4-you/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-4-you/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-4-you/subscriptions","organizations_url":"https://api.github.com/users/peace-4-you/orgs","repos_url":"https://api.github.com/users/peace-4-you/repos","events_url":"https://api.github.com/users/peace-4-you/events{/privacy}","received_events_url":"https://api.github.com/users/peace-4-you/received_events","type":"User","site_admin":false},"repo":{"id":67405358,"name":"TI2206-2016-2017","full_name":"peace-4-you/TI2206-2016-2017","owner":{"login":"peace-4-you","id":14056877,"avatar_url":"https://avatars.githubusercontent.com/u/14056877?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-4-you","html_url":"https://github.com/peace-4-you","followers_url":"https://api.github.com/users/peace-4-you/followers","following_url":"https://api.github.com/users/peace-4-you/following{/other_user}","gists_url":"https://api.github.com/users/peace-4-you/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-4-you/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-4-you/subscriptions","organizations_url":"https://api.github.com/users/peace-4-you/orgs","repos_url":"https://api.github.com/users/peace-4-you/repos","events_url":"https://api.github.com/users/peace-4-you/events{/privacy}","received_events_url":"https://api.github.com/users/peace-4-you/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peace-4-you/TI2206-2016-2017","description":"Project Bust-a-move game","fork":false,"url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017","forks_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/forks","keys_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/teams","hooks_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/hooks","issue_events_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/events{/number}","events_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/events","assignees_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/assignees{/user}","branches_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/branches{/branch}","tags_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/tags","blobs_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/languages","stargazers_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/stargazers","contributors_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/contributors","subscribers_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/subscribers","subscription_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/subscription","commits_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/contents/{+path}","compare_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/merges","archive_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/downloads","issues_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues{/number}","pulls_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/labels{/name}","releases_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/releases{/id}","deployments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/deployments","created_at":"2016-09-05T09:04:32Z","updated_at":"2016-09-07T09:06:39Z","pushed_at":"2016-09-30T12:17:50Z","git_url":"git://github.com/peace-4-you/TI2206-2016-2017.git","ssh_url":"git@github.com:peace-4-you/TI2206-2016-2017.git","clone_url":"https://github.com/peace-4-you/TI2206-2016-2017.git","svn_url":"https://github.com/peace-4-you/TI2206-2016-2017","homepage":"","size":9829,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"peace-4-you:development","ref":"development","sha":"092b0b8bcc14e94765f8b640cf6ad795d9e51e4c","user":{"login":"peace-4-you","id":14056877,"avatar_url":"https://avatars.githubusercontent.com/u/14056877?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-4-you","html_url":"https://github.com/peace-4-you","followers_url":"https://api.github.com/users/peace-4-you/followers","following_url":"https://api.github.com/users/peace-4-you/following{/other_user}","gists_url":"https://api.github.com/users/peace-4-you/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-4-you/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-4-you/subscriptions","organizations_url":"https://api.github.com/users/peace-4-you/orgs","repos_url":"https://api.github.com/users/peace-4-you/repos","events_url":"https://api.github.com/users/peace-4-you/events{/privacy}","received_events_url":"https://api.github.com/users/peace-4-you/received_events","type":"User","site_admin":false},"repo":{"id":67405358,"name":"TI2206-2016-2017","full_name":"peace-4-you/TI2206-2016-2017","owner":{"login":"peace-4-you","id":14056877,"avatar_url":"https://avatars.githubusercontent.com/u/14056877?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-4-you","html_url":"https://github.com/peace-4-you","followers_url":"https://api.github.com/users/peace-4-you/followers","following_url":"https://api.github.com/users/peace-4-you/following{/other_user}","gists_url":"https://api.github.com/users/peace-4-you/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-4-you/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-4-you/subscriptions","organizations_url":"https://api.github.com/users/peace-4-you/orgs","repos_url":"https://api.github.com/users/peace-4-you/repos","events_url":"https://api.github.com/users/peace-4-you/events{/privacy}","received_events_url":"https://api.github.com/users/peace-4-you/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peace-4-you/TI2206-2016-2017","description":"Project Bust-a-move game","fork":false,"url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017","forks_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/forks","keys_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/teams","hooks_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/hooks","issue_events_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/events{/number}","events_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/events","assignees_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/assignees{/user}","branches_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/branches{/branch}","tags_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/tags","blobs_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/languages","stargazers_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/stargazers","contributors_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/contributors","subscribers_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/subscribers","subscription_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/subscription","commits_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/contents/{+path}","compare_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/merges","archive_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/downloads","issues_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues{/number}","pulls_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/labels{/name}","releases_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/releases{/id}","deployments_url":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/deployments","created_at":"2016-09-05T09:04:32Z","updated_at":"2016-09-07T09:06:39Z","pushed_at":"2016-09-30T12:17:50Z","git_url":"git://github.com/peace-4-you/TI2206-2016-2017.git","ssh_url":"git@github.com:peace-4-you/TI2206-2016-2017.git","clone_url":"https://github.com/peace-4-you/TI2206-2016-2017.git","svn_url":"https://github.com/peace-4-you/TI2206-2016-2017","homepage":"","size":9829,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63"},"html":{"href":"https://github.com/peace-4-you/TI2206-2016-2017/pull/63"},"issue":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/63"},"comments":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/peace-4-you/TI2206-2016-2017/statuses/9e26eaad769e8366e3df1279fd6242e3bddca900"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mauricewillemsen","id":12033506,"avatar_url":"https://avatars.githubusercontent.com/u/12033506?v=3","gravatar_id":"","url":"https://api.github.com/users/mauricewillemsen","html_url":"https://github.com/mauricewillemsen","followers_url":"https://api.github.com/users/mauricewillemsen/followers","following_url":"https://api.github.com/users/mauricewillemsen/following{/other_user}","gists_url":"https://api.github.com/users/mauricewillemsen/gists{/gist_id}","starred_url":"https://api.github.com/users/mauricewillemsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauricewillemsen/subscriptions","organizations_url":"https://api.github.com/users/mauricewillemsen/orgs","repos_url":"https://api.github.com/users/mauricewillemsen/repos","events_url":"https://api.github.com/users/mauricewillemsen/events{/privacy}","received_events_url":"https://api.github.com/users/mauricewillemsen/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":8,"additions":1002,"deletions":793,"changed_files":19}}
{"actor":{"display_login":"mauricewillemsen"}}