{"action":"opened","issue":{"url":"https://api.github.com/repos/thangcao/Twitter/issues/1","repository_url":"https://api.github.com/repos/thangcao/Twitter","labels_url":"https://api.github.com/repos/thangcao/Twitter/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/thangcao/Twitter/issues/1/comments","events_url":"https://api.github.com/repos/thangcao/Twitter/issues/1/events","html_url":"https://github.com/thangcao/Twitter/issues/1","id":169779035,"number":1,"title":"Assignment 3&4 Review","user":{"login":"avo1","id":10482065,"avatar_url":"https://avatars.githubusercontent.com/u/10482065?v=3","gravatar_id":"","url":"https://api.github.com/users/avo1","html_url":"https://github.com/avo1","followers_url":"https://api.github.com/users/avo1/followers","following_url":"https://api.github.com/users/avo1/following{/other_user}","gists_url":"https://api.github.com/users/avo1/gists{/gist_id}","starred_url":"https://api.github.com/users/avo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avo1/subscriptions","organizations_url":"https://api.github.com/users/avo1/orgs","repos_url":"https://api.github.com/users/avo1/repos","events_url":"https://api.github.com/users/avo1/events{/privacy}","received_events_url":"https://api.github.com/users/avo1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-07T04:18:54Z","updated_at":"2016-08-07T04:18:54Z","closed_at":null,"body":"🚀 nice work. The point of homework 3 was to explore a simple example of a full MVC application with a RESTful API. We added homework 4 so that you'll have the experience building an app that's more similar in complexity to a production app. Congratulations on finishing the final assignment! It's impressive to realize how far you've come in the first half of the class, going from building a simple tip calculator to a full Twitter app.\r\n\r\n\r\n## Grading Summary:\r\n* **Functionality**: Excellent\r\n* **Code Style**: Good\r\n* **Visual Design**: Excellent\r\n\r\n#### **Overall**: Excellent\r\n\r\n\r\n## Detailed Notes\r\n\r\n* Great splash screen, but there's a problem with this: as a user, should I tap on `Get Started` or `Sign in`?\r\n\r\n<img width=\"272\" alt=\"screen shot 2016-08-07 at 10 58 49 am\" src=\"https://cloud.githubusercontent.com/assets/10482065/17460380/edc9f76a-5c8d-11e6-95f9-15a4647cb90f.png\">\r\n\r\n* Nice work encapsulating the properties into the private class extension for better encapsulation. You should create a blank line between each function for more readability.\r\n\r\n* Nice work specifying the Auto Layout constraints. There's 1 thing in this assignment to implement the dynamic constrain for the retweet label. You should try handling the conditionally present retweet label in the cells. This is a situation where it's not possible to specify the behavior by only the Interface Builder.\r\n* Nice work setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.\r\n* Nice work implementing the fav/unfav, and retweet/unretweet correctly and update the count accordingly.\r\n* Your infinite loading is not smooth. When it triggers the end of the table, load 20 more, but don't auto scroll to the end of the table. At that moment, if I slightly scroll **up**, you still trigger another loading.\r\n* In ComposeVC, you should handle the limit of 140 chars. If your number becomes negative but you shouldn't allow to `Tweet`\r\n\r\n<img width=\"316\" alt=\"screen shot 2016-08-07 at 11 07 02 am\" src=\"https://cloud.githubusercontent.com/assets/10482065/17460402/2b9a0d18-5c8f-11e6-9aaa-0a06ab2486d1.png\">\r\n\r\n* Nice work handling the post tweet insertion into the feed. `NSNotificationCenter` is one of the way to do that, or you can use the delegate patter we learnt. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.\r\n\r\n* On the hamburger menu, there's a bug as in this gif\r\n\r\n![burgermenu](https://cloud.githubusercontent.com/assets/10482065/17460415/bba30eaa-5c8f-11e6-8fbe-e05ccd74fa42.gif)\r\n\r\n* Some other inputs for the menu: when the menu is shown and you tap on the other VC on the right edge, it should go back to that VC, not trigger and segue on that VC (and it causes the problem above). The logout button should be on the menu as well.\r\n"}}
{"actor":{"display_login":"avo1"}}