{"action":"created","issue":{"url":"https://api.github.com/repos/nats-io/node-nats/issues/99","repository_url":"https://api.github.com/repos/nats-io/node-nats","labels_url":"https://api.github.com/repos/nats-io/node-nats/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/nats-io/node-nats/issues/99/comments","events_url":"https://api.github.com/repos/nats-io/node-nats/issues/99/events","html_url":"https://github.com/nats-io/node-nats/pull/99","id":190607996,"number":99,"title":"addresses issue 97","user":{"login":"sfrooster","id":3125143,"avatar_url":"https://avatars.githubusercontent.com/u/3125143?v=3","gravatar_id":"","url":"https://api.github.com/users/sfrooster","html_url":"https://github.com/sfrooster","followers_url":"https://api.github.com/users/sfrooster/followers","following_url":"https://api.github.com/users/sfrooster/following{/other_user}","gists_url":"https://api.github.com/users/sfrooster/gists{/gist_id}","starred_url":"https://api.github.com/users/sfrooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfrooster/subscriptions","organizations_url":"https://api.github.com/users/sfrooster/orgs","repos_url":"https://api.github.com/users/sfrooster/repos","events_url":"https://api.github.com/users/sfrooster/events{/privacy}","received_events_url":"https://api.github.com/users/sfrooster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"derekcollison","id":90097,"avatar_url":"https://avatars.githubusercontent.com/u/90097?v=3","gravatar_id":"","url":"https://api.github.com/users/derekcollison","html_url":"https://github.com/derekcollison","followers_url":"https://api.github.com/users/derekcollison/followers","following_url":"https://api.github.com/users/derekcollison/following{/other_user}","gists_url":"https://api.github.com/users/derekcollison/gists{/gist_id}","starred_url":"https://api.github.com/users/derekcollison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekcollison/subscriptions","organizations_url":"https://api.github.com/users/derekcollison/orgs","repos_url":"https://api.github.com/users/derekcollison/repos","events_url":"https://api.github.com/users/derekcollison/events{/privacy}","received_events_url":"https://api.github.com/users/derekcollison/received_events","type":"User","site_admin":false},"assignees":[{"login":"derekcollison","id":90097,"avatar_url":"https://avatars.githubusercontent.com/u/90097?v=3","gravatar_id":"","url":"https://api.github.com/users/derekcollison","html_url":"https://github.com/derekcollison","followers_url":"https://api.github.com/users/derekcollison/followers","following_url":"https://api.github.com/users/derekcollison/following{/other_user}","gists_url":"https://api.github.com/users/derekcollison/gists{/gist_id}","starred_url":"https://api.github.com/users/derekcollison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekcollison/subscriptions","organizations_url":"https://api.github.com/users/derekcollison/orgs","repos_url":"https://api.github.com/users/derekcollison/repos","events_url":"https://api.github.com/users/derekcollison/events{/privacy}","received_events_url":"https://api.github.com/users/derekcollison/received_events","type":"User","site_admin":false},{"login":"aricart","id":1032976,"avatar_url":"https://avatars.githubusercontent.com/u/1032976?v=3","gravatar_id":"","url":"https://api.github.com/users/aricart","html_url":"https://github.com/aricart","followers_url":"https://api.github.com/users/aricart/followers","following_url":"https://api.github.com/users/aricart/following{/other_user}","gists_url":"https://api.github.com/users/aricart/gists{/gist_id}","starred_url":"https://api.github.com/users/aricart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aricart/subscriptions","organizations_url":"https://api.github.com/users/aricart/orgs","repos_url":"https://api.github.com/users/aricart/repos","events_url":"https://api.github.com/users/aricart/events{/privacy}","received_events_url":"https://api.github.com/users/aricart/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-21T03:04:40Z","updated_at":"2016-11-21T03:22:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nats-io/node-nats/pulls/99","html_url":"https://github.com/nats-io/node-nats/pull/99","diff_url":"https://github.com/nats-io/node-nats/pull/99.diff","patch_url":"https://github.com/nats-io/node-nats/pull/99.patch"},"body":"see #97 "},"comment":{"url":"https://api.github.com/repos/nats-io/node-nats/issues/comments/261833516","html_url":"https://github.com/nats-io/node-nats/pull/99#issuecomment-261833516","issue_url":"https://api.github.com/repos/nats-io/node-nats/issues/99","id":261833516,"user":{"login":"sfrooster","id":3125143,"avatar_url":"https://avatars.githubusercontent.com/u/3125143?v=3","gravatar_id":"","url":"https://api.github.com/users/sfrooster","html_url":"https://github.com/sfrooster","followers_url":"https://api.github.com/users/sfrooster/followers","following_url":"https://api.github.com/users/sfrooster/following{/other_user}","gists_url":"https://api.github.com/users/sfrooster/gists{/gist_id}","starred_url":"https://api.github.com/users/sfrooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfrooster/subscriptions","organizations_url":"https://api.github.com/users/sfrooster/orgs","repos_url":"https://api.github.com/users/sfrooster/repos","events_url":"https://api.github.com/users/sfrooster/events{/privacy}","received_events_url":"https://api.github.com/users/sfrooster/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T03:22:45Z","updated_at":"2016-11-21T03:22:45Z","body":"I fixed he original round of failures, current failure only occurs with\nNode6:\n\n  1) Yield should yield to other events:\n\n     Uncaught AssertionError: expected 21 to be within 10..20\n\n      at Assertion.fail (node_modules/should/cjs/should.js:205:17)\n\n      at Assertion.value [as within] (node_modules/should/cjs/should.js:277:19)\n\n      at Timeout.<anonymous> (test/yield.js:33:20)\n\n\nDon't know what that is.  As for a new test, my question is what behavior\nwould be inline with a timeout from the other clients?\n\nOn Sun, Nov 20, 2016 at 7:15 PM, Derek Collison <notifications@github.com>\nwrote:\n\n> Be good to have some tests to prove it works correctly. Also check why\n> tests failed.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/nats-io/node-nats/pull/99#issuecomment-261832808>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AC-vlxzyaTAkVyRQLcibTGZhG3WI1Yxdks5rAQzrgaJpZM4K3xTA>\n> .\n>\n"}}
{"actor":{"display_login":"sfrooster"}}