{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments/86104835","pull_request_review_id":6778928,"id":86104835,"diff_hunk":"@@ -212,101 +222,121 @@ typedef enum _sai_hostif_trap_type_t\n     /** default packet action is forward */\n     SAI_HOSTIF_TRAP_TYPE_VRRP = 0x00002005,\n \n-    /**\n-     * @brief BGP traffic (tcp src port == 179 or tcp dst port == 179) to local\n-     * router IP address (default packet action is forward)\n-     */\n-    SAI_HOSTIF_TRAP_TYPE_BGP = 0x00002006,\n-\n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_DHCPV6 = 0x00002007,\n+    SAI_HOSTIF_TRAP_TYPE_DHCPV6 = 0x00002006,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_OSPFV6 = 0x00002008,\n+    SAI_HOSTIF_TRAP_TYPE_OSPFV6 = 0x00002007,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_VRRPV6 = 0x00002009,\n-\n-    /**\n-     * @brief BGPv6 traffic (tcp src port == 179 or tcp dst port == 179) to\n-     * local router IP address (default packet action is forward)\n-     */\n-    SAI_HOSTIF_TRAP_TYPE_BGPV6 = 0x0000200a,\n+    SAI_HOSTIF_TRAP_TYPE_VRRPV6 = 0x00002008,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_IPV6_NEIGHBOR_DISCOVERY = 0x0000200b,\n+    SAI_HOSTIF_TRAP_TYPE_IPV6_NEIGHBOR_DISCOVERY = 0x00002009,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_V2 = 0x0000200c,\n+    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_V2 = 0x0000200a,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_REPORT = 0x0000200d,\n+    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_REPORT = 0x0000200b,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_DONE = 0x0000200e,\n+    SAI_HOSTIF_TRAP_TYPE_IPV6_MLD_V1_DONE = 0x0000200c,\n \n     /** default packet action is forward */\n-    SAI_HOSTIF_TRAP_TYPE_MLD_V2_REPORT = 0x0000200f,\n+    SAI_HOSTIF_TRAP_TYPE_MLD_V2_REPORT = 0x0000200d,\n+\n+    /** Router traps custom range start */\n+    SAI_HOSTIF_TRAP_TYPE_ROUTER_CUSTOM_RANGE_BASE = 0x0003000,\n+\n+    /* local IP traps */\n \n     /**\n      * @brief IP packets to local router IP address (routes with\n      * #SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID = #SAI_SWITCH_ATTR_CPU_PORT)\n-     * (default packet action is trap)\n+     * (default packet action is drop)","path":"inc/saihostintf.h","position":94,"original_position":94,"commit_id":"29de613379370a6757e1f339c33b2d5607ebc1e1","original_commit_id":"29de613379370a6757e1f339c33b2d5607ebc1e1","user":{"login":"atitjain","id":11074959,"avatar_url":"https://avatars.githubusercontent.com/u/11074959?v=3","gravatar_id":"","url":"https://api.github.com/users/atitjain","html_url":"https://github.com/atitjain","followers_url":"https://api.github.com/users/atitjain/followers","following_url":"https://api.github.com/users/atitjain/following{/other_user}","gists_url":"https://api.github.com/users/atitjain/gists{/gist_id}","starred_url":"https://api.github.com/users/atitjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atitjain/subscriptions","organizations_url":"https://api.github.com/users/atitjain/orgs","repos_url":"https://api.github.com/users/atitjain/repos","events_url":"https://api.github.com/users/atitjain/events{/privacy}","received_events_url":"https://api.github.com/users/atitjain/received_events","type":"User","site_admin":false},"body":"what is the difference between this and the following ones which are also IP2ME like:\r\nSAI_HOSTIF_TRAP_TYPE_SSH \r\nSAI_HOSTIF_TRAP_TYPE_SNMP \r\nSAI_HOSTIF_TRAP_TYPE_BGP etc.\r\n\r\nThis looks like a superset. Do you mean a better match gets more priority. ","created_at":"2016-11-02T09:52:08Z","updated_at":"2016-11-02T09:52:08Z","html_url":"https://github.com/opencomputeproject/SAI/pull/266#discussion_r86104835","pull_request_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments/86104835"},"html":{"href":"https://github.com/opencomputeproject/SAI/pull/266#discussion_r86104835"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266","id":90146311,"html_url":"https://github.com/opencomputeproject/SAI/pull/266","diff_url":"https://github.com/opencomputeproject/SAI/pull/266.diff","patch_url":"https://github.com/opencomputeproject/SAI/pull/266.patch","issue_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/266","number":266,"state":"open","locked":false,"title":"host if spec changes for 1.0","user":{"login":"itaibaz","id":10446690,"avatar_url":"https://avatars.githubusercontent.com/u/10446690?v=3","gravatar_id":"","url":"https://api.github.com/users/itaibaz","html_url":"https://github.com/itaibaz","followers_url":"https://api.github.com/users/itaibaz/followers","following_url":"https://api.github.com/users/itaibaz/following{/other_user}","gists_url":"https://api.github.com/users/itaibaz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaibaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaibaz/subscriptions","organizations_url":"https://api.github.com/users/itaibaz/orgs","repos_url":"https://api.github.com/users/itaibaz/repos","events_url":"https://api.github.com/users/itaibaz/events{/privacy}","received_events_url":"https://api.github.com/users/itaibaz/received_events","type":"User","site_admin":false},"body":"Add host interface table entry, for demux of traps to host if object\nRemove host if user defined traps, and add them to regular trap list\n","created_at":"2016-10-20T07:27:37Z","updated_at":"2016-11-02T09:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a418499e5afa1d41edf58f635105f3c0be35f24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/266/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/SAI/statuses/29de613379370a6757e1f339c33b2d5607ebc1e1","head":{"label":"itaibaz:hostspec","ref":"hostspec","sha":"29de613379370a6757e1f339c33b2d5607ebc1e1","user":{"login":"itaibaz","id":10446690,"avatar_url":"https://avatars.githubusercontent.com/u/10446690?v=3","gravatar_id":"","url":"https://api.github.com/users/itaibaz","html_url":"https://github.com/itaibaz","followers_url":"https://api.github.com/users/itaibaz/followers","following_url":"https://api.github.com/users/itaibaz/following{/other_user}","gists_url":"https://api.github.com/users/itaibaz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaibaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaibaz/subscriptions","organizations_url":"https://api.github.com/users/itaibaz/orgs","repos_url":"https://api.github.com/users/itaibaz/repos","events_url":"https://api.github.com/users/itaibaz/events{/privacy}","received_events_url":"https://api.github.com/users/itaibaz/received_events","type":"User","site_admin":false},"repo":{"id":44550776,"name":"SAI","full_name":"itaibaz/SAI","owner":{"login":"itaibaz","id":10446690,"avatar_url":"https://avatars.githubusercontent.com/u/10446690?v=3","gravatar_id":"","url":"https://api.github.com/users/itaibaz","html_url":"https://github.com/itaibaz","followers_url":"https://api.github.com/users/itaibaz/followers","following_url":"https://api.github.com/users/itaibaz/following{/other_user}","gists_url":"https://api.github.com/users/itaibaz/gists{/gist_id}","starred_url":"https://api.github.com/users/itaibaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaibaz/subscriptions","organizations_url":"https://api.github.com/users/itaibaz/orgs","repos_url":"https://api.github.com/users/itaibaz/repos","events_url":"https://api.github.com/users/itaibaz/events{/privacy}","received_events_url":"https://api.github.com/users/itaibaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itaibaz/SAI","description":"Switch Abstraction Interface","fork":true,"url":"https://api.github.com/repos/itaibaz/SAI","forks_url":"https://api.github.com/repos/itaibaz/SAI/forks","keys_url":"https://api.github.com/repos/itaibaz/SAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itaibaz/SAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itaibaz/SAI/teams","hooks_url":"https://api.github.com/repos/itaibaz/SAI/hooks","issue_events_url":"https://api.github.com/repos/itaibaz/SAI/issues/events{/number}","events_url":"https://api.github.com/repos/itaibaz/SAI/events","assignees_url":"https://api.github.com/repos/itaibaz/SAI/assignees{/user}","branches_url":"https://api.github.com/repos/itaibaz/SAI/branches{/branch}","tags_url":"https://api.github.com/repos/itaibaz/SAI/tags","blobs_url":"https://api.github.com/repos/itaibaz/SAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itaibaz/SAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itaibaz/SAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/itaibaz/SAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itaibaz/SAI/statuses/{sha}","languages_url":"https://api.github.com/repos/itaibaz/SAI/languages","stargazers_url":"https://api.github.com/repos/itaibaz/SAI/stargazers","contributors_url":"https://api.github.com/repos/itaibaz/SAI/contributors","subscribers_url":"https://api.github.com/repos/itaibaz/SAI/subscribers","subscription_url":"https://api.github.com/repos/itaibaz/SAI/subscription","commits_url":"https://api.github.com/repos/itaibaz/SAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/itaibaz/SAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/itaibaz/SAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/itaibaz/SAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/itaibaz/SAI/contents/{+path}","compare_url":"https://api.github.com/repos/itaibaz/SAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itaibaz/SAI/merges","archive_url":"https://api.github.com/repos/itaibaz/SAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itaibaz/SAI/downloads","issues_url":"https://api.github.com/repos/itaibaz/SAI/issues{/number}","pulls_url":"https://api.github.com/repos/itaibaz/SAI/pulls{/number}","milestones_url":"https://api.github.com/repos/itaibaz/SAI/milestones{/number}","notifications_url":"https://api.github.com/repos/itaibaz/SAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itaibaz/SAI/labels{/name}","releases_url":"https://api.github.com/repos/itaibaz/SAI/releases{/id}","deployments_url":"https://api.github.com/repos/itaibaz/SAI/deployments","created_at":"2015-10-19T17:15:59Z","updated_at":"2016-05-05T16:24:00Z","pushed_at":"2016-11-01T16:51:59Z","git_url":"git://github.com/itaibaz/SAI.git","ssh_url":"git@github.com:itaibaz/SAI.git","clone_url":"https://github.com/itaibaz/SAI.git","svn_url":"https://github.com/itaibaz/SAI","homepage":null,"size":33166,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"ecdb1e23a399fddff50be167b426052277f6ee93","user":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":43159385,"name":"SAI","full_name":"opencomputeproject/SAI","owner":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars.githubusercontent.com/u/16659405?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/SAI","description":"Switch Abstraction Interface","fork":false,"url":"https://api.github.com/repos/opencomputeproject/SAI","forks_url":"https://api.github.com/repos/opencomputeproject/SAI/forks","keys_url":"https://api.github.com/repos/opencomputeproject/SAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/SAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/SAI/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/SAI/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/SAI/events","assignees_url":"https://api.github.com/repos/opencomputeproject/SAI/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/SAI/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/SAI/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/SAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/SAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/SAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/SAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/SAI/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/SAI/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/SAI/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/SAI/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/SAI/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/SAI/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/SAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/SAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/SAI/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/SAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/SAI/merges","archive_url":"https://api.github.com/repos/opencomputeproject/SAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/SAI/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/SAI/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/SAI/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/SAI/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/SAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/SAI/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/SAI/releases{/id}","deployments_url":"https://api.github.com/repos/opencomputeproject/SAI/deployments","created_at":"2015-09-25T16:19:31Z","updated_at":"2016-10-24T20:21:11Z","pushed_at":"2016-11-02T05:14:20Z","git_url":"git://github.com/opencomputeproject/SAI.git","ssh_url":"git@github.com:opencomputeproject/SAI.git","clone_url":"https://github.com/opencomputeproject/SAI.git","svn_url":"https://github.com/opencomputeproject/SAI","homepage":null,"size":69112,"stargazers_count":51,"watchers_count":51,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":45,"forks":65,"open_issues":45,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266"},"html":{"href":"https://github.com/opencomputeproject/SAI/pull/266"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/SAI/issues/266"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/SAI/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/SAI/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/SAI/statuses/29de613379370a6757e1f339c33b2d5607ebc1e1"}}}}
{"actor":{"display_login":"atitjain"}}