{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/84903081","pull_request_review_id":5650396,"id":84903081,"diff_hunk":"@@ -13,19 +13,17 @@ namespace merkle_transaction_repository {\n \n using abs_tx = abstract_transaction::AbstractTransaction;\n \n+std::vector<std::unique_ptr<abs_tx>> transactions;\n+\n // WIP\n //std::unique_ptr<merkle::MerkleRoot> merkle_root;\n \n-//bool commit(std::unique_ptr<consensus_event::ConsensusEvent> const event) {\n-//    return false;\n-//}\n-\n-bool commit(std::string hash, const std::unique_ptr<consensus_event::ConsensusEvent> &event) {\n-    return false;\n+bool commit(std::string hash, const std::unique_ptr<abs_tx> &tx) {\n+    return repository::world_state_repository::add(tx->getHash(), tx->getAsText());\n }\n \n-std::unique_ptr<abs_tx> findLeaf(std::string const hash) {\n-\n+bool leafExists(std::string const hash) {","path":"core/repository/consensus/merkle_transaction_repository.cpp","position":21,"original_position":21,"commit_id":"35340cd5048034926e595d31a3abec1af0dc4663","original_commit_id":"35340cd5048034926e595d31a3abec1af0dc4663","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars.githubusercontent.com/u/20982317?v=3","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Function parameter 'hash' should be passed by reference.](https://www.codacy.com/app/soramitsu/iroha/file/4278250936/issues/source?bid=3712501&fileBranchId=3837537#l25)","created_at":"2016-10-25T13:37:42Z","updated_at":"2016-10-25T13:37:42Z","html_url":"https://github.com/hyperledger/iroha/pull/43#discussion_r84903081","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/84903081"},"html":{"href":"https://github.com/hyperledger/iroha/pull/43#discussion_r84903081"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/43","id":90776357,"html_url":"https://github.com/hyperledger/iroha/pull/43","diff_url":"https://github.com/hyperledger/iroha/pull/43.diff","patch_url":"https://github.com/hyperledger/iroha/pull/43.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/43","number":43,"state":"open","locked":false,"title":"Feature sumeragi","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars.githubusercontent.com/u/20982317?v=3","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"test","created_at":"2016-10-25T10:05:27Z","updated_at":"2016-10-25T13:37:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a8bf001834334b9eb4af69170e10cd6b2eff248","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/43/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/43/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/43/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/35340cd5048034926e595d31a3abec1af0dc4663","head":{"label":"hyperledger:feature-sumeragi","ref":"feature-sumeragi","sha":"35340cd5048034926e595d31a3abec1af0dc4663","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-10-25T13:36:26Z","pushed_at":"2016-10-25T13:32:39Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":19748,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":19,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"a199ef810184e4d5209e809b65539f8ff80a9a8f","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2016-10-25T13:36:26Z","pushed_at":"2016-10-25T13:32:39Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":19748,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/43"},"html":{"href":"https://github.com/hyperledger/iroha/pull/43"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/43"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/35340cd5048034926e595d31a3abec1af0dc4663"}}}}
{"actor":{"display_login":"takemiyamakoto"}}