{"action":"created","comment":{"url":"https://api.github.com/repos/Kitware/CDash/pulls/comments/79176672","id":79176672,"diff_hunk":"@@ -331,11 +331,18 @@ function ctest_parse($filehandler, $projectid, $expected_md5 = '', $do_checksum\n         return false;\n     }\n \n-    // Write the file to the backup directory.\n-    $filename = writeBackupFile($filehandler, $content, $projectname, $buildname,\n-        $sitename, $stamp, $file . '.xml');\n-    if ($filename === false) {\n-        return $handler;\n+    // If backups are disabled, switch the filename to that of the existing handle\n+    // Otherwise, create a backup file and process from that\n+    global $CDASH_BACKUP_TIMEFRAME;\n+    if ($CDASH_BACKUP_TIMEFRAME == '0') {\n+        $meta_data = stream_get_meta_data($filehandler);\n+        $filename = $meta_data[\"uri\"];","path":"include/ctestparser.php","position":null,"original_position":14,"commit_id":"ccea43667000239b0d4c76191092a668343ff9ef","original_commit_id":"fd91714072ab13f5e5ea7d1257cc7500aa62a5b7","user":{"login":"danlamanna","id":608229,"avatar_url":"https://avatars.githubusercontent.com/u/608229?v=3","gravatar_id":"","url":"https://api.github.com/users/danlamanna","html_url":"https://github.com/danlamanna","followers_url":"https://api.github.com/users/danlamanna/followers","following_url":"https://api.github.com/users/danlamanna/following{/other_user}","gists_url":"https://api.github.com/users/danlamanna/gists{/gist_id}","starred_url":"https://api.github.com/users/danlamanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlamanna/subscriptions","organizations_url":"https://api.github.com/users/danlamanna/orgs","repos_url":"https://api.github.com/users/danlamanna/repos","events_url":"https://api.github.com/users/danlamanna/events{/privacy}","received_events_url":"https://api.github.com/users/danlamanna/received_events","type":"User","site_admin":false},"body":"@zachmullen Fixed","created_at":"2016-09-16T14:10:13Z","updated_at":"2016-09-16T14:10:13Z","html_url":"https://github.com/Kitware/CDash/pull/418#discussion_r79176672","pull_request_url":"https://api.github.com/repos/Kitware/CDash/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/comments/79176672"},"html":{"href":"https://github.com/Kitware/CDash/pull/418#discussion_r79176672"},"pull_request":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/Kitware/CDash/pulls/418","id":85474777,"html_url":"https://github.com/Kitware/CDash/pull/418","diff_url":"https://github.com/Kitware/CDash/pull/418.diff","patch_url":"https://github.com/Kitware/CDash/pull/418.patch","issue_url":"https://api.github.com/repos/Kitware/CDash/issues/418","number":418,"state":"open","locked":false,"title":"Disable intermediate backup file creation when backups are disabled","user":{"login":"danlamanna","id":608229,"avatar_url":"https://avatars.githubusercontent.com/u/608229?v=3","gravatar_id":"","url":"https://api.github.com/users/danlamanna","html_url":"https://github.com/danlamanna","followers_url":"https://api.github.com/users/danlamanna/followers","following_url":"https://api.github.com/users/danlamanna/following{/other_user}","gists_url":"https://api.github.com/users/danlamanna/gists{/gist_id}","starred_url":"https://api.github.com/users/danlamanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlamanna/subscriptions","organizations_url":"https://api.github.com/users/danlamanna/orgs","repos_url":"https://api.github.com/users/danlamanna/repos","events_url":"https://api.github.com/users/danlamanna/events{/privacy}","received_events_url":"https://api.github.com/users/danlamanna/received_events","type":"User","site_admin":false},"body":"This fixes the issue where backups were created for the duration of processing even when `CDASH_BACKUP_TIMEFRAME` was '0'.","created_at":"2016-09-15T20:31:13Z","updated_at":"2016-09-16T14:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3771078407257358524d72d7ce65ad4e4536a2d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kitware/CDash/pulls/418/commits","review_comments_url":"https://api.github.com/repos/Kitware/CDash/pulls/418/comments","review_comment_url":"https://api.github.com/repos/Kitware/CDash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitware/CDash/issues/418/comments","statuses_url":"https://api.github.com/repos/Kitware/CDash/statuses/ccea43667000239b0d4c76191092a668343ff9ef","head":{"label":"Kitware:fix-intermediate-backup-creation","ref":"fix-intermediate-backup-creation","sha":"ccea43667000239b0d4c76191092a668343ff9ef","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":25169249,"name":"CDash","full_name":"Kitware/CDash","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/CDash","description":"An open source, web-based software testing server","fork":false,"url":"https://api.github.com/repos/Kitware/CDash","forks_url":"https://api.github.com/repos/Kitware/CDash/forks","keys_url":"https://api.github.com/repos/Kitware/CDash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/CDash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/CDash/teams","hooks_url":"https://api.github.com/repos/Kitware/CDash/hooks","issue_events_url":"https://api.github.com/repos/Kitware/CDash/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/CDash/events","assignees_url":"https://api.github.com/repos/Kitware/CDash/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/CDash/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/CDash/tags","blobs_url":"https://api.github.com/repos/Kitware/CDash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/CDash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/CDash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/CDash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/CDash/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/CDash/languages","stargazers_url":"https://api.github.com/repos/Kitware/CDash/stargazers","contributors_url":"https://api.github.com/repos/Kitware/CDash/contributors","subscribers_url":"https://api.github.com/repos/Kitware/CDash/subscribers","subscription_url":"https://api.github.com/repos/Kitware/CDash/subscription","commits_url":"https://api.github.com/repos/Kitware/CDash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/CDash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/CDash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/CDash/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/CDash/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/CDash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/CDash/merges","archive_url":"https://api.github.com/repos/Kitware/CDash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/CDash/downloads","issues_url":"https://api.github.com/repos/Kitware/CDash/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/CDash/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/CDash/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/CDash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/CDash/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/CDash/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/CDash/deployments","created_at":"2014-10-13T17:21:17Z","updated_at":"2016-09-15T03:34:37Z","pushed_at":"2016-09-16T13:57:12Z","git_url":"git://github.com/Kitware/CDash.git","ssh_url":"git@github.com:Kitware/CDash.git","clone_url":"https://github.com/Kitware/CDash.git","svn_url":"https://github.com/Kitware/CDash","homepage":"http://www.cdash.org/","size":23024,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":34,"forks":23,"open_issues":34,"watchers":28,"default_branch":"master"}},"base":{"label":"Kitware:master","ref":"master","sha":"7218709b2899191c129b25978087dd78385c8a04","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":25169249,"name":"CDash","full_name":"Kitware/CDash","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/CDash","description":"An open source, web-based software testing server","fork":false,"url":"https://api.github.com/repos/Kitware/CDash","forks_url":"https://api.github.com/repos/Kitware/CDash/forks","keys_url":"https://api.github.com/repos/Kitware/CDash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/CDash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/CDash/teams","hooks_url":"https://api.github.com/repos/Kitware/CDash/hooks","issue_events_url":"https://api.github.com/repos/Kitware/CDash/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/CDash/events","assignees_url":"https://api.github.com/repos/Kitware/CDash/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/CDash/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/CDash/tags","blobs_url":"https://api.github.com/repos/Kitware/CDash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/CDash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/CDash/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/CDash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/CDash/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/CDash/languages","stargazers_url":"https://api.github.com/repos/Kitware/CDash/stargazers","contributors_url":"https://api.github.com/repos/Kitware/CDash/contributors","subscribers_url":"https://api.github.com/repos/Kitware/CDash/subscribers","subscription_url":"https://api.github.com/repos/Kitware/CDash/subscription","commits_url":"https://api.github.com/repos/Kitware/CDash/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/CDash/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/CDash/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/CDash/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/CDash/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/CDash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/CDash/merges","archive_url":"https://api.github.com/repos/Kitware/CDash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/CDash/downloads","issues_url":"https://api.github.com/repos/Kitware/CDash/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/CDash/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/CDash/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/CDash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/CDash/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/CDash/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/CDash/deployments","created_at":"2014-10-13T17:21:17Z","updated_at":"2016-09-15T03:34:37Z","pushed_at":"2016-09-16T13:57:12Z","git_url":"git://github.com/Kitware/CDash.git","ssh_url":"git@github.com:Kitware/CDash.git","clone_url":"https://github.com/Kitware/CDash.git","svn_url":"https://github.com/Kitware/CDash","homepage":"http://www.cdash.org/","size":23024,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":34,"forks":23,"open_issues":34,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/418"},"html":{"href":"https://github.com/Kitware/CDash/pull/418"},"issue":{"href":"https://api.github.com/repos/Kitware/CDash/issues/418"},"comments":{"href":"https://api.github.com/repos/Kitware/CDash/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitware/CDash/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/Kitware/CDash/statuses/ccea43667000239b0d4c76191092a668343ff9ef"}}}}
{"actor":{"display_login":"danlamanna"}}