{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/65360126","id":65360126,"diff_hunk":"@@ -326,6 +343,8 @@ def fit(self, inst, picks=None, start=None, stop=None, decim=None,\n         self : instance of ICA\n             Returns the modified instance.\n         \"\"\"\n+        if picks is not None:","path":"mne/preprocessing/ica.py","position":35,"original_position":35,"commit_id":"162368e266fddc993e90a403c1bac44165757408","original_commit_id":"162368e266fddc993e90a403c1bac44165757408","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"this conditional can go inside the helper checking function","created_at":"2016-06-01T13:34:25Z","updated_at":"2016-06-01T13:34:25Z","html_url":"https://github.com/mne-tools/mne-python/pull/3270#discussion_r65360126","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/65360126"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3270#discussion_r65360126"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270","id":71820372,"html_url":"https://github.com/mne-tools/mne-python/pull/3270","diff_url":"https://github.com/mne-tools/mne-python/pull/3270.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3270.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3270","number":3270,"state":"open","locked":false,"title":"WIP: Ica inf values fix","user":{"login":"ARudiuk","id":2080576,"avatar_url":"https://avatars.githubusercontent.com/u/2080576?v=3","gravatar_id":"","url":"https://api.github.com/users/ARudiuk","html_url":"https://github.com/ARudiuk","followers_url":"https://api.github.com/users/ARudiuk/followers","following_url":"https://api.github.com/users/ARudiuk/following{/other_user}","gists_url":"https://api.github.com/users/ARudiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ARudiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARudiuk/subscriptions","organizations_url":"https://api.github.com/users/ARudiuk/orgs","repos_url":"https://api.github.com/users/ARudiuk/repos","events_url":"https://api.github.com/users/ARudiuk/events{/privacy}","received_events_url":"https://api.github.com/users/ARudiuk/received_events","type":"User","site_admin":false},"body":"It seems like the error with #3267 is that the user can define channels which are not supported data channels.\r\n\r\nIn my current code I have added a simple method that crashes the program if there are unsupported channels defined by the user. I also added EOG as an acceptable channel. \r\n@agramfort @Eric89GXL any ideas on how to proceed? \r\n\r\nTwo things that still need to be addressed in my eyes are: 1) should EOG be included as a supported channel? 2) how would I raise an appropriate error for bad channels being present?","created_at":"2016-05-29T07:22:46Z","updated_at":"2016-06-01T13:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a20259194c0b4b13089123af1cc52eb2ec7391","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3270/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/162368e266fddc993e90a403c1bac44165757408","head":{"label":"ARudiuk:ica_inf_values","ref":"ica_inf_values","sha":"162368e266fddc993e90a403c1bac44165757408","user":{"login":"ARudiuk","id":2080576,"avatar_url":"https://avatars.githubusercontent.com/u/2080576?v=3","gravatar_id":"","url":"https://api.github.com/users/ARudiuk","html_url":"https://github.com/ARudiuk","followers_url":"https://api.github.com/users/ARudiuk/followers","following_url":"https://api.github.com/users/ARudiuk/following{/other_user}","gists_url":"https://api.github.com/users/ARudiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ARudiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARudiuk/subscriptions","organizations_url":"https://api.github.com/users/ARudiuk/orgs","repos_url":"https://api.github.com/users/ARudiuk/repos","events_url":"https://api.github.com/users/ARudiuk/events{/privacy}","received_events_url":"https://api.github.com/users/ARudiuk/received_events","type":"User","site_admin":false},"repo":{"id":28989683,"name":"mne-python","full_name":"ARudiuk/mne-python","owner":{"login":"ARudiuk","id":2080576,"avatar_url":"https://avatars.githubusercontent.com/u/2080576?v=3","gravatar_id":"","url":"https://api.github.com/users/ARudiuk","html_url":"https://github.com/ARudiuk","followers_url":"https://api.github.com/users/ARudiuk/followers","following_url":"https://api.github.com/users/ARudiuk/following{/other_user}","gists_url":"https://api.github.com/users/ARudiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ARudiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARudiuk/subscriptions","organizations_url":"https://api.github.com/users/ARudiuk/orgs","repos_url":"https://api.github.com/users/ARudiuk/repos","events_url":"https://api.github.com/users/ARudiuk/events{/privacy}","received_events_url":"https://api.github.com/users/ARudiuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ARudiuk/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/ARudiuk/mne-python","forks_url":"https://api.github.com/repos/ARudiuk/mne-python/forks","keys_url":"https://api.github.com/repos/ARudiuk/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARudiuk/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARudiuk/mne-python/teams","hooks_url":"https://api.github.com/repos/ARudiuk/mne-python/hooks","issue_events_url":"https://api.github.com/repos/ARudiuk/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/ARudiuk/mne-python/events","assignees_url":"https://api.github.com/repos/ARudiuk/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/ARudiuk/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/ARudiuk/mne-python/tags","blobs_url":"https://api.github.com/repos/ARudiuk/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARudiuk/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARudiuk/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARudiuk/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARudiuk/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ARudiuk/mne-python/languages","stargazers_url":"https://api.github.com/repos/ARudiuk/mne-python/stargazers","contributors_url":"https://api.github.com/repos/ARudiuk/mne-python/contributors","subscribers_url":"https://api.github.com/repos/ARudiuk/mne-python/subscribers","subscription_url":"https://api.github.com/repos/ARudiuk/mne-python/subscription","commits_url":"https://api.github.com/repos/ARudiuk/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARudiuk/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARudiuk/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARudiuk/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARudiuk/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/ARudiuk/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARudiuk/mne-python/merges","archive_url":"https://api.github.com/repos/ARudiuk/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARudiuk/mne-python/downloads","issues_url":"https://api.github.com/repos/ARudiuk/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/ARudiuk/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ARudiuk/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ARudiuk/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARudiuk/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/ARudiuk/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/ARudiuk/mne-python/deployments","created_at":"2015-01-08T22:39:27Z","updated_at":"2016-05-26T19:37:20Z","pushed_at":"2016-06-01T04:17:57Z","git_url":"git://github.com/ARudiuk/mne-python.git","ssh_url":"git@github.com:ARudiuk/mne-python.git","clone_url":"https://github.com/ARudiuk/mne-python.git","svn_url":"https://github.com/ARudiuk/mne-python","homepage":"http://martinos.org/mne/","size":86074,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"a1cbb6bf96612dec707e19876bef492f9f5d12d0","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-05-29T00:38:38Z","pushed_at":"2016-06-01T04:17:58Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":178014,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":191,"forks":190,"open_issues":191,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3270"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3270"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3270/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3270/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/162368e266fddc993e90a403c1bac44165757408"}}}}
{"actor":{"display_login":"Eric89GXL"}}