{"push_id":1050282372,"size":13,"distinct_size":1,"ref":"refs/heads/fix-onstart-deadlock","head":"1c6ee9d09dbe8dac15b3a1f65381ea7a5b57d61b","before":"deccf0a7125c5b785290e3d31fe9ff956348ac66","commits":[{"sha":"2a69267f24b0c8ea692615892c79893dea61ba29","author":{"email":"8123c7b1fb88cee3c97fc23dd58ca1950822ea23@redhat.com","name":"Michal Fojtik"},"message":"Improve messaging for Docker timeouts","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/2a69267f24b0c8ea692615892c79893dea61ba29"},{"sha":"e30ada2553926c1f2f959f94d10be218b3ae7a05","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #445 from mfojtik/custom-timeout-error\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/e30ada2553926c1f2f959f94d10be218b3ae7a05"},{"sha":"2c0fc8ae6150b27396dc00907cac128eeda99b09","author":{"email":"d0dfd0f70ba1d932abb60e5810b58ec740b2ab91@redhat.com","name":"Cesar Wong"},"message":"Allow passing a proxy configuration for script download","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/2c0fc8ae6150b27396dc00907cac128eeda99b09"},{"sha":"ab1922728cd492440e0df56a33f37918d8f2a800","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #448 from csrwng/script_proxy\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/ab1922728cd492440e0df56a33f37918d8f2a800"},{"sha":"61ff171b9f331a3dccb91fe45af913603bc9088d","author":{"email":"e633824286795b52eabb9e183635b7dc44e6a28a@redhat.com","name":"Dan McPherson"},"message":"Fix typo","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/61ff171b9f331a3dccb91fe45af913603bc9088d"},{"sha":"b52e76efa077b824970daa3568d3a6bf92302b73","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #450 from danmcp/master\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/b52e76efa077b824970daa3568d3a6bf92302b73"},{"sha":"19b107c7c3b56efc2cf424d41bba9b4f66879861","author":{"email":"e633824286795b52eabb9e183635b7dc44e6a28a@redhat.com","name":"Dan McPherson"},"message":"Git is not an acronym","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/19b107c7c3b56efc2cf424d41bba9b4f66879861"},{"sha":"6c7e58fde4bfade60af51e8fecf765f87f78ed83","author":{"email":"d0dfd0f70ba1d932abb60e5810b58ec740b2ab91@redhat.com","name":"Cesar Wong"},"message":"Throw an error if a scripts URL is specified but  no scripts can be downloaded from it","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/6c7e58fde4bfade60af51e8fecf765f87f78ed83"},{"sha":"362b7da5cab8bcdd4ed71a56592e50c6dfdd063c","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #451 from danmcp/master\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/362b7da5cab8bcdd4ed71a56592e50c6dfdd063c"},{"sha":"48e62fd57bebba14e1d0f7a40a15b65dafa5458c","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #449 from csrwng/script_download_error\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/48e62fd57bebba14e1d0f7a40a15b65dafa5458c"},{"sha":"35d23d8a31b2cb33319bc433a205dbd61c4a4e23","author":{"email":"8c969d742f8a0d9f34fd145da1aa01b17db92622@gmail.com","name":"Rodolfo Carvalho"},"message":"Change imports to follow project standards","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/35d23d8a31b2cb33319bc433a205dbd61c4a4e23"},{"sha":"fb6df26bef9876c1274132e34f4bc3006a219aca","author":{"email":"e932f255a97219792d17a85f47c61dcbae45313b@redhat.com","name":"OpenShift Bot"},"message":"Merge pull request #455 from rhcarvalho/reorganize-imports\n\nMerged by openshift-bot","distinct":false,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/fb6df26bef9876c1274132e34f4bc3006a219aca"},{"sha":"1c6ee9d09dbe8dac15b3a1f65381ea7a5b57d61b","author":{"email":"8c969d742f8a0d9f34fd145da1aa01b17db92622@gmail.com","name":"Rodolfo Carvalho"},"message":"Fix deadlock condition\n\nThis is a quick on-spot fix, would be nice to actually rework the\noverall implementation to avoid this hackish solution.\n\nThe problem is that STI.Save (for saving artifacts) calls RunContainer\nwith opts.OnStart set to a function that reads from the read half of a\npipe, while the write half is set as the container stdout. Docker won't\nclose the container's output and error streams upon termination\n(expected behavior), so OnStart will never terminate, it will block\nforever waiting for more data to be read.\n\nWith OnStart blocked, RunContainer is blocked, and STI.Save never\nreturns, thus the deferred call to close the pipe halves is never\nexecuted, thus the deadlock.","distinct":true,"url":"https://api.github.com/repos/rhcarvalho/source-to-image/commits/1c6ee9d09dbe8dac15b3a1f65381ea7a5b57d61b"}]}