{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/73663708","id":73663708,"diff_hunk":"@@ -1625,10 +1625,6 @@ let DefaultBasicReferencesForOutOfProjectSources =\n       // Note: this is not a partiuclarly good technique as it relying on the environment the compiler is executing in\n       // to determine the default references. However, System.Core will only fail to load on machines with only .NET 2.0,\n       // in which case the compiler will also be running as a .NET 2.0 process.\n-      //\n-      // NOTE: it seems this can now be removed now that .NET 4.x is minimally assumed when using this toolchain\n-      if (try System.Reflection.Assembly.Load(new System.Reflection.AssemblyName(\"System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089\")) |> ignore; true with _ -> false) then \n-          yield \"System.Core\" ","path":"src/fsharp/CompileOps.fs","position":7,"original_position":7,"commit_id":"d0f37bd30adc92ea2b6a36dca2cd8816be31d7fa","original_commit_id":"d0f37bd30adc92ea2b6a36dca2cd8816be31d7fa","user":{"login":"dsyme","id":7204669,"avatar_url":"https://avatars.githubusercontent.com/u/7204669?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"body":"I think you should now _always_  yield System.Core here (remove the condition, not the yield)","created_at":"2016-08-05T09:14:17Z","updated_at":"2016-08-05T09:14:17Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/1407#discussion_r73663708","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/73663708"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/1407#discussion_r73663708"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407","id":80193715,"html_url":"https://github.com/Microsoft/visualfsharp/pull/1407","diff_url":"https://github.com/Microsoft/visualfsharp/pull/1407.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/1407.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1407","number":1407,"state":"open","locked":false,"title":"Make FSI run on coreclr again","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"FSI was broken on coreclr because:\r\n\r\n1. Incorrect usage of LoaderContext.\r\n2. FSI does resolution magic using MSBUILD on Windows Desktop.  When initializing FSI code on coreclr it tried to compute a highest framework version.  But didn't really know how to do it.\r\n\r\nThis PR: uses LoaderContext correctly.  And works around the initialization issue.\r\n\r\nTODO:\r\nA.  Figure out new resolver mechanism that eliminates desktop/MSBUILD style resolver magic.\r\nB.  Eliminate current requirement for command line options.\r\n\r\n\r\n\r\n\r\n ","created_at":"2016-08-05T06:08:18Z","updated_at":"2016-08-05T09:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57411606668d6d70978b721b8bf3ffdb0cad61ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1407/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/d0f37bd30adc92ea2b6a36dca2cd8816be31d7fa","head":{"label":"KevinRansom:fsierror","ref":"fsierror","sha":"d0f37bd30adc92ea2b6a36dca2cd8816be31d7fa","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"repo":{"id":50952442,"name":"visualfsharp","full_name":"KevinRansom/visualfsharp","owner":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinRansom/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/KevinRansom/visualfsharp","forks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/forks","keys_url":"https://api.github.com/repos/KevinRansom/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinRansom/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinRansom/visualfsharp/teams","hooks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/events","assignees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/KevinRansom/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/tags","blobs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinRansom/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinRansom/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscription","commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/KevinRansom/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinRansom/visualfsharp/merges","archive_url":"https://api.github.com/repos/KevinRansom/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinRansom/visualfsharp/downloads","issues_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/KevinRansom/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinRansom/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinRansom/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinRansom/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/KevinRansom/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/deployments","created_at":"2016-02-02T21:15:23Z","updated_at":"2016-02-02T21:15:38Z","pushed_at":"2016-08-05T06:51:33Z","git_url":"git://github.com/KevinRansom/visualfsharp.git","ssh_url":"git@github.com:KevinRansom/visualfsharp.git","clone_url":"https://github.com/KevinRansom/visualfsharp.git","svn_url":"https://github.com/KevinRansom/visualfsharp","homepage":null,"size":75754,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"082d82b9ed568bd2cfa86d541b9c952c409c92f8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2016-08-05T04:57:04Z","pushed_at":"2016-08-05T06:51:33Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":234275,"stargazers_count":803,"watchers_count":803,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":267,"forks":200,"open_issues":267,"watchers":803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/1407"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1407"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1407/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1407/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/d0f37bd30adc92ea2b6a36dca2cd8816be31d7fa"}}}}
{"actor":{"display_login":"dsyme"}}