{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/939","repository_url":"https://api.github.com/repos/OPM/opm-parser","labels_url":"https://api.github.com/repos/OPM/opm-parser/issues/939/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-parser/issues/939/comments","events_url":"https://api.github.com/repos/OPM/opm-parser/issues/939/events","html_url":"https://github.com/OPM/opm-parser/pull/939","id":183012072,"number":939,"title":"The great shared_ptr purge","user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":45,"created_at":"2016-10-14T10:08:01Z","updated_at":"2016-10-19T13:00:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/939","html_url":"https://github.com/OPM/opm-parser/pull/939","diff_url":"https://github.com/OPM/opm-parser/pull/939.diff","patch_url":"https://github.com/OPM/opm-parser/pull/939.patch"},"body":"Hi,\r\n\r\nFor a long time we've talked about getting rid of the pointless shared_ptr use in opm-parser, and now most of them are gone. This has a few implications worth mentioning:\r\n\r\n* I've unearthed some bugs because of this\r\n* Deck is now copyable, and EclipseState and friends will hopefully be soon.\r\n* Copying generally now means copying\r\n* Storage type is no longer mandated by opm-parser; the decision is left to the caller.\r\n* Interfaces are clearer i.e. they don't imply ownership sharing anymore, which was never really the intention.\r\n\r\nThis PR does not really change any behaviour. However, downstream code WILL break from both interface changes and the removal of all the *Ptr aliases. Downstream PRs will be coming."},"comment":{"url":"https://api.github.com/repos/OPM/opm-parser/issues/comments/254805269","html_url":"https://github.com/OPM/opm-parser/pull/939#issuecomment-254805269","issue_url":"https://api.github.com/repos/OPM/opm-parser/issues/939","id":254805269,"user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T13:00:46Z","updated_at":"2016-10-19T13:00:46Z","body":"jenkins build this with downstreams opm-output=109 opm-core=1089 opm-simulators=863 opm-grid=242 opm-upscaling=206 opm-material=170 please"}}
{"actor":{"display_login":"jokva"}}