{"action":"created","issue":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/844","repository_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/844/labels{/name}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/844/comments","events_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/844/events","html_url":"https://github.com/WhisperSystems/Signal-Desktop/issues/844","id":163682091,"number":844,"title":"filtering duplicate messages","user":{"login":"Trolldemorted","id":10261186,"avatar_url":"https://avatars.githubusercontent.com/u/10261186?v=3","gravatar_id":"","url":"https://api.github.com/users/Trolldemorted","html_url":"https://github.com/Trolldemorted","followers_url":"https://api.github.com/users/Trolldemorted/followers","following_url":"https://api.github.com/users/Trolldemorted/following{/other_user}","gists_url":"https://api.github.com/users/Trolldemorted/gists{/gist_id}","starred_url":"https://api.github.com/users/Trolldemorted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trolldemorted/subscriptions","organizations_url":"https://api.github.com/users/Trolldemorted/orgs","repos_url":"https://api.github.com/users/Trolldemorted/repos","events_url":"https://api.github.com/users/Trolldemorted/events{/privacy}","received_events_url":"https://api.github.com/users/Trolldemorted/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-04T13:55:44Z","updated_at":"2016-07-04T23:04:28Z","closed_at":null,"body":"<!-- This is a bug report template. By following the instructions below and filling out the sections with your information, you will help the developers to get all the necessary data to fix your issue.\r\nYou can also preview your report before submitting it. You may remove sections that aren't relevant to your particular case.\r\n\r\nBefore we begin, please note that this tracker is only for issues, not questions or comments.\r\n\r\nIf you are looking for support, please see our support center instead:\r\nhttp://support.whispersystems.org/\r\nor email support@whispersystems.org\r\n\r\nLet's begin with a checklist: please replace the empty checkbox [ ] below with a checked one [x] if you have searched for existing issues -->\r\n\r\n- [x] I have searched open and closed issues for duplicates\r\n\r\n----------------------------------------\r\n\r\n### Bug description\r\nSignal devices may think an outgoing message was not successfully transmitted, and send the same message multiple times.\r\n\r\nSince i dont think this will ever be fixed completely, couldn't we just assign a unique id to each message and thus identify and discard duplicates (im assuming messages dont have one)?\r\n\r\nDisplaying the same message over and over again is obviously horrible, a number attached to each multiple times received message indicating the amount would be much better.\r\n\r\n![unbenannt](https://cloud.githubusercontent.com/assets/10261186/16562690/812f5cf2-41fe-11e6-8a3e-88847ae964c6.PNG)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/comments/230362175","html_url":"https://github.com/WhisperSystems/Signal-Desktop/issues/844#issuecomment-230362175","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/844","id":230362175,"user":{"login":"liliakai","id":1039940,"avatar_url":"https://avatars.githubusercontent.com/u/1039940?v=3","gravatar_id":"","url":"https://api.github.com/users/liliakai","html_url":"https://github.com/liliakai","followers_url":"https://api.github.com/users/liliakai/followers","following_url":"https://api.github.com/users/liliakai/following{/other_user}","gists_url":"https://api.github.com/users/liliakai/gists{/gist_id}","starred_url":"https://api.github.com/users/liliakai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liliakai/subscriptions","organizations_url":"https://api.github.com/users/liliakai/orgs","repos_url":"https://api.github.com/users/liliakai/repos","events_url":"https://api.github.com/users/liliakai/events{/privacy}","received_events_url":"https://api.github.com/users/liliakai/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T23:04:28Z","updated_at":"2016-07-04T23:04:28Z","body":"If the client sends the same ciphertext it will be discarded as a duplicate at the protocol level as mentioned earlier. If the client re-encrypts the message it will not be detected as a duplicate. \n\nYour proposed solution would require changes in all three clients. It would be better just to fix the bug in the mobile clients that are retransmitting to recipients who actually received it already."}}
{"actor":{"display_login":"liliakai"}}