{"action":"closed","number":5432,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5432","id":90704074,"html_url":"https://github.com/apple/swift/pull/5432","diff_url":"https://github.com/apple/swift/pull/5432.diff","patch_url":"https://github.com/apple/swift/pull/5432.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5432","number":5432,"state":"closed","locked":false,"title":"[CMake] Updates for Android NDK r13","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nFixes the Android build, and makes some adjustments for Android NDK r13.\r\n\r\n* Fix FindICU.cmake to properly set the `SWIFT_${sdk}_ICU_UC` and `SWIFT_${sdk}_ICU_I18N` values. These were not properly set because \"uc\" and \"i18n\" were lowercase.\r\n* Adapt `add_swift_library` to parse `ICU_UC` and `ICU_I18N` for private link libraries and use the proper `SWIFT_${sdk}_ICU_*` values.\r\n* NDK r13 removes a subdirectory from the llvm-libc++ includes path. Adapt to this change, and add a FIXME to address this issue before it may break again.\r\n* Update the documentation to point to a new libicu download for NDK 13.","created_at":"2016-10-24T22:19:16Z","updated_at":"2016-10-25T15:38:23Z","closed_at":"2016-10-25T15:38:23Z","merged_at":"2016-10-25T15:38:23Z","merge_commit_sha":"adf36cbea5a59bd0bfbebc249eae43b198e7d896","assignee":{"login":"erg","id":27430,"avatar_url":"https://avatars.githubusercontent.com/u/27430?v=3","gravatar_id":"","url":"https://api.github.com/users/erg","html_url":"https://github.com/erg","followers_url":"https://api.github.com/users/erg/followers","following_url":"https://api.github.com/users/erg/following{/other_user}","gists_url":"https://api.github.com/users/erg/gists{/gist_id}","starred_url":"https://api.github.com/users/erg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erg/subscriptions","organizations_url":"https://api.github.com/users/erg/orgs","repos_url":"https://api.github.com/users/erg/repos","events_url":"https://api.github.com/users/erg/events{/privacy}","received_events_url":"https://api.github.com/users/erg/received_events","type":"User","site_admin":false},"assignees":[{"login":"erg","id":27430,"avatar_url":"https://avatars.githubusercontent.com/u/27430?v=3","gravatar_id":"","url":"https://api.github.com/users/erg","html_url":"https://github.com/erg","followers_url":"https://api.github.com/users/erg/followers","following_url":"https://api.github.com/users/erg/following{/other_user}","gists_url":"https://api.github.com/users/erg/gists{/gist_id}","starred_url":"https://api.github.com/users/erg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erg/subscriptions","organizations_url":"https://api.github.com/users/erg/orgs","repos_url":"https://api.github.com/users/erg/repos","events_url":"https://api.github.com/users/erg/events{/privacy}","received_events_url":"https://api.github.com/users/erg/received_events","type":"User","site_admin":false},{"login":"phausler","id":278470,"avatar_url":"https://avatars.githubusercontent.com/u/278470?v=3","gravatar_id":"","url":"https://api.github.com/users/phausler","html_url":"https://github.com/phausler","followers_url":"https://api.github.com/users/phausler/followers","following_url":"https://api.github.com/users/phausler/following{/other_user}","gists_url":"https://api.github.com/users/phausler/gists{/gist_id}","starred_url":"https://api.github.com/users/phausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phausler/subscriptions","organizations_url":"https://api.github.com/users/phausler/orgs","repos_url":"https://api.github.com/users/phausler/repos","events_url":"https://api.github.com/users/phausler/events{/privacy}","received_events_url":"https://api.github.com/users/phausler/received_events","type":"User","site_admin":false},{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5432/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5432/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5432/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/61868b5aec2ea39c53020180199cad2d995e48de","head":{"label":"modocache:android-ndk-r13","ref":"android-ndk-r13","sha":"61868b5aec2ea39c53020180199cad2d995e48de","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"repo":{"id":47582695,"name":"swift","full_name":"modocache/swift","owner":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/modocache/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/modocache/swift","forks_url":"https://api.github.com/repos/modocache/swift/forks","keys_url":"https://api.github.com/repos/modocache/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modocache/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modocache/swift/teams","hooks_url":"https://api.github.com/repos/modocache/swift/hooks","issue_events_url":"https://api.github.com/repos/modocache/swift/issues/events{/number}","events_url":"https://api.github.com/repos/modocache/swift/events","assignees_url":"https://api.github.com/repos/modocache/swift/assignees{/user}","branches_url":"https://api.github.com/repos/modocache/swift/branches{/branch}","tags_url":"https://api.github.com/repos/modocache/swift/tags","blobs_url":"https://api.github.com/repos/modocache/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modocache/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modocache/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/modocache/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modocache/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/modocache/swift/languages","stargazers_url":"https://api.github.com/repos/modocache/swift/stargazers","contributors_url":"https://api.github.com/repos/modocache/swift/contributors","subscribers_url":"https://api.github.com/repos/modocache/swift/subscribers","subscription_url":"https://api.github.com/repos/modocache/swift/subscription","commits_url":"https://api.github.com/repos/modocache/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/modocache/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/modocache/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/modocache/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/modocache/swift/contents/{+path}","compare_url":"https://api.github.com/repos/modocache/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modocache/swift/merges","archive_url":"https://api.github.com/repos/modocache/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modocache/swift/downloads","issues_url":"https://api.github.com/repos/modocache/swift/issues{/number}","pulls_url":"https://api.github.com/repos/modocache/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/modocache/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/modocache/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modocache/swift/labels{/name}","releases_url":"https://api.github.com/repos/modocache/swift/releases{/id}","deployments_url":"https://api.github.com/repos/modocache/swift/deployments","created_at":"2015-12-07T22:16:48Z","updated_at":"2016-04-01T19:24:05Z","pushed_at":"2016-10-24T22:17:58Z","git_url":"git://github.com/modocache/swift.git","ssh_url":"git@github.com:modocache/swift.git","clone_url":"https://github.com/modocache/swift.git","svn_url":"https://github.com/modocache/swift","homepage":"","size":121926,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"bd49107d2020db58a9229d4719ab751704b36f08","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-10-25T15:20:31Z","pushed_at":"2016-10-25T15:38:22Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":192062,"stargazers_count":34718,"watchers_count":34718,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4984,"mirror_url":null,"open_issues_count":103,"forks":4984,"open_issues":103,"watchers":34718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5432"},"html":{"href":"https://github.com/apple/swift/pull/5432"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5432"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5432/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5432/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5432/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/61868b5aec2ea39c53020180199cad2d995e48de"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"erg","id":27430,"avatar_url":"https://avatars.githubusercontent.com/u/27430?v=3","gravatar_id":"","url":"https://api.github.com/users/erg","html_url":"https://github.com/erg","followers_url":"https://api.github.com/users/erg/followers","following_url":"https://api.github.com/users/erg/following{/other_user}","gists_url":"https://api.github.com/users/erg/gists{/gist_id}","starred_url":"https://api.github.com/users/erg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erg/subscriptions","organizations_url":"https://api.github.com/users/erg/orgs","repos_url":"https://api.github.com/users/erg/repos","events_url":"https://api.github.com/users/erg/events{/privacy}","received_events_url":"https://api.github.com/users/erg/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":22,"deletions":13,"changed_files":4}}
{"actor":{"display_login":"erg"}}