{"action":"closed","number":13703,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13703","id":88904128,"html_url":"https://github.com/servo/servo/pull/13703","diff_url":"https://github.com/servo/servo/pull/13703.diff","patch_url":"https://github.com/servo/servo/pull/13703.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13703","number":13703,"state":"closed","locked":false,"title":"Replacing Node.rootNode for Node.getRootNode.","user":{"login":"Rafagd","id":572618,"avatar_url":"https://avatars.githubusercontent.com/u/572618?v=3","gravatar_id":"","url":"https://api.github.com/users/Rafagd","html_url":"https://github.com/Rafagd","followers_url":"https://api.github.com/users/Rafagd/followers","following_url":"https://api.github.com/users/Rafagd/following{/other_user}","gists_url":"https://api.github.com/users/Rafagd/gists{/gist_id}","starred_url":"https://api.github.com/users/Rafagd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rafagd/subscriptions","organizations_url":"https://api.github.com/users/Rafagd/orgs","repos_url":"https://api.github.com/users/Rafagd/repos","events_url":"https://api.github.com/users/Rafagd/events{/privacy}","received_events_url":"https://api.github.com/users/Rafagd/received_events","type":"User","site_admin":false},"body":"- Changed the specification for the Node element to reflect the new standard.\r\n- Changed the implementation of the NodeMethod.\r\n\r\nI'm still waiting for some answers for the questions I've posted on #13699, but I'm already doing the pull request so I can get some feedback as well.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #13699 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13703)\n<!-- Reviewable:end -->\n","created_at":"2016-10-11T20:24:08Z","updated_at":"2016-10-14T20:46:11Z","closed_at":"2016-10-14T20:46:11Z","merged_at":"2016-10-14T20:46:11Z","merge_commit_sha":"0074d2a7a8b3bc40f96238347e021670528165a8","assignee":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13703/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13703/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13703/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/0074d2a7a8b3bc40f96238347e021670528165a8","head":{"label":"Rafagd:my_changes","ref":"my_changes","sha":"0074d2a7a8b3bc40f96238347e021670528165a8","user":{"login":"Rafagd","id":572618,"avatar_url":"https://avatars.githubusercontent.com/u/572618?v=3","gravatar_id":"","url":"https://api.github.com/users/Rafagd","html_url":"https://github.com/Rafagd","followers_url":"https://api.github.com/users/Rafagd/followers","following_url":"https://api.github.com/users/Rafagd/following{/other_user}","gists_url":"https://api.github.com/users/Rafagd/gists{/gist_id}","starred_url":"https://api.github.com/users/Rafagd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rafagd/subscriptions","organizations_url":"https://api.github.com/users/Rafagd/orgs","repos_url":"https://api.github.com/users/Rafagd/repos","events_url":"https://api.github.com/users/Rafagd/events{/privacy}","received_events_url":"https://api.github.com/users/Rafagd/received_events","type":"User","site_admin":false},"repo":{"id":70164077,"name":"servo","full_name":"Rafagd/servo","owner":{"login":"Rafagd","id":572618,"avatar_url":"https://avatars.githubusercontent.com/u/572618?v=3","gravatar_id":"","url":"https://api.github.com/users/Rafagd","html_url":"https://github.com/Rafagd","followers_url":"https://api.github.com/users/Rafagd/followers","following_url":"https://api.github.com/users/Rafagd/following{/other_user}","gists_url":"https://api.github.com/users/Rafagd/gists{/gist_id}","starred_url":"https://api.github.com/users/Rafagd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rafagd/subscriptions","organizations_url":"https://api.github.com/users/Rafagd/orgs","repos_url":"https://api.github.com/users/Rafagd/repos","events_url":"https://api.github.com/users/Rafagd/events{/privacy}","received_events_url":"https://api.github.com/users/Rafagd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rafagd/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Rafagd/servo","forks_url":"https://api.github.com/repos/Rafagd/servo/forks","keys_url":"https://api.github.com/repos/Rafagd/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rafagd/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rafagd/servo/teams","hooks_url":"https://api.github.com/repos/Rafagd/servo/hooks","issue_events_url":"https://api.github.com/repos/Rafagd/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Rafagd/servo/events","assignees_url":"https://api.github.com/repos/Rafagd/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Rafagd/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Rafagd/servo/tags","blobs_url":"https://api.github.com/repos/Rafagd/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rafagd/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rafagd/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rafagd/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rafagd/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Rafagd/servo/languages","stargazers_url":"https://api.github.com/repos/Rafagd/servo/stargazers","contributors_url":"https://api.github.com/repos/Rafagd/servo/contributors","subscribers_url":"https://api.github.com/repos/Rafagd/servo/subscribers","subscription_url":"https://api.github.com/repos/Rafagd/servo/subscription","commits_url":"https://api.github.com/repos/Rafagd/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rafagd/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rafagd/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rafagd/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rafagd/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Rafagd/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rafagd/servo/merges","archive_url":"https://api.github.com/repos/Rafagd/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rafagd/servo/downloads","issues_url":"https://api.github.com/repos/Rafagd/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Rafagd/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Rafagd/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Rafagd/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rafagd/servo/labels{/name}","releases_url":"https://api.github.com/repos/Rafagd/servo/releases{/id}","deployments_url":"https://api.github.com/repos/Rafagd/servo/deployments","created_at":"2016-10-06T14:53:42Z","updated_at":"2016-10-06T10:45:23Z","pushed_at":"2016-10-13T21:41:05Z","git_url":"git://github.com/Rafagd/servo.git","ssh_url":"git@github.com:Rafagd/servo.git","clone_url":"https://github.com/Rafagd/servo.git","svn_url":"https://github.com/Rafagd/servo","homepage":"https://servo.org/","size":212112,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"781a0771458de73d2f843377082a6961c38fb66d","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-14T19:45:56Z","pushed_at":"2016-10-14T20:46:04Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":301669,"stargazers_count":8048,"watchers_count":8048,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1307,"mirror_url":null,"open_issues_count":1804,"forks":1307,"open_issues":1804,"watchers":8048,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13703"},"html":{"href":"https://github.com/servo/servo/pull/13703"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13703"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13703/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13703/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13703/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/0074d2a7a8b3bc40f96238347e021670528165a8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":30,"review_comments":2,"commits":1,"additions":6,"deletions":73,"changed_files":5}}
{"actor":{"display_login":"bors-servo"}}