{"action":"created","issue":{"url":"https://api.github.com/repos/gina-alaska/awrvi/issues/102","repository_url":"https://api.github.com/repos/gina-alaska/awrvi","labels_url":"https://api.github.com/repos/gina-alaska/awrvi/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/gina-alaska/awrvi/issues/102/comments","events_url":"https://api.github.com/repos/gina-alaska/awrvi/issues/102/events","html_url":"https://github.com/gina-alaska/awrvi/pull/102","id":136236801,"number":102,"title":"Only category admin can manage choices #95","user":{"login":"grimm","id":100140,"avatar_url":"https://avatars.githubusercontent.com/u/100140?v=3","gravatar_id":"","url":"https://api.github.com/users/grimm","html_url":"https://github.com/grimm","followers_url":"https://api.github.com/users/grimm/followers","following_url":"https://api.github.com/users/grimm/following{/other_user}","gists_url":"https://api.github.com/users/grimm/gists{/gist_id}","starred_url":"https://api.github.com/users/grimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimm/subscriptions","organizations_url":"https://api.github.com/users/grimm/orgs","repos_url":"https://api.github.com/users/grimm/repos","events_url":"https://api.github.com/users/grimm/events{/privacy}","received_events_url":"https://api.github.com/users/grimm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gina-alaska/awrvi/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-25T00:42:01Z","updated_at":"2016-03-21T18:38:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gina-alaska/awrvi/pulls/102","html_url":"https://github.com/gina-alaska/awrvi/pull/102","diff_url":"https://github.com/gina-alaska/awrvi/pull/102.diff","patch_url":"https://github.com/gina-alaska/awrvi/pull/102.patch"},"body":"Fixes #95 "},"comment":{"url":"https://api.github.com/repos/gina-alaska/awrvi/issues/comments/199418685","html_url":"https://github.com/gina-alaska/awrvi/pull/102#issuecomment-199418685","issue_url":"https://api.github.com/repos/gina-alaska/awrvi/issues/102","id":199418685,"user":{"login":"teknofire","id":3766,"avatar_url":"https://avatars.githubusercontent.com/u/3766?v=3","gravatar_id":"","url":"https://api.github.com/users/teknofire","html_url":"https://github.com/teknofire","followers_url":"https://api.github.com/users/teknofire/followers","following_url":"https://api.github.com/users/teknofire/following{/other_user}","gists_url":"https://api.github.com/users/teknofire/gists{/gist_id}","starred_url":"https://api.github.com/users/teknofire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teknofire/subscriptions","organizations_url":"https://api.github.com/users/teknofire/orgs","repos_url":"https://api.github.com/users/teknofire/repos","events_url":"https://api.github.com/users/teknofire/events{/privacy}","received_events_url":"https://api.github.com/users/teknofire/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T18:38:04Z","updated_at":"2016-03-21T18:38:04Z","body":"Ok, I think we need to take a quick step back.  There are lots of gaps in theses tests right now concerning the index permissions. \r\n\r\nWe should be writing these from the point of the different actors and what they can or cannot do.  Not separate tests for each permission type.  So currently there should probably be 3 methods in the ability tests that cover the appropriate actions for `:create, :read, :update, :delete`.  I would also say get rid of the `:manage` permission checks as the handling all the `CRUD` permission should cover that.\r\n\r\nLet's make sure to cover these scenarios\r\n\r\n1. guests  (logged out users)\r\n1. logged in users who do not own the index\r\n1. logged in users who do own the index\r\n\r\nEventually this would need to include any specialized action like the finalized stuff as well."}}