{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/comments/74676030","id":74676030,"diff_hunk":"@@ -433,7 +433,19 @@ public virtual Task ForgetTwoFactorClientAsync()\n         /// <param name=\"isPersistent\">Flag indicating whether the sign-in cookie should persist after the browser is closed.</param>\n         /// <returns>The task object representing the asynchronous operation containing the <see name=\"SignInResult\"/>\n         /// for the sign-in attempt.</returns>\n-        public virtual async Task<SignInResult> ExternalLoginSignInAsync(string loginProvider, string providerKey, bool isPersistent)\n+        public virtual Task<SignInResult> ExternalLoginSignInAsync(string loginProvider, string providerKey, bool isPersistent) ","path":"src/Microsoft.AspNetCore.Identity/SignInManager.cs","position":5,"original_position":5,"commit_id":"457ac7282dbbc56df7715e4434fbd33e9a849650","original_commit_id":"457ac7282dbbc56df7715e4434fbd33e9a849650","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"> This is a overload method for placing a default value for one parameter. Should we just have the one of the overload to be virtual? (I assume we can't change this in 1.1.0 since take away the virtual modifier will be a breaking change. But I'm just wondering.)\n> \n\nI am not sure what the suggestion or ask is here. Can you clarify what you mean?","created_at":"2016-08-13T00:04:40Z","updated_at":"2016-08-13T00:04:40Z","html_url":"https://github.com/aspnet/Identity/pull/932#discussion_r74676030","pull_request_url":"https://api.github.com/repos/aspnet/Identity/pulls/932","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments/74676030"},"html":{"href":"https://github.com/aspnet/Identity/pull/932#discussion_r74676030"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/932"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Identity/pulls/932","id":80522736,"html_url":"https://github.com/aspnet/Identity/pull/932","diff_url":"https://github.com/aspnet/Identity/pull/932.diff","patch_url":"https://github.com/aspnet/Identity/pull/932.patch","issue_url":"https://api.github.com/repos/aspnet/Identity/issues/932","number":932,"state":"open","locked":false,"title":"Add ExternalSignIn overload that can bypass TFA","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/aspnet/Identity/issues/850\r\n\r\ncc @divega @blowdart @brockallen","created_at":"2016-08-08T21:10:58Z","updated_at":"2016-08-13T00:04:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ef24625c9802451e036a9c02d89f0a6ddbd690","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Identity/pulls/932/commits","review_comments_url":"https://api.github.com/repos/aspnet/Identity/pulls/932/comments","review_comment_url":"https://api.github.com/repos/aspnet/Identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Identity/issues/932/comments","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/457ac7282dbbc56df7715e4434fbd33e9a849650","head":{"label":"aspnet:haok/8-8bypass","ref":"haok/8-8bypass","sha":"457ac7282dbbc56df7715e4434fbd33e9a849650","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Identity/deployments","created_at":"2014-02-03T20:23:53Z","updated_at":"2016-08-12T04:12:27Z","pushed_at":"2016-08-12T17:31:35Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":7651,"stargazers_count":884,"watchers_count":884,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":73,"forks":393,"open_issues":73,"watchers":884,"default_branch":"dev"}},"base":{"label":"aspnet:haok/8-8check","ref":"haok/8-8check","sha":"5922338f4bfbedfcc71efacdf591bb0f5efa9e48","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16491880,"name":"Identity","full_name":"aspnet/Identity","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Identity","description":"ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data.","fork":false,"url":"https://api.github.com/repos/aspnet/Identity","forks_url":"https://api.github.com/repos/aspnet/Identity/forks","keys_url":"https://api.github.com/repos/aspnet/Identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Identity/teams","hooks_url":"https://api.github.com/repos/aspnet/Identity/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Identity/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Identity/events","assignees_url":"https://api.github.com/repos/aspnet/Identity/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Identity/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Identity/tags","blobs_url":"https://api.github.com/repos/aspnet/Identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Identity/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Identity/languages","stargazers_url":"https://api.github.com/repos/aspnet/Identity/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Identity/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Identity/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Identity/subscription","commits_url":"https://api.github.com/repos/aspnet/Identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Identity/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Identity/merges","archive_url":"https://api.github.com/repos/aspnet/Identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Identity/downloads","issues_url":"https://api.github.com/repos/aspnet/Identity/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Identity/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Identity/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Identity/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Identity/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Identity/deployments","created_at":"2014-02-03T20:23:53Z","updated_at":"2016-08-12T04:12:27Z","pushed_at":"2016-08-12T17:31:35Z","git_url":"git://github.com/aspnet/Identity.git","ssh_url":"git@github.com:aspnet/Identity.git","clone_url":"https://github.com/aspnet/Identity.git","svn_url":"https://github.com/aspnet/Identity","homepage":"","size":7651,"stargazers_count":884,"watchers_count":884,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":73,"forks":393,"open_issues":73,"watchers":884,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/932"},"html":{"href":"https://github.com/aspnet/Identity/pull/932"},"issue":{"href":"https://api.github.com/repos/aspnet/Identity/issues/932"},"comments":{"href":"https://api.github.com/repos/aspnet/Identity/issues/932/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/932/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Identity/pulls/932/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Identity/statuses/457ac7282dbbc56df7715e4434fbd33e9a849650"}}}}
{"actor":{"display_login":"HaoK"}}