{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/hmrctest/pulls/comments/86310151","pull_request_review_id":6973177,"id":86310151,"diff_hunk":"@@ -100,9 +99,10 @@ trait EmbeddedServiceOrchestrator extends ResourceProvider with StartAndStopServ\n \n     val environment: Environment = Environment.simple(mode = applicationMode)\n     val application: Application = new GuiceApplicationBuilder(environment = environment, configuration = config).build()\n+    Play.start(application)","path":"src/main/scala/uk/gov/hmrc/play/it/MicroServiceEmbeddedServer.scala","position":12,"original_position":12,"commit_id":"dce52a490a332c084821ab0d12a9bb641eee8a8e","original_commit_id":"dce52a490a332c084821ab0d12a9bb641eee8a8e","user":{"login":"trasahin","id":1140488,"avatar_url":"https://avatars.githubusercontent.com/u/1140488?v=3","gravatar_id":"","url":"https://api.github.com/users/trasahin","html_url":"https://github.com/trasahin","followers_url":"https://api.github.com/users/trasahin/followers","following_url":"https://api.github.com/users/trasahin/following{/other_user}","gists_url":"https://api.github.com/users/trasahin/gists{/gist_id}","starred_url":"https://api.github.com/users/trasahin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trasahin/subscriptions","organizations_url":"https://api.github.com/users/trasahin/orgs","repos_url":"https://api.github.com/users/trasahin/repos","events_url":"https://api.github.com/users/trasahin/events{/privacy}","received_events_url":"https://api.github.com/users/trasahin/received_events","type":"User","site_admin":false},"body":"also do we need to call Play.stop tear down process ?","created_at":"2016-11-03T09:50:47Z","updated_at":"2016-11-03T09:50:47Z","html_url":"https://github.com/hmrc/hmrctest/pull/11#discussion_r86310151","pull_request_url":"https://api.github.com/repos/hmrc/hmrctest/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/comments/86310151"},"html":{"href":"https://github.com/hmrc/hmrctest/pull/11#discussion_r86310151"},"pull_request":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/hmrctest/pulls/11","id":92119309,"html_url":"https://github.com/hmrc/hmrctest/pull/11","diff_url":"https://github.com/hmrc/hmrctest/pull/11.diff","patch_url":"https://github.com/hmrc/hmrctest/pull/11.patch","issue_url":"https://api.github.com/repos/hmrc/hmrctest/issues/11","number":11,"state":"open","locked":false,"title":"Ensure embedded Play application started.","user":{"login":"timothygordon32","id":2032848,"avatar_url":"https://avatars.githubusercontent.com/u/2032848?v=3","gravatar_id":"","url":"https://api.github.com/users/timothygordon32","html_url":"https://github.com/timothygordon32","followers_url":"https://api.github.com/users/timothygordon32/followers","following_url":"https://api.github.com/users/timothygordon32/following{/other_user}","gists_url":"https://api.github.com/users/timothygordon32/gists{/gist_id}","starred_url":"https://api.github.com/users/timothygordon32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothygordon32/subscriptions","organizations_url":"https://api.github.com/users/timothygordon32/orgs","repos_url":"https://api.github.com/users/timothygordon32/repos","events_url":"https://api.github.com/users/timothygordon32/events{/privacy}","received_events_url":"https://api.github.com/users/timothygordon32/received_events","type":"User","site_admin":false},"body":"Service manager client has independent materializer.","created_at":"2016-11-03T09:40:48Z","updated_at":"2016-11-03T09:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"899fc0f86e9db2841d8fb88b99eec9b8109e5c89","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/hmrctest/pulls/11/commits","review_comments_url":"https://api.github.com/repos/hmrc/hmrctest/pulls/11/comments","review_comment_url":"https://api.github.com/repos/hmrc/hmrctest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/hmrctest/issues/11/comments","statuses_url":"https://api.github.com/repos/hmrc/hmrctest/statuses/dce52a490a332c084821ab0d12a9bb641eee8a8e","head":{"label":"hmrc:PE-2590-dwp-data-play-2.5","ref":"PE-2590-dwp-data-play-2.5","sha":"dce52a490a332c084821ab0d12a9bb641eee8a8e","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":32391059,"name":"hmrctest","full_name":"hmrc/hmrctest","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/hmrctest","description":"Scala library providing some useful functionality for unit and integration tests","fork":false,"url":"https://api.github.com/repos/hmrc/hmrctest","forks_url":"https://api.github.com/repos/hmrc/hmrctest/forks","keys_url":"https://api.github.com/repos/hmrc/hmrctest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/hmrctest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/hmrctest/teams","hooks_url":"https://api.github.com/repos/hmrc/hmrctest/hooks","issue_events_url":"https://api.github.com/repos/hmrc/hmrctest/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/hmrctest/events","assignees_url":"https://api.github.com/repos/hmrc/hmrctest/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/hmrctest/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/hmrctest/tags","blobs_url":"https://api.github.com/repos/hmrc/hmrctest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/hmrctest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/hmrctest/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/hmrctest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/hmrctest/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/hmrctest/languages","stargazers_url":"https://api.github.com/repos/hmrc/hmrctest/stargazers","contributors_url":"https://api.github.com/repos/hmrc/hmrctest/contributors","subscribers_url":"https://api.github.com/repos/hmrc/hmrctest/subscribers","subscription_url":"https://api.github.com/repos/hmrc/hmrctest/subscription","commits_url":"https://api.github.com/repos/hmrc/hmrctest/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/hmrctest/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/hmrctest/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/hmrctest/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/hmrctest/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/hmrctest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/hmrctest/merges","archive_url":"https://api.github.com/repos/hmrc/hmrctest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/hmrctest/downloads","issues_url":"https://api.github.com/repos/hmrc/hmrctest/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/hmrctest/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/hmrctest/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/hmrctest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/hmrctest/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/hmrctest/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/hmrctest/deployments","created_at":"2015-03-17T12:08:22Z","updated_at":"2016-03-11T16:43:07Z","pushed_at":"2016-11-03T09:40:48Z","git_url":"git://github.com/hmrc/hmrctest.git","ssh_url":"git@github.com:hmrc/hmrctest.git","clone_url":"https://github.com/hmrc/hmrctest.git","svn_url":"https://github.com/hmrc/hmrctest","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"1ed9c9f1497fabe66b54adc8beb031b24937d20f","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":32391059,"name":"hmrctest","full_name":"hmrc/hmrctest","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/hmrctest","description":"Scala library providing some useful functionality for unit and integration tests","fork":false,"url":"https://api.github.com/repos/hmrc/hmrctest","forks_url":"https://api.github.com/repos/hmrc/hmrctest/forks","keys_url":"https://api.github.com/repos/hmrc/hmrctest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/hmrctest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/hmrctest/teams","hooks_url":"https://api.github.com/repos/hmrc/hmrctest/hooks","issue_events_url":"https://api.github.com/repos/hmrc/hmrctest/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/hmrctest/events","assignees_url":"https://api.github.com/repos/hmrc/hmrctest/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/hmrctest/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/hmrctest/tags","blobs_url":"https://api.github.com/repos/hmrc/hmrctest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/hmrctest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/hmrctest/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/hmrctest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/hmrctest/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/hmrctest/languages","stargazers_url":"https://api.github.com/repos/hmrc/hmrctest/stargazers","contributors_url":"https://api.github.com/repos/hmrc/hmrctest/contributors","subscribers_url":"https://api.github.com/repos/hmrc/hmrctest/subscribers","subscription_url":"https://api.github.com/repos/hmrc/hmrctest/subscription","commits_url":"https://api.github.com/repos/hmrc/hmrctest/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/hmrctest/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/hmrctest/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/hmrctest/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/hmrctest/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/hmrctest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/hmrctest/merges","archive_url":"https://api.github.com/repos/hmrc/hmrctest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/hmrctest/downloads","issues_url":"https://api.github.com/repos/hmrc/hmrctest/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/hmrctest/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/hmrctest/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/hmrctest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/hmrctest/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/hmrctest/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/hmrctest/deployments","created_at":"2015-03-17T12:08:22Z","updated_at":"2016-03-11T16:43:07Z","pushed_at":"2016-11-03T09:40:48Z","git_url":"git://github.com/hmrc/hmrctest.git","ssh_url":"git@github.com:hmrc/hmrctest.git","clone_url":"https://github.com/hmrc/hmrctest.git","svn_url":"https://github.com/hmrc/hmrctest","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/11"},"html":{"href":"https://github.com/hmrc/hmrctest/pull/11"},"issue":{"href":"https://api.github.com/repos/hmrc/hmrctest/issues/11"},"comments":{"href":"https://api.github.com/repos/hmrc/hmrctest/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/hmrctest/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/hmrctest/statuses/dce52a490a332c084821ab0d12a9bb641eee8a8e"}}}}
{"actor":{"display_login":"trasahin"}}