{"action":"created","comment":{"url":"https://api.github.com/repos/Mainflux/mainflux/pulls/comments/82505110","pull_request_review_id":3410626,"id":82505110,"diff_hunk":"@@ -21,6 +21,9 @@\n ###\n mongo:\n   image: mongo:latest\n+  ports:","path":"docker-compose.yml","position":4,"original_position":4,"commit_id":"de236fcc90a4afba95340c63c52b728666d05bcf","original_commit_id":"de236fcc90a4afba95340c63c52b728666d05bcf","user":{"login":"drasko","id":149944,"avatar_url":"https://avatars.githubusercontent.com/u/149944?v=3","gravatar_id":"","url":"https://api.github.com/users/drasko","html_url":"https://github.com/drasko","followers_url":"https://api.github.com/users/drasko/followers","following_url":"https://api.github.com/users/drasko/following{/other_user}","gists_url":"https://api.github.com/users/drasko/gists{/gist_id}","starred_url":"https://api.github.com/users/drasko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drasko/subscriptions","organizations_url":"https://api.github.com/users/drasko/orgs","repos_url":"https://api.github.com/users/drasko/repos","events_url":"https://api.github.com/users/drasko/events{/privacy}","received_events_url":"https://api.github.com/users/drasko/received_events","type":"User","site_admin":false},"body":"Why are you exposing these ports to local host? This is not needed.\r\n\r\nDocker container `mainflux-server` should be capable to directly access container `mongo`, no need need for Mongo DB ports exposed to the host.\r\n\r\nProblem is of course that your Mongo client on your dev host will not work - you have to log into container and check DB contents.\r\n\r\nBut anyway - for dev I would expect that everybody use local MongoDB on host, and Docker is for deployments...","created_at":"2016-10-08T16:10:07Z","updated_at":"2016-10-08T16:14:56Z","html_url":"https://github.com/Mainflux/mainflux/pull/63#discussion_r82505110","pull_request_url":"https://api.github.com/repos/Mainflux/mainflux/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/comments/82505110"},"html":{"href":"https://github.com/Mainflux/mainflux/pull/63#discussion_r82505110"},"pull_request":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/Mainflux/mainflux/pulls/63","id":88548188,"html_url":"https://github.com/Mainflux/mainflux/pull/63","diff_url":"https://github.com/Mainflux/mainflux/pull/63.diff","patch_url":"https://github.com/Mainflux/mainflux/pull/63.patch","issue_url":"https://api.github.com/repos/Mainflux/mainflux/issues/63","number":63,"state":"open","locked":false,"title":"Fixed docker-compose","user":{"login":"nmarcetic","id":6399555,"avatar_url":"https://avatars.githubusercontent.com/u/6399555?v=3","gravatar_id":"","url":"https://api.github.com/users/nmarcetic","html_url":"https://github.com/nmarcetic","followers_url":"https://api.github.com/users/nmarcetic/followers","following_url":"https://api.github.com/users/nmarcetic/following{/other_user}","gists_url":"https://api.github.com/users/nmarcetic/gists{/gist_id}","starred_url":"https://api.github.com/users/nmarcetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmarcetic/subscriptions","organizations_url":"https://api.github.com/users/nmarcetic/orgs","repos_url":"https://api.github.com/users/nmarcetic/repos","events_url":"https://api.github.com/users/nmarcetic/events{/privacy}","received_events_url":"https://api.github.com/users/nmarcetic/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-08T14:53:23Z","updated_at":"2016-10-08T16:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cb99b9d254151193c0f05f1eece1f0505ba7b8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mainflux/mainflux/pulls/63/commits","review_comments_url":"https://api.github.com/repos/Mainflux/mainflux/pulls/63/comments","review_comment_url":"https://api.github.com/repos/Mainflux/mainflux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mainflux/mainflux/issues/63/comments","statuses_url":"https://api.github.com/repos/Mainflux/mainflux/statuses/de236fcc90a4afba95340c63c52b728666d05bcf","head":{"label":"nmarcetic:master","ref":"master","sha":"de236fcc90a4afba95340c63c52b728666d05bcf","user":{"login":"nmarcetic","id":6399555,"avatar_url":"https://avatars.githubusercontent.com/u/6399555?v=3","gravatar_id":"","url":"https://api.github.com/users/nmarcetic","html_url":"https://github.com/nmarcetic","followers_url":"https://api.github.com/users/nmarcetic/followers","following_url":"https://api.github.com/users/nmarcetic/following{/other_user}","gists_url":"https://api.github.com/users/nmarcetic/gists{/gist_id}","starred_url":"https://api.github.com/users/nmarcetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmarcetic/subscriptions","organizations_url":"https://api.github.com/users/nmarcetic/orgs","repos_url":"https://api.github.com/users/nmarcetic/repos","events_url":"https://api.github.com/users/nmarcetic/events{/privacy}","received_events_url":"https://api.github.com/users/nmarcetic/received_events","type":"User","site_admin":false},"repo":{"id":70332000,"name":"mainflux","full_name":"nmarcetic/mainflux","owner":{"login":"nmarcetic","id":6399555,"avatar_url":"https://avatars.githubusercontent.com/u/6399555?v=3","gravatar_id":"","url":"https://api.github.com/users/nmarcetic","html_url":"https://github.com/nmarcetic","followers_url":"https://api.github.com/users/nmarcetic/followers","following_url":"https://api.github.com/users/nmarcetic/following{/other_user}","gists_url":"https://api.github.com/users/nmarcetic/gists{/gist_id}","starred_url":"https://api.github.com/users/nmarcetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmarcetic/subscriptions","organizations_url":"https://api.github.com/users/nmarcetic/orgs","repos_url":"https://api.github.com/users/nmarcetic/repos","events_url":"https://api.github.com/users/nmarcetic/events{/privacy}","received_events_url":"https://api.github.com/users/nmarcetic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmarcetic/mainflux","description":"Industrial IoT Cloud","fork":true,"url":"https://api.github.com/repos/nmarcetic/mainflux","forks_url":"https://api.github.com/repos/nmarcetic/mainflux/forks","keys_url":"https://api.github.com/repos/nmarcetic/mainflux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmarcetic/mainflux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmarcetic/mainflux/teams","hooks_url":"https://api.github.com/repos/nmarcetic/mainflux/hooks","issue_events_url":"https://api.github.com/repos/nmarcetic/mainflux/issues/events{/number}","events_url":"https://api.github.com/repos/nmarcetic/mainflux/events","assignees_url":"https://api.github.com/repos/nmarcetic/mainflux/assignees{/user}","branches_url":"https://api.github.com/repos/nmarcetic/mainflux/branches{/branch}","tags_url":"https://api.github.com/repos/nmarcetic/mainflux/tags","blobs_url":"https://api.github.com/repos/nmarcetic/mainflux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmarcetic/mainflux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmarcetic/mainflux/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmarcetic/mainflux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmarcetic/mainflux/statuses/{sha}","languages_url":"https://api.github.com/repos/nmarcetic/mainflux/languages","stargazers_url":"https://api.github.com/repos/nmarcetic/mainflux/stargazers","contributors_url":"https://api.github.com/repos/nmarcetic/mainflux/contributors","subscribers_url":"https://api.github.com/repos/nmarcetic/mainflux/subscribers","subscription_url":"https://api.github.com/repos/nmarcetic/mainflux/subscription","commits_url":"https://api.github.com/repos/nmarcetic/mainflux/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmarcetic/mainflux/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmarcetic/mainflux/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmarcetic/mainflux/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmarcetic/mainflux/contents/{+path}","compare_url":"https://api.github.com/repos/nmarcetic/mainflux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmarcetic/mainflux/merges","archive_url":"https://api.github.com/repos/nmarcetic/mainflux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmarcetic/mainflux/downloads","issues_url":"https://api.github.com/repos/nmarcetic/mainflux/issues{/number}","pulls_url":"https://api.github.com/repos/nmarcetic/mainflux/pulls{/number}","milestones_url":"https://api.github.com/repos/nmarcetic/mainflux/milestones{/number}","notifications_url":"https://api.github.com/repos/nmarcetic/mainflux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmarcetic/mainflux/labels{/name}","releases_url":"https://api.github.com/repos/nmarcetic/mainflux/releases{/id}","deployments_url":"https://api.github.com/repos/nmarcetic/mainflux/deployments","created_at":"2016-10-08T13:11:19Z","updated_at":"2016-10-08T13:11:20Z","pushed_at":"2016-10-08T14:48:52Z","git_url":"git://github.com/nmarcetic/mainflux.git","ssh_url":"git@github.com:nmarcetic/mainflux.git","clone_url":"https://github.com/nmarcetic/mainflux.git","svn_url":"https://github.com/nmarcetic/mainflux","homepage":"http://mainflux.com","size":129,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mainflux:master","ref":"master","sha":"9de6bc14481c8de945179438f99fc01b502c2cf7","user":{"login":"Mainflux","id":13207490,"avatar_url":"https://avatars.githubusercontent.com/u/13207490?v=3","gravatar_id":"","url":"https://api.github.com/users/Mainflux","html_url":"https://github.com/Mainflux","followers_url":"https://api.github.com/users/Mainflux/followers","following_url":"https://api.github.com/users/Mainflux/following{/other_user}","gists_url":"https://api.github.com/users/Mainflux/gists{/gist_id}","starred_url":"https://api.github.com/users/Mainflux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mainflux/subscriptions","organizations_url":"https://api.github.com/users/Mainflux/orgs","repos_url":"https://api.github.com/users/Mainflux/repos","events_url":"https://api.github.com/users/Mainflux/events{/privacy}","received_events_url":"https://api.github.com/users/Mainflux/received_events","type":"Organization","site_admin":false},"repo":{"id":38644318,"name":"mainflux","full_name":"Mainflux/mainflux","owner":{"login":"Mainflux","id":13207490,"avatar_url":"https://avatars.githubusercontent.com/u/13207490?v=3","gravatar_id":"","url":"https://api.github.com/users/Mainflux","html_url":"https://github.com/Mainflux","followers_url":"https://api.github.com/users/Mainflux/followers","following_url":"https://api.github.com/users/Mainflux/following{/other_user}","gists_url":"https://api.github.com/users/Mainflux/gists{/gist_id}","starred_url":"https://api.github.com/users/Mainflux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mainflux/subscriptions","organizations_url":"https://api.github.com/users/Mainflux/orgs","repos_url":"https://api.github.com/users/Mainflux/repos","events_url":"https://api.github.com/users/Mainflux/events{/privacy}","received_events_url":"https://api.github.com/users/Mainflux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mainflux/mainflux","description":"Industrial IoT Cloud","fork":false,"url":"https://api.github.com/repos/Mainflux/mainflux","forks_url":"https://api.github.com/repos/Mainflux/mainflux/forks","keys_url":"https://api.github.com/repos/Mainflux/mainflux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mainflux/mainflux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mainflux/mainflux/teams","hooks_url":"https://api.github.com/repos/Mainflux/mainflux/hooks","issue_events_url":"https://api.github.com/repos/Mainflux/mainflux/issues/events{/number}","events_url":"https://api.github.com/repos/Mainflux/mainflux/events","assignees_url":"https://api.github.com/repos/Mainflux/mainflux/assignees{/user}","branches_url":"https://api.github.com/repos/Mainflux/mainflux/branches{/branch}","tags_url":"https://api.github.com/repos/Mainflux/mainflux/tags","blobs_url":"https://api.github.com/repos/Mainflux/mainflux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mainflux/mainflux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mainflux/mainflux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mainflux/mainflux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mainflux/mainflux/statuses/{sha}","languages_url":"https://api.github.com/repos/Mainflux/mainflux/languages","stargazers_url":"https://api.github.com/repos/Mainflux/mainflux/stargazers","contributors_url":"https://api.github.com/repos/Mainflux/mainflux/contributors","subscribers_url":"https://api.github.com/repos/Mainflux/mainflux/subscribers","subscription_url":"https://api.github.com/repos/Mainflux/mainflux/subscription","commits_url":"https://api.github.com/repos/Mainflux/mainflux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mainflux/mainflux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mainflux/mainflux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mainflux/mainflux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mainflux/mainflux/contents/{+path}","compare_url":"https://api.github.com/repos/Mainflux/mainflux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mainflux/mainflux/merges","archive_url":"https://api.github.com/repos/Mainflux/mainflux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mainflux/mainflux/downloads","issues_url":"https://api.github.com/repos/Mainflux/mainflux/issues{/number}","pulls_url":"https://api.github.com/repos/Mainflux/mainflux/pulls{/number}","milestones_url":"https://api.github.com/repos/Mainflux/mainflux/milestones{/number}","notifications_url":"https://api.github.com/repos/Mainflux/mainflux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mainflux/mainflux/labels{/name}","releases_url":"https://api.github.com/repos/Mainflux/mainflux/releases{/id}","deployments_url":"https://api.github.com/repos/Mainflux/mainflux/deployments","created_at":"2015-07-06T20:31:50Z","updated_at":"2016-10-04T12:32:37Z","pushed_at":"2016-10-08T14:53:24Z","git_url":"git://github.com/Mainflux/mainflux.git","ssh_url":"git@github.com:Mainflux/mainflux.git","clone_url":"https://github.com/Mainflux/mainflux.git","svn_url":"https://github.com/Mainflux/mainflux","homepage":"http://mainflux.com","size":139,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/63"},"html":{"href":"https://github.com/Mainflux/mainflux/pull/63"},"issue":{"href":"https://api.github.com/repos/Mainflux/mainflux/issues/63"},"comments":{"href":"https://api.github.com/repos/Mainflux/mainflux/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mainflux/mainflux/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/Mainflux/mainflux/statuses/de236fcc90a4afba95340c63c52b728666d05bcf"}}}}
{"actor":{"display_login":"drasko"}}