{"action":"created","issue":{"url":"https://api.github.com/repos/randym/axlsx/issues/477","repository_url":"https://api.github.com/repos/randym/axlsx","labels_url":"https://api.github.com/repos/randym/axlsx/issues/477/labels{/name}","comments_url":"https://api.github.com/repos/randym/axlsx/issues/477/comments","events_url":"https://api.github.com/repos/randym/axlsx/issues/477/events","html_url":"https://github.com/randym/axlsx/pull/477","id":169084654,"number":477,"title":"Fix Relationship.instances cache.","user":{"login":"marshall-lee","id":3194530,"avatar_url":"https://avatars.githubusercontent.com/u/3194530?v=3","gravatar_id":"","url":"https://api.github.com/users/marshall-lee","html_url":"https://github.com/marshall-lee","followers_url":"https://api.github.com/users/marshall-lee/followers","following_url":"https://api.github.com/users/marshall-lee/following{/other_user}","gists_url":"https://api.github.com/users/marshall-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/marshall-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshall-lee/subscriptions","organizations_url":"https://api.github.com/users/marshall-lee/orgs","repos_url":"https://api.github.com/users/marshall-lee/repos","events_url":"https://api.github.com/users/marshall-lee/events{/privacy}","received_events_url":"https://api.github.com/users/marshall-lee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-03T09:15:26Z","updated_at":"2016-11-03T01:48:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/randym/axlsx/pulls/477","html_url":"https://github.com/randym/axlsx/pull/477","diff_url":"https://github.com/randym/axlsx/pull/477.diff","patch_url":"https://github.com/randym/axlsx/pull/477.patch"},"body":"This PR aims to fix several issues with Relationship cache:\n\n1) It's not threadsafe, so I propose to use a TLS variable for this.\n2) Memory obtained by cache remains non-freed before the next run of `serialize`. I think it should be freed immediately.\n3) Memory should be freed in `ensure` block to prevent memory bloating in case of exception.\n\n_There are only two hard things in Computer Science: cache invalidation and naming things._\n"},"comment":{"url":"https://api.github.com/repos/randym/axlsx/issues/comments/258048869","html_url":"https://github.com/randym/axlsx/pull/477#issuecomment-258048869","issue_url":"https://api.github.com/repos/randym/axlsx/issues/477","id":258048869,"user":{"login":"randym","id":870812,"avatar_url":"https://avatars.githubusercontent.com/u/870812?v=3","gravatar_id":"","url":"https://api.github.com/users/randym","html_url":"https://github.com/randym","followers_url":"https://api.github.com/users/randym/followers","following_url":"https://api.github.com/users/randym/following{/other_user}","gists_url":"https://api.github.com/users/randym/gists{/gist_id}","starred_url":"https://api.github.com/users/randym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randym/subscriptions","organizations_url":"https://api.github.com/users/randym/orgs","repos_url":"https://api.github.com/users/randym/repos","events_url":"https://api.github.com/users/randym/events{/privacy}","received_events_url":"https://api.github.com/users/randym/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T01:48:29Z","updated_at":"2016-11-03T01:48:29Z","body":"@marshall-lee would you be kind enough to rebase and add specs for your changes?"}}
{"actor":{"display_login":"randym"}}