{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/73707733","id":73707733,"diff_hunk":"@@ -1,80 +1,59 @@\n-require 'postgres_ha_admin/postgres_ha_admin'\n require 'pg'\n require 'pg/dsn_parser'\n \n module PostgresHaAdmin\n   class FailoverDatabases\n     TABLE_NAME = \"repl_nodes\".freeze\n \n-    attr_reader :yml_file, :connection_hash, :logger, :log_file\n+    attr_reader :yml_file, :logger","path":"gems/pending/postgres_ha_admin/failover_databases.rb","position":10,"original_position":10,"commit_id":"6ba63e1c908b00aa566ba1de1a5e2dd780e7863c","original_commit_id":"6ba63e1c908b00aa566ba1de1a5e2dd780e7863c","user":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"body":"Does logger need to be an `attr_reader`?","created_at":"2016-08-05T15:09:05Z","updated_at":"2016-08-05T15:09:05Z","html_url":"https://github.com/ManageIQ/manageiq/pull/10271#discussion_r73707733","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/73707733"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10271#discussion_r73707733"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271","id":80154977,"html_url":"https://github.com/ManageIQ/manageiq/pull/10271","diff_url":"https://github.com/ManageIQ/manageiq/pull/10271.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10271.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10271","number":10271,"state":"open","locked":false,"title":"Refactored FailoverDatabases and corresponding rspec","user":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"body":"Refactoring FailoverDatabases class making code cleaner and allowing to use```Tempfile``` in rspec instead of 'real' files.\r\n\r\nThis PR is follow-up for: https://github.com/ManageIQ/manageiq/pull/10103\r\n\r\n/cc @carbonin \r\n","created_at":"2016-08-04T21:43:52Z","updated_at":"2016-08-05T15:09:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01090fde776f4665e64ec043f924e65b8cb2a3f9","assignee":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"assignees":[{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10271/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6ba63e1c908b00aa566ba1de1a5e2dd780e7863c","head":{"label":"yrudman:refactor-failover_databases","ref":"refactor-failover_databases","sha":"6ba63e1c908b00aa566ba1de1a5e2dd780e7863c","user":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"repo":{"id":50465345,"name":"manageiq","full_name":"yrudman/manageiq","owner":{"login":"yrudman","id":6556758,"avatar_url":"https://avatars.githubusercontent.com/u/6556758?v=3","gravatar_id":"","url":"https://api.github.com/users/yrudman","html_url":"https://github.com/yrudman","followers_url":"https://api.github.com/users/yrudman/followers","following_url":"https://api.github.com/users/yrudman/following{/other_user}","gists_url":"https://api.github.com/users/yrudman/gists{/gist_id}","starred_url":"https://api.github.com/users/yrudman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrudman/subscriptions","organizations_url":"https://api.github.com/users/yrudman/orgs","repos_url":"https://api.github.com/users/yrudman/repos","events_url":"https://api.github.com/users/yrudman/events{/privacy}","received_events_url":"https://api.github.com/users/yrudman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrudman/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/yrudman/manageiq","forks_url":"https://api.github.com/repos/yrudman/manageiq/forks","keys_url":"https://api.github.com/repos/yrudman/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrudman/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrudman/manageiq/teams","hooks_url":"https://api.github.com/repos/yrudman/manageiq/hooks","issue_events_url":"https://api.github.com/repos/yrudman/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/yrudman/manageiq/events","assignees_url":"https://api.github.com/repos/yrudman/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/yrudman/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/yrudman/manageiq/tags","blobs_url":"https://api.github.com/repos/yrudman/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrudman/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrudman/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrudman/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrudman/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/yrudman/manageiq/languages","stargazers_url":"https://api.github.com/repos/yrudman/manageiq/stargazers","contributors_url":"https://api.github.com/repos/yrudman/manageiq/contributors","subscribers_url":"https://api.github.com/repos/yrudman/manageiq/subscribers","subscription_url":"https://api.github.com/repos/yrudman/manageiq/subscription","commits_url":"https://api.github.com/repos/yrudman/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrudman/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrudman/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrudman/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrudman/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/yrudman/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrudman/manageiq/merges","archive_url":"https://api.github.com/repos/yrudman/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrudman/manageiq/downloads","issues_url":"https://api.github.com/repos/yrudman/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/yrudman/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/yrudman/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/yrudman/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrudman/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/yrudman/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/yrudman/manageiq/deployments","created_at":"2016-01-26T22:55:59Z","updated_at":"2016-01-26T22:56:16Z","pushed_at":"2016-08-05T11:35:08Z","git_url":"git://github.com/yrudman/manageiq.git","ssh_url":"git@github.com:yrudman/manageiq.git","clone_url":"https://github.com/yrudman/manageiq.git","svn_url":"https://github.com/yrudman/manageiq","homepage":"manageiq.org","size":141945,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c16a171551a842ca98598ed53fa645d449913b3a","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-08-04T01:15:42Z","pushed_at":"2016-08-05T15:04:28Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":191613,"stargazers_count":299,"watchers_count":299,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":744,"forks":332,"open_issues":744,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10271"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10271"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10271/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10271/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/6ba63e1c908b00aa566ba1de1a5e2dd780e7863c"}}}}
{"actor":{"display_login":"carbonin"}}