{"action":"created","issue":{"url":"https://api.github.com/repos/uber/tchannel-go/issues/438","repository_url":"https://api.github.com/repos/uber/tchannel-go","labels_url":"https://api.github.com/repos/uber/tchannel-go/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/uber/tchannel-go/issues/438/comments","events_url":"https://api.github.com/repos/uber/tchannel-go/issues/438/events","html_url":"https://github.com/uber/tchannel-go/pull/438","id":165809299,"number":438,"title":"Fix flaky test TestResponseClosedBeforeRequest","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/uber/tchannel-go/labels/test","name":"test","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-15T15:08:52Z","updated_at":"2016-07-15T15:51:59Z","closed_at":"2016-07-15T15:24:07Z","pull_request":{"url":"https://api.github.com/repos/uber/tchannel-go/pulls/438","html_url":"https://github.com/uber/tchannel-go/pull/438","diff_url":"https://github.com/uber/tchannel-go/pull/438.diff","patch_url":"https://github.com/uber/tchannel-go/pull/438.patch"},"body":"On the writer side, the last flush of the \"closeRequest\" byte would fail\r\nwith \"mex has been shutdown\". The following sequence of events was\r\ncausing the issue:\r\n\r\n - Flush calls flushFragment, which sends a frame with the \"closeRequest\" byte\r\n - The remote side receives the byte, and closes the response\r\n - Sender receives the last response frame, and shuts down the mex\r\n - Original goroutine in Flush calls newFragment (since previous\r\n   fragment) has been sent\r\n - newFragment fails since the mex has been shutdown\r\n\r\nSince this is a valid sequence of events, we ignore the error from\r\nFlush when writing out the closeRequest byte. This issue is unlikely\r\nto happen in production, since the network calls to send and receive\r\nframes should take longer than scheduling the goroutine running Flush.\r\n\r\n\r\ncc @akshayjshah\r\nFixes #431 "},"comment":{"url":"https://api.github.com/repos/uber/tchannel-go/issues/comments/232990936","html_url":"https://github.com/uber/tchannel-go/pull/438#issuecomment-232990936","issue_url":"https://api.github.com/repos/uber/tchannel-go/issues/438","id":232990936,"user":{"login":"akshayjshah","id":972790,"avatar_url":"https://avatars.githubusercontent.com/u/972790?v=3","gravatar_id":"","url":"https://api.github.com/users/akshayjshah","html_url":"https://github.com/akshayjshah","followers_url":"https://api.github.com/users/akshayjshah/followers","following_url":"https://api.github.com/users/akshayjshah/following{/other_user}","gists_url":"https://api.github.com/users/akshayjshah/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayjshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayjshah/subscriptions","organizations_url":"https://api.github.com/users/akshayjshah/orgs","repos_url":"https://api.github.com/users/akshayjshah/repos","events_url":"https://api.github.com/users/akshayjshah/events{/privacy}","received_events_url":"https://api.github.com/users/akshayjshah/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T15:51:59Z","updated_at":"2016-07-15T15:51:59Z","body":"tricky, tricky. lgtm."}}
{"actor":{"display_login":"akshayjshah"}}