{"action":"created","comment":{"url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/comments/86171755","pull_request_review_id":6842172,"id":86171755,"diff_hunk":"@@ -0,0 +1,61 @@\n+#!/usr/bin/python\n+import os\n+import Install_DB.initialize_db as init_sql\n+import Install_DB.update_manager as um","path":"Install_DB/installer.py","position":4,"original_position":4,"commit_id":"ee722737cce5a0aba1f4e4555866918b988013d7","original_commit_id":"ee722737cce5a0aba1f4e4555866918b988013d7","user":{"login":"Gendostie","id":8163028,"avatar_url":"https://avatars.githubusercontent.com/u/8163028?v=3","gravatar_id":"","url":"https://api.github.com/users/Gendostie","html_url":"https://github.com/Gendostie","followers_url":"https://api.github.com/users/Gendostie/followers","following_url":"https://api.github.com/users/Gendostie/following{/other_user}","gists_url":"https://api.github.com/users/Gendostie/gists{/gist_id}","starred_url":"https://api.github.com/users/Gendostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gendostie/subscriptions","organizations_url":"https://api.github.com/users/Gendostie/orgs","repos_url":"https://api.github.com/users/Gendostie/repos","events_url":"https://api.github.com/users/Gendostie/events{/privacy}","received_events_url":"https://api.github.com/users/Gendostie/received_events","type":"User","site_admin":false},"body":"Je sais qu'on en a parler, mais dans les import, le nom du dossier devrait pas être là si les script sont dans le même dossier.","created_at":"2016-11-02T15:39:43Z","updated_at":"2016-11-02T15:39:43Z","html_url":"https://github.com/Gendostie/market-analysis/pull/7#discussion_r86171755","pull_request_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/comments/86171755"},"html":{"href":"https://github.com/Gendostie/market-analysis/pull/7#discussion_r86171755"},"pull_request":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7","id":91521704,"html_url":"https://github.com/Gendostie/market-analysis/pull/7","diff_url":"https://github.com/Gendostie/market-analysis/pull/7.diff","patch_url":"https://github.com/Gendostie/market-analysis/pull/7.patch","issue_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/7","number":7,"state":"open","locked":false,"title":"Create installer","user":{"login":"j-philippe-rochette","id":6010789,"avatar_url":"https://avatars.githubusercontent.com/u/6010789?v=3","gravatar_id":"","url":"https://api.github.com/users/j-philippe-rochette","html_url":"https://github.com/j-philippe-rochette","followers_url":"https://api.github.com/users/j-philippe-rochette/followers","following_url":"https://api.github.com/users/j-philippe-rochette/following{/other_user}","gists_url":"https://api.github.com/users/j-philippe-rochette/gists{/gist_id}","starred_url":"https://api.github.com/users/j-philippe-rochette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-philippe-rochette/subscriptions","organizations_url":"https://api.github.com/users/j-philippe-rochette/orgs","repos_url":"https://api.github.com/users/j-philippe-rochette/repos","events_url":"https://api.github.com/users/j-philippe-rochette/events{/privacy}","received_events_url":"https://api.github.com/users/j-philippe-rochette/received_events","type":"User","site_admin":false},"body":"La fonction installer.py fonctionne maintenant très bien et j'ai fait le merge avec la branche master. Si tu veux la tester, je te conseille de slicer la liste sp500 dans la fonction get_csv (j'ai mis un commentaire). Ça prend quand même plusieurs minutes en allant chercher seulement l'information de l'année jusqu'à aujourd'hui pour 50 compagnies sooooooo.. Les 505 pour 10 ans c'est pas mal long!\n\nJ'estime 10h sur mon vieil ordi environ et peut-être 5-6h sur ceux de l'école (estimation faite avec une plus vieille version mais rien a vraiment changé depuis). Pour 10 mois et 50 compagnies, ça donne 9800 lignes. Si on (sous)estime les entrées à 10'000 lignes par années pour 50 compagnies, c'est au moins un milliard pour les 505 en 10 ans!\n\nLe \"noeud\" c'est l'insertion dans la BD des données \"daily\" vu qu'il y en a vraiment beaucoup (comme démontré) et que je les insère une à une. Ça pourrait être un issue à régler pour plus tard mais en attendant je suggère de juste prendre des plus petits ensembles de données pour nos tests. On pourrait peut-être voir pour faire une copie de la table \"daily\" au pire et de l'inclure direct en partant dans notre application? Je sais pas si ça se fait.\n","created_at":"2016-10-30T13:27:00Z","updated_at":"2016-11-02T15:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adcb1e9acd2091030facdfb69feca3a19d01a7d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/7/comments","statuses_url":"https://api.github.com/repos/Gendostie/market-analysis/statuses/ee722737cce5a0aba1f4e4555866918b988013d7","head":{"label":"Gendostie:create_installer","ref":"create_installer","sha":"ee722737cce5a0aba1f4e4555866918b988013d7","user":{"login":"Gendostie","id":8163028,"avatar_url":"https://avatars.githubusercontent.com/u/8163028?v=3","gravatar_id":"","url":"https://api.github.com/users/Gendostie","html_url":"https://github.com/Gendostie","followers_url":"https://api.github.com/users/Gendostie/followers","following_url":"https://api.github.com/users/Gendostie/following{/other_user}","gists_url":"https://api.github.com/users/Gendostie/gists{/gist_id}","starred_url":"https://api.github.com/users/Gendostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gendostie/subscriptions","organizations_url":"https://api.github.com/users/Gendostie/orgs","repos_url":"https://api.github.com/users/Gendostie/repos","events_url":"https://api.github.com/users/Gendostie/events{/privacy}","received_events_url":"https://api.github.com/users/Gendostie/received_events","type":"User","site_admin":false},"repo":{"id":68839420,"name":"market-analysis","full_name":"Gendostie/market-analysis","owner":{"login":"Gendostie","id":8163028,"avatar_url":"https://avatars.githubusercontent.com/u/8163028?v=3","gravatar_id":"","url":"https://api.github.com/users/Gendostie","html_url":"https://github.com/Gendostie","followers_url":"https://api.github.com/users/Gendostie/followers","following_url":"https://api.github.com/users/Gendostie/following{/other_user}","gists_url":"https://api.github.com/users/Gendostie/gists{/gist_id}","starred_url":"https://api.github.com/users/Gendostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gendostie/subscriptions","organizations_url":"https://api.github.com/users/Gendostie/orgs","repos_url":"https://api.github.com/users/Gendostie/repos","events_url":"https://api.github.com/users/Gendostie/events{/privacy}","received_events_url":"https://api.github.com/users/Gendostie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gendostie/market-analysis","description":null,"fork":false,"url":"https://api.github.com/repos/Gendostie/market-analysis","forks_url":"https://api.github.com/repos/Gendostie/market-analysis/forks","keys_url":"https://api.github.com/repos/Gendostie/market-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gendostie/market-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gendostie/market-analysis/teams","hooks_url":"https://api.github.com/repos/Gendostie/market-analysis/hooks","issue_events_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/Gendostie/market-analysis/events","assignees_url":"https://api.github.com/repos/Gendostie/market-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/Gendostie/market-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/Gendostie/market-analysis/tags","blobs_url":"https://api.github.com/repos/Gendostie/market-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gendostie/market-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gendostie/market-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gendostie/market-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gendostie/market-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Gendostie/market-analysis/languages","stargazers_url":"https://api.github.com/repos/Gendostie/market-analysis/stargazers","contributors_url":"https://api.github.com/repos/Gendostie/market-analysis/contributors","subscribers_url":"https://api.github.com/repos/Gendostie/market-analysis/subscribers","subscription_url":"https://api.github.com/repos/Gendostie/market-analysis/subscription","commits_url":"https://api.github.com/repos/Gendostie/market-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gendostie/market-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gendostie/market-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gendostie/market-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/Gendostie/market-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gendostie/market-analysis/merges","archive_url":"https://api.github.com/repos/Gendostie/market-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gendostie/market-analysis/downloads","issues_url":"https://api.github.com/repos/Gendostie/market-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Gendostie/market-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Gendostie/market-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gendostie/market-analysis/labels{/name}","releases_url":"https://api.github.com/repos/Gendostie/market-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/Gendostie/market-analysis/deployments","created_at":"2016-09-21T17:06:49Z","updated_at":"2016-09-24T22:00:15Z","pushed_at":"2016-11-02T15:28:40Z","git_url":"git://github.com/Gendostie/market-analysis.git","ssh_url":"git@github.com:Gendostie/market-analysis.git","clone_url":"https://github.com/Gendostie/market-analysis.git","svn_url":"https://github.com/Gendostie/market-analysis","homepage":null,"size":919,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"Gendostie:master","ref":"master","sha":"4deb427eb16f5f7bae2072abe6e56eefab54b8a3","user":{"login":"Gendostie","id":8163028,"avatar_url":"https://avatars.githubusercontent.com/u/8163028?v=3","gravatar_id":"","url":"https://api.github.com/users/Gendostie","html_url":"https://github.com/Gendostie","followers_url":"https://api.github.com/users/Gendostie/followers","following_url":"https://api.github.com/users/Gendostie/following{/other_user}","gists_url":"https://api.github.com/users/Gendostie/gists{/gist_id}","starred_url":"https://api.github.com/users/Gendostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gendostie/subscriptions","organizations_url":"https://api.github.com/users/Gendostie/orgs","repos_url":"https://api.github.com/users/Gendostie/repos","events_url":"https://api.github.com/users/Gendostie/events{/privacy}","received_events_url":"https://api.github.com/users/Gendostie/received_events","type":"User","site_admin":false},"repo":{"id":68839420,"name":"market-analysis","full_name":"Gendostie/market-analysis","owner":{"login":"Gendostie","id":8163028,"avatar_url":"https://avatars.githubusercontent.com/u/8163028?v=3","gravatar_id":"","url":"https://api.github.com/users/Gendostie","html_url":"https://github.com/Gendostie","followers_url":"https://api.github.com/users/Gendostie/followers","following_url":"https://api.github.com/users/Gendostie/following{/other_user}","gists_url":"https://api.github.com/users/Gendostie/gists{/gist_id}","starred_url":"https://api.github.com/users/Gendostie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gendostie/subscriptions","organizations_url":"https://api.github.com/users/Gendostie/orgs","repos_url":"https://api.github.com/users/Gendostie/repos","events_url":"https://api.github.com/users/Gendostie/events{/privacy}","received_events_url":"https://api.github.com/users/Gendostie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gendostie/market-analysis","description":null,"fork":false,"url":"https://api.github.com/repos/Gendostie/market-analysis","forks_url":"https://api.github.com/repos/Gendostie/market-analysis/forks","keys_url":"https://api.github.com/repos/Gendostie/market-analysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gendostie/market-analysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gendostie/market-analysis/teams","hooks_url":"https://api.github.com/repos/Gendostie/market-analysis/hooks","issue_events_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/events{/number}","events_url":"https://api.github.com/repos/Gendostie/market-analysis/events","assignees_url":"https://api.github.com/repos/Gendostie/market-analysis/assignees{/user}","branches_url":"https://api.github.com/repos/Gendostie/market-analysis/branches{/branch}","tags_url":"https://api.github.com/repos/Gendostie/market-analysis/tags","blobs_url":"https://api.github.com/repos/Gendostie/market-analysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gendostie/market-analysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gendostie/market-analysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gendostie/market-analysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gendostie/market-analysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Gendostie/market-analysis/languages","stargazers_url":"https://api.github.com/repos/Gendostie/market-analysis/stargazers","contributors_url":"https://api.github.com/repos/Gendostie/market-analysis/contributors","subscribers_url":"https://api.github.com/repos/Gendostie/market-analysis/subscribers","subscription_url":"https://api.github.com/repos/Gendostie/market-analysis/subscription","commits_url":"https://api.github.com/repos/Gendostie/market-analysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gendostie/market-analysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gendostie/market-analysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gendostie/market-analysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gendostie/market-analysis/contents/{+path}","compare_url":"https://api.github.com/repos/Gendostie/market-analysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gendostie/market-analysis/merges","archive_url":"https://api.github.com/repos/Gendostie/market-analysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gendostie/market-analysis/downloads","issues_url":"https://api.github.com/repos/Gendostie/market-analysis/issues{/number}","pulls_url":"https://api.github.com/repos/Gendostie/market-analysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Gendostie/market-analysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Gendostie/market-analysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gendostie/market-analysis/labels{/name}","releases_url":"https://api.github.com/repos/Gendostie/market-analysis/releases{/id}","deployments_url":"https://api.github.com/repos/Gendostie/market-analysis/deployments","created_at":"2016-09-21T17:06:49Z","updated_at":"2016-09-24T22:00:15Z","pushed_at":"2016-11-02T15:28:40Z","git_url":"git://github.com/Gendostie/market-analysis.git","ssh_url":"git@github.com:Gendostie/market-analysis.git","clone_url":"https://github.com/Gendostie/market-analysis.git","svn_url":"https://github.com/Gendostie/market-analysis","homepage":null,"size":919,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7"},"html":{"href":"https://github.com/Gendostie/market-analysis/pull/7"},"issue":{"href":"https://api.github.com/repos/Gendostie/market-analysis/issues/7"},"comments":{"href":"https://api.github.com/repos/Gendostie/market-analysis/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Gendostie/market-analysis/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Gendostie/market-analysis/statuses/ee722737cce5a0aba1f4e4555866918b988013d7"}}}}
{"actor":{"display_login":"Gendostie"}}