{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/53225996","id":53225996,"diff_hunk":"@@ -592,8 +589,7 @@ protected virtual bool IsAction(TypeInfo typeInfo, MethodInfo methodInfo)\n             var routeTemplateProvider =\n                 attributes\n                 .OfType<IRouteTemplateProvider>()\n-                .Where(a => !IsSilentRouteAttribute(a))\n-                .SingleOrDefault();\n+                .SingleOrDefault(a => !IsSilentRouteAttribute(a));","path":"src/Microsoft.AspNetCore.Mvc.Core/Internal/DefaultApplicationModelProvider.cs","position":18,"original_position":18,"commit_id":"e4508402e497150f1c8cc2c46adb936d019f24f9","original_commit_id":"e4508402e497150f1c8cc2c46adb936d019f24f9","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"That would hide a bug. It's intended that this method only be called when one or zero attributes is a non-silent route provided. TLDR all of this code is complicated on purpose.","created_at":"2016-02-17T20:26:04Z","updated_at":"2016-02-17T20:26:04Z","html_url":"https://github.com/aspnet/Mvc/pull/4109#discussion_r53225996","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4109","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/53225996"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4109#discussion_r53225996"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4109"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/4109","id":59671224,"html_url":"https://github.com/aspnet/Mvc/pull/4109","diff_url":"https://github.com/aspnet/Mvc/pull/4109.diff","patch_url":"https://github.com/aspnet/Mvc/pull/4109.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/4109","number":4109,"state":"open","locked":false,"title":"Small Refactorings","user":{"login":"calebnelton","id":5648963,"avatar_url":"https://avatars.githubusercontent.com/u/5648963?v=3","gravatar_id":"","url":"https://api.github.com/users/calebnelton","html_url":"https://github.com/calebnelton","followers_url":"https://api.github.com/users/calebnelton/followers","following_url":"https://api.github.com/users/calebnelton/following{/other_user}","gists_url":"https://api.github.com/users/calebnelton/gists{/gist_id}","starred_url":"https://api.github.com/users/calebnelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebnelton/subscriptions","organizations_url":"https://api.github.com/users/calebnelton/orgs","repos_url":"https://api.github.com/users/calebnelton/repos","events_url":"https://api.github.com/users/calebnelton/events{/privacy}","received_events_url":"https://api.github.com/users/calebnelton/received_events","type":"User","site_admin":false},"body":"Was not paying attention in WebEx meeting ... this was more fun.","created_at":"2016-02-17T16:37:55Z","updated_at":"2016-02-17T20:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b553d7cc8612e1c24fd7a4167ffaf5d6f928cd6e","assignee":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars.githubusercontent.com/u/174281?v=3","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4109/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/4109/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/4109/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/e4508402e497150f1c8cc2c46adb936d019f24f9","head":{"label":"calebnelton:dev","ref":"dev","sha":"e4508402e497150f1c8cc2c46adb936d019f24f9","user":{"login":"calebnelton","id":5648963,"avatar_url":"https://avatars.githubusercontent.com/u/5648963?v=3","gravatar_id":"","url":"https://api.github.com/users/calebnelton","html_url":"https://github.com/calebnelton","followers_url":"https://api.github.com/users/calebnelton/followers","following_url":"https://api.github.com/users/calebnelton/following{/other_user}","gists_url":"https://api.github.com/users/calebnelton/gists{/gist_id}","starred_url":"https://api.github.com/users/calebnelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebnelton/subscriptions","organizations_url":"https://api.github.com/users/calebnelton/orgs","repos_url":"https://api.github.com/users/calebnelton/repos","events_url":"https://api.github.com/users/calebnelton/events{/privacy}","received_events_url":"https://api.github.com/users/calebnelton/received_events","type":"User","site_admin":false},"repo":{"id":51932842,"name":"Mvc","full_name":"calebnelton/Mvc","owner":{"login":"calebnelton","id":5648963,"avatar_url":"https://avatars.githubusercontent.com/u/5648963?v=3","gravatar_id":"","url":"https://api.github.com/users/calebnelton","html_url":"https://github.com/calebnelton","followers_url":"https://api.github.com/users/calebnelton/followers","following_url":"https://api.github.com/users/calebnelton/following{/other_user}","gists_url":"https://api.github.com/users/calebnelton/gists{/gist_id}","starred_url":"https://api.github.com/users/calebnelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebnelton/subscriptions","organizations_url":"https://api.github.com/users/calebnelton/orgs","repos_url":"https://api.github.com/users/calebnelton/repos","events_url":"https://api.github.com/users/calebnelton/events{/privacy}","received_events_url":"https://api.github.com/users/calebnelton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calebnelton/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":true,"url":"https://api.github.com/repos/calebnelton/Mvc","forks_url":"https://api.github.com/repos/calebnelton/Mvc/forks","keys_url":"https://api.github.com/repos/calebnelton/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calebnelton/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calebnelton/Mvc/teams","hooks_url":"https://api.github.com/repos/calebnelton/Mvc/hooks","issue_events_url":"https://api.github.com/repos/calebnelton/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/calebnelton/Mvc/events","assignees_url":"https://api.github.com/repos/calebnelton/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/calebnelton/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/calebnelton/Mvc/tags","blobs_url":"https://api.github.com/repos/calebnelton/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calebnelton/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calebnelton/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/calebnelton/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calebnelton/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/calebnelton/Mvc/languages","stargazers_url":"https://api.github.com/repos/calebnelton/Mvc/stargazers","contributors_url":"https://api.github.com/repos/calebnelton/Mvc/contributors","subscribers_url":"https://api.github.com/repos/calebnelton/Mvc/subscribers","subscription_url":"https://api.github.com/repos/calebnelton/Mvc/subscription","commits_url":"https://api.github.com/repos/calebnelton/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/calebnelton/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/calebnelton/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/calebnelton/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/calebnelton/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/calebnelton/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calebnelton/Mvc/merges","archive_url":"https://api.github.com/repos/calebnelton/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calebnelton/Mvc/downloads","issues_url":"https://api.github.com/repos/calebnelton/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/calebnelton/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/calebnelton/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/calebnelton/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calebnelton/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/calebnelton/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/calebnelton/Mvc/deployments","created_at":"2016-02-17T15:31:39Z","updated_at":"2016-02-17T15:31:45Z","pushed_at":"2016-02-17T16:35:03Z","git_url":"git://github.com/calebnelton/Mvc.git","ssh_url":"git@github.com:calebnelton/Mvc.git","clone_url":"https://github.com/calebnelton/Mvc.git","svn_url":"https://github.com/calebnelton/Mvc","homepage":"","size":21125,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"910f0139f9b2681cc65d3451d4c8b9ceddaefd63","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2016-02-17T17:19:00Z","pushed_at":"2016-02-17T19:23:43Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":28771,"stargazers_count":2748,"watchers_count":2748,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1089,"mirror_url":null,"open_issues_count":267,"forks":1089,"open_issues":267,"watchers":2748,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4109"},"html":{"href":"https://github.com/aspnet/Mvc/pull/4109"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4109"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/4109/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4109/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/4109/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/e4508402e497150f1c8cc2c46adb936d019f24f9"}}}}