{"action":"created","issue":{"url":"https://api.github.com/repos/jcabi/jcabi-email/issues/50","repository_url":"https://api.github.com/repos/jcabi/jcabi-email","labels_url":"https://api.github.com/repos/jcabi/jcabi-email/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/jcabi/jcabi-email/issues/50/comments","events_url":"https://api.github.com/repos/jcabi/jcabi-email/issues/50/events","html_url":"https://github.com/jcabi/jcabi-email/pull/50","id":171610470,"number":50,"title":"SMTPS wire and unit test for SMTPS protocol","user":{"login":"amihaiemil","id":6305156,"avatar_url":"https://avatars.githubusercontent.com/u/6305156?v=3","gravatar_id":"","url":"https://api.github.com/users/amihaiemil","html_url":"https://github.com/amihaiemil","followers_url":"https://api.github.com/users/amihaiemil/followers","following_url":"https://api.github.com/users/amihaiemil/following{/other_user}","gists_url":"https://api.github.com/users/amihaiemil/gists{/gist_id}","starred_url":"https://api.github.com/users/amihaiemil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amihaiemil/subscriptions","organizations_url":"https://api.github.com/users/amihaiemil/orgs","repos_url":"https://api.github.com/users/amihaiemil/repos","events_url":"https://api.github.com/users/amihaiemil/events{/privacy}","received_events_url":"https://api.github.com/users/amihaiemil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jcabi/jcabi-email/labels/15%20mins","name":"15 mins","color":"eb6421"},{"url":"https://api.github.com/repos/jcabi/jcabi-email/labels/@mkordas","name":"@mkordas","color":"009801"},{"url":"https://api.github.com/repos/jcabi/jcabi-email/labels/CR","name":"CR","color":"bfd4f3"}],"state":"open","locked":false,"assignee":{"login":"mkordas","id":5467276,"avatar_url":"https://avatars.githubusercontent.com/u/5467276?v=3","gravatar_id":"","url":"https://api.github.com/users/mkordas","html_url":"https://github.com/mkordas","followers_url":"https://api.github.com/users/mkordas/followers","following_url":"https://api.github.com/users/mkordas/following{/other_user}","gists_url":"https://api.github.com/users/mkordas/gists{/gist_id}","starred_url":"https://api.github.com/users/mkordas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkordas/subscriptions","organizations_url":"https://api.github.com/users/mkordas/orgs","repos_url":"https://api.github.com/users/mkordas/repos","events_url":"https://api.github.com/users/mkordas/events{/privacy}","received_events_url":"https://api.github.com/users/mkordas/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkordas","id":5467276,"avatar_url":"https://avatars.githubusercontent.com/u/5467276?v=3","gravatar_id":"","url":"https://api.github.com/users/mkordas","html_url":"https://github.com/mkordas","followers_url":"https://api.github.com/users/mkordas/followers","following_url":"https://api.github.com/users/mkordas/following{/other_user}","gists_url":"https://api.github.com/users/mkordas/gists{/gist_id}","starred_url":"https://api.github.com/users/mkordas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkordas/subscriptions","organizations_url":"https://api.github.com/users/mkordas/orgs","repos_url":"https://api.github.com/users/mkordas/repos","events_url":"https://api.github.com/users/mkordas/events{/privacy}","received_events_url":"https://api.github.com/users/mkordas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-08-17T09:14:14Z","updated_at":"2016-08-19T15:45:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jcabi/jcabi-email/pulls/50","html_url":"https://github.com/jcabi/jcabi-email/pull/50","diff_url":"https://github.com/jcabi/jcabi-email/pull/50.diff","patch_url":"https://github.com/jcabi/jcabi-email/pull/50.patch"},"body":"PR for #46 \r\nAlso added SMTPS wire, since Protocol.SMTPS does not work with ``smtp`` transport, it needs ``smtps`` transport.\r\n\r\nUpdated javadocs too since they were not ok.\r\n\r\nFixed bug in Protocol.SMTPS which was setting some properties for smtp protocol, not for smtps.\r\n\r\n**More details:** \r\n\r\n**1)** This SMTPS Wire is needed since the Greenmail unit test does not work with the SMTP wire .\r\n\r\nThis issue was not found before since apparently Gmail server works fine if called with the SMTP wire and SMTPS protocol.\r\n\r\nI am not sure why Gmail worked with the SMTP wire, but it works with this SMTPS wire as well, so I would leave this as it is now, since it makes sense the most: If you send an email through SMTPS protocol, a smtps transport should be used.\r\n\r\n**2)** Properties from Protocol.SMTP were not ok since the smtps transport used in the SMTPS wire looks up the properties with \".smtps.\" in the middle, not \".smtp.\". If it does not find them, the defaults are used (localhost and port 465) and so the unit test passed locally, but failed on the linux server since you need root priviledge to access ports < 1024 .\r\n"},"comment":{"url":"https://api.github.com/repos/jcabi/jcabi-email/issues/comments/241054826","html_url":"https://github.com/jcabi/jcabi-email/pull/50#issuecomment-241054826","issue_url":"https://api.github.com/repos/jcabi/jcabi-email/issues/50","id":241054826,"user":{"login":"mkordas","id":5467276,"avatar_url":"https://avatars.githubusercontent.com/u/5467276?v=3","gravatar_id":"","url":"https://api.github.com/users/mkordas","html_url":"https://github.com/mkordas","followers_url":"https://api.github.com/users/mkordas/followers","following_url":"https://api.github.com/users/mkordas/following{/other_user}","gists_url":"https://api.github.com/users/mkordas/gists{/gist_id}","starred_url":"https://api.github.com/users/mkordas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkordas/subscriptions","organizations_url":"https://api.github.com/users/mkordas/orgs","repos_url":"https://api.github.com/users/mkordas/repos","events_url":"https://api.github.com/users/mkordas/events{/privacy}","received_events_url":"https://api.github.com/users/mkordas/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T15:45:23Z","updated_at":"2016-08-19T15:45:23Z","body":"@amihaiemil sure, I'll cheek it soon"}}
{"actor":{"display_login":"mkordas"}}