{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1034","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1034/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1034/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1034/events","html_url":"https://github.com/pmem/nvml/pull/1034","id":167865576,"number":1034,"title":"ut: remove all log files in setup()","user":{"login":"marcinslusarz","id":12811376,"avatar_url":"https://avatars.githubusercontent.com/u/12811376?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinslusarz","html_url":"https://github.com/marcinslusarz","followers_url":"https://api.github.com/users/marcinslusarz/followers","following_url":"https://api.github.com/users/marcinslusarz/following{/other_user}","gists_url":"https://api.github.com/users/marcinslusarz/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinslusarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinslusarz/subscriptions","organizations_url":"https://api.github.com/users/marcinslusarz/orgs","repos_url":"https://api.github.com/users/marcinslusarz/repos","events_url":"https://api.github.com/users/marcinslusarz/events{/privacy}","received_events_url":"https://api.github.com/users/marcinslusarz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-27T14:18:57Z","updated_at":"2016-07-28T14:31:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1034","html_url":"https://github.com/pmem/nvml/pull/1034","diff_url":"https://github.com/pmem/nvml/pull/1034.diff","patch_url":"https://github.com/pmem/nvml/pull/1034.patch"},"body":"Release libraries ignore *_LOG_FILE variables, so when test passes\r\nin debug mode, but fails in release mode, it's easy to get confused\r\nby looking at log file from previous run.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1034)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/235912413","html_url":"https://github.com/pmem/nvml/pull/1034#issuecomment-235912413","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1034","id":235912413,"user":{"login":"marcinslusarz","id":12811376,"avatar_url":"https://avatars.githubusercontent.com/u/12811376?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinslusarz","html_url":"https://github.com/marcinslusarz","followers_url":"https://api.github.com/users/marcinslusarz/followers","following_url":"https://api.github.com/users/marcinslusarz/following{/other_user}","gists_url":"https://api.github.com/users/marcinslusarz/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinslusarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinslusarz/subscriptions","organizations_url":"https://api.github.com/users/marcinslusarz/orgs","repos_url":"https://api.github.com/users/marcinslusarz/repos","events_url":"https://api.github.com/users/marcinslusarz/events{/privacy}","received_events_url":"https://api.github.com/users/marcinslusarz/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T14:31:40Z","updated_at":"2016-07-28T14:31:40Z","body":"\n\n\n\n\n\n\n\n*[src/test/unittest/unittest.sh, line 1587 \\[r1\\]](https://reviewable.io:443/reviews/pmem/nvml/1034#-KNhCSAKNd4iqlHw9tBN:-KNkiJLsJdZSPR02OxtQ:1865807290) ([raw file](https://github.com/pmem/nvml/blob/59ea49218e21977d02d23829bef17dca98e61b66/src/test/unittest/unittest.sh#L1587)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary>\n> Just out of curiosity - wouldn't it be enough to do:\n> `rm -f *.log` ?\n</details>\nThis command would remove logs for all tests. Tests are run in parallel, so this change would break it.\nSee the newest version.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1034)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"marcinslusarz"}}