{"action":"created","issue":{"url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/61","repository_url":"https://api.github.com/repos/justindowning/puppet-rbenv","labels_url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/61/comments","events_url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/61/events","html_url":"https://github.com/justindowning/puppet-rbenv/pull/61","id":187093630,"number":61,"title":"Fix test command not to run fetch-rbenv anytime puppet runs when version is set.","user":{"login":"sfzylad","id":22446399,"avatar_url":"https://avatars.githubusercontent.com/u/22446399?v=3","gravatar_id":"","url":"https://api.github.com/users/sfzylad","html_url":"https://github.com/sfzylad","followers_url":"https://api.github.com/users/sfzylad/followers","following_url":"https://api.github.com/users/sfzylad/following{/other_user}","gists_url":"https://api.github.com/users/sfzylad/gists{/gist_id}","starred_url":"https://api.github.com/users/sfzylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfzylad/subscriptions","organizations_url":"https://api.github.com/users/sfzylad/orgs","repos_url":"https://api.github.com/users/sfzylad/repos","events_url":"https://api.github.com/users/sfzylad/events{/privacy}","received_events_url":"https://api.github.com/users/sfzylad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-03T15:29:47Z","updated_at":"2016-11-17T13:56:25Z","closed_at":"2016-11-16T03:00:38Z","pull_request":{"url":"https://api.github.com/repos/justindowning/puppet-rbenv/pulls/61","html_url":"https://github.com/justindowning/puppet-rbenv/pull/61","diff_url":"https://github.com/justindowning/puppet-rbenv/pull/61.diff","patch_url":"https://github.com/justindowning/puppet-rbenv/pull/61.patch"},"body":"When `rbenv` class is included the following way, puppet runs are not idempotent anymore. It looks like `unless` condition of `exec` resource fails:\r\n\r\n```puppet\r\n    class { '::rbenv':\r\n        install_dir => '/opt/rbenv/rbenv-0.4.0',\r\n        version     => 'v0.4.0',\r\n    }\r\n```\r\n\r\nThis PR changes a bit the way how test is performed.. Basically version vould always be string as rbenv is tagged according to pattern: `v$RBENV_VERSION`, so I believe using single equal mark will do here. At least this is what my `test` manual is saying:\r\n\r\n```\r\n       STRING1 = STRING2\r\n              the strings are equal\r\n```\r\n\r\nPlease do let me know if any firther clarification is required."},"comment":{"url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/comments/261252356","html_url":"https://github.com/justindowning/puppet-rbenv/pull/61#issuecomment-261252356","issue_url":"https://api.github.com/repos/justindowning/puppet-rbenv/issues/61","id":261252356,"user":{"login":"sfzylad","id":22446399,"avatar_url":"https://avatars.githubusercontent.com/u/22446399?v=3","gravatar_id":"","url":"https://api.github.com/users/sfzylad","html_url":"https://github.com/sfzylad","followers_url":"https://api.github.com/users/sfzylad/followers","following_url":"https://api.github.com/users/sfzylad/following{/other_user}","gists_url":"https://api.github.com/users/sfzylad/gists{/gist_id}","starred_url":"https://api.github.com/users/sfzylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfzylad/subscriptions","organizations_url":"https://api.github.com/users/sfzylad/orgs","repos_url":"https://api.github.com/users/sfzylad/repos","events_url":"https://api.github.com/users/sfzylad/events{/privacy}","received_events_url":"https://api.github.com/users/sfzylad/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T13:56:25Z","updated_at":"2016-11-17T13:56:25Z","body":"Well, this way it can fail the whole puppet run if the origin is not\navailable. Even if puppet would have nothing to do with rbenv.\n\nOn 16 November 2016 at 03:01, Justin Downing <notifications@github.com>\nwrote:\n\n> I decided we can just remove that unless check so that it fetches the\n> origin every time.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/justindowning/puppet-rbenv/pull/61#issuecomment-260840295>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AVaBP1kngoHSH_Qokb-BYVL4Gl9JYPP6ks5q-nHzgaJpZM4KogME>\n> .\n>\n\n\n\n-- \n-- \nDominik Zyla\n"}}
{"actor":{"display_login":"sfzylad"}}