{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/polyfill/pulls/comments/49278195","id":49278195,"diff_hunk":"@@ -0,0 +1,63 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Polyfill\\Tests\\Apcu;\n+\n+/**\n+ * @requires extension apc","path":"tests/Apcu/ApcuTest.php","position":15,"original_position":15,"commit_id":"a4189793f8baf8172610ca9433b753a7adbd2c2d","original_commit_id":"a4189793f8baf8172610ca9433b753a7adbd2c2d","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"shouldn't these tests run against both apc and apcu to ensure they work the same. now it's only executed against apc.","created_at":"2016-01-10T16:52:34Z","updated_at":"2016-01-10T16:52:34Z","html_url":"https://github.com/symfony/polyfill/pull/22#discussion_r49278195","pull_request_url":"https://api.github.com/repos/symfony/polyfill/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/comments/49278195"},"html":{"href":"https://github.com/symfony/polyfill/pull/22#discussion_r49278195"},"pull_request":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/polyfill/pulls/22","id":54717916,"html_url":"https://github.com/symfony/polyfill/pull/22","diff_url":"https://github.com/symfony/polyfill/pull/22.diff","patch_url":"https://github.com/symfony/polyfill/pull/22.patch","issue_url":"https://api.github.com/repos/symfony/polyfill/issues/22","number":22,"state":"open","locked":false,"title":"[APCu] A new polyfill for the legacy APC users","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"Now that we know that `apc_*` functions are legacy and `apcu_*` is the only way in PHP7, I propose to move forward with this polyfill. Let's replace all usages of `apc_*` in Symfony and elsewhere by their `apcu_*` equivalent and add a deps on this new polyfill to cope with legacy `apc` users.","created_at":"2015-12-29T10:53:13Z","updated_at":"2016-01-10T16:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd1cda9fca4f8d74455be57748b7d68a02661c8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/polyfill/pulls/22/commits","review_comments_url":"https://api.github.com/repos/symfony/polyfill/pulls/22/comments","review_comment_url":"https://api.github.com/repos/symfony/polyfill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/polyfill/issues/22/comments","statuses_url":"https://api.github.com/repos/symfony/polyfill/statuses/a4189793f8baf8172610ca9433b753a7adbd2c2d","head":{"label":"nicolas-grekas:apcu","ref":"apcu","sha":"a4189793f8baf8172610ca9433b753a7adbd2c2d","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"repo":{"id":44743110,"name":"polyfill","full_name":"nicolas-grekas/polyfill","owner":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolas-grekas/polyfill","description":"PHP polyfill","fork":true,"url":"https://api.github.com/repos/nicolas-grekas/polyfill","forks_url":"https://api.github.com/repos/nicolas-grekas/polyfill/forks","keys_url":"https://api.github.com/repos/nicolas-grekas/polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolas-grekas/polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolas-grekas/polyfill/teams","hooks_url":"https://api.github.com/repos/nicolas-grekas/polyfill/hooks","issue_events_url":"https://api.github.com/repos/nicolas-grekas/polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/nicolas-grekas/polyfill/events","assignees_url":"https://api.github.com/repos/nicolas-grekas/polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/nicolas-grekas/polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/nicolas-grekas/polyfill/tags","blobs_url":"https://api.github.com/repos/nicolas-grekas/polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolas-grekas/polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolas-grekas/polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolas-grekas/polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolas-grekas/polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolas-grekas/polyfill/languages","stargazers_url":"https://api.github.com/repos/nicolas-grekas/polyfill/stargazers","contributors_url":"https://api.github.com/repos/nicolas-grekas/polyfill/contributors","subscribers_url":"https://api.github.com/repos/nicolas-grekas/polyfill/subscribers","subscription_url":"https://api.github.com/repos/nicolas-grekas/polyfill/subscription","commits_url":"https://api.github.com/repos/nicolas-grekas/polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolas-grekas/polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolas-grekas/polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolas-grekas/polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolas-grekas/polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/nicolas-grekas/polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolas-grekas/polyfill/merges","archive_url":"https://api.github.com/repos/nicolas-grekas/polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolas-grekas/polyfill/downloads","issues_url":"https://api.github.com/repos/nicolas-grekas/polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/nicolas-grekas/polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolas-grekas/polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolas-grekas/polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolas-grekas/polyfill/labels{/name}","releases_url":"https://api.github.com/repos/nicolas-grekas/polyfill/releases{/id}","created_at":"2015-10-22T12:16:34Z","updated_at":"2015-10-22T12:16:36Z","pushed_at":"2016-01-10T15:48:23Z","git_url":"git://github.com/nicolas-grekas/polyfill.git","ssh_url":"git@github.com:nicolas-grekas/polyfill.git","clone_url":"https://github.com/nicolas-grekas/polyfill.git","svn_url":"https://github.com/nicolas-grekas/polyfill","homepage":null,"size":909,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"587a1a847c2d306a9ee7f092fb2fb8d36e93554c","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":44726463,"name":"polyfill","full_name":"symfony/polyfill","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/polyfill","description":"PHP polyfills","fork":false,"url":"https://api.github.com/repos/symfony/polyfill","forks_url":"https://api.github.com/repos/symfony/polyfill/forks","keys_url":"https://api.github.com/repos/symfony/polyfill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/polyfill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/polyfill/teams","hooks_url":"https://api.github.com/repos/symfony/polyfill/hooks","issue_events_url":"https://api.github.com/repos/symfony/polyfill/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/polyfill/events","assignees_url":"https://api.github.com/repos/symfony/polyfill/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/polyfill/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/polyfill/tags","blobs_url":"https://api.github.com/repos/symfony/polyfill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/polyfill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/polyfill/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/polyfill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/polyfill/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/polyfill/languages","stargazers_url":"https://api.github.com/repos/symfony/polyfill/stargazers","contributors_url":"https://api.github.com/repos/symfony/polyfill/contributors","subscribers_url":"https://api.github.com/repos/symfony/polyfill/subscribers","subscription_url":"https://api.github.com/repos/symfony/polyfill/subscription","commits_url":"https://api.github.com/repos/symfony/polyfill/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/polyfill/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/polyfill/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/polyfill/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/polyfill/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/polyfill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/polyfill/merges","archive_url":"https://api.github.com/repos/symfony/polyfill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/polyfill/downloads","issues_url":"https://api.github.com/repos/symfony/polyfill/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/polyfill/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/polyfill/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/polyfill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/polyfill/labels{/name}","releases_url":"https://api.github.com/repos/symfony/polyfill/releases{/id}","created_at":"2015-10-22T06:30:37Z","updated_at":"2016-01-09T07:15:10Z","pushed_at":"2016-01-10T15:48:24Z","git_url":"git://github.com/symfony/polyfill.git","ssh_url":"git@github.com:symfony/polyfill.git","clone_url":"https://github.com/symfony/polyfill.git","svn_url":"https://github.com/symfony/polyfill","homepage":"https://symfony.com","size":0,"stargazers_count":122,"watchers_count":122,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/22"},"html":{"href":"https://github.com/symfony/polyfill/pull/22"},"issue":{"href":"https://api.github.com/repos/symfony/polyfill/issues/22"},"comments":{"href":"https://api.github.com/repos/symfony/polyfill/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/polyfill/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/polyfill/statuses/a4189793f8baf8172610ca9433b753a7adbd2c2d"}}}}