{"action":"opened","number":10957,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10957","id":94478298,"html_url":"https://github.com/xbmc/xbmc/pull/10957","diff_url":"https://github.com/xbmc/xbmc/pull/10957.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10957.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10957","number":10957,"state":"open","locked":false,"title":"[listprovider] Refresh list when job was not finished","user":{"login":"BigNoid","id":447067,"avatar_url":"https://avatars.githubusercontent.com/u/447067?v=3","gravatar_id":"","url":"https://api.github.com/users/BigNoid","html_url":"https://github.com/BigNoid","followers_url":"https://api.github.com/users/BigNoid/followers","following_url":"https://api.github.com/users/BigNoid/following{/other_user}","gists_url":"https://api.github.com/users/BigNoid/gists{/gist_id}","starred_url":"https://api.github.com/users/BigNoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigNoid/subscriptions","organizations_url":"https://api.github.com/users/BigNoid/orgs","repos_url":"https://api.github.com/users/BigNoid/repos","events_url":"https://api.github.com/users/BigNoid/events{/privacy}","received_events_url":"https://api.github.com/users/BigNoid/received_events","type":"User","site_admin":false},"body":"## Description\r\nFollow up of #10931. Instead of always invalidating, only invalidate if ```OnJobComplete``` wasn't reached with success. \r\n## Motivation and Context\r\nThe job manager isn't aware of jobs that are busy but get interrupted because the window is closed.\r\nAt this point ```Reset()``` is called. By marking the job there as invalidated if ```OnJobComplete``` wasn't called, the job will fire again the next time the list is visible and otherwise it will only fire again through external events.\r\n\r\n## How Has This Been Tested?\r\nRuntime tested\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n\r\n@tamland I don't think I can fix this in any other way. The way the jobmanager is setup, is to get results from ```OnJobComplete```. It doesn't handle the cases where ```OnJobComplete``` isn't reached for whatever reason. There's ```OnJobProgress``` but afaict that is only useful for showing the progress. ","created_at":"2016-11-19T10:43:39Z","updated_at":"2016-11-19T10:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10957/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10957/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10957/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/7b7db0b1ed1f34ed58c3f82bbd59492936ad4eb2","head":{"label":"BigNoid:directory_refresh","ref":"directory_refresh","sha":"7b7db0b1ed1f34ed58c3f82bbd59492936ad4eb2","user":{"login":"BigNoid","id":447067,"avatar_url":"https://avatars.githubusercontent.com/u/447067?v=3","gravatar_id":"","url":"https://api.github.com/users/BigNoid","html_url":"https://github.com/BigNoid","followers_url":"https://api.github.com/users/BigNoid/followers","following_url":"https://api.github.com/users/BigNoid/following{/other_user}","gists_url":"https://api.github.com/users/BigNoid/gists{/gist_id}","starred_url":"https://api.github.com/users/BigNoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigNoid/subscriptions","organizations_url":"https://api.github.com/users/BigNoid/orgs","repos_url":"https://api.github.com/users/BigNoid/repos","events_url":"https://api.github.com/users/BigNoid/events{/privacy}","received_events_url":"https://api.github.com/users/BigNoid/received_events","type":"User","site_admin":false},"repo":{"id":3390815,"name":"xbmc","full_name":"BigNoid/xbmc","owner":{"login":"BigNoid","id":447067,"avatar_url":"https://avatars.githubusercontent.com/u/447067?v=3","gravatar_id":"","url":"https://api.github.com/users/BigNoid","html_url":"https://github.com/BigNoid","followers_url":"https://api.github.com/users/BigNoid/followers","following_url":"https://api.github.com/users/BigNoid/following{/other_user}","gists_url":"https://api.github.com/users/BigNoid/gists{/gist_id}","starred_url":"https://api.github.com/users/BigNoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigNoid/subscriptions","organizations_url":"https://api.github.com/users/BigNoid/orgs","repos_url":"https://api.github.com/users/BigNoid/repos","events_url":"https://api.github.com/users/BigNoid/events{/privacy}","received_events_url":"https://api.github.com/users/BigNoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BigNoid/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/BigNoid/xbmc","forks_url":"https://api.github.com/repos/BigNoid/xbmc/forks","keys_url":"https://api.github.com/repos/BigNoid/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BigNoid/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BigNoid/xbmc/teams","hooks_url":"https://api.github.com/repos/BigNoid/xbmc/hooks","issue_events_url":"https://api.github.com/repos/BigNoid/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/BigNoid/xbmc/events","assignees_url":"https://api.github.com/repos/BigNoid/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/BigNoid/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/BigNoid/xbmc/tags","blobs_url":"https://api.github.com/repos/BigNoid/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BigNoid/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BigNoid/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/BigNoid/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BigNoid/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/BigNoid/xbmc/languages","stargazers_url":"https://api.github.com/repos/BigNoid/xbmc/stargazers","contributors_url":"https://api.github.com/repos/BigNoid/xbmc/contributors","subscribers_url":"https://api.github.com/repos/BigNoid/xbmc/subscribers","subscription_url":"https://api.github.com/repos/BigNoid/xbmc/subscription","commits_url":"https://api.github.com/repos/BigNoid/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/BigNoid/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/BigNoid/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/BigNoid/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/BigNoid/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/BigNoid/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BigNoid/xbmc/merges","archive_url":"https://api.github.com/repos/BigNoid/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BigNoid/xbmc/downloads","issues_url":"https://api.github.com/repos/BigNoid/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/BigNoid/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/BigNoid/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/BigNoid/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BigNoid/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/BigNoid/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/BigNoid/xbmc/deployments","created_at":"2012-02-08T20:07:50Z","updated_at":"2016-10-23T08:43:51Z","pushed_at":"2016-11-19T08:33:13Z","git_url":"git://github.com/BigNoid/xbmc.git","ssh_url":"git@github.com:BigNoid/xbmc.git","clone_url":"https://github.com/BigNoid/xbmc.git","svn_url":"https://github.com/BigNoid/xbmc","homepage":"http://xbmc.org","size":551384,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"bbd323fe2ec3254ce71872e2c8e2e97fcf1f52d9","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-11-19T10:15:12Z","pushed_at":"2016-11-19T09:34:31Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1778355,"stargazers_count":5187,"watchers_count":5187,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3741,"mirror_url":null,"open_issues_count":211,"forks":3741,"open_issues":211,"watchers":5187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10957"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10957"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10957"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10957/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10957/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10957/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/7b7db0b1ed1f34ed58c3f82bbd59492936ad4eb2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"BigNoid"}}