{"action":"created","comment":{"url":"https://api.github.com/repos/chef/omnitruck/pulls/comments/56093238","id":56093238,"diff_hunk":"@@ -26,14 +26,25 @@ def fix_windows_manifest!(manifest)\n           builds.each do |version, build|\n             case architecture\n             when 'x86_64'\n-              builds_64bit[version] = build\n-\n-              # Prior to 12.6.0 we have sometimes posted some windows builds\n-              # only for x86_64. We need to make sure these builds are also\n-              # distributed for i386 since prior to 12.6.0 we only had a single\n-              # windows build that works for all platforms.\n-              if Opscode::Version.parse(version) <= Opscode::Version.parse(\"12.6.0\")\n+              if %w{chef angrychef}.include?(project.name)\n+                if Opscode::Version.parse(version) <= Opscode::Version.parse(\"12.6.0\")\n+                  # Including and prior to Chef 12.6.0 we only had 1 Windows build that worked for\n+                  # all architectures and versions.  It was a 32-bit build but was sometimes\n+                  # marked in the 64-bit manifest, so we need to copy all old 64-bit builds\n+                  # into the 32-bit manifest.\n+                  builds_32bit[version] = build\n+                else\n+                  # Now that we _actually_ have 64-bit builds we also want to\n+                  # exclude all the old 32-bit builds from the 64-bit manifest\n+                  builds_64bit[version] = build\n+                end\n+              elsif project.name == 'chefdk'\n+                # We still only build a 32-bit version of the ChefDK, but again,\n+                # it may have the 64-bit arch tag on it\n                 builds_32bit[version] = build\n+                builds_64bit[version] = build\n+              else\n+                builds_64bit[version] = build","path":"lib/chef/project_cache.rb","position":29,"original_position":29,"commit_id":"2242d948ba1882266316fce624f73f7417a76717","original_commit_id":"2242d948ba1882266316fce624f73f7417a76717","user":{"login":"randomcamel","id":400783,"avatar_url":"https://avatars.githubusercontent.com/u/400783?v=3","gravatar_id":"","url":"https://api.github.com/users/randomcamel","html_url":"https://github.com/randomcamel","followers_url":"https://api.github.com/users/randomcamel/followers","following_url":"https://api.github.com/users/randomcamel/following{/other_user}","gists_url":"https://api.github.com/users/randomcamel/gists{/gist_id}","starred_url":"https://api.github.com/users/randomcamel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomcamel/subscriptions","organizations_url":"https://api.github.com/users/randomcamel/orgs","repos_url":"https://api.github.com/users/randomcamel/repos","events_url":"https://api.github.com/users/randomcamel/events{/privacy}","received_events_url":"https://api.github.com/users/randomcamel/received_events","type":"User","site_admin":false},"body":"The `elsif` and the `else` do the same thing?","created_at":"2016-03-14T23:22:47Z","updated_at":"2016-03-14T23:22:47Z","html_url":"https://github.com/chef/omnitruck/pull/163#discussion_r56093238","pull_request_url":"https://api.github.com/repos/chef/omnitruck/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/comments/56093238"},"html":{"href":"https://github.com/chef/omnitruck/pull/163#discussion_r56093238"},"pull_request":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/chef/omnitruck/pulls/163","id":62598415,"html_url":"https://github.com/chef/omnitruck/pull/163","diff_url":"https://github.com/chef/omnitruck/pull/163.diff","patch_url":"https://github.com/chef/omnitruck/pull/163.patch","issue_url":"https://api.github.com/repos/chef/omnitruck/issues/163","number":163,"state":"open","locked":false,"title":"Bring 64-bit Windows Support to the Stable Channel","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"This includes two fixes:\r\n\r\n1) Update the stable channel to no longer hard-code all requests as `i386`.  This will _allow_ requests to return 64-bit packages\r\n2) Update the manifest to stop including 32-bit packages in the Windows `x86_64` architecture.  This will cause requests for versions of Chef <= 12.6.0 to fail against the `x86_64` architecture because those packages are actually 32-bit\r\n\r\n\\cc @chefsalim @adamedx @randomcamel \r\n\r\nPending Questions:\r\n\r\n- [ ] When can we roll this change out?\r\n- [ ] What is it going to affect besides the downloads site and the install.ps1 script?","created_at":"2016-03-11T20:31:52Z","updated_at":"2016-03-14T23:22:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2b80c8b1bb63fd9435c06e5629229fe81d61268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/omnitruck/pulls/163/commits","review_comments_url":"https://api.github.com/repos/chef/omnitruck/pulls/163/comments","review_comment_url":"https://api.github.com/repos/chef/omnitruck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/omnitruck/issues/163/comments","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/2242d948ba1882266316fce624f73f7417a76717","head":{"label":"chef:windows64support","ref":"windows64support","sha":"2242d948ba1882266316fce624f73f7417a76717","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4981792,"name":"omnitruck","full_name":"chef/omnitruck","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnitruck","description":"Web service to automate the release of Omnibus artifacts","fork":false,"url":"https://api.github.com/repos/chef/omnitruck","forks_url":"https://api.github.com/repos/chef/omnitruck/forks","keys_url":"https://api.github.com/repos/chef/omnitruck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnitruck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnitruck/teams","hooks_url":"https://api.github.com/repos/chef/omnitruck/hooks","issue_events_url":"https://api.github.com/repos/chef/omnitruck/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnitruck/events","assignees_url":"https://api.github.com/repos/chef/omnitruck/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnitruck/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnitruck/tags","blobs_url":"https://api.github.com/repos/chef/omnitruck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnitruck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnitruck/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnitruck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnitruck/languages","stargazers_url":"https://api.github.com/repos/chef/omnitruck/stargazers","contributors_url":"https://api.github.com/repos/chef/omnitruck/contributors","subscribers_url":"https://api.github.com/repos/chef/omnitruck/subscribers","subscription_url":"https://api.github.com/repos/chef/omnitruck/subscription","commits_url":"https://api.github.com/repos/chef/omnitruck/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnitruck/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnitruck/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnitruck/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnitruck/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnitruck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnitruck/merges","archive_url":"https://api.github.com/repos/chef/omnitruck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnitruck/downloads","issues_url":"https://api.github.com/repos/chef/omnitruck/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnitruck/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnitruck/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnitruck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnitruck/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnitruck/releases{/id}","deployments_url":"https://api.github.com/repos/chef/omnitruck/deployments","created_at":"2012-07-10T23:09:36Z","updated_at":"2016-01-19T21:35:29Z","pushed_at":"2016-03-14T22:58:30Z","git_url":"git://github.com/chef/omnitruck.git","ssh_url":"git@github.com:chef/omnitruck.git","clone_url":"https://github.com/chef/omnitruck.git","svn_url":"https://github.com/chef/omnitruck","homepage":"","size":1070,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":27,"forks":15,"open_issues":27,"watchers":8,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"c764a5974bec01fbd825cfdc1b15124e8e5f928e","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4981792,"name":"omnitruck","full_name":"chef/omnitruck","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnitruck","description":"Web service to automate the release of Omnibus artifacts","fork":false,"url":"https://api.github.com/repos/chef/omnitruck","forks_url":"https://api.github.com/repos/chef/omnitruck/forks","keys_url":"https://api.github.com/repos/chef/omnitruck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnitruck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnitruck/teams","hooks_url":"https://api.github.com/repos/chef/omnitruck/hooks","issue_events_url":"https://api.github.com/repos/chef/omnitruck/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnitruck/events","assignees_url":"https://api.github.com/repos/chef/omnitruck/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnitruck/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnitruck/tags","blobs_url":"https://api.github.com/repos/chef/omnitruck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnitruck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnitruck/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnitruck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnitruck/languages","stargazers_url":"https://api.github.com/repos/chef/omnitruck/stargazers","contributors_url":"https://api.github.com/repos/chef/omnitruck/contributors","subscribers_url":"https://api.github.com/repos/chef/omnitruck/subscribers","subscription_url":"https://api.github.com/repos/chef/omnitruck/subscription","commits_url":"https://api.github.com/repos/chef/omnitruck/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnitruck/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnitruck/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnitruck/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnitruck/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnitruck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnitruck/merges","archive_url":"https://api.github.com/repos/chef/omnitruck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnitruck/downloads","issues_url":"https://api.github.com/repos/chef/omnitruck/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnitruck/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnitruck/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnitruck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnitruck/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnitruck/releases{/id}","deployments_url":"https://api.github.com/repos/chef/omnitruck/deployments","created_at":"2012-07-10T23:09:36Z","updated_at":"2016-01-19T21:35:29Z","pushed_at":"2016-03-14T22:58:30Z","git_url":"git://github.com/chef/omnitruck.git","ssh_url":"git@github.com:chef/omnitruck.git","clone_url":"https://github.com/chef/omnitruck.git","svn_url":"https://github.com/chef/omnitruck","homepage":"","size":1070,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":27,"forks":15,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/163"},"html":{"href":"https://github.com/chef/omnitruck/pull/163"},"issue":{"href":"https://api.github.com/repos/chef/omnitruck/issues/163"},"comments":{"href":"https://api.github.com/repos/chef/omnitruck/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/chef/omnitruck/statuses/2242d948ba1882266316fce624f73f7417a76717"}}}}