{"action":"created","comment":{"url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/comments/74707924","id":74707924,"diff_hunk":"@@ -4,32 +4,31 @@\n import org.apache.commons.lang3.SerializationUtils;\n \n import java.io.Serializable;\n-import java.util.ArrayList;\n-import java.util.Collections;\n-import java.util.List;\n import java.util.Map;\n \n /**\n  * @author Caellian\n  *         Created on 17.7.2016. at 21:59.\n  */\n public class NBTHelper {\n-    private static List<Class> NBTPrimitivesClasses = new ArrayList<>();\n-\n-    {\n-        NBTPrimitivesClasses.add(Byte.class);\n-        NBTPrimitivesClasses.add(Byte[].class);\n-        NBTPrimitivesClasses.add(Double.class);\n-        NBTPrimitivesClasses.add(Float.class);\n-        NBTPrimitivesClasses.add(Integer.class);\n-        NBTPrimitivesClasses.add(Integer[].class);\n-        NBTPrimitivesClasses.add(Long.class);\n-        NBTPrimitivesClasses.add(Short.class);\n-        NBTPrimitivesClasses = Collections.unmodifiableList(NBTPrimitivesClasses);\n-    }\n+    private final static Class[] NBT_PRIMITIVES_CLASSES = new Class[]{\n+        Byte.class,\n+        Byte[].class,\n+        Double.class,\n+        Float.class,\n+        Integer.class,\n+        Integer[].class,\n+        Long.class,\n+        Short.class\n+    };\n \n     public static boolean isNBTPrimitive(Object any) {\n-        return NBTPrimitivesClasses.contains(any.getClass());\n+        for (Class aClass : NBT_PRIMITIVES_CLASSES) {","path":"src/main/java/xyz/openmodloader/nbt/NBTHelper.java","position":null,"original_position":40,"commit_id":"f810523057894d307ff5b6435c2345770b46dd19","original_commit_id":"f810523057894d307ff5b6435c2345770b46dd19","user":{"login":"Victorious3","id":3749322,"avatar_url":"https://avatars.githubusercontent.com/u/3749322?v=3","gravatar_id":"","url":"https://api.github.com/users/Victorious3","html_url":"https://github.com/Victorious3","followers_url":"https://api.github.com/users/Victorious3/followers","following_url":"https://api.github.com/users/Victorious3/following{/other_user}","gists_url":"https://api.github.com/users/Victorious3/gists{/gist_id}","starred_url":"https://api.github.com/users/Victorious3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Victorious3/subscriptions","organizations_url":"https://api.github.com/users/Victorious3/orgs","repos_url":"https://api.github.com/users/Victorious3/repos","events_url":"https://api.github.com/users/Victorious3/events{/privacy}","received_events_url":"https://api.github.com/users/Victorious3/received_events","type":"User","site_admin":false},"body":"`ArrayUtils.contains` (Don't ask why you need 10000 different utility classes just to make arrays less stupid, just one of these java things.","created_at":"2016-08-14T20:30:50Z","updated_at":"2016-08-14T20:30:50Z","html_url":"https://github.com/OpenModLoader/OpenModLoader/pull/94#discussion_r74707924","pull_request_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/comments/74707924"},"html":{"href":"https://github.com/OpenModLoader/OpenModLoader/pull/94#discussion_r74707924"},"pull_request":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94","id":78761034,"html_url":"https://github.com/OpenModLoader/OpenModLoader/pull/94","diff_url":"https://github.com/OpenModLoader/OpenModLoader/pull/94.diff","patch_url":"https://github.com/OpenModLoader/OpenModLoader/pull/94.patch","issue_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/94","number":94,"state":"open","locked":false,"title":"[WIP] Flow & Power APIs","user":{"login":"Caellian","id":4082795,"avatar_url":"https://avatars.githubusercontent.com/u/4082795?v=3","gravatar_id":"","url":"https://api.github.com/users/Caellian","html_url":"https://github.com/Caellian","followers_url":"https://api.github.com/users/Caellian/followers","following_url":"https://api.github.com/users/Caellian/following{/other_user}","gists_url":"https://api.github.com/users/Caellian/gists{/gist_id}","starred_url":"https://api.github.com/users/Caellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caellian/subscriptions","organizations_url":"https://api.github.com/users/Caellian/orgs","repos_url":"https://api.github.com/users/Caellian/repos","events_url":"https://api.github.com/users/Caellian/events{/privacy}","received_events_url":"https://api.github.com/users/Caellian/received_events","type":"User","site_admin":false},"body":"Power API @Strikingwolf and I are working on. This PR is so people can see our progress so far and is not complete yet.\r\nAPI is almost finished so I decided to create this PR for people to try and break our code and hopefully improve it with found bugs and ideas.\r\n\r\nI will shortly post a TODO list containing everything I want to add to this before it's accepted and close the issue.","created_at":"2016-07-25T22:09:29Z","updated_at":"2016-08-14T20:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c24717eda55838070a053cb99a463f8ebee566aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94/commits","review_comments_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94/comments","review_comment_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/94/comments","statuses_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/statuses/f810523057894d307ff5b6435c2345770b46dd19","head":{"label":"Caellian:master","ref":"master","sha":"f810523057894d307ff5b6435c2345770b46dd19","user":{"login":"Caellian","id":4082795,"avatar_url":"https://avatars.githubusercontent.com/u/4082795?v=3","gravatar_id":"","url":"https://api.github.com/users/Caellian","html_url":"https://github.com/Caellian","followers_url":"https://api.github.com/users/Caellian/followers","following_url":"https://api.github.com/users/Caellian/following{/other_user}","gists_url":"https://api.github.com/users/Caellian/gists{/gist_id}","starred_url":"https://api.github.com/users/Caellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caellian/subscriptions","organizations_url":"https://api.github.com/users/Caellian/orgs","repos_url":"https://api.github.com/users/Caellian/repos","events_url":"https://api.github.com/users/Caellian/events{/privacy}","received_events_url":"https://api.github.com/users/Caellian/received_events","type":"User","site_admin":false},"repo":{"id":63539520,"name":"OpenModLoader","full_name":"Caellian/OpenModLoader","owner":{"login":"Caellian","id":4082795,"avatar_url":"https://avatars.githubusercontent.com/u/4082795?v=3","gravatar_id":"","url":"https://api.github.com/users/Caellian","html_url":"https://github.com/Caellian","followers_url":"https://api.github.com/users/Caellian/followers","following_url":"https://api.github.com/users/Caellian/following{/other_user}","gists_url":"https://api.github.com/users/Caellian/gists{/gist_id}","starred_url":"https://api.github.com/users/Caellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caellian/subscriptions","organizations_url":"https://api.github.com/users/Caellian/orgs","repos_url":"https://api.github.com/users/Caellian/repos","events_url":"https://api.github.com/users/Caellian/events{/privacy}","received_events_url":"https://api.github.com/users/Caellian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Caellian/OpenModLoader","description":"A next gen minecraft mod loader for minecraft 1.10 and above","fork":true,"url":"https://api.github.com/repos/Caellian/OpenModLoader","forks_url":"https://api.github.com/repos/Caellian/OpenModLoader/forks","keys_url":"https://api.github.com/repos/Caellian/OpenModLoader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caellian/OpenModLoader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caellian/OpenModLoader/teams","hooks_url":"https://api.github.com/repos/Caellian/OpenModLoader/hooks","issue_events_url":"https://api.github.com/repos/Caellian/OpenModLoader/issues/events{/number}","events_url":"https://api.github.com/repos/Caellian/OpenModLoader/events","assignees_url":"https://api.github.com/repos/Caellian/OpenModLoader/assignees{/user}","branches_url":"https://api.github.com/repos/Caellian/OpenModLoader/branches{/branch}","tags_url":"https://api.github.com/repos/Caellian/OpenModLoader/tags","blobs_url":"https://api.github.com/repos/Caellian/OpenModLoader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caellian/OpenModLoader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caellian/OpenModLoader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caellian/OpenModLoader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caellian/OpenModLoader/statuses/{sha}","languages_url":"https://api.github.com/repos/Caellian/OpenModLoader/languages","stargazers_url":"https://api.github.com/repos/Caellian/OpenModLoader/stargazers","contributors_url":"https://api.github.com/repos/Caellian/OpenModLoader/contributors","subscribers_url":"https://api.github.com/repos/Caellian/OpenModLoader/subscribers","subscription_url":"https://api.github.com/repos/Caellian/OpenModLoader/subscription","commits_url":"https://api.github.com/repos/Caellian/OpenModLoader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caellian/OpenModLoader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caellian/OpenModLoader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caellian/OpenModLoader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caellian/OpenModLoader/contents/{+path}","compare_url":"https://api.github.com/repos/Caellian/OpenModLoader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caellian/OpenModLoader/merges","archive_url":"https://api.github.com/repos/Caellian/OpenModLoader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caellian/OpenModLoader/downloads","issues_url":"https://api.github.com/repos/Caellian/OpenModLoader/issues{/number}","pulls_url":"https://api.github.com/repos/Caellian/OpenModLoader/pulls{/number}","milestones_url":"https://api.github.com/repos/Caellian/OpenModLoader/milestones{/number}","notifications_url":"https://api.github.com/repos/Caellian/OpenModLoader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caellian/OpenModLoader/labels{/name}","releases_url":"https://api.github.com/repos/Caellian/OpenModLoader/releases{/id}","deployments_url":"https://api.github.com/repos/Caellian/OpenModLoader/deployments","created_at":"2016-07-17T15:43:44Z","updated_at":"2016-07-17T15:43:45Z","pushed_at":"2016-08-14T18:29:24Z","git_url":"git://github.com/Caellian/OpenModLoader.git","ssh_url":"git@github.com:Caellian/OpenModLoader.git","clone_url":"https://github.com/Caellian/OpenModLoader.git","svn_url":"https://github.com/Caellian/OpenModLoader","homepage":"http://openmodloader.xyz/","size":3172,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenModLoader:master","ref":"master","sha":"5ab1945b6fd225176fa323ccc9f5987072c96653","user":{"login":"OpenModLoader","id":20051910,"avatar_url":"https://avatars.githubusercontent.com/u/20051910?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModLoader","html_url":"https://github.com/OpenModLoader","followers_url":"https://api.github.com/users/OpenModLoader/followers","following_url":"https://api.github.com/users/OpenModLoader/following{/other_user}","gists_url":"https://api.github.com/users/OpenModLoader/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModLoader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModLoader/subscriptions","organizations_url":"https://api.github.com/users/OpenModLoader/orgs","repos_url":"https://api.github.com/users/OpenModLoader/repos","events_url":"https://api.github.com/users/OpenModLoader/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModLoader/received_events","type":"Organization","site_admin":false},"repo":{"id":61618132,"name":"OpenModLoader","full_name":"OpenModLoader/OpenModLoader","owner":{"login":"OpenModLoader","id":20051910,"avatar_url":"https://avatars.githubusercontent.com/u/20051910?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenModLoader","html_url":"https://github.com/OpenModLoader","followers_url":"https://api.github.com/users/OpenModLoader/followers","following_url":"https://api.github.com/users/OpenModLoader/following{/other_user}","gists_url":"https://api.github.com/users/OpenModLoader/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenModLoader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenModLoader/subscriptions","organizations_url":"https://api.github.com/users/OpenModLoader/orgs","repos_url":"https://api.github.com/users/OpenModLoader/repos","events_url":"https://api.github.com/users/OpenModLoader/events{/privacy}","received_events_url":"https://api.github.com/users/OpenModLoader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenModLoader/OpenModLoader","description":"A next gen minecraft mod loader for minecraft 1.10 and above","fork":false,"url":"https://api.github.com/repos/OpenModLoader/OpenModLoader","forks_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/forks","keys_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/teams","hooks_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/hooks","issue_events_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/events{/number}","events_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/events","assignees_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/assignees{/user}","branches_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/branches{/branch}","tags_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/tags","blobs_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/languages","stargazers_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/stargazers","contributors_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/contributors","subscribers_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/subscribers","subscription_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/subscription","commits_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/contents/{+path}","compare_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/merges","archive_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/downloads","issues_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues{/number}","pulls_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/labels{/name}","releases_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/releases{/id}","deployments_url":"https://api.github.com/repos/OpenModLoader/OpenModLoader/deployments","created_at":"2016-06-21T08:53:39Z","updated_at":"2016-08-09T20:35:48Z","pushed_at":"2016-08-14T18:29:25Z","git_url":"git://github.com/OpenModLoader/OpenModLoader.git","ssh_url":"git@github.com:OpenModLoader/OpenModLoader.git","clone_url":"https://github.com/OpenModLoader/OpenModLoader.git","svn_url":"https://github.com/OpenModLoader/OpenModLoader","homepage":"http://openmodloader.xyz/","size":3450,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":13,"forks":19,"open_issues":13,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94"},"html":{"href":"https://github.com/OpenModLoader/OpenModLoader/pull/94"},"issue":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/94"},"comments":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/OpenModLoader/OpenModLoader/statuses/f810523057894d307ff5b6435c2345770b46dd19"}}}}
{"actor":{"display_login":"Victorious3"}}