{"action":"created","comment":{"url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/comments/49669777","id":49669777,"diff_hunk":"@@ -233,93 +238,73 @@\n   IPrintWithWriter\n   (-pr-writer [native writer opts]\n     (-write writer \"#native \")\n-    (print-map\n-     (->> (js-keys native)\n-          (keep (fn [k]\n-                  (let [v (aget native k)\n-                        k (keyword k)]\n-                    (when-not (or (fn? v)\n-                                  (#{:cljs$lang$protocol_mask$partition0$ :cljs$lang$protocol_mask$partition1$ :__ro :nativestore$core$IReadOnly$} k))\n-                      [k v])))))\n-     pr-writer writer opts))\n+    (print-map (map (fn [k] [k (aget native (name k))]) @keyset)\n+               pr-writer writer opts))\n \n   ICounted\n   (-count [native]\n-    (alength (js-keys native)))\n+    (count @keyset))\n \n   ILookup\n   (-lookup [native k]\n     (-lookup native k nil))\n   (-lookup [native k not-found]\n-    (let [key (if (keyword? k) (name k) k)\n-          res (aget native key)]\n-      (cond (nil? res)\n-            not-found\n-            (array? res)\n-            (if (satisfies? IReference (aget res 0))\n-              (amap res i ret (resolve-ref (aget res i)))\n-              res)\n-            (satisfies? IReference res)\n-            (resolve-ref res)\n-            :default\n-            res)))\n+    (let [v (aget native (name k))]\n+      (cond\n+        (nil? v) not-found\n+        (array? v) (if (satisfies? IReference (aget v 0))\n+                     (amap v i ret (resolve-ref (aget v i)))\n+                     v)\n+        (satisfies? IReference v) (resolve-ref v)\n+        :default v)))\n \n   ITransientAssociative\n   (-assoc! [native k v]\n     (when (and (-read-only? native) (not *transaction*))\n       (throw (js/Error. \"Cannot mutate store values outside transact!: \")))\n-    (aset native (if (keyword? k) (name k) k) v)\n+    (vswap! keyset conj k)\n+    (aset native (name k) v)","path":"src/nativestore/core.cljs","position":75,"original_position":75,"commit_id":"b173aca1014c1a4ed48b280f01beaadb8ccba347","original_commit_id":"b173aca1014c1a4ed48b280f01beaadb8ccba347","user":{"login":"eslick","id":294768,"avatar_url":"https://avatars.githubusercontent.com/u/294768?v=3","gravatar_id":"","url":"https://api.github.com/users/eslick","html_url":"https://github.com/eslick","followers_url":"https://api.github.com/users/eslick/followers","following_url":"https://api.github.com/users/eslick/following{/other_user}","gists_url":"https://api.github.com/users/eslick/gists{/gist_id}","starred_url":"https://api.github.com/users/eslick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslick/subscriptions","organizations_url":"https://api.github.com/users/eslick/orgs","repos_url":"https://api.github.com/users/eslick/repos","events_url":"https://api.github.com/users/eslick/events{/privacy}","received_events_url":"https://api.github.com/users/eslick/received_events","type":"User","site_admin":false},"body":"This and all other places this change is made breaks the existing contract that (seq (assoc! (native) :foo 10)) => [[:foo 10]].  This changes results in (seq (assoc! (native) :foo 10)) => [[\"foo\" 10]].  Native objects purposefully stored keywords as keywords so we didn't end up with ambiguities with maps of strings to value vs. maps of keywords to values.  ","created_at":"2016-01-13T23:51:17Z","updated_at":"2016-01-13T23:51:17Z","html_url":"https://github.com/VitalLabs/nativestore/pull/4#discussion_r49669777","pull_request_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/comments/49669777"},"html":{"href":"https://github.com/VitalLabs/nativestore/pull/4#discussion_r49669777"},"pull_request":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4","id":55963299,"html_url":"https://github.com/VitalLabs/nativestore/pull/4","diff_url":"https://github.com/VitalLabs/nativestore/pull/4.diff","patch_url":"https://github.com/VitalLabs/nativestore/pull/4.patch","issue_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/4","number":4,"state":"open","locked":false,"title":"Implement ICloneable and add keyset property to Native deftype","user":{"login":"aamedina","id":1291511,"avatar_url":"https://avatars.githubusercontent.com/u/1291511?v=3","gravatar_id":"","url":"https://api.github.com/users/aamedina","html_url":"https://github.com/aamedina","followers_url":"https://api.github.com/users/aamedina/followers","following_url":"https://api.github.com/users/aamedina/following{/other_user}","gists_url":"https://api.github.com/users/aamedina/gists{/gist_id}","starred_url":"https://api.github.com/users/aamedina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamedina/subscriptions","organizations_url":"https://api.github.com/users/aamedina/orgs","repos_url":"https://api.github.com/users/aamedina/repos","events_url":"https://api.github.com/users/aamedina/events{/privacy}","received_events_url":"https://api.github.com/users/aamedina/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-13T22:08:24Z","updated_at":"2016-01-13T23:51:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ffc9271723055d15c3b7b8015cd84a64c57145c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4/commits","review_comments_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4/comments","review_comment_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/4/comments","statuses_url":"https://api.github.com/repos/VitalLabs/nativestore/statuses/b173aca1014c1a4ed48b280f01beaadb8ccba347","head":{"label":"VitalLabs:native-js-keys","ref":"native-js-keys","sha":"b173aca1014c1a4ed48b280f01beaadb8ccba347","user":{"login":"VitalLabs","id":9441412,"avatar_url":"https://avatars.githubusercontent.com/u/9441412?v=3","gravatar_id":"","url":"https://api.github.com/users/VitalLabs","html_url":"https://github.com/VitalLabs","followers_url":"https://api.github.com/users/VitalLabs/followers","following_url":"https://api.github.com/users/VitalLabs/following{/other_user}","gists_url":"https://api.github.com/users/VitalLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/VitalLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitalLabs/subscriptions","organizations_url":"https://api.github.com/users/VitalLabs/orgs","repos_url":"https://api.github.com/users/VitalLabs/repos","events_url":"https://api.github.com/users/VitalLabs/events{/privacy}","received_events_url":"https://api.github.com/users/VitalLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24541228,"name":"nativestore","full_name":"VitalLabs/nativestore","owner":{"login":"VitalLabs","id":9441412,"avatar_url":"https://avatars.githubusercontent.com/u/9441412?v=3","gravatar_id":"","url":"https://api.github.com/users/VitalLabs","html_url":"https://github.com/VitalLabs","followers_url":"https://api.github.com/users/VitalLabs/followers","following_url":"https://api.github.com/users/VitalLabs/following{/other_user}","gists_url":"https://api.github.com/users/VitalLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/VitalLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitalLabs/subscriptions","organizations_url":"https://api.github.com/users/VitalLabs/orgs","repos_url":"https://api.github.com/users/VitalLabs/repos","events_url":"https://api.github.com/users/VitalLabs/events{/privacy}","received_events_url":"https://api.github.com/users/VitalLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VitalLabs/nativestore","description":"Low-level, client-side database for Clojurescript applications integrated with the Derive library.","fork":false,"url":"https://api.github.com/repos/VitalLabs/nativestore","forks_url":"https://api.github.com/repos/VitalLabs/nativestore/forks","keys_url":"https://api.github.com/repos/VitalLabs/nativestore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VitalLabs/nativestore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VitalLabs/nativestore/teams","hooks_url":"https://api.github.com/repos/VitalLabs/nativestore/hooks","issue_events_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/events{/number}","events_url":"https://api.github.com/repos/VitalLabs/nativestore/events","assignees_url":"https://api.github.com/repos/VitalLabs/nativestore/assignees{/user}","branches_url":"https://api.github.com/repos/VitalLabs/nativestore/branches{/branch}","tags_url":"https://api.github.com/repos/VitalLabs/nativestore/tags","blobs_url":"https://api.github.com/repos/VitalLabs/nativestore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VitalLabs/nativestore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VitalLabs/nativestore/git/refs{/sha}","trees_url":"https://api.github.com/repos/VitalLabs/nativestore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VitalLabs/nativestore/statuses/{sha}","languages_url":"https://api.github.com/repos/VitalLabs/nativestore/languages","stargazers_url":"https://api.github.com/repos/VitalLabs/nativestore/stargazers","contributors_url":"https://api.github.com/repos/VitalLabs/nativestore/contributors","subscribers_url":"https://api.github.com/repos/VitalLabs/nativestore/subscribers","subscription_url":"https://api.github.com/repos/VitalLabs/nativestore/subscription","commits_url":"https://api.github.com/repos/VitalLabs/nativestore/commits{/sha}","git_commits_url":"https://api.github.com/repos/VitalLabs/nativestore/git/commits{/sha}","comments_url":"https://api.github.com/repos/VitalLabs/nativestore/comments{/number}","issue_comment_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/comments{/number}","contents_url":"https://api.github.com/repos/VitalLabs/nativestore/contents/{+path}","compare_url":"https://api.github.com/repos/VitalLabs/nativestore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VitalLabs/nativestore/merges","archive_url":"https://api.github.com/repos/VitalLabs/nativestore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VitalLabs/nativestore/downloads","issues_url":"https://api.github.com/repos/VitalLabs/nativestore/issues{/number}","pulls_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls{/number}","milestones_url":"https://api.github.com/repos/VitalLabs/nativestore/milestones{/number}","notifications_url":"https://api.github.com/repos/VitalLabs/nativestore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VitalLabs/nativestore/labels{/name}","releases_url":"https://api.github.com/repos/VitalLabs/nativestore/releases{/id}","created_at":"2014-09-27T19:48:11Z","updated_at":"2015-09-16T12:17:35Z","pushed_at":"2016-01-13T22:10:36Z","git_url":"git://github.com/VitalLabs/nativestore.git","ssh_url":"git@github.com:VitalLabs/nativestore.git","clone_url":"https://github.com/VitalLabs/nativestore.git","svn_url":"https://github.com/VitalLabs/nativestore","homepage":null,"size":70,"stargazers_count":17,"watchers_count":17,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":17,"default_branch":"master"}},"base":{"label":"VitalLabs:master","ref":"master","sha":"d2b9433a0541d9446e5c6be7b53135c1c435ce45","user":{"login":"VitalLabs","id":9441412,"avatar_url":"https://avatars.githubusercontent.com/u/9441412?v=3","gravatar_id":"","url":"https://api.github.com/users/VitalLabs","html_url":"https://github.com/VitalLabs","followers_url":"https://api.github.com/users/VitalLabs/followers","following_url":"https://api.github.com/users/VitalLabs/following{/other_user}","gists_url":"https://api.github.com/users/VitalLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/VitalLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitalLabs/subscriptions","organizations_url":"https://api.github.com/users/VitalLabs/orgs","repos_url":"https://api.github.com/users/VitalLabs/repos","events_url":"https://api.github.com/users/VitalLabs/events{/privacy}","received_events_url":"https://api.github.com/users/VitalLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24541228,"name":"nativestore","full_name":"VitalLabs/nativestore","owner":{"login":"VitalLabs","id":9441412,"avatar_url":"https://avatars.githubusercontent.com/u/9441412?v=3","gravatar_id":"","url":"https://api.github.com/users/VitalLabs","html_url":"https://github.com/VitalLabs","followers_url":"https://api.github.com/users/VitalLabs/followers","following_url":"https://api.github.com/users/VitalLabs/following{/other_user}","gists_url":"https://api.github.com/users/VitalLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/VitalLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VitalLabs/subscriptions","organizations_url":"https://api.github.com/users/VitalLabs/orgs","repos_url":"https://api.github.com/users/VitalLabs/repos","events_url":"https://api.github.com/users/VitalLabs/events{/privacy}","received_events_url":"https://api.github.com/users/VitalLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VitalLabs/nativestore","description":"Low-level, client-side database for Clojurescript applications integrated with the Derive library.","fork":false,"url":"https://api.github.com/repos/VitalLabs/nativestore","forks_url":"https://api.github.com/repos/VitalLabs/nativestore/forks","keys_url":"https://api.github.com/repos/VitalLabs/nativestore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VitalLabs/nativestore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VitalLabs/nativestore/teams","hooks_url":"https://api.github.com/repos/VitalLabs/nativestore/hooks","issue_events_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/events{/number}","events_url":"https://api.github.com/repos/VitalLabs/nativestore/events","assignees_url":"https://api.github.com/repos/VitalLabs/nativestore/assignees{/user}","branches_url":"https://api.github.com/repos/VitalLabs/nativestore/branches{/branch}","tags_url":"https://api.github.com/repos/VitalLabs/nativestore/tags","blobs_url":"https://api.github.com/repos/VitalLabs/nativestore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VitalLabs/nativestore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VitalLabs/nativestore/git/refs{/sha}","trees_url":"https://api.github.com/repos/VitalLabs/nativestore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VitalLabs/nativestore/statuses/{sha}","languages_url":"https://api.github.com/repos/VitalLabs/nativestore/languages","stargazers_url":"https://api.github.com/repos/VitalLabs/nativestore/stargazers","contributors_url":"https://api.github.com/repos/VitalLabs/nativestore/contributors","subscribers_url":"https://api.github.com/repos/VitalLabs/nativestore/subscribers","subscription_url":"https://api.github.com/repos/VitalLabs/nativestore/subscription","commits_url":"https://api.github.com/repos/VitalLabs/nativestore/commits{/sha}","git_commits_url":"https://api.github.com/repos/VitalLabs/nativestore/git/commits{/sha}","comments_url":"https://api.github.com/repos/VitalLabs/nativestore/comments{/number}","issue_comment_url":"https://api.github.com/repos/VitalLabs/nativestore/issues/comments{/number}","contents_url":"https://api.github.com/repos/VitalLabs/nativestore/contents/{+path}","compare_url":"https://api.github.com/repos/VitalLabs/nativestore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VitalLabs/nativestore/merges","archive_url":"https://api.github.com/repos/VitalLabs/nativestore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VitalLabs/nativestore/downloads","issues_url":"https://api.github.com/repos/VitalLabs/nativestore/issues{/number}","pulls_url":"https://api.github.com/repos/VitalLabs/nativestore/pulls{/number}","milestones_url":"https://api.github.com/repos/VitalLabs/nativestore/milestones{/number}","notifications_url":"https://api.github.com/repos/VitalLabs/nativestore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VitalLabs/nativestore/labels{/name}","releases_url":"https://api.github.com/repos/VitalLabs/nativestore/releases{/id}","created_at":"2014-09-27T19:48:11Z","updated_at":"2015-09-16T12:17:35Z","pushed_at":"2016-01-13T22:10:36Z","git_url":"git://github.com/VitalLabs/nativestore.git","ssh_url":"git@github.com:VitalLabs/nativestore.git","clone_url":"https://github.com/VitalLabs/nativestore.git","svn_url":"https://github.com/VitalLabs/nativestore","homepage":null,"size":70,"stargazers_count":17,"watchers_count":17,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4"},"html":{"href":"https://github.com/VitalLabs/nativestore/pull/4"},"issue":{"href":"https://api.github.com/repos/VitalLabs/nativestore/issues/4"},"comments":{"href":"https://api.github.com/repos/VitalLabs/nativestore/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VitalLabs/nativestore/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/VitalLabs/nativestore/statuses/b173aca1014c1a4ed48b280f01beaadb8ccba347"}}}}