{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/60725545","id":60725545,"diff_hunk":"@@ -25,7 +25,7 @@\n             name=\"Copy Files to Backup Directory\" id=\"copyIngestedFiles\" required=\"false\"\n             type=\"Boolean\" default=\"false\"/>\n \n-        <AD description=\"Optional: Parameters (Key-Value pairs) that are available to any registered ingest plugin.  The format should be 'key=value'.\"\n+        <AD description=\"Optional: Metacard attribute overrides (Key-Value pairs) that can be set on the content monitor.  If an attribute is specified here, it will overwrite the metacard's attribute that was created from the content directory.   The format should be 'key=value'.\"\n             name=\"Parameters\" id=\"parameters\" required=\"false\" type=\"String\"","path":"catalog/core/catalog-core-directorymonitor/src/main/resources/OSGI-INF/metatype/metatype.xml","position":6,"original_position":6,"commit_id":"5b42858e74507f6e43729bc67b60b8c66855d105","original_commit_id":"5b42858e74507f6e43729bc67b60b8c66855d105","user":{"login":"jlcsmith","id":4503545,"avatar_url":"https://avatars.githubusercontent.com/u/4503545?v=3","gravatar_id":"","url":"https://api.github.com/users/jlcsmith","html_url":"https://github.com/jlcsmith","followers_url":"https://api.github.com/users/jlcsmith/followers","following_url":"https://api.github.com/users/jlcsmith/following{/other_user}","gists_url":"https://api.github.com/users/jlcsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jlcsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlcsmith/subscriptions","organizations_url":"https://api.github.com/users/jlcsmith/orgs","repos_url":"https://api.github.com/users/jlcsmith/repos","events_url":"https://api.github.com/users/jlcsmith/events{/privacy}","received_events_url":"https://api.github.com/users/jlcsmith/received_events","type":"User","site_admin":false},"body":"Nit - name should be `Attribute overrides`","created_at":"2016-04-22T11:30:50Z","updated_at":"2016-04-22T11:30:50Z","html_url":"https://github.com/codice/ddf/pull/720#discussion_r60725545","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/720","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/60725545"},"html":{"href":"https://github.com/codice/ddf/pull/720#discussion_r60725545"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/720"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/720","id":67382040,"html_url":"https://github.com/codice/ddf/pull/720","diff_url":"https://github.com/codice/ddf/pull/720.diff","patch_url":"https://github.com/codice/ddf/pull/720.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/720","number":720,"state":"open","locked":false,"title":"DDF-2034 Updated Parameter Configuration for Content Directory Monitor","user":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThis PR augments the existing Content Directory parameter passing code in the following ways:\r\n1) Prevents the parameters being added to the CreateStorageRequest so that they are not exposed to ingest plugins\r\n2) Adds an overloaded create function to the CatalogFramework for attribute overrides\r\n3) Overrides valid attributes on metcards with the passed parameters\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@jrnorth\r\n@dcruver\r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@jlcsmith\r\n@kcwire\r\n#### How should this be tested?\r\nBuild, Install, Configure the Content Directory Monitor with an overridable attribute, ingest some data, and verify the metacard attribute is overridden after ingest.\r\n#### Any background context you want to provide?\r\nAfter discussion with @michaelmenousek, @kcwire and @jlcsmith, it was determined that this approach for metacard attribute overrides was the most logical.\r\n#### What are the relevant tickets?\r\nhttps://codice.atlassian.net/browse/DDF-2034\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n","created_at":"2016-04-21T16:15:19Z","updated_at":"2016-04-22T11:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43a418c68100e725f46bb6499ac86f8ad9188ea9","assignee":{"login":"kcwire","id":4631300,"avatar_url":"https://avatars.githubusercontent.com/u/4631300?v=3","gravatar_id":"","url":"https://api.github.com/users/kcwire","html_url":"https://github.com/kcwire","followers_url":"https://api.github.com/users/kcwire/followers","following_url":"https://api.github.com/users/kcwire/following{/other_user}","gists_url":"https://api.github.com/users/kcwire/gists{/gist_id}","starred_url":"https://api.github.com/users/kcwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcwire/subscriptions","organizations_url":"https://api.github.com/users/kcwire/orgs","repos_url":"https://api.github.com/users/kcwire/repos","events_url":"https://api.github.com/users/kcwire/events{/privacy}","received_events_url":"https://api.github.com/users/kcwire/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/720/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/720/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/720/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/5b42858e74507f6e43729bc67b60b8c66855d105","head":{"label":"bdeining:DDF-2034","ref":"DDF-2034","sha":"5b42858e74507f6e43729bc67b60b8c66855d105","user":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"repo":{"id":40979396,"name":"ddf","full_name":"bdeining/ddf","owner":{"login":"bdeining","id":6551038,"avatar_url":"https://avatars.githubusercontent.com/u/6551038?v=3","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdeining/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/bdeining/ddf","forks_url":"https://api.github.com/repos/bdeining/ddf/forks","keys_url":"https://api.github.com/repos/bdeining/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdeining/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdeining/ddf/teams","hooks_url":"https://api.github.com/repos/bdeining/ddf/hooks","issue_events_url":"https://api.github.com/repos/bdeining/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/bdeining/ddf/events","assignees_url":"https://api.github.com/repos/bdeining/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/bdeining/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/bdeining/ddf/tags","blobs_url":"https://api.github.com/repos/bdeining/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdeining/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdeining/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdeining/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdeining/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/bdeining/ddf/languages","stargazers_url":"https://api.github.com/repos/bdeining/ddf/stargazers","contributors_url":"https://api.github.com/repos/bdeining/ddf/contributors","subscribers_url":"https://api.github.com/repos/bdeining/ddf/subscribers","subscription_url":"https://api.github.com/repos/bdeining/ddf/subscription","commits_url":"https://api.github.com/repos/bdeining/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdeining/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdeining/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdeining/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdeining/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/bdeining/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdeining/ddf/merges","archive_url":"https://api.github.com/repos/bdeining/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdeining/ddf/downloads","issues_url":"https://api.github.com/repos/bdeining/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/bdeining/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/bdeining/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/bdeining/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdeining/ddf/labels{/name}","releases_url":"https://api.github.com/repos/bdeining/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/bdeining/ddf/deployments","created_at":"2015-08-18T15:16:49Z","updated_at":"2016-01-11T14:33:01Z","pushed_at":"2016-04-22T02:31:11Z","git_url":"git://github.com/bdeining/ddf.git","ssh_url":"git@github.com:bdeining/ddf.git","clone_url":"https://github.com/bdeining/ddf.git","svn_url":"https://github.com/bdeining/ddf","homepage":"","size":139927,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"432c3bfe3c1fe1c486ee5485c23516e94e781e4f","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"The Distributed Data Framework - Federated Open Geospatial Consortium (OGC) filter powered metadata catalog with SAML Web SSO secured container","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-04-16T03:12:26Z","pushed_at":"2016-04-22T02:37:11Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"","size":157101,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":17,"forks":75,"open_issues":17,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/720"},"html":{"href":"https://github.com/codice/ddf/pull/720"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/720"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/5b42858e74507f6e43729bc67b60b8c66855d105"}}}}