{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/comments/90784616","pull_request_review_id":11300650,"id":90784616,"diff_hunk":"@@ -1,6 +1,14 @@\n FROM openshift/jenkins-1-centos7\n \n+USER root","path":"docker/jenkins1-centos/Dockerfile","position":3,"original_position":3,"commit_id":"68c28b4dff42ffb390fb3189c555ca6d3c9f21e0","original_commit_id":"68c28b4dff42ffb390fb3189c555ca6d3c9f21e0","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars.githubusercontent.com/u/981838?v=3","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"body":"[Proposition] If we require root here we should revert to jenkins user `USER 1001` after we execute all required commands. \r\nThen container user would not be changed.","created_at":"2016-12-04T19:51:42Z","updated_at":"2016-12-04T19:51:42Z","html_url":"https://github.com/aerogear/digger-jenkins/pull/13#discussion_r90784616","pull_request_url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/comments/90784616"},"html":{"href":"https://github.com/aerogear/digger-jenkins/pull/13#discussion_r90784616"},"pull_request":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13","id":96438444,"html_url":"https://github.com/aerogear/digger-jenkins/pull/13","diff_url":"https://github.com/aerogear/digger-jenkins/pull/13.diff","patch_url":"https://github.com/aerogear/digger-jenkins/pull/13.patch","issue_url":"https://api.github.com/repos/aerogear/digger-jenkins/issues/13","number":13,"state":"open","locked":false,"title":"Update to allow for android-sdk-install (via jenkins job)","user":{"login":"luigizuccarelli","id":12412882,"avatar_url":"https://avatars.githubusercontent.com/u/12412882?v=3","gravatar_id":"","url":"https://api.github.com/users/luigizuccarelli","html_url":"https://github.com/luigizuccarelli","followers_url":"https://api.github.com/users/luigizuccarelli/followers","following_url":"https://api.github.com/users/luigizuccarelli/following{/other_user}","gists_url":"https://api.github.com/users/luigizuccarelli/gists{/gist_id}","starred_url":"https://api.github.com/users/luigizuccarelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigizuccarelli/subscriptions","organizations_url":"https://api.github.com/users/luigizuccarelli/orgs","repos_url":"https://api.github.com/users/luigizuccarelli/repos","events_url":"https://api.github.com/users/luigizuccarelli/events{/privacy}","received_events_url":"https://api.github.com/users/luigizuccarelli/received_events","type":"User","site_admin":false},"body":"## Motivation:\r\nThe current android slave docker container has the android sdk 'baked' into the image\r\nTo avoid any legal problems with the license agreement it would be better to exclude the install and setup of the sdk in a container\r\n\r\n##  Solution:\r\nThe best solution (and easiest - after days of trying plugins/master-slave configurations with external directory mounts etc) was found to be :-\r\n\r\n  - Create a simple freestyle jenkins job\r\n  - Copy the script (included in this repo jenkinsfiles/install-android-sdk.sh) into the job execute shell field\r\n  - Add a Global variable GRADLE_HOME that points to the gradle wrapper directory\r\n  - Create the android slave build pipeline with the script example (jenkinsfiles/new-android.groovy)\r\n  - The install android job needs to be executed once only\r\n\r\nSimple changes to the current dockerfile were necessary (set the JAVA_HOME env for gradle and include wget for the install script)\r\n\r\nResult:\r\nThe slave relies on the GRADLE_HOME setting and calls the gradlew script.\r\nThis has been tested locally.\r\n\r\nJIRA:\r\nrefer to AGDIGGER-43 for details and logs","created_at":"2016-12-04T16:57:46Z","updated_at":"2016-12-04T19:51:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13/commits","review_comments_url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13/comments","review_comment_url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/digger-jenkins/issues/13/comments","statuses_url":"https://api.github.com/repos/aerogear/digger-jenkins/statuses/68c28b4dff42ffb390fb3189c555ca6d3c9f21e0","head":{"label":"luigizuccarelli:AGDIGGER-43","ref":"AGDIGGER-43","sha":"68c28b4dff42ffb390fb3189c555ca6d3c9f21e0","user":{"login":"luigizuccarelli","id":12412882,"avatar_url":"https://avatars.githubusercontent.com/u/12412882?v=3","gravatar_id":"","url":"https://api.github.com/users/luigizuccarelli","html_url":"https://github.com/luigizuccarelli","followers_url":"https://api.github.com/users/luigizuccarelli/followers","following_url":"https://api.github.com/users/luigizuccarelli/following{/other_user}","gists_url":"https://api.github.com/users/luigizuccarelli/gists{/gist_id}","starred_url":"https://api.github.com/users/luigizuccarelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigizuccarelli/subscriptions","organizations_url":"https://api.github.com/users/luigizuccarelli/orgs","repos_url":"https://api.github.com/users/luigizuccarelli/repos","events_url":"https://api.github.com/users/luigizuccarelli/events{/privacy}","received_events_url":"https://api.github.com/users/luigizuccarelli/received_events","type":"User","site_admin":false},"repo":{"id":75550977,"name":"digger-jenkins","full_name":"luigizuccarelli/digger-jenkins","owner":{"login":"luigizuccarelli","id":12412882,"avatar_url":"https://avatars.githubusercontent.com/u/12412882?v=3","gravatar_id":"","url":"https://api.github.com/users/luigizuccarelli","html_url":"https://github.com/luigizuccarelli","followers_url":"https://api.github.com/users/luigizuccarelli/followers","following_url":"https://api.github.com/users/luigizuccarelli/following{/other_user}","gists_url":"https://api.github.com/users/luigizuccarelli/gists{/gist_id}","starred_url":"https://api.github.com/users/luigizuccarelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigizuccarelli/subscriptions","organizations_url":"https://api.github.com/users/luigizuccarelli/orgs","repos_url":"https://api.github.com/users/luigizuccarelli/repos","events_url":"https://api.github.com/users/luigizuccarelli/events{/privacy}","received_events_url":"https://api.github.com/users/luigizuccarelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luigizuccarelli/digger-jenkins","description":"Digger on Jenkins: An OpenSource Build Farm for mobile app builds in the cloud ","fork":true,"url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins","forks_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/forks","keys_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/teams","hooks_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/hooks","issue_events_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/events","assignees_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/tags","blobs_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/languages","stargazers_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/stargazers","contributors_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/contributors","subscribers_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/subscribers","subscription_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/subscription","commits_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/merges","archive_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/downloads","issues_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/luigizuccarelli/digger-jenkins/deployments","created_at":"2016-12-04T16:56:28Z","updated_at":"2016-12-04T16:56:30Z","pushed_at":"2016-12-04T16:57:05Z","git_url":"git://github.com/luigizuccarelli/digger-jenkins.git","ssh_url":"git@github.com:luigizuccarelli/digger-jenkins.git","clone_url":"https://github.com/luigizuccarelli/digger-jenkins.git","svn_url":"https://github.com/luigizuccarelli/digger-jenkins","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"953035ce43e747905399ba5d97eefe8b79e84065","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":74746328,"name":"digger-jenkins","full_name":"aerogear/digger-jenkins","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars.githubusercontent.com/u/954205?v=3","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/digger-jenkins","description":"Digger on Jenkins: An OpenSource Build Farm for mobile app builds in the cloud ","fork":false,"url":"https://api.github.com/repos/aerogear/digger-jenkins","forks_url":"https://api.github.com/repos/aerogear/digger-jenkins/forks","keys_url":"https://api.github.com/repos/aerogear/digger-jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/digger-jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/digger-jenkins/teams","hooks_url":"https://api.github.com/repos/aerogear/digger-jenkins/hooks","issue_events_url":"https://api.github.com/repos/aerogear/digger-jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/digger-jenkins/events","assignees_url":"https://api.github.com/repos/aerogear/digger-jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/digger-jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/digger-jenkins/tags","blobs_url":"https://api.github.com/repos/aerogear/digger-jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/digger-jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/digger-jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/digger-jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/digger-jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/digger-jenkins/languages","stargazers_url":"https://api.github.com/repos/aerogear/digger-jenkins/stargazers","contributors_url":"https://api.github.com/repos/aerogear/digger-jenkins/contributors","subscribers_url":"https://api.github.com/repos/aerogear/digger-jenkins/subscribers","subscription_url":"https://api.github.com/repos/aerogear/digger-jenkins/subscription","commits_url":"https://api.github.com/repos/aerogear/digger-jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/digger-jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/digger-jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/digger-jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/digger-jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/digger-jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/digger-jenkins/merges","archive_url":"https://api.github.com/repos/aerogear/digger-jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/digger-jenkins/downloads","issues_url":"https://api.github.com/repos/aerogear/digger-jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/digger-jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/digger-jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/digger-jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/digger-jenkins/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/digger-jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/digger-jenkins/deployments","created_at":"2016-11-25T09:55:10Z","updated_at":"2016-12-01T07:33:00Z","pushed_at":"2016-12-04T16:57:46Z","git_url":"git://github.com/aerogear/digger-jenkins.git","ssh_url":"git@github.com:aerogear/digger-jenkins.git","clone_url":"https://github.com/aerogear/digger-jenkins.git","svn_url":"https://github.com/aerogear/digger-jenkins","homepage":null,"size":42,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13"},"html":{"href":"https://github.com/aerogear/digger-jenkins/pull/13"},"issue":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/issues/13"},"comments":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/digger-jenkins/statuses/68c28b4dff42ffb390fb3189c555ca6d3c9f21e0"}}}}
{"actor":{"display_login":"wtrocki"}}