{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/52779411","id":52779411,"diff_hunk":"@@ -1974,6 +1978,11 @@ define([\n \n     function splitLongitudeTriangles(instance) {\n         var geometry = instance.geometry;\n+\n+        if (!define(geometry.indices)) {","path":"Source/Core/GeometryPipeline.js","position":16,"original_position":16,"commit_id":"5dac90388b7dd7ceb568b4c27d20334f211f97e5","original_commit_id":"5dac90388b7dd7ceb568b4c27d20334f211f97e5","user":{"login":"hpinkos","id":3451886,"avatar_url":"https://avatars.githubusercontent.com/u/3451886?v=3","gravatar_id":"","url":"https://api.github.com/users/hpinkos","html_url":"https://github.com/hpinkos","followers_url":"https://api.github.com/users/hpinkos/followers","following_url":"https://api.github.com/users/hpinkos/following{/other_user}","gists_url":"https://api.github.com/users/hpinkos/gists{/gist_id}","starred_url":"https://api.github.com/users/hpinkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpinkos/subscriptions","organizations_url":"https://api.github.com/users/hpinkos/orgs","repos_url":"https://api.github.com/users/hpinkos/repos","events_url":"https://api.github.com/users/hpinkos/events{/privacy}","received_events_url":"https://api.github.com/users/hpinkos/received_events","type":"User","site_admin":false},"body":"I don't think checking `geometry.indices` is the right answer.  Indices is optional.  You should check for `geometry.attributes.position` instead.  Do that throughout.","created_at":"2016-02-12T18:35:14Z","updated_at":"2016-02-12T18:35:14Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537#discussion_r52779411","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/52779411"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537#discussion_r52779411"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537","id":58767403,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3537","number":3537,"state":"open","locked":false,"title":"Added check if sides have a length","user":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"body":"For #3241\r\n\r\nIs this what we where looking for, for #2657? If so I can add this check around to the other geometrics and add tests. If not I can refactor this and then go from there.","created_at":"2016-02-09T16:00:09Z","updated_at":"2016-02-12T18:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"842765f329abef01a6f7e29c01db9c9c968a66c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3537/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/5dac90388b7dd7ceb568b4c27d20334f211f97e5","head":{"label":"TomPed:fix-empty-rectangle-bug","ref":"fix-empty-rectangle-bug","sha":"5dac90388b7dd7ceb568b4c27d20334f211f97e5","user":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"repo":{"id":49444126,"name":"cesium","full_name":"TomPed/cesium","owner":{"login":"TomPed","id":11602092,"avatar_url":"https://avatars.githubusercontent.com/u/11602092?v=3","gravatar_id":"","url":"https://api.github.com/users/TomPed","html_url":"https://github.com/TomPed","followers_url":"https://api.github.com/users/TomPed/followers","following_url":"https://api.github.com/users/TomPed/following{/other_user}","gists_url":"https://api.github.com/users/TomPed/gists{/gist_id}","starred_url":"https://api.github.com/users/TomPed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomPed/subscriptions","organizations_url":"https://api.github.com/users/TomPed/orgs","repos_url":"https://api.github.com/users/TomPed/repos","events_url":"https://api.github.com/users/TomPed/events{/privacy}","received_events_url":"https://api.github.com/users/TomPed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomPed/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/TomPed/cesium","forks_url":"https://api.github.com/repos/TomPed/cesium/forks","keys_url":"https://api.github.com/repos/TomPed/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomPed/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomPed/cesium/teams","hooks_url":"https://api.github.com/repos/TomPed/cesium/hooks","issue_events_url":"https://api.github.com/repos/TomPed/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/TomPed/cesium/events","assignees_url":"https://api.github.com/repos/TomPed/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/TomPed/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/TomPed/cesium/tags","blobs_url":"https://api.github.com/repos/TomPed/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomPed/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomPed/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomPed/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomPed/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/TomPed/cesium/languages","stargazers_url":"https://api.github.com/repos/TomPed/cesium/stargazers","contributors_url":"https://api.github.com/repos/TomPed/cesium/contributors","subscribers_url":"https://api.github.com/repos/TomPed/cesium/subscribers","subscription_url":"https://api.github.com/repos/TomPed/cesium/subscription","commits_url":"https://api.github.com/repos/TomPed/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomPed/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomPed/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomPed/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomPed/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/TomPed/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomPed/cesium/merges","archive_url":"https://api.github.com/repos/TomPed/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomPed/cesium/downloads","issues_url":"https://api.github.com/repos/TomPed/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/TomPed/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/TomPed/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/TomPed/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomPed/cesium/labels{/name}","releases_url":"https://api.github.com/repos/TomPed/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/TomPed/cesium/deployments","created_at":"2016-01-11T18:03:32Z","updated_at":"2016-01-11T18:03:43Z","pushed_at":"2016-02-12T16:16:10Z","git_url":"git://github.com/TomPed/cesium.git","ssh_url":"git@github.com:TomPed/cesium.git","clone_url":"https://github.com/TomPed/cesium.git","svn_url":"https://github.com/TomPed/cesium","homepage":"cesiumjs.org","size":239034,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:3d-tiles","ref":"3d-tiles","sha":"9c916e845942fede579892d1455310a173fe2dfb","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-02-11T21:06:58Z","pushed_at":"2016-02-12T18:33:49Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":256220,"stargazers_count":1139,"watchers_count":1139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":675,"mirror_url":null,"open_issues_count":365,"forks":675,"open_issues":365,"watchers":1139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3537"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3537"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3537/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3537/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/5dac90388b7dd7ceb568b4c27d20334f211f97e5"}}}}