{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/coinbase/geoengineer/pulls/44","id":98259635,"html_url":"https://github.com/coinbase/geoengineer/pull/44","diff_url":"https://github.com/coinbase/geoengineer/pull/44.diff","patch_url":"https://github.com/coinbase/geoengineer/pull/44.patch","issue_url":"https://api.github.com/repos/coinbase/geoengineer/issues/44","number":44,"state":"closed","locked":false,"title":"Refactor: #reset","user":{"login":"brad-larson","id":14502699,"avatar_url":"https://avatars.githubusercontent.com/u/14502699?v=3","gravatar_id":"","url":"https://api.github.com/users/brad-larson","html_url":"https://github.com/brad-larson","followers_url":"https://api.github.com/users/brad-larson/followers","following_url":"https://api.github.com/users/brad-larson/following{/other_user}","gists_url":"https://api.github.com/users/brad-larson/gists{/gist_id}","starred_url":"https://api.github.com/users/brad-larson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad-larson/subscriptions","organizations_url":"https://api.github.com/users/brad-larson/orgs","repos_url":"https://api.github.com/users/brad-larson/repos","events_url":"https://api.github.com/users/brad-larson/events{/privacy}","received_events_url":"https://api.github.com/users/brad-larson/received_events","type":"User","site_admin":false},"body":"Type of change:\r\n===============\r\n- Refactor\r\n\r\nWhat changed? ... and Why:\r\n==========================\r\nRealized that when I tried to use the `#reset` functionality in a real\r\nworld project, it didn't reset the remote resource, which meant that\r\n_terraform_id was not refreshed, which meant that the plan still wasn't\r\nup to date.\r\n\r\nSo I renamed the `reset` and `eager_load` to `reset_attributes` and\r\n`eager_load_attributes`, and added a `reset` function to\r\n`GeoEngineer::Resource`, which calls `reset_attributes` and also resets\r\nthe remote variables such that the resource re-calculates the correct\r\nthings.\r\n\r\nHow has it been tested:\r\n=======================\r\nAdded some tests\r\n\r\n@mentions:\r\n==========\r\n@grahamjenson","created_at":"2016-12-16T00:42:07Z","updated_at":"2016-12-16T00:49:34Z","closed_at":"2016-12-16T00:49:34Z","merged_at":"2016-12-16T00:49:34Z","merge_commit_sha":"5356e8b51a7ebf0b2301c1e50f2d09a8dbf4b91c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coinbase/geoengineer/pulls/44/commits","review_comments_url":"https://api.github.com/repos/coinbase/geoengineer/pulls/44/comments","review_comment_url":"https://api.github.com/repos/coinbase/geoengineer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coinbase/geoengineer/issues/44/comments","statuses_url":"https://api.github.com/repos/coinbase/geoengineer/statuses/bfd879d9e7cc9e06b13d1252c5d59f32ed74d2cd","head":{"label":"coinbase:brad-rearchitect-reset","ref":"brad-rearchitect-reset","sha":"bfd879d9e7cc9e06b13d1252c5d59f32ed74d2cd","user":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"repo":{"id":63974097,"name":"geoengineer","full_name":"coinbase/geoengineer","owner":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coinbase/geoengineer","description":"Infrastructure As Code","fork":false,"url":"https://api.github.com/repos/coinbase/geoengineer","forks_url":"https://api.github.com/repos/coinbase/geoengineer/forks","keys_url":"https://api.github.com/repos/coinbase/geoengineer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coinbase/geoengineer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coinbase/geoengineer/teams","hooks_url":"https://api.github.com/repos/coinbase/geoengineer/hooks","issue_events_url":"https://api.github.com/repos/coinbase/geoengineer/issues/events{/number}","events_url":"https://api.github.com/repos/coinbase/geoengineer/events","assignees_url":"https://api.github.com/repos/coinbase/geoengineer/assignees{/user}","branches_url":"https://api.github.com/repos/coinbase/geoengineer/branches{/branch}","tags_url":"https://api.github.com/repos/coinbase/geoengineer/tags","blobs_url":"https://api.github.com/repos/coinbase/geoengineer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coinbase/geoengineer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coinbase/geoengineer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coinbase/geoengineer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coinbase/geoengineer/statuses/{sha}","languages_url":"https://api.github.com/repos/coinbase/geoengineer/languages","stargazers_url":"https://api.github.com/repos/coinbase/geoengineer/stargazers","contributors_url":"https://api.github.com/repos/coinbase/geoengineer/contributors","subscribers_url":"https://api.github.com/repos/coinbase/geoengineer/subscribers","subscription_url":"https://api.github.com/repos/coinbase/geoengineer/subscription","commits_url":"https://api.github.com/repos/coinbase/geoengineer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coinbase/geoengineer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coinbase/geoengineer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coinbase/geoengineer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coinbase/geoengineer/contents/{+path}","compare_url":"https://api.github.com/repos/coinbase/geoengineer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coinbase/geoengineer/merges","archive_url":"https://api.github.com/repos/coinbase/geoengineer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coinbase/geoengineer/downloads","issues_url":"https://api.github.com/repos/coinbase/geoengineer/issues{/number}","pulls_url":"https://api.github.com/repos/coinbase/geoengineer/pulls{/number}","milestones_url":"https://api.github.com/repos/coinbase/geoengineer/milestones{/number}","notifications_url":"https://api.github.com/repos/coinbase/geoengineer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coinbase/geoengineer/labels{/name}","releases_url":"https://api.github.com/repos/coinbase/geoengineer/releases{/id}","deployments_url":"https://api.github.com/repos/coinbase/geoengineer/deployments","created_at":"2016-07-22T18:15:01Z","updated_at":"2016-12-15T18:24:06Z","pushed_at":"2016-12-16T00:49:34Z","git_url":"git://github.com/coinbase/geoengineer.git","ssh_url":"git@github.com:coinbase/geoengineer.git","clone_url":"https://github.com/coinbase/geoengineer.git","svn_url":"https://github.com/coinbase/geoengineer","homepage":"","size":316,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"coinbase:master","ref":"master","sha":"f07da5219bbfebbe7abf497e9f9039df5f9e717b","user":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"repo":{"id":63974097,"name":"geoengineer","full_name":"coinbase/geoengineer","owner":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coinbase/geoengineer","description":"Infrastructure As Code","fork":false,"url":"https://api.github.com/repos/coinbase/geoengineer","forks_url":"https://api.github.com/repos/coinbase/geoengineer/forks","keys_url":"https://api.github.com/repos/coinbase/geoengineer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coinbase/geoengineer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coinbase/geoengineer/teams","hooks_url":"https://api.github.com/repos/coinbase/geoengineer/hooks","issue_events_url":"https://api.github.com/repos/coinbase/geoengineer/issues/events{/number}","events_url":"https://api.github.com/repos/coinbase/geoengineer/events","assignees_url":"https://api.github.com/repos/coinbase/geoengineer/assignees{/user}","branches_url":"https://api.github.com/repos/coinbase/geoengineer/branches{/branch}","tags_url":"https://api.github.com/repos/coinbase/geoengineer/tags","blobs_url":"https://api.github.com/repos/coinbase/geoengineer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coinbase/geoengineer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coinbase/geoengineer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coinbase/geoengineer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coinbase/geoengineer/statuses/{sha}","languages_url":"https://api.github.com/repos/coinbase/geoengineer/languages","stargazers_url":"https://api.github.com/repos/coinbase/geoengineer/stargazers","contributors_url":"https://api.github.com/repos/coinbase/geoengineer/contributors","subscribers_url":"https://api.github.com/repos/coinbase/geoengineer/subscribers","subscription_url":"https://api.github.com/repos/coinbase/geoengineer/subscription","commits_url":"https://api.github.com/repos/coinbase/geoengineer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coinbase/geoengineer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coinbase/geoengineer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coinbase/geoengineer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coinbase/geoengineer/contents/{+path}","compare_url":"https://api.github.com/repos/coinbase/geoengineer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coinbase/geoengineer/merges","archive_url":"https://api.github.com/repos/coinbase/geoengineer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coinbase/geoengineer/downloads","issues_url":"https://api.github.com/repos/coinbase/geoengineer/issues{/number}","pulls_url":"https://api.github.com/repos/coinbase/geoengineer/pulls{/number}","milestones_url":"https://api.github.com/repos/coinbase/geoengineer/milestones{/number}","notifications_url":"https://api.github.com/repos/coinbase/geoengineer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coinbase/geoengineer/labels{/name}","releases_url":"https://api.github.com/repos/coinbase/geoengineer/releases{/id}","deployments_url":"https://api.github.com/repos/coinbase/geoengineer/deployments","created_at":"2016-07-22T18:15:01Z","updated_at":"2016-12-15T18:24:06Z","pushed_at":"2016-12-16T00:49:34Z","git_url":"git://github.com/coinbase/geoengineer.git","ssh_url":"git@github.com:coinbase/geoengineer.git","clone_url":"https://github.com/coinbase/geoengineer.git","svn_url":"https://github.com/coinbase/geoengineer","homepage":"","size":316,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coinbase/geoengineer/pulls/44"},"html":{"href":"https://github.com/coinbase/geoengineer/pull/44"},"issue":{"href":"https://api.github.com/repos/coinbase/geoengineer/issues/44"},"comments":{"href":"https://api.github.com/repos/coinbase/geoengineer/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/coinbase/geoengineer/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/coinbase/geoengineer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coinbase/geoengineer/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/coinbase/geoengineer/statuses/bfd879d9e7cc9e06b13d1252c5d59f32ed74d2cd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grahamjenson","id":331436,"avatar_url":"https://avatars.githubusercontent.com/u/331436?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamjenson","html_url":"https://github.com/grahamjenson","followers_url":"https://api.github.com/users/grahamjenson/followers","following_url":"https://api.github.com/users/grahamjenson/following{/other_user}","gists_url":"https://api.github.com/users/grahamjenson/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamjenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamjenson/subscriptions","organizations_url":"https://api.github.com/users/grahamjenson/orgs","repos_url":"https://api.github.com/users/grahamjenson/repos","events_url":"https://api.github.com/users/grahamjenson/events{/privacy}","received_events_url":"https://api.github.com/users/grahamjenson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"grahamjenson"}}