{"action":"created","issue":{"url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/115","repository_url":"https://api.github.com/repos/sweeneychris/TheiaSfM","labels_url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/115/comments","events_url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/115/events","html_url":"https://github.com/sweeneychris/TheiaSfM/issues/115","id":185207327,"number":115,"title":"Stricter focal length validation","user":{"login":"s7orm","id":270592,"avatar_url":"https://avatars.githubusercontent.com/u/270592?v=3","gravatar_id":"","url":"https://api.github.com/users/s7orm","html_url":"https://github.com/s7orm","followers_url":"https://api.github.com/users/s7orm/followers","following_url":"https://api.github.com/users/s7orm/following{/other_user}","gists_url":"https://api.github.com/users/s7orm/gists{/gist_id}","starred_url":"https://api.github.com/users/s7orm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7orm/subscriptions","organizations_url":"https://api.github.com/users/s7orm/orgs","repos_url":"https://api.github.com/users/s7orm/repos","events_url":"https://api.github.com/users/s7orm/events{/privacy}","received_events_url":"https://api.github.com/users/s7orm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sweeneychris/TheiaSfM/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-25T19:10:52Z","updated_at":"2016-10-26T14:42:13Z","closed_at":null,"body":"Hello,\r\n\r\nwhile playing around with some test images I encountered the following error:\r\n`Check failed: ransac_params.error_thresh > 0 (0 vs. 0) Error threshold must be set to greater than zero`\r\n\r\nI tracked down the issue and it turned out that the Exif:PixelXDimension and Exif:PixelYDimension attributes of the image were not available, which lead to the focal length being set to `inf` [here](https://github.com/sweeneychris/TheiaSfM/blob/ee10a9220dbdf85af161195747e56c8bfb2e5661/src/theia/sfm/exif_reader.cc#L247-L263). The infinity value passes the [sanity check](https://github.com/sweeneychris/TheiaSfM/blob/ee10a9220dbdf85af161195747e56c8bfb2e5661/src/theia/sfm/exif_reader.cc#L148-L150) but leads to the error above [further down the road](https://github.com/sweeneychris/TheiaSfM/blob/ee10a9220dbdf85af161195747e56c8bfb2e5661/src/theia/sfm/estimate_twoview_info.cc#L122-L124).\r\n\r\nAlso according to the documentation, in case the user has configured that only calibrated views should be allowed (the only_calibrated_views parameter for build_reconstruction), the image should be skipped if the focal length is invalid, but I dont think [this is the case](https://github.com/sweeneychris/TheiaSfM/blob/ee10a9220dbdf85af161195747e56c8bfb2e5661/src/theia/sfm/feature_extractor_and_matcher.cc#L197-L198) (correct me if I am wrong).\r\n\r\nPS: The issue can be reproduced with the 1440553366_b4cb1d881b_o.jpg image from the Gendarmenmarkt 1DSfM image data set (and several others).\r\nPS2: I am using the latest OpenImageIO version from homebrew - 1.6.13."},"comment":{"url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/comments/256368665","html_url":"https://github.com/sweeneychris/TheiaSfM/issues/115#issuecomment-256368665","issue_url":"https://api.github.com/repos/sweeneychris/TheiaSfM/issues/115","id":256368665,"user":{"login":"sweeneychris","id":799414,"avatar_url":"https://avatars.githubusercontent.com/u/799414?v=3","gravatar_id":"","url":"https://api.github.com/users/sweeneychris","html_url":"https://github.com/sweeneychris","followers_url":"https://api.github.com/users/sweeneychris/followers","following_url":"https://api.github.com/users/sweeneychris/following{/other_user}","gists_url":"https://api.github.com/users/sweeneychris/gists{/gist_id}","starred_url":"https://api.github.com/users/sweeneychris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweeneychris/subscriptions","organizations_url":"https://api.github.com/users/sweeneychris/orgs","repos_url":"https://api.github.com/users/sweeneychris/repos","events_url":"https://api.github.com/users/sweeneychris/events{/privacy}","received_events_url":"https://api.github.com/users/sweeneychris/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T14:42:13Z","updated_at":"2016-10-26T14:42:13Z","body":"Does this latest change still fail the exif unit test for you? Note that in order to use this patch you'll have to download and apply it as a patch (it is not yet merged into the master branch)."}}
{"actor":{"display_login":"sweeneychris"}}