{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/9385","labels_url":"https://api.github.com/repos/servo/servo/issues/9385/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/9385/comments","events_url":"https://api.github.com/repos/servo/servo/issues/9385/events","html_url":"https://github.com/servo/servo/pull/9385","id":127699974,"number":9385,"title":"Win32 support","user":{"login":"larsbergstrom","id":475847,"avatar_url":"https://avatars.githubusercontent.com/u/475847?v=3","gravatar_id":"","url":"https://api.github.com/users/larsbergstrom","html_url":"https://github.com/larsbergstrom","followers_url":"https://api.github.com/users/larsbergstrom/followers","following_url":"https://api.github.com/users/larsbergstrom/following{/other_user}","gists_url":"https://api.github.com/users/larsbergstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/larsbergstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsbergstrom/subscriptions","organizations_url":"https://api.github.com/users/larsbergstrom/orgs","repos_url":"https://api.github.com/users/larsbergstrom/repos","events_url":"https://api.github.com/users/larsbergstrom/events{/privacy}","received_events_url":"https://api.github.com/users/larsbergstrom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-20T14:57:09Z","updated_at":"2016-01-20T19:26:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9385","html_url":"https://github.com/servo/servo/pull/9385","diff_url":"https://github.com/servo/servo/pull/9385.diff","patch_url":"https://github.com/servo/servo/pull/9385.patch"},"body":"r? @frewsxcv for python stuff\r\nr? @pcwalton for the \"remove usage of Gaol\" stuff for Win32\r\nr? anybody else for misc cargo.lock updates, etc.\r\n\r\nThis replaces #7878.\r\n\r\nThis works best with https://github.com/servo/mozjs/pull/71, too, to enable static linking, but can be run without (via some PATH hackery).\r\n\r\nThe instructions are here, and will be added to a .md file in the repo once the mozjs changes also land:\r\nhttps://hackpad.com/Servo-on-Windows-C1LPcI2bP25\r\n\r\nI'd like to get these changes landed because I've been rebasing them for months, they're otherwise quite stable, and don't affect our other platforms and targets.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9385)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/173332579","html_url":"https://github.com/servo/servo/pull/9385#issuecomment-173332579","issue_url":"https://api.github.com/repos/servo/servo/issues/9385","id":173332579,"user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T19:26:28Z","updated_at":"2016-01-20T19:26:28Z","body":"\n\n\n\n\n\n\n\n*[python/servo/command_base.py, line 65 \\[r4\\]](https://reviewable.io:443/reviews/servo/servo/9385#-K8VJ3Yd55H0lxTxejy-:-K8VUTgRh3e6p6_TQ3m1:-1314352421) ([raw file](https://github.com/servo/servo/blob/32b6d288b3bdd04844690949027bd6b1eab80ece/python/servo/command_base.py#L65)):*\nIf a function should return \"yes\" or \"no\", it should return a boolean, not an integer. Right?\n\nThis is how I would write it personally:\n\n```\n\ndef use_nightly_rust():\n    envvar = os.environ.get(\"SERVO_USE_NIGHTLY_RUST\", \"0\")\n    return envvar != \"0\"\n```\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/9385)*\n<!-- Sent from Reviewable.io -->\n"}}