{"action":"created","issue":{"url":"https://api.github.com/repos/axboe/fio/issues/161","repository_url":"https://api.github.com/repos/axboe/fio","labels_url":"https://api.github.com/repos/axboe/fio/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/axboe/fio/issues/161/comments","events_url":"https://api.github.com/repos/axboe/fio/issues/161/events","html_url":"https://github.com/axboe/fio/pull/161","id":146047508,"number":161,"title":"add pmemblk engine","user":{"login":"bgbhpe","id":18034742,"avatar_url":"https://avatars.githubusercontent.com/u/18034742?v=3","gravatar_id":"","url":"https://api.github.com/users/bgbhpe","html_url":"https://github.com/bgbhpe","followers_url":"https://api.github.com/users/bgbhpe/followers","following_url":"https://api.github.com/users/bgbhpe/following{/other_user}","gists_url":"https://api.github.com/users/bgbhpe/gists{/gist_id}","starred_url":"https://api.github.com/users/bgbhpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgbhpe/subscriptions","organizations_url":"https://api.github.com/users/bgbhpe/orgs","repos_url":"https://api.github.com/users/bgbhpe/repos","events_url":"https://api.github.com/users/bgbhpe/events{/privacy}","received_events_url":"https://api.github.com/users/bgbhpe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-05T16:56:39Z","updated_at":"2016-04-06T00:26:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/axboe/fio/pulls/161","html_url":"https://github.com/axboe/fio/pull/161","diff_url":"https://github.com/axboe/fio/pull/161.diff","patch_url":"https://github.com/axboe/fio/pull/161.patch"},"body":"Seeking comments on a new IO engine utilizing the NVML libpmemblk.  More information on libpmemblk and the NVML is available here http://pmem.io/nvml/."},"comment":{"url":"https://api.github.com/repos/axboe/fio/issues/comments/206045926","html_url":"https://github.com/axboe/fio/pull/161#issuecomment-206045926","issue_url":"https://api.github.com/repos/axboe/fio/issues/161","id":206045926,"user":{"login":"axboe","id":2619634,"avatar_url":"https://avatars.githubusercontent.com/u/2619634?v=3","gravatar_id":"","url":"https://api.github.com/users/axboe","html_url":"https://github.com/axboe","followers_url":"https://api.github.com/users/axboe/followers","following_url":"https://api.github.com/users/axboe/following{/other_user}","gists_url":"https://api.github.com/users/axboe/gists{/gist_id}","starred_url":"https://api.github.com/users/axboe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axboe/subscriptions","organizations_url":"https://api.github.com/users/axboe/orgs","repos_url":"https://api.github.com/users/axboe/repos","events_url":"https://api.github.com/users/axboe/events{/privacy}","received_events_url":"https://api.github.com/users/axboe/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T00:26:23Z","updated_at":"2016-04-06T00:26:23Z","body":"I'll take a look when I'm back from vacation next week. But some initial comments:\r\n\r\n1) If this is going into fio git, then you don't need to keep the external engine hooks. Get rid dlym checks, and the defines.\r\n2) Add an example/ job file that uses it."}}