{"action":"closed","number":9489,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489","id":63481400,"html_url":"https://github.com/joomla/joomla-cms/pull/9489","diff_url":"https://github.com/joomla/joomla-cms/pull/9489.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9489.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9489","number":9489,"state":"closed","locked":false,"title":"Set mailto link for contact email based on emailcloak plugin settings","user":{"login":"matrikular","id":1304616,"avatar_url":"https://avatars.githubusercontent.com/u/1304616?v=3","gravatar_id":"","url":"https://api.github.com/users/matrikular","html_url":"https://github.com/matrikular","followers_url":"https://api.github.com/users/matrikular/followers","following_url":"https://api.github.com/users/matrikular/following{/other_user}","gists_url":"https://api.github.com/users/matrikular/gists{/gist_id}","starred_url":"https://api.github.com/users/matrikular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrikular/subscriptions","organizations_url":"https://api.github.com/users/matrikular/orgs","repos_url":"https://api.github.com/users/matrikular/repos","events_url":"https://api.github.com/users/matrikular/events{/privacy}","received_events_url":"https://api.github.com/users/matrikular/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\nWith the proposed changes the boolean flag \"$mailto\" is passed to the JHtmlEmail::cloak method so the email shown in the contact view is influenced by the email cloak plugins (settings) without triggering it.\r\n\r\n#### Why do it this way?\r\nOne could argue that this flag could / should be in com_contact itself and I agree - on the long run, surely the better option. I'm working on a PR for that, too. Regarding the current implementation: I didn't want to call the plugin directly or via JHtmlContent::prepare, since we only need the plugins mode parameter value here.\r\n\r\n#### Test Instructions\r\n1. **Back-end:** Create a contact. Give it a title and make sure to fill out the email address field. The contact doesn't have to be assigned to a user or a category. For easy access, create a menu item to that user.\r\n2. **Front-end:** Verify that the email address including the mailto link is visible in the front-end. If not, please check the settings for com_contact.\r\n3. **Back-end:** Go to the plugin section and edit the \"Content - Email Cloaking\" plugin. The only parameter there is the \"mode\" switch. Set / Change it to \"Non-linkable Text\".\r\n4. **Front-end:** Refresh the page. Without the patch you will see that the email address will always have a mailto link attached to it.\r\n5. **Front-end** / **Back-end:** Apply the patch and check again. The mailto link can now be switched on or off via the email cloak plugin.","created_at":"2016-03-19T23:00:28Z","updated_at":"2016-03-20T00:56:01Z","closed_at":"2016-03-20T00:56:01Z","merged_at":null,"merge_commit_sha":"b04c4ff5a6491cc31db4260d04764044af621806","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9489/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/5919370eb81e95504cfd58769fd5325f45023f22","head":{"label":"matrikular:patch-6","ref":"patch-6","sha":"5919370eb81e95504cfd58769fd5325f45023f22","user":{"login":"matrikular","id":1304616,"avatar_url":"https://avatars.githubusercontent.com/u/1304616?v=3","gravatar_id":"","url":"https://api.github.com/users/matrikular","html_url":"https://github.com/matrikular","followers_url":"https://api.github.com/users/matrikular/followers","following_url":"https://api.github.com/users/matrikular/following{/other_user}","gists_url":"https://api.github.com/users/matrikular/gists{/gist_id}","starred_url":"https://api.github.com/users/matrikular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrikular/subscriptions","organizations_url":"https://api.github.com/users/matrikular/orgs","repos_url":"https://api.github.com/users/matrikular/repos","events_url":"https://api.github.com/users/matrikular/events{/privacy}","received_events_url":"https://api.github.com/users/matrikular/received_events","type":"User","site_admin":false},"repo":{"id":44177189,"name":"joomla-cms","full_name":"matrikular/joomla-cms","owner":{"login":"matrikular","id":1304616,"avatar_url":"https://avatars.githubusercontent.com/u/1304616?v=3","gravatar_id":"","url":"https://api.github.com/users/matrikular","html_url":"https://github.com/matrikular","followers_url":"https://api.github.com/users/matrikular/followers","following_url":"https://api.github.com/users/matrikular/following{/other_user}","gists_url":"https://api.github.com/users/matrikular/gists{/gist_id}","starred_url":"https://api.github.com/users/matrikular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrikular/subscriptions","organizations_url":"https://api.github.com/users/matrikular/orgs","repos_url":"https://api.github.com/users/matrikular/repos","events_url":"https://api.github.com/users/matrikular/events{/privacy}","received_events_url":"https://api.github.com/users/matrikular/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matrikular/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/matrikular/joomla-cms","forks_url":"https://api.github.com/repos/matrikular/joomla-cms/forks","keys_url":"https://api.github.com/repos/matrikular/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrikular/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrikular/joomla-cms/teams","hooks_url":"https://api.github.com/repos/matrikular/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/matrikular/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/matrikular/joomla-cms/events","assignees_url":"https://api.github.com/repos/matrikular/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/matrikular/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/matrikular/joomla-cms/tags","blobs_url":"https://api.github.com/repos/matrikular/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrikular/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrikular/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrikular/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrikular/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/matrikular/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/matrikular/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/matrikular/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/matrikular/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/matrikular/joomla-cms/subscription","commits_url":"https://api.github.com/repos/matrikular/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrikular/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrikular/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrikular/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrikular/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/matrikular/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrikular/joomla-cms/merges","archive_url":"https://api.github.com/repos/matrikular/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrikular/joomla-cms/downloads","issues_url":"https://api.github.com/repos/matrikular/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/matrikular/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/matrikular/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/matrikular/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrikular/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/matrikular/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/matrikular/joomla-cms/deployments","created_at":"2015-10-13T13:13:52Z","updated_at":"2015-10-13T13:14:23Z","pushed_at":"2016-03-20T00:42:16Z","git_url":"git://github.com/matrikular/joomla-cms.git","ssh_url":"git@github.com:matrikular/joomla-cms.git","clone_url":"https://github.com/matrikular/joomla-cms.git","svn_url":"https://github.com/matrikular/joomla-cms","homepage":"https://www.joomla.org","size":142072,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"5b355cebe28c1081dcad986a3ffec8b18b63112c","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-03-19T22:29:37Z","pushed_at":"2016-03-20T00:37:04Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":267975,"stargazers_count":1858,"watchers_count":1858,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2090,"mirror_url":null,"open_issues_count":620,"forks":2090,"open_issues":620,"watchers":1858,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/9489"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9489"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/9489/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/9489/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/5919370eb81e95504cfd58769fd5325f45023f22"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":12,"deletions":1,"changed_files":1}}