{"action":"closed","number":591,"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/591","id":77480454,"html_url":"https://github.com/facebook/componentkit/pull/591","diff_url":"https://github.com/facebook/componentkit/pull/591.diff","patch_url":"https://github.com/facebook/componentkit/pull/591.patch","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/591","number":591,"state":"closed","locked":false,"title":"Removed accessibilityIdentifier from context (fixes issue #590)","user":{"login":"taiber","id":1702206,"avatar_url":"https://avatars.githubusercontent.com/u/1702206?v=3","gravatar_id":"","url":"https://api.github.com/users/taiber","html_url":"https://github.com/taiber","followers_url":"https://api.github.com/users/taiber/followers","following_url":"https://api.github.com/users/taiber/following{/other_user}","gists_url":"https://api.github.com/users/taiber/gists{/gist_id}","starred_url":"https://api.github.com/users/taiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taiber/subscriptions","organizations_url":"https://api.github.com/users/taiber/orgs","repos_url":"https://api.github.com/users/taiber/repos","events_url":"https://api.github.com/users/taiber/events{/privacy}","received_events_url":"https://api.github.com/users/taiber/received_events","type":"User","site_admin":false},"body":"We shouldn't pass in accessibilityIdentifier as part of accessibility context as it's an automation feature, not an accessibility one. See issue #590 for more details.\r\n\r\nThis diff removes the use of the identifier, forcing people to pass it in correctly and consistently if they want to use it (e.g. `{@selector(setAccessibilityIdentifier:), @\"accessibilityId\"}` in attributes).\r\n\r\nTest plan: ran all the tests, made sure that passing accessibilityIdentifier correctly works as expected","created_at":"2016-07-14T15:54:35Z","updated_at":"2016-07-15T16:03:35Z","closed_at":"2016-07-15T16:03:35Z","merged_at":"2016-07-15T16:03:35Z","merge_commit_sha":"3f5329648e1049388a5b5922646e40f4d96252bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/componentkit/pulls/591/commits","review_comments_url":"https://api.github.com/repos/facebook/componentkit/pulls/591/comments","review_comment_url":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/591/comments","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/2969a45474153524c311bd7ba873d1f15d8179ee","head":{"label":"taiber:master","ref":"master","sha":"2969a45474153524c311bd7ba873d1f15d8179ee","user":{"login":"taiber","id":1702206,"avatar_url":"https://avatars.githubusercontent.com/u/1702206?v=3","gravatar_id":"","url":"https://api.github.com/users/taiber","html_url":"https://github.com/taiber","followers_url":"https://api.github.com/users/taiber/followers","following_url":"https://api.github.com/users/taiber/following{/other_user}","gists_url":"https://api.github.com/users/taiber/gists{/gist_id}","starred_url":"https://api.github.com/users/taiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taiber/subscriptions","organizations_url":"https://api.github.com/users/taiber/orgs","repos_url":"https://api.github.com/users/taiber/repos","events_url":"https://api.github.com/users/taiber/events{/privacy}","received_events_url":"https://api.github.com/users/taiber/received_events","type":"User","site_admin":false},"repo":{"id":63343572,"name":"componentkit","full_name":"taiber/componentkit","owner":{"login":"taiber","id":1702206,"avatar_url":"https://avatars.githubusercontent.com/u/1702206?v=3","gravatar_id":"","url":"https://api.github.com/users/taiber","html_url":"https://github.com/taiber","followers_url":"https://api.github.com/users/taiber/followers","following_url":"https://api.github.com/users/taiber/following{/other_user}","gists_url":"https://api.github.com/users/taiber/gists{/gist_id}","starred_url":"https://api.github.com/users/taiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taiber/subscriptions","organizations_url":"https://api.github.com/users/taiber/orgs","repos_url":"https://api.github.com/users/taiber/repos","events_url":"https://api.github.com/users/taiber/events{/privacy}","received_events_url":"https://api.github.com/users/taiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taiber/componentkit","description":"A React-inspired view framework for iOS.","fork":true,"url":"https://api.github.com/repos/taiber/componentkit","forks_url":"https://api.github.com/repos/taiber/componentkit/forks","keys_url":"https://api.github.com/repos/taiber/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taiber/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taiber/componentkit/teams","hooks_url":"https://api.github.com/repos/taiber/componentkit/hooks","issue_events_url":"https://api.github.com/repos/taiber/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/taiber/componentkit/events","assignees_url":"https://api.github.com/repos/taiber/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/taiber/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/taiber/componentkit/tags","blobs_url":"https://api.github.com/repos/taiber/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taiber/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taiber/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/taiber/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taiber/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/taiber/componentkit/languages","stargazers_url":"https://api.github.com/repos/taiber/componentkit/stargazers","contributors_url":"https://api.github.com/repos/taiber/componentkit/contributors","subscribers_url":"https://api.github.com/repos/taiber/componentkit/subscribers","subscription_url":"https://api.github.com/repos/taiber/componentkit/subscription","commits_url":"https://api.github.com/repos/taiber/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/taiber/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/taiber/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/taiber/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/taiber/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/taiber/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taiber/componentkit/merges","archive_url":"https://api.github.com/repos/taiber/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taiber/componentkit/downloads","issues_url":"https://api.github.com/repos/taiber/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/taiber/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/taiber/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/taiber/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taiber/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/taiber/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/taiber/componentkit/deployments","created_at":"2016-07-14T14:30:25Z","updated_at":"2016-07-14T14:30:28Z","pushed_at":"2016-07-15T15:31:39Z","git_url":"git://github.com/taiber/componentkit.git","ssh_url":"git@github.com:taiber/componentkit.git","clone_url":"https://github.com/taiber/componentkit.git","svn_url":"https://github.com/taiber/componentkit","homepage":"http://www.componentkit.org/","size":8233,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a4da6d4985537870132feea67a0a139771c05d49","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":32600951,"name":"componentkit","full_name":"facebook/componentkit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/componentkit","description":"A React-inspired view framework for iOS.","fork":false,"url":"https://api.github.com/repos/facebook/componentkit","forks_url":"https://api.github.com/repos/facebook/componentkit/forks","keys_url":"https://api.github.com/repos/facebook/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/componentkit/teams","hooks_url":"https://api.github.com/repos/facebook/componentkit/hooks","issue_events_url":"https://api.github.com/repos/facebook/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/componentkit/events","assignees_url":"https://api.github.com/repos/facebook/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/componentkit/tags","blobs_url":"https://api.github.com/repos/facebook/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/componentkit/languages","stargazers_url":"https://api.github.com/repos/facebook/componentkit/stargazers","contributors_url":"https://api.github.com/repos/facebook/componentkit/contributors","subscribers_url":"https://api.github.com/repos/facebook/componentkit/subscribers","subscription_url":"https://api.github.com/repos/facebook/componentkit/subscription","commits_url":"https://api.github.com/repos/facebook/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/componentkit/merges","archive_url":"https://api.github.com/repos/facebook/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/componentkit/downloads","issues_url":"https://api.github.com/repos/facebook/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/componentkit/deployments","created_at":"2015-03-20T18:42:47Z","updated_at":"2016-07-15T09:45:24Z","pushed_at":"2016-07-15T16:03:35Z","git_url":"git://github.com/facebook/componentkit.git","ssh_url":"git@github.com:facebook/componentkit.git","clone_url":"https://github.com/facebook/componentkit.git","svn_url":"https://github.com/facebook/componentkit","homepage":"http://www.componentkit.org/","size":8993,"stargazers_count":3217,"watchers_count":3217,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":347,"mirror_url":null,"open_issues_count":54,"forks":347,"open_issues":54,"watchers":3217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/591"},"html":{"href":"https://github.com/facebook/componentkit/pull/591"},"issue":{"href":"https://api.github.com/repos/facebook/componentkit/issues/591"},"comments":{"href":"https://api.github.com/repos/facebook/componentkit/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/componentkit/statuses/2969a45474153524c311bd7ba873d1f15d8179ee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":3,"additions":7,"deletions":17,"changed_files":7}}
{"actor":{"display_login":"eczarny"}}