{"action":"created","issue":{"url":"https://api.github.com/repos/workshopper/learnyounode/issues/398","labels_url":"https://api.github.com/repos/workshopper/learnyounode/issues/398/labels{/name}","comments_url":"https://api.github.com/repos/workshopper/learnyounode/issues/398/comments","events_url":"https://api.github.com/repos/workshopper/learnyounode/issues/398/events","html_url":"https://github.com/workshopper/learnyounode/pull/398","id":124863155,"number":398,"title":"verification of content-type and status code for http file server exercise","user":{"login":"jpdamon","id":3506319,"avatar_url":"https://avatars.githubusercontent.com/u/3506319?v=3","gravatar_id":"","url":"https://api.github.com/users/jpdamon","html_url":"https://github.com/jpdamon","followers_url":"https://api.github.com/users/jpdamon/followers","following_url":"https://api.github.com/users/jpdamon/following{/other_user}","gists_url":"https://api.github.com/users/jpdamon/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdamon/subscriptions","organizations_url":"https://api.github.com/users/jpdamon/orgs","repos_url":"https://api.github.com/users/jpdamon/repos","events_url":"https://api.github.com/users/jpdamon/events{/privacy}","received_events_url":"https://api.github.com/users/jpdamon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-04T23:33:34Z","updated_at":"2016-01-05T00:24:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/workshopper/learnyounode/pulls/398","html_url":"https://github.com/workshopper/learnyounode/pull/398","diff_url":"https://github.com/workshopper/learnyounode/pull/398.diff","patch_url":"https://github.com/workshopper/learnyounode/pull/398.patch"},"body":"Clarified that setting the content-type and status code are now required. Added verification to exercise.js\r\nFixes #348  "},"comment":{"url":"https://api.github.com/repos/workshopper/learnyounode/issues/comments/168852698","html_url":"https://github.com/workshopper/learnyounode/pull/398#issuecomment-168852698","issue_url":"https://api.github.com/repos/workshopper/learnyounode/issues/398","id":168852698,"user":{"login":"martinheidegger","id":914122,"avatar_url":"https://avatars.githubusercontent.com/u/914122?v=3","gravatar_id":"","url":"https://api.github.com/users/martinheidegger","html_url":"https://github.com/martinheidegger","followers_url":"https://api.github.com/users/martinheidegger/followers","following_url":"https://api.github.com/users/martinheidegger/following{/other_user}","gists_url":"https://api.github.com/users/martinheidegger/gists{/gist_id}","starred_url":"https://api.github.com/users/martinheidegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinheidegger/subscriptions","organizations_url":"https://api.github.com/users/martinheidegger/orgs","repos_url":"https://api.github.com/users/martinheidegger/repos","events_url":"https://api.github.com/users/martinheidegger/events{/privacy}","received_events_url":"https://api.github.com/users/martinheidegger/received_events","type":"User","site_admin":false},"created_at":"2016-01-05T00:24:13Z","updated_at":"2016-01-05T00:24:13Z","body":"Continuing conversation here:\r\n\r\n_Yes,_ the tests obviously didn't cover this particular use-case before so it would be good to have a test-case covering this particular problem. The test cases are quite simple: Just add a `valid_0x.js` file to the `test/http_file_server/` folder that - without your fix - would have failed. You then can run the tests again using `npm test`.\r\n\r\nAlso it would be good if the PR would contain the locales in all languages - even if they are in english - since there is no fallback yet."}}