{"action":"created","issue":{"url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/37","repository_url":"https://api.github.com/repos/janbar/pvr.mythtv","labels_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/37/comments","events_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/37/events","html_url":"https://github.com/janbar/pvr.mythtv/issues/37","id":154563528,"number":37,"title":"Problem with recording resumepoints caused by inconsistent airdate","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"labels":[{"id":184500728,"url":"https://api.github.com/repos/janbar/pvr.mythtv/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-05-12T19:36:23Z","updated_at":"2016-11-28T22:15:42Z","closed_at":"2016-07-12T22:26:20Z","body":"Hi Janbar,\n\nI hope you're doing well! The addon is still working perfectly here and it's used almost every day! Nice job you did with wsapi and cppmyth!\n\nI've spend some time to track down a problem, but I'm unsure how to fix it, hence no PR yet. The symptom is that recording resumepoints (kodi videodatabase) are not set/shown when the recording is new (unwatched).\n\nTo reproduce: \n- play a recording, seek, stop playback --> no resumepoint is down, the recording is unwatched\n- play it again, seek, stop playback --> resumepoint is saved and playback can be resumed.\n\nThe issue is caused by an inconsistency in the airdate field, which is filled into year, handed over to kodi and here used to identify a recording (`PVRRecordingsPath.cpp`). When the list of recordings is initially filled, the data is taken from the wsapi and the Airdate field is correctly field (for example with `2016-01-01`). When you start playing the recording, the addon receives a `RECORDING_LIST_CHANGE UPDATE` event where the airdate field of the ProgramInfo is set to the current date time. I've double checked with wireshark that it's not a parsing problem. This causes the recording to be transferred to Kodi with year set to -1. When you now stop the playback, Kodi sets the resumepoint for an incorrect path. When you start the playback again, and stop it, it will work because the path now doesn't contain a year anymore.\n\nHave you seen this behaviour? Could you try to reproduce it? Would be good to know if that's some local issue with my setup. How would we fix that in the addon? As a workaround I patched out saving the year, but that's not the solution.\n\nBTW: Has there been any progress on storing the resume points again on the backend? Or still not possible with wsapi? \n\nPing also @metaron-uk who added that code in https://github.com/janbar/pvr.mythtv/commit/882370462b20d14d7465d1ca07ff5ba8d1e0b2ed. \n\nMythTV version: 0.28.0+fixes.20160506.0b08cb4-0ubuntu0mythbuntu2\n\nThanks much,\nChristian\n"},"comment":{"url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/comments/263411916","html_url":"https://github.com/janbar/pvr.mythtv/issues/37#issuecomment-263411916","issue_url":"https://api.github.com/repos/janbar/pvr.mythtv/issues/37","id":263411916,"user":{"login":"janbar","id":2353635,"avatar_url":"https://avatars.githubusercontent.com/u/2353635?v=3","gravatar_id":"","url":"https://api.github.com/users/janbar","html_url":"https://github.com/janbar","followers_url":"https://api.github.com/users/janbar/followers","following_url":"https://api.github.com/users/janbar/following{/other_user}","gists_url":"https://api.github.com/users/janbar/gists{/gist_id}","starred_url":"https://api.github.com/users/janbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janbar/subscriptions","organizations_url":"https://api.github.com/users/janbar/orgs","repos_url":"https://api.github.com/users/janbar/repos","events_url":"https://api.github.com/users/janbar/events{/privacy}","received_events_url":"https://api.github.com/users/janbar/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T22:15:42Z","updated_at":"2016-11-28T22:15:42Z","body":"Hi @fetzerch, hope you re fine. I review last changes from mythtv api and new services to handle saved bookmark have been published. I will update the addon in the couple of weeks to handle saved bookmark in the backend. The feature will be re-available from MythTV 29. br."}}
{"actor":{"display_login":"janbar"}}