{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/1601","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/1601/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/1601/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/1601/events","html_url":"https://github.com/tbeu/Modelica/issues/1601","id":197609030,"number":1601,"title":"Wrong calculation of Reynolds number for non-circular pipes","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":506762997,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true},{"id":506769233,"url":"https://api.github.com/repos/tbeu/Modelica/labels/L:Fluid","name":"L:Fluid","color":"0000aa","default":false},{"id":506770144,"url":"https://api.github.com/repos/tbeu/Modelica/labels/P:%20high","name":"P: high","color":"ff6666","default":false}],"state":"open","locked":false,"assignee":{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false},"assignees":[{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tbeu/Modelica/milestones/52","html_url":"https://github.com/tbeu/Modelica/milestone/52","labels_url":"https://api.github.com/repos/tbeu/Modelica/milestones/52/labels","id":2214855,"number":52,"title":"MSL3.2.1+build.3","description":"Plan as of 84th Modelica Design Meeting:\n 1. Freeze date for maintenance build: Dec 22, 2014\n 2. Leo will run regression testing an fill a ticket for all models with non-obvious differences by Jan 2, 2015 (check \n    wiki:HowTo/MAP-LIB/ModelicaStandardLibrary/RegressionTesting for instructions how to replicate regression tests)\n 3. All library officers should react within one week, until Jan 9, 2015 (either explain the difference or fix the bug)\n 4. A web meeting is scheduled shortly after Jan 9, 2015 for a quick review and then build `v3.2.1+build.3-beta.2`\n\n","creator":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":78,"state":"closed","created_at":"2016-12-25T13:01:13Z","updated_at":"2016-12-26T18:02:36Z","due_on":"2014-03-15T07:00:00Z","closed_at":"2016-12-25T13:01:13Z"},"comments":6,"created_at":"2016-12-26T18:02:17Z","updated_at":"2016-12-26T18:03:56Z","closed_at":null,"body":"**Reported by A&#x2e;Taeschner on 10 Nov 2014 12:13 UTC**\nI found a severe bug in the Fluid library when calculating the pressure drop of noncircular pipes where the cross area A is not given by A=pi/4\\*d*d anymore. The bug is in line 3422 of Modelica/Fluid/Pipes.mo:\n\nRe :=(4/pi)\\*abs(m_flow)/(diameter\\*mu);\n\nThis equation is only correct for circular pipes, but for arbitrary pipes it has to be:\n\nRe :=abs(m_flow)\\*diameter/(crossArea\\*mu);\n\nThis seems to be not the only line where the wrong assumption (A=pi/4\\*d*d) has been used, but I had no time to investigate this further.\n\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/1601"},"comment":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/comments/269231543","html_url":"https://github.com/tbeu/Modelica/issues/1601#issuecomment-269231543","issue_url":"https://api.github.com/repos/tbeu/Modelica/issues/1601","id":269231543,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T18:03:56Z","updated_at":"2016-12-26T18:03:56Z","body":"**Comment by rfranke on 6 Jan 2015 21:46 UTC**\nSVN 29a67410d01a196bb2671f3ef4ede06b581ade48 introduces your example and the fix basing on your patch. The default DetailedPipeFlow model works for non-circular pipes now, besides the Laminar and the NoFriction model.\n\nThe (LaminarAnd)QuadraticTurbulent models still need to be fixed.\n"}}
{"actor":{"display_login":"modelica-trac-importer"}}