{"action":"created","comment":{"url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/comments/65253037","id":65253037,"diff_hunk":"@@ -0,0 +1,63 @@\n+---\n+\n+# supported for ansible ver => 2.0\n+#- name: Install python-mysqldb for Ansible\n+#  package: pkg=python-mysqldb state=present\n+\n+\n+- name: Install python-mysqldb for Ansible\n+  apt: name=python-mysqldb state=present\n+  when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'\n+\n+- name: Install python-mysqldb for Ansible\n+  yum: name=MySQL-python state=present\n+  when: ansible_os_family == 'RedHat' or ansible_os_family == 'Oracle Linux'\n+\n+- name: root password is present\n+  mysql_user: name=root host={{ item }} password={{ mysql_root_password }} state=present\n+  with_items:\n+    - '::1'\n+    - '127.0.0.1'\n+    - 'localhost'\n+\n+- name: root has .my.cnf\n+  template: src=my.cnf.j2 dest=/root/.my.cnf ","path":"tasks/mysql_secure_installation.yml","position":null,"original_position":24,"commit_id":"ef77bf7c1120bffe361114d02a49f16a301ea581","original_commit_id":"01d890be12a646958d5c6fa63221c6b92fd96ccf","user":{"login":"fitz123","id":10243861,"avatar_url":"https://avatars.githubusercontent.com/u/10243861?v=3","gravatar_id":"","url":"https://api.github.com/users/fitz123","html_url":"https://github.com/fitz123","followers_url":"https://api.github.com/users/fitz123/followers","following_url":"https://api.github.com/users/fitz123/following{/other_user}","gists_url":"https://api.github.com/users/fitz123/gists{/gist_id}","starred_url":"https://api.github.com/users/fitz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitz123/subscriptions","organizations_url":"https://api.github.com/users/fitz123/orgs","repos_url":"https://api.github.com/users/fitz123/repos","events_url":"https://api.github.com/users/fitz123/events{/privacy}","received_events_url":"https://api.github.com/users/fitz123/received_events","type":"User","site_admin":false},"body":"> If the user running the role is not root but e.g. becomes root with sudo, login will fail\r\n\r\nit's not true, at least according my tests\r\n\r\n> Also the .my.cnf has to be copied before the \"root password is present\" task, else the login will fail.\r\n\r\nIt's not true, it's vice versa. If I'll set up .my.cnf before `root password is present` task - it'll fail if user has empty root password. In current sequence nothing fail in both cases","created_at":"2016-05-31T20:07:03Z","updated_at":"2016-05-31T20:07:03Z","html_url":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15#discussion_r65253037","pull_request_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/comments/65253037"},"html":{"href":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15#discussion_r65253037"},"pull_request":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15","id":70946401,"html_url":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15","diff_url":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15.diff","patch_url":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15.patch","issue_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/15","number":15,"state":"open","locked":false,"title":"alt version initial commit","user":{"login":"fitz123","id":10243861,"avatar_url":"https://avatars.githubusercontent.com/u/10243861?v=3","gravatar_id":"","url":"https://api.github.com/users/fitz123","html_url":"https://github.com/fitz123","followers_url":"https://api.github.com/users/fitz123/followers","following_url":"https://api.github.com/users/fitz123/following{/other_user}","gists_url":"https://api.github.com/users/fitz123/gists{/gist_id}","starred_url":"https://api.github.com/users/fitz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitz123/subscriptions","organizations_url":"https://api.github.com/users/fitz123/orgs","repos_url":"https://api.github.com/users/fitz123/repos","events_url":"https://api.github.com/users/fitz123/events{/privacy}","received_events_url":"https://api.github.com/users/fitz123/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-21T10:49:29Z","updated_at":"2016-05-31T20:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bedf2a69120db797dcc0f22d8dd5068cc46d23a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15/commits","review_comments_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15/comments","review_comment_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/15/comments","statuses_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/statuses/ef77bf7c1120bffe361114d02a49f16a301ea581","head":{"label":"fitz123:alt_version","ref":"alt_version","sha":"ef77bf7c1120bffe361114d02a49f16a301ea581","user":{"login":"fitz123","id":10243861,"avatar_url":"https://avatars.githubusercontent.com/u/10243861?v=3","gravatar_id":"","url":"https://api.github.com/users/fitz123","html_url":"https://github.com/fitz123","followers_url":"https://api.github.com/users/fitz123/followers","following_url":"https://api.github.com/users/fitz123/following{/other_user}","gists_url":"https://api.github.com/users/fitz123/gists{/gist_id}","starred_url":"https://api.github.com/users/fitz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitz123/subscriptions","organizations_url":"https://api.github.com/users/fitz123/orgs","repos_url":"https://api.github.com/users/fitz123/repos","events_url":"https://api.github.com/users/fitz123/events{/privacy}","received_events_url":"https://api.github.com/users/fitz123/received_events","type":"User","site_admin":false},"repo":{"id":59354849,"name":"ansible-mysql-hardening","full_name":"fitz123/ansible-mysql-hardening","owner":{"login":"fitz123","id":10243861,"avatar_url":"https://avatars.githubusercontent.com/u/10243861?v=3","gravatar_id":"","url":"https://api.github.com/users/fitz123","html_url":"https://github.com/fitz123","followers_url":"https://api.github.com/users/fitz123/followers","following_url":"https://api.github.com/users/fitz123/following{/other_user}","gists_url":"https://api.github.com/users/fitz123/gists{/gist_id}","starred_url":"https://api.github.com/users/fitz123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitz123/subscriptions","organizations_url":"https://api.github.com/users/fitz123/orgs","repos_url":"https://api.github.com/users/fitz123/repos","events_url":"https://api.github.com/users/fitz123/events{/privacy}","received_events_url":"https://api.github.com/users/fitz123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fitz123/ansible-mysql-hardening","description":"This Ansible playbook provides security configuration for MySQL.","fork":true,"url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening","forks_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/forks","keys_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/teams","hooks_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/hooks","issue_events_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/events","assignees_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/tags","blobs_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/languages","stargazers_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/stargazers","contributors_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/contributors","subscribers_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/subscribers","subscription_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/subscription","commits_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/merges","archive_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/downloads","issues_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/labels{/name}","releases_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/releases{/id}","deployments_url":"https://api.github.com/repos/fitz123/ansible-mysql-hardening/deployments","created_at":"2016-05-21T10:45:36Z","updated_at":"2016-05-21T10:45:37Z","pushed_at":"2016-05-31T19:57:20Z","git_url":"git://github.com/fitz123/ansible-mysql-hardening.git","ssh_url":"git@github.com:fitz123/ansible-mysql-hardening.git","clone_url":"https://github.com/fitz123/ansible-mysql-hardening.git","svn_url":"https://github.com/fitz123/ansible-mysql-hardening","homepage":"http://dev-sec.io/","size":33,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dev-sec:master","ref":"master","sha":"3d7eadc31c83b1e0b72a60f7432e76067c7eee0f","user":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":38443903,"name":"ansible-mysql-hardening","full_name":"dev-sec/ansible-mysql-hardening","owner":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dev-sec/ansible-mysql-hardening","description":"This Ansible playbook provides security configuration for MySQL.","fork":false,"url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening","forks_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/forks","keys_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/teams","hooks_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/hooks","issue_events_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/events","assignees_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/tags","blobs_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/languages","stargazers_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/stargazers","contributors_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/contributors","subscribers_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/subscribers","subscription_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/subscription","commits_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/merges","archive_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/downloads","issues_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/labels{/name}","releases_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/releases{/id}","deployments_url":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/deployments","created_at":"2015-07-02T16:28:08Z","updated_at":"2016-05-30T19:08:55Z","pushed_at":"2016-05-31T19:57:21Z","git_url":"git://github.com/dev-sec/ansible-mysql-hardening.git","ssh_url":"git@github.com:dev-sec/ansible-mysql-hardening.git","clone_url":"https://github.com/dev-sec/ansible-mysql-hardening.git","svn_url":"https://github.com/dev-sec/ansible-mysql-hardening","homepage":"http://dev-sec.io/","size":68,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15"},"html":{"href":"https://github.com/dev-sec/ansible-mysql-hardening/pull/15"},"issue":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/15"},"comments":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/dev-sec/ansible-mysql-hardening/statuses/ef77bf7c1120bffe361114d02a49f16a301ea581"}}}}
{"actor":{"display_login":"fitz123"}}