{"action":"closed","number":5589,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/5589","id":97470061,"html_url":"https://github.com/astropy/astropy/pull/5589","diff_url":"https://github.com/astropy/astropy/pull/5589.diff","patch_url":"https://github.com/astropy/astropy/pull/5589.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/5589","number":5589,"state":"closed","locked":false,"title":"Fix up lazy loading issues","user":{"login":"mwcraig","id":1147167,"avatar_url":"https://avatars.githubusercontent.com/u/1147167?v=3","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"body":"Fix or address these issues which resulted from lazy loading. In each case the goal is to maintain the current (1.x) behavior of io.fits.\r\n\r\n- [x] Handling of invalid key in the `in` operator (closes #5583)\r\n- [x] Slices not working (closes #5585)\r\n- [x] Variable name incorrect (closes #5594)\r\n- ~~[ ] Address behavior of `close` #5582~~ Won't change unless someone requests it.\r\n\r\n@eteq -- I believe I've milestoned this correctly, but please modify if not.\r\n\r\nedit: changed text of second todo.","created_at":"2016-12-11T19:48:44Z","updated_at":"2016-12-13T01:48:53Z","closed_at":"2016-12-13T01:48:53Z","merged_at":"2016-12-13T01:48:52Z","merge_commit_sha":"ab7efa68c4463875f4a6f2159168dd8945c314ea","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/38","html_url":"https://github.com/astropy/astropy/milestone/38","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/38/labels","id":1761583,"number":38,"title":"v1.3.0","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":169,"state":"open","created_at":"2016-05-12T04:39:02Z","updated_at":"2016-12-13T01:48:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/5589/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/5589/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/5589/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/34af35528769caf7899a3951fae1b68efb3d1bcd","head":{"label":"mwcraig:fix-lazy-load-issues","ref":"fix-lazy-load-issues","sha":"34af35528769caf7899a3951fae1b68efb3d1bcd","user":{"login":"mwcraig","id":1147167,"avatar_url":"https://avatars.githubusercontent.com/u/1147167?v=3","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"repo":{"id":13460171,"name":"astropy","full_name":"mwcraig/astropy","owner":{"login":"mwcraig","id":1147167,"avatar_url":"https://avatars.githubusercontent.com/u/1147167?v=3","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwcraig/astropy","description":"Main AstroPy repository","fork":true,"url":"https://api.github.com/repos/mwcraig/astropy","forks_url":"https://api.github.com/repos/mwcraig/astropy/forks","keys_url":"https://api.github.com/repos/mwcraig/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwcraig/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwcraig/astropy/teams","hooks_url":"https://api.github.com/repos/mwcraig/astropy/hooks","issue_events_url":"https://api.github.com/repos/mwcraig/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/mwcraig/astropy/events","assignees_url":"https://api.github.com/repos/mwcraig/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/mwcraig/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/mwcraig/astropy/tags","blobs_url":"https://api.github.com/repos/mwcraig/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwcraig/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwcraig/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwcraig/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwcraig/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/mwcraig/astropy/languages","stargazers_url":"https://api.github.com/repos/mwcraig/astropy/stargazers","contributors_url":"https://api.github.com/repos/mwcraig/astropy/contributors","subscribers_url":"https://api.github.com/repos/mwcraig/astropy/subscribers","subscription_url":"https://api.github.com/repos/mwcraig/astropy/subscription","commits_url":"https://api.github.com/repos/mwcraig/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwcraig/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwcraig/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwcraig/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwcraig/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/mwcraig/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwcraig/astropy/merges","archive_url":"https://api.github.com/repos/mwcraig/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwcraig/astropy/downloads","issues_url":"https://api.github.com/repos/mwcraig/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/mwcraig/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/mwcraig/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/mwcraig/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwcraig/astropy/labels{/name}","releases_url":"https://api.github.com/repos/mwcraig/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/mwcraig/astropy/deployments","created_at":"2013-10-10T02:34:38Z","updated_at":"2014-08-15T21:01:16Z","pushed_at":"2016-12-13T00:10:03Z","git_url":"git://github.com/mwcraig/astropy.git","ssh_url":"git@github.com:mwcraig/astropy.git","clone_url":"https://github.com/mwcraig/astropy.git","svn_url":"https://github.com/mwcraig/astropy","homepage":"astropy.org","size":51491,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"a72fdfb6b07356805182cb3a2fc20487404b073f","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-12-12T09:20:30Z","pushed_at":"2016-12-13T01:48:52Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":72062,"stargazers_count":1076,"watchers_count":1076,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":620,"mirror_url":null,"open_issues_count":764,"forks":620,"open_issues":764,"watchers":1076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5589"},"html":{"href":"https://github.com/astropy/astropy/pull/5589"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/5589"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/5589/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5589/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5589/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/34af35528769caf7899a3951fae1b68efb3d1bcd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"comments":9,"review_comments":6,"commits":6,"additions":103,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"eteq"}}