{"action":"created","issue":{"url":"https://api.github.com/repos/inconshreveable/log15/issues/96","repository_url":"https://api.github.com/repos/inconshreveable/log15","labels_url":"https://api.github.com/repos/inconshreveable/log15/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/inconshreveable/log15/issues/96/comments","events_url":"https://api.github.com/repos/inconshreveable/log15/issues/96/events","html_url":"https://github.com/inconshreveable/log15/issues/96","id":164688170,"number":96,"title":"invalid formatting directive","user":{"login":"kevinburke","id":234019,"avatar_url":"https://avatars.githubusercontent.com/u/234019?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinburke","html_url":"https://github.com/kevinburke","followers_url":"https://api.github.com/users/kevinburke/followers","following_url":"https://api.github.com/users/kevinburke/following{/other_user}","gists_url":"https://api.github.com/users/kevinburke/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinburke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinburke/subscriptions","organizations_url":"https://api.github.com/users/kevinburke/orgs","repos_url":"https://api.github.com/users/kevinburke/repos","events_url":"https://api.github.com/users/kevinburke/events{/privacy}","received_events_url":"https://api.github.com/users/kevinburke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-09T22:14:22Z","updated_at":"2016-07-09T22:17:12Z","closed_at":null,"body":"`go vet ./...` warns:\r\n\r\n```\r\nhandler.go:109: unrecognized printf verb 'n'\r\n```\r\n\r\nThis is the line in question:\r\n\r\n```go\r\nr.Ctx = append(r.Ctx, \"fn\", fmt.Sprintf(\"%+n\", r.Call))\r\n```\r\n\r\nThis commit has been around since 2014 at least. The fmt docs don't mention `%n` or `%+n`: https://golang.org/pkg/fmt/\r\n\r\nI tried switching to `%+s`, `%+v`, `%#v`, but these all made the tests fail/changed the output, so I'm uncertain what rule Go is applying for that directive, or how to fix it."},"comment":{"url":"https://api.github.com/repos/inconshreveable/log15/issues/comments/231558879","html_url":"https://github.com/inconshreveable/log15/issues/96#issuecomment-231558879","issue_url":"https://api.github.com/repos/inconshreveable/log15/issues/96","id":231558879,"user":{"login":"ChrisHines","id":1060711,"avatar_url":"https://avatars.githubusercontent.com/u/1060711?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisHines","html_url":"https://github.com/ChrisHines","followers_url":"https://api.github.com/users/ChrisHines/followers","following_url":"https://api.github.com/users/ChrisHines/following{/other_user}","gists_url":"https://api.github.com/users/ChrisHines/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisHines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisHines/subscriptions","organizations_url":"https://api.github.com/users/ChrisHines/orgs","repos_url":"https://api.github.com/users/ChrisHines/repos","events_url":"https://api.github.com/users/ChrisHines/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisHines/received_events","type":"User","site_admin":false},"created_at":"2016-07-09T22:17:12Z","updated_at":"2016-07-09T22:17:12Z","body":"Also, go vet isn't perfect.\n\nOn Sat, Jul 9, 2016, 6:15 PM Chris Hines <chris@cs-guy.com> wrote:\n\n> Look at the docs for github.com/go-stack/stack.\n>\n> On Sat, Jul 9, 2016, 6:14 PM Kevin Burke <notifications@github.com> wrote:\n>\n>> go vet ./... warns:\n>>\n>> handler.go:109: unrecognized printf verb 'n'\n>>\n>> This is the line in question:\n>>\n>> r.Ctx = append(r.Ctx, \"fn\", fmt.Sprintf(\"%+n\", r.Call))\n>>\n>> This commit has been around since 2014 at least. The fmt docs don't\n>> mention %n or %+n: https://golang.org/pkg/fmt/\n>>\n>> I tried switching to %+s, %+v, %#v, but these all made the tests\n>> fail/changed the output, so I'm uncertain what rule Go is applying for that\n>> directive, or how to fix it.\n>>\n>> —\n>> You are receiving this because you are subscribed to this thread.\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/inconshreveable/log15/issues/96>, or mute the thread\n>> <https://github.com/notifications/unsubscribe/ABAvZ5m2w1DeqqfuEckIdfJy0d1lX49Dks5qUB0_gaJpZM4JItqk>\n>> .\n>>\n>\n"}}
{"actor":{"display_login":"ChrisHines"}}