{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11694","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11694/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11694/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11694/events","html_url":"https://github.com/cockroachdb/cockroach/pull/11694","id":192374522,"number":11694,"title":"sql: limit virtual tables to current database","user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars.githubusercontent.com/u/43821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-29T19:22:01Z","updated_at":"2016-12-02T16:46:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/11694","html_url":"https://github.com/cockroachdb/cockroach/pull/11694","diff_url":"https://github.com/cockroachdb/cockroach/pull/11694.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/11694.patch"},"body":"In postgres, the contents of tables in the `pg_catalog` and `information_schema` databases are limited to entries relating to the current database and system databases. This commit limits our implementation of these tables in the same way.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/11694)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/264501092","html_url":"https://github.com/cockroachdb/cockroach/pull/11694#issuecomment-264501092","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/11694","id":264501092,"user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars.githubusercontent.com/u/43821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T16:46:29Z","updated_at":"2016-12-02T16:46:29Z","body":"\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[pkg/sql/information_schema.go, line 540 at r2](https://reviewable.io:443/reviews/cockroachdb/cockroach/11694#-KXl_R51-iHj6okr-g6s:-KXzlXuQa3QH6NzYJbQW:b-69x836) ([raw file](https://github.com/cockroachdb/cockroach/blob/359a118492dcd1c4d72fd7740268b8a11d93abd4/pkg/sql/information_schema.go#L540)):*\n<details><summary><i>Previously, nvanbenschoten (Nathan VanBenschoten) wrote…</i></summary><blockquote>\n\nOk, do we assert this behavior in tests?\n</blockquote></details>\n\nGood point, done. This testing actually uncovered some issues with the patch. I moved this check into `forEachTableDescWithTableLookup` so that `pg_constraint` and `pg_depend` and some tables from `information_schema` also behave correctly. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/11694)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jordanlewis"}}