{"action":"created","issue":{"url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/276","repository_url":"https://api.github.com/repos/cjcliffe/CubicSDR","labels_url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/276/comments","events_url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/276/events","html_url":"https://github.com/cjcliffe/CubicSDR/issues/276","id":131175981,"number":276,"title":"Adding CubicSDR build to PothosSDR","user":{"login":"cjcliffe","id":247927,"avatar_url":"https://avatars.githubusercontent.com/u/247927?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcliffe","html_url":"https://github.com/cjcliffe","followers_url":"https://api.github.com/users/cjcliffe/followers","following_url":"https://api.github.com/users/cjcliffe/following{/other_user}","gists_url":"https://api.github.com/users/cjcliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcliffe/subscriptions","organizations_url":"https://api.github.com/users/cjcliffe/orgs","repos_url":"https://api.github.com/users/cjcliffe/repos","events_url":"https://api.github.com/users/cjcliffe/events{/privacy}","received_events_url":"https://api.github.com/users/cjcliffe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cjcliffe/CubicSDR/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"cjcliffe","id":247927,"avatar_url":"https://avatars.githubusercontent.com/u/247927?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcliffe","html_url":"https://github.com/cjcliffe","followers_url":"https://api.github.com/users/cjcliffe/followers","following_url":"https://api.github.com/users/cjcliffe/following{/other_user}","gists_url":"https://api.github.com/users/cjcliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcliffe/subscriptions","organizations_url":"https://api.github.com/users/cjcliffe/orgs","repos_url":"https://api.github.com/users/cjcliffe/repos","events_url":"https://api.github.com/users/cjcliffe/events{/privacy}","received_events_url":"https://api.github.com/users/cjcliffe/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cjcliffe/CubicSDR/milestones/7","html_url":"https://github.com/cjcliffe/CubicSDR/milestones/0.2.0","labels_url":"https://api.github.com/repos/cjcliffe/CubicSDR/milestones/7/labels","id":1247575,"number":7,"title":"0.2.0","description":"- Moving releases into minor revision; so this is the old \"0.1.5\"","creator":{"login":"cjcliffe","id":247927,"avatar_url":"https://avatars.githubusercontent.com/u/247927?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcliffe","html_url":"https://github.com/cjcliffe","followers_url":"https://api.github.com/users/cjcliffe/followers","following_url":"https://api.github.com/users/cjcliffe/following{/other_user}","gists_url":"https://api.github.com/users/cjcliffe/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcliffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcliffe/subscriptions","organizations_url":"https://api.github.com/users/cjcliffe/orgs","repos_url":"https://api.github.com/users/cjcliffe/repos","events_url":"https://api.github.com/users/cjcliffe/events{/privacy}","received_events_url":"https://api.github.com/users/cjcliffe/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":32,"state":"open","created_at":"2015-08-10T05:52:15Z","updated_at":"2016-02-13T16:05:47Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2016-02-03T22:36:13Z","updated_at":"2016-02-14T00:34:28Z","closed_at":null,"body":"Reference: https://github.com/pothosware/PothosSDR/wiki\r\n- Add any required files or build options for integrating with PothosSDR release builds"},"comment":{"url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/comments/183780714","html_url":"https://github.com/cjcliffe/CubicSDR/issues/276#issuecomment-183780714","issue_url":"https://api.github.com/repos/cjcliffe/CubicSDR/issues/276","id":183780714,"user":{"login":"guruofquality","id":184117,"avatar_url":"https://avatars.githubusercontent.com/u/184117?v=3","gravatar_id":"","url":"https://api.github.com/users/guruofquality","html_url":"https://github.com/guruofquality","followers_url":"https://api.github.com/users/guruofquality/followers","following_url":"https://api.github.com/users/guruofquality/following{/other_user}","gists_url":"https://api.github.com/users/guruofquality/gists{/gist_id}","starred_url":"https://api.github.com/users/guruofquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruofquality/subscriptions","organizations_url":"https://api.github.com/users/guruofquality/orgs","repos_url":"https://api.github.com/users/guruofquality/repos","events_url":"https://api.github.com/users/guruofquality/events{/privacy}","received_events_url":"https://api.github.com/users/guruofquality/received_events","type":"User","site_admin":false},"created_at":"2016-02-14T00:34:28Z","updated_at":"2016-02-14T00:34:28Z","body":"OK, that was it. The font resources needed to be installed.\r\n\r\nSo I replicated the install rules in the top level build like so:\r\n\r\n```\r\nExternalProject_Get_Property(CubicSDR SOURCE_DIR)\r\nExternalProject_Get_Property(CubicSDR BINARY_DIR)\r\nfile(GLOB CUBICSDR_RESOURCES \"${SOURCE_DIR}/font/*.*\")\r\ninstall(\r\n    FILES\r\n        ${SOURCE_DIR}/external/liquid-dsp/msvc/64/libliquid.dll\r\n        ${BINARY_DIR}/x64/${CMAKE_BUILD_TYPE}/CubicSDR.exe\r\n        ${CUBICSDR_RESOURCES}\r\n    DESTINATION bin\r\n)\r\n```\r\n\r\nSo thats a workaround, but my install target wishlist for CubicSDR would look like the following addition to the CubicSDR/CMakeLists.txt:\r\n\r\n```\r\nIF (WIN32 AND NOT BUILD_INSTALLER)\r\n\r\n    ADD_DEFINITIONS(\r\n\t    -DRES_FOLDER=\"../share/cubicsdr/\"\r\n\t)\t\r\n\r\n    INSTALL(TARGETS CubicSDR DESTINATION bin)\r\n        install(FILES \r\n            ${CUBICSDR_RESOURCES}\r\n            ${PROJECT_SOURCE_DIR}/src/CubicSDR.png\r\n    DESTINATION share/cubicsdr)\r\n```\r\n\r\nI'm not sure if the RES_FOLDER relative path would work, but the idea was to support a relocatable install and to also put the icons into the share directory (and not bin)."}}